[jdk21u-dev] RFR: 8330027: Identity hashes of archived objects must be based on a reproducible random seed

[Martin Doerr]

On Fri, 10 May 2024 14:58:37 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> This fixes an issue with CDS archive reproducibility that can happen under rare circumstances. See original JBS issue for details.
> 
> I had to manually resolve the hunk in src/hotspot/share/cds/heapShared.cpp because both
> 
>     8251330: Reorder CDS archived heap to speed up relocation
>     8329431: Improve speed of writing CDS heap objects
>     were missing.
> 
> I also had to change `CDSConfig::is_dumping_static_archive()` - which only exists in JDK 22 and later - to the technically equal `DumpSharedSpaces`.

LGTM. I suggest removing the empty line, too.

src/hotspot/share/cds/heapShared.cpp line 279:

> 277:     count_allocation(obj->size());
> 278:     ArchiveHeapWriter::add_source_obj(obj);
> 279: 

Original change removes the empty line here.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk21u-dev/pull/562#pullrequestreview-2053771991
PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/562#discussion_r1599052253