[jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v3]

[Severin Gehwolf]

On Tue, 21 May 2024 08:15:10 GMT, María Arias de Reyna <duke at openjdk.org> wrote:

>> The [8u backport](https://github.com/openjdk/jdk8u-dev/pull/502) makes a good point that `-Dcom.sun.security.ocsp.useget=false` is of no use here without [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638). I would thus remove those lines as in the 8u version.
>> 
>> Also, when comparing with 8u, I noticed that the 11u version only is missing a newline between the new `case` statements and the earlier ones:
>> 
>> 17u:
>> ~~~
>>                              "https://revoked.root-e1.certainly.com");
>> 
>> +            case "globalsignr46" ->
>> +                    new CATestURLs("https://valid.r46.roots.globalsign.com",
>> +                            "https://revoked.r46.roots.globalsign.com");
>> +            case "globalsigne46" ->
>> +                    new CATestURLs("https://valid.e46.roots.globalsign.com",
>> +                            "https://revoked.e46.roots.globalsign.com");
>> +
>>              default -> throw new RuntimeException("No test setup found for: " + alias);
>> ~~~
>> 
>> 11u:
>> ~~~
>>                              "https://revoked.root-e1.certainly.com");
>> +            case "globalsignr46":
>> +                    return new CATestURLs("https://valid.r46.roots.globalsign.com",
>> +                            "https://revoked.r46.roots.globalsign.com");
>> +            case "globalsigne46":
>> +                    return new CATestURLs("https://valid.e46.roots.globalsign.com",
>> +                            "https://revoked.e46.roots.globalsign.com");
>> 
>>              default: throw new RuntimeException("No test setup found for: " + alias);
>> ~~~
>> 
>> It would be good if all three backports matched.
>
> @gnu-andrew Changes pushed and the test run locally.

@Delawen Please ask for approval using the `/approval` command before you integrate.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#issuecomment-2122908985