[jdk17u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls

[fitzsim]

On Wed, 22 May 2024 23:21:21 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> I propose backporting the fix for `8286781` to `jdk17u`.
>> 
>> I tested the changes on `jdk17u-dev` `master`, on `Fedora 38` `x86-64`, `slowdebug` and `fastdebug` configurations.  The test was to run `IdealGraphVisualizer`, per `jdk17u-dev/src/utils/IdealGraphVisualizer/README.md`, then run, e.g.:
>> 
>> 
>> ./build/linux-x86_64-server-fastdebug/jdk/bin/java -XX:+PrintIdealGraph -XX:PrintIdealGraphLevel=1 -classpath ~/source/hello-java Hello
>> 
>> 
>> I needed extra JVM arguments in `jdk17u-dev/src/utils/IdealGraphVisualizer/application/target/idealgraphvisualizer/bin/idealgraphvisualizer` to make the visualizer utility work on 17:
>> 
>> 
>>             --jdkhome '"$jdkhome"' \
>>             -J--add-opens=java.base/java.net=ALL-UNNAMED \
>>             -J--add-opens=java.base/java.security=ALL-UNNAMED \
>>             -J--add-opens=java.base/java.lang=ALL-UNNAMED \
>>             -J--add-opens=java.desktop/sun.awt=ALL-UNNAMED \
>>             -J--add-opens=java.desktop/javax.swing.plaf.synth=ALL-UNNAMED \
>>             -J--add-opens=java.desktop/javax.swing=ALL-UNNAMED \
>>             -J--add-exports=java.desktop/com.sun.java.swing.plaf.gtk=ALL-UNNAMED \
>>             --clusters '"$clusters"' \
>> 
>> 
>> Networking between the test and the utility worked fine with the backport applied.
>
> I don't think it's reasonable to expect every patch submission to be tested on every possible platform. Those who want to produce builds on that platform and have the resources to do so should be regularly testing and maintaining it.  Full testing this patch on every platform would also mean running the visualiser on AIX and Solaris, which aren't even tested by GHA.  Where those platforms have been broken by changes in the past, those who build on them have submitted patches to fix them.
> 
> I see it as a bigger issue that the visualiser doesn't even work out of the box on 17 at present and no-one has moved to fix this so far.

Thank you, @gnu-andrew.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2487#issuecomment-2128118585