[jdk21u-dev] RFR: 8330027: Identity hashes of archived objects must be based on a reproducible random seed [v2]

Martin Doerr mdoerr at openjdk.org
Mon May 27 12:55:12 UTC 2024


On Tue, 14 May 2024 07:23:30 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> This fixes an issue with CDS archive reproducibility that can happen under rare circumstances. See original JBS issue for details.
>> 
>> I had to manually resolve the hunk in src/hotspot/share/cds/heapShared.cpp because both
>> 
>>     8251330: Reorder CDS archived heap to speed up relocation
>>     8329431: Improve speed of writing CDS heap objects
>>     were missing.
>> 
>> I also had to change `CDSConfig::is_dumping_static_archive()` - which only exists in JDK 22 and later - to the technically equal `DumpSharedSpaces`.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update heapShared.cpp

Marked as reviewed by mdoerr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk21u-dev/pull/562#pullrequestreview-2080861053


More information about the jdk-updates-dev mailing list