[jdk17u-dev] RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline [v2]

[Aleksey Shipilev]

On Mon, 27 May 2024 13:59:25 GMT, Rinku Kumar Maurya <duke at openjdk.org> wrote:

>> clean backport to fix file descriptor leak with ProcessBuilder.startPipeline. When using ProcessBuilder.startPipeline the pipes (or pipe if only 2 ProcessBuilder instance used) created are never closed.
>> 
>> 
>> with changes :-
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>    jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java
>>                                                          1     1     0     0   
>> ==============================
>> TEST SUCCESS
>> 
>> 
>> without changes :-
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>    jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java
>>                                                          1     0     1     0 
>> ==============================
>> TEST FAILURE
>> 
>> with expected output :-
>> test PipelineLeaksFD.checkForLeaks(java.util.ImmutableCollections$ListN at 44d1a216): failure
>> java.lang.AssertionError: More or fewer pipes than expected
>> ...
>
> Rinku Kumar Maurya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Backport 226b8e680a82096b3d268703872d30182c10e326

...and now also `/approval 8290885 request <the fix request text goes here>` for approval for that one.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2462#issuecomment-2133679996