[jdk17u-dev] RFR: 8314835: gtest wrappers should be marked as flagless

[SendaoYan]

On Tue, 28 May 2024 07:41:27 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Hi, about this and similar "flagless" backports. Why is this backported, and how does it affect test execution? What does flagless do, exactly?

If the testcase mark as `@requires vm.flagless`, then this testcase will not been selected by jtreg when gived jvm non-default jvm options. That means this testcase not suitable for run with non-default jvm options.

Take `gtest/AsyncLogGtest.java` as an example:
Do jtreg list with default jvm options:

> jtreg -l test/hotspot/jtreg/gtest/AsyncLogGtest.java
Testsuite: /home/yansendao/git/jdk/test/hotspot/jtreg
gtest/AsyncLogGtest.java
Tests found: 1


Do jtreg list with jvm options -Xcomp, it says not tests found:

> jtreg -l -Xcomp test/hotspot/jtreg/gtest/AsyncLogGtest.java
Testsuite: /home/yansendao/git/jdk/test/hotspot/jtreg
Tests found: 0


The testcases which mark as `@requires vm.flagless` not suitable for run with non-default jvm options, that means these testcases will only run with default jvm options. These testcases will run failed when it's not mark as `@requires vm.flagless` when run with some non-default jvm options. The "flagless" backport make these testcases more robustness.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2470#issuecomment-2134586655