From duke at openjdk.org Fri Nov 1 04:36:42 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Fri, 1 Nov 2024 04:36:42 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v2] In-Reply-To: <bX_isycwgNMnBwm2FpfH7Y1YfHCd_uWGOt8cKb5rSlE=.380e649c-a8d8-4a7e-95e8-140804e89c5c@github.com> References: <Nm9nt3ihKhACiDQgVwXSrcEDnd-HkyBTBJPU_cv2DDs=.714d8254-9859-4393-b0b2-1c6cb67d4379@github.com> <bX_isycwgNMnBwm2FpfH7Y1YfHCd_uWGOt8cKb5rSlE=.380e649c-a8d8-4a7e-95e8-140804e89c5c@github.com> Message-ID: <nnYAwjVzHZ5iEQuRpHX8EcRrOHVmgUFs9s5K2VcigGk=.3277f534-f7a2-474a-b167-0733acfb8729@github.com> On Thu, 17 Oct 2024 10:55:17 GMT, Taizo Kurashige <duke at openjdk.org> wrote: >> Hi, >> >> This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts >> >> Original patch does not apply cleanly for the following reasons: >> >> ?Fix to getOsMap() in test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied since getOsMap() was removed in https://bugs.openjdk.org/browse/JDK-8331700. >> ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in [https://bugs.openjdk.org/browse/JDK-8220753](https://bugs.openjdk.org/browse/JDK-8220753%28jdk13%29) (jdk13). >> ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed in https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. >> >> Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing >> >> Thanks. > > Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-8296631 > - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 > - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 Could anyone review this backport please? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2955#issuecomment-2451277394 From dcherepanov at openjdk.org Fri Nov 1 07:51:37 2024 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Fri, 1 Nov 2024 07:51:37 GMT Subject: [jdk11u-dev] RFR: 8301118: Ignore allow and disallow options for java.security.manager System Property In-Reply-To: <qeVqpJvHZH6t3mrXv5FYbzgErhRdTyTF7w3AF2sy5pY=.afe2c97e-9602-431e-8b19-88f113a1a6d1@github.com> References: <qeVqpJvHZH6t3mrXv5FYbzgErhRdTyTF7w3AF2sy5pY=.afe2c97e-9602-431e-8b19-88f113a1a6d1@github.com> Message-ID: <6Q3MV-qghWGVpm7G4VwSvawYvUj7jO18EEQ2ZKd_Wwk=.176222ca-971f-487f-a581-67b384896722@github.com> On Fri, 6 Sep 2024 11:13:21 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote: > Proposing the change for parity with Oracle (fixed in 11.0.21-oracle). > > The change isn't a backport and it's implemented according to the description of https://bugs.openjdk.org/browse/JDK-8301118. New allow/disallow options for the java.security.manager system property should be ignored in JDK11. > > New test fails without the change and passes with the change. Kindly reminder ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2932#issuecomment-2451453342 From goetz at openjdk.org Fri Nov 1 08:56:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 1 Nov 2024 08:56:36 GMT Subject: [jdk21u-dev] RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic In-Reply-To: <jX1MjWrB66u613MKWwFjPm5Tcn5y_QXjqk155frBv7c=.9891643f-f860-49b1-bf4a-bf5f9b617a5b@github.com> References: <jX1MjWrB66u613MKWwFjPm5Tcn5y_QXjqk155frBv7c=.9891643f-f860-49b1-bf4a-bf5f9b617a5b@github.com> Message-ID: <g03nh_3JoTbQ1pkEzCZW425IGDkoNX5Bda5FPF3FuOE=.44724b0d-48fc-4835-8f94-d70a19d95b72@github.com> On Wed, 30 Oct 2024 22:15:51 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote: > Hi all, > > backport https://bugs.openjdk.org/browse/JDK-8295159 to fix broken Java floating-point arithmetic. > > Minor merge conflicts in os_linux.cpp and os_bsd.cpp have been resolved manually. The conflict is with the NativeLibraryLoadEvent tracing applied on the mainline around the dlopen() call: https://github.com/openjdk/jdk/pull/16903 > > The fix passed tier1-3 jtreg tests. > > Thank you Hi @bulasevich , do we need any of the 6 related issues listed in the JBS issue? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1111#issuecomment-2451537521 From duke at openjdk.org Fri Nov 1 09:28:33 2024 From: duke at openjdk.org (duke) Date: Fri, 1 Nov 2024 09:28:33 GMT Subject: [jdk17u-dev] RFR: 8337851: Some tests have name which confuse jtreg In-Reply-To: <n9RBpkKvl1KtuLzkhPs620E6NmM1C2QouuyRUc_EhP4=.919fbea7-3f88-4d8b-9160-71a6aa46b539@github.com> References: <n9RBpkKvl1KtuLzkhPs620E6NmM1C2QouuyRUc_EhP4=.919fbea7-3f88-4d8b-9160-71a6aa46b539@github.com> Message-ID: <ClhaEPrivsSAkcaD1FlknjgRtnCjC_7onyH8d6XWJOc=.530e3cb2-0372-400c-869f-14dea1052ca5@github.com> On Thu, 31 Oct 2024 04:27:35 GMT, toshiogata <duke at openjdk.org> wrote: > Hi all, > > I would like to backport this patch because the reported jtreg issue is reproducible in JDK17. > The original patch applies cleanly. > > Although the test/langtools/tools/javac/warnings/Serial directory were introduced in JDK 18 and the associated jtreg issues for that directory is not present in JDK 17, Serial.java and Serial.out have been renamed to minimize differences. > > Testing: the related tests with "-retain:all" option, and all tests under tools/javac > > Thank you @toshiogata Your change (at version b82391b17894e0dffa43fb533d39f693501cb5c3) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3018#issuecomment-2451579688 From fyang at openjdk.org Fri Nov 1 09:34:34 2024 From: fyang at openjdk.org (Fei Yang) Date: Fri, 1 Nov 2024 09:34:34 GMT Subject: [jdk21u-dev] Integrated: 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing In-Reply-To: <j-TiovMsoQK1JitbLmZjJFz0EoDT-mxV9gxPIdnnYq8=.49ca77b5-9c34-4e12-8f43-e96dbb33b4cf@github.com> References: <j-TiovMsoQK1JitbLmZjJFz0EoDT-mxV9gxPIdnnYq8=.49ca77b5-9c34-4e12-8f43-e96dbb33b4cf@github.com> Message-ID: <R5iGCJEWxvJ0AmOPuo7918H2hFC6fNjh-zBRgWUbKoU=.878347d7-a924-4452-aff8-9cf624db352d@github.com> On Thu, 31 Oct 2024 03:11:18 GMT, Fei Yang <fyang at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [239d84a8](https://github.com/openjdk/jdk/commit/239d84a82a1e6f4ebbd5c5abb320e39cfd5bc330) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fei Yang on 21 Oct 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson. > > Thanks! This pull request has now been integrated. Changeset: ed797f7d Author: Fei Yang <fyang at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/ed797f7d6b0eff31168e54dd07eb5dd22dd898f1 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing Backport-of: 239d84a82a1e6f4ebbd5c5abb320e39cfd5bc330 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1112 From fyang at openjdk.org Fri Nov 1 09:35:34 2024 From: fyang at openjdk.org (Fei Yang) Date: Fri, 1 Nov 2024 09:35:34 GMT Subject: [jdk17u-dev] Integrated: 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing In-Reply-To: <1ks7D5i6TQWxSbiH8WTAbm4ErMPqOv_mcC0q7a6cQ7E=.4f53b300-1dfd-4fe0-8d3c-f3530f33279a@github.com> References: <1ks7D5i6TQWxSbiH8WTAbm4ErMPqOv_mcC0q7a6cQ7E=.4f53b300-1dfd-4fe0-8d3c-f3530f33279a@github.com> Message-ID: <XsL8bETQcZWeaYghvNrX0AFhfdCWkUVflaQAWhuZcsY=.71d295c3-9c6e-4b70-9527-15c4ca2fc52e@github.com> On Thu, 31 Oct 2024 03:11:45 GMT, Fei Yang <fyang at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [239d84a8](https://github.com/openjdk/jdk/commit/239d84a82a1e6f4ebbd5c5abb320e39cfd5bc330) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fei Yang on 21 Oct 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson. > > Thanks! This pull request has now been integrated. Changeset: 2a9bd220 Author: Fei Yang <fyang at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/2a9bd220811a2aadab57eff870a16ff0485fefb1 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing Backport-of: 239d84a82a1e6f4ebbd5c5abb320e39cfd5bc330 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3017 From duke at openjdk.org Fri Nov 1 10:29:35 2024 From: duke at openjdk.org (duke) Date: Fri, 1 Nov 2024 10:29:35 GMT Subject: [jdk17u-dev] RFR: 8338751: ConfigureNotify behavior has changed in KWin 6.2 In-Reply-To: <HI7MTzk9XLHJKZOCKc7LErPLoSukfJc0VLRQZPpTrkA=.15fab3ba-8b68-46f7-824c-d3ccd4cb3180@github.com> References: <HI7MTzk9XLHJKZOCKc7LErPLoSukfJc0VLRQZPpTrkA=.15fab3ba-8b68-46f7-824c-d3ccd4cb3180@github.com> Message-ID: <v_lIyTVEmEoXPw5aeED_ndru6piaF9iUMTT4pN2BKX0=.317dcd31-1777-4b96-bf07-966edc4299d3@github.com> On Mon, 21 Oct 2024 20:17:11 GMT, Vlad Zahorodnii <duke at openjdk.org> wrote: > Reviewed-by: prr, azvegint, serb @zzag Your change (at version 5ec0fb29e9ecd69193fd8ef26b84d698018d62af) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2981#issuecomment-2451654960 From goetz at openjdk.org Fri Nov 1 10:36:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 1 Nov 2024 10:36:06 GMT Subject: [jdk17u-dev] RFR: 8339931: Update problem list for WindowUpdateFocusabilityTest.java Message-ID: <f4ymHLVZE8bS2lDCHN6yZ1XsYeoHuW3hsfTxN4ha0kc=.c297eaa2-41d7-4647-afc1-5be66d80d610@github.com> I backport this for parity with 17.0.14-oracle. No commit available, but obvious to "implement". Also adding 8202926, as this includes the backport of that change. ------------- Commit messages: - Backport 8339931 Changes: https://git.openjdk.org/jdk17u-dev/pull/3022/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3022&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339931 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3022.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3022/head:pull/3022 PR: https://git.openjdk.org/jdk17u-dev/pull/3022 From goetz at openjdk.org Fri Nov 1 10:40:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 1 Nov 2024 10:40:13 GMT Subject: [jdk17u-dev] RFR: 8332340: Add JavacBench as a test case for CDS Message-ID: <5T0YFoXnahrEDB1HBNFyVlk9L0wEZOvb9LFMETkT06Q=.6f2fc87e-6aa2-463e-9ca4-1dd5f01339d2@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 7fd9d6c760c66d3e2f4034cf1a6b1b583ff829a9 Changes: https://git.openjdk.org/jdk17u-dev/pull/3023/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3023&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332340 Stats: 607 lines in 4 files changed: 607 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3023.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3023/head:pull/3023 PR: https://git.openjdk.org/jdk17u-dev/pull/3023 From srl at openjdk.org Fri Nov 1 12:35:29 2024 From: srl at openjdk.org (Steven Loomis) Date: Fri, 1 Nov 2024 12:35:29 GMT Subject: [jdk17u-dev] Integrated: 8195675: Call to insertText with single character from custom Input Method ignored In-Reply-To: <RcnnloKer9ASwFVkTv9Rl5L5UcgUJ40jSQjDahC1CFY=.3f69ccde-d17e-4421-b993-e77900bac0f4@github.com> References: <RcnnloKer9ASwFVkTv9Rl5L5UcgUJ40jSQjDahC1CFY=.3f69ccde-d17e-4421-b993-e77900bac0f4@github.com> Message-ID: <LkOSHBsv8F15bJfBOSJpiyH5tHIPnGtrTY6RudlZusI=.7eb12dae-fdb8-440f-81b9-10872ed61ffa@github.com> On Thu, 17 Oct 2024 13:17:40 GMT, Steven Loomis <srl at openjdk.org> wrote: > 8195675: Call to insertText with single character from custom Input Method ignored This pull request has now been integrated. Changeset: 9ae66afc Author: Steven Loomis <srl at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/9ae66afc465160bba75b389514f2a1eaec89993c Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod 8195675: Call to insertText with single character from custom Input Method ignored Backport-of: b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2971 From duke at openjdk.org Fri Nov 1 15:16:37 2024 From: duke at openjdk.org (duke) Date: Fri, 1 Nov 2024 15:16:37 GMT Subject: [jdk21u-dev] RFR: 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException In-Reply-To: <On0r1XKBaeNsett3e6Ya0kSfMUdoZVfBrDq-RNZUDU0=.5e9951d0-c4de-47d3-864f-8a10ac855172@github.com> References: <On0r1XKBaeNsett3e6Ya0kSfMUdoZVfBrDq-RNZUDU0=.5e9951d0-c4de-47d3-864f-8a10ac855172@github.com> Message-ID: <YH6lQOQg65INRwN55E4aM0sTd7qQaodmPmtrZ7_jbrA=.00bc119d-d01c-47c3-afbf-6e89632531f6@github.com> On Mon, 28 Oct 2024 23:07:52 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [fe0ccdf5](https://github.com/openjdk/jdk/commit/fe0ccdf5f8a5559a608d2e2cd2b6aecbe245c5ec) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Naoto Sato on 13 Nov 2023 and was reviewed by Roger Riggs, Iris Clark, Justin Lu and Joe Wang. > > Thanks! @pengxiaolong Your change (at version 32a65ef2408584d079d5fc2b9aa9424e0d91e021) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1101#issuecomment-2452046219 From xpeng at openjdk.org Fri Nov 1 15:16:37 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Fri, 1 Nov 2024 15:16:37 GMT Subject: [jdk21u-dev] RFR: 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException In-Reply-To: <On0r1XKBaeNsett3e6Ya0kSfMUdoZVfBrDq-RNZUDU0=.5e9951d0-c4de-47d3-864f-8a10ac855172@github.com> References: <On0r1XKBaeNsett3e6Ya0kSfMUdoZVfBrDq-RNZUDU0=.5e9951d0-c4de-47d3-864f-8a10ac855172@github.com> Message-ID: <j1UOeky64KbaxcgKrdXfsXi44KS3LMAo7mSU0j0au4Q=.bf6b9b26-00c9-4a8f-9d72-cb26477341e2@github.com> On Mon, 28 Oct 2024 23:07:52 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [fe0ccdf5](https://github.com/openjdk/jdk/commit/fe0ccdf5f8a5559a608d2e2cd2b6aecbe245c5ec) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Naoto Sato on 13 Nov 2023 and was reviewed by Roger Riggs, Iris Clark, Justin Lu and Joe Wang. > > Thanks! Thank you for the review and approval! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1101#issuecomment-2452045765 From xpeng at openjdk.org Fri Nov 1 21:58:37 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Fri, 1 Nov 2024 21:58:37 GMT Subject: [jdk21u-dev] Integrated: 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException In-Reply-To: <On0r1XKBaeNsett3e6Ya0kSfMUdoZVfBrDq-RNZUDU0=.5e9951d0-c4de-47d3-864f-8a10ac855172@github.com> References: <On0r1XKBaeNsett3e6Ya0kSfMUdoZVfBrDq-RNZUDU0=.5e9951d0-c4de-47d3-864f-8a10ac855172@github.com> Message-ID: <5D3wFYRtvDn13OzrmZ_NQvxLoOsScb_-nQWMr219t3Y=.b9069bdb-f911-4236-aaea-ed48f2084abf@github.com> On Mon, 28 Oct 2024 23:07:52 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [fe0ccdf5](https://github.com/openjdk/jdk/commit/fe0ccdf5f8a5559a608d2e2cd2b6aecbe245c5ec) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Naoto Sato on 13 Nov 2023 and was reviewed by Roger Riggs, Iris Clark, Justin Lu and Joe Wang. > > Thanks! This pull request has now been integrated. Changeset: eb8d5fe5 Author: Xiaolong Peng <xpeng at openjdk.org> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/eb8d5fe5b9a79725c7a2409e15c36739cd9dca56 Stats: 50 lines in 2 files changed: 34 ins; 8 del; 8 mod 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException Backport-of: fe0ccdf5f8a5559a608d2e2cd2b6aecbe245c5ec ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1101 From syan at openjdk.org Sat Nov 2 12:12:34 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 2 Nov 2024 12:12:34 GMT Subject: [jdk17u-dev] RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds In-Reply-To: <MoQsf9p2xZfHaO2qKB3GTLaZoowu3DY9SWFC6ILD_Do=.8d127f9e-7d95-46c1-ac89-dfb08c82f308@github.com> References: <MoQsf9p2xZfHaO2qKB3GTLaZoowu3DY9SWFC6ILD_Do=.8d127f9e-7d95-46c1-ac89-dfb08c82f308@github.com> Message-ID: <8HFoEkkZe1te08mFHKGD1LEbMBtB9VqgmB-hWXc8QCw=.a39e54b9-e18b-412d-beb5-940e37e3351b@github.com> On Wed, 30 Oct 2024 07:27:00 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [571c435e](https://github.com/openjdk/jdk/commit/571c435e1a34dcf08fd7545d531c258c9116ea79) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jan Kratochvil on 23 Aug 2023 and was reviewed by Erik Joelsson. > > Without this PR, the jdk build with --enable-ccache can't generate comments in -XX:+PrintInterpreter, this PR fix the build issue. So I want to backport this PR to jdk17u-dev from jdk22. > > Thanks! Thanks for the approval. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3015#issuecomment-2452970139 From duke at openjdk.org Sat Nov 2 12:12:34 2024 From: duke at openjdk.org (duke) Date: Sat, 2 Nov 2024 12:12:34 GMT Subject: [jdk17u-dev] RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds In-Reply-To: <MoQsf9p2xZfHaO2qKB3GTLaZoowu3DY9SWFC6ILD_Do=.8d127f9e-7d95-46c1-ac89-dfb08c82f308@github.com> References: <MoQsf9p2xZfHaO2qKB3GTLaZoowu3DY9SWFC6ILD_Do=.8d127f9e-7d95-46c1-ac89-dfb08c82f308@github.com> Message-ID: <IMaBIOUrM9UcQcs363YJAF-lGPc1FMCfrd8nryCaMYw=.beed5510-6873-4747-86a6-80ecb5e969a5@github.com> On Wed, 30 Oct 2024 07:27:00 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [571c435e](https://github.com/openjdk/jdk/commit/571c435e1a34dcf08fd7545d531c258c9116ea79) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jan Kratochvil on 23 Aug 2023 and was reviewed by Erik Joelsson. > > Without this PR, the jdk build with --enable-ccache can't generate comments in -XX:+PrintInterpreter, this PR fix the build issue. So I want to backport this PR to jdk17u-dev from jdk22. > > Thanks! @sendaoYan Your change (at version c8685519a8834a652f2b420835f3e0efc90d369f) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3015#issuecomment-2452970324 From goetz at openjdk.org Sat Nov 2 12:30:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 2 Nov 2024 12:30:14 GMT Subject: [jdk21u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project. Message-ID: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> Customize the README.md to jdk21u. Plan is to backport this to 17 and maybe older jdks and adapt the paths etc correspondingly. Should we put there more information? ------------- Commit messages: - 8343474: [updates] Customize README.md to specifics of update project Changes: https://git.openjdk.org/jdk21u-dev/pull/1118/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1118&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343474 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1118.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1118/head:pull/1118 PR: https://git.openjdk.org/jdk21u-dev/pull/1118 From lucy at openjdk.org Sat Nov 2 16:57:32 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Sat, 2 Nov 2024 16:57:32 GMT Subject: [jdk17u-dev] RFR: 8339931: Update problem list for WindowUpdateFocusabilityTest.java In-Reply-To: <f4ymHLVZE8bS2lDCHN6yZ1XsYeoHuW3hsfTxN4ha0kc=.c297eaa2-41d7-4647-afc1-5be66d80d610@github.com> References: <f4ymHLVZE8bS2lDCHN6yZ1XsYeoHuW3hsfTxN4ha0kc=.c297eaa2-41d7-4647-afc1-5be66d80d610@github.com> Message-ID: <clnKATS6HBiqrZspr8KVqM6NQoYMnwy6QThMIiOBibU=.024a4cff-3306-411e-84a2-df8f9115634d@github.com> On Fri, 1 Nov 2024 10:31:18 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > No commit available, but obvious to "implement". > Also adding 8202926, as this includes the backport of that change. LGTM ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3022#pullrequestreview-2411334865 From aph-open at littlepinkcloud.com Sun Nov 3 17:39:59 2024 From: aph-open at littlepinkcloud.com (Andrew Haley) Date: Sun, 3 Nov 2024 17:39:59 +0000 Subject: New JDK 11u maintainer: Andrew Hughes Message-ID: <6dfaae85-c4e5-4f7f-bd62-5b4e6cbd4f4f@littlepinkcloud.com> Following the news that SAP will terminate efforts in jdk11u after the October release, we need a new maintainer. I'm pleased to announce that the very experienced Andrew Hughes will step into this role, and will continue his job as jdk8u maintainer. SAP have done a tremendous amount of work on JDK 11u over the years, and I'm sure the entire JDK Updates community will join me in thanking them for that. Thank you for your care and diligence stewarding OpenJDK. The SAP announcement is at https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-May/032760.html -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From goetz at openjdk.org Mon Nov 4 07:57:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 07:57:40 GMT Subject: [jdk21u-dev] Integrated: 8333754: Add a Test against ECDSA and ECDH NIST Test vector In-Reply-To: <9tF1rWgeS4ZOV6IWKklNuSEetWJO_-S6AY57kC-raxs=.d828967f-4302-4729-9db3-48a5a8806a81@github.com> References: <9tF1rWgeS4ZOV6IWKklNuSEetWJO_-S6AY57kC-raxs=.d828967f-4302-4729-9db3-48a5a8806a81@github.com> Message-ID: <LxPM_AYlLJvuZM6HocCltseZXq9bwAlvHU3SCfv6Ggg=.233151e3-3530-4b8e-acbe-5cbc1fcc4cdb@github.com> On Wed, 30 Oct 2024 14:10:13 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > Applies clean, but test ECDSAPrimitive does not compile. The second commit contains the fixes for this. > In head, ECOperations.setSum takes a MutablePoint as second argument, > so it is built from the available AffinePoint. > In 21, ECOperations.setSum() takes an AffinePoint, so I just pass the available one. > > Tests pass. This pull request has now been integrated. Changeset: 93dc5915 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/93dc591573138fed070b226254c2f27b0f9856fc Stats: 9497 lines in 4 files changed: 9497 ins; 0 del; 0 mod 8333754: Add a Test against ECDSA and ECDH NIST Test vector Reviewed-by: mbaesken Backport-of: fad6644eabbad6b6d3472206d9db946408aca612 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1108 From goetz at openjdk.org Mon Nov 4 07:59:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 07:59:36 GMT Subject: [jdk21u-dev] Integrated: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts In-Reply-To: <POVI2WyE_s82xXzT5NVrRe0kYahQpw0p16YuNGNaHdc=.84141d77-3cc9-40c7-a635-b1054ad95467@github.com> References: <POVI2WyE_s82xXzT5NVrRe0kYahQpw0p16YuNGNaHdc=.84141d77-3cc9-40c7-a635-b1054ad95467@github.com> Message-ID: <YZHNVAqx3ndSteq1OtSTbMJCLCD6Fh1shjZKg47rjnM=.fdc9dca0-9b02-403c-b00d-b77316704332@github.com> On Wed, 30 Oct 2024 15:33:06 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 3d20298d Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/3d20298dd8f370fa8372b6566694085b4c743634 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts Backport-of: 8feabc849ba2f617c8c6dbb2ec5074297beb6437 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1110 From goetz at openjdk.org Mon Nov 4 08:02:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 08:02:33 GMT Subject: [jdk17u-dev] Integrated: 8339931: Update problem list for WindowUpdateFocusabilityTest.java In-Reply-To: <f4ymHLVZE8bS2lDCHN6yZ1XsYeoHuW3hsfTxN4ha0kc=.c297eaa2-41d7-4647-afc1-5be66d80d610@github.com> References: <f4ymHLVZE8bS2lDCHN6yZ1XsYeoHuW3hsfTxN4ha0kc=.c297eaa2-41d7-4647-afc1-5be66d80d610@github.com> Message-ID: <N06xPZUY658RmgyIzNyToqgqCXfXZu2SaFq5rwEoEsw=.14ec6690-3a84-4cb7-9e38-e2b361e3e90d@github.com> On Fri, 1 Nov 2024 10:31:18 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > No commit available, but obvious to "implement". > Also adding 8202926, as this includes the backport of that change. This pull request has now been integrated. Changeset: 5fada956 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/5fada9567731c4538c7d3744fd655ea97420147e Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8339931: Update problem list for WindowUpdateFocusabilityTest.java 8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails Reviewed-by: lucy ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3022 From goetz at openjdk.org Mon Nov 4 08:02:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 08:02:41 GMT Subject: [jdk21u-dev] Integrated: 8317116: Provide layouts for multiple test UI in PassFailJFrame In-Reply-To: <Ef1B23GZ076N4E4PGP76l8FdwPQM-YIEtD6LnFJipYg=.96a18f06-6451-4194-aa75-1045b8acbf1b@github.com> References: <Ef1B23GZ076N4E4PGP76l8FdwPQM-YIEtD6LnFJipYg=.96a18f06-6451-4194-aa75-1045b8acbf1b@github.com> Message-ID: <4BCrz5f_UfLhwOn70b5cOJd-o6i-cgZAzwSZGXjuTGs=.232061b8-c35b-4187-a03c-3b7858c5c2de@github.com> On Thu, 31 Oct 2024 19:31:08 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 72eaaa25 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/72eaaa25270721138b2e04aad3814943d2fc4d5a Stats: 319 lines in 2 files changed: 315 ins; 0 del; 4 mod 8317116: Provide layouts for multiple test UI in PassFailJFrame Backport-of: 85f0442727201e0d36ed0a71d2199e602501c98d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1114 From goetz at openjdk.org Mon Nov 4 08:03:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 08:03:34 GMT Subject: [jdk21u-dev] Integrated: 8340785: Update description of PassFailJFrame and samples In-Reply-To: <Y_stWtg4Hg-4be5SjpwOsU91mExOgULH6Hb95oQPbJY=.42054926-7bec-464c-b10a-47ed0c930f50@github.com> References: <Y_stWtg4Hg-4be5SjpwOsU91mExOgULH6Hb95oQPbJY=.42054926-7bec-464c-b10a-47ed0c930f50@github.com> Message-ID: <Ur7lKr3r6Yy8_nldO2TPCK2-fGb3sbnGA2abcQ7gtjQ=.57c94ac5-de7b-4e23-a42a-eb30fc715c07@github.com> On Thu, 31 Oct 2024 19:34:14 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: ae467248 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/ae4672482ccf02ee5f45f5eee107c72e7506461f Stats: 159 lines in 1 file changed: 126 ins; 0 del; 33 mod 8340785: Update description of PassFailJFrame and samples Backport-of: 5063494f5b0859a396b4e41096793c777d4650b8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1115 From goetz at openjdk.org Mon Nov 4 08:04:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 08:04:43 GMT Subject: [jdk17u-dev] Integrated: 8332340: Add JavacBench as a test case for CDS In-Reply-To: <5T0YFoXnahrEDB1HBNFyVlk9L0wEZOvb9LFMETkT06Q=.6f2fc87e-6aa2-463e-9ca4-1dd5f01339d2@github.com> References: <5T0YFoXnahrEDB1HBNFyVlk9L0wEZOvb9LFMETkT06Q=.6f2fc87e-6aa2-463e-9ca4-1dd5f01339d2@github.com> Message-ID: <jIE1JMd11chWPwDixlvm1SoPokJGz2CAwpaNkQUteYQ=.ea216288-03a0-4325-b132-6e6f0323730c@github.com> On Fri, 1 Nov 2024 10:35:12 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: ead94467 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/ead94467e8b26c2160902f9661f03deb34fcad9f Stats: 607 lines in 4 files changed: 607 ins; 0 del; 0 mod 8332340: Add JavacBench as a test case for CDS Backport-of: 7fd9d6c760c66d3e2f4034cf1a6b1b583ff829a9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3023 From goetz at openjdk.org Mon Nov 4 08:04:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 08:04:43 GMT Subject: [jdk21u-dev] Integrated: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result In-Reply-To: <AiTnZZBfUiZhyTXQVoNzAMlIhc0_3t9LPA1cYiX1rRk=.386e9748-70cc-4666-8f66-94c42dfe58d6@github.com> References: <AiTnZZBfUiZhyTXQVoNzAMlIhc0_3t9LPA1cYiX1rRk=.386e9748-70cc-4666-8f66-94c42dfe58d6@github.com> Message-ID: <FHV8taaxR9Jv0549Js62Gu7zRMf-VLpyyu4Rcf8o048=.cf81c28a-fc1c-4bbd-9d1b-81919b5e91c7@github.com> On Thu, 31 Oct 2024 19:56:16 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: b08fa9a4 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/b08fa9a47fc0fa8ced083072c48423e2a6914465 Stats: 58 lines in 2 files changed: 58 ins; 0 del; 0 mod 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result Backport-of: cd61f97c2de94d19c0101c51bde143001078c89f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1116 From goetz at openjdk.org Mon Nov 4 08:05:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 08:05:40 GMT Subject: [jdk17u-dev] Integrated: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts In-Reply-To: <HbsgGDx_pf26IujhjYMcNHg42l-FaF5QTp5cCO2fGbg=.10119559-31e4-4e3c-87a1-10f02465373c@github.com> References: <HbsgGDx_pf26IujhjYMcNHg42l-FaF5QTp5cCO2fGbg=.10119559-31e4-4e3c-87a1-10f02465373c@github.com> Message-ID: <AFe-roQh0gjKafPO7sb6S3ckkob0P9F7i8tgz4sAD7A=.9bea7ada-ae52-48bf-afe8-05f61780af32@github.com> On Wed, 30 Oct 2024 15:33:26 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle This pull request has now been integrated. Changeset: 4c89a63a Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/4c89a63a812b98dad33c6838360b813e0869a0c1 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts Backport-of: 8feabc849ba2f617c8c6dbb2ec5074297beb6437 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3016 From goetz at openjdk.org Mon Nov 4 08:06:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 08:06:38 GMT Subject: [jdk17u-dev] Integrated: 8317116: Provide layouts for multiple test UI in PassFailJFrame In-Reply-To: <mkFdhevKqsbBDVwM_IDsNVWXkYrzOKmgSlR0hNVlT40=.ba8a34f7-55d2-4670-b44a-c3f987d46beb@github.com> References: <mkFdhevKqsbBDVwM_IDsNVWXkYrzOKmgSlR0hNVlT40=.ba8a34f7-55d2-4670-b44a-c3f987d46beb@github.com> Message-ID: <Z9Xotfh4w-7BQoMrzmAq7Qe406ThLnINrO7djqZoFeQ=.dbdc48db-eb4a-40d4-b98c-336c1370dc5d@github.com> On Thu, 31 Oct 2024 19:33:43 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle This pull request has now been integrated. Changeset: fadfa582 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/fadfa5824d15e532c2c6f18ec37e9685952f8290 Stats: 319 lines in 2 files changed: 315 ins; 0 del; 4 mod 8317116: Provide layouts for multiple test UI in PassFailJFrame Backport-of: 85f0442727201e0d36ed0a71d2199e602501c98d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3019 From goetz at openjdk.org Mon Nov 4 08:06:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 08:06:36 GMT Subject: [jdk21u-dev] Integrated: 8340214: C2 compilation asserts with "no node with a side effect" in PhaseIdealLoop::try_sink_out_of_loop In-Reply-To: <GQ17aOAFCsgP62BAPMbNriS6Wmm8SLL6xBT4tT2uhL8=.5c7d029a-7a1c-4d29-af9a-82fb39b68b09@github.com> References: <GQ17aOAFCsgP62BAPMbNriS6Wmm8SLL6xBT4tT2uhL8=.5c7d029a-7a1c-4d29-af9a-82fb39b68b09@github.com> Message-ID: <wBbWQ9JENT0hjoQNv61O2oGWUS98z3wSq7G-yUIprkQ=.31b5137e-e960-4007-88b0-e7e96b6d6c39@github.com> On Thu, 31 Oct 2024 20:24:19 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 6b33c1c0 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/6b33c1c0b1e8b1be729a831a26a2194f2b874918 Stats: 124 lines in 4 files changed: 112 ins; 1 del; 11 mod 8340214: C2 compilation asserts with "no node with a side effect" in PhaseIdealLoop::try_sink_out_of_loop Backport-of: ff2f39f24018436556a8956ec55da433dc697437 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1117 From mbaesken at openjdk.org Mon Nov 4 08:07:31 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 4 Nov 2024 08:07:31 GMT Subject: [jdk21u-dev] RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files In-Reply-To: <PuKyfW7LUlrIDyksexnHjfMOti5wDfvTTgFEkHDi4O4=.290d09ad-15ae-4cae-8b10-c056c5765a45@github.com> References: <PuKyfW7LUlrIDyksexnHjfMOti5wDfvTTgFEkHDi4O4=.290d09ad-15ae-4cae-8b10-c056c5765a45@github.com> Message-ID: <dvHoATZURWYNlf2VX2RSUwXudongOZr0JGLndWU7XBI=.fcba7d33-928d-4e6c-a968-768b58dd7394@github.com> On Thu, 31 Oct 2024 09:04:25 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > Omitted edit in CLDRConverter.java. The modified method was > introduced by "8317979: Use TZ database style abbreviations in the CLDR locale provider" > which is a preparatory change for "8174269 Remove COMPAT locale data provider from JDK". > Both are not candidates for backport. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1113#pullrequestreview-2412381700 From goetz at openjdk.org Mon Nov 4 08:08:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 08:08:29 GMT Subject: [jdk17u-dev] Integrated: 8340785: Update description of PassFailJFrame and samples In-Reply-To: <DtjnhY1MYodDbUGqK4qlSX5zbOxwgxTAFIZg9DykU7U=.0bb4f377-536d-40f3-bdca-2881cb7fe644@github.com> References: <DtjnhY1MYodDbUGqK4qlSX5zbOxwgxTAFIZg9DykU7U=.0bb4f377-536d-40f3-bdca-2881cb7fe644@github.com> Message-ID: <2bIz_hMCHA4XfzsDYNki7VuW1DMhl6iZ5aEHPLpZWPA=.ef2fe99c-9fe3-4adf-9099-d7f7c1d5a60f@github.com> On Thu, 31 Oct 2024 19:34:23 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle This pull request has now been integrated. Changeset: 59fcc3c6 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/59fcc3c6bc6d8bcb049cdb0bbaa2f942bb252b90 Stats: 159 lines in 1 file changed: 126 ins; 0 del; 33 mod 8340785: Update description of PassFailJFrame and samples Backport-of: 5063494f5b0859a396b4e41096793c777d4650b8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3020 From goetz at openjdk.org Mon Nov 4 08:09:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 08:09:36 GMT Subject: [jdk17u-dev] Integrated: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result In-Reply-To: <eLGWdT5zQ3BQ47ttRvFpp3eAmzoQ5LLaetQTWjWwd_M=.2bdb5fbb-63a7-4a34-9552-9b700191bf9c@github.com> References: <eLGWdT5zQ3BQ47ttRvFpp3eAmzoQ5LLaetQTWjWwd_M=.2bdb5fbb-63a7-4a34-9552-9b700191bf9c@github.com> Message-ID: <ggZ0Yf9MITKrrufsH1AFxK1NTqnErVkRDaB5OCCmXRE=.55fd00df-f2e9-4abb-b038-452ba3400a2f@github.com> On Thu, 31 Oct 2024 19:56:27 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle This pull request has now been integrated. Changeset: a7fc50c8 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/a7fc50c8e482c7b2a25fd8ee9e6b4bea01e6eb82 Stats: 58 lines in 2 files changed: 58 ins; 0 del; 0 mod 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result Backport-of: cd61f97c2de94d19c0101c51bde143001078c89f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3021 From goetz at openjdk.org Mon Nov 4 08:58:03 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 08:58:03 GMT Subject: [jdk21u-dev] RFR: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe Message-ID: <YhAVrB7hf-Eofv270Qro78wELfP6JD1HJ1pDeqxx49g=.6a87e25b-7c49-476d-af0f-46b9193b51d1@github.com> I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 47c10694c66bc131c8a5e1572340415b8daaba08 Changes: https://git.openjdk.org/jdk21u-dev/pull/1119/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1119&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340812 Stats: 73 lines in 2 files changed: 70 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1119.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1119/head:pull/1119 PR: https://git.openjdk.org/jdk21u-dev/pull/1119 From clanger at openjdk.org Mon Nov 4 09:00:29 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 4 Nov 2024 09:00:29 GMT Subject: [jdk21u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project. In-Reply-To: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> References: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> Message-ID: <YaME7F8E6PUQGpuPezBdTIszYZ9Zm_-zcY7c-P6dLTU=.ee54b460-a7d0-4727-8cef-d6e897f71806@github.com> On Sat, 2 Nov 2024 12:25:29 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > Customize the README.md to jdk21u. > > Plan is to backport this to 17 and maybe older jdks and adapt the paths etc correspondingly. > So let?s keep this sufficiently generic so that the information holds for jdkXu and jdkXu-dev > and that the change can easily be backported (by adapting 21->17 etc). > > Should we put there more information? Marked as reviewed by clanger (Reviewer). README.md line 6: > 4: Repository [jdk21u](https://github.com/openjdk/jdk21u) is used for rampdown of the update releases of jdk21u and only accepts critical changes that must make the next release during rampdown. (You probably do not want to target jdk21u). > 5: > 6: For more OpenJDK 21 updates specific information as timelines and contribution see the [project wiki page](https://wiki.openjdk.org/display/JDKUpdates/JDK+21u/). Maybe Suggestion: For more OpenJDK 21 updates specific information such as timelines and contribution guidelines see the [project wiki page](https://wiki.openjdk.org/display/JDKUpdates/JDK+21u/). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1118#pullrequestreview-2412501157 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1118#discussion_r1827392329 From goetz at openjdk.org Mon Nov 4 09:00:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 09:00:42 GMT Subject: [jdk17u-dev] RFR: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe Message-ID: <Uc8uuNQKGOU_LE5sfCNAsPsuV2MQkzUt2dLACmYx7jw=.35b6e13c-ecaa-4b58-a99c-30549ec08d8e@github.com> I backport this for parity with 17.0.14-oracle. Resolved Copyright, probably clean anyways. ------------- Commit messages: - Backport 47c10694c66bc131c8a5e1572340415b8daaba08 Changes: https://git.openjdk.org/jdk17u-dev/pull/3024/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3024&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340812 Stats: 73 lines in 2 files changed: 70 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3024.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3024/head:pull/3024 PR: https://git.openjdk.org/jdk17u-dev/pull/3024 From goetz at openjdk.org Mon Nov 4 09:16:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 09:16:41 GMT Subject: [jdk17u-dev] RFR: 8340799: Add border inside instruction frame in PassFailJFrame Message-ID: <z4W2X4urh5fbepehEedkplcc--iyzGh1T3pEwqNyVaM=.b123a1f1-b7f2-4eb8-9029-a97d981895e7@github.com> I backport this for parity with 17.0.14-oracle ------------- Commit messages: - Backport 520060f79a3cedb8f93e6bbd0e9b2823eaabf79a Changes: https://git.openjdk.org/jdk17u-dev/pull/3025/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3025&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340799 Stats: 47 lines in 1 file changed: 34 ins; 0 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3025.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3025/head:pull/3025 PR: https://git.openjdk.org/jdk17u-dev/pull/3025 From goetz at openjdk.org Mon Nov 4 09:17:04 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 09:17:04 GMT Subject: [jdk21u-dev] RFR: 8340799: Add border inside instruction frame in PassFailJFrame Message-ID: <9JIn656tDI4qQgi3z0JL66y1Sp3ojumtDlUKKXQnhD8=.8b981281-bf44-4ab4-9529-7df8bc265d1f@github.com> I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 520060f79a3cedb8f93e6bbd0e9b2823eaabf79a Changes: https://git.openjdk.org/jdk21u-dev/pull/1120/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1120&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340799 Stats: 47 lines in 1 file changed: 34 ins; 0 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1120.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1120/head:pull/1120 PR: https://git.openjdk.org/jdk21u-dev/pull/1120 From goetz at openjdk.org Mon Nov 4 09:19:04 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 09:19:04 GMT Subject: [jdk21u-dev] RFR: 8341235: Improve default instruction frame title in PassFailJFrame Message-ID: <Iz6I8d-HeIF4i3eOgjQ-HQ7OR2JgL2A4KaVX8Tkpawc=.a1d3704e-85d4-42e9-9fbe-ad40c53b20b2@github.com> I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 4ba170c403ae85576f84dafd4a157ba0db99873f Changes: https://git.openjdk.org/jdk21u-dev/pull/1121/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1121&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341235 Stats: 42 lines in 1 file changed: 39 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1121.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1121/head:pull/1121 PR: https://git.openjdk.org/jdk21u-dev/pull/1121 From goetz at openjdk.org Mon Nov 4 09:20:05 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Nov 2024 09:20:05 GMT Subject: [jdk17u-dev] RFR: 8341235: Improve default instruction frame title in PassFailJFrame Message-ID: <pvqH32QlLP0VKvyUQF4txTEjgYSmm7tb3bmvUKm9muQ=.2baa0c34-4e7b-4c5a-883a-d93602a9b7e3@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 4ba170c403ae85576f84dafd4a157ba0db99873f Changes: https://git.openjdk.org/jdk17u-dev/pull/3026/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3026&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341235 Stats: 42 lines in 1 file changed: 39 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3026.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3026/head:pull/3026 PR: https://git.openjdk.org/jdk17u-dev/pull/3026 From roland at openjdk.org Mon Nov 4 12:30:42 2024 From: roland at openjdk.org (Roland Westrelin) Date: Mon, 4 Nov 2024 12:30:42 GMT Subject: [jdk21u-dev] Integrated: 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress In-Reply-To: <DSyWBe6pIdw4b_gQFzVheOZrdf56UpEVMr2_MNxc_HY=.f245a9e4-cae1-467b-8924-a0ce591cf4f1@github.com> References: <DSyWBe6pIdw4b_gQFzVheOZrdf56UpEVMr2_MNxc_HY=.f245a9e4-cae1-467b-8924-a0ce591cf4f1@github.com> Message-ID: <mHvgzuupqkvk1MmD-lTILyPfhA2Rkl47W_HAZVqAl0E=.308efa6e-9689-43f3-8dba-9fdba968e9a6@github.com> On Thu, 24 Oct 2024 08:57:44 GMT, Roland Westrelin <roland at openjdk.org> wrote: > Clean backport of JDK-8342496 This pull request has now been integrated. Changeset: c17e0094 Author: Roland Westrelin <roland at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/c17e00945d0b06f7459a3dbb091321cfe3dc6129 Stats: 70 lines in 2 files changed: 70 ins; 0 del; 0 mod 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress Backport-of: 680dc5d896f4f7b01b3cf800d548e32bb2ef8c81 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1088 From roland at openjdk.org Mon Nov 4 12:31:33 2024 From: roland at openjdk.org (Roland Westrelin) Date: Mon, 4 Nov 2024 12:31:33 GMT Subject: [jdk17u-dev] Integrated: 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress In-Reply-To: <Uxs0P7vYLASzZOCVpPw8nJ-deVL5Pn4VhNodvyB7NOI=.eda21d4f-c9bb-4d8c-a3ec-2fc6bf277528@github.com> References: <Uxs0P7vYLASzZOCVpPw8nJ-deVL5Pn4VhNodvyB7NOI=.eda21d4f-c9bb-4d8c-a3ec-2fc6bf277528@github.com> Message-ID: <P_bbm-6x1J5PuP-yD9w2uMe_jrULwOzwJ3awoxtl77g=.016e47d4-88fc-409d-8052-045592753653@github.com> On Fri, 25 Oct 2024 08:57:33 GMT, Roland Westrelin <roland at openjdk.org> wrote: > Clean backport JDK-8342496 This pull request has now been integrated. Changeset: 955bae2b Author: Roland Westrelin <roland at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/955bae2b03055552237584aa7c68b1afcfa3b9c1 Stats: 70 lines in 2 files changed: 70 ins; 0 del; 0 mod 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress Backport-of: 680dc5d896f4f7b01b3cf800d548e32bb2ef8c81 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3006 From mbaesken at openjdk.org Mon Nov 4 15:33:06 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 4 Nov 2024 15:33:06 GMT Subject: [jdk23u] RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang Message-ID: <W---agxTqxo1_pGJveYu1DJZOVtqWk3t3hyCjyajZwk=.594eb5cc-6e75-4a0a-883d-0f8454eb48a9@github.com> Backport of 8341722, changes of Lib.gmk are not in 23u ------------- Commit messages: - Backport e7c5bf45f753ad6459c666a4dd4a31197b69e05e Changes: https://git.openjdk.org/jdk23u/pull/213/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=213&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341722 Stats: 10 lines in 4 files changed: 1 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk23u/pull/213.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/213/head:pull/213 PR: https://git.openjdk.org/jdk23u/pull/213 From roland at openjdk.org Mon Nov 4 15:33:52 2024 From: roland at openjdk.org (Roland Westrelin) Date: Mon, 4 Nov 2024 15:33:52 GMT Subject: [jdk21u-dev] RFR: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() Message-ID: <oXGjmxsYM6bWFQ_2aVzfK5sZdiuYMtL9oNUk8glJosQ=.c75109a9-1e28-4e0b-98fd-d78b96bb8af0@github.com> clean backport of JDK-8340824 ------------- Commit messages: - Backport 90c944fefe4a7827c08a8e6a81f137c3157a749b Changes: https://git.openjdk.org/jdk21u-dev/pull/1122/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1122&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340824 Stats: 89 lines in 2 files changed: 14 ins; 11 del; 64 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1122.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1122/head:pull/1122 PR: https://git.openjdk.org/jdk21u-dev/pull/1122 From srl at openjdk.org Mon Nov 4 16:29:27 2024 From: srl at openjdk.org (Steven Loomis) Date: Mon, 4 Nov 2024 16:29:27 GMT Subject: [jdk11u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v3] In-Reply-To: <3j_Tqw92GYtmWFYtRJkbplIF1_KiA4VXBe9lt1dMvTc=.5f342d4c-074a-4b56-bb3d-8c93fc5a47d7@github.com> References: <3j_Tqw92GYtmWFYtRJkbplIF1_KiA4VXBe9lt1dMvTc=.5f342d4c-074a-4b56-bb3d-8c93fc5a47d7@github.com> Message-ID: <-vkps507KhQ9HKpJ3Sw26fY_qopj7e8TbZruHr4R7u0=.ac422fce-bd04-4a76-a4d1-5d94f5f21361@github.com> > @srl295 Could not automatically backport b8f2ec90 to openjdk/jdk11u-dev due to conflicts in the following files: > > src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m > Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk11u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know. > > # Fetch the up-to-date version of the target branch > $ git fetch --no-tags https://git.openjdk.org/jdk11u-dev.git master:master > > # Check out the target branch and create your own branch to backport > $ git checkout master > $ git checkout -b backport-srl295-b8f2ec90-master > > # Fetch the commit you want to backport > $ git fetch --no-tags https://git.openjdk.org/jdk.git b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd > > # Backport the commit > $ git cherry-pick --no-commit b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd > # Resolve conflicts now > > # Commit the files you have modified > $ git add files/with/resolved/conflicts > $ git commit -m 'Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd' > Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk11u-dev with the title Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd. > > Below you can find a suggestion for the pull request body: > > Hi all, > > This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. > > The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. > > PR: https://github.com/openjdk/jdk/pull/17921 > > Thanks! Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - 8195675: merge from master - 8195675: empty commit to trigger build - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2954/files - new: https://git.openjdk.org/jdk11u-dev/pull/2954/files/99d846f1..98f35e83 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2954&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2954&range=01-02 Stats: 8 lines in 1 file changed: 0 ins; 8 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2954.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2954/head:pull/2954 PR: https://git.openjdk.org/jdk11u-dev/pull/2954 From clanger at openjdk.org Mon Nov 4 15:57:39 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 4 Nov 2024 15:57:39 GMT Subject: [jdk23u] RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang In-Reply-To: <W---agxTqxo1_pGJveYu1DJZOVtqWk3t3hyCjyajZwk=.594eb5cc-6e75-4a0a-883d-0f8454eb48a9@github.com> References: <W---agxTqxo1_pGJveYu1DJZOVtqWk3t3hyCjyajZwk=.594eb5cc-6e75-4a0a-883d-0f8454eb48a9@github.com> Message-ID: <Tlg0Jvbd457UU2O48RIqQXSLS_fBwEB1VUXgdsL_qwo=.33287bb4-059b-48bb-b4e5-aae8ebccc3c5@github.com> On Mon, 4 Nov 2024 15:28:00 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > Backport of 8341722, changes of Lib.gmk are not in 23u so I omit those; otherwise applied clean. Marked as reviewed by clanger (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk23u/pull/213#pullrequestreview-2413453830 From bulasevich at openjdk.org Mon Nov 4 17:30:37 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Mon, 4 Nov 2024 17:30:37 GMT Subject: [jdk21u-dev] RFR: 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: <IemMFwdS40DbQh6aW3eSIf4O1SgR97r2U66YGavrdyQ=.700b0a41-0aca-45b3-aaac-bcf109bc4cf2@github.com> References: <IemMFwdS40DbQh6aW3eSIf4O1SgR97r2U66YGavrdyQ=.700b0a41-0aca-45b3-aaac-bcf109bc4cf2@github.com> Message-ID: <JOv256F1ZHJNWHQ9xhZ0iRQv_J07HkKW65XyY0hT5-g=.ff5b719c-eb86-4c3a-b37a-cf48305d7fa9@github.com> On Thu, 24 Oct 2024 13:54:06 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote: > (not a clean backport) > Reworked to avoid https://github.com/openjdk/jdk/pull/17328/files backport Reproducer: import jdk.jfr.consumer.RecordingStream; /** * Stress test to provoke the memory leak: * starts 1M empty threads in VM with jfr recording */ public class PinnedThreadTracker implements AutoCloseable { private final RecordingStream recordingStream; public PinnedThreadTracker() { recordingStream = new RecordingStream(); recordingStream.startAsync(); System.out.println("start recording.."); } @Override public void close() { recordingStream.close(); } class MyThread extends Thread { public void run() { } } public void runThreads() { for (int i = 0; i < 100; i++) { for (int j = 0; j < 100; j++) { for (int k = 0; k < 100; k++) { new MyThread().start(); } MyThread thr = new MyThread(); thr.start(); try { thr.join(); } catch (Exception ex) {} } System.out.print("."); } } public static void main(String a[]) { PinnedThreadTracker ptt = new PinnedThreadTracker(); ptt.runThreads(); ptt.close(); } } Manual testing results on jdk21u: $ for i in {0..60}; do export PID=`ps -ax | grep java | grep PinnedThreadTracker | sed "s/^ *// ; s/ .*//"` jcmd $PID VM.native_memory | grep Tracing.*reserved sleep 1s done Before the change (jcmd VM.native_memory output once a second): - Tracing (reserved=17355KB, committed=17355KB) - Tracing (reserved=21646KB, committed=21646KB) - Tracing (reserved=25870KB, committed=25870KB) - Tracing (reserved=30065KB, committed=30065KB) ... - Tracing (reserved=240567KB, committed=240567KB) - Tracing (reserved=244519KB, committed=244519KB) - Tracing (reserved=248525KB, committed=248525KB) - Tracing (reserved=252527KB, committed=252527KB) With the fix: - Tracing (reserved=17655KB, committed=17655KB) - Tracing (reserved=18125KB, committed=18125KB) - Tracing (reserved=18449KB, committed=18449KB) - Tracing (reserved=18961KB, committed=18961KB) ... - Tracing (reserved=17443KB, committed=17443KB) - Tracing (reserved=17958KB, committed=17958KB) - Tracing (reserved=18491KB, committed=18491KB) - Tracing (reserved=18970KB, committed=18970KB) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1095#issuecomment-2455300319 From srl at openjdk.org Mon Nov 4 17:56:55 2024 From: srl at openjdk.org (Steven Loomis) Date: Mon, 4 Nov 2024 17:56:55 GMT Subject: [jdk11u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v3] In-Reply-To: <-vkps507KhQ9HKpJ3Sw26fY_qopj7e8TbZruHr4R7u0=.ac422fce-bd04-4a76-a4d1-5d94f5f21361@github.com> References: <3j_Tqw92GYtmWFYtRJkbplIF1_KiA4VXBe9lt1dMvTc=.5f342d4c-074a-4b56-bb3d-8c93fc5a47d7@github.com> <-vkps507KhQ9HKpJ3Sw26fY_qopj7e8TbZruHr4R7u0=.ac422fce-bd04-4a76-a4d1-5d94f5f21361@github.com> Message-ID: <TKicrzQVmI9k57yVo2pCRkZAblErZk54cB8UNm7yurE=.f4149c6b-3459-4d19-a831-e843c0859543@github.com> On Mon, 4 Nov 2024 16:29:27 GMT, Steven Loomis <srl at openjdk.org> wrote: >> @srl295 Could not automatically backport b8f2ec90 to openjdk/jdk11u-dev due to conflicts in the following files: >> >> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m >> Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk11u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know. >> >> # Fetch the up-to-date version of the target branch >> $ git fetch --no-tags https://git.openjdk.org/jdk11u-dev.git master:master >> >> # Check out the target branch and create your own branch to backport >> $ git checkout master >> $ git checkout -b backport-srl295-b8f2ec90-master >> >> # Fetch the commit you want to backport >> $ git fetch --no-tags https://git.openjdk.org/jdk.git b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd >> >> # Backport the commit >> $ git cherry-pick --no-commit b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd >> # Resolve conflicts now >> >> # Commit the files you have modified >> $ git add files/with/resolved/conflicts >> $ git commit -m 'Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd' >> Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk11u-dev with the title Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd. >> >> Below you can find a suggestion for the pull request body: >> >> Hi all, >> >> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. >> >> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. >> >> PR: https://github.com/openjdk/jdk/pull/17921 >> >> Thanks! > > Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - 8195675: merge from master > - 8195675: empty commit to trigger build > - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd > The macOS-12 environment is deprecated, consider switching to macOS-13, macOS-14 (macos-latest) or macOS-15. For more details, see https://github.com/actions/runner-images/issues/10721 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2954#issuecomment-2455355091 From mdoerr at openjdk.org Mon Nov 4 18:05:52 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 4 Nov 2024 18:05:52 GMT Subject: [jdk23u] RFR: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory Message-ID: <216VMHv4HtLt3cg1rrIDbpJWraJ8CesnUIaF4OzTH0k=.6a905f9c-3e95-46be-9ca3-557d3b5bae5f@github.com> Clean backport of [JDK-8343205](https://bugs.openjdk.org/browse/JDK-8343205). ------------- Commit messages: - Backport 75801992a7c626d409f66e2491082dba84c6fe45 Changes: https://git.openjdk.org/jdk23u/pull/214/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=214&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343205 Stats: 27 lines in 2 files changed: 16 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk23u/pull/214.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/214/head:pull/214 PR: https://git.openjdk.org/jdk23u/pull/214 From mdoerr at openjdk.org Mon Nov 4 18:13:44 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 4 Nov 2024 18:13:44 GMT Subject: [jdk21u-dev] RFR: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory Message-ID: <rwyUPl4cGRW2spxtJE62X5_PmMOOqFCBp2La19tGa5M=.a30df0e2-7db8-4354-b9a2-71225ce52559@github.com> Almost clean backport of [JDK-8343205](https://bugs.openjdk.org/browse/JDK-8343205). I have included `get_c1_thread_count()` and `get_c2_thread_count()` from [JDK-8317562](https://bugs.openjdk.org/browse/JDK-8317562) (see 2nd commit). ------------- Commit messages: - Add getters from JDK-8317562. - Backport 75801992a7c626d409f66e2491082dba84c6fe45 Changes: https://git.openjdk.org/jdk21u-dev/pull/1123/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1123&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343205 Stats: 29 lines in 2 files changed: 18 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1123.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1123/head:pull/1123 PR: https://git.openjdk.org/jdk21u-dev/pull/1123 From bulasevich at openjdk.org Mon Nov 4 19:08:39 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Mon, 4 Nov 2024 19:08:39 GMT Subject: [jdk21u-dev] RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic In-Reply-To: <g03nh_3JoTbQ1pkEzCZW425IGDkoNX5Bda5FPF3FuOE=.44724b0d-48fc-4835-8f94-d70a19d95b72@github.com> References: <jX1MjWrB66u613MKWwFjPm5Tcn5y_QXjqk155frBv7c=.9891643f-f860-49b1-bf4a-bf5f9b617a5b@github.com> <g03nh_3JoTbQ1pkEzCZW425IGDkoNX5Bda5FPF3FuOE=.44724b0d-48fc-4835-8f94-d70a19d95b72@github.com> Message-ID: <aPLNFlIl2ncJEdE9bZGKvYoYiZkPJQYOvA3oUr5lHgU=.8a11dabe-2bb7-4ba9-9b34-5e5d73649baf@github.com> On Fri, 1 Nov 2024 08:54:02 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > Hi @bulasevich , do we need any of the 6 related issues listed in the JBS issue? Hi @GoeLin I do not think we need them: 1. JDK-6487931 JVM reports EXCEPTION_FLT_STACK_CHECK when calling a Java method through JNI Resolved: 2011-03-07 2. JDK-6550813 Crash because of FPU control word being modified by native code (win32) Resolved: 2011-04-25 3. JDK-8317810 DSO created with -ffast-math breaks Java floating-point arithmetic Unresolved. It is a JBS record for further similar change for x86 platform. 4. JDK-8321017 Record in JFR that IEEE rounding mode was corrupted by loading a library JFR improvement. I do not think it is necessary to backport. 5. JDK-8319708 Assertion 'fsetenv didn't work' in jdk tier4 tests after 8295159 on Linux aarch64 RHEL9.3 Closed (User error) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1111#issuecomment-2455488657 From szaldana at openjdk.org Mon Nov 4 20:50:15 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 4 Nov 2024 20:50:15 GMT Subject: [jdk21u-dev] RFR: 8338389: [JFR] Long strings should be added to the string pool Message-ID: <7Ozip7X2S8TqCRAFmAkiTw4m6ANBM-oghgds44_ly8M=.73b107bb-4411-41ca-8a7c-d96cefc0caf5@github.com> Hi all, This pull request contains a backport of commit [d5c6158c](https://github.com/openjdk/jdk/commit/d5c6158cedfd96a9f97d83355b10730b81274648) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Joakim Nordstr?m on 27 Aug 2024 and was reviewed by Markus Gr?nlund. Thanks! ------------- Commit messages: - Backport d5c6158cedfd96a9f97d83355b10730b81274648 Changes: https://git.openjdk.org/jdk21u-dev/pull/1109/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1109&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338389 Stats: 119 lines in 2 files changed: 116 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1109.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1109/head:pull/1109 PR: https://git.openjdk.org/jdk21u-dev/pull/1109 From phh at openjdk.org Mon Nov 4 23:07:28 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 4 Nov 2024 23:07:28 GMT Subject: [jdk21u-dev] RFR: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory In-Reply-To: <rwyUPl4cGRW2spxtJE62X5_PmMOOqFCBp2La19tGa5M=.a30df0e2-7db8-4354-b9a2-71225ce52559@github.com> References: <rwyUPl4cGRW2spxtJE62X5_PmMOOqFCBp2La19tGa5M=.a30df0e2-7db8-4354-b9a2-71225ce52559@github.com> Message-ID: <990U3_WWdGf1AXqS_U7PbcQObNjFdhFp-osIDxDUmRc=.c0171f9f-0991-438d-b6e1-df465b97a7dd@github.com> On Mon, 4 Nov 2024 18:07:40 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: > Almost clean backport of [JDK-8343205](https://bugs.openjdk.org/browse/JDK-8343205). I have included `get_c1_thread_count()` and `get_c2_thread_count()` from [JDK-8317562](https://bugs.openjdk.org/browse/JDK-8317562) (see 2nd commit). Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1123#pullrequestreview-2414315627 From syan at openjdk.org Mon Nov 4 23:13:35 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 4 Nov 2024 23:13:35 GMT Subject: [jdk17u-dev] Integrated: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds In-Reply-To: <MoQsf9p2xZfHaO2qKB3GTLaZoowu3DY9SWFC6ILD_Do=.8d127f9e-7d95-46c1-ac89-dfb08c82f308@github.com> References: <MoQsf9p2xZfHaO2qKB3GTLaZoowu3DY9SWFC6ILD_Do=.8d127f9e-7d95-46c1-ac89-dfb08c82f308@github.com> Message-ID: <gc40W3y-3_59X77X8EyEpCkxRtjd5PER6ixbGyhu_JE=.3a315bc7-7107-444d-a477-69181c3daae2@github.com> On Wed, 30 Oct 2024 07:27:00 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [571c435e](https://github.com/openjdk/jdk/commit/571c435e1a34dcf08fd7545d531c258c9116ea79) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jan Kratochvil on 23 Aug 2023 and was reviewed by Erik Joelsson. > > Without this PR, the jdk build with --enable-ccache can't generate comments in -XX:+PrintInterpreter, this PR fix the build issue. So I want to backport this PR to jdk17u-dev from jdk22. > > Thanks! This pull request has now been integrated. Changeset: 18ea311a Author: SendaoYan <syan at openjdk.org> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/18ea311a328ffba286c72fe9035cb395c187aae9 Stats: 14 lines in 1 file changed: 14 ins; 0 del; 0 mod 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds Backport-of: c37acdb0880f9ac013ba88c436ce980647e6d0a9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3015 From duke at openjdk.org Mon Nov 4 23:15:38 2024 From: duke at openjdk.org (Vlad Zahorodnii) Date: Mon, 4 Nov 2024 23:15:38 GMT Subject: [jdk17u-dev] Integrated: 8338751: ConfigureNotify behavior has changed in KWin 6.2 In-Reply-To: <HI7MTzk9XLHJKZOCKc7LErPLoSukfJc0VLRQZPpTrkA=.15fab3ba-8b68-46f7-824c-d3ccd4cb3180@github.com> References: <HI7MTzk9XLHJKZOCKc7LErPLoSukfJc0VLRQZPpTrkA=.15fab3ba-8b68-46f7-824c-d3ccd4cb3180@github.com> Message-ID: <kvlT6e1hEFLNb9KnJKmYo8mol5APDisSEq8xe427U-0=.c635dff4-f361-4385-9447-ee4ddb1898c5@github.com> On Mon, 21 Oct 2024 20:17:11 GMT, Vlad Zahorodnii <duke at openjdk.org> wrote: > Reviewed-by: prr, azvegint, serb This pull request has now been integrated. Changeset: 24769df8 Author: Vlad Zahorodnii <vlad.zahorodnii at kde.org> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/24769df8018233b9cc7bfefcdb74c509140897fc Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8338751: ConfigureNotify behavior has changed in KWin 6.2 Backport-of: 3da68900818fc43b777098fe6e244779794d5294 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2981 From duke at openjdk.org Mon Nov 4 23:15:40 2024 From: duke at openjdk.org (toshiogata) Date: Mon, 4 Nov 2024 23:15:40 GMT Subject: [jdk17u-dev] Integrated: 8337851: Some tests have name which confuse jtreg In-Reply-To: <n9RBpkKvl1KtuLzkhPs620E6NmM1C2QouuyRUc_EhP4=.919fbea7-3f88-4d8b-9160-71a6aa46b539@github.com> References: <n9RBpkKvl1KtuLzkhPs620E6NmM1C2QouuyRUc_EhP4=.919fbea7-3f88-4d8b-9160-71a6aa46b539@github.com> Message-ID: <93fL2ZOvxUPMShmNu7t3ZY5EFy1Clk5gfHiHT5ZcNmo=.d2325eb8-233b-48ce-9b70-af8e3fdc9223@github.com> On Thu, 31 Oct 2024 04:27:35 GMT, toshiogata <duke at openjdk.org> wrote: > Hi all, > > I would like to backport this patch because the reported jtreg issue is reproducible in JDK17. > The original patch applies cleanly. > > Although the test/langtools/tools/javac/warnings/Serial directory were introduced in JDK 18 and the associated jtreg issues for that directory is not present in JDK 17, Serial.java and Serial.out have been renamed to minimize differences. > > Testing: the related tests with "-retain:all" option, and all tests under tools/javac > > Thank you This pull request has now been integrated. Changeset: 6c7f6221 Author: t.ogata <ogata.toshitaka at fujitsu.com> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/6c7f6221628a6b1b33ff8f73b32c06cdf5d72285 Stats: 0 lines in 4 files changed: 0 ins; 0 del; 0 mod 8337851: Some tests have name which confuse jtreg Backport-of: e6698f51a1977d553ce4e1dd14b43b0d325224fa ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3018 From phh at openjdk.org Mon Nov 4 23:24:38 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 4 Nov 2024 23:24:38 GMT Subject: [jdk11u-dev] RFR: 8301118: Ignore allow and disallow options for java.security.manager System Property In-Reply-To: <qeVqpJvHZH6t3mrXv5FYbzgErhRdTyTF7w3AF2sy5pY=.afe2c97e-9602-431e-8b19-88f113a1a6d1@github.com> References: <qeVqpJvHZH6t3mrXv5FYbzgErhRdTyTF7w3AF2sy5pY=.afe2c97e-9602-431e-8b19-88f113a1a6d1@github.com> Message-ID: <hSz7rfqJF1iySUR0CeMSDql72dgZq818bvDTOoArsxs=.b8aa5b9c-222f-4250-bd10-2350fde48cec@github.com> On Fri, 6 Sep 2024 11:13:21 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote: > Proposing the change for parity with Oracle (fixed in 11.0.21-oracle). > > The change isn't a backport and it's implemented according to the description of https://bugs.openjdk.org/browse/JDK-8301118. New allow/disallow options for the java.security.manager system property should be ignored in JDK11. > > New test fails without the change and passes with the change. Change lgtm, would be good to check Oracle 11u to see whether it issues a warning. The OSX build failures appear unrelated but should be addressed in a different PR. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2932#pullrequestreview-2414339040 From syan at openjdk.org Mon Nov 4 23:35:40 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 4 Nov 2024 23:35:40 GMT Subject: [jdk11u-dev] Integrated: 8334332: TestIOException.java fails if run by root In-Reply-To: <5-zEZYJt00wVH02mwY3eiC1JNttfqb55dnyk8BRRxZg=.cef6f6ff-d62b-4287-bd09-416541b1a862@github.com> References: <5-zEZYJt00wVH02mwY3eiC1JNttfqb55dnyk8BRRxZg=.cef6f6ff-d62b-4287-bd09-416541b1a862@github.com> Message-ID: <-Ggl6IgqtusPYae_DR3ELCflvMBg-FFDxCBPr8M8Ywk=.4dccc1ba-d19b-4d23-8c35-f708cf6785c7@github.com> On Tue, 18 Jun 2024 15:31:24 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [472b935b](https://github.com/openjdk/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 18 Jun 2024 and was reviewed by Pavel Rappo. > > The reason of backport is not clean is that, multiple PRs have been merged into the `jdk17u-dev` of this file, including `JDK-8215516`, `JDK-8164597`, etc., and these PRs cannot be directly backported to `jdk11u-dev`. > > This PR also change `test/langtools/TEST.ROOT`, it's partial backport of [JDK-8242652](https://bugs.openjdk.org/browse/JDK-8242652). [JDK-8242652](https://bugs.openjdk.org/browse/JDK-8242652) can't backport to jdk11u-dev, the jdk11u-dev repo dosen't have file `test/langtools/jdk/javadoc/doclet/testSearchScript/TestSearchScript.java`. > > Only change test testcase, the risk is quite very low. > > The change verified on below env: > > - [x] linux non-root user > - [x] linix root user > - [x] windows > > Thanks! This pull request has now been integrated. Changeset: 98161b7a Author: SendaoYan <syan at openjdk.org> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk11u-dev/commit/98161b7a9b1ff4a9f3b6c41efd15c31a8f959c68 Stats: 55 lines in 2 files changed: 40 ins; 0 del; 15 mod 8334332: TestIOException.java fails if run by root Reviewed-by: phh Backport-of: 472b935b442f7f925b665c7de91eda77f3dcbe8b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2795 From duke at openjdk.org Tue Nov 5 00:39:33 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Tue, 5 Nov 2024 00:39:33 GMT Subject: [jdk11u-dev] RFR: 8026976: ECParameters, Point does not match field size In-Reply-To: <VO_d4MJBGy62PUI87lIRgShsUSwqWZs3MT1OFb0gaBU=.718d419a-e5cd-4e26-8df7-de70adc97da0@github.com> References: <VO_d4MJBGy62PUI87lIRgShsUSwqWZs3MT1OFb0gaBU=.718d419a-e5cd-4e26-8df7-de70adc97da0@github.com> Message-ID: <H28x1aLQqYDvpfoutzekG5f_ZwLeZ8FqADbXNR2BqaY=.6dd23f30-3324-474b-b849-3af34057d610@github.com> On Mon, 21 Oct 2024 07:15:55 GMT, Taizo Kurashige <duke at openjdk.org> wrote: > Hi all, > > This is a backport of JDK-8026976: ECParameters, Point does not match field size > > Original patch apply cleanly to 11u. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. Could anyone review this backport please? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2958#issuecomment-2455985313 From syan at openjdk.org Tue Nov 5 00:53:31 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 00:53:31 GMT Subject: [jdk17u-dev] RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds In-Reply-To: <MoQsf9p2xZfHaO2qKB3GTLaZoowu3DY9SWFC6ILD_Do=.8d127f9e-7d95-46c1-ac89-dfb08c82f308@github.com> References: <MoQsf9p2xZfHaO2qKB3GTLaZoowu3DY9SWFC6ILD_Do=.8d127f9e-7d95-46c1-ac89-dfb08c82f308@github.com> Message-ID: <3Pml2X7CIg2kMoFM2xNMf4aj5W8OC_DmpMk6yPAHsNk=.6ef5cf88-271c-4cc9-a6d0-1e910e034b78@github.com> On Wed, 30 Oct 2024 07:27:00 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [571c435e](https://github.com/openjdk/jdk/commit/571c435e1a34dcf08fd7545d531c258c9116ea79) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jan Kratochvil on 23 Aug 2023 and was reviewed by Erik Joelsson. > > Without this PR, the jdk build with --enable-ccache can't generate comments in -XX:+PrintInterpreter, this PR fix the build issue. So I want to backport this PR to jdk17u-dev from jdk22. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3015#issuecomment-2455998024 From syan at openjdk.org Tue Nov 5 00:57:39 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 00:57:39 GMT Subject: [jdk11u-dev] RFR: 8334332: TestIOException.java fails if run by root In-Reply-To: <5-zEZYJt00wVH02mwY3eiC1JNttfqb55dnyk8BRRxZg=.cef6f6ff-d62b-4287-bd09-416541b1a862@github.com> References: <5-zEZYJt00wVH02mwY3eiC1JNttfqb55dnyk8BRRxZg=.cef6f6ff-d62b-4287-bd09-416541b1a862@github.com> Message-ID: <vCCay_pvdMZY0JvFvAizTTRShRFRFunIR19hlDIUjUs=.f928b4ef-c0d9-4b57-82df-b31a790a69d8@github.com> On Tue, 18 Jun 2024 15:31:24 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [472b935b](https://github.com/openjdk/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 18 Jun 2024 and was reviewed by Pavel Rappo. > > The reason of backport is not clean is that, multiple PRs have been merged into the `jdk17u-dev` of this file, including `JDK-8215516`, `JDK-8164597`, etc., and these PRs cannot be directly backported to `jdk11u-dev`. > > This PR also change `test/langtools/TEST.ROOT`, it's partial backport of [JDK-8242652](https://bugs.openjdk.org/browse/JDK-8242652). [JDK-8242652](https://bugs.openjdk.org/browse/JDK-8242652) can't backport to jdk11u-dev, the jdk11u-dev repo dosen't have file `test/langtools/jdk/javadoc/doclet/testSearchScript/TestSearchScript.java`. > > Only change test testcase, the risk is quite very low. > > The change verified on below env: > > - [x] linux non-root user > - [x] linix root user > - [x] windows > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2795#issuecomment-2456001814 From syan at openjdk.org Tue Nov 5 00:59:46 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 00:59:46 GMT Subject: [jdk11u-dev] RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds Message-ID: <5tjzD9DeTZ2ABIkbHeBvk7_7VHGwp2OzeECDvVPsLJw=.ef46ab40-46c1-4425-8a20-c808f8c2c75d@github.com> Hi all, This pull request contains a backport of commit [571c435e](https://github.com/openjdk/jdk/commit/571c435e1a34dcf08fd7545d531c258c9116ea79) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jan Kratochvil on 23 Aug 2023 and was reviewed by Erik Joelsson. Without this PR, the jdk build with --enable-ccache can't generate comments in -XX:+PrintInterpreter, this PR fix the build issue. So I want to backport this PR to jdk11u-dev from jdk22. Thanks! ------------- Commit messages: - Backport 18ea311a328ffba286c72fe9035cb395c187aae9 Changes: https://git.openjdk.org/jdk11u-dev/pull/2960/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2960&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313374 Stats: 14 lines in 1 file changed: 14 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2960.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2960/head:pull/2960 PR: https://git.openjdk.org/jdk11u-dev/pull/2960 From syan at openjdk.org Tue Nov 5 02:06:09 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 02:06:09 GMT Subject: [jdk17u-dev] RFR: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option Message-ID: <Z_NA-cZ7DhxSWhNFgpxNTIDS8GG0wuz7YCHKz_lTjTQ=.df3b0fdc-55ee-4e85-8c5d-124c3d370895@github.com> Hi all, This pull request contains a backport of commit [8bcd4920](https://github.com/openjdk/jdk/commit/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport 8bcd4920f1b03d0ef8e295e53557c629f05ceaa4 Changes: https://git.openjdk.org/jdk17u-dev/pull/3027/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3027&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342681 Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3027.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3027/head:pull/3027 PR: https://git.openjdk.org/jdk17u-dev/pull/3027 From syan at openjdk.org Tue Nov 5 02:07:16 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 02:07:16 GMT Subject: [jdk21u-dev] RFR: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option Message-ID: <txHKcNX3RqqwGgiBOkY4dF5wQpkPN-Us9FMrV-aay6E=.088437be-9ec2-4142-ac67-1b30cdee807c@github.com> Hi all, This pull request contains a backport of commit [8bcd4920](https://github.com/openjdk/jdk/commit/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport 8bcd4920f1b03d0ef8e295e53557c629f05ceaa4 Changes: https://git.openjdk.org/jdk21u-dev/pull/1124/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1124&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342681 Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1124.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1124/head:pull/1124 PR: https://git.openjdk.org/jdk21u-dev/pull/1124 From syan at openjdk.org Tue Nov 5 04:22:51 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 04:22:51 GMT Subject: [jdk21u-dev] RFR: 8306446: java/lang/management/ThreadMXBean/Locks.java transient failures Message-ID: <qCaLH1-JjqIvNsBxjifkdcswDo1cor-bXmfQKUWwHn8=.4789c106-9429-4f77-a3de-49c070013c28@github.com> Hi all, This pull request contains a backport of commit [4ae5a3e3](https://github.com/openjdk/jdk/commit/4ae5a3e39b681bfd001df1483d8a6d1fce0bc7f8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Kevin Walls on 28 Jul 2023 and was reviewed by Chris Plummer and Serguei Spitsyn. Thanks! ------------- Commit messages: - Backport 4ae5a3e39b681bfd001df1483d8a6d1fce0bc7f8 Changes: https://git.openjdk.org/jdk21u-dev/pull/1125/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1125&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306446 Stats: 54 lines in 1 file changed: 31 ins; 1 del; 22 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1125.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1125/head:pull/1125 PR: https://git.openjdk.org/jdk21u-dev/pull/1125 From syan at openjdk.org Tue Nov 5 06:23:34 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 06:23:34 GMT Subject: [jdk21u-dev] RFR: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option In-Reply-To: <txHKcNX3RqqwGgiBOkY4dF5wQpkPN-Us9FMrV-aay6E=.088437be-9ec2-4142-ac67-1b30cdee807c@github.com> References: <txHKcNX3RqqwGgiBOkY4dF5wQpkPN-Us9FMrV-aay6E=.088437be-9ec2-4142-ac67-1b30cdee807c@github.com> Message-ID: <npUR0TCGMpnn8HLko3v2ab0l6juMYqWUs9VBIeiBtVE=.df6aaad0-f15e-4d52-949d-b79885bc5560@github.com> On Tue, 5 Nov 2024 02:00:40 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8bcd4920](https://github.com/openjdk/jdk/commit/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev. > > Thanks! GHA report a failure `wget exited with exit code 4` on linux-x64 at `Get JTReg` stage, seems environmental issue, it's unreleated to this issue. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1124#issuecomment-2456328224 From syan at openjdk.org Tue Nov 5 06:23:39 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 06:23:39 GMT Subject: [jdk17u-dev] RFR: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option In-Reply-To: <Z_NA-cZ7DhxSWhNFgpxNTIDS8GG0wuz7YCHKz_lTjTQ=.df3b0fdc-55ee-4e85-8c5d-124c3d370895@github.com> References: <Z_NA-cZ7DhxSWhNFgpxNTIDS8GG0wuz7YCHKz_lTjTQ=.df3b0fdc-55ee-4e85-8c5d-124c3d370895@github.com> Message-ID: <LwszAnYqzV9KUei_NRP9Z3IYElVWJR4rq_FEVYU2b-4=.851a45ef-3f4d-4261-8267-8081c6dee87e@github.com> On Tue, 5 Nov 2024 02:00:53 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8bcd4920](https://github.com/openjdk/jdk/commit/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev. > > Thanks! GHA report a failure `wget exited with exit code 4` on linux-x64 at `Get JTReg` stage, seems environmental issue, it's unreleated to this issue. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3027#issuecomment-2456327661 From syan at openjdk.org Tue Nov 5 07:32:04 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 07:32:04 GMT Subject: [jdk23u] RFR: 8207908: JMXStatusTest.java fails assertion intermittently Message-ID: <0wIyVGFPnXdRo2zyJaYxzfqTneYIAF19jOPk7CZndHo=.63d488c6-1ee9-4773-aa5f-bc6aca90f4f3@github.com> Hi all, This pull request contains a backport of commit [b7d0eff5](https://github.com/openjdk/jdk/commit/b7d0eff5ad77e338b237773d2fc047eea3d2ac12) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer and Alex Menkov. Thanks! ------------- Commit messages: - Backport b7d0eff5ad77e338b237773d2fc047eea3d2ac12 Changes: https://git.openjdk.org/jdk23u/pull/215/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=215&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8207908 Stats: 9 lines in 2 files changed: 1 ins; 2 del; 6 mod Patch: https://git.openjdk.org/jdk23u/pull/215.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/215/head:pull/215 PR: https://git.openjdk.org/jdk23u/pull/215 From syan at openjdk.org Tue Nov 5 07:32:59 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 07:32:59 GMT Subject: [jdk21u-dev] RFR: 8207908: JMXStatusTest.java fails assertion intermittently Message-ID: <31BSa6_85M--T6yx2_VQfDLBg4g16mgzWWMC-zr7iWs=.47ae8a9f-2160-496b-965d-7738e96cc2b5@github.com> Hi all, This pull request contains a backport of commit [b7d0eff5](https://github.com/openjdk/jdk/commit/b7d0eff5ad77e338b237773d2fc047eea3d2ac12) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer and Alex Menkov. Thanks! ------------- Commit messages: - Backport b7d0eff5ad77e338b237773d2fc047eea3d2ac12 Changes: https://git.openjdk.org/jdk21u-dev/pull/1126/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1126&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8207908 Stats: 9 lines in 2 files changed: 1 ins; 2 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1126.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1126/head:pull/1126 PR: https://git.openjdk.org/jdk21u-dev/pull/1126 From goetz at openjdk.org Tue Nov 5 07:44:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Nov 2024 07:44:39 GMT Subject: [jdk21u-dev] RFR: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option In-Reply-To: <txHKcNX3RqqwGgiBOkY4dF5wQpkPN-Us9FMrV-aay6E=.088437be-9ec2-4142-ac67-1b30cdee807c@github.com> References: <txHKcNX3RqqwGgiBOkY4dF5wQpkPN-Us9FMrV-aay6E=.088437be-9ec2-4142-ac67-1b30cdee807c@github.com> Message-ID: <wiDyqhAocmDfEQqSpdi8q1T5mHvf1JJm1klwwV09fuo=.5df3dddb-23d5-43f4-9f5f-bb4c90f59e4d@github.com> On Tue, 5 Nov 2024 02:00:40 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8bcd4920](https://github.com/openjdk/jdk/commit/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev. > > Thanks! Thanks for fixing this! Our CI stumbled over this failure tonight. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1124#issuecomment-2456446890 From syan at openjdk.org Tue Nov 5 07:46:34 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 07:46:34 GMT Subject: [jdk23u] RFR: 8207908: JMXStatusTest.java fails assertion intermittently In-Reply-To: <0wIyVGFPnXdRo2zyJaYxzfqTneYIAF19jOPk7CZndHo=.63d488c6-1ee9-4773-aa5f-bc6aca90f4f3@github.com> References: <0wIyVGFPnXdRo2zyJaYxzfqTneYIAF19jOPk7CZndHo=.63d488c6-1ee9-4773-aa5f-bc6aca90f4f3@github.com> Message-ID: <31wuLzRtHHv4rsLOrOybUk4OAoHZmAuNC6wAtdVURkg=.c6fb4612-b5aa-45c4-ae29-6099e3fae68c@github.com> On Tue, 5 Nov 2024 07:26:55 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [b7d0eff5](https://github.com/openjdk/jdk/commit/b7d0eff5ad77e338b237773d2fc047eea3d2ac12) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer and Alex Menkov. > > Thanks! GHA report several failures: 1. `linux-x64-optimized /build (debug)` at stage `Get JTReg` fails as `wget exited with exit code 4`, seems like environmental issue, it's unreleatred to this PR. 2. `docs /build (debug)` at stage `Get JTReg` fails as `wget exited with exit code 4`, seems like environmental issue, it's unreleatred to this PR. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/215#issuecomment-2456451033 From mbaesken at openjdk.org Tue Nov 5 07:53:37 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 5 Nov 2024 07:53:37 GMT Subject: [jdk21u-dev] Integrated: 8333728: ubsan: shenandoahFreeSet.cpp:1347:24: runtime error: division by zero In-Reply-To: <zhy3ktwjFfRDnOj7T6_bk6sEDmLURSr9LAGNFz-c4lg=.431f1343-5252-4cf5-b672-c11c93627393@github.com> References: <zhy3ktwjFfRDnOj7T6_bk6sEDmLURSr9LAGNFz-c4lg=.431f1343-5252-4cf5-b672-c11c93627393@github.com> Message-ID: <iMB_R_2wrvAL0r4AvMT8bD1wDWUZrOZ6LDAqqKTHaHc=.71c2a3db-1968-4547-bf55-fbf6feb75be5@github.com> On Mon, 7 Oct 2024 12:04:55 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > Backport of 8333728; loop coding is a little different / diffs in the strides This pull request has now been integrated. Changeset: 34021e99 Author: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/34021e99d55a158637a4e1b7a08fbf804a91c170 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod 8333728: ubsan: shenandoahFreeSet.cpp:1347:24: runtime error: division by zero Reviewed-by: mdoerr, lucy Backport-of: b5575942027281166676678e2081b024ec572644 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1030 From goetz at openjdk.org Tue Nov 5 08:18:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Nov 2024 08:18:28 GMT Subject: [jdk17u-dev] RFR: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe In-Reply-To: <Uc8uuNQKGOU_LE5sfCNAsPsuV2MQkzUt2dLACmYx7jw=.35b6e13c-ecaa-4b58-a99c-30549ec08d8e@github.com> References: <Uc8uuNQKGOU_LE5sfCNAsPsuV2MQkzUt2dLACmYx7jw=.35b6e13c-ecaa-4b58-a99c-30549ec08d8e@github.com> Message-ID: <zx6lh7gokYQzSGM01tTgoXnaTn_ROO9woKrKatghc3w=.ee184a3f-864e-4dc4-bba2-55dfa1932453@github.com> On Mon, 4 Nov 2024 08:55:40 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > Resolved Copyright, probably clean anyways. GHA failure: infra issue, unrelated Error: sh][ERROR] wget exited with exit code 4 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3024#issuecomment-2456507169 From goetz at openjdk.org Tue Nov 5 08:20:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Nov 2024 08:20:37 GMT Subject: [jdk17u-dev] RFR: 8341235: Improve default instruction frame title in PassFailJFrame In-Reply-To: <pvqH32QlLP0VKvyUQF4txTEjgYSmm7tb3bmvUKm9muQ=.2baa0c34-4e7b-4c5a-883a-d93602a9b7e3@github.com> References: <pvqH32QlLP0VKvyUQF4txTEjgYSmm7tb3bmvUKm9muQ=.2baa0c34-4e7b-4c5a-883a-d93602a9b7e3@github.com> Message-ID: <A98p_RzU2gSoZ2aS_m_lGiz5Vi7MW9BYoTLRYJtNd4g=.d4e93aca-b4a1-4eac-baa4-69c4eda2cc95@github.com> On Mon, 4 Nov 2024 09:13:45 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: both infra issue, unrelated Error: sh][ERROR] wget exited with exit code 4 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3026#issuecomment-2456510049 From syan at openjdk.org Tue Nov 5 08:24:28 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 08:24:28 GMT Subject: [jdk21u-dev] RFR: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option In-Reply-To: <wiDyqhAocmDfEQqSpdi8q1T5mHvf1JJm1klwwV09fuo=.5df3dddb-23d5-43f4-9f5f-bb4c90f59e4d@github.com> References: <txHKcNX3RqqwGgiBOkY4dF5wQpkPN-Us9FMrV-aay6E=.088437be-9ec2-4142-ac67-1b30cdee807c@github.com> <wiDyqhAocmDfEQqSpdi8q1T5mHvf1JJm1klwwV09fuo=.5df3dddb-23d5-43f4-9f5f-bb4c90f59e4d@github.com> Message-ID: <87Y2haKcIX7_TDT5LpEnFKj5qJg8OmARQ9jnj83thKg=.dde13f8d-1aae-4866-87fb-eec3b1049d5f@github.com> On Tue, 5 Nov 2024 07:41:47 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > Thanks for fixing this! Our CI stumbled over this failure tonight. Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1124#issuecomment-2456518503 From syan at openjdk.org Tue Nov 5 08:26:33 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 08:26:33 GMT Subject: [jdk17u-dev] RFR: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option In-Reply-To: <Z_NA-cZ7DhxSWhNFgpxNTIDS8GG0wuz7YCHKz_lTjTQ=.df3b0fdc-55ee-4e85-8c5d-124c3d370895@github.com> References: <Z_NA-cZ7DhxSWhNFgpxNTIDS8GG0wuz7YCHKz_lTjTQ=.df3b0fdc-55ee-4e85-8c5d-124c3d370895@github.com> Message-ID: <ZvU9_2A-wiwk-8mFMjoqPTnbpsUuiBC0yAfeNw4FUfo=.8a9b25c3-068d-4472-b5e3-7f9afc3b9ceb@github.com> On Tue, 5 Nov 2024 02:00:53 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8bcd4920](https://github.com/openjdk/jdk/commit/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3027#issuecomment-2456520676 From duke at openjdk.org Tue Nov 5 08:26:33 2024 From: duke at openjdk.org (duke) Date: Tue, 5 Nov 2024 08:26:33 GMT Subject: [jdk17u-dev] RFR: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option In-Reply-To: <Z_NA-cZ7DhxSWhNFgpxNTIDS8GG0wuz7YCHKz_lTjTQ=.df3b0fdc-55ee-4e85-8c5d-124c3d370895@github.com> References: <Z_NA-cZ7DhxSWhNFgpxNTIDS8GG0wuz7YCHKz_lTjTQ=.df3b0fdc-55ee-4e85-8c5d-124c3d370895@github.com> Message-ID: <_U5eTakDiZKlMADF7DO_QUkXiwUH3JUu3x4HFQs3UAk=.ec3da524-39c9-445e-a340-e681ea5f2685@github.com> On Tue, 5 Nov 2024 02:00:53 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8bcd4920](https://github.com/openjdk/jdk/commit/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev. > > Thanks! @sendaoYan Your change (at version 5915222539e9a4f80ba1b8aca111db6adab2968c) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3027#issuecomment-2456522346 From goetz at openjdk.org Tue Nov 5 08:36:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Nov 2024 08:36:35 GMT Subject: [jdk21u-dev] RFR: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() In-Reply-To: <oXGjmxsYM6bWFQ_2aVzfK5sZdiuYMtL9oNUk8glJosQ=.c75109a9-1e28-4e0b-98fd-d78b96bb8af0@github.com> References: <oXGjmxsYM6bWFQ_2aVzfK5sZdiuYMtL9oNUk8glJosQ=.c75109a9-1e28-4e0b-98fd-d78b96bb8af0@github.com> Message-ID: <fOMXLfcIh97I6Ihy4bi_2BfJErTxGKzVQxdIrZf7VQw=.e0bfcbe0-322a-4cf8-8cf6-4576dcdcbbe7@github.com> On Mon, 4 Nov 2024 13:47:36 GMT, Roland Westrelin <roland at openjdk.org> wrote: > clean backport of JDK-8340824 Hi @rwestrel, should we target 21.0.7 as oracle does? This has no coverage in a released version yet and is brand new. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1122#issuecomment-2456542061 From duke at openjdk.org Tue Nov 5 08:41:37 2024 From: duke at openjdk.org (duke) Date: Tue, 5 Nov 2024 08:41:37 GMT Subject: [jdk21u-dev] RFR: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option In-Reply-To: <txHKcNX3RqqwGgiBOkY4dF5wQpkPN-Us9FMrV-aay6E=.088437be-9ec2-4142-ac67-1b30cdee807c@github.com> References: <txHKcNX3RqqwGgiBOkY4dF5wQpkPN-Us9FMrV-aay6E=.088437be-9ec2-4142-ac67-1b30cdee807c@github.com> Message-ID: <EA6wvR4AqI8e1y9OZ2rfEHuNNi45p9Mt4vIh1pyQIl4=.87bb5c2b-ea08-4853-a715-26bdf779d1af@github.com> On Tue, 5 Nov 2024 02:00:40 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8bcd4920](https://github.com/openjdk/jdk/commit/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev. > > Thanks! @sendaoYan Your change (at version a0a1a3d65de070c8e32218c254e9371edb27597b) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1124#issuecomment-2456553154 From syan at openjdk.org Tue Nov 5 08:45:35 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 08:45:35 GMT Subject: [jdk21u-dev] RFR: 8306446: java/lang/management/ThreadMXBean/Locks.java transient failures In-Reply-To: <qCaLH1-JjqIvNsBxjifkdcswDo1cor-bXmfQKUWwHn8=.4789c106-9429-4f77-a3de-49c070013c28@github.com> References: <qCaLH1-JjqIvNsBxjifkdcswDo1cor-bXmfQKUWwHn8=.4789c106-9429-4f77-a3de-49c070013c28@github.com> Message-ID: <wgbWg2WIUdmZnHtGdbG4otn4BsMVZgh9kp4IRrcCUHU=.0ed96976-56bb-4520-a404-af052cd5bb94@github.com> On Tue, 5 Nov 2024 04:18:01 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [4ae5a3e3](https://github.com/openjdk/jdk/commit/4ae5a3e39b681bfd001df1483d8a6d1fce0bc7f8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 28 Jul 2023 and was reviewed by Chris Plummer and Serguei Spitsyn. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1125#issuecomment-2456561182 From duke at openjdk.org Tue Nov 5 08:45:35 2024 From: duke at openjdk.org (duke) Date: Tue, 5 Nov 2024 08:45:35 GMT Subject: [jdk21u-dev] RFR: 8306446: java/lang/management/ThreadMXBean/Locks.java transient failures In-Reply-To: <qCaLH1-JjqIvNsBxjifkdcswDo1cor-bXmfQKUWwHn8=.4789c106-9429-4f77-a3de-49c070013c28@github.com> References: <qCaLH1-JjqIvNsBxjifkdcswDo1cor-bXmfQKUWwHn8=.4789c106-9429-4f77-a3de-49c070013c28@github.com> Message-ID: <Ry4M5TW1JmzlFHU2VByq2M12cam76ag9D4p0mesRk1o=.32d61d10-e9dc-458b-9002-3a2bc5c46041@github.com> On Tue, 5 Nov 2024 04:18:01 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [4ae5a3e3](https://github.com/openjdk/jdk/commit/4ae5a3e39b681bfd001df1483d8a6d1fce0bc7f8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 28 Jul 2023 and was reviewed by Chris Plummer and Serguei Spitsyn. > > Thanks! @sendaoYan Your change (at version 0c953dfa40c3f849ff616f5ca0d49e91b5f614ba) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1125#issuecomment-2456562147 From goetz at openjdk.org Tue Nov 5 08:50:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Nov 2024 08:50:13 GMT Subject: [jdk21u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project [v2] In-Reply-To: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> References: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> Message-ID: <C_XZ6gGPforlvOQK1gcpX_oIzS8Pno1gjeQe_nBQjzc=.971f25fc-c74e-4261-bed8-09324d14e812@github.com> > Customize the README.md to jdk21u. > > Plan is to backport this to 17 and maybe older jdks and adapt the paths etc correspondingly. > So let?s keep this sufficiently generic so that the information holds for jdkXu and jdkXu-dev > and that the change can easily be backported (by adapting 21->17 etc). > > Should we put there more information? Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Apply suggestions from code review Add changes proposed by Christoph. Co-authored-by: Christoph Langer <christoph.langer at sap.com> ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1118/files - new: https://git.openjdk.org/jdk21u-dev/pull/1118/files/2f063d19..bc062ce9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1118&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1118&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1118.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1118/head:pull/1118 PR: https://git.openjdk.org/jdk21u-dev/pull/1118 From roland at openjdk.org Tue Nov 5 08:56:33 2024 From: roland at openjdk.org (Roland Westrelin) Date: Tue, 5 Nov 2024 08:56:33 GMT Subject: [jdk21u-dev] RFR: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() In-Reply-To: <fOMXLfcIh97I6Ihy4bi_2BfJErTxGKzVQxdIrZf7VQw=.e0bfcbe0-322a-4cf8-8cf6-4576dcdcbbe7@github.com> References: <oXGjmxsYM6bWFQ_2aVzfK5sZdiuYMtL9oNUk8glJosQ=.c75109a9-1e28-4e0b-98fd-d78b96bb8af0@github.com> <fOMXLfcIh97I6Ihy4bi_2BfJErTxGKzVQxdIrZf7VQw=.e0bfcbe0-322a-4cf8-8cf6-4576dcdcbbe7@github.com> Message-ID: <b5KXPVT-Rmp1TAjK1uExT_Rvauy5QqEAEkPQ0Jdb99s=.c8e769ad-a4b1-4a91-842a-6d7898dffd44@github.com> On Tue, 5 Nov 2024 08:33:45 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> clean backport of JDK-8340824 > > Hi @rwestrel, should we target 21.0.7 as oracle does? This has no coverage in a released version yet and is brand new. @GoeLin that would be fine with me. What would be the process then? Do I need to close this one for now and re-apply for approval later on? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1122#issuecomment-2456584021 From syan at openjdk.org Tue Nov 5 09:53:29 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 09:53:29 GMT Subject: [jdk21u-dev] RFR: 8306446: java/lang/management/ThreadMXBean/Locks.java transient failures In-Reply-To: <qCaLH1-JjqIvNsBxjifkdcswDo1cor-bXmfQKUWwHn8=.4789c106-9429-4f77-a3de-49c070013c28@github.com> References: <qCaLH1-JjqIvNsBxjifkdcswDo1cor-bXmfQKUWwHn8=.4789c106-9429-4f77-a3de-49c070013c28@github.com> Message-ID: <EIvb9y4kDBEuzbYZ4WU_ZVC71XTYIQd-7C8EWFRWAa8=.f47bc000-f2d3-4bf6-a443-93abb4c6719b@github.com> On Tue, 5 Nov 2024 04:18:01 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [4ae5a3e3](https://github.com/openjdk/jdk/commit/4ae5a3e39b681bfd001df1483d8a6d1fce0bc7f8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 28 Jul 2023 and was reviewed by Chris Plummer and Serguei Spitsyn. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1125#issuecomment-2456714219 From syan at openjdk.org Tue Nov 5 09:53:30 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 09:53:30 GMT Subject: [jdk21u-dev] Integrated: 8306446: java/lang/management/ThreadMXBean/Locks.java transient failures In-Reply-To: <qCaLH1-JjqIvNsBxjifkdcswDo1cor-bXmfQKUWwHn8=.4789c106-9429-4f77-a3de-49c070013c28@github.com> References: <qCaLH1-JjqIvNsBxjifkdcswDo1cor-bXmfQKUWwHn8=.4789c106-9429-4f77-a3de-49c070013c28@github.com> Message-ID: <KQr7jovvSmWKj2I4SW1GMFvB_Wpn2BNjI-izjzAmEc4=.b6cafa38-8668-47eb-8ca6-fe430a89d580@github.com> On Tue, 5 Nov 2024 04:18:01 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [4ae5a3e3](https://github.com/openjdk/jdk/commit/4ae5a3e39b681bfd001df1483d8a6d1fce0bc7f8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 28 Jul 2023 and was reviewed by Chris Plummer and Serguei Spitsyn. > > Thanks! This pull request has now been integrated. Changeset: 6b4be014 Author: SendaoYan <syan at openjdk.org> Committer: Kevin Walls <kevinw at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/6b4be0148a80feaa790b08cc4b232b4b3017bbec Stats: 54 lines in 1 file changed: 31 ins; 1 del; 22 mod 8306446: java/lang/management/ThreadMXBean/Locks.java transient failures Backport-of: 4ae5a3e39b681bfd001df1483d8a6d1fce0bc7f8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1125 From sgehwolf at openjdk.org Tue Nov 5 10:20:33 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 5 Nov 2024 10:20:33 GMT Subject: [jdk21u-dev] RFR: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() In-Reply-To: <fOMXLfcIh97I6Ihy4bi_2BfJErTxGKzVQxdIrZf7VQw=.e0bfcbe0-322a-4cf8-8cf6-4576dcdcbbe7@github.com> References: <oXGjmxsYM6bWFQ_2aVzfK5sZdiuYMtL9oNUk8glJosQ=.c75109a9-1e28-4e0b-98fd-d78b96bb8af0@github.com> <fOMXLfcIh97I6Ihy4bi_2BfJErTxGKzVQxdIrZf7VQw=.e0bfcbe0-322a-4cf8-8cf6-4576dcdcbbe7@github.com> Message-ID: <MvtVIJFgnx5x1z2m2k0OCmxvskxL40AqjuMk5zhRymg=.cc0bab4d-026a-4e8b-b482-3f677e190917@github.com> On Tue, 5 Nov 2024 08:33:45 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> clean backport of JDK-8340824 > > Hi @rwestrel, should we target 21.0.7 as oracle does? This has no coverage in a released version yet and is brand new. > @GoeLin that would be fine with me. What would be the process then? Do I need to close this one for now and re-apply for approval later on? Not G?tz, but you can keep the PR open and we'll approve once 21.0.7 development opens. At that point the PR would move to the ready state. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1122#issuecomment-2456774981 From mdoerr at openjdk.org Tue Nov 5 10:35:28 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 5 Nov 2024 10:35:28 GMT Subject: [jdk21u-dev] RFR: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory In-Reply-To: <rwyUPl4cGRW2spxtJE62X5_PmMOOqFCBp2La19tGa5M=.a30df0e2-7db8-4354-b9a2-71225ce52559@github.com> References: <rwyUPl4cGRW2spxtJE62X5_PmMOOqFCBp2La19tGa5M=.a30df0e2-7db8-4354-b9a2-71225ce52559@github.com> Message-ID: <vzoMR17I-DKE2JC5wU2uHNW4B5VS_UYezEQUyWfC-Bo=.4d634617-6919-4aa2-a8df-4d70a784522c@github.com> On Mon, 4 Nov 2024 18:07:40 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: > Almost clean backport of [JDK-8343205](https://bugs.openjdk.org/browse/JDK-8343205). I have included `get_c1_thread_count()` and `get_c2_thread_count()` from [JDK-8317562](https://bugs.openjdk.org/browse/JDK-8317562) (see 2nd commit). Thanks for the review! GHA failure is unrelated: wget exited with exit code 4 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1123#issuecomment-2456810525 From mbaesken at openjdk.org Tue Nov 5 11:18:32 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 5 Nov 2024 11:18:32 GMT Subject: [jdk23u] RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang In-Reply-To: <W---agxTqxo1_pGJveYu1DJZOVtqWk3t3hyCjyajZwk=.594eb5cc-6e75-4a0a-883d-0f8454eb48a9@github.com> References: <W---agxTqxo1_pGJveYu1DJZOVtqWk3t3hyCjyajZwk=.594eb5cc-6e75-4a0a-883d-0f8454eb48a9@github.com> Message-ID: <2Ag5smyIeLKtYv5BRI-vWD883beqVEZHIdjsB2-7RK4=.1dee4cb8-b7fa-4261-bbaf-e784870f28f1@github.com> On Mon, 4 Nov 2024 15:28:00 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > Backport of 8341722, changes of Lib.gmk are not in 23u so I omit those; otherwise applied clean. Hi Christoph, thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/213#issuecomment-2456898474 From sgehwolf at redhat.com Tue Nov 5 13:11:26 2024 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Tue, 05 Nov 2024 14:11:26 +0100 Subject: Result: New JDK Updates Committer: Sendao Yan Message-ID: <e8a2eabb0acf99382dabb69dd4c84aa6eb616b8b.camel@redhat.com> Voting for Sendao Yan [1] is now closed. Yes: 9 Veto: 0 Abstain: 0 According to the bylaws' definition of Three-Vote Consensus[2], this is sufficient to approve the nomination. Thanks, Severin [1] https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-October/038550.html [2] http://openjdk.java.net/bylaws#three-vote-consensus From goetz at openjdk.org Tue Nov 5 13:44:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Nov 2024 13:44:31 GMT Subject: [jdk21u-dev] Integrated: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files In-Reply-To: <PuKyfW7LUlrIDyksexnHjfMOti5wDfvTTgFEkHDi4O4=.290d09ad-15ae-4cae-8b10-c056c5765a45@github.com> References: <PuKyfW7LUlrIDyksexnHjfMOti5wDfvTTgFEkHDi4O4=.290d09ad-15ae-4cae-8b10-c056c5765a45@github.com> Message-ID: <YCtohZPATd788_6lmHjZwm-dgn2joWmW5443UYmbRCc=.a0ac71b8-fc3c-4779-8ac8-a02e38e7f161@github.com> On Thu, 31 Oct 2024 09:04:25 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > Omitted edit in CLDRConverter.java. The modified method was > introduced by "8317979: Use TZ database style abbreviations in the CLDR locale provider" > which is a preparatory change for "8174269 Remove COMPAT locale data provider from JDK". > Both are not candidates for backport. This pull request has now been integrated. Changeset: f4940f65 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/f4940f65f8908602e2043caaf1141150be865acc Stats: 20 lines in 3 files changed: 4 ins; 0 del; 16 mod 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files Reviewed-by: mbaesken Backport-of: 35a94b769761bd923fe6db03be672f05c1a74c38 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1113 From goetz at openjdk.org Tue Nov 5 13:45:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Nov 2024 13:45:42 GMT Subject: [jdk21u-dev] Integrated: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe In-Reply-To: <YhAVrB7hf-Eofv270Qro78wELfP6JD1HJ1pDeqxx49g=.6a87e25b-7c49-476d-af0f-46b9193b51d1@github.com> References: <YhAVrB7hf-Eofv270Qro78wELfP6JD1HJ1pDeqxx49g=.6a87e25b-7c49-476d-af0f-46b9193b51d1@github.com> Message-ID: <UYGOrhqQngXpGWlGPTuNTvxy6TghrQYLVGONqWtF0vk=.238741be-b29d-4291-8717-a21ee27ae798@github.com> On Mon, 4 Nov 2024 08:52:44 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: d7c2775a Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/d7c2775a1eb12903ebec262e1d6b3ddc7564532c Stats: 73 lines in 2 files changed: 70 ins; 1 del; 2 mod 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe Backport-of: 47c10694c66bc131c8a5e1572340415b8daaba08 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1119 From goetz at openjdk.org Tue Nov 5 13:46:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Nov 2024 13:46:31 GMT Subject: [jdk21u-dev] Integrated: 8340799: Add border inside instruction frame in PassFailJFrame In-Reply-To: <9JIn656tDI4qQgi3z0JL66y1Sp3ojumtDlUKKXQnhD8=.8b981281-bf44-4ab4-9529-7df8bc265d1f@github.com> References: <9JIn656tDI4qQgi3z0JL66y1Sp3ojumtDlUKKXQnhD8=.8b981281-bf44-4ab4-9529-7df8bc265d1f@github.com> Message-ID: <gquMsP3ia2XcW-6dZBPkxjmWdwAyPxMHD25M2tlZpao=.afe2bfe7-9495-4798-bc75-15edb6dba1e1@github.com> On Mon, 4 Nov 2024 09:11:35 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 498252fe Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/498252fe73c548d5af2914615d70247de9f95f37 Stats: 47 lines in 1 file changed: 34 ins; 0 del; 13 mod 8340799: Add border inside instruction frame in PassFailJFrame Backport-of: 520060f79a3cedb8f93e6bbd0e9b2823eaabf79a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1120 From goetz at openjdk.org Tue Nov 5 13:47:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Nov 2024 13:47:40 GMT Subject: [jdk21u-dev] Integrated: 8341235: Improve default instruction frame title in PassFailJFrame In-Reply-To: <Iz6I8d-HeIF4i3eOgjQ-HQ7OR2JgL2A4KaVX8Tkpawc=.a1d3704e-85d4-42e9-9fbe-ad40c53b20b2@github.com> References: <Iz6I8d-HeIF4i3eOgjQ-HQ7OR2JgL2A4KaVX8Tkpawc=.a1d3704e-85d4-42e9-9fbe-ad40c53b20b2@github.com> Message-ID: <yGSDBqQKyqDBIJJMDaqV6FnG4rYZE_p_aDi_zjDTwFw=.fcff3d15-8e0d-476e-b7b5-3fc8836ffb29@github.com> On Mon, 4 Nov 2024 09:12:24 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 9ce77a2f Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/9ce77a2f0af3f5d210f1b897aaf4c9ca77984b71 Stats: 42 lines in 1 file changed: 39 ins; 0 del; 3 mod 8341235: Improve default instruction frame title in PassFailJFrame Backport-of: 4ba170c403ae85576f84dafd4a157ba0db99873f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1121 From goetz at openjdk.org Tue Nov 5 13:48:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Nov 2024 13:48:43 GMT Subject: [jdk17u-dev] Integrated: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe In-Reply-To: <Uc8uuNQKGOU_LE5sfCNAsPsuV2MQkzUt2dLACmYx7jw=.35b6e13c-ecaa-4b58-a99c-30549ec08d8e@github.com> References: <Uc8uuNQKGOU_LE5sfCNAsPsuV2MQkzUt2dLACmYx7jw=.35b6e13c-ecaa-4b58-a99c-30549ec08d8e@github.com> Message-ID: <-_mIkeRHBDqBsE10CamLmQzEanJSEECYhHkVr3AtFwg=.ffe9149b-f0ae-4a19-a569-7659810341d9@github.com> On Mon, 4 Nov 2024 08:55:40 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > Resolved Copyright, probably clean anyways. This pull request has now been integrated. Changeset: d1be3c9f Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/d1be3c9ff3e21c3c2688432835f1b3bcc51142f7 Stats: 73 lines in 2 files changed: 70 ins; 1 del; 2 mod 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe Backport-of: 47c10694c66bc131c8a5e1572340415b8daaba08 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3024 From goetz at openjdk.org Tue Nov 5 13:49:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Nov 2024 13:49:37 GMT Subject: [jdk17u-dev] Integrated: 8340799: Add border inside instruction frame in PassFailJFrame In-Reply-To: <z4W2X4urh5fbepehEedkplcc--iyzGh1T3pEwqNyVaM=.b123a1f1-b7f2-4eb8-9029-a97d981895e7@github.com> References: <z4W2X4urh5fbepehEedkplcc--iyzGh1T3pEwqNyVaM=.b123a1f1-b7f2-4eb8-9029-a97d981895e7@github.com> Message-ID: <N-wnrvR8bv6touQAjT5bOm70farqKn3IRKh81QOefDo=.59cb276c-bded-4c9f-9421-dfde1dd7a0fa@github.com> On Mon, 4 Nov 2024 09:11:51 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle This pull request has now been integrated. Changeset: eb464423 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/eb464423f2b8614a5e2401375a7a8985a555c07a Stats: 47 lines in 1 file changed: 34 ins; 0 del; 13 mod 8340799: Add border inside instruction frame in PassFailJFrame Backport-of: 520060f79a3cedb8f93e6bbd0e9b2823eaabf79a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3025 From goetz at openjdk.org Tue Nov 5 13:50:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Nov 2024 13:50:36 GMT Subject: [jdk17u-dev] Integrated: 8341235: Improve default instruction frame title in PassFailJFrame In-Reply-To: <pvqH32QlLP0VKvyUQF4txTEjgYSmm7tb3bmvUKm9muQ=.2baa0c34-4e7b-4c5a-883a-d93602a9b7e3@github.com> References: <pvqH32QlLP0VKvyUQF4txTEjgYSmm7tb3bmvUKm9muQ=.2baa0c34-4e7b-4c5a-883a-d93602a9b7e3@github.com> Message-ID: <KkCxn74ZMUUSpefvbCBuKmaPK6wvzuSMStijdj9YSKg=.f355a531-94af-433b-9192-52073862882d@github.com> On Mon, 4 Nov 2024 09:13:45 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: b0c75b45 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/b0c75b453345ad7b23751788771c4fd38e919b33 Stats: 42 lines in 1 file changed: 39 ins; 0 del; 3 mod 8341235: Improve default instruction frame title in PassFailJFrame Backport-of: 4ba170c403ae85576f84dafd4a157ba0db99873f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3026 From goetz at openjdk.org Tue Nov 5 13:57:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Nov 2024 13:57:45 GMT Subject: [jdk17u-dev] RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files Message-ID: <7WidG5JWFvitScTXyG1gTIc1qeDs2eX6wnpZjysX8E4=.eefa1281-4db5-4149-a00c-17cb5e274ece@github.com> I backport this for parity with 17.0.14-oracle. Clean backport from 21. ------------- Commit messages: - Backport f4940f65f8908602e2043caaf1141150be865acc Changes: https://git.openjdk.org/jdk17u-dev/pull/3028/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3028&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339803 Stats: 20 lines in 3 files changed: 4 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3028.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3028/head:pull/3028 PR: https://git.openjdk.org/jdk17u-dev/pull/3028 From dcherepanov at openjdk.org Tue Nov 5 15:51:52 2024 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Tue, 5 Nov 2024 15:51:52 GMT Subject: [jdk11u-dev] RFR: 8301118: Ignore allow and disallow options for java.security.manager System Property In-Reply-To: <hSz7rfqJF1iySUR0CeMSDql72dgZq818bvDTOoArsxs=.b8aa5b9c-222f-4250-bd10-2350fde48cec@github.com> References: <qeVqpJvHZH6t3mrXv5FYbzgErhRdTyTF7w3AF2sy5pY=.afe2c97e-9602-431e-8b19-88f113a1a6d1@github.com> <hSz7rfqJF1iySUR0CeMSDql72dgZq818bvDTOoArsxs=.b8aa5b9c-222f-4250-bd10-2350fde48cec@github.com> Message-ID: <7iNMgHOz9MtyNaCmpUPyZEcnpiA0deI-0qcHpGFIIh8=.e30a48af-a7f6-470d-8d43-3d4b2fba2393@github.com> On Mon, 4 Nov 2024 23:21:46 GMT, Paul Hohensee <phh at openjdk.org> wrote: >> Proposing the change for parity with Oracle (fixed in 11.0.21-oracle). >> >> The change isn't a backport and it's implemented according to the description of https://bugs.openjdk.org/browse/JDK-8301118. New allow/disallow options for the java.security.manager system property should be ignored in JDK11. >> >> New test fails without the change and passes with the change. > > Change lgtm, would be good to check Oracle 11u to see whether it issues a warning. > > The OSX build failures appear unrelated but should be addressed in a different PR. @phohensee Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2932#issuecomment-2457539455 From duke at openjdk.org Tue Nov 5 16:57:40 2024 From: duke at openjdk.org (Saint Wesonga) Date: Tue, 5 Nov 2024 16:57:40 GMT Subject: [jdk23u] RFR: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set In-Reply-To: <PLkHcKiZo_fBJAiyoTuEFb1IzWzxg70USzGM42VvHkE=.e56eb430-8fcc-42d0-ae22-da83a03c596e@github.com> References: <PLkHcKiZo_fBJAiyoTuEFb1IzWzxg70USzGM42VvHkE=.e56eb430-8fcc-42d0-ae22-da83a03c596e@github.com> Message-ID: <HlueUUewMgy8I0R8uUjhK1A-BxIvr8dWmPZi5O2v8RE=.bd399903-e345-4183-9207-8396c7cfc1d9@github.com> On Sat, 19 Oct 2024 17:50:53 GMT, Saint Wesonga <duke at openjdk.org> wrote: > Backport https://github.com/openjdk/jdk/commit/5bf27098e22172ed5d3ec0c43fe0553f8322c4b1 to jdk23u. UnsafeIntrinsicsTest.java#ZGenerationalDebug test now passes on Windows AArch64 with this change. Hi @stefank, are you able to review this jdk23u backport of https://github.com/openjdk/jdk/pull/20390 as well? ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/198#issuecomment-2457700111 From phh at openjdk.org Tue Nov 5 17:02:37 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 5 Nov 2024 17:02:37 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v2] In-Reply-To: <bX_isycwgNMnBwm2FpfH7Y1YfHCd_uWGOt8cKb5rSlE=.380e649c-a8d8-4a7e-95e8-140804e89c5c@github.com> References: <Nm9nt3ihKhACiDQgVwXSrcEDnd-HkyBTBJPU_cv2DDs=.714d8254-9859-4393-b0b2-1c6cb67d4379@github.com> <bX_isycwgNMnBwm2FpfH7Y1YfHCd_uWGOt8cKb5rSlE=.380e649c-a8d8-4a7e-95e8-140804e89c5c@github.com> Message-ID: <6XnuRsFDFHNl27zoXvVdwQnBvkIhYQdABEPRCAts0AY=.087e93a8-7eab-45a2-9296-5742b2c4f968@github.com> On Thu, 17 Oct 2024 10:55:17 GMT, Taizo Kurashige <duke at openjdk.org> wrote: >> Hi, >> >> This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts >> >> Original patch does not apply cleanly for the following reasons: >> >> ?Fix to getOsMap() in test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied since getOsMap() was removed in https://bugs.openjdk.org/browse/JDK-8331700. >> ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in [https://bugs.openjdk.org/browse/JDK-8220753](https://bugs.openjdk.org/browse/JDK-8220753%28jdk13%29) (jdk13). >> ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed in https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. >> >> Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing >> >> Thanks. > > Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-8296631 > - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 > - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2955#pullrequestreview-2416217940 From stefank at openjdk.org Tue Nov 5 17:10:40 2024 From: stefank at openjdk.org (Stefan Karlsson) Date: Tue, 5 Nov 2024 17:10:40 GMT Subject: [jdk23u] RFR: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set In-Reply-To: <PLkHcKiZo_fBJAiyoTuEFb1IzWzxg70USzGM42VvHkE=.e56eb430-8fcc-42d0-ae22-da83a03c596e@github.com> References: <PLkHcKiZo_fBJAiyoTuEFb1IzWzxg70USzGM42VvHkE=.e56eb430-8fcc-42d0-ae22-da83a03c596e@github.com> Message-ID: <Bh4mtNLOPZPPDsgZEExMoR6ArNT9vduD8MdVbOL7AEg=.3a87039a-4314-4fcf-8172-af4fb4e4d2f0@github.com> On Sat, 19 Oct 2024 17:50:53 GMT, Saint Wesonga <duke at openjdk.org> wrote: > Backport https://github.com/openjdk/jdk/commit/5bf27098e22172ed5d3ec0c43fe0553f8322c4b1 to jdk23u. UnsafeIntrinsicsTest.java#ZGenerationalDebug test now passes on Windows AArch64 with this change. Looks like a correct backport to me. ------------- Marked as reviewed by stefank (Reviewer). PR Review: https://git.openjdk.org/jdk23u/pull/198#pullrequestreview-2416236409 From duke at openjdk.org Tue Nov 5 17:23:29 2024 From: duke at openjdk.org (duke) Date: Tue, 5 Nov 2024 17:23:29 GMT Subject: [jdk23u] RFR: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set In-Reply-To: <PLkHcKiZo_fBJAiyoTuEFb1IzWzxg70USzGM42VvHkE=.e56eb430-8fcc-42d0-ae22-da83a03c596e@github.com> References: <PLkHcKiZo_fBJAiyoTuEFb1IzWzxg70USzGM42VvHkE=.e56eb430-8fcc-42d0-ae22-da83a03c596e@github.com> Message-ID: <4XccJcRmVrdDsm9VYRxRhA4QkCMxJqrd4yyV23sU1f0=.d8d431eb-efa8-4862-ae49-e75239528d89@github.com> On Sat, 19 Oct 2024 17:50:53 GMT, Saint Wesonga <duke at openjdk.org> wrote: > Backport https://github.com/openjdk/jdk/commit/5bf27098e22172ed5d3ec0c43fe0553f8322c4b1 to jdk23u. UnsafeIntrinsicsTest.java#ZGenerationalDebug test now passes on Windows AArch64 with this change. @swesonga Your change (at version 08d142e5e1263539c0aba4bfadbec6297ed0561b) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/198#issuecomment-2457759071 From cushon at openjdk.org Tue Nov 5 18:49:17 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 5 Nov 2024 18:49:17 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> References: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> Message-ID: <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> > This change improves annotation processing test coverage, see [JDK-8336942](https://bugs.openjdk.org/browse/JDK-8336942). I resolved a trivial merge conflict with JDK-8323684, which added the `nameToAnnotation` map. The modified test passes. Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 - 8336942: Improve test coverage for class loading elements with annotations of different retentions Reviewed-by: vromero ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2955/files - new: https://git.openjdk.org/jdk17u-dev/pull/2955/files/6592b5ab..8d083450 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2955&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2955&range=00-01 Stats: 11904 lines in 742 files changed: 7550 ins; 1877 del; 2477 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2955.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2955/head:pull/2955 PR: https://git.openjdk.org/jdk17u-dev/pull/2955 From cushon at openjdk.org Tue Nov 5 18:52:53 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 5 Nov 2024 18:52:53 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> References: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> Message-ID: <m2-qk0i2t5yMjwx3TmlfMZCewIldJRBn1HttVwBT8XY=.263020ce-bafe-4fc9-a8ad-5662b395bec7@github.com> On Tue, 5 Nov 2024 18:49:17 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote: >> This change improves annotation processing test coverage, see [JDK-8336942](https://bugs.openjdk.org/browse/JDK-8336942). I resolved a trivial merge conflict with JDK-8323684, which added the `nameToAnnotation` map. The modified test passes. > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 > - 8336942: Improve test coverage for class loading elements with annotations of different retentions > > Reviewed-by: vromero Please keep this open for now ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2457923366 From cushon at openjdk.org Tue Nov 5 18:53:41 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 5 Nov 2024 18:53:41 GMT Subject: [jdk21u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <mTBEOPqFvDuQf13u24iXB65OuyE1Sz3Uy6_I0Ow8Vxo=.1d4ad8b1-1544-45b5-8375-9038cbb2f2bd@github.com> References: <mTBEOPqFvDuQf13u24iXB65OuyE1Sz3Uy6_I0Ow8Vxo=.1d4ad8b1-1544-45b5-8375-9038cbb2f2bd@github.com> Message-ID: <1A8Pjqodey4brM-cndhW3u6TUyNDzospAEl8UmaGdN0=.8536dd69-12ea-445b-8fae-35ae640f02cb@github.com> > This change improves annotation processing test coverage, see [JDK-8336942](https://bugs.openjdk.org/browse/JDK-8336942). I resolved a trivial merge conflict with JDK-8323684, which added the `nameToAnnotation` map. The modified test passes. Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 - 8336942: Improve test coverage for class loading elements with annotations of different retentions Reviewed-by: vromero ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1037/files - new: https://git.openjdk.org/jdk21u-dev/pull/1037/files/d059d1b6..3729338f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1037&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1037&range=00-01 Stats: 18349 lines in 211 files changed: 15995 ins; 1318 del; 1036 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1037.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1037/head:pull/1037 PR: https://git.openjdk.org/jdk21u-dev/pull/1037 From syan at openjdk.org Tue Nov 5 19:20:38 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 19:20:38 GMT Subject: [jdk17u-dev] Integrated: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option In-Reply-To: <Z_NA-cZ7DhxSWhNFgpxNTIDS8GG0wuz7YCHKz_lTjTQ=.df3b0fdc-55ee-4e85-8c5d-124c3d370895@github.com> References: <Z_NA-cZ7DhxSWhNFgpxNTIDS8GG0wuz7YCHKz_lTjTQ=.df3b0fdc-55ee-4e85-8c5d-124c3d370895@github.com> Message-ID: <A_m-mdhUN8UGNH391s0WuLAVWkJMK25P2yUTnYyYkgk=.d985befb-f3a5-443a-a1d4-6482d29576df@github.com> On Tue, 5 Nov 2024 02:00:53 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8bcd4920](https://github.com/openjdk/jdk/commit/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: 5819d91f Author: SendaoYan <syan at openjdk.org> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/5819d91f83a84050b7b7dc5e349efa26638db863 Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option Backport-of: 8bcd4920f1b03d0ef8e295e53557c629f05ceaa4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3027 From syan at openjdk.org Tue Nov 5 19:23:40 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Nov 2024 19:23:40 GMT Subject: [jdk21u-dev] Integrated: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option In-Reply-To: <txHKcNX3RqqwGgiBOkY4dF5wQpkPN-Us9FMrV-aay6E=.088437be-9ec2-4142-ac67-1b30cdee807c@github.com> References: <txHKcNX3RqqwGgiBOkY4dF5wQpkPN-Us9FMrV-aay6E=.088437be-9ec2-4142-ac67-1b30cdee807c@github.com> Message-ID: <Ik_IQayd9js5HhzuHq5VNEXq0VxxQEizHQmM32Q6lzM=.df3b1a7e-9d02-40e6-b4ff-cc6ed33b36b5@github.com> On Tue, 5 Nov 2024 02:00:40 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8bcd4920](https://github.com/openjdk/jdk/commit/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: bb60a427 Author: SendaoYan <syan at openjdk.org> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/bb60a427d7b9bc8b33091daa7d7e4a37256f93bc Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option Backport-of: 8bcd4920f1b03d0ef8e295e53557c629f05ceaa4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1124 From duke at openjdk.org Tue Nov 5 19:24:32 2024 From: duke at openjdk.org (Saint Wesonga) Date: Tue, 5 Nov 2024 19:24:32 GMT Subject: [jdk23u] Integrated: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set In-Reply-To: <PLkHcKiZo_fBJAiyoTuEFb1IzWzxg70USzGM42VvHkE=.e56eb430-8fcc-42d0-ae22-da83a03c596e@github.com> References: <PLkHcKiZo_fBJAiyoTuEFb1IzWzxg70USzGM42VvHkE=.e56eb430-8fcc-42d0-ae22-da83a03c596e@github.com> Message-ID: <utjzlEpzN55JXxjHZXfZw70qePiGJq1xE5K91vqN0e0=.7812c363-0d92-4be6-aefa-e2d7f6bf5aa4@github.com> On Sat, 19 Oct 2024 17:50:53 GMT, Saint Wesonga <duke at openjdk.org> wrote: > Backport https://github.com/openjdk/jdk/commit/5bf27098e22172ed5d3ec0c43fe0553f8322c4b1 to jdk23u. UnsafeIntrinsicsTest.java#ZGenerationalDebug test now passes on Windows AArch64 with this change. This pull request has now been integrated. Changeset: 7f189a59 Author: Saint Wesonga <saint.wesonga at microsoft.com> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk23u/commit/7f189a59d9ad803aee72565bc46a817d3f46f2e5 Stats: 59 lines in 1 file changed: 19 ins; 36 del; 4 mod 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set Reviewed-by: stefank Backport-of: 5bf27098e22172ed5d3ec0c43fe0553f8322c4b1 ------------- PR: https://git.openjdk.org/jdk23u/pull/198 From syan at openjdk.org Wed Nov 6 01:18:36 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 6 Nov 2024 01:18:36 GMT Subject: [jdk17u-dev] RFR: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option In-Reply-To: <Z_NA-cZ7DhxSWhNFgpxNTIDS8GG0wuz7YCHKz_lTjTQ=.df3b0fdc-55ee-4e85-8c5d-124c3d370895@github.com> References: <Z_NA-cZ7DhxSWhNFgpxNTIDS8GG0wuz7YCHKz_lTjTQ=.df3b0fdc-55ee-4e85-8c5d-124c3d370895@github.com> Message-ID: <d6AbtxGvBIIDwPUOHTtpDd8fQn8tY-2jSnNo5D9SOuE=.a1d5e46e-0b6c-484d-8d17-47f9a6999461@github.com> On Tue, 5 Nov 2024 02:00:53 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8bcd4920](https://github.com/openjdk/jdk/commit/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3027#issuecomment-2458509856 From syan at openjdk.org Wed Nov 6 01:51:10 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 6 Nov 2024 01:51:10 GMT Subject: [jdk23u] RFR: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags Message-ID: <v62xJP4t60KMpQIAmvQMMKGbFciWTOmkX0pCRCSHFAc=.2b23870d-0bed-476b-8410-7e951bb13ee2@github.com> Hi all, This pull request contains a backport of commit [5e021cbc](https://github.com/openjdk/jdk/commit/5e021cbcc7a6cb30a27380950e115ff12846239c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Leonid Mesnik on 7 Aug 2024 and was reviewed by Magnus Ihse Bursie. Thanks! ------------- Commit messages: - Backport 5e021cbcc7a6cb30a27380950e115ff12846239c Changes: https://git.openjdk.org/jdk23u/pull/216/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=216&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337410 Stats: 33 lines in 1 file changed: 30 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/216.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/216/head:pull/216 PR: https://git.openjdk.org/jdk23u/pull/216 From syan at openjdk.org Wed Nov 6 01:52:01 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 6 Nov 2024 01:52:01 GMT Subject: [jdk21u-dev] RFR: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags Message-ID: <V2U1Oxd9VoavOLmLw28Ya_faaSHh3FAq-AWPJY25SGM=.23d37d48-8623-4144-abd4-d0924f69efa5@github.com> Hi all, This pull request contains a backport of commit [5e021cbc](https://github.com/openjdk/jdk/commit/5e021cbcc7a6cb30a27380950e115ff12846239c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Leonid Mesnik on 7 Aug 2024 and was reviewed by Magnus Ihse Bursie. Thanks! ------------- Commit messages: - Backport 5e021cbcc7a6cb30a27380950e115ff12846239c Changes: https://git.openjdk.org/jdk21u-dev/pull/1128/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1128&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337410 Stats: 33 lines in 1 file changed: 30 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1128.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1128/head:pull/1128 PR: https://git.openjdk.org/jdk21u-dev/pull/1128 From syan at openjdk.org Wed Nov 6 02:05:29 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 6 Nov 2024 02:05:29 GMT Subject: [jdk21u-dev] RFR: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option In-Reply-To: <txHKcNX3RqqwGgiBOkY4dF5wQpkPN-Us9FMrV-aay6E=.088437be-9ec2-4142-ac67-1b30cdee807c@github.com> References: <txHKcNX3RqqwGgiBOkY4dF5wQpkPN-Us9FMrV-aay6E=.088437be-9ec2-4142-ac67-1b30cdee807c@github.com> Message-ID: <VseVpRUtA-TgEYlFQkH28U8c9llJqNaWd5uVlUqmJBs=.d2c663fe-d378-42b6-af5a-4c507bea0928@github.com> On Tue, 5 Nov 2024 02:00:40 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8bcd4920](https://github.com/openjdk/jdk/commit/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1124#issuecomment-2458574370 From jwtang at openjdk.org Wed Nov 6 02:14:04 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Wed, 6 Nov 2024 02:14:04 GMT Subject: [jdk21u-dev] RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump Message-ID: <Mw0ex-Ijyg21Wpawt_al_MjY-9F_g04YLouw6chyIxI=.dc15acad-a2b8-4ba9-a5e1-b17f3422edf2@github.com> I have two reasons to backport 8330846. 1. When run the jtreg test `test/jdk/jdk/jfr/event/runtime/TestThreadDumpEvent.java` with the option `-testThreadFactory:Virtual`, it will fail because of the loss of `TestThreadDumpEvent.main` in the result. 2. It helps developers to have a better view of their programs. ------------- Commit messages: - Backport fcedde804277af5a26febdcfb7817858d72f01ab Changes: https://git.openjdk.org/jdk21u-dev/pull/1129/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1129&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330846 Stats: 97 lines in 2 files changed: 97 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1129.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1129/head:pull/1129 PR: https://git.openjdk.org/jdk21u-dev/pull/1129 From duke at openjdk.org Wed Nov 6 05:34:36 2024 From: duke at openjdk.org (duke) Date: Wed, 6 Nov 2024 05:34:36 GMT Subject: [jdk23u] RFR: 8342962: [s390x] TestOSRLotsOfLocals.java crashes In-Reply-To: <r98OSLzNNdP9cDm0kY1kr-9finTS6jrBZwsbsWYS0eY=.e239b233-301d-4235-8be4-1269c76cb927@github.com> References: <r98OSLzNNdP9cDm0kY1kr-9finTS6jrBZwsbsWYS0eY=.e239b233-301d-4235-8be4-1269c76cb927@github.com> Message-ID: <-4oA0hg1N3lNTwYUy7fPCnNzF0o2at9fdORrZXurSNU=.a817b783-58d0-4a03-8bca-7d1b6c4b857e@github.com> On Tue, 29 Oct 2024 05:15:15 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [54327bc4](https://github.com/openjdk/jdk/commit/54327bc4e38773b7461977ce17f2185c068bce9b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 29 Oct 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! @offamitkumar Your change (at version 7568e50f253c52be0d4564698961d38412bfa67e) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/209#issuecomment-2458757946 From duke at openjdk.org Wed Nov 6 06:53:33 2024 From: duke at openjdk.org (fitzsim) Date: Wed, 6 Nov 2024 06:53:33 GMT Subject: [jdk17u-dev] RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files In-Reply-To: <7WidG5JWFvitScTXyG1gTIc1qeDs2eX6wnpZjysX8E4=.eefa1281-4db5-4149-a00c-17cb5e274ece@github.com> References: <7WidG5JWFvitScTXyG1gTIc1qeDs2eX6wnpZjysX8E4=.eefa1281-4db5-4149-a00c-17cb5e274ece@github.com> Message-ID: <NwQWrsG5K16leiOWUvJoYnD13MzIlO2vx6F1Lij-MYU=.dc480824-b655-4f3b-a78c-97e6b0fcf309@github.com> On Tue, 5 Nov 2024 13:52:38 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > Clean backport from 21. _I am not a reviewer, but I maintain `java-17-openjdk` in `RHEL` so I will try to review `rfr`-labelled pull requests for `jdk17u-dev`, time-permitting._ This looks good to me, based on my reading of the `FILES` section of the `zic` man page. The `linux-x64-hs-minimal` seems unrelated (due to a transient network failure, perhaps). Can it be rerun independently to get it to pass? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3028#issuecomment-2458842714 From duke at openjdk.org Wed Nov 6 07:19:34 2024 From: duke at openjdk.org (fitzsim) Date: Wed, 6 Nov 2024 07:19:34 GMT Subject: [jdk17u-dev] RFR: 8321470: ThreadLocal.nextHashCode can be static final In-Reply-To: <_JxaKtFY6eq9xK7qbw7YkzzpdCoQKJ0FuoIy1GwpK10=.4b8c60a0-0cc6-42fc-ad60-6ea5237e786a@github.com> References: <_JxaKtFY6eq9xK7qbw7YkzzpdCoQKJ0FuoIy1GwpK10=.4b8c60a0-0cc6-42fc-ad60-6ea5237e786a@github.com> Message-ID: <PQlZbfH1lk7G2EmA22qrj7eFse2vmDkN0Nb4yNjl7g4=.789e65a8-5aef-4842-8cb5-544687e0d676@github.com> On Sat, 26 Oct 2024 23:46:17 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote: > Backporting JDK-8321470: ThreadLocal.nextHashCode can be static final. Minor change makes the variable final (it is already static). Patch is clean. _I am not a reviewer; I maintain `java-17-openjdk` in `RHEL` so I try to review `rfr`-labelled pull requests for `jdk17u-dev`, time-permitting._ This change seems safe and like a correct optimization that should improve performance. (It would have been nice if there were some performance analysis submitted with the original pull request that could have been re-run on 17.) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3007#issuecomment-2458875082 From mbaesken at openjdk.org Wed Nov 6 08:16:09 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 6 Nov 2024 08:16:09 GMT Subject: [jdk23u] RFR: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux Message-ID: <wvY18yRblyr0jpd4CM-WxrLCsRiimQMUBPslLtz8nQI=.27b7b2b6-0185-4421-a7da-578426b91f97@github.com> 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux ------------- Commit messages: - Backport 06d8216a4ef6b883119459da7e52b37d16cd2f03 Changes: https://git.openjdk.org/jdk23u/pull/217/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=217&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318442 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk23u/pull/217.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/217/head:pull/217 PR: https://git.openjdk.org/jdk23u/pull/217 From mbaesken at openjdk.org Wed Nov 6 08:28:59 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 6 Nov 2024 08:28:59 GMT Subject: [jdk17u-dev] RFR: 8340387: Update OS detection code to recognize Windows Server 2025 Message-ID: <WYPz68QYPmKRxBxdwUfWFvVtyMjMn7vG7p0xAjYG5VE=.ecc0c3f4-8e18-4802-be5a-dc8be66b69a8@github.com> 8340387: Update OS detection code to recognize Windows Server 2025 ------------- Commit messages: - Backport 34cddfbedd20d5804cab8044fbc402564e98eb9c Changes: https://git.openjdk.org/jdk17u-dev/pull/3029/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3029&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340387 Stats: 11 lines in 2 files changed: 8 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3029.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3029/head:pull/3029 PR: https://git.openjdk.org/jdk17u-dev/pull/3029 From aph at openjdk.org Wed Nov 6 08:52:41 2024 From: aph at openjdk.org (Andrew Haley) Date: Wed, 6 Nov 2024 08:52:41 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v2] In-Reply-To: <bX_isycwgNMnBwm2FpfH7Y1YfHCd_uWGOt8cKb5rSlE=.380e649c-a8d8-4a7e-95e8-140804e89c5c@github.com> References: <Nm9nt3ihKhACiDQgVwXSrcEDnd-HkyBTBJPU_cv2DDs=.714d8254-9859-4393-b0b2-1c6cb67d4379@github.com> <bX_isycwgNMnBwm2FpfH7Y1YfHCd_uWGOt8cKb5rSlE=.380e649c-a8d8-4a7e-95e8-140804e89c5c@github.com> Message-ID: <D9gyvzA69cZkHLDMxrLoVNJxO-89WTkmr9-8zD-T0v0=.7312a615-d7c2-4d51-a4ad-715082e4fa0b@github.com> On Thu, 17 Oct 2024 10:55:17 GMT, Taizo Kurashige <duke at openjdk.org> wrote: >> Hi, >> >> This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts >> >> Original patch does not apply cleanly for the following reasons: >> >> ?Fix to getOsMap() in test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied since getOsMap() was removed in https://bugs.openjdk.org/browse/JDK-8331700. >> ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in [https://bugs.openjdk.org/browse/JDK-8220753](https://bugs.openjdk.org/browse/JDK-8220753%28jdk13%29) (jdk13). >> ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed in https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. >> >> Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing >> >> Thanks. > > Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-8296631 > - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 > - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 Why are the two sets of files key4.db and cert9.db different? zarquon:Downloads $ shasum cert9*.db 41eed34f2505f3a549cb85542ae58b2f239c593e cert9(1).db b0e2a3aa1c884de00a342e01d5c2aa4c4ca1d801 cert9.db zarquon:Downloads $ shasum key4*.db c06ef63d0a2e960bbe91744c2fe1b8e7cd2bd841 key4(1).db 0a48f27990384fbae2d70dc9a496d08b6b5ea0f3 key4.db dbtool can't read the files in fips/. Are they a different kind of database? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2955#issuecomment-2459029633 From goetz at openjdk.org Wed Nov 6 09:54:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Nov 2024 09:54:47 GMT Subject: [jdk17u-dev] RFR: 8343687: [17u] TestAntiDependencyForPinnedLoads requires UTF-8 Message-ID: <alDoCfv7zNf6OmzNcdGdpucCJFwwkhmEQwhqLynl-Cc=.ea5ab1c9-aa1a-494c-987a-221520878367@github.com> We see this test failing on Windows. Forcing UTF-8 fixes the issue. ------------- Commit messages: - 8343687: [17u] TestAntiDependencyForPinnedLoads requires UTF-8 Changes: https://git.openjdk.org/jdk17u-dev/pull/3030/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3030&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343687 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3030.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3030/head:pull/3030 PR: https://git.openjdk.org/jdk17u-dev/pull/3030 From mdoerr at openjdk.org Wed Nov 6 10:44:29 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 6 Nov 2024 10:44:29 GMT Subject: [jdk17u-dev] RFR: 8343687: [17u] TestAntiDependencyForPinnedLoads requires UTF-8 In-Reply-To: <alDoCfv7zNf6OmzNcdGdpucCJFwwkhmEQwhqLynl-Cc=.ea5ab1c9-aa1a-494c-987a-221520878367@github.com> References: <alDoCfv7zNf6OmzNcdGdpucCJFwwkhmEQwhqLynl-Cc=.ea5ab1c9-aa1a-494c-987a-221520878367@github.com> Message-ID: <zxFUbKmdz9WG8BqR5RBF-CH3tfu8AC_9FNefoB8kcBc=.a7011652-ee0e-4954-b39a-c4b0d0c1a7cd@github.com> On Wed, 6 Nov 2024 09:50:38 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > We see this test failing on Windows. > > Forcing UTF-8 fixes the issue. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3030#pullrequestreview-2417919750 From goetz at openjdk.org Wed Nov 6 10:51:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Nov 2024 10:51:48 GMT Subject: [jdk17u-dev] RFR: 8343687: [17u] TestAntiDependencyForPinnedLoads requires UTF-8 [v2] In-Reply-To: <alDoCfv7zNf6OmzNcdGdpucCJFwwkhmEQwhqLynl-Cc=.ea5ab1c9-aa1a-494c-987a-221520878367@github.com> References: <alDoCfv7zNf6OmzNcdGdpucCJFwwkhmEQwhqLynl-Cc=.ea5ab1c9-aa1a-494c-987a-221520878367@github.com> Message-ID: <O2pQ8F813lV2qf4QKrBO6B4bMK2TAgimycawPitfDBc=.feb996e3-82ed-4bfd-98c1-0ef104b9e9d0@github.com> > We see this test failing on Windows. > > Forcing UTF-8 fixes the issue. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Fix compiled file ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3030/files - new: https://git.openjdk.org/jdk17u-dev/pull/3030/files/f43f5c90..d47dbad4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3030&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3030&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3030.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3030/head:pull/3030 PR: https://git.openjdk.org/jdk17u-dev/pull/3030 From mdoerr at openjdk.org Wed Nov 6 10:55:29 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 6 Nov 2024 10:55:29 GMT Subject: [jdk17u-dev] RFR: 8343687: [17u] TestAntiDependencyForPinnedLoads requires UTF-8 [v2] In-Reply-To: <O2pQ8F813lV2qf4QKrBO6B4bMK2TAgimycawPitfDBc=.feb996e3-82ed-4bfd-98c1-0ef104b9e9d0@github.com> References: <alDoCfv7zNf6OmzNcdGdpucCJFwwkhmEQwhqLynl-Cc=.ea5ab1c9-aa1a-494c-987a-221520878367@github.com> <O2pQ8F813lV2qf4QKrBO6B4bMK2TAgimycawPitfDBc=.feb996e3-82ed-4bfd-98c1-0ef104b9e9d0@github.com> Message-ID: <d9qD5LHL9nZS3NUIDC4D_62s-XlxfyWGDK27opMNuww=.532628df-8ea4-4838-a76b-aca55fd4d98a@github.com> On Wed, 6 Nov 2024 10:51:48 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> We see this test failing on Windows. >> >> Forcing UTF-8 fixes the issue. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Fix compiled file Marked as reviewed by mdoerr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3030#pullrequestreview-2417945439 From goetz at openjdk.org Wed Nov 6 11:02:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Nov 2024 11:02:37 GMT Subject: [jdk17u-dev] RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files In-Reply-To: <NwQWrsG5K16leiOWUvJoYnD13MzIlO2vx6F1Lij-MYU=.dc480824-b655-4f3b-a78c-97e6b0fcf309@github.com> References: <7WidG5JWFvitScTXyG1gTIc1qeDs2eX6wnpZjysX8E4=.eefa1281-4db5-4149-a00c-17cb5e274ece@github.com> <NwQWrsG5K16leiOWUvJoYnD13MzIlO2vx6F1Lij-MYU=.dc480824-b655-4f3b-a78c-97e6b0fcf309@github.com> Message-ID: <KjP0YfljmvYeo1raBkUVjDhgsZHuqU8GyvNDTErVKY8=.c4026bf4-cd2a-417e-b09b-0955d51a4ef1@github.com> On Wed, 6 Nov 2024 06:51:22 GMT, fitzsim <duke at openjdk.org> wrote: >> I backport this for parity with 17.0.14-oracle. >> >> Clean backport from 21. > > _I am not a reviewer, but I maintain `java-17-openjdk` in `RHEL` so I will try to review `rfr`-labelled pull requests for `jdk17u-dev`, time-permitting._ > > This looks good to me, based on my reading of the `FILES` section of the `zic` man page. > > The `linux-x64-hs-minimal` seems unrelated (due to a transient network failure, perhaps). Can it be rerun independently to get it to pass? Hi @fitzsim, thanks for looking at this change! Yes, I also think that the GHA error is unrelated. We see this issue a lot lately: Error: sh][ERROR] wget exited with exit code 4 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3028#issuecomment-2459441346 From goetz at openjdk.org Wed Nov 6 12:30:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Nov 2024 12:30:30 GMT Subject: [jdk17u-dev] RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel In-Reply-To: <RoSrZOf_nGeLt6HdhWAI8vUd2q9osWhhYrzPyuqUDh8=.22025c7e-2a9a-41df-9ba4-9b82f9252e5b@github.com> References: <RoSrZOf_nGeLt6HdhWAI8vUd2q9osWhhYrzPyuqUDh8=.22025c7e-2a9a-41df-9ba4-9b82f9252e5b@github.com> Message-ID: <fVuG6Nrz3o7E21GmkqWbeAvHLLsaMLAspSiE3dfLVqY=.a8babf52-cedd-4bd4-a7be-a69820af23f5@github.com> On Tue, 18 Jun 2024 08:02:55 GMT, Andrew Lu <andrewlu at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. > The test is limit to Windows, so backport with JDK-8331495 together, also backport with the new issue JDK-8331999 Still looks good. I'll backport JDK-8337810 problem listing this test on win. This will avoid the failure on win reported as JDK-8333880, but we have the test coverage on the other platforms in 17. ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2605#pullrequestreview-2418144338 From goetz at openjdk.org Wed Nov 6 12:44:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Nov 2024 12:44:33 GMT Subject: [jdk17u-dev] RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel In-Reply-To: <RoSrZOf_nGeLt6HdhWAI8vUd2q9osWhhYrzPyuqUDh8=.22025c7e-2a9a-41df-9ba4-9b82f9252e5b@github.com> References: <RoSrZOf_nGeLt6HdhWAI8vUd2q9osWhhYrzPyuqUDh8=.22025c7e-2a9a-41df-9ba4-9b82f9252e5b@github.com> Message-ID: <Sj-j4OYQlFj1dZQdTkYdzJREFIKKcGObkpx1W_Th4sA=.c57693c0-aa2d-43f9-8cba-c6cca87dbcac@github.com> On Tue, 18 Jun 2024 08:02:55 GMT, Andrew Lu <andrewlu at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. > The test is limit to Windows, so backport with JDK-8331495 together, also backport with the new issue JDK-8331999 Marked as reviewed by goetz (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2605#pullrequestreview-2418175277 From duke at openjdk.org Wed Nov 6 13:15:32 2024 From: duke at openjdk.org (fitzsim) Date: Wed, 6 Nov 2024 13:15:32 GMT Subject: [jdk17u-dev] RFR: 8303742: CompletableFuture.orTimeout leaks if the future completes exceptionally [v2] In-Reply-To: <NiBu-9_LjKDBhq-LHz8iQj1i5RVPy0bFEj4Vpe0sYwI=.ddc3ea2d-1b16-42ae-bd3d-c3d23c5194df@github.com> References: <4b--P27Y6FnyGlxqn6AtCj64wqzhAWeJXkniNfztkAM=.ef1e9755-7641-47a2-b376-1ac2e68476eb@github.com> <NiBu-9_LjKDBhq-LHz8iQj1i5RVPy0bFEj4Vpe0sYwI=.ddc3ea2d-1b16-42ae-bd3d-c3d23c5194df@github.com> Message-ID: <fDEAMHroem_0q4Uso7ddqDwrXO316EUH43ygefhRHPU=.86176035-4f96-4131-a1a1-7bb9d71c6c5a@github.com> On Fri, 25 Oct 2024 22:16:36 GMT, Ben Taylor <btaylor at openjdk.org> wrote: >> Clean backport of a patch to prevent `CompleteableFuture.orTimeout` from leaking when a `ScheduledFutureTask` exits exceptionally >> >> Passes the included test as well as jtreg tier 1 locally on linux x86_64 >> >> Updated to include JDK-8304557, which is a follow up item to prevent the test from timing out, see @RealCLanger's comment below. That backport is also clean. > > Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: > > Backport 6f67abd352ce9605dd93188995d42a47ee07b25e _I am not a Reviewer; I maintain `java-17-openjdk` in `RHEL` so I try to review `rfr`-labelled pull requests for `jdk17u-dev`, time-permitting._ This looks like a good change to have in `17`. The need for the test case load-reduction workaround in `JDK-8304557` is interesting. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3000#issuecomment-2459719661 From mbaesken at openjdk.org Wed Nov 6 14:31:35 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 6 Nov 2024 14:31:35 GMT Subject: [jdk23u] Integrated: 8334442: Temporarily disable return type assertion to reduce noise in testing In-Reply-To: <86IPTFgGN--mH7zftkJwBJ7zdIPnx_MQhpw4JLcPdzg=.3eaf9cb6-220b-48c7-844d-b8a0f3a1935d@github.com> References: <86IPTFgGN--mH7zftkJwBJ7zdIPnx_MQhpw4JLcPdzg=.3eaf9cb6-220b-48c7-844d-b8a0f3a1935d@github.com> Message-ID: <N0jXXnQ4kibkWiIEff_GiHBN7rhR-ELL7W8z6fufwbs=.07454753-8a20-41a7-a46d-a3637cbeec3f@github.com> On Wed, 9 Oct 2024 11:48:25 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8334442: Temporarily disable return type assertion to reduce noise in testing This pull request has now been integrated. Changeset: 64588005 Author: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk23u/commit/645880052b0cb5babca8d849787d764899b584b8 Stats: 10 lines in 1 file changed: 0 ins; 10 del; 0 mod 8334442: Temporarily disable return type assertion to reduce noise in testing Backport-of: 614b99a8f8360dc0a6a018f06fb336c6883f0f4a ------------- PR: https://git.openjdk.org/jdk23u/pull/146 From goetz at openjdk.org Wed Nov 6 14:31:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Nov 2024 14:31:47 GMT Subject: [jdk21u-dev] RFR: 8337810: ProblemList BasicDirectoryModel/LoaderThreadCount.java on Windows Message-ID: <LiC_UZkAXTYtrPPdGkVXrbGOyShvmLf02bi9ZxeuiQ4=.b3af5601-9462-4a4d-b470-e3c7c4b152df@github.com> Bringing this to 21 as we see the failure there, too. ------------- Commit messages: - Backport f92c60e1a9968620cbc92b52aa546b57c09da487 Changes: https://git.openjdk.org/jdk21u-dev/pull/1130/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1130&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337810 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1130.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1130/head:pull/1130 PR: https://git.openjdk.org/jdk21u-dev/pull/1130 From goetz at openjdk.org Wed Nov 6 15:04:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Nov 2024 15:04:49 GMT Subject: [jdk17u-dev] RFR: 8337810: ProblemList BasicDirectoryModel/LoaderThreadCount.java on Windows Message-ID: <727jGjP1Ry2nnHSyFf0JHUUZPubq5aJh_xZncVgTWIM=.495765b3-22f4-4b03-85c0-6617227a1632@github.com> I want to ProblemList this in 17, too. ------------- Commit messages: - Backport f92c60e1a9968620cbc92b52aa546b57c09da487 Changes: https://git.openjdk.org/jdk17u-dev/pull/3031/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3031&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337810 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3031.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3031/head:pull/3031 PR: https://git.openjdk.org/jdk17u-dev/pull/3031 From goetz at openjdk.org Wed Nov 6 15:31:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Nov 2024 15:31:37 GMT Subject: [jdk17u-dev] Integrated: 8343687: [17u] TestAntiDependencyForPinnedLoads requires UTF-8 In-Reply-To: <alDoCfv7zNf6OmzNcdGdpucCJFwwkhmEQwhqLynl-Cc=.ea5ab1c9-aa1a-494c-987a-221520878367@github.com> References: <alDoCfv7zNf6OmzNcdGdpucCJFwwkhmEQwhqLynl-Cc=.ea5ab1c9-aa1a-494c-987a-221520878367@github.com> Message-ID: <yoVvyCd_iVwVODBVVHO9RL6opQcjJUD6ZkhaSg-1MjQ=.a80afaaa-9e02-48f3-9ba2-36f50bad74ad@github.com> On Wed, 6 Nov 2024 09:50:38 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > We see this test failing on Windows. > > Forcing UTF-8 fixes the issue. This pull request has now been integrated. Changeset: 93b2aa48 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/93b2aa48598ef26f645e673ad111885d2acd18ef Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8343687: [17u] TestAntiDependencyForPinnedLoads requires UTF-8 Reviewed-by: mdoerr ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3030 From goetz at openjdk.org Wed Nov 6 15:44:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Nov 2024 15:44:32 GMT Subject: [jdk17u-dev] Integrated: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files In-Reply-To: <7WidG5JWFvitScTXyG1gTIc1qeDs2eX6wnpZjysX8E4=.eefa1281-4db5-4149-a00c-17cb5e274ece@github.com> References: <7WidG5JWFvitScTXyG1gTIc1qeDs2eX6wnpZjysX8E4=.eefa1281-4db5-4149-a00c-17cb5e274ece@github.com> Message-ID: <Eq2f6g6W7sB1vRVk4E0wpt3QjwYti4yGA2aY8XbpM5g=.ab1e7ac5-f347-4fb4-b76d-ade0189b5e77@github.com> On Tue, 5 Nov 2024 13:52:38 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > Clean backport from 21. This pull request has now been integrated. Changeset: 0d7b2729 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/0d7b2729e4f4c0fec2dcfea65a0834732a408ee4 Stats: 20 lines in 3 files changed: 4 ins; 0 del; 16 mod 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files Backport-of: f4940f65f8908602e2043caaf1141150be865acc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3028 From amitkumar at openjdk.org Wed Nov 6 17:08:38 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Wed, 6 Nov 2024 17:08:38 GMT Subject: [jdk23u] Integrated: 8342962: [s390x] TestOSRLotsOfLocals.java crashes In-Reply-To: <r98OSLzNNdP9cDm0kY1kr-9finTS6jrBZwsbsWYS0eY=.e239b233-301d-4235-8be4-1269c76cb927@github.com> References: <r98OSLzNNdP9cDm0kY1kr-9finTS6jrBZwsbsWYS0eY=.e239b233-301d-4235-8be4-1269c76cb927@github.com> Message-ID: <7_nNQN2WzY9lzm6pBx9YFVwd0WQt2691sdFCc05AIds=.b2bacec7-2f0f-44c0-bb80-78cb00ca3138@github.com> On Tue, 29 Oct 2024 05:15:15 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [54327bc4](https://github.com/openjdk/jdk/commit/54327bc4e38773b7461977ce17f2185c068bce9b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 29 Oct 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! This pull request has now been integrated. Changeset: 69d97e02 Author: Amit Kumar <amitkumar at openjdk.org> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk23u/commit/69d97e02192ae000bee41c21c24453ab43c92709 Stats: 17 lines in 1 file changed: 14 ins; 0 del; 3 mod 8342962: [s390x] TestOSRLotsOfLocals.java crashes Backport-of: 54327bc4e38773b7461977ce17f2185c068bce9b ------------- PR: https://git.openjdk.org/jdk23u/pull/209 From bulasevich at openjdk.org Thu Nov 7 02:23:59 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Thu, 7 Nov 2024 02:23:59 GMT Subject: [jdk21u-dev] RFR: 8334890: Missing unconditional cross modifying fence in nmethod entry barriers Message-ID: <7u4nbPZzwdWVWMKKixpsZBArBuQBnQcrHAGbVepvoEg=.8e9170ba-4917-4d7e-8626-d0cb58019895@github.com> The change adds an unconditional memory barrier to guarantee the instruction fetcher observes the correct updated immediate. ------------- Commit messages: - Backport c0604fb823d9f3b2e347a9857b11606b223ad8ec Changes: https://git.openjdk.org/jdk21u-dev/pull/1131/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1131&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334890 Stats: 18 lines in 1 file changed: 1 ins; 14 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1131.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1131/head:pull/1131 PR: https://git.openjdk.org/jdk21u-dev/pull/1131 From goetz at openjdk.org Thu Nov 7 08:05:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 08:05:47 GMT Subject: [jdk21u-dev] Integrated: 8337810: ProblemList BasicDirectoryModel/LoaderThreadCount.java on Windows In-Reply-To: <LiC_UZkAXTYtrPPdGkVXrbGOyShvmLf02bi9ZxeuiQ4=.b3af5601-9462-4a4d-b470-e3c7c4b152df@github.com> References: <LiC_UZkAXTYtrPPdGkVXrbGOyShvmLf02bi9ZxeuiQ4=.b3af5601-9462-4a4d-b470-e3c7c4b152df@github.com> Message-ID: <3UNf83s7E6BMXirWArRz0cs2bAuhwUf5304FkYIOo7Y=.316f709d-3d76-4f79-ab59-1c92d24161c1@github.com> On Wed, 6 Nov 2024 11:52:58 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > Bringing this to 21 as we see the failure there, too. This pull request has now been integrated. Changeset: 4a5c578b Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/4a5c578bb092cde2c1cb40a451de6be63a9026f4 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8337810: ProblemList BasicDirectoryModel/LoaderThreadCount.java on Windows Backport-of: f92c60e1a9968620cbc92b52aa546b57c09da487 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1130 From duke at openjdk.org Thu Nov 7 09:21:55 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Thu, 7 Nov 2024 09:21:55 GMT Subject: [jdk21u-dev] RFR: 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows Message-ID: <hCZuxP9oDF459Cpyrb1AvpxwUC41Xw_gH4Vmryk_wDk=.845d7a0d-229a-4a31-836c-426b0e8352c6@github.com> Hi all, I want to backport JDK-8333427 for jdk21u. This is clean backport. It changes only one test. Testing: langtools/tools/javac/newlines/NewLineTest.java ------------- Commit messages: - 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows Changes: https://git.openjdk.org/jdk21u-dev/pull/1132/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1132&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333427 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1132.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1132/head:pull/1132 PR: https://git.openjdk.org/jdk21u-dev/pull/1132 From goetz at openjdk.org Thu Nov 7 09:38:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 09:38:53 GMT Subject: [jdk21u-dev] RFR: 8327924: Simplify TrayIconScalingTest.java Message-ID: <E2miutZguydI-Gg5l78FpB5_mqv-mmiroxMuNRQE7rY=.1e86c3e1-7da4-4e11-8952-2dd2ca8f95b8@github.com> I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 1496b5de9004c6a9e43ead5f6e9e88362028a7cc Changes: https://git.openjdk.org/jdk21u-dev/pull/1133/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1133&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327924 Stats: 27 lines in 1 file changed: 10 ins; 11 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1133.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1133/head:pull/1133 PR: https://git.openjdk.org/jdk21u-dev/pull/1133 From goetz at openjdk.org Thu Nov 7 09:40:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 09:40:24 GMT Subject: [jdk17u-dev] RFR: 8327924: Simplify TrayIconScalingTest.java Message-ID: <7Sf68DPSirIJfL39eZrOum-6Bkrd5WTIXbARoS29Bew=.3bd2e692-5049-45aa-801e-5b33faea0b70@github.com> I backport this for parity with 17.0.14-oracle ------------- Commit messages: - Backport 1496b5de9004c6a9e43ead5f6e9e88362028a7cc Changes: https://git.openjdk.org/jdk17u-dev/pull/3032/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3032&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327924 Stats: 27 lines in 1 file changed: 10 ins; 11 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3032.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3032/head:pull/3032 PR: https://git.openjdk.org/jdk17u-dev/pull/3032 From sgehwolf at openjdk.org Thu Nov 7 09:48:48 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 7 Nov 2024 09:48:48 GMT Subject: [jdk21u-dev] RFR: 8334890: Missing unconditional cross modifying fence in nmethod entry barriers In-Reply-To: <7u4nbPZzwdWVWMKKixpsZBArBuQBnQcrHAGbVepvoEg=.8e9170ba-4917-4d7e-8626-d0cb58019895@github.com> References: <7u4nbPZzwdWVWMKKixpsZBArBuQBnQcrHAGbVepvoEg=.8e9170ba-4917-4d7e-8626-d0cb58019895@github.com> Message-ID: <vkXtONgulblRJXRfJ8toeatUo2DiU91y7uugB2ahUGQ=.da32b1e3-70fe-4a47-9448-d41acf17049b@github.com> On Thu, 7 Nov 2024 02:18:54 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote: > The change adds an unconditional memory barrier to guarantee the instruction fetcher observes the correct updated immediate. > > Merge conflict caused by minor context difference (added comment in a mainline): fixed manually. > > Testing: jtreg tier 1-3 on arm64 and x64. It's not clear this change introduces a regression: https://bugs.openjdk.org/browse/JDK-8337778 Please clarify. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1131#issuecomment-2461770526 From goetz at openjdk.org Thu Nov 7 09:50:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 09:50:59 GMT Subject: [jdk21u-dev] RFR: 8308429: jvmti/StopThread/stopthrd007 failed with "NoClassDefFoundError: Could not initialize class jdk.internal.misc.VirtualThreads" Message-ID: <lJLB4xckDKlLdbNF2gnV3CUG9b4WpWRV3etxrbvsoeA=.01a73c23-4246-4b12-9419-095a37676685@github.com> I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 0e501f66dfc52a0e049d4fa39c1fcd24f1f2ee4b Changes: https://git.openjdk.org/jdk21u-dev/pull/1134/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1134&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308429 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1134.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1134/head:pull/1134 PR: https://git.openjdk.org/jdk21u-dev/pull/1134 From goetz at openjdk.org Thu Nov 7 09:57:00 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 09:57:00 GMT Subject: [jdk21u-dev] RFR: 8325038: runtime/cds/appcds/ProhibitedPackage.java can fail with UseLargePages Message-ID: <WgEIQ7avCLCXpAnb-31j8kwCAYIZB1sQxvJkSeQ1xuE=.c6428f36-d52f-455b-986f-7b4527b6e7f2@github.com> I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport b42b8886aa93a50d114f9a105ef6b94febd38729 Changes: https://git.openjdk.org/jdk21u-dev/pull/1135/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1135&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325038 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1135.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1135/head:pull/1135 PR: https://git.openjdk.org/jdk21u-dev/pull/1135 From goetz at openjdk.org Thu Nov 7 09:57:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 09:57:26 GMT Subject: [jdk17u-dev] RFR: 8325038: runtime/cds/appcds/ProhibitedPackage.java can fail with UseLargePages Message-ID: <2iI1BwH7Wz9L2dxcRHZd9KRaGZ7mhIeVh5itRhJ8148=.20a9d04b-4902-4210-9a01-d345ca9904a6@github.com> I backport this for parity with 17.0.14-oracle ------------- Commit messages: - Backport b42b8886aa93a50d114f9a105ef6b94febd38729 Changes: https://git.openjdk.org/jdk17u-dev/pull/3033/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3033&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325038 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3033.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3033/head:pull/3033 PR: https://git.openjdk.org/jdk17u-dev/pull/3033 From goetz at openjdk.org Thu Nov 7 10:05:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 10:05:20 GMT Subject: [jdk21u-dev] RFR: 8333235: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with C1 Message-ID: <JHn-WzVTZbLGLZbmNLDDDDEFNpYljaGxXSs2Cd3ygnI=.f2a2f902-2045-46d3-8b46-c12750fff90c@github.com> I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport f73922b27d126314fc3127ee25aa40b6258c8a6b Changes: https://git.openjdk.org/jdk21u-dev/pull/1136/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1136&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333235 Stats: 14 lines in 1 file changed: 11 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1136.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1136/head:pull/1136 PR: https://git.openjdk.org/jdk21u-dev/pull/1136 From goetz at openjdk.org Thu Nov 7 10:46:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 10:46:54 GMT Subject: [jdk17u-dev] RFR: 8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp Message-ID: <S0s8pXqP9pxM23zHpRmc1jyCBii9kst8xx5fja4xQqI=.c291bcc0-1c51-4f37-a14e-28e1716db2b0@github.com> I backport this for parity with 17.0.14-oracle, ------------- Commit messages: - Backport 6f4ddc2f6bf0dd9a626a76d0f5e56a54c6cf6b65 Changes: https://git.openjdk.org/jdk17u-dev/pull/3034/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3034&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335142 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3034.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3034/head:pull/3034 PR: https://git.openjdk.org/jdk17u-dev/pull/3034 From goetz at openjdk.org Thu Nov 7 10:47:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 10:47:29 GMT Subject: [jdk21u-dev] RFR: 8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp Message-ID: <N4sGTnQRqTtlwCDelw16EptbYuqZZE6njYfqOB6vfOk=.535db45c-88d3-4e32-904d-50a4217d898f@github.com> I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 6f4ddc2f6bf0dd9a626a76d0f5e56a54c6cf6b65 Changes: https://git.openjdk.org/jdk21u-dev/pull/1137/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1137&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335142 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1137.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1137/head:pull/1137 PR: https://git.openjdk.org/jdk21u-dev/pull/1137 From aboldtch at openjdk.org Thu Nov 7 11:01:41 2024 From: aboldtch at openjdk.org (Axel Boldt-Christmas) Date: Thu, 7 Nov 2024 11:01:41 GMT Subject: [jdk23u] RFR: 8340586: JdkJfrEvent::get_all_klasses stores non-strong oops in JNI handles Message-ID: <bO9rYB6nC4STutjBz7VkE5ZIFU62QiH0Mh4kkETPWC8=.d2a8c97f-8e2e-4c6c-9b22-8ba2e8c227a2@github.com> Hi all, This pull request contains a backport of commit [97b681e9](https://github.com/openjdk/jdk/commit/97b681e93a9469d8d16122dc10bbf2f5b5fe2266) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Axel Boldt-Christmas on 7 Nov 2024 and was reviewed by Coleen Phillimore, Stefan Karlsson and Markus Gr?nlund. Thanks! ------------- Commit messages: - Backport 97b681e93a9469d8d16122dc10bbf2f5b5fe2266 Changes: https://git.openjdk.org/jdk23u/pull/218/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=218&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340586 Stats: 34 lines in 3 files changed: 17 ins; 13 del; 4 mod Patch: https://git.openjdk.org/jdk23u/pull/218.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/218/head:pull/218 PR: https://git.openjdk.org/jdk23u/pull/218 From duke at openjdk.org Thu Nov 7 11:53:29 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Thu, 7 Nov 2024 11:53:29 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v3] In-Reply-To: <Nm9nt3ihKhACiDQgVwXSrcEDnd-HkyBTBJPU_cv2DDs=.714d8254-9859-4393-b0b2-1c6cb67d4379@github.com> References: <Nm9nt3ihKhACiDQgVwXSrcEDnd-HkyBTBJPU_cv2DDs=.714d8254-9859-4393-b0b2-1c6cb67d4379@github.com> Message-ID: <I4ooNznKJeLVl7m87ZNS03xqw7qkSmJVrLN4bcy9sCg=.fcfa646b-5f73-4f16-9210-5fab5308870c@github.com> > Hi, > > This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts > > Original patch does not apply cleanly for the following reasons: > > ?Fix to getOsMap() in test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied since getOsMap() was removed in https://bugs.openjdk.org/browse/JDK-8331700. > ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in [https://bugs.openjdk.org/browse/JDK-8220753](https://bugs.openjdk.org/browse/JDK-8220753%28jdk13%29) (jdk13). > ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed in https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into backport-8296631 - Merge branch 'openjdk:master' into backport-8296631 - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2955/files - new: https://git.openjdk.org/jdk11u-dev/pull/2955/files/2cc6ddb4..a247aa1d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2955&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2955&range=01-02 Stats: 63 lines in 3 files changed: 40 ins; 8 del; 15 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2955.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2955/head:pull/2955 PR: https://git.openjdk.org/jdk11u-dev/pull/2955 From duke at openjdk.org Thu Nov 7 13:13:11 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Thu, 7 Nov 2024 13:13:11 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v2] In-Reply-To: <D9gyvzA69cZkHLDMxrLoVNJxO-89WTkmr9-8zD-T0v0=.7312a615-d7c2-4d51-a4ad-715082e4fa0b@github.com> References: <Nm9nt3ihKhACiDQgVwXSrcEDnd-HkyBTBJPU_cv2DDs=.714d8254-9859-4393-b0b2-1c6cb67d4379@github.com> <bX_isycwgNMnBwm2FpfH7Y1YfHCd_uWGOt8cKb5rSlE=.380e649c-a8d8-4a7e-95e8-140804e89c5c@github.com> <D9gyvzA69cZkHLDMxrLoVNJxO-89WTkmr9-8zD-T0v0=.7312a615-d7c2-4d51-a4ad-715082e4fa0b@github.com> Message-ID: <XnHHs5lEi0-JA3PWQGBQMTkpHrJJMKFBGNeS1OzOTmc=.fb1f4724-0108-4598-b91f-f90f8632fdd7@github.com> On Wed, 6 Nov 2024 08:49:42 GMT, Andrew Haley <aph at openjdk.org> wrote: >> Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: >> >> - Merge branch 'openjdk:master' into backport-8296631 >> - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 >> - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 > > Why are the two sets of files key4.db and cert9.db different? > > > zarquon:Downloads $ shasum cert9*.db > 41eed34f2505f3a549cb85542ae58b2f239c593e cert9(1).db > b0e2a3aa1c884de00a342e01d5c2aa4c4ca1d801 cert9.db > zarquon:Downloads $ shasum key4*.db > c06ef63d0a2e960bbe91744c2fe1b8e7cd2bd841 key4(1).db > 0a48f27990384fbae2d70dc9a496d08b6b5ea0f3 key4.db > > > dbtool can't read the files in fips/. Are they a different kind of database? @theRealAph > Why are the two sets of files key4.db and cert9.db different? The reason key4.db and cert9.db are different is that they are newly created by me using the "modutil" command. I created them with reference to [jdk/test/jdk/sun/security/pkcs11/Secmod/README-SQLITE](https://github.com/openjdk/jdk/blob/ac82a8f89c7066fb1d379b12bcfd68053cb39ba4/test/jdk/sun/security/pkcs11/Secmod/README-SQLITE) and manually copied pkcs11.txt from [jdk/test/jdk/sun/security/pkcs11/Secmod/pkcs11.txt](https://github.com/openjdk/jdk/blob/f0b251d76078e8d5b47e967b0449c4cbdcb5a005/test/jdk/sun/security/pkcs11/Secmod/pkcs11.txt). However, after receiving your comment, I realized that the README-SQLITE procedure does not correspond to the contents of pkcs11.txt. So I recreated key4.db ,cert9.db and pkcs11.txt using the following steps: $ mkdir ./tmpdb $ modutil -create -force -dbdir sql:./tmpdb $ modutil -enable "NSS Internal PKCS #11 Module" -dbdir sql:./tmpdb WARNING: Performing this operation while the browser is running could cause corruption of your security databases. If the browser is currently running, you should exit browser before continuing this operation. Type 'q <enter>' to abort, or <enter> to continue: Slot "NSS Internal Cryptographic Services" enabled. Slot "NSS User Private Key and Certificate Services" enabled. $ modutil -undefault "NSS Internal PKCS #11 Module" -mechanisms SHA256:SHA512:Camellia:SEED:ECC -force -dbdir sql:./tmpdb -secmod secmod.db Successfully changed defaults. $ modutil -add "Builtin Roots Module" -libfile libnssckbi.so -dbdir sql:./tmpdb WARNING: Performing this operation while the browser is running could cause corruption of your security databases. If the browser is currently running, you should exit browser before continuing this operation. Type 'q <enter>' to abort, or <enter> to continue: WARNING: Manually adding a module while p11-kit is enabled could cause duplicate module registration in your security database. It is suggested to configure the module through p11-kit configuration file instead. Type 'q <enter>' to abort, or <enter> to continue: Module "Builtin Roots Module" added to database. $ echo "" > ./tmpdb/1 $ echo "test12" > ./tmpdb/2 $ modutil -changepw "NSS Certificate DB" -force -dbdir sql:./tmpdb/ -pwfile ./tmpdb/1 -newpwfile ./tmpdb/2 Token "NSS Certificate DB" password changed successfully. $ ls tmpdb/ 1 2 cert9.db key4.db pkcs11.txt $ cat tmpdb/pkcs11.txt library= name=NSS Internal PKCS #11 Module parameters=configdir='sql:./tmpdb' certPrefix='' keyPrefix='' secmod='secmod.db' flags= updatedir='' updateCertPrefix='' updateKeyPrefix='' updateid='' updateTokenDescription='' NSS=trustOrder=75 cipherOrder=100 slotParams={0x00000001=[slotFlags=RSA,RC4,RC2,DES,DH,SHA1,MD5,MD2,SSL,TLS,AES,RANDOM askpw=any timeout=30 ] } Flags=internal,critical library=libnssckbi.so name=Builtin Roots Module NSS=trustOrder=100 I then verified again that the tests in pkcs11/fips/pass. > dbtool can't read the files in fips/. Are they a different kind of database? Please check if dbtool can't read the db files in fips/ again because I recreated as above. I didn't intend to use a different kind of database. If dbtool can't read them, it would be helpful if you could provide an error message. In some cases, I will replace the db files in pkcs11/fips with the db files in pkcs11/KeyStore/ClientAuthData. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2955#issuecomment-2462197616 From duke at openjdk.org Thu Nov 7 13:13:10 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Thu, 7 Nov 2024 13:13:10 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v4] In-Reply-To: <Nm9nt3ihKhACiDQgVwXSrcEDnd-HkyBTBJPU_cv2DDs=.714d8254-9859-4393-b0b2-1c6cb67d4379@github.com> References: <Nm9nt3ihKhACiDQgVwXSrcEDnd-HkyBTBJPU_cv2DDs=.714d8254-9859-4393-b0b2-1c6cb67d4379@github.com> Message-ID: <wYQx4reYw191HCZv7EJ5NdTH9gzpdSGndMPPWKpcXe8=.fe1edce0-85d4-4dec-bd84-edbab5d5b763@github.com> > Hi, > > This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts > > Original patch does not apply cleanly for the following reasons: > > ?Fix to getOsMap() in test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied since getOsMap() was removed in https://bugs.openjdk.org/browse/JDK-8331700. > ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in [https://bugs.openjdk.org/browse/JDK-8220753](https://bugs.openjdk.org/browse/JDK-8220753%28jdk13%29) (jdk13). > ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed in https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: Replace pkcs11/fips/key4.db and pkcs11.txt ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2955/files - new: https://git.openjdk.org/jdk11u-dev/pull/2955/files/a247aa1d..7c28df67 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2955&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2955&range=02-03 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2955.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2955/head:pull/2955 PR: https://git.openjdk.org/jdk11u-dev/pull/2955 From goetz at openjdk.org Thu Nov 7 13:14:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 13:14:08 GMT Subject: [jdk21u-dev] RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property Message-ID: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> I backport this for parity with 21.0.6-oracle. I resolved two files: test/jdk/sun/security/mscapi/InteropWithSunRsaSign.java Copyright test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java Resolved because 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode not in 21. Tests all pass except for three I skipped: test/jdk/sun/security/pkcs11/rsa/GenKeyStore.java test/jdk/sun/security/rsa/GenKeyStore.java test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilHmacSHA1.java Checked the change in these files. ------------- Commit messages: - Backport 9a9ac1d0059438d33fe69ef51265dc7cff6ad2bd Changes: https://git.openjdk.org/jdk21u-dev/pull/1138/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1138&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341927 Stats: 1006 lines in 230 files changed: 307 ins; 0 del; 699 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1138.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1138/head:pull/1138 PR: https://git.openjdk.org/jdk21u-dev/pull/1138 From goetz at openjdk.org Thu Nov 7 13:23:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 13:23:58 GMT Subject: [jdk21u-dev] RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump In-Reply-To: <Mw0ex-Ijyg21Wpawt_al_MjY-9F_g04YLouw6chyIxI=.dc15acad-a2b8-4ba9-a5e1-b17f3422edf2@github.com> References: <Mw0ex-Ijyg21Wpawt_al_MjY-9F_g04YLouw6chyIxI=.dc15acad-a2b8-4ba9-a5e1-b17f3422edf2@github.com> Message-ID: <G9SUlu-3RDGh-qwY0w_4OcKZ15146jBBbLPKkaa0-J4=.8e2d3d4e-d9ba-4eeb-b645-0dd37e402d1f@github.com> On Wed, 6 Nov 2024 02:08:36 GMT, Jiawei Tang <jwtang at openjdk.org> wrote: > I have two reasons to backport 8330846. > 1. When run the jtreg test `test/jdk/jdk/jfr/event/runtime/TestThreadDumpEvent.java` with the option `-testThreadFactory:Virtual`, it will fail because of the loss of `TestThreadDumpEvent.main` in the result. > 2. It helps developers to have a better view of their programs. Hi @jia-wei-tang, what about follow-up JDK-8334215, is this needed also? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1129#issuecomment-2462225484 From goetz at openjdk.org Thu Nov 7 13:25:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 13:25:52 GMT Subject: [jdk21u-dev] RFR: 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: <JOv256F1ZHJNWHQ9xhZ0iRQv_J07HkKW65XyY0hT5-g=.ff5b719c-eb86-4c3a-b37a-cf48305d7fa9@github.com> References: <IemMFwdS40DbQh6aW3eSIf4O1SgR97r2U66YGavrdyQ=.700b0a41-0aca-45b3-aaac-bcf109bc4cf2@github.com> <JOv256F1ZHJNWHQ9xhZ0iRQv_J07HkKW65XyY0hT5-g=.ff5b719c-eb86-4c3a-b37a-cf48305d7fa9@github.com> Message-ID: <uIqJiQG_PPAeqbJSd3dyNZyvUS6vRM6MF_zaThGNKlY=.d08dcc33-0055-4281-bce5-1a0bc7e60179@github.com> On Mon, 4 Nov 2024 17:28:07 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote: >> (not a clean backport) >> Reworked to avoid https://github.com/openjdk/jdk/pull/17328/files backport >> >> Functional jtreg1-3 tests are Ok. >> Manual testing: the reproducer shows the problem is fixed with the change (see comments below) > > Reproducer: > > import jdk.jfr.consumer.RecordingStream; > > /** > * Stress test to provoke the memory leak: > * starts 1M empty threads in VM with jfr recording > */ > public class PinnedThreadTracker implements AutoCloseable > { > private final RecordingStream recordingStream; > > public PinnedThreadTracker() { > recordingStream = new RecordingStream(); > recordingStream.startAsync(); > System.out.println("start recording.."); > } > > @Override > public void close() { > recordingStream.close(); > } > > class MyThread extends Thread { > public void run() { > } > } > public void runThreads() { > for (int i = 0; i < 100; i++) { > for (int j = 0; j < 100; j++) { > for (int k = 0; k < 100; k++) { > new MyThread().start(); > } > MyThread thr = new MyThread(); thr.start(); > try { > thr.join(); > } catch (Exception ex) {} > } > System.out.print("."); > } > } > > public static void main(String a[]) { > PinnedThreadTracker ptt = new PinnedThreadTracker(); > ptt.runThreads(); > ptt.close(); > } > } > > > Manual testing results on jdk21u: > > $ for i in {0..60}; do > export PID=`ps -ax | grep java | grep PinnedThreadTracker | sed "s/^ *// ; s/ .*//"` > jcmd $PID VM.native_memory | grep Tracing.*reserved > sleep 1s > done > > Before the change (jcmd VM.native_memory output once a second): > - Tracing (reserved=17355KB, committed=17355KB) > - Tracing (reserved=21646KB, committed=21646KB) > - Tracing (reserved=25870KB, committed=25870KB) > - Tracing (reserved=30065KB, committed=30065KB) > ... > - Tracing (reserved=240567KB, committed=240567KB) > - Tracing (reserved=244519KB, committed=244519KB) > - Tracing (reserved=248525KB, committed=248525KB) > - Tracing (reserved=252527KB, committed=252527KB) > > With the fix: > - Tracing (reserved=17655KB, committed=17655KB) > - Tracing (reserved=18125KB, committed=18125KB) > - Tracing (reserved=18449KB, committed=18449KB) > - Tracing (reserved=18961KB, committed=18961KB) > ... > - Tracing (reserved=17443KB, committed=17443KB) > - Tracing (reserved=17958KB, committed=17958KB) > - Tracing (reserved=... Hi @bulasevich, can this wait for the April update? It would get some more test coverage. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1095#issuecomment-2462229914 From goetz at openjdk.org Thu Nov 7 13:26:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 13:26:55 GMT Subject: [jdk21u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <1A8Pjqodey4brM-cndhW3u6TUyNDzospAEl8UmaGdN0=.8536dd69-12ea-445b-8fae-35ae640f02cb@github.com> References: <mTBEOPqFvDuQf13u24iXB65OuyE1Sz3Uy6_I0Ow8Vxo=.1d4ad8b1-1544-45b5-8375-9038cbb2f2bd@github.com> <1A8Pjqodey4brM-cndhW3u6TUyNDzospAEl8UmaGdN0=.8536dd69-12ea-445b-8fae-35ae640f02cb@github.com> Message-ID: <BJvBmh8I5MHskZNNwYg3iPa_P83DR_U29DJejQrxlm4=.1f49332a-ee48-4849-8ff6-5dee8531a820@github.com> On Tue, 5 Nov 2024 18:53:41 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote: >> This change improves annotation processing test coverage, see [JDK-8336942](https://bugs.openjdk.org/browse/JDK-8336942). I resolved a trivial merge conflict with JDK-8323684, which added the `nameToAnnotation` map. The modified test passes. > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 > - 8336942: Improve test coverage for class loading elements with annotations of different retentions > > Reviewed-by: vromero @cushon Please first get a review, then label for approval. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1037#issuecomment-2462233654 From mbaesken at openjdk.org Thu Nov 7 13:42:45 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 7 Nov 2024 13:42:45 GMT Subject: [jdk17u-dev] Integrated: 8340387: Update OS detection code to recognize Windows Server 2025 In-Reply-To: <WYPz68QYPmKRxBxdwUfWFvVtyMjMn7vG7p0xAjYG5VE=.ecc0c3f4-8e18-4802-be5a-dc8be66b69a8@github.com> References: <WYPz68QYPmKRxBxdwUfWFvVtyMjMn7vG7p0xAjYG5VE=.ecc0c3f4-8e18-4802-be5a-dc8be66b69a8@github.com> Message-ID: <Jg7S_fUo8sKm4ac_F8UX6SEJhHZXpAOyBLwHuB6Ptnc=.ac4700b4-e5a0-4067-ad02-d64d76893c01@github.com> On Wed, 6 Nov 2024 08:23:54 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8340387: Update OS detection code to recognize Windows Server 2025 This pull request has now been integrated. Changeset: d2b244d8 Author: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/d2b244d8de68caf911d0639abba802ead2620b2d Stats: 11 lines in 2 files changed: 8 ins; 0 del; 3 mod 8340387: Update OS detection code to recognize Windows Server 2025 Backport-of: 34cddfbedd20d5804cab8044fbc402564e98eb9c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3029 From goetz at openjdk.org Thu Nov 7 13:54:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 13:54:56 GMT Subject: [jdk21u-dev] RFR: 8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" Message-ID: <pdFcTkReD1gzLFhnqNvMOC8O6zkvn0fTjEJfDNlp-GU=.b98b3440-bf2c-48ce-a39d-3340f07e8c1e@github.com> I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport 28b201955907e145f208d756b607ab545a83b2d3 Changes: https://git.openjdk.org/jdk21u-dev/pull/1139/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1139&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8240343 Stats: 34 lines in 3 files changed: 6 ins; 28 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1139.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1139/head:pull/1139 PR: https://git.openjdk.org/jdk21u-dev/pull/1139 From goetz at openjdk.org Thu Nov 7 13:56:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 13:56:20 GMT Subject: [jdk17u-dev] RFR: 8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" Message-ID: <V2wWHDprRqdkaYxhepge2-bCUDNVQZo3xJll8WDbaik=.a98b8bbb-0473-4ea9-992a-7e5131c3230f@github.com> I backport this for parity with 17.0.13-oracle ------------- Commit messages: - Backport 28b201955907e145f208d756b607ab545a83b2d3 Changes: https://git.openjdk.org/jdk17u-dev/pull/3035/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3035&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8240343 Stats: 34 lines in 3 files changed: 6 ins; 28 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3035.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3035/head:pull/3035 PR: https://git.openjdk.org/jdk17u-dev/pull/3035 From goetz at openjdk.org Thu Nov 7 14:06:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 14:06:17 GMT Subject: [jdk21u-dev] RFR: 8330278: Have SSLSocketTemplate.doClientSide use loopback address Message-ID: <BlK49r7EbP902iJ0ZdSbOxs9kuPmlEFY6ONPRYuVuzI=.1958ae1a-f36f-48ca-9091-014408681f8b@github.com> I backport this for parity with 21.0.6-oracle. Resolved import in TLSBase. Probably clean. ------------- Commit messages: - Backport 0eff492e4107abc5624f0c3445877bf38629a980 Changes: https://git.openjdk.org/jdk21u-dev/pull/1140/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1140&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330278 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1140.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1140/head:pull/1140 PR: https://git.openjdk.org/jdk21u-dev/pull/1140 From goetz at openjdk.org Thu Nov 7 14:10:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 14:10:37 GMT Subject: [jdk17u-dev] RFR: 8330278: Have SSLSocketTemplate.doClientSide use loopback address Message-ID: <Vb89NL44sxTbvg_G2GS_B-J2xva10sGZyOo7_dNUpIw=.8f98e141-e384-49aa-af60-819a281d0125@github.com> I backport this for parity with 17.0.14-oracle Resolved import, probably clean. ------------- Commit messages: - Backport 0eff492e4107abc5624f0c3445877bf38629a980 Changes: https://git.openjdk.org/jdk17u-dev/pull/3036/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3036&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330278 Stats: 177 lines in 5 files changed: 170 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3036.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3036/head:pull/3036 PR: https://git.openjdk.org/jdk17u-dev/pull/3036 From phh at openjdk.org Thu Nov 7 15:57:49 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 7 Nov 2024 15:57:49 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> References: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> Message-ID: <rn8UzJALDvr6WxI3yJM3F9wxmlSzU-r4x8_S7ILbQVo=.7a3948c1-2135-4fb6-af5d-c80dd4064fc1@github.com> On Tue, 5 Nov 2024 18:49:17 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote: >> This change improves annotation processing test coverage, see [JDK-8336942](https://bugs.openjdk.org/browse/JDK-8336942). I resolved a trivial merge conflict with JDK-8323684, which added the `nameToAnnotation` map. The modified test passes. > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 > - 8336942: Improve test coverage for class loading elements with annotations of different retentions > > Reviewed-by: vromero Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2955#pullrequestreview-2421407527 From syan at openjdk.org Thu Nov 7 15:57:50 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 7 Nov 2024 15:57:50 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags In-Reply-To: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> Message-ID: <9OkdVECbT2LaevIOArFb04TL9qebfyNNz4_M4y1EAao=.a1a0e9bf-0882-450d-87ce-36c885f6dfd6@github.com> On Tue, 9 Jul 2024 07:17:51 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. > > The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. > > Thanks! wait wait ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2326379850 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2444079671 From goetz at openjdk.org Thu Nov 7 15:57:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 15:57:51 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags In-Reply-To: <9OkdVECbT2LaevIOArFb04TL9qebfyNNz4_M4y1EAao=.a1a0e9bf-0882-450d-87ce-36c885f6dfd6@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <9OkdVECbT2LaevIOArFb04TL9qebfyNNz4_M4y1EAao=.a1a0e9bf-0882-450d-87ce-36c885f6dfd6@github.com> Message-ID: <qtbnFPwbj_WOaiikycxOGcLvBKhP0IGEb149xRnuZhs=.e45a1bbd-2b74-4ce8-bd5b-6de5426c233a@github.com> On Tue, 29 Oct 2024 12:30:38 GMT, SendaoYan <syan at openjdk.org> wrote: >> Hi all, >> >> This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. >> >> The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. >> >> Thanks! > > wait Hi @sendaoYan, what's up with this backport? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2462272885 From syan at openjdk.org Thu Nov 7 16:01:01 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 7 Nov 2024 16:01:01 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v2] In-Reply-To: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> Message-ID: <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> > Hi all, > > This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. > > The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. > > Thanks! SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-sendaoYan-43029006-master - Backport 430290066c23d09166a84f2f6f89e770c6ba04ff ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/830/files - new: https://git.openjdk.org/jdk21u-dev/pull/830/files/199b8d3b..e479a477 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=830&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=830&range=00-01 Stats: 40611 lines in 683 files changed: 29070 ins; 7900 del; 3641 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/830.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/830/head:pull/830 PR: https://git.openjdk.org/jdk21u-dev/pull/830 From syan at openjdk.org Thu Nov 7 16:09:46 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 7 Nov 2024 16:09:46 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags In-Reply-To: <9OkdVECbT2LaevIOArFb04TL9qebfyNNz4_M4y1EAao=.a1a0e9bf-0882-450d-87ce-36c885f6dfd6@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <9OkdVECbT2LaevIOArFb04TL9qebfyNNz4_M4y1EAao=.a1a0e9bf-0882-450d-87ce-36c885f6dfd6@github.com> Message-ID: <vUwLrYN0wDuiJ4Uxh7Yo6VklVqncub047uy1x8STto8=.90085c85-3aca-4ac2-af1d-ac2376b9cb02@github.com> On Tue, 29 Oct 2024 12:30:38 GMT, SendaoYan <syan at openjdk.org> wrote: >> Hi all, >> >> This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. >> >> The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. >> >> Thanks! > > wait > Hi @sendaoYan, what's up with this backport? I think I just mistake the PR status. I make this PR as ready now. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2462620528 From syan at openjdk.org Thu Nov 7 16:09:49 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 7 Nov 2024 16:09:49 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v2] In-Reply-To: <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> Message-ID: <XPng3KQFi9DFohEJ5VTpOv1Pggw0p6xFeURv62QqxeU=.19096a2c-f536-400f-b38f-f02a7c5e5bc0@github.com> On Thu, 7 Nov 2024 16:01:01 GMT, SendaoYan <syan at openjdk.org> wrote: >> Hi all, >> >> This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. >> >> The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. >> >> Thanks! > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-43029006-master > - Backport 430290066c23d09166a84f2f6f89e770c6ba04ff I will verify the jtreg tests again then create approval request later. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2462624835 From goetz at openjdk.org Thu Nov 7 18:17:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Nov 2024 18:17:54 GMT Subject: [jdk21u-dev] RFR: 8332112: Update nsk.share.Log to don't print summary during VM shutdown hook Message-ID: <EVSnPYlBJyGPua2OZEutV_K0nMKFIqSkAprixAluPLc=.47f3fcc4-e37d-46d3-9f1a-e02e3adcf94a@github.com> I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport 61aff6db15d5bdda77427af5ce34d0fe43373197 Changes: https://git.openjdk.org/jdk21u-dev/pull/1141/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1141&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332112 Stats: 168 lines in 30 files changed: 2 ins; 134 del; 32 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1141.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1141/head:pull/1141 PR: https://git.openjdk.org/jdk21u-dev/pull/1141 From duke at openjdk.org Thu Nov 7 19:15:54 2024 From: duke at openjdk.org (fitzsim) Date: Thu, 7 Nov 2024 19:15:54 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> References: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> Message-ID: <eZzcpvkqLSM8DDT2Tt-PhZg-X76bFORdz0ePeYeHeb4=.9dfbf019-12ff-4f21-9e40-9613983f2b78@github.com> On Tue, 5 Nov 2024 18:49:17 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote: >> This change improves annotation processing test coverage, see [JDK-8336942](https://bugs.openjdk.org/browse/JDK-8336942). I resolved a trivial merge conflict with JDK-8323684, which added the `nameToAnnotation` map. The modified test passes. > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 > - 8336942: Improve test coverage for class loading elements with annotations of different retentions > > Reviewed-by: vromero _I am not a Reviewer; I maintain `java-17-openjdk` in `RHEL` so I try to review `rfr`-labelled pull requests for `jdk17u-dev`, time-permitting._ This looks like a good change to have in 17. I tested it on `Fedora 41 x86_64`. While trying this out, I noticed a potential oddity regarding `BasicAnnoTests.java`: the first of the two `Test` annotations does not seem to take effect. For example, I would expect that changing: `@Test(posn=0, annoType=TA.class, expect="1")` to: `@Test(posn=0, annoType=TA.class, expect="33")` would cause a failure, but it does not. Am I missing something? I am testing with jtreg `857ed6167418cb4ebe2844fd536461a1649bdced` running on `jdk-17.0.13+11`. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2463022522 From dhanalla at openjdk.org Fri Nov 8 01:20:36 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Fri, 8 Nov 2024 01:20:36 GMT Subject: [jdk23u] RFR: 8338136: Hotspot should support multiple large page sizes on Windows Message-ID: <Qk4FG7KXxa-cnYVQGb-l2X1X_f2t3z6_tv6mkY3aWVY=.2dc83de0-11bc-47f9-9578-4f87b1562525@github.com> 8338136: Hotspot should support multiple large page sizes on Windows ------------- Commit messages: - Backport 4ded28380b6756e0679d80706f76bd6e78c370b9 Changes: https://git.openjdk.org/jdk23u/pull/219/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=219&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338136 Stats: 154 lines in 4 files changed: 142 ins; 1 del; 11 mod Patch: https://git.openjdk.org/jdk23u/pull/219.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/219/head:pull/219 PR: https://git.openjdk.org/jdk23u/pull/219 From syan at openjdk.org Fri Nov 8 03:31:45 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 03:31:45 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v2] In-Reply-To: <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> Message-ID: <7JOQ4OwVM-HIAg9-ePO9Mg7Jf5NaHWkYTcIdo6Ge794=.6a3e7638-e0f6-4502-92ee-c1e0641e3346@github.com> On Thu, 7 Nov 2024 16:01:01 GMT, SendaoYan <syan at openjdk.org> wrote: >> Hi all, >> >> This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. >> >> The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. >> >> Thanks! > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-43029006-master > - Backport 430290066c23d09166a84f2f6f89e770c6ba04ff This backport will generate below javac compiler error, caused by new API `Path resolve(String first, String... more)` was not supported in jdk21u-dev Should we integrate this PR first, and then create a new PR to fix the compiler error. /tmp/tone/run/jtreg/jdk-repo/test/jdk/java/security/Security/ConfigFileTest.java:57: error: no suitable method found for resolve(String,String) private static Path COPIED_JAVA = COPY_JDK_DIR.resolve("bin", "java"); ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2463677848 From goetz at openjdk.org Fri Nov 8 07:22:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 07:22:59 GMT Subject: [jdk21u-dev] RFR: 8327924: Simplify TrayIconScalingTest.java In-Reply-To: <E2miutZguydI-Gg5l78FpB5_mqv-mmiroxMuNRQE7rY=.1e86c3e1-7da4-4e11-8952-2dd2ca8f95b8@github.com> References: <E2miutZguydI-Gg5l78FpB5_mqv-mmiroxMuNRQE7rY=.1e86c3e1-7da4-4e11-8952-2dd2ca8f95b8@github.com> Message-ID: <UzYBznJtHUNTdmQViMzy5tBdFLU-PxdjCMzk3VCVJZo=.a5475b5c-9ecc-4a44-bf65-b9f01f4048a2@github.com> On Thu, 7 Nov 2024 09:33:50 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. Infra issue. Creation of sysroot failed. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1133#issuecomment-2463939464 From goetz at openjdk.org Fri Nov 8 07:27:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 07:27:32 GMT Subject: [jdk17u-dev] RFR: 8327924: Simplify TrayIconScalingTest.java In-Reply-To: <7Sf68DPSirIJfL39eZrOum-6Bkrd5WTIXbARoS29Bew=.3bd2e692-5049-45aa-801e-5b33faea0b70@github.com> References: <7Sf68DPSirIJfL39eZrOum-6Bkrd5WTIXbARoS29Bew=.3bd2e692-5049-45aa-801e-5b33faea0b70@github.com> Message-ID: <zcQd1B5HqXNfCK7fNqXdAq6mkVB6hQBgbfdTG45iq58=.c8911856-0adf-4c34-89e1-bf2b40f344e3@github.com> On Thu, 7 Nov 2024 09:34:02 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle GHA failure: infra issue, build setup failed. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3032#issuecomment-2463943585 From goetz at openjdk.org Fri Nov 8 07:29:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 07:29:32 GMT Subject: [jdk21u-dev] RFR: 8308429: jvmti/StopThread/stopthrd007 failed with "NoClassDefFoundError: Could not initialize class jdk.internal.misc.VirtualThreads" In-Reply-To: <lJLB4xckDKlLdbNF2gnV3CUG9b4WpWRV3etxrbvsoeA=.01a73c23-4246-4b12-9419-095a37676685@github.com> References: <lJLB4xckDKlLdbNF2gnV3CUG9b4WpWRV3etxrbvsoeA=.01a73c23-4246-4b12-9419-095a37676685@github.com> Message-ID: <7gD1Ro9eNiRXYe4DuedwaahtyRTb2vtCuzphu99xD4k=.45e9fcf6-8a5f-447f-b244-9fdb834f8546@github.com> On Thu, 7 Nov 2024 09:45:36 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. GHA failure: various infra issues, Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1134#issuecomment-2463946814 From goetz at openjdk.org Fri Nov 8 07:30:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 07:30:28 GMT Subject: [jdk21u-dev] RFR: 8325038: runtime/cds/appcds/ProhibitedPackage.java can fail with UseLargePages In-Reply-To: <WgEIQ7avCLCXpAnb-31j8kwCAYIZB1sQxvJkSeQ1xuE=.c6428f36-d52f-455b-986f-7b4527b6e7f2@github.com> References: <WgEIQ7avCLCXpAnb-31j8kwCAYIZB1sQxvJkSeQ1xuE=.c6428f36-d52f-455b-986f-7b4527b6e7f2@github.com> Message-ID: <FhCXiMVMZ8h1C9kut-HjuP7zKVX5D3NpvIU0lkTXMDc=.5c412b9a-338d-4e1a-99f1-012e04c24dac@github.com> On Thu, 7 Nov 2024 09:51:51 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. GHA failure: infra issue, unrelated. code-select: error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' Error: Process completed with exit code 1. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1135#issuecomment-2463948384 From goetz at openjdk.org Fri Nov 8 07:49:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 07:49:20 GMT Subject: [jdk21u-dev] RFR: 8333235: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with C1 In-Reply-To: <JHn-WzVTZbLGLZbmNLDDDDEFNpYljaGxXSs2Cd3ygnI=.f2a2f902-2045-46d3-8b46-c12750fff90c@github.com> References: <JHn-WzVTZbLGLZbmNLDDDDEFNpYljaGxXSs2Cd3ygnI=.f2a2f902-2045-46d3-8b46-c12750fff90c@github.com> Message-ID: <_GNOEuWC_nfEvj18aMkc7Y6_OpSX3dIApxHOaU9ZK4Y=.00e0639b-c5f6-4749-b4d2-c155457a750d@github.com> On Thu, 7 Nov 2024 10:00:34 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. GHA failure: infra issue, unrelated. xcode-select: error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' Error: Process completed with exit code 1. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1136#issuecomment-2463951135 From goetz at openjdk.org Fri Nov 8 07:49:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 07:49:27 GMT Subject: [jdk21u-dev] RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property In-Reply-To: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> References: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> Message-ID: <RWnXKJ5StwrOKaFjGnVVSoxdhLEHpzzZrn8LqHolHgc=.a732cd56-d32f-4851-bb58-7aafc37f5427@github.com> On Thu, 7 Nov 2024 13:07:52 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > I resolved two files: > test/jdk/sun/security/mscapi/InteropWithSunRsaSign.java > Copyright > > test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java > Resolved because 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode not in 21. > > Tests all pass except for three I skipped: > test/jdk/sun/security/pkcs11/rsa/GenKeyStore.java > test/jdk/sun/security/rsa/GenKeyStore.java > test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilHmacSHA1.java > Checked the change in these files. GHA failure: various infra issues. Unrelated. Will try to restart subtests anyways, as this is a large change. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1138#issuecomment-2463963026 From goetz at openjdk.org Fri Nov 8 07:49:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 07:49:30 GMT Subject: [jdk17u-dev] RFR: 8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp In-Reply-To: <S0s8pXqP9pxM23zHpRmc1jyCBii9kst8xx5fja4xQqI=.c291bcc0-1c51-4f37-a14e-28e1716db2b0@github.com> References: <S0s8pXqP9pxM23zHpRmc1jyCBii9kst8xx5fja4xQqI=.c291bcc0-1c51-4f37-a14e-28e1716db2b0@github.com> Message-ID: <UEOWIR1730JJLbhkyh4I4lic_1dFJ0hNGmL3MCcaWx4=.e4b75679-6e8b-4eab-95de-88bff2667f4c@github.com> On Thu, 7 Nov 2024 10:42:29 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle, GHA failure: mac: infra issue, linux: build of JVM aborted. Unrelated, this is a test only change. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3034#issuecomment-2463959158 From goetz at openjdk.org Fri Nov 8 07:49:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 07:49:31 GMT Subject: [jdk21u-dev] RFR: 8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp In-Reply-To: <N4sGTnQRqTtlwCDelw16EptbYuqZZE6njYfqOB6vfOk=.535db45c-88d3-4e32-904d-50a4217d898f@github.com> References: <N4sGTnQRqTtlwCDelw16EptbYuqZZE6njYfqOB6vfOk=.535db45c-88d3-4e32-904d-50a4217d898f@github.com> Message-ID: <rGDGqjtSK1cuTJRYr7jPS5yY6ai3HkSspJCysSCHQMo=.d90ddfa1-f09d-413c-ba4b-a4fb69f252e7@github.com> On Thu, 7 Nov 2024 10:41:53 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. GHA failure: both infra issues, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1137#issuecomment-2463953008 From goetz at openjdk.org Fri Nov 8 07:49:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 07:49:32 GMT Subject: [jdk17u-dev] RFR: 8325038: runtime/cds/appcds/ProhibitedPackage.java can fail with UseLargePages In-Reply-To: <2iI1BwH7Wz9L2dxcRHZd9KRaGZ7mhIeVh5itRhJ8148=.20a9d04b-4902-4210-9a01-d345ca9904a6@github.com> References: <2iI1BwH7Wz9L2dxcRHZd9KRaGZ7mhIeVh5itRhJ8148=.20a9d04b-4902-4210-9a01-d345ca9904a6@github.com> Message-ID: <m314_Ra8oSbrZGk3wZtYwGfCYZUZSFX9zXL4r3sHRHw=.0fdad3d2-5eb7-428f-8273-b176d872a7c1@github.com> On Thu, 7 Nov 2024 09:52:00 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle GHA failure: infra issue, unrelated. xcode-select: error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' Error: Process completed with exit code 1. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3033#issuecomment-2463949632 From goetz at openjdk.org Fri Nov 8 07:57:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 07:57:23 GMT Subject: [jdk21u-dev] RFR: 8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" In-Reply-To: <pdFcTkReD1gzLFhnqNvMOC8O6zkvn0fTjEJfDNlp-GU=.b98b3440-bf2c-48ce-a39d-3340f07e8c1e@github.com> References: <pdFcTkReD1gzLFhnqNvMOC8O6zkvn0fTjEJfDNlp-GU=.b98b3440-bf2c-48ce-a39d-3340f07e8c1e@github.com> Message-ID: <RAYYeTCUbdsRzxx9yeOqqFHsd5ivmfhkFurecadwzt4=.9d90afc9-8ecb-41f6-9732-171f8967c444@github.com> On Thu, 7 Nov 2024 13:49:44 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.5-oracle. GHA failure: infra issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1139#issuecomment-2463986010 From goetz at openjdk.org Fri Nov 8 08:00:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 08:00:33 GMT Subject: [jdk21u-dev] RFR: 8330278: Have SSLSocketTemplate.doClientSide use loopback address In-Reply-To: <BlK49r7EbP902iJ0ZdSbOxs9kuPmlEFY6ONPRYuVuzI=.1958ae1a-f36f-48ca-9091-014408681f8b@github.com> References: <BlK49r7EbP902iJ0ZdSbOxs9kuPmlEFY6ONPRYuVuzI=.1958ae1a-f36f-48ca-9091-014408681f8b@github.com> Message-ID: <iQd21Xf-p_mF7QXP4IJCTo-EG8rpmaCyeNz_8yBNeDk=.9bc18083-6a9b-418e-a286-59d11a1875c4@github.com> On Thu, 7 Nov 2024 13:59:59 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > Resolved import in TLSBase. Probably clean. GHA failures: various infra issues, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1140#issuecomment-2463989074 From goetz at openjdk.org Fri Nov 8 08:05:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 08:05:15 GMT Subject: [jdk17u-dev] RFR: 8330278: Have SSLSocketTemplate.doClientSide use loopback address [v2] In-Reply-To: <Vb89NL44sxTbvg_G2GS_B-J2xva10sGZyOo7_dNUpIw=.8f98e141-e384-49aa-af60-819a281d0125@github.com> References: <Vb89NL44sxTbvg_G2GS_B-J2xva10sGZyOo7_dNUpIw=.8f98e141-e384-49aa-af60-819a281d0125@github.com> Message-ID: <D5q5_CXKQ84KdmQ1T1eGRPiD0PDzgbBCKBcbwnghufk=.14c50a90-27e3-4fe2-92a9-ebb08c2ecaba@github.com> > I backport this for parity with 17.0.14-oracle > > Resolved import, probably clean. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 0eff492e4107abc5624f0c3445877bf38629a980 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3036/files - new: https://git.openjdk.org/jdk17u-dev/pull/3036/files/9a6cfe9e..30c3660d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3036&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3036&range=00-01 Stats: 173 lines in 3 files changed: 0 ins; 169 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3036.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3036/head:pull/3036 PR: https://git.openjdk.org/jdk17u-dev/pull/3036 From syan at openjdk.org Fri Nov 8 08:05:34 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 08:05:34 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v2] In-Reply-To: <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> Message-ID: <n5sc42bjltYKF5Y1qBp65VIAw2SxrjshUMRrEx3OM6Q=.9415986c-19f7-46b2-a2ae-3d871bf7489d@github.com> On Thu, 7 Nov 2024 16:01:01 GMT, SendaoYan <syan at openjdk.org> wrote: >> Hi all, >> >> This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. >> >> The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. >> >> Thanks! > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-43029006-master > - Backport 430290066c23d09166a84f2f6f89e770c6ba04ff GHA report `install some dependencies` failure in macos-aarch64, it seems like envirnmental issue, it's unrelrated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2463991998 From syan at openjdk.org Fri Nov 8 08:05:34 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 08:05:34 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v2] In-Reply-To: <n5sc42bjltYKF5Y1qBp65VIAw2SxrjshUMRrEx3OM6Q=.9415986c-19f7-46b2-a2ae-3d871bf7489d@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> <n5sc42bjltYKF5Y1qBp65VIAw2SxrjshUMRrEx3OM6Q=.9415986c-19f7-46b2-a2ae-3d871bf7489d@github.com> Message-ID: <xCrH7RWUnkf0Z3XS3wThdhZB9ZARdJhYe2IMsgGebio=.258f6c8b-71e7-4029-a06f-f27d5f8c8f92@github.com> On Fri, 8 Nov 2024 07:58:41 GMT, SendaoYan <syan at openjdk.org> wrote: >> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: >> >> - Merge branch 'openjdk:master' into backport-sendaoYan-43029006-master >> - Backport 430290066c23d09166a84f2f6f89e770c6ba04ff > > GHA report `install some dependencies` failure in macos-aarch64, it seems like envirnmental issue, it's unrelrated to this PR. > Hi @sendaoYan, what's up with this backport? This backport will cause test `java/security/Security/ConfigFileTest.java` compile error, because new API Path resolve(String first, String... more) was not supported in jdk21u-dev. Should I integrate this backport, and then create a new PR to fix the error right away. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2463997968 From goetz at openjdk.org Fri Nov 8 08:07:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 08:07:09 GMT Subject: [jdk21u-dev] RFR: 8332112: Update nsk.share.Log to don't print summary during VM shutdown hook In-Reply-To: <EVSnPYlBJyGPua2OZEutV_K0nMKFIqSkAprixAluPLc=.47f3fcc4-e37d-46d3-9f1a-e02e3adcf94a@github.com> References: <EVSnPYlBJyGPua2OZEutV_K0nMKFIqSkAprixAluPLc=.47f3fcc4-e37d-46d3-9f1a-e02e3adcf94a@github.com> Message-ID: <kOTSlXIZYl94zzu1QcPrFLEka-wVod5W5SrTzMTWE48=.bb626357-6e6a-48d3-8dd8-792780c3cbb3@github.com> On Thu, 7 Nov 2024 18:11:48 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.5-oracle. GHA failure: linux-x64: infra issue, unrelated. (Error: sh][ERROR] wget exited with exit code 4) Two tests pending. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1141#issuecomment-2464000600 From goetz at openjdk.org Fri Nov 8 08:40:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 08:40:17 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v2] In-Reply-To: <xCrH7RWUnkf0Z3XS3wThdhZB9ZARdJhYe2IMsgGebio=.258f6c8b-71e7-4029-a06f-f27d5f8c8f92@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> <n5sc42bjltYKF5Y1qBp65VIAw2SxrjshUMRrEx3OM6Q=.9415986c-19f7-46b2-a2ae-3d871bf7489d@github.com> <xCrH7RWUnkf0Z3XS3wThdhZB9ZARdJhYe2IMsgGebio=.258f6c8b-71e7-4029-a06f-f27d5f8c8f92@github.com> Message-ID: <ZrbrxsfGXrIkQHLKk7zj3sOz7PUGuhHg-Yx1VGZq-PQ=.a2811570-3fdc-490d-b9f7-6cecabfeb1ba@github.com> On Fri, 8 Nov 2024 08:01:45 GMT, SendaoYan <syan at openjdk.org> wrote: >> GHA report `install some dependencies` failure in macos-aarch64, it seems like envirnmental issue, it's unrelrated to this PR. > >> Hi @sendaoYan, what's up with this backport? > > This backport will cause test `java/security/Security/ConfigFileTest.java` compile error, because new API Path resolve(String first, String... more) was not supported in jdk21u-dev. > Should I integrate this backport, and then create a new PR to fix the error right away. Hi @sendaoYan, this is a normal thing happening with backports. We don't file extra bugs for this. If it was clean before, it is best to push an extra commit on top of the original backport, explain in detail in the PR what and why it was edited, and include a short remark in the approval comment that it had to be adapted to 21. (This hints the person backporting to 17 to base the backport on the 21 commit). ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2464128667 From syan at openjdk.org Fri Nov 8 08:48:37 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 08:48:37 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v2] In-Reply-To: <xCrH7RWUnkf0Z3XS3wThdhZB9ZARdJhYe2IMsgGebio=.258f6c8b-71e7-4029-a06f-f27d5f8c8f92@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> <n5sc42bjltYKF5Y1qBp65VIAw2SxrjshUMRrEx3OM6Q=.9415986c-19f7-46b2-a2ae-3d871bf7489d@github.com> <xCrH7RWUnkf0Z3XS3wThdhZB9ZARdJhYe2IMsgGebio=.258f6c8b-71e7-4029-a06f-f27d5f8c8f92@github.com> Message-ID: <g_sveZSEQLL2hbxYUN7WAmW1x7e54kaEHrAnA8iVIro=.44d30759-312e-4c07-b021-55fc37b1ae10@github.com> On Fri, 8 Nov 2024 08:01:45 GMT, SendaoYan <syan at openjdk.org> wrote: >> GHA report `install some dependencies` failure in macos-aarch64, it seems like envirnmental issue, it's unrelrated to this PR. > >> Hi @sendaoYan, what's up with this backport? > > This backport will cause test `java/security/Security/ConfigFileTest.java` compile error, because new API Path resolve(String first, String... more) was not supported in jdk21u-dev. > Should I integrate this backport, and then create a new PR to fix the error right away. > Hi @sendaoYan, this is a normal thing happening with backports. We don't file extra bugs for this. If it was clean before, it is best to push an extra commit on top of the original backport, explain in detail in the PR what and why it was edited, and include a short remark in the approval comment that it had to be adapted to 21. (This hints the person backporting to 17 to base the backport on the 21 commit). Thanks for the detail advice. I will create a new PR to backport plus fix the compile error. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2464142193 From syan at openjdk.org Fri Nov 8 09:02:55 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 09:02:55 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags Message-ID: <Qk_XKv2pj5CkmC4ajymNnkbOvqQZPBDAMLND9OmI1Zo=.1dc2d4cf-92bc-4968-a6e9-da642d066746@github.com> Hi all, This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. The new API `Path resolve(String first, String... more)` was not supported in jdk21u-dev, so I change the line code from `COPY_JDK_DIR.resolve("bin", "java")` to `COPY_JDK_DIR.resolve("bin").resolve("java")` to avoid jdk21 javac genrate compile error, and make this backport uncleanly, all other parts are backport cleanly. The change has been verified locally, test-fix only, no risk. Thanks! ------------- Commit messages: - Backport 430290066c23d09166a84f2f6f89e770c6ba04ff - 8319673: Few security tests ignore VM flags Changes: https://git.openjdk.org/jdk21u-dev/pull/1142/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1142&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319673 Stats: 49 lines in 3 files changed: 12 ins; 13 del; 24 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1142.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1142/head:pull/1142 PR: https://git.openjdk.org/jdk21u-dev/pull/1142 From syan at openjdk.org Fri Nov 8 09:03:19 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 09:03:19 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v2] In-Reply-To: <g_sveZSEQLL2hbxYUN7WAmW1x7e54kaEHrAnA8iVIro=.44d30759-312e-4c07-b021-55fc37b1ae10@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> <n5sc42bjltYKF5Y1qBp65VIAw2SxrjshUMRrEx3OM6Q=.9415986c-19f7-46b2-a2ae-3d871bf7489d@github.com> <xCrH7RWUnkf0Z3XS3wThdhZB9ZARdJhYe2IMsgGebio=.258f6c8b-71e7-4029-a06f-f27d5f8c8f92@github.com> <g_sveZSEQLL2hbxYUN7WAmW1x7e54kaEHrAnA8iVIro=.44d30759-312e-4c07-b021-55fc37b1ae10@github.com> Message-ID: <Z2DPhokz7s-VMvlsSXC3pRrxO6XRQBSlMibDLZZQGOg=.754a7cff-4782-47c2-8de8-35c3ae615f01@github.com> On Fri, 8 Nov 2024 08:44:46 GMT, SendaoYan <syan at openjdk.org> wrote: > Thanks for the detail advice. I will create a new PR to backport plus fix the compile error. The new PR https://github.com/openjdk/jdk21u-dev/pull/1142 has been created, close this as duplicated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2464169799 From syan at openjdk.org Fri Nov 8 09:03:19 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 09:03:19 GMT Subject: [jdk21u-dev] Withdrawn: 8319673: Few security tests ignore VM flags In-Reply-To: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> Message-ID: <lPP-XKe--ocXNYrJZ0UyK0aFXNbe-dXTYeyNoNSix1I=.afdd6f31-08af-4f1e-9ebf-9b0c409e5fd7@github.com> On Tue, 9 Jul 2024 07:17:51 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. > > The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/830 From goetz at openjdk.org Fri Nov 8 09:06:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 09:06:35 GMT Subject: [jdk17u-dev] RFR: 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature Message-ID: <XWOMzBfdp_YETZWXwmDssUw3Id4u33d8Lwyw9twZRI0=.af078778-e8b6-43b2-969f-8424d1d71173@github.com> I backport this for parity with 17.0.14-oracle. I verified that the ProblemList change, which is omitted in 21, is not needed in 17 either. ------------- Commit messages: - Backport d7c85b194dcb2c312afe18e62a87b1708d4f14bb Changes: https://git.openjdk.org/jdk17u-dev/pull/3037/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3037&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333317 Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3037.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3037/head:pull/3037 PR: https://git.openjdk.org/jdk17u-dev/pull/3037 From goetz at openjdk.org Fri Nov 8 09:08:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 09:08:13 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v2] In-Reply-To: <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> Message-ID: <zejUVdlJ9Ry9us0qoZgy3hoR91WTFbAs-VoiU4-QLNo=.60839398-346e-439d-894b-4299d20aa7f5@github.com> On Thu, 7 Nov 2024 16:01:01 GMT, SendaoYan <syan at openjdk.org> wrote: >> Hi all, >> >> This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. >> >> The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. >> >> Thanks! > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-43029006-master > - Backport 430290066c23d09166a84f2f6f89e770c6ba04ff Hi, you don't need a new pr, just push a fix to this branch. The fix is simple enough, you can just edit it in the web. Locally, you can check out origin/pr/830 and double-check on it if needed. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2464178807 From syan at openjdk.org Fri Nov 8 09:37:28 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 09:37:28 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v2] In-Reply-To: <zejUVdlJ9Ry9us0qoZgy3hoR91WTFbAs-VoiU4-QLNo=.60839398-346e-439d-894b-4299d20aa7f5@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> <zejUVdlJ9Ry9us0qoZgy3hoR91WTFbAs-VoiU4-QLNo=.60839398-346e-439d-894b-4299d20aa7f5@github.com> Message-ID: <jPdNNxDw1ezehxRxv7Yy5q_hODytKCN4WbeL12xvAYY=.0d7790c9-6b30-4adc-ac9e-1fde0e9fcca5@github.com> On Fri, 8 Nov 2024 09:04:25 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > Hi, you don't need a new pr, just push a fix to this branch. The fix is simple enough, you can just edit it in the web. Locally, you can check out origin/pr/830 and double-check on it if needed. Hi, I can't edit the code in the web. Seems like I don't have enough permission.  ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2464235473 From syan at openjdk.org Fri Nov 8 09:47:15 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 09:47:15 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v3] In-Reply-To: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> Message-ID: <FRk1kNb6VseLuEwe2SjE555xQi9N3X6vMDf7k3m43CI=.1b1609b5-223b-4b9b-901d-3f2584a9e8dc@github.com> > Hi all, > > This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. > > The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. > > The new API `Path resolve(String first, String... more)` was not supported in jdk21u-dev, so I change the line code from `COPY_JDK_DIR.resolve("bin", "java")` to `COPY_JDK_DIR.resolve("bin").resolve("java")` to avoid jdk21 javac genrate compile error, and make this backport uncleanly, all other parts are backport cleanly. > > The change has been verified locally, test-fix only, no risk. > > Thanks! SendaoYan has updated the pull request incrementally with one additional commit since the last revision: change the line code from COPY_JDK_DIR.resolve("bin", "java") to COPY_JDK_DIR.resolve("bin").resolve("java") to avoid jdk21 javac genrate compile error ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/830/files - new: https://git.openjdk.org/jdk21u-dev/pull/830/files/e479a477..29167217 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=830&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=830&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/830.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/830/head:pull/830 PR: https://git.openjdk.org/jdk21u-dev/pull/830 From syan at openjdk.org Fri Nov 8 09:49:13 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 09:49:13 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags In-Reply-To: <Qk_XKv2pj5CkmC4ajymNnkbOvqQZPBDAMLND9OmI1Zo=.1dc2d4cf-92bc-4968-a6e9-da642d066746@github.com> References: <Qk_XKv2pj5CkmC4ajymNnkbOvqQZPBDAMLND9OmI1Zo=.1dc2d4cf-92bc-4968-a6e9-da642d066746@github.com> Message-ID: <B0oHq-xuM5P2lc-_5SBU7Gx2T4To3ufzb6a2fbCajNA=.03c61685-9741-4cc7-9c5b-fac98bda2939@github.com> On Fri, 8 Nov 2024 08:53:19 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. > > The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. > > The new API `Path resolve(String first, String... more)` was not supported in jdk21u-dev, so I change the line code from `COPY_JDK_DIR.resolve("bin", "java")` to `COPY_JDK_DIR.resolve("bin").resolve("java")` to avoid jdk21 javac genrate compile error, and make this backport uncleanly, all other parts are backport cleanly. > > The change has been verified locally, test-fix only, no risk. > > Thanks! Close this as duplicate to https://github.com/openjdk/jdk21u-dev/pull/830 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1142#issuecomment-2464257101 From syan at openjdk.org Fri Nov 8 09:49:13 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 09:49:13 GMT Subject: [jdk21u-dev] Withdrawn: 8319673: Few security tests ignore VM flags In-Reply-To: <Qk_XKv2pj5CkmC4ajymNnkbOvqQZPBDAMLND9OmI1Zo=.1dc2d4cf-92bc-4968-a6e9-da642d066746@github.com> References: <Qk_XKv2pj5CkmC4ajymNnkbOvqQZPBDAMLND9OmI1Zo=.1dc2d4cf-92bc-4968-a6e9-da642d066746@github.com> Message-ID: <TA5nO0UjlWsq0T8VEaZBG0DFcmTh9eLukj7yIXN3tSI=.1f6fe052-d6d0-4cf9-b918-5b41471c04f7@github.com> On Fri, 8 Nov 2024 08:53:19 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. > > The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. > > The new API `Path resolve(String first, String... more)` was not supported in jdk21u-dev, so I change the line code from `COPY_JDK_DIR.resolve("bin", "java")` to `COPY_JDK_DIR.resolve("bin").resolve("java")` to avoid jdk21 javac genrate compile error, and make this backport uncleanly, all other parts are backport cleanly. > > The change has been verified locally, test-fix only, no risk. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1142 From syan at openjdk.org Fri Nov 8 09:51:23 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 09:51:23 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v2] In-Reply-To: <zejUVdlJ9Ry9us0qoZgy3hoR91WTFbAs-VoiU4-QLNo=.60839398-346e-439d-894b-4299d20aa7f5@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <9oUTDdgmUHrT-wNKmwOg0Zx1aAfTI5yfwS41w600Fkc=.6020690c-20df-4f30-9d3a-598a6388e9a9@github.com> <zejUVdlJ9Ry9us0qoZgy3hoR91WTFbAs-VoiU4-QLNo=.60839398-346e-439d-894b-4299d20aa7f5@github.com> Message-ID: <YV-atMIfxbjNIgCmBKFFWtHJewwz8Rs0oLOliDHibtA=.768994e7-61fa-465e-aeb3-2562e51ba843@github.com> On Fri, 8 Nov 2024 09:04:25 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > Hi, you don't need a new pr, just push a fix to this branch. The fix is simple enough, you can just edit it in the web. Locally, you can check out origin/pr/830 and double-check on it if needed. Thanks for your patient advising. This PR has been updated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2464263522 From goetz at openjdk.org Fri Nov 8 11:15:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 11:15:16 GMT Subject: [jdk21u-dev] Integrated: 8320575: generic type information lost on mandated parameters of record's compact constructors In-Reply-To: <HL1ORhOoc8ZxLIpOBa_VIQPZBBnt1IcQ3vn1jlEfSp4=.8bd56034-61f5-4ead-a21b-10dfc48e9b51@github.com> References: <HL1ORhOoc8ZxLIpOBa_VIQPZBBnt1IcQ3vn1jlEfSp4=.8bd56034-61f5-4ead-a21b-10dfc48e9b51@github.com> Message-ID: <Pvxy1AXOXpfXbwTv7gZkLYv5enHIETdMiQWEBlGYDM8=.045eef90-fdf8-4c8a-bd88-1605b2247370@github.com> On Mon, 7 Oct 2024 07:56:28 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > As the CSR for 21 says, I omit the specification changes. > These make the description more precise. As I understand, > the change brought to 21 is ok with the broader, unchanged > specification. > > The rest applied clean. This pull request has now been integrated. Changeset: 582a2bef Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/582a2befafc87184a3eae51dc61ce6df6ccaf5c9 Stats: 369 lines in 3 files changed: 351 ins; 6 del; 12 mod 8320575: generic type information lost on mandated parameters of record's compact constructors Reviewed-by: mbaesken Backport-of: 7bf1989f59695c3d08b4bd116fb4c022cf9661f4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1026 From syan at openjdk.org Fri Nov 8 15:28:51 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 15:28:51 GMT Subject: [jdk11u-dev] RFR: 8224624: Inefficiencies in CodeStrings::add_comment cause timeouts [v2] In-Reply-To: <fDDFomdmY9aW5JfLtXuVBKmzD1cA48UIg0hwReMPpCU=.607fbd81-eadb-408c-a1d1-4e25e0194c0b@github.com> References: <L5CQvYGVLIILEqAqMSnKGKSCMCbj5bKp_MsGqMZW0MA=.f4d660ae-3196-43a6-b666-9fb829314dea@github.com> <fDDFomdmY9aW5JfLtXuVBKmzD1cA48UIg0hwReMPpCU=.607fbd81-eadb-408c-a1d1-4e25e0194c0b@github.com> Message-ID: <VNTfsoQhZ1CERu8CFkczTDBMSc_0gUTwPqNFtPWu4ck=.a46f9939-90ba-4700-a2bd-67f0b06223ed@github.com> On Tue, 15 Oct 2024 06:17:48 GMT, SendaoYan <syan at openjdk.org> wrote: >> Hi all, >> This is prefix backport of [JDK-8231058](https://bugs.openjdk.org/browse/JDK-8231058), after apply this backport will make backport of [JDK-8231058](https://bugs.openjdk.org/browse/JDK-8231058) cleanly. >> This PR improves C1 compiled time of the test `compiler/c1/TestLinearScanOrderMain.java` method dramatically from [92s to 1.8s](https://bugs.openjdk.org/browse/JDK-8224624), and solve this test intermittent timeout. >> >> Additonal testing: >> >> - [x] linux aarch64 build with release/slowdebug configure >> - [x] linux x86_64 build with release/slowdebug configure >> - [x] jtreg tests(include tier1/2/3 etc.) with release build on linux aarch64 >> - [x] jtreg tests(include tier1/2/3 etc.) with release build on linux x86_64 > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8224624 > - 8224624: Inefficiencies in CodeStrings::add_comment cause timeouts > > Changing CodeStrings to a doubly-linked-list and searching for the comment with the right offset in reverse. > > Reviewed-by: kvn Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2951#issuecomment-2465028584 From syan at openjdk.org Fri Nov 8 15:28:52 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 8 Nov 2024 15:28:52 GMT Subject: [jdk11u-dev] Integrated: 8224624: Inefficiencies in CodeStrings::add_comment cause timeouts In-Reply-To: <L5CQvYGVLIILEqAqMSnKGKSCMCbj5bKp_MsGqMZW0MA=.f4d660ae-3196-43a6-b666-9fb829314dea@github.com> References: <L5CQvYGVLIILEqAqMSnKGKSCMCbj5bKp_MsGqMZW0MA=.f4d660ae-3196-43a6-b666-9fb829314dea@github.com> Message-ID: <gmO8DjP9w2m2IN2ucmteKSc1FQu5BGDeUZj2V0Heq4g=.90dd2e48-0305-403e-b5c3-c5c8834088ed@github.com> On Tue, 15 Oct 2024 02:49:09 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > This is prefix backport of [JDK-8231058](https://bugs.openjdk.org/browse/JDK-8231058), after apply this backport will make backport of [JDK-8231058](https://bugs.openjdk.org/browse/JDK-8231058) cleanly. > This PR improves C1 compiled time of the test `compiler/c1/TestLinearScanOrderMain.java` method dramatically from [92s to 1.8s](https://bugs.openjdk.org/browse/JDK-8224624), and solve this test intermittent timeout. > > Additonal testing: > > - [x] linux aarch64 build with release/slowdebug configure > - [x] linux x86_64 build with release/slowdebug configure > - [x] jtreg tests(include tier1/2/3 etc.) with release build on linux aarch64 > - [x] jtreg tests(include tier1/2/3 etc.) with release build on linux x86_64 This pull request has now been integrated. Changeset: 96805ae9 Author: SendaoYan <syan at openjdk.org> URL: https://git.openjdk.org/jdk11u-dev/commit/96805ae97b5153b48d5fa5d1dac99a3763f9cde9 Stats: 32 lines in 2 files changed: 23 ins; 3 del; 6 mod 8224624: Inefficiencies in CodeStrings::add_comment cause timeouts Changing CodeStrings to a doubly-linked-list and searching for the comment with the right offset in reverse. Backport-of: 7cff981f5a3aa192e57545c7df069fb48ba69edf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2951 From lucy at openjdk.org Fri Nov 8 15:45:59 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 8 Nov 2024 15:45:59 GMT Subject: [jdk21u-dev] RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property In-Reply-To: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> References: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> Message-ID: <sYM1lSVObCoOH2eTfoKzj-H6mv5LlYhtm5Gh9IJPc8g=.5956189c-3d2a-4b66-91a6-b75ac666d56c@github.com> On Thu, 7 Nov 2024 13:07:52 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > I resolved two files: > test/jdk/sun/security/mscapi/InteropWithSunRsaSign.java > Copyright > > test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java > Resolved because 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode not in 21. > > Tests all pass except for three I skipped: > test/jdk/sun/security/pkcs11/rsa/GenKeyStore.java > test/jdk/sun/security/rsa/GenKeyStore.java > test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilHmacSHA1.java > Checked the change in these files. Looks almost good to me. Found one inconsistency (or typo?) in test/jdk/com/sun/crypto/provider/Cipher/RSA/TestOAEPPadding.java It is also present in JDK head revision. Not sure if it should be corrected here or fixed with a follow-up PR in head (and subsequent backport). ------------- Changes requested by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1138#pullrequestreview-2424139418 From lucy at openjdk.org Fri Nov 8 16:12:40 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 8 Nov 2024 16:12:40 GMT Subject: [jdk21u-dev] RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property In-Reply-To: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> References: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> Message-ID: <ajuimMnMk91B9UDMvggw4pZhddjboTAuVD2ECHcsPlk=.9935f9b2-8020-4a37-b2f5-14c6ef394bef@github.com> On Thu, 7 Nov 2024 13:07:52 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > I resolved two files: > test/jdk/sun/security/mscapi/InteropWithSunRsaSign.java > Copyright > > test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java > Resolved because 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode not in 21. > > Tests all pass except for three I skipped: > test/jdk/sun/security/pkcs11/rsa/GenKeyStore.java > test/jdk/sun/security/rsa/GenKeyStore.java > test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilHmacSHA1.java > Checked the change in these files. Typo cleanup delegated to a follow-up fix in head. Yes, this typo will only be noticed if the test is executed with a non-default provider. I will approve this PR. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1138#pullrequestreview-2424207550 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1138#issuecomment-2465135099 From goetz at openjdk.org Fri Nov 8 16:12:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 8 Nov 2024 16:12:41 GMT Subject: [jdk21u-dev] RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property In-Reply-To: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> References: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> Message-ID: <ZEs_zzF7sQH0ZAjGqKwIWCVYLo6JfqpakcEHP8lNm9g=.1acb9d9e-4332-426c-bb75-fe568d3d54cd@github.com> On Thu, 7 Nov 2024 13:07:52 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > I resolved two files: > test/jdk/sun/security/mscapi/InteropWithSunRsaSign.java > Copyright > > test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java > Resolved because 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode not in 21. > > Tests all pass except for three I skipped: > test/jdk/sun/security/pkcs11/rsa/GenKeyStore.java > test/jdk/sun/security/rsa/GenKeyStore.java > test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilHmacSHA1.java > Checked the change in these files. Nice finding! I think it should be fixed in head. I will double check and open an issue in head and bring that to 21 later on. But the test works anyways, as the default string is used if the propery is empty. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1138#issuecomment-2465127715 From duke at openjdk.org Fri Nov 8 18:14:53 2024 From: duke at openjdk.org (duke) Date: Fri, 8 Nov 2024 18:14:53 GMT Subject: [jdk11u-dev] RFR: 8339470: [17u] More defensive fix for 8163921 In-Reply-To: <qfiYp3f86zO4JnKeyhP-3Ao3h5dkeiclWSVPltnsi-A=.3d4a4526-df03-489e-ba15-4feba24ea9f8@github.com> References: <qfiYp3f86zO4JnKeyhP-3Ao3h5dkeiclWSVPltnsi-A=.3d4a4526-df03-489e-ba15-4feba24ea9f8@github.com> Message-ID: <uWn3bkshAh-g0JR-VUcLlHaAqO_dSHXtAt9XslP1Od0=.2c8a2bc3-c631-4da5-aefd-a2fdc85b9478@github.com> On Thu, 3 Oct 2024 17:50:45 GMT, Dan Lutker <dlutker at openjdk.org> wrote: > Clean backport to fix regression in JDK11. Low risk and existing tests should be sufficient coverage. @lutkerd Your change (at version 572a600a52afe58f58668e3c0be6c4cb1a410d2c) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2950#issuecomment-2465467812 From dlutker at openjdk.org Fri Nov 8 18:26:23 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Fri, 8 Nov 2024 18:26:23 GMT Subject: [jdk11u-dev] Integrated: 8339470: [17u] More defensive fix for 8163921 In-Reply-To: <qfiYp3f86zO4JnKeyhP-3Ao3h5dkeiclWSVPltnsi-A=.3d4a4526-df03-489e-ba15-4feba24ea9f8@github.com> References: <qfiYp3f86zO4JnKeyhP-3Ao3h5dkeiclWSVPltnsi-A=.3d4a4526-df03-489e-ba15-4feba24ea9f8@github.com> Message-ID: <DrwZFtC-Z9ftcjyCgSyV9xDBBQdgSTJ_8adN2MsJjp0=.0034a84a-4ec1-4b8b-95a0-714f30049d4a@github.com> On Thu, 3 Oct 2024 17:50:45 GMT, Dan Lutker <dlutker at openjdk.org> wrote: > Clean backport to fix regression in JDK11. Low risk and existing tests should be sufficient coverage. This pull request has now been integrated. Changeset: 827528c3 Author: Dan Lutker <dlutker at openjdk.org> Committer: Victor Rudometov <vrudomet at openjdk.org> URL: https://git.openjdk.org/jdk11u-dev/commit/827528c3228705496813887f92f964310b010464 Stats: 11 lines in 2 files changed: 1 ins; 0 del; 10 mod 8339470: [17u] More defensive fix for 8163921 Backport-of: 6261dd7e3827ecd65c61a3d71f4234c88f08fccd ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2950 From duke at openjdk.org Fri Nov 8 19:23:08 2024 From: duke at openjdk.org (Abhishek N) Date: Fri, 8 Nov 2024 19:23:08 GMT Subject: [jdk23u] RFR: 8343411: Test fail on Windows due to "An established connection was aborted by the software in your host machine" Message-ID: <kG3lHGNWGmcH8dgG8bENjRvWnlyyXtN3LNH9RnDSlXs=.694b4f18-847f-46ce-8c72-45e7121df528@github.com> 8343411: Test fail on Windows due to "An established connection was aborted by the software in your host machine" ------------- Commit messages: - Backport 72f67fb16a2470fc40c6ddc3700ba92f98a62096 Changes: https://git.openjdk.org/jdk23u/pull/220/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=220&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343411 Stats: 25 lines in 1 file changed: 7 ins; 15 del; 3 mod Patch: https://git.openjdk.org/jdk23u/pull/220.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/220/head:pull/220 PR: https://git.openjdk.org/jdk23u/pull/220 From duke at openjdk.org Fri Nov 8 19:28:47 2024 From: duke at openjdk.org (Abhishek N) Date: Fri, 8 Nov 2024 19:28:47 GMT Subject: [jdk23u] RFR: 8343411: Test fail on Windows due to "An established connection was aborted by the software in your host machine" In-Reply-To: <kG3lHGNWGmcH8dgG8bENjRvWnlyyXtN3LNH9RnDSlXs=.694b4f18-847f-46ce-8c72-45e7121df528@github.com> References: <kG3lHGNWGmcH8dgG8bENjRvWnlyyXtN3LNH9RnDSlXs=.694b4f18-847f-46ce-8c72-45e7121df528@github.com> Message-ID: <u6TaUm_kRMnBO6yqv4VHqoBLKU2VJ29ZnxL-mCoCOv0=.b0b2070d-09d5-44c9-8965-80b58692a667@github.com> On Fri, 8 Nov 2024 19:15:18 GMT, Abhishek N <duke at openjdk.org> wrote: > Straight Backport. Good to backport to lower releases. test passes Straight Backport.Good to backport to lower releases. test passes ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/220#issuecomment-2465589143 From phh at openjdk.org Fri Nov 8 22:33:08 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 8 Nov 2024 22:33:08 GMT Subject: [jdk11u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test In-Reply-To: <2FkJtZlLbZWhK2aIJHoyLV4XWKx86kmR1oi5_Fb7pMI=.bc2e5379-7efb-4679-ade6-e2f9d9081725@github.com> References: <2FkJtZlLbZWhK2aIJHoyLV4XWKx86kmR1oi5_Fb7pMI=.bc2e5379-7efb-4679-ade6-e2f9d9081725@github.com> Message-ID: <C7Qx_aLFVtuWDgJLJsgvjAXxf95u8_OvCp57otlfOyk=.c0f13c3e-79f2-4bcd-84e6-9d1167e3cc87@github.com> On Mon, 26 Aug 2024 18:25:41 GMT, Daniel Hu <duke at openjdk.org> wrote: > Clean backport that improves DataDescriptorSignatureMissing test; already backported to 17 and 21. Passes affected test in Linux x64. > MacOS GHA failing due to unrelated deprecated code during compile Maintainer(s), the JBS is tagged jdk11u-fix-yes, but the bot doesn't appear to have noticed. How can we fix it? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2922#issuecomment-2465848581 From andrew at openjdk.org Sat Nov 9 01:08:47 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 9 Nov 2024 01:08:47 GMT Subject: [jdk11u-dev] RFR: 8342629: [11u] Properly message out that shenandoah is disabled [v2] In-Reply-To: <zliuZrCWTwKRR8jkK992jjKRV1nzxJm96YG_VsrR8ZE=.80c65c0f-8a9a-43d1-bf09-bdf36872e87e@github.com> References: <oLW30rmi6YPTpS8x0NkrCVxx9NnkV14GnUqQyb1iKcg=.a5493e44-5f32-43c6-bb78-426ab431623d@github.com> <fQ1WLwBgiJx0TrjJ0XlRhfrYNd6mfhrfQksbZSr6cNc=.df224098-ab49-4ac4-8eaf-b356581805e7@github.com> <zliuZrCWTwKRR8jkK992jjKRV1nzxJm96YG_VsrR8ZE=.80c65c0f-8a9a-43d1-bf09-bdf36872e87e@github.com> Message-ID: <hGHmyePElEjP8AS2a2eXrzjZ90K3STxyVTVxUU7t4RA=.b53a6c7c-541c-4359-ab2f-442ad6c0ee76@github.com> On Mon, 28 Oct 2024 19:25:06 GMT, Andrew John Hughes <andrew at openjdk.org> wrote: > /approval request The request should contain a reason as to why the change should be approved (e.g. change is low risk, fixes a critical issue, testing passes). As this is a trivial patch, I'll approve this as is, but please do fill this in on future changes. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2946#issuecomment-2465958369 From cushon at openjdk.org Sat Nov 9 01:13:59 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Sat, 9 Nov 2024 01:13:59 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <eZzcpvkqLSM8DDT2Tt-PhZg-X76bFORdz0ePeYeHeb4=.9dfbf019-12ff-4f21-9e40-9613983f2b78@github.com> References: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> <eZzcpvkqLSM8DDT2Tt-PhZg-X76bFORdz0ePeYeHeb4=.9dfbf019-12ff-4f21-9e40-9613983f2b78@github.com> Message-ID: <7YiIqU7d-KfOG4VyQChleVnld2TtPZYPs3lH-ShUzI0=.56ce7b17-7940-4ffc-ad11-202557a97104@github.com> On Thu, 7 Nov 2024 19:13:04 GMT, Thomas Fitzsimmons <duke at openjdk.org> wrote: >> Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: >> >> - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 >> - 8336942: Improve test coverage for class loading elements with annotations of different retentions >> >> Reviewed-by: vromero > > _I am not a Reviewer; I maintain `java-17-openjdk` in `RHEL` so I try to review `rfr`-labelled pull requests for `jdk17u-dev`, time-permitting._ > > This looks like a good change to have in 17. I tested it on `Fedora 41 x86_64`. > > While trying this out, I noticed a potential oddity regarding `BasicAnnoTests.java`: the first of the two `Test` annotations does not seem to take effect. For example, I would expect that changing: > > `@Test(posn=0, annoType=TA.class, expect="1")` > > to: > > `@Test(posn=0, annoType=TA.class, expect="33")` > > would cause a failure, but it does not. Am I missing something? > > I am testing with jtreg `857ed6167418cb4ebe2844fd536461a1649bdced` running on `jdk-17.0.13+11`. @fitzsim I tried with jtreg `857ed6167418cb4ebe2844fd536461a1649bdced` and `17.0.13+11` and I can reproduce a test failure with that change. Could you double-check you're still unable to reproduce that failure? diff --git a/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java b/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java index d4540107022..e22c3d132b9 100644 --- a/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java +++ b/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java @@ -423,7 +423,7 @@ public class BasicAnnoTests extends JavacTestingAbstractProcessor { // vary position of one annotated // the three above with the corner case of the ambiguos decl + type anno added - @Test(posn=0, annoType=TA.class, expect="1") + @Test(posn=0, annoType=TA.class, expect="33") public @TA(1) int f1; @Test(posn=0, annoType=TA.class, expect="11") make test TEST="jtreg:test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java" ... ./src/jdk17u-dev/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java:427: error: Unexpected value: 1, expected: 33 public @TA(1) int f1; ^ 1 error ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2465960160 From jvanek at openjdk.org Sat Nov 9 06:31:56 2024 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Sat, 9 Nov 2024 06:31:56 GMT Subject: [jdk11u-dev] RFR: 8342629: [11u] Properly message out that shenandoah is disabled [v2] In-Reply-To: <fQ1WLwBgiJx0TrjJ0XlRhfrYNd6mfhrfQksbZSr6cNc=.df224098-ab49-4ac4-8eaf-b356581805e7@github.com> References: <oLW30rmi6YPTpS8x0NkrCVxx9NnkV14GnUqQyb1iKcg=.a5493e44-5f32-43c6-bb78-426ab431623d@github.com> <fQ1WLwBgiJx0TrjJ0XlRhfrYNd6mfhrfQksbZSr6cNc=.df224098-ab49-4ac4-8eaf-b356581805e7@github.com> Message-ID: <Cvv-bxYGd5J9cUurAkIC1-FaJeTFmtLYyeB1ans0yyY=.3f2bd9ba-b4d5-47c0-8b90-0e12fda42ed4@github.com> On Fri, 18 Oct 2024 17:16:46 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote: >> Unluckily, ShenandoahGC in jdk11 i still disabled by default. In addition, its output is broken: >> >> >> checking for dlopen in -ldl... yes >> checking if shenandoah can be built... checking if zgc can be built... no, platform not supported >> checking if jvmci module jdk.internal.vm.ci should be built... yes >> >> >> In all other JDKs it is enabled by default, and prints correctly yes/no: >> >> checking for dlopen in -ldl... yes >> checking if shenandoah can be built... yes >> checking if zgc can be built... yes >> checking if jvmci module jdk.internal.vm.ci should be built... yes >> >> >> >> This PR is fixing this. In jdk17 and up , when manually disabled, the "no" is printed. > > Ji?? Van?k has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8342629: [11u] Properly message out that shenandoah is disabled I see. Will remember that. TY! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2946#issuecomment-2466076441 From duke at openjdk.org Sat Nov 9 08:27:17 2024 From: duke at openjdk.org (Thomas Fitzsimmons) Date: Sat, 9 Nov 2024 08:27:17 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <7YiIqU7d-KfOG4VyQChleVnld2TtPZYPs3lH-ShUzI0=.56ce7b17-7940-4ffc-ad11-202557a97104@github.com> References: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> <eZzcpvkqLSM8DDT2Tt-PhZg-X76bFORdz0ePeYeHeb4=.9dfbf019-12ff-4f21-9e40-9613983f2b78@github.com> <7YiIqU7d-KfOG4VyQChleVnld2TtPZYPs3lH-ShUzI0=.56ce7b17-7940-4ffc-ad11-202557a97104@github.com> Message-ID: <VygMMVCz4t8OmS1nNWOXJNqIYJq8_K73t3YoYqIpXzM=.bb4d174a-d388-4ebe-9072-78d892aa7784@github.com> On Sat, 9 Nov 2024 01:08:47 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote: >> _I am not a Reviewer; I maintain `java-17-openjdk` in `RHEL` so I try to review `rfr`-labelled pull requests for `jdk17u-dev`, time-permitting._ >> >> This looks like a good change to have in 17. I tested it on `Fedora 41 x86_64`. >> >> While trying this out, I noticed a potential oddity regarding `BasicAnnoTests.java`: the first of the two `Test` annotations does not seem to take effect. For example, I would expect that changing: >> >> `@Test(posn=0, annoType=TA.class, expect="1")` >> >> to: >> >> `@Test(posn=0, annoType=TA.class, expect="33")` >> >> would cause a failure, but it does not. Am I missing something? >> >> I am testing with jtreg `857ed6167418cb4ebe2844fd536461a1649bdced` running on `jdk-17.0.13+11`. > > @fitzsim I tried with jtreg `857ed6167418cb4ebe2844fd536461a1649bdced` and `17.0.13+11` and I can reproduce a test failure with that change. Could you double-check you're still unable to reproduce that failure? > > > diff --git a/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java b/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java > index d4540107022..e22c3d132b9 100644 > --- a/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java > +++ b/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java > @@ -423,7 +423,7 @@ public class BasicAnnoTests extends JavacTestingAbstractProcessor { > // vary position of one annotated > // the three above with the corner case of the ambiguos decl + type anno added > > - @Test(posn=0, annoType=TA.class, expect="1") > + @Test(posn=0, annoType=TA.class, expect="33") > public @TA(1) int f1; > > @Test(posn=0, annoType=TA.class, expect="11") > > > > make test TEST="jtreg:test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java" > ... > ./src/jdk17u-dev/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java:427: error: Unexpected value: 1, expected: 33 > public @TA(1) int f1; > ^ > 1 error @cushon I should have included a patch for context; I was modifying the first of the two `Test` annotations _added by this pull request_. Can you try this patch, on top of this pull request? diff --git a/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java b/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java index d4540107022..06bd32bcfbb 100644 --- a/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java +++ b/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java @@ -535,7 +535,7 @@ public class BasicAnnoTests extends JavacTestingAbstractProcessor { @Test(posn=1, annoType=TA.class, expect="23") public Set<@TA(23) ? super Object> f9; - @Test(posn=0, annoType=TA.class, expect="1") + @Test(posn=0, annoType=TA.class, expect="33") @Test(posn=0, annoType=TD.class, expect="2") public @TA(1) @TD(2) int f10; I get: make test TEST="jtreg:test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java" ... Passed: tools/javac/processing/model/type/BasicAnnoTests.java Test results: passed: 1 ... TEST SUCCESS but I would expect a failure. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2466116287 From duke at openjdk.org Sat Nov 9 06:31:57 2024 From: duke at openjdk.org (duke) Date: Sat, 9 Nov 2024 06:31:57 GMT Subject: [jdk11u-dev] RFR: 8342629: [11u] Properly message out that shenandoah is disabled [v2] In-Reply-To: <fQ1WLwBgiJx0TrjJ0XlRhfrYNd6mfhrfQksbZSr6cNc=.df224098-ab49-4ac4-8eaf-b356581805e7@github.com> References: <oLW30rmi6YPTpS8x0NkrCVxx9NnkV14GnUqQyb1iKcg=.a5493e44-5f32-43c6-bb78-426ab431623d@github.com> <fQ1WLwBgiJx0TrjJ0XlRhfrYNd6mfhrfQksbZSr6cNc=.df224098-ab49-4ac4-8eaf-b356581805e7@github.com> Message-ID: <CU9ZVvwYLVaVbk94Yxaqfhp0bSZ4Rm_cgCwkxJO9UVw=.306e6d89-b229-40f6-9706-b1d1ff512383@github.com> On Fri, 18 Oct 2024 17:16:46 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote: >> Unluckily, ShenandoahGC in jdk11 i still disabled by default. In addition, its output is broken: >> >> >> checking for dlopen in -ldl... yes >> checking if shenandoah can be built... checking if zgc can be built... no, platform not supported >> checking if jvmci module jdk.internal.vm.ci should be built... yes >> >> >> In all other JDKs it is enabled by default, and prints correctly yes/no: >> >> checking for dlopen in -ldl... yes >> checking if shenandoah can be built... yes >> checking if zgc can be built... yes >> checking if jvmci module jdk.internal.vm.ci should be built... yes >> >> >> >> This PR is fixing this. In jdk17 and up , when manually disabled, the "no" is printed. > > Ji?? Van?k has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8342629: [11u] Properly message out that shenandoah is disabled @judovana Your change (at version 02d91fe1bcad639b36b4ccc612eed98177f3a28c) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2946#issuecomment-2466076905 From cushon at openjdk.org Sat Nov 9 15:15:45 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Sat, 9 Nov 2024 15:15:45 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <VygMMVCz4t8OmS1nNWOXJNqIYJq8_K73t3YoYqIpXzM=.bb4d174a-d388-4ebe-9072-78d892aa7784@github.com> References: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> <eZzcpvkqLSM8DDT2Tt-PhZg-X76bFORdz0ePeYeHeb4=.9dfbf019-12ff-4f21-9e40-9613983f2b78@github.com> <7YiIqU7d-KfOG4VyQChleVnld2TtPZYPs3lH-ShUzI0=.56ce7b17-7940-4ffc-ad11-202557a97104@github.com> <VygMMVCz4t8OmS1nNWOXJNqIYJq8_K73t3YoYqIpXzM=.bb4d174a-d388-4ebe-9072-78d892aa7784@github.com> Message-ID: <qRjVnNr9PuTCx4_j_jmCHU80HftBJhCnqIDUGkW3Mnk=.9e106cb8-30d4-4e27-b03b-e1c9cf62f0fd@github.com> On Sat, 9 Nov 2024 08:24:06 GMT, Thomas Fitzsimmons <duke at openjdk.org> wrote: >> @fitzsim I tried with jtreg `857ed6167418cb4ebe2844fd536461a1649bdced` and `17.0.13+11` and I can reproduce a test failure with that change. Could you double-check you're still unable to reproduce that failure? >> >> >> diff --git a/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java b/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java >> index d4540107022..e22c3d132b9 100644 >> --- a/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java >> +++ b/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java >> @@ -423,7 +423,7 @@ public class BasicAnnoTests extends JavacTestingAbstractProcessor { >> // vary position of one annotated >> // the three above with the corner case of the ambiguos decl + type anno added >> >> - @Test(posn=0, annoType=TA.class, expect="1") >> + @Test(posn=0, annoType=TA.class, expect="33") >> public @TA(1) int f1; >> >> @Test(posn=0, annoType=TA.class, expect="11") >> >> >> >> make test TEST="jtreg:test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java" >> ... >> ./src/jdk17u-dev/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java:427: error: Unexpected value: 1, expected: 33 >> public @TA(1) int f1; >> ^ >> 1 error > > @cushon I should have included a patch for context; I was modifying the first of the two `Test` annotations _added by this pull request_. Can you try this patch, on top of this pull request? > > > diff --git a/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java b/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java > index d4540107022..06bd32bcfbb 100644 > --- a/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java > +++ b/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java > @@ -535,7 +535,7 @@ public class BasicAnnoTests extends JavacTestingAbstractProcessor { > @Test(posn=1, annoType=TA.class, expect="23") > public Set<@TA(23) ? super Object> f9; > > - @Test(posn=0, annoType=TA.class, expect="1") > + @Test(posn=0, annoType=TA.class, expect="33") > @Test(posn=0, annoType=TD.class, expect="2") > public @TA(1) @TD(2) int f10; > > > I get: > > > make test TEST="jtreg:test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java" > ... > Passed: tools/javac/processing/model/type/BasicAnnoTests.java > Test results: passed: 1 > ... > TEST SUCCESS > > but I would expect a failure. @fitzsim thanks for clarifying, and for the catch! I think that may be a long-standing bug in the test harness, it's grouping the annotations by position and if there are multiple annotations with the same position it only ends up looking at one of them. I can reproduce the expected failure with your change and something like the following. I think this issue with the test should be fixed at head, I will follow up on that. The motivation for originally adding the test in JDK-8336942 that's being backported here was that this example would cause a crash if the implementation failed to handle two annotations with different retentions at the same location, so there's some value in this even without the fix to the test harness. diff --git a/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java b/test/langtools/tools/javac/processing/m odel/type/BasicAnnoTests.java index d4540107022..718b4aae95a 100644 --- a/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java +++ b/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java @@ -139,7 +139,7 @@ public class BasicAnnoTests extends JavacTestingAbstractProcessor { */ class TestTypeScanner extends TypeScanner<Void, Void> { Element elem; - NavigableMap<Integer, AnnotationMirror> toBeFound; + NavigableMap<Integer, List<AnnotationMirror>> toBeFound; int count = 0; Set<TypeMirror> seen = new HashSet<>(); @@ -147,10 +147,10 @@ public class BasicAnnoTests extends JavacTestingAbstractProcessor { super(types); this.elem = elem; - NavigableMap<Integer, AnnotationMirror> testByPos = new TreeMap<>(); + NavigableMap<Integer, List<AnnotationMirror>> testByPos = new TreeMap<>(); for (AnnotationMirror test : tests) { for (int pos : getPosn(test)) { - testByPos.put(pos, test); + testByPos.computeIfAbsent(pos, ArrayList::new).add(test); } } this.toBeFound = testByPos; @@ -172,17 +172,18 @@ public class BasicAnnoTests extends JavacTestingAbstractProcessor { out.println("scan " + count + ": " + t); if (toBeFound.size() > 0) { if (toBeFound.firstKey().equals(count)) { - AnnotationMirror test = toBeFound.pollFirstEntry().getValue(); - String annoType = getAnnoType(test); - AnnotationMirror anno = getAnnotation(t, annoType); - if (anno == null) { - error(elem, "annotation not found on " + count + ": " + t); - } else { - String v = getValue(anno, "value").toString(); - if (v.equals(getExpect(test))) { - out.println("found " + anno + " as expected"); + for (AnnotationMirror test : toBeFound.pollFirstEntry().getValue()) { + String annoType = getAnnoType(test); + AnnotationMirror anno = getAnnotation(t, annoType); + if (anno == null) { + error(elem, "annotation not found on " + count + ": " + t); } else { - error(elem, "Unexpected value: " + v + ", expected: " + getExpect(test)); + String v = getValue(anno, "value").toString(); + if (v.equals(getExpect(test))) { + out.println("found " + anno + " as expected"); + } else { + error(elem, "Unexpected value: " + v + ", expected: " + getExpect(test)); + } } } } else if (count > toBeFound.firstKey()) { ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2466253349 From goetz at openjdk.org Sat Nov 9 19:08:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 9 Nov 2024 19:08:34 GMT Subject: [jdk21u-dev] RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property [v2] In-Reply-To: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> References: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> Message-ID: <IMVCfyiAra_xEHNjANSzq-uj3FmGcTCag1oU1WAWTdU=.f7dc3e39-e132-42ac-aaee-c83e4777e2d2@github.com> > I backport this for parity with 21.0.6-oracle. > > I resolved two files: > test/jdk/sun/security/mscapi/InteropWithSunRsaSign.java > Copyright > > test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java > Resolved because 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode not in 21. > > Tests all pass except for three I skipped: > test/jdk/sun/security/pkcs11/rsa/GenKeyStore.java > test/jdk/sun/security/rsa/GenKeyStore.java > test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilHmacSHA1.java > Checked the change in these files. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Backport 8343848 Including fix of the issue spotted by Lutz ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1138/files - new: https://git.openjdk.org/jdk21u-dev/pull/1138/files/ab113fd4..e3810934 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1138&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1138&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1138.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1138/head:pull/1138 PR: https://git.openjdk.org/jdk21u-dev/pull/1138 From goetz at openjdk.org Sat Nov 9 19:08:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 9 Nov 2024 19:08:36 GMT Subject: [jdk21u-dev] RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property In-Reply-To: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> References: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> Message-ID: <iP1IYgo6Iccy31xtmRAwd2E1HtvEsAi_r--YmYBJITg=.87568301-ef4e-4172-af29-0e124a2a6a87@github.com> On Thu, 7 Nov 2024 13:07:52 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > I resolved two files: > test/jdk/sun/security/mscapi/InteropWithSunRsaSign.java > Copyright > > test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java > Resolved because 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode not in 21. > > Tests all pass except for three I skipped: > test/jdk/sun/security/pkcs11/rsa/GenKeyStore.java > test/jdk/sun/security/rsa/GenKeyStore.java > test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilHmacSHA1.java > Checked the change in these files. Including this fix Lutz spotted in his review. Better to have this correct right away, and simplifies backport to 17. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1138#issuecomment-2466412224 From goetz at openjdk.org Sat Nov 9 19:16:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 9 Nov 2024 19:16:52 GMT Subject: [jdk17u-dev] Withdrawn: 8303489: Add a test to verify classes in vmStruct have unique vtables In-Reply-To: <NHggvQyiNxotfxa-gfcQEcauJYuoG8YqZolzl129WuA=.1c87020c-b7ca-4c6e-bca0-421a850ce80e@github.com> References: <NHggvQyiNxotfxa-gfcQEcauJYuoG8YqZolzl129WuA=.1c87020c-b7ca-4c6e-bca0-421a850ce80e@github.com> Message-ID: <Gh9UlIurk6tPoOZSWUvvFJ6feEUyGSENy7TvtXH2b6M=.ef776205-57f1-4337-b765-90a9a8d657db@github.com> On Tue, 1 Oct 2024 14:02:17 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this to improve testing in 17u This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2926 From goetz at openjdk.org Sat Nov 9 19:19:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 9 Nov 2024 19:19:24 GMT Subject: [jdk17u-dev] RFR: 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature In-Reply-To: <XWOMzBfdp_YETZWXwmDssUw3Id4u33d8Lwyw9twZRI0=.af078778-e8b6-43b2-969f-8424d1d71173@github.com> References: <XWOMzBfdp_YETZWXwmDssUw3Id4u33d8Lwyw9twZRI0=.af078778-e8b6-43b2-969f-8424d1d71173@github.com> Message-ID: <H5uKzM6fiwE5FvfSfT5MVEeuEgHA34yIKFkedSKPHWo=.414917a0-5ff5-44ef-bfe1-311873855878@github.com> On Fri, 8 Nov 2024 09:00:56 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > I verified that the ProblemList change, which is omitted in 21, is not needed in 17 either. GHa failure: infra issue, unrelated. error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3037#issuecomment-2466416614 From goetz at openjdk.org Sat Nov 9 19:20:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 9 Nov 2024 19:20:26 GMT Subject: [jdk17u-dev] RFR: 8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" In-Reply-To: <V2wWHDprRqdkaYxhepge2-bCUDNVQZo3xJll8WDbaik=.a98b8bbb-0473-4ea9-992a-7e5131c3230f@github.com> References: <V2wWHDprRqdkaYxhepge2-bCUDNVQZo3xJll8WDbaik=.a98b8bbb-0473-4ea9-992a-7e5131c3230f@github.com> Message-ID: <sULzmOy6-HBrpQm7UFqf_rNkTGALAkwOvmi4v_8ABCE=.73fc44d0-6188-4c36-ab22-33e440f933d5@github.com> On Thu, 7 Nov 2024 13:50:41 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle GHA fialure: infra issue, unrelated. error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3035#issuecomment-2466416876 From cushon at openjdk.org Sat Nov 9 20:56:39 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Sat, 9 Nov 2024 20:56:39 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <qRjVnNr9PuTCx4_j_jmCHU80HftBJhCnqIDUGkW3Mnk=.9e106cb8-30d4-4e27-b03b-e1c9cf62f0fd@github.com> References: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> <eZzcpvkqLSM8DDT2Tt-PhZg-X76bFORdz0ePeYeHeb4=.9dfbf019-12ff-4f21-9e40-9613983f2b78@github.com> <7YiIqU7d-KfOG4VyQChleVnld2TtPZYPs3lH-ShUzI0=.56ce7b17-7940-4ffc-ad11-202557a97104@github.com> <VygMMVCz4t8OmS1nNWOXJNqIYJq8_K73t3YoYqIpXzM=.bb4d174a-d388-4ebe-9072-78d892aa7784@github.com> <qRjVnNr9PuTCx4_j_jmCHU80HftBJhCnqIDUGkW3Mnk=.9e106cb8-30d4-4e27-b03b-e1c9cf62f0fd@github.com> Message-ID: <jj1ci7vlsr6PcN8it0PAKbNmyJCR8gONy0tvm1CMEYw=.f90078ea-e99c-491b-b294-04bee5dd0a8f@github.com> On Sat, 9 Nov 2024 15:13:42 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote: > I think this issue with the test should be fixed at head, I will follow up on that. I filed https://bugs.openjdk.org/browse/JDK-8343882 for this ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2466456408 From duke at openjdk.org Sat Nov 9 21:47:47 2024 From: duke at openjdk.org (Thomas Fitzsimmons) Date: Sat, 9 Nov 2024 21:47:47 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> References: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> Message-ID: <ItFMX2RRHfrEgYj61juoK1BPL_62Yame12JJUDs8-7Y=.c9740d80-5f96-4d40-af0d-53ef2d557d93@github.com> On Tue, 5 Nov 2024 18:49:17 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote: >> This change improves annotation processing test coverage, see [JDK-8336942](https://bugs.openjdk.org/browse/JDK-8336942). I resolved a trivial merge conflict with JDK-8323684, which added the `nameToAnnotation` map. The modified test passes. > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 > - 8336942: Improve test coverage for class loading elements with annotations of different retentions > > Reviewed-by: vromero Liam Miller-Cushon ***@***.***> writes: > I think this issue with the test should be fixed at head, I will > follow up on that. > > I filed https://bugs.openjdk.org/browse/JDK-8343882 for this Looks good, thank you. On Monday I will experiment on `jdk17u-dev` with your preliminary fix for the test harness. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2466468840 From syan at openjdk.org Sun Nov 10 01:29:25 2024 From: syan at openjdk.org (SendaoYan) Date: Sun, 10 Nov 2024 01:29:25 GMT Subject: [jdk11u-dev] RFR: 8231058: VerifyOops crashes with assert(_offset >= 0) failed: offset for non comment? Message-ID: <kWOIwC7sBwGPueFLW3PZZGmcEBOEj2QPGF3ekSP46qA=.e80f22ab-8a4f-40ae-937b-a6ac68a49358@github.com> Hi all, This is clean backport of [JDK-8231058](https://bugs.openjdk.org/browse/JDK-8231058), to fix JVM crash when running with `-XX:+VerifyOops`. The newly added test run failed before this backport, and run passed after apply this backport. Additonal testing: - [ ] linux aarch64 build with release/slowdebug configure - [ ] linux x86_64 build with release/slowdebug configure - [ ] jtreg tests(include tier1/2/3 etc.) with release build on linux aarch64 - [ ] jtreg tests(include tier1/2/3 etc.) with release build on linux x86_64 ------------- Commit messages: - 8231058: VerifyOops crashes with assert(_offset >= 0) failed: offset for non comment? Changes: https://git.openjdk.org/jdk11u-dev/pull/2963/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2963&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8231058 Stats: 37 lines in 2 files changed: 36 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2963.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2963/head:pull/2963 PR: https://git.openjdk.org/jdk11u-dev/pull/2963 From lucy at openjdk.org Sun Nov 10 13:38:14 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Sun, 10 Nov 2024 13:38:14 GMT Subject: [jdk21u-dev] RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property [v2] In-Reply-To: <IMVCfyiAra_xEHNjANSzq-uj3FmGcTCag1oU1WAWTdU=.f7dc3e39-e132-42ac-aaee-c83e4777e2d2@github.com> References: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> <IMVCfyiAra_xEHNjANSzq-uj3FmGcTCag1oU1WAWTdU=.f7dc3e39-e132-42ac-aaee-c83e4777e2d2@github.com> Message-ID: <YPrvjIc8YbpYcIwfhvmDdQ5qpZSWN-evmJ5GjIte58k=.ca5a4f8a-daac-45e2-bfef-a0fe59d9e1a2@github.com> On Sat, 9 Nov 2024 19:08:34 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> I backport this for parity with 21.0.6-oracle. >> >> I resolved two files: >> test/jdk/sun/security/mscapi/InteropWithSunRsaSign.java >> Copyright >> >> test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java >> Resolved because 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode not in 21. >> >> Tests all pass except for three I skipped: >> test/jdk/sun/security/pkcs11/rsa/GenKeyStore.java >> test/jdk/sun/security/rsa/GenKeyStore.java >> test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilHmacSHA1.java >> Checked the change in these files. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Backport 8343848 > > Including fix of the issue spotted by Lutz Looks good now. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1138#pullrequestreview-2425764281 From jwtang at openjdk.org Mon Nov 11 01:59:36 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Mon, 11 Nov 2024 01:59:36 GMT Subject: [jdk21u-dev] RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump In-Reply-To: <G9SUlu-3RDGh-qwY0w_4OcKZ15146jBBbLPKkaa0-J4=.8e2d3d4e-d9ba-4eeb-b645-0dd37e402d1f@github.com> References: <Mw0ex-Ijyg21Wpawt_al_MjY-9F_g04YLouw6chyIxI=.dc15acad-a2b8-4ba9-a5e1-b17f3422edf2@github.com> <G9SUlu-3RDGh-qwY0w_4OcKZ15146jBBbLPKkaa0-J4=.8e2d3d4e-d9ba-4eeb-b645-0dd37e402d1f@github.com> Message-ID: <NDJgNDJpu3pXc78xOC372m-N1pMp-X90h-WLAgbSzbk=.809d63f1-fbdc-43b9-917d-72257136fb03@github.com> On Thu, 7 Nov 2024 13:20:38 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > Hi @jia-wei-tang, what about follow-up JDK-8334215, is this needed also? Removing the label in the meantime. Yes, It is needed. Should I backport JDK-8334215 in the same pr or create a new one? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1129#issuecomment-2467081752 From ashi at openjdk.org Mon Nov 11 05:59:36 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Nov 2024 05:59:36 GMT Subject: [jdk11u-dev] Integrated: 8232367: Update Reactive Streams to 1.0.3 -- tests only In-Reply-To: <ZCQ3snQfDD3ZUrKOzceImmbrvs18GEXnRMknFrHp5rc=.bee399c7-7ff3-4192-a32f-46a373c53bef@github.com> References: <ZCQ3snQfDD3ZUrKOzceImmbrvs18GEXnRMknFrHp5rc=.bee399c7-7ff3-4192-a32f-46a373c53bef@github.com> Message-ID: <w_D9xHC7nqlvPfvM9ZUJQW6aXOs3QhrfE6dqo5hkNHg=.afafeecf-8f2e-4ab9-8964-bafbb79a5ec4@github.com> On Sat, 24 Aug 2024 03:26:27 GMT, Amos Shi <ashi at openjdk.org> wrote: > Backport of [JDK-8232367](https://bugs.openjdk.org/browse/JDK-8232367) > > Testing > - Local: Compile passed on `MacOS 14.6.1` on Apple M1 Max > - Not a test or directory containing tests: `java/net/httpclient/reactivestreams-tck/org/reactivestreams/tck/SubscriberWhiteboxVerification.java` > - Pipeline: All passed except `macOS` > - `macOS`: `/Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here` The issue exists in all recent PR in [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/pulls) and not caused by Current PR > - Testing Machine: We consider SAP nightlies passed on `2024-09-03` > - Because no test failure is found caused by `SubscriberWhiteboxVerification.java` This pull request has now been integrated. Changeset: add90003 Author: Amos Shi <ashi at openjdk.org> URL: https://git.openjdk.org/jdk11u-dev/commit/add90003d601eec60cf9166f6013f0e86382729d Stats: 10 lines in 1 file changed: 8 ins; 1 del; 1 mod 8232367: Update Reactive Streams to 1.0.3 -- tests only Backport-of: 9f6af13f9d9d9b1f7a2b6eaac96240a51cadfd72 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2921 From ashi at openjdk.org Mon Nov 11 05:59:38 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Nov 2024 05:59:38 GMT Subject: [jdk11u-dev] Integrated: 8247706: Unintentional use of new Date(year...) with absolute year In-Reply-To: <Zvi6hDMwVLdriGDbaSL2l3pK_XiAifzL_U-TTjFETms=.9110fc0c-e4ad-4763-8e6d-0675aed6d181@github.com> References: <Zvi6hDMwVLdriGDbaSL2l3pK_XiAifzL_U-TTjFETms=.9110fc0c-e4ad-4763-8e6d-0675aed6d181@github.com> Message-ID: <k4-Co31iVzBj2RohE9j9qmj5nNUPHwhtrKd-JuvhzII=.2461434e-024e-453a-bc7d-70962717d4b4@github.com> On Tue, 27 Aug 2024 01:24:35 GMT, Amos Shi <ashi at openjdk.org> wrote: > Backport of [JDK-8247706](https://bugs.openjdk.org/browse/JDK-8247706) > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - Passed: `java/text/Format/DateFormat/DateFormatRegression.java` > - Passed: `java/time/tck/java/time/format/TCKLocalizedPrinterParser.java` > - Passed: `java/util/Calendar/FieldStateTest.java` > - Pipeline: All passed except `macOS` > - `macOS`: `/Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here` The issue exists in all recent PR in [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/pulls) and not caused by Current PR > - Testing Machine: SAP nightlies passed on `2024-09-03` > - Automated jtreg test: `jtreg_jdk_tier1` Started at `2024-09-03 09:22:44+01:00` > - java/util/Calendar/FieldStateTest.java: SUCCESSFUL GitHub ? - [09:37:01.601 -> 954 msec] This pull request has now been integrated. Changeset: 04e6f37d Author: Amos Shi <ashi at openjdk.org> URL: https://git.openjdk.org/jdk11u-dev/commit/04e6f37d2c3b0983db92184f49391b4453b459df Stats: 7 lines in 3 files changed: 0 ins; 0 del; 7 mod 8247706: Unintentional use of new Date(year...) with absolute year Backport-of: 175b597ad2fbbcceac2946ca26b27d069a6003fd ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2924 From ashi at openjdk.org Mon Nov 11 06:01:48 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Nov 2024 06:01:48 GMT Subject: [jdk11u-dev] Integrated: 8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64 In-Reply-To: <38IYoRPEjj1aqwGRuDD5-RkCwTzOEdgEVyW3Bne7jlM=.5d0c0ecc-9c44-479a-8295-9b7734777afa@github.com> References: <38IYoRPEjj1aqwGRuDD5-RkCwTzOEdgEVyW3Bne7jlM=.5d0c0ecc-9c44-479a-8295-9b7734777afa@github.com> Message-ID: <g4ebNys5ln6uNpXoPh1l0TMVWTvv6F55cd8PZHEJjw4=.c4c529ac-77a3-4b09-8ae2-29f5209dc79b@github.com> On Wed, 21 Aug 2024 00:44:50 GMT, Amos Shi <ashi at openjdk.org> wrote: > Backport of [JDK-8225045](https://bugs.openjdk.org/browse/JDK-8225045) > - This PR contains two commits > - `commit 1` is generated by git `patch` command, is a clean backport for `JInternalFrameIconTest.java` > - `commit 2` is the manual merge of `test/jdk/ProblemList.txt.rej` file. The content of the file is bellow. > > > @@ -751,7 +751,6 @@ > javax/swing/JComboBox/8182031/ComboPopupTest.java 8196465 linux-all,macosx-all > javax/swing/JFileChooser/6738668/bug6738668.java 8194946 generic-all > javax/swing/JInternalFrame/Test6325652.java 8224977 macosx-all > -javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java 8225045 linux-all > javax/swing/JPopupMenu/4870644/bug4870644.java 8194130 macosx-all,linux-all > javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java 8065099,8208565 macosx-all,linux-all > javax/swing/UIDefaults/6302464/bug6302464.java 8199079 macosx-all > > > Testing > - Local on MacOS: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `JInternalFrameIconTest.java`: Test results: passed: 1 > - Local on Linux: Test passed on `Ubuntu 22.04.4` by @Harry-Junhua-Huang > - Passed: `javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java` > - Pipeline: All passed except `macOS` > - `macOS`: `/Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here` The issue exists in all recent PR in [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/pulls) and not caused by Current PR > - Testing Machine: SAP nightlies **SKIPPED** on `2024-08-23` > - Automated jtreg test: `jtreg_jdk_tier4`, Started at `2024-08-22 21:03:43+01:00` > - javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!printer)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] This pull request has now been integrated. Changeset: 249144c0 Author: Amos Shi <ashi at openjdk.org> URL: https://git.openjdk.org/jdk11u-dev/commit/249144c02be9d0e51bef1b3a88bd8eeadb5a8d2f Stats: 13 lines in 2 files changed: 11 ins; 2 del; 0 mod 8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64 Backport-of: a483869a6a98ccf296763732a32894f6a39fff40 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2918 From goetz at openjdk.org Mon Nov 11 08:08:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 08:08:17 GMT Subject: [jdk21u-dev] RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property [v2] In-Reply-To: <IMVCfyiAra_xEHNjANSzq-uj3FmGcTCag1oU1WAWTdU=.f7dc3e39-e132-42ac-aaee-c83e4777e2d2@github.com> References: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> <IMVCfyiAra_xEHNjANSzq-uj3FmGcTCag1oU1WAWTdU=.f7dc3e39-e132-42ac-aaee-c83e4777e2d2@github.com> Message-ID: <QyrxghE6Y9S26vDynr1OUtSMYNPipNoUP71TYjuo2ls=.5abd6043-88c5-4b82-b4d4-2c27b56c87d4@github.com> On Sat, 9 Nov 2024 19:08:34 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> I backport this for parity with 21.0.6-oracle. >> >> I resolved two files: >> test/jdk/sun/security/mscapi/InteropWithSunRsaSign.java >> Copyright >> >> test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java >> Resolved because 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode not in 21. >> >> Tests all pass except for three I skipped: >> test/jdk/sun/security/pkcs11/rsa/GenKeyStore.java >> test/jdk/sun/security/rsa/GenKeyStore.java >> test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilHmacSHA1.java >> Checked the change in these files. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Backport 8343848 > > Including fix of the issue spotted by Lutz GHA failure: infra issue, unrelated error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1138#issuecomment-2467480493 From goetz at openjdk.org Mon Nov 11 08:55:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 08:55:45 GMT Subject: [jdk21u-dev] Integrated: 8308429: jvmti/StopThread/stopthrd007 failed with "NoClassDefFoundError: Could not initialize class jdk.internal.misc.VirtualThreads" In-Reply-To: <lJLB4xckDKlLdbNF2gnV3CUG9b4WpWRV3etxrbvsoeA=.01a73c23-4246-4b12-9419-095a37676685@github.com> References: <lJLB4xckDKlLdbNF2gnV3CUG9b4WpWRV3etxrbvsoeA=.01a73c23-4246-4b12-9419-095a37676685@github.com> Message-ID: <v53bSmduK0-4eHS6JmmG7ymMy3nql-2RwKv9IPK-ZZg=.2a0475d3-6d84-4cab-aaa4-5b5a662b4089@github.com> On Thu, 7 Nov 2024 09:45:36 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: c09025ad Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/c09025add8893423bf6d08705c469beada71ba58 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod 8308429: jvmti/StopThread/stopthrd007 failed with "NoClassDefFoundError: Could not initialize class jdk.internal.misc.VirtualThreads" Backport-of: 0e501f66dfc52a0e049d4fa39c1fcd24f1f2ee4b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1134 From goetz at openjdk.org Mon Nov 11 08:57:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 08:57:12 GMT Subject: [jdk21u-dev] Integrated: 8325038: runtime/cds/appcds/ProhibitedPackage.java can fail with UseLargePages In-Reply-To: <WgEIQ7avCLCXpAnb-31j8kwCAYIZB1sQxvJkSeQ1xuE=.c6428f36-d52f-455b-986f-7b4527b6e7f2@github.com> References: <WgEIQ7avCLCXpAnb-31j8kwCAYIZB1sQxvJkSeQ1xuE=.c6428f36-d52f-455b-986f-7b4527b6e7f2@github.com> Message-ID: <dak4bGXDflFs2aytiLi5PPHP9OOZTBGZC-feJOn7jpI=.2dee1a37-72cd-4d39-9393-fd042de68f04@github.com> On Thu, 7 Nov 2024 09:51:51 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 14b897a0 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/14b897a0187e594d6da400e6a7b570c0c9710956 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8325038: runtime/cds/appcds/ProhibitedPackage.java can fail with UseLargePages Backport-of: b42b8886aa93a50d114f9a105ef6b94febd38729 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1135 From goetz at openjdk.org Mon Nov 11 08:58:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 08:58:51 GMT Subject: [jdk21u-dev] Integrated: 8327924: Simplify TrayIconScalingTest.java In-Reply-To: <E2miutZguydI-Gg5l78FpB5_mqv-mmiroxMuNRQE7rY=.1e86c3e1-7da4-4e11-8952-2dd2ca8f95b8@github.com> References: <E2miutZguydI-Gg5l78FpB5_mqv-mmiroxMuNRQE7rY=.1e86c3e1-7da4-4e11-8952-2dd2ca8f95b8@github.com> Message-ID: <5ZW9XZNn0fdfTVnmqYhzIn7HoQ-jQe2I0YQm7def11Q=.de260ac0-3aea-4133-b323-a99ec08a9945@github.com> On Thu, 7 Nov 2024 09:33:50 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: d85992de Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/d85992de6261eb30d4b0996bd653d75bb0f60569 Stats: 27 lines in 1 file changed: 10 ins; 11 del; 6 mod 8327924: Simplify TrayIconScalingTest.java Backport-of: 1496b5de9004c6a9e43ead5f6e9e88362028a7cc ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1133 From goetz at openjdk.org Mon Nov 11 08:59:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 08:59:25 GMT Subject: [jdk21u-dev] Integrated: 8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" In-Reply-To: <pdFcTkReD1gzLFhnqNvMOC8O6zkvn0fTjEJfDNlp-GU=.b98b3440-bf2c-48ce-a39d-3340f07e8c1e@github.com> References: <pdFcTkReD1gzLFhnqNvMOC8O6zkvn0fTjEJfDNlp-GU=.b98b3440-bf2c-48ce-a39d-3340f07e8c1e@github.com> Message-ID: <jSeK5efsHSf_CTRbcNYK-T6FT5Ro1Hv1MB_q_iMWB6o=.879e6ea8-9142-4f94-8337-1129e75aff3a@github.com> On Thu, 7 Nov 2024 13:49:44 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: b4ab5de4 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/b4ab5de4c06c99df67febc7a3c4f13496b7399c4 Stats: 34 lines in 3 files changed: 6 ins; 28 del; 0 mod 8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" Backport-of: 28b201955907e145f208d756b607ab545a83b2d3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1139 From goetz at openjdk.org Mon Nov 11 08:59:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 08:59:57 GMT Subject: [jdk21u-dev] Integrated: 8330278: Have SSLSocketTemplate.doClientSide use loopback address In-Reply-To: <BlK49r7EbP902iJ0ZdSbOxs9kuPmlEFY6ONPRYuVuzI=.1958ae1a-f36f-48ca-9091-014408681f8b@github.com> References: <BlK49r7EbP902iJ0ZdSbOxs9kuPmlEFY6ONPRYuVuzI=.1958ae1a-f36f-48ca-9091-014408681f8b@github.com> Message-ID: <BZgSJcIonxQohZIrRYZaIOBnJHz7LJPM_0kA8oGf6hE=.31699a22-c302-40fa-aea6-54948abb8445@github.com> On Thu, 7 Nov 2024 13:59:59 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > Resolved import in TLSBase. Probably clean. This pull request has now been integrated. Changeset: bbc006f3 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/bbc006f3be0d08f5f50a0b7c04300289020fdc21 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod 8330278: Have SSLSocketTemplate.doClientSide use loopback address Backport-of: 0eff492e4107abc5624f0c3445877bf38629a980 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1140 From goetz at openjdk.org Mon Nov 11 09:01:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 09:01:10 GMT Subject: [jdk17u-dev] Integrated: 8325038: runtime/cds/appcds/ProhibitedPackage.java can fail with UseLargePages In-Reply-To: <2iI1BwH7Wz9L2dxcRHZd9KRaGZ7mhIeVh5itRhJ8148=.20a9d04b-4902-4210-9a01-d345ca9904a6@github.com> References: <2iI1BwH7Wz9L2dxcRHZd9KRaGZ7mhIeVh5itRhJ8148=.20a9d04b-4902-4210-9a01-d345ca9904a6@github.com> Message-ID: <9UWrQM8L5d1aw0jOzLrMHeW7I58FSm8XABVSIWw3fZ8=.8101a9f4-a9ec-4784-9e46-4f2096073b6d@github.com> On Thu, 7 Nov 2024 09:52:00 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle This pull request has now been integrated. Changeset: 915cc663 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/915cc663abc2942c29fae723ee4a1749dc0d3f9f Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8325038: runtime/cds/appcds/ProhibitedPackage.java can fail with UseLargePages Backport-of: b42b8886aa93a50d114f9a105ef6b94febd38729 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3033 From goetz at openjdk.org Mon Nov 11 09:01:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 09:01:50 GMT Subject: [jdk17u-dev] RFR: 8330278: Have SSLSocketTemplate.doClientSide use loopback address [v2] In-Reply-To: <D5q5_CXKQ84KdmQ1T1eGRPiD0PDzgbBCKBcbwnghufk=.14c50a90-27e3-4fe2-92a9-ebb08c2ecaba@github.com> References: <Vb89NL44sxTbvg_G2GS_B-J2xva10sGZyOo7_dNUpIw=.8f98e141-e384-49aa-af60-819a281d0125@github.com> <D5q5_CXKQ84KdmQ1T1eGRPiD0PDzgbBCKBcbwnghufk=.14c50a90-27e3-4fe2-92a9-ebb08c2ecaba@github.com> Message-ID: <hG4gNwK_9SB_oNjMkFRjGsTt_M2oKIYSxc4R4WB8GFs=.0459bc43-b95f-44bc-92d4-fa52947f07c4@github.com> On Fri, 8 Nov 2024 08:05:15 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> I backport this for parity with 17.0.14-oracle >> >> Resolved import, probably clean. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 0eff492e4107abc5624f0c3445877bf38629a980 GHA failure: infra issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3036#issuecomment-2467587638 From goetz at openjdk.org Mon Nov 11 09:01:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 09:01:51 GMT Subject: [jdk17u-dev] Integrated: 8327924: Simplify TrayIconScalingTest.java In-Reply-To: <7Sf68DPSirIJfL39eZrOum-6Bkrd5WTIXbARoS29Bew=.3bd2e692-5049-45aa-801e-5b33faea0b70@github.com> References: <7Sf68DPSirIJfL39eZrOum-6Bkrd5WTIXbARoS29Bew=.3bd2e692-5049-45aa-801e-5b33faea0b70@github.com> Message-ID: <RjfWcck-Xv1ugz2kBn7pmRfavqD7P5Tz-Zt0dq_HmT4=.ad5a0505-e880-4f76-be7f-2e8cce5e6a01@github.com> On Thu, 7 Nov 2024 09:34:02 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle This pull request has now been integrated. Changeset: f8a119b5 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/f8a119b5397572ca23d59ac4e23d471cfb5de0c3 Stats: 27 lines in 1 file changed: 10 ins; 11 del; 6 mod 8327924: Simplify TrayIconScalingTest.java Backport-of: 1496b5de9004c6a9e43ead5f6e9e88362028a7cc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3032 From goetz at openjdk.org Mon Nov 11 09:02:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 09:02:24 GMT Subject: [jdk21u-dev] Integrated: 8332112: Update nsk.share.Log to don't print summary during VM shutdown hook In-Reply-To: <EVSnPYlBJyGPua2OZEutV_K0nMKFIqSkAprixAluPLc=.47f3fcc4-e37d-46d3-9f1a-e02e3adcf94a@github.com> References: <EVSnPYlBJyGPua2OZEutV_K0nMKFIqSkAprixAluPLc=.47f3fcc4-e37d-46d3-9f1a-e02e3adcf94a@github.com> Message-ID: <q14c-uqpmzrE_SfzHinuS83WpbH4DXP-knZafs9u2X4=.cb564f95-0c7e-4def-9423-b022e195e91d@github.com> On Thu, 7 Nov 2024 18:11:48 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: 30374095 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/30374095c13d43a47a321d03fefa7f2ad91acfa9 Stats: 168 lines in 30 files changed: 2 ins; 134 del; 32 mod 8332112: Update nsk.share.Log to don't print summary during VM shutdown hook Backport-of: 61aff6db15d5bdda77427af5ce34d0fe43373197 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1141 From goetz at openjdk.org Mon Nov 11 09:03:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 09:03:56 GMT Subject: [jdk17u-dev] Integrated: 8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" In-Reply-To: <V2wWHDprRqdkaYxhepge2-bCUDNVQZo3xJll8WDbaik=.a98b8bbb-0473-4ea9-992a-7e5131c3230f@github.com> References: <V2wWHDprRqdkaYxhepge2-bCUDNVQZo3xJll8WDbaik=.a98b8bbb-0473-4ea9-992a-7e5131c3230f@github.com> Message-ID: <htptPd_GlNYniJDcwGazKl9CAh4hc6M6Lcmb5X0vDkU=.d3d36dad-b28f-47f4-af2b-68c41739c51a@github.com> On Thu, 7 Nov 2024 13:50:41 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle This pull request has now been integrated. Changeset: c41236b7 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/c41236b74033275026c254e4251fa91f0aac9ead Stats: 34 lines in 3 files changed: 6 ins; 28 del; 0 mod 8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" Backport-of: 28b201955907e145f208d756b607ab545a83b2d3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3035 From goetz at openjdk.org Mon Nov 11 09:05:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 09:05:01 GMT Subject: [jdk21u-dev] Integrated: 8333235: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with C1 In-Reply-To: <JHn-WzVTZbLGLZbmNLDDDDEFNpYljaGxXSs2Cd3ygnI=.f2a2f902-2045-46d3-8b46-c12750fff90c@github.com> References: <JHn-WzVTZbLGLZbmNLDDDDEFNpYljaGxXSs2Cd3ygnI=.f2a2f902-2045-46d3-8b46-c12750fff90c@github.com> Message-ID: <ax33LEsA7kZhyAsu-xb6fEbnenGhwZj0az_QFc_Q0Gc=.1e3af12e-e87e-42af-998c-31e90981c5ed@github.com> On Thu, 7 Nov 2024 10:00:34 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 2702f671 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/2702f67147c0bdfa77b7d80c614f05b68f6e802a Stats: 14 lines in 1 file changed: 11 ins; 0 del; 3 mod 8333235: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with C1 Backport-of: f73922b27d126314fc3127ee25aa40b6258c8a6b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1136 From goetz at openjdk.org Mon Nov 11 09:05:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 09:05:31 GMT Subject: [jdk21u-dev] Integrated: 8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp In-Reply-To: <N4sGTnQRqTtlwCDelw16EptbYuqZZE6njYfqOB6vfOk=.535db45c-88d3-4e32-904d-50a4217d898f@github.com> References: <N4sGTnQRqTtlwCDelw16EptbYuqZZE6njYfqOB6vfOk=.535db45c-88d3-4e32-904d-50a4217d898f@github.com> Message-ID: <RTBljbTKi-A_VHvTvm35amUmR59QY1U5bb69hmUqZI8=.8ca3048e-5778-4015-b921-b1cba1b19cc3@github.com> On Thu, 7 Nov 2024 10:41:53 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 78697133 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/7869713396af8e0aae1489a1add9253538cdf04d Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp Backport-of: 6f4ddc2f6bf0dd9a626a76d0f5e56a54c6cf6b65 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1137 From goetz at openjdk.org Mon Nov 11 09:05:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 09:05:37 GMT Subject: [jdk17u-dev] Integrated: 8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp In-Reply-To: <S0s8pXqP9pxM23zHpRmc1jyCBii9kst8xx5fja4xQqI=.c291bcc0-1c51-4f37-a14e-28e1716db2b0@github.com> References: <S0s8pXqP9pxM23zHpRmc1jyCBii9kst8xx5fja4xQqI=.c291bcc0-1c51-4f37-a14e-28e1716db2b0@github.com> Message-ID: <SzLnQiqlPhDUGtQrmONt6cr3isbiFFUp-faDus8utDM=.a0de5781-b63e-407d-8d24-e6f64617b0b0@github.com> On Thu, 7 Nov 2024 10:42:29 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle, This pull request has now been integrated. Changeset: eef1d179 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/eef1d179ad6e73b29bffd74cd7b23750aaa15c7f Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp Backport-of: 6f4ddc2f6bf0dd9a626a76d0f5e56a54c6cf6b65 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3034 From goetz at openjdk.org Mon Nov 11 09:06:04 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 09:06:04 GMT Subject: [jdk17u-dev] Integrated: 8330278: Have SSLSocketTemplate.doClientSide use loopback address In-Reply-To: <Vb89NL44sxTbvg_G2GS_B-J2xva10sGZyOo7_dNUpIw=.8f98e141-e384-49aa-af60-819a281d0125@github.com> References: <Vb89NL44sxTbvg_G2GS_B-J2xva10sGZyOo7_dNUpIw=.8f98e141-e384-49aa-af60-819a281d0125@github.com> Message-ID: <iDuAoB2717jH7gqwwKDCNHu_63jv4UaL1MrPOL47sE0=.081152c7-6627-4089-a378-bc195fb13d5e@github.com> On Thu, 7 Nov 2024 14:04:47 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle > > Resolved import, probably clean. This pull request has now been integrated. Changeset: f4489554 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/f4489554769f449b2c72a5b2cd41d74b7ce1bf99 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod 8330278: Have SSLSocketTemplate.doClientSide use loopback address Backport-of: 0eff492e4107abc5624f0c3445877bf38629a980 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3036 From goetz at openjdk.org Mon Nov 11 09:07:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 09:07:47 GMT Subject: [jdk17u-dev] Integrated: 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature In-Reply-To: <XWOMzBfdp_YETZWXwmDssUw3Id4u33d8Lwyw9twZRI0=.af078778-e8b6-43b2-969f-8424d1d71173@github.com> References: <XWOMzBfdp_YETZWXwmDssUw3Id4u33d8Lwyw9twZRI0=.af078778-e8b6-43b2-969f-8424d1d71173@github.com> Message-ID: <-rbTQKISI1bRLoWs3_vtD0dhW0KLbMcMyxB9oqvFaLE=.aa682a1c-f7f7-4e72-a742-f7c1571a829c@github.com> On Fri, 8 Nov 2024 09:00:56 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > I verified that the ProblemList change, which is omitted in 21, is not needed in 17 either. This pull request has now been integrated. Changeset: cc70a502 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/cc70a502050587351b9b60a79d63877c92bc10cc Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature Backport-of: d7c85b194dcb2c312afe18e62a87b1708d4f14bb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3037 From duke at openjdk.org Mon Nov 11 09:17:05 2024 From: duke at openjdk.org (Abhishek N) Date: Mon, 11 Nov 2024 09:17:05 GMT Subject: [jdk23u] Withdrawn: 8343411: Test fail on Windows due to "An established connection was aborted by the software in your host machine" In-Reply-To: <kG3lHGNWGmcH8dgG8bENjRvWnlyyXtN3LNH9RnDSlXs=.694b4f18-847f-46ce-8c72-45e7121df528@github.com> References: <kG3lHGNWGmcH8dgG8bENjRvWnlyyXtN3LNH9RnDSlXs=.694b4f18-847f-46ce-8c72-45e7121df528@github.com> Message-ID: <BYlLnNO__MuqyYZMJUeINYMYUrBgA1EEAF2UJJY0Pts=.ac964ac3-0d43-4ce5-b6ad-5d78c84e7052@github.com> On Fri, 8 Nov 2024 19:15:18 GMT, Abhishek N <duke at openjdk.org> wrote: > Straight Backport. Good to backport to lower releases. test passes This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk23u/pull/220 From sgehwolf at openjdk.org Mon Nov 11 09:23:01 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 11 Nov 2024 09:23:01 GMT Subject: [jdk21u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project [v2] In-Reply-To: <C_XZ6gGPforlvOQK1gcpX_oIzS8Pno1gjeQe_nBQjzc=.971f25fc-c74e-4261-bed8-09324d14e812@github.com> References: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> <C_XZ6gGPforlvOQK1gcpX_oIzS8Pno1gjeQe_nBQjzc=.971f25fc-c74e-4261-bed8-09324d14e812@github.com> Message-ID: <juBxR9FYWtgLpOyNwkguZjuLjOSd7jRsJWI_bKSJjCE=.2d0b816c-34cf-4cfc-88af-3ce446eff892@github.com> On Tue, 5 Nov 2024 08:50:13 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> Customize the README.md to jdk21u. >> >> Plan is to backport this to 17 and maybe older jdks and adapt the paths etc correspondingly. >> So let?s keep this sufficiently generic so that the information holds for jdkXu and jdkXu-dev >> and that the change can easily be backported (by adapting 21->17 etc). >> >> Should we put there more information? > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Apply suggestions from code review > > Add changes proposed by Christoph. > > Co-authored-by: Christoph Langer <christoph.langer at sap.com> Ship it! ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1118#pullrequestreview-2426495236 From goetz at openjdk.org Mon Nov 11 09:50:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 09:50:52 GMT Subject: [jdk21u-dev] Integrated: 8341927: Replace hardcoded security providers with new test.provider.name system property In-Reply-To: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> References: <KGMJ5dwFiNX6zxVnEnUrGoZnYfF4hyK-q6iUtaBniRY=.7d84eff8-7dd8-4232-86fe-7943721adb75@github.com> Message-ID: <qhELKfXFgvJq8nTMNu0-k2vHsU0r7jbq9uIHlRKObeI=.41968186-b02a-4765-afa9-91be3018c61e@github.com> On Thu, 7 Nov 2024 13:07:52 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > I resolved two files: > test/jdk/sun/security/mscapi/InteropWithSunRsaSign.java > Copyright > > test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java > Resolved because 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode not in 21. > > Tests all pass except for three I skipped: > test/jdk/sun/security/pkcs11/rsa/GenKeyStore.java > test/jdk/sun/security/rsa/GenKeyStore.java > test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilHmacSHA1.java > Checked the change in these files. This pull request has now been integrated. Changeset: 9bdf2a61 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/9bdf2a619d1d158d6c1e8e1e1238a4229e0b0783 Stats: 1006 lines in 230 files changed: 307 ins; 0 del; 699 mod 8341927: Replace hardcoded security providers with new test.provider.name system property 8343848: Fix typo of property name in TestOAEPPadding after 8341927 Reviewed-by: lucy Backport-of: 9a9ac1d0059438d33fe69ef51265dc7cff6ad2bd ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1138 From aph at openjdk.org Mon Nov 11 10:14:16 2024 From: aph at openjdk.org (Andrew Haley) Date: Mon, 11 Nov 2024 10:14:16 GMT Subject: [jdk21u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project [v2] In-Reply-To: <C_XZ6gGPforlvOQK1gcpX_oIzS8Pno1gjeQe_nBQjzc=.971f25fc-c74e-4261-bed8-09324d14e812@github.com> References: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> <C_XZ6gGPforlvOQK1gcpX_oIzS8Pno1gjeQe_nBQjzc=.971f25fc-c74e-4261-bed8-09324d14e812@github.com> Message-ID: <9so1BEr77uch5mNYohVNSQ-Gd8A-6QKrSsmC06_364U=.a80a252b-ed71-4218-acff-c01df4d45000@github.com> On Tue, 5 Nov 2024 08:50:13 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> Customize the README.md to jdk21u. >> >> Plan is to backport this to 17 and maybe older jdks and adapt the paths etc correspondingly. >> So let?s keep this sufficiently generic so that the information holds for jdkXu and jdkXu-dev >> and that the change can easily be backported (by adapting 21->17 etc). >> >> Should we put there more information? > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Apply suggestions from code review > > Add changes proposed by Christoph. > > Co-authored-by: Christoph Langer <christoph.langer at sap.com> README.md line 4: > 2: > 3: JDK 21 updates are continuously developed in repository [jdk21u-dev](https://github.com/openjdk/jdk21u-dev). > 4: Repository [jdk21u](https://github.com/openjdk/jdk21u) is used for rampdown of the update releases of jdk21u and only accepts critical changes that must make the next release during rampdown. (You probably do not want to target jdk21u). Suggestion: The JDK 21 Updates project uses two GitHub repositories. Updates are continuously developed in the repository [jdk21u-dev](https://github.com/openjdk/jdk21u-dev). This is the repository usually targeted by contributors. The [jdk21u](https://github.com/openjdk/jdk21u) repository is used for rampdown of the update releases of jdk21u and only accepts critical changes that must make the next release during rampdown. (You probably do not want to target jdk21u). ------------- PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1118#discussion_r1836318293 From goetz at openjdk.org Mon Nov 11 10:52:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 10:52:51 GMT Subject: [jdk21u-dev] RFR: 8342181: Update tests to use stronger Key and Salt size Message-ID: <vU72O0T41l7FNyMNdCdzyxNZVIWS0h8MJG8aXUiOS3I=.71cb9724-dc49-4e73-8352-a15362cbb7f5@github.com> I backport this for parity with 21.0.6-oracle. Resolved TestOAEPPadding because of context difference. Probably considered clean. ------------- Commit messages: - Backport f340ab2d360b5dfd375095ac053e9f4fc22a98de Changes: https://git.openjdk.org/jdk21u-dev/pull/1144/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1144&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342181 Stats: 240 lines in 40 files changed: 138 ins; 0 del; 102 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1144.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1144/head:pull/1144 PR: https://git.openjdk.org/jdk21u-dev/pull/1144 From goetz at openjdk.org Mon Nov 11 11:31:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 11:31:23 GMT Subject: [jdk21u-dev] RFR: 8342188: Update tests to use stronger key parameters and certificates Message-ID: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> I backport this for parity with 21.0.6-oracle. Locally a clean patch, but /backport did not work. lib files included in tests. ------------- Commit messages: - Backport ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe Changes: https://git.openjdk.org/jdk21u-dev/pull/1145/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1145&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342188 Stats: 2619 lines in 14 files changed: 981 ins; 395 del; 1243 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1145.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1145/head:pull/1145 PR: https://git.openjdk.org/jdk21u-dev/pull/1145 From goetz at openjdk.org Mon Nov 11 11:57:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 11:57:46 GMT Subject: [jdk21u-dev] RFR: 8342183: Update tests to use stronger algorithms and keys Message-ID: <grJyW-kFRkQbxOIfO66_O7U1QzYGd9yNfV4oaPlHSus=.8b3f3b53-7720-4a29-afb4-0f757ed7fda2@github.com> I backport this for parity with 21.0.6-oracle. Resolved Copyright of SignedOrder, probably clean. ------------- Commit messages: - Backport c82ad845e101bf5d97c0744377d68002907d4a0e Changes: https://git.openjdk.org/jdk21u-dev/pull/1146/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1146&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342183 Stats: 267 lines in 35 files changed: 142 ins; 8 del; 117 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1146.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1146/head:pull/1146 PR: https://git.openjdk.org/jdk21u-dev/pull/1146 From goetz at openjdk.org Mon Nov 11 13:03:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 13:03:54 GMT Subject: [jdk21u-dev] RFR: 8342188: Update tests to use stronger key parameters and certificates [v2] In-Reply-To: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> References: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> Message-ID: <lnh4B9TnnLJaOA9ACtYCu1nXNtrMVWVXUavYTKeKdJk=.75f8361d-034c-4118-81d5-65fa7f790ac5@github.com> > I backport this for parity with 21.0.6-oracle. > > Locally a clean patch, but /backport did not work. > lib files included in tests. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1145/files - new: https://git.openjdk.org/jdk21u-dev/pull/1145/files/4632c6ee..0e077b9e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1145&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1145&range=00-01 Stats: 109 lines in 1 file changed: 109 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1145.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1145/head:pull/1145 PR: https://git.openjdk.org/jdk21u-dev/pull/1145 From duke at openjdk.org Mon Nov 11 13:30:28 2024 From: duke at openjdk.org (Thomas Fitzsimmons) Date: Mon, 11 Nov 2024 13:30:28 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <qRjVnNr9PuTCx4_j_jmCHU80HftBJhCnqIDUGkW3Mnk=.9e106cb8-30d4-4e27-b03b-e1c9cf62f0fd@github.com> References: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> <eZzcpvkqLSM8DDT2Tt-PhZg-X76bFORdz0ePeYeHeb4=.9dfbf019-12ff-4f21-9e40-9613983f2b78@github.com> <7YiIqU7d-KfOG4VyQChleVnld2TtPZYPs3lH-ShUzI0=.56ce7b17-7940-4ffc-ad11-202557a97104@github.com> <VygMMVCz4t8OmS1nNWOXJNqIYJq8_K73t3YoYqIpXzM=.bb4d174a-d388-4ebe-9072-78d892aa7784@github.com> <qRjVnNr9PuTCx4_j_jmCHU80HftBJhCnqIDUGkW3Mnk=.9e106cb8-30d4-4e27-b03b-e1c9cf62f0fd@github.com> Message-ID: <eTxLzQVXoETKECLy1lQEJwnMYr8xOnufXUE-I0dgM00=.b0a33029-b2ea-4500-bb37-86edf5b40cc5@github.com> On Sat, 9 Nov 2024 15:13:42 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote: > I can reproduce the expected failure with your change and something like the following. Confirmed on my setup: /source/jdk17u-dev/test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java:541: error: Unexpected value: 1, expected: 33 public @TA(1) @TD(2) int f10; ^ 1 error ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2468179947 From jvanek at openjdk.org Mon Nov 11 13:55:56 2024 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Mon, 11 Nov 2024 13:55:56 GMT Subject: [jdk11u-dev] Integrated: 8342629: [11u] Properly message out that shenandoah is disabled In-Reply-To: <oLW30rmi6YPTpS8x0NkrCVxx9NnkV14GnUqQyb1iKcg=.a5493e44-5f32-43c6-bb78-426ab431623d@github.com> References: <oLW30rmi6YPTpS8x0NkrCVxx9NnkV14GnUqQyb1iKcg=.a5493e44-5f32-43c6-bb78-426ab431623d@github.com> Message-ID: <CouBOQ0W2maGiBXpG7dEs_ufVNMhctVP01XcdtgSx5Y=.e07d1649-d563-4325-8bc1-4011290d9ba4@github.com> On Mon, 30 Sep 2024 16:27:37 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote: > Unluckily, ShenandoahGC in jdk11 i still disabled by default. In addition, its output is broken: > > > checking for dlopen in -ldl... yes > checking if shenandoah can be built... checking if zgc can be built... no, platform not supported > checking if jvmci module jdk.internal.vm.ci should be built... yes > > > In all other JDKs it is enabled by default, and prints correctly yes/no: > > checking for dlopen in -ldl... yes > checking if shenandoah can be built... yes > checking if zgc can be built... yes > checking if jvmci module jdk.internal.vm.ci should be built... yes > > > > This PR is fixing this. In jdk17 and up , when manually disabled, the "no" is printed. This pull request has now been integrated. Changeset: cf53387d Author: Ji?? Van?k <jvanek at openjdk.org> Committer: Severin Gehwolf <sgehwolf at openjdk.org> URL: https://git.openjdk.org/jdk11u-dev/commit/cf53387daf0d99e2d426e5e9a35e8d79b9701485 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8342629: [11u] Properly message out that shenandoah is disabled Reviewed-by: andrew ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2946 From amitkumar at openjdk.org Mon Nov 11 14:39:51 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 11 Nov 2024 14:39:51 GMT Subject: [jdk23u] RFR: 8319947: Recursive lightweight locking: s390x implementation Message-ID: <a9xbtmTtwZOqFSL7tqyk5Z0Sx6-6C7y9he2Gn4kR58E=.3550d35e-ae9a-45f5-8e93-fa2925adedef@github.com> Hi all, This pull request contains a backport of commit [d457609f](https://github.com/openjdk/jdk/commit/d457609f700bbb1fed233f1a04501c995852e5ac) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 28 Jun 2024 and was reviewed by Axel Boldt-Christmas and Lutz Schmidt. Thanks! ------------- Commit messages: - Backport d457609f700bbb1fed233f1a04501c995852e5ac Changes: https://git.openjdk.org/jdk23u/pull/221/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=221&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319947 Stats: 553 lines in 9 files changed: 426 ins; 64 del; 63 mod Patch: https://git.openjdk.org/jdk23u/pull/221.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/221/head:pull/221 PR: https://git.openjdk.org/jdk23u/pull/221 From goetz at openjdk.org Mon Nov 11 14:42:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 14:42:12 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: <45UzLuBpkdqiMiRzz-SVYtQbplWB-oWRcC9k6w5gYps=.dd750e61-a429-420c-8bd1-ccc35787bed0@github.com> References: <w8CMo34RO2XDqFpbBM99zKIworM_HiI1RhBx3CK_G8k=.6e4f7d28-ae7f-418a-a3b8-c56baf3889ab@github.com> <45UzLuBpkdqiMiRzz-SVYtQbplWB-oWRcC9k6w5gYps=.dd750e61-a429-420c-8bd1-ccc35787bed0@github.com> Message-ID: <QMvQmzgCZKjKOhQSmnHuXrx6wUPJtc758XyU08CtFJc=.2e508103-11e0-4a1b-94a1-81c8d8db2968@github.com> On Fri, 23 Aug 2024 10:21:38 GMT, HempushpaSahu <duke at openjdk.org> wrote: >> Backporting JDK-8179502 - Enhance OCSP, CRL and Certificate Fetch Timeouts. >> OCSP request throws Connection timeout occasionally, so this needs to be backported to fix the issue. >> >> Reported issue : https://bugs.openjdk.org/browse/JDK-8179502 > > Duplicate of https://github.com/openjdk/jdk17u-dev/pull/2747. Hence, closing this PR > Thanks. Hi @HempushpaSahu , one more thing: What happens if someone has set com.sun.security.crl.timeout and installs the update. Will that value be taken over to com.sun.security.ocsp.readtimeout, or will that fall back to 15s? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2754#issuecomment-2468336412 From andrew at openjdk.org Mon Nov 11 15:02:32 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 11 Nov 2024 15:02:32 GMT Subject: [jdk21u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project [v2] In-Reply-To: <C_XZ6gGPforlvOQK1gcpX_oIzS8Pno1gjeQe_nBQjzc=.971f25fc-c74e-4261-bed8-09324d14e812@github.com> References: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> <C_XZ6gGPforlvOQK1gcpX_oIzS8Pno1gjeQe_nBQjzc=.971f25fc-c74e-4261-bed8-09324d14e812@github.com> Message-ID: <S3NxkAG65VvSc0ySw7DqXomXZineL9P_G6EnB4gAtT0=.bcbd5f51-5be6-4950-b0ba-c28e5602189a@github.com> On Tue, 5 Nov 2024 08:50:13 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> Customize the README.md to jdk21u. >> >> Plan is to backport this to 17 and maybe older jdks and adapt the paths etc correspondingly. >> So let?s keep this sufficiently generic so that the information holds for jdkXu and jdkXu-dev >> and that the change can easily be backported (by adapting 21->17 etc). >> >> Should we put there more information? > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Apply suggestions from code review > > Add changes proposed by Christoph. > > Co-authored-by: Christoph Langer <christoph.langer at sap.com> I would go with aph's version, which reads a little better. ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1118#pullrequestreview-2427516978 From duke at openjdk.org Mon Nov 11 15:19:34 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 11 Nov 2024 15:19:34 GMT Subject: [jdk11u-dev] RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files Message-ID: <9hd_GHxl58UPjSaK0bHqMnMIAIrn6zulQD4QHoD2wZ4=.d52daacf-403b-4fcd-9aa0-b4527c0fc0f9@github.com> Backport of [JDK-8339803](https://bugs.openjdk.org/browse/JDK-8339803) from 17u. Related to tz-2024b timezone update. Clean backport. Passed tier1 tests. ------------- Commit messages: - Backport 0d7b2729e4f4c0fec2dcfea65a0834732a408ee4 Changes: https://git.openjdk.org/jdk11u-dev/pull/2964/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2964&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339803 Stats: 20 lines in 3 files changed: 4 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2964.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2964/head:pull/2964 PR: https://git.openjdk.org/jdk11u-dev/pull/2964 From goetz at openjdk.org Mon Nov 11 15:20:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Nov 2024 15:20:14 GMT Subject: [jdk21u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project [v3] In-Reply-To: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> References: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> Message-ID: <2n6_6tHOaCk6r19zEQS7_wvv1_sZ92ac_DxOGJAb7dI=.92554dee-7944-4f80-a039-a27c41d983e5@github.com> > Customize the README.md to jdk21u. > > Plan is to backport this to 17 and maybe older jdks and adapt the paths etc correspondingly. > So let?s keep this sufficiently generic so that the information holds for jdkXu and jdkXu-dev > and that the change can easily be backported (by adapting 21->17 etc). > > Should we put there more information? Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Taking over suggestion of Andrew Yes, this makes it much clearer. Thanks! Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com> ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1118/files - new: https://git.openjdk.org/jdk21u-dev/pull/1118/files/bc062ce9..f253b707 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1118&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1118&range=01-02 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1118.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1118/head:pull/1118 PR: https://git.openjdk.org/jdk21u-dev/pull/1118 From gnu.andrew at redhat.com Mon Nov 11 15:41:11 2024 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Mon, 11 Nov 2024 15:41:11 +0000 Subject: New JDK 11u maintainer: Andrew Hughes In-Reply-To: <6dfaae85-c4e5-4f7f-bd62-5b4e6cbd4f4f@littlepinkcloud.com> References: <6dfaae85-c4e5-4f7f-bd62-5b4e6cbd4f4f@littlepinkcloud.com> Message-ID: <ZzIll2RzkHB4aP6H@hex.discworld.ac.uk> On 17:39 Sun 03 Nov 2024, Andrew Haley wrote: > Following the news that SAP will terminate efforts in jdk11u after the > October release, we need a new maintainer. I'm pleased to announce that > the very experienced Andrew Hughes will step into this role, and will > continue his job as jdk8u maintainer. > > SAP have done a tremendous amount of work on JDK 11u over the years, and > I'm sure the entire JDK Updates community will join me in thanking them > for that. Thank you for your care and diligence stewarding OpenJDK. > > The SAP announcement is at > https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-May/032760.html > > -- > Andrew Haley (he/him) > Java Platform Lead Engineer > Red Hat UK Ltd. <https://www.redhat.com> > https://keybase.io/andrewhaley > EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 > Thanks Andrew for the kind words. I have updated the 11u schedule on the wiki [0] and hope to do the first build promotion for 11.0.26 over the next few days. I'm just waiting on Oracle putting the deployment keys in place. I plan to follow much the same schedule as 8u, where each promotion contains a week of changes Monday to Friday, rather than the mid-week process used by SAP. I find this is both easier to follow as a contributor and also more practical for me personally. [0] https://wiki.openjdk.org/display/JDKUpdates/JDK11u Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: <https://mail.openjdk.org/pipermail/jdk-updates-dev/attachments/20241111/ee3eb9ba/signature.asc> From sgehwolf at openjdk.org Mon Nov 11 15:56:11 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 11 Nov 2024 15:56:11 GMT Subject: [jdk21u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project [v3] In-Reply-To: <2n6_6tHOaCk6r19zEQS7_wvv1_sZ92ac_DxOGJAb7dI=.92554dee-7944-4f80-a039-a27c41d983e5@github.com> References: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> <2n6_6tHOaCk6r19zEQS7_wvv1_sZ92ac_DxOGJAb7dI=.92554dee-7944-4f80-a039-a27c41d983e5@github.com> Message-ID: <axKl2ZT3mr8FGjNU6CEN2pUgtVnRC2edJEz8uDdyGTM=.f9349990-f63e-4671-bd2a-422bd38526ba@github.com> On Mon, 11 Nov 2024 15:20:14 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> Customize the README.md to jdk21u. >> >> Plan is to backport this to 17 and maybe older jdks and adapt the paths etc correspondingly. >> So let?s keep this sufficiently generic so that the information holds for jdkXu and jdkXu-dev >> and that the change can easily be backported (by adapting 21->17 etc). >> >> Should we put there more information? > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Taking over suggestion of Andrew > > Yes, this makes it much clearer. Thanks! > > Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com> Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1118#pullrequestreview-2427633772 From sgehwolf at openjdk.org Mon Nov 11 16:20:01 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 11 Nov 2024 16:20:01 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> References: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> Message-ID: <LHiau4zB9uYZqg-kd8MXmd_PZBr4JlUtHoyPxro2nSA=.9949dde2-6f2b-494f-aed5-2468bb07ede6@github.com> On Sun, 28 Jul 2024 22:02:37 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote: > Hello, I'd like to backport JDK-8179502 to JDK17u to improve the timeout adjustment for OCSP GET requests (which was missed in JDK-8179503). > > The backport is almost clean except for the following: > - OCSP.java was merged manually because of JDK-8328638 and JDK-8329213 is already backported into 17u-dev > - copyright year in GetPropertyAction.java and URICertStore.java files are updated manually > - CRLReadTimeout.java test is updated manually because of the different notation of internal X509CRLImpl and CRLExtensions classes. > > All new and related jtreg tests are passed Pasting @GoeLin's question from #2754 here: > What happens if someone has set com.sun.security.crl.timeout and installs the update. Will that value be taken over to com.sun.security.ocsp.readtimeout, or will that fall back to 15s? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#issuecomment-2468549711 From andrew at openjdk.org Mon Nov 11 16:42:05 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 11 Nov 2024 16:42:05 GMT Subject: [jdk21u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project [v3] In-Reply-To: <2n6_6tHOaCk6r19zEQS7_wvv1_sZ92ac_DxOGJAb7dI=.92554dee-7944-4f80-a039-a27c41d983e5@github.com> References: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> <2n6_6tHOaCk6r19zEQS7_wvv1_sZ92ac_DxOGJAb7dI=.92554dee-7944-4f80-a039-a27c41d983e5@github.com> Message-ID: <9nP6Fq1qlz8JQJnAeFvPWs5SPI-zvX5UBKdvLelxqbs=.368d7fea-169e-443e-acec-fbbfc6aaae9e@github.com> On Mon, 11 Nov 2024 15:20:14 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> Customize the README.md to jdk21u. >> >> Plan is to backport this to 17 and maybe older jdks and adapt the paths etc correspondingly. >> So let?s keep this sufficiently generic so that the information holds for jdkXu and jdkXu-dev >> and that the change can easily be backported (by adapting 21->17 etc). >> >> Should we put there more information? > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Taking over suggestion of Andrew > > Yes, this makes it much clearer. Thanks! > > Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com> Marked as reviewed by andrew (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1118#pullrequestreview-2427730980 From aph at openjdk.org Mon Nov 11 18:06:38 2024 From: aph at openjdk.org (Andrew Haley) Date: Mon, 11 Nov 2024 18:06:38 GMT Subject: [jdk21u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project [v3] In-Reply-To: <2n6_6tHOaCk6r19zEQS7_wvv1_sZ92ac_DxOGJAb7dI=.92554dee-7944-4f80-a039-a27c41d983e5@github.com> References: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> <2n6_6tHOaCk6r19zEQS7_wvv1_sZ92ac_DxOGJAb7dI=.92554dee-7944-4f80-a039-a27c41d983e5@github.com> Message-ID: <KN40lIC3U1Gk2ghUFpfEaw6D1G36wMFsGT6cpOgNo04=.1ce4242f-bf7a-4f79-a707-95d2e5f067f4@github.com> On Mon, 11 Nov 2024 15:20:14 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> Customize the README.md to jdk21u. >> >> Plan is to backport this to 17 and maybe older jdks and adapt the paths etc correspondingly. >> So let?s keep this sufficiently generic so that the information holds for jdkXu and jdkXu-dev >> and that the change can easily be backported (by adapting 21->17 etc). >> >> Should we put there more information? > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Taking over suggestion of Andrew > > Yes, this makes it much clearer. Thanks! > > Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com> Marked as reviewed by aph (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1118#pullrequestreview-2427876217 From bulasevich at openjdk.org Mon Nov 11 18:21:14 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Mon, 11 Nov 2024 18:21:14 GMT Subject: [jdk21u-dev] RFR: 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: <JOv256F1ZHJNWHQ9xhZ0iRQv_J07HkKW65XyY0hT5-g=.ff5b719c-eb86-4c3a-b37a-cf48305d7fa9@github.com> References: <IemMFwdS40DbQh6aW3eSIf4O1SgR97r2U66YGavrdyQ=.700b0a41-0aca-45b3-aaac-bcf109bc4cf2@github.com> <JOv256F1ZHJNWHQ9xhZ0iRQv_J07HkKW65XyY0hT5-g=.ff5b719c-eb86-4c3a-b37a-cf48305d7fa9@github.com> Message-ID: <B5rQvmSgDnGd7bMRh7-4L6g5teZKouaI8pjjsRfMRxM=.b5b9f333-faab-4e56-a761-511c598d167f@github.com> On Mon, 4 Nov 2024 17:28:07 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote: >> (not a clean backport) >> Reworked to avoid https://github.com/openjdk/jdk/pull/17328/files backport >> >> Functional jtreg1-3 tests are Ok. >> Manual testing: the reproducer shows the problem is fixed with the change (see comments below) > > Reproducer: > > import jdk.jfr.consumer.RecordingStream; > > /** > * Stress test to provoke the memory leak: > * starts 1M empty threads in VM with jfr recording > */ > public class PinnedThreadTracker implements AutoCloseable > { > private final RecordingStream recordingStream; > > public PinnedThreadTracker() { > recordingStream = new RecordingStream(); > recordingStream.startAsync(); > System.out.println("start recording.."); > } > > @Override > public void close() { > recordingStream.close(); > } > > class MyThread extends Thread { > public void run() { > } > } > public void runThreads() { > for (int i = 0; i < 100; i++) { > for (int j = 0; j < 100; j++) { > for (int k = 0; k < 100; k++) { > new MyThread().start(); > } > MyThread thr = new MyThread(); thr.start(); > try { > thr.join(); > } catch (Exception ex) {} > } > System.out.print("."); > } > } > > public static void main(String a[]) { > PinnedThreadTracker ptt = new PinnedThreadTracker(); > ptt.runThreads(); > ptt.close(); > } > } > > > Manual testing results on jdk21u: > > $ for i in {0..60}; do > export PID=`ps -ax | grep java | grep PinnedThreadTracker | sed "s/^ *// ; s/ .*//"` > jcmd $PID VM.native_memory | grep Tracing.*reserved > sleep 1s > done > > Before the change (jcmd VM.native_memory output once a second): > - Tracing (reserved=17355KB, committed=17355KB) > - Tracing (reserved=21646KB, committed=21646KB) > - Tracing (reserved=25870KB, committed=25870KB) > - Tracing (reserved=30065KB, committed=30065KB) > ... > - Tracing (reserved=240567KB, committed=240567KB) > - Tracing (reserved=244519KB, committed=244519KB) > - Tracing (reserved=248525KB, committed=248525KB) > - Tracing (reserved=252527KB, committed=252527KB) > > With the fix: > - Tracing (reserved=17655KB, committed=17655KB) > - Tracing (reserved=18125KB, committed=18125KB) > - Tracing (reserved=18449KB, committed=18449KB) > - Tracing (reserved=18961KB, committed=18961KB) > ... > - Tracing (reserved=17443KB, committed=17443KB) > - Tracing (reserved=17958KB, committed=17958KB) > - Tracing (reserved=... > Hi @bulasevich, can this wait for the April update? It would get some more test coverage. Hi @GoeLin In my opinion, this bug could have a significant impact on customers, and it would be ideal to fix it as soon as possible. However, I understand that some reasonable patience is necessary. I'm not opposed to waiting for the next update. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1095#issuecomment-2468775044 From duke at openjdk.org Mon Nov 11 18:28:16 2024 From: duke at openjdk.org (Thomas Fitzsimmons) Date: Mon, 11 Nov 2024 18:28:16 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <qRjVnNr9PuTCx4_j_jmCHU80HftBJhCnqIDUGkW3Mnk=.9e106cb8-30d4-4e27-b03b-e1c9cf62f0fd@github.com> References: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> <eZzcpvkqLSM8DDT2Tt-PhZg-X76bFORdz0ePeYeHeb4=.9dfbf019-12ff-4f21-9e40-9613983f2b78@github.com> <7YiIqU7d-KfOG4VyQChleVnld2TtPZYPs3lH-ShUzI0=.56ce7b17-7940-4ffc-ad11-202557a97104@github.com> <VygMMVCz4t8OmS1nNWOXJNqIYJq8_K73t3YoYqIpXzM=.bb4d174a-d388-4ebe-9072-78d892aa7784@github.com> <qRjVnNr9PuTCx4_j_jmCHU80HftBJhCnqIDUGkW3Mnk=.9e106cb8-30d4-4e27-b03b-e1c9cf62f0fd@github.com> Message-ID: <LomfixMRAXVY7EhsUTzNgXZ_PvJ0Ted7RDjuJC0kTMs=.bcbc1737-8ea0-4c21-a814-bac899d5fe72@github.com> On Sat, 9 Nov 2024 15:13:42 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote: > The motivation for originally adding the test in JDK-8336942 that's being backported here was that this example would cause a crash if the implementation failed to handle two annotations with different retentions at the same location, so there's some value in this even without the fix to the test harness. Independent of the harness fix, I would ideally like to be able replicate the crash you mention. I have not yet found a way to make the `f10` lines you added produce a failure. Can you advise how I would do that? So far, I tried the new test on, and it succeeded on, `959665633eae0923d8acce533834940d1797bffd`, the commit before your backport of the fix for JDK-8225377, `3a2bf8e570d5e329f22b4eaf5e90fef8cd14f8b2`. The `f10` lines also passed on `3a2bf8e570d5e329f22b4eaf5e90fef8cd14f8b2`. Maybe there is some other fix I need to revert? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2468788765 From cushon at openjdk.org Mon Nov 11 18:52:11 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Mon, 11 Nov 2024 18:52:11 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <LomfixMRAXVY7EhsUTzNgXZ_PvJ0Ted7RDjuJC0kTMs=.bcbc1737-8ea0-4c21-a814-bac899d5fe72@github.com> References: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> <eZzcpvkqLSM8DDT2Tt-PhZg-X76bFORdz0ePeYeHeb4=.9dfbf019-12ff-4f21-9e40-9613983f2b78@github.com> <7YiIqU7d-KfOG4VyQChleVnld2TtPZYPs3lH-ShUzI0=.56ce7b17-7940-4ffc-ad11-202557a97104@github.com> <VygMMVCz4t8OmS1nNWOXJNqIYJq8_K73t3YoYqIpXzM=.bb4d174a-d388-4ebe-9072-78d892aa7784@github.com> <qRjVnNr9PuTCx4_j_jmCHU80HftBJhCnqIDUGkW3Mnk=.9e106cb8-30d4-4e27-b03b-e1c9cf62f0fd@github.com> <LomfixMRAXVY7EhsUTzNgXZ_PvJ0Ted7RDjuJC0kTMs=.bcbc1737-8ea0-4c21-a814-bac899d5fe72@github.com> Message-ID: <dTTNaOV_Mcem8O8ZltIwe9IKuRQu22sQcbvkfLa4EzQ=.2b39aff0-b3a0-4fb1-bf05-faee98e43c26@github.com> On Mon, 11 Nov 2024 18:26:02 GMT, Thomas Fitzsimmons <duke at openjdk.org> wrote: > Independent of the harness fix, I would ideally like to be able replicate the crash you mention. I have not yet found a way to make the `f10` lines you added produce a failure. Can you advise how I would do that? > > So far, I tried the new test on, and it succeeded on, `959665633eae0923d8acce533834940d1797bffd`, the commit before your backport of the fix for JDK-8225377, `3a2bf8e570d5e329f22b4eaf5e90fef8cd14f8b2`. The `f10` lines also passed on `3a2bf8e570d5e329f22b4eaf5e90fef8cd14f8b2`. Maybe there is some other fix I need to revert? Sorry for not providing more of this context up front. The crash was an interaction with the backport for JDK-8225377, which was previously backported to JDK 17 and backed out. The motivation for backporting this test change was to have coverage in-place if the backport ends up getting re-done (https://bugs.openjdk.org/browse/JDK-8341779). (It isn't certain if that backport will be re-done, if it is there will be additional discussion and a CSR first.) I created a draft PR with the changes to reproduce the crash here: https://github.com/openjdk/jdk17u-dev/pull/3038 make test TEST="jtreg:test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java" ... java.lang.AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155) at jdk.compiler/com.sun.tools.javac.util.Assert.check(Assert.java:46) at jdk.compiler/com.sun.tools.javac.code.TypeMetadata$Annotations.combine(TypeMetadata.java:194) at jdk.compiler/com.sun.tools.javac.code.TypeMetadata$Annotations.combine(TypeMetadata.java:174) at jdk.compiler/com.sun.tools.javac.code.TypeMetadata.combine(TypeMetadata.java:90) at jdk.compiler/com.sun.tools.javac.code.Type.annotatedType(Type.java:403) at jdk.compiler/com.sun.tools.javac.jvm.ClassReader$TypeAnnotationTypeMapping.reannotate(ClassReader.java:2476) The changes in the draft PR are * Re-do the backport of JDK-8225377 (https://bugs.openjdk.org/browse/JDK-8341779) * Update the backport for some changes in javac's `TypeMetadata` API * This PR * Removing the logic that was updated for the `TypeMetadata`, which reproduces the crash ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2468826252 From abakhtin at openjdk.org Mon Nov 11 18:55:41 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 11 Nov 2024 18:55:41 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: <LHiau4zB9uYZqg-kd8MXmd_PZBr4JlUtHoyPxro2nSA=.9949dde2-6f2b-494f-aed5-2468bb07ede6@github.com> References: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> <LHiau4zB9uYZqg-kd8MXmd_PZBr4JlUtHoyPxro2nSA=.9949dde2-6f2b-494f-aed5-2468bb07ede6@github.com> Message-ID: <gORXCb2VEPgxwQMKoZJIGDS7QckVN_DD2H1snhT49Ws=.c3393191-419d-4e9e-a66d-25545ec1ff31@github.com> On Mon, 11 Nov 2024 16:17:46 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote: > Pasting @GoeLin's question from #2754 here: > > > What happens if someone has set com.sun.security.crl.timeout and installs the update. Will that value be taken over to com.sun.security.ocsp.readtimeout, or will that fall back to 15s? Hi @GoeLin, you are right. The new "com.sun.security.ocsp.readtimeout" property is set independently of "com.sun.security.crl.timeout". In your case, it will fall back to the default 15s value. It changes current behavior. I can update this logic to change the default read timeout to the "com.sun.security.crl.timeout" value. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#issuecomment-2468827206 From clanger at openjdk.org Mon Nov 11 19:25:11 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 11 Nov 2024 19:25:11 GMT Subject: [jdk21u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project [v3] In-Reply-To: <2n6_6tHOaCk6r19zEQS7_wvv1_sZ92ac_DxOGJAb7dI=.92554dee-7944-4f80-a039-a27c41d983e5@github.com> References: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> <2n6_6tHOaCk6r19zEQS7_wvv1_sZ92ac_DxOGJAb7dI=.92554dee-7944-4f80-a039-a27c41d983e5@github.com> Message-ID: <KXqPfzBSOTnHGet3nTc4cw-TTLTdji407CjDB606dgg=.1c4f8911-8e29-42f5-9db6-e4bc03f3c647@github.com> On Mon, 11 Nov 2024 15:20:14 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> Customize the README.md to jdk21u. >> >> Plan is to backport this to 17 and maybe older jdks and adapt the paths etc correspondingly. >> So let?s keep this sufficiently generic so that the information holds for jdkXu and jdkXu-dev >> and that the change can easily be backported (by adapting 21->17 etc). >> >> Should we put there more information? > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Taking over suggestion of Andrew > > Yes, this makes it much clearer. Thanks! > > Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com> Marked as reviewed by clanger (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1118#pullrequestreview-2427996380 From btaylor at openjdk.org Mon Nov 11 20:48:06 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 11 Nov 2024 20:48:06 GMT Subject: [jdk17u-dev] Integrated: 8303742: CompletableFuture.orTimeout leaks if the future completes exceptionally In-Reply-To: <4b--P27Y6FnyGlxqn6AtCj64wqzhAWeJXkniNfztkAM=.ef1e9755-7641-47a2-b376-1ac2e68476eb@github.com> References: <4b--P27Y6FnyGlxqn6AtCj64wqzhAWeJXkniNfztkAM=.ef1e9755-7641-47a2-b376-1ac2e68476eb@github.com> Message-ID: <Xc_GoIjdOy1CBTxpXvwf8Rql32RKuwKisaiIUGyyL0s=.5f15109a-3429-48aa-a214-690745e64755@github.com> On Wed, 23 Oct 2024 22:14:19 GMT, Ben Taylor <btaylor at openjdk.org> wrote: > Clean backport of a patch to prevent `CompleteableFuture.orTimeout` from leaking when a `ScheduledFutureTask` exits exceptionally > > Passes the included test as well as jtreg tier 1 locally on linux x86_64 > > Updated to include JDK-8304557, which is a follow up item to prevent the test from timing out, see @RealCLanger's comment below. That backport is also clean. This pull request has now been integrated. Changeset: 41b4812c Author: Ben Taylor <btaylor at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/41b4812c2409c9867d9fc2f60777706d07a95875 Stats: 84 lines in 2 files changed: 83 ins; 0 del; 1 mod 8303742: CompletableFuture.orTimeout leaks if the future completes exceptionally 8304557: java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java times out Reviewed-by: phh Backport-of: ded6a8131970ac2f7ae59716769e6f6bae3b809a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3000 From andrewlu at openjdk.org Tue Nov 12 02:09:24 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Nov 2024 02:09:24 GMT Subject: [jdk17u-dev] Integrated: 8331142: Add test for number of loader threads in BasicDirectoryModel In-Reply-To: <RoSrZOf_nGeLt6HdhWAI8vUd2q9osWhhYrzPyuqUDh8=.22025c7e-2a9a-41df-9ba4-9b82f9252e5b@github.com> References: <RoSrZOf_nGeLt6HdhWAI8vUd2q9osWhhYrzPyuqUDh8=.22025c7e-2a9a-41df-9ba4-9b82f9252e5b@github.com> Message-ID: <VzkKwLMwZyIzp0qdC-7eRldNOtaOAilHGomU3Tr-YWA=.ed339339-962a-4def-a1f6-2929c96a6e8d@github.com> On Tue, 18 Jun 2024 08:02:55 GMT, Andrew Lu <andrewlu at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. > The test is limit to Windows, so backport with JDK-8331495 together, also backport with the new issue JDK-8331999 This pull request has now been integrated. Changeset: ef8243a6 Author: Andrew Lu <andrewlu at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/ef8243a644c8b5c30251a5c2d6b42176db5fa5ca Stats: 277 lines in 1 file changed: 277 ins; 0 del; 0 mod 8331142: Add test for number of loader threads in BasicDirectoryModel 8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only 8331999: BasicDirectoryModel/LoaderThreadCount.java frequently fails on Windows in CI Reviewed-by: goetz Backport-of: fcd7fb74c7654956660082c83e42d2262478a1e5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2605 From amitkumar at openjdk.org Tue Nov 12 03:13:01 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Tue, 12 Nov 2024 03:13:01 GMT Subject: [jdk23u] RFR: 8336012: Fix usages of jtreg-reserved properties Message-ID: <iRrBOUJBCt-Mx4fnWjTbbxFF2NZI-6oZy-SfW0syLy8=.1b79d702-5285-445d-a5d3-64354836b1f6@github.com> Hi all, This pull request contains a backport of commit [e6c5aa7a](https://github.com/openjdk/jdk/commit/e6c5aa7a6cb54c647d261facdcffa6a410849627) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. `test/jdk/java/lang/invoke/PrivateInvokeTest.java` is failing on s390x JDK23 - CI consistently. error: STDERR: STARTED test.java.lang.invoke.PrivateInvokeTest::testFirst 'testFirst' java.lang.NumberFormatException: For input string: "Verbose[p=SUMMARY,f=FULL,e=FULL,t=false,m=false]" at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) at java.base/java.lang.Integer.parseInt(Integer.java:588) at java.base/java.lang.Integer.parseInt(Integer.java:685) at test.java.lang.invoke.PrivateInvokeTest.<init>(PrivateInvokeTest.java:72) at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501) at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:485) FAILED test.java.lang.invoke.PrivateInvokeTest::testFirst 'testFirst' [60ms] STARTED test.java.lang.invoke.PrivateInvokeTest::testInvokeDirect 'testInvokeDirect' java.lang.NumberFormatException: For input string: "Verbose[p=SUMMARY,f=FULL,e=FULL,t=false,m=false]" at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) at java.base/java.lang.Integer.parseInt(Integer.java:588) at java.base/java.lang.Integer.parseInt(Integer.java:685) at test.java.lang.invoke.PrivateInvokeTest.<init>(PrivateInvokeTest.java:72) at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501) at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:485) FAILED test.java.lang.invoke.PrivateInvokeTest::testInvokeDirect 'testInvokeDirect' [4ms] JavaTest Message: JUnit Platform Failure(s): 2 [ JUnit Containers: found 4, started 4, succeeded 4, failed 0, aborted 0, skipped 0] [ JUnit Tests: found 2, started 2, succeeded 0, failed 2, aborted 0, skipped 0] java.lang.Exception: JUnit test failure at com.sun.javatest.regtest.agent.JUnitRunner.runWithJUnitPlatform(JUnitRunner.java:155) at com.sun.javatest.regtest.agent.JUnitRunner.main(JUnitRunner.java:99) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) at java.base/java.lang.reflect.Method.invoke(Method.java:580) at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333) at java.base/java.lang.Thread.run(Thread.java:1575) JavaTest Message: Test threw exception: java.lang.Exception JavaTest Message: shutting down test ------------- Commit messages: - Backport e6c5aa7a6cb54c647d261facdcffa6a410849627 Changes: https://git.openjdk.org/jdk23u/pull/222/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=222&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336012 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/222.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/222/head:pull/222 PR: https://git.openjdk.org/jdk23u/pull/222 From abakhtin at openjdk.org Tue Nov 12 03:50:28 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 12 Nov 2024 03:50:28 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts [v2] In-Reply-To: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> References: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> Message-ID: <qTK7M5627kV8iSAn5Oz-N9fLDHmIvLZPZWMzOI11h8k=.5855523b-f6ad-43f0-b0df-3f047a6783f1@github.com> > Hello, I'd like to backport JDK-8179502 to JDK17u to improve the timeout adjustment for OCSP GET requests (which was missed in JDK-8179503). > > The backport is almost clean except for the following: > - OCSP.java was merged manually because of JDK-8328638 and JDK-8329213 is already backported into 17u-dev > - copyright year in GetPropertyAction.java and URICertStore.java files are updated manually > - CRLReadTimeout.java test is updated manually because of the different notation of internal X509CRLImpl and CRLExtensions classes. > > All new and related jtreg tests are passed Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: Change default readtimeout to CONNECT_TIMEOUT ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2747/files - new: https://git.openjdk.org/jdk17u-dev/pull/2747/files/df460a63..e73f8c1a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2747&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2747&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2747.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2747/head:pull/2747 PR: https://git.openjdk.org/jdk17u-dev/pull/2747 From mvs at openjdk.org Tue Nov 12 05:18:47 2024 From: mvs at openjdk.org (Manukumar V S) Date: Tue, 12 Nov 2024 05:18:47 GMT Subject: [jdk23u] RFR: 8338103: Stabilize and open source a Swing OGL ButtonResizeTest Message-ID: <BAt1xhbU2xoNUhY8CEOsnSEBjUyIAg06P9fghYYKAdQ=.863440b8-3109-4b72-b86c-4c890e69d7d1@github.com> 8338103: Stabilize and open source a Swing OGL ButtonResizeTest ------------- Commit messages: - Backport 3d49fb8a17ceec6e23595bc8affc89765899f72b Changes: https://git.openjdk.org/jdk23u/pull/223/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=223&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338103 Stats: 352 lines in 1 file changed: 352 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/223.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/223/head:pull/223 PR: https://git.openjdk.org/jdk23u/pull/223 From goetz at openjdk.org Tue Nov 12 08:11:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 12 Nov 2024 08:11:27 GMT Subject: [jdk21u-dev] RFR: 8342188: Update tests to use stronger key parameters and certificates [v2] In-Reply-To: <lnh4B9TnnLJaOA9ACtYCu1nXNtrMVWVXUavYTKeKdJk=.75f8361d-034c-4118-81d5-65fa7f790ac5@github.com> References: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> <lnh4B9TnnLJaOA9ACtYCu1nXNtrMVWVXUavYTKeKdJk=.75f8361d-034c-4118-81d5-65fa7f790ac5@github.com> Message-ID: <4ZamIgI0DnD01EUe04KExZS0AYObxxUE606Vub9ar_k=.2ecae827-fca4-4400-bd11-4ff140aa58cc@github.com> On Mon, 11 Nov 2024 13:03:54 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> I backport this for parity with 21.0.6-oracle. >> >> Locally a clean patch, but /backport did not work. >> lib files included in tests. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe GHA failure: infra issue, unrelated xcode-select: error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1145#issuecomment-2469847043 From goetz at openjdk.org Tue Nov 12 08:28:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 12 Nov 2024 08:28:19 GMT Subject: [jdk17u-dev] Integrated: 8337810: ProblemList BasicDirectoryModel/LoaderThreadCount.java on Windows In-Reply-To: <727jGjP1Ry2nnHSyFf0JHUUZPubq5aJh_xZncVgTWIM=.495765b3-22f4-4b03-85c0-6617227a1632@github.com> References: <727jGjP1Ry2nnHSyFf0JHUUZPubq5aJh_xZncVgTWIM=.495765b3-22f4-4b03-85c0-6617227a1632@github.com> Message-ID: <1DYhZm4P61Yj5eKxoFyjBqxQEZP4VLEy16FI9vBxgwQ=.9e9742a8-fc34-4b45-82af-b14dd39472e9@github.com> On Wed, 6 Nov 2024 14:52:20 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I want to ProblemList this in 17, too. This pull request has now been integrated. Changeset: e4707348 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/e470734853a82f56c4d1c0715252ec8968e69b1e Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8337810: ProblemList BasicDirectoryModel/LoaderThreadCount.java on Windows Backport-of: f92c60e1a9968620cbc92b52aa546b57c09da487 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3031 From duke at openjdk.org Tue Nov 12 08:42:18 2024 From: duke at openjdk.org (KavyaKS94) Date: Tue, 12 Nov 2024 08:42:18 GMT Subject: [jdk23u] RFR: 8337339: gc/arguments/Test*SizeFlags.java timing out with Xcomp Message-ID: <fudF_UPdlxV6FKuCUcaMdCWF09ztnScCuwh_-PQkB-0=.2f10f6ef-d680-424d-b90c-b62527f2d01f@github.com> Clean backport. disabling these tests in Xcomp. Tested in mach5 ------------- Commit messages: - 8337339: gc/arguments/Test*SizeFlags.java timing out with Xcomp Changes: https://git.openjdk.org/jdk23u/pull/224/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=224&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337339 Stats: 3 lines in 3 files changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/224.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/224/head:pull/224 PR: https://git.openjdk.org/jdk23u/pull/224 From duke at openjdk.org Tue Nov 12 09:16:21 2024 From: duke at openjdk.org (KavyaKS94) Date: Tue, 12 Nov 2024 09:16:21 GMT Subject: [jdk23u] RFR: 8337339: gc/arguments/Test*SizeFlags.java timing out with Xcomp In-Reply-To: <fudF_UPdlxV6FKuCUcaMdCWF09ztnScCuwh_-PQkB-0=.2f10f6ef-d680-424d-b90c-b62527f2d01f@github.com> References: <fudF_UPdlxV6FKuCUcaMdCWF09ztnScCuwh_-PQkB-0=.2f10f6ef-d680-424d-b90c-b62527f2d01f@github.com> Message-ID: <CjLuNQ_DooG6qaONjrDUOju0Phbcfu8Hata9RE1X3DA=.fb48982e-ae59-4561-b5ca-9837da3a39ca@github.com> On Tue, 12 Nov 2024 08:37:08 GMT, KavyaKS94 <duke at openjdk.org> wrote: > Clean backport. disabling these tests in Xcomp. Tested in mach5 Withdrawing PR ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/224#issuecomment-2469981725 From duke at openjdk.org Tue Nov 12 09:16:21 2024 From: duke at openjdk.org (KavyaKS94) Date: Tue, 12 Nov 2024 09:16:21 GMT Subject: [jdk23u] Withdrawn: 8337339: gc/arguments/Test*SizeFlags.java timing out with Xcomp In-Reply-To: <fudF_UPdlxV6FKuCUcaMdCWF09ztnScCuwh_-PQkB-0=.2f10f6ef-d680-424d-b90c-b62527f2d01f@github.com> References: <fudF_UPdlxV6FKuCUcaMdCWF09ztnScCuwh_-PQkB-0=.2f10f6ef-d680-424d-b90c-b62527f2d01f@github.com> Message-ID: <lNQau_AzNHEZ1_E47qxfGeX0UsgdmP0ET5NjvIr9j6U=.ef140288-cd11-455c-820a-3763bbd5fbbc@github.com> On Tue, 12 Nov 2024 08:37:08 GMT, KavyaKS94 <duke at openjdk.org> wrote: > Clean backport. disabling these tests in Xcomp. Tested in mach5 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk23u/pull/224 From duke at openjdk.org Tue Nov 12 14:53:01 2024 From: duke at openjdk.org (duke) Date: Tue, 12 Nov 2024 14:53:01 GMT Subject: [jdk23u] RFR: 8342489: compiler/c2/irTests/TestVectorizationMismatchedAccess.java fails on big-endian platforms In-Reply-To: <b396ycf-4ehcbBnQSAue-uZAixgMqXKLxI7lBs2GcuE=.1448c976-df96-485f-afff-286984630c45@github.com> References: <b396ycf-4ehcbBnQSAue-uZAixgMqXKLxI7lBs2GcuE=.1448c976-df96-485f-afff-286984630c45@github.com> Message-ID: <wP-6SUp3xSyqIACZSawR-Pb7auA7CJD1x9-olOSj0oU=.a312f232-653a-4595-9aee-7f3a3b80ddf7@github.com> On Wed, 30 Oct 2024 03:32:37 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [b6f745df](https://github.com/openjdk/jdk/commit/b6f745df5795341dab1fc049a188a9e70d563a1a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 30 Oct 2024 and was reviewed by Emanuel Peter and Matthias Baesken. > > Thanks! @offamitkumar Your change (at version ca6ae2db303c18b246fff7095f17d0df5ad3ec20) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/211#issuecomment-2470738269 From goetz at openjdk.org Tue Nov 12 15:35:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 12 Nov 2024 15:35:58 GMT Subject: [jdk17u-dev] RFR: 8300416: java.security.MessageDigestSpi clone can result in thread-unsafe clones Message-ID: <BUiczzTncE_deDvnCPH-46BYgKT_WqksCVUhrQ2CVRY=.9cabe268-00b0-4f5c-9f72-70cd6329380c@github.com> I would like to fix this in 17. Resolved Copyright, probably clean. ------------- Commit messages: - Backport 2e2e71e1fa326b8d30f018a3e0726bbcd6d24019 Changes: https://git.openjdk.org/jdk17u-dev/pull/3039/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3039&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300416 Stats: 64 lines in 2 files changed: 58 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3039.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3039/head:pull/3039 PR: https://git.openjdk.org/jdk17u-dev/pull/3039 From andrew at openjdk.org Tue Nov 12 20:57:56 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 12 Nov 2024 20:57:56 GMT Subject: [jdk11u-dev] RFR: 8335801: [11u] Backport of 8210988 to 11u removes gcc warnings [v2] In-Reply-To: <qnqXZY4kMk8FK0iZJ0WO7F7WtzzgkfGshj9u8s5vJRQ=.fc522631-d750-42ff-a6a0-15cd310bbf31@github.com> References: <qnqXZY4kMk8FK0iZJ0WO7F7WtzzgkfGshj9u8s5vJRQ=.fc522631-d750-42ff-a6a0-15cd310bbf31@github.com> Message-ID: <hBQxP6QErIGyMmvQnpNehVuwpDiidfJ3QkHCfeqCgmM=.8013fb78-6f11-44be-903b-2c23d2d87971@github.com> > The backport of 8210988 contained a number of issues, the most serious of which is it completely removed warnings from `gcc` builds by changing `WARNING_CFLAGS_JDK` and `WARNING_CFLAGS_JVM`, but not defining `WARNINGS_ENABLE_ALL`, `WARNINGS_ENABLE_ADDITIONAL_JVM` and `DISABLED_WARNINGS`. > > The other more minor issues are the silent inclusion of `-Wreorder` to clang builds (should be a backport of [JDK-8208672](https://bugs.openjdk.org/browse/JDK-8208672)) and `-xc99=%none` (reverting [JDK-8215296](https://bugs.openjdk.org/browse/JDK-8215296)), because new lines were used as is without comparing differences in what was being replaced. > > All three of these changes show up clearly when comparing the 11u & 12u changesets, and are corrected by this patch. > > I can also confirm this has the desired effect with warnings as my local build on GCC 13 now fails again, whereas it was passing before (we need some backports there to make that work) Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge remote-tracking branch 'dev/master' into JDK-8335801 - Merge remote-tracking branch 'dev/master' into JDK-8335801 - 8335801: [11u] Backport of 8210988 to 11u removes gcc warnings ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2838/files - new: https://git.openjdk.org/jdk11u-dev/pull/2838/files/b4fadd62..4e9ee141 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2838&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2838&range=00-01 Stats: 34335 lines in 282 files changed: 19820 ins; 13189 del; 1326 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2838.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2838/head:pull/2838 PR: https://git.openjdk.org/jdk11u-dev/pull/2838 From andrew at openjdk.org Tue Nov 12 21:04:16 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 12 Nov 2024 21:04:16 GMT Subject: [jdk11u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test In-Reply-To: <2FkJtZlLbZWhK2aIJHoyLV4XWKx86kmR1oi5_Fb7pMI=.bc2e5379-7efb-4679-ade6-e2f9d9081725@github.com> References: <2FkJtZlLbZWhK2aIJHoyLV4XWKx86kmR1oi5_Fb7pMI=.bc2e5379-7efb-4679-ade6-e2f9d9081725@github.com> Message-ID: <zxwFuiF58SjghdFerqD6JYst1pgjXHTlh4qHUIyxNOU=.799faf1c-0501-47cc-b248-6ae70e3e2dd2@github.com> On Mon, 26 Aug 2024 18:25:41 GMT, Daniel Hu <duke at openjdk.org> wrote: > Clean backport that improves DataDescriptorSignatureMissing test; already backported to 17 and 21. Passes affected test in Linux x64. > MacOS GHA failing due to unrelated deprecated code during compile Confirmed clean and updated test passes. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2922#pullrequestreview-2430685247 From duke at openjdk.org Tue Nov 12 21:37:19 2024 From: duke at openjdk.org (duke) Date: Tue, 12 Nov 2024 21:37:19 GMT Subject: [jdk11u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test In-Reply-To: <2FkJtZlLbZWhK2aIJHoyLV4XWKx86kmR1oi5_Fb7pMI=.bc2e5379-7efb-4679-ade6-e2f9d9081725@github.com> References: <2FkJtZlLbZWhK2aIJHoyLV4XWKx86kmR1oi5_Fb7pMI=.bc2e5379-7efb-4679-ade6-e2f9d9081725@github.com> Message-ID: <MTieo94r1p33RFqcVLGNvS48sNMOxVjuJ0Gubrg0El8=.f2b0703b-4883-4c8b-a988-2e65c9ba0825@github.com> On Mon, 26 Aug 2024 18:25:41 GMT, Daniel Hu <duke at openjdk.org> wrote: > Clean backport that improves DataDescriptorSignatureMissing test; already backported to 17 and 21. Passes affected test in Linux x64. > MacOS GHA failing due to unrelated deprecated code during compile @cost0much Your change (at version 9a2b47253920b38455ae4c85f9f6681b006bb873) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2922#issuecomment-2471630006 From duke at openjdk.org Tue Nov 12 21:59:27 2024 From: duke at openjdk.org (Daniel Hu) Date: Tue, 12 Nov 2024 21:59:27 GMT Subject: [jdk11u-dev] Integrated: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test In-Reply-To: <2FkJtZlLbZWhK2aIJHoyLV4XWKx86kmR1oi5_Fb7pMI=.bc2e5379-7efb-4679-ade6-e2f9d9081725@github.com> References: <2FkJtZlLbZWhK2aIJHoyLV4XWKx86kmR1oi5_Fb7pMI=.bc2e5379-7efb-4679-ade6-e2f9d9081725@github.com> Message-ID: <Z2lNKh2AXj4fevaVEZ1snGZm99f2wcfmBiJ24Lfhqik=.8217b228-33fd-4033-b84a-f24023a352dd@github.com> On Mon, 26 Aug 2024 18:25:41 GMT, Daniel Hu <duke at openjdk.org> wrote: > Clean backport that improves DataDescriptorSignatureMissing test; already backported to 17 and 21. Passes affected test in Linux x64. > MacOS GHA failing due to unrelated deprecated code during compile This pull request has now been integrated. Changeset: 513a67a6 Author: Daniel Hu <costmuch at amazon.com> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk11u-dev/commit/513a67a65f2d1198c6b6f84c2e21e60e02566690 Stats: 158 lines in 1 file changed: 52 ins; 38 del; 68 mod 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test Reviewed-by: andrew Backport-of: 79349b8bb30e3a358a1fec2382d44aabcf15239b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2922 From duke at openjdk.org Tue Nov 12 22:17:18 2024 From: duke at openjdk.org (Thomas Fitzsimmons) Date: Tue, 12 Nov 2024 22:17:18 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> References: <KtkIyo7j6So1uzkfDKkyHAZErOTIZVaxTnz3QwegjXE=.d7f403f8-265a-441c-90c7-e1a7002ac255@github.com> <okIm37DGqMjsFocfXo32OZm6XwFCB1B9OMD8gOWQpkc=.4ecb7ed1-2058-44eb-8aea-847bc2f61be5@github.com> Message-ID: <DqWZL4ihK2WGt0x6GLiIwlnIjQfOnWe21QONvZBCckY=.c346ffa0-9e99-4714-bad2-42cf5e8f8301@github.com> On Tue, 5 Nov 2024 18:49:17 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote: >> This change improves annotation processing test coverage, see [JDK-8336942](https://bugs.openjdk.org/browse/JDK-8336942). I resolved a trivial merge conflict with JDK-8323684, which added the `nameToAnnotation` map. The modified test passes. > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 > - 8336942: Improve test coverage for class loading elements with annotations of different retentions > > Reviewed-by: vromero Thanks, that does clarify motivation. I do not see harm in merging this pull request in the meantime, even if the backport does not ultimately happen. From what I can tell (though I am not an expert in this area, and I did not step through the code) the new test lines may increase coverage of the existing `ClassReader` implementation, since they introduce an as yet unrepresented annotated type declaration pattern. And even if they are superfluous, they are harmless because they do not cause a test failure on the current `17` code. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2471693337 From andrew at openjdk.org Wed Nov 13 01:13:30 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 13 Nov 2024 01:13:30 GMT Subject: [jdk11u-dev] RFR: 8335801: [11u] Backport of 8210988 to 11u removes gcc warnings [v2] In-Reply-To: <hBQxP6QErIGyMmvQnpNehVuwpDiidfJ3QkHCfeqCgmM=.8013fb78-6f11-44be-903b-2c23d2d87971@github.com> References: <qnqXZY4kMk8FK0iZJ0WO7F7WtzzgkfGshj9u8s5vJRQ=.fc522631-d750-42ff-a6a0-15cd310bbf31@github.com> <hBQxP6QErIGyMmvQnpNehVuwpDiidfJ3QkHCfeqCgmM=.8013fb78-6f11-44be-903b-2c23d2d87971@github.com> Message-ID: <0UC02Iv5Anp5EFZITLUBsF6Bq8L4mGFBe0bVdTLkjL4=.7da7388d-1b53-4bd4-8ebc-5540564ab722@github.com> On Tue, 12 Nov 2024 20:57:56 GMT, Andrew John Hughes <andrew at openjdk.org> wrote: >> The backport of 8210988 contained a number of issues, the most serious of which is it completely removed warnings from `gcc` builds by changing `WARNING_CFLAGS_JDK` and `WARNING_CFLAGS_JVM`, but not defining `WARNINGS_ENABLE_ALL`, `WARNINGS_ENABLE_ADDITIONAL_JVM` and `DISABLED_WARNINGS`. >> >> The other more minor issues are the silent inclusion of `-Wreorder` to clang builds (should be a backport of [JDK-8208672](https://bugs.openjdk.org/browse/JDK-8208672)) and `-xc99=%none` (reverting [JDK-8215296](https://bugs.openjdk.org/browse/JDK-8215296)), because new lines were used as is without comparing differences in what was being replaced. >> >> All three of these changes show up clearly when comparing the 11u & 12u changesets, and are corrected by this patch. >> >> I can also confirm this has the desired effect with warnings as my local build on GCC 13 now fails again, whereas it was passing before (we need some backports there to make that work) > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge remote-tracking branch 'dev/master' into JDK-8335801 > - Merge remote-tracking branch 'dev/master' into JDK-8335801 > - 8335801: [11u] Backport of 8210988 to 11u removes gcc warnings Merged with latest jdk11u-dev and tests passed. Merging. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2838#issuecomment-2472055562 From andrew at openjdk.org Wed Nov 13 01:13:30 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 13 Nov 2024 01:13:30 GMT Subject: [jdk11u-dev] Integrated: 8335801: [11u] Backport of 8210988 to 11u removes gcc warnings In-Reply-To: <qnqXZY4kMk8FK0iZJ0WO7F7WtzzgkfGshj9u8s5vJRQ=.fc522631-d750-42ff-a6a0-15cd310bbf31@github.com> References: <qnqXZY4kMk8FK0iZJ0WO7F7WtzzgkfGshj9u8s5vJRQ=.fc522631-d750-42ff-a6a0-15cd310bbf31@github.com> Message-ID: <ULiTU5DMcizAG8VSqHdZpcjBUZ0aIcRt0Pf92NmneYo=.176e460a-a0a3-45cd-a10f-a09f79d324eb@github.com> On Sat, 6 Jul 2024 15:00:54 GMT, Andrew John Hughes <andrew at openjdk.org> wrote: > The backport of 8210988 contained a number of issues, the most serious of which is it completely removed warnings from `gcc` builds by changing `WARNING_CFLAGS_JDK` and `WARNING_CFLAGS_JVM`, but not defining `WARNINGS_ENABLE_ALL`, `WARNINGS_ENABLE_ADDITIONAL_JVM` and `DISABLED_WARNINGS`. > > The other more minor issues are the silent inclusion of `-Wreorder` to clang builds (should be a backport of [JDK-8208672](https://bugs.openjdk.org/browse/JDK-8208672)) and `-xc99=%none` (reverting [JDK-8215296](https://bugs.openjdk.org/browse/JDK-8215296)), because new lines were used as is without comparing differences in what was being replaced. > > All three of these changes show up clearly when comparing the 11u & 12u changesets, and are corrected by this patch. > > I can also confirm this has the desired effect with warnings as my local build on GCC 13 now fails again, whereas it was passing before (we need some backports there to make that work) This pull request has now been integrated. Changeset: c99638d3 Author: Andrew John Hughes <andrew at openjdk.org> URL: https://git.openjdk.org/jdk11u-dev/commit/c99638d35c8aea16eae244d26bc4ab8dcb080788 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod 8335801: [11u] Backport of 8210988 to 11u removes gcc warnings Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2838 From syan at openjdk.org Wed Nov 13 08:52:05 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 13 Nov 2024 08:52:05 GMT Subject: [jdk21u-dev] RFR: 8339892: Several security shell tests don't set TESTJAVAOPTS Message-ID: <vkDj7PWOtPU5fUNzdwIc6sfb7Kw1SPl3UYz1jE-qQZY=.9ca0f697-090d-43a5-a0f2-ceda180e4e89@github.com> Hi all, This pull request contains a backport of commit [8a2a75e5](https://github.com/openjdk/jdk/commit/8a2a75e56de4497da48f43b3be3eb71bf3ef75ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sonia Zaldana Calles on 12 Nov 2024 and was reviewed by Valerie Peng. Thanks! ------------- Commit messages: - Backport 8a2a75e56de4497da48f43b3be3eb71bf3ef75ab Changes: https://git.openjdk.org/jdk21u-dev/pull/1147/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1147&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339892 Stats: 22 lines in 10 files changed: 0 ins; 0 del; 22 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1147.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1147/head:pull/1147 PR: https://git.openjdk.org/jdk21u-dev/pull/1147 From syan at openjdk.org Wed Nov 13 08:52:21 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 13 Nov 2024 08:52:21 GMT Subject: [jdk23u] RFR: 8339892: Several security shell tests don't set TESTJAVAOPTS Message-ID: <F25RZoZxQPHv1fbG4sLG0ihL9K38tmZV-r9_ZkJuiIg=.503583d7-9977-48bb-9611-c6e0b30328a0@github.com> Hi all, This pull request contains a backport of commit [8a2a75e5](https://github.com/openjdk/jdk/commit/8a2a75e56de4497da48f43b3be3eb71bf3ef75ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sonia Zaldana Calles on 12 Nov 2024 and was reviewed by Valerie Peng. Thanks! ------------- Commit messages: - Backport 8a2a75e56de4497da48f43b3be3eb71bf3ef75ab Changes: https://git.openjdk.org/jdk23u/pull/225/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=225&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339892 Stats: 22 lines in 10 files changed: 0 ins; 0 del; 22 mod Patch: https://git.openjdk.org/jdk23u/pull/225.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/225/head:pull/225 PR: https://git.openjdk.org/jdk23u/pull/225 From goetz at openjdk.org Wed Nov 13 09:21:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Nov 2024 09:21:57 GMT Subject: [jdk21u-dev] RFR: 8342181: Update tests to use stronger Key and Salt size In-Reply-To: <vU72O0T41l7FNyMNdCdzyxNZVIWS0h8MJG8aXUiOS3I=.71cb9724-dc49-4e73-8352-a15362cbb7f5@github.com> References: <vU72O0T41l7FNyMNdCdzyxNZVIWS0h8MJG8aXUiOS3I=.71cb9724-dc49-4e73-8352-a15362cbb7f5@github.com> Message-ID: <_YrswnwQJ2iZMIrYEODn-Dsad8vIr4t7SrYe1eLa4qc=.6f9edab1-a222-489a-aa59-fc1f9b8a6deb@github.com> On Mon, 11 Nov 2024 10:48:15 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > Resolved TestOAEPPadding because of context difference. Probably considered clean. GHA failure: infra issue, unrelated xcode-select: error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1144#issuecomment-2472921253 From goetz at openjdk.org Wed Nov 13 09:21:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Nov 2024 09:21:59 GMT Subject: [jdk21u-dev] Integrated: 8343474: [updates] Customize README.md to specifics of update project In-Reply-To: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> References: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> Message-ID: <qbdrCLaDhiKS0-k7feGh3pvMQkoMRYLcGe_1aR0A6Vs=.ed7078b3-ddda-47dd-9423-a7858b863dec@github.com> On Sat, 2 Nov 2024 12:25:29 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > Customize the README.md to jdk21u. > > Plan is to backport this to 17 and maybe older jdks and adapt the paths etc correspondingly. > So let?s keep this sufficiently generic so that the information holds for jdkXu and jdkXu-dev > and that the change can easily be backported (by adapting 21->17 etc). > > Should we put there more information? This pull request has now been integrated. Changeset: 22d5e0d1 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/22d5e0d1f8849410abe40165b58f45f5e4293884 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod 8343474: [updates] Customize README.md to specifics of update project Reviewed-by: clanger, sgehwolf, andrew, aph ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1118 From goetz at openjdk.org Wed Nov 13 09:23:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Nov 2024 09:23:09 GMT Subject: [jdk17u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project Message-ID: <vLPSdUoaOMLnfTiBxORZW6DLlFjKTN3HZW_O3Hz5m8g=.c49b589b-c779-4869-80c8-481d75f07df9@github.com> I want to keep the README in sync with 21. Adapted all mention of 21 to 17. ------------- Commit messages: - Backport 22d5e0d1f8849410abe40165b58f45f5e4293884 Changes: https://git.openjdk.org/jdk17u-dev/pull/3040/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3040&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343474 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3040.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3040/head:pull/3040 PR: https://git.openjdk.org/jdk17u-dev/pull/3040 From sgehwolf at openjdk.org Wed Nov 13 09:33:10 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 13 Nov 2024 09:33:10 GMT Subject: [jdk17u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project In-Reply-To: <vLPSdUoaOMLnfTiBxORZW6DLlFjKTN3HZW_O3Hz5m8g=.c49b589b-c779-4869-80c8-481d75f07df9@github.com> References: <vLPSdUoaOMLnfTiBxORZW6DLlFjKTN3HZW_O3Hz5m8g=.c49b589b-c779-4869-80c8-481d75f07df9@github.com> Message-ID: <sTf1pYbzuudLMi3kRIz0AO6XC0enjWQOHKcaw2bRAPI=.fc6ac5c6-b81c-424b-b1e9-134df3555c92@github.com> On Wed, 13 Nov 2024 09:18:01 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I want to keep the README in sync with 21. > > Adapted all mention of 21 to 17. Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3040#pullrequestreview-2432436091 From amitkumar at openjdk.org Wed Nov 13 09:46:55 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Wed, 13 Nov 2024 09:46:55 GMT Subject: [jdk23u] RFR: 8342489: compiler/c2/irTests/TestVectorizationMismatchedAccess.java fails on big-endian platforms In-Reply-To: <b396ycf-4ehcbBnQSAue-uZAixgMqXKLxI7lBs2GcuE=.1448c976-df96-485f-afff-286984630c45@github.com> References: <b396ycf-4ehcbBnQSAue-uZAixgMqXKLxI7lBs2GcuE=.1448c976-df96-485f-afff-286984630c45@github.com> Message-ID: <qbldON3ed_M1S66VmuReUhMzzDXjkdYk3GbdYPdJd4g=.16c203fb-3122-4439-ba77-7604ae4faa7a@github.com> On Wed, 30 Oct 2024 03:32:37 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [b6f745df](https://github.com/openjdk/jdk/commit/b6f745df5795341dab1fc049a188a9e70d563a1a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 30 Oct 2024 and was reviewed by Emanuel Peter and Matthias Baesken. > > Thanks! @MBaesken can you sponsor this change, please. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/211#issuecomment-2473006794 From mbaesken at openjdk.org Wed Nov 13 10:23:54 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 13 Nov 2024 10:23:54 GMT Subject: [jdk23u] RFR: 8342489: compiler/c2/irTests/TestVectorizationMismatchedAccess.java fails on big-endian platforms In-Reply-To: <b396ycf-4ehcbBnQSAue-uZAixgMqXKLxI7lBs2GcuE=.1448c976-df96-485f-afff-286984630c45@github.com> References: <b396ycf-4ehcbBnQSAue-uZAixgMqXKLxI7lBs2GcuE=.1448c976-df96-485f-afff-286984630c45@github.com> Message-ID: <rL2rE7NonT_AiM11RvrFg4o4NdCEFDMYGdRA_I8Taas=.414ec0c4-96d0-4a83-8f93-d04703f40334@github.com> On Wed, 30 Oct 2024 03:32:37 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [b6f745df](https://github.com/openjdk/jdk/commit/b6f745df5795341dab1fc049a188a9e70d563a1a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 30 Oct 2024 and was reviewed by Emanuel Peter and Matthias Baesken. > > Thanks! Sure ! ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/211#issuecomment-2473076067 From amitkumar at openjdk.org Wed Nov 13 10:23:55 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Wed, 13 Nov 2024 10:23:55 GMT Subject: [jdk23u] Integrated: 8342489: compiler/c2/irTests/TestVectorizationMismatchedAccess.java fails on big-endian platforms In-Reply-To: <b396ycf-4ehcbBnQSAue-uZAixgMqXKLxI7lBs2GcuE=.1448c976-df96-485f-afff-286984630c45@github.com> References: <b396ycf-4ehcbBnQSAue-uZAixgMqXKLxI7lBs2GcuE=.1448c976-df96-485f-afff-286984630c45@github.com> Message-ID: <gJ_xiNfprGeEwaieI-bT1zmwo6m2z8eyUL-089xoPXU=.0ef68e0c-5a84-4a80-9aff-09c9fd851ce4@github.com> On Wed, 30 Oct 2024 03:32:37 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [b6f745df](https://github.com/openjdk/jdk/commit/b6f745df5795341dab1fc049a188a9e70d563a1a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 30 Oct 2024 and was reviewed by Emanuel Peter and Matthias Baesken. > > Thanks! This pull request has now been integrated. Changeset: 37c05c05 Author: Amit Kumar <amitkumar at openjdk.org> Committer: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk23u/commit/37c05c05c1977bcf22cdeb9d0b6c44a4fa51d7cc Stats: 31 lines in 1 file changed: 8 ins; 3 del; 20 mod 8342489: compiler/c2/irTests/TestVectorizationMismatchedAccess.java fails on big-endian platforms Backport-of: b6f745df5795341dab1fc049a188a9e70d563a1a ------------- PR: https://git.openjdk.org/jdk23u/pull/211 From goetz at openjdk.org Wed Nov 13 10:33:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Nov 2024 10:33:45 GMT Subject: [jdk21u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project [v3] In-Reply-To: <2n6_6tHOaCk6r19zEQS7_wvv1_sZ92ac_DxOGJAb7dI=.92554dee-7944-4f80-a039-a27c41d983e5@github.com> References: <wwtlbJ1B98GDQ0yDnAJO30cn436BgKlCwj3i5FUcaQ8=.aa03bbe8-4107-4e5e-b23f-24dba10b482e@github.com> <2n6_6tHOaCk6r19zEQS7_wvv1_sZ92ac_DxOGJAb7dI=.92554dee-7944-4f80-a039-a27c41d983e5@github.com> Message-ID: <1-44_hVFOz6ik0eQJRJaSdNvzJ2ZazJBxdPCibSeRJY=.884c3995-1b6d-49b8-91dd-d615d3b08822@github.com> On Mon, 11 Nov 2024 15:20:14 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> Customize the README.md to jdk21u. >> >> Plan is to backport this to 17 and maybe older jdks and adapt the paths etc correspondingly. >> So let?s keep this sufficiently generic so that the information holds for jdkXu and jdkXu-dev >> and that the change can easily be backported (by adapting 21->17 etc). >> >> Should we put there more information? > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Taking over suggestion of Andrew > > Yes, this makes it much clearer. Thanks! > > Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com> Thanks for the reviews and help with this! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1118#issuecomment-2473121322 From mbaesken at openjdk.org Wed Nov 13 12:40:04 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 13 Nov 2024 12:40:04 GMT Subject: [jdk21u-dev] RFR: 8340801: Disable ubsan checks in some awt/2d coding Message-ID: <uLsfAj9wKB3U5nYjqqNWk4C4v7boO3uP5nohy9zNStY=.3f6a28a5-0ad8-4239-9eda-973f3c58ff7a@github.com> 8340801: Disable ubsan checks in some awt/2d coding ------------- Commit messages: - Backport e7cf25ce0efdf568fc8eaff249d49e46d5a6eda1 Changes: https://git.openjdk.org/jdk21u-dev/pull/1148/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1148&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340801 Stats: 45 lines in 2 files changed: 45 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1148.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1148/head:pull/1148 PR: https://git.openjdk.org/jdk21u-dev/pull/1148 From fferrari at openjdk.org Wed Nov 13 13:16:45 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Wed, 13 Nov 2024 13:16:45 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts [v2] In-Reply-To: <qTK7M5627kV8iSAn5Oz-N9fLDHmIvLZPZWMzOI11h8k=.5855523b-f6ad-43f0-b0df-3f047a6783f1@github.com> References: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> <qTK7M5627kV8iSAn5Oz-N9fLDHmIvLZPZWMzOI11h8k=.5855523b-f6ad-43f0-b0df-3f047a6783f1@github.com> Message-ID: <cdaBdlGTPG01yPrqZ6UHWfadfRsIWcX6E23Y84IlgmM=.570b746a-3284-4873-a0cc-a9a30e8b4eaf@github.com> On Tue, 12 Nov 2024 03:50:28 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote: >> Hello, I'd like to backport JDK-8179502 to JDK17u to improve the timeout adjustment for OCSP GET requests (which was missed in JDK-8179503). >> >> The backport is almost clean except for the following: >> - OCSP.java was merged manually because of JDK-8328638 and JDK-8329213 is already backported into 17u-dev >> - copyright year in GetPropertyAction.java and URICertStore.java files are updated manually >> - CRLReadTimeout.java test is updated manually because of the different notation of internal X509CRLImpl and CRLExtensions classes. >> >> All new and related jtreg tests are passed > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > Change default readtimeout to CONNECT_TIMEOUT src/java.base/share/classes/sun/security/provider/certpath/OCSP.java line 72: > 70: > 71: private static final int DEFAULT_CONNECT_TIMEOUT = 15000; > 72: private static final int DEFAULT_READ_TIMEOUT = 15000; Hi @alexeybakhtin and @GoeLin, After e73f8c1a0301574a3248081a80142d7fbc9c8b74, `DEFAULT_READ_TIMEOUT` is now unused and can be removed. Apparently, this backward-compatibility problem went undetected in the original change. Please also note that the behavior is no longer aligned with [the CSR](https://bugs.openjdk.org/browse/JDK-8337407 "JDK-8337407: Enhance OCSP, CRL and Certificate Fetch Timeouts") (emphasis by me): > For __*all properties*__, existing and new, the proposed expanded syntax will conform to the following: > > - […] > - As with the current behavior, non-numeric, non-decimal (e.g. hexadecimal values prepended by "0x", etc) values will be interpreted as illegal and __*will default to the 15 second timeout*__. The same is true for negative values. `com.sun.security.ocsp.readtimeout` is now an exceptional case, it won't default to the 15 seconds timeout, but to `com.sun.security.ocsp.timeout` (which defaults to 15 seconds). Should the CSR be adjusted? Otherwise, how do we ensure Oracle's backport behaves the same way? I don't have enough backporting experience, is it usually accepted to diverge from newer releases (≥ 21u) in a backport CSR? ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#discussion_r1840245556 From mbaesken at openjdk.org Wed Nov 13 13:20:39 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 13 Nov 2024 13:20:39 GMT Subject: [jdk21u-dev] RFR: 8336911: ZGC: Division by zero in heuristics after JDK-8332717 Message-ID: <dOdlx73EdQkwTvyIiklGPHiQ1mXn2A_jPgc3sQg78Rs=.0f5b0d8a-5942-4e7b-af3a-0c765e117e98@github.com> 8336911: ZGC: Division by zero in heuristics after JDK-8332717 ------------- Commit messages: - Backport 1cc32237aee03a38bfb0f6679f7328a682ad6ea9 Changes: https://git.openjdk.org/jdk21u-dev/pull/1149/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1149&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336911 Stats: 13 lines in 1 file changed: 13 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1149.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1149/head:pull/1149 PR: https://git.openjdk.org/jdk21u-dev/pull/1149 From mbaesken at openjdk.org Wed Nov 13 13:44:03 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 13 Nov 2024 13:44:03 GMT Subject: [jdk21u-dev] RFR: 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp Message-ID: <oXnw9oUMoM-QNz4l89lET2BEuka0v15o54h__uCFpW8=.ada1e3b0-517e-426d-8681-345990985251@github.com> clean after adding static to __ieee754_pow see 8252136 ------------- Commit messages: - Backport 37cfaa8deb4cc15864bb6dc2c8a87fc97cff2f0d Changes: https://git.openjdk.org/jdk21u-dev/pull/1150/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1150&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338449 Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1150.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1150/head:pull/1150 PR: https://git.openjdk.org/jdk21u-dev/pull/1150 From jan.lahoda at oracle.com Wed Nov 13 13:55:56 2024 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Wed, 13 Nov 2024 14:55:56 +0100 Subject: CFV: New JDK Updates Committer - Adam Sotona In-Reply-To: <519ef1bb-982d-427b-9797-c9a18c6f6f86@oracle.com> References: <519ef1bb-982d-427b-9797-c9a18c6f6f86@oracle.com> Message-ID: <92490085-a2a8-4c6f-9683-31223255d802@oracle.com> The vote for Adam Sotona [1] is now closed. Yes: 3 No: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus [2], this is sufficient to approve the nomination. Jan [1] https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-October/038659.html [2] https://openjdk.org/bylaws#lazy-consensus On 24. 10. 24 16:30, Jan Lahoda wrote: > I hereby nominate Adam Sotona to JDK Updates Committer. > > Adam is a Reviewer on the JDK project, working mainly on the ClassFile > API, but also on other projects related to the javac compiler and > core-libs. > > He has over 100 integrated patches inside the JDK[3]. > > Votes are due by Nov 8, 2024. > > Only current JDK Updates Committers [1] are eligible to vote on this > nomination.? Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Best regards, > > Jan > > [1] https://openjdk.org/census#jdk-updates > [2] https://openjdk.org/projects/#committer-vote > [3] https://github.com/openjdk/jdk23u/commits/master/?author=asotona > From jan.lahoda at oracle.com Wed Nov 13 13:57:36 2024 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Wed, 13 Nov 2024 14:57:36 +0100 Subject: Result: New JDK Committer: Adam Sotona In-Reply-To: <519ef1bb-982d-427b-9797-c9a18c6f6f86@oracle.com> References: <519ef1bb-982d-427b-9797-c9a18c6f6f86@oracle.com> Message-ID: <e14068fa-c63f-4162-b8c2-f0c7a73cadeb@oracle.com> [resending with correct subject - sorry for any inconvenience] The vote for Adam Sotona [1] is now closed. Yes: 3 No: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus [2], this is sufficient to approve the nomination. Jan [1] https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-October/038659.html [2] https://openjdk.org/bylaws#lazy-consensus On 24. 10. 24 16:30, Jan Lahoda wrote: > I hereby nominate Adam Sotona to JDK Updates Committer. > > Adam is a Reviewer on the JDK project, working mainly on the ClassFile > API, but also on other projects related to the javac compiler and > core-libs. > > He has over 100 integrated patches inside the JDK[3]. > > Votes are due by Nov 8, 2024. > > Only current JDK Updates Committers [1] are eligible to vote on this > nomination.? Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Best regards, > > Jan > > [1] https://openjdk.org/census#jdk-updates > [2] https://openjdk.org/projects/#committer-vote > [3] https://github.com/openjdk/jdk23u/commits/master/?author=asotona > From jan.lahoda at oracle.com Wed Nov 13 13:59:30 2024 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Wed, 13 Nov 2024 14:59:30 +0100 Subject: Result: New JDK _Updates_ Committer: Adam Sotona In-Reply-To: <519ef1bb-982d-427b-9797-c9a18c6f6f86@oracle.com> References: <519ef1bb-982d-427b-9797-c9a18c6f6f86@oracle.com> Message-ID: <ae93cc2c-f19f-4018-8f16-08a672337643@oracle.com> [resending with correct subject - sorry for any inconvenience] The vote for Adam Sotona [1] is now closed. Yes: 3 No: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus [2], this is sufficient to approve the nomination. Jan [1] https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-October/038659.html [2] https://openjdk.org/bylaws#lazy-consensus On 24. 10. 24 16:30, Jan Lahoda wrote: > I hereby nominate Adam Sotona to JDK Updates Committer. > > Adam is a Reviewer on the JDK project, working mainly on the ClassFile > API, but also on other projects related to the javac compiler and > core-libs. > > He has over 100 integrated patches inside the JDK[3]. > > Votes are due by Nov 8, 2024. > > Only current JDK Updates Committers [1] are eligible to vote on this > nomination.? Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Best regards, > > Jan > > [1] https://openjdk.org/census#jdk-updates > [2] https://openjdk.org/projects/#committer-vote > [3] https://github.com/openjdk/jdk23u/commits/master/?author=asotona > From lucy at openjdk.org Wed Nov 13 14:34:24 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Wed, 13 Nov 2024 14:34:24 GMT Subject: [jdk17u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project In-Reply-To: <vLPSdUoaOMLnfTiBxORZW6DLlFjKTN3HZW_O3Hz5m8g=.c49b589b-c779-4869-80c8-481d75f07df9@github.com> References: <vLPSdUoaOMLnfTiBxORZW6DLlFjKTN3HZW_O3Hz5m8g=.c49b589b-c779-4869-80c8-481d75f07df9@github.com> Message-ID: <KM94JRUOu0d-a_-BpjsXFf3w6xwT12sN9j4Po6hPslw=.55545177-1be6-4323-922f-e637df552777@github.com> On Wed, 13 Nov 2024 09:18:01 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I want to keep the README in sync with 21. > > Adapted all mention of 21 to 17. LGTM. Very helpful addition. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3040#pullrequestreview-2433425341 From mbaesken at openjdk.org Wed Nov 13 14:56:56 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 13 Nov 2024 14:56:56 GMT Subject: [jdk21u-dev] RFR: 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask' Message-ID: <UIpQJBRMmlWElkAE_ggABeWl2Kt4ifPwWiPHbJphPrU=.7876ac16-952c-429c-bd2e-a73914be2f99@github.com> 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask' ------------- Commit messages: - Backport beff8bfe2a5334823b67cb748bc8652dc6a3f3d4 Changes: https://git.openjdk.org/jdk21u-dev/pull/1151/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1151&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342823 Stats: 6 lines in 2 files changed: 2 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1151.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1151/head:pull/1151 PR: https://git.openjdk.org/jdk21u-dev/pull/1151 From mdoerr at openjdk.org Wed Nov 13 15:47:07 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 13 Nov 2024 15:47:07 GMT Subject: [jdk21u-dev] RFR: 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp In-Reply-To: <oXnw9oUMoM-QNz4l89lET2BEuka0v15o54h__uCFpW8=.ada1e3b0-517e-426d-8681-345990985251@github.com> References: <oXnw9oUMoM-QNz4l89lET2BEuka0v15o54h__uCFpW8=.ada1e3b0-517e-426d-8681-345990985251@github.com> Message-ID: <bXTsn1Rm5bl-ie-jtLzsOAZBy_kLICh7vc4ERBgKh_A=.ff323d0f-e7f5-4bec-8cd6-1a058577341e@github.com> On Wed, 13 Nov 2024 13:37:49 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > clean after adding static to __ieee754_pow see 8252136 Ok. The small addition from https://github.com/openjdk/jdk/commit/09d4936657a0bdc122a4ab80735bd9c8c109839c LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1150#pullrequestreview-2433652484 From abakhtin at openjdk.org Wed Nov 13 18:21:39 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 13 Nov 2024 18:21:39 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts [v2] In-Reply-To: <cdaBdlGTPG01yPrqZ6UHWfadfRsIWcX6E23Y84IlgmM=.570b746a-3284-4873-a0cc-a9a30e8b4eaf@github.com> References: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> <qTK7M5627kV8iSAn5Oz-N9fLDHmIvLZPZWMzOI11h8k=.5855523b-f6ad-43f0-b0df-3f047a6783f1@github.com> <cdaBdlGTPG01yPrqZ6UHWfadfRsIWcX6E23Y84IlgmM=.570b746a-3284-4873-a0cc-a9a30e8b4eaf@github.com> Message-ID: <ouvoF62uGvFgyWP3XF_ZrrN4Sm5o5kC_sp6Q9ixtsKk=.5c0173a2-7219-4189-9b5f-fd211cbef405@github.com> On Wed, 13 Nov 2024 13:11:11 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote: >> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: >> >> Change default readtimeout to CONNECT_TIMEOUT > > src/java.base/share/classes/sun/security/provider/certpath/OCSP.java line 72: > >> 70: >> 71: private static final int DEFAULT_CONNECT_TIMEOUT = 15000; >> 72: private static final int DEFAULT_READ_TIMEOUT = 15000; > > Hi @alexeybakhtin and @GoeLin, > > After e73f8c1a0301574a3248081a80142d7fbc9c8b74, `DEFAULT_READ_TIMEOUT` is now unused and can be removed. > > Apparently, this backward-compatibility problem went undetected in the original change. Please also note that the behavior is no longer aligned with [the CSR](https://bugs.openjdk.org/browse/JDK-8337407 "JDK-8337407: Enhance OCSP, CRL and Certificate Fetch Timeouts") (emphasis by me): >> For __*all properties*__, existing and new, the proposed expanded syntax will conform to the following: >> >> - […] >> - As with the current behavior, non-numeric, non-decimal (e.g. hexadecimal values prepended by "0x", etc) values will be interpreted as illegal and __*will default to the 15 second timeout*__. The same is true for negative values. > > `com.sun.security.ocsp.readtimeout` is now an exceptional case, it won't default to the 15 seconds timeout, but to `com.sun.security.ocsp.timeout` (which defaults to 15 seconds). > > Should the CSR be adjusted? Otherwise, how do we ensure Oracle's backport behaves the same way? I don't have enough backporting experience, is it usually accepted to diverge from newer releases (≥ 21u) in a backport CSR? Hi @franferrax Thank you for the finding. I'll remove `DEFAULT_READ_TIMEOUT` You are right, the CSR for update releases should be updated for `com.sun.security.ocsp.readtimeout` default value. I'll do it and ask you to review it from an engineering point of view. I hope in this way, without backward compatibility, the patch will be accepted. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#discussion_r1840959784 From abakhtin at openjdk.org Wed Nov 13 18:30:32 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 13 Nov 2024 18:30:32 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts [v3] In-Reply-To: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> References: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> Message-ID: <A1ib3rtSqlN09KW41WuLickHFeJXWqIAKBAsBw-mIkk=.a9f75704-81f0-47dc-9271-1caa183a85a5@github.com> > Hello, I'd like to backport JDK-8179502 to JDK17u to improve the timeout adjustment for OCSP GET requests (which was missed in JDK-8179503). > > The backport is almost clean except for the following: > - OCSP.java was merged manually because of JDK-8328638 and JDK-8329213 is already backported into 17u-dev > - copyright year in GetPropertyAction.java and URICertStore.java files are updated manually > - CRLReadTimeout.java test is updated manually because of the different notation of internal X509CRLImpl and CRLExtensions classes. > > All new and related jtreg tests are passed Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: Remove unused DEFAULT_READ_TIMEOUT constant ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2747/files - new: https://git.openjdk.org/jdk17u-dev/pull/2747/files/e73f8c1a..65e02f91 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2747&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2747&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2747.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2747/head:pull/2747 PR: https://git.openjdk.org/jdk17u-dev/pull/2747 From duke at openjdk.org Wed Nov 13 20:06:07 2024 From: duke at openjdk.org (sophia-guo) Date: Wed, 13 Nov 2024 20:06:07 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 Message-ID: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> Hi, I would like to backport[ 8333248](https://bugs.openjdk.org/browse/JDK-8333248) to jdk21u. As [JDK-8325520](https://bugs.openjdk.org/browse/JDK-8325520) was also backported to 21 so the test now fails on risc-v there. ------------- Commit messages: - Backport 9b0a5c5cd056262fab99525e9260762b617152a3 Changes: https://git.openjdk.org/jdk21u-dev/pull/1100/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1100&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333248 Stats: 29 lines in 1 file changed: 0 ins; 0 del; 29 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1100.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1100/head:pull/1100 PR: https://git.openjdk.org/jdk21u-dev/pull/1100 From sgehwolf at openjdk.org Wed Nov 13 20:06:07 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 13 Nov 2024 20:06:07 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 In-Reply-To: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> Message-ID: <WT2Yxkdpf3jzUXpWQbk6CRsBy9cMt0TBqgGaDMRTN28=.f4fe4961-4f18-4095-b925-d97bcb6c668a@github.com> On Mon, 28 Oct 2024 16:52:51 GMT, sophia-guo <duke at openjdk.org> wrote: > Hi, I would like to backport[ 8333248](https://bugs.openjdk.org/browse/JDK-8333248) to jdk21u. As [JDK-8325520](https://bugs.openjdk.org/browse/JDK-8325520) was also backported to 21 so the test now fails on risc-v there. @robilad @sophia-guo Is a Red Hat employee and is covered by the RH OCA. Could you please look into her OCA status, thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1100#issuecomment-2464246264 From duke at openjdk.org Wed Nov 13 20:52:39 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Wed, 13 Nov 2024 20:52:39 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result Message-ID: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> Backport for https://bugs.openjdk.org/browse/JDK-8337066 When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. This is a clean backport. ------------- Commit messages: - Backport cd61f97c2de94d19c0101c51bde143001078c89f Changes: https://git.openjdk.org/jdk11u-dev/pull/2961/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2961&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337066 Stats: 58 lines in 2 files changed: 58 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2961.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2961/head:pull/2961 PR: https://git.openjdk.org/jdk11u-dev/pull/2961 From sgehwolf at openjdk.org Wed Nov 13 20:52:39 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 13 Nov 2024 20:52:39 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result In-Reply-To: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> Message-ID: <a3WEdeN9LpuuzjVYHUnErvSQYbmx6u_P3Jc_nwob8zw=.a8d5fbb2-5b44-4fde-9fd9-a414af0d2ddd@github.com> On Fri, 8 Nov 2024 12:44:55 GMT, Radek ??p <duke at openjdk.org> wrote: > Backport for https://bugs.openjdk.org/browse/JDK-8337066 > > When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. > > This is a clean backport. @RadekCap The PR title needs to be `Backport cd61f97c2de94d19c0101c51bde143001078c89f` so that the bots recognize this as a backport. The commit message doesn't matter. @robilad @RadekCap works for Red Hat and is covered by the Red Hat OCA. @RadekCap Please enable GHA testing for your fork. See: https://github.com/openjdk/jdk11u-dev/pull/2961/checks?check_run_id=32713036064 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2464797425 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2464804237 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2464903588 From mdoerr at openjdk.org Wed Nov 13 21:05:15 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 13 Nov 2024 21:05:15 GMT Subject: [jdk21u-dev] RFR: 8342607: Enhance register printing on x86_64 platforms Message-ID: <pS9fvMBAf9nylaUkntksVv-KEAMwIGU5nkUpuuU21FU=.758c177b-c1c5-4a1a-8acc-289ddcaf003a@github.com> Clean backport of [JDK-8342607](https://bugs.openjdk.org/browse/JDK-8342607). ------------- Commit messages: - Backport d8b3685d36873904248e9701f66459e074a4a8ab Changes: https://git.openjdk.org/jdk21u-dev/pull/1152/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1152&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342607 Stats: 37 lines in 3 files changed: 36 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1152.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1152/head:pull/1152 PR: https://git.openjdk.org/jdk21u-dev/pull/1152 From mdoerr at openjdk.org Wed Nov 13 21:05:26 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 13 Nov 2024 21:05:26 GMT Subject: [jdk21u-dev] RFR: 8343724: [PPC64] Disallow OptoScheduling Message-ID: <NcUSexWS2CcmAxE0yAeXJix9q_PHRe5AQBvYCN6CK0E=.f0f4b45c-a286-45f5-9e3b-6af7819cf1e5@github.com> Clean backport of [JDK-8343724](https://bugs.openjdk.org/browse/JDK-8343724). ------------- Commit messages: - Backport f621f26cd113090a0305598cfc50f0eac9a263c6 Changes: https://git.openjdk.org/jdk21u-dev/pull/1153/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1153&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343724 Stats: 39 lines in 2 files changed: 22 ins; 16 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1153.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1153/head:pull/1153 PR: https://git.openjdk.org/jdk21u-dev/pull/1153 From mdoerr at openjdk.org Wed Nov 13 21:35:55 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 13 Nov 2024 21:35:55 GMT Subject: [jdk21u-dev] RFR: 8343343: Misc crash dump improvements on more platforms after JDK-8294160 Message-ID: <hXGvQNmO3aDCd7QslGZqddzuwJuE3D1lRyqjagCkzjc=.e52283c1-5284-4df1-8662-b508f1649c09@github.com> Mostly clean backport of [JDK-8343343](https://bugs.openjdk.org/browse/JDK-8343343). PPC64 files use a different frame constructor after [JDK-8290965](https://bugs.openjdk.org/browse/JDK-8290965) (JDK23). ------------- Commit messages: - Backport e33dc13567a4f0d9a6c1ae63fa0424ca27d52584 Changes: https://git.openjdk.org/jdk21u-dev/pull/1154/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1154&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343343 Stats: 282 lines in 14 files changed: 63 ins; 214 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1154.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1154/head:pull/1154 PR: https://git.openjdk.org/jdk21u-dev/pull/1154 From fferrari at openjdk.org Thu Nov 14 01:27:33 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Thu, 14 Nov 2024 01:27:33 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts [v2] In-Reply-To: <ouvoF62uGvFgyWP3XF_ZrrN4Sm5o5kC_sp6Q9ixtsKk=.5c0173a2-7219-4189-9b5f-fd211cbef405@github.com> References: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> <qTK7M5627kV8iSAn5Oz-N9fLDHmIvLZPZWMzOI11h8k=.5855523b-f6ad-43f0-b0df-3f047a6783f1@github.com> <cdaBdlGTPG01yPrqZ6UHWfadfRsIWcX6E23Y84IlgmM=.570b746a-3284-4873-a0cc-a9a30e8b4eaf@github.com> <ouvoF62uGvFgyWP3XF_ZrrN4Sm5o5kC_sp6Q9ixtsKk=.5c0173a2-7219-4189-9b5f-fd211cbef405@github.com> Message-ID: <cIw3yZhzKI9YH-yvpRxwSDFAhQ_MN6jVfbJB8htSiSA=.8c2f6d7d-2a47-4897-afc4-40d2b92745d7@github.com> On Wed, 13 Nov 2024 18:18:31 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote: >> src/java.base/share/classes/sun/security/provider/certpath/OCSP.java line 72: >> >>> 70: >>> 71: private static final int DEFAULT_CONNECT_TIMEOUT = 15000; >>> 72: private static final int DEFAULT_READ_TIMEOUT = 15000; >> >> Hi @alexeybakhtin and @GoeLin, >> >> After e73f8c1a0301574a3248081a80142d7fbc9c8b74, `DEFAULT_READ_TIMEOUT` is now unused and can be removed. >> >> Apparently, this backward-compatibility problem went undetected in the original change. Please also note that the behavior is no longer aligned with [the CSR](https://bugs.openjdk.org/browse/JDK-8337407 "JDK-8337407: Enhance OCSP, CRL and Certificate Fetch Timeouts") (emphasis by me): >>> For __*all properties*__, existing and new, the proposed expanded syntax will conform to the following: >>> >>> - […] >>> - As with the current behavior, non-numeric, non-decimal (e.g. hexadecimal values prepended by "0x", etc) values will be interpreted as illegal and __*will default to the 15 second timeout*__. The same is true for negative values. >> >> `com.sun.security.ocsp.readtimeout` is now an exceptional case, it won't default to the 15 seconds timeout, but to `com.sun.security.ocsp.timeout` (which defaults to 15 seconds). >> >> Should the CSR be adjusted? Otherwise, how do we ensure Oracle's backport behaves the same way? I don't have enough backporting experience, is it usually accepted to diverge from newer releases (≥ 21u) in a backport CSR? > > Hi @franferrax > Thank you for the finding. I'll remove `DEFAULT_READ_TIMEOUT` > You are right, the CSR for update releases should be updated for `com.sun.security.ocsp.readtimeout` default value. I'll do it and ask you to review it from an engineering point of view. > I hope in this way, without backward compatibility, the patch will be accepted. I will take a look, but please note I'm not a Reviewer. One more comment, I see that the following issues are not part of the backport. Although all of them are test-only changes (mostly tuning the timeout), we might also want to include these to avoid some instability. * [JDK-8309740](https://bugs.openjdk.org/browse/JDK-8309740 "Expand timeout windows for tests in JDK-8179502"), openjdk/jdk at 5ca4cdd2caceba9dad8025e5a8851740a3961921 * [JDK-8310629](https://bugs.openjdk.org/browse/JDK-8310629 "java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready"), openjdk/jdk at b20dc1e9cda1ea3a76b3f14c778c6816e5cc1c0c * [JDK-8325024](https://bugs.openjdk.org/browse/JDK-8325024 "java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information"), openjdk/jdk at 432756b6e51c903e2bff8b9c3028a4f2ea8973f4 * [JDK-8337826](https://bugs.openjdk.org/browse/JDK-8337826 "Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754"), openjdk/jdk at 9b11bd7f4a511ddadf9f02e82aab6ba78beb6763 The last one is an ongoing effort to try to fix [JDK-8309754](https://bugs.openjdk.org/browse/JDK-8309754 "java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java failed with "Expected to pass, found 1 soft fail exceptions""), so we could alternatively wait for that fix and then make all the 5 backports together. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#discussion_r1841396469 From mbaesken at openjdk.org Thu Nov 14 08:31:41 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 14 Nov 2024 08:31:41 GMT Subject: [jdk21u-dev] RFR: 8343343: Misc crash dump improvements on more platforms after JDK-8294160 In-Reply-To: <hXGvQNmO3aDCd7QslGZqddzuwJuE3D1lRyqjagCkzjc=.e52283c1-5284-4df1-8662-b508f1649c09@github.com> References: <hXGvQNmO3aDCd7QslGZqddzuwJuE3D1lRyqjagCkzjc=.e52283c1-5284-4df1-8662-b508f1649c09@github.com> Message-ID: <1bv4BGZaF4CTOq6ygLbyZ9bzlHetvH_KVflja42-AT0=.788dab93-0e23-428e-95ea-5953d395044d@github.com> On Wed, 13 Nov 2024 21:31:14 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: > Mostly clean backport of [JDK-8343343](https://bugs.openjdk.org/browse/JDK-8343343). PPC64 files use a different frame constructor after [JDK-8290965](https://bugs.openjdk.org/browse/JDK-8290965) (JDK23). Includes [JDK-8343149](https://bugs.openjdk.org/browse/JDK-8343149). Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1154#pullrequestreview-2435355024 From mdoerr at openjdk.org Thu Nov 14 08:58:17 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 14 Nov 2024 08:58:17 GMT Subject: [jdk21u-dev] RFR: 8343343: Misc crash dump improvements on more platforms after JDK-8294160 In-Reply-To: <hXGvQNmO3aDCd7QslGZqddzuwJuE3D1lRyqjagCkzjc=.e52283c1-5284-4df1-8662-b508f1649c09@github.com> References: <hXGvQNmO3aDCd7QslGZqddzuwJuE3D1lRyqjagCkzjc=.e52283c1-5284-4df1-8662-b508f1649c09@github.com> Message-ID: <p8oXI2LCzkuJPvrE6t7eUiH55IUIZtlM0dbOFBJVpMM=.dfb3b833-89b0-4688-a626-61625b72fea0@github.com> On Wed, 13 Nov 2024 21:31:14 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: > Mostly clean backport of [JDK-8343343](https://bugs.openjdk.org/browse/JDK-8343343). PPC64 files use a different frame constructor after [JDK-8290965](https://bugs.openjdk.org/browse/JDK-8290965) (JDK23). Includes [JDK-8343149](https://bugs.openjdk.org/browse/JDK-8343149). Thanks for the review! GHA failures on macOS-aarch64 are unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1154#issuecomment-2475762781 From sgehwolf at openjdk.org Thu Nov 14 09:20:15 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 14 Nov 2024 09:20:15 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result In-Reply-To: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> Message-ID: <InD3HFV5TP_IlOTV-AYdHRfZK58EG6-8Id15_hQiH0Q=.cb98face-ef13-4607-b8cf-7f56b81dc06d@github.com> On Fri, 8 Nov 2024 12:44:55 GMT, Radek ??p <duke at openjdk.org> wrote: > Backport for https://bugs.openjdk.org/browse/JDK-8337066 > > When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. > > This is a clean backport. What testing have you done for this in addition to GHA? > This is a clean backport. The bot doesn't seem to agree with this. Did you perhaps use the JDK 17u version of the patch rather than jdk head? If so, the sha in the PR title should be the JDK 17u version. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2475807144 From sgehwolf at openjdk.org Thu Nov 14 10:09:39 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 14 Nov 2024 10:09:39 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 In-Reply-To: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> Message-ID: <bZIW0iMNgySVMS7jwEipa5p1HmnQyr-gYmJjrks2mQo=.a4b73f8a-e0e9-4a2b-a0b2-17548713c7f3@github.com> On Mon, 28 Oct 2024 16:52:51 GMT, sophia-guo <duke at openjdk.org> wrote: > Hi, I would like to backport[ 8333248](https://bugs.openjdk.org/browse/JDK-8333248) to jdk21u. As [JDK-8325520](https://bugs.openjdk.org/browse/JDK-8325520) was also backported to 21 so the test now fails on risc-v there. @sophia-guo Please enable GHA testing for your fork. See: https://github.com/openjdk/jdk21u-dev/pull/1100/checks?check_run_id=32172108437 Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1100#issuecomment-2475920345 From duke at openjdk.org Thu Nov 14 12:52:31 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Thu, 14 Nov 2024 12:52:31 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result In-Reply-To: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> Message-ID: <ZjW1y6R4mAmuk2LQdM25qU5q4jkEiz_upKOuPolcgr4=.81885560-e7d9-4c29-9952-cf0d56a4ae21@github.com> On Fri, 8 Nov 2024 12:44:55 GMT, Radek ??p <duke at openjdk.org> wrote: > Backport for https://bugs.openjdk.org/browse/JDK-8337066 > > When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. > > This is a clean backport. My bad. I've cherrypicked it from 17u-dev instead of 17u. Lesson learned, thank you. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2476275211 From syan at openjdk.org Thu Nov 14 13:06:56 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 14 Nov 2024 13:06:56 GMT Subject: [jdk23u] RFR: 8339892: Several security shell tests don't set TESTJAVAOPTS In-Reply-To: <F25RZoZxQPHv1fbG4sLG0ihL9K38tmZV-r9_ZkJuiIg=.503583d7-9977-48bb-9611-c6e0b30328a0@github.com> References: <F25RZoZxQPHv1fbG4sLG0ihL9K38tmZV-r9_ZkJuiIg=.503583d7-9977-48bb-9611-c6e0b30328a0@github.com> Message-ID: <ALgBuUhpVTF1na7B0grK1Uh1HrAE7Mwv-S_N2wuYB9s=.01047c02-29a4-4ca8-a72c-a2a58e3452ae@github.com> On Wed, 13 Nov 2024 08:47:33 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8a2a75e5](https://github.com/openjdk/jdk/commit/8a2a75e56de4497da48f43b3be3eb71bf3ef75ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sonia Zaldana Calles on 12 Nov 2024 and was reviewed by Valerie Peng. > > Thanks! GHA report 2 failures 1. macos-aarch64 job at `install toolchain and dependencies` stage fails `invalid developer directory` seems like environmental issue, it's unreleated to this issue. 2. windows-x64 job jtreg test `java/util/zip/ZipFile/ZipSourceCache.java` fails `The process cannot access the file because it is being used by another process` seems like environmental issue or test bug, it's unreleated to this issue. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/225#issuecomment-2476304170 From syan at openjdk.org Thu Nov 14 13:08:42 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 14 Nov 2024 13:08:42 GMT Subject: [jdk21u-dev] RFR: 8339892: Several security shell tests don't set TESTJAVAOPTS In-Reply-To: <vkDj7PWOtPU5fUNzdwIc6sfb7Kw1SPl3UYz1jE-qQZY=.9ca0f697-090d-43a5-a0f2-ceda180e4e89@github.com> References: <vkDj7PWOtPU5fUNzdwIc6sfb7Kw1SPl3UYz1jE-qQZY=.9ca0f697-090d-43a5-a0f2-ceda180e4e89@github.com> Message-ID: <EOBfH5oMCnEZDySbz5EP9SF0QlpHd2fpWw_FvpMEHxM=.b305594a-3202-4553-8747-9791702f6f65@github.com> On Wed, 13 Nov 2024 08:47:23 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8a2a75e5](https://github.com/openjdk/jdk/commit/8a2a75e56de4497da48f43b3be3eb71bf3ef75ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sonia Zaldana Calles on 12 Nov 2024 and was reviewed by Valerie Peng. > > Thanks! GHA report a test failure 1. macos-aarch64 job at install toolchain and dependencies stage fails invalid developer directory seems like environmental issue, it's unreleated to this issue. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1147#issuecomment-2476308966 From syan at openjdk.org Thu Nov 14 13:24:41 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 14 Nov 2024 13:24:41 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v8] In-Reply-To: <zKl5MYAUM51Sb4KLPf3H8UACqLiruP52zRasjInW4Yk=.aa649c8d-3f2e-4dd7-a1b0-9a230fa33b68@github.com> References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> <zKl5MYAUM51Sb4KLPf3H8UACqLiruP52zRasjInW4Yk=.aa649c8d-3f2e-4dd7-a1b0-9a230fa33b68@github.com> Message-ID: <Cxujct7TuPAVJmGB2ctO5bXzy7xq40TLokjQ5f-FOf8=.0f779459-f107-4c94-a4c9-1e40a24e5d08@github.com> On Wed, 4 Sep 2024 01:13:01 GMT, SendaoYan <syan at openjdk.org> wrote: >> Hi, >> This is backport of [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023) and [JDK-8290269](https://bugs.openjdk.org/browse/JDK-8290269), this PR is prefixed PR of backport >> [JDK-8293503](https://github.com/openjdk/jdk17u-dev/pull/2431 ) >> >> Only change the testcase, additional testing: >> >> - [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 release build >> - [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 fastdebug build >> - [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 release build >> - [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 fastdebug build >> >> It's not clean backport: >> 1. test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR `8210708` before `8290023` jdk20 >> 2. There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev >> 3. test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported `8298073` and `8241293` after `8290023` in jdk17u-dev >> 4. test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR `8284161` before `8290023` in jdk20 > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > backport JDK-8290269, to fix error: "TEST RESULT: Error. Parse Exception: Invalid tag: required" Give up backport to 17u. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2438#issuecomment-2476342300 From syan at openjdk.org Thu Nov 14 13:24:45 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 14 Nov 2024 13:24:45 GMT Subject: [jdk17u-dev] Withdrawn: 8293503: gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 failed assertGreaterThanOrEqual: expected MMM >= NNN In-Reply-To: <aJanb8p42n2CMpdvv2WMLxZSVVJlDDvj4A6QEENGQiU=.930c6e37-2954-48c5-aa37-929a1861f8e1@github.com> References: <aJanb8p42n2CMpdvv2WMLxZSVVJlDDvj4A6QEENGQiU=.930c6e37-2954-48c5-aa37-929a1861f8e1@github.com> Message-ID: <rLjTMfpw02vyNjD6bNLvJrtgsuOIagpkRGFH6sLfrZU=.cf1d74b5-dc06-4d95-aff2-d7e4bfd04185@github.com> On Fri, 26 Apr 2024 09:19:21 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi, > Backport of JDK-[8293503](https://bugs.openjdk.org/browse/JDK-8293503), to fix the [intermittent failure](https://github.com/openjdk-bots/jdk17u-dev/actions/runs/8841821807/job/24280514750) of TestMetaspacePerfCounters.java. > This PR add a proper barrier inbetween two measurements. Only change the testcase, the change has been verify on below binary: > > - [x] linux x64 release > - [x] linux x64 fastdebug > - [x] linux x86 release > - [x] linux x86 fastdebug This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2431 From syan at openjdk.org Thu Nov 14 13:24:42 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 14 Nov 2024 13:24:42 GMT Subject: [jdk17u-dev] Withdrawn: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests In-Reply-To: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: <1LMnt_vrjXxhyRHXzk_EskMZHYDF9X4HHr3bIq3Ia40=.36881049-0218-4d51-b994-56098418d138@github.com> On Sun, 28 Apr 2024 09:55:01 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi, > This is backport of [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023) and [JDK-8290269](https://bugs.openjdk.org/browse/JDK-8290269), this PR is prefixed PR of backport > [JDK-8293503](https://github.com/openjdk/jdk17u-dev/pull/2431 ) > > Only change the testcase, additional testing: > > - [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 release build > - [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 fastdebug build > - [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 release build > - [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 fastdebug build > > It's not clean backport: > 1. test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR `8210708` before `8290023` jdk20 > 2. There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev > 3. test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported `8298073` and `8241293` after `8290023` in jdk17u-dev > 4. test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR `8284161` before `8290023` in jdk20 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2438 From syan at openjdk.org Thu Nov 14 13:24:48 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 14 Nov 2024 13:24:48 GMT Subject: [jdk17u-dev] Withdrawn: 8319569: Several java/util tests should be updated to accept VM flags In-Reply-To: <PBj0vpIOtMWI8rCnbVdPXDtJUwpy_fv3rHfyvd8Tecg=.9a6e7958-d31f-4be0-960e-ce545246ec82@github.com> References: <PBj0vpIOtMWI8rCnbVdPXDtJUwpy_fv3rHfyvd8Tecg=.9a6e7958-d31f-4be0-960e-ce545246ec82@github.com> Message-ID: <fOJpPUewl9cLTnoQ0OYThl8791eU51o-QRltllDi_34=.5273bd63-98f4-428c-92d9-788a7a79c22f@github.com> On Fri, 21 Jun 2024 01:08:43 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [2bb4b939](https://github.com/openjdk/jdk/commit/2bb4b9398d65e3f37f34e45476c969ff0afb1540) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Justin Lu on 23 Nov 2023 and was reviewed by Naoto Sato and Lance Andersen. > > There are two files make this backport not clean: > > 1. jdk17u-dev doesn't have file `test/jdk/java/util/Currency/PropertiesTest.sh` > 2. `test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java` has previous change before the backport PR in jdk-tip > > Additional testing > > - [ ] change verify > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2620 From duke at openjdk.org Thu Nov 14 13:36:35 2024 From: duke at openjdk.org (akhilesh-delphix) Date: Thu, 14 Nov 2024 13:36:35 GMT Subject: [jdk17u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases In-Reply-To: <h8hHnXMIy1TI1faMK7SBqjQeANYWMLn1zor8lwQYe90=.938dd42a-076f-4552-9be1-06a965f240e8@github.com> References: <h8hHnXMIy1TI1faMK7SBqjQeANYWMLn1zor8lwQYe90=.938dd42a-076f-4552-9be1-06a965f240e8@github.com> Message-ID: <1UUqQN-7Z73RTII7FWXHU6iNA9QEIHEdh42lEewXD3s=.cde8dd2b-6c02-4490-981c-9dd4f2c1c622@github.com> On Mon, 16 Sep 2024 17:06:28 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote: > Almost clean backport from JDK21 > > The only difference is an additional EPERM check in the stat1 method. This method was removed in JDK21 as part of JDK-8283335 Hi @alexeybakhtin I hope this PR will also fix issue `java.nio.file.FileSystemException: app.jar: Function not implemented` Observed while running **`java -jar -Xdiag app.jar`** JAVA openjdk version "17.0.12" 2024-07-16 Here is complete stacktrace java.nio.file.FileSystemException: app.jar: Function not implemented at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:100) at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106) at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111) at java.base/sun.nio.fs.UnixFileAttributeViews$Basic.readAttributes(UnixFileAttributeViews.java:55) at java.base/sun.nio.fs.UnixFileSystemProvider.readAttributes(UnixFileSystemProvider.java:148) at java.base/sun.nio.fs.LinuxFileSystemProvider.readAttributes(LinuxFileSystemProvider.java:99) at java.base/java.nio.file.Files.readAttributes(Files.java:1851) at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1432) at java.base/java.util.zip.ZipFile$CleanableResource.<init>(ZipFile.java:717) at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:251) at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:180) at java.base/java.util.jar.JarFile.<init>(JarFile.java:346) at java.base/java.util.jar.JarFile.<init>(JarFile.java:317) at java.base/java.util.jar.JarFile.<init>(JarFile.java:256) at java.base/sun.launcher.LauncherHelper.getMainClassFromJar(LauncherHelper.java:561) at java.base/sun.launcher.LauncherHelper.loadMainClass(LauncherHelper.java:787) at java.base/sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:695) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2883#issuecomment-2472739578 From duke at openjdk.org Thu Nov 14 14:32:44 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 14 Nov 2024 14:32:44 GMT Subject: [jdk17u-dev] RFR: 8332935: Crash: assert(*lastPtr != 0) failed: Mismatched JNINativeInterface tables, check for new entries Message-ID: <e5LFZGDIUuc_57g0TQTWcMs8zrkJWx9zCQpNBKMuipY=.89f48dad-b4fa-4176-aefb-78f3bd480f6a@github.com> Backport of [JDK-8332935](https://bugs.openjdk.org/browse/JDK-8332935). This is a P2 issue that makes the JVM to crash in some situations, JDK-8332935 was difficult to track down (it happened by chance) so I think it's worth a backport. Backport is mostly clean but for a copyright change and low risk. Tier1 tests passed in Linux. ------------- Commit messages: - Backport 90699828478fe0a1307ad68cc0cb368fe4db890e Changes: https://git.openjdk.org/jdk17u-dev/pull/3041/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3041&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332935 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3041.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3041/head:pull/3041 PR: https://git.openjdk.org/jdk17u-dev/pull/3041 From duke at openjdk.org Thu Nov 14 14:35:38 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Thu, 14 Nov 2024 14:35:38 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result In-Reply-To: <InD3HFV5TP_IlOTV-AYdHRfZK58EG6-8Id15_hQiH0Q=.cb98face-ef13-4607-b8cf-7f56b81dc06d@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> <InD3HFV5TP_IlOTV-AYdHRfZK58EG6-8Id15_hQiH0Q=.cb98face-ef13-4607-b8cf-7f56b81dc06d@github.com> Message-ID: <DiLvLnbsgn9K99CFx7GH9ZP4QD29hy66WI1QqltGA1Q=.c65d0234-9679-4ec0-9ebe-4e698424b708@github.com> On Thu, 14 Nov 2024 09:16:34 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote: > What testing have you done for this in addition to GHA? jtreg tier1, and I can see that PackTestZip64 is failing with `java.io.IOException: Files are differ starting at position: 43630` Well, I need to review the behavior in the previous versions. Other jtreg tier 1 tests are green. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2476505781 From sgehwolf at openjdk.org Thu Nov 14 14:44:22 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 14 Nov 2024 14:44:22 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result In-Reply-To: <DiLvLnbsgn9K99CFx7GH9ZP4QD29hy66WI1QqltGA1Q=.c65d0234-9679-4ec0-9ebe-4e698424b708@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> <InD3HFV5TP_IlOTV-AYdHRfZK58EG6-8Id15_hQiH0Q=.cb98face-ef13-4607-b8cf-7f56b81dc06d@github.com> <DiLvLnbsgn9K99CFx7GH9ZP4QD29hy66WI1QqltGA1Q=.c65d0234-9679-4ec0-9ebe-4e698424b708@github.com> Message-ID: <a9-9Ep7EFqLrOXWKQi_q9NwpyPlNDFJUGvHtyNLna6w=.cc78aab5-2a87-4655-bed3-e9c792bb6953@github.com> On Thu, 14 Nov 2024 14:32:20 GMT, Radek ??p <duke at openjdk.org> wrote: > > What testing have you done for this in addition to GHA? > > jtreg tier1, and I can see that PackTestZip64 is failing with > > `java.io.IOException: Files are differ starting at position: 43630` > > Well, I need to review the behavior in the previous versions. > > Other jtreg tier 1 tests are green. How about `TestAntiDependencyForPinnedLoads.java` before the patch and after? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2476529556 From mbaesken at openjdk.org Thu Nov 14 14:50:58 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 14 Nov 2024 14:50:58 GMT Subject: [jdk21u-dev] RFR: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux Message-ID: <bCXPXH_uAecH64Mk1AEQwfmPVU-dKuVrAz0uBS2NjOU=.dd38cd29-d556-41b5-a002-f8547462a542@github.com> 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux ------------- Commit messages: - Backport 06d8216a4ef6b883119459da7e52b37d16cd2f03 Changes: https://git.openjdk.org/jdk21u-dev/pull/1155/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1155&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318442 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1155.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1155/head:pull/1155 PR: https://git.openjdk.org/jdk21u-dev/pull/1155 From duke at openjdk.org Thu Nov 14 15:55:58 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Thu, 14 Nov 2024 15:55:58 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result In-Reply-To: <a9-9Ep7EFqLrOXWKQi_q9NwpyPlNDFJUGvHtyNLna6w=.cc78aab5-2a87-4655-bed3-e9c792bb6953@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> <InD3HFV5TP_IlOTV-AYdHRfZK58EG6-8Id15_hQiH0Q=.cb98face-ef13-4607-b8cf-7f56b81dc06d@github.com> <DiLvLnbsgn9K99CFx7GH9ZP4QD29hy66WI1QqltGA1Q=.c65d0234-9679-4ec0-9ebe-4e698424b708@github.com> <a9-9Ep7EFqLrOXWKQi_q9NwpyPlNDFJUGvHtyNLna6w=.cc78aab5-2a87-4655-bed3-e9c792bb6953@github.com> Message-ID: <8tuBYKeWpC4YXMAqellbE7_9xb_N2MwnSjkZLYZ2YsI=.c9ee265f-cf67-4ccf-a051-7929a0584428@github.com> On Thu, 14 Nov 2024 14:41:44 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote: > How about `TestAntiDependencyForPinnedLoads.java` before the patch and after? It needs more thorough work. @RadekCap feels embarrassed, I'm sorry. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2476771023 From sgehwolf at openjdk.org Thu Nov 14 16:23:29 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 14 Nov 2024 16:23:29 GMT Subject: [jdk17u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases In-Reply-To: <1UUqQN-7Z73RTII7FWXHU6iNA9QEIHEdh42lEewXD3s=.cde8dd2b-6c02-4490-981c-9dd4f2c1c622@github.com> References: <h8hHnXMIy1TI1faMK7SBqjQeANYWMLn1zor8lwQYe90=.938dd42a-076f-4552-9be1-06a965f240e8@github.com> <1UUqQN-7Z73RTII7FWXHU6iNA9QEIHEdh42lEewXD3s=.cde8dd2b-6c02-4490-981c-9dd4f2c1c622@github.com> Message-ID: <OFfLc5lReGZGy7aP7gE1fSHeincCe1kfBkYKEryh-0Y=.2271bd43-361f-489d-a42d-58e21a44bd88@github.com> On Wed, 13 Nov 2024 08:00:25 GMT, akhilesh-delphix <duke at openjdk.org> wrote: > java.nio.file.FileSystemException: app.jar: Function not implemented This looks like a different issue. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2883#issuecomment-2476850306 From abakhtin at openjdk.org Thu Nov 14 18:55:50 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Thu, 14 Nov 2024 18:55:50 GMT Subject: [jdk17u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases In-Reply-To: <OFfLc5lReGZGy7aP7gE1fSHeincCe1kfBkYKEryh-0Y=.2271bd43-361f-489d-a42d-58e21a44bd88@github.com> References: <h8hHnXMIy1TI1faMK7SBqjQeANYWMLn1zor8lwQYe90=.938dd42a-076f-4552-9be1-06a965f240e8@github.com> <1UUqQN-7Z73RTII7FWXHU6iNA9QEIHEdh42lEewXD3s=.cde8dd2b-6c02-4490-981c-9dd4f2c1c622@github.com> <OFfLc5lReGZGy7aP7gE1fSHeincCe1kfBkYKEryh-0Y=.2271bd43-361f-489d-a42d-58e21a44bd88@github.com> Message-ID: <ko2XNBOU5qMYP2Z7xptFtAZTYqSjTBIsoVfFKrnRKXE=.907bca5a-201f-47f1-85e3-9494d58b789e@github.com> On Thu, 14 Nov 2024 16:20:18 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote: > java.nio.file.FileSystemException: app.jar: Function not implemented @akhilesh-delphix, It looks like a similar issue, but the state syscall returns `ENOSYS` error code instead of `EPERM`. So, this PR does not fix your issue. Could you please describe your environment? Maybe we will need a follow-up to handle `ENOSYS` as well. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2883#issuecomment-2477180490 From duke at openjdk.org Thu Nov 14 19:00:20 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 14 Nov 2024 19:00:20 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 Message-ID: <DWo2vVYmalCKfAWRsRxb8buce-twZBhZOgJlbByQtl4=.8bf70b24-c881-482b-ba0f-a2903eec3588@github.com> With [JDK-8340671](https://bugs.openjdk.org/browse/JDK-8340671) the GHA runner was bumped from `macos-11` to `macos-12` with minimum impact. But the `macos-12` runner image [will be fully retired by December 3rd, 2024](https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/), so it's now convenient to bump to `macos-13`. Previous attempts to upgrade to GHA runners to `macos-13` required a long list of backports that proved difficult to review and risky to backport. These were related to the deprecation of `sprintf` (that is replaced with `snprintf` in more modern OpenJDK versions), and to passing arguments to functions without a prototype in AWT native libraries. Instead of risking to do these backports an alternate solution may be to add specific compilation flags that transform these errors to warnings. This is done by adding `-Wno-deprecated-declarations` (to bypass `sprintf` deprecation) and `-Wno-deprecated-non-prototype` to bypass passing arguments to a function without a prototype to specific parts of the makefiles for the `macosx` platform only. For easier review the PR is separated in three commits in two pushes. - First push (to ensure a proper build on `macos-12` with new compilation flags) - The first commit adds `-Wno-deprecated-declaration` to some makefiles (`macosx` only). - And the second one adds `-Wno-deprecated-non-prototype` to the affected AWT libraries (again `macosx` only). - A second push (to ensure a proper build on `macos-13`) - A third commit that bumps GHA runners to `macos-13` and `xcode 14.3.1` Tier-1 tests seem to be failing randomly on `macos-13` with either a timeout or an ArrayIndexOutOfBoundsException t in `serviceability/sa/ClhsdbFindPC.java`. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). Solving this `tier-1` test problem may require a second PR. ------------- Commit messages: - Use -Wno-deprecated-non-prototype to bypass passing arguments to a function without a prototype is deprecated in awtlib - Use -Wno-deprecated-declarations to bypass sprintf deprecation Changes: https://git.openjdk.org/jdk11u-dev/pull/2965/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2965&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343786 Stats: 16 lines in 6 files changed: 14 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2965.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2965/head:pull/2965 PR: https://git.openjdk.org/jdk11u-dev/pull/2965 From duke at openjdk.org Thu Nov 14 19:13:22 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 14 Nov 2024 19:13:22 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 In-Reply-To: <DWo2vVYmalCKfAWRsRxb8buce-twZBhZOgJlbByQtl4=.8bf70b24-c881-482b-ba0f-a2903eec3588@github.com> References: <DWo2vVYmalCKfAWRsRxb8buce-twZBhZOgJlbByQtl4=.8bf70b24-c881-482b-ba0f-a2903eec3588@github.com> Message-ID: <pyGWkf5CnJW3u16moKFOoULptqkNB8-ShkPHsH3ur3w=.5126364f-f666-466e-803a-3596918f5694@github.com> On Thu, 14 Nov 2024 18:55:09 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > With [JDK-8340671](https://bugs.openjdk.org/browse/JDK-8340671) the GHA runner was bumped from `macos-11` to `macos-12` with minimum impact. > > But the `macos-12` runner image [will be fully retired by December 3rd, 2024](https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/), so it's now convenient to bump to `macos-13`. > > Previous attempts to upgrade to GHA runners to `macos-13` required a long list of backports that proved difficult to review and risky to backport. These were related to the deprecation of `sprintf` (that is replaced with `snprintf` in more modern OpenJDK versions), and to passing arguments to functions without a prototype in AWT native libraries. > > Instead of risking to do these backports an alternate solution may be to add specific compilation flags that transform these errors to warnings. This is done by adding `-Wno-deprecated-declarations` (to bypass `sprintf` deprecation) and `-Wno-deprecated-non-prototype` to bypass passing arguments to a function without a prototype to specific parts of the makefiles for the `macosx` platform only. > > For easier review the PR is separated in three commits in two pushes. > > - First push (to verify a proper build on `macos-12` with new compilation flags) > - The first commit adds `-Wno-deprecated-declaration` to some makefiles (`macosx` only). > - And the second one adds `-Wno-deprecated-non-prototype` to the affected AWT libraries (again `macosx` only). > - A second push (to ensure a proper build on `macos-13`) > - A third commit that bumps GHA runners to `macos-13` and `xcode 14.3.1` > > Tier-1 tests seem to be failing randomly on `macos-13` with either a timeout or an ArrayIndexOutOfBoundsException t in `serviceability/sa/ClhsdbFindPC.java`. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). > > Solving this `tier-1` test problem may require a second PR. Mmm... We'll need a compilation flag to build in both `macos-12` _and_ `macos-13`, as these new compilation flags are just on `XCode 14.3.1` and not on previous versions. After all we wouldn't like old `macos` pipelines failing. I'll close the PR and add these flags. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2965#issuecomment-2477211578 From duke at openjdk.org Thu Nov 14 19:13:22 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 14 Nov 2024 19:13:22 GMT Subject: [jdk11u-dev] Withdrawn: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 In-Reply-To: <DWo2vVYmalCKfAWRsRxb8buce-twZBhZOgJlbByQtl4=.8bf70b24-c881-482b-ba0f-a2903eec3588@github.com> References: <DWo2vVYmalCKfAWRsRxb8buce-twZBhZOgJlbByQtl4=.8bf70b24-c881-482b-ba0f-a2903eec3588@github.com> Message-ID: <Nz2rR2pwk2yhn1-LeJ-dYz-7tCxxC4e5Qg9oR3K-MlM=.a9f79c52-87be-4e0c-b66d-353f94e07726@github.com> On Thu, 14 Nov 2024 18:55:09 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > With [JDK-8340671](https://bugs.openjdk.org/browse/JDK-8340671) the GHA runner was bumped from `macos-11` to `macos-12` with minimum impact. > > But the `macos-12` runner image [will be fully retired by December 3rd, 2024](https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/), so it's now convenient to bump to `macos-13`. > > Previous attempts to upgrade to GHA runners to `macos-13` required a long list of backports that proved difficult to review and risky to backport. These were related to the deprecation of `sprintf` (that is replaced with `snprintf` in more modern OpenJDK versions), and to passing arguments to functions without a prototype in AWT native libraries. > > Instead of risking to do these backports an alternate solution may be to add specific compilation flags that transform these errors to warnings. This is done by adding `-Wno-deprecated-declarations` (to bypass `sprintf` deprecation) and `-Wno-deprecated-non-prototype` to bypass passing arguments to a function without a prototype to specific parts of the makefiles for the `macosx` platform only. > > For easier review the PR is separated in three commits in two pushes. > > - First push (to verify a proper build on `macos-12` with new compilation flags) > - The first commit adds `-Wno-deprecated-declaration` to some makefiles (`macosx` only). > - And the second one adds `-Wno-deprecated-non-prototype` to the affected AWT libraries (again `macosx` only). > - A second push (to ensure a proper build on `macos-13`) > - A third commit that bumps GHA runners to `macos-13` and `xcode 14.3.1` > > Tier-1 tests seem to be failing randomly on `macos-13` with either a timeout or an ArrayIndexOutOfBoundsException t in `serviceability/sa/ClhsdbFindPC.java`. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). > > Solving this `tier-1` test problem may require a second PR. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2965 From goetz at openjdk.org Fri Nov 15 07:35:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Nov 2024 07:35:58 GMT Subject: [jdk21u-dev] Integrated: 8342181: Update tests to use stronger Key and Salt size In-Reply-To: <vU72O0T41l7FNyMNdCdzyxNZVIWS0h8MJG8aXUiOS3I=.71cb9724-dc49-4e73-8352-a15362cbb7f5@github.com> References: <vU72O0T41l7FNyMNdCdzyxNZVIWS0h8MJG8aXUiOS3I=.71cb9724-dc49-4e73-8352-a15362cbb7f5@github.com> Message-ID: <8QzM_a90fjntCF3djFsTyuRUTZUBc1S8xsbTXMOLsQc=.0be0e5be-da6b-47bc-bdd3-744c588c9001@github.com> On Mon, 11 Nov 2024 10:48:15 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > Resolved TestOAEPPadding because of context difference. Probably considered clean. This pull request has now been integrated. Changeset: d81d3015 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/d81d3015610b2468a954185d15d898ca64f51583 Stats: 240 lines in 40 files changed: 138 ins; 0 del; 102 mod 8342181: Update tests to use stronger Key and Salt size Backport-of: f340ab2d360b5dfd375095ac053e9f4fc22a98de ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1144 From goetz at openjdk.org Fri Nov 15 07:38:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Nov 2024 07:38:54 GMT Subject: [jdk17u-dev] Integrated: 8343474: [updates] Customize README.md to specifics of update project In-Reply-To: <vLPSdUoaOMLnfTiBxORZW6DLlFjKTN3HZW_O3Hz5m8g=.c49b589b-c779-4869-80c8-481d75f07df9@github.com> References: <vLPSdUoaOMLnfTiBxORZW6DLlFjKTN3HZW_O3Hz5m8g=.c49b589b-c779-4869-80c8-481d75f07df9@github.com> Message-ID: <yQaxZXhlYxdcjvcNq8zC0oPviT2JIm3hPRyDwFv71sk=.e0ace5b5-7ee7-4219-a434-2b1265b73e66@github.com> On Wed, 13 Nov 2024 09:18:01 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I want to keep the README in sync with 21. > > Adapted all mention of 21 to 17. This pull request has now been integrated. Changeset: ac1f8688 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/ac1f86887384f0e3cf9becdeb9ee1e54fd4e60cb Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod 8343474: [updates] Customize README.md to specifics of update project Reviewed-by: sgehwolf, lucy Backport-of: 22d5e0d1f8849410abe40165b58f45f5e4293884 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3040 From goetz at openjdk.org Fri Nov 15 07:41:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Nov 2024 07:41:36 GMT Subject: [jdk21u-dev] RFR: 8342188: Update tests to use stronger key parameters and certificates [v3] In-Reply-To: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> References: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> Message-ID: <awXEvtz47kgfh87pqkq9thm8NvHvwftQWVr13EVTggE=.df6dd7c5-d159-4983-b51f-0daabb2c6ac4@github.com> > I backport this for parity with 21.0.6-oracle. > > Locally a clean patch, but /backport did not work. > lib files included in tests. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into goetz_backport_8342188 - Backport ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/1145/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1145&range=02 Stats: 2719 lines in 15 files changed: 1071 ins; 395 del; 1253 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1145.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1145/head:pull/1145 PR: https://git.openjdk.org/jdk21u-dev/pull/1145 From goetz at openjdk.org Fri Nov 15 08:02:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Nov 2024 08:02:06 GMT Subject: [jdk21u-dev] RFR: 8342188: Update tests to use stronger key parameters and certificates [v4] In-Reply-To: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> References: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> Message-ID: <gNO52SDkDqqvQKz4AHPDI3sdpf2ap_aJnU7NTJVKOyY=.4725d057-7a0b-407d-ab90-339c7702babc@github.com> > I backport this for parity with 21.0.6-oracle. > > Locally a clean patch, but /backport did not work. > lib files included in tests. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/1145/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1145&range=03 Stats: 2619 lines in 14 files changed: 981 ins; 395 del; 1243 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1145.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1145/head:pull/1145 PR: https://git.openjdk.org/jdk21u-dev/pull/1145 From goetz at openjdk.org Fri Nov 15 08:10:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Nov 2024 08:10:57 GMT Subject: [jdk21u-dev] RFR: 8342188: Update tests to use stronger key parameters and certificates [v5] In-Reply-To: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> References: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> Message-ID: <tV2yz9pg8F0AxM_ma_xOdoxo8wXmKtpX95Bn47vmZKo=.4ac845fd-4f54-4b7b-ac34-fff986e7af92@github.com> > I backport this for parity with 21.0.6-oracle. > > Locally a clean patch, but /backport did not work. > lib files included in tests. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/1145/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1145&range=04 Stats: 2728 lines in 15 files changed: 1090 ins; 395 del; 1243 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1145.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1145/head:pull/1145 PR: https://git.openjdk.org/jdk21u-dev/pull/1145 From goetz at openjdk.org Fri Nov 15 08:49:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Nov 2024 08:49:23 GMT Subject: [jdk21u-dev] RFR: 8342188: Update tests to use stronger key parameters and certificates [v5] In-Reply-To: <tV2yz9pg8F0AxM_ma_xOdoxo8wXmKtpX95Bn47vmZKo=.4ac845fd-4f54-4b7b-ac34-fff986e7af92@github.com> References: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> <tV2yz9pg8F0AxM_ma_xOdoxo8wXmKtpX95Bn47vmZKo=.4ac845fd-4f54-4b7b-ac34-fff986e7af92@github.com> Message-ID: <E8BtyYTttTGK0TWPdLJCxHZiZODTnYDzjwdnwzqqZ-4=.36914582-c87b-40ec-8417-fa4dd416c4f9@github.com> On Fri, 15 Nov 2024 08:10:57 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> I backport this for parity with 21.0.6-oracle. >> >> Locally a clean patch, but /backport did not work. >> lib files included in tests. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe Sorry for the force-push, but I had spoiled the merge. Anyways, it's clean, so a single commit is the obvious thing. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1145#issuecomment-2478250789 From goetz at openjdk.org Fri Nov 15 09:07:03 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Nov 2024 09:07:03 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 In-Reply-To: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> Message-ID: <knlHwOfrKu9maKnw5v_aycMl8Y6A36TxXHiZBvBkudA=.9cedfb61-ff35-4473-85af-9737f7e62393@github.com> On Mon, 28 Oct 2024 16:52:51 GMT, sophia-guo <duke at openjdk.org> wrote: > Hi, I would like to backport[ 8333248](https://bugs.openjdk.org/browse/JDK-8333248) to jdk21u. As [JDK-8325520](https://bugs.openjdk.org/browse/JDK-8325520) was also backported to 21 so the test now fails on risc-v there. Hi @sophia-guo Please enable GHA actions for this repo. Merging head will trigger retests. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1100#issuecomment-2478287173 From sgehwolf at openjdk.org Fri Nov 15 09:15:25 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 15 Nov 2024 09:15:25 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 In-Reply-To: <knlHwOfrKu9maKnw5v_aycMl8Y6A36TxXHiZBvBkudA=.9cedfb61-ff35-4473-85af-9737f7e62393@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> <knlHwOfrKu9maKnw5v_aycMl8Y6A36TxXHiZBvBkudA=.9cedfb61-ff35-4473-85af-9737f7e62393@github.com> Message-ID: <5HboMuayf7ga75M4ElKEIJ29yQBMPfmUQ98mlpuUcaw=.eb83d5cc-c9da-4788-bfdb-375d1f3293b5@github.com> On Fri, 15 Nov 2024 09:04:40 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > Please enable GHA actions for this repo. > Merging head will trigger retests. Yes. Or alternatively you can trigger it manually with the GH UI. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1100#issuecomment-2478302809 From goetz at openjdk.org Fri Nov 15 09:25:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Nov 2024 09:25:09 GMT Subject: [jdk21u-dev] RFR: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux In-Reply-To: <bCXPXH_uAecH64Mk1AEQwfmPVU-dKuVrAz0uBS2NjOU=.dd38cd29-d556-41b5-a002-f8547462a542@github.com> References: <bCXPXH_uAecH64Mk1AEQwfmPVU-dKuVrAz0uBS2NjOU=.dd38cd29-d556-41b5-a002-f8547462a542@github.com> Message-ID: <Je4B9mpafsX2JcpbWuDly_yVoYjWshUADyoqNKpVlyg=.113da85a-4638-4485-a49f-3d70866c53dc@github.com> On Thu, 14 Nov 2024 14:44:43 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux GHA failure: infra issue, unrelated error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' and similar. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1155#issuecomment-2478320355 From syan at openjdk.org Fri Nov 15 09:32:17 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 15 Nov 2024 09:32:17 GMT Subject: [jdk21u-dev] RFR: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags In-Reply-To: <V2U1Oxd9VoavOLmLw28Ya_faaSHh3FAq-AWPJY25SGM=.23d37d48-8623-4144-abd4-d0924f69efa5@github.com> References: <V2U1Oxd9VoavOLmLw28Ya_faaSHh3FAq-AWPJY25SGM=.23d37d48-8623-4144-abd4-d0924f69efa5@github.com> Message-ID: <OW8jHYSVuIhIsqcu73-XrJme4QpMCAK006aWF2X3sJw=.5875a92d-c899-4c62-a618-750a3ea1f621@github.com> On Wed, 6 Nov 2024 01:46:30 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [5e021cbc](https://github.com/openjdk/jdk/commit/5e021cbcc7a6cb30a27380950e115ff12846239c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Leonid Mesnik on 7 Aug 2024 and was reviewed by Magnus Ihse Bursie. > > I backport this PR parity with 21.0.7-oracle. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1128#issuecomment-2478344858 From syan at openjdk.org Fri Nov 15 09:34:31 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 15 Nov 2024 09:34:31 GMT Subject: [jdk21u-dev] Integrated: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags In-Reply-To: <V2U1Oxd9VoavOLmLw28Ya_faaSHh3FAq-AWPJY25SGM=.23d37d48-8623-4144-abd4-d0924f69efa5@github.com> References: <V2U1Oxd9VoavOLmLw28Ya_faaSHh3FAq-AWPJY25SGM=.23d37d48-8623-4144-abd4-d0924f69efa5@github.com> Message-ID: <z7noVFsehUhFo4c_Tom1b3wdm6WhSvR39bGlrcGuEKw=.2182f745-a854-482b-9fd4-8e32db9c16e2@github.com> On Wed, 6 Nov 2024 01:46:30 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [5e021cbc](https://github.com/openjdk/jdk/commit/5e021cbcc7a6cb30a27380950e115ff12846239c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Leonid Mesnik on 7 Aug 2024 and was reviewed by Magnus Ihse Bursie. > > I backport this PR parity with 21.0.7-oracle. > > Thanks! This pull request has now been integrated. Changeset: c5d75ef6 Author: SendaoYan <syan at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/c5d75ef66e294783c08e9f9950cbfdaa5d10c4ce Stats: 33 lines in 1 file changed: 30 ins; 2 del; 1 mod 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags Backport-of: 5e021cbcc7a6cb30a27380950e115ff12846239c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1128 From syan at openjdk.org Fri Nov 15 09:36:28 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 15 Nov 2024 09:36:28 GMT Subject: [jdk21u-dev] RFR: 8339892: Several security shell tests don't set TESTJAVAOPTS In-Reply-To: <vkDj7PWOtPU5fUNzdwIc6sfb7Kw1SPl3UYz1jE-qQZY=.9ca0f697-090d-43a5-a0f2-ceda180e4e89@github.com> References: <vkDj7PWOtPU5fUNzdwIc6sfb7Kw1SPl3UYz1jE-qQZY=.9ca0f697-090d-43a5-a0f2-ceda180e4e89@github.com> Message-ID: <I1lQTl3dgLPUDzBtr0ZGXEFD3Ocs0Jwowd7nx1jJjh4=.e458f94c-f59a-44ff-b72f-de5d2e7024e1@github.com> On Wed, 13 Nov 2024 08:47:23 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8a2a75e5](https://github.com/openjdk/jdk/commit/8a2a75e56de4497da48f43b3be3eb71bf3ef75ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sonia Zaldana Calles on 12 Nov 2024 and was reviewed by Valerie Peng. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1147#issuecomment-2478350910 From syan at openjdk.org Fri Nov 15 09:36:28 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 15 Nov 2024 09:36:28 GMT Subject: [jdk21u-dev] Integrated: 8339892: Several security shell tests don't set TESTJAVAOPTS In-Reply-To: <vkDj7PWOtPU5fUNzdwIc6sfb7Kw1SPl3UYz1jE-qQZY=.9ca0f697-090d-43a5-a0f2-ceda180e4e89@github.com> References: <vkDj7PWOtPU5fUNzdwIc6sfb7Kw1SPl3UYz1jE-qQZY=.9ca0f697-090d-43a5-a0f2-ceda180e4e89@github.com> Message-ID: <KeyAqBGJziqQXO0Jg5NIujVkukHVxTf-BE5rmDGmkk4=.314ad463-4955-41fc-9cf7-07658bfada7b@github.com> On Wed, 13 Nov 2024 08:47:23 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8a2a75e5](https://github.com/openjdk/jdk/commit/8a2a75e56de4497da48f43b3be3eb71bf3ef75ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sonia Zaldana Calles on 12 Nov 2024 and was reviewed by Valerie Peng. > > Thanks! This pull request has now been integrated. Changeset: 1af737e5 Author: SendaoYan <syan at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/1af737e55216ca173e417ca56b82fb7487436789 Stats: 22 lines in 10 files changed: 0 ins; 0 del; 22 mod 8339892: Several security shell tests don't set TESTJAVAOPTS Backport-of: 8a2a75e56de4497da48f43b3be3eb71bf3ef75ab ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1147 From syan at openjdk.org Fri Nov 15 09:36:29 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 15 Nov 2024 09:36:29 GMT Subject: [jdk21u-dev] RFR: 8207908: JMXStatusTest.java fails assertion intermittently In-Reply-To: <31BSa6_85M--T6yx2_VQfDLBg4g16mgzWWMC-zr7iWs=.47ae8a9f-2160-496b-965d-7738e96cc2b5@github.com> References: <31BSa6_85M--T6yx2_VQfDLBg4g16mgzWWMC-zr7iWs=.47ae8a9f-2160-496b-965d-7738e96cc2b5@github.com> Message-ID: <4QbklHBbdLaBpL2OVCsQREpenpn8zJi4eSdeVlkNWEg=.e6a416bd-ecbc-4e57-a5e2-930ce591bb05@github.com> On Tue, 5 Nov 2024 07:27:08 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [b7d0eff5](https://github.com/openjdk/jdk/commit/b7d0eff5ad77e338b237773d2fc047eea3d2ac12) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer and Alex Menkov. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1126#issuecomment-2478351417 From syan at openjdk.org Fri Nov 15 09:36:29 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 15 Nov 2024 09:36:29 GMT Subject: [jdk21u-dev] Integrated: 8207908: JMXStatusTest.java fails assertion intermittently In-Reply-To: <31BSa6_85M--T6yx2_VQfDLBg4g16mgzWWMC-zr7iWs=.47ae8a9f-2160-496b-965d-7738e96cc2b5@github.com> References: <31BSa6_85M--T6yx2_VQfDLBg4g16mgzWWMC-zr7iWs=.47ae8a9f-2160-496b-965d-7738e96cc2b5@github.com> Message-ID: <D2LvYIlnMAVF0quzmCQeeOAZQQiVL90H1cS-HEMxK74=.32bab25d-91f3-46e1-aeb7-ba165a45a549@github.com> On Tue, 5 Nov 2024 07:27:08 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [b7d0eff5](https://github.com/openjdk/jdk/commit/b7d0eff5ad77e338b237773d2fc047eea3d2ac12) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer and Alex Menkov. > > Thanks! This pull request has now been integrated. Changeset: d0abff2f Author: SendaoYan <syan at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/d0abff2f0745aa135cc9dbf6def4f260b634f107 Stats: 9 lines in 2 files changed: 1 ins; 2 del; 6 mod 8207908: JMXStatusTest.java fails assertion intermittently Backport-of: b7d0eff5ad77e338b237773d2fc047eea3d2ac12 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1126 From syan at openjdk.org Fri Nov 15 09:51:42 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 15 Nov 2024 09:51:42 GMT Subject: [jdk17u-dev] RFR: 8207908: JMXStatusTest.java fails assertion intermittently Message-ID: <OcxCgF_eLcquDcAaG4hqRfkwpVvUNPbd-Lz2va5bndg=.a6da9517-15d7-4e8e-809c-8b751be6b33a@github.com> Hi all, This pull request contains a backport of commit [b7d0eff5](https://github.com/openjdk/jdk/commit/b7d0eff5ad77e338b237773d2fc047eea3d2ac12) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer and Alex Menkov. Thanks! ------------- Commit messages: - Backport d0abff2f0745aa135cc9dbf6def4f260b634f107 Changes: https://git.openjdk.org/jdk17u-dev/pull/3042/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3042&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8207908 Stats: 9 lines in 2 files changed: 1 ins; 2 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3042.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3042/head:pull/3042 PR: https://git.openjdk.org/jdk17u-dev/pull/3042 From mdoerr at openjdk.org Fri Nov 15 10:06:31 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 15 Nov 2024 10:06:31 GMT Subject: [jdk21u-dev] RFR: 8343343: Misc crash dump improvements on more platforms after JDK-8294160 [v2] In-Reply-To: <hXGvQNmO3aDCd7QslGZqddzuwJuE3D1lRyqjagCkzjc=.e52283c1-5284-4df1-8662-b508f1649c09@github.com> References: <hXGvQNmO3aDCd7QslGZqddzuwJuE3D1lRyqjagCkzjc=.e52283c1-5284-4df1-8662-b508f1649c09@github.com> Message-ID: <GQAnbThQLY7sLV2vsJyTWloDx9ZUrx8FP5Ul1a_UeyQ=.0b3da0a8-ca7d-454c-aa5e-23f07828a9f9@github.com> > Mostly clean backport of [JDK-8343343](https://bugs.openjdk.org/browse/JDK-8343343). PPC64 files use a different frame constructor after [JDK-8290965](https://bugs.openjdk.org/browse/JDK-8290965) (JDK23). Includes [JDK-8343149](https://bugs.openjdk.org/browse/JDK-8343149). Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: Fix aix. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1154/files - new: https://git.openjdk.org/jdk21u-dev/pull/1154/files/adc27ba4..08cbaaf4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1154&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1154&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1154.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1154/head:pull/1154 PR: https://git.openjdk.org/jdk21u-dev/pull/1154 From mdoerr at openjdk.org Fri Nov 15 10:10:01 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 15 Nov 2024 10:10:01 GMT Subject: [jdk21u-dev] RFR: 8342607: Enhance register printing on x86_64 platforms In-Reply-To: <pS9fvMBAf9nylaUkntksVv-KEAMwIGU5nkUpuuU21FU=.758c177b-c1c5-4a1a-8acc-289ddcaf003a@github.com> References: <pS9fvMBAf9nylaUkntksVv-KEAMwIGU5nkUpuuU21FU=.758c177b-c1c5-4a1a-8acc-289ddcaf003a@github.com> Message-ID: <938WMHICf3OzH4T1eHReTjAOd5JyGn715TPiQBIZc0k=.1703c4c9-67ae-4735-806f-f7b3f56b9e2c@github.com> On Wed, 13 Nov 2024 20:58:12 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: > Clean backport of [JDK-8342607](https://bugs.openjdk.org/browse/JDK-8342607). GHA failures on macOS-aarch64 are unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1152#issuecomment-2478463627 From mdoerr at openjdk.org Fri Nov 15 10:13:43 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 15 Nov 2024 10:13:43 GMT Subject: [jdk21u-dev] RFR: 8343724: [PPC64] Disallow OptoScheduling In-Reply-To: <NcUSexWS2CcmAxE0yAeXJix9q_PHRe5AQBvYCN6CK0E=.f0f4b45c-a286-45f5-9e3b-6af7819cf1e5@github.com> References: <NcUSexWS2CcmAxE0yAeXJix9q_PHRe5AQBvYCN6CK0E=.f0f4b45c-a286-45f5-9e3b-6af7819cf1e5@github.com> Message-ID: <bY_HiUCqqUMVSbZPzVj3NFVdHfeTLBJeA9WiqMubAm8=.0c8b2527-020e-4c92-8893-b21991b6ba11@github.com> On Wed, 13 Nov 2024 20:59:11 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: > Clean backport of [JDK-8343724](https://bugs.openjdk.org/browse/JDK-8343724). GHA failures are unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1153#issuecomment-2478471781 From mbaesken at openjdk.org Fri Nov 15 11:18:26 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 15 Nov 2024 11:18:26 GMT Subject: [jdk21u-dev] Integrated: 8340801: Disable ubsan checks in some awt/2d coding In-Reply-To: <uLsfAj9wKB3U5nYjqqNWk4C4v7boO3uP5nohy9zNStY=.3f6a28a5-0ad8-4239-9eda-973f3c58ff7a@github.com> References: <uLsfAj9wKB3U5nYjqqNWk4C4v7boO3uP5nohy9zNStY=.3f6a28a5-0ad8-4239-9eda-973f3c58ff7a@github.com> Message-ID: <DZmRjxB4MA6MKTMsGeqJuoWvLpu0RGH3cdQ7u-ssMUQ=.78e2b8b9-f553-4f7f-a466-507c064f72ac@github.com> On Wed, 13 Nov 2024 12:35:13 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8340801: Disable ubsan checks in some awt/2d coding This pull request has now been integrated. Changeset: 6affc09a Author: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/6affc09ae20eca86a8f2c41245f783cf6316547b Stats: 45 lines in 2 files changed: 45 ins; 0 del; 0 mod 8340801: Disable ubsan checks in some awt/2d coding Backport-of: e7cf25ce0efdf568fc8eaff249d49e46d5a6eda1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1148 From mbaesken at openjdk.org Fri Nov 15 11:18:26 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 15 Nov 2024 11:18:26 GMT Subject: [jdk21u-dev] RFR: 8340801: Disable ubsan checks in some awt/2d coding In-Reply-To: <uLsfAj9wKB3U5nYjqqNWk4C4v7boO3uP5nohy9zNStY=.3f6a28a5-0ad8-4239-9eda-973f3c58ff7a@github.com> References: <uLsfAj9wKB3U5nYjqqNWk4C4v7boO3uP5nohy9zNStY=.3f6a28a5-0ad8-4239-9eda-973f3c58ff7a@github.com> Message-ID: <h3g1YbiW8SWgqha4q4USIQiul6xRzvFF2XF03ddyQFU=.f84264ac-46ce-4e66-bf9f-d54413288cb8@github.com> On Wed, 13 Nov 2024 12:35:13 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8340801: Disable ubsan checks in some awt/2d coding macos-aarch64 GHA toolchain install failure "xcode-select: error: invalid developer directory" ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1148#issuecomment-2478589195 From mbaesken at openjdk.org Fri Nov 15 11:21:16 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 15 Nov 2024 11:21:16 GMT Subject: [jdk21u-dev] Integrated: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux In-Reply-To: <bCXPXH_uAecH64Mk1AEQwfmPVU-dKuVrAz0uBS2NjOU=.dd38cd29-d556-41b5-a002-f8547462a542@github.com> References: <bCXPXH_uAecH64Mk1AEQwfmPVU-dKuVrAz0uBS2NjOU=.dd38cd29-d556-41b5-a002-f8547462a542@github.com> Message-ID: <HJyBkQ7YqpeweDtgyFFwmDLshQyo0MpwUD1sCWPsGmk=.092702ec-b2d1-4dd4-9626-0de8a3533c80@github.com> On Thu, 14 Nov 2024 14:44:43 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux This pull request has now been integrated. Changeset: bcc85d92 Author: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/bcc85d923fffe37546caa4a738d8fdbce745dd45 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux Backport-of: 06d8216a4ef6b883119459da7e52b37d16cd2f03 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1155 From mbaesken at openjdk.org Fri Nov 15 11:30:47 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 15 Nov 2024 11:30:47 GMT Subject: [jdk21u-dev] RFR: 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask' In-Reply-To: <UIpQJBRMmlWElkAE_ggABeWl2Kt4ifPwWiPHbJphPrU=.7876ac16-952c-429c-bd2e-a73914be2f99@github.com> References: <UIpQJBRMmlWElkAE_ggABeWl2Kt4ifPwWiPHbJphPrU=.7876ac16-952c-429c-bd2e-a73914be2f99@github.com> Message-ID: <_SfSmC4SEN677_nPOWfTbB02BKU4vyRSv3EOKNjgAbc=.e3117334-f3ca-4d9f-b263-70561b4b970c@github.com> On Wed, 13 Nov 2024 14:49:30 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask' macOS aarch GHA broken; linux zero failed downloading apache ant ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1151#issuecomment-2478612322 From mbaesken at openjdk.org Fri Nov 15 11:30:57 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 15 Nov 2024 11:30:57 GMT Subject: [jdk21u-dev] RFR: 8336911: ZGC: Division by zero in heuristics after JDK-8332717 In-Reply-To: <dOdlx73EdQkwTvyIiklGPHiQ1mXn2A_jPgc3sQg78Rs=.0f5b0d8a-5942-4e7b-af3a-0c765e117e98@github.com> References: <dOdlx73EdQkwTvyIiklGPHiQ1mXn2A_jPgc3sQg78Rs=.0f5b0d8a-5942-4e7b-af3a-0c765e117e98@github.com> Message-ID: <eGX-nFTu5nJdZONRny14ypyQ4wiYoliGRre5tCWk1aM=.566844ad-8a3e-4fb5-b9f3-5a1f3dec5fac@github.com> On Wed, 13 Nov 2024 12:56:21 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8336911: ZGC: Division by zero in heuristics after JDK-8332717 macOS aarch GHA infra broken 'xcode-select: error: invalid developer directory" ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1149#issuecomment-2478610156 From mbaesken at openjdk.org Fri Nov 15 11:32:51 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 15 Nov 2024 11:32:51 GMT Subject: [jdk21u-dev] RFR: 8343343: Misc crash dump improvements on more platforms after JDK-8294160 [v2] In-Reply-To: <GQAnbThQLY7sLV2vsJyTWloDx9ZUrx8FP5Ul1a_UeyQ=.0b3da0a8-ca7d-454c-aa5e-23f07828a9f9@github.com> References: <hXGvQNmO3aDCd7QslGZqddzuwJuE3D1lRyqjagCkzjc=.e52283c1-5284-4df1-8662-b508f1649c09@github.com> <GQAnbThQLY7sLV2vsJyTWloDx9ZUrx8FP5Ul1a_UeyQ=.0b3da0a8-ca7d-454c-aa5e-23f07828a9f9@github.com> Message-ID: <ubxprVCUBPBkD6uVyCbgH2DGOVOZ64DSkNL9aT4Vk6Y=.1a149ef0-2b6d-431f-a2b4-0a02e3c92a17@github.com> On Fri, 15 Nov 2024 10:06:31 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: >> Mostly clean backport of [JDK-8343343](https://bugs.openjdk.org/browse/JDK-8343343). PPC64 files use a different frame constructor after [JDK-8290965](https://bugs.openjdk.org/browse/JDK-8290965) (JDK23). Includes [JDK-8343149](https://bugs.openjdk.org/browse/JDK-8343149). > > Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: > > Fix aix. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1154#pullrequestreview-2438357894 From avieirov at redhat.com Fri Nov 15 11:47:38 2024 From: avieirov at redhat.com (Antonio Vieiro) Date: Fri, 15 Nov 2024 12:47:38 +0100 Subject: Keep jdk11 GHA runners on macosx? Message-ID: <bc65d34f-2631-4aec-831c-e6988cb57719@redhat.com> Hi all, As you may know keeping up to date with GHA macosx runners is complicated due to recent changes _and_ deprecations [1], both in XCode and Github runners. This means that jdk11u and jdk11u-dev runners (currently on macos-12) will stop failing on next december unless an upgrade to macos-13 is in place. It may be possible to build jdk11u/jdk11u-dev on macos-13 with XCode 14.3.1, but this will require adding some extra compilation flags to support the deprecated `sprintf` and some arguments being passed to functions without prototypes (backporting these proved difficult/risky in the past). These compilation flags are XCode 14 specific and will break builds on `macos-12` and earlier, unless an special configuration flag is added to the build system thats makes the build adapt to XCode 14. Is there any interest in having jdk11u GHA runners upgraded to run on macos-13? Any interest in keeping jdk11u building on newest XCode versions but failing in previous ones? Opinions? Thanks, Antonio [1] macos-12 deprecation on 2024-12-03 https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/ Xcode 14 and 16 will be removed from macOS 14 on November 4 https://github.com/actions/runner-images/issues/10703 From goetz at openjdk.org Fri Nov 15 12:36:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Nov 2024 12:36:44 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v3] In-Reply-To: <FRk1kNb6VseLuEwe2SjE555xQi9N3X6vMDf7k3m43CI=.1b1609b5-223b-4b9b-901d-3f2584a9e8dc@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <FRk1kNb6VseLuEwe2SjE555xQi9N3X6vMDf7k3m43CI=.1b1609b5-223b-4b9b-901d-3f2584a9e8dc@github.com> Message-ID: <dF92fIQ5FjXg8h0dLtRNTGRiee6NcozQcEFzO25ZVe0=.7d93233b-f40a-4c89-a20e-da1adc59cf24@github.com> On Fri, 8 Nov 2024 09:47:15 GMT, SendaoYan <syan at openjdk.org> wrote: >> Hi all, >> >> This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. >> >> The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. >> >> The new API `Path resolve(String first, String... more)` was not supported in jdk21u-dev, so I change the line code from `COPY_JDK_DIR.resolve("bin", "java")` to `COPY_JDK_DIR.resolve("bin").resolve("java")` to avoid jdk21 javac generate compile error, and make this backport uncleanly, all other parts are backported cleanly. >> >> The change has been verified locally, test-fix only, no risk. >> >> Thanks! > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > change the line code from COPY_JDK_DIR.resolve("bin", "java") to COPY_JDK_DIR.resolve("bin").resolve("java") to avoid jdk21 javac genrate compile error GHA failure of latest run: infra issue, unrelated error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2478716793 From sgehwolf at redhat.com Fri Nov 15 12:41:47 2024 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Fri, 15 Nov 2024 13:41:47 +0100 Subject: Keep jdk11 GHA runners on macosx? In-Reply-To: <bc65d34f-2631-4aec-831c-e6988cb57719@redhat.com> References: <bc65d34f-2631-4aec-831c-e6988cb57719@redhat.com> Message-ID: <117d9f7a193522d7cad835148acd53bf63a73310.camel@redhat.com> On Fri, 2024-11-15 at 12:47 +0100, Antonio Vieiro wrote: > Any interest in keeping jdk11u building on newest XCode versions but > failing in previous ones? Opinions? Yes. We'd want to keep GHA working for macosx on jdk11u. It's an important check to have for not inadvertently breaking the build. Just to clarify: You are proposing to require macos-13 or better with XCode 14.3.1 or newer, for JDK 11u builds on macosx going forward? If there is no way of building/running on older osx/xcode I guess there is no other choice but to set this as a requirement for building going forward? It would be good to know what the community thinks. Thanks, Severin > [1] > macos-12 deprecation on 2024-12-03 > https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/ > > Xcode 14 and 16 will be removed from macOS 14 on November 4 > https://github.com/actions/runner-images/issues/10703 > From lucy at openjdk.org Fri Nov 15 12:49:56 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 15 Nov 2024 12:49:56 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v3] In-Reply-To: <FRk1kNb6VseLuEwe2SjE555xQi9N3X6vMDf7k3m43CI=.1b1609b5-223b-4b9b-901d-3f2584a9e8dc@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <FRk1kNb6VseLuEwe2SjE555xQi9N3X6vMDf7k3m43CI=.1b1609b5-223b-4b9b-901d-3f2584a9e8dc@github.com> Message-ID: <ljpM3S3FM5NOoDRx72V4L5PQsK_zLJk8DkcCcy44F8o=.a7be8c9c-ec1c-46ff-9531-b72533217c3f@github.com> On Fri, 8 Nov 2024 09:47:15 GMT, SendaoYan <syan at openjdk.org> wrote: >> Hi all, >> >> This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. >> >> The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. >> >> The new API `Path resolve(String first, String... more)` was not supported in jdk21u-dev, so I change the line code from `COPY_JDK_DIR.resolve("bin", "java")` to `COPY_JDK_DIR.resolve("bin").resolve("java")` to avoid jdk21 javac generate compile error, and make this backport uncleanly, all other parts are backported cleanly. >> >> The change has been verified locally, test-fix only, no risk. >> >> Thanks! > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > change the line code from COPY_JDK_DIR.resolve("bin", "java") to COPY_JDK_DIR.resolve("bin").resolve("java") to avoid jdk21 javac genrate compile error LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/830#pullrequestreview-2438485296 From goetz at openjdk.org Fri Nov 15 12:51:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Nov 2024 12:51:09 GMT Subject: [jdk17u-dev] RFR: 8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak" Message-ID: <cTRkZ72M5nVF6PMA9494zviPQ8W8y5mUlq01Y1KwOqI=.f28e0da0-a67a-4077-b17c-e5fabc9190b0@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport aefd4ac4a336f00c067bcb91b95472ccc9a6bf83 Changes: https://git.openjdk.org/jdk17u-dev/pull/3043/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3043&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8258734 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3043.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3043/head:pull/3043 PR: https://git.openjdk.org/jdk17u-dev/pull/3043 From goetz at openjdk.org Fri Nov 15 12:55:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Nov 2024 12:55:20 GMT Subject: [jdk17u-dev] RFR: 8284291: sun/security/krb5/auto/Renew.java fails intermittently on Windows 11 Message-ID: <q0_xtZmN0nsBjVXoaJ_nCM4OQ4icQitwzAXAa1zWbwo=.364acaa4-1b0d-4715-ab40-8de36593754f@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 05ae7ed1aac6fabc9c8820c12b6567fe93a3546f Changes: https://git.openjdk.org/jdk17u-dev/pull/3044/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3044&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284291 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3044.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3044/head:pull/3044 PR: https://git.openjdk.org/jdk17u-dev/pull/3044 From syan at openjdk.org Fri Nov 15 12:57:57 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 15 Nov 2024 12:57:57 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v3] In-Reply-To: <ljpM3S3FM5NOoDRx72V4L5PQsK_zLJk8DkcCcy44F8o=.a7be8c9c-ec1c-46ff-9531-b72533217c3f@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <FRk1kNb6VseLuEwe2SjE555xQi9N3X6vMDf7k3m43CI=.1b1609b5-223b-4b9b-901d-3f2584a9e8dc@github.com> <ljpM3S3FM5NOoDRx72V4L5PQsK_zLJk8DkcCcy44F8o=.a7be8c9c-ec1c-46ff-9531-b72533217c3f@github.com> Message-ID: <SfIvExy-Gs2Ee2FrmezuCyBgC1O77X5q4GvqvWzenrA=.c1226573-898e-4317-9bf6-bbdd9ae22533@github.com> On Fri, 15 Nov 2024 12:47:21 GMT, Lutz Schmidt <lucy at openjdk.org> wrote: > LGTM. Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2478752409 From goetz at openjdk.org Fri Nov 15 12:58:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Nov 2024 12:58:56 GMT Subject: [jdk17u-dev] RFR: 8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test Message-ID: <pDV3PYIx_HAX_voLUFy2-_tz9omK6aaYG-mGUZqK8hc=.2ce27bc4-b15d-4bc6-bfc8-e693f1c9a693@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport b22a38dedb06199f2cba3b6f8962ddf2f9f4f16d Changes: https://git.openjdk.org/jdk17u-dev/pull/3045/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3045&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292309 Stats: 336 lines in 1 file changed: 52 ins; 224 del; 60 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3045.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3045/head:pull/3045 PR: https://git.openjdk.org/jdk17u-dev/pull/3045 From syan at openjdk.org Fri Nov 15 13:02:53 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 15 Nov 2024 13:02:53 GMT Subject: [jdk17u-dev] RFR: 8207908: JMXStatusTest.java fails assertion intermittently In-Reply-To: <OcxCgF_eLcquDcAaG4hqRfkwpVvUNPbd-Lz2va5bndg=.a6da9517-15d7-4e8e-809c-8b751be6b33a@github.com> References: <OcxCgF_eLcquDcAaG4hqRfkwpVvUNPbd-Lz2va5bndg=.a6da9517-15d7-4e8e-809c-8b751be6b33a@github.com> Message-ID: <5Y2XmIp2UY9B4yLULS3-jgcVN_oSYv88HOG20xvH5fY=.c292b402-4bd3-4141-8a20-28b5a77f8850@github.com> On Fri, 15 Nov 2024 09:46:19 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [b7d0eff5](https://github.com/openjdk/jdk/commit/b7d0eff5ad77e338b237773d2fc047eea3d2ac12) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer and Alex Menkov. > > Thanks! GHA report 3 failures: 1. linux-x64 build debug job at `Get JTReg` stage fails `wget exited with exit code 4` seems like infra issue or environmental issue, it's unrelated to this PR. 2. macos-aarch64 build debug job at `install toolchain depedencies` stage fails `xcode-select: error: invalid developer directory` seems like infra issue or environmental issue, it's unrelated to this PR. 3. macos-aarch64 build release job at `install toolchain depedencies` stage fails `xcode-select: error: invalid developer directory` seems like infra issue or environmental issue, it's unrelated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3042#issuecomment-2478760348 From mdoerr at openjdk.org Fri Nov 15 14:10:05 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 15 Nov 2024 14:10:05 GMT Subject: [jdk21u-dev] RFR: 8342188: Update tests to use stronger key parameters and certificates [v5] In-Reply-To: <tV2yz9pg8F0AxM_ma_xOdoxo8wXmKtpX95Bn47vmZKo=.4ac845fd-4f54-4b7b-ac34-fff986e7af92@github.com> References: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> <tV2yz9pg8F0AxM_ma_xOdoxo8wXmKtpX95Bn47vmZKo=.4ac845fd-4f54-4b7b-ac34-fff986e7af92@github.com> Message-ID: <vwHWlDhEwfkfnwPCjdsQodSyxbpyGqK3PH4CtVCvO2E=.613fe433-290d-4749-a193-397e3ba9c007@github.com> On Fri, 15 Nov 2024 08:10:57 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> I backport this for parity with 21.0.6-oracle. >> >> Locally a clean patch, but /backport did not work. >> lib files included in tests. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe It's still clean. I think we can live with force-push for clean backports :-) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1145#issuecomment-2478938239 From avieirov at redhat.com Fri Nov 15 14:16:49 2024 From: avieirov at redhat.com (Antonio Vieiro) Date: Fri, 15 Nov 2024 15:16:49 +0100 Subject: Keep jdk11 GHA runners on macosx? In-Reply-To: <117d9f7a193522d7cad835148acd53bf63a73310.camel@redhat.com> References: <bc65d34f-2631-4aec-831c-e6988cb57719@redhat.com> <117d9f7a193522d7cad835148acd53bf63a73310.camel@redhat.com> Message-ID: <122242ff-1e80-4362-bce6-87cdcd139097@redhat.com> Hi all, El 15/11/24 a las 13:41, Severin Gehwolf escribi?: > Just to clarify: > > You are proposing to require macos-13 or better with XCode 14.3.1 or > newer, for JDK 11u builds on macosx going forward? Not really. The proposal is to add a configuration flag ("--with-xcode14" or similar) so that: - Builds and tier-1 tests can be run in GHA: macos-13/XCode 14.3.1 - By adding "-Wno-deprecated-declaration" to some .mk files to bypass the "sprintf" deprecation that is generating errors. - By adding "-Wno-deprecated-non-prototype" to some .mk files to bypass sending arguments to functions without protype (AWTlib), that are generating errors too. If the "--with-xcode-14" configuration is _not_ present then builds are as usual, i.e., exising pipelines on macos-12 and earlier will run as usual. > > If there is no way of building/running on older osx/xcode I guess there > is no other choice but to set this as a requirement for building going > forward? The flag is of interest only for doing GHA builds on XCode 14, as imposed by the deprecation of macos-12 GHA runners. So if you don't set the flag you can build as usual, on macos-12 and earlier, with older XCode versions. > > It would be good to know what the community thinks. Yep. Cheers, Antonio From goetz at openjdk.org Fri Nov 15 14:37:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Nov 2024 14:37:48 GMT Subject: [jdk17u-dev] RFR: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker Message-ID: <HiN8Lk0Wq9uzYr0HehC0PJaKFaUGT1ubgUvBghOZA34=.99f12638-afe1-427f-a2fc-95041326f79c@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 220781fa56a9c8d3b64c5c6578ffd76b9edb795c Changes: https://git.openjdk.org/jdk17u-dev/pull/3046/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3046&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298513 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3046.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3046/head:pull/3046 PR: https://git.openjdk.org/jdk17u-dev/pull/3046 From mdoerr at openjdk.org Fri Nov 15 14:44:50 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 15 Nov 2024 14:44:50 GMT Subject: [jdk21u-dev] RFR: 8343343: Misc crash dump improvements on more platforms after JDK-8294160 [v2] In-Reply-To: <GQAnbThQLY7sLV2vsJyTWloDx9ZUrx8FP5Ul1a_UeyQ=.0b3da0a8-ca7d-454c-aa5e-23f07828a9f9@github.com> References: <hXGvQNmO3aDCd7QslGZqddzuwJuE3D1lRyqjagCkzjc=.e52283c1-5284-4df1-8662-b508f1649c09@github.com> <GQAnbThQLY7sLV2vsJyTWloDx9ZUrx8FP5Ul1a_UeyQ=.0b3da0a8-ca7d-454c-aa5e-23f07828a9f9@github.com> Message-ID: <R7vBYl-swjkPgkT8PHvTGTQ8itXMNb4oIS3GmkLCdrQ=.92b0be9e-fa79-4e38-9027-ab2f8e9f03de@github.com> On Fri, 15 Nov 2024 10:06:31 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: >> Mostly clean backport of [JDK-8343343](https://bugs.openjdk.org/browse/JDK-8343343). PPC64 files use a different frame constructor after [JDK-8290965](https://bugs.openjdk.org/browse/JDK-8290965) (JDK23). Includes [JDK-8343149](https://bugs.openjdk.org/browse/JDK-8343149). > > Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: > > Fix aix. GHA failures are unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1154#issuecomment-2479040656 From duke at openjdk.org Fri Nov 15 17:16:56 2024 From: duke at openjdk.org (sophia-guo) Date: Fri, 15 Nov 2024 17:16:56 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 In-Reply-To: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> Message-ID: <NURrOIkUuQUm2ZFsmb-8QvM4Ex0_P6_DH7eRWOFhsnw=.83d8cc8f-7966-480c-965b-cc90d73264b5@github.com> On Mon, 28 Oct 2024 16:52:51 GMT, sophia-guo <duke at openjdk.org> wrote: > Hi, I would like to backport[ 8333248](https://bugs.openjdk.org/browse/JDK-8333248) to jdk21u. As [JDK-8325520](https://bugs.openjdk.org/browse/JDK-8325520) was also backported to 21 so the test now fails on risc-v there. Just confirm that the GHA action should have been enabled. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1100#issuecomment-2479468349 From duke at openjdk.org Fri Nov 15 23:45:04 2024 From: duke at openjdk.org (duke) Date: Fri, 15 Nov 2024 23:45:04 GMT Subject: [jdk21u-dev] RFR: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate In-Reply-To: <_-Tp2qhNmlZNquRSjo8f1x226hwBY3Ra7AnEmtJ9Gcw=.6fa12ab2-b85d-456f-be8b-df1f3e1f6f6b@github.com> References: <_-Tp2qhNmlZNquRSjo8f1x226hwBY3Ra7AnEmtJ9Gcw=.6fa12ab2-b85d-456f-be8b-df1f3e1f6f6b@github.com> Message-ID: <_2xTofebXaO43qIEd_4Iu10mPOpbmMhPmDAkh0ksnEA=.ef1ebb45-00f4-49c0-bb6e-f536d5fd5a01@github.com> On Thu, 12 Sep 2024 22:29:41 GMT, William Kemper <wkemper at openjdk.org> wrote: > Clean backport. Change is confined to Shenandoah. @earthling-amzn Your change (at version 6456fa07fb02740ba300d9ad1f3c37b7872de904) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/973#issuecomment-2480140981 From syan at openjdk.org Sat Nov 16 02:25:25 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 16 Nov 2024 02:25:25 GMT Subject: [jdk21u-dev] RFR: 8336257: Additional tests in jmxremote/startstop to match on PID not app name Message-ID: <EH9r5GQlVufB8QM2cSXTnsKpMiuASqKB6N30H43RTy4=.f94b319d-ed7b-4574-8d74-48ee5b54796f@github.com> Hi all, This pull request contains a backport of commit [687601eb](https://github.com/openjdk/jdk/commit/687601ebcaedf133fd4d5cecc42c5aadf9c73f3c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer, Alan Bateman, Alex Menkov and Daniel D. Daugherty. Thanks! ------------- Commit messages: - Backport 687601ebcaedf133fd4d5cecc42c5aadf9c73f3c Changes: https://git.openjdk.org/jdk21u-dev/pull/1156/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1156&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336257 Stats: 6 lines in 2 files changed: 2 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1156.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1156/head:pull/1156 PR: https://git.openjdk.org/jdk21u-dev/pull/1156 From goetz at openjdk.org Sat Nov 16 10:34:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 16 Nov 2024 10:34:55 GMT Subject: [jdk21u-dev] RFR: 8342188: Update tests to use stronger key parameters and certificates [v5] In-Reply-To: <tV2yz9pg8F0AxM_ma_xOdoxo8wXmKtpX95Bn47vmZKo=.4ac845fd-4f54-4b7b-ac34-fff986e7af92@github.com> References: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> <tV2yz9pg8F0AxM_ma_xOdoxo8wXmKtpX95Bn47vmZKo=.4ac845fd-4f54-4b7b-ac34-fff986e7af92@github.com> Message-ID: <GT_7lHNNc2XDWOMfoD8u7fy95njfvvA96fn0l0Y7Vys=.bad9ca8b-d9ae-41af-98ac-28369a1b7ab3@github.com> On Fri, 15 Nov 2024 08:10:57 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> I backport this for parity with 21.0.6-oracle. >> >> Locally a clean patch, but /backport did not work. >> lib files included in tests. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe GHA failure: infra issue, unrelated error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1145#issuecomment-2480509198 From goetz at openjdk.org Sat Nov 16 10:36:18 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 16 Nov 2024 10:36:18 GMT Subject: [jdk21u-dev] RFR: 8342183: Update tests to use stronger algorithms and keys In-Reply-To: <grJyW-kFRkQbxOIfO66_O7U1QzYGd9yNfV4oaPlHSus=.8b3f3b53-7720-4a29-afb4-0f757ed7fda2@github.com> References: <grJyW-kFRkQbxOIfO66_O7U1QzYGd9yNfV4oaPlHSus=.8b3f3b53-7720-4a29-afb4-0f757ed7fda2@github.com> Message-ID: <QuQH9vl-g1eLxtkd_ECneB38YHFkHIRGQPeN9Q1-3hc=.5557e9d0-bb4a-43d6-adf1-8e28828d29dc@github.com> On Mon, 11 Nov 2024 11:52:42 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > Resolved Copyright of SignedOrder, probably clean. GHA failure: infra issue, unrelated. error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1146#issuecomment-2480509453 From goetz at openjdk.org Sat Nov 16 10:40:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 16 Nov 2024 10:40:15 GMT Subject: [jdk17u-dev] RFR: 8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak" In-Reply-To: <cTRkZ72M5nVF6PMA9494zviPQ8W8y5mUlq01Y1KwOqI=.f28e0da0-a67a-4077-b17c-e5fabc9190b0@github.com> References: <cTRkZ72M5nVF6PMA9494zviPQ8W8y5mUlq01Y1KwOqI=.f28e0da0-a67a-4077-b17c-e5fabc9190b0@github.com> Message-ID: <npEpQqSEDiuhzS9DWzVkG55SywRSsDqZFIXWzPQBiEk=.6f0b03aa-c6c3-44fe-a6db-b846a487a5da@github.com> On Fri, 15 Nov 2024 12:46:32 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. GHA failure: infra issue, unrelated. error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3043#issuecomment-2480516600 From goetz at openjdk.org Sat Nov 16 10:40:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 16 Nov 2024 10:40:51 GMT Subject: [jdk17u-dev] RFR: 8284291: sun/security/krb5/auto/Renew.java fails intermittently on Windows 11 In-Reply-To: <q0_xtZmN0nsBjVXoaJ_nCM4OQ4icQitwzAXAa1zWbwo=.364acaa4-1b0d-4715-ab40-8de36593754f@github.com> References: <q0_xtZmN0nsBjVXoaJ_nCM4OQ4icQitwzAXAa1zWbwo=.364acaa4-1b0d-4715-ab40-8de36593754f@github.com> Message-ID: <UavJrZnGwjH6t5KNSKoGHENXdfZJnpbKHEnP_xAbD2M=.32f68976-e6e9-4284-8b76-481e28aaf4e0@github.com> On Fri, 15 Nov 2024 12:50:37 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. GHA failure: infra issue, unrelated. mac: error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' linux: Error: sh][ERROR] wget exited with exit code 4 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3044#issuecomment-2480518139 From goetz at openjdk.org Sat Nov 16 10:40:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 16 Nov 2024 10:40:43 GMT Subject: [jdk17u-dev] RFR: 8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test In-Reply-To: <pDV3PYIx_HAX_voLUFy2-_tz9omK6aaYG-mGUZqK8hc=.2ce27bc4-b15d-4bc6-bfc8-e693f1c9a693@github.com> References: <pDV3PYIx_HAX_voLUFy2-_tz9omK6aaYG-mGUZqK8hc=.2ce27bc4-b15d-4bc6-bfc8-e693f1c9a693@github.com> Message-ID: <fV5Pekxz_8ALkTs0VCIvakI9ReR5rAV2Ji3lHxdGqEg=.962778a2-0fc4-4531-a42b-75ab27a94345@github.com> On Fri, 15 Nov 2024 12:52:48 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. GHA failure: infra issue, unrelated. mac: error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3045#issuecomment-2480518255 From goetz at openjdk.org Sat Nov 16 10:41:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 16 Nov 2024 10:41:51 GMT Subject: [jdk17u-dev] RFR: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker In-Reply-To: <HiN8Lk0Wq9uzYr0HehC0PJaKFaUGT1ubgUvBghOZA34=.99f12638-afe1-427f-a2fc-95041326f79c@github.com> References: <HiN8Lk0Wq9uzYr0HehC0PJaKFaUGT1ubgUvBghOZA34=.99f12638-afe1-427f-a2fc-95041326f79c@github.com> Message-ID: <ElNMVTGKWKoKCoPHHGCp5P57_c1neruJbaFaY4JFoWw=.dd7e2df1-9d06-48b5-b42b-9f095125ca8b@github.com> On Fri, 15 Nov 2024 14:32:31 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. GHA failure: infra issue, unrelated. mac: error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3046#issuecomment-2480518383 From duke at openjdk.org Sat Nov 16 11:18:50 2024 From: duke at openjdk.org (duke) Date: Sat, 16 Nov 2024 11:18:50 GMT Subject: [jdk17u-dev] RFR: 8332935: Crash: assert(*lastPtr != 0) failed: Mismatched JNINativeInterface tables, check for new entries In-Reply-To: <e5LFZGDIUuc_57g0TQTWcMs8zrkJWx9zCQpNBKMuipY=.89f48dad-b4fa-4176-aefb-78f3bd480f6a@github.com> References: <e5LFZGDIUuc_57g0TQTWcMs8zrkJWx9zCQpNBKMuipY=.89f48dad-b4fa-4176-aefb-78f3bd480f6a@github.com> Message-ID: <swC6K3RdblF5dHW2u4euJdMa3L19PEnTBdlrwif3hmw=.131b0d1d-f18f-4838-ae4e-7e3b4e2aae62@github.com> On Thu, 14 Nov 2024 14:26:11 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Backport of [JDK-8332935](https://bugs.openjdk.org/browse/JDK-8332935). This is a P2 issue that makes the JVM to crash in some situations, JDK-8332935 was difficult to track down (it happened by chance) so I think it's worth a backport. > > Backport is mostly clean but for a copyright change and low risk. Tier1 tests passed in Linux. @vieiro Your change (at version 672a8aa39aa4cc8d68fd58fa63b58d1501027704) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3041#issuecomment-2480526827 From syan at openjdk.org Sat Nov 16 16:54:58 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 16 Nov 2024 16:54:58 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> Message-ID: <1xktYlJrpTSD3dj1jzG12eSBl2Z9oASp3lZC4QO65vQ=.d2fd6f52-06db-4abc-a556-e5ffe45ec67f@github.com> On Sat, 19 Oct 2024 08:00:47 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [f56a1541](https://github.com/openjdk/jdk/commit/f56a154132f7e66b1b65adfa2aa937119999b14a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 14 Oct 2024 and was reviewed by Chen Liang, Severin Gehwolf, Magnus Ihse Bursie and Brian Burkhalter. > > The original PR use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly. > > Additional testing: > > - [x] linux-x64 build at alinux3, and run the test passed. > - [x] linux-x64 build at centos7 docker container, and run the test passed. > - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command > > `libCreationTimeHelper.c` compile test command: > > gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c > > > Thanks! Hi, can anyone take look this PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1068#issuecomment-2480662977 From syan at openjdk.org Sat Nov 16 16:55:01 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 16 Nov 2024 16:55:01 GMT Subject: [jdk11u-dev] RFR: 8204267: Generate comments in -XX:+PrintInterpreter to link to source code In-Reply-To: <GW_C66bE_JwBvdBb1VOVkI5WCFtjS7p_TMVcNCkg-yI=.a1e02012-653c-4243-a035-bb583ab60a32@github.com> References: <GW_C66bE_JwBvdBb1VOVkI5WCFtjS7p_TMVcNCkg-yI=.a1e02012-653c-4243-a035-bb583ab60a32@github.com> Message-ID: <g8IXmCdkICMMd2gnl8fhAgJsGKTGNRQKun-MmaXMxjg=.fbb9a59a-6df4-4f8d-ac33-e112e7058139@github.com> On Sat, 19 Oct 2024 08:25:50 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > HotSpot's interpreter is dynamically generated (by C++ sources such as src/hotspot/cpu/x86/templateTable_x86.cpp). > > The command `java -XX:+PrintInterpreter` can be used to print a disassembly of the HotSpot interpreter. However, the output has very little comment, and it's very hard to associate the assembler instructions with the C++ code that generates them. > > To make it easier to understand the -XX:+PrintInterpreter, we should generate comments to link the instructions back to the C++ source code that generates them. This is doable because much of the interpreter code generation is done via a macro "__". We can redefine this macro to generate comments. > > The file `src/hotspot/share/compiler/disassembler.cpp` has different context cause this PR can't backport cleanly, all other files are backport cleanly. > > Only change the behavior of `PrintInterpreter`, risk is low. > > Additional testing: > > - [x] linux x64 build with fastdebug and slowdebug configure > - [x] linux x64 jtreg tests(include tier1/2/3 etc.) with release build > - [x] linux aarch64 jtreg tests(include tier1/2/3 etc.) with release build > > > Thanks. Hi, can anyone take look this PR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2957#issuecomment-2480662957 From duke at openjdk.org Sat Nov 16 22:29:53 2024 From: duke at openjdk.org (duke) Date: Sat, 16 Nov 2024 22:29:53 GMT Subject: [jdk11u-dev] Withdrawn: 8320675: PrinterJob/SecurityDialogTest.java hangs In-Reply-To: <J-VFfS2KJyUkJkuSis8SvqgqUFCC-Dlgge2h2ddgqvY=.c14955ef-5736-4b11-a2ab-662cb7bd20f9@github.com> References: <J-VFfS2KJyUkJkuSis8SvqgqUFCC-Dlgge2h2ddgqvY=.c14955ef-5736-4b11-a2ab-662cb7bd20f9@github.com> Message-ID: <4jnjHeOmEwiCQz8l6_WNeFaYUUEbHoP3nJd718gaEx8=.2f11b195-a16a-47b1-9d22-1e45a2dd82bc@github.com> On Thu, 15 Aug 2024 06:49:52 GMT, Andrew Lu <andrewlu at openjdk.org> wrote: > I backport this for parity with 11.0.25-oracle. > modify lines are different, but code is clean. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2912 From duke at openjdk.org Sun Nov 17 23:25:21 2024 From: duke at openjdk.org (duke) Date: Sun, 17 Nov 2024 23:25:21 GMT Subject: [jdk17u-dev] Withdrawn: 8307648: java/net/httpclient/ExpectContinueTest.java timed out In-Reply-To: <7b2Q9_wuaiyAuPzTbGcsHBJFBeZdM0fK1cq6zjJpjgQ=.04ca936f-2ef2-485b-bc00-ac48829ab2d6@github.com> References: <7b2Q9_wuaiyAuPzTbGcsHBJFBeZdM0fK1cq6zjJpjgQ=.04ca936f-2ef2-485b-bc00-ac48829ab2d6@github.com> Message-ID: <T7KU0OcYz3-Aao405GCjIT1g7mTB0awXa-nM-nvqodQ=.76e9b1de-7b16-4f1b-9a4e-9867443e3af3@github.com> On Tue, 13 Aug 2024 22:24:03 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote: > The backport is not clean. > > JDK17 does not have JDK-8293786. As a result, the debug log is not merged into Stream::incoming_reset method. These changes could be skipped because they are not required for this functionality > > Also, ExpectContinueTest test was added in JDK21 as part of JDK-8286171. Not backported to JDK17. The changes for this test are skipped > > All java/net/httpclient JTREG tests passed This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2799 From amitkumar at openjdk.org Mon Nov 18 04:43:37 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 18 Nov 2024 04:43:37 GMT Subject: [jdk21u-dev] RFR: 8343506: [s390x] multiple test failures with ubsan Message-ID: <FSFXc1IQtmB9nkMolGGQGwnlgLqFpFSsC92hoMLHatU=.0d545267-9713-468b-866c-4cd4f4b78d0f@github.com> clean backport for [JDK-8343506](https://bugs.openjdk.org/browse/JDK-8343506) ------------- Commit messages: - Backport f6edfe58d6931b058a5fec722615740818711065 Changes: https://git.openjdk.org/jdk21u-dev/pull/1157/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1157&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343506 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1157.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1157/head:pull/1157 PR: https://git.openjdk.org/jdk21u-dev/pull/1157 From amitkumar at openjdk.org Mon Nov 18 04:58:24 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 18 Nov 2024 04:58:24 GMT Subject: [jdk23u] RFR: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java Message-ID: <GzlWJJPxavKkqQY2spMqtWP3vwIRaCfZkD8dhmdvuH4=.ac1719f5-8bd1-416d-a9ee-5e3260a1ce0f@github.com> Hi all, This pull request contains a backport of commit [3245f56e](https://github.com/openjdk/jdk/commit/3245f56e53792b3cfc9788799ba1594d6af15bea) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 15 Nov 2024 and was reviewed by Lutz Schmidt. Thanks! ------------- Commit messages: - Backport 3245f56e53792b3cfc9788799ba1594d6af15bea Changes: https://git.openjdk.org/jdk23u/pull/226/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=226&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344164 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/226.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/226/head:pull/226 PR: https://git.openjdk.org/jdk23u/pull/226 From amitkumar at openjdk.org Mon Nov 18 05:03:35 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 18 Nov 2024 05:03:35 GMT Subject: [jdk21u-dev] RFR: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java Message-ID: <FwgThfnyMw38TpSEqBkocsAWe5Y6TXTFDCEvtEMfqqI=.f8af1977-06ca-4f8a-98e0-e33bee62800b@github.com> Hi all, This pull request contains a backport of commit [3245f56e](https://github.com/openjdk/jdk/commit/3245f56e53792b3cfc9788799ba1594d6af15bea) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 15 Nov 2024 and was reviewed by Lutz Schmidt. Thanks! ------------- Commit messages: - Backport 3245f56e53792b3cfc9788799ba1594d6af15bea Changes: https://git.openjdk.org/jdk21u-dev/pull/1158/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1158&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344164 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1158.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1158/head:pull/1158 PR: https://git.openjdk.org/jdk21u-dev/pull/1158 From jwtang at openjdk.org Mon Nov 18 07:25:47 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Mon, 18 Nov 2024 07:25:47 GMT Subject: [jdk21u-dev] RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump In-Reply-To: <G9SUlu-3RDGh-qwY0w_4OcKZ15146jBBbLPKkaa0-J4=.8e2d3d4e-d9ba-4eeb-b645-0dd37e402d1f@github.com> References: <Mw0ex-Ijyg21Wpawt_al_MjY-9F_g04YLouw6chyIxI=.dc15acad-a2b8-4ba9-a5e1-b17f3422edf2@github.com> <G9SUlu-3RDGh-qwY0w_4OcKZ15146jBBbLPKkaa0-J4=.8e2d3d4e-d9ba-4eeb-b645-0dd37e402d1f@github.com> Message-ID: <yH0D7XOIuzuO4LGgW3uxAxKA8JjdPuVrzLFme-pJZmU=.19a3b5f8-0dd4-4ceb-ab29-2845090152f0@github.com> On Thu, 7 Nov 2024 13:20:38 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> I have two reasons to backport 8330846. >> 1. When run the jtreg test `test/jdk/jdk/jfr/event/runtime/TestThreadDumpEvent.java` with the option `-testThreadFactory:Virtual`, it will fail because of the loss of `TestThreadDumpEvent.main` in the result. >> 2. It helps developers to have a better view of their programs. > > Hi @jia-wei-tang, > what about follow-up JDK-8334215, is this needed also? > Removing the label in the meantime. @GoeLin Hi, Should I backport JDK-8334215 in the same pr or create a new on after this merged? JDK-8330846 is the base of JDK-8334215, so I think both of them should be backported. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1129#issuecomment-2482139699 From duke at openjdk.org Mon Nov 18 07:53:53 2024 From: duke at openjdk.org (HempushpaSahu) Date: Mon, 18 Nov 2024 07:53:53 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: <45UzLuBpkdqiMiRzz-SVYtQbplWB-oWRcC9k6w5gYps=.dd750e61-a429-420c-8bd1-ccc35787bed0@github.com> References: <w8CMo34RO2XDqFpbBM99zKIworM_HiI1RhBx3CK_G8k=.6e4f7d28-ae7f-418a-a3b8-c56baf3889ab@github.com> <45UzLuBpkdqiMiRzz-SVYtQbplWB-oWRcC9k6w5gYps=.dd750e61-a429-420c-8bd1-ccc35787bed0@github.com> Message-ID: <NYywP48RYLuzIBnQIGj0iGO2w1ROgEU3eyYfY80MMLM=.bf6c3472-f801-4f9b-9a3a-ce819b5b9c94@github.com> On Fri, 23 Aug 2024 10:21:38 GMT, HempushpaSahu <duke at openjdk.org> wrote: >> Backporting JDK-8179502 - Enhance OCSP, CRL and Certificate Fetch Timeouts. >> OCSP request throws Connection timeout occasionally, so this needs to be backported to fix the issue. >> >> Reported issue : https://bugs.openjdk.org/browse/JDK-8179502 > > Duplicate of https://github.com/openjdk/jdk17u-dev/pull/2747. Hence, closing this PR > Thanks. > Hi @HempushpaSahu , one more thing: What happens if someone has set com.sun.security.crl.timeout and installs the update. Will that value be taken over to com.sun.security.ocsp.readtimeout, or will that fall back to 15s? This has been handled by Alexey in the openJdk PR 8179502. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2754#issuecomment-2482185840 From goetz at openjdk.org Mon Nov 18 10:18:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 10:18:24 GMT Subject: [jdk17u-dev] RFR: 8300416: java.security.MessageDigestSpi clone can result in thread-unsafe clones In-Reply-To: <BUiczzTncE_deDvnCPH-46BYgKT_WqksCVUhrQ2CVRY=.9cabe268-00b0-4f5c-9f72-70cd6329380c@github.com> References: <BUiczzTncE_deDvnCPH-46BYgKT_WqksCVUhrQ2CVRY=.9cabe268-00b0-4f5c-9f72-70cd6329380c@github.com> Message-ID: <dLhFsfGc4eZyYIzH4ud4Kla_t_3GLBx3v1ugG3Jxkd0=.6560d8bf-9898-4261-bfbf-fe299409c7f6@github.com> On Tue, 12 Nov 2024 15:30:39 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I would like to fix this in 17. > > Resolved Copyright, probably clean. GHA failures: well known infra issues, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3039#issuecomment-2482533985 From goetz at openjdk.org Mon Nov 18 10:18:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 10:18:24 GMT Subject: [jdk17u-dev] Integrated: 8300416: java.security.MessageDigestSpi clone can result in thread-unsafe clones In-Reply-To: <BUiczzTncE_deDvnCPH-46BYgKT_WqksCVUhrQ2CVRY=.9cabe268-00b0-4f5c-9f72-70cd6329380c@github.com> References: <BUiczzTncE_deDvnCPH-46BYgKT_WqksCVUhrQ2CVRY=.9cabe268-00b0-4f5c-9f72-70cd6329380c@github.com> Message-ID: <fYagzUZdxaAJH4ycxrrgMr0_JkGtR49Qc2ygBsMoCeU=.a396f0e1-4b5e-48cc-ac83-70c822450593@github.com> On Tue, 12 Nov 2024 15:30:39 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I would like to fix this in 17. > > Resolved Copyright, probably clean. This pull request has now been integrated. Changeset: 49b1ca94 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/49b1ca9447d79cf5e6bcba0a33b0468fcbcb6319 Stats: 64 lines in 2 files changed: 58 ins; 0 del; 6 mod 8300416: java.security.MessageDigestSpi clone can result in thread-unsafe clones Backport-of: 2e2e71e1fa326b8d30f018a3e0726bbcd6d24019 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3039 From goetz at openjdk.org Mon Nov 18 10:42:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 10:42:51 GMT Subject: [jdk17u-dev] RFR: 8302225: SunJCE Provider doesn't validate key sizes when using 'constrained' transforms for AES/KW and AES/KWP Message-ID: <Q6_kPU4G39OcwmdBTVKstFkm68YpfXvsOWUpk63cQbQ=.61892003-542e-4a20-8a18-7f2de43e43d5@github.com> I would like to fix this issue in the sun crypto provider. Clean backport except for Copyright, probably recognized clean. ------------- Commit messages: - Backport 4ce493f09ea3a34322462e82fd73b8375be1cba5 Changes: https://git.openjdk.org/jdk17u-dev/pull/3047/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3047&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302225 Stats: 60 lines in 2 files changed: 36 ins; 13 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3047.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3047/head:pull/3047 PR: https://git.openjdk.org/jdk17u-dev/pull/3047 From mdoerr at openjdk.org Mon Nov 18 11:10:24 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 18 Nov 2024 11:10:24 GMT Subject: [jdk21u-dev] RFR: 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners Message-ID: <L9r2GC0mwEDl7AjAP9Nr-Wqke7TflyehASQNT02oUrg=.81832fc9-10f7-463a-989b-1663715e6d7a@github.com> Clean backport of [JDK-8343923](https://bugs.openjdk.org/browse/JDK-8343923). Required because of https://github.com/actions/runner-images/issues/10703. ------------- Commit messages: - Backport 4c5bc5f2f091ae861d5329cdae42fe7fa295544b Changes: https://git.openjdk.org/jdk21u-dev/pull/1159/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1159&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343923 Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1159.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1159/head:pull/1159 PR: https://git.openjdk.org/jdk21u-dev/pull/1159 From mdoerr at openjdk.org Mon Nov 18 11:10:55 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 18 Nov 2024 11:10:55 GMT Subject: [jdk17u-dev] RFR: 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners Message-ID: <MMHwioQyodcsm7_39LX0ThfYR1PUA3UcP2kCNobTN3g=.bc28be47-5e29-4029-aa1b-7ae63bdd3ea6@github.com> Clean backport of [JDK-8343923](https://bugs.openjdk.org/browse/JDK-8343923). Required because of https://github.com/actions/runner-images/issues/10703. ------------- Commit messages: - Backport 4c5bc5f2f091ae861d5329cdae42fe7fa295544b Changes: https://git.openjdk.org/jdk17u-dev/pull/3048/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3048&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343923 Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3048.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3048/head:pull/3048 PR: https://git.openjdk.org/jdk17u-dev/pull/3048 From syan at openjdk.org Mon Nov 18 11:11:03 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 18 Nov 2024 11:11:03 GMT Subject: [jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v3] In-Reply-To: <FRk1kNb6VseLuEwe2SjE555xQi9N3X6vMDf7k3m43CI=.1b1609b5-223b-4b9b-901d-3f2584a9e8dc@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> <FRk1kNb6VseLuEwe2SjE555xQi9N3X6vMDf7k3m43CI=.1b1609b5-223b-4b9b-901d-3f2584a9e8dc@github.com> Message-ID: <rGsNyMEoPJFMvLZt-kjuT1pM0xiwtKBurZx1_5yG4d0=.7b3c18a9-4846-4a66-971e-da67c03e7336@github.com> On Fri, 8 Nov 2024 09:47:15 GMT, SendaoYan <syan at openjdk.org> wrote: >> Hi all, >> >> This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. >> >> The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. >> >> The new API `Path resolve(String first, String... more)` was not supported in jdk21u-dev, so I change the line code from `COPY_JDK_DIR.resolve("bin", "java")` to `COPY_JDK_DIR.resolve("bin").resolve("java")` to avoid jdk21 javac generate compile error, and make this backport uncleanly, all other parts are backported cleanly. >> >> The change has been verified locally, test-fix only, no risk. >> >> Thanks! > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > change the line code from COPY_JDK_DIR.resolve("bin", "java") to COPY_JDK_DIR.resolve("bin").resolve("java") to avoid jdk21 javac genrate compile error Thanks all for the review and approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2482714903 From syan at openjdk.org Mon Nov 18 11:11:04 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 18 Nov 2024 11:11:04 GMT Subject: [jdk21u-dev] Integrated: 8319673: Few security tests ignore VM flags In-Reply-To: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> References: <dGgQ3fdoqwcFPm0eMKVGeIJGv1ocVbo9vS36wDhVcd8=.818f83da-585f-46c5-b09d-97a5666e6119@github.com> Message-ID: <V4pW5-mZLJlKGNiD2lY40JFqN-J1XC8Cmt1Oi3afuKM=.24b111ba-c075-4def-989f-d5baee3fe33d@github.com> On Tue, 9 Jul 2024 07:17:51 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [43029006](https://github.com/openjdk/jdk/commit/430290066c23d09166a84f2f6f89e770c6ba04ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Backport parity with 21.0.5-oracle, the change has been verified, no risk. > > The commit being backported was authored by Matthew Donovan on 29 Feb 2024 and was reviewed by Weijun Wang and Hai-May Chao. > > The new API `Path resolve(String first, String... more)` was not supported in jdk21u-dev, so I change the line code from `COPY_JDK_DIR.resolve("bin", "java")` to `COPY_JDK_DIR.resolve("bin").resolve("java")` to avoid jdk21 javac generate compile error, and make this backport uncleanly, all other parts are backported cleanly. > > The change has been verified locally, test-fix only, no risk. > > Thanks! This pull request has now been integrated. Changeset: fa07b3de Author: SendaoYan <syan at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/fa07b3dee8c9958f759a4168e86670f145f769d1 Stats: 49 lines in 3 files changed: 12 ins; 13 del; 24 mod 8319673: Few security tests ignore VM flags Reviewed-by: lucy Backport-of: 430290066c23d09166a84f2f6f89e770c6ba04ff ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/830 From syan at openjdk.org Mon Nov 18 11:13:50 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 18 Nov 2024 11:13:50 GMT Subject: [jdk21u-dev] RFR: 8336257: Additional tests in jmxremote/startstop to match on PID not app name In-Reply-To: <EH9r5GQlVufB8QM2cSXTnsKpMiuASqKB6N30H43RTy4=.f94b319d-ed7b-4574-8d74-48ee5b54796f@github.com> References: <EH9r5GQlVufB8QM2cSXTnsKpMiuASqKB6N30H43RTy4=.f94b319d-ed7b-4574-8d74-48ee5b54796f@github.com> Message-ID: <RT-KtBae0kbvDKH2oMH-w0vWu_-vObsY0nesJHaDcjQ=.c2099bc9-8fe4-4a12-ac5f-232f3ac4cc27@github.com> On Sat, 16 Nov 2024 02:18:23 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [687601eb](https://github.com/openjdk/jdk/commit/687601ebcaedf133fd4d5cecc42c5aadf9c73f3c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer, Alan Bateman, Alex Menkov and Daniel D. Daugherty. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1156#issuecomment-2482726777 From syan at openjdk.org Mon Nov 18 11:13:51 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 18 Nov 2024 11:13:51 GMT Subject: [jdk21u-dev] Integrated: 8336257: Additional tests in jmxremote/startstop to match on PID not app name In-Reply-To: <EH9r5GQlVufB8QM2cSXTnsKpMiuASqKB6N30H43RTy4=.f94b319d-ed7b-4574-8d74-48ee5b54796f@github.com> References: <EH9r5GQlVufB8QM2cSXTnsKpMiuASqKB6N30H43RTy4=.f94b319d-ed7b-4574-8d74-48ee5b54796f@github.com> Message-ID: <8pPxH4k5M8_xixsOUgUZIPnxZNewr60TpmG_uW7t01Y=.afb36c05-0d6d-41b9-93ef-089110831c43@github.com> On Sat, 16 Nov 2024 02:18:23 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [687601eb](https://github.com/openjdk/jdk/commit/687601ebcaedf133fd4d5cecc42c5aadf9c73f3c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer, Alan Bateman, Alex Menkov and Daniel D. Daugherty. > > Thanks! This pull request has now been integrated. Changeset: 5b1a9521 Author: SendaoYan <syan at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/5b1a9521de45394817aa36dbf007e69a60c92604 Stats: 6 lines in 2 files changed: 2 ins; 1 del; 3 mod 8336257: Additional tests in jmxremote/startstop to match on PID not app name Backport-of: 687601ebcaedf133fd4d5cecc42c5aadf9c73f3c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1156 From duke at openjdk.org Mon Nov 18 13:26:54 2024 From: duke at openjdk.org (duke) Date: Mon, 18 Nov 2024 13:26:54 GMT Subject: [jdk21u-dev] RFR: 8343506: [s390x] multiple test failures with ubsan In-Reply-To: <FSFXc1IQtmB9nkMolGGQGwnlgLqFpFSsC92hoMLHatU=.0d545267-9713-468b-866c-4cd4f4b78d0f@github.com> References: <FSFXc1IQtmB9nkMolGGQGwnlgLqFpFSsC92hoMLHatU=.0d545267-9713-468b-866c-4cd4f4b78d0f@github.com> Message-ID: <W9o9YuhAJ_JMbxnjDaKwiak3OXCQVvscAm2kYj-6GIE=.58e0638e-e544-468f-97f8-a6c6924c8dba@github.com> On Mon, 18 Nov 2024 04:38:12 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > clean backport for [JDK-8343506](https://bugs.openjdk.org/browse/JDK-8343506) @offamitkumar Your change (at version e1cd6ca5bf41ca87e6a2947528f3ae2583a8a9df) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1157#issuecomment-2483034793 From duke at openjdk.org Mon Nov 18 13:27:58 2024 From: duke at openjdk.org (duke) Date: Mon, 18 Nov 2024 13:27:58 GMT Subject: [jdk21u-dev] RFR: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java In-Reply-To: <FwgThfnyMw38TpSEqBkocsAWe5Y6TXTFDCEvtEMfqqI=.f8af1977-06ca-4f8a-98e0-e33bee62800b@github.com> References: <FwgThfnyMw38TpSEqBkocsAWe5Y6TXTFDCEvtEMfqqI=.f8af1977-06ca-4f8a-98e0-e33bee62800b@github.com> Message-ID: <EU3KRBTkHjtzNphQrW7RTfXEoZHeunALxXzF_YhDG1U=.b6041340-9780-4fcc-9444-7ad9dd932891@github.com> On Mon, 18 Nov 2024 04:57:46 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [3245f56e](https://github.com/openjdk/jdk/commit/3245f56e53792b3cfc9788799ba1594d6af15bea) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 15 Nov 2024 and was reviewed by Lutz Schmidt. > > Thanks! @offamitkumar Your change (at version 6a9a418b624e22080d78a288bb599a0a1d08ab8d) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1158#issuecomment-2483039156 From goetz at openjdk.org Mon Nov 18 13:30:04 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 13:30:04 GMT Subject: [jdk17u-dev] RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property Message-ID: <bYXb_dXuiHVhe7G-L8Wg64Oh7WRA2VHgXbQmcQc22EI=.a4d85128-81e1-4c07-81db-c685beeff407@github.com> I backport this for parity with Oracle 17.0.14. The backport is based on the commit to 21. Tests passed including win tests. Three files are not real tests, I double-checked these. I had to resolve a lot of files, but all except three only differed in the Copyright year. Resolved files ================ doc/testing.html Resolved. Context differences. test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestCipherKeyWrapperTest.java test/jdk/com/sun/crypto/provider/Cipher/PBE/DecryptWithoutParameters.java test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java test/jdk/com/sun/crypto/provider/Cipher/PBE/PBESealedObject.java test/jdk/com/sun/crypto/provider/Cipher/PBE/TestCipherKeyWrapperPBEKey.java test/jdk/com/sun/crypto/provider/KeyGenerator/Test4628062.java test/jdk/com/sun/crypto/provider/Mac/HmacPBESHA1.java test/jdk/com/sun/crypto/provider/Mac/HmacSaltLengths.java test/jdk/com/sun/crypto/provider/Mac/MacClone.java test/jdk/com/sun/crypto/provider/NSASuiteB/TestHmacSHAOids.java All these test lack 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider All only Copyright except for DecryptWithoutParameters.java: Test in 17 has less and other test cases, adapted change to this. test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestGeneral.java Test was modified in 18 by 8271745: Correct block size for KW,KWP mode and use fixed IV for KWP mode for SunJCE Test in 17 has other test cases, adapted change to this. test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestKeySizeCheck.java Test was modified in 8302225: SunJCE Provider doesn't validate key sizes when using 'constrained' transforms for AES/KW and AES/KWP Backport started. Resolved Copyright. test/jdk/com/sun/crypto/provider/KeyAgreement/TestExponentSize.java Modified in 19 by 8267319: Use larger default key sizes and algorithms based on CNSA Resolved Copyright. test/jdk/com/sun/jdi/ClassesByName2Test.java Modified by virtual threads changes. Resolved Copyright. test/jdk/javax/crypto/EncryptedPrivateKeyInfo/GetAlgName.java Modified in 20 by 8296442: EncryptedPrivateKeyInfo can be created with an uninitialized AlgorithmParameters. This is a follow-up of a cleanup change also in 20. Resolved Copyright. Files not in 17 =============== test/jdk/com/sun/crypto/provider/KeyGenerator/Test6227536.java This test came in 20 with 6227536: KeyGenerator.init() methods do not throw IllegalArgumentException for keysize == 0 Not a candidate for backport. test/jdk/sun/security/ec/ECDSAPrimitive.java Depends on 8333754: Add a Test against ECDSA and ECDH NIST Test vector which is a candidate for backport, but it's not trivial to do so. I would like to proceed with this change, anyways. test/jdk/sun/security/ec/ECDSAPrvGreaterThanOrder.java This test came in 18 with 8272385: Enforce ECPrivateKey d value to be in the range [1, n-1] for SunEC provider Not a candidate for backport. Throws new exception. test/jdk/sun/security/ec/OidInstance.java This test came in 19 with 8279801: EC KeyFactory and KeyPairGenerator do not have aliases for OID format Hmm, I think this would be nice-to-have in 17. It's not critical. But I don't want to drive this now. test/jdk/sun/security/pkcs11/Cipher/KeyWrap/NISTWrapKAT.java test/jdk/sun/security/pkcs11/Cipher/KeyWrap/TestGeneral.java Both came in 18 with 8264849: Add KW and KWP support to PKCS11 provider. Seems to be a follow-up Enhancement enabled by a change that came in 17. test/jdk/sun/security/pkcs11/Cipher/PBECipher.java test/jdk/sun/security/pkcs11/Mac/PBAMac.java Both came in 21 with 8301553: Support Password-Based Cryptography in SunPKCS11 Not a candidate for backport. ------------- Commit messages: - Backport 9bdf2a619d1d158d6c1e8e1e1238a4229e0b0783 Changes: https://git.openjdk.org/jdk17u-dev/pull/3049/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3049&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341927 Stats: 970 lines in 222 files changed: 294 ins; 0 del; 676 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3049.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3049/head:pull/3049 PR: https://git.openjdk.org/jdk17u-dev/pull/3049 From goetz at openjdk.org Mon Nov 18 13:47:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 13:47:50 GMT Subject: [jdk21u-dev] Integrated: 8342188: Update tests to use stronger key parameters and certificates In-Reply-To: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> References: <oToGgAvkZsmcooAliwr7icWxT9PRy6H3OKd3FmVK-P0=.439bb96c-55b6-4d8d-96f3-a3343e680dff@github.com> Message-ID: <2WRv1L_JIKhn7Dh2jbm1fp6YRe8x92FSNZmwWGzsqM0=.2cfe29ab-042d-40b6-afc8-32a39386f3e2@github.com> On Mon, 11 Nov 2024 11:26:11 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > Locally a clean patch, but /backport did not work. > lib files included in tests. This pull request has now been integrated. Changeset: 0fd31732 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/0fd31732ddf21e29281f6040e4e9e3de0b6f6eab Stats: 2728 lines in 15 files changed: 1090 ins; 395 del; 1243 mod 8342188: Update tests to use stronger key parameters and certificates Backport-of: ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1145 From goetz at openjdk.org Mon Nov 18 13:48:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 13:48:53 GMT Subject: [jdk21u-dev] Integrated: 8342183: Update tests to use stronger algorithms and keys In-Reply-To: <grJyW-kFRkQbxOIfO66_O7U1QzYGd9yNfV4oaPlHSus=.8b3f3b53-7720-4a29-afb4-0f757ed7fda2@github.com> References: <grJyW-kFRkQbxOIfO66_O7U1QzYGd9yNfV4oaPlHSus=.8b3f3b53-7720-4a29-afb4-0f757ed7fda2@github.com> Message-ID: <TbpCbDtFWDbyPXcIq8fHTx2vk-Ur_TkO_lAVS2371EI=.69291db9-310a-4135-acca-ae36a25f1499@github.com> On Mon, 11 Nov 2024 11:52:42 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > > Resolved Copyright of SignedOrder, probably clean. This pull request has now been integrated. Changeset: e1eb3412 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/e1eb341217fb5411721dec1b78e4bbf06f2f5cda Stats: 267 lines in 35 files changed: 142 ins; 8 del; 117 mod 8342183: Update tests to use stronger algorithms and keys Backport-of: c82ad845e101bf5d97c0744377d68002907d4a0e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1146 From goetz at openjdk.org Mon Nov 18 13:48:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 13:48:58 GMT Subject: [jdk17u-dev] Integrated: 8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak" In-Reply-To: <cTRkZ72M5nVF6PMA9494zviPQ8W8y5mUlq01Y1KwOqI=.f28e0da0-a67a-4077-b17c-e5fabc9190b0@github.com> References: <cTRkZ72M5nVF6PMA9494zviPQ8W8y5mUlq01Y1KwOqI=.f28e0da0-a67a-4077-b17c-e5fabc9190b0@github.com> Message-ID: <yMHG3v0NTklBCeb5XrMU0RXXSQ7h2xsIx-cDhl9PRB8=.d8ac8883-fe0d-4625-90d8-bb963f1a0d67@github.com> On Fri, 15 Nov 2024 12:46:32 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: e4860005 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/e4860005dcbaceb783dd6ea2cb7cbc9972ce38fa Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod 8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak" Backport-of: aefd4ac4a336f00c067bcb91b95472ccc9a6bf83 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3043 From goetz at openjdk.org Mon Nov 18 13:49:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 13:49:57 GMT Subject: [jdk17u-dev] Integrated: 8284291: sun/security/krb5/auto/Renew.java fails intermittently on Windows 11 In-Reply-To: <q0_xtZmN0nsBjVXoaJ_nCM4OQ4icQitwzAXAa1zWbwo=.364acaa4-1b0d-4715-ab40-8de36593754f@github.com> References: <q0_xtZmN0nsBjVXoaJ_nCM4OQ4icQitwzAXAa1zWbwo=.364acaa4-1b0d-4715-ab40-8de36593754f@github.com> Message-ID: <1eWsVMSaJ_UKYGqSLKiQUzmAQQvDHFFXt2e7E0JS8K0=.f2dcb304-945c-46f5-a5ca-5bd0cc2780c6@github.com> On Fri, 15 Nov 2024 12:50:37 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 4b74741d Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/4b74741d179bf928f3fa8a77fc838c3c608f613a Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod 8284291: sun/security/krb5/auto/Renew.java fails intermittently on Windows 11 Backport-of: 05ae7ed1aac6fabc9c8820c12b6567fe93a3546f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3044 From goetz at openjdk.org Mon Nov 18 13:51:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 13:51:11 GMT Subject: [jdk17u-dev] Integrated: 8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test In-Reply-To: <pDV3PYIx_HAX_voLUFy2-_tz9omK6aaYG-mGUZqK8hc=.2ce27bc4-b15d-4bc6-bfc8-e693f1c9a693@github.com> References: <pDV3PYIx_HAX_voLUFy2-_tz9omK6aaYG-mGUZqK8hc=.2ce27bc4-b15d-4bc6-bfc8-e693f1c9a693@github.com> Message-ID: <Mg5E7ZNMF_nTqgcL4HOq0J6ewdA-ai_qpe4lM1a1vUY=.483e7e47-6758-433e-af94-7b3267549864@github.com> On Fri, 15 Nov 2024 12:52:48 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: b1fae1cb Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/b1fae1cbff511e9f96d053bb4dcd533f06de24c0 Stats: 336 lines in 1 file changed: 52 ins; 224 del; 60 mod 8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test Backport-of: b22a38dedb06199f2cba3b6f8962ddf2f9f4f16d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3045 From goetz at openjdk.org Mon Nov 18 13:51:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 13:51:47 GMT Subject: [jdk17u-dev] Integrated: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker In-Reply-To: <HiN8Lk0Wq9uzYr0HehC0PJaKFaUGT1ubgUvBghOZA34=.99f12638-afe1-427f-a2fc-95041326f79c@github.com> References: <HiN8Lk0Wq9uzYr0HehC0PJaKFaUGT1ubgUvBghOZA34=.99f12638-afe1-427f-a2fc-95041326f79c@github.com> Message-ID: <pOPxJaBBzl3U1nHgCfnKOjMpPb5xAmGy-aJFT-Cr2tg=.0642ff72-eeeb-4e3d-9a57-cf3cbbc94474@github.com> On Fri, 15 Nov 2024 14:32:31 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 8989babe Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/8989babebe824ed31f434d7b5fef236a67549042 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker Backport-of: 220781fa56a9c8d3b64c5c6578ffd76b9edb795c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3046 From duke at openjdk.org Mon Nov 18 13:54:07 2024 From: duke at openjdk.org (duke) Date: Mon, 18 Nov 2024 13:54:07 GMT Subject: [jdk11u-dev] Withdrawn: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion In-Reply-To: <vPftO_RdHDIC0_1KymDSWwvGiNs7UMMNvFT-ZT3Kd3Q=.cc7d6bed-4450-40c2-9229-0532ce592665@github.com> References: <vPftO_RdHDIC0_1KymDSWwvGiNs7UMMNvFT-ZT3Kd3Q=.cc7d6bed-4450-40c2-9229-0532ce592665@github.com> Message-ID: <bqh75PxopnV3i2cduQM_wASUSkym5X7suznY4bOssVQ=.0b09a176-155e-4789-982a-cf4c08f534f1@github.com> On Mon, 23 Sep 2024 10:54:41 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2939 From duke at openjdk.org Mon Nov 18 14:00:59 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Mon, 18 Nov 2024 14:00:59 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result In-Reply-To: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> Message-ID: <gSmb2dFEDjVgUAE9Xy-Xb63xfmm8azJGwEQjL1h0YsM=.50fc4abe-cdff-4439-8665-52fa8f6d0829@github.com> On Fri, 8 Nov 2024 12:44:55 GMT, Radek ??p <duke at openjdk.org> wrote: > Backport for https://bugs.openjdk.org/browse/JDK-8337066 > > When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. > > This is a clean backport. I run tier1 locally and it's passing: ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 jtreg:test/jdk:tier1 1898 1898 0 0 jtreg:test/langtools:tier1 3937 3937 0 0 jtreg:test/nashorn:tier1 0 0 0 0 jtreg:test/jaxp:tier1 0 0 0 0 ============================== TEST SUCCESS Finished building target 'run-test-tier1' in configuration 'linux-x86_64-normal-server-release' I had issues with running the test with `make run-test TEST="jtreg:test/hotspot/jtreg/compiler/controldependency/TestAntiDependencyForPinnedLoads.java"` because it leads to some kind of fallback to US-ASCII: test/8337066/test/hotspot/jtreg/compiler/controldependency/TestAntiDependencyForPinnedLoads.java:39: error: unmappable character (0xE5) for encoding US-ASCII String str = "YYYY\ufffd\ufffd\ufffdMM\ufffd\ufffd\ufffdDD\ufffd\ufffd\ufffd"; A manual jtreg run pass the test. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2483125840 From sgehwolf at openjdk.org Mon Nov 18 14:02:06 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 18 Nov 2024 14:02:06 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 In-Reply-To: <NURrOIkUuQUm2ZFsmb-8QvM4Ex0_P6_DH7eRWOFhsnw=.83d8cc8f-7966-480c-965b-cc90d73264b5@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> <NURrOIkUuQUm2ZFsmb-8QvM4Ex0_P6_DH7eRWOFhsnw=.83d8cc8f-7966-480c-965b-cc90d73264b5@github.com> Message-ID: <xuQV80Qh4F1ptKnmKUrFYOmW5R1mPczuScNRLjQzgNc=.b9b479d7-f1aa-474c-a8a4-8240118e01db@github.com> On Fri, 15 Nov 2024 17:14:04 GMT, sophia-guo <duke at openjdk.org> wrote: > Just confirm that the GHA action should have been enabled. Yes, but this PR doesn't show them as being run. I.e. it's 1. enable GHA testing. 2. trigger GHA testing. You've done 1. but not 2. Example PR with GHA checks being run is here: https://github.com/openjdk/jdk21u-dev/pull/1143 It has `19 successful checks`. Yours has `2 successful checks`. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1100#issuecomment-2483128790 From mbaesken at openjdk.org Mon Nov 18 14:03:47 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 18 Nov 2024 14:03:47 GMT Subject: [jdk21u-dev] RFR: 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp In-Reply-To: <oXnw9oUMoM-QNz4l89lET2BEuka0v15o54h__uCFpW8=.ada1e3b0-517e-426d-8681-345990985251@github.com> References: <oXnw9oUMoM-QNz4l89lET2BEuka0v15o54h__uCFpW8=.ada1e3b0-517e-426d-8681-345990985251@github.com> Message-ID: <Qlq_rHXjpl2GbxpA8NPb04xT8W9QPoMlflkfo-tUxaM=.24a44ff8-438a-402e-88be-ff426af47379@github.com> On Wed, 13 Nov 2024 13:37:49 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > clean after adding static to __ieee754_pow see 8252136 macOS install toolchain issue in GHA is unrelated. Martin, thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1150#issuecomment-2483132207 From mdoerr at openjdk.org Mon Nov 18 14:04:30 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 18 Nov 2024 14:04:30 GMT Subject: [jdk21u-dev] Integrated: 8343724: [PPC64] Disallow OptoScheduling In-Reply-To: <NcUSexWS2CcmAxE0yAeXJix9q_PHRe5AQBvYCN6CK0E=.f0f4b45c-a286-45f5-9e3b-6af7819cf1e5@github.com> References: <NcUSexWS2CcmAxE0yAeXJix9q_PHRe5AQBvYCN6CK0E=.f0f4b45c-a286-45f5-9e3b-6af7819cf1e5@github.com> Message-ID: <ZcfSo2ddKoyRL6IHv4pmT4r51QGW-KtIeN0AUo1u-Hk=.c8f24c22-3dfb-430b-8b89-c61123d32cb4@github.com> On Wed, 13 Nov 2024 20:59:11 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: > Clean backport of [JDK-8343724](https://bugs.openjdk.org/browse/JDK-8343724). This pull request has now been integrated. Changeset: 38f654ee Author: Martin Doerr <mdoerr at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/38f654ee78297804c859c6a2f2f1b30fbb7a67ba Stats: 39 lines in 2 files changed: 22 ins; 16 del; 1 mod 8343724: [PPC64] Disallow OptoScheduling Backport-of: f621f26cd113090a0305598cfc50f0eac9a263c6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1153 From mdoerr at openjdk.org Mon Nov 18 14:04:31 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 18 Nov 2024 14:04:31 GMT Subject: [jdk21u-dev] Integrated: 8342607: Enhance register printing on x86_64 platforms In-Reply-To: <pS9fvMBAf9nylaUkntksVv-KEAMwIGU5nkUpuuU21FU=.758c177b-c1c5-4a1a-8acc-289ddcaf003a@github.com> References: <pS9fvMBAf9nylaUkntksVv-KEAMwIGU5nkUpuuU21FU=.758c177b-c1c5-4a1a-8acc-289ddcaf003a@github.com> Message-ID: <LAADWv6vka842EIWRdFTFn7oqZpAyZR3RHLuTYHXyZU=.2645ab48-a776-4de1-9d10-27474cbef6d1@github.com> On Wed, 13 Nov 2024 20:58:12 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: > Clean backport of [JDK-8342607](https://bugs.openjdk.org/browse/JDK-8342607). This pull request has now been integrated. Changeset: 1bfb57dc Author: Martin Doerr <mdoerr at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/1bfb57dca4a65ea64a15914b1e8b5c4c509db6f5 Stats: 37 lines in 3 files changed: 36 ins; 0 del; 1 mod 8342607: Enhance register printing on x86_64 platforms Backport-of: d8b3685d36873904248e9701f66459e074a4a8ab ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1152 From amitkumar at openjdk.org Mon Nov 18 14:04:33 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 18 Nov 2024 14:04:33 GMT Subject: [jdk21u-dev] Integrated: 8343506: [s390x] multiple test failures with ubsan In-Reply-To: <FSFXc1IQtmB9nkMolGGQGwnlgLqFpFSsC92hoMLHatU=.0d545267-9713-468b-866c-4cd4f4b78d0f@github.com> References: <FSFXc1IQtmB9nkMolGGQGwnlgLqFpFSsC92hoMLHatU=.0d545267-9713-468b-866c-4cd4f4b78d0f@github.com> Message-ID: <oj3eQJg3eSamVbCRpkfKNRUdu9lx-zpG0-ykBTg_wXg=.a251e539-e67d-4833-8ece-c34e9ddf5fec@github.com> On Mon, 18 Nov 2024 04:38:12 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > clean backport for [JDK-8343506](https://bugs.openjdk.org/browse/JDK-8343506) This pull request has now been integrated. Changeset: fe41d0a2 Author: Amit Kumar <amitkumar at openjdk.org> Committer: Martin Doerr <mdoerr at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/fe41d0a2e1e951c8f8a9e3842d3fe768f4fc604f Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8343506: [s390x] multiple test failures with ubsan Backport-of: f6edfe58d6931b058a5fec722615740818711065 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1157 From mbaesken at openjdk.org Mon Nov 18 14:05:27 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 18 Nov 2024 14:05:27 GMT Subject: [jdk21u-dev] Integrated: 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp In-Reply-To: <oXnw9oUMoM-QNz4l89lET2BEuka0v15o54h__uCFpW8=.ada1e3b0-517e-426d-8681-345990985251@github.com> References: <oXnw9oUMoM-QNz4l89lET2BEuka0v15o54h__uCFpW8=.ada1e3b0-517e-426d-8681-345990985251@github.com> Message-ID: <z5VZG29KhO75VwPqXBDfYpaCjOri2YUNT3UYJYNrcqM=.3bb7d556-4f95-403f-aacc-1f98cf5ea7bf@github.com> On Wed, 13 Nov 2024 13:37:49 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > clean after adding static to __ieee754_pow see 8252136 This pull request has now been integrated. Changeset: a4927ca5 Author: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/a4927ca550a4e508dad215c8cb948034af638693 Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp Reviewed-by: mdoerr Backport-of: 37cfaa8deb4cc15864bb6dc2c8a87fc97cff2f0d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1150 From mbaesken at openjdk.org Mon Nov 18 14:06:17 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 18 Nov 2024 14:06:17 GMT Subject: [jdk21u-dev] Integrated: 8336911: ZGC: Division by zero in heuristics after JDK-8332717 In-Reply-To: <dOdlx73EdQkwTvyIiklGPHiQ1mXn2A_jPgc3sQg78Rs=.0f5b0d8a-5942-4e7b-af3a-0c765e117e98@github.com> References: <dOdlx73EdQkwTvyIiklGPHiQ1mXn2A_jPgc3sQg78Rs=.0f5b0d8a-5942-4e7b-af3a-0c765e117e98@github.com> Message-ID: <thhfM6fPhrpIsNONZyHqanVtH1s0kRxx0MeiEHfgtu0=.8dff64ae-4505-4207-8697-aa70c91de6a4@github.com> On Wed, 13 Nov 2024 12:56:21 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8336911: ZGC: Division by zero in heuristics after JDK-8332717 This pull request has now been integrated. Changeset: f36b3b4c Author: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/f36b3b4c45e85d4501aab8850c2be79032c5dff7 Stats: 13 lines in 1 file changed: 13 ins; 0 del; 0 mod 8336911: ZGC: Division by zero in heuristics after JDK-8332717 Backport-of: 1cc32237aee03a38bfb0f6679f7328a682ad6ea9 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1149 From amitkumar at openjdk.org Mon Nov 18 14:06:18 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 18 Nov 2024 14:06:18 GMT Subject: [jdk21u-dev] Integrated: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java In-Reply-To: <FwgThfnyMw38TpSEqBkocsAWe5Y6TXTFDCEvtEMfqqI=.f8af1977-06ca-4f8a-98e0-e33bee62800b@github.com> References: <FwgThfnyMw38TpSEqBkocsAWe5Y6TXTFDCEvtEMfqqI=.f8af1977-06ca-4f8a-98e0-e33bee62800b@github.com> Message-ID: <nIBF6m0ot4Kk9ussw7PuKp0a9KVxiCOjXjRt_dXsHzU=.7dfcec26-5852-478d-b0cf-2bcccb415693@github.com> On Mon, 18 Nov 2024 04:57:46 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [3245f56e](https://github.com/openjdk/jdk/commit/3245f56e53792b3cfc9788799ba1594d6af15bea) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 15 Nov 2024 and was reviewed by Lutz Schmidt. > > Thanks! This pull request has now been integrated. Changeset: 4f6c5067 Author: Amit Kumar <amitkumar at openjdk.org> Committer: Martin Doerr <mdoerr at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/4f6c506793020c3d8f6b17feb4c7d7a5d29b920c Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java Backport-of: 3245f56e53792b3cfc9788799ba1594d6af15bea ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1158 From mbaesken at openjdk.org Mon Nov 18 14:07:52 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 18 Nov 2024 14:07:52 GMT Subject: [jdk21u-dev] Integrated: 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask' In-Reply-To: <UIpQJBRMmlWElkAE_ggABeWl2Kt4ifPwWiPHbJphPrU=.7876ac16-952c-429c-bd2e-a73914be2f99@github.com> References: <UIpQJBRMmlWElkAE_ggABeWl2Kt4ifPwWiPHbJphPrU=.7876ac16-952c-429c-bd2e-a73914be2f99@github.com> Message-ID: <fb3gaxsIYU7ZyAVYIqufdIASBaKVYnPkMNngwlUynKE=.385621e0-5a20-4995-af3f-9c3e53c8c8d0@github.com> On Wed, 13 Nov 2024 14:49:30 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask' This pull request has now been integrated. Changeset: b9c83b5d Author: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/b9c83b5d698e659d3de1f8e3a5dee56b9bbba510 Stats: 6 lines in 2 files changed: 2 ins; 2 del; 2 mod 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask' Backport-of: beff8bfe2a5334823b67cb748bc8652dc6a3f3d4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1151 From duke at openjdk.org Mon Nov 18 14:22:00 2024 From: duke at openjdk.org (HempushpaSahu) Date: Mon, 18 Nov 2024 14:22:00 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: <gORXCb2VEPgxwQMKoZJIGDS7QckVN_DD2H1snhT49Ws=.c3393191-419d-4e9e-a66d-25545ec1ff31@github.com> References: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> <LHiau4zB9uYZqg-kd8MXmd_PZBr4JlUtHoyPxro2nSA=.9949dde2-6f2b-494f-aed5-2468bb07ede6@github.com> <gORXCb2VEPgxwQMKoZJIGDS7QckVN_DD2H1snhT49Ws=.c3393191-419d-4e9e-a66d-25545ec1ff31@github.com> Message-ID: <HeqyooGlIDab0_O8eNgUZ9x9oqVYpKkjVCjLr35Hx4Q=.e4f1f27a-354f-4451-a85c-011c164b8a38@github.com> On Mon, 11 Nov 2024 18:50:30 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote: >> Pasting @GoeLin's question from #2754 here: >> >>> What happens if someone has set com.sun.security.crl.timeout and installs the update. Will that value be taken over to com.sun.security.ocsp.readtimeout, or will that fall back to 15s? > >> Pasting @GoeLin's question from #2754 here: >> >> > What happens if someone has set com.sun.security.crl.timeout and installs the update. Will that value be taken over to com.sun.security.ocsp.readtimeout, or will that fall back to 15s? > > Hi @GoeLin, you are right. The new "com.sun.security.ocsp.readtimeout" property is set independently of "com.sun.security.crl.timeout". In your case, it will fall back to the default 15s value. It changes current behavior. > I can update this logic to change the default read timeout to the "com.sun.security.crl.timeout" value. Hi @alexeybakhtin , I have tested the four backports mentioned above together, and they have passed successfully. Should we include these tests as part of the PR? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#issuecomment-2483177950 From goetz at openjdk.org Mon Nov 18 14:26:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 14:26:20 GMT Subject: [jdk21u-dev] RFR: 8325525: Create jtreg test case for JDK-8325203 Message-ID: <noWTQgalTvqWcFsJw6YHamBbqJkx2cP_GpVBCKz6cCQ=.15bdab31-06bf-4c71-9a8a-7a10c48c9351@github.com> I backport this for parity with 21.0.5-oracle. I include follow-up 8336315. Both are clean backports. Test passes on win. ------------- Commit messages: - Backport 8336315 - Backport 81a0d1ba03bbdbe718302b3925cdc207d5d05232 Changes: https://git.openjdk.org/jdk21u-dev/pull/1160/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1160&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325525 Stats: 129 lines in 2 files changed: 129 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1160.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1160/head:pull/1160 PR: https://git.openjdk.org/jdk21u-dev/pull/1160 From goetz at openjdk.org Mon Nov 18 14:36:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 14:36:27 GMT Subject: [jdk17u-dev] RFR: 8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils Message-ID: <FDH0-Fkj9BDzVGEvd4yz31tmm7msdXAEkK2IsBpoI_0=.d2a80f5e-0417-45b6-80b3-04bf485bb34f@github.com> I backport this for parity with 17.0.14-oracle. Applies clean, but FILE_SEPERATOR was already backported to Utils.java. Second commit removes redundant definition. ------------- Commit messages: - Resolve FILE_SEPARATOR in Utlis.java - Backport cc8bf95046d1fba0f88b0e17481f36b2be870659 Changes: https://git.openjdk.org/jdk17u-dev/pull/3050/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3050&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296718 Stats: 468 lines in 4 files changed: 231 ins; 234 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3050.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3050/head:pull/3050 PR: https://git.openjdk.org/jdk17u-dev/pull/3050 From kcr at openjdk.org Mon Nov 18 15:00:14 2024 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 18 Nov 2024 15:00:14 GMT Subject: [jdk21u-dev] RFR: 8325525: Create jtreg test case for JDK-8325203 In-Reply-To: <noWTQgalTvqWcFsJw6YHamBbqJkx2cP_GpVBCKz6cCQ=.15bdab31-06bf-4c71-9a8a-7a10c48c9351@github.com> References: <noWTQgalTvqWcFsJw6YHamBbqJkx2cP_GpVBCKz6cCQ=.15bdab31-06bf-4c71-9a8a-7a10c48c9351@github.com> Message-ID: <Pm9a-JkK_JbEX73KkPg-xro0tHufcYS1-wOwf-qhi_4=.fcad19b6-a11a-4801-9c4b-9a482f51ffed@github.com> On Mon, 18 Nov 2024 14:17:19 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.5-oracle. > > I include follow-up 8336315. > > Both are clean backports. Test passes on win. @GoeLin This PR should not list [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) as an additional issue, since that bug has already been backported to jdk21u-dev. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1160#issuecomment-2483295395 From szaldana at openjdk.org Mon Nov 18 15:16:00 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 18 Nov 2024 15:16:00 GMT Subject: [jdk21u-dev] Integrated: 8338389: [JFR] Long strings should be added to the string pool In-Reply-To: <7Ozip7X2S8TqCRAFmAkiTw4m6ANBM-oghgds44_ly8M=.73b107bb-4411-41ca-8a7c-d96cefc0caf5@github.com> References: <7Ozip7X2S8TqCRAFmAkiTw4m6ANBM-oghgds44_ly8M=.73b107bb-4411-41ca-8a7c-d96cefc0caf5@github.com> Message-ID: <D7uI9NHHJJyOIoaxrpnmUwZnqXT3e7itMaPcXoXrzfA=.d68bd41d-3563-4ee0-896c-47b857325f39@github.com> On Wed, 30 Oct 2024 15:26:27 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [d5c6158c](https://github.com/openjdk/jdk/commit/d5c6158cedfd96a9f97d83355b10730b81274648) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Joakim Nordstr?m on 27 Aug 2024 and was reviewed by Markus Gr?nlund. > > Thanks! This pull request has now been integrated. Changeset: 948710fb Author: Sonia Zaldana Calles <szaldana at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/948710fb048532e0432629ef90bd6f3298786569 Stats: 119 lines in 2 files changed: 116 ins; 0 del; 3 mod 8338389: [JFR] Long strings should be added to the string pool Backport-of: d5c6158cedfd96a9f97d83355b10730b81274648 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1109 From goetz at openjdk.org Mon Nov 18 15:26:00 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 15:26:00 GMT Subject: [jdk21u-dev] RFR: 8325525: Create jtreg test case for JDK-8325203 In-Reply-To: <Pm9a-JkK_JbEX73KkPg-xro0tHufcYS1-wOwf-qhi_4=.fcad19b6-a11a-4801-9c4b-9a482f51ffed@github.com> References: <noWTQgalTvqWcFsJw6YHamBbqJkx2cP_GpVBCKz6cCQ=.15bdab31-06bf-4c71-9a8a-7a10c48c9351@github.com> <Pm9a-JkK_JbEX73KkPg-xro0tHufcYS1-wOwf-qhi_4=.fcad19b6-a11a-4801-9c4b-9a482f51ffed@github.com> Message-ID: <ezIFelBjiQkA7ho3qF4jkTOQ1zwJ1qcvTE4HySDkbyo=.05921f79-e1ef-4247-ae0f-1e3722ea8f58@github.com> On Mon, 18 Nov 2024 14:57:30 GMT, Kevin Rushforth <kcr at openjdk.org> wrote: >> I backport this for parity with 21.0.5-oracle. >> >> I include follow-up 8336315. >> >> Both are clean backports. Test passes on win. > > @GoeLin This PR should not list [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) as an additional issue, since that bug has already been backported to jdk21u-dev. @kevinrushforth, thanks, I mistyped the bugid. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1160#issuecomment-2483362819 From syan at openjdk.org Mon Nov 18 15:42:02 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 18 Nov 2024 15:42:02 GMT Subject: [jdk17u-dev] RFR: 8207908: JMXStatusTest.java fails assertion intermittently In-Reply-To: <OcxCgF_eLcquDcAaG4hqRfkwpVvUNPbd-Lz2va5bndg=.a6da9517-15d7-4e8e-809c-8b751be6b33a@github.com> References: <OcxCgF_eLcquDcAaG4hqRfkwpVvUNPbd-Lz2va5bndg=.a6da9517-15d7-4e8e-809c-8b751be6b33a@github.com> Message-ID: <rTiB09lu3742BZh1XhvcLK7aZmu_PwqPXRZLaOwy120=.fa4908fb-2a17-47e5-8ec1-3af396d9a815@github.com> On Fri, 15 Nov 2024 09:46:19 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [b7d0eff5](https://github.com/openjdk/jdk/commit/b7d0eff5ad77e338b237773d2fc047eea3d2ac12) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer and Alex Menkov. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3042#issuecomment-2483406300 From syan at openjdk.org Mon Nov 18 15:42:02 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 18 Nov 2024 15:42:02 GMT Subject: [jdk17u-dev] Integrated: 8207908: JMXStatusTest.java fails assertion intermittently In-Reply-To: <OcxCgF_eLcquDcAaG4hqRfkwpVvUNPbd-Lz2va5bndg=.a6da9517-15d7-4e8e-809c-8b751be6b33a@github.com> References: <OcxCgF_eLcquDcAaG4hqRfkwpVvUNPbd-Lz2va5bndg=.a6da9517-15d7-4e8e-809c-8b751be6b33a@github.com> Message-ID: <b8PuBnz1G76zCBsruEaX2bpt2rK9DOvuki1Vz6MndEA=.7f1da0ce-dedb-4825-a897-b2732cd1e6a7@github.com> On Fri, 15 Nov 2024 09:46:19 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [b7d0eff5](https://github.com/openjdk/jdk/commit/b7d0eff5ad77e338b237773d2fc047eea3d2ac12) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer and Alex Menkov. > > Thanks! This pull request has now been integrated. Changeset: 6d7a6e13 Author: SendaoYan <syan at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/6d7a6e1378a9aeb7f4dd14bf0986b0f142356f3e Stats: 9 lines in 2 files changed: 1 ins; 2 del; 6 mod 8207908: JMXStatusTest.java fails assertion intermittently Backport-of: d0abff2f0745aa135cc9dbf6def4f260b634f107 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3042 From goetz at openjdk.org Mon Nov 18 16:01:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 16:01:57 GMT Subject: [jdk17u-dev] RFR: 8307297: Move some DnD tests to open Message-ID: <BwKUULw98oLzv48TgTs-yrzqx1xM9rp1vP8nVozmH8w=.a96a439d-c37c-4fa8-b0af-595ec48d8d74@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 3bf3876185f7b9e7679af3fa22ec20887cd4e498 Changes: https://git.openjdk.org/jdk17u-dev/pull/3052/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3052&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307297 Stats: 1233 lines in 7 files changed: 1233 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3052.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3052/head:pull/3052 PR: https://git.openjdk.org/jdk17u-dev/pull/3052 From goetz at openjdk.org Mon Nov 18 16:05:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 16:05:08 GMT Subject: [jdk17u-dev] RFR: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI Message-ID: <EtQJgJD22HNpApchLKtZByKtC9_Afu12n43EUQAOabg=.1afe9a20-8d4b-412e-a430-6ba972998cc6@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 02bce0b1452b804f3a7883ca8bf29a524b73672e Changes: https://git.openjdk.org/jdk17u-dev/pull/3053/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3053&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309532 Stats: 65 lines in 1 file changed: 51 ins; 1 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3053.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3053/head:pull/3053 PR: https://git.openjdk.org/jdk17u-dev/pull/3053 From goetz at openjdk.org Mon Nov 18 16:12:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 16:12:29 GMT Subject: [jdk17u-dev] RFR: 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic" Message-ID: <GTF1A_uNAbHl7r9F2VgwjUMU_9THCGWuzxP3Z8cNTKM=.26c126b4-743f-4f9e-8382-d77cc33b68b7@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 0fd807118c9b2cb8381b5c0f5d22d4e3451e8f10 Changes: https://git.openjdk.org/jdk17u-dev/pull/3054/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3054&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317738 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3054.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3054/head:pull/3054 PR: https://git.openjdk.org/jdk17u-dev/pull/3054 From mbaesken at openjdk.org Mon Nov 18 16:20:38 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 18 Nov 2024 16:20:38 GMT Subject: [jdk21u-dev] RFR: 8333144: docker tests do not work when ubsan is configured Message-ID: <K8yyNl_GTFDmFJT1aiBLC_VI_SnT_smBAjCwA3Gv5KA=.59955edf-ca30-4a03-8de7-3ffc27a81350@github.com> 8333144: docker tests do not work when ubsan is configured ------------- Commit messages: - Backport fbe8a81d1900d0de1920ad1df6ad574f3da4bd51 Changes: https://git.openjdk.org/jdk21u-dev/pull/1161/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1161&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333144 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1161.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1161/head:pull/1161 PR: https://git.openjdk.org/jdk21u-dev/pull/1161 From mdoerr at openjdk.org Mon Nov 18 16:28:04 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 18 Nov 2024 16:28:04 GMT Subject: [jdk21u-dev] Integrated: 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners In-Reply-To: <L9r2GC0mwEDl7AjAP9Nr-Wqke7TflyehASQNT02oUrg=.81832fc9-10f7-463a-989b-1663715e6d7a@github.com> References: <L9r2GC0mwEDl7AjAP9Nr-Wqke7TflyehASQNT02oUrg=.81832fc9-10f7-463a-989b-1663715e6d7a@github.com> Message-ID: <emkIn-FvGz6OPwVW9bPbJOs_vjM0q5rkwiEuaDO3Eh0=.c94cf0ee-1254-4103-b33d-08771c016a09@github.com> On Mon, 18 Nov 2024 11:05:19 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: > Clean backport of [JDK-8343923](https://bugs.openjdk.org/browse/JDK-8343923). Required because of https://github.com/actions/runner-images/issues/10703. Local build with Xcode 15.4 on a MacBook Pro M1 has worked. This pull request has now been integrated. Changeset: 4b1365ea Author: Martin Doerr <mdoerr at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/4b1365eaab151ecf5ff2c40e4292d93137499c06 Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners Backport-of: 4c5bc5f2f091ae861d5329cdae42fe7fa295544b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1159 From mdoerr at openjdk.org Mon Nov 18 16:29:10 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 18 Nov 2024 16:29:10 GMT Subject: [jdk17u-dev] Integrated: 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners In-Reply-To: <MMHwioQyodcsm7_39LX0ThfYR1PUA3UcP2kCNobTN3g=.bc28be47-5e29-4029-aa1b-7ae63bdd3ea6@github.com> References: <MMHwioQyodcsm7_39LX0ThfYR1PUA3UcP2kCNobTN3g=.bc28be47-5e29-4029-aa1b-7ae63bdd3ea6@github.com> Message-ID: <IjEyA3kBXhQ1L5Edx-r-o8nAi5x2d19aaYePJ9O-F5M=.019bd349-d3e0-4287-a85a-b561456e0023@github.com> On Mon, 18 Nov 2024 11:05:37 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: > Clean backport of [JDK-8343923](https://bugs.openjdk.org/browse/JDK-8343923). Required because of https://github.com/actions/runner-images/issues/10703. Local build with Xcode 15.4 on a MacBook Pro M1 has worked. This pull request has now been integrated. Changeset: 82a609dd Author: Martin Doerr <mdoerr at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/82a609dd7841eab66866e785ddd035b55d441970 Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners Backport-of: 4c5bc5f2f091ae861d5329cdae42fe7fa295544b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3048 From goetz at openjdk.org Mon Nov 18 16:32:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Nov 2024 16:32:34 GMT Subject: [jdk17u-dev] RFR: 8295344: Harden runtime/StackGuardPages/TestStackGuardPages.java Message-ID: <Xzr1NebiMi29-D5MkW5IMZWoTvcTbWdGyHf4qgCY_R8=.9fe47925-1e79-4fb1-ba42-f13b1a8b08e8@github.com> I backport this for parity with 17.0.13-oracle. Omitted ProblemList, as test is not problem listed in 17. ------------- Commit messages: - Backport /8c2c8b3f7f1bf286ca67a736938797d14fd7555c Changes: https://git.openjdk.org/jdk17u-dev/pull/3051/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3051&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295344 Stats: 151 lines in 3 files changed: 96 ins; 29 del; 26 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3051.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3051/head:pull/3051 PR: https://git.openjdk.org/jdk17u-dev/pull/3051 From duke at openjdk.org Mon Nov 18 17:22:22 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Mon, 18 Nov 2024 17:22:22 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result [v2] In-Reply-To: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> Message-ID: <iWOgQPKil7AjVh47ZTLNtvtupCh3MspP9smESOz8Ag0=.5f9b3ae8-a11f-436c-b681-bb0893476069@github.com> > Backport for https://bugs.openjdk.org/browse/JDK-8337066 > > When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. > > This is a clean backport. Radek ??p has updated the pull request incrementally with one additional commit since the last revision: Backport 93b2aa48598ef26f645e673ad111885d2acd18ef ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2961/files - new: https://git.openjdk.org/jdk11u-dev/pull/2961/files/9a976942..667b0f6a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2961&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2961&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2961.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2961/head:pull/2961 PR: https://git.openjdk.org/jdk11u-dev/pull/2961 From duke at openjdk.org Mon Nov 18 17:22:22 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Mon, 18 Nov 2024 17:22:22 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result In-Reply-To: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> Message-ID: <wWqjivD5UE5JNF_d9fh_B_fm8Oennv_FZiqyG4OKGLY=.22f8242f-e56e-4f62-b58e-70a6a0c8a846@github.com> On Fri, 8 Nov 2024 12:44:55 GMT, Radek ??p <duke at openjdk.org> wrote: > Backport for https://bugs.openjdk.org/browse/JDK-8337066 > > When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. > > This is a clean backport. @vieiro just pointed out that I need to update the code from this PR with this one - https://bugs.openjdk.org/browse/JDK-8343687 to make it compilable with "make run-tests ..." not just only passing with jtreg. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2483570096 From sgehwolf at openjdk.org Mon Nov 18 17:22:22 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 18 Nov 2024 17:22:22 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result In-Reply-To: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> Message-ID: <DEuSjmIk9D7d9yrf50wJfP2JVc-BwJYv6vyHpvll-Oo=.4c71cc1f-b0b3-4153-a938-547d9fad7255@github.com> On Fri, 8 Nov 2024 12:44:55 GMT, Radek ??p <duke at openjdk.org> wrote: > Backport for https://bugs.openjdk.org/browse/JDK-8337066 > > When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. > > This is a clean backport. > @vieiro just pointed me that I need to backport this first - https://bugs.openjdk.org/browse/JDK-8343687 @RadekCap I don't think that will work. What should work is adding [JDK-8343687](https://bugs.openjdk.org/browse/JDK-8343687) to this backport. I.e. cherry-pick the patch and use `/issue add JDK-8343687` on this PR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2483615503 From duke at openjdk.org Mon Nov 18 19:12:50 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 18 Nov 2024 19:12:50 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result [v2] In-Reply-To: <iWOgQPKil7AjVh47ZTLNtvtupCh3MspP9smESOz8Ag0=.5f9b3ae8-a11f-436c-b681-bb0893476069@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> <iWOgQPKil7AjVh47ZTLNtvtupCh3MspP9smESOz8Ag0=.5f9b3ae8-a11f-436c-b681-bb0893476069@github.com> Message-ID: <4Fzpr4RWwcuP12xTzNCJQ3roNmPABVX7exxhc1t_Xjs=.4b2322f1-644d-4664-ba47-5b58b50b6396@github.com> On Mon, 18 Nov 2024 17:22:22 GMT, Radek ??p <duke at openjdk.org> wrote: >> Backport for https://bugs.openjdk.org/browse/JDK-8337066 >> >> When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. >> >> This is a clean backport. > > Radek ??p has updated the pull request incrementally with one additional commit since the last revision: > > Backport 93b2aa48598ef26f645e673ad111885d2acd18ef > > @vieiro just pointed me that I need to backport this first - https://bugs.openjdk.org/browse/JDK-8343687 > > @RadekCap I don't think that will work. What should work is adding [JDK-8343687](https://bugs.openjdk.org/browse/JDK-8343687) to this backport. I.e. cherry-pick the patch and use `/issue add JDK-8343687` on this PR. > @vieiro just pointed out that I need to update the code from this PR with this one - https://bugs.openjdk.org/browse/JDK-8343687 to make it compilable with "make run-tests ..." not just only passing with jtreg. There's a slight difference between what @vieiro says and what people understand. But hey, I'm trying to improve :-) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2483890277 From abakhtin at openjdk.org Mon Nov 18 20:52:31 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 18 Nov 2024 20:52:31 GMT Subject: [jdk17u-dev] RFR: 8309740: Expand timeout windows for tests in JDK-8179502 Message-ID: <WQS8uq6Xj-dcM2hccYpen1cNzGUiDh26EjUVOxvUAEs=.147f78a2-0093-4956-8a57-077f33975187@github.com> Reviewed-by: xuelei, mbaesken Follow-up clean test backport for JDK-8179502 ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/2747 Commit messages: - 8309740: Expand timeout windows for tests in JDK-8179502 Changes: https://git.openjdk.org/jdk17u-dev/pull/3055/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3055&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309740 Stats: 21 lines in 3 files changed: 5 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3055.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3055/head:pull/3055 PR: https://git.openjdk.org/jdk17u-dev/pull/3055 From abakhtin at openjdk.org Mon Nov 18 21:12:49 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 18 Nov 2024 21:12:49 GMT Subject: [jdk17u-dev] RFR: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready Message-ID: <0BPQlfeW_nLAkuO98J7qMLHbIdQFghjCx1YAwjiRQHQ=.ae2340ce-88ce-4523-8234-44f67d66f2da@github.com> Follow-up clean test backport for JDK-8179502 (second in the series, applied after 8309740) ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/3055 Commit messages: - 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready Changes: https://git.openjdk.org/jdk17u-dev/pull/3056/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3056&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310629 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3056.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3056/head:pull/3056 PR: https://git.openjdk.org/jdk17u-dev/pull/3056 From abakhtin at openjdk.org Mon Nov 18 22:00:49 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 18 Nov 2024 22:00:49 GMT Subject: [jdk17u-dev] RFR: 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information Message-ID: <f6qhIo5ma5LqAPv5O5iqFI-xDj3bY89us5uY-n9lLDs=.6d2d1db9-880b-4692-951f-eabacfcb2738@github.com> Follow-up clean test backport for JDK-8179502 (third in the series, applied after 8310629) ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/3056 Commit messages: - 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information Changes: https://git.openjdk.org/jdk17u-dev/pull/3057/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3057&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325024 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3057.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3057/head:pull/3057 PR: https://git.openjdk.org/jdk17u-dev/pull/3057 From duke at openjdk.org Mon Nov 18 22:16:40 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 18 Nov 2024 22:16:40 GMT Subject: [jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 Message-ID: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions. The PR is separated in three commits for easier review: - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables: - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used) - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used). - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14). - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`). Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`. ------------- Commit messages: - xcode14: Use -Wno-deprecated-non-prototype to bypass passing arguments to a function without a prototype - xcode14: Use -Wno-deprecated-declarations to bypass sprintf deprecation - 8344458: [11u] Add conditional support for XCode 14 Changes: https://git.openjdk.org/jdk11u-dev/pull/2966/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2966&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344458 Stats: 37 lines in 10 files changed: 35 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2966.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2966/head:pull/2966 PR: https://git.openjdk.org/jdk11u-dev/pull/2966 From abakhtin at openjdk.org Mon Nov 18 22:24:21 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 18 Nov 2024 22:24:21 GMT Subject: [jdk17u-dev] RFR: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 Message-ID: <U0Mxx7m6CgIzVNbSMbPYppGosNB9FEsosSygxOC_Hy4=.0f3e89ee-262a-4b7c-b960-04292a6f2674@github.com> Follow-up clean test backport for JDK-8179502 (fourth in the series, applied after 8325024) ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/3057 Commit messages: - 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 Changes: https://git.openjdk.org/jdk17u-dev/pull/3058/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3058&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337826 Stats: 105 lines in 2 files changed: 46 ins; 24 del; 35 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3058.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3058/head:pull/3058 PR: https://git.openjdk.org/jdk17u-dev/pull/3058 From abakhtin at openjdk.org Mon Nov 18 22:32:52 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 18 Nov 2024 22:32:52 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts [v3] In-Reply-To: <A1ib3rtSqlN09KW41WuLickHFeJXWqIAKBAsBw-mIkk=.a9f75704-81f0-47dc-9271-1caa183a85a5@github.com> References: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> <A1ib3rtSqlN09KW41WuLickHFeJXWqIAKBAsBw-mIkk=.a9f75704-81f0-47dc-9271-1caa183a85a5@github.com> Message-ID: <pcAVQWKdXfK9Uc43b151JVdCQFVPYpTFxpjc5QXhbbs=.f0564f90-f6f9-4bb1-bbb1-9bde3d63d172@github.com> On Wed, 13 Nov 2024 18:30:32 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote: >> Hello, I'd like to backport JDK-8179502 to JDK17u to improve the timeout adjustment for OCSP GET requests (which was missed in JDK-8179503). >> >> The backport is almost clean except for the following: >> - OCSP.java was merged manually because of JDK-8328638 and JDK-8329213 is already backported into 17u-dev >> - copyright year in GetPropertyAction.java and URICertStore.java files are updated manually >> - CRLReadTimeout.java test is updated manually because of the different notation of internal X509CRLImpl and CRLExtensions classes. >> >> All new and related jtreg tests are passed > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > Remove unused DEFAULT_READ_TIMEOUT constant @franferrax , @HempushpaSahu, Thank you! I do not think it is possible to add other bug fixes to this PR, so I submitted dependent backport PRs for the mentioned test fixes: - [JDK-8309740](https://bugs.openjdk.org/browse/JDK-8309740), https://github.com/openjdk/jdk/commit/5ca4cdd2caceba9dad8025e5a8851740a3961921 - [JDK-8310629](https://bugs.openjdk.org/browse/JDK-8310629), https://github.com/openjdk/jdk/commit/b20dc1e9cda1ea3a76b3f14c778c6816e5cc1c0c - [JDK-8325024](https://bugs.openjdk.org/browse/JDK-8325024), https://github.com/openjdk/jdk/commit/432756b6e51c903e2bff8b9c3028a4f2ea8973f4 - [JDK-8337826](https://bugs.openjdk.org/browse/JDK-8337826), https://github.com/openjdk/jdk/commit/9b11bd7f4a511ddadf9f02e82aab6ba78beb6763 Backports are clean, so no review is required ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#issuecomment-2484267270 From abakhtin at openjdk.org Mon Nov 18 22:32:52 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 18 Nov 2024 22:32:52 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts [v2] In-Reply-To: <cIw3yZhzKI9YH-yvpRxwSDFAhQ_MN6jVfbJB8htSiSA=.8c2f6d7d-2a47-4897-afc4-40d2b92745d7@github.com> References: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> <qTK7M5627kV8iSAn5Oz-N9fLDHmIvLZPZWMzOI11h8k=.5855523b-f6ad-43f0-b0df-3f047a6783f1@github.com> <cdaBdlGTPG01yPrqZ6UHWfadfRsIWcX6E23Y84IlgmM=.570b746a-3284-4873-a0cc-a9a30e8b4eaf@github.com> <ouvoF62uGvFgyWP3XF_ZrrN4Sm5o5kC_sp6Q9ixtsKk=.5c0173a2-7219-4189-9b5f-fd211cbef405@github.com> <cIw3yZhzKI9YH-yvpRxwSDFAhQ_MN6jVfbJB8htSiSA=.8c2f6d7d-2a47-4897-afc4-40d2b92745d7@github.com> Message-ID: <HaXab1RzBmeE7Ck6hEt0VrohmiZfPTxXLQu_duZoN8A=.f7e90f68-1b18-496f-beae-a8a2b0938b32@github.com> On Thu, 14 Nov 2024 01:24:20 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote: >> Hi @franferrax >> Thank you for the finding. I'll remove `DEFAULT_READ_TIMEOUT` >> You are right, the CSR for update releases should be updated for `com.sun.security.ocsp.readtimeout` default value. I'll do it and ask you to review it from an engineering point of view. >> I hope in this way, without backward compatibility, the patch will be accepted. > > I will take a look, but please note I'm not a Reviewer. > > One more comment, I see that the following issues are not part of the backport. Although all of them are test-only changes (mostly tuning the timeout), we might also want to include these to avoid some instability. > > * [JDK-8309740](https://bugs.openjdk.org/browse/JDK-8309740 "Expand timeout windows for tests in JDK-8179502"), openjdk/jdk at 5ca4cdd2caceba9dad8025e5a8851740a3961921 > * [JDK-8310629](https://bugs.openjdk.org/browse/JDK-8310629 "java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready"), openjdk/jdk at b20dc1e9cda1ea3a76b3f14c778c6816e5cc1c0c > * [JDK-8325024](https://bugs.openjdk.org/browse/JDK-8325024 "java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information"), openjdk/jdk at 432756b6e51c903e2bff8b9c3028a4f2ea8973f4 > * [JDK-8337826](https://bugs.openjdk.org/browse/JDK-8337826 "Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754"), openjdk/jdk at 9b11bd7f4a511ddadf9f02e82aab6ba78beb6763 > > The last one is an ongoing effort to try to fix [JDK-8309754](https://bugs.openjdk.org/browse/JDK-8309754 "java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java failed with "Expected to pass, found 1 soft fail exceptions""), so we could alternatively wait for that fix and then make all the 5 backports together. Backport PRs are created for test fixes ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#discussion_r1847362520 From duke at openjdk.org Mon Nov 18 22:45:58 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 18 Nov 2024 22:45:58 GMT Subject: [jdk17u-dev] Integrated: 8332935: Crash: assert(*lastPtr != 0) failed: Mismatched JNINativeInterface tables, check for new entries In-Reply-To: <e5LFZGDIUuc_57g0TQTWcMs8zrkJWx9zCQpNBKMuipY=.89f48dad-b4fa-4176-aefb-78f3bd480f6a@github.com> References: <e5LFZGDIUuc_57g0TQTWcMs8zrkJWx9zCQpNBKMuipY=.89f48dad-b4fa-4176-aefb-78f3bd480f6a@github.com> Message-ID: <ZsZ9ry6atqQ-b4fo4ffCE9j9wSt_fShmZqZk55mZ1FU=.400c2641-8311-4518-9ecb-3c4f0dc545df@github.com> On Thu, 14 Nov 2024 14:26:11 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Backport of [JDK-8332935](https://bugs.openjdk.org/browse/JDK-8332935). This is a P2 issue that makes the JVM to crash in some situations, JDK-8332935 was difficult to track down (it happened by chance) so I think it's worth a backport. > > Backport is mostly clean but for a copyright change and low risk. Tier1 tests passed in Linux. This pull request has now been integrated. Changeset: d0949c82 Author: Antonio Vieiro <avieirov at redhat.com> Committer: Martin Doerr <mdoerr at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/d0949c82fd2eedc983e85fd86a9ce7d430e574a7 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8332935: Crash: assert(*lastPtr != 0) failed: Mismatched JNINativeInterface tables, check for new entries Backport-of: 90699828478fe0a1307ad68cc0cb368fe4db890e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3041 From duke at openjdk.org Mon Nov 18 22:56:14 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 18 Nov 2024 22:56:14 GMT Subject: [jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 In-Reply-To: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> References: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> Message-ID: <tb-KCmRDA-DwBxXmIO6o_Z4kX9UjD7gDA_AZV6Pavew=.e851ac44-5723-472e-921b-9363388349d2@github.com> On Mon, 18 Nov 2024 22:12:39 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions. > > The PR is separated in three commits for easier review: > > - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables: > - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used) > - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used). > - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14). > - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`). > > Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`. NOTE: [The GHA `macos-12` runners have been shut-down](https://github.com/actions/runner-images/issues/10721) between November 18, 14:00 UTC and November 19, 00:00 UTC and are currently unavailable. The tests will be re-run when again available. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2966#issuecomment-2484301422 From duke at openjdk.org Mon Nov 18 22:59:56 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 18 Nov 2024 22:59:56 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 Message-ID: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> An implementation of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) that bumps the GHA runners versions to `macos-13` and `XCode 14.3.1`. This uses the `--enable-xcode14` configuration flag introduced in https://github.com/openjdk/jdk11u-dev/pull/2966 ([JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458)) to build and run tier-1 tests on `macos-13` and `XCode 14.3.1`. Tier-1 tests seem to be failing randomly on macos-13/XCode14 with either a timeout or an ArrayIndexOutOfBoundsException t in serviceability/sa/ClhsdbFindPC.java. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). The rest of `tier1` tests are expected to pass on this platform. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/2966 Commit messages: - 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 Changes: https://git.openjdk.org/jdk11u-dev/pull/2967/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2967&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343786 Stats: 6 lines in 3 files changed: 1 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2967.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2967/head:pull/2967 PR: https://git.openjdk.org/jdk11u-dev/pull/2967 From abakhtin at openjdk.org Tue Nov 19 02:24:24 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 19 Nov 2024 02:24:24 GMT Subject: [jdk23u] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files Message-ID: <Ldr_iLJWxTxZw1DEhb0mjvfUnSsDgGHkahLvvzPMhTE=.0b68f6d9-3edc-4b89-96d1-1b0516e0ca7b@github.com> Please review the JAR tool enhancement. It allows suppressing the overwriting of existing files with a new cmd line option. The backport is almost clean except of src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java line 264 OptionType.EXTRACT was defined by JDK-8173970 but not backported to JDK23 yet. All related JTREG tests passed ------------- Commit messages: - Backport 158b93d19a518d2b9d3d185e2d4c4dbff9c82aab Changes: https://git.openjdk.org/jdk23u/pull/227/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=227&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335912 Stats: 528 lines in 5 files changed: 526 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk23u/pull/227.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/227/head:pull/227 PR: https://git.openjdk.org/jdk23u/pull/227 From duke at openjdk.org Tue Nov 19 06:53:45 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 19 Nov 2024 06:53:45 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v2] In-Reply-To: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> References: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> Message-ID: <vRaJoxxFcowxf5nbtYahm-VDoDWHu14WQKtdQaorHuA=.0c475032-1f03-4403-8cd6-f2568cb56266@github.com> > An implementation of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) that bumps the GHA runners versions to `macos-13` and `XCode 14.3.1`. > > This uses the `--enable-xcode14` configuration flag introduced in https://github.com/openjdk/jdk11u-dev/pull/2966 ([JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458)) to build and run tier-1 tests on `macos-13` and `XCode 14.3.1`. > > Tier-1 tests seem to be failing randomly on macos-13/XCode14 with either a timeout or an ArrayIndexOutOfBoundsException t in serviceability/sa/ClhsdbFindPC.java. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). > > The rest of `tier1` tests are expected to pass on this platform. Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2967/files - new: https://git.openjdk.org/jdk11u-dev/pull/2967/files/32101230..32101230 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2967&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2967&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2967.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2967/head:pull/2967 PR: https://git.openjdk.org/jdk11u-dev/pull/2967 From duke at openjdk.org Tue Nov 19 06:53:34 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 19 Nov 2024 06:53:34 GMT Subject: [jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v2] In-Reply-To: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> References: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> Message-ID: <VCSaGTA3DbZ7DLR8YADHQT0r0CFVC8gqXX-VNihJfGQ=.c40e70c5-3c2a-4d2e-b498-e89628d26047@github.com> > An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions. > > The PR is separated in three commits for easier review: > > - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables: > - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used) > - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used). > - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14). > - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`). > > Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`. Antonio Vieiro has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: xcode14: Use -Wno-deprecated-non-prototype to bypass passing arguments to a function without a prototype ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2966/files - new: https://git.openjdk.org/jdk11u-dev/pull/2966/files/17ab59d4..fec6eed5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2966&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2966&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2966.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2966/head:pull/2966 PR: https://git.openjdk.org/jdk11u-dev/pull/2966 From goetz at openjdk.org Tue Nov 19 07:22:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Nov 2024 07:22:06 GMT Subject: [jdk21u-dev] RFR: 8325525: Create jtreg test case for JDK-8325203 In-Reply-To: <noWTQgalTvqWcFsJw6YHamBbqJkx2cP_GpVBCKz6cCQ=.15bdab31-06bf-4c71-9a8a-7a10c48c9351@github.com> References: <noWTQgalTvqWcFsJw6YHamBbqJkx2cP_GpVBCKz6cCQ=.15bdab31-06bf-4c71-9a8a-7a10c48c9351@github.com> Message-ID: <nJVjlDnVJRcd6Fdz3Cy7ydXyjC_jA9QYm9dHpKp3XSg=.9ecd27b2-a195-4f2b-862e-16f474615cee@github.com> On Mon, 18 Nov 2024 14:17:19 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.5-oracle. > > I include follow-up 8336315. > > Both are clean backports. Test passes on win. GHA failure: infra issue, unrelated. Error: sh][ERROR] wget exited with exit code 4 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1160#issuecomment-2484875009 From duke at openjdk.org Tue Nov 19 07:45:48 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 19 Nov 2024 07:45:48 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v3] In-Reply-To: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> References: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> Message-ID: <mwBGWK2kQBgtX997f0pX6JgV2B4EwwUcPmq90j56_8M=.2e4c722a-ebac-49b5-bd32-e2f59ef4baf6@github.com> > An implementation of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) that bumps the GHA runners versions to `macos-13` and `XCode 14.3.1`. > > This uses the `--enable-xcode14` configuration flag introduced in https://github.com/openjdk/jdk11u-dev/pull/2966 ([JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458)) to build and run tier-1 tests on `macos-13` and `XCode 14.3.1`. > > Tier-1 tests seem to be failing randomly on macos-13/XCode14 with either a timeout or an ArrayIndexOutOfBoundsException t in serviceability/sa/ClhsdbFindPC.java. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). > > The rest of `tier1` tests are expected to pass on this platform. Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/2967/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2967&range=02 Stats: 6 lines in 3 files changed: 1 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2967.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2967/head:pull/2967 PR: https://git.openjdk.org/jdk11u-dev/pull/2967 From goetz.lindenmaier at sap.com Tue Nov 19 07:47:18 2024 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Tue, 19 Nov 2024 07:47:18 +0000 Subject: [17u notice]: no more enhancements Message-ID: <PAXPR02MB824563E4A9EEDAC80A0A5E84EC202@PAXPR02MB8245.eurprd02.prod.outlook.com> Dear updates maintainers, 21u is stable in OpenJDK for more than one year, and the next LTS, 25, is already coming up in less than a year. Thus I want to remind maintainers of the rules for eligible changes to 17. I will be more strict on approving changes to 17 in future. As this was very well written by Andrew Haley, I want to cite the mail of him addressing the topic for jdk11: --------------------------------------------------------------------------- In general, new features and performance improvements from later JDK releases will not be accepted. There may be exceptions in some cases, but they will be very unusual, perhaps in cases of gross performance problems on some systems. We'll address these as they arise. Any reasonable bug fix that improves the stability, security, or performance of JDK 11u (here: 17u) in a significant way should be considered. Bugs fitting into one or more of the following categories will usually be accepted for approval: CPU fix merges (i.e. critical security bugs) TZData updates Test fixes (and extra tests - more testing is always welcome!) Changes to root CACerts Changes to the build number Fixes specific to downstream builders' projects i18n / l10n changes In addition this list, we will consider Build system improvements, particularly for stability and reproducibility Changes necessary to make 11u work on new operating systems and hardware. See also https://mail.openjdk.org/pipermail/jdk-updates-dev/2021-October/009521.html. If you depend on a change not eligible to be backported to 17, look into moving to 21 or later! Best regards, Goetz -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://mail.openjdk.org/pipermail/jdk-updates-dev/attachments/20241119/fe0a5298/attachment-0001.htm> From goetz at openjdk.org Tue Nov 19 08:03:03 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Nov 2024 08:03:03 GMT Subject: [jdk17u-dev] RFR: 8321470: ThreadLocal.nextHashCode can be static final In-Reply-To: <_JxaKtFY6eq9xK7qbw7YkzzpdCoQKJ0FuoIy1GwpK10=.4b8c60a0-0cc6-42fc-ad60-6ea5237e786a@github.com> References: <_JxaKtFY6eq9xK7qbw7YkzzpdCoQKJ0FuoIy1GwpK10=.4b8c60a0-0cc6-42fc-ad60-6ea5237e786a@github.com> Message-ID: <nUZmod_XDNx9wkBTeTe2UGWgZDb0jdxVmRP-r7EB2kQ=.6c1c15cd-be0b-4c18-893c-aba493b73cc2@github.com> On Sat, 26 Oct 2024 23:46:17 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote: > Backporting JDK-8321470: ThreadLocal.nextHashCode can be static final. Minor change makes the variable final (it is already static). Patch is clean. Hi @satyenme I approved this backport, while I don't think it's a good change to be backported. In future, I will be more strict on approvals. See also https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-November/039331.html Best regards, Goetz. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3007#issuecomment-2484966148 From lucy at openjdk.org Tue Nov 19 08:12:50 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 19 Nov 2024 08:12:50 GMT Subject: [jdk21u-dev] RFR: 8325525: Create jtreg test case for JDK-8325203 In-Reply-To: <noWTQgalTvqWcFsJw6YHamBbqJkx2cP_GpVBCKz6cCQ=.15bdab31-06bf-4c71-9a8a-7a10c48c9351@github.com> References: <noWTQgalTvqWcFsJw6YHamBbqJkx2cP_GpVBCKz6cCQ=.15bdab31-06bf-4c71-9a8a-7a10c48c9351@github.com> Message-ID: <7ycjdAbSeSsELYj_PgqQARjbFJcdQi39KtHaxeaU69E=.6ffd3a4c-b630-4211-996f-c6a5f308ac58@github.com> On Mon, 18 Nov 2024 14:17:19 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.5-oracle. > > I include follow-up 8336315. > > Both are clean backports. Test passes on win. LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1160#pullrequestreview-2444661975 From lucy at openjdk.org Tue Nov 19 08:17:56 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 19 Nov 2024 08:17:56 GMT Subject: [jdk17u-dev] RFR: 8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils In-Reply-To: <FDH0-Fkj9BDzVGEvd4yz31tmm7msdXAEkK2IsBpoI_0=.d2a80f5e-0417-45b6-80b3-04bf485bb34f@github.com> References: <FDH0-Fkj9BDzVGEvd4yz31tmm7msdXAEkK2IsBpoI_0=.d2a80f5e-0417-45b6-80b3-04bf485bb34f@github.com> Message-ID: <REpTdrUURaHn_gdO3o5Ddf1imjmxQ7KLGsBdyX_kBR8=.17718ed3-d46c-4643-9422-d6900a155bb8@github.com> On Mon, 18 Nov 2024 14:32:02 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > Applies clean, but FILE_SEPERATOR was already backported to Utils.java. > Second commit removes redundant definition. LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3050#pullrequestreview-2444675503 From lucy at openjdk.org Tue Nov 19 09:17:01 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 19 Nov 2024 09:17:01 GMT Subject: [jdk17u-dev] RFR: 8295344: Harden runtime/StackGuardPages/TestStackGuardPages.java In-Reply-To: <Xzr1NebiMi29-D5MkW5IMZWoTvcTbWdGyHf4qgCY_R8=.9fe47925-1e79-4fb1-ba42-f13b1a8b08e8@github.com> References: <Xzr1NebiMi29-D5MkW5IMZWoTvcTbWdGyHf4qgCY_R8=.9fe47925-1e79-4fb1-ba42-f13b1a8b08e8@github.com> Message-ID: <M8cnXxaQaqhjpSuqeIq7OaPDxDbAv_ydZx8PbpTPKg8=.71333fdd-30d4-4130-b516-897440a3bec6@github.com> On Mon, 18 Nov 2024 15:46:49 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. > > Omitted ProblemList, as test is not problem listed in 17. Looks good. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3051#pullrequestreview-2444812232 From avieirov at redhat.com Tue Nov 19 10:02:49 2024 From: avieirov at redhat.com (Antonio Vieiro) Date: Tue, 19 Nov 2024 11:02:49 +0100 Subject: Keep jdk11 GHA runners on macosx? In-Reply-To: <122242ff-1e80-4362-bce6-87cdcd139097@redhat.com> References: <bc65d34f-2631-4aec-831c-e6988cb57719@redhat.com> <117d9f7a193522d7cad835148acd53bf63a73310.camel@redhat.com> <122242ff-1e80-4362-bce6-87cdcd139097@redhat.com> Message-ID: <f9d9dea5-3f7a-4045-9db0-fe83ca1ac3cd@redhat.com> Hi, Since the deprecation of `macos-12` runners is imminent I dared to do two quick PRs to try to workaround the builds on XCode 14. The first one [1] introduces a `--enable-xcode14` flag that has no effect on pre-XCode 12 builds (see [1] test results). This flag can then be used on XCode 14 builds (see [2]) to build & run tier-1 tests. Note that the objective is to at least build & run tests on XCode 14 only (i.e., running tier2 and later tiers is out of scope). Looking at it in perspective we may well drop this configuration flag and detect the XCode version directly, and make the build system adapt to it. Alternatively we may want to tackle about 4 backports for the sprintf deprecation [3] and the invocation of function pointers without prototypes in awtlib [4]. This is more risky, I think. Cheers, Antonio [1] https://github.com/openjdk/jdk11u-dev/pull/2966 [2] https://github.com/openjdk/jdk11u-dev/pull/2967 [3] 024-11-09T19:58:55.9236680Z In file included from /Users/runner/work/jdk11u-dev/jdk11u-dev/src/jdk.pack/share/native/common-unpack/bands.cpp:44: 2024-11-09T19:58:55.9324940Z /Users/runner/work/jdk11u-dev/jdk11u-dev/src/jdk.pack/share/native/common-unpack/unpack.h:421:52: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations] 2024-11-09T19:58:55.9328870Z Creating support/test/hotspot/jtreg/native/lib/libnativemethbind002.dylib from 1 file(s) 2024-11-09T19:58:56.0331530Z const char* saveIntStr(int num) { char buf[30]; sprintf(buf, "%d", num); return saveStr(buf); } 2024-11-09T19:58:56.0332970Z Creating support/test/hotspot/jtreg/native/lib/libnativemethbind003.dylib from 1 file(s) [4] 024-11-09T19:06:59.1104900Z gmake[2]: *** Waiting for unfinished jobs.... 2024-11-09T19:06:59.1531740Z Creating support/test/hotspot/jtreg/native/lib/libnosuspendStackTrace.dylib from 1 file(s) 2024-11-09T19:06:59.2544570Z Creating support/test/hotspot/jtreg/native/lib/librawmonitor.dylib from 1 file(s) 2024-11-09T19:06:59.3553310Z /Users/runner/work/jdk11u-dev/jdk11u-dev/src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c:430:43: error: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype] 2024-11-09T19:06:59.3558840Z Creating support/test/hotspot/jtreg/native/lib/libheapref.dylib from 1 file(s) 2024-11-09T19:06:59.4566920Z if ((*sMlibFns[MLIB_CONVKERNCVT].fptr)(kdata, &scale, dkern, w, h, El 15/11/24 a las 15:16, Antonio Vieiro escribi?: > Hi all, > > El 15/11/24 a las 13:41, Severin Gehwolf escribi?: >> Just to clarify: >> >> You are proposing to require macos-13 or better with XCode 14.3.1 or >> newer, for JDK 11u builds on macosx going forward? > > Not really. The proposal is to add a configuration flag ("--with-xcode14" or similar) so that: > > - Builds and tier-1 tests can be run in GHA: macos-13/XCode 14.3.1 > ? - By adding "-Wno-deprecated-declaration" to some .mk files to bypass the "sprintf" deprecation that is generating errors. > ? - By adding "-Wno-deprecated-non-prototype" to some .mk files to bypass sending arguments to functions without protype (AWTlib), that are generating errors too. > > If the "--with-xcode-14" configuration is _not_ present then builds are as usual, i.e., exising pipelines on macos-12 and earlier will run as usual. > >> >> If there is no way of building/running on older osx/xcode I guess there >> is no other choice but to set this as a requirement for building going >> forward? > > The flag is of interest only for doing GHA builds on XCode 14, as imposed by the deprecation of macos-12 GHA runners. > > So if you don't set the flag you can build as usual, on macos-12 and earlier, with older XCode versions. > >> >> It would be good to know what the community thinks. > > Yep. > > Cheers, > Antonio -- Antonio Vieiro SSE - Sustaining Engineering Red Hat, Inc. (https://www.redhat.com) PGP key : https://keys.openpgp.org/vks/v1/by-fingerprint/9A0CE286F22F7CCF2BC045FB1163A4EF861302B0 Fingerprint: 9A0C E286 F22F 7CCF 2BC0 45FB 1163 A4EF 8613 02B0 From sgehwolf at openjdk.org Tue Nov 19 11:39:50 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 19 Nov 2024 11:39:50 GMT Subject: [jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v2] In-Reply-To: <VCSaGTA3DbZ7DLR8YADHQT0r0CFVC8gqXX-VNihJfGQ=.c40e70c5-3c2a-4d2e-b498-e89628d26047@github.com> References: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> <VCSaGTA3DbZ7DLR8YADHQT0r0CFVC8gqXX-VNihJfGQ=.c40e70c5-3c2a-4d2e-b498-e89628d26047@github.com> Message-ID: <0BE17VixOijHPabl4YtDbsyVZ97ZdJOtAoalhlwCAQM=.62a33865-f873-4ac6-9abb-9da857b88c9e@github.com> On Tue, 19 Nov 2024 06:53:34 GMT, Antonio Vieiro <duke at openjdk.org> wrote: >> An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions. >> >> The PR is separated in three commits for easier review: >> >> - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables: >> - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used) >> - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used). >> - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14). >> - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`). >> >> Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`. > > Antonio Vieiro has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > xcode14: Use -Wno-deprecated-non-prototype to bypass passing arguments to a function without a prototype Seems OK to me. I'm not sure we need the doc fixes. doc/building.html line 317: > 315: </ul> > 316: <p>If you have recently (inadvertently) updated your OS and/or Xcode version, and the JDK can no longer be built, please see the section on <a href="#problems-with-the-build-environment">Problems with the Build Environment</a>, and <a href="#getting-help">Getting Help</a> to find out if there are any recent, non-merged patches available for this update.</p> > 317: <p>Experimental support for XCode 14 can be enabled using the <code>--enable-xcode14</code> configuration flag.</p> Please remove this. We don't usually update `doc/building.html` for every build change. doc/building.md line 359: > 357: > 358: Experimental support for XCode 14 can be enabled using the `--enable-xcode14` configuration flag. > 359: Same here. ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2966#pullrequestreview-2445175160 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2966#discussion_r1848178932 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2966#discussion_r1848179371 From sgehwolf at openjdk.org Tue Nov 19 11:46:03 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 19 Nov 2024 11:46:03 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result [v2] In-Reply-To: <iWOgQPKil7AjVh47ZTLNtvtupCh3MspP9smESOz8Ag0=.5f9b3ae8-a11f-436c-b681-bb0893476069@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> <iWOgQPKil7AjVh47ZTLNtvtupCh3MspP9smESOz8Ag0=.5f9b3ae8-a11f-436c-b681-bb0893476069@github.com> Message-ID: <MtNnLaODo6hKaH2CHAmh2wF6odeSfubewiv5Fkiktck=.18d0b5e4-a7c5-4749-872a-2fb03c83d052@github.com> On Mon, 18 Nov 2024 17:22:22 GMT, Radek ??p <duke at openjdk.org> wrote: >> Backport for https://bugs.openjdk.org/browse/JDK-8337066 >> >> When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. >> >> This is a clean backport. > > Radek ??p has updated the pull request incrementally with one additional commit since the last revision: > > Backport 93b2aa48598ef26f645e673ad111885d2acd18ef The test passes if the product code is reverted, but I see the same happened for the JDK 17 version. Only a few style issues to fix and this is good to go. src/hotspot/share/opto/gcm.cpp line 688: > 686: worklist_store.push(initial_mem); > 687: worklist_visited.push(initial_mem); > 688: worklist_mem.push(NULL); OK. The JDK 17u version has the `nullptr` vs `NULL` changes. Hence the patch is not deemed clean. test/hotspot/jtreg/compiler/controldependency/TestAntiDependencyForPinnedLoads.java line 44: > 42: if (!revStr.equals("?DD?MM?YYYY")) throw new InternalError("FAIL"); > 43: } > 44: } Style: The JDK 17u patch has 4 space indent instead of 2. Please don't add changes like that in a backport. Use the same indentation as the JDK 17u patch. ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2961#pullrequestreview-2445117981 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#discussion_r1848148650 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#discussion_r1848146806 From duke at openjdk.org Tue Nov 19 12:26:05 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Tue, 19 Nov 2024 12:26:05 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result [v3] In-Reply-To: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> Message-ID: <cARSx0TOpqpRDofHGcZyWpWSb6dMr-LY190iacO2zuQ=.df3ff00d-6b5f-42f9-bc01-8923fe65676b@github.com> > Backport for https://bugs.openjdk.org/browse/JDK-8337066 > > When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. > > This is a clean backport. Radek ??p has updated the pull request incrementally with one additional commit since the last revision: Fixed indentation. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2961/files - new: https://git.openjdk.org/jdk11u-dev/pull/2961/files/667b0f6a..4b57a7db Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2961&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2961&range=01-02 Stats: 8 lines in 1 file changed: 1 ins; 1 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2961.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2961/head:pull/2961 PR: https://git.openjdk.org/jdk11u-dev/pull/2961 From duke at openjdk.org Tue Nov 19 12:36:05 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Tue, 19 Nov 2024 12:36:05 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result [v2] In-Reply-To: <MtNnLaODo6hKaH2CHAmh2wF6odeSfubewiv5Fkiktck=.18d0b5e4-a7c5-4749-872a-2fb03c83d052@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> <iWOgQPKil7AjVh47ZTLNtvtupCh3MspP9smESOz8Ag0=.5f9b3ae8-a11f-436c-b681-bb0893476069@github.com> <MtNnLaODo6hKaH2CHAmh2wF6odeSfubewiv5Fkiktck=.18d0b5e4-a7c5-4749-872a-2fb03c83d052@github.com> Message-ID: <AArNlusZjCtfHoonpImVNo6knbJoFAvgTyHI5E0w3xU=.4b6de1f6-7624-4b88-b564-ea59a6ed0b8a@github.com> On Tue, 19 Nov 2024 11:09:22 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote: >> Radek ??p has updated the pull request incrementally with one additional commit since the last revision: >> >> Backport 93b2aa48598ef26f645e673ad111885d2acd18ef > > src/hotspot/share/opto/gcm.cpp line 688: > >> 686: worklist_store.push(initial_mem); >> 687: worklist_visited.push(initial_mem); >> 688: worklist_mem.push(NULL); > > OK. The JDK 17u version has the `nullptr` vs `NULL` changes. Hence the patch is not deemed clean. I see, thank you. Is there anything expected from me here (like removing "This is a clean backport." from the original comment) or is it just for me to know? > test/hotspot/jtreg/compiler/controldependency/TestAntiDependencyForPinnedLoads.java line 44: > >> 42: if (!revStr.equals("?DD?MM?YYYY")) throw new InternalError("FAIL"); >> 43: } >> 44: } > > Style: The JDK 17u patch has 4 space indent instead of 2. Please don't add changes like that in a backport. Use the same indentation as the JDK 17u patch. Fixed by https://github.com/openjdk/jdk11u-dev/pull/2961/commits/4b57a7db4935f1277cb584bdaff27781ce085866 ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#discussion_r1848278348 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#discussion_r1848273188 From duke at openjdk.org Tue Nov 19 12:39:58 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 19 Nov 2024 12:39:58 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v3] In-Reply-To: <mwBGWK2kQBgtX997f0pX6JgV2B4EwwUcPmq90j56_8M=.2e4c722a-ebac-49b5-bd32-e2f59ef4baf6@github.com> References: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> <mwBGWK2kQBgtX997f0pX6JgV2B4EwwUcPmq90j56_8M=.2e4c722a-ebac-49b5-bd32-e2f59ef4baf6@github.com> Message-ID: <YohNGclT_n8fbYVfPRwTLu5ievwG0vmYtcF2w4e0aAU=.41ce1cd1-8b4a-4d5f-a084-f514298d83d5@github.com> On Tue, 19 Nov 2024 07:45:48 GMT, Antonio Vieiro <duke at openjdk.org> wrote: >> An implementation of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) that bumps the GHA runners versions to `macos-13` and `XCode 14.3.1`. >> >> This uses the `--enable-xcode14` configuration flag introduced in https://github.com/openjdk/jdk11u-dev/pull/2966 ([JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458)) to build and run tier-1 tests on `macos-13` and `XCode 14.3.1`. >> >> Tier-1 tests seem to be failing randomly on macos-13/XCode14 with either a timeout or an ArrayIndexOutOfBoundsException t in serviceability/sa/ClhsdbFindPC.java. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). >> >> The rest of `tier1` tests are expected to pass on this platform. > > Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 As expected, all `tier1` tests pass with `XCode 14` but for `ClhsdbFindPC`, that fails with a timeout. Suspect is [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) that will require investigation (intermittent). 2024-11-19T08:29:29.3416570Z java.lang.RuntimeException: Test ERROR java.io.IOException: App waiting timeout 2024-11-19T08:29:29.3418220Z at ClhsdbFindPC.testFindPC(ClhsdbFindPC.java:155) Attaching excerpt of the build log for future reference: [xcode14-build-failure.txt](https://github.com/user-attachments/files/17815022/xcode14-build-failure.txt) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2967#issuecomment-2485600341 From sgehwolf at openjdk.org Tue Nov 19 13:29:53 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 19 Nov 2024 13:29:53 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result [v3] In-Reply-To: <cARSx0TOpqpRDofHGcZyWpWSb6dMr-LY190iacO2zuQ=.df3ff00d-6b5f-42f9-bc01-8923fe65676b@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> <cARSx0TOpqpRDofHGcZyWpWSb6dMr-LY190iacO2zuQ=.df3ff00d-6b5f-42f9-bc01-8923fe65676b@github.com> Message-ID: <F23U4Th3So26QP37i3ypgiEhQ49X3XG91VKcFTlpnI0=.4cc1c2f9-d170-40ab-bae2-da4c02a13cc7@github.com> On Tue, 19 Nov 2024 12:26:05 GMT, Radek ??p <duke at openjdk.org> wrote: >> Backport for https://bugs.openjdk.org/browse/JDK-8337066 >> >> When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. >> >> This is a clean backport. > > Radek ??p has updated the pull request incrementally with one additional commit since the last revision: > > Fixed indentation. Apparently this is caused by a backport of [JDK-8242115](https://bugs.openjdk.org/browse/JDK-8242115) which is not in 11u (unlike 17), so I wonder if we need it. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2485711432 From duke at openjdk.org Tue Nov 19 14:08:39 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 19 Nov 2024 14:08:39 GMT Subject: [jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v3] In-Reply-To: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> References: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> Message-ID: <x3HsZv4qmSYA8PuYkxSzpOB9xDPyYEKcu-ispJXNkU8=.d7ac8df1-6377-446c-8223-754c98b240a9@github.com> > An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions. > > The PR is separated in three commits for easier review: > > - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables: > - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used) > - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used). > - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14). > - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`). > > Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`. Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: Removed doc instructions as per review ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2966/files - new: https://git.openjdk.org/jdk11u-dev/pull/2966/files/fec6eed5..0a5ecb00 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2966&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2966&range=01-02 Stats: 3 lines in 2 files changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2966.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2966/head:pull/2966 PR: https://git.openjdk.org/jdk11u-dev/pull/2966 From duke at openjdk.org Tue Nov 19 14:08:42 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 19 Nov 2024 14:08:42 GMT Subject: [jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v2] In-Reply-To: <0BE17VixOijHPabl4YtDbsyVZ97ZdJOtAoalhlwCAQM=.62a33865-f873-4ac6-9abb-9da857b88c9e@github.com> References: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> <VCSaGTA3DbZ7DLR8YADHQT0r0CFVC8gqXX-VNihJfGQ=.c40e70c5-3c2a-4d2e-b498-e89628d26047@github.com> <0BE17VixOijHPabl4YtDbsyVZ97ZdJOtAoalhlwCAQM=.62a33865-f873-4ac6-9abb-9da857b88c9e@github.com> Message-ID: <eVJkZfq_6GFghSRVEJ-0FyMlFnd0ofl8HKPVUAbdSZw=.eb92d07b-9a83-434b-8548-99297570480f@github.com> On Tue, 19 Nov 2024 11:32:01 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote: >> Antonio Vieiro has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: >> >> xcode14: Use -Wno-deprecated-non-prototype to bypass passing arguments to a function without a prototype > > doc/building.html line 317: > >> 315: </ul> >> 316: <p>If you have recently (inadvertently) updated your OS and/or Xcode version, and the JDK can no longer be built, please see the section on <a href="#problems-with-the-build-environment">Problems with the Build Environment</a>, and <a href="#getting-help">Getting Help</a> to find out if there are any recent, non-merged patches available for this update.</p> >> 317: <p>Experimental support for XCode 14 can be enabled using the <code>--enable-xcode14</code> configuration flag.</p> > > Please remove this. We don't usually update `doc/building.html` for every build change. Removed in last commit > doc/building.md line 359: > >> 357: >> 358: Experimental support for XCode 14 can be enabled using the `--enable-xcode14` configuration flag. >> 359: > > Same here. Removed in last commit. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2966#discussion_r1848427918 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2966#discussion_r1848428213 From duke at openjdk.org Tue Nov 19 15:07:02 2024 From: duke at openjdk.org (sophia-guo) Date: Tue, 19 Nov 2024 15:07:02 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 In-Reply-To: <xuQV80Qh4F1ptKnmKUrFYOmW5R1mPczuScNRLjQzgNc=.b9b479d7-f1aa-474c-a8a4-8240118e01db@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> <NURrOIkUuQUm2ZFsmb-8QvM4Ex0_P6_DH7eRWOFhsnw=.83d8cc8f-7966-480c-965b-cc90d73264b5@github.com> <xuQV80Qh4F1ptKnmKUrFYOmW5R1mPczuScNRLjQzgNc=.b9b479d7-f1aa-474c-a8a4-8240118e01db@github.com> Message-ID: <DFGBi1dO5gseeKSFtG6ihVtTQwkzjZzz8NL3xBcRtO4=.e25bc815-7f4f-4aee-9b24-511da39234b4@github.com> On Mon, 18 Nov 2024 13:59:18 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote: >> Just confirm that the GHA action should have been enabled. > >> Just confirm that the GHA action should have been enabled. > > Yes, but this PR doesn't show them as being run. I.e. it's 1. enable GHA testing. 2. trigger GHA testing. You've done 1. but not 2. > > Example PR with GHA checks being run is here: https://github.com/openjdk/jdk21u-dev/pull/1143 > > It has `19 successful checks`. Yours has `2 successful checks`. @jerboaa I believe I don't have permission to manually trigger GHA testing with the GH UI in this repo? Actions tab is invisible to me and I can't do the rerun workflow. Or I'm checking the wrong way? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1100#issuecomment-2485968496 From sgehwolf at openjdk.org Tue Nov 19 15:26:12 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 19 Nov 2024 15:26:12 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 In-Reply-To: <xuQV80Qh4F1ptKnmKUrFYOmW5R1mPczuScNRLjQzgNc=.b9b479d7-f1aa-474c-a8a4-8240118e01db@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> <NURrOIkUuQUm2ZFsmb-8QvM4Ex0_P6_DH7eRWOFhsnw=.83d8cc8f-7966-480c-965b-cc90d73264b5@github.com> <xuQV80Qh4F1ptKnmKUrFYOmW5R1mPczuScNRLjQzgNc=.b9b479d7-f1aa-474c-a8a4-8240118e01db@github.com> Message-ID: <B_0eKYKI-CnOUaQuZ3MPo4IrV9fl8TRIv8QcSavcbRg=.ce175cd3-c730-4b3d-ae84-7f76a3d6d0fa@github.com> On Mon, 18 Nov 2024 13:59:18 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote: >> Just confirm that the GHA action should have been enabled. > >> Just confirm that the GHA action should have been enabled. > > Yes, but this PR doesn't show them as being run. I.e. it's 1. enable GHA testing. 2. trigger GHA testing. You've done 1. but not 2. > > Example PR with GHA checks being run is here: https://github.com/openjdk/jdk21u-dev/pull/1143 > > It has `19 successful checks`. Yours has `2 successful checks`. > @jerboaa I believe I don't have permission to manually trigger GHA testing with the GH UI in this repo? Actions tab is invisible to me and I can't do the rerun workflow. Or I'm checking the wrong way? I don't remember where exactly the manual run trigger is (it's there somewhere). Merging latest master into your branch and pushing it should trigger it too (i.e. should be automatic for the next backport): git checkout master git pull https://github.com/openjdk/jdk21u-dev master git checkout 8333248-backport-9b0a5c5c git merge master git push origin HEAD ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1100#issuecomment-2486016547 From syan at openjdk.org Tue Nov 19 15:30:08 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 19 Nov 2024 15:30:08 GMT Subject: [jdk17u-dev] RFR: 8336257: Additional tests in jmxremote/startstop to match on PID not app name Message-ID: <yra7M13ESSoAlsk2k8MsWxE-GXR5Cebckkve-lo8Wfs=.6bfa80a4-2c02-48c4-8ff3-b3bf3618057f@github.com> Hi all, This pull request contains a backport of commit [687601eb](https://github.com/openjdk/jdk/commit/687601ebcaedf133fd4d5cecc42c5aadf9c73f3c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer, Alan Bateman, Alex Menkov and Daniel D. Daugherty. Thanks! ------------- Commit messages: - Backport 5b1a9521de45394817aa36dbf007e69a60c92604 Changes: https://git.openjdk.org/jdk17u-dev/pull/3060/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3060&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336257 Stats: 6 lines in 2 files changed: 2 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3060.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3060/head:pull/3060 PR: https://git.openjdk.org/jdk17u-dev/pull/3060 From henryjen at openjdk.org Tue Nov 19 15:56:17 2024 From: henryjen at openjdk.org (Henry Jen) Date: Tue, 19 Nov 2024 15:56:17 GMT Subject: [jdk23u] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: <Ldr_iLJWxTxZw1DEhb0mjvfUnSsDgGHkahLvvzPMhTE=.0b68f6d9-3edc-4b89-96d1-1b0516e0ca7b@github.com> References: <Ldr_iLJWxTxZw1DEhb0mjvfUnSsDgGHkahLvvzPMhTE=.0b68f6d9-3edc-4b89-96d1-1b0516e0ca7b@github.com> Message-ID: <5Fsd63CNusFWqb5KS4kRYDlcTG1ltBr6iU3ZX5Eg1iY=.12ee37e8-2ba9-4f9c-ab7d-24e32bedce6b@github.com> On Tue, 19 Nov 2024 02:19:31 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote: > Please review the JAR tool enhancement. > It allows suppressing the overwriting of existing files with a new cmd line option. > The backport is almost clean except of src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java line 264 > OptionType.EXTRACT was defined by JDK-8173970 but not backported to JDK23 yet. > > All related JTREG tests passed Marked as reviewed by henryjen (Committer). ------------- PR Review: https://git.openjdk.org/jdk23u/pull/227#pullrequestreview-2445900218 From mdoerr at openjdk.org Tue Nov 19 16:37:40 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 19 Nov 2024 16:37:40 GMT Subject: [jdk17u-dev] RFR: 8342607: Enhance register printing on x86_64 platforms Message-ID: <UkmARLM1OQiHuX1MZB_W_CATUgpOvpxhNSbgk0CH610=.bf8d5b44-3eda-4e0f-bbfe-ec282a10696b@github.com> Clean backport of [JDK-8342607](https://bugs.openjdk.org/browse/JDK-8342607). ------------- Commit messages: - Backport 1bfb57dca4a65ea64a15914b1e8b5c4c509db6f5 Changes: https://git.openjdk.org/jdk17u-dev/pull/3061/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3061&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342607 Stats: 37 lines in 3 files changed: 36 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3061.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3061/head:pull/3061 PR: https://git.openjdk.org/jdk17u-dev/pull/3061 From duke at openjdk.org Tue Nov 19 16:56:03 2024 From: duke at openjdk.org (sophia-guo) Date: Tue, 19 Nov 2024 16:56:03 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 [v2] In-Reply-To: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> Message-ID: <rxBVBiEJcpTyE4H4vcon5K--3twiegXQymwKH65FouQ=.8c48d178-920f-4d74-a610-722e884ce41e@github.com> > Hi, I would like to backport[ 8333248](https://bugs.openjdk.org/browse/JDK-8333248) to jdk21u. As [JDK-8325520](https://bugs.openjdk.org/browse/JDK-8325520) was also backported to 21 so the test now fails on risc-v there. sophia-guo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into 8333248-backport-9b0a5c5c - Backport 9b0a5c5cd056262fab99525e9260762b617152a3 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1100/files - new: https://git.openjdk.org/jdk21u-dev/pull/1100/files/7db718cb..12a6731e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1100&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1100&range=00-01 Stats: 17914 lines in 415 files changed: 13838 ins; 1406 del; 2670 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1100.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1100/head:pull/1100 PR: https://git.openjdk.org/jdk21u-dev/pull/1100 From duke at openjdk.org Tue Nov 19 17:06:03 2024 From: duke at openjdk.org (sophia-guo) Date: Tue, 19 Nov 2024 17:06:03 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 In-Reply-To: <B_0eKYKI-CnOUaQuZ3MPo4IrV9fl8TRIv8QcSavcbRg=.ce175cd3-c730-4b3d-ae84-7f76a3d6d0fa@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> <NURrOIkUuQUm2ZFsmb-8QvM4Ex0_P6_DH7eRWOFhsnw=.83d8cc8f-7966-480c-965b-cc90d73264b5@github.com> <xuQV80Qh4F1ptKnmKUrFYOmW5R1mPczuScNRLjQzgNc=.b9b479d7-f1aa-474c-a8a4-8240118e01db@github.com> <B_0eKYKI-CnOUaQuZ3MPo4IrV9fl8TRIv8QcSavcbRg=.ce175cd3-c730-4b3d-ae84-7f76a3d6d0fa@github.com> Message-ID: <HeIrcOk3y3KH0bWT2UJ7rsoCYyrOsqVSMA6e7B7mxC0=.240da825-3b0e-49e8-b9c0-84e9efcc255e@github.com> On Tue, 19 Nov 2024 15:22:17 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote: >>> Just confirm that the GHA action should have been enabled. >> >> Yes, but this PR doesn't show them as being run. I.e. it's 1. enable GHA testing. 2. trigger GHA testing. You've done 1. but not 2. >> >> Example PR with GHA checks being run is here: https://github.com/openjdk/jdk21u-dev/pull/1143 >> >> It has `19 successful checks`. Yours has `2 successful checks`. > >> @jerboaa I believe I don't have permission to manually trigger GHA testing with the GH UI in this repo? Actions tab is invisible to me and I can't do the rerun workflow. Or I'm checking the wrong way? > > I don't remember where exactly the manual run trigger is (it's there somewhere). Merging latest master into your branch and pushing it should trigger it too (i.e. should be automatic for the next backport): > > > git checkout master > git pull https://github.com/openjdk/jdk21u-dev master > git checkout 8333248-backport-9b0a5c5c > git merge master > git push origin HEAD Thanks @jerboaa ! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1100#issuecomment-2486270772 From cushon at openjdk.org Tue Nov 19 17:09:19 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 19 Nov 2024 17:09:19 GMT Subject: [jdk11u-dev] RFR: 8273914: Indy string concat changes order of operations [v4] In-Reply-To: <48_6CiXhu6kGwSLVNcSEC9X5wi7rc6JOMY2CaEJ1yu4=.bbf55ed2-ef95-413c-a4d9-85f3b386778c@github.com> References: <48_6CiXhu6kGwSLVNcSEC9X5wi7rc6JOMY2CaEJ1yu4=.bbf55ed2-ef95-413c-a4d9-85f3b386778c@github.com> Message-ID: <Tx6K7vnqYlK-ETW4-kUYRcVwCiKdraL2NqmR8J4-RRE=.18c0e6a3-2c3f-45d0-bae0-9e5c8d7320be@github.com> > This is a backport of [JDK-8273914: Indy string concat changes order of operations](https://bugs.openjdk.org/browse/JDK-8273914). > > The patch applied cleanly. I downgrade the class file major version in the `.jasm` test inputs for compatibility with JDK 11. > > Testing: tier1 langtools tests Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge remote-tracking branch 'upstream/master' into backport-JDK-8273914 - Downgrade major version for jasm test inputs - Merge remote-tracking branch 'upstream/master' into backport-JDK-8273914 - Backport cfee4512f7048e9cf440078e9eb87d37c7ebcdd9 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2933/files - new: https://git.openjdk.org/jdk11u-dev/pull/2933/files/cd858cfa..a57aad56 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2933&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2933&range=02-03 Stats: 302 lines in 16 files changed: 142 ins; 52 del; 108 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2933.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2933/head:pull/2933 PR: https://git.openjdk.org/jdk11u-dev/pull/2933 From mdoerr at openjdk.org Tue Nov 19 17:25:44 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 19 Nov 2024 17:25:44 GMT Subject: [jdk17u-dev] RFR: 8342607: Enhance register printing on x86_64 platforms [v2] In-Reply-To: <UkmARLM1OQiHuX1MZB_W_CATUgpOvpxhNSbgk0CH610=.bf8d5b44-3eda-4e0f-bbfe-ec282a10696b@github.com> References: <UkmARLM1OQiHuX1MZB_W_CATUgpOvpxhNSbgk0CH610=.bf8d5b44-3eda-4e0f-bbfe-ec282a10696b@github.com> Message-ID: <uM23IARtt6_sGzICrmteZMHCJt9k9foQ3_O4naAO2Fk=.ee334aa5-f7fe-4f00-ba8b-293c2211e0fe@github.com> > Clean backport of [JDK-8342607](https://bugs.openjdk.org/browse/JDK-8342607) plus small part of https://github.com/openjdk/jdk/commit/98ce45ff7432a56d73b51046817b5fe84a412042 (2nd commit, may help other backports, too). Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: Add small part of JDK-8292981. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3061/files - new: https://git.openjdk.org/jdk17u-dev/pull/3061/files/dad1c36c..5ad2abc9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3061&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3061&range=00-01 Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3061.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3061/head:pull/3061 PR: https://git.openjdk.org/jdk17u-dev/pull/3061 From goetz at openjdk.org Tue Nov 19 17:53:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Nov 2024 17:53:27 GMT Subject: [jdk21u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b Message-ID: <tiZYiBW8uJmweGNIrgmRNm_iqLTU-xNSSa_hIZyJUzY=.036e2ca2-54d0-413d-9c9e-65e6c03814c3@github.com> I backport this for parity with 21.0.6-oracle. The documentation of the tz update says that it is not needed necessarily, but a cleanup of various information. I think we should go along here. It seems to bring a row of visible changes, and it's good if this can be mapped to the same update everywhere. Also, this will simplify later tz updates, which happen regularly. CSR for update versions available. This is a Backport of the [jdk23u version](https://github.com/openjdk/jdk23u/commit/73b2341c670f98fb130c57f80eb1461226da1985), as the [jdk24 version](https://github.com/openjdk/jdk/commit/ebc17c7c8d6febd5a887309d1b7a466bcd2cc0a9) contains changes breaking the Java standard. As I understand this only affects Java 8. But Oracle avoided to bring these changes to 23, so we should not do that in 21, either. In detail, the 23u version omits backport of changes to src/java.base/share/classes/java/time/ZoneId.java and src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java. In the tests changes to test/jdk/java/time/tck/java/time/TCKZoneId.java and test/jdk/java/util/TimeZone/OldIDMappingTest.java are omited, and test/jdk/sun/util/calendar/zi/TestZoneInfo310.java is modified differently. File test/jdk/sun/util/calendar/zi/tzdata_jdk/tz2024b_overridden_zones is added in 23. The change to test/jdk/sun/util/resources/TimeZone/Bug4848242.java differs, too. **Needed adaptions:** I had to resolve java/text/Format/DateFormat/TimeZoneNameTest.java. But the new version breaks the test. I assume this is because 21 does not have "[8174269](https://bugs.openjdk.org/browse/JDK-8174269): Remove COMPAT locale data provider from JDK". The original version of the test passes. test/jdk/sun/util/resources/TimeZone/Bug4848242.java is failing, too. The original version works, reverted. Further I reverted test/jdk/java/util/TimeZone/TimeZoneData/aliases.txt and .../displaynames.txt as else java/util/TimeZone/Bug6329116.java (unmodified) starts failing. See extra commits seperating out these edits. ------------- Commit messages: - Add back Ulanbator link to test data file - Add file missed - Revert some test changes to make tests pass - Resolved one file because 8174296 is not in 21 - Backport 73b2341c670f98fb130c57f80eb1461226da1985 Changes: https://git.openjdk.org/jdk21u-dev/pull/1143/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1143&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339637 Stats: 1316 lines in 16 files changed: 400 ins; 60 del; 856 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1143.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1143/head:pull/1143 PR: https://git.openjdk.org/jdk21u-dev/pull/1143 From andrew at openjdk.org Tue Nov 19 17:53:27 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 19 Nov 2024 17:53:27 GMT Subject: [jdk21u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <tiZYiBW8uJmweGNIrgmRNm_iqLTU-xNSSa_hIZyJUzY=.036e2ca2-54d0-413d-9c9e-65e6c03814c3@github.com> References: <tiZYiBW8uJmweGNIrgmRNm_iqLTU-xNSSa_hIZyJUzY=.036e2ca2-54d0-413d-9c9e-65e6c03814c3@github.com> Message-ID: <CnsT-iCbqMUk0tWGSXhSFX7lyu0zYp6ywoHQiQWBF84=.6d767ba8-305c-44f2-a778-8b22bc8abc32@github.com> On Fri, 8 Nov 2024 12:36:19 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > The documentation of the tz update says that it is not needed > necessarily, but a cleanup of various information. I think > we should go along here. It seems to bring a row of visible changes, > and it's good if this can be mapped to the same update everywhere. > Also, this will simplify later tz updates, which happen regularly. > > CSR for update versions available. > > This is a Backport of the [jdk23u version](https://github.com/openjdk/jdk23u/commit/73b2341c670f98fb130c57f80eb1461226da1985), as the [jdk24 version](https://github.com/openjdk/jdk/commit/ebc17c7c8d6febd5a887309d1b7a466bcd2cc0a9) contains > changes breaking the Java standard. As I understand this only > affects Java 8. But Oracle avoided to bring these changes to 23, > so we should not do that in 21, either. > > In detail, the 23u version omits backport of changes to > src/java.base/share/classes/java/time/ZoneId.java > and src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java. > > In the tests changes to test/jdk/java/time/tck/java/time/TCKZoneId.java and > test/jdk/java/util/TimeZone/OldIDMappingTest.java are omited, and > test/jdk/sun/util/calendar/zi/TestZoneInfo310.java is modified differently. File > test/jdk/sun/util/calendar/zi/tzdata_jdk/tz2024b_overridden_zones > is added in 23. The change to test/jdk/sun/util/resources/TimeZone/Bug4848242.java differs, too. > > **Needed adaptions:** > > I had to resolve java/text/Format/DateFormat/TimeZoneNameTest.java. > But the new version breaks the test. I assume this is because 21 does > not have "[8174269](https://bugs.openjdk.org/browse/JDK-8174269): Remove COMPAT > locale data provider from JDK". > The original version of the test passes. > > test/jdk/sun/util/resources/TimeZone/Bug4848242.java is failing, too. > The original version works, reverted. > > Further I reverted test/jdk/java/util/TimeZone/TimeZoneData/aliases.txt and .../displaynames.txt > as else java/util/TimeZone/Bug6329116.java (unmodified) starts failing. > > See extra commits seperating out these edits. I ran the `java/text/Format`, `java/util/TimeZone`, `sun/util/calendar` and `sun/util/resources` tests in four different scenarios: * Build of 23u with its own tests -- all passed * Build of 23u with the patches from this PR - failures from many tests, some untouched by this PR, due to changes post-21u * Build of 21u with the patches from this PR - passed * Build of 21u with the patches before the test reversion - three failures in `java/text/Format/DateFormat/TimeZoneNameTest.java`, `java/util/TimeZone/Bug6329116.java` and `sun/util/resources/TimeZone/Bug4848242.java` In summary, this area has changed considerably due to changes in 22 & 23, notably [JDK-8174269](https://bugs.openjdk.org/browse/JDK-8174269) and [JDK-8317979](https://bugs.openjdk.org/browse/JDK-8317979). `TimeZoneNameTest.java` and `Bug6329116.java` are run with the `COMPAT` provider in 21u, which is removed by 8174269. The CLDR provider is using zone names from tzdata (JDK-8317979) while, I believe, COMPAT has its own set of names which are unaffected by the tzdata change. I thus think most of the reversion is correct. There is one exception: ~~~ Link Asia/Ulaanbaatar Asia/Choibalsan ~~~ This is a change in the timezone data for 2024b; see "Asia/Choibalsan is now an alias for Asia/Ulaanbaatar rather than being a separate Zone with differing behavior before April 2008. This seems better given our wildly conflicting information about Mongolia's time zone history. (Thanks to Heitor David Pinto.)" from the tzdata release notes. So this change should be reinstated, but the ones related to the three-letter zone names are correct. Looking at this, but it will take a bit of time to work out what is going on with the tests. The `ZoneId` change would affect every JDK that has `java.time.ZoneId` i.e. 8 and later. I think you might be confusing 8+ with just 8 alone. `ZoneId` defines `EST`, `MST` and `HST` as fixed offsets but the latest tzdata does not, instead making them links to `continent/city`-style timezones. In 24, they are changed to these new values in `ZoneId` but that requires a spec change that is not being backported to 23 and older. The [tz2024b_overridden_zones](https://github.com/openjdk/jdk23u/pull/191/files#diff-34c2e2f13c31af3c514eab2db322bb4192f4b2d6d888b4517e9f4be4fe4cbd3e) file brings back these fixed offsets. It does make me wonder if the 23u version of the tests were run against a tzdata with these fixed timezones back in play, as, for 21u, you seem to have ended up reverting the change which converts them from names to aliases. I'll try and dig into them further next week. ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1143#pullrequestreview-2440030181 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1143#issuecomment-2465975263 From goetz at openjdk.org Tue Nov 19 17:53:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Nov 2024 17:53:27 GMT Subject: [jdk21u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <CnsT-iCbqMUk0tWGSXhSFX7lyu0zYp6ywoHQiQWBF84=.6d767ba8-305c-44f2-a778-8b22bc8abc32@github.com> References: <tiZYiBW8uJmweGNIrgmRNm_iqLTU-xNSSa_hIZyJUzY=.036e2ca2-54d0-413d-9c9e-65e6c03814c3@github.com> <CnsT-iCbqMUk0tWGSXhSFX7lyu0zYp6ywoHQiQWBF84=.6d767ba8-305c-44f2-a778-8b22bc8abc32@github.com> Message-ID: <j-ywRAPEQbIGhEn0DGzecm8GMLfMvZn9PDJ5a7esL1o=.2831f024-dcc7-433b-a312-2153d630eed6@github.com> On Sat, 9 Nov 2024 01:37:16 GMT, Andrew John Hughes <andrew at openjdk.org> wrote: >> I backport this for parity with 21.0.6-oracle. >> The documentation of the tz update says that it is not needed >> necessarily, but a cleanup of various information. I think >> we should go along here. It seems to bring a row of visible changes, >> and it's good if this can be mapped to the same update everywhere. >> Also, this will simplify later tz updates, which happen regularly. >> >> CSR for update versions available. >> >> This is a Backport of the [jdk23u version](https://github.com/openjdk/jdk23u/commit/73b2341c670f98fb130c57f80eb1461226da1985), as the [jdk24 version](https://github.com/openjdk/jdk/commit/ebc17c7c8d6febd5a887309d1b7a466bcd2cc0a9) contains >> changes breaking the Java standard. As I understand this only >> affects Java 8. But Oracle avoided to bring these changes to 23, >> so we should not do that in 21, either. >> >> In detail, the 23u version omits backport of changes to >> src/java.base/share/classes/java/time/ZoneId.java >> and src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java. >> >> In the tests changes to test/jdk/java/time/tck/java/time/TCKZoneId.java and >> test/jdk/java/util/TimeZone/OldIDMappingTest.java are omited, and >> test/jdk/sun/util/calendar/zi/TestZoneInfo310.java is modified differently. File >> test/jdk/sun/util/calendar/zi/tzdata_jdk/tz2024b_overridden_zones >> is added in 23. The change to test/jdk/sun/util/resources/TimeZone/Bug4848242.java differs, too. >> >> **Needed adaptions:** >> >> I had to resolve java/text/Format/DateFormat/TimeZoneNameTest.java. >> But the new version breaks the test. I assume this is because 21 does >> not have "[8174269](https://bugs.openjdk.org/browse/JDK-8174269): Remove COMPAT >> locale data provider from JDK". >> The original version of the test passes. >> >> test/jdk/sun/util/resources/TimeZone/Bug4848242.java is failing, too. >> The original version works, reverted. >> >> Further I reverted test/jdk/java/util/TimeZone/TimeZoneData/aliases.txt and .../displaynames.txt >> as else java/util/TimeZone/Bug6329116.java (unmodified) starts failing. >> >> See extra commits seperating out these edits. > > Looking at this, but it will take a bit of time to work out what is going on with the tests. > > The `ZoneId` change would affect every JDK that has `java.time.ZoneId` i.e. 8 and later. I think you might be confusing 8+ with just 8 alone. `ZoneId` defines `EST`, `MST` and `HST` as fixed offsets but the latest tzdata does not, instead making them links to `continent/city`-style timezones. In 24, they are changed to these new values in `ZoneId` but that requires a spec change that is not being backported to 23 and older. > > The [tz2024b_overridden_zones](https://github.com/openjdk/jdk23u/pull/191/files#diff-34c2e2f13c31af3c514eab2db322bb4192f4b2d6d888b4517e9f4be4fe4cbd3e) file brings back these fixed offsets. It does make me wonder if the 23u version of the tests were run against a tzdata with these fixed timezones back in play, as, for 21u, you seem to have ended up reverting the change which converts them from names to aliases. I'll try and dig into them further next week. Hi @gnu-andrew, I just missed adding tz2024b_overridden_zones to the PR, but it was there when I ran all the tests in my local dir. Our nighttests are green except for TestZoneInfo310.java which could not find above file. Hi @gnu-andrew you mean I should add the link back to aliases.txt? I pushed another commit doing so. Bug6329116 still passes. Thanks for looking at this! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1143#issuecomment-2466423955 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1143#issuecomment-2486370460 From duke at openjdk.org Tue Nov 19 18:04:59 2024 From: duke at openjdk.org (Saint Wesonga) Date: Tue, 19 Nov 2024 18:04:59 GMT Subject: [jdk21u-dev] RFR: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set In-Reply-To: <VUWTWvbH6-fw7kB8NqKZQYyFL3BRGxcNSGD6NtPk7C8=.5d832516-91cd-4433-9158-9b9f5dcab38e@github.com> References: <VUWTWvbH6-fw7kB8NqKZQYyFL3BRGxcNSGD6NtPk7C8=.5d832516-91cd-4433-9158-9b9f5dcab38e@github.com> Message-ID: <4NSoyAJ1H1at0XaBUDUK24q42ew1DskoyOhuRmGSmQg=.a2d7ca8d-cb56-494a-8c2f-234fee55237e@github.com> On Mon, 7 Oct 2024 17:02:15 GMT, Saint Wesonga <duke at openjdk.org> wrote: > Backport https://github.com/openjdk/jdk23u/commit/7f189a59d9ad803aee72565bc46a817d3f46f2e5 to jdk21u. UnsafeIntrinsicsTest.java#ZGenerationalDebug test now passes on Windows AArch64 with this change. All tier1 tests also passed. I will open a new PR since the backport commit is different. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1032#issuecomment-2486397615 From duke at openjdk.org Tue Nov 19 18:04:59 2024 From: duke at openjdk.org (Saint Wesonga) Date: Tue, 19 Nov 2024 18:04:59 GMT Subject: [jdk21u-dev] RFR: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set [v2] In-Reply-To: <VUWTWvbH6-fw7kB8NqKZQYyFL3BRGxcNSGD6NtPk7C8=.5d832516-91cd-4433-9158-9b9f5dcab38e@github.com> References: <VUWTWvbH6-fw7kB8NqKZQYyFL3BRGxcNSGD6NtPk7C8=.5d832516-91cd-4433-9158-9b9f5dcab38e@github.com> Message-ID: <WUIUIBM0g96YoTSVlc9a56QbVL-DU6STBVfa3crduEA=.14e19d9c-ba8a-4c1c-b0c5-1cca86552fd1@github.com> > Backport https://github.com/openjdk/jdk23u/commit/7f189a59d9ad803aee72565bc46a817d3f46f2e5 to jdk21u. UnsafeIntrinsicsTest.java#ZGenerationalDebug test now passes on Windows AArch64 with this change. All tier1 tests also passed. Saint Wesonga has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 7f189a59d9ad803aee72565bc46a817d3f46f2e5 ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/1032/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1032&range=01 Stats: 59 lines in 1 file changed: 19 ins; 36 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1032.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1032/head:pull/1032 PR: https://git.openjdk.org/jdk21u-dev/pull/1032 From fferrari at openjdk.org Tue Nov 19 18:22:57 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Tue, 19 Nov 2024 18:22:57 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts [v3] In-Reply-To: <pcAVQWKdXfK9Uc43b151JVdCQFVPYpTFxpjc5QXhbbs=.f0564f90-f6f9-4bb1-bbb1-9bde3d63d172@github.com> References: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> <A1ib3rtSqlN09KW41WuLickHFeJXWqIAKBAsBw-mIkk=.a9f75704-81f0-47dc-9271-1caa183a85a5@github.com> <pcAVQWKdXfK9Uc43b151JVdCQFVPYpTFxpjc5QXhbbs=.f0564f90-f6f9-4bb1-bbb1-9bde3d63d172@github.com> Message-ID: <0ACMGLPmFfSgCI8DQ4-10gtA6A-ESvsVoOTMRYbj6QQ=.8eb466d6-5957-480a-ba80-a1d83ced9711@github.com> On Mon, 18 Nov 2024 22:29:11 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote: >> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove unused DEFAULT_READ_TIMEOUT constant > > @franferrax , @HempushpaSahu, Thank you! > I do not think it is possible to add other bug fixes to this PR, so I submitted dependent backport PRs for the mentioned test fixes: > > - [JDK-8309740](https://bugs.openjdk.org/browse/JDK-8309740), https://github.com/openjdk/jdk/commit/5ca4cdd2caceba9dad8025e5a8851740a3961921 > - [JDK-8310629](https://bugs.openjdk.org/browse/JDK-8310629), https://github.com/openjdk/jdk/commit/b20dc1e9cda1ea3a76b3f14c778c6816e5cc1c0c > - [JDK-8325024](https://bugs.openjdk.org/browse/JDK-8325024), https://github.com/openjdk/jdk/commit/432756b6e51c903e2bff8b9c3028a4f2ea8973f4 > - [JDK-8337826](https://bugs.openjdk.org/browse/JDK-8337826), https://github.com/openjdk/jdk/commit/9b11bd7f4a511ddadf9f02e82aab6ba78beb6763 > > Backports are clean, so no review is required Hi @alexeybakhtin, thank you for the additional time and effort put into this! My intention is to help move things faster, because I've been made aware about customers waiting for this. However, as @GoeLin [explained](https://bugs.openjdk.org/browse/JDK-8179502?focusedId=14720853&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14720853), if Oracle doesn't include this backport in 17.0.14, the documentation won't be updated, so we'll need to wait for them to proceed. Apparently, Oracle's reason for not doing the backport is its low priority. Customers are now trying to get it prioritized through Oracle support, but it looks like we won't make it for the 17.0.14 rampdown date ([_December 3_](https://wiki.openjdk.org/display/JDKUpdates/JDK+17u#JDK17u-Timelines)). NOTE: FYI, AFAIK, you can add multiple backports to a pull requiest with the [`/issue add <id>[,<id>,...]` command](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/issue). ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#issuecomment-2486435596 From goetz at openjdk.org Tue Nov 19 18:45:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Nov 2024 18:45:09 GMT Subject: [jdk17u-dev] RFR: 8322766: Micro bench SSLHandshake should use default algorithms Message-ID: <h7AVijS6pmykxpqiTt2scznONQCzns2HKSEcZhnHXMY=.a772e27c-608e-4037-a287-c4bbbef2fbc0@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 06dd73534271874eff008b8d3027f4ce49b136b3 Changes: https://git.openjdk.org/jdk17u-dev/pull/3062/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3062&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322766 Stats: 9 lines in 2 files changed: 1 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3062.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3062/head:pull/3062 PR: https://git.openjdk.org/jdk17u-dev/pull/3062 From goetz at openjdk.org Tue Nov 19 18:49:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Nov 2024 18:49:41 GMT Subject: [jdk17u-dev] RFR: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization Message-ID: <nahLNuELNoBvKq6Twj0US05kKR0Bn49evRUS3bsAvNo=.08416412-d4fb-4825-97ea-f1cca9d02e20@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 638708cad8228f62caf633015973403164675560 Changes: https://git.openjdk.org/jdk17u-dev/pull/3063/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3063&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328697 Stats: 58 lines in 2 files changed: 29 ins; 27 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3063.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3063/head:pull/3063 PR: https://git.openjdk.org/jdk17u-dev/pull/3063 From duke at openjdk.org Tue Nov 19 19:53:04 2024 From: duke at openjdk.org (duke) Date: Tue, 19 Nov 2024 19:53:04 GMT Subject: [jdk17u-dev] RFR: 8321470: ThreadLocal.nextHashCode can be static final In-Reply-To: <_JxaKtFY6eq9xK7qbw7YkzzpdCoQKJ0FuoIy1GwpK10=.4b8c60a0-0cc6-42fc-ad60-6ea5237e786a@github.com> References: <_JxaKtFY6eq9xK7qbw7YkzzpdCoQKJ0FuoIy1GwpK10=.4b8c60a0-0cc6-42fc-ad60-6ea5237e786a@github.com> Message-ID: <QrH_T0YXSBixLDLffz15Vkk5PupqDJ9Ws_gVsK-1p88=.0043eb5c-5783-40cd-9673-2d3bcf1692f1@github.com> On Sat, 26 Oct 2024 23:46:17 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote: > Backporting JDK-8321470: ThreadLocal.nextHashCode can be static final. Minor change makes the variable final (it is already static). Patch is clean. @satyenme Your change (at version 5465501b43be4be5237d58b2aef90135470479ac) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3007#issuecomment-2486612471 From duke at openjdk.org Tue Nov 19 19:52:57 2024 From: duke at openjdk.org (duke) Date: Tue, 19 Nov 2024 19:52:57 GMT Subject: [jdk21u-dev] RFR: 8321470: ThreadLocal.nextHashCode can be static final In-Reply-To: <0h9ux4XD0cTSwa9VZSEOlDY_RFKQR7KSWUC8T7VfMrM=.34b5568a-832d-4191-b4f0-137bccfd07a4@github.com> References: <0h9ux4XD0cTSwa9VZSEOlDY_RFKQR7KSWUC8T7VfMrM=.34b5568a-832d-4191-b4f0-137bccfd07a4@github.com> Message-ID: <bJq6cM7pKkiTIw6EnVhWr8QuBLkrOG44mK1DB2RyYtk=.9e5c8b1d-968b-4abf-a848-e93573abd954@github.com> On Sat, 26 Oct 2024 23:46:14 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote: > Backporting JDK-8321470: ThreadLocal.nextHashCode can be static final. Minor change makes the variable final (it is already static). Patch is clean. @satyenme Your change (at version e54cafbf2b6efc2a19d97d2cb4b5466c07395d9d) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1099#issuecomment-2486613438 From xpeng at openjdk.org Tue Nov 19 20:04:47 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Tue, 19 Nov 2024 20:04:47 GMT Subject: [jdk17u-dev] RFR: 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException Message-ID: <SG3JbPt8riqYWeF2pqKEHaoWXRVdu32mKB-M4xIb_o0=.fb12d9fe-3937-42f8-abc5-05a533cadc93@github.com> Hi all, This pull request contains a backport of commit [fe0ccdf5](https://github.com/openjdk/jdk/commit/fe0ccdf5f8a5559a608d2e2cd2b6aecbe245c5ec) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Naoto Sato on 13 Nov 2023 and was reviewed by Roger Riggs, Iris Clark, Justin Lu and Joe Wang. Tese: - [x] `CONF=linux-x86_64-server-fastdebug make test TEST=jdk/* JTREG_KEYWORDS=!headful`, there are failures caused by missing printer for test, not related this change. Thanks! ------------- Commit messages: - Backport fe0ccdf5f8a5559a608d2e2cd2b6aecbe245c5ec Changes: https://git.openjdk.org/jdk17u-dev/pull/3059/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3059&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319640 Stats: 50 lines in 2 files changed: 34 ins; 8 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3059.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3059/head:pull/3059 PR: https://git.openjdk.org/jdk17u-dev/pull/3059 From abakhtin at openjdk.org Tue Nov 19 20:12:20 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 19 Nov 2024 20:12:20 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts [v3] In-Reply-To: <0ACMGLPmFfSgCI8DQ4-10gtA6A-ESvsVoOTMRYbj6QQ=.8eb466d6-5957-480a-ba80-a1d83ced9711@github.com> References: <H0tITFNYgM7wh9J_xb81M6370vglUhFlbZKrsibsu3s=.9751c99a-c551-4749-9de2-622fa963fd57@github.com> <A1ib3rtSqlN09KW41WuLickHFeJXWqIAKBAsBw-mIkk=.a9f75704-81f0-47dc-9271-1caa183a85a5@github.com> <pcAVQWKdXfK9Uc43b151JVdCQFVPYpTFxpjc5QXhbbs=.f0564f90-f6f9-4bb1-bbb1-9bde3d63d172@github.com> <0ACMGLPmFfSgCI8DQ4-10gtA6A-ESvsVoOTMRYbj6QQ=.8eb466d6-5957-480a-ba80-a1d83ced9711@github.com> Message-ID: <u8h_1Q3mmkJH4UYP1VrEat93fssmxg7Z9p8iJjq5cMI=.6079451c-8783-4555-a1fc-a33b30c6faec@github.com> On Tue, 19 Nov 2024 18:20:49 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote: >> @franferrax , @HempushpaSahu, Thank you! >> I do not think it is possible to add other bug fixes to this PR, so I submitted dependent backport PRs for the mentioned test fixes: >> >> - [JDK-8309740](https://bugs.openjdk.org/browse/JDK-8309740), https://github.com/openjdk/jdk/commit/5ca4cdd2caceba9dad8025e5a8851740a3961921 >> - [JDK-8310629](https://bugs.openjdk.org/browse/JDK-8310629), https://github.com/openjdk/jdk/commit/b20dc1e9cda1ea3a76b3f14c778c6816e5cc1c0c >> - [JDK-8325024](https://bugs.openjdk.org/browse/JDK-8325024), https://github.com/openjdk/jdk/commit/432756b6e51c903e2bff8b9c3028a4f2ea8973f4 >> - [JDK-8337826](https://bugs.openjdk.org/browse/JDK-8337826), https://github.com/openjdk/jdk/commit/9b11bd7f4a511ddadf9f02e82aab6ba78beb6763 >> >> Backports are clean, so no review is required > > Hi @alexeybakhtin, thank you for the additional time and effort put into this! My intention is to help move things faster, because I've been made aware about customers waiting for this. > > However, as @GoeLin [explained](https://bugs.openjdk.org/browse/JDK-8179502?focusedId=14720853&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14720853), if Oracle doesn't include this backport in 17.0.14, the documentation won't be updated, so we'll need to wait for them to proceed. Apparently, Oracle's reason for not doing the backport is its low priority. Customers are now trying to get it prioritized through Oracle support, but it looks like we won't make it for the 17.0.14 rampdown date ([_December 3_](https://wiki.openjdk.org/display/JDKUpdates/JDK+17u#JDK17u-Timelines)). > > NOTE: FYI, AFAIK, you can add multiple backports to a pull requiest with the [`/issue add <id>[,<id>,...]` command](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/issue). Hi @franferrax, Thank you for your support. We also have customers who are waiting for this enhancement. About `/issue` command - I do not like this approach much. It will bring a much more difference between the backport and the original fix. Right now, all test fixes are applied cleanly. But, if it would help to integrate this enhancement, I can combine all follow-up backports into this one. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#issuecomment-2486652268 From ssubramaniam at openjdk.org Tue Nov 19 20:16:51 2024 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Tue, 19 Nov 2024 20:16:51 GMT Subject: [jdk17u-dev] Integrated: 8321470: ThreadLocal.nextHashCode can be static final In-Reply-To: <_JxaKtFY6eq9xK7qbw7YkzzpdCoQKJ0FuoIy1GwpK10=.4b8c60a0-0cc6-42fc-ad60-6ea5237e786a@github.com> References: <_JxaKtFY6eq9xK7qbw7YkzzpdCoQKJ0FuoIy1GwpK10=.4b8c60a0-0cc6-42fc-ad60-6ea5237e786a@github.com> Message-ID: <Ou4eF7lIxJxe-Jo6sFY6iLDDD3rJsFSuaE63_HXV7ac=.aac94d03-965f-4c30-9f06-2db65bd655d2@github.com> On Sat, 26 Oct 2024 23:46:17 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote: > Backporting JDK-8321470: ThreadLocal.nextHashCode can be static final. Minor change makes the variable final (it is already static). Patch is clean. This pull request has now been integrated. Changeset: ba643837 Author: Satyen Subramaniam <ssubramaniam at openjdk.org> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/ba6438377cf3dfde6dbdd5a2b3119d10b9d87f6b Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8321470: ThreadLocal.nextHashCode can be static final Backport-of: c42535f1110d60d1472080ad4fcadb8acbeb4c4b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3007 From ssubramaniam at openjdk.org Tue Nov 19 20:16:54 2024 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Tue, 19 Nov 2024 20:16:54 GMT Subject: [jdk21u-dev] Integrated: 8321470: ThreadLocal.nextHashCode can be static final In-Reply-To: <0h9ux4XD0cTSwa9VZSEOlDY_RFKQR7KSWUC8T7VfMrM=.34b5568a-832d-4191-b4f0-137bccfd07a4@github.com> References: <0h9ux4XD0cTSwa9VZSEOlDY_RFKQR7KSWUC8T7VfMrM=.34b5568a-832d-4191-b4f0-137bccfd07a4@github.com> Message-ID: <bKeAZrn_0IxVGdvOvHSEDA2CgRBlQjA3axyijJjDeQk=.d6405168-edd3-49be-aaa5-f7e0ad30fc81@github.com> On Sat, 26 Oct 2024 23:46:14 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote: > Backporting JDK-8321470: ThreadLocal.nextHashCode can be static final. Minor change makes the variable final (it is already static). Patch is clean. This pull request has now been integrated. Changeset: 324e32f9 Author: Satyen Subramaniam <ssubramaniam at openjdk.org> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/324e32f91d0a7aedcb6883484372c94df6fb6a6b Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8321470: ThreadLocal.nextHashCode can be static final Backport-of: c42535f1110d60d1472080ad4fcadb8acbeb4c4b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1099 From abakhtin at openjdk.org Tue Nov 19 22:13:05 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 19 Nov 2024 22:13:05 GMT Subject: [jdk21u-dev] RFR: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 Message-ID: <ycrgV0SkY2VIAqm3MvkFGXRQiqk4R-jleid_-dLQ7DQ=.f81a371f-2114-49fe-a7e8-e5f5498abc75@github.com> I'd like to backport it as a follow-up for JDK-8179502 Backport is clean All related JTREG tests passed ------------- Commit messages: - 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 Changes: https://git.openjdk.org/jdk21u-dev/pull/1162/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1162&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337826 Stats: 105 lines in 2 files changed: 46 ins; 24 del; 35 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1162.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1162/head:pull/1162 PR: https://git.openjdk.org/jdk21u-dev/pull/1162 From wkemper at openjdk.org Tue Nov 19 23:27:28 2024 From: wkemper at openjdk.org (William Kemper) Date: Tue, 19 Nov 2024 23:27:28 GMT Subject: [jdk21u-dev] Integrated: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate In-Reply-To: <_-Tp2qhNmlZNquRSjo8f1x226hwBY3Ra7AnEmtJ9Gcw=.6fa12ab2-b85d-456f-be8b-df1f3e1f6f6b@github.com> References: <_-Tp2qhNmlZNquRSjo8f1x226hwBY3Ra7AnEmtJ9Gcw=.6fa12ab2-b85d-456f-be8b-df1f3e1f6f6b@github.com> Message-ID: <60H6VeR-kd6Ryxa_4aioMpyh4HvZaeNyFFmPUPaxe5Q=.f1b0dbc2-adce-4cb9-a34d-710123e3dcd2@github.com> On Thu, 12 Sep 2024 22:29:41 GMT, William Kemper <wkemper at openjdk.org> wrote: > Clean backport. Change is confined to Shenandoah. This pull request has now been integrated. Changeset: fd7b6e45 Author: William Kemper <wkemper at openjdk.org> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/fd7b6e451b65d3bc814c3ccc21f1d7fab9956555 Stats: 21 lines in 2 files changed: 14 ins; 0 del; 7 mod 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate Reviewed-by: shade Backport-of: e74edbaea9f09169f597a470f647f3b7d10cc71b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/973 From andrew at openjdk.org Wed Nov 20 00:59:32 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 20 Nov 2024 00:59:32 GMT Subject: [jdk21u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <tiZYiBW8uJmweGNIrgmRNm_iqLTU-xNSSa_hIZyJUzY=.036e2ca2-54d0-413d-9c9e-65e6c03814c3@github.com> References: <tiZYiBW8uJmweGNIrgmRNm_iqLTU-xNSSa_hIZyJUzY=.036e2ca2-54d0-413d-9c9e-65e6c03814c3@github.com> Message-ID: <yhgFwmTAgTgyxzCMMzSXp_0cg11wVf6sIIt4wmBkJ5I=.0a88e2cc-2f81-41c3-82ce-4cd6a9b42625@github.com> On Fri, 8 Nov 2024 12:36:19 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > The documentation of the tz update says that it is not needed > necessarily, but a cleanup of various information. I think > we should go along here. It seems to bring a row of visible changes, > and it's good if this can be mapped to the same update everywhere. > Also, this will simplify later tz updates, which happen regularly. > > CSR for update versions available. > > This is a Backport of the [jdk23u version](https://github.com/openjdk/jdk23u/commit/73b2341c670f98fb130c57f80eb1461226da1985), as the [jdk24 version](https://github.com/openjdk/jdk/commit/ebc17c7c8d6febd5a887309d1b7a466bcd2cc0a9) contains > changes breaking the Java standard. As I understand this only > affects Java 8. But Oracle avoided to bring these changes to 23, > so we should not do that in 21, either. > > In detail, the 23u version omits backport of changes to > src/java.base/share/classes/java/time/ZoneId.java > and src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java. > > In the tests changes to test/jdk/java/time/tck/java/time/TCKZoneId.java and > test/jdk/java/util/TimeZone/OldIDMappingTest.java are omited, and > test/jdk/sun/util/calendar/zi/TestZoneInfo310.java is modified differently. File > test/jdk/sun/util/calendar/zi/tzdata_jdk/tz2024b_overridden_zones > is added in 23. The change to test/jdk/sun/util/resources/TimeZone/Bug4848242.java differs, too. > > **Needed adaptions:** > > I had to resolve java/text/Format/DateFormat/TimeZoneNameTest.java. > But the new version breaks the test. I assume this is because 21 does > not have "[8174269](https://bugs.openjdk.org/browse/JDK-8174269): Remove COMPAT > locale data provider from JDK". > The original version of the test passes. > > test/jdk/sun/util/resources/TimeZone/Bug4848242.java is failing, too. > The original version works, reverted. > > Further I reverted test/jdk/java/util/TimeZone/TimeZoneData/aliases.txt and .../displaynames.txt > as else java/util/TimeZone/Bug6329116.java (unmodified) starts failing. > > See extra commits seperating out these edits. Yes, that one is an actual data change in this update, whereas the others are due to the three-letter zones being removed and don't seem to affect the COMPAT provider. Change looks good to me now. Thanks for restoring that line. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1143#pullrequestreview-2447111388 From syan at openjdk.org Wed Nov 20 02:05:18 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 20 Nov 2024 02:05:18 GMT Subject: [jdk23u] RFR: 8344356: Aarch64: implement -XX:+VerifyActivationFrameSize Message-ID: <wJm_yhPLaxOkOOUcDt5iaPcw3mSA40R2MtVGrtnQ0GQ=.5c230159-8458-461d-96cc-f5f8306792c8@github.com> Hi all, This pull request contains a backport of commit [4ddd3dec](https://github.com/openjdk/jdk/commit/4ddd3dec2d0b232d48646ca89b16591b3026aa5c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 20 Nov 2024 and was reviewed by Andrew Haley. Thanks! ------------- Commit messages: - Backport 4ddd3dec2d0b232d48646ca89b16591b3026aa5c Changes: https://git.openjdk.org/jdk23u/pull/228/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=228&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344356 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/228.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/228/head:pull/228 PR: https://git.openjdk.org/jdk23u/pull/228 From syan at openjdk.org Wed Nov 20 02:06:19 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 20 Nov 2024 02:06:19 GMT Subject: [jdk21u-dev] RFR: 8344356: Aarch64: implement -XX:+VerifyActivationFrameSize Message-ID: <XM84u_KZv5ayaSLdVY7zihhMirPYokjdvDVHJOf83L8=.b0816402-7c71-4f2e-a907-55dbb1e39e7d@github.com> Hi all, This pull request contains a backport of commit [4ddd3dec](https://github.com/openjdk/jdk/commit/4ddd3dec2d0b232d48646ca89b16591b3026aa5c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 20 Nov 2024 and was reviewed by Andrew Haley. Thanks! ------------- Commit messages: - Backport 4ddd3dec2d0b232d48646ca89b16591b3026aa5c Changes: https://git.openjdk.org/jdk21u-dev/pull/1163/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1163&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344356 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1163.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1163/head:pull/1163 PR: https://git.openjdk.org/jdk21u-dev/pull/1163 From amitkumar at openjdk.org Wed Nov 20 03:59:15 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Wed, 20 Nov 2024 03:59:15 GMT Subject: [jdk21u-dev] RFR: 8343884: [s390x] Disallow OptoScheduling Message-ID: <Rn0cj-l5pnagAS9RtY_RVHSp8momKJYV4WMeSs8JwjI=.cd4983ea-571a-4d40-b358-9ec2b9ce68a4@github.com> Hi all, This pull request contains a backport of commit [7540fa21](https://github.com/openjdk/jdk/commit/7540fa2147ff8fc9c652ef13548f72f27e2809a8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 19 Nov 2024 and was reviewed by Lutz Schmidt. Thanks! ------------- Commit messages: - Backport 7540fa2147ff8fc9c652ef13548f72f27e2809a8 Changes: https://git.openjdk.org/jdk21u-dev/pull/1164/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1164&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343884 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1164.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1164/head:pull/1164 PR: https://git.openjdk.org/jdk21u-dev/pull/1164 From syan at openjdk.org Wed Nov 20 08:04:17 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 20 Nov 2024 08:04:17 GMT Subject: [jdk17u-dev] RFR: 8336257: Additional tests in jmxremote/startstop to match on PID not app name In-Reply-To: <yra7M13ESSoAlsk2k8MsWxE-GXR5Cebckkve-lo8Wfs=.6bfa80a4-2c02-48c4-8ff3-b3bf3618057f@github.com> References: <yra7M13ESSoAlsk2k8MsWxE-GXR5Cebckkve-lo8Wfs=.6bfa80a4-2c02-48c4-8ff3-b3bf3618057f@github.com> Message-ID: <gDFsVtLm-sujiIw4-JLGMBVVbSfLY8_oWRmatDCKLmQ=.7d9bb8f5-a1e1-4b94-b5b6-29db7bcaa5e9@github.com> On Tue, 19 Nov 2024 15:25:23 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [687601eb](https://github.com/openjdk/jdk/commit/687601ebcaedf133fd4d5cecc42c5aadf9c73f3c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer, Alan Bateman, Alex Menkov and Daniel D. Daugherty. > > Thanks! GHA report failure: 1. linux-x64-hs-zero / build (debug) job fails at `Get JTReg` stage, report fails `wget exited with exit code 4`, seems like environmental issue or infra issue, it's unrelated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3060#issuecomment-2487817043 From goetz at openjdk.org Wed Nov 20 08:13:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 08:13:19 GMT Subject: [jdk17u-dev] RFR: 8322766: Micro bench SSLHandshake should use default algorithms In-Reply-To: <h7AVijS6pmykxpqiTt2scznONQCzns2HKSEcZhnHXMY=.a772e27c-608e-4037-a287-c4bbbef2fbc0@github.com> References: <h7AVijS6pmykxpqiTt2scznONQCzns2HKSEcZhnHXMY=.a772e27c-608e-4037-a287-c4bbbef2fbc0@github.com> Message-ID: <Ti3uALk88TOO_0IztTuZRJC7TeKkgqu66sJTVkaFW-A=.331f1cbf-8fd1-4ad6-9427-1f96d5029716@github.com> On Tue, 19 Nov 2024 18:39:31 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. GHA failure: infra issue, unrelated Error: sh][ERROR] wget exited with exit code 4 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3062#issuecomment-2487835326 From duke at openjdk.org Wed Nov 20 08:26:35 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Wed, 20 Nov 2024 08:26:35 GMT Subject: [jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result [v3] In-Reply-To: <cARSx0TOpqpRDofHGcZyWpWSb6dMr-LY190iacO2zuQ=.df3ff00d-6b5f-42f9-bc01-8923fe65676b@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> <cARSx0TOpqpRDofHGcZyWpWSb6dMr-LY190iacO2zuQ=.df3ff00d-6b5f-42f9-bc01-8923fe65676b@github.com> Message-ID: <b05oihL3oR5K3TdN9PsRvY9XcA9BlOdc8fKsyqVAxWc=.d32a3642-64ac-46fe-b5d5-45f41aecf051@github.com> On Tue, 19 Nov 2024 12:26:05 GMT, Radek ??p <duke at openjdk.org> wrote: >> Backport for https://bugs.openjdk.org/browse/JDK-8337066 >> >> When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. >> >> This is a clean backport. > > Radek ??p has updated the pull request incrementally with one additional commit since the last revision: > > Fixed indentation. - backport is adding test and fixes behavior caused by https://bugs.openjdk.org/browse/JDK-8242115 - https://bugs.openjdk.org/browse/JDK-8242115 isn't backported, currently, it isn't worth it to be backported and probably won't be backported - the test is green on patched code, and on unpatched code - the conclusion is not to backport this. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#issuecomment-2487862487 From duke at openjdk.org Wed Nov 20 08:26:36 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Wed, 20 Nov 2024 08:26:36 GMT Subject: [jdk11u-dev] Withdrawn: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result In-Reply-To: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> References: <OOh0TSgbs3OJzWkajcvQ1Sofxb5NNsazVJRYqMPYkhs=.2d2e03d7-374f-49eb-8135-3ecef4aaebee@github.com> Message-ID: <_eklZLJdSIpJG04WCpFqT6e5fEbT06BbBVu2xzWg8Xk=.12c14fa7-0ef5-4f51-b4af-9a68daa268d7@github.com> On Fri, 8 Nov 2024 12:44:55 GMT, Radek ??p <duke at openjdk.org> wrote: > Backport for https://bugs.openjdk.org/browse/JDK-8337066 > > When calling StringBuffer/StringBuilder.reverse with 2byte string repeatedly, the API returns wrong result. > > This is a clean backport. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2961 From mbaesken at openjdk.org Wed Nov 20 08:27:27 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 20 Nov 2024 08:27:27 GMT Subject: [jdk21u-dev] Integrated: 8333144: docker tests do not work when ubsan is configured In-Reply-To: <K8yyNl_GTFDmFJT1aiBLC_VI_SnT_smBAjCwA3Gv5KA=.59955edf-ca30-4a03-8de7-3ffc27a81350@github.com> References: <K8yyNl_GTFDmFJT1aiBLC_VI_SnT_smBAjCwA3Gv5KA=.59955edf-ca30-4a03-8de7-3ffc27a81350@github.com> Message-ID: <ubjTyCQDMfgRjHSFE9d2CD_yEnXyZ4A93fYuTr61ryo=.9d8e030b-dd58-4121-9b75-807ec043de7c@github.com> On Mon, 18 Nov 2024 16:14:10 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8333144: docker tests do not work when ubsan is configured This pull request has now been integrated. Changeset: cb9a6a2f Author: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/cb9a6a2f6a093a579acbe7529f57bf12c80f1b02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8333144: docker tests do not work when ubsan is configured Backport-of: fbe8a81d1900d0de1920ad1df6ad574f3da4bd51 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1161 From mbaesken at openjdk.org Wed Nov 20 08:44:21 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 20 Nov 2024 08:44:21 GMT Subject: [jdk21u-dev] RFR: 8338550: Do libubsan1 installation in test container only if requested Message-ID: <evMlQAEmYarRF12g5Re3SYVfNit6OYkkfzwy0Aow2bY=.9ae02215-d3d7-4f7d-b4e3-f08757c14e9c@github.com> 8338550: Do libubsan1 installation in test container only if requested ------------- Commit messages: - Backport 7933e45cda7e3eaeabd3b3fa81492ade8e1cc2dc Changes: https://git.openjdk.org/jdk21u-dev/pull/1165/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1165&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338550 Stats: 10 lines in 2 files changed: 6 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1165.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1165/head:pull/1165 PR: https://git.openjdk.org/jdk21u-dev/pull/1165 From aph at openjdk.org Wed Nov 20 08:53:18 2024 From: aph at openjdk.org (Andrew Haley) Date: Wed, 20 Nov 2024 08:53:18 GMT Subject: [jdk23u] RFR: 8344356: Aarch64: implement -XX:+VerifyActivationFrameSize In-Reply-To: <wJm_yhPLaxOkOOUcDt5iaPcw3mSA40R2MtVGrtnQ0GQ=.5c230159-8458-461d-96cc-f5f8306792c8@github.com> References: <wJm_yhPLaxOkOOUcDt5iaPcw3mSA40R2MtVGrtnQ0GQ=.5c230159-8458-461d-96cc-f5f8306792c8@github.com> Message-ID: <erKqeQz--feM65s661fvMZZUSmxwwCCq7xDA4pO4Nh8=.6ed589eb-66c1-4313-96da-a9f2dff08578@github.com> On Wed, 20 Nov 2024 01:58:50 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [4ddd3dec](https://github.com/openjdk/jdk/commit/4ddd3dec2d0b232d48646ca89b16591b3026aa5c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 20 Nov 2024 and was reviewed by Andrew Haley. > > Thanks! Why? ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/228#issuecomment-2487923342 From goetz at openjdk.org Wed Nov 20 09:05:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 09:05:13 GMT Subject: [jdk17u-dev] RFR: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails Message-ID: <bEwjpfWRkA9tWCysvSBQRQeAaw5u5TG2yTPVb6OJS4c=.eadb5f36-4cb9-4f69-9e87-2f5cfe58abca@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 2dd882af0830f174810840affa79045db4f04ef0 Changes: https://git.openjdk.org/jdk17u-dev/pull/3064/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3064&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8254759 Stats: 145 lines in 1 file changed: 145 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3064.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3064/head:pull/3064 PR: https://git.openjdk.org/jdk17u-dev/pull/3064 From syan at openjdk.org Wed Nov 20 09:12:22 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 20 Nov 2024 09:12:22 GMT Subject: [jdk23u] RFR: 8344356: Aarch64: implement -XX:+VerifyActivationFrameSize In-Reply-To: <erKqeQz--feM65s661fvMZZUSmxwwCCq7xDA4pO4Nh8=.6ed589eb-66c1-4313-96da-a9f2dff08578@github.com> References: <wJm_yhPLaxOkOOUcDt5iaPcw3mSA40R2MtVGrtnQ0GQ=.5c230159-8458-461d-96cc-f5f8306792c8@github.com> <erKqeQz--feM65s661fvMZZUSmxwwCCq7xDA4pO4Nh8=.6ed589eb-66c1-4313-96da-a9f2dff08578@github.com> Message-ID: <5Sk1eV4577DX4lpgyTfkZ5OlrfgbcWirc78LdDCTj-o=.72a0ebc0-38b8-4d2a-a03c-62ddf9214b5b@github.com> On Wed, 20 Nov 2024 08:50:44 GMT, Andrew Haley <aph at openjdk.org> wrote: > Why? I want to backport this PR to jdk21u-dev. Before this PR backported to jdk21u-dev, should we backport to jdk23u first. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/228#issuecomment-2487967109 From sgehwolf at openjdk.org Wed Nov 20 09:41:21 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 20 Nov 2024 09:41:21 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 [v2] In-Reply-To: <rxBVBiEJcpTyE4H4vcon5K--3twiegXQymwKH65FouQ=.8c48d178-920f-4d74-a610-722e884ce41e@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> <rxBVBiEJcpTyE4H4vcon5K--3twiegXQymwKH65FouQ=.8c48d178-920f-4d74-a610-722e884ce41e@github.com> Message-ID: <kxmiqXU61uL_jBBlohBJchFWM2QOtrNNU671krxDdWs=.859f8eba-9dd9-4abb-8799-7e9e7b676892@github.com> On Tue, 19 Nov 2024 16:56:03 GMT, sophia-guo <duke at openjdk.org> wrote: >> Hi, I would like to backport[ 8333248](https://bugs.openjdk.org/browse/JDK-8333248) to jdk21u. As [JDK-8325520](https://bugs.openjdk.org/browse/JDK-8325520) was also backported to 21 so the test now fails on risc-v there. > > sophia-guo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into 8333248-backport-9b0a5c5c > - Backport 9b0a5c5cd056262fab99525e9260762b617152a3 This patch is ready for integration. Please check the test passes post-patch (if not already done) and then integrate. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1100#issuecomment-2488078604 From goetz at openjdk.org Wed Nov 20 09:55:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 09:55:22 GMT Subject: [jdk17u-dev] Integrated: 8302225: SunJCE Provider doesn't validate key sizes when using 'constrained' transforms for AES/KW and AES/KWP In-Reply-To: <Q6_kPU4G39OcwmdBTVKstFkm68YpfXvsOWUpk63cQbQ=.61892003-542e-4a20-8a18-7f2de43e43d5@github.com> References: <Q6_kPU4G39OcwmdBTVKstFkm68YpfXvsOWUpk63cQbQ=.61892003-542e-4a20-8a18-7f2de43e43d5@github.com> Message-ID: <FlQ7FsHPP5st-3hPs0E3UDXf39Daz--RxCfcftOcghI=.c21bc9dd-89b3-4d14-b6cc-73c5152bf5e7@github.com> On Mon, 18 Nov 2024 10:28:25 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I would like to fix this issue in the sun crypto provider. > > Clean backport except for Copyright, probably recognized clean. This pull request has now been integrated. Changeset: 878daefa Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/878daefa221e7f4d8198bd81b4868f4eb7bbfada Stats: 60 lines in 2 files changed: 36 ins; 13 del; 11 mod 8302225: SunJCE Provider doesn't validate key sizes when using 'constrained' transforms for AES/KW and AES/KWP Backport-of: 4ce493f09ea3a34322462e82fd73b8375be1cba5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3047 From goetz at openjdk.org Wed Nov 20 09:55:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 09:55:54 GMT Subject: [jdk17u-dev] RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property [v2] In-Reply-To: <bYXb_dXuiHVhe7G-L8Wg64Oh7WRA2VHgXbQmcQc22EI=.a4d85128-81e1-4c07-81db-c685beeff407@github.com> References: <bYXb_dXuiHVhe7G-L8Wg64Oh7WRA2VHgXbQmcQc22EI=.a4d85128-81e1-4c07-81db-c685beeff407@github.com> Message-ID: <hi6ZGt0-Vlzwvez9Fxf7R7chwzINtqOOrms5TZLE0Zg=.e7ca2be0-2efb-409b-b344-1b2d6d93aab6@github.com> > I backport this for parity with Oracle 17.0.14. The backport is based on the commit to 21. > > Tests passed including win tests. Three files are not real tests, I double-checked these. > > I had to resolve a lot of files, but all except three only differed in the Copyright year. > > Resolved files > ================ > > doc/testing.html > Resolved. Context differences. > > test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestCipherKeyWrapperTest.java > test/jdk/com/sun/crypto/provider/Cipher/PBE/DecryptWithoutParameters.java > test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java > test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java > test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java > test/jdk/com/sun/crypto/provider/Cipher/PBE/PBESealedObject.java > test/jdk/com/sun/crypto/provider/Cipher/PBE/TestCipherKeyWrapperPBEKey.java > test/jdk/com/sun/crypto/provider/KeyGenerator/Test4628062.java > test/jdk/com/sun/crypto/provider/Mac/HmacPBESHA1.java > test/jdk/com/sun/crypto/provider/Mac/HmacSaltLengths.java > test/jdk/com/sun/crypto/provider/Mac/MacClone.java > test/jdk/com/sun/crypto/provider/NSASuiteB/TestHmacSHAOids.java > All these test lack 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider > All only Copyright except for > DecryptWithoutParameters.java: Test in 17 has less and other test cases, adapted change to this. > > test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestGeneral.java > Test was modified in 18 by 8271745: Correct block size for KW,KWP mode and use fixed IV for KWP mode for SunJCE > Test in 17 has other test cases, adapted change to this. > > test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestKeySizeCheck.java > Test was modified in 8302225: SunJCE Provider doesn't validate key sizes when using 'constrained' transforms for AES/KW and AES/KWP > Backport started. > Resolved Copyright. > > test/jdk/com/sun/crypto/provider/KeyAgreement/TestExponentSize.java > Modified in 19 by 8267319: Use larger default key sizes and algorithms based on CNSA > Resolved Copyright. > > test/jdk/com/sun/jdi/ClassesByName2Test.java > Modified by virtual threads changes. > Resolved Copyright. > > test/jdk/javax/crypto/EncryptedPrivateKeyInfo/GetAlgName.java > Modified in 20 by 8296442: EncryptedPrivateKeyInfo can be created with an uninitialized AlgorithmParameters. This is a follow-up of a cleanup change also in 20. > Resolved Copyright. > > > > Files not in 17 > =============== > > test/jdk/com/sun/crypto/provider/KeyGenerator/Test6227536.java > This tes... Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into goetz_backport_8341927 - Backport 9bdf2a619d1d158d6c1e8e1e1238a4229e0b0783 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/3049/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3049&range=01 Stats: 970 lines in 222 files changed: 294 ins; 0 del; 676 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3049.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3049/head:pull/3049 PR: https://git.openjdk.org/jdk17u-dev/pull/3049 From goetz at openjdk.org Wed Nov 20 09:58:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 09:58:33 GMT Subject: [jdk21u-dev] Integrated: 8325525: Create jtreg test case for JDK-8325203 In-Reply-To: <noWTQgalTvqWcFsJw6YHamBbqJkx2cP_GpVBCKz6cCQ=.15bdab31-06bf-4c71-9a8a-7a10c48c9351@github.com> References: <noWTQgalTvqWcFsJw6YHamBbqJkx2cP_GpVBCKz6cCQ=.15bdab31-06bf-4c71-9a8a-7a10c48c9351@github.com> Message-ID: <7Rs3LMVqSeXh26x3nieuz3OQH1y0tFC_h_3bckMaJFQ=.da29005f-08d6-4cff-9af1-239f763d6899@github.com> On Mon, 18 Nov 2024 14:17:19 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.5-oracle. > > I include follow-up 8336315. > > Both are clean backports. Test passes on win. This pull request has now been integrated. Changeset: 936b2395 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/936b23953044d0c9a8ea558208c3cd503895144a Stats: 129 lines in 2 files changed: 129 ins; 0 del; 0 mod 8325525: Create jtreg test case for JDK-8325203 8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive Reviewed-by: lucy Backport-of: 81a0d1ba03bbdbe718302b3925cdc207d5d05232 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1160 From goetz at openjdk.org Wed Nov 20 10:01:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 10:01:33 GMT Subject: [jdk17u-dev] Integrated: 8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils In-Reply-To: <FDH0-Fkj9BDzVGEvd4yz31tmm7msdXAEkK2IsBpoI_0=.d2a80f5e-0417-45b6-80b3-04bf485bb34f@github.com> References: <FDH0-Fkj9BDzVGEvd4yz31tmm7msdXAEkK2IsBpoI_0=.d2a80f5e-0417-45b6-80b3-04bf485bb34f@github.com> Message-ID: <9ekqKsvj0p7GGmx5E0S-srMnvYtJg_Eo0U2XCj_Urkk=.82c68ceb-49ff-49c4-880c-a121ee7a9c92@github.com> On Mon, 18 Nov 2024 14:32:02 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > Applies clean, but FILE_SEPERATOR was already backported to Utils.java. > Second commit removes redundant definition. This pull request has now been integrated. Changeset: 8ef9a496 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/8ef9a496cf213065c1d776f734b4ccb6d75aad5e Stats: 468 lines in 4 files changed: 231 ins; 234 del; 3 mod 8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils Reviewed-by: lucy Backport-of: cc8bf95046d1fba0f88b0e17481f36b2be870659 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3050 From goetz at openjdk.org Wed Nov 20 10:03:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 10:03:24 GMT Subject: [jdk17u-dev] Integrated: 8295344: Harden runtime/StackGuardPages/TestStackGuardPages.java In-Reply-To: <Xzr1NebiMi29-D5MkW5IMZWoTvcTbWdGyHf4qgCY_R8=.9fe47925-1e79-4fb1-ba42-f13b1a8b08e8@github.com> References: <Xzr1NebiMi29-D5MkW5IMZWoTvcTbWdGyHf4qgCY_R8=.9fe47925-1e79-4fb1-ba42-f13b1a8b08e8@github.com> Message-ID: <LSS4sI1T_svHTMI3mO4ukID1m5aLNHXwdbJfmABDJEw=.fbaa7040-5258-475a-bb53-707f3cbf9f4d@github.com> On Mon, 18 Nov 2024 15:46:49 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. > > Omitted ProblemList, as test is not problem listed in 17. This pull request has now been integrated. Changeset: a49d5eaf Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/a49d5eafb42e5723425aff469ae2dfee584c71fa Stats: 151 lines in 3 files changed: 96 ins; 29 del; 26 mod 8295344: Harden runtime/StackGuardPages/TestStackGuardPages.java Reviewed-by: lucy Backport-of: 8c2c8b3f7f1bf286ca67a736938797d14fd7555c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3051 From goetz at openjdk.org Wed Nov 20 10:04:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 10:04:24 GMT Subject: [jdk17u-dev] Integrated: 8307297: Move some DnD tests to open In-Reply-To: <BwKUULw98oLzv48TgTs-yrzqx1xM9rp1vP8nVozmH8w=.a96a439d-c37c-4fa8-b0af-595ec48d8d74@github.com> References: <BwKUULw98oLzv48TgTs-yrzqx1xM9rp1vP8nVozmH8w=.a96a439d-c37c-4fa8-b0af-595ec48d8d74@github.com> Message-ID: <ETKTjHqoi8zJE5E1wnSoWUQAyWYKLumuVId89L74wkI=.dae8cb90-07c2-404f-9d08-5490a95e26bc@github.com> On Mon, 18 Nov 2024 15:56:53 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 86a64afa Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/86a64afa011c1dbd265fa7494c7566aaccf9127d Stats: 1233 lines in 7 files changed: 1233 ins; 0 del; 0 mod 8307297: Move some DnD tests to open Backport-of: 3bf3876185f7b9e7679af3fa22ec20887cd4e498 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3052 From goetz at openjdk.org Wed Nov 20 10:05:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 10:05:22 GMT Subject: [jdk17u-dev] Integrated: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI In-Reply-To: <EtQJgJD22HNpApchLKtZByKtC9_Afu12n43EUQAOabg=.1afe9a20-8d4b-412e-a430-6ba972998cc6@github.com> References: <EtQJgJD22HNpApchLKtZByKtC9_Afu12n43EUQAOabg=.1afe9a20-8d4b-412e-a430-6ba972998cc6@github.com> Message-ID: <LeJ7B83zjsMKaMXiA38V9J3rc3PdBRazqqTDG3hRK-s=.87bc4da2-9275-43f3-99f0-4a7ce601cf37@github.com> On Mon, 18 Nov 2024 16:00:33 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 2c06cbb7 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/2c06cbb70446d92022ce513ab3ec399edc3112b2 Stats: 65 lines in 1 file changed: 51 ins; 1 del; 13 mod 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI Backport-of: 02bce0b1452b804f3a7883ca8bf29a524b73672e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3053 From goetz at openjdk.org Wed Nov 20 10:08:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 10:08:30 GMT Subject: [jdk17u-dev] Integrated: 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic" In-Reply-To: <GTF1A_uNAbHl7r9F2VgwjUMU_9THCGWuzxP3Z8cNTKM=.26c126b4-743f-4f9e-8382-d77cc33b68b7@github.com> References: <GTF1A_uNAbHl7r9F2VgwjUMU_9THCGWuzxP3Z8cNTKM=.26c126b4-743f-4f9e-8382-d77cc33b68b7@github.com> Message-ID: <NoSB4DX4Uc0Z9WELVoO71YCRE9chxQmhk3BssxRsphg=.dfb27cb1-e9b7-41fb-a1aa-5d455d86b5cb@github.com> On Mon, 18 Nov 2024 16:06:47 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: b88676dc Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/b88676dcef07734e6f3697cedf5a51a1bed7f304 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic" Backport-of: 0fd807118c9b2cb8381b5c0f5d22d4e3451e8f10 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3054 From goetz at openjdk.org Wed Nov 20 10:09:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 10:09:17 GMT Subject: [jdk17u-dev] Integrated: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization In-Reply-To: <nahLNuELNoBvKq6Twj0US05kKR0Bn49evRUS3bsAvNo=.08416412-d4fb-4825-97ea-f1cca9d02e20@github.com> References: <nahLNuELNoBvKq6Twj0US05kKR0Bn49evRUS3bsAvNo=.08416412-d4fb-4825-97ea-f1cca9d02e20@github.com> Message-ID: <9q9oFk2QDG2UxZtwqgFylDn8JwOyHu05xpTO1xlY_Ew=.8fd67f1a-5a1e-4aa1-9249-feacd22d2197@github.com> On Tue, 19 Nov 2024 18:43:43 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 73d6539e Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/73d6539e660ec35f54359a17f08a3131a65bc9b2 Stats: 58 lines in 2 files changed: 29 ins; 27 del; 2 mod 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization Backport-of: 638708cad8228f62caf633015973403164675560 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3063 From aph at openjdk.org Wed Nov 20 10:48:19 2024 From: aph at openjdk.org (Andrew Haley) Date: Wed, 20 Nov 2024 10:48:19 GMT Subject: [jdk21u-dev] RFR: 8344356: Aarch64: implement -XX:+VerifyActivationFrameSize In-Reply-To: <XM84u_KZv5ayaSLdVY7zihhMirPYokjdvDVHJOf83L8=.b0816402-7c71-4f2e-a907-55dbb1e39e7d@github.com> References: <XM84u_KZv5ayaSLdVY7zihhMirPYokjdvDVHJOf83L8=.b0816402-7c71-4f2e-a907-55dbb1e39e7d@github.com> Message-ID: <T_Oj9Xepg7jjosVp_2Mt9lzPn91U4h8hON-05FJu5kA=.abe99762-e5f0-45e5-b55b-ba56d57d9358@github.com> On Wed, 20 Nov 2024 01:59:00 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [4ddd3dec](https://github.com/openjdk/jdk/commit/4ddd3dec2d0b232d48646ca89b16591b3026aa5c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 20 Nov 2024 and was reviewed by Andrew Haley. > > Thanks! Why? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1163#issuecomment-2488235466 From mbaesken at openjdk.org Wed Nov 20 12:36:16 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 20 Nov 2024 12:36:16 GMT Subject: [jdk21u-dev] Integrated: 8338550: Do libubsan1 installation in test container only if requested In-Reply-To: <evMlQAEmYarRF12g5Re3SYVfNit6OYkkfzwy0Aow2bY=.9ae02215-d3d7-4f7d-b4e3-f08757c14e9c@github.com> References: <evMlQAEmYarRF12g5Re3SYVfNit6OYkkfzwy0Aow2bY=.9ae02215-d3d7-4f7d-b4e3-f08757c14e9c@github.com> Message-ID: <fO15mPdlaBx_TLtHQWFgba3Dh30NAexATEyJzHL4CJc=.eca8a1bd-1b0d-44e9-a7bb-74d8243b47f5@github.com> On Wed, 20 Nov 2024 08:36:41 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8338550: Do libubsan1 installation in test container only if requested This pull request has now been integrated. Changeset: f9cd285e Author: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/f9cd285e4ca7f442dda8ad4f35be770197c73e4a Stats: 10 lines in 2 files changed: 6 ins; 0 del; 4 mod 8338550: Do libubsan1 installation in test container only if requested Backport-of: 7933e45cda7e3eaeabd3b3fa81492ade8e1cc2dc ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1165 From goetz at openjdk.org Wed Nov 20 12:43:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 12:43:13 GMT Subject: [jdk17u-dev] RFR: 8325525: Create jtreg test case for JDK-8325203 Message-ID: <jLmbuqK6Qglgu6eVugjMkhMiWCjzY9VuHGjWxPkF5Ls=.35591a95-0daa-48c7-9cc9-c48a52925628@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 936b23953044d0c9a8ea558208c3cd503895144a Changes: https://git.openjdk.org/jdk17u-dev/pull/3065/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3065&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325525 Stats: 129 lines in 2 files changed: 129 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3065.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3065/head:pull/3065 PR: https://git.openjdk.org/jdk17u-dev/pull/3065 From mbaesken at openjdk.org Wed Nov 20 13:44:56 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 20 Nov 2024 13:44:56 GMT Subject: [jdk21u-dev] RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang Message-ID: <R9YVQZ0ROMhlK8JamZiOci7f-M4uAmuM7AgmCs8Dt_0=.9345df30-4e05-4614-9d58-ae394ac9d34b@github.com> changes to make/modules/jdk.hotspot.agent/Lib.gmk are omitted ------------- Commit messages: - Backport e7c5bf45f753ad6459c666a4dd4a31197b69e05e Changes: https://git.openjdk.org/jdk21u-dev/pull/1167/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1167&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341722 Stats: 10 lines in 4 files changed: 1 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1167.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1167/head:pull/1167 PR: https://git.openjdk.org/jdk21u-dev/pull/1167 From clanger at openjdk.org Wed Nov 20 13:53:15 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 20 Nov 2024 13:53:15 GMT Subject: [jdk21u-dev] RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang In-Reply-To: <R9YVQZ0ROMhlK8JamZiOci7f-M4uAmuM7AgmCs8Dt_0=.9345df30-4e05-4614-9d58-ae394ac9d34b@github.com> References: <R9YVQZ0ROMhlK8JamZiOci7f-M4uAmuM7AgmCs8Dt_0=.9345df30-4e05-4614-9d58-ae394ac9d34b@github.com> Message-ID: <Yf-4QjZf4w_R1x6U_wzGC6ZleEr-m2EJq9HRoP34z3o=.300a84c8-4cfd-409c-8bfd-89540ec1c7e7@github.com> On Wed, 20 Nov 2024 13:37:52 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > changes to make/modules/jdk.hotspot.agent/Lib.gmk are omitted LGTM ------------- Marked as reviewed by clanger (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1167#pullrequestreview-2448679273 From goetz at openjdk.org Wed Nov 20 14:47:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 14:47:34 GMT Subject: [jdk17u-dev] RFR: 8274170: Add hooks for custom makefiles to augment jtreg test execution Message-ID: <tfrP_KXEPZgoyr1u0TtPdJ_QKzKZIxNIvuK9FXrq4t4=.abe7d40c-805b-4e36-83b6-7654b0afde40@github.com> I backport this for parity with 17.0.14-oracle. I had to resolve due to context diffs. ------------- Commit messages: - Backport 14100d55dc822a7eb4f3e499aa9077e7ad17b2a6 Changes: https://git.openjdk.org/jdk17u-dev/pull/3066/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3066&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274170 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3066.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3066/head:pull/3066 PR: https://git.openjdk.org/jdk17u-dev/pull/3066 From goetz at openjdk.org Wed Nov 20 15:24:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 15:24:31 GMT Subject: [jdk17u-dev] RFR: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use Message-ID: <rvCCt-ZQm4DmpeipbvmrJca-bASVRJaE26Q2wpwsdVI=.5ab54a09-0d19-42a4-bb5f-bec132c5c527@github.com> This was back ported to 21, it's useful in 17, too. ------------- Commit messages: - Backport 2af0312c958e693b1377f4c014ae8f84cabf6b83 Changes: https://git.openjdk.org/jdk17u-dev/pull/3067/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3067&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328619 Stats: 19 lines in 1 file changed: 7 ins; 2 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3067.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3067/head:pull/3067 PR: https://git.openjdk.org/jdk17u-dev/pull/3067 From lucy at openjdk.org Wed Nov 20 15:26:20 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Wed, 20 Nov 2024 15:26:20 GMT Subject: [jdk17u-dev] RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property [v2] In-Reply-To: <hi6ZGt0-Vlzwvez9Fxf7R7chwzINtqOOrms5TZLE0Zg=.e7ca2be0-2efb-409b-b344-1b2d6d93aab6@github.com> References: <bYXb_dXuiHVhe7G-L8Wg64Oh7WRA2VHgXbQmcQc22EI=.a4d85128-81e1-4c07-81db-c685beeff407@github.com> <hi6ZGt0-Vlzwvez9Fxf7R7chwzINtqOOrms5TZLE0Zg=.e7ca2be0-2efb-409b-b344-1b2d6d93aab6@github.com> Message-ID: <mVeW20GK0ouI7Bfbc_6lolw65v7-D_0BQSFrHLHd43U=.28906278-e288-4a57-ad21-b076263c5983@github.com> On Wed, 20 Nov 2024 09:55:54 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> I backport this for parity with Oracle 17.0.14. The backport is based on the commit to 21. >> >> Tests passed including win tests. Three files are not real tests, I double-checked these. >> >> I had to resolve a lot of files, but all except three only differed in the Copyright year. >> >> Resolved files >> ================ >> >> doc/testing.html >> Resolved. Context differences. >> >> test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestCipherKeyWrapperTest.java >> test/jdk/com/sun/crypto/provider/Cipher/PBE/DecryptWithoutParameters.java >> test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java >> test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java >> test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java >> test/jdk/com/sun/crypto/provider/Cipher/PBE/PBESealedObject.java >> test/jdk/com/sun/crypto/provider/Cipher/PBE/TestCipherKeyWrapperPBEKey.java >> test/jdk/com/sun/crypto/provider/KeyGenerator/Test4628062.java >> test/jdk/com/sun/crypto/provider/Mac/HmacPBESHA1.java >> test/jdk/com/sun/crypto/provider/Mac/HmacSaltLengths.java >> test/jdk/com/sun/crypto/provider/Mac/MacClone.java >> test/jdk/com/sun/crypto/provider/NSASuiteB/TestHmacSHAOids.java >> All these test lack 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider >> All only Copyright except for >> DecryptWithoutParameters.java: Test in 17 has less and other test cases, adapted change to this. >> >> test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestGeneral.java >> Test was modified in 18 by 8271745: Correct block size for KW,KWP mode and use fixed IV for KWP mode for SunJCE >> Test in 17 has other test cases, adapted change to this. >> >> test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestKeySizeCheck.java >> Test was modified in 8302225: SunJCE Provider doesn't validate key sizes when using 'constrained' transforms for AES/KW and AES/KWP >> Backport started. >> Resolved Copyright. >> >> test/jdk/com/sun/crypto/provider/KeyAgreement/TestExponentSize.java >> Modified in 19 by 8267319: Use larger default key sizes and algorithms based on CNSA >> Resolved Copyright. >> >> test/jdk/com/sun/jdi/ClassesByName2Test.java >> Modified by virtual threads changes. >> Resolved Copyright. >> >> test/jdk/javax/crypto/EncryptedPrivateKeyInfo/GetAlgName.java >> Modified in 20 by 8296442: EncryptedPrivateKeyInfo can be created with an uninitialized AlgorithmParameters. This is a follow-up of a cleanup change also in 20. >> Resolved Copyright. >> >> >> >> ... > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into goetz_backport_8341927 > - Backport 9bdf2a619d1d158d6c1e8e1e1238a4229e0b0783 LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3049#pullrequestreview-2448951314 From goetz at openjdk.org Wed Nov 20 15:27:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 15:27:17 GMT Subject: [jdk21u-dev] RFR: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use Message-ID: <XrfjL8ns-oGtmg9lBOMbQJnx2Hiv_bA96SCOjJ_FjVo=.fbbbc241-07aa-4698-b225-00130db061ac@github.com> I backport this for parity with 21.0.7-oracle. ------------- Commit messages: - Backport 2af0312c958e693b1377f4c014ae8f84cabf6b83 Changes: https://git.openjdk.org/jdk21u-dev/pull/1168/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1168&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328619 Stats: 19 lines in 1 file changed: 7 ins; 2 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1168.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1168/head:pull/1168 PR: https://git.openjdk.org/jdk21u-dev/pull/1168 From goetz at openjdk.org Wed Nov 20 15:51:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 15:51:24 GMT Subject: [jdk21u-dev] RFR: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11 In-Reply-To: <ik_4xDbbHRA36ppB-MHk98LYF6avCaFwShjk-gZuPmo=.5a9498e2-09bf-40ed-8dae-541b17154921@github.com> References: <ik_4xDbbHRA36ppB-MHk98LYF6avCaFwShjk-gZuPmo=.5a9498e2-09bf-40ed-8dae-541b17154921@github.com> Message-ID: <s1yxeDTyRIDqM9bmRDa6Uk9Rt-CojauSlcjD8pWKPU4=.bb50cb5d-1bd6-495f-bb8e-9faf527a046e@github.com> On Fri, 4 Oct 2024 12:01:25 GMT, Sorna Sarathi <duke at openjdk.org> wrote: > Hi all, > This pull request contains a backport of commit [3251eea](https://github.com/openjdk/jdk/commit/3251eea1f4289a0505052be204407c02ca38b0ad) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > Tier1 testing is successful. > Thanks! > > JBS Issue: [JDK-8336499](https://bugs.openjdk.org/browse/JDK-8336499) Hi @Sorna-Sarathi , please enable GHA actions and trigger a rerun. Please do more extensive testing of this change. Tier 1 is not sufficient for a change in a important component as security. Please give a more detailed backport comment, see also https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix Further, I would propose to defer this to the April update, so that it has at least some coverage by 24. It's a pity you missed 23, that's closed as far as I know. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1021#issuecomment-2488944307 From goetz at openjdk.org Wed Nov 20 16:02:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Nov 2024 16:02:50 GMT Subject: [jdk21u-dev] RFR: 8319678: Several tests from corelibs areas ignore VM flags Message-ID: <KnpVte01t8ywfiASdkMkCfWyZksqxDkrT2dbgWKSVOk=.90656f4d-ad07-48fb-8797-2ff944f2ca26@github.com> I backport this for parity with 21.0.7-oracle. Resolved HijrahConfigTest.java because "8315444: Convert test/jdk/tools to Classfile API" is not in 21 ------------- Commit messages: - Backport 2e3682a7f2983cd58b9564253dc698760faba4b8 Changes: https://git.openjdk.org/jdk21u-dev/pull/1169/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1169&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319678 Stats: 161 lines in 6 files changed: 56 ins; 58 del; 47 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1169.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1169/head:pull/1169 PR: https://git.openjdk.org/jdk21u-dev/pull/1169 From andrew at openjdk.org Wed Nov 20 16:54:34 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 20 Nov 2024 16:54:34 GMT Subject: [jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v3] In-Reply-To: <x3HsZv4qmSYA8PuYkxSzpOB9xDPyYEKcu-ispJXNkU8=.d7ac8df1-6377-446c-8223-754c98b240a9@github.com> References: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> <x3HsZv4qmSYA8PuYkxSzpOB9xDPyYEKcu-ispJXNkU8=.d7ac8df1-6377-446c-8223-754c98b240a9@github.com> Message-ID: <0xDMTzGJUF2xBrp1KpKe9trx6HCoJk-TLf-slW6gACQ=.bfdf827b-f75f-4792-a857-013be0c3f91f@github.com> On Tue, 19 Nov 2024 14:08:39 GMT, Antonio Vieiro <duke at openjdk.org> wrote: >> An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions. >> >> The PR is separated in three commits for easier review: >> >> - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables: >> - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used) >> - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used). >> - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14). >> - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`). >> >> Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`. > > Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: > > Removed doc instructions as per review I don't think this is the right approach. This new flag is called `--enable-xcode14`, but its implementation has nothing to do with the compiler version or enabling XCode 14. It simply adds additional compiler flags to disable the warnings. Someone can add `--enable-xcode14` with 13 installed and these flags will be added (and presumably the build will fail, as you said these flags are not supported there). Alternatively, someone could have XCode 14 and not know about this flag, and it still fail to build. Also, I fail to see the point of the macosx check, because presumably this is due to a new version of clang that is part of XCode 14, and so the build would fail if someone uses that version of clang on Linux. If these flags are needed for builds with XCode 14, we should detect that this newer compiler is being used and add them automatically. In fact, ideally, you should not depend on the version at all but test the compiler with the flag and add it if it works. Take a look at `FLAGS_SETUP_GCC6_COMPILER_FLAGS` also in `flags-cflags.m4` You also don't need to define your own variables and pepper them all over every Makefile. This should be something handled in `FLAGS_SETUP_CFLAGS_HELPER`. Look at the area around line 587 where warnings are added to gcc and clang. They are already different there for Linux and MacOS for the JDK. Detecting whether these new flags work and then adding them to `WARNING_CFLAGS_JVM` and `WARNING_CFLAGS_JDK` looks the right way to go. ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2966#pullrequestreview-2449203122 From duke at openjdk.org Wed Nov 20 19:45:48 2024 From: duke at openjdk.org (Chad Rakoczy) Date: Wed, 20 Nov 2024 19:45:48 GMT Subject: [jdk21u-dev] RFR: 8341194: [REDO] Implement C2 VectorizedHashCode on AArch64 Message-ID: <D49WFHgrecB8cjqvr6q3_5WOE_GXgBobwH-mqXRrJGk=.9938536c-92df-4690-9717-4707afd8e36a@github.com> Backport [JDK-8341194](https://bugs.openjdk.org/browse/JDK-8341194) [REDO] Implement C2 VectorizedHashCode on AArch64 Backport is clean. Trivial merge conflicts with includes and already present code. Original implementation [JDK-8322770](https://bugs.openjdk.org/browse/JDK-8322770) caused build and test failures. Build failures that were reproducible with `make bootcycle-images` run on `linux-aarch64 fastdebug/release` successfully. All jtreg and new asmtest pass on `linux-aarch64 release`. ------------- Commit messages: - Backport 4fc6d4135e795d18a024a6035908f380b81082d1 Changes: https://git.openjdk.org/jdk21u-dev/pull/1170/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1170&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341194 Stats: 1329 lines in 12 files changed: 748 ins; 0 del; 581 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1170.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1170/head:pull/1170 PR: https://git.openjdk.org/jdk21u-dev/pull/1170 From abakhtin at openjdk.org Wed Nov 20 22:20:07 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 20 Nov 2024 22:20:07 GMT Subject: [jdk21u-dev] Integrated: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 In-Reply-To: <ycrgV0SkY2VIAqm3MvkFGXRQiqk4R-jleid_-dLQ7DQ=.f81a371f-2114-49fe-a7e8-e5f5498abc75@github.com> References: <ycrgV0SkY2VIAqm3MvkFGXRQiqk4R-jleid_-dLQ7DQ=.f81a371f-2114-49fe-a7e8-e5f5498abc75@github.com> Message-ID: <dJ4vOr2VX9E9OXI1UKfa3VhGhPjMXBe9Q3tmUlH8VuY=.98d13261-3d37-4d8b-99d1-95ac2cf57113@github.com> On Tue, 19 Nov 2024 22:06:38 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote: > I'd like to backport it as a follow-up for JDK-8179502 > > Backport is clean > All related JTREG tests passed This pull request has now been integrated. Changeset: 2029e4e1 Author: Alexey Bakhtin <abakhtin at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/2029e4e1de9283a4e3dcb11195949b2f07f03dd6 Stats: 105 lines in 2 files changed: 46 ins; 24 del; 35 mod 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 Backport-of: 9b11bd7f4a511ddadf9f02e82aab6ba78beb6763 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1162 From syan at openjdk.org Thu Nov 21 02:02:29 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:02:29 GMT Subject: [jdk17u-dev] RFR: 8336257: Additional tests in jmxremote/startstop to match on PID not app name In-Reply-To: <yra7M13ESSoAlsk2k8MsWxE-GXR5Cebckkve-lo8Wfs=.6bfa80a4-2c02-48c4-8ff3-b3bf3618057f@github.com> References: <yra7M13ESSoAlsk2k8MsWxE-GXR5Cebckkve-lo8Wfs=.6bfa80a4-2c02-48c4-8ff3-b3bf3618057f@github.com> Message-ID: <47sebNP_n2NRhVKA5QuFVsMjhqjCIcvUAOBSPRjECWg=.3cb39cd7-9382-4948-9d1b-83195bce9e1c@github.com> On Tue, 19 Nov 2024 15:25:23 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [687601eb](https://github.com/openjdk/jdk/commit/687601ebcaedf133fd4d5cecc42c5aadf9c73f3c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer, Alan Bateman, Alex Menkov and Daniel D. Daugherty. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3060#issuecomment-2489907664 From syan at openjdk.org Thu Nov 21 02:02:29 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:02:29 GMT Subject: [jdk17u-dev] Integrated: 8336257: Additional tests in jmxremote/startstop to match on PID not app name In-Reply-To: <yra7M13ESSoAlsk2k8MsWxE-GXR5Cebckkve-lo8Wfs=.6bfa80a4-2c02-48c4-8ff3-b3bf3618057f@github.com> References: <yra7M13ESSoAlsk2k8MsWxE-GXR5Cebckkve-lo8Wfs=.6bfa80a4-2c02-48c4-8ff3-b3bf3618057f@github.com> Message-ID: <g6gTkDwIiieKL46Coxpvp0SiMfI5WFdpN9sq0kPTQFk=.21cbd58b-6dca-4c8d-ba14-0873a0c85a3b@github.com> On Tue, 19 Nov 2024 15:25:23 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [687601eb](https://github.com/openjdk/jdk/commit/687601ebcaedf133fd4d5cecc42c5aadf9c73f3c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer, Alan Bateman, Alex Menkov and Daniel D. Daugherty. > > Thanks! This pull request has now been integrated. Changeset: 848d8e83 Author: SendaoYan <syan at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/848d8e830edb946238661fdedb3c931c3b0f9687 Stats: 6 lines in 2 files changed: 2 ins; 1 del; 3 mod 8336257: Additional tests in jmxremote/startstop to match on PID not app name Backport-of: 5b1a9521de45394817aa36dbf007e69a60c92604 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3060 From andrew at openjdk.org Thu Nov 21 02:13:26 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 21 Nov 2024 02:13:26 GMT Subject: [jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v3] In-Reply-To: <x3HsZv4qmSYA8PuYkxSzpOB9xDPyYEKcu-ispJXNkU8=.d7ac8df1-6377-446c-8223-754c98b240a9@github.com> References: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> <x3HsZv4qmSYA8PuYkxSzpOB9xDPyYEKcu-ispJXNkU8=.d7ac8df1-6377-446c-8223-754c98b240a9@github.com> Message-ID: <j6Kyl5cagbOfoeLfN0xOJpgoNaNAqAaBk73x4QEFE_c=.fe18d057-91d4-458f-9a59-89570bedc701@github.com> On Tue, 19 Nov 2024 14:08:39 GMT, Antonio Vieiro <duke at openjdk.org> wrote: >> An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions. >> >> The PR is separated in three commits for easier review: >> >> - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables: >> - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used) >> - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used). >> - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14). >> - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`). >> >> Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`. > > Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: > > Removed doc instructions as per review I tried with clang 15, 16, 17 & 18 on Linux and did not see similar errors with `-Wdeprecated-declarations` and `-Wdeprecated-non-prototype`. With `--disable-warnings-as-errors` on, it gets as far as running the built JDK, which then segfaults. I think this may be due to undefined behaviour issues mentioned in [JDK-8229258](https://bugs.openjdk.org/browse/JDK-8229258) and [JDK-8276453](https://bugs.openjdk.org/browse/JDK-8276453) With warnings as errors on (the default), it fails with: ~~~ + /usr/bin/head -n 15 /localhome/andrew/projects/openjdk/upstream/jdk11u-dev/src/hotspot/share/compiler/compilerDefinitions.cpp:85:13: error: implicit conversion from 'const intx' (aka 'const long') to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-const-int-float-conversion] if (v > max_intx) { ~ ^~~~~~~~ 1 error generated. ~~~ which I believe is [JDK-8287052](https://bugs.openjdk.org/browse/JDK-8287052) Is `--disable-warnings-as-errors` not sufficient to make the GHA build work on MacOS 13? It's not an ideal solution but it's a less disruptive way to keep a working MacOS build in the short term. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2966#issuecomment-2489920360 From syan at openjdk.org Thu Nov 21 02:21:45 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:21:45 GMT Subject: [jdk21u-dev] RFR: 8344526: RISC-V: implement -XX:+VerifyActivationFrameSize Message-ID: <297zWAZrSCd5lMhAOyVnlug0QjluJ6nWlbNmgPqvU0o=.6a96ca36-73cd-493a-bad7-3a3641529368@github.com> Hi all, This pull request contains a backport of commit [4fbf2720](https://github.com/openjdk/jdk/commit/4fbf272017d2f6933e66f8a67cb88e3ffc42339e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 21 Nov 2024 and was reviewed by Hamlin Li and Fei Yang. Thanks! ------------- Commit messages: - Backport 4fbf272017d2f6933e66f8a67cb88e3ffc42339e Changes: https://git.openjdk.org/jdk21u-dev/pull/1171/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1171&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344526 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1171.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1171/head:pull/1171 PR: https://git.openjdk.org/jdk21u-dev/pull/1171 From syan at openjdk.org Thu Nov 21 02:35:24 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:35:24 GMT Subject: [jdk21u-dev] RFR: 8344526: RISC-V: implement -XX:+VerifyActivationFrameSize In-Reply-To: <297zWAZrSCd5lMhAOyVnlug0QjluJ6nWlbNmgPqvU0o=.6a96ca36-73cd-493a-bad7-3a3641529368@github.com> References: <297zWAZrSCd5lMhAOyVnlug0QjluJ6nWlbNmgPqvU0o=.6a96ca36-73cd-493a-bad7-3a3641529368@github.com> Message-ID: <3YcFZNmGLe12xQc4RewFj5FfTjhpJXVvrj_HGFMY4O8=.f61dc308-b568-4229-b2f1-6ee6d0682dc1@github.com> On Thu, 21 Nov 2024 02:17:03 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [4fbf2720](https://github.com/openjdk/jdk/commit/4fbf272017d2f6933e66f8a67cb88e3ffc42339e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 21 Nov 2024 and was reviewed by Hamlin Li and Fei Yang. > > Thanks! I think it's not quite strong necessary to backport this PR, sorry for the interrupt. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1171#issuecomment-2489940497 From syan at openjdk.org Thu Nov 21 02:35:26 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:35:26 GMT Subject: [jdk21u-dev] RFR: 8344356: Aarch64: implement -XX:+VerifyActivationFrameSize In-Reply-To: <XM84u_KZv5ayaSLdVY7zihhMirPYokjdvDVHJOf83L8=.b0816402-7c71-4f2e-a907-55dbb1e39e7d@github.com> References: <XM84u_KZv5ayaSLdVY7zihhMirPYokjdvDVHJOf83L8=.b0816402-7c71-4f2e-a907-55dbb1e39e7d@github.com> Message-ID: <S8rvS-CZosEoulVUdAdJNDzh9KICXRin_fgniyk6KcE=.16d81288-b530-41fa-9c44-8f24b52fe896@github.com> On Wed, 20 Nov 2024 01:59:00 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [4ddd3dec](https://github.com/openjdk/jdk/commit/4ddd3dec2d0b232d48646ca89b16591b3026aa5c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 20 Nov 2024 and was reviewed by Andrew Haley. > > Thanks! I think it's not quite strong necessary to backport this PR, sorry for the interrupt. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1163#issuecomment-2489940583 From syan at openjdk.org Thu Nov 21 02:35:25 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:35:25 GMT Subject: [jdk21u-dev] Withdrawn: 8344526: RISC-V: implement -XX:+VerifyActivationFrameSize In-Reply-To: <297zWAZrSCd5lMhAOyVnlug0QjluJ6nWlbNmgPqvU0o=.6a96ca36-73cd-493a-bad7-3a3641529368@github.com> References: <297zWAZrSCd5lMhAOyVnlug0QjluJ6nWlbNmgPqvU0o=.6a96ca36-73cd-493a-bad7-3a3641529368@github.com> Message-ID: <YUqSYOW-r_K0P5MuNyESqks3BX0pIWSXD_6l82H2JxM=.9c15774b-79a0-4fbb-8d96-849e8453ac7d@github.com> On Thu, 21 Nov 2024 02:17:03 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [4fbf2720](https://github.com/openjdk/jdk/commit/4fbf272017d2f6933e66f8a67cb88e3ffc42339e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 21 Nov 2024 and was reviewed by Hamlin Li and Fei Yang. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1171 From syan at openjdk.org Thu Nov 21 02:35:31 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:35:31 GMT Subject: [jdk23u] RFR: 8344356: Aarch64: implement -XX:+VerifyActivationFrameSize In-Reply-To: <wJm_yhPLaxOkOOUcDt5iaPcw3mSA40R2MtVGrtnQ0GQ=.5c230159-8458-461d-96cc-f5f8306792c8@github.com> References: <wJm_yhPLaxOkOOUcDt5iaPcw3mSA40R2MtVGrtnQ0GQ=.5c230159-8458-461d-96cc-f5f8306792c8@github.com> Message-ID: <Yk8aXFCS6gR_A_ZLhrYYPUH15wkOqq0rJnOKadtPaBs=.de7494b7-5429-47ad-92f9-6f93007be2f9@github.com> On Wed, 20 Nov 2024 01:58:50 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [4ddd3dec](https://github.com/openjdk/jdk/commit/4ddd3dec2d0b232d48646ca89b16591b3026aa5c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 20 Nov 2024 and was reviewed by Andrew Haley. > > Thanks! I think it's not quite strong necessary to backport this PR, sorry for the interrupt. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/228#issuecomment-2489940622 From syan at openjdk.org Thu Nov 21 02:35:26 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:35:26 GMT Subject: [jdk21u-dev] Withdrawn: 8344356: Aarch64: implement -XX:+VerifyActivationFrameSize In-Reply-To: <XM84u_KZv5ayaSLdVY7zihhMirPYokjdvDVHJOf83L8=.b0816402-7c71-4f2e-a907-55dbb1e39e7d@github.com> References: <XM84u_KZv5ayaSLdVY7zihhMirPYokjdvDVHJOf83L8=.b0816402-7c71-4f2e-a907-55dbb1e39e7d@github.com> Message-ID: <k4jxb5hF4Ub6Am9KsspwY7Svd0N2rZT24AO5eGjle8w=.7d01a95d-1f66-49ae-9c90-cc5e3a604045@github.com> On Wed, 20 Nov 2024 01:59:00 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [4ddd3dec](https://github.com/openjdk/jdk/commit/4ddd3dec2d0b232d48646ca89b16591b3026aa5c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 20 Nov 2024 and was reviewed by Andrew Haley. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1163 From syan at openjdk.org Thu Nov 21 02:35:31 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:35:31 GMT Subject: [jdk23u] Withdrawn: 8344356: Aarch64: implement -XX:+VerifyActivationFrameSize In-Reply-To: <wJm_yhPLaxOkOOUcDt5iaPcw3mSA40R2MtVGrtnQ0GQ=.5c230159-8458-461d-96cc-f5f8306792c8@github.com> References: <wJm_yhPLaxOkOOUcDt5iaPcw3mSA40R2MtVGrtnQ0GQ=.5c230159-8458-461d-96cc-f5f8306792c8@github.com> Message-ID: <BYVltJ8LhdpJiHI9LpONfkk08xu2Y1v5YcFs1dBYHxY=.302b32ee-9b76-49e5-81ac-ef33d2b3556c@github.com> On Wed, 20 Nov 2024 01:58:50 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [4ddd3dec](https://github.com/openjdk/jdk/commit/4ddd3dec2d0b232d48646ca89b16591b3026aa5c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 20 Nov 2024 and was reviewed by Andrew Haley. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk23u/pull/228 From syan at openjdk.org Thu Nov 21 02:43:18 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:43:18 GMT Subject: [jdk23u] RFR: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags In-Reply-To: <v62xJP4t60KMpQIAmvQMMKGbFciWTOmkX0pCRCSHFAc=.2b23870d-0bed-476b-8410-7e951bb13ee2@github.com> References: <v62xJP4t60KMpQIAmvQMMKGbFciWTOmkX0pCRCSHFAc=.2b23870d-0bed-476b-8410-7e951bb13ee2@github.com> Message-ID: <6l_w5GhZEod2tIpp2Q1MGsz3AeZZ2E6bR6l4DPlJ8Ig=.42fed048-5323-4094-94fc-05fe8c231b58@github.com> On Wed, 6 Nov 2024 01:46:28 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [5e021cbc](https://github.com/openjdk/jdk/commit/5e021cbcc7a6cb30a27380950e115ff12846239c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Leonid Mesnik on 7 Aug 2024 and was reviewed by Magnus Ihse Bursie. > > Thanks! jdk23u repo seems not needed to backport. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/216#issuecomment-2489948350 From syan at openjdk.org Thu Nov 21 02:43:18 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:43:18 GMT Subject: [jdk23u] Withdrawn: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags In-Reply-To: <v62xJP4t60KMpQIAmvQMMKGbFciWTOmkX0pCRCSHFAc=.2b23870d-0bed-476b-8410-7e951bb13ee2@github.com> References: <v62xJP4t60KMpQIAmvQMMKGbFciWTOmkX0pCRCSHFAc=.2b23870d-0bed-476b-8410-7e951bb13ee2@github.com> Message-ID: <LBxARkkpQqCKZ0oIi5zeysIRLzj8gRXKdv_SUc0InM0=.b6f8acbd-281a-496b-adff-a168b8142f94@github.com> On Wed, 6 Nov 2024 01:46:28 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [5e021cbc](https://github.com/openjdk/jdk/commit/5e021cbcc7a6cb30a27380950e115ff12846239c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Leonid Mesnik on 7 Aug 2024 and was reviewed by Magnus Ihse Bursie. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk23u/pull/216 From syan at openjdk.org Thu Nov 21 02:43:22 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:43:22 GMT Subject: [jdk23u] Withdrawn: 8339892: Several security shell tests don't set TESTJAVAOPTS In-Reply-To: <F25RZoZxQPHv1fbG4sLG0ihL9K38tmZV-r9_ZkJuiIg=.503583d7-9977-48bb-9611-c6e0b30328a0@github.com> References: <F25RZoZxQPHv1fbG4sLG0ihL9K38tmZV-r9_ZkJuiIg=.503583d7-9977-48bb-9611-c6e0b30328a0@github.com> Message-ID: <rsr4c8UBnlPyeX5OfzalnLzf0-OBxTmXvX7_Sh8LaEk=.96553390-3a96-4355-a646-64280d8adb43@github.com> On Wed, 13 Nov 2024 08:47:33 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8a2a75e5](https://github.com/openjdk/jdk/commit/8a2a75e56de4497da48f43b3be3eb71bf3ef75ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sonia Zaldana Calles on 12 Nov 2024 and was reviewed by Valerie Peng. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk23u/pull/225 From syan at openjdk.org Thu Nov 21 02:43:28 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:43:28 GMT Subject: [jdk23u] RFR: 8207908: JMXStatusTest.java fails assertion intermittently In-Reply-To: <0wIyVGFPnXdRo2zyJaYxzfqTneYIAF19jOPk7CZndHo=.63d488c6-1ee9-4773-aa5f-bc6aca90f4f3@github.com> References: <0wIyVGFPnXdRo2zyJaYxzfqTneYIAF19jOPk7CZndHo=.63d488c6-1ee9-4773-aa5f-bc6aca90f4f3@github.com> Message-ID: <cfif21VW_I1tEuQdUtoMahSWqv3rJSNymIr8l4pZIow=.f7780df8-5c9d-4bdc-84dc-e8abc27cad9c@github.com> On Tue, 5 Nov 2024 07:26:55 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [b7d0eff5](https://github.com/openjdk/jdk/commit/b7d0eff5ad77e338b237773d2fc047eea3d2ac12) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer and Alex Menkov. > > Thanks! jdk23u repo seems not needed to backport. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/215#issuecomment-2489948449 From syan at openjdk.org Thu Nov 21 02:43:28 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:43:28 GMT Subject: [jdk23u] Withdrawn: 8207908: JMXStatusTest.java fails assertion intermittently In-Reply-To: <0wIyVGFPnXdRo2zyJaYxzfqTneYIAF19jOPk7CZndHo=.63d488c6-1ee9-4773-aa5f-bc6aca90f4f3@github.com> References: <0wIyVGFPnXdRo2zyJaYxzfqTneYIAF19jOPk7CZndHo=.63d488c6-1ee9-4773-aa5f-bc6aca90f4f3@github.com> Message-ID: <Y_RX3I-yBkmB3kpEx_glReF7Tl_vF_vRzK9PXxcnjeY=.b74ed321-8b18-4f84-ba72-28f2116ce058@github.com> On Tue, 5 Nov 2024 07:26:55 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [b7d0eff5](https://github.com/openjdk/jdk/commit/b7d0eff5ad77e338b237773d2fc047eea3d2ac12) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer and Alex Menkov. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk23u/pull/215 From syan at openjdk.org Thu Nov 21 02:43:22 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:43:22 GMT Subject: [jdk23u] RFR: 8339892: Several security shell tests don't set TESTJAVAOPTS In-Reply-To: <F25RZoZxQPHv1fbG4sLG0ihL9K38tmZV-r9_ZkJuiIg=.503583d7-9977-48bb-9611-c6e0b30328a0@github.com> References: <F25RZoZxQPHv1fbG4sLG0ihL9K38tmZV-r9_ZkJuiIg=.503583d7-9977-48bb-9611-c6e0b30328a0@github.com> Message-ID: <kkHBxc3mOeoryA8ZW1-8mNwH3qxQ6GDYCWH-XGtbp5U=.a28a08d1-482d-4787-9fdd-e1192a2117d7@github.com> On Wed, 13 Nov 2024 08:47:33 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [8a2a75e5](https://github.com/openjdk/jdk/commit/8a2a75e56de4497da48f43b3be3eb71bf3ef75ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sonia Zaldana Calles on 12 Nov 2024 and was reviewed by Valerie Peng. > > Thanks! jdk23u repo seems not needed to backport. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/225#issuecomment-2489948734 From syan at openjdk.org Thu Nov 21 02:44:25 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:44:25 GMT Subject: [jdk11u-dev] RFR: 8204267: Generate comments in -XX:+PrintInterpreter to link to source code In-Reply-To: <GW_C66bE_JwBvdBb1VOVkI5WCFtjS7p_TMVcNCkg-yI=.a1e02012-653c-4243-a035-bb583ab60a32@github.com> References: <GW_C66bE_JwBvdBb1VOVkI5WCFtjS7p_TMVcNCkg-yI=.a1e02012-653c-4243-a035-bb583ab60a32@github.com> Message-ID: <2pH3_znofbn0GsF4akCfBamJq3r0D1gsIo_K0R5c_cM=.785529ca-5e63-4913-a4c0-a5e96ece96a6@github.com> On Sat, 19 Oct 2024 08:25:50 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > HotSpot's interpreter is dynamically generated (by C++ sources such as src/hotspot/cpu/x86/templateTable_x86.cpp). > > The command `java -XX:+PrintInterpreter` can be used to print a disassembly of the HotSpot interpreter. However, the output has very little comment, and it's very hard to associate the assembler instructions with the C++ code that generates them. > > To make it easier to understand the -XX:+PrintInterpreter, we should generate comments to link the instructions back to the C++ source code that generates them. This is doable because much of the interpreter code generation is done via a macro "__". We can redefine this macro to generate comments. > > The file `src/hotspot/share/compiler/disassembler.cpp` has different context cause this PR can't backport cleanly, all other files are backport cleanly. > > Only change the behavior of `PrintInterpreter`, risk is low. > > Additional testing: > > - [x] linux x64 build with fastdebug and slowdebug configure > - [x] linux x64 jtreg tests(include tier1/2/3 etc.) with release build > - [x] linux aarch64 jtreg tests(include tier1/2/3 etc.) with release build > > > Thanks. I think it's not quite strong necessary to backport this PR, sorry for the interrupt. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2957#issuecomment-2489949609 From syan at openjdk.org Thu Nov 21 02:44:25 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:44:25 GMT Subject: [jdk11u-dev] Withdrawn: 8204267: Generate comments in -XX:+PrintInterpreter to link to source code In-Reply-To: <GW_C66bE_JwBvdBb1VOVkI5WCFtjS7p_TMVcNCkg-yI=.a1e02012-653c-4243-a035-bb583ab60a32@github.com> References: <GW_C66bE_JwBvdBb1VOVkI5WCFtjS7p_TMVcNCkg-yI=.a1e02012-653c-4243-a035-bb583ab60a32@github.com> Message-ID: <dk0EAa2i71WrVhBrrQ5reoQCQTLZmAnMMQvVxuYxI9Q=.f5e48df3-bd48-45df-8d54-b0ec5f972d49@github.com> On Sat, 19 Oct 2024 08:25:50 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > HotSpot's interpreter is dynamically generated (by C++ sources such as src/hotspot/cpu/x86/templateTable_x86.cpp). > > The command `java -XX:+PrintInterpreter` can be used to print a disassembly of the HotSpot interpreter. However, the output has very little comment, and it's very hard to associate the assembler instructions with the C++ code that generates them. > > To make it easier to understand the -XX:+PrintInterpreter, we should generate comments to link the instructions back to the C++ source code that generates them. This is doable because much of the interpreter code generation is done via a macro "__". We can redefine this macro to generate comments. > > The file `src/hotspot/share/compiler/disassembler.cpp` has different context cause this PR can't backport cleanly, all other files are backport cleanly. > > Only change the behavior of `PrintInterpreter`, risk is low. > > Additional testing: > > - [x] linux x64 build with fastdebug and slowdebug configure > - [x] linux x64 jtreg tests(include tier1/2/3 etc.) with release build > - [x] linux aarch64 jtreg tests(include tier1/2/3 etc.) with release build > > > Thanks. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2957 From syan at openjdk.org Thu Nov 21 02:44:31 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:44:31 GMT Subject: [jdk11u-dev] RFR: 8341806: Gcc version detection failure on Alinux3 In-Reply-To: <FSbmKoAdq0_AWIXCuB_knUlkdtuzqpXJGgXptIZWU7k=.6629d34c-eb65-4cc0-baf6-f4fdb6793959@github.com> References: <FSbmKoAdq0_AWIXCuB_knUlkdtuzqpXJGgXptIZWU7k=.6629d34c-eb65-4cc0-baf6-f4fdb6793959@github.com> Message-ID: <iW1YogjuQtBU64wSkHGJHVpMmOmlJ0VYeQTRckm_Ivk=.1c1a0d97-0685-41a8-9833-98b4e3c49428@github.com> On Fri, 18 Oct 2024 07:24:22 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [ace44e56](https://github.com/openjdk/jdk/commit/ace44e564ffe67af5fc25a0f126cf48da0eca078) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 11 Oct 2024 and was reviewed by Magnus Ihse Bursie and Julian Waters. > > Thanks! I think it's not quite strong necessary to backport this PR, sorry for the interrupt. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2956#issuecomment-2489949714 From syan at openjdk.org Thu Nov 21 02:44:31 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:44:31 GMT Subject: [jdk11u-dev] Withdrawn: 8341806: Gcc version detection failure on Alinux3 In-Reply-To: <FSbmKoAdq0_AWIXCuB_knUlkdtuzqpXJGgXptIZWU7k=.6629d34c-eb65-4cc0-baf6-f4fdb6793959@github.com> References: <FSbmKoAdq0_AWIXCuB_knUlkdtuzqpXJGgXptIZWU7k=.6629d34c-eb65-4cc0-baf6-f4fdb6793959@github.com> Message-ID: <S81qQpvLsGC1ZFJMM26TImH8MPiwUZU9amdEE2J4CxM=.f26d677a-a483-4413-8fe5-c99257afdb20@github.com> On Fri, 18 Oct 2024 07:24:22 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [ace44e56](https://github.com/openjdk/jdk/commit/ace44e564ffe67af5fc25a0f126cf48da0eca078) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 11 Oct 2024 and was reviewed by Magnus Ihse Bursie and Julian Waters. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2956 From duke at openjdk.org Thu Nov 21 04:20:18 2024 From: duke at openjdk.org (duke) Date: Thu, 21 Nov 2024 04:20:18 GMT Subject: [jdk21u-dev] RFR: 8343884: [s390x] Disallow OptoScheduling In-Reply-To: <Rn0cj-l5pnagAS9RtY_RVHSp8momKJYV4WMeSs8JwjI=.cd4983ea-571a-4d40-b358-9ec2b9ce68a4@github.com> References: <Rn0cj-l5pnagAS9RtY_RVHSp8momKJYV4WMeSs8JwjI=.cd4983ea-571a-4d40-b358-9ec2b9ce68a4@github.com> Message-ID: <Ps7XjmvGXvdhJ0P3UzoCciDxf003L1pIYM2sv-gxtyo=.1406b987-6ab7-4e4a-acb8-cdda8d27d053@github.com> On Wed, 20 Nov 2024 03:52:29 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [7540fa21](https://github.com/openjdk/jdk/commit/7540fa2147ff8fc9c652ef13548f72f27e2809a8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 19 Nov 2024 and was reviewed by Lutz Schmidt. > > Thanks! @offamitkumar Your change (at version 2714827154f85a0f1152f2e075009fddae2857d7) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1164#issuecomment-2490035471 From duke at openjdk.org Thu Nov 21 05:41:17 2024 From: duke at openjdk.org (akhilesh-delphix) Date: Thu, 21 Nov 2024 05:41:17 GMT Subject: [jdk17u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases In-Reply-To: <ko2XNBOU5qMYP2Z7xptFtAZTYqSjTBIsoVfFKrnRKXE=.907bca5a-201f-47f1-85e3-9494d58b789e@github.com> References: <h8hHnXMIy1TI1faMK7SBqjQeANYWMLn1zor8lwQYe90=.938dd42a-076f-4552-9be1-06a965f240e8@github.com> <1UUqQN-7Z73RTII7FWXHU6iNA9QEIHEdh42lEewXD3s=.cde8dd2b-6c02-4490-981c-9dd4f2c1c622@github.com> <OFfLc5lReGZGy7aP7gE1fSHeincCe1kfBkYKEryh-0Y=.2271bd43-361f-489d-a42d-58e21a44bd88@github.com> <ko2XNBOU5qMYP2Z7xptFtAZTYqSjTBIsoVfFKrnRKXE=.907bca5a-201f-47f1-85e3-9494d58b789e@github.com> Message-ID: <Qv1CybCBBy1L6PAUODh5r9DnHK17Z0Pe_4qbqF5SzTE=.a427bbc5-13e2-4086-bb5d-8ca21fbf4ea0@github.com> On Thu, 14 Nov 2024 18:53:15 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote: >>> java.nio.file.FileSystemException: app.jar: Function not implemented >> >> This looks like a different issue. > >> java.nio.file.FileSystemException: app.jar: Function not implemented > > @akhilesh-delphix, It looks like a similar issue, but the state syscall returns `ENOSYS` error code instead of `EPERM`. So, this PR does not fix your issue. > Could you please describe your environment? Maybe we will need a follow-up to handle `ENOSYS` as well. hi @alexeybakhtin I have a alpine:3.19.0 based docker image which is getting deployed as Pod in K8s deployment. It deploys well for all customers except this one where we are facing the above issue: **Container runtime** `containerd://1.7.20-k3s1` **kubectl version** Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.0", GitCommit:"1b4df30b3cdfeaba6024e81e559a6cd09a089d65", GitTreeState:"clean", BuildDate:"2023-04-11T17:10:18Z", GoVersion:"go1.20.3", Compiler:"gc", Platform:"windows/amd64"} Kustomize Version: v5.0.1 Server Version: version.Info{Major:"1", Minor:"30", GitVersion:"v1.30.4+rke2r1", GitCommit:"a51b3b711150f57ffc1f526a640ec058514ed596", GitTreeState:"clean", BuildDate:"2024-08-15T06:00:17Z", GoVersion:"go1.22.5 X:boringcrypto", Compiler:"gc", Platform:"linux/amd64"} WARNING: version difference between client (1.27) and server (1.30) exceeds the supported minor version skew of +/-1 Java Version `openjdk version "17.0.12" 2024-07-16 ` Please let me know if you require more details. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2883#issuecomment-2490120770 From duke at openjdk.org Thu Nov 21 07:17:17 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 21 Nov 2024 07:17:17 GMT Subject: [jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v3] In-Reply-To: <0xDMTzGJUF2xBrp1KpKe9trx6HCoJk-TLf-slW6gACQ=.bfdf827b-f75f-4792-a857-013be0c3f91f@github.com> References: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> <x3HsZv4qmSYA8PuYkxSzpOB9xDPyYEKcu-ispJXNkU8=.d7ac8df1-6377-446c-8223-754c98b240a9@github.com> <0xDMTzGJUF2xBrp1KpKe9trx6HCoJk-TLf-slW6gACQ=.bfdf827b-f75f-4792-a857-013be0c3f91f@github.com> Message-ID: <8wlvCGk6AF3acoynYt9_B90M64A24q_z46b5iNXIIdY=.403b7887-21ee-4592-9425-65badbab77e3@github.com> On Wed, 20 Nov 2024 16:52:03 GMT, Andrew John Hughes <andrew at openjdk.org> wrote: > [...] > If these flags are needed for builds with XCode 14, we should detect that this newer compiler is being used and add them automatically. In fact, ideally, you should not depend on the version at all but test the compiler with the flag and add it if it works. Take a look at `FLAGS_SETUP_GCC6_COMPILER_FLAGS` also in `flags-cflags.m4` > [...] Yep, I came to the same conclusion in the updates_dev mailing list after pushing. The flag was useful to try to compile on XCode 13 and XCode 14 during experiments, but detecting the compiler is probably the way to go. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2966#issuecomment-2490243260 From duke at openjdk.org Thu Nov 21 07:21:27 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 21 Nov 2024 07:21:27 GMT Subject: [jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v3] In-Reply-To: <j6Kyl5cagbOfoeLfN0xOJpgoNaNAqAaBk73x4QEFE_c=.fe18d057-91d4-458f-9a59-89570bedc701@github.com> References: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> <x3HsZv4qmSYA8PuYkxSzpOB9xDPyYEKcu-ispJXNkU8=.d7ac8df1-6377-446c-8223-754c98b240a9@github.com> <j6Kyl5cagbOfoeLfN0xOJpgoNaNAqAaBk73x4QEFE_c=.fe18d057-91d4-458f-9a59-89570bedc701@github.com> Message-ID: <-A3ZGWoPuEYSzjzw27QhrW_HZHCs8BdyvPSbQv8xXJQ=.29f5d73c-9339-4b2e-b9a1-de122601e489@github.com> On Thu, 21 Nov 2024 02:10:23 GMT, Andrew John Hughes <andrew at openjdk.org> wrote: > [...] > Is `--disable-warnings-as-errors` not sufficient to make the GHA build work on MacOS 13? It's not an ideal solution but it's a less disruptive way to keep a working MacOS build in the short term. I'll give it a try. Yep, it's not ideal (we may not be able to run the tests as in https://github.com/openjdk/jdk11u-dev/pull/2967) but it's indeed less disruptive. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2966#issuecomment-2490247792 From syan at openjdk.org Thu Nov 21 07:42:52 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 07:42:52 GMT Subject: [jdk21u-dev] RFR: 8316907: Fix nonnull-compare warnings Message-ID: <7gGZLQeCEadp8uZ5ZgA_S1dbVhMgVIkGKKzTPz50tvM=.91589217-f2a1-4112-9735-e75814414fa3@github.com> Hi all, There are some gcc compile warnings which recorded by [JDK-8342304](https://bugs.openjdk.org/browse/JDK-8342304), and the PR [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) fix the gcc compile warnings. So I want to backport [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) to jdk21u-dev. But before backport [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893), we should backport [JDK-8316907](https://bugs.openjdk.org/browse/JDK-8316907) first, [JDK-8316907](https://bugs.openjdk.org/browse/JDK-8316907) solve nonnull-compare warnings emitted by GCC after removing `-fno-delete-null-pointer-checks`. Additional testing: 1. jtreg tests(include tier1/2/3 etc.) with linux-x64 release build 2. jtreg tests(include tier1/2/3 etc.) with linux-x64 fastdebug build 3. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 release build 4. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 fastdebug build ------------- Commit messages: - Backport 516cfb135f7e5fefaf6e6f2928f6ecb88806f1ef Changes: https://git.openjdk.org/jdk21u-dev/pull/1172/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1172&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316907 Stats: 6 lines in 2 files changed: 0 ins; 6 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1172.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1172/head:pull/1172 PR: https://git.openjdk.org/jdk21u-dev/pull/1172 From mbaesken at openjdk.org Thu Nov 21 08:07:21 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 21 Nov 2024 08:07:21 GMT Subject: [jdk17u-dev] RFR: 8342607: Enhance register printing on x86_64 platforms [v2] In-Reply-To: <uM23IARtt6_sGzICrmteZMHCJt9k9foQ3_O4naAO2Fk=.ee334aa5-f7fe-4f00-ba8b-293c2211e0fe@github.com> References: <UkmARLM1OQiHuX1MZB_W_CATUgpOvpxhNSbgk0CH610=.bf8d5b44-3eda-4e0f-bbfe-ec282a10696b@github.com> <uM23IARtt6_sGzICrmteZMHCJt9k9foQ3_O4naAO2Fk=.ee334aa5-f7fe-4f00-ba8b-293c2211e0fe@github.com> Message-ID: <7wc7hUC4kXZfzXlNeu5CvoPqXMGBJZVDlCkX_JPFa-4=.735ed833-4e7a-4206-88c0-e67e809cb691@github.com> On Tue, 19 Nov 2024 17:25:44 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: >> Clean backport of [JDK-8342607](https://bugs.openjdk.org/browse/JDK-8342607) plus small part of https://github.com/openjdk/jdk/commit/98ce45ff7432a56d73b51046817b5fe84a412042 (2nd commit, may help other backports, too). > > Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: > > Add small part of JDK-8292981. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3061#pullrequestreview-2450544885 From mbaesken at openjdk.org Thu Nov 21 08:10:20 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 21 Nov 2024 08:10:20 GMT Subject: [jdk21u-dev] Integrated: 8341722: Fix some warnings as errors when building on Linux with toolchain clang In-Reply-To: <R9YVQZ0ROMhlK8JamZiOci7f-M4uAmuM7AgmCs8Dt_0=.9345df30-4e05-4614-9d58-ae394ac9d34b@github.com> References: <R9YVQZ0ROMhlK8JamZiOci7f-M4uAmuM7AgmCs8Dt_0=.9345df30-4e05-4614-9d58-ae394ac9d34b@github.com> Message-ID: <BTd4uDTR5earj2WZD_55gXCtmHodnCM-SzaE7JaziKA=.49b9d7c8-6779-443b-a50d-edce2bc70c40@github.com> On Wed, 20 Nov 2024 13:37:52 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > changes to make/modules/jdk.hotspot.agent/Lib.gmk are omitted This pull request has now been integrated. Changeset: 3aa59b31 Author: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/3aa59b3139d6ca88afb4339510b0a47ec15c8959 Stats: 10 lines in 4 files changed: 1 ins; 6 del; 3 mod 8341722: Fix some warnings as errors when building on Linux with toolchain clang Reviewed-by: clanger Backport-of: e7c5bf45f753ad6459c666a4dd4a31197b69e05e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1167 From goetz at openjdk.org Thu Nov 21 08:38:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Nov 2024 08:38:26 GMT Subject: [jdk17u-dev] RFR: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use In-Reply-To: <rvCCt-ZQm4DmpeipbvmrJca-bASVRJaE26Q2wpwsdVI=.5ab54a09-0d19-42a4-bb5f-bec132c5c527@github.com> References: <rvCCt-ZQm4DmpeipbvmrJca-bASVRJaE26Q2wpwsdVI=.5ab54a09-0d19-42a4-bb5f-bec132c5c527@github.com> Message-ID: <0-9OqhJfPrN_aQwIsG0YhGFj71ioZESICd6CbiRxh1M=.01426d95-d4f0-4568-ba5c-7579c4889d05@github.com> On Wed, 20 Nov 2024 15:19:11 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > This was back ported to 21, it's useful in 17, too. GHA failure: well known wget problem, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3067#issuecomment-2490379467 From goetz at openjdk.org Thu Nov 21 08:53:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Nov 2024 08:53:15 GMT Subject: [jdk21u-dev] RFR: 8343343: Misc crash dump improvements on more platforms after JDK-8294160 [v2] In-Reply-To: <R7vBYl-swjkPgkT8PHvTGTQ8itXMNb4oIS3GmkLCdrQ=.92b0be9e-fa79-4e38-9027-ab2f8e9f03de@github.com> References: <hXGvQNmO3aDCd7QslGZqddzuwJuE3D1lRyqjagCkzjc=.e52283c1-5284-4df1-8662-b508f1649c09@github.com> <GQAnbThQLY7sLV2vsJyTWloDx9ZUrx8FP5Ul1a_UeyQ=.0b3da0a8-ca7d-454c-aa5e-23f07828a9f9@github.com> <R7vBYl-swjkPgkT8PHvTGTQ8itXMNb4oIS3GmkLCdrQ=.92b0be9e-fa79-4e38-9027-ab2f8e9f03de@github.com> Message-ID: <VuHRTpQOMeDUMeBAsYfzPkJsZa1uE_tI1CgYmnR2QDU=.3d46af2b-b099-461d-bf3f-2dfcc73fc69f@github.com> On Fri, 15 Nov 2024 14:40:58 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: >> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix aix. > > GHA failures are unrelated. Hi @TheRealMDoerr this is rather new and an enhancement. What about waiting for April update, so it is live in 24 before we backport? 21.0.7 development starts soon. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1154#issuecomment-2490411495 From goetz at openjdk.org Thu Nov 21 09:07:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Nov 2024 09:07:26 GMT Subject: [jdk21u-dev] Integrated: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use In-Reply-To: <XrfjL8ns-oGtmg9lBOMbQJnx2Hiv_bA96SCOjJ_FjVo=.fbbbc241-07aa-4698-b225-00130db061ac@github.com> References: <XrfjL8ns-oGtmg9lBOMbQJnx2Hiv_bA96SCOjJ_FjVo=.fbbbc241-07aa-4698-b225-00130db061ac@github.com> Message-ID: <L9gdy6qK0sy6liy2ymJ37VG-W_vZqlZft4CBrL1BtQE=.8b114d54-54f7-4d5a-ab50-523a526fd5a5@github.com> On Wed, 20 Nov 2024 15:18:57 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: 322fc813 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/322fc813b8e2953ab52131dbd540a1b76bc533c9 Stats: 19 lines in 1 file changed: 7 ins; 2 del; 10 mod 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use Backport-of: 2af0312c958e693b1377f4c014ae8f84cabf6b83 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1168 From goetz at openjdk.org Thu Nov 21 09:08:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Nov 2024 09:08:25 GMT Subject: [jdk21u-dev] Integrated: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <tiZYiBW8uJmweGNIrgmRNm_iqLTU-xNSSa_hIZyJUzY=.036e2ca2-54d0-413d-9c9e-65e6c03814c3@github.com> References: <tiZYiBW8uJmweGNIrgmRNm_iqLTU-xNSSa_hIZyJUzY=.036e2ca2-54d0-413d-9c9e-65e6c03814c3@github.com> Message-ID: <1E6JD-WQaf7UvFFokltOuNjy-cDGFBjQCamI-cVx7eQ=.e4067ae4-f5ed-42ee-8c46-789d3633af7d@github.com> On Fri, 8 Nov 2024 12:36:19 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.6-oracle. > The documentation of the tz update says that it is not needed > necessarily, but a cleanup of various information. I think > we should go along here. It seems to bring a row of visible changes, > and it's good if this can be mapped to the same update everywhere. > Also, this will simplify later tz updates, which happen regularly. > > CSR for update versions available. > > This is a Backport of the [jdk23u version](https://github.com/openjdk/jdk23u/commit/73b2341c670f98fb130c57f80eb1461226da1985), as the [jdk24 version](https://github.com/openjdk/jdk/commit/ebc17c7c8d6febd5a887309d1b7a466bcd2cc0a9) contains > changes breaking the Java standard. As I understand this only > affects Java 8. But Oracle avoided to bring these changes to 23, > so we should not do that in 21, either. > > In detail, the 23u version omits backport of changes to > src/java.base/share/classes/java/time/ZoneId.java > and src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java. > > In the tests changes to test/jdk/java/time/tck/java/time/TCKZoneId.java and > test/jdk/java/util/TimeZone/OldIDMappingTest.java are omited, and > test/jdk/sun/util/calendar/zi/TestZoneInfo310.java is modified differently. File > test/jdk/sun/util/calendar/zi/tzdata_jdk/tz2024b_overridden_zones > is added in 23. The change to test/jdk/sun/util/resources/TimeZone/Bug4848242.java differs, too. > > **Needed adaptions:** > > I had to resolve java/text/Format/DateFormat/TimeZoneNameTest.java. > But the new version breaks the test. I assume this is because 21 does > not have "[8174269](https://bugs.openjdk.org/browse/JDK-8174269): Remove COMPAT > locale data provider from JDK". > The original version of the test passes. > > test/jdk/sun/util/resources/TimeZone/Bug4848242.java is failing, too. > The original version works, reverted. > > Further I reverted test/jdk/java/util/TimeZone/TimeZoneData/aliases.txt and .../displaynames.txt > as else java/util/TimeZone/Bug6329116.java (unmodified) starts failing. > > See extra commits seperating out these edits. This pull request has now been integrated. Changeset: add7934b Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/add7934bb57ce0e1030061c8e551eaae6a6f7fee Stats: 1316 lines in 16 files changed: 400 ins; 60 del; 856 mod 8339637: (tz) Update Timezone Data to 2024b Reviewed-by: andrew Backport-of: 73b2341c670f98fb130c57f80eb1461226da1985 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1143 From goetz at openjdk.org Thu Nov 21 09:09:18 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Nov 2024 09:09:18 GMT Subject: [jdk21u-dev] Integrated: 8319678: Several tests from corelibs areas ignore VM flags In-Reply-To: <KnpVte01t8ywfiASdkMkCfWyZksqxDkrT2dbgWKSVOk=.90656f4d-ad07-48fb-8797-2ff944f2ca26@github.com> References: <KnpVte01t8ywfiASdkMkCfWyZksqxDkrT2dbgWKSVOk=.90656f4d-ad07-48fb-8797-2ff944f2ca26@github.com> Message-ID: <b4zCkQN3V_5VuxsF8Ncu379W9OCZJmGFKhembb-ARls=.29a510b3-5102-4e10-a8d3-c1992d207f49@github.com> On Wed, 20 Nov 2024 15:56:50 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 21.0.7-oracle. > > Resolved HijrahConfigTest.java because "8315444: Convert test/jdk/tools to Classfile API" is not in 21 This pull request has now been integrated. Changeset: 4bbc29cf Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/4bbc29cf9c98dc286e6069701d580fcc084cb792 Stats: 161 lines in 6 files changed: 56 ins; 58 del; 47 mod 8319678: Several tests from corelibs areas ignore VM flags Backport-of: 2e3682a7f2983cd58b9564253dc698760faba4b8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1169 From lucy at openjdk.org Thu Nov 21 09:11:19 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Thu, 21 Nov 2024 09:11:19 GMT Subject: [jdk17u-dev] RFR: 8274170: Add hooks for custom makefiles to augment jtreg test execution In-Reply-To: <tfrP_KXEPZgoyr1u0TtPdJ_QKzKZIxNIvuK9FXrq4t4=.abe7d40c-805b-4e36-83b6-7654b0afde40@github.com> References: <tfrP_KXEPZgoyr1u0TtPdJ_QKzKZIxNIvuK9FXrq4t4=.abe7d40c-805b-4e36-83b6-7654b0afde40@github.com> Message-ID: <nYhzHcu5L4VGehatNLlMbv56tuW3WuhyJm5aTpQtSAo=.3eda2817-c340-456e-9d0d-3b7166c1ad58@github.com> On Wed, 20 Nov 2024 14:43:13 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > I had to resolve due to context diffs. LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3066#pullrequestreview-2450694014 From goetz at openjdk.org Thu Nov 21 09:11:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Nov 2024 09:11:33 GMT Subject: [jdk17u-dev] Integrated: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails In-Reply-To: <bEwjpfWRkA9tWCysvSBQRQeAaw5u5TG2yTPVb6OJS4c=.eadb5f36-4cb9-4f69-9e87-2f5cfe58abca@github.com> References: <bEwjpfWRkA9tWCysvSBQRQeAaw5u5TG2yTPVb6OJS4c=.eadb5f36-4cb9-4f69-9e87-2f5cfe58abca@github.com> Message-ID: <yHq3QYENCWV5_6OTvJkgvPi4Ym9FNgGorPmeQHFyCr0=.e0f423c8-9559-4baa-ac71-dc1b53058313@github.com> On Wed, 20 Nov 2024 08:59:33 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 60126931 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/60126931c43c740d136a44a62e63e8dab8fea2f9 Stats: 145 lines in 1 file changed: 145 ins; 0 del; 0 mod 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails Backport-of: 2dd882af0830f174810840affa79045db4f04ef0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3064 From goetz at openjdk.org Thu Nov 21 09:15:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Nov 2024 09:15:23 GMT Subject: [jdk17u-dev] Integrated: 8322766: Micro bench SSLHandshake should use default algorithms In-Reply-To: <h7AVijS6pmykxpqiTt2scznONQCzns2HKSEcZhnHXMY=.a772e27c-608e-4037-a287-c4bbbef2fbc0@github.com> References: <h7AVijS6pmykxpqiTt2scznONQCzns2HKSEcZhnHXMY=.a772e27c-608e-4037-a287-c4bbbef2fbc0@github.com> Message-ID: <8_jCimgWyVWmHx8vSPITn6lSs0UF8GH8iTSkLlLmNpU=.bf74b8d6-59dc-440c-9667-1974054f3f15@github.com> On Tue, 19 Nov 2024 18:39:31 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: cd3a614b Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/cd3a614b363ba4a90ddf7214d598e0c05abce25e Stats: 9 lines in 2 files changed: 1 ins; 0 del; 8 mod 8322766: Micro bench SSLHandshake should use default algorithms Backport-of: 06dd73534271874eff008b8d3027f4ce49b136b3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3062 From goetz at openjdk.org Thu Nov 21 09:15:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Nov 2024 09:15:25 GMT Subject: [jdk17u-dev] Integrated: 8341927: Replace hardcoded security providers with new test.provider.name system property In-Reply-To: <bYXb_dXuiHVhe7G-L8Wg64Oh7WRA2VHgXbQmcQc22EI=.a4d85128-81e1-4c07-81db-c685beeff407@github.com> References: <bYXb_dXuiHVhe7G-L8Wg64Oh7WRA2VHgXbQmcQc22EI=.a4d85128-81e1-4c07-81db-c685beeff407@github.com> Message-ID: <yU5Y2XQVJYZDnzGdKTpALGI7lX-qVUBEjqvKI70zuzk=.27b0703d-60cf-429e-b55a-8e9e8d359e22@github.com> On Mon, 18 Nov 2024 13:23:53 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with Oracle 17.0.14. The backport is based on the commit to 21. > > Tests passed including win tests. Three files are not real tests, I double-checked these. > > I had to resolve a lot of files, but all except three only differed in the Copyright year. > > Resolved files > ================ > > doc/testing.html > Resolved. Context differences. > > test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestCipherKeyWrapperTest.java > test/jdk/com/sun/crypto/provider/Cipher/PBE/DecryptWithoutParameters.java > test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java > test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java > test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java > test/jdk/com/sun/crypto/provider/Cipher/PBE/PBESealedObject.java > test/jdk/com/sun/crypto/provider/Cipher/PBE/TestCipherKeyWrapperPBEKey.java > test/jdk/com/sun/crypto/provider/KeyGenerator/Test4628062.java > test/jdk/com/sun/crypto/provider/Mac/HmacPBESHA1.java > test/jdk/com/sun/crypto/provider/Mac/HmacSaltLengths.java > test/jdk/com/sun/crypto/provider/Mac/MacClone.java > test/jdk/com/sun/crypto/provider/NSASuiteB/TestHmacSHAOids.java > All these test lack 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider > All only Copyright except for > DecryptWithoutParameters.java: Test in 17 has less and other test cases, adapted change to this. > > test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestGeneral.java > Test was modified in 18 by 8271745: Correct block size for KW,KWP mode and use fixed IV for KWP mode for SunJCE > Test in 17 has other test cases, adapted change to this. > > test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestKeySizeCheck.java > Test was modified in 8302225: SunJCE Provider doesn't validate key sizes when using 'constrained' transforms for AES/KW and AES/KWP > Backport started. > Resolved Copyright. > > test/jdk/com/sun/crypto/provider/KeyAgreement/TestExponentSize.java > Modified in 19 by 8267319: Use larger default key sizes and algorithms based on CNSA > Resolved Copyright. > > test/jdk/com/sun/jdi/ClassesByName2Test.java > Modified by virtual threads changes. > Resolved Copyright. > > test/jdk/javax/crypto/EncryptedPrivateKeyInfo/GetAlgName.java > Modified in 20 by 8296442: EncryptedPrivateKeyInfo can be created with an uninitialized AlgorithmParameters. This is a follow-up of a cleanup change also in 20. > Resolved Copyright. > > > > Files not in 17 > =============== > > test/jdk/com/sun/crypto/provider/KeyGenerator/Test6227536.java > This tes... This pull request has now been integrated. Changeset: 4ea9694e Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/4ea9694e7e524ae7069e300cedf946d7e49b8293 Stats: 970 lines in 222 files changed: 294 ins; 0 del; 676 mod 8341927: Replace hardcoded security providers with new test.provider.name system property 8343848: Fix typo of property name in TestOAEPPadding after 8341927 Reviewed-by: lucy Backport-of: 9bdf2a619d1d158d6c1e8e1e1238a4229e0b0783 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3049 From goetz at openjdk.org Thu Nov 21 09:16:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Nov 2024 09:16:17 GMT Subject: [jdk17u-dev] Integrated: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use In-Reply-To: <rvCCt-ZQm4DmpeipbvmrJca-bASVRJaE26Q2wpwsdVI=.5ab54a09-0d19-42a4-bb5f-bec132c5c527@github.com> References: <rvCCt-ZQm4DmpeipbvmrJca-bASVRJaE26Q2wpwsdVI=.5ab54a09-0d19-42a4-bb5f-bec132c5c527@github.com> Message-ID: <87MSnjydaU0UtabgBAhrFEf9AqjmeL8sziVY-rLRigA=.8e91d7a6-a7d1-4d8f-b39d-372bad40aa57@github.com> On Wed, 20 Nov 2024 15:19:11 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > This was back ported to 21, it's useful in 17, too. This pull request has now been integrated. Changeset: dcac5eb0 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/dcac5eb061d65dddaa5a7eb88bb70ea088887f52 Stats: 19 lines in 1 file changed: 7 ins; 2 del; 10 mod 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use Backport-of: 2af0312c958e693b1377f4c014ae8f84cabf6b83 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3067 From mdoerr at openjdk.org Thu Nov 21 10:19:16 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 21 Nov 2024 10:19:16 GMT Subject: [jdk21u-dev] RFR: 8343343: Misc crash dump improvements on more platforms after JDK-8294160 [v2] In-Reply-To: <VuHRTpQOMeDUMeBAsYfzPkJsZa1uE_tI1CgYmnR2QDU=.3d46af2b-b099-461d-bf3f-2dfcc73fc69f@github.com> References: <hXGvQNmO3aDCd7QslGZqddzuwJuE3D1lRyqjagCkzjc=.e52283c1-5284-4df1-8662-b508f1649c09@github.com> <GQAnbThQLY7sLV2vsJyTWloDx9ZUrx8FP5Ul1a_UeyQ=.0b3da0a8-ca7d-454c-aa5e-23f07828a9f9@github.com> <R7vBYl-swjkPgkT8PHvTGTQ8itXMNb4oIS3GmkLCdrQ=.92b0be9e-fa79-4e38-9027-ab2f8e9f03de@github.com> <VuHRTpQOMeDUMeBAsYfzPkJsZa1uE_tI1CgYmnR2QDU=.3d46af2b-b099-461d-bf3f-2dfcc73fc69f@github.com> Message-ID: <IOwt8PLkUKxoHlRwFfHaN3v0D_L_a8WiYE8n2qFZ49I=.3dbcd1b4-4bbe-4900-82db-e226e0ebbc29@github.com> On Thu, 21 Nov 2024 08:50:46 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> GHA failures are unrelated. > > Hi @TheRealMDoerr > this is rather new and an enhancement. > What about waiting for April update, so it is live in 24 before we backport? > 21.0.7 development starts soon. @GoeLin: Having the `is_readable_pointer` checks is a good thing. This PR only looks large because of harmless refactoring. The modification is already shipped for some platforms with [JDK-8294160](https://bugs.openjdk.org/browse/JDK-8294160) in 21 GA and 17.0.7. On the other hand, I'm not aware of too many "error occurred during error reporting" issues on the missing platforms, so I can live with shipping it with 21.0.7. I leave the 21u lead maintainers free to decide. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1154#issuecomment-2490700982 From duke at openjdk.org Thu Nov 21 10:59:21 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Thu, 21 Nov 2024 10:59:21 GMT Subject: [jdk21u-dev] RFR: 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows In-Reply-To: <hCZuxP9oDF459Cpyrb1AvpxwUC41Xw_gH4Vmryk_wDk=.845d7a0d-229a-4a31-836c-426b0e8352c6@github.com> References: <hCZuxP9oDF459Cpyrb1AvpxwUC41Xw_gH4Vmryk_wDk=.845d7a0d-229a-4a31-836c-426b0e8352c6@github.com> Message-ID: <N1rPlXAiMVn4tXhxv80aciOzIFGOcY1Ps9hIYLoqx44=.b29e78fb-ef55-4e32-8cbe-7e16fb3b3aeb@github.com> On Thu, 7 Nov 2024 09:16:32 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote: > Hi all, > > I want to backport JDK-8333427 for jdk21u. > This is clean backport. It changes only one test. > > Testing: langtools/tools/javac/newlines/NewLineTest.java GHA failures are unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1132#issuecomment-2490792426 From goetz at openjdk.org Thu Nov 21 11:04:02 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Nov 2024 11:04:02 GMT Subject: [jdk17u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b Message-ID: <289zv3TFodwMO-HQYshfGvHVeUbIuyZ2ZGi8vBsm81g=.a5bcb271-ee4c-4357-8229-5a2750b00d36@github.com> I backport this for parity with 17.0.14-oracle. This is based on the commit to 21. I replaced the path to tzdata to the other location in 17 in the patch. Like this, the change applies clean. ------------- Commit messages: - Backport add7934bb57ce0e1030061c8e551eaae6a6f7fee Changes: https://git.openjdk.org/jdk17u-dev/pull/3068/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3068&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339637 Stats: 1316 lines in 16 files changed: 400 ins; 60 del; 856 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3068.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3068/head:pull/3068 PR: https://git.openjdk.org/jdk17u-dev/pull/3068 From goetz at openjdk.org Thu Nov 21 12:36:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Nov 2024 12:36:44 GMT Subject: [jdk17u-dev] RFR: 8342181: Update tests to use stronger Key and Salt size Message-ID: <W7E5OSRoV3aMileCh8GsNuBEI7nH4Mh68oa_YwSZ8Dw=.cec3b24e-9563-4c61-8ff3-c05a1ab984ca@github.com> I backport this for parity with 17.0.14-oracle. This is based on the change to 21. I resolved three files: jdk/jdk17u-dev/pull/ test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestCipherKeyWrapperTest.java Trivial resolve because https://bugs.openjdk.org/browse/JDK-8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider is missing in 17. test/jdk/java/security/Signature/ResetAfterException.java Copyright because https://bugs.openjdk.org/browse/JDK-8284191: Replace usages of 'a the' in hotspot and java.base is missin in 17. test/jdk/jdk/security/jarsigner/Spec.java Trivial resolve due to context difference. Two changes to this file are missing in 17: https://bugs.openjdk.org/browse/JDK-8267319: Use larger default key sizes and algorithms based on CNSA https://bugs.openjdk.org/browse/JDK-8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options ------------- Commit messages: - Backport d81d3015610b2468a954185d15d898ca64f51583 Changes: https://git.openjdk.org/jdk17u-dev/pull/3069/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3069&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342181 Stats: 240 lines in 40 files changed: 138 ins; 0 del; 102 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3069.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3069/head:pull/3069 PR: https://git.openjdk.org/jdk17u-dev/pull/3069 From duke at openjdk.org Thu Nov 21 17:08:39 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Thu, 21 Nov 2024 17:08:39 GMT Subject: [jdk17u-dev] RFR: 8331863: DUIterator_Fast used before it is constructed Message-ID: <MTNG6hgmwGAnPRw56EgMpvsFDmQqtwrdbz8ix19a0hw=.15bd11ed-b585-4952-b952-f3387fe737ef@github.com> Backport of JDK-8331863 from 21u. Clean backport. Passed tier1 tests. ------------- Commit messages: - Backport d13f75c9ef000b05442f9f468b2f45df9a8450cf Changes: https://git.openjdk.org/jdk17u-dev/pull/3070/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3070&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331863 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3070.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3070/head:pull/3070 PR: https://git.openjdk.org/jdk17u-dev/pull/3070 From duke at openjdk.org Thu Nov 21 18:05:37 2024 From: duke at openjdk.org (sophia-guo) Date: Thu, 21 Nov 2024 18:05:37 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 [v2] In-Reply-To: <kxmiqXU61uL_jBBlohBJchFWM2QOtrNNU671krxDdWs=.859f8eba-9dd9-4abb-8799-7e9e7b676892@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> <rxBVBiEJcpTyE4H4vcon5K--3twiegXQymwKH65FouQ=.8c48d178-920f-4d74-a610-722e884ce41e@github.com> <kxmiqXU61uL_jBBlohBJchFWM2QOtrNNU671krxDdWs=.859f8eba-9dd9-4abb-8799-7e9e7b676892@github.com> Message-ID: <wHS62pjaKn6pncKsocBFFMur6TbUOWVHHiYlO0vcyRg=.86c23240-4b7e-4d38-b4c1-519018241bce@github.com> On Wed, 20 Nov 2024 09:38:37 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote: > This patch is ready for integration. Please check the test passes post-patch (if not already done) and then integrate. Thanks! @jerboaa is this something I need to do? Sorry I'm really not familiar with this process. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1100#issuecomment-2491921441 From sgehwolf at openjdk.org Thu Nov 21 18:16:28 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 21 Nov 2024 18:16:28 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 [v2] In-Reply-To: <wHS62pjaKn6pncKsocBFFMur6TbUOWVHHiYlO0vcyRg=.86c23240-4b7e-4d38-b4c1-519018241bce@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> <rxBVBiEJcpTyE4H4vcon5K--3twiegXQymwKH65FouQ=.8c48d178-920f-4d74-a610-722e884ce41e@github.com> <kxmiqXU61uL_jBBlohBJchFWM2QOtrNNU671krxDdWs=.859f8eba-9dd9-4abb-8799-7e9e7b676892@github.com> <wHS62pjaKn6pncKsocBFFMur6TbUOWVHHiYlO0vcyRg=.86c23240-4b7e-4d38-b4c1-519018241bce@github.com> Message-ID: <mXeiKFH21p6q61TeVqn_cK8tiCuPYcf7UGN2UVzEmK0=.307070bb-1e4b-4219-9468-bdaf5625792e@github.com> On Thu, 21 Nov 2024 18:02:13 GMT, sophia-guo <duke at openjdk.org> wrote: > > This patch is ready for integration. Please check the test passes post-patch (if not already done) and then integrate. Thanks! > > @jerboaa is this something I need to do? Sorry I'm really not familiar with this process. Yes, see [this comment](https://github.com/openjdk/jdk21u-dev/pull/1100#issuecomment-2442126840). Basically type `/integrate` :-) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1100#issuecomment-2491945084 From duke at openjdk.org Thu Nov 21 19:12:24 2024 From: duke at openjdk.org (duke) Date: Thu, 21 Nov 2024 19:12:24 GMT Subject: [jdk21u-dev] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 [v2] In-Reply-To: <rxBVBiEJcpTyE4H4vcon5K--3twiegXQymwKH65FouQ=.8c48d178-920f-4d74-a610-722e884ce41e@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> <rxBVBiEJcpTyE4H4vcon5K--3twiegXQymwKH65FouQ=.8c48d178-920f-4d74-a610-722e884ce41e@github.com> Message-ID: <LOXxlqxPJnVita6Nqxi5zfcVIlNqgf7GE2i_R7V_6rU=.17ebd946-2992-4804-a4d5-5a2e4a07aaf8@github.com> On Tue, 19 Nov 2024 16:56:03 GMT, sophia-guo <duke at openjdk.org> wrote: >> Hi, I would like to backport[ 8333248](https://bugs.openjdk.org/browse/JDK-8333248) to jdk21u. As [JDK-8325520](https://bugs.openjdk.org/browse/JDK-8325520) was also backported to 21 so the test now fails on risc-v there. > > sophia-guo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into 8333248-backport-9b0a5c5c > - Backport 9b0a5c5cd056262fab99525e9260762b617152a3 @sophia-guo Your change (at version 12a6731eb922d896f4c3a5a00dfd9a02f6810a5e) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1100#issuecomment-2492051940 From duke at openjdk.org Fri Nov 22 00:03:24 2024 From: duke at openjdk.org (sophia-guo) Date: Fri, 22 Nov 2024 00:03:24 GMT Subject: [jdk21u-dev] Integrated: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 In-Reply-To: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> References: <C7zhEj912YiAuQls38-j4Asp10KwHIghcXOQWEt41vM=.0042d7da-d6cb-401c-97d0-bc45bb45d9c0@github.com> Message-ID: <a7T11szLxdBeZ841cZDiOGe7G4t3VVkapcaoMYoMTc4=.787b6556-46b7-4511-acf0-8a3356959243@github.com> On Mon, 28 Oct 2024 16:52:51 GMT, sophia-guo <duke at openjdk.org> wrote: > Hi, I would like to backport[ 8333248](https://bugs.openjdk.org/browse/JDK-8333248) to jdk21u. As [JDK-8325520](https://bugs.openjdk.org/browse/JDK-8325520) was also backported to 21 so the test now fails on risc-v there. This pull request has now been integrated. Changeset: f091c767 Author: Sophia Guo <sophia.gwf at gmail.com> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/f091c76728c1911d53c2efb81596f88a57a04ceb Stats: 29 lines in 1 file changed: 0 ins; 0 del; 29 mod 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 Backport-of: 9b0a5c5cd056262fab99525e9260762b617152a3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1100 From amitkumar at openjdk.org Fri Nov 22 00:05:27 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Fri, 22 Nov 2024 00:05:27 GMT Subject: [jdk21u-dev] Integrated: 8343884: [s390x] Disallow OptoScheduling In-Reply-To: <Rn0cj-l5pnagAS9RtY_RVHSp8momKJYV4WMeSs8JwjI=.cd4983ea-571a-4d40-b358-9ec2b9ce68a4@github.com> References: <Rn0cj-l5pnagAS9RtY_RVHSp8momKJYV4WMeSs8JwjI=.cd4983ea-571a-4d40-b358-9ec2b9ce68a4@github.com> Message-ID: <818-b9NKcMsZj9cI6z7OJGvVejpDvUlSHH7sjHtwT3s=.a127a34d-225f-4d5f-bede-b44aafcf8f01@github.com> On Wed, 20 Nov 2024 03:52:29 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [7540fa21](https://github.com/openjdk/jdk/commit/7540fa2147ff8fc9c652ef13548f72f27e2809a8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 19 Nov 2024 and was reviewed by Lutz Schmidt. > > Thanks! This pull request has now been integrated. Changeset: 50fc231b Author: Amit Kumar <amitkumar at openjdk.org> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/50fc231b04c0e97d74ad2d6bb97096d924bd3f0f Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod 8343884: [s390x] Disallow OptoScheduling Backport-of: 7540fa2147ff8fc9c652ef13548f72f27e2809a8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1164 From andrew at openjdk.org Fri Nov 22 01:08:18 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 22 Nov 2024 01:08:18 GMT Subject: [jdk17u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <289zv3TFodwMO-HQYshfGvHVeUbIuyZ2ZGi8vBsm81g=.a5bcb271-ee4c-4357-8229-5a2750b00d36@github.com> References: <289zv3TFodwMO-HQYshfGvHVeUbIuyZ2ZGi8vBsm81g=.a5bcb271-ee4c-4357-8229-5a2750b00d36@github.com> Message-ID: <QfAJWl01wvzpubmVZkjWJnvSjO_xdCSw6QxnI-QeD5E=.acb754c8-f69d-4136-88b3-cbdd030c48cc@github.com> On Thu, 21 Nov 2024 10:59:22 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > This is based on the commit to 21. > > I replaced the path to tzdata to the other location in 17 in the patch. > Like this, the change applies clean. Patch looks the same as 21u to me, bar the paths. Do the timezone tests (`java/text/Format`, `java/util/TimeZone`, `sun/util/calendar` and `sun/util/resources`) pass? ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3068#pullrequestreview-2453112470 From duke at openjdk.org Fri Nov 22 02:23:21 2024 From: duke at openjdk.org (duke) Date: Fri, 22 Nov 2024 02:23:21 GMT Subject: [jdk21u-dev] RFR: 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows In-Reply-To: <hCZuxP9oDF459Cpyrb1AvpxwUC41Xw_gH4Vmryk_wDk=.845d7a0d-229a-4a31-836c-426b0e8352c6@github.com> References: <hCZuxP9oDF459Cpyrb1AvpxwUC41Xw_gH4Vmryk_wDk=.845d7a0d-229a-4a31-836c-426b0e8352c6@github.com> Message-ID: <A0Q5RVX2oppIWV2oNJi96fcUs0t6d5kr-iM8UCs6EEs=.05df2a7e-3ed9-40cb-af74-8b9dc3c334e5@github.com> On Thu, 7 Nov 2024 09:16:32 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote: > Hi all, > > I want to backport JDK-8333427 for jdk21u. > This is clean backport. It changes only one test. > > Testing: langtools/tools/javac/newlines/NewLineTest.java @tkiriyama Your change (at version 1c7989ff260c8929c5c5c11238b6ba4aa1af49b7) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1132#issuecomment-2492740193 From syan at openjdk.org Fri Nov 22 06:48:59 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 22 Nov 2024 06:48:59 GMT Subject: [jdk17u-dev] RFR: 8343877: Test AsyncClose.java intermittent fails - Socket.getInputStream().read() wasn't preempted Message-ID: <cYLdotSm8F_7MWu5ZyOSCI3X7uZDkUs4VpEX_wLio2o=.f6ef55a3-fccf-4798-8450-78f6626341b0@github.com> Hi all, This pull request contains a backport of commit [752e1629](https://github.com/openjdk/jdk/commit/752e1629555f0ec8630373ec87b049afdd709ea6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jaikiran Pai on 14 Nov 2024 and was reviewed by Daniel Fuchs, Mark Sheppard, SendaoYan and Alan Bateman. Thanks! ------------- Commit messages: - Backport 752e1629555f0ec8630373ec87b049afdd709ea6 Changes: https://git.openjdk.org/jdk17u-dev/pull/3071/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3071&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343877 Stats: 33 lines in 2 files changed: 4 ins; 0 del; 29 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3071.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3071/head:pull/3071 PR: https://git.openjdk.org/jdk17u-dev/pull/3071 From syan at openjdk.org Fri Nov 22 06:49:47 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 22 Nov 2024 06:49:47 GMT Subject: [jdk21u-dev] RFR: 8343877: Test AsyncClose.java intermittent fails - Socket.getInputStream().read() wasn't preempted Message-ID: <0Ul6zbl6XE1vadVgT65BPNRdIOCyHk2Z_LSTVezzzBU=.7a1cd2d6-378a-49be-a4f8-533091e3ae47@github.com> Hi all, This pull request contains a backport of commit [752e1629](https://github.com/openjdk/jdk/commit/752e1629555f0ec8630373ec87b049afdd709ea6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jaikiran Pai on 14 Nov 2024 and was reviewed by Daniel Fuchs, Mark Sheppard, SendaoYan and Alan Bateman. Thanks! ------------- Commit messages: - Backport 752e1629555f0ec8630373ec87b049afdd709ea6 Changes: https://git.openjdk.org/jdk21u-dev/pull/1174/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1174&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343877 Stats: 33 lines in 2 files changed: 4 ins; 0 del; 29 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1174.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1174/head:pull/1174 PR: https://git.openjdk.org/jdk21u-dev/pull/1174 From goetz at openjdk.org Fri Nov 22 07:04:04 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 07:04:04 GMT Subject: [jdk17u-dev] RFR: 8342181: Update tests to use stronger Key and Salt size [v2] In-Reply-To: <W7E5OSRoV3aMileCh8GsNuBEI7nH4Mh68oa_YwSZ8Dw=.cec3b24e-9563-4c61-8ff3-c05a1ab984ca@github.com> References: <W7E5OSRoV3aMileCh8GsNuBEI7nH4Mh68oa_YwSZ8Dw=.cec3b24e-9563-4c61-8ff3-c05a1ab984ca@github.com> Message-ID: <V0pwG-QlhWJHSGmEvpVrk2_3pvXefz_frMptAE6a2i0=.c2d08b93-5c8d-49a9-a9a9-bb7423b5e48b@github.com> > I backport this for parity with 17.0.14-oracle. > > This is based on the change to 21. > I resolved three files: > jdk/jdk17u-dev/pull/ > > test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestCipherKeyWrapperTest.java > Trivial resolve because > https://bugs.openjdk.org/browse/JDK-8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider > is missing in 17. > > test/jdk/java/security/Signature/ResetAfterException.java > Copyright because > https://bugs.openjdk.org/browse/JDK-8284191: Replace usages of 'a the' in hotspot and java.base > is missin in 17. > > test/jdk/jdk/security/jarsigner/Spec.java > Trivial resolve due to context difference. > Two changes to this file are missing in 17: > https://bugs.openjdk.org/browse/JDK-8267319: Use larger default key sizes and algorithms based on CNSA > https://bugs.openjdk.org/browse/JDK-8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Add missed somicolon. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3069/files - new: https://git.openjdk.org/jdk17u-dev/pull/3069/files/cdb6b9b7..6e0477e8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3069&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3069&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3069.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3069/head:pull/3069 PR: https://git.openjdk.org/jdk17u-dev/pull/3069 From goetz at openjdk.org Fri Nov 22 07:42:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 07:42:21 GMT Subject: [jdk17u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <QfAJWl01wvzpubmVZkjWJnvSjO_xdCSw6QxnI-QeD5E=.acb754c8-f69d-4136-88b3-cbdd030c48cc@github.com> References: <289zv3TFodwMO-HQYshfGvHVeUbIuyZ2ZGi8vBsm81g=.a5bcb271-ee4c-4357-8229-5a2750b00d36@github.com> <QfAJWl01wvzpubmVZkjWJnvSjO_xdCSw6QxnI-QeD5E=.acb754c8-f69d-4136-88b3-cbdd030c48cc@github.com> Message-ID: <AxGjqztfR9R4M6Blo9QtI30w0F04qMAXEmou8H1lULg=.f05e4df8-98a6-4dea-8c3c-7e8ef05d38ba@github.com> On Fri, 22 Nov 2024 01:05:59 GMT, Andrew John Hughes <andrew at openjdk.org> wrote: >> I backport this for parity with 17.0.14-oracle. >> >> This is based on the commit to 21. >> >> I replaced the path to tzdata to the other location in 17 in the patch. >> Like this, the change applies clean. > > Patch looks the same as 21u to me, bar the paths. > Do the timezone tests (`java/text/Format`, `java/util/TimeZone`, `sun/util/calendar` and `sun/util/resources`) pass? Hi @gnu-andrew yes, they pass. The PR was in our nightly tests which run tier1-4 (headless) on 7 platforms, and I ran the tests locally. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3068#issuecomment-2493071262 From goetz at openjdk.org Fri Nov 22 07:42:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 07:42:21 GMT Subject: [jdk17u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <289zv3TFodwMO-HQYshfGvHVeUbIuyZ2ZGi8vBsm81g=.a5bcb271-ee4c-4357-8229-5a2750b00d36@github.com> References: <289zv3TFodwMO-HQYshfGvHVeUbIuyZ2ZGi8vBsm81g=.a5bcb271-ee4c-4357-8229-5a2750b00d36@github.com> Message-ID: <pqw8K4v5oDcQbPbjKqPp8HBUuh0yEmyxcGDaiArrHuw=.a29d18f4-4cb9-4d62-92b6-c4564558c237@github.com> On Thu, 21 Nov 2024 10:59:22 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > This is based on the commit to 21. > > I replaced the path to tzdata to the other location in 17 in the patch. > Like this, the change applies clean. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3068#issuecomment-2493071952 From rmarchenko at openjdk.org Fri Nov 22 07:48:43 2024 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Fri, 22 Nov 2024 07:48:43 GMT Subject: [jdk11u-dev] RFR: 8301753: AppendFile/WriteFile has differences between make 3.81 and 4+ Message-ID: <TKPsFJQLWMVJdNnX95zcRIopUzz3iD3PDLceSSE-vHg=.e69d751c-6c3d-4588-a15f-992e8eee33c8@github.com> Clean backport to 11u. This fixes "make test" build problem occured with make version <4.0 in JDK11. The new test is passed locally with a manual run with both "GNU Make 3.82" and "GNU Make 4.3". ------------- Commit messages: - Backport a39cf2e3b242298fbf5fafdb8aa9b5d4562061ef Changes: https://git.openjdk.org/jdk11u-dev/pull/2969/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2969&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301753 Stats: 58 lines in 2 files changed: 56 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2969.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2969/head:pull/2969 PR: https://git.openjdk.org/jdk11u-dev/pull/2969 From goetz at openjdk.org Fri Nov 22 07:49:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 07:49:55 GMT Subject: [jdk17u-dev] RFR: 8342181: Update tests to use stronger Key and Salt size [v3] In-Reply-To: <W7E5OSRoV3aMileCh8GsNuBEI7nH4Mh68oa_YwSZ8Dw=.cec3b24e-9563-4c61-8ff3-c05a1ab984ca@github.com> References: <W7E5OSRoV3aMileCh8GsNuBEI7nH4Mh68oa_YwSZ8Dw=.cec3b24e-9563-4c61-8ff3-c05a1ab984ca@github.com> Message-ID: <EcHQYsczuCB1-C10enf57wNq8PX7Wyhp7xpFhdMfMdU=.c155b6e4-c56e-4dc4-9b14-53100a0d574e@github.com> > I backport this for parity with 17.0.14-oracle. > > This is based on the change to 21. > I resolved three files: > jdk/jdk17u-dev/pull/ > > test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestCipherKeyWrapperTest.java > Trivial resolve because > https://bugs.openjdk.org/browse/JDK-8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider > is missing in 17. > > test/jdk/java/security/Signature/ResetAfterException.java > Copyright because > https://bugs.openjdk.org/browse/JDK-8284191: Replace usages of 'a the' in hotspot and java.base > is missin in 17. > > test/jdk/jdk/security/jarsigner/Spec.java > Trivial resolve due to context difference. > Two changes to this file are missing in 17: > https://bugs.openjdk.org/browse/JDK-8267319: Use larger default key sizes and algorithms based on CNSA > https://bugs.openjdk.org/browse/JDK-8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Besides the semicolon I missed a line in Spec.java ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3069/files - new: https://git.openjdk.org/jdk17u-dev/pull/3069/files/6e0477e8..e4b10aaa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3069&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3069&range=01-02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3069.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3069/head:pull/3069 PR: https://git.openjdk.org/jdk17u-dev/pull/3069 From goetz at openjdk.org Fri Nov 22 09:50:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 09:50:16 GMT Subject: [jdk17u-dev] Integrated: 8274170: Add hooks for custom makefiles to augment jtreg test execution In-Reply-To: <tfrP_KXEPZgoyr1u0TtPdJ_QKzKZIxNIvuK9FXrq4t4=.abe7d40c-805b-4e36-83b6-7654b0afde40@github.com> References: <tfrP_KXEPZgoyr1u0TtPdJ_QKzKZIxNIvuK9FXrq4t4=.abe7d40c-805b-4e36-83b6-7654b0afde40@github.com> Message-ID: <mfXfeAu_JhkbvbKcHe9fkpU_54Bmz7ASHhnJ8t7CAl4=.76269b83-9619-430f-8dfd-7fb4ea0d6070@github.com> On Wed, 20 Nov 2024 14:43:13 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > I had to resolve due to context diffs. This pull request has now been integrated. Changeset: 7575163a Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/7575163ab2eb85b9d18026ca5f8004e9752d3358 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod 8274170: Add hooks for custom makefiles to augment jtreg test execution Reviewed-by: lucy Backport-of: 14100d55dc822a7eb4f3e499aa9077e7ad17b2a6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3066 From goetz at openjdk.org Fri Nov 22 09:51:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 09:51:27 GMT Subject: [jdk17u-dev] Integrated: 8325525: Create jtreg test case for JDK-8325203 In-Reply-To: <jLmbuqK6Qglgu6eVugjMkhMiWCjzY9VuHGjWxPkF5Ls=.35591a95-0daa-48c7-9cc9-c48a52925628@github.com> References: <jLmbuqK6Qglgu6eVugjMkhMiWCjzY9VuHGjWxPkF5Ls=.35591a95-0daa-48c7-9cc9-c48a52925628@github.com> Message-ID: <_5WqtaWehCQAxi2UMDythGx4RgeO8Ulbhen1KuDJsDo=.921a980f-2b1e-4d3e-bb27-0e5cd2dceef5@github.com> On Wed, 20 Nov 2024 12:37:06 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: c4ea7b47 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/c4ea7b47be9c231006c914c4cb19765cfe9fb355 Stats: 129 lines in 2 files changed: 129 ins; 0 del; 0 mod 8325525: Create jtreg test case for JDK-8325203 8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive Backport-of: 936b23953044d0c9a8ea558208c3cd503895144a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3065 From goetz at openjdk.org Fri Nov 22 10:13:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 10:13:46 GMT Subject: [jdk17u-dev] RFR: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags Message-ID: <dmmDaO6pDvX5dh3Wboxd4eeJNbeExqekguS8fA5Jdfw=.41c6c0e3-fb58-47e8-b6c3-22244eab2932@github.com> I backport this for parity with 17.0.14-oracle. Resolved Copyritht, probably clean. ------------- Commit messages: - Backport 5e021cbcc7a6cb30a27380950e115ff12846239c Changes: https://git.openjdk.org/jdk17u-dev/pull/3072/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3072&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337410 Stats: 33 lines in 1 file changed: 30 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3072.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3072/head:pull/3072 PR: https://git.openjdk.org/jdk17u-dev/pull/3072 From goetz at openjdk.org Fri Nov 22 10:15:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 10:15:22 GMT Subject: [jdk17u-dev] RFR: 8342181: Update tests to use stronger Key and Salt size [v3] In-Reply-To: <EcHQYsczuCB1-C10enf57wNq8PX7Wyhp7xpFhdMfMdU=.c155b6e4-c56e-4dc4-9b14-53100a0d574e@github.com> References: <W7E5OSRoV3aMileCh8GsNuBEI7nH4Mh68oa_YwSZ8Dw=.cec3b24e-9563-4c61-8ff3-c05a1ab984ca@github.com> <EcHQYsczuCB1-C10enf57wNq8PX7Wyhp7xpFhdMfMdU=.c155b6e4-c56e-4dc4-9b14-53100a0d574e@github.com> Message-ID: <IIo-QWwXd6cgwH3hdvpWlCp2LFWeK3zJTpnsDRICbV0=.e0659e05-2dad-407c-8e14-4c3cd2288fbf@github.com> On Fri, 22 Nov 2024 07:49:55 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: >> I backport this for parity with 17.0.14-oracle. >> >> This is based on the change to 21. >> I resolved three files: >> jdk/jdk17u-dev/pull/ >> >> test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestCipherKeyWrapperTest.java >> Trivial resolve because >> https://bugs.openjdk.org/browse/JDK-8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider >> is missing in 17. >> >> test/jdk/java/security/Signature/ResetAfterException.java >> Copyright because >> https://bugs.openjdk.org/browse/JDK-8284191: Replace usages of 'a the' in hotspot and java.base >> is missin in 17. >> >> test/jdk/jdk/security/jarsigner/Spec.java >> Trivial resolve due to context difference. >> Two changes to this file are missing in 17: >> https://bugs.openjdk.org/browse/JDK-8267319: Use larger default key sizes and algorithms based on CNSA >> https://bugs.openjdk.org/browse/JDK-8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Besides the semicolon I missed a line in Spec.java Nice this is clean despite the resolves I did! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3069#issuecomment-2493397144 From goetz at openjdk.org Fri Nov 22 10:15:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 10:15:23 GMT Subject: [jdk17u-dev] Integrated: 8342181: Update tests to use stronger Key and Salt size In-Reply-To: <W7E5OSRoV3aMileCh8GsNuBEI7nH4Mh68oa_YwSZ8Dw=.cec3b24e-9563-4c61-8ff3-c05a1ab984ca@github.com> References: <W7E5OSRoV3aMileCh8GsNuBEI7nH4Mh68oa_YwSZ8Dw=.cec3b24e-9563-4c61-8ff3-c05a1ab984ca@github.com> Message-ID: <8UFqM-EsuYXVK1zlRXJxUueSmzQGLkzExlm3QIZu9io=.0127e105-6f5f-45d6-810b-49efdbfba839@github.com> On Thu, 21 Nov 2024 12:31:43 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > This is based on the change to 21. > I resolved three files: > jdk/jdk17u-dev/pull/ > > test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestCipherKeyWrapperTest.java > Trivial resolve because > https://bugs.openjdk.org/browse/JDK-8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider > is missing in 17. > > test/jdk/java/security/Signature/ResetAfterException.java > Copyright because > https://bugs.openjdk.org/browse/JDK-8284191: Replace usages of 'a the' in hotspot and java.base > is missin in 17. > > test/jdk/jdk/security/jarsigner/Spec.java > Trivial resolve due to context difference. > Two changes to this file are missing in 17: > https://bugs.openjdk.org/browse/JDK-8267319: Use larger default key sizes and algorithms based on CNSA > https://bugs.openjdk.org/browse/JDK-8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options This pull request has now been integrated. Changeset: a44a35e2 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/a44a35e2c33f01f9feb4ffad417ced12c029d4e0 Stats: 240 lines in 40 files changed: 138 ins; 0 del; 102 mod 8342181: Update tests to use stronger Key and Salt size Backport-of: d81d3015610b2468a954185d15d898ca64f51583 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3069 From goetz at openjdk.org Fri Nov 22 10:42:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 10:42:07 GMT Subject: [jdk17u-dev] RFR: 8342188: Update tests to use stronger key parameters and certificates Message-ID: <CLkVs8d9EAkz2NuUBBt3BgKB-yJtrn-3Xs5N21l7fOg=.5f4ec622-6d13-4fa5-b6ee-3b66f8e71947@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe Changes: https://git.openjdk.org/jdk17u-dev/pull/3073/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3073&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342188 Stats: 2728 lines in 15 files changed: 1090 ins; 395 del; 1243 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3073.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3073/head:pull/3073 PR: https://git.openjdk.org/jdk17u-dev/pull/3073 From goetz at openjdk.org Fri Nov 22 11:05:02 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 11:05:02 GMT Subject: [jdk17u-dev] RFR: 8342183: Update tests to use stronger algorithms and keys Message-ID: <Eah7uW4EBARuprwWGdunQQirRnGTPrxtSAq5o3H1L3I=.b28cd565-4daf-4e57-9219-8c632e678dd4@github.com> I had to resolve, but probably clean: test/jdk/com/sun/crypto/provider/Mac/MacClone.java Resolved due to context. test/jdk/sun/security/pkcs/pkcs7/SignerOrder.java Resolved Copyright. ------------- Commit messages: - Backport e1eb341217fb5411721dec1b78e4bbf06f2f5cda Changes: https://git.openjdk.org/jdk17u-dev/pull/3074/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3074&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342183 Stats: 267 lines in 35 files changed: 142 ins; 8 del; 117 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3074.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3074/head:pull/3074 PR: https://git.openjdk.org/jdk17u-dev/pull/3074 From duke at openjdk.org Fri Nov 22 12:35:41 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 22 Nov 2024 12:35:41 GMT Subject: [jdk21u-dev] RFR: 8342704: GHA: Report truncation is broken after JDK-8341424 Message-ID: <SPtcox1_2Pxw2cSNdDyqF5bAbbsz2wUaKCXbbyumDGI=.d103a5e7-e27a-420e-abf0-2b480f676898@github.com> Backport of [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424) and companion [JDK-8342704](https://bugs.openjdk.org/browse/JDK-8342704) This collects `hs_errs` when they happen with GitHub Actions, which may be useful during reviews. The idea is to backport this to `17` and `11` too. Low risk, as this affects GHA actions only. GHA builds and tests run correctly. ------------- Commit messages: - Backport bf92c498391b099b67c313703e48374cade76f87 - Backport 3ab519f16381ab49353e67db8480ed13f52ca3e8 Changes: https://git.openjdk.org/jdk21u-dev/pull/1175/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1175&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342704 Stats: 81 lines in 3 files changed: 67 ins; 14 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1175.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1175/head:pull/1175 PR: https://git.openjdk.org/jdk21u-dev/pull/1175 From andrew at openjdk.org Fri Nov 22 12:36:16 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 22 Nov 2024 12:36:16 GMT Subject: [jdk17u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <289zv3TFodwMO-HQYshfGvHVeUbIuyZ2ZGi8vBsm81g=.a5bcb271-ee4c-4357-8229-5a2750b00d36@github.com> References: <289zv3TFodwMO-HQYshfGvHVeUbIuyZ2ZGi8vBsm81g=.a5bcb271-ee4c-4357-8229-5a2750b00d36@github.com> Message-ID: <CYeJ1bpAe69fj_lzi5IVWCp22f9DEWdWiDu1ZV9UXtw=.e4849618-a2e1-4351-8d0f-47973d186dd4@github.com> On Thu, 21 Nov 2024 10:59:22 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > This is based on the commit to 21. > > I replaced the path to tzdata to the other location in 17 in the patch. > Like this, the change applies clean. Thanks for confirming. Fine by me. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3068#pullrequestreview-2454330397 From goetz at openjdk.org Fri Nov 22 12:56:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 12:56:21 GMT Subject: [jdk17u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <289zv3TFodwMO-HQYshfGvHVeUbIuyZ2ZGi8vBsm81g=.a5bcb271-ee4c-4357-8229-5a2750b00d36@github.com> References: <289zv3TFodwMO-HQYshfGvHVeUbIuyZ2ZGi8vBsm81g=.a5bcb271-ee4c-4357-8229-5a2750b00d36@github.com> Message-ID: <tV4GVGIncVdHEVSEZdmkBVuxO9NZwoWE3LTOiqeSMTg=.95697982-2292-43d2-a9dc-bd35de4b5e95@github.com> On Thu, 21 Nov 2024 10:59:22 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > This is based on the commit to 21. > > I replaced the path to tzdata to the other location in 17 in the patch. > Like this, the change applies clean. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3068#issuecomment-2493698293 From goetz at openjdk.org Fri Nov 22 13:52:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 13:52:22 GMT Subject: [jdk17u-dev] RFR: 8314610: hotspot can't compile with the latest of gtest because of <iomanip> In-Reply-To: <_DaWIQJpWtTrcrT4QsAb4BIS2QR_uu7MA_mCPB0IYOI=.646e8ec4-9c4d-4f53-9fd5-2e5bb8a9bc8c@github.com> References: <_DaWIQJpWtTrcrT4QsAb4BIS2QR_uu7MA_mCPB0IYOI=.646e8ec4-9c4d-4f53-9fd5-2e5bb8a9bc8c@github.com> Message-ID: <PC9R6kTvVIeXQcgigkmrR8zmTtJFvIqmSklxp28SYxc=.b21bd7e0-8bd6-427d-8f82-2ac1bebdc2e1@github.com> On Mon, 14 Oct 2024 10:12:47 GMT, Sorna Sarathi <duke at openjdk.org> wrote: > Hi all, > This pull request contains a backport of commit [febc34d](https://github.com/openjdk/jdk/commit/febc34dd285c3382716e068748d4a3b0c73d87ad) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > Tier1 testing is successful. > Thanks! > > JBS Issue: [JDK-8314610](https://bugs.openjdk.org/browse/JDK-8314610) Hi @Sorna-Sarathi please check the failed GHA tests. Most of the time they fail because of a problem with the test setup. Nevertheless you need to check this to make sure it's not caused by your backport. You should in any case comment why it failed. Then you can either restart the tests or just argue that they are not important for the backport you are working on in this PR (if this actually is the case!). Just restarting without checking the tests is not good as sometimes changes bring sporadic failures ... ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2959#issuecomment-2493814510 From goetz at openjdk.org Fri Nov 22 13:55:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Nov 2024 13:55:20 GMT Subject: [jdk17u-dev] RFR: 8342607: Enhance register printing on x86_64 platforms [v2] In-Reply-To: <uM23IARtt6_sGzICrmteZMHCJt9k9foQ3_O4naAO2Fk=.ee334aa5-f7fe-4f00-ba8b-293c2211e0fe@github.com> References: <UkmARLM1OQiHuX1MZB_W_CATUgpOvpxhNSbgk0CH610=.bf8d5b44-3eda-4e0f-bbfe-ec282a10696b@github.com> <uM23IARtt6_sGzICrmteZMHCJt9k9foQ3_O4naAO2Fk=.ee334aa5-f7fe-4f00-ba8b-293c2211e0fe@github.com> Message-ID: <4UUnW6ax-m07h7TxWPJSRoU0C4Sic7MOKw0B76pvwg0=.7c63f2fe-d62a-4ec4-9054-76ee256e057c@github.com> On Tue, 19 Nov 2024 17:25:44 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: >> Clean backport of [JDK-8342607](https://bugs.openjdk.org/browse/JDK-8342607) plus small part of https://github.com/openjdk/jdk/commit/98ce45ff7432a56d73b51046817b5fe84a412042 (2nd commit, may help other backports, too). > > Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: > > Add small part of JDK-8292981. Hi @TheRealMDoerr I think we should wait for the april update to give the change some testing in-the-open. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3061#issuecomment-2493820289 From syan at openjdk.org Fri Nov 22 15:40:24 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 22 Nov 2024 15:40:24 GMT Subject: [jdk21u-dev] RFR: 8316907: Fix nonnull-compare warnings In-Reply-To: <7gGZLQeCEadp8uZ5ZgA_S1dbVhMgVIkGKKzTPz50tvM=.91589217-f2a1-4112-9735-e75814414fa3@github.com> References: <7gGZLQeCEadp8uZ5ZgA_S1dbVhMgVIkGKKzTPz50tvM=.91589217-f2a1-4112-9735-e75814414fa3@github.com> Message-ID: <TGfPU1yiXfJTn2uVNu01U8qpsPv9yzlfitcyQsm1-1w=.9263abec-5889-4073-85f7-bf3d6f5f2961@github.com> On Thu, 21 Nov 2024 07:38:30 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > There are some gcc compile warnings which recorded by [JDK-8342304](https://bugs.openjdk.org/browse/JDK-8342304) on linux-riscv64 platform, and the PR [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) fix the gcc compile warnings. So I want to backport [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) to jdk21u-dev. But before backport [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893), we should backport [JDK-8316907](https://bugs.openjdk.org/browse/JDK-8316907) first, [JDK-8316907](https://bugs.openjdk.org/browse/JDK-8316907) solve nonnull-compare warnings emitted by GCC after removing `-fno-delete-null-pointer-checks`. > > Additional testing: > > - [x] 1. jtreg tests(include tier1/2/3 etc.) with linux-x64 release build > - [x] 2. jtreg tests(include tier1/2/3 etc.) with linux-x64 fastdebug build > - [x] 3. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 release build > - [x] 4. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 fastdebug build Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1172#issuecomment-2494041899 From syan at openjdk.org Fri Nov 22 15:40:25 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 22 Nov 2024 15:40:25 GMT Subject: [jdk21u-dev] Integrated: 8316907: Fix nonnull-compare warnings In-Reply-To: <7gGZLQeCEadp8uZ5ZgA_S1dbVhMgVIkGKKzTPz50tvM=.91589217-f2a1-4112-9735-e75814414fa3@github.com> References: <7gGZLQeCEadp8uZ5ZgA_S1dbVhMgVIkGKKzTPz50tvM=.91589217-f2a1-4112-9735-e75814414fa3@github.com> Message-ID: <JbHbAbmAJsilAy1OfhaLjo6QYmlejzWGfXdn4zVeUAE=.a82a776b-c632-44a2-a737-b02e36aca525@github.com> On Thu, 21 Nov 2024 07:38:30 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > There are some gcc compile warnings which recorded by [JDK-8342304](https://bugs.openjdk.org/browse/JDK-8342304) on linux-riscv64 platform, and the PR [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) fix the gcc compile warnings. So I want to backport [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) to jdk21u-dev. But before backport [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893), we should backport [JDK-8316907](https://bugs.openjdk.org/browse/JDK-8316907) first, [JDK-8316907](https://bugs.openjdk.org/browse/JDK-8316907) solve nonnull-compare warnings emitted by GCC after removing `-fno-delete-null-pointer-checks`. > > Additional testing: > > - [x] 1. jtreg tests(include tier1/2/3 etc.) with linux-x64 release build > - [x] 2. jtreg tests(include tier1/2/3 etc.) with linux-x64 fastdebug build > - [x] 3. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 release build > - [x] 4. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 fastdebug build This pull request has now been integrated. Changeset: ef5702e7 Author: SendaoYan <syan at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/ef5702e7f4be11ab3f3b7d74b98cf9aa628829f7 Stats: 6 lines in 2 files changed: 0 ins; 6 del; 0 mod 8316907: Fix nonnull-compare warnings Backport-of: 516cfb135f7e5fefaf6e6f2928f6ecb88806f1ef ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1172 From duke at openjdk.org Fri Nov 22 16:32:52 2024 From: duke at openjdk.org (Saint Wesonga) Date: Fri, 22 Nov 2024 16:32:52 GMT Subject: [jdk21u-dev] RFR: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set Message-ID: <HhdgJY_Yud2qt8zSfMJ7L1bqd5jHm0XPGhvDy-uXkHQ=.f557d3ff-b737-4b32-9c6a-944cb9901d95@github.com> Backport https://github.com/openjdk/jdk23u/commit/7f189a59d9ad803aee72565bc46a817d3f46f2e5 to jdk23u. UnsafeIntrinsicsTest.java#ZGenerationalDebug test now passes in fastdebug on Windows AArch64 with this change. ------------- Commit messages: - Backport 7f189a59d9ad803aee72565bc46a817d3f46f2e5 Changes: https://git.openjdk.org/jdk21u-dev/pull/1176/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1176&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334475 Stats: 59 lines in 1 file changed: 19 ins; 36 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1176.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1176/head:pull/1176 PR: https://git.openjdk.org/jdk21u-dev/pull/1176 From xpeng at openjdk.org Fri Nov 22 17:30:25 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Fri, 22 Nov 2024 17:30:25 GMT Subject: [jdk17u-dev] RFR: 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException In-Reply-To: <SG3JbPt8riqYWeF2pqKEHaoWXRVdu32mKB-M4xIb_o0=.fb12d9fe-3937-42f8-abc5-05a533cadc93@github.com> References: <SG3JbPt8riqYWeF2pqKEHaoWXRVdu32mKB-M4xIb_o0=.fb12d9fe-3937-42f8-abc5-05a533cadc93@github.com> Message-ID: <TcydBkBSjNpvoxVxHYBXrqqRkH5Pp487x-ZDT_Ygtsc=.1cf16219-d606-4d85-adbe-3c6e28349900@github.com> On Tue, 19 Nov 2024 01:12:23 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [fe0ccdf5](https://github.com/openjdk/jdk/commit/fe0ccdf5f8a5559a608d2e2cd2b6aecbe245c5ec) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Naoto Sato on 13 Nov 2023 and was reviewed by Roger Riggs, Iris Clark, Justin Lu and Joe Wang. > > Tese: > - [x] `CONF=linux-x86_64-server-fastdebug make test TEST=jdk/* JTREG_KEYWORDS=!headful`, there are failures caused by missing printer for test, not related this change. > > Thanks! Thanks for the review and approval. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3059#issuecomment-2494371944 From duke at openjdk.org Fri Nov 22 17:30:25 2024 From: duke at openjdk.org (duke) Date: Fri, 22 Nov 2024 17:30:25 GMT Subject: [jdk17u-dev] RFR: 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException In-Reply-To: <SG3JbPt8riqYWeF2pqKEHaoWXRVdu32mKB-M4xIb_o0=.fb12d9fe-3937-42f8-abc5-05a533cadc93@github.com> References: <SG3JbPt8riqYWeF2pqKEHaoWXRVdu32mKB-M4xIb_o0=.fb12d9fe-3937-42f8-abc5-05a533cadc93@github.com> Message-ID: <rNVMY3ZC6gZfEg9Ir7RFRValHVxgu4Lq9XRuGhNJroI=.f59dbaec-25e3-484a-b427-a32833281fcf@github.com> On Tue, 19 Nov 2024 01:12:23 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [fe0ccdf5](https://github.com/openjdk/jdk/commit/fe0ccdf5f8a5559a608d2e2cd2b6aecbe245c5ec) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Naoto Sato on 13 Nov 2023 and was reviewed by Roger Riggs, Iris Clark, Justin Lu and Joe Wang. > > Tese: > - [x] `CONF=linux-x86_64-server-fastdebug make test TEST=jdk/* JTREG_KEYWORDS=!headful`, there are failures caused by missing printer for test, not related this change. > > Thanks! @pengxiaolong Your change (at version d65648e9caf470f45da8a6ad9b7c0f3889ad668d) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3059#issuecomment-2494374258 From xpeng at openjdk.org Fri Nov 22 17:44:24 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Fri, 22 Nov 2024 17:44:24 GMT Subject: [jdk17u-dev] Integrated: 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException In-Reply-To: <SG3JbPt8riqYWeF2pqKEHaoWXRVdu32mKB-M4xIb_o0=.fb12d9fe-3937-42f8-abc5-05a533cadc93@github.com> References: <SG3JbPt8riqYWeF2pqKEHaoWXRVdu32mKB-M4xIb_o0=.fb12d9fe-3937-42f8-abc5-05a533cadc93@github.com> Message-ID: <HZDNwyMBYPqgwxU7DwsK-KrrFZU6sDCte6e6Wr-pzqA=.e0c9664c-d1f6-43e1-ba1c-5d820b411423@github.com> On Tue, 19 Nov 2024 01:12:23 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [fe0ccdf5](https://github.com/openjdk/jdk/commit/fe0ccdf5f8a5559a608d2e2cd2b6aecbe245c5ec) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Naoto Sato on 13 Nov 2023 and was reviewed by Roger Riggs, Iris Clark, Justin Lu and Joe Wang. > > Tese: > - [x] `CONF=linux-x86_64-server-fastdebug make test TEST=jdk/* JTREG_KEYWORDS=!headful`, there are failures caused by missing printer for test, not related this change. > > Thanks! This pull request has now been integrated. Changeset: e0dd517d Author: Xiaolong Peng <xpeng at openjdk.org> Committer: Paul Hohensee <phh at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/e0dd517d5027fba176dbd386f2c325e960c1b900 Stats: 50 lines in 2 files changed: 34 ins; 8 del; 8 mod 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException Backport-of: fe0ccdf5f8a5559a608d2e2cd2b6aecbe245c5ec ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3059 From abakhtin at openjdk.org Fri Nov 22 21:13:58 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 22 Nov 2024 21:13:58 GMT Subject: [jdk21u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files Message-ID: <rYsJDZQyol_Ndf3Y5prTHolmPoco1jUXLODssmYYUdY=.b6cfae94-99ec-47eb-9dc0-0dbad5a556bf@github.com> Clean backport of jar tool enhancement from JDK23 JTREG tests passed ------------- Commit messages: - Backport 158b93d19a518d2b9d3d185e2d4c4dbff9c82aab Changes: https://git.openjdk.org/jdk21u-dev/pull/1177/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1177&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335912 Stats: 528 lines in 5 files changed: 526 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1177.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1177/head:pull/1177 PR: https://git.openjdk.org/jdk21u-dev/pull/1177 From phh at openjdk.org Fri Nov 22 21:37:20 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 22 Nov 2024 21:37:20 GMT Subject: [jdk21u-dev] RFR: 8341194: [REDO] Implement C2 VectorizedHashCode on AArch64 In-Reply-To: <D49WFHgrecB8cjqvr6q3_5WOE_GXgBobwH-mqXRrJGk=.9938536c-92df-4690-9717-4707afd8e36a@github.com> References: <D49WFHgrecB8cjqvr6q3_5WOE_GXgBobwH-mqXRrJGk=.9938536c-92df-4690-9717-4707afd8e36a@github.com> Message-ID: <S2PN5D5_xhUzs2MpdS20j5Foh9CZZ-w3sd1-FNWp97E=.02c75cde-e73f-4517-aa3c-284fa0ef5640@github.com> On Wed, 20 Nov 2024 19:40:14 GMT, Chad Rakoczy <duke at openjdk.org> wrote: > Backport [JDK-8341194](https://bugs.openjdk.org/browse/JDK-8341194) [REDO] Implement C2 VectorizedHashCode on AArch64 > > Backport is clean. Trivial merge conflicts with includes and already present code. Original implementation [JDK-8322770](https://bugs.openjdk.org/browse/JDK-8322770) caused build and test failures. Build failures that were reproducible with `make bootcycle-images` run on `linux-aarch64 fastdebug/release` successfully. All jtreg and new asmtest pass on `linux-aarch64 release`. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1170#pullrequestreview-2455756334 From henryjen at openjdk.org Fri Nov 22 23:16:01 2024 From: henryjen at openjdk.org (Henry Jen) Date: Fri, 22 Nov 2024 23:16:01 GMT Subject: [jdk21u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: <rYsJDZQyol_Ndf3Y5prTHolmPoco1jUXLODssmYYUdY=.b6cfae94-99ec-47eb-9dc0-0dbad5a556bf@github.com> References: <rYsJDZQyol_Ndf3Y5prTHolmPoco1jUXLODssmYYUdY=.b6cfae94-99ec-47eb-9dc0-0dbad5a556bf@github.com> Message-ID: <_T_A_ALckOyOPoqLwPTGVThDlLeIgVLmoA2zvbJvKX0=.d403e4b2-dba4-4559-a5d3-50a368f4f568@github.com> On Fri, 22 Nov 2024 21:08:42 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote: > Clean backport of jar tool enhancement from JDK23 > > JTREG tests passed LGTM ------------- Marked as reviewed by henryjen (Committer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1177#pullrequestreview-2455930485 From syan at openjdk.org Sat Nov 23 02:49:28 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 23 Nov 2024 02:49:28 GMT Subject: [jdk21u-dev] RFR: 8316893: Compile without -fno-delete-null-pointer-checks Message-ID: <HYcqumwOjXH8K9QNVrokoduZ9GDpr0GZ01BUtsA2m0c=.ab59f07a-7297-4012-984e-c5350aff564d@github.com> Hi all, There are some gcc compile warnings which recorded by [JDK-8342304](https://bugs.openjdk.org/browse/JDK-8342304) on linux-riscv64 platform, and the PR [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) fix the gcc compile warnings. So I want to backport [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) to jdk21u-dev. Additional testing: - [ ] 1. jtreg tests(include tier1/2/3 etc.) with linux-x64 release build - [ ] 2. jtreg tests(include tier1/2/3 etc.) with linux-x64 fastdebug build - [ ] 3. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 release build - [ ] 4. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 fastdebug build ------------- Commit messages: - Backport 287b24322135b54641f013970c4545ce069c4350 Changes: https://git.openjdk.org/jdk21u-dev/pull/1178/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1178&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316893 Stats: 17 lines in 1 file changed: 0 ins; 14 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1178.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1178/head:pull/1178 PR: https://git.openjdk.org/jdk21u-dev/pull/1178 From syan at openjdk.org Sat Nov 23 12:12:20 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 23 Nov 2024 12:12:20 GMT Subject: [jdk21u-dev] RFR: 8316893: Compile without -fno-delete-null-pointer-checks In-Reply-To: <HYcqumwOjXH8K9QNVrokoduZ9GDpr0GZ01BUtsA2m0c=.ab59f07a-7297-4012-984e-c5350aff564d@github.com> References: <HYcqumwOjXH8K9QNVrokoduZ9GDpr0GZ01BUtsA2m0c=.ab59f07a-7297-4012-984e-c5350aff564d@github.com> Message-ID: <IlgbcvUnqDB73Hs5WFkgmqlW1VEuxE18XqMXu6c4i5Q=.ec0f48ad-d3a7-40ff-922d-abbb896821c1@github.com> On Sat, 23 Nov 2024 02:35:55 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > There are some gcc compile warnings which recorded by [JDK-8342304](https://bugs.openjdk.org/browse/JDK-8342304) on linux-riscv64 platform, and the PR [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) fix the gcc compile warnings. So I want to backport [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) to jdk21u-dev. > > Additional testing: > > - [x] 1. jtreg tests(include tier1/2/3 etc.) with linux-x64 release build > - [x] 2. jtreg tests(include tier1/2/3 etc.) with linux-x64 fastdebug build > - [x] 3. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 release build > - [x] 4. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 fastdebug build GHA report a failure: 1. linux-x86-hs / build (debug) job at `Get JTReg` stage fails `wget exited with exit code 4`, seems like environmental issue or infra issue, it's unrelated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1178#issuecomment-2495458132 From goetz at openjdk.org Sat Nov 23 13:51:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 23 Nov 2024 13:51:27 GMT Subject: [jdk17u-dev] RFR: 8342188: Update tests to use stronger key parameters and certificates In-Reply-To: <CLkVs8d9EAkz2NuUBBt3BgKB-yJtrn-3Xs5N21l7fOg=.5f4ec622-6d13-4fa5-b6ee-3b66f8e71947@github.com> References: <CLkVs8d9EAkz2NuUBBt3BgKB-yJtrn-3Xs5N21l7fOg=.5f4ec622-6d13-4fa5-b6ee-3b66f8e71947@github.com> Message-ID: <yOCGOWoVib72DXQqMleE5PpzOq_S446GKbw260OqxK8=.ea04cef9-fb2b-4902-92a8-cb2d9ccce4b2@github.com> On Fri, 22 Nov 2024 10:36:18 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: 3 times infra issue, unrelated. wget failed. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3073#issuecomment-2495485900 From goetz at openjdk.org Sat Nov 23 13:55:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 23 Nov 2024 13:55:27 GMT Subject: [jdk17u-dev] Integrated: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <289zv3TFodwMO-HQYshfGvHVeUbIuyZ2ZGi8vBsm81g=.a5bcb271-ee4c-4357-8229-5a2750b00d36@github.com> References: <289zv3TFodwMO-HQYshfGvHVeUbIuyZ2ZGi8vBsm81g=.a5bcb271-ee4c-4357-8229-5a2750b00d36@github.com> Message-ID: <XO59tVjC_dghS2RLPLzhWAgfwzffnqsZtVXJMIlkDnk=.63fb4265-2cbf-40fc-a10b-5240727eeebe@github.com> On Thu, 21 Nov 2024 10:59:22 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > This is based on the commit to 21. > > I replaced the path to tzdata to the other location in 17 in the patch. > Like this, the change applies clean. This pull request has now been integrated. Changeset: fbc040cf Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/fbc040cf8a17fc8de15b8771765441b86a8169ae Stats: 1316 lines in 16 files changed: 400 ins; 60 del; 856 mod 8339637: (tz) Update Timezone Data to 2024b Reviewed-by: andrew Backport-of: add7934bb57ce0e1030061c8e551eaae6a6f7fee ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3068 From syan at openjdk.org Sun Nov 24 09:32:58 2024 From: syan at openjdk.org (SendaoYan) Date: Sun, 24 Nov 2024 09:32:58 GMT Subject: [jdk21u-dev] RFR: 8338344: Test TestPrivilegedMode.java intermittent fails java.lang.NoClassDefFoundError: jdk/test/lib/Platform Message-ID: <cLdxMMO50PXsyZmaD1pGGVtDv6Wv0kqofeUak97Wxng=.80207ae3-89da-447f-bf36-be1851968196@github.com> Hi all, This pull request contains a backport of commit [e3a5e265](https://github.com/openjdk/jdk/commit/e3a5e265a7747b02b8f828fbedea0dda7246fc51) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 14 Aug 2024 and was reviewed by Christian Hagedorn and Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport e3a5e265a7747b02b8f828fbedea0dda7246fc51 Changes: https://git.openjdk.org/jdk21u-dev/pull/1179/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1179&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338344 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1179.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1179/head:pull/1179 PR: https://git.openjdk.org/jdk21u-dev/pull/1179 From syan at openjdk.org Mon Nov 25 06:30:23 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 25 Nov 2024 06:30:23 GMT Subject: [jdk21u-dev] RFR: 8338344: Test TestPrivilegedMode.java intermittent fails java.lang.NoClassDefFoundError: jdk/test/lib/Platform In-Reply-To: <cLdxMMO50PXsyZmaD1pGGVtDv6Wv0kqofeUak97Wxng=.80207ae3-89da-447f-bf36-be1851968196@github.com> References: <cLdxMMO50PXsyZmaD1pGGVtDv6Wv0kqofeUak97Wxng=.80207ae3-89da-447f-bf36-be1851968196@github.com> Message-ID: <YGc4TUIH5K_FBhZQFmkQWE5BxS_QWfO2qeiK7kNA5QM=.795b2c1b-e4cf-4e69-b5b3-207b66dd1f3b@github.com> On Sun, 24 Nov 2024 09:27:38 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [e3a5e265](https://github.com/openjdk/jdk/commit/e3a5e265a7747b02b8f828fbedea0dda7246fc51) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 14 Aug 2024 and was reviewed by Christian Hagedorn and Aleksey Shipilev. > > Thanks! GHA report 1 failure: 1. `linux-x64-hs-nopch build debug` job at `Get JTRreg` stage fails `wget exited with exit code 4` seems environmental issue or infra issue, it's unrelated to this issue. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1179#issuecomment-2496969211 From syan at openjdk.org Mon Nov 25 07:12:25 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 25 Nov 2024 07:12:25 GMT Subject: [jdk17u-dev] RFR: 8343877: Test AsyncClose.java intermittent fails - Socket.getInputStream().read() wasn't preempted In-Reply-To: <cYLdotSm8F_7MWu5ZyOSCI3X7uZDkUs4VpEX_wLio2o=.f6ef55a3-fccf-4798-8450-78f6626341b0@github.com> References: <cYLdotSm8F_7MWu5ZyOSCI3X7uZDkUs4VpEX_wLio2o=.f6ef55a3-fccf-4798-8450-78f6626341b0@github.com> Message-ID: <4EC_4-6q9BxeH4HkOjFWFoQbdvD9CfuwD83kE8hTaUU=.2d7bb1f1-1f44-4b36-923a-64ddd7380cd4@github.com> On Fri, 22 Nov 2024 06:44:34 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [752e1629](https://github.com/openjdk/jdk/commit/752e1629555f0ec8630373ec87b049afdd709ea6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 14 Nov 2024 and was reviewed by Daniel Fuchs, Mark Sheppard, SendaoYan and Alan Bateman. > > Thanks! GHA report 1 failure: 1. `linux-x64-hs-nopch build debug` job at `Get JTRreg` stage fails `wget exited with exit code 4` seems environmental issue or infra issue, it's unrelated to this issue. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3071#issuecomment-2497035661 From duke at openjdk.org Mon Nov 25 07:20:55 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 25 Nov 2024 07:20:55 GMT Subject: [jdk21u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names Message-ID: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). Tested tier1 tests and processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) ------------- Commit messages: - Backport 1bc13a1c10a580f84f1b7686c95344ec2633f611 Changes: https://git.openjdk.org/jdk21u-dev/pull/1180/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1180&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340552 Stats: 12 lines in 1 file changed: 8 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1180.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1180/head:pull/1180 PR: https://git.openjdk.org/jdk21u-dev/pull/1180 From duke at openjdk.org Mon Nov 25 07:46:20 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 25 Nov 2024 07:46:20 GMT Subject: [jdk21u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> References: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> Message-ID: <OdDDN3Tx5HPG-amPMJ8N2gm_0pP9WtqKuXVmRaE0rek=.f27aa7ed-3120-4eae-96de-7f21af266a46@github.com> On Mon, 25 Nov 2024 07:15:55 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested tier1 tests and processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) Build failure is unrelated. It's due to [abusing downloads from `archive.apache.org`:](https://infra.apache.org/infra-ban.html) [build.sh][INFO] Downloading https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.8-bin.zip to /home/runner/work/jdk21u-dev/jdk21u-dev/jtreg/src/make/../build/deps/apache-ant-1.10.8-bin.zip Error: sh][ERROR] wget exited with exit code 4 Error: Process completed with exit code 1. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1180#issuecomment-2497116313 From goetz at openjdk.org Mon Nov 25 08:16:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Nov 2024 08:16:25 GMT Subject: [jdk17u-dev] Integrated: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags In-Reply-To: <dmmDaO6pDvX5dh3Wboxd4eeJNbeExqekguS8fA5Jdfw=.41c6c0e3-fb58-47e8-b6c3-22244eab2932@github.com> References: <dmmDaO6pDvX5dh3Wboxd4eeJNbeExqekguS8fA5Jdfw=.41c6c0e3-fb58-47e8-b6c3-22244eab2932@github.com> Message-ID: <a6hmUa9eq8tef50URadrGmt_c-1EACiQ2wNvpPzGtic=.cbf9feb7-a82b-4037-94d2-1b19c4722f1c@github.com> On Fri, 22 Nov 2024 10:08:25 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. > > Resolved Copyritht, probably clean. This pull request has now been integrated. Changeset: 86979c7b Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/86979c7b6cd647300eb60a9f1881db22ff92733d Stats: 33 lines in 1 file changed: 30 ins; 2 del; 1 mod 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags Backport-of: 5e021cbcc7a6cb30a27380950e115ff12846239c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3072 From goetz at openjdk.org Mon Nov 25 08:20:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Nov 2024 08:20:25 GMT Subject: [jdk17u-dev] Integrated: 8342188: Update tests to use stronger key parameters and certificates In-Reply-To: <CLkVs8d9EAkz2NuUBBt3BgKB-yJtrn-3Xs5N21l7fOg=.5f4ec622-6d13-4fa5-b6ee-3b66f8e71947@github.com> References: <CLkVs8d9EAkz2NuUBBt3BgKB-yJtrn-3Xs5N21l7fOg=.5f4ec622-6d13-4fa5-b6ee-3b66f8e71947@github.com> Message-ID: <y4i_ckYddn0L7Dbt1tlfspiPhiGNLw9ZgoabrjLWvag=.e11552f9-c9aa-4d23-bb86-90a6708c197c@github.com> On Fri, 22 Nov 2024 10:36:18 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 00921067 Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/009210673c66e6d5a535745eb6f4b3f9a06c93a8 Stats: 2728 lines in 15 files changed: 1090 ins; 395 del; 1243 mod 8342188: Update tests to use stronger key parameters and certificates Backport-of: ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3073 From goetz at openjdk.org Mon Nov 25 08:21:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Nov 2024 08:21:21 GMT Subject: [jdk17u-dev] Integrated: 8342183: Update tests to use stronger algorithms and keys In-Reply-To: <Eah7uW4EBARuprwWGdunQQirRnGTPrxtSAq5o3H1L3I=.b28cd565-4daf-4e57-9219-8c632e678dd4@github.com> References: <Eah7uW4EBARuprwWGdunQQirRnGTPrxtSAq5o3H1L3I=.b28cd565-4daf-4e57-9219-8c632e678dd4@github.com> Message-ID: <CfLbnX9ANy4s298KUx61KCQ67NrXjm-szqMXSYiJL7s=.394885a5-1b51-47bb-9ffc-2685951ca3df@github.com> On Fri, 22 Nov 2024 11:00:20 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > I had to resolve, but probably clean: > > test/jdk/com/sun/crypto/provider/Mac/MacClone.java > Resolved due to context. > > test/jdk/sun/security/pkcs/pkcs7/SignerOrder.java > Resolved Copyright. This pull request has now been integrated. Changeset: 571ad58c Author: Goetz Lindenmaier <goetz at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/571ad58c627c832f64a4c07b123e0d19cfd7ea8e Stats: 267 lines in 35 files changed: 142 ins; 8 del; 117 mod 8342183: Update tests to use stronger algorithms and keys Backport-of: e1eb341217fb5411721dec1b78e4bbf06f2f5cda ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3074 From duke at openjdk.org Mon Nov 25 10:18:23 2024 From: duke at openjdk.org (duke) Date: Mon, 25 Nov 2024 10:18:23 GMT Subject: [jdk21u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> References: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> Message-ID: <TT_ukvfRTtN_jW_9YIx6V6_XFhBP6AO3DXYg22rnoCk=.0724d727-11c1-45bb-8d4d-9ff717b5c72a@github.com> On Mon, 25 Nov 2024 07:15:55 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested tier1 tests and processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) @vieiro Your change (at version f8885a9b8a1c3f0fbb762443e0f40ff43583837b) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1180#issuecomment-2497530884 From goetz at openjdk.org Mon Nov 25 14:09:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Nov 2024 14:09:28 GMT Subject: [jdk17u-dev] RFR: 8314610: hotspot can't compile with the latest of gtest because of <iomanip> In-Reply-To: <_DaWIQJpWtTrcrT4QsAb4BIS2QR_uu7MA_mCPB0IYOI=.646e8ec4-9c4d-4f53-9fd5-2e5bb8a9bc8c@github.com> References: <_DaWIQJpWtTrcrT4QsAb4BIS2QR_uu7MA_mCPB0IYOI=.646e8ec4-9c4d-4f53-9fd5-2e5bb8a9bc8c@github.com> Message-ID: <v0PO6C9Xjg-ww4nmy-UlrU_LvKT9dg7z8QUrZA4uqWA=.96277484-ebf4-4388-959b-9aa45bae92fc@github.com> On Mon, 14 Oct 2024 10:12:47 GMT, Sorna Sarathi <duke at openjdk.org> wrote: > Hi all, > This pull request contains a backport of commit [febc34d](https://github.com/openjdk/jdk/commit/febc34dd285c3382716e068748d4a3b0c73d87ad) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > Tier1 testing is successful. > Thanks! > > JBS Issue: [JDK-8314610](https://bugs.openjdk.org/browse/JDK-8314610) Removing the approval request tag in the meantime ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2959#issuecomment-2498116682 From duke at openjdk.org Mon Nov 25 14:20:25 2024 From: duke at openjdk.org (duke) Date: Mon, 25 Nov 2024 14:20:25 GMT Subject: [jdk23u] RFR: 8340586: JdkJfrEvent::get_all_klasses stores non-strong oops in JNI handles In-Reply-To: <bO9rYB6nC4STutjBz7VkE5ZIFU62QiH0Mh4kkETPWC8=.d2a8c97f-8e2e-4c6c-9b22-8ba2e8c227a2@github.com> References: <bO9rYB6nC4STutjBz7VkE5ZIFU62QiH0Mh4kkETPWC8=.d2a8c97f-8e2e-4c6c-9b22-8ba2e8c227a2@github.com> Message-ID: <hfMTl0rCe9lUREuFnmjn3qvDqFUuhlCk5_cHWg8kxTQ=.6528f03c-d847-4cd1-a4a7-4fa94c16bd01@github.com> On Thu, 7 Nov 2024 10:55:05 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [97b681e9](https://github.com/openjdk/jdk/commit/97b681e93a9469d8d16122dc10bbf2f5b5fe2266) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Axel Boldt-Christmas on 7 Nov 2024 and was reviewed by Coleen Phillimore, Stefan Karlsson and Markus Gr?nlund. > > Thanks! @xmas92 Your change (at version fc5451438272231720ddfcf1dbb54e635ddcf2e6) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/218#issuecomment-2498143359 From duke at openjdk.org Mon Nov 25 14:49:14 2024 From: duke at openjdk.org (duke) Date: Mon, 25 Nov 2024 14:49:14 GMT Subject: [jdk23u] RFR: 8319947: Recursive lightweight locking: s390x implementation In-Reply-To: <a9xbtmTtwZOqFSL7tqyk5Z0Sx6-6C7y9he2Gn4kR58E=.3550d35e-ae9a-45f5-8e93-fa2925adedef@github.com> References: <a9xbtmTtwZOqFSL7tqyk5Z0Sx6-6C7y9he2Gn4kR58E=.3550d35e-ae9a-45f5-8e93-fa2925adedef@github.com> Message-ID: <zOlwknoRE_wGyEPrQSh2RmBiagtlautZP7W-CnJL6ao=.84b37171-e31c-4645-908d-79abc84cb77c@github.com> On Mon, 11 Nov 2024 14:34:25 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [d457609f](https://github.com/openjdk/jdk/commit/d457609f700bbb1fed233f1a04501c995852e5ac) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 28 Jun 2024 and was reviewed by Axel Boldt-Christmas and Lutz Schmidt. > > Thanks! @offamitkumar Your change (at version 3aceec839a6b5ea0180bade133b7145be7413a4b) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/221#issuecomment-2498222493 From duke at openjdk.org Mon Nov 25 14:49:26 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 25 Nov 2024 14:49:26 GMT Subject: [jdk21u-dev] Integrated: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> References: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> Message-ID: <wu7WfzmmgkEgpL3ratELsFtfrISzHymdS5Znimt0F1M=.b65ee481-e078-4572-a120-1e46d44a5510@github.com> On Mon, 25 Nov 2024 07:15:55 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested tier1 tests and processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) This pull request has now been integrated. Changeset: bc4abb43 Author: Antonio Vieiro <avieirov at redhat.com> Committer: Severin Gehwolf <sgehwolf at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/bc4abb4379ced7ddfb3d173d2dfc669a4b11d12f Stats: 12 lines in 1 file changed: 8 ins; 0 del; 4 mod 8340552: Harden TzdbZoneRulesCompiler against missing zone names Backport-of: 1bc13a1c10a580f84f1b7686c95344ec2633f611 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1180 From duke at openjdk.org Mon Nov 25 14:49:19 2024 From: duke at openjdk.org (duke) Date: Mon, 25 Nov 2024 14:49:19 GMT Subject: [jdk23u] RFR: 8336012: Fix usages of jtreg-reserved properties In-Reply-To: <iRrBOUJBCt-Mx4fnWjTbbxFF2NZI-6oZy-SfW0syLy8=.1b79d702-5285-445d-a5d3-64354836b1f6@github.com> References: <iRrBOUJBCt-Mx4fnWjTbbxFF2NZI-6oZy-SfW0syLy8=.1b79d702-5285-445d-a5d3-64354836b1f6@github.com> Message-ID: <2PiS0d1u7vkrDGsHh7OBuP6elYKn0mCMOUURCODbudQ=.152a869c-beb6-4a58-8d3f-85c2122740c6@github.com> On Tue, 12 Nov 2024 03:08:38 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [e6c5aa7a](https://github.com/openjdk/jdk/commit/e6c5aa7a6cb54c647d261facdcffa6a410849627) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > `test/jdk/java/lang/invoke/PrivateInvokeTest.java` is failing on s390x JDK23 - CI consistently. error: > > > STDERR: > STARTED test.java.lang.invoke.PrivateInvokeTest::testFirst 'testFirst' > java.lang.NumberFormatException: For input string: "Verbose[p=SUMMARY,f=FULL,e=FULL,t=false,m=false]" > at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) > at java.base/java.lang.Integer.parseInt(Integer.java:588) > at java.base/java.lang.Integer.parseInt(Integer.java:685) > at test.java.lang.invoke.PrivateInvokeTest.<init>(PrivateInvokeTest.java:72) > at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501) > at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:485) > FAILED test.java.lang.invoke.PrivateInvokeTest::testFirst 'testFirst' [60ms] > STARTED test.java.lang.invoke.PrivateInvokeTest::testInvokeDirect 'testInvokeDirect' > java.lang.NumberFormatException: For input string: "Verbose[p=SUMMARY,f=FULL,e=FULL,t=false,m=false]" > at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) > at java.base/java.lang.Integer.parseInt(Integer.java:588) > at java.base/java.lang.Integer.parseInt(Integer.java:685) > at test.java.lang.invoke.PrivateInvokeTest.<init>(PrivateInvokeTest.java:72) > at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501) > at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:485) > FAILED test.java.lang.invoke.PrivateInvokeTest::testInvokeDirect 'testInvokeDirect' [4ms] > JavaTest Message: JUnit Platform Failure(s): 2 > > [ JUnit Containers: found 4, started 4, succeeded 4, failed 0, aborted 0, skipped 0] > [ JUnit Tests: found 2, started 2, succeeded 0, failed 2, aborted 0, skipped 0] > > java.lang.Exception: JUnit test failure > at com.sun.javatest.regtest.agent.JUnitRunner.runWithJUnitPlatform(JUnitRunner.java:155) > at com.sun.javatest.regtest.agent.JUnitRunner.main(JUnitRunner.java:99) > at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) > at java.base/java.lang.reflect.Method.invoke(Method.java:580) > at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333) > at java.base/java.lang.Thread.run(Thre... @offamitkumar Your change (at version a343a0b7e46c4612363bda4ea46ab39563d2d761) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/222#issuecomment-2498223055 From syan at openjdk.org Mon Nov 25 14:58:23 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 25 Nov 2024 14:58:23 GMT Subject: [jdk21u-dev] RFR: 8316893: Compile without -fno-delete-null-pointer-checks In-Reply-To: <HYcqumwOjXH8K9QNVrokoduZ9GDpr0GZ01BUtsA2m0c=.ab59f07a-7297-4012-984e-c5350aff564d@github.com> References: <HYcqumwOjXH8K9QNVrokoduZ9GDpr0GZ01BUtsA2m0c=.ab59f07a-7297-4012-984e-c5350aff564d@github.com> Message-ID: <XlGQdIe0zpl0vfAnhPuZVI5jH5cwQD3IMeEhsci_K6s=.38ff708b-1b25-4872-950d-c32662e35077@github.com> On Sat, 23 Nov 2024 02:35:55 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > There are some gcc compile warnings which recorded by [JDK-8342304](https://bugs.openjdk.org/browse/JDK-8342304) on linux-riscv64 platform, and the PR [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) fix the gcc compile warnings. So I want to backport [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) to jdk21u-dev. > > Additional testing: > > - [x] 1. jtreg tests(include tier1/2/3 etc.) with linux-x64 release build > - [x] 2. jtreg tests(include tier1/2/3 etc.) with linux-x64 fastdebug build > - [x] 3. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 release build > - [x] 4. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 fastdebug build Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1178#issuecomment-2498243380 From syan at openjdk.org Mon Nov 25 14:58:24 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 25 Nov 2024 14:58:24 GMT Subject: [jdk21u-dev] Integrated: 8316893: Compile without -fno-delete-null-pointer-checks In-Reply-To: <HYcqumwOjXH8K9QNVrokoduZ9GDpr0GZ01BUtsA2m0c=.ab59f07a-7297-4012-984e-c5350aff564d@github.com> References: <HYcqumwOjXH8K9QNVrokoduZ9GDpr0GZ01BUtsA2m0c=.ab59f07a-7297-4012-984e-c5350aff564d@github.com> Message-ID: <cFf8ki29Xg9B2PhwAUdlUQadJsGDTj8xwIGfpO3fnFU=.af20c7ba-7cae-4e8e-93df-3f30c9574c04@github.com> On Sat, 23 Nov 2024 02:35:55 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > There are some gcc compile warnings which recorded by [JDK-8342304](https://bugs.openjdk.org/browse/JDK-8342304) on linux-riscv64 platform, and the PR [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) fix the gcc compile warnings. So I want to backport [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) to jdk21u-dev. > > Additional testing: > > - [x] 1. jtreg tests(include tier1/2/3 etc.) with linux-x64 release build > - [x] 2. jtreg tests(include tier1/2/3 etc.) with linux-x64 fastdebug build > - [x] 3. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 release build > - [x] 4. jtreg tests(include tier1/2/3 etc.) with linux-aarch64 fastdebug build This pull request has now been integrated. Changeset: 70455810 Author: SendaoYan <syan at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/704558107540a902f3e9d90fd4c9909539125b41 Stats: 17 lines in 1 file changed: 0 ins; 14 del; 3 mod 8316893: Compile without -fno-delete-null-pointer-checks Backport-of: 287b24322135b54641f013970c4545ce069c4350 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1178 From syan at openjdk.org Mon Nov 25 14:59:23 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 25 Nov 2024 14:59:23 GMT Subject: [jdk21u-dev] RFR: 8338344: Test TestPrivilegedMode.java intermittent fails java.lang.NoClassDefFoundError: jdk/test/lib/Platform In-Reply-To: <cLdxMMO50PXsyZmaD1pGGVtDv6Wv0kqofeUak97Wxng=.80207ae3-89da-447f-bf36-be1851968196@github.com> References: <cLdxMMO50PXsyZmaD1pGGVtDv6Wv0kqofeUak97Wxng=.80207ae3-89da-447f-bf36-be1851968196@github.com> Message-ID: <hlQjqonc9dw1k_RC3YZ-3S-Faf2Q_HqMtQ0GbBUOrXw=.b0c298e5-82fc-4625-8952-f944060fa560@github.com> On Sun, 24 Nov 2024 09:27:38 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [e3a5e265](https://github.com/openjdk/jdk/commit/e3a5e265a7747b02b8f828fbedea0dda7246fc51) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 14 Aug 2024 and was reviewed by Christian Hagedorn and Aleksey Shipilev. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1179#issuecomment-2498245234 From syan at openjdk.org Mon Nov 25 14:59:24 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 25 Nov 2024 14:59:24 GMT Subject: [jdk21u-dev] Integrated: 8338344: Test TestPrivilegedMode.java intermittent fails java.lang.NoClassDefFoundError: jdk/test/lib/Platform In-Reply-To: <cLdxMMO50PXsyZmaD1pGGVtDv6Wv0kqofeUak97Wxng=.80207ae3-89da-447f-bf36-be1851968196@github.com> References: <cLdxMMO50PXsyZmaD1pGGVtDv6Wv0kqofeUak97Wxng=.80207ae3-89da-447f-bf36-be1851968196@github.com> Message-ID: <q5UUc522cW0XJUx257o0qX-hPPdf3R8hS_j8wV7pwYc=.41172ba7-3407-4043-ba50-0007be11f21f@github.com> On Sun, 24 Nov 2024 09:27:38 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [e3a5e265](https://github.com/openjdk/jdk/commit/e3a5e265a7747b02b8f828fbedea0dda7246fc51) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 14 Aug 2024 and was reviewed by Christian Hagedorn and Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: 149991de Author: SendaoYan <syan at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/149991de706d3d5c1848b4df882e3b86d1ea77ea Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8338344: Test TestPrivilegedMode.java intermittent fails java.lang.NoClassDefFoundError: jdk/test/lib/Platform Backport-of: e3a5e265a7747b02b8f828fbedea0dda7246fc51 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1179 From syan at openjdk.org Mon Nov 25 14:59:31 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 25 Nov 2024 14:59:31 GMT Subject: [jdk17u-dev] RFR: 8343877: Test AsyncClose.java intermittent fails - Socket.getInputStream().read() wasn't preempted In-Reply-To: <cYLdotSm8F_7MWu5ZyOSCI3X7uZDkUs4VpEX_wLio2o=.f6ef55a3-fccf-4798-8450-78f6626341b0@github.com> References: <cYLdotSm8F_7MWu5ZyOSCI3X7uZDkUs4VpEX_wLio2o=.f6ef55a3-fccf-4798-8450-78f6626341b0@github.com> Message-ID: <t-0kN4enwiyxhUwZQsnuGbBTTo3zQSQUYKcANZCILIU=.6c1e6ac2-b56b-49cc-80e4-a0b7ae8ceb2d@github.com> On Fri, 22 Nov 2024 06:44:34 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [752e1629](https://github.com/openjdk/jdk/commit/752e1629555f0ec8630373ec87b049afdd709ea6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 14 Nov 2024 and was reviewed by Daniel Fuchs, Mark Sheppard, SendaoYan and Alan Bateman. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3071#issuecomment-2498248019 From syan at openjdk.org Mon Nov 25 14:59:31 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 25 Nov 2024 14:59:31 GMT Subject: [jdk17u-dev] Integrated: 8343877: Test AsyncClose.java intermittent fails - Socket.getInputStream().read() wasn't preempted In-Reply-To: <cYLdotSm8F_7MWu5ZyOSCI3X7uZDkUs4VpEX_wLio2o=.f6ef55a3-fccf-4798-8450-78f6626341b0@github.com> References: <cYLdotSm8F_7MWu5ZyOSCI3X7uZDkUs4VpEX_wLio2o=.f6ef55a3-fccf-4798-8450-78f6626341b0@github.com> Message-ID: <Nt_9B_6PirD-vOzsdJMAtwTwik0BpDVLk6xzqjxefYY=.7ef724ff-d59b-4fca-babf-4fd0aada4e91@github.com> On Fri, 22 Nov 2024 06:44:34 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [752e1629](https://github.com/openjdk/jdk/commit/752e1629555f0ec8630373ec87b049afdd709ea6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 14 Nov 2024 and was reviewed by Daniel Fuchs, Mark Sheppard, SendaoYan and Alan Bateman. > > Thanks! This pull request has now been integrated. Changeset: 0d6b6b33 Author: SendaoYan <syan at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/0d6b6b331fb8ae010e2f02e1c55cc611cc25a49e Stats: 33 lines in 2 files changed: 4 ins; 0 del; 29 mod 8343877: Test AsyncClose.java intermittent fails - Socket.getInputStream().read() wasn't preempted Backport-of: 752e1629555f0ec8630373ec87b049afdd709ea6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3071 From syan at openjdk.org Mon Nov 25 15:00:15 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 25 Nov 2024 15:00:15 GMT Subject: [jdk21u-dev] RFR: 8343877: Test AsyncClose.java intermittent fails - Socket.getInputStream().read() wasn't preempted In-Reply-To: <0Ul6zbl6XE1vadVgT65BPNRdIOCyHk2Z_LSTVezzzBU=.7a1cd2d6-378a-49be-a4f8-533091e3ae47@github.com> References: <0Ul6zbl6XE1vadVgT65BPNRdIOCyHk2Z_LSTVezzzBU=.7a1cd2d6-378a-49be-a4f8-533091e3ae47@github.com> Message-ID: <IwqTcB8scugkgi6PkDiyXaErqMa_QuJbQOnZfsG-3pw=.8d37f2e1-f3ab-4e04-90c0-d56497c340c9@github.com> On Fri, 22 Nov 2024 06:44:31 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [752e1629](https://github.com/openjdk/jdk/commit/752e1629555f0ec8630373ec87b049afdd709ea6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 14 Nov 2024 and was reviewed by Daniel Fuchs, Mark Sheppard, SendaoYan and Alan Bateman. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1174#issuecomment-2498248267 From syan at openjdk.org Mon Nov 25 15:00:16 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 25 Nov 2024 15:00:16 GMT Subject: [jdk21u-dev] Integrated: 8343877: Test AsyncClose.java intermittent fails - Socket.getInputStream().read() wasn't preempted In-Reply-To: <0Ul6zbl6XE1vadVgT65BPNRdIOCyHk2Z_LSTVezzzBU=.7a1cd2d6-378a-49be-a4f8-533091e3ae47@github.com> References: <0Ul6zbl6XE1vadVgT65BPNRdIOCyHk2Z_LSTVezzzBU=.7a1cd2d6-378a-49be-a4f8-533091e3ae47@github.com> Message-ID: <NHThU7m1WKgavg51KEoW95uw9XNbhuLGGUXZfW2VK2c=.92cbc614-47f8-4816-b8b7-aa425efe2fd6@github.com> On Fri, 22 Nov 2024 06:44:31 GMT, SendaoYan <syan at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [752e1629](https://github.com/openjdk/jdk/commit/752e1629555f0ec8630373ec87b049afdd709ea6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 14 Nov 2024 and was reviewed by Daniel Fuchs, Mark Sheppard, SendaoYan and Alan Bateman. > > Thanks! This pull request has now been integrated. Changeset: 50aa07ef Author: SendaoYan <syan at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/50aa07ef1ee658424f016d06aeed7003bfba534d Stats: 33 lines in 2 files changed: 4 ins; 0 del; 29 mod 8343877: Test AsyncClose.java intermittent fails - Socket.getInputStream().read() wasn't preempted Backport-of: 752e1629555f0ec8630373ec87b049afdd709ea6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1174 From duke at openjdk.org Mon Nov 25 17:03:16 2024 From: duke at openjdk.org (duke) Date: Mon, 25 Nov 2024 17:03:16 GMT Subject: [jdk21u-dev] RFR: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set In-Reply-To: <HhdgJY_Yud2qt8zSfMJ7L1bqd5jHm0XPGhvDy-uXkHQ=.f557d3ff-b737-4b32-9c6a-944cb9901d95@github.com> References: <HhdgJY_Yud2qt8zSfMJ7L1bqd5jHm0XPGhvDy-uXkHQ=.f557d3ff-b737-4b32-9c6a-944cb9901d95@github.com> Message-ID: <U214fIaY3tCkN4l5kpxlGbT7Uqvcw1mzEeGMUjtiVfE=.5dbd4e91-cc33-4fad-b5bd-7bd6923c7359@github.com> On Fri, 22 Nov 2024 16:28:02 GMT, Saint Wesonga <duke at openjdk.org> wrote: > Backport https://github.com/openjdk/jdk23u/commit/7f189a59d9ad803aee72565bc46a817d3f46f2e5 to jdk23u. UnsafeIntrinsicsTest.java#ZGenerationalDebug test now passes in fastdebug on Windows AArch64 with this change. @swesonga Your change (at version cdbf48f3c656436ad14caa659d7927434ec76cdf) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1176#issuecomment-2498560549 From duke at openjdk.org Mon Nov 25 21:40:53 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 25 Nov 2024 21:40:53 GMT Subject: [jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v4] In-Reply-To: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> References: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> Message-ID: <AIBq8t4TyKj7LQgPZZXQ9Qy0YV_B3EidBEbeTdkcvJU=.adf0d542-9f55-42f3-9b9f-1809ca1bc53d@github.com> > An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions. > > The PR is separated in three commits for easier review: > > - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables: > - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used) > - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used). > - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14). > - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`). > > Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`. Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: Augment --disable-warnings-as-errors for clang >= 14.x.y ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2966/files - new: https://git.openjdk.org/jdk11u-dev/pull/2966/files/0a5ecb00..c8aa170c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2966&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2966&range=02-03 Stats: 41 lines in 8 files changed: 7 ins; 32 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2966.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2966/head:pull/2966 PR: https://git.openjdk.org/jdk11u-dev/pull/2966 From duke at openjdk.org Mon Nov 25 21:42:42 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 25 Nov 2024 21:42:42 GMT Subject: [jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v3] In-Reply-To: <x3HsZv4qmSYA8PuYkxSzpOB9xDPyYEKcu-ispJXNkU8=.d7ac8df1-6377-446c-8223-754c98b240a9@github.com> References: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> <x3HsZv4qmSYA8PuYkxSzpOB9xDPyYEKcu-ispJXNkU8=.d7ac8df1-6377-446c-8223-754c98b240a9@github.com> Message-ID: <VTaSyIwMi8TUKT0Oj2TAyGZAvUR7Rp4CYgR5z1dTFq0=.e99e14a0-c979-462d-9cef-58ce4b400ad4@github.com> On Tue, 19 Nov 2024 14:08:39 GMT, Antonio Vieiro <duke at openjdk.org> wrote: >> An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions. >> >> The PR is separated in three commits for easier review: >> >> - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables: >> - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used) >> - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used). >> - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14). >> - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`). >> >> Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`. > > Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: > > Removed doc instructions as per review Inspired by this comment > Is `--disable-warnings-as-errors` not sufficient to make the GHA build work on MacOS 13? It's not an ideal solution but it's a less disruptive way to keep a working MacOS build in the short term. I thought we could augment the `DISABLED_WARNINGS` on the macosx/clang 14.X.Y combo with `unused-parameter unused deprecated-declarations deprecated-non-prototype`. This change has no effect in previous clang versions, so builds and tests on these previous versions are unaffected. Building on XCode 14 and up will require now adding `--disable-warnings-as-errors` when running configure for these changes to take effect. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2966#issuecomment-2499089028 From duke at openjdk.org Mon Nov 25 21:54:10 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 25 Nov 2024 21:54:10 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v4] In-Reply-To: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> References: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> Message-ID: <Q7DgV4oGXgByQqUEQepmUbX_KjFPrTYTvSWEy5idgrs=.7df7c438-b905-4e18-9f22-c3a699868747@github.com> > An implementation of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) that bumps the GHA runners versions to `macos-13` and `XCode 14.3.1`. > > This uses the `--enable-xcode14` configuration flag introduced in https://github.com/openjdk/jdk11u-dev/pull/2966 ([JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458)) to build and run tier-1 tests on `macos-13` and `XCode 14.3.1`. > > Tier-1 tests seem to be failing randomly on macos-13/XCode14 with either a timeout or an ArrayIndexOutOfBoundsException t in serviceability/sa/ClhsdbFindPC.java. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). > > The rest of `tier1` tests are expected to pass on this platform. Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: Use --disable-warnings-as-errors for building on XCode 14 and up ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2967/files - new: https://git.openjdk.org/jdk11u-dev/pull/2967/files/34a5b048..fcfdd708 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2967&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2967&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2967.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2967/head:pull/2967 PR: https://git.openjdk.org/jdk11u-dev/pull/2967 From duke at openjdk.org Mon Nov 25 21:54:10 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 25 Nov 2024 21:54:10 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v3] In-Reply-To: <mwBGWK2kQBgtX997f0pX6JgV2B4EwwUcPmq90j56_8M=.2e4c722a-ebac-49b5-bd32-e2f59ef4baf6@github.com> References: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> <mwBGWK2kQBgtX997f0pX6JgV2B4EwwUcPmq90j56_8M=.2e4c722a-ebac-49b5-bd32-e2f59ef4baf6@github.com> Message-ID: <fzj-oI-lDQFTW-vNDkEuMTetPBnNx6mRqIumPd5Ds0c=.1fa60670-2e3e-4dea-b8c4-710a210e346c@github.com> On Tue, 19 Nov 2024 07:45:48 GMT, Antonio Vieiro <duke at openjdk.org> wrote: >> An implementation of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) that bumps the GHA runners versions to `macos-13` and `XCode 14.3.1`. >> >> This uses the `--enable-xcode14` configuration flag introduced in https://github.com/openjdk/jdk11u-dev/pull/2966 ([JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458)) to build and run tier-1 tests on `macos-13` and `XCode 14.3.1`. >> >> Tier-1 tests seem to be failing randomly on macos-13/XCode14 with either a timeout or an ArrayIndexOutOfBoundsException t in serviceability/sa/ClhsdbFindPC.java. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). >> >> The rest of `tier1` tests are expected to pass on this platform. > > Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 The second commit replaces the original `--enable-xcode14` with `--disable-warnings-as-errors`. Again, build and tests are expected to pass but for an `ArrayIndexOutOfBoundsException` in `serviceability/sa/ClhsdbFindPC.java' ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2967#issuecomment-2499107233 From abakhtin at openjdk.org Mon Nov 25 22:15:48 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 25 Nov 2024 22:15:48 GMT Subject: [jdk17u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files Message-ID: <Pd07J1RU-3hGN9lMvpJBSYh6xlp0QgOQlAcVNpmRuC0=.fc5918b9-f3cc-4682-bbe1-7d77fa935984@github.com> Almost clean backport from JDK21u patch The only manual merge is for jar.properties because of JDK-8302819 not backported to JDK17 JTREG tests passed ------------- Commit messages: - Backport 158b93d19a518d2b9d3d185e2d4c4dbff9c82aab Changes: https://git.openjdk.org/jdk17u-dev/pull/3075/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3075&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335912 Stats: 528 lines in 5 files changed: 526 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3075.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3075/head:pull/3075 PR: https://git.openjdk.org/jdk17u-dev/pull/3075 From mbalao at openjdk.org Mon Nov 25 22:23:16 2024 From: mbalao at openjdk.org (Martin Balao) Date: Mon, 25 Nov 2024 22:23:16 GMT Subject: [jdk21u-dev] RFR: 8344993: [21u] Re-introduce 8327501 and 8328366 to the JDK Message-ID: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> Hi, In this PR I back out 8341989 for 8327501 and 8328366 to be re-introduced to JDK 21u. I plan to propose a backport of 8342905 thereafter. Reversion of 8341989 was clean. Thanks, Martin.- ------------- Commit messages: - 8344993: [21u] Re-introduce 8327501 and 8328366 to the JDK Changes: https://git.openjdk.org/jdk21u-dev/pull/1181/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1181&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344993 Stats: 11 lines in 2 files changed: 8 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1181.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1181/head:pull/1181 PR: https://git.openjdk.org/jdk21u-dev/pull/1181 From abakhtin at openjdk.org Mon Nov 25 23:11:35 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 25 Nov 2024 23:11:35 GMT Subject: [jdk11u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files Message-ID: <z32K0nD8RdA6wQlVyh0K_YpLO5owiYUg_ev91NkhBWs=.d1a9fa02-fc0d-4db2-ad75-db9a957d3c1c@github.com> Almost clean backport from JDK17u The only trivial manual merge is for jar.properties because of JDK-8276766 and Main.java because of JDK-8266835 are not backported to JDK11 JTREG tests passed ------------- Commit messages: - Backport 158b93d19a518d2b9d3d185e2d4c4dbff9c82aab Changes: https://git.openjdk.org/jdk11u-dev/pull/2970/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2970&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335912 Stats: 528 lines in 5 files changed: 526 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2970.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2970/head:pull/2970 PR: https://git.openjdk.org/jdk11u-dev/pull/2970 From alanb at openjdk.org Tue Nov 26 08:59:50 2024 From: alanb at openjdk.org (Alan Bateman) Date: Tue, 26 Nov 2024 08:59:50 GMT Subject: [jdk21u-dev] RFR: 8344993: [21u] Re-introduce 8327501 and 8328366 to the JDK In-Reply-To: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> References: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> Message-ID: <psH6dJJyw_Q-Q2M089uVw50mXam8pO1uCkLbK3zpiQY=.bbe17e99-6431-498c-9bae-79af50fcbe4e@github.com> On Mon, 25 Nov 2024 22:17:04 GMT, Martin Balao <mbalao at openjdk.org> wrote: > Hi, > > In this PR I back out 8341989 for 8327501 and 8328366 to be re-introduced to JDK 21u. I plan to propose a backport of 8342905 thereafter. Reversion of 8341989 was clean. > > Thanks, > Martin.- src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 984: > 982: @SuppressWarnings("removal") > 983: SecurityManager sm = System.getSecurityManager(); > 984: if (sm != null && isCommon) The check should be `if (isCommon && JLA.allowSecurityManager())` as a SM can be set mid-flight even if it is super weird to do that. ------------- PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1181#discussion_r1858073335 From sgehwolf at openjdk.org Tue Nov 26 09:09:51 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 26 Nov 2024 09:09:51 GMT Subject: [jdk21u-dev] RFR: 8344993: [21u] Re-introduce 8327501 and 8328366 to the JDK In-Reply-To: <psH6dJJyw_Q-Q2M089uVw50mXam8pO1uCkLbK3zpiQY=.bbe17e99-6431-498c-9bae-79af50fcbe4e@github.com> References: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> <psH6dJJyw_Q-Q2M089uVw50mXam8pO1uCkLbK3zpiQY=.bbe17e99-6431-498c-9bae-79af50fcbe4e@github.com> Message-ID: <zZ4JocY_X1yiz_WVfwcAcZENLrSkodGZZxE3o_TTlvg=.1a8b5765-9bd8-4674-b400-afc6d2c93b99@github.com> On Tue, 26 Nov 2024 08:57:03 GMT, Alan Bateman <alanb at openjdk.org> wrote: >> Hi, >> >> In this PR I back out 8341989 for 8327501 and 8328366 to be re-introduced to JDK 21u. I plan to propose a backport of 8342905 thereafter. Reversion of 8341989 was clean. >> >> Thanks, >> Martin.- > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 984: > >> 982: @SuppressWarnings("removal") >> 983: SecurityManager sm = System.getSecurityManager(); >> 984: if (sm != null && isCommon) > > The check should be `if (isCommon && JLA.allowSecurityManager())` as a SM can be set mid-flight even if it is super weird to do that. I think this is what the backport of [JDK-8342905](https://bugs.openjdk.org/browse/JDK-8342905) will do which Martin mentioned he'll do as a follow-up after this one. ------------- PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1181#discussion_r1858088977 From aboldtch at openjdk.org Tue Nov 26 09:44:57 2024 From: aboldtch at openjdk.org (Axel Boldt-Christmas) Date: Tue, 26 Nov 2024 09:44:57 GMT Subject: [jdk23u] Integrated: 8340586: JdkJfrEvent::get_all_klasses stores non-strong oops in JNI handles In-Reply-To: <bO9rYB6nC4STutjBz7VkE5ZIFU62QiH0Mh4kkETPWC8=.d2a8c97f-8e2e-4c6c-9b22-8ba2e8c227a2@github.com> References: <bO9rYB6nC4STutjBz7VkE5ZIFU62QiH0Mh4kkETPWC8=.d2a8c97f-8e2e-4c6c-9b22-8ba2e8c227a2@github.com> Message-ID: <BsBbXGzCmYMiQB43Hm8P6rBH-dAoRQmyrzg1MGhG1Mg=.66955eb1-6a11-4e26-b1cd-4613fc16d73f@github.com> On Thu, 7 Nov 2024 10:55:05 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [97b681e9](https://github.com/openjdk/jdk/commit/97b681e93a9469d8d16122dc10bbf2f5b5fe2266) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Axel Boldt-Christmas on 7 Nov 2024 and was reviewed by Coleen Phillimore, Stefan Karlsson and Markus Gr?nlund. > > Thanks! This pull request has now been integrated. Changeset: d6204268 Author: Axel Boldt-Christmas <aboldtch at openjdk.org> Committer: Stefan Karlsson <stefank at openjdk.org> URL: https://git.openjdk.org/jdk23u/commit/d620426835a15fe75c42758567a7dab4ef0eb772 Stats: 34 lines in 3 files changed: 17 ins; 13 del; 4 mod 8340586: JdkJfrEvent::get_all_klasses stores non-strong oops in JNI handles Backport-of: 97b681e93a9469d8d16122dc10bbf2f5b5fe2266 ------------- PR: https://git.openjdk.org/jdk23u/pull/218 From amitkumar at openjdk.org Tue Nov 26 11:09:40 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Tue, 26 Nov 2024 11:09:40 GMT Subject: [jdk23u] RFR: 8336012: Fix usages of jtreg-reserved properties In-Reply-To: <iRrBOUJBCt-Mx4fnWjTbbxFF2NZI-6oZy-SfW0syLy8=.1b79d702-5285-445d-a5d3-64354836b1f6@github.com> References: <iRrBOUJBCt-Mx4fnWjTbbxFF2NZI-6oZy-SfW0syLy8=.1b79d702-5285-445d-a5d3-64354836b1f6@github.com> Message-ID: <qg0kJvD0tzd66wo62Cx1s1zw5Q6niYoYp6m_pIoTD5U=.375acec9-2252-4c50-972b-ca4381d28e1e@github.com> On Tue, 12 Nov 2024 03:08:38 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [e6c5aa7a](https://github.com/openjdk/jdk/commit/e6c5aa7a6cb54c647d261facdcffa6a410849627) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > `test/jdk/java/lang/invoke/PrivateInvokeTest.java` is failing on s390x JDK23 - CI consistently. error: > > > STDERR: > STARTED test.java.lang.invoke.PrivateInvokeTest::testFirst 'testFirst' > java.lang.NumberFormatException: For input string: "Verbose[p=SUMMARY,f=FULL,e=FULL,t=false,m=false]" > at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) > at java.base/java.lang.Integer.parseInt(Integer.java:588) > at java.base/java.lang.Integer.parseInt(Integer.java:685) > at test.java.lang.invoke.PrivateInvokeTest.<init>(PrivateInvokeTest.java:72) > at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501) > at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:485) > FAILED test.java.lang.invoke.PrivateInvokeTest::testFirst 'testFirst' [60ms] > STARTED test.java.lang.invoke.PrivateInvokeTest::testInvokeDirect 'testInvokeDirect' > java.lang.NumberFormatException: For input string: "Verbose[p=SUMMARY,f=FULL,e=FULL,t=false,m=false]" > at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) > at java.base/java.lang.Integer.parseInt(Integer.java:588) > at java.base/java.lang.Integer.parseInt(Integer.java:685) > at test.java.lang.invoke.PrivateInvokeTest.<init>(PrivateInvokeTest.java:72) > at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501) > at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:485) > FAILED test.java.lang.invoke.PrivateInvokeTest::testInvokeDirect 'testInvokeDirect' [4ms] > JavaTest Message: JUnit Platform Failure(s): 2 > > [ JUnit Containers: found 4, started 4, succeeded 4, failed 0, aborted 0, skipped 0] > [ JUnit Tests: found 2, started 2, succeeded 0, failed 2, aborted 0, skipped 0] > > java.lang.Exception: JUnit test failure > at com.sun.javatest.regtest.agent.JUnitRunner.runWithJUnitPlatform(JUnitRunner.java:155) > at com.sun.javatest.regtest.agent.JUnitRunner.main(JUnitRunner.java:99) > at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) > at java.base/java.lang.reflect.Method.invoke(Method.java:580) > at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333) > at java.base/java.lang.Thread.run(Thre... Hi, Can I get a sponsor for this clean-backport ? ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/222#issuecomment-2500321361 From amitkumar at openjdk.org Tue Nov 26 11:10:46 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Tue, 26 Nov 2024 11:10:46 GMT Subject: [jdk23u] RFR: 8319947: Recursive lightweight locking: s390x implementation In-Reply-To: <a9xbtmTtwZOqFSL7tqyk5Z0Sx6-6C7y9he2Gn4kR58E=.3550d35e-ae9a-45f5-8e93-fa2925adedef@github.com> References: <a9xbtmTtwZOqFSL7tqyk5Z0Sx6-6C7y9he2Gn4kR58E=.3550d35e-ae9a-45f5-8e93-fa2925adedef@github.com> Message-ID: <ZBjsm4ZKhh2qTDgpzU6mYY-KK91iHAkICgcDs32HGgY=.20199d21-db72-43eb-b39e-769afe9ce445@github.com> On Mon, 11 Nov 2024 14:34:25 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [d457609f](https://github.com/openjdk/jdk/commit/d457609f700bbb1fed233f1a04501c995852e5ac) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 28 Jun 2024 and was reviewed by Axel Boldt-Christmas and Lutz Schmidt. > > Thanks! This backport is also clean, if someone could help me with sponsoring it. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/221#issuecomment-2500323347 From duke at openjdk.org Tue Nov 26 11:29:34 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 26 Nov 2024 11:29:34 GMT Subject: [jdk17u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names Message-ID: <TgaabuJ4kLIMG1jKbU2qfiJLjmgHhdQKkYr3O640A5U=.7686ead0-df43-423f-bda4-bd102843591e@github.com> Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). Tested with tier1 tests and also processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) ------------- Commit messages: - Backport bc4abb4379ced7ddfb3d173d2dfc669a4b11d12f Changes: https://git.openjdk.org/jdk17u-dev/pull/3076/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3076&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340552 Stats: 12 lines in 1 file changed: 8 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3076.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3076/head:pull/3076 PR: https://git.openjdk.org/jdk17u-dev/pull/3076 From duke at openjdk.org Tue Nov 26 13:17:52 2024 From: duke at openjdk.org (duke) Date: Tue, 26 Nov 2024 13:17:52 GMT Subject: [jdk23u] RFR: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java In-Reply-To: <GzlWJJPxavKkqQY2spMqtWP3vwIRaCfZkD8dhmdvuH4=.ac1719f5-8bd1-416d-a9ee-5e3260a1ce0f@github.com> References: <GzlWJJPxavKkqQY2spMqtWP3vwIRaCfZkD8dhmdvuH4=.ac1719f5-8bd1-416d-a9ee-5e3260a1ce0f@github.com> Message-ID: <Fmm_QflMDFBH_I80HL56jK9RTjIKl35OdDo5Z5Lv5fw=.0f5e027c-dc99-4c50-826b-aafc18d1cd32@github.com> On Mon, 18 Nov 2024 04:53:38 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [3245f56e](https://github.com/openjdk/jdk/commit/3245f56e53792b3cfc9788799ba1594d6af15bea) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 15 Nov 2024 and was reviewed by Lutz Schmidt. > > Thanks! @offamitkumar Your change (at version 692079026af09c3dcdf49307a51cbb7701dd8cad) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/226#issuecomment-2500774294 From duke at openjdk.org Tue Nov 26 13:26:06 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Tue, 26 Nov 2024 13:26:06 GMT Subject: [jdk21u-dev] RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform Message-ID: <X6mp770KuGNUcM4F9Os6ljRpAmpdCc_4WzHNub1-oBo=.b0acb5ce-e2a4-46cd-b028-a8151477a5e8@github.com> Hi all, This is a backport of JDK-8344275 : tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform Original patch does not apply cleanly because JDK-8340311 and JDK-8343314 are not applied to jdk21. JDK-8340311 and JDK-8343314 are enhancement, so I don't backport them. Testing: tools/jpackage tests importing jdk.jpackage.test.Executor on Windows Server 2019 (Japanese and English locales) Thanks. ------------- Commit messages: - Merge branch 'openjdk:master' into fix_Win8301247Test_bug - Backport JDK-8344275 Changes: https://git.openjdk.org/jdk21u-dev/pull/1182/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1182&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344275 Stats: 34 lines in 2 files changed: 27 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1182.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1182/head:pull/1182 PR: https://git.openjdk.org/jdk21u-dev/pull/1182 From duke at openjdk.org Tue Nov 26 14:17:46 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 26 Nov 2024 14:17:46 GMT Subject: [jdk17u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <TgaabuJ4kLIMG1jKbU2qfiJLjmgHhdQKkYr3O640A5U=.7686ead0-df43-423f-bda4-bd102843591e@github.com> References: <TgaabuJ4kLIMG1jKbU2qfiJLjmgHhdQKkYr3O640A5U=.7686ead0-df43-423f-bda4-bd102843591e@github.com> Message-ID: <HRiQwfiBHQxd62vB7C6SUHRHJcJXzGIofW-tzQKwAPY=.5ad98c02-c5b7-4158-a5de-f84dcc75b3f3@github.com> On Tue, 26 Nov 2024 11:23:22 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested with tier1 tests and also processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) Build failure is unrelated. It's due to [abusing downloads from archive.apache.org:](https://infra.apache.org/infra-ban.html) [build.sh][INFO] Downloading https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.8-bin.zip to /home/runner/work/jdk21u-dev/jdk21u-dev/jtreg/src/make/../build/deps/apache-ant-1.10.8-bin.zip Error: sh][ERROR] wget exited with exit code 4 Error: Process completed with exit code 1. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3076#issuecomment-2500915130 From mbaesken at openjdk.org Tue Nov 26 15:12:24 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 26 Nov 2024 15:12:24 GMT Subject: [jdk21u-dev] RFR: 8345055: ProblemList failing rtm tests on ppc platforms Message-ID: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> Exclude some rtm related test which we see currently failing on some ppc64 platforms. ------------- Commit messages: - JDK-8345055 Changes: https://git.openjdk.org/jdk21u-dev/pull/1183/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1183&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345055 Stats: 11 lines in 1 file changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1183.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1183/head:pull/1183 PR: https://git.openjdk.org/jdk21u-dev/pull/1183 From duke at openjdk.org Tue Nov 26 15:51:25 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Tue, 26 Nov 2024 15:51:25 GMT Subject: [jdk11u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b Message-ID: <wGlr2PR50Y7HO-NaFJV09fl4fFJMjNLe1DDefe2_NTo=.4b787ff7-9b06-40e7-a3b3-42366bbb1afb@github.com> Backport of JDK-8339637 from 17u-dev. Clean backport. Passed tier1 tests. Passed gtests. ------------- Commit messages: - Backport fbc040cf8a17fc8de15b8771765441b86a8169ae Changes: https://git.openjdk.org/jdk11u-dev/pull/2971/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2971&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339637 Stats: 1316 lines in 16 files changed: 400 ins; 60 del; 856 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2971.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2971/head:pull/2971 PR: https://git.openjdk.org/jdk11u-dev/pull/2971 From mdoerr at openjdk.org Tue Nov 26 17:10:50 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 26 Nov 2024 17:10:50 GMT Subject: [jdk21u-dev] RFR: 8345055: ProblemList failing rtm tests on ppc platforms In-Reply-To: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> References: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> Message-ID: <u6IQgfj4edOaqU2OQQdDanQ676eO-uP5xHIY5spv3AI=.773370d3-1e15-41bd-925f-0db54d98b7db@github.com> On Tue, 26 Nov 2024 15:08:05 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > Exclude some rtm related test which we see currently failing on some ppc64 platforms. test/hotspot/jtreg/ProblemList.txt line 64: > 62: compiler/rtm/locking/TestUseRTMDeopt.java 8183263 generic-x64,generic-i586,generic-ppc64le,generic-ppc64 > 63: compiler/rtm/locking/TestUseRTMXendForLockBusy.java 8183263,8307907 generic-x64,generic-i586,generic-ppc64le,generic-ppc64 > 64: compiler/rtm/print/TestPrintPreciseRTMLockingStatistics.java 8183263,8307907 generic-x64,generic-i586, The last line should get updated, too. ------------- PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1183#discussion_r1858936962 From duke at openjdk.org Wed Nov 27 04:19:50 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Wed, 27 Nov 2024 04:19:50 GMT Subject: [jdk11u-dev] RFR: 8026976: ECParameters, Point does not match field size In-Reply-To: <VO_d4MJBGy62PUI87lIRgShsUSwqWZs3MT1OFb0gaBU=.718d419a-e5cd-4e26-8df7-de70adc97da0@github.com> References: <VO_d4MJBGy62PUI87lIRgShsUSwqWZs3MT1OFb0gaBU=.718d419a-e5cd-4e26-8df7-de70adc97da0@github.com> Message-ID: <LxNRSerBFOXgv1W4qUghIkHxQ0Rk6pTwA62YmBMKU-o=.ec9c8d79-4a6c-4b5f-9d98-e396972a4819@github.com> On Mon, 21 Oct 2024 07:15:55 GMT, Taizo Kurashige <duke at openjdk.org> wrote: > Hi all, > > This is a backport of JDK-8026976: ECParameters, Point does not match field size > > Original patch apply cleanly to 11u. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. Could anyone review this backport please? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2958#issuecomment-2502691842 From duke at openjdk.org Wed Nov 27 04:37:48 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Wed, 27 Nov 2024 04:37:48 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v2] In-Reply-To: <D9gyvzA69cZkHLDMxrLoVNJxO-89WTkmr9-8zD-T0v0=.7312a615-d7c2-4d51-a4ad-715082e4fa0b@github.com> References: <Nm9nt3ihKhACiDQgVwXSrcEDnd-HkyBTBJPU_cv2DDs=.714d8254-9859-4393-b0b2-1c6cb67d4379@github.com> <bX_isycwgNMnBwm2FpfH7Y1YfHCd_uWGOt8cKb5rSlE=.380e649c-a8d8-4a7e-95e8-140804e89c5c@github.com> <D9gyvzA69cZkHLDMxrLoVNJxO-89WTkmr9-8zD-T0v0=.7312a615-d7c2-4d51-a4ad-715082e4fa0b@github.com> Message-ID: <G28oDP0_fZcHgAT2sk2FRtTxI-5yceNv2W_kjLkA0sA=.56124284-a47e-4ce9-9c32-92c5d0ad7a4b@github.com> On Wed, 6 Nov 2024 08:49:42 GMT, Andrew Haley <aph at openjdk.org> wrote: >> Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: >> >> - Merge branch 'openjdk:master' into backport-8296631 >> - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 >> - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 > > Why are the two sets of files key4.db and cert9.db different? > > > zarquon:Downloads $ shasum cert9*.db > 41eed34f2505f3a549cb85542ae58b2f239c593e cert9(1).db > b0e2a3aa1c884de00a342e01d5c2aa4c4ca1d801 cert9.db > zarquon:Downloads $ shasum key4*.db > c06ef63d0a2e960bbe91744c2fe1b8e7cd2bd841 key4(1).db > 0a48f27990384fbae2d70dc9a496d08b6b5ea0f3 key4.db > > > dbtool can't read the files in fips/. Are they a different kind of database? @theRealAph If you have time, I would like you to check my comment and fix. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2955#issuecomment-2502747710 From amitkumar at openjdk.org Wed Nov 27 08:21:59 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Wed, 27 Nov 2024 08:21:59 GMT Subject: [jdk23u] RFR: 8342409: [s390x] C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR Message-ID: <PoTxD38Z0m8xtq-2LIzvzYNIrI8AYqwO0yRHtarxG0k=.a5d57f95-7bde-416f-a247-9056bb3ae0c8@github.com> Hi all, This pull request contains a backport of commit [9201e9fc](https://github.com/openjdk/jdk/commit/9201e9fcc28cff37cf9996e8db38f9aee7511b1c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 18 Oct 2024 and was reviewed by Richard Reingruber and Lutz Schmidt. Thanks! ------------- Commit messages: - Backport 9201e9fcc28cff37cf9996e8db38f9aee7511b1c Changes: https://git.openjdk.org/jdk23u/pull/229/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=229&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342409 Stats: 9 lines in 2 files changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/229.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/229/head:pull/229 PR: https://git.openjdk.org/jdk23u/pull/229 From amitkumar at openjdk.org Wed Nov 27 08:33:21 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Wed, 27 Nov 2024 08:33:21 GMT Subject: [jdk21u-dev] RFR: 8342409: [s390x] C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR Message-ID: <CaPtLN03DsjJx2HSui-Yi_i9f6sBrtkpoAp_OsyqU6M=.ac6ef6e5-df83-44e6-a438-74f3e3667575@github.com> Hi all, This pull request contains a backport of commit [9201e9fc](https://github.com/openjdk/jdk/commit/9201e9fcc28cff37cf9996e8db38f9aee7511b1c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 18 Oct 2024 and was reviewed by Richard Reingruber and Lutz Schmidt. Thanks! ------------- Commit messages: - Backport 9201e9fcc28cff37cf9996e8db38f9aee7511b1c Changes: https://git.openjdk.org/jdk21u-dev/pull/1184/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1184&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342409 Stats: 9 lines in 2 files changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1184.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1184/head:pull/1184 PR: https://git.openjdk.org/jdk21u-dev/pull/1184 From mbaesken at openjdk.org Wed Nov 27 09:05:28 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 27 Nov 2024 09:05:28 GMT Subject: [jdk21u-dev] RFR: 8345055: ProblemList failing rtm tests on ppc platforms [v2] In-Reply-To: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> References: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> Message-ID: <CKib1ryEclSLWHA5hKbdqlJUqWhh5EIkpElcGUu9caE=.7b69fd3e-7c24-42e7-9858-fd6649fcef17@github.com> > Exclude some rtm related test which we see currently failing on some ppc64 platforms. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: exclude TestPrintPreciseRTMLockingStatistics too on ppc64 and ppc64le ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1183/files - new: https://git.openjdk.org/jdk21u-dev/pull/1183/files/7f986fbf..98b06edf Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1183&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1183&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1183.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1183/head:pull/1183 PR: https://git.openjdk.org/jdk21u-dev/pull/1183 From mbaesken at openjdk.org Wed Nov 27 09:05:28 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 27 Nov 2024 09:05:28 GMT Subject: [jdk21u-dev] RFR: 8345055: ProblemList failing rtm tests on ppc platforms [v2] In-Reply-To: <u6IQgfj4edOaqU2OQQdDanQ676eO-uP5xHIY5spv3AI=.773370d3-1e15-41bd-925f-0db54d98b7db@github.com> References: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> <u6IQgfj4edOaqU2OQQdDanQ676eO-uP5xHIY5spv3AI=.773370d3-1e15-41bd-925f-0db54d98b7db@github.com> Message-ID: <14vROU3-lUYevb27qK4Gg2p0ac8987j0aOdKjo0nmQE=.8b3407d1-3919-474a-a4bf-4e19ea0f6130@github.com> On Tue, 26 Nov 2024 17:08:19 GMT, Martin Doerr <mdoerr at openjdk.org> wrote: >> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: >> >> exclude TestPrintPreciseRTMLockingStatistics too on ppc64 and ppc64le > > test/hotspot/jtreg/ProblemList.txt line 64: > >> 62: compiler/rtm/locking/TestUseRTMDeopt.java 8183263 generic-x64,generic-i586,generic-ppc64le,generic-ppc64 >> 63: compiler/rtm/locking/TestUseRTMXendForLockBusy.java 8183263,8307907 generic-x64,generic-i586,generic-ppc64le,generic-ppc64 >> 64: compiler/rtm/print/TestPrintPreciseRTMLockingStatistics.java 8183263,8307907 generic-x64,generic-i586, > > The last line should get updated, too. Yes I added it. But for some strange reason I do not see many failures with this test, only 2 on AIX this year. Very strange. The others fail very often. ------------- PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1183#discussion_r1860251242 From syan at openjdk.org Wed Nov 27 09:13:55 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 27 Nov 2024 09:13:55 GMT Subject: [jdk21u-dev] RFR: 8344628: Test TestEnableJVMCIProduct.java run with virtual thread intermittent fails Message-ID: <qa_rNprlt5ibVNEV6Ef8kuJFEpavNSGXNc9ApP2nnCo=.bada2240-9285-4874-a1b9-9776a8079e9f@github.com> Hi all, This pull request contains a backport of commit [3a625f38](https://github.com/openjdk/jdk/commit/3a625f38aa4ab611fe5c7dffe420abce826d0d7e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Doug Simon on 26 Nov 2024 and was reviewed by SendaoYan, Dean Long and Hamlin Li. Thanks! ------------- Commit messages: - Backport 3a625f38aa4ab611fe5c7dffe420abce826d0d7e Changes: https://git.openjdk.org/jdk21u-dev/pull/1185/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1185&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344628 Stats: 19 lines in 1 file changed: 13 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1185.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1185/head:pull/1185 PR: https://git.openjdk.org/jdk21u-dev/pull/1185 From mdoerr at openjdk.org Wed Nov 27 11:27:46 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 27 Nov 2024 11:27:46 GMT Subject: [jdk21u-dev] RFR: 8345055: ProblemList failing rtm tests on ppc platforms [v2] In-Reply-To: <CKib1ryEclSLWHA5hKbdqlJUqWhh5EIkpElcGUu9caE=.7b69fd3e-7c24-42e7-9858-fd6649fcef17@github.com> References: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> <CKib1ryEclSLWHA5hKbdqlJUqWhh5EIkpElcGUu9caE=.7b69fd3e-7c24-42e7-9858-fd6649fcef17@github.com> Message-ID: <TmR8YEFT25bpyE3Q4JuLpLD44Jf6NU6XVl1PKzUXaaU=.67708c1b-2dd5-4cc2-83ac-f66b49d6534a@github.com> On Wed, 27 Nov 2024 09:05:28 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: >> Exclude some rtm related test which we see currently failing on some ppc64 platforms. > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > exclude TestPrintPreciseRTMLockingStatistics too on ppc64 and ppc64le Marked as reviewed by mdoerr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1183#pullrequestreview-2464744553 From aph at openjdk.org Wed Nov 27 11:31:53 2024 From: aph at openjdk.org (Andrew Haley) Date: Wed, 27 Nov 2024 11:31:53 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v4] In-Reply-To: <wYQx4reYw191HCZv7EJ5NdTH9gzpdSGndMPPWKpcXe8=.fe1edce0-85d4-4dec-bd84-edbab5d5b763@github.com> References: <Nm9nt3ihKhACiDQgVwXSrcEDnd-HkyBTBJPU_cv2DDs=.714d8254-9859-4393-b0b2-1c6cb67d4379@github.com> <wYQx4reYw191HCZv7EJ5NdTH9gzpdSGndMPPWKpcXe8=.fe1edce0-85d4-4dec-bd84-edbab5d5b763@github.com> Message-ID: <nnZ9sXkBnA9dbhu-8TBV307qRFki_IiEiHkmCimgUNI=.b3633c73-ca91-4b47-80aa-cc98350a86a9@github.com> On Thu, 7 Nov 2024 13:13:10 GMT, Taizo Kurashige <duke at openjdk.org> wrote: >> Hi, >> >> This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts >> >> Original patch does not apply cleanly for the following reasons: >> >> ?Fix to getOsMap() in test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied since getOsMap() was removed in https://bugs.openjdk.org/browse/JDK-8331700. >> ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in [https://bugs.openjdk.org/browse/JDK-8220753](https://bugs.openjdk.org/browse/JDK-8220753%28jdk13%29) (jdk13). >> ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed in https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. >> >> Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing >> >> Thanks. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > Replace pkcs11/fips/key4.db and pkcs11.txt What do you see? $ pwd /local/jdk11u-dev/test/jdk/sun/security/pkcs11/fips $ /usr/lib64/nss/unsupported-tools/dbtool -d . dbdir selected is . CertDB: KeyDB: ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2955#issuecomment-2503633598 From mbaesken at openjdk.org Wed Nov 27 12:51:46 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 27 Nov 2024 12:51:46 GMT Subject: [jdk21u-dev] RFR: 8345055: ProblemList failing rtm tests on ppc platforms [v2] In-Reply-To: <CKib1ryEclSLWHA5hKbdqlJUqWhh5EIkpElcGUu9caE=.7b69fd3e-7c24-42e7-9858-fd6649fcef17@github.com> References: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> <CKib1ryEclSLWHA5hKbdqlJUqWhh5EIkpElcGUu9caE=.7b69fd3e-7c24-42e7-9858-fd6649fcef17@github.com> Message-ID: <EQ3CskjaDT7Z9NZoyOv-3MSQJZ2YO5w1z2TPe8SYNE0=.c1fbed0a-d5ee-4a0a-986c-033551f03e82@github.com> On Wed, 27 Nov 2024 09:05:28 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: >> Exclude some rtm related test which we see currently failing on some ppc64 platforms. > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > exclude TestPrintPreciseRTMLockingStatistics too on ppc64 and ppc64le Hi Martin, thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1183#issuecomment-2503796576 From goetz at openjdk.org Wed Nov 27 13:07:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Nov 2024 13:07:39 GMT Subject: [jdk21u-dev] RFR: 8345055: ProblemList failing rtm tests on ppc platforms [v2] In-Reply-To: <CKib1ryEclSLWHA5hKbdqlJUqWhh5EIkpElcGUu9caE=.7b69fd3e-7c24-42e7-9858-fd6649fcef17@github.com> References: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> <CKib1ryEclSLWHA5hKbdqlJUqWhh5EIkpElcGUu9caE=.7b69fd3e-7c24-42e7-9858-fd6649fcef17@github.com> Message-ID: <tSAXSh59nijfT4zryRpv2lcw1DgMjLZCP7cf6RpKIrs=.5dcd4b10-dc96-40c6-aa2a-7d4840d7f361@github.com> On Wed, 27 Nov 2024 09:05:28 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: >> Exclude some rtm related test which we see currently failing on some ppc64 platforms. > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > exclude TestPrintPreciseRTMLockingStatistics too on ppc64 and ppc64le Hi, can you please add [21u] to the title? You need to do this in the PR and the JBS issue (not needed in the commit). Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1183#issuecomment-2503829177 From sgehwolf at openjdk.org Wed Nov 27 13:45:41 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 27 Nov 2024 13:45:41 GMT Subject: [jdk21u-dev] RFR: 8344993: [21u] Re-introduce 8327501 and 8328366 to the JDK In-Reply-To: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> References: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> Message-ID: <2oZGFKM8ayoofTBLsJT4x_PT7muEeUe8JPrKo-xwhkw=.30a1c613-ed82-4ecf-8604-28d33daab7b1@github.com> On Mon, 25 Nov 2024 22:17:04 GMT, Martin Balao <mbalao at openjdk.org> wrote: > Hi, > > In this PR I back out 8341989 for 8327501 and 8328366 to be re-introduced to JDK 21u. I plan to propose a backport of 8342905 thereafter. Reversion of 8341989 was clean. > > Thanks, > Martin.- LGTM ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1181#pullrequestreview-2465066647 From sgehwolf at openjdk.org Wed Nov 27 13:53:47 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 27 Nov 2024 13:53:47 GMT Subject: [jdk21u-dev] RFR: 8344993: [21u] Re-introduce 8327501 and 8328366 to the JDK In-Reply-To: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> References: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> Message-ID: <nsac7Ba2O7kNq2_lsP-ZpfYECxkVeW-NnZcDiDluW7Y=.e69749f7-beed-468d-8c25-935e429deb48@github.com> On Mon, 25 Nov 2024 22:17:04 GMT, Martin Balao <mbalao at openjdk.org> wrote: > Hi, > > In this PR I back out 8341989 for 8327501 and 8328366 to be re-introduced to JDK 21u. I plan to propose a backport of 8342905 thereafter. Reversion of 8341989 was clean. > > Thanks, > Martin.- @martinuy Please fix the PR title mismatch. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1181#issuecomment-2503930487 From andrew at openjdk.org Wed Nov 27 14:15:50 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Nov 2024 14:15:50 GMT Subject: [jdk11u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <wGlr2PR50Y7HO-NaFJV09fl4fFJMjNLe1DDefe2_NTo=.4b787ff7-9b06-40e7-a3b3-42366bbb1afb@github.com> References: <wGlr2PR50Y7HO-NaFJV09fl4fFJMjNLe1DDefe2_NTo=.4b787ff7-9b06-40e7-a3b3-42366bbb1afb@github.com> Message-ID: <_TQ-gioRsYU59GPhrY7iQIrAZAR_FYFKXH5F93LVQPc=.2ae3d851-5ba9-479e-9ef7-a7b919ddae3e@github.com> On Tue, 26 Nov 2024 15:45:32 GMT, Radek ??p <duke at openjdk.org> wrote: > Backport of JDK-8339637 from 17u-dev. > > Clean backport. Passed tier1 tests. Passed gtests. Confirmed clean. Do the timezone tests (`java/time`, `java/text/Format`, `java/util/TimeZone`, `sun/util/calendar` and `sun/util/resources`) pass? The first two are not covered by tier 1 testing. ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2971#pullrequestreview-2465145699 From andrew at openjdk.org Wed Nov 27 14:25:43 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Nov 2024 14:25:43 GMT Subject: [jdk11u-dev] RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files In-Reply-To: <9hd_GHxl58UPjSaK0bHqMnMIAIrn6zulQD4QHoD2wZ4=.d52daacf-403b-4fcd-9aa0-b4527c0fc0f9@github.com> References: <9hd_GHxl58UPjSaK0bHqMnMIAIrn6zulQD4QHoD2wZ4=.d52daacf-403b-4fcd-9aa0-b4527c0fc0f9@github.com> Message-ID: <bQj8Cg0E1zCKy4_wYrdOERLcGpRAVw8ol0HOu_vNrBg=.0c266b09-338d-470d-8021-c8e63120b022@github.com> On Mon, 11 Nov 2024 15:13:30 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Backport of [JDK-8339803](https://bugs.openjdk.org/browse/JDK-8339803) from 17u. Related to tz-2024b timezone update. > > Clean backport. Passed tier1 tests. Confirmed clean. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2964#pullrequestreview-2465178560 From duke at openjdk.org Wed Nov 27 14:28:51 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Wed, 27 Nov 2024 14:28:51 GMT Subject: [jdk11u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <wGlr2PR50Y7HO-NaFJV09fl4fFJMjNLe1DDefe2_NTo=.4b787ff7-9b06-40e7-a3b3-42366bbb1afb@github.com> References: <wGlr2PR50Y7HO-NaFJV09fl4fFJMjNLe1DDefe2_NTo=.4b787ff7-9b06-40e7-a3b3-42366bbb1afb@github.com> Message-ID: <B4mYOLc3TKKuabzOFzf3Ni2HGa5xMxrpqbBjA-9n7uE=.7a59fd38-c276-48ca-b7de-ec63601aef9c@github.com> On Tue, 26 Nov 2024 15:45:32 GMT, Radek ??p <duke at openjdk.org> wrote: > Backport of JDK-8339637 from 17u-dev. > > Clean backport. Passed tier1 tests. Passed gtests. I run `make run-test TEST="jtreg:java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources"` with these results: ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/java/text/Format 90 90 0 0 jtreg:test/jdk/java/util/TimeZone 25 25 0 0 jtreg:test/jdk/sun/util/calendar 5 5 0 0 jtreg:test/jdk/sun/util/resources 21 21 0 0 ============================== TEST SUCCESS Finished building target 'run-test' in configuration 'linux-x86_64-normal-server-release' ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2971#issuecomment-2504016961 From andrew at openjdk.org Wed Nov 27 14:40:48 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Nov 2024 14:40:48 GMT Subject: [jdk11u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <wGlr2PR50Y7HO-NaFJV09fl4fFJMjNLe1DDefe2_NTo=.4b787ff7-9b06-40e7-a3b3-42366bbb1afb@github.com> References: <wGlr2PR50Y7HO-NaFJV09fl4fFJMjNLe1DDefe2_NTo=.4b787ff7-9b06-40e7-a3b3-42366bbb1afb@github.com> Message-ID: <0oxMuQj1rUN7Id4-zaDM-DjimXGbqPQ7WWuoAstOBpk=.621f0623-0243-4f19-8793-8b1f61219c7f@github.com> On Tue, 26 Nov 2024 15:45:32 GMT, Radek ??p <duke at openjdk.org> wrote: > Backport of JDK-8339637 from 17u-dev. > > Clean backport. Passed tier1 tests. Passed gtests. Thanks. Looks good to me. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2971#pullrequestreview-2465219090 From duke at openjdk.org Wed Nov 27 14:50:45 2024 From: duke at openjdk.org (duke) Date: Wed, 27 Nov 2024 14:50:45 GMT Subject: [jdk11u-dev] RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files In-Reply-To: <9hd_GHxl58UPjSaK0bHqMnMIAIrn6zulQD4QHoD2wZ4=.d52daacf-403b-4fcd-9aa0-b4527c0fc0f9@github.com> References: <9hd_GHxl58UPjSaK0bHqMnMIAIrn6zulQD4QHoD2wZ4=.d52daacf-403b-4fcd-9aa0-b4527c0fc0f9@github.com> Message-ID: <YszDbizmNSsNmj5uNJZEkTjes-CayAl2WsMlsne4naQ=.b946ef6e-a70b-4d7a-8bcc-df2fab99cc93@github.com> On Mon, 11 Nov 2024 15:13:30 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Backport of [JDK-8339803](https://bugs.openjdk.org/browse/JDK-8339803) from 17u. Related to tz-2024b timezone update. > > Clean backport. Passed tier1 tests. @vieiro Your change (at version b2148c384619433cc4e86cd59a204963051b1f48) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2964#issuecomment-2504067491 From duke at openjdk.org Wed Nov 27 14:56:42 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 27 Nov 2024 14:56:42 GMT Subject: [jdk11u-dev] Integrated: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files In-Reply-To: <9hd_GHxl58UPjSaK0bHqMnMIAIrn6zulQD4QHoD2wZ4=.d52daacf-403b-4fcd-9aa0-b4527c0fc0f9@github.com> References: <9hd_GHxl58UPjSaK0bHqMnMIAIrn6zulQD4QHoD2wZ4=.d52daacf-403b-4fcd-9aa0-b4527c0fc0f9@github.com> Message-ID: <2NTuEWYOS3C4PQ1CIEcK2fRnk_ftW2OUGP4V70YG3Qk=.a426f942-c95e-49a6-86a2-6e10b7902878@github.com> On Mon, 11 Nov 2024 15:13:30 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Backport of [JDK-8339803](https://bugs.openjdk.org/browse/JDK-8339803) from 17u. Related to tz-2024b timezone update. > > Clean backport. Passed tier1 tests. This pull request has now been integrated. Changeset: 2155f8d2 Author: Antonio Vieiro <avieirov at redhat.com> Committer: Andrew John Hughes <andrew at openjdk.org> URL: https://git.openjdk.org/jdk11u-dev/commit/2155f8d22a5e34d9b9386485b2a6a1c2bdf8b52c Stats: 20 lines in 3 files changed: 4 ins; 0 del; 16 mod 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files Reviewed-by: andrew Backport-of: 0d7b2729e4f4c0fec2dcfea65a0834732a408ee4 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2964 From duke at openjdk.org Wed Nov 27 15:06:00 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Wed, 27 Nov 2024 15:06:00 GMT Subject: [jdk11u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b [v2] In-Reply-To: <wGlr2PR50Y7HO-NaFJV09fl4fFJMjNLe1DDefe2_NTo=.4b787ff7-9b06-40e7-a3b3-42366bbb1afb@github.com> References: <wGlr2PR50Y7HO-NaFJV09fl4fFJMjNLe1DDefe2_NTo=.4b787ff7-9b06-40e7-a3b3-42366bbb1afb@github.com> Message-ID: <1pD3Ld9XSzVlo9xgUWy1YKRSfhQ0AIVh2beqm7OYll0=.6aab1fb2-f2a7-41bc-a2e7-17899723134a@github.com> > Backport of JDK-8339637 from 17u-dev. > > Clean backport. Passed tier1 tests. Passed gtests. Radek ??p has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2971/files - new: https://git.openjdk.org/jdk11u-dev/pull/2971/files/d3bd3405..35e33ed5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2971&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2971&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2971.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2971/head:pull/2971 PR: https://git.openjdk.org/jdk11u-dev/pull/2971 From martin.doerr at sap.com Wed Nov 27 15:17:47 2024 From: martin.doerr at sap.com (Doerr, Martin) Date: Wed, 27 Nov 2024 15:17:47 +0000 Subject: CFV: New JDK Updates Committer - Amit Kumar Message-ID: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> Hi, I hereby nominate Amit Kumar [1] for the role of JDK Updates Project Committer. Amit works for IBM, is a JDK Committer and has taken responsibility for the s390 port. He?s contributing to the jdk-updates projects focusing on s390 [5]. Votes are due by Thursday, 12 Dec 2024 at 09:00 UTC. Only current JDK-Updates Committers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Best regards, Martin [1] https://openjdk.org/census#amitkumar [2] https://github.com/openjdk/jdk/commits?author=offamitkumar [3] https://openjdk.org/census [4] https://openjdk.java.net/projects/#committer-vote [5] backports: jdk22u (2) : https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk23u (4 + 4 open): https://github.com/openjdk/jdk23u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u (3) : https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u-dev (10 + 2 open): https://github.com/openjdk/jdk21u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk17u-dev (6) : https://github.com/openjdk/jdk17u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk11u-dev (1) : https://github.com/openjdk/jdk11u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://mail.openjdk.org/pipermail/jdk-updates-dev/attachments/20241127/f1418c00/attachment.htm> From martin.doerr at sap.com Wed Nov 27 15:19:40 2024 From: martin.doerr at sap.com (Doerr, Martin) Date: Wed, 27 Nov 2024 15:19:40 +0000 Subject: CFV: New JDK Updates Committer - Amit Kumar In-Reply-To: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> References: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> Message-ID: <DU0PR02MB85488652BEC48F87C163D6699A282@DU0PR02MB8548.eurprd02.prod.outlook.com> Vote: yes Von: jdk-updates-dev <jdk-updates-dev-retn at openjdk.org> im Auftrag von Doerr, Martin <martin.doerr at sap.com> Datum: Mittwoch, 27. November 2024 um 16:18 An: jdk-updates-dev at openjdk.org <jdk-updates-dev at openjdk.org> Betreff: CFV: New JDK Updates Committer - Amit Kumar Hi, I hereby nominate Amit Kumar [1] for the role of JDK Updates Project Committer. Amit works for IBM, is a JDK Committer and has taken responsibility for the s390 port. He?s contributing to the jdk-updates projects focusing on s390 [5]. Votes are due by Thursday, 12 Dec 2024 at 09:00 UTC. Only current JDK-Updates Committers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Best regards, Martin [1] https://openjdk.org/census#amitkumar [2] https://github.com/openjdk/jdk/commits?author=offamitkumar [3] https://openjdk.org/census [4] https://openjdk.java.net/projects/#committer-vote [5] backports: jdk22u (2) : https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk23u (4 + 4 open): https://github.com/openjdk/jdk23u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u (3) : https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u-dev (10 + 2 open): https://github.com/openjdk/jdk21u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk17u-dev (6) : https://github.com/openjdk/jdk17u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk11u-dev (1) : https://github.com/openjdk/jdk11u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://mail.openjdk.org/pipermail/jdk-updates-dev/attachments/20241127/2e119d47/attachment-0001.htm> From matthias.baesken at sap.com Wed Nov 27 15:33:19 2024 From: matthias.baesken at sap.com (Baesken, Matthias) Date: Wed, 27 Nov 2024 15:33:19 +0000 Subject: CFV: New JDK Updates Committer - Amit Kumar (Doerr, Martin) In-Reply-To: <mailman.5365.1732720787.332.jdk-updates-dev@openjdk.org> References: <mailman.5365.1732720787.332.jdk-updates-dev@openjdk.org> Message-ID: <AM9PR02MB6770450C13109D11D41F644C93282@AM9PR02MB6770.eurprd02.prod.outlook.com> >I hereby nominate Amit Kumar [1] for the role of JDK Updates Project Committer. >Amit works for IBM, is a JDK Committer and has taken responsibility for the s390 port. He?s contributing to the jdk-updates projects focusing on s390 [5]. >Votes are due by Thursday, 12 Dec 2024 at 09:00 UTC. Vote: yes Best regards, Matthias From lutz.schmidt at sap.com Wed Nov 27 15:34:37 2024 From: lutz.schmidt at sap.com (Schmidt, Lutz) Date: Wed, 27 Nov 2024 15:34:37 +0000 Subject: CFV: New JDK Updates Committer - Amit Kumar In-Reply-To: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> References: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> Message-ID: <PAXPR02MB7264F452D1BE68EC140C12F982282@PAXPR02MB7264.eurprd02.prod.outlook.com> Vote: yes -Lutz From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.org> on behalf of Doerr, Martin <martin.doerr at sap.com> Date: Wednesday, 27. November 2024 at 16:18 To: jdk-updates-dev at openjdk.org <jdk-updates-dev at openjdk.org> Subject: CFV: New JDK Updates Committer - Amit Kumar Hi, I hereby nominate Amit Kumar [1] for the role of JDK Updates Project Committer. Amit works for IBM, is a JDK Committer and has taken responsibility for the s390 port. He?s contributing to the jdk-updates projects focusing on s390 [5]. Votes are due by Thursday, 12 Dec 2024 at 09:00 UTC. Only current JDK-Updates Committers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Best regards, Martin [1] https://openjdk.org/census#amitkumar [2] https://github.com/openjdk/jdk/commits?author=offamitkumar [3] https://openjdk.org/census [4] https://openjdk.java.net/projects/#committer-vote [5] backports: jdk22u (2) : https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk23u (4 + 4 open): https://github.com/openjdk/jdk23u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u (3) : https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u-dev (10 + 2 open): https://github.com/openjdk/jdk21u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk17u-dev (6) : https://github.com/openjdk/jdk17u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk11u-dev (1) : https://github.com/openjdk/jdk11u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://mail.openjdk.org/pipermail/jdk-updates-dev/attachments/20241127/e354b576/attachment-0001.htm> From andrew at openjdk.org Wed Nov 27 15:53:50 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Nov 2024 15:53:50 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v4] In-Reply-To: <Q7DgV4oGXgByQqUEQepmUbX_KjFPrTYTvSWEy5idgrs=.7df7c438-b905-4e18-9f22-c3a699868747@github.com> References: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> <Q7DgV4oGXgByQqUEQepmUbX_KjFPrTYTvSWEy5idgrs=.7df7c438-b905-4e18-9f22-c3a699868747@github.com> Message-ID: <AIcKwxNt8vmzmQmf4Jnbq8CnDUs0t6kL6JufxySDi64=.930c3b7d-2d32-4b01-ba02-2e041541e236@github.com> On Mon, 25 Nov 2024 21:54:10 GMT, Antonio Vieiro <duke at openjdk.org> wrote: >> An implementation of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) that bumps the GHA runners versions to `macos-13` and `XCode 14.3.1`. >> >> This uses the `--enable-xcode14` configuration flag introduced in https://github.com/openjdk/jdk11u-dev/pull/2966 ([JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458)) to build and run tier-1 tests on `macos-13` and `XCode 14.3.1`. >> >> Tier-1 tests seem to be failing randomly on macos-13/XCode14 with either a timeout or an ArrayIndexOutOfBoundsException t in serviceability/sa/ClhsdbFindPC.java. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). >> >> The rest of `tier1` tests are expected to pass on this platform. > > Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: > > Use --disable-warnings-as-errors for building on XCode 14 and up Can we update this PR so it targets `master` rather than `2966`? Then we can integrate this and look into turning the warnings-as-errors back on long term. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2967#issuecomment-2504221672 From duke at openjdk.org Wed Nov 27 16:01:09 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 27 Nov 2024 16:01:09 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v5] In-Reply-To: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> References: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> Message-ID: <st50-OlLA_YgdxVvnoGgbii7vNFqndLBgPEqTW5E8t4=.482a308e-f1c6-4b11-94db-da475fcea1de@github.com> > An implementation of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) that bumps the GHA runners versions to `macos-13` and `XCode 14.3.1`. > > This uses the `--enable-xcode14` configuration flag introduced in https://github.com/openjdk/jdk11u-dev/pull/2966 ([JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458)) to build and run tier-1 tests on `macos-13` and `XCode 14.3.1`. > > Tier-1 tests seem to be failing randomly on macos-13/XCode14 with either a timeout or an ArrayIndexOutOfBoundsException t in serviceability/sa/ClhsdbFindPC.java. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). > > The rest of `tier1` tests are expected to pass on this platform. Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Use --disable-warnings-as-errors for building on XCode 14 and up - 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/2967/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2967&range=04 Stats: 6 lines in 3 files changed: 1 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2967.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2967/head:pull/2967 PR: https://git.openjdk.org/jdk11u-dev/pull/2967 From duke at openjdk.org Wed Nov 27 16:01:10 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 27 Nov 2024 16:01:10 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v4] In-Reply-To: <Q7DgV4oGXgByQqUEQepmUbX_KjFPrTYTvSWEy5idgrs=.7df7c438-b905-4e18-9f22-c3a699868747@github.com> References: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> <Q7DgV4oGXgByQqUEQepmUbX_KjFPrTYTvSWEy5idgrs=.7df7c438-b905-4e18-9f22-c3a699868747@github.com> Message-ID: <i2JA5s9D_djz42A4dJ2mbqFRvi-2qcuQK5i0aXTdOu0=.fb8d43dd-1785-4fcb-9e82-b47e602408f1@github.com> On Mon, 25 Nov 2024 21:54:10 GMT, Antonio Vieiro <duke at openjdk.org> wrote: >> An implementation of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) that bumps the GHA runners versions to `macos-13` and `XCode 14.3.1`. >> >> This uses the `--enable-xcode14` configuration flag introduced in https://github.com/openjdk/jdk11u-dev/pull/2966 ([JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458)) to build and run tier-1 tests on `macos-13` and `XCode 14.3.1`. >> >> Tier-1 tests seem to be failing randomly on macos-13/XCode14 with either a timeout or an ArrayIndexOutOfBoundsException t in serviceability/sa/ClhsdbFindPC.java. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). >> >> The rest of `tier1` tests are expected to pass on this platform. > > Antonio Vieiro has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. Rebased on `master`. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2967#issuecomment-2504237956 From andrew at openjdk.org Wed Nov 27 16:08:41 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Nov 2024 16:08:41 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v5] In-Reply-To: <st50-OlLA_YgdxVvnoGgbii7vNFqndLBgPEqTW5E8t4=.482a308e-f1c6-4b11-94db-da475fcea1de@github.com> References: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> <st50-OlLA_YgdxVvnoGgbii7vNFqndLBgPEqTW5E8t4=.482a308e-f1c6-4b11-94db-da475fcea1de@github.com> Message-ID: <V-r8sJHwTiMessGV8hdQrB6-u5iIZ0gFbSvnYhyMako=.35d12111-06c7-429c-9fcd-cd34fe5f83d1@github.com> On Wed, 27 Nov 2024 16:01:09 GMT, Antonio Vieiro <duke at openjdk.org> wrote: >> An implementation of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) that bumps the GHA runners versions to `macos-13` and `XCode 14.3.1`. >> >> This uses the `--enable-xcode14` configuration flag introduced in https://github.com/openjdk/jdk11u-dev/pull/2966 ([JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458)) to build and run tier-1 tests on `macos-13` and `XCode 14.3.1`. >> >> Tier-1 tests seem to be failing randomly on macos-13/XCode14 with either a timeout or an ArrayIndexOutOfBoundsException t in serviceability/sa/ClhsdbFindPC.java. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). >> >> The rest of `tier1` tests are expected to pass on this platform. > > Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Use --disable-warnings-as-errors for building on XCode 14 and up > - 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 Thanks. Assuming this builds as before, we can integrate. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2967#issuecomment-2504255210 From andrew at openjdk.org Wed Nov 27 16:19:49 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Nov 2024 16:19:49 GMT Subject: [jdk21u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> References: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> Message-ID: <NxJn6uVBDTO0B5wSf9VAzac3VD2ln2JSBvowNEkHPUk=.f0f1e824-7734-46b4-9d59-3bc727a894cf@github.com> On Mon, 25 Nov 2024 07:15:55 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested tier1 tests and processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) Shouldn't this have gone to 23 first? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1180#issuecomment-2504280428 From duke at openjdk.org Wed Nov 27 16:22:56 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 27 Nov 2024 16:22:56 GMT Subject: [jdk21u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> References: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> Message-ID: <qSBUBL3LTwSL1TofNcvMo0rOOEbg3hmVKfq5YXm4DDw=.ac13368d-9a56-4872-8e72-c29104fee8f8@github.com> On Mon, 25 Nov 2024 07:15:55 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested tier1 tests and processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) Should it? Let's backport it to 23 then. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1180#issuecomment-2504286046 From duke at openjdk.org Wed Nov 27 16:38:40 2024 From: duke at openjdk.org (duke) Date: Wed, 27 Nov 2024 16:38:40 GMT Subject: [jdk11u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b [v2] In-Reply-To: <1pD3Ld9XSzVlo9xgUWy1YKRSfhQ0AIVh2beqm7OYll0=.6aab1fb2-f2a7-41bc-a2e7-17899723134a@github.com> References: <wGlr2PR50Y7HO-NaFJV09fl4fFJMjNLe1DDefe2_NTo=.4b787ff7-9b06-40e7-a3b3-42366bbb1afb@github.com> <1pD3Ld9XSzVlo9xgUWy1YKRSfhQ0AIVh2beqm7OYll0=.6aab1fb2-f2a7-41bc-a2e7-17899723134a@github.com> Message-ID: <36lmzLMlmt7OtkN3Cf20b9rQgu4eh7CEF4bXhvtv09Y=.0f368da6-7401-4c0f-bf8c-2342d6efba1e@github.com> On Wed, 27 Nov 2024 15:06:00 GMT, Radek ??p <duke at openjdk.org> wrote: >> Backport of JDK-8339637 from 17u-dev. >> >> Clean backport. Passed tier1 tests. Passed gtests. > > Radek ??p has updated the pull request incrementally with one additional commit since the last revision: > > Update full name @RadekCap Your change (at version 35e33ed550838dffe903c3e534d684abc96aebff) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2971#issuecomment-2504321420 From sgehwolf at openjdk.org Wed Nov 27 16:43:45 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 27 Nov 2024 16:43:45 GMT Subject: [jdk21u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <NxJn6uVBDTO0B5wSf9VAzac3VD2ln2JSBvowNEkHPUk=.f0f1e824-7734-46b4-9d59-3bc727a894cf@github.com> References: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> <NxJn6uVBDTO0B5wSf9VAzac3VD2ln2JSBvowNEkHPUk=.f0f1e824-7734-46b4-9d59-3bc727a894cf@github.com> Message-ID: <i-kPMpRwAPV42U3dZIcBkZpUr_hfMtSxXPIGwfhVg3o=.d026551e-8250-496e-ab15-00c06155dac8@github.com> On Wed, 27 Nov 2024 16:16:59 GMT, Andrew John Hughes <andrew at openjdk.org> wrote: > Shouldn't this have gone to 23 first? I think the deadline for 23.0.2 update has closed? https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-October/038559.html ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1180#issuecomment-2504327067 From duke at openjdk.org Wed Nov 27 16:49:43 2024 From: duke at openjdk.org (duke) Date: Wed, 27 Nov 2024 16:49:43 GMT Subject: [jdk23u] RFR: 8342409: [s390x] C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR In-Reply-To: <PoTxD38Z0m8xtq-2LIzvzYNIrI8AYqwO0yRHtarxG0k=.a5d57f95-7bde-416f-a247-9056bb3ae0c8@github.com> References: <PoTxD38Z0m8xtq-2LIzvzYNIrI8AYqwO0yRHtarxG0k=.a5d57f95-7bde-416f-a247-9056bb3ae0c8@github.com> Message-ID: <OxoAMFhmI70tF-9M3fVpYOSUyfPWkRvu6pB23_vQ8j4=.d81f5ee7-c3b2-434a-aa6c-6efa9a340ec7@github.com> On Wed, 27 Nov 2024 08:16:48 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [9201e9fc](https://github.com/openjdk/jdk/commit/9201e9fcc28cff37cf9996e8db38f9aee7511b1c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 18 Oct 2024 and was reviewed by Richard Reingruber and Lutz Schmidt. > > Thanks! @offamitkumar Your change (at version 9f6002735dde2ae08c4dad3a861ccf61b91d7ced) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/229#issuecomment-2504342349 From sgehwolf at openjdk.org Wed Nov 27 19:47:38 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 27 Nov 2024 19:47:38 GMT Subject: [jdk21u-dev] RFR: 8344993: [21u] [REDO] Backport JDK-8327501 and JDK-8328366 to JDK 21 In-Reply-To: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> References: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> Message-ID: <s9HIPDJP5-aJ9QjffOViuefAg0nYexJsZcTkaIMYPhg=.f666d62a-e6fd-4370-be64-92876b02c2c7@github.com> On Mon, 25 Nov 2024 22:17:04 GMT, Martin Balao <mbalao at openjdk.org> wrote: > Hi, > > In this PR I back out 8341989 for 8327501 and 8328366 to be re-introduced to JDK 21u. I plan to propose a backport of 8342905 thereafter. Reversion of 8341989 was clean. > > Thanks, > Martin.- @martinuy Please submit a dependent PR for 8328366 so that we can approve them both. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1181#issuecomment-2504661884 From duke at openjdk.org Wed Nov 27 22:25:54 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Wed, 27 Nov 2024 22:25:54 GMT Subject: [jdk11u-dev] Integrated: 8339637: (tz) Update Timezone Data to 2024b In-Reply-To: <wGlr2PR50Y7HO-NaFJV09fl4fFJMjNLe1DDefe2_NTo=.4b787ff7-9b06-40e7-a3b3-42366bbb1afb@github.com> References: <wGlr2PR50Y7HO-NaFJV09fl4fFJMjNLe1DDefe2_NTo=.4b787ff7-9b06-40e7-a3b3-42366bbb1afb@github.com> Message-ID: <amzIdZnbQZC3uXzUOigpA6bHiEQGEPfIG_uvsejzxbg=.309be88a-4eea-4a89-9a7d-c6cd9cc38dc1@github.com> On Tue, 26 Nov 2024 15:45:32 GMT, Radek ??p <duke at openjdk.org> wrote: > Backport of JDK-8339637 from 17u-dev. > > Clean backport. Passed tier1 tests. Passed gtests. This pull request has now been integrated. Changeset: 874b25e6 Author: RadekCap <rcap at redhat.com> Committer: Andrew John Hughes <andrew at openjdk.org> URL: https://git.openjdk.org/jdk11u-dev/commit/874b25e64174ba64efec9b61229f3f610133270a Stats: 1316 lines in 16 files changed: 400 ins; 60 del; 856 mod 8339637: (tz) Update Timezone Data to 2024b Reviewed-by: andrew Backport-of: fbc040cf8a17fc8de15b8771765441b86a8169ae ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2971 From andrew at openjdk.org Thu Nov 28 00:34:43 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 28 Nov 2024 00:34:43 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v5] In-Reply-To: <st50-OlLA_YgdxVvnoGgbii7vNFqndLBgPEqTW5E8t4=.482a308e-f1c6-4b11-94db-da475fcea1de@github.com> References: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> <st50-OlLA_YgdxVvnoGgbii7vNFqndLBgPEqTW5E8t4=.482a308e-f1c6-4b11-94db-da475fcea1de@github.com> Message-ID: <FVZMIREA5VncnXPIYaMZkGnQKlSWbu11AwqfpVm-lcI=.68f0a563-1689-47af-9b0c-0d750c7afa03@github.com> On Wed, 27 Nov 2024 16:01:09 GMT, Antonio Vieiro <duke at openjdk.org> wrote: >> An implementation of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) that bumps the GHA runners versions to `macos-13` and `XCode 14.3.1`. >> >> This uses the `--enable-xcode14` configuration flag introduced in https://github.com/openjdk/jdk11u-dev/pull/2966 ([JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458)) to build and run tier-1 tests on `macos-13` and `XCode 14.3.1`. >> >> Tier-1 tests seem to be failing randomly on macos-13/XCode14 with either a timeout or an ArrayIndexOutOfBoundsException t in serviceability/sa/ClhsdbFindPC.java. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). >> >> The rest of `tier1` tests are expected to pass on this platform. > > Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Use --disable-warnings-as-errors for building on XCode 14 and up > - 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 This looks ok to go in, but I don't know if you want to hold off for now to allow testing of #2966 with MacOS 12. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2967#pullrequestreview-2466124417 From andrew at openjdk.org Thu Nov 28 00:53:42 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 28 Nov 2024 00:53:42 GMT Subject: [jdk17u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <TgaabuJ4kLIMG1jKbU2qfiJLjmgHhdQKkYr3O640A5U=.7686ead0-df43-423f-bda4-bd102843591e@github.com> References: <TgaabuJ4kLIMG1jKbU2qfiJLjmgHhdQKkYr3O640A5U=.7686ead0-df43-423f-bda4-bd102843591e@github.com> Message-ID: <r22rPlaUFDdQgAoEp_uxHtzBBQva0uMkRjBsNYnTJmQ=.a365f520-a11a-4c8e-9a56-b7ab86aadf26@github.com> On Tue, 26 Nov 2024 11:23:22 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested with tier1 tests and also processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) Confirmed clean. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3076#pullrequestreview-2466137295 From richard.reingruber at sap.com Thu Nov 28 08:25:03 2024 From: richard.reingruber at sap.com (Reingruber, Richard) Date: Thu, 28 Nov 2024 08:25:03 +0000 Subject: CFV: New JDK Updates Committer - Amit Kumar In-Reply-To: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> References: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> Message-ID: <VI1PR0202MB3504CE9B107201A1B4DDC1C89B292@VI1PR0202MB3504.eurprd02.prod.outlook.com> Vote: yes Richard. From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.org> on behalf of Doerr, Martin <martin.doerr at sap.com> Date: Wednesday, 27. November 2024 at 16:18 To: jdk-updates-dev at openjdk.org <jdk-updates-dev at openjdk.org> Subject: CFV: New JDK Updates Committer - Amit Kumar Hi, I hereby nominate Amit Kumar [1] for the role of JDK Updates Project Committer. Amit works for IBM, is a JDK Committer and has taken responsibility for the s390 port. He?s contributing to the jdk-updates projects focusing on s390 [5]. Votes are due by Thursday, 12 Dec 2024 at 09:00 UTC. Only current JDK-Updates Committers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Best regards, Martin [1] https://openjdk.org/census#amitkumar [2] https://github.com/openjdk/jdk/commits?author=offamitkumar [3] https://openjdk.org/census [4] https://openjdk.java.net/projects/#committer-vote [5] backports: jdk22u (2) : https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk23u (4 + 4 open): https://github.com/openjdk/jdk23u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u (3) : https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u-dev (10 + 2 open): https://github.com/openjdk/jdk21u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk17u-dev (6) : https://github.com/openjdk/jdk17u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk11u-dev (1) : https://github.com/openjdk/jdk11u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://mail.openjdk.org/pipermail/jdk-updates-dev/attachments/20241128/c8daab33/attachment.htm> From volker.simonis at gmail.com Thu Nov 28 08:30:58 2024 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 28 Nov 2024 09:30:58 +0100 Subject: CFV: New JDK Updates Committer - Amit Kumar In-Reply-To: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> References: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> Message-ID: <CA+3eh126RN=Rzk7t8LiftnR_=gY2-q5OPxvDCA=cFv=hFL5yZQ@mail.gmail.com> Vote: yes Doerr, Martin <martin.doerr at sap.com> schrieb am Mi., 27. Nov. 2024, 16:18: > Hi, > > > > I hereby nominate Amit Kumar [1] for the role of JDK Updates Project > Committer. > > Amit works for IBM, is a JDK Committer and has taken responsibility for > the s390 port. He?s contributing to the jdk-updates projects focusing on > s390 [5]. > > Votes are due by Thursday, 12 Dec 2024 at 09:00 UTC. > > > > Only current JDK-Updates Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing list. > > > > For Lazy Consensus voting instructions, see [4]. > > > > Best regards, > > Martin > > > > [1] https://openjdk.org/census#amitkumar > > [2] https://github.com/openjdk/jdk/commits?author=offamitkumar > > [3] https://openjdk.org/census > > [4] https://openjdk.java.net/projects/#committer-vote > > [5] backports: > > jdk22u (2) : > https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > > jdk23u (4 + 4 open): > https://github.com/openjdk/jdk23u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > > jdk21u (3) : > https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > > jdk21u-dev (10 + 2 open): > https://github.com/openjdk/jdk21u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > > jdk17u-dev (6) : > https://github.com/openjdk/jdk17u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > > jdk11u-dev (1) : > https://github.com/openjdk/jdk11u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://mail.openjdk.org/pipermail/jdk-updates-dev/attachments/20241128/3b452dd3/attachment-0001.htm> From mbaesken at openjdk.org Thu Nov 28 08:44:22 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 28 Nov 2024 08:44:22 GMT Subject: [jdk21u-dev] RFR: 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed Message-ID: <eujZYbQGx6doSoU7HMi7qW-ugMXSPIQ7VrEDKqUQYpc=.a2ece88c-0e83-4141-a8eb-a983c69368ff@github.com> 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed ------------- Commit messages: - Backport 2564f0f99866c33d14947609c276a421ce8cc0a2 Changes: https://git.openjdk.org/jdk21u-dev/pull/1187/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1187&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325906 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1187.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1187/head:pull/1187 PR: https://git.openjdk.org/jdk21u-dev/pull/1187 From duke at openjdk.org Thu Nov 28 08:49:48 2024 From: duke at openjdk.org (duke) Date: Thu, 28 Nov 2024 08:49:48 GMT Subject: [jdk17u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <TgaabuJ4kLIMG1jKbU2qfiJLjmgHhdQKkYr3O640A5U=.7686ead0-df43-423f-bda4-bd102843591e@github.com> References: <TgaabuJ4kLIMG1jKbU2qfiJLjmgHhdQKkYr3O640A5U=.7686ead0-df43-423f-bda4-bd102843591e@github.com> Message-ID: <-Q0AtwBUmjtmcqZiYjDcncYTnCKulsGUwmQhRQv7i60=.a2afd770-6fe7-47b6-9920-a274435b4cc2@github.com> On Tue, 26 Nov 2024 11:23:22 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested with tier1 tests and also processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) @vieiro Your change (at version 8e4d14dadab9539b754aa07b3c1afa9ea43cdd63) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3076#issuecomment-2505560368 From fyang at openjdk.org Thu Nov 28 09:08:45 2024 From: fyang at openjdk.org (Fei Yang) Date: Thu, 28 Nov 2024 09:08:45 GMT Subject: [jdk23u] RFR: 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing In-Reply-To: <2ae2lcw7nezGeg4_ShP6mPMK64J08kVWADgZ2jZ6ECY=.921f1b00-16a3-47fd-ac38-ef23e90dca39@github.com> References: <2ae2lcw7nezGeg4_ShP6mPMK64J08kVWADgZ2jZ6ECY=.921f1b00-16a3-47fd-ac38-ef23e90dca39@github.com> Message-ID: <8kb7UwHT0WL0E2CWkmNge0fCLdZ_WWbP3ZrOUdtBqRc=.75d759f0-9ca5-40d0-b6ff-627866d951cf@github.com> On Thu, 31 Oct 2024 03:10:39 GMT, Fei Yang <fyang at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [239d84a8](https://github.com/openjdk/jdk/commit/239d84a82a1e6f4ebbd5c5abb320e39cfd5bc330) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fei Yang on 21 Oct 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson. > > Thanks! bot, please keep it open. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/212#issuecomment-2505599713 From duke at openjdk.org Thu Nov 28 09:14:50 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 28 Nov 2024 09:14:50 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v5] In-Reply-To: <FVZMIREA5VncnXPIYaMZkGnQKlSWbu11AwqfpVm-lcI=.68f0a563-1689-47af-9b0c-0d750c7afa03@github.com> References: <q1aCqsvnFbBFKkchb-FREeLQL8xg6Pt3gxaj448x8FM=.6f40d40f-a5d8-4a5c-aa4a-fc6f8893dc33@github.com> <st50-OlLA_YgdxVvnoGgbii7vNFqndLBgPEqTW5E8t4=.482a308e-f1c6-4b11-94db-da475fcea1de@github.com> <FVZMIREA5VncnXPIYaMZkGnQKlSWbu11AwqfpVm-lcI=.68f0a563-1689-47af-9b0c-0d750c7afa03@github.com> Message-ID: <XRnjiHjudmFzLSP3XcqcNxLFkgIFw36453CWjbQDLWU=.ddefa12c-ef2f-488b-a757-314d5c6a50e1@github.com> On Thu, 28 Nov 2024 00:32:29 GMT, Andrew John Hughes <andrew at openjdk.org> wrote: > This looks ok to go in, but I don't know if you want to hold off for now to allow testing of #2966 with MacOS 12. I think this change with `--disable-warnings-as-errors` supersedes #2966 , so let's close #2966 and let's get this in. Next efforts should go to fix the Clhsdb test failure (adding log for the record). [clhsdb-failure.txt](https://github.com/user-attachments/files/17945641/clhsdb-failure.txt) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2967#issuecomment-2505612470 From duke at openjdk.org Thu Nov 28 09:20:53 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 28 Nov 2024 09:20:53 GMT Subject: [jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v4] In-Reply-To: <AIBq8t4TyKj7LQgPZZXQ9Qy0YV_B3EidBEbeTdkcvJU=.adf0d542-9f55-42f3-9b9f-1809ca1bc53d@github.com> References: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> <AIBq8t4TyKj7LQgPZZXQ9Qy0YV_B3EidBEbeTdkcvJU=.adf0d542-9f55-42f3-9b9f-1809ca1bc53d@github.com> Message-ID: <MoJtGGq6DFYk08O6jiSSGwVXLkOPFZu1uxC3R93iYoY=.15f8eb46-8fe3-4bc6-9ede-a2c009bc2196@github.com> On Mon, 25 Nov 2024 21:40:53 GMT, Antonio Vieiro <duke at openjdk.org> wrote: >> An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions. >> >> The PR is separated in three commits for easier review: >> >> - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables: >> - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used) >> - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used). >> - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14). >> - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`). >> >> Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`. > > Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: > > Augment --disable-warnings-as-errors for clang >= 14.x.y Closed in favor of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) in #2967 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2966#issuecomment-2505623467 From duke at openjdk.org Thu Nov 28 09:20:54 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 28 Nov 2024 09:20:54 GMT Subject: [jdk11u-dev] Withdrawn: 8344458: [11u] Add initial support for building with XCode 14 In-Reply-To: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> References: <HSqOwUqj51meKyqhonPx7JWVD0Lk6VCZAw8YL7mKCgo=.af93884b-5421-4a94-8c3d-1a730a3e55ba@github.com> Message-ID: <_ZmkBo7b2Y-c37Z_WNeNqJbe1_S-MU9QSze0pr_vhR4=.bff3e502-b5ad-48d4-992b-4172e3e2bb1d@github.com> On Mon, 18 Nov 2024 22:12:39 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions. > > The PR is separated in three commits for easier review: > > - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables: > - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used) > - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used). > - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14). > - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`). > > Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2966 From goetz at openjdk.org Thu Nov 28 09:28:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Nov 2024 09:28:44 GMT Subject: [jdk21u-dev] RFR: 8341194: [REDO] Implement C2 VectorizedHashCode on AArch64 In-Reply-To: <D49WFHgrecB8cjqvr6q3_5WOE_GXgBobwH-mqXRrJGk=.9938536c-92df-4690-9717-4707afd8e36a@github.com> References: <D49WFHgrecB8cjqvr6q3_5WOE_GXgBobwH-mqXRrJGk=.9938536c-92df-4690-9717-4707afd8e36a@github.com> Message-ID: <_FoRkBY7d62YlXSAYJ_x5mbqpeQ2szCr4DaLfNelI2A=.a2b453fd-951f-464b-9f18-3d233c518d66@github.com> On Wed, 20 Nov 2024 19:40:14 GMT, Chad Rakoczy <duke at openjdk.org> wrote: > Backport [JDK-8341194](https://bugs.openjdk.org/browse/JDK-8341194) [REDO] Implement C2 VectorizedHashCode on AArch64 > > Backport is clean. Trivial merge conflicts with includes and already present code. Original implementation [JDK-8322770](https://bugs.openjdk.org/browse/JDK-8322770) caused build and test failures. Build failures that were reproducible with `make bootcycle-images` run on `linux-aarch64 fastdebug/release` successfully. All jtreg and new asmtest pass on `linux-aarch64 release`. Hi, I would like to defer this to the April release. It is an enhancement and rather new. That way it will have at lease some coverage by 24, ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1170#issuecomment-2505639776 From duke at openjdk.org Thu Nov 28 09:34:38 2024 From: duke at openjdk.org (duke) Date: Thu, 28 Nov 2024 09:34:38 GMT Subject: [jdk21u-dev] RFR: 8342409: [s390x] C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR In-Reply-To: <CaPtLN03DsjJx2HSui-Yi_i9f6sBrtkpoAp_OsyqU6M=.ac6ef6e5-df83-44e6-a438-74f3e3667575@github.com> References: <CaPtLN03DsjJx2HSui-Yi_i9f6sBrtkpoAp_OsyqU6M=.ac6ef6e5-df83-44e6-a438-74f3e3667575@github.com> Message-ID: <Y6hck0Mqgxt2pQoWylxu0Rcm0d3XKOY0SeJNlmilgV0=.99c8d19e-0b74-4eda-b4f7-eba46e3b94c7@github.com> On Wed, 27 Nov 2024 08:28:05 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [9201e9fc](https://github.com/openjdk/jdk/commit/9201e9fcc28cff37cf9996e8db38f9aee7511b1c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 18 Oct 2024 and was reviewed by Richard Reingruber and Lutz Schmidt. > > Thanks! @offamitkumar Your change (at version d2a331d364e0b2e567a290cb12c047e089d143b5) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1184#issuecomment-2505652988 From duke at openjdk.org Thu Nov 28 09:36:41 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 28 Nov 2024 09:36:41 GMT Subject: [jdk17u-dev] Integrated: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <TgaabuJ4kLIMG1jKbU2qfiJLjmgHhdQKkYr3O640A5U=.7686ead0-df43-423f-bda4-bd102843591e@github.com> References: <TgaabuJ4kLIMG1jKbU2qfiJLjmgHhdQKkYr3O640A5U=.7686ead0-df43-423f-bda4-bd102843591e@github.com> Message-ID: <CLxdSB1xCVjhwKuzLze4HUNBUsBa1ikDdzfKG21L9rM=.9fa6c275-3f8d-4eff-b217-78ecfe29c87d@github.com> On Tue, 26 Nov 2024 11:23:22 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested with tier1 tests and also processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) This pull request has now been integrated. Changeset: d70ea492 Author: Antonio Vieiro <avieirov at redhat.com> Committer: Severin Gehwolf <sgehwolf at openjdk.org> URL: https://git.openjdk.org/jdk17u-dev/commit/d70ea492436514ac79fd723578e5e5bae5c18866 Stats: 12 lines in 1 file changed: 8 ins; 0 del; 4 mod 8340552: Harden TzdbZoneRulesCompiler against missing zone names Reviewed-by: andrew Backport-of: bc4abb4379ced7ddfb3d173d2dfc669a4b11d12f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3076 From mbaesken at openjdk.org Thu Nov 28 09:54:02 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 28 Nov 2024 09:54:02 GMT Subject: [jdk21u-dev] RFR: 8341820: Check return value of hcreate_r Message-ID: <4w7ckR2uzxvbKsDsosQOKQK5n8FhsJkd-MJcEm-jzOA=.ff4970e1-0d64-4d01-ae86-22ad8bff2b50@github.com> 8341820: Check return value of hcreate_r ------------- Commit messages: - Backport 7c0dbf8e9c69d51aa8e06305e4483002116019f4 Changes: https://git.openjdk.org/jdk21u-dev/pull/1188/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1188&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341820 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1188.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1188/head:pull/1188 PR: https://git.openjdk.org/jdk21u-dev/pull/1188 From christoph.langer at sap.com Thu Nov 28 09:55:28 2024 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 28 Nov 2024 09:55:28 +0000 Subject: CFV: New JDK Updates Committer - Amit Kumar In-Reply-To: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> References: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> Message-ID: <DU0PR02MB98007CB8EB9B7A6256C009608A292@DU0PR02MB9800.eurprd02.prod.outlook.com> Vote: yes /Christoph From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.org> On Behalf Of Doerr, Martin Sent: Mittwoch, 27. November 2024 16:18 To: jdk-updates-dev at openjdk.org Subject: CFV: New JDK Updates Committer - Amit Kumar Hi, I hereby nominate Amit Kumar [1] for the role of JDK Updates Project Committer. Amit works for IBM, is a JDK Committer and has taken responsibility for the s390 port. He?s contributing to the jdk-updates projects focusing on s390 [5]. Votes are due by Thursday, 12 Dec 2024 at 09:00 UTC. Only current JDK-Updates Committers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Best regards, Martin [1] https://openjdk.org/census#amitkumar [2] https://github.com/openjdk/jdk/commits?author=offamitkumar [3] https://openjdk.org/census [4] https://openjdk.java.net/projects/#committer-vote [5] backports: jdk22u (2) : https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk23u (4 + 4 open): https://github.com/openjdk/jdk23u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u (3) : https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u-dev (10 + 2 open): https://github.com/openjdk/jdk21u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk17u-dev (6) : https://github.com/openjdk/jdk17u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk11u-dev (1) : https://github.com/openjdk/jdk11u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://mail.openjdk.org/pipermail/jdk-updates-dev/attachments/20241128/d61949d8/attachment-0001.htm> From goetz.lindenmaier at sap.com Thu Nov 28 09:59:23 2024 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 28 Nov 2024 09:59:23 +0000 Subject: CFV: New JDK Updates Committer - Amit Kumar In-Reply-To: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> References: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> Message-ID: <PAXPR02MB82453C0E42D20775C66944CCEC292@PAXPR02MB8245.eurprd02.prod.outlook.com> Vote: yes Best regards, Goetz. From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.org> On Behalf Of Doerr, Martin Sent: Wednesday, November 27, 2024 4:18 PM To: jdk-updates-dev at openjdk.org Subject: CFV: New JDK Updates Committer - Amit Kumar Hi, I hereby nominate Amit Kumar [1] for the role of JDK Updates Project Committer. Amit works for IBM, is a JDK Committer and has taken responsibility for the s390 port. He's contributing to the jdk-updates projects focusing on s390 [5]. Votes are due by Thursday, 12 Dec 2024 at 09:00 UTC. Only current JDK-Updates Committers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Best regards, Martin [1] https://openjdk.org/census#amitkumar [2] https://github.com/openjdk/jdk/commits?author=offamitkumar [3] https://openjdk.org/census [4] https://openjdk.java.net/projects/#committer-vote [5] backports: jdk22u (2) : https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk23u (4 + 4 open): https://github.com/openjdk/jdk23u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u (3) : https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u-dev (10 + 2 open): https://github.com/openjdk/jdk21u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk17u-dev (6) : https://github.com/openjdk/jdk17u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk11u-dev (1) : https://github.com/openjdk/jdk11u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://mail.openjdk.org/pipermail/jdk-updates-dev/attachments/20241128/a76fac85/attachment.htm> From sgehwolf at redhat.com Thu Nov 28 10:30:04 2024 From: sgehwolf at redhat.com (sgehwolf at redhat.com) Date: Thu, 28 Nov 2024 11:30:04 +0100 Subject: CFV: New JDK Updates Committer - Amit Kumar In-Reply-To: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> References: <DU0PR02MB8548676CCD04D0844AC87B659A282@DU0PR02MB8548.eurprd02.prod.outlook.com> Message-ID: <393cf96385a3b940f3f50b443fb0c757c6703787.camel@redhat.com> Vote: yes On Wed, 2024-11-27 at 15:17 +0000, Doerr, Martin wrote: > I hereby nominate Amit Kumar [1] for the role of JDK Updates Project > Committer. From duke at openjdk.org Thu Nov 28 10:31:54 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 28 Nov 2024 10:31:54 GMT Subject: [jdk11u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names Message-ID: <pJ2sPmIRbLeEnPeNrXqYyrj8ojScLFLisSMNU_UgDpw=.45309c23-420c-470f-b255-2bf22afdd094@github.com> Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). Tested with tier1 tests and also processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) ------------- Commit messages: - Backport d70ea492436514ac79fd723578e5e5bae5c18866 Changes: https://git.openjdk.org/jdk11u-dev/pull/2972/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2972&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340552 Stats: 12 lines in 1 file changed: 8 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2972.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2972/head:pull/2972 PR: https://git.openjdk.org/jdk11u-dev/pull/2972 From mbaesken at openjdk.org Thu Nov 28 10:50:38 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 28 Nov 2024 10:50:38 GMT Subject: [jdk21u-dev] RFR: 8345055: [21u] ProblemList failing rtm tests on ppc platforms [v2] In-Reply-To: <CKib1ryEclSLWHA5hKbdqlJUqWhh5EIkpElcGUu9caE=.7b69fd3e-7c24-42e7-9858-fd6649fcef17@github.com> References: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> <CKib1ryEclSLWHA5hKbdqlJUqWhh5EIkpElcGUu9caE=.7b69fd3e-7c24-42e7-9858-fd6649fcef17@github.com> Message-ID: <rsf0QENzY1fpR5DXNJ5S1b50pZ8LwmtzX1nD_YX1XZI=.c0af9594-92b7-4ce3-87b7-a060e8e7ad61@github.com> On Wed, 27 Nov 2024 09:05:28 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: >> Exclude some rtm related test which we see currently failing on some ppc64 platforms. > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > exclude TestPrintPreciseRTMLockingStatistics too on ppc64 and ppc64le Looks like compiler/rtm/cli/TestUseRTMDeoptOptionOnSupportedConfig.java is failing too (at least on AIX). This was not in the list of the already excluded tests where just the platform info had to be adjusted. Should I add this one too in this PR , or handle it elsewhere ? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1183#issuecomment-2505816620 From duke at openjdk.org Thu Nov 28 11:33:44 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 28 Nov 2024 11:33:44 GMT Subject: [jdk11u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <pJ2sPmIRbLeEnPeNrXqYyrj8ojScLFLisSMNU_UgDpw=.45309c23-420c-470f-b255-2bf22afdd094@github.com> References: <pJ2sPmIRbLeEnPeNrXqYyrj8ojScLFLisSMNU_UgDpw=.45309c23-420c-470f-b255-2bf22afdd094@github.com> Message-ID: <YxYZutXVIFaSOSvrb8CGsSWCJVOKnm4ZNJvDALekyzs=.ac56781f-39eb-4bd8-b2b4-405dabec251f@github.com> On Thu, 28 Nov 2024 10:27:45 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested with tier1 tests and also processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) Build failure due to [archive.apache.org ban policies](https://infra.apache.org/infra-ban.html) Run # Build JTReg and move files to the proper locations [build.sh][INFO] CYGWIN_OR_MSYS=0 [build.sh][INFO] JAVA_HOME: /usr/lib/jvm/temurin-17-jdk-amd64 [build.sh][INFO] Downloading https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.8-bin.zip to /home/runner/work/jdk11u-dev/jdk11u-dev/jtreg/src/make/../build/deps/apache-ant-1.10.8-bin.zip Error: sh][ERROR] wget exited with exit code 4 Error: Process completed with exit code 1. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2972#issuecomment-2505899793 From duke at openjdk.org Thu Nov 28 11:42:45 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Thu, 28 Nov 2024 11:42:45 GMT Subject: [jdk21u-dev] Integrated: 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows In-Reply-To: <hCZuxP9oDF459Cpyrb1AvpxwUC41Xw_gH4Vmryk_wDk=.845d7a0d-229a-4a31-836c-426b0e8352c6@github.com> References: <hCZuxP9oDF459Cpyrb1AvpxwUC41Xw_gH4Vmryk_wDk=.845d7a0d-229a-4a31-836c-426b0e8352c6@github.com> Message-ID: <ppPcjbxWe9WvvFaDGOd4ZlnA3-DfgXy3IxeijW8Wc4k=.7e1fc9db-f742-4b88-a9be-2b847fb060dd@github.com> On Thu, 7 Nov 2024 09:16:32 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote: > Hi all, > > I want to backport JDK-8333427 for jdk21u. > This is clean backport. It changes only one test. > > Testing: langtools/tools/javac/newlines/NewLineTest.java This pull request has now been integrated. Changeset: 2dd73179 Author: KIRIYAMA Takuya <kiriyama.takuya at fujitsu.com> Committer: Severin Gehwolf <sgehwolf at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/2dd73179c82b9c7f09945813c887fba671935272 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows Backport-of: 1b0281dc77f41fc5df323c7f7b25a4138b1ffb9e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1132 From duke at openjdk.org Thu Nov 28 11:58:52 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 28 Nov 2024 11:58:52 GMT Subject: [jdk23u] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names Message-ID: <P2iuJBYEXv8PcpcYEzg2IrKaeJdakGfIq5-hiSJ2fqU=.fafda074-13e5-4f5b-855e-ddf4152f73d9@github.com> Clean backport of JDK-8340552. Tested tier1 tests and processing data from tzdata/2024b. ------------- Commit messages: - Backport 1bc13a1c10a580f84f1b7686c95344ec2633f611 Changes: https://git.openjdk.org/jdk23u/pull/230/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=230&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340552 Stats: 12 lines in 1 file changed: 8 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk23u/pull/230.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/230/head:pull/230 PR: https://git.openjdk.org/jdk23u/pull/230 From mbaesken at openjdk.org Thu Nov 28 12:23:45 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 28 Nov 2024 12:23:45 GMT Subject: [jdk21u-dev] Integrated: 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed In-Reply-To: <eujZYbQGx6doSoU7HMi7qW-ugMXSPIQ7VrEDKqUQYpc=.a2ece88c-0e83-4141-a8eb-a983c69368ff@github.com> References: <eujZYbQGx6doSoU7HMi7qW-ugMXSPIQ7VrEDKqUQYpc=.a2ece88c-0e83-4141-a8eb-a983c69368ff@github.com> Message-ID: <kvDcTF6nHzWcCHg2Si4BADyncXtuUnOXeSZjmg4AtVk=.916d8b1c-b361-4918-976a-118958a18691@github.com> On Thu, 28 Nov 2024 08:37:40 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed This pull request has now been integrated. Changeset: 6b9ef8da Author: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/6b9ef8dadf17bfaac654f0ce8aa537e580109b18 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed Backport-of: 2564f0f99866c33d14947609c276a421ce8cc0a2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1187 From mbaesken at openjdk.org Thu Nov 28 12:28:18 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 28 Nov 2024 12:28:18 GMT Subject: [jdk17u-dev] RFR: 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed Message-ID: <8iWrSWNTA23GIDKFXzeR-JdmvM_EcydSUDSMt2ZSYhA=.b7f6ca84-81ae-4241-9d9b-3a0181e29cd2@github.com> 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed ------------- Commit messages: - Backport 2564f0f99866c33d14947609c276a421ce8cc0a2 Changes: https://git.openjdk.org/jdk17u-dev/pull/3077/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3077&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325906 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3077.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3077/head:pull/3077 PR: https://git.openjdk.org/jdk17u-dev/pull/3077 From duke at openjdk.org Thu Nov 28 13:31:51 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Thu, 28 Nov 2024 13:31:51 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v4] In-Reply-To: <wYQx4reYw191HCZv7EJ5NdTH9gzpdSGndMPPWKpcXe8=.fe1edce0-85d4-4dec-bd84-edbab5d5b763@github.com> References: <Nm9nt3ihKhACiDQgVwXSrcEDnd-HkyBTBJPU_cv2DDs=.714d8254-9859-4393-b0b2-1c6cb67d4379@github.com> <wYQx4reYw191HCZv7EJ5NdTH9gzpdSGndMPPWKpcXe8=.fe1edce0-85d4-4dec-bd84-edbab5d5b763@github.com> Message-ID: <oQaB6ghMnmkXFfIBcudhboRzdQM4eRoGd8mkjY4PjCI=.d94255ef-20c9-4b70-913c-6db54404f993@github.com> On Thu, 7 Nov 2024 13:13:10 GMT, Taizo Kurashige <duke at openjdk.org> wrote: >> Hi, >> >> This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts >> >> Original patch does not apply cleanly for the following reasons: >> >> ?Fix to getOsMap() in test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied since getOsMap() was removed in https://bugs.openjdk.org/browse/JDK-8331700. >> ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in [https://bugs.openjdk.org/browse/JDK-8220753](https://bugs.openjdk.org/browse/JDK-8220753%28jdk13%29) (jdk13). >> ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed in https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. >> >> Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing >> >> Thanks. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > Replace pkcs11/fips/key4.db and pkcs11.txt I tried and got the same output as you ... $ pwd /work/kurashige/JDK-8296631/jdk11u-dev/test/jdk/sun/security/pkcs11/fips $ /usr/lib64/nss/unsupported-tools/dbtool -d . dbdir selected is . CertDB: KeyDB: However, the same output was obtained for dbdir that existed before this PR was created. $ pwd /work/kurashige/JDK-8296631/jdk11u-dev/test/jdk/sun/security/pkcs11/nss/db $ ls cert8.db cert9.db key3.db key4.db secmod.db $ /usr/lib64/nss/unsupported-tools/dbtool -d . dbdir selected is . CertDB: KeyDB: I'm sorry for my ignorance, but I don't know what the problem is. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2955#issuecomment-2506132969 From mbaesken at openjdk.org Thu Nov 28 13:34:18 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 28 Nov 2024 13:34:18 GMT Subject: [jdk21u-dev] RFR: 8345055: [21u] ProblemList failing rtm tests on ppc platforms [v3] In-Reply-To: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> References: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> Message-ID: <VIOXULdwsWPqMkIpmJtWgGXWdKxM0TR0fak1wwMgOCs=.bc00ac78-c122-4db9-bf3a-9b07350eef99@github.com> > Exclude some rtm related test which we see currently failing on some ppc64 platforms. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: add exclusion of compiler/rtm/cli/TestUseRTMDeoptOptionOnSupportedConfig.java on power ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1183/files - new: https://git.openjdk.org/jdk21u-dev/pull/1183/files/98b06edf..753d0029 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1183&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1183&range=01-02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1183.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1183/head:pull/1183 PR: https://git.openjdk.org/jdk21u-dev/pull/1183 From mdoerr at openjdk.org Thu Nov 28 13:40:47 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 28 Nov 2024 13:40:47 GMT Subject: [jdk21u-dev] RFR: 8345055: [21u] ProblemList failing rtm tests on ppc platforms [v3] In-Reply-To: <VIOXULdwsWPqMkIpmJtWgGXWdKxM0TR0fak1wwMgOCs=.bc00ac78-c122-4db9-bf3a-9b07350eef99@github.com> References: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> <VIOXULdwsWPqMkIpmJtWgGXWdKxM0TR0fak1wwMgOCs=.bc00ac78-c122-4db9-bf3a-9b07350eef99@github.com> Message-ID: <CpegX-O9BWaRxpxk9hifFHwF9XWuwMRzSez7MpMy0sM=.4ee33bbe-cda4-4445-b732-923c66f1bdec@github.com> On Thu, 28 Nov 2024 13:34:18 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: >> Exclude some rtm related test which we see currently failing on some ppc64 platforms. > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > add exclusion of compiler/rtm/cli/TestUseRTMDeoptOptionOnSupportedConfig.java on power Marked as reviewed by mdoerr (Reviewer). You can add it. We don't need to test RTM in 21u. ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1183#pullrequestreview-2468204044 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1183#issuecomment-2506143722 From mbaesken at openjdk.org Thu Nov 28 13:40:47 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 28 Nov 2024 13:40:47 GMT Subject: [jdk21u-dev] RFR: 8345055: [21u] ProblemList failing rtm tests on ppc platforms [v3] In-Reply-To: <VIOXULdwsWPqMkIpmJtWgGXWdKxM0TR0fak1wwMgOCs=.bc00ac78-c122-4db9-bf3a-9b07350eef99@github.com> References: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> <VIOXULdwsWPqMkIpmJtWgGXWdKxM0TR0fak1wwMgOCs=.bc00ac78-c122-4db9-bf3a-9b07350eef99@github.com> Message-ID: <BO3y0eVdE7wDCmrRTpWzXCG25QBq99CW_74y1F2xnnw=.c7104f14-bcf4-46df-adcc-3ea6016e6f94@github.com> On Thu, 28 Nov 2024 13:34:18 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: >> Exclude some rtm related test which we see currently failing on some ppc64 platforms. > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > add exclusion of compiler/rtm/cli/TestUseRTMDeoptOptionOnSupportedConfig.java on power compiler/rtm/cli/TestUseRTMDeoptOptionOnSupportedConfig.java fails at least on AIX too, so I added this one as well. Thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1183#issuecomment-2506144789 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1183#issuecomment-2506146824 From mbaesken at openjdk.org Thu Nov 28 13:40:48 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 28 Nov 2024 13:40:48 GMT Subject: [jdk21u-dev] Integrated: 8345055: [21u] ProblemList failing rtm tests on ppc platforms In-Reply-To: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> References: <2FpZAdjhi9WdHm0DXKweYv3Hz-3UA6ZZImFeNEckVio=.832361e1-3ea0-4bd1-9765-8a7a507424f0@github.com> Message-ID: <kK6XDlAZZhjs9b4rB0aunyRiFsp7W5__HGSGV_pcYjA=.5de5b261-ec69-44ec-bb80-2ba88bd82bcf@github.com> On Tue, 26 Nov 2024 15:08:05 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote: > Exclude some rtm related test which we see currently failing on some ppc64 platforms. This pull request has now been integrated. Changeset: 5ac01dec Author: Matthias Baesken <mbaesken at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/5ac01dec3617efd6e51ea3256cba31c741336c13 Stats: 12 lines in 1 file changed: 1 ins; 0 del; 11 mod 8345055: [21u] ProblemList failing rtm tests on ppc platforms Reviewed-by: mdoerr ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1183 From duke at openjdk.org Thu Nov 28 15:07:53 2024 From: duke at openjdk.org (duke) Date: Thu, 28 Nov 2024 15:07:53 GMT Subject: [jdk21u-dev] Withdrawn: 8341059: Change Entrust TLS distrust date to November 12, 2024 In-Reply-To: <7vZuE1siKa9wZGjSHg1yTubxKcA11XI7rYCwLHsc1_Y=.23f4d493-a3ed-49b0-9bd2-361cd86b0006@github.com> References: <7vZuE1siKa9wZGjSHg1yTubxKcA11XI7rYCwLHsc1_Y=.23f4d493-a3ed-49b0-9bd2-361cd86b0006@github.com> Message-ID: <BYNw3a5zB2jXkr0md6H03PrgNqJFGdtmx2UyKIae3H0=.89407b6e-e368-4f18-b71d-ad305066bf07@github.com> On Fri, 27 Sep 2024 23:40:46 GMT, Andrew John Hughes <andrew at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [f554c3ff](https://github.com/openjdk/jdk/commit/f554c3ffce7599fdb535b03db4a6ea96870b3c2d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Rajan Halade on 27 Sep 2024 and was reviewed by Sean Mullan. > > The commit does not apply cleanly to 21u-dev due to the absence of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560). Equivalent changes to those in `distrust/Entrust.java` are applied to `Entrust/Distrust.java` instead. > > The tests in `test/jdk/sun/security/ssl/X509TrustManagerImpl/Entrust` pass with the updated build and fail against 21.0.4. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1015 From duke at openjdk.org Thu Nov 28 15:08:49 2024 From: duke at openjdk.org (duke) Date: Thu, 28 Nov 2024 15:08:49 GMT Subject: [jdk21u-dev] Withdrawn: 8300148: Consider using a StoreStore barrier instead of Release barrier on ctor exit In-Reply-To: <jVgzxHt5triWZZcYuAm7wa-CFKTCK5qbp5_JivTw4X0=.bba2c741-0070-4060-94f7-78c263056ed1@github.com> References: <jVgzxHt5triWZZcYuAm7wa-CFKTCK5qbp5_JivTw4X0=.bba2c741-0070-4060-94f7-78c263056ed1@github.com> Message-ID: <Mx2HOfSJupKpajM_Ezg9lsEQB0cAGofcvTLXK9SDh8k=.049557bd-cc21-4f98-810f-84bfa82fac50@github.com> On Wed, 24 Apr 2024 19:02:10 GMT, Aleksey Shipilev <shade at openjdk.org> wrote: > The backport is not clean because the hunk in `macro.cpp` does not apply to JDK 21, because it was added later with [JDK-8287061](https://bugs.openjdk.org/browse/JDK-8287061). > > We have been carrying this patch in our internal releases for 4 months, with some services using it successfully. It is time to bring it to JDK 21u. > > Additional testing: > - [x] New benchmark improves > - [x] New IR test passes > - [x] Linux AArch64 server fastdebug, `all` > - [x] Linux x86_64 server fastdebug, `all` This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/530 From andrew at openjdk.org Thu Nov 28 18:08:39 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 28 Nov 2024 18:08:39 GMT Subject: [jdk21u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <i-kPMpRwAPV42U3dZIcBkZpUr_hfMtSxXPIGwfhVg3o=.d026551e-8250-496e-ab15-00c06155dac8@github.com> References: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> <NxJn6uVBDTO0B5wSf9VAzac3VD2ln2JSBvowNEkHPUk=.f0f1e824-7734-46b4-9d59-3bc727a894cf@github.com> <i-kPMpRwAPV42U3dZIcBkZpUr_hfMtSxXPIGwfhVg3o=.d026551e-8250-496e-ab15-00c06155dac8@github.com> Message-ID: <3kgHkxkVoG8kHL0WJsY-38xYpu3g0WgL-zFUTwtz220=.850155fb-5f4f-45f5-9ed0-0d4b4eaa58db@github.com> On Wed, 27 Nov 2024 16:39:12 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote: > > Shouldn't this have gone to 23 first? > > I think the deadline for 23.0.2 update has closed? https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-October/038559.html Thanks, I wasn't aware of this. It seems very early. This essentially means 23 has only had about a month of post-release development. So no, Antonio, no reason to backport this to 23 after all. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1180#issuecomment-2506606038 From amitkumar at openjdk.org Thu Nov 28 21:07:50 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Thu, 28 Nov 2024 21:07:50 GMT Subject: [jdk21u-dev] Integrated: 8342409: [s390x] C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR In-Reply-To: <CaPtLN03DsjJx2HSui-Yi_i9f6sBrtkpoAp_OsyqU6M=.ac6ef6e5-df83-44e6-a438-74f3e3667575@github.com> References: <CaPtLN03DsjJx2HSui-Yi_i9f6sBrtkpoAp_OsyqU6M=.ac6ef6e5-df83-44e6-a438-74f3e3667575@github.com> Message-ID: <jz4PlLE32JBABpB4KKAoZWCpd0Jy7YpX2N_slJPGTmI=.75f81fb9-221e-400f-a2a3-3c2859db8626@github.com> On Wed, 27 Nov 2024 08:28:05 GMT, Amit Kumar <amitkumar at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit [9201e9fc](https://github.com/openjdk/jdk/commit/9201e9fcc28cff37cf9996e8db38f9aee7511b1c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 18 Oct 2024 and was reviewed by Richard Reingruber and Lutz Schmidt. > > Thanks! This pull request has now been integrated. Changeset: a803b5a0 Author: Amit Kumar <amitkumar at openjdk.org> Committer: Martin Doerr <mdoerr at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/a803b5a05eedf93fc9c7a7f64f6aa78adf2fdcca Stats: 9 lines in 2 files changed: 8 ins; 0 del; 1 mod 8342409: [s390x] C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR Backport-of: 9201e9fcc28cff37cf9996e8db38f9aee7511b1c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1184 From duke at openjdk.org Thu Nov 28 21:08:47 2024 From: duke at openjdk.org (Saint Wesonga) Date: Thu, 28 Nov 2024 21:08:47 GMT Subject: [jdk21u-dev] Integrated: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set In-Reply-To: <HhdgJY_Yud2qt8zSfMJ7L1bqd5jHm0XPGhvDy-uXkHQ=.f557d3ff-b737-4b32-9c6a-944cb9901d95@github.com> References: <HhdgJY_Yud2qt8zSfMJ7L1bqd5jHm0XPGhvDy-uXkHQ=.f557d3ff-b737-4b32-9c6a-944cb9901d95@github.com> Message-ID: <fyt8JF6dBay86mjdenWMUfMcNlRImGL334_0m0XQ4Ds=.a7c34e17-3f38-46ad-ade2-4002c0aae877@github.com> On Fri, 22 Nov 2024 16:28:02 GMT, Saint Wesonga <duke at openjdk.org> wrote: > Backport https://github.com/openjdk/jdk23u/commit/7f189a59d9ad803aee72565bc46a817d3f46f2e5 to jdk23u. UnsafeIntrinsicsTest.java#ZGenerationalDebug test now passes in fastdebug on Windows AArch64 with this change. This pull request has now been integrated. Changeset: 046c4aa1 Author: Saint Wesonga <saint.wesonga at microsoft.com> Committer: Martin Doerr <mdoerr at openjdk.org> URL: https://git.openjdk.org/jdk21u-dev/commit/046c4aa16167134d1614be81a375d2d86e44077a Stats: 59 lines in 1 file changed: 19 ins; 36 del; 4 mod 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set Backport-of: 7f189a59d9ad803aee72565bc46a817d3f46f2e5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1176 From andrew at openjdk.org Fri Nov 29 00:49:46 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Nov 2024 00:49:46 GMT Subject: [jdk11u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: <nNlZrILLme7EKXQioDLN6zfYvLVWhCeSNWrBpFRQ040=.00edeb92-5357-45a9-89fe-cb639f6c38a9@github.com> References: <nNlZrILLme7EKXQioDLN6zfYvLVWhCeSNWrBpFRQ040=.00edeb92-5357-45a9-89fe-cb639f6c38a9@github.com> Message-ID: <tlpK92PsLGThems7qa3OPmTGZ7V4smjksoWi65zAJWI=.764fb374-5588-40e0-bfb5-10d9e2a6c703@github.com> On Mon, 29 May 2023 09:38:20 GMT, Nagata-Haruhito <duke at openjdk.org> wrote: > I want to backport JDK-8268457 to JDK11u. > This is almost clean except lastmodified month. > > Note, included test is broken, it was fixed with JDK-8274606, > I intend to follow up with its backport same as jdk17u. Is there a reason that `SurrogateTest.java` in this change has a different copyright year (2023) to the version in 17u and 18 (2021)? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1907#issuecomment-2506894901 From andrew at openjdk.org Fri Nov 29 01:00:41 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Nov 2024 01:00:41 GMT Subject: [jdk23u] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <P2iuJBYEXv8PcpcYEzg2IrKaeJdakGfIq5-hiSJ2fqU=.fafda074-13e5-4f5b-855e-ddf4152f73d9@github.com> References: <P2iuJBYEXv8PcpcYEzg2IrKaeJdakGfIq5-hiSJ2fqU=.fafda074-13e5-4f5b-855e-ddf4152f73d9@github.com> Message-ID: <FTw5geZMZRsKmSe87FyO85WQHddtfaGggjj_uvbhG24=.8b6863cc-4c56-4839-9807-5b6283d8d607@github.com> On Thu, 28 Nov 2024 11:54:02 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of JDK-8340552. > > Tested tier1 tests and processing data from tzdata/2024b. As mentioned on https://github.com/openjdk/jdk21u-dev/pull/1180#issuecomment-2506606038 this is unnecessary as there will be no further releases from 23u. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/230#issuecomment-2506901081 From andrew at openjdk.org Fri Nov 29 01:06:45 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Nov 2024 01:06:45 GMT Subject: [jdk11u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <pJ2sPmIRbLeEnPeNrXqYyrj8ojScLFLisSMNU_UgDpw=.45309c23-420c-470f-b255-2bf22afdd094@github.com> References: <pJ2sPmIRbLeEnPeNrXqYyrj8ojScLFLisSMNU_UgDpw=.45309c23-420c-470f-b255-2bf22afdd094@github.com> Message-ID: <eb8pKfhAIySrxv2mCKQFU3-xcKmVXflrtC9Df0pef5I=.4749c2a7-a259-42c6-9b9d-986b939882d0@github.com> On Thu, 28 Nov 2024 10:27:45 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested with tier1 tests and also processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) Confirmed clean ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2972#pullrequestreview-2468916846 From goetz at openjdk.org Fri Nov 29 07:37:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 29 Nov 2024 07:37:35 GMT Subject: [jdk21u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order Message-ID: <z3gAipHezaSn3OC-I-0IigGpsyPWUE4_mL3e9fvCcos=.1588cd67-45c2-437b-aa80-ead317e9a757@github.com> Resolved SystemModulesPlugin.java due to context (ClassFile.of() <--> Classfile) The patch is based on the commit to 23, the version for 22/22.0.1 is identical. I can reproduce the error with the test, and the patch fixes the issue. I had to adapt the tests because "8317620: Build JDK tools with ModuleMainClass attribute" is missing in 21. jdk.jfr has no main, so I exclude it from the tests. ------------- Commit messages: - Fix tests - Backport f3be138eb80c9e7f6cc21afb75cda9e49b667c8a Changes: https://git.openjdk.org/jdk21u-dev/pull/1189/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1189&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322809 Stats: 290 lines in 6 files changed: 282 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1189.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1189/head:pull/1189 PR: https://git.openjdk.org/jdk21u-dev/pull/1189 From duke at openjdk.org Fri Nov 29 07:57:44 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 29 Nov 2024 07:57:44 GMT Subject: [jdk23u] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <P2iuJBYEXv8PcpcYEzg2IrKaeJdakGfIq5-hiSJ2fqU=.fafda074-13e5-4f5b-855e-ddf4152f73d9@github.com> References: <P2iuJBYEXv8PcpcYEzg2IrKaeJdakGfIq5-hiSJ2fqU=.fafda074-13e5-4f5b-855e-ddf4152f73d9@github.com> Message-ID: <kEHl1tCH-13TPY2DLmMy74CSoRwfyiIy87JRWBFYo9w=.cd394308-2964-4fbe-aaab-0a503ec913bf@github.com> On Thu, 28 Nov 2024 11:54:02 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of JDK-8340552. > > Tested tier1 tests and processing data from tzdata/2024b. Very true. Missed that. Closing. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/230#issuecomment-2507265321 From duke at openjdk.org Fri Nov 29 07:57:51 2024 From: duke at openjdk.org (duke) Date: Fri, 29 Nov 2024 07:57:51 GMT Subject: [jdk11u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <pJ2sPmIRbLeEnPeNrXqYyrj8ojScLFLisSMNU_UgDpw=.45309c23-420c-470f-b255-2bf22afdd094@github.com> References: <pJ2sPmIRbLeEnPeNrXqYyrj8ojScLFLisSMNU_UgDpw=.45309c23-420c-470f-b255-2bf22afdd094@github.com> Message-ID: <91GIXwl916TxkhfSJR2DmebnfU-ChwM7WeDeKAn_TXI=.0a916b50-d764-43be-8b1e-845de24927d7@github.com> On Thu, 28 Nov 2024 10:27:45 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested with tier1 tests and also processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) @vieiro Your change (at version b353dfe7f220a9ce6e0adba085804dad6d53a029) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2972#issuecomment-2507265058 From duke at openjdk.org Fri Nov 29 07:57:45 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 29 Nov 2024 07:57:45 GMT Subject: [jdk23u] Withdrawn: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <P2iuJBYEXv8PcpcYEzg2IrKaeJdakGfIq5-hiSJ2fqU=.fafda074-13e5-4f5b-855e-ddf4152f73d9@github.com> References: <P2iuJBYEXv8PcpcYEzg2IrKaeJdakGfIq5-hiSJ2fqU=.fafda074-13e5-4f5b-855e-ddf4152f73d9@github.com> Message-ID: <9YJxfJQHSw9WKFLcu7fJLKBha2PN7cceBtmtMZHRToU=.cefd8681-78a3-47ff-a172-cf161e0cf248@github.com> On Thu, 28 Nov 2024 11:54:02 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of JDK-8340552. > > Tested tier1 tests and processing data from tzdata/2024b. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk23u/pull/230 From mbaesken at openjdk.org Fri Nov 29 08:01:52 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 29 Nov 2024 08:01:52 GMT Subject: [jdk21u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order In-Reply-To: <z3gAipHezaSn3OC-I-0IigGpsyPWUE4_mL3e9fvCcos=.1588cd67-45c2-437b-aa80-ead317e9a757@github.com> References: <z3gAipHezaSn3OC-I-0IigGpsyPWUE4_mL3e9fvCcos=.1588cd67-45c2-437b-aa80-ead317e9a757@github.com> Message-ID: <XBWJKafNkHaaDqjd1xnp6mPwkAKvg5H5jk5EuDXf5Fc=.7b7b7947-9981-4e30-89d1-9908b3de9947@github.com> On Thu, 28 Nov 2024 10:52:17 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > Resolved SystemModulesPlugin.java due to context (ClassFile.of() <--> Classfile) > > The patch is based on the commit to 23, the version for 22/22.0.1 is identical. > > I can reproduce the error with the test, and the patch fixes the issue. > > I had to adapt the tests because "8317620: Build JDK tools with ModuleMainClass attribute" is missing in 21. > jdk.jfr has no main, so I exclude it from the tests. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1189#pullrequestreview-2469297056 From duke at openjdk.org Fri Nov 29 08:09:54 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 29 Nov 2024 08:09:54 GMT Subject: [jdk21u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> References: <XEvTBXCv6dBeaBiBBVe41j3P7ATNQXJfpxCwPqvGHFo=.4456d0e6-c89c-4e81-9948-8bc0020a7e6e@github.com> Message-ID: <WplOmohlHXdzFQLy3EF0KGa0kvqgZnCBvgqbRI5TZkI=.9034f4c7-3b33-4f75-a607-85c5959f2553@github.com> On Mon, 25 Nov 2024 07:15:55 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested tier1 tests and processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) I'm afraid I saw the comment _after_ the backport to 23u. I've just closed it. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1180#issuecomment-2507282432 From goetz at openjdk.org Fri Nov 29 08:28:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 29 Nov 2024 08:28:12 GMT Subject: [jdk17u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order Message-ID: <jVT1fsPbuuLwMNGPwCQumTljOKiDAkdkdGXu3r2iq2Q=.e6838078-c799-4e5b-b498-5460988d05c2@github.com> This is a backport of the 21 PR code, but it needs further adaptions. SystemModulesPlugin.java had to be resolved. The code to be patched does the same, but uses different Java syntax. Also, I had to remove one more case from the test as jdk.httpserver has no main specified. But the test still shows the same failure as in head when the fix misses in the JVM, and passes if the fix is present. ------------- Commit messages: - Backport f3be138eb80c9e7f6cc21afb75cda9e49b667c8a Changes: https://git.openjdk.org/jdk17u-dev/pull/3078/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3078&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322809 Stats: 294 lines in 6 files changed: 287 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3078.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3078/head:pull/3078 PR: https://git.openjdk.org/jdk17u-dev/pull/3078 From sgehwolf at openjdk.org Fri Nov 29 10:27:45 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 29 Nov 2024 10:27:45 GMT Subject: [jdk21u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order In-Reply-To: <z3gAipHezaSn3OC-I-0IigGpsyPWUE4_mL3e9fvCcos=.1588cd67-45c2-437b-aa80-ead317e9a757@github.com> References: <z3gAipHezaSn3OC-I-0IigGpsyPWUE4_mL3e9fvCcos=.1588cd67-45c2-437b-aa80-ead317e9a757@github.com> Message-ID: <V_RkxzVHEA0Ad8ZQ2pTqMEsIuhDaYnIXroLzecQVXL4=.8d24815c-3ac2-42d1-86d2-61488b09b2fe@github.com> On Thu, 28 Nov 2024 10:52:17 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote: > Resolved SystemModulesPlugin.java due to context (ClassFile.of() <--> Classfile) > > The patch is based on the commit to 23, the version for 22/22.0.1 is identical. > > I can reproduce the error with the test, and the patch fixes the issue. > > I had to adapt the tests because "8317620: Build JDK tools with ModuleMainClass attribute" is missing in 21. > jdk.jfr has no main, so I exclude it from the tests. test/jdk/tools/jlink/plugins/SystemModuleDescriptors/src/net.foo/module-info.java line 25: > 23: > 24: module net.foo { > 25: requires jdk.jfr; Not needed if there is no main class in that module. test/jdk/tools/jlink/plugins/SystemModuleDescriptors/src/net.foo/net/foo/Main.java line 44: > 42: ModuleFinder.ofSystem().find(mn).get().descriptor().mainClass() > 43: .orElseThrow(() -> new RuntimeException(mn + " no main class")) > 44: ); The test needs at least 2 main classes in modules (the original review suggests it's adding `jdk.jfr` so that there are 4). I suggest to remove the `jdk.jfr` module if it doesn't include a main class. The dep on `jdk.jfr` in `net.foo`'s module can go away. ------------- PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1189#discussion_r1863302655 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1189#discussion_r1863301896 From duke at openjdk.org Fri Nov 29 11:51:50 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 29 Nov 2024 11:51:50 GMT Subject: [jdk11u-dev] Integrated: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: <pJ2sPmIRbLeEnPeNrXqYyrj8ojScLFLisSMNU_UgDpw=.45309c23-420c-470f-b255-2bf22afdd094@github.com> References: <pJ2sPmIRbLeEnPeNrXqYyrj8ojScLFLisSMNU_UgDpw=.45309c23-420c-470f-b255-2bf22afdd094@github.com> Message-ID: <lbUc-T0U7eH2ckoLWbbMnppDsAgQiuA-ZCrOTe0FrtI=.f98b3b87-8e78-4c7e-a48f-900eda28fd42@github.com> On Thu, 28 Nov 2024 10:27:45 GMT, Antonio Vieiro <duke at openjdk.org> wrote: > Clean backport of [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552). > > Tested with tier1 tests and also processing data [from tzdata/2024b.](https://data.iana.org/time-zones/releases/tzdb-2024b.tar.lz) This pull request has now been integrated. Changeset: 1c80800a Author: Antonio Vieiro <avieirov at redhat.com> Committer: Andrew John Hughes <andrew at openjdk.org> URL: https://git.openjdk.org/jdk11u-dev/commit/1c80800a26fee6b1760b63bcfae672e232c639f7 Stats: 12 lines in 1 file changed: 8 ins; 0 del; 4 mod 8340552: Harden TzdbZoneRulesCompiler against missing zone names Reviewed-by: andrew Backport-of: d70ea492436514ac79fd723578e5e5bae5c18866 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2972 From dcherepanov at openjdk.org Fri Nov 29 18:16:15 2024 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Fri, 29 Nov 2024 18:16:15 GMT Subject: [jdk21u-dev] RFR: 8343285: java.lang.Process is unresponsive and CPU usage spikes to 100% Message-ID: <YA4RqhDAf7279iTN1pjLKYwon8IV0b0cCKh_fi8U2CA=.09f7922c-bd31-4100-9ae0-38090e761c83@github.com> Clean backport of https://bugs.openjdk.org/browse/JDK-8343285 Tested with LibreOffice - hangs without the fix and works with the fix ------------- Commit messages: - Backport c00e20c399cf9b3b21258bd5654a92d703c8fcd2 Changes: https://git.openjdk.org/jdk21u-dev/pull/1190/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1190&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343285 Stats: 7 lines in 1 file changed: 0 ins; 1 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1190.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1190/head:pull/1190 PR: https://git.openjdk.org/jdk21u-dev/pull/1190 From dcherepanov at openjdk.org Fri Nov 29 18:26:23 2024 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Fri, 29 Nov 2024 18:26:23 GMT Subject: [jdk17u-dev] RFR: 8343285: java.lang.Process is unresponsive and CPU usage spikes to 100% Message-ID: <90mo2KekX6zwcKUcxN6WXX43Sph-quOCCIFpTE9EGJo=.fdbae526-4a12-4e2d-bdf1-b1f09c5ff66d@github.com> Clean backport of https://bugs.openjdk.org/browse/JDK-8343285 Tested with LibreOffice - it hangs without the fix and works with the fix ------------- Commit messages: - Backport c00e20c399cf9b3b21258bd5654a92d703c8fcd2 Changes: https://git.openjdk.org/jdk17u-dev/pull/3079/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3079&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343285 Stats: 7 lines in 1 file changed: 0 ins; 1 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3079.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3079/head:pull/3079 PR: https://git.openjdk.org/jdk17u-dev/pull/3079 From duke at openjdk.org Fri Nov 29 21:11:46 2024 From: duke at openjdk.org (duke) Date: Fri, 29 Nov 2024 21:11:46 GMT Subject: [jdk17u-dev] Withdrawn: 8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp In-Reply-To: <do1jTBtNndf04Ai8RCUpci9oK0smJji6XGdL1z0sTKA=.0dc5a243-3511-45a1-b40b-2754a805e7d7@github.com> References: <do1jTBtNndf04Ai8RCUpci9oK0smJji6XGdL1z0sTKA=.0dc5a243-3511-45a1-b40b-2754a805e7d7@github.com> Message-ID: <C0QM6wtkamod35yK7hZt-IBe67JFVsrtMSXTk9dLF_o=.dd95b469-d7dd-404b-b7ff-4dda43740741@github.com> On Wed, 28 Aug 2024 15:16:04 GMT, Radim Vansa <rvansa at openjdk.org> wrote: > Hi all, > > This pull request contains a backport of commit[ 02f79008](https://github.com/openjdk/jdk/commit/02f79008828b3dcce3bd6492efaa43e99376c0c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Albert Mingkun Yang on 15 Nov 2021 and was reviewed by Thomas Schatzl and Stefan Johansson. > > The backport is not clean; some method return types differ in later JDK versions. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2830 From duke at openjdk.org Sat Nov 30 12:38:49 2024 From: duke at openjdk.org (akhilesh-delphix) Date: Sat, 30 Nov 2024 12:38:49 GMT Subject: [jdk17u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases In-Reply-To: <ko2XNBOU5qMYP2Z7xptFtAZTYqSjTBIsoVfFKrnRKXE=.907bca5a-201f-47f1-85e3-9494d58b789e@github.com> References: <h8hHnXMIy1TI1faMK7SBqjQeANYWMLn1zor8lwQYe90=.938dd42a-076f-4552-9be1-06a965f240e8@github.com> <1UUqQN-7Z73RTII7FWXHU6iNA9QEIHEdh42lEewXD3s=.cde8dd2b-6c02-4490-981c-9dd4f2c1c622@github.com> <OFfLc5lReGZGy7aP7gE1fSHeincCe1kfBkYKEryh-0Y=.2271bd43-361f-489d-a42d-58e21a44bd88@github.com> <ko2XNBOU5qMYP2Z7xptFtAZTYqSjTBIsoVfFKrnRKXE=.907bca5a-201f-47f1-85e3-9494d58b789e@github.com> Message-ID: <vNZCiafZgIpFTIgDbQRhmGMEN7mCkOwHV-Kf_q-7-MQ=.4e908e72-3701-40f8-a124-919240707f8d@github.com> On Thu, 14 Nov 2024 18:53:15 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote: >>> java.nio.file.FileSystemException: app.jar: Function not implemented >> >> This looks like a different issue. > >> java.nio.file.FileSystemException: app.jar: Function not implemented > > @akhilesh-delphix, It looks like a similar issue, but the state syscall returns `ENOSYS` error code instead of `EPERM`. So, this PR does not fix your issue. > Could you please describe your environment? Maybe we will need a follow-up to handle `ENOSYS` as well. hi @alexeybakhtin, Pls let me know if you need further details on this. Additionally , is it possible for you confirm that the issue faced by me (`java.nio.file.FileSystemException: app.jar: Function not implemented`) is a JDK issue (possibly regression of https://bugs.openjdk.org/browse/JDK-8316304). It will help us communicate with our stakeholders ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2883#issuecomment-2508948223