[jdk17u-dev] RFR: 8303742: CompletableFuture.orTimeout leaks if the future completes exceptionally [v2]

fitzsim duke at openjdk.org
Wed Nov 6 13:15:32 UTC 2024


On Fri, 25 Oct 2024 22:16:36 GMT, Ben Taylor <btaylor at openjdk.org> wrote:

>> Clean backport of a patch to prevent `CompleteableFuture.orTimeout` from leaking when a `ScheduledFutureTask` exits exceptionally
>> 
>> Passes the included test as well as jtreg tier 1 locally on linux x86_64
>> 
>> Updated to include JDK-8304557, which is a follow up item to prevent the test from timing out, see @RealCLanger's comment below. That backport is also clean.
>
> Ben Taylor has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Backport 6f67abd352ce9605dd93188995d42a47ee07b25e

_I am not a Reviewer; I maintain `java-17-openjdk` in `RHEL` so I try to review `rfr`-labelled pull requests for `jdk17u-dev`, time-permitting._

This looks like a good change to have in `17`.  The need for the test case load-reduction workaround in `JDK-8304557` is interesting.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3000#issuecomment-2459719661


More information about the jdk-updates-dev mailing list