[jdk21u-dev] RFR: 8319673: Few security tests ignore VM flags [v2]
SendaoYan
syan at openjdk.org
Fri Nov 8 08:48:37 UTC 2024
On Fri, 8 Nov 2024 08:01:45 GMT, SendaoYan <syan at openjdk.org> wrote:
>> GHA report `install some dependencies` failure in macos-aarch64, it seems like envirnmental issue, it's unrelrated to this PR.
>
>> Hi @sendaoYan, what's up with this backport?
>
> This backport will cause test `java/security/Security/ConfigFileTest.java` compile error, because new API Path resolve(String first, String... more) was not supported in jdk21u-dev.
> Should I integrate this backport, and then create a new PR to fix the error right away.
> Hi @sendaoYan, this is a normal thing happening with backports. We don't file extra bugs for this. If it was clean before, it is best to push an extra commit on top of the original backport, explain in detail in the PR what and why it was edited, and include a short remark in the approval comment that it had to be adapted to 21. (This hints the person backporting to 17 to base the backport on the 21 commit).
Thanks for the detail advice. I will create a new PR to backport plus fix the compile error.
-------------
PR Comment: https://git.openjdk.org/jdk21u-dev/pull/830#issuecomment-2464142193
More information about the jdk-updates-dev
mailing list