[jdk11u-dev] RFR: 8224624: Inefficiencies in CodeStrings::add_comment cause timeouts [v2]

[SendaoYan]

On Tue, 15 Oct 2024 06:17:48 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> This is prefix backport of [JDK-8231058](https://bugs.openjdk.org/browse/JDK-8231058), after apply this backport will make backport of [JDK-8231058](https://bugs.openjdk.org/browse/JDK-8231058) cleanly.
>> This PR improves C1 compiled time of the test `compiler/c1/TestLinearScanOrderMain.java` method dramatically from [92s to 1.8s](https://bugs.openjdk.org/browse/JDK-8224624), and solve this test intermittent timeout.
>> 
>> Additonal testing:
>> 
>> - [x] linux aarch64 build with release/slowdebug configure
>> - [x] linux x86_64 build with release/slowdebug configure
>> - [x] jtreg tests(include tier1/2/3 etc.) with release build on linux aarch64
>> - [x] jtreg tests(include tier1/2/3 etc.) with release build on linux x86_64
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into jbs8224624
>  - 8224624: Inefficiencies in CodeStrings::add_comment cause timeouts
>    
>    Changing CodeStrings to a doubly-linked-list and searching for the comment with the right offset in reverse.
>    
>    Reviewed-by: kvn

Thanks for the approved.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2951#issuecomment-2465028584