[jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2]

Thomas Fitzsimmons duke at openjdk.org
Mon Nov 11 18:28:16 UTC 2024


On Sat, 9 Nov 2024 15:13:42 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

> The motivation for originally adding the test in JDK-8336942 that's being backported here was that this example would cause a crash if the implementation failed to handle two annotations with different retentions at the same location, so there's some value in this even without the fix to the test harness.

Independent of the harness fix, I would ideally like to be able replicate the crash you mention.  I have not yet found a way to make the `f10` lines you added produce a failure.  Can you advise how I would do that?

So far, I tried the new test on, and it succeeded on, `959665633eae0923d8acce533834940d1797bffd`, the commit before your backport of the fix for JDK-8225377, `3a2bf8e570d5e329f22b4eaf5e90fef8cd14f8b2`.  The `f10` lines also passed on `3a2bf8e570d5e329f22b4eaf5e90fef8cd14f8b2`.  Maybe there is some other fix I need to revert?

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2468788765


More information about the jdk-updates-dev mailing list