[jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2]

[Thomas Fitzsimmons]

On Tue, 5 Nov 2024 18:49:17 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> This change improves annotation processing test coverage, see [JDK-8336942](https://bugs.openjdk.org/browse/JDK-8336942). I resolved a trivial merge conflict with JDK-8323684, which added the `nameToAnnotation` map. The modified test passes.
>
> Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942
>  - 8336942: Improve test coverage for class loading elements with annotations of different retentions
>    
>    Reviewed-by: vromero

Thanks, that does clarify motivation.  I do not see harm in merging this pull request in the meantime, even if the backport does not ultimately happen.  From what I can tell (though I am not an expert in this area, and I did not step through the code) the new test lines may increase coverage of the existing `ClassReader` implementation, since they introduce an as yet unrepresented annotated type declaration pattern.  And even if they are superfluous, they are harmless because they do not cause a test failure on the current `17` code.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2471693337