[jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14
Antonio Vieiro
duke at openjdk.org
Mon Nov 18 22:16:40 UTC 2024
An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions.
The PR is separated in three commits for easier review:
- First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables:
- `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used)
- And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used).
- The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14).
- The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`).
Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`.
-------------
Commit messages:
- xcode14: Use -Wno-deprecated-non-prototype to bypass passing arguments to a function without a prototype
- xcode14: Use -Wno-deprecated-declarations to bypass sprintf deprecation
- 8344458: [11u] Add conditional support for XCode 14
Changes: https://git.openjdk.org/jdk11u-dev/pull/2966/files
Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2966&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8344458
Stats: 37 lines in 10 files changed: 35 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/jdk11u-dev/pull/2966.diff
Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2966/head:pull/2966
PR: https://git.openjdk.org/jdk11u-dev/pull/2966
More information about the jdk-updates-dev
mailing list