[jdk11u-dev] RFR: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result [v2]

[Radek Čáp]

On Tue, 19 Nov 2024 11:09:22 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Radek Čáp has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Backport 93b2aa48598ef26f645e673ad111885d2acd18ef
>
> src/hotspot/share/opto/gcm.cpp line 688:
> 
>> 686:   worklist_store.push(initial_mem);
>> 687:   worklist_visited.push(initial_mem);
>> 688:   worklist_mem.push(NULL);
> 
> OK. The JDK 17u version has the `nullptr` vs `NULL` changes. Hence the patch is not deemed clean.

I see, thank you. 
Is there anything expected from me here (like removing "This is a clean backport." from the original comment) or is it just for me to know?

> test/hotspot/jtreg/compiler/controldependency/TestAntiDependencyForPinnedLoads.java line 44:
> 
>> 42:       if (!revStr.equals("日DD月MM年YYYY")) throw new InternalError("FAIL");
>> 43:     }
>> 44:   }
> 
> Style: The JDK 17u patch has 4 space indent instead of 2. Please don't add changes like that in a backport. Use the same indentation as the JDK 17u patch.

Fixed by https://github.com/openjdk/jdk11u-dev/pull/2961/commits/4b57a7db4935f1277cb584bdaff27781ce085866

-------------

PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#discussion_r1848278348
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2961#discussion_r1848273188