[jdk21u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b

Andrew John Hughes andrew at openjdk.org
Wed Nov 20 00:59:32 UTC 2024


On Fri, 8 Nov 2024 12:36:19 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this for parity with 21.0.6-oracle.
> The documentation of the tz update says that it is not needed 
> necessarily, but a cleanup of various information. I think 
> we should go along here. It seems to bring a row of visible changes, 
> and it's good if this can be mapped to the same update everywhere.
> Also, this will simplify later tz updates, which happen regularly.
> 
> CSR for update versions available.
> 
> This is a Backport of the [jdk23u version](https://github.com/openjdk/jdk23u/commit/73b2341c670f98fb130c57f80eb1461226da1985), as the [jdk24 version](https://github.com/openjdk/jdk/commit/ebc17c7c8d6febd5a887309d1b7a466bcd2cc0a9) contains
> changes breaking the Java standard.  As I understand this only
> affects Java 8. But Oracle avoided to bring these changes to 23,
> so we should not do that in 21, either.
> 
> In detail, the 23u version omits backport of changes to 
> src/java.base/share/classes/java/time/ZoneId.java
> and src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java.
> 
> In the tests changes to test/jdk/java/time/tck/java/time/TCKZoneId.java and
> test/jdk/java/util/TimeZone/OldIDMappingTest.java are omited, and
> test/jdk/sun/util/calendar/zi/TestZoneInfo310.java is modified differently. File 
> test/jdk/sun/util/calendar/zi/tzdata_jdk/tz2024b_overridden_zones
> is added in 23. The change to test/jdk/sun/util/resources/TimeZone/Bug4848242.java differs, too.
> 
> **Needed adaptions:**
> 
> I had to resolve java/text/Format/DateFormat/TimeZoneNameTest.java.
> But the new version breaks the test. I assume this is because 21 does
> not have "[8174269](https://bugs.openjdk.org/browse/JDK-8174269): Remove COMPAT 
> locale data provider from JDK".
> The original version of the test passes.
> 
> test/jdk/sun/util/resources/TimeZone/Bug4848242.java is failing, too.
> The original version works, reverted.
> 
> Further I reverted test/jdk/java/util/TimeZone/TimeZoneData/aliases.txt and .../displaynames.txt
> as else java/util/TimeZone/Bug6329116.java (unmodified) starts failing.
> 
> See extra commits seperating out these edits.

Yes, that one is an actual data change in this update, whereas the others are due to the three-letter zones being removed and don't seem to affect the COMPAT provider.

Change looks good to me now. Thanks for restoring that line.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk21u-dev/pull/1143#pullrequestreview-2447111388


More information about the jdk-updates-dev mailing list