[jdk17u-dev] RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property [v2]

[Lutz Schmidt]

On Wed, 20 Nov 2024 09:55:54 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this for parity with Oracle 17.0.14. The backport is based on the commit to 21.
>> 
>> Tests passed including win tests. Three files are not real tests, I double-checked these.
>> 
>> I had to resolve a lot of files, but all except three only differed in the Copyright year.
>> 
>> Resolved files
>> ================
>> 
>> doc/testing.html
>> Resolved. Context differences.
>> 
>> test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestCipherKeyWrapperTest.java
>> test/jdk/com/sun/crypto/provider/Cipher/PBE/DecryptWithoutParameters.java
>> test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java
>> test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java
>> test/jdk/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java
>> test/jdk/com/sun/crypto/provider/Cipher/PBE/PBESealedObject.java
>> test/jdk/com/sun/crypto/provider/Cipher/PBE/TestCipherKeyWrapperPBEKey.java
>> test/jdk/com/sun/crypto/provider/KeyGenerator/Test4628062.java
>> test/jdk/com/sun/crypto/provider/Mac/HmacPBESHA1.java
>> test/jdk/com/sun/crypto/provider/Mac/HmacSaltLengths.java
>> test/jdk/com/sun/crypto/provider/Mac/MacClone.java
>> test/jdk/com/sun/crypto/provider/NSASuiteB/TestHmacSHAOids.java
>> All these test lack 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider
>> All only Copyright except for
>> DecryptWithoutParameters.java: Test in 17 has less and other test cases, adapted change to this.
>> 
>> test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestGeneral.java
>> Test was modified in 18 by 8271745: Correct block size for KW,KWP mode and use fixed IV for KWP mode for SunJCE
>> Test in 17 has other test cases, adapted change to this.
>> 
>> test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestKeySizeCheck.java
>> Test was modified in 8302225: SunJCE Provider doesn't validate key sizes when using 'constrained' transforms for AES/KW and AES/KWP
>> Backport started.
>> Resolved Copyright.
>> 
>> test/jdk/com/sun/crypto/provider/KeyAgreement/TestExponentSize.java
>> Modified in 19 by 8267319: Use larger default key sizes and algorithms based on CNSA
>> Resolved Copyright.
>> 
>> test/jdk/com/sun/jdi/ClassesByName2Test.java
>> Modified by virtual threads changes.
>> Resolved Copyright.
>> 
>> test/jdk/javax/crypto/EncryptedPrivateKeyInfo/GetAlgName.java
>> Modified in 20 by 8296442: EncryptedPrivateKeyInfo can be created with an uninitialized AlgorithmParameters. This is a follow-up of a cleanup change also in 20.
>> Resolved Copyright.
>> 
>> 
>> 
>> ...
>
> Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge branch 'master' into goetz_backport_8341927
>  - Backport 9bdf2a619d1d158d6c1e8e1e1238a4229e0b0783

LGTM.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/3049#pullrequestreview-2448951314