[jdk21u-dev] RFR: 8344993: [21u] Re-introduce 8327501 and 8328366 to the JDK

[Severin Gehwolf]

On Tue, 26 Nov 2024 08:57:03 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Hi,
>> 
>> In this PR I back out 8341989 for 8327501 and 8328366 to be re-introduced to JDK 21u. I plan to propose a backport of 8342905 thereafter. Reversion of 8341989 was clean.
>> 
>> Thanks,
>> Martin.-
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 984:
> 
>> 982:             @SuppressWarnings("removal")
>> 983:             SecurityManager sm = System.getSecurityManager();
>> 984:             if (sm != null && isCommon)
> 
> The check should be `if (isCommon && JLA.allowSecurityManager())` as a SM can be set mid-flight even if it is super weird to do that.

I think this is what the backport of [JDK-8342905](https://bugs.openjdk.org/browse/JDK-8342905) will do which Martin mentioned he'll do as a follow-up after this one.

-------------

PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1181#discussion_r1858088977