[jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v4]

[Antonio Vieiro]

On Mon, 25 Nov 2024 21:40:53 GMT, Antonio Vieiro <duke at openjdk.org> wrote:

>> An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions.
>> 
>> The PR is separated in three commits for easier review:
>> 
>> - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables:
>>     - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used)
>>     - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used).
>> - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14).
>> - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`).
>> 
>> Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`.
>
> Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Augment --disable-warnings-as-errors for clang >= 14.x.y

Closed in favor of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) in #2967

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2966#issuecomment-2505623467