[jdk17u-dev] RFR: 8313638: Add test for dump of resolved references
Martin Doerr
mdoerr at openjdk.org
Wed Oct 2 10:41:40 UTC 2024
On Tue, 1 Oct 2024 08:25:20 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
> I had to resolve the Whitebox coding. The method added by the backported change already exists in 17.
>
> Originally, WB_GetResolvedReferences was added by "https://bugs.openjdk.org/browse/JDK-8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive" in 10 which did not directly use it, there were closed tests depending on it. See "https://bugs.openjdk.org/browse/JDK-8188791: Move AppCDS from closed repo to open repo". It was removed in "https://bugs.openjdk.org/browse/JDK-8298048: Combine CDS archive heap into a single block" in 21 and added again by this change.
>
> I resolved the code to use the version of this new change to reduce differences to 21.
>
> The old Whitebox code is used in
> runtime/cds/appcds/cacheObject/CheckCachedResolvedReferencesApp.java
> runtime/cds/appcds/cacheObject/GCStressApp.java
> All runtime/cds/appcds/cacheObject/ are still passing.
LGTM.
-------------
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk17u-dev/pull/2924#pullrequestreview-2342585130
More information about the jdk-updates-dev
mailing list