[jdk17u-dev] RFR: 8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp

Radim Vansa rvansa at openjdk.org
Thu Oct 3 18:29:37 UTC 2024


On Thu, 3 Oct 2024 15:07:14 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit[ 02f79008](https://github.com/openjdk/jdk/commit/02f79008828b3dcce3bd6492efaa43e99376c0c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> 
>> The commit being backported was authored by Albert Mingkun Yang on 15 Nov 2021 and was reviewed by Thomas Schatzl and Stefan Johansson.
>> 
>> The backport is not clean; some method return types differ in later JDK versions.
>> 
>> Thanks!
>
> You need to ask for maintainer approval using "/approval request <text>".

@phohensee Actually I've added the `jdk17u-fix-request` label in JIRA, but it was removed by @GoeLin - so is this practically a rejection?

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2830#issuecomment-2392054472


More information about the jdk-updates-dev mailing list