[jdk21u-dev] RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient

[Ryan Flegel]

On Fri, 4 Oct 2024 06:57:44 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> I am backporting this fix because I am being affected by [JDK-8335181](https://bugs.openjdk.org/browse/JDK-8335181). I had to downgrade to HTTP/1.1 in order to use `HttpClient`.
>> 
>> I needed to resolve two minor conflicts in `MultiExchange.java` due to [JDK-8191494](https://bugs.openjdk.org/browse/JDK-8191494) being applied slightly differently in different projects. In both cases, I kept the change closer to upstream.
>> 
>> The conflicts were:
>> * Explicit vs implicit null field initialization
>> * Different debug log message
>> 
>> I was unable to run local tests due to this error:
>> 
>> * For target jdk__optimize_image_exec:
>> Error: Unable to initialize main class build.tools.jigsaw.AddPackagesAttribute
>> Caused by: java.lang.ClassFormatError: StackMapTable format error: access beyond the end of attribute
>> 
>> 
>> However, all tests in the GitHub actions have passed.
>
> Hello Ryan,
> 
>> I was unable to run local tests due to this error:
>> 
>> ```
>> * For target jdk__optimize_image_exec:
>> Error: Unable to initialize main class build.tools.jigsaw.AddPackagesAttribute
>> Caused by: java.lang.ClassFormatError: StackMapTable format error: access beyond the end of attribute
>> ```
> 
> If you are on macosx and using Xcode 16 then I suspect you are running into the issue noted in https://mail.openjdk.org/pipermail/jdk-dev/2024-September/009400.html

Thanks @jaikiran. That's almost certainly what the issue is. I'll downgrade to XCode 15.4 and give the tier2 tests another try.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1020#issuecomment-2397247698