[jdk21u-dev] RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v2]
Goetz Lindenmaier
goetz at openjdk.org
Fri Oct 11 13:14:16 UTC 2024
On Mon, 7 Oct 2024 09:09:20 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
>> I backport this for parity with 21.0.6-oracle.
>>
>> As the CSR for 21 says, I omit the specification changes.
>> These make the description more precise. As I understand,
>> the change brought to 21 is ok with the broader, unchanged
>> specification.
>>
>> The rest applied clean.
>
> Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>
> Backport 7bf1989f59695c3d08b4bd116fb4c022cf9661f4
Hi Weibing,
thanks for having a look!
Well, the comment of three methods got changed but only one has code changes. At least the public commit https://github.com/openjdk/jdk/commit/7bf1989f59695c3d08b4bd116fb4c022cf9661f4 touches only the code of getGenericParameterTypes().
I omitted the comments on purpose because the[ CSR for 21 8337480](https://bugs.openjdk.org/browse/JDK-8337480) does not mention the comment change as the [original one 8321819](https://bugs.openjdk.org/browse/JDK-8321819) does. Also, I read the discussion in the comments like that.
So you are saying you backported all the comments to 21? If so. I'll add them, too.
Thanks, Goetz
-------------
PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1026#issuecomment-2407386633
More information about the jdk-updates-dev
mailing list