[jdk11u-dev] RFR: 8224624: Inefficiencies in CodeStrings::add_comment cause timeouts [v2]

SendaoYan syan at openjdk.org
Tue Oct 15 06:17:48 UTC 2024


> Hi all,
> This is prefix backport of [JDK-8231058](https://bugs.openjdk.org/browse/JDK-8231058), after apply this backport will make backport of [JDK-8231058](https://bugs.openjdk.org/browse/JDK-8231058) cleanly.
> This PR improves C1 compiled time of the test `compiler/c1/TestLinearScanOrderMain.java` method dramatically from [92s to 1.8s](https://bugs.openjdk.org/browse/JDK-8224624), and solve this test intermittent timeout.
> 
> Additonal testing:
> 
> - [x] linux aarch64 build with release/slowdebug configure
> - [x] linux x86_64 build with release/slowdebug configure
> - [x] jtreg tests(include tier1/2/3 etc.) with release build on linux aarch64
> - [x] jtreg tests(include tier1/2/3 etc.) with release build on linux x86_64

SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'openjdk:master' into jbs8224624
 - 8224624: Inefficiencies in CodeStrings::add_comment cause timeouts
   
   Changing CodeStrings to a doubly-linked-list and searching for the comment with the right offset in reverse.
   
   Reviewed-by: kvn

-------------

Changes:
  - all: https://git.openjdk.org/jdk11u-dev/pull/2951/files
  - new: https://git.openjdk.org/jdk11u-dev/pull/2951/files/97890d56..4f859b8d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2951&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2951&range=00-01

  Stats: 3570 lines in 69 files changed: 2545 ins; 554 del; 471 mod
  Patch: https://git.openjdk.org/jdk11u-dev/pull/2951.diff
  Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2951/head:pull/2951

PR: https://git.openjdk.org/jdk11u-dev/pull/2951


More information about the jdk-updates-dev mailing list