[jdk21u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v2]

[Steven Loomis]

On Thu, 17 Oct 2024 07:16:30 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Steven Loomis has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   8342073: Call to insertText with single character from custom Input Method ignored
>>   
>>   - Backport of JDK-8195675
>>   - Backport of https://github.com/openjdk/jdk/commit/b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd
>>   
>>   Reviewed-by: prr
>>   (cherry picked from commit b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd)
>
> Hi,
> what tests did you run to 
> 1. assure this fixes the issue in 21, too.
> 2. you do not introduce a regression in 21 ?
> Usually you mention this in the Fix request comment (which you can edit). You can also 
> get the comment replaced by issueing a new approval command here in the PR if the first comment was generated by the command, too.

@GoeLin thanks.  The issue was filed against JDK 8 and was present in current main also. So there is that.

As to testing, it seems on Mac Sonoma I'm currently unable to build any of the repos (even the one I used to test when merging months ago.). Various issues.  I will keep trying, though.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1052#issuecomment-2420428689