[jdk23u] RFR: 8339637: (tz) Update Timezone Data to 2024b [v3]
Sean Coffey
coffeys at openjdk.org
Fri Oct 18 14:05:30 UTC 2024
On Fri, 18 Oct 2024 13:40:50 GMT, Johny Jose <duke at openjdk.org> wrote:
>> Backport of tz2024b changes (https://git.openjdk.org/jdk/commit/ebc17c7c8d6febd5a887309d1b7a466bcd2cc0a9)
>>
>> Not clean backport as the spec changes made in mainline is not backported to jdk23u. TZdata2024 changes announced on 5th September 2024 includes changes to "EST", "MST", and "HST", i.e., changing those time zones from distinct time zones to links to other time zones. For update releases, will not make the same ZoneId changes due to current specification.
>
> Johny Jose has updated the pull request incrementally with one additional commit since the last revision:
>
> Review changes
minor formatting comments. Looks good otherwise.
test/jdk/java/util/TimeZone/Bug6329116.java line 155:
> 153: */
> 154: continue;
> 155:
don't think any edits are required to this file ? Can you "git restore" this one ?
test/jdk/sun/util/calendar/zi/TestZoneInfo310.java line 53:
> 51: String tzfiles = "africa antarctica asia australasia europe northamerica southamerica backward etcetera gmt";
> 52: Path jdk_tzdir = Paths.get(System.getProperty("test.src"), "tzdata_jdk");
> 53: // tz2024b_overridden_zones file is created to preserve the behaviour of "EST", "MST", and "HST" when timezone 2024b changes are applied
split this comment over 2 lines please
-------------
PR Review: https://git.openjdk.org/jdk23u/pull/191#pullrequestreview-2378149215
PR Review Comment: https://git.openjdk.org/jdk23u/pull/191#discussion_r1806536012
PR Review Comment: https://git.openjdk.org/jdk23u/pull/191#discussion_r1806537767
More information about the jdk-updates-dev
mailing list