[jdk17u-dev] RFR: 8315097: Rename createJavaProcessBuilder [v3]
Goetz Lindenmaier
goetz at openjdk.org
Mon Oct 21 08:04:06 UTC 2024
On Fri, 18 Oct 2024 14:15:06 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
>> Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>>
>> Fix one file missed
>
> test/hotspot/jtreg/gc/arguments/TestArrayAllocatorMallocLimit.java line 54:
>
>> 52:
>> 53: public static void testDefaultValue() throws Exception {
>> 54: ProcessBuilder pb = GCArguments.createLimitedTestJavaProcessBuilder(
>
> Shouldn't this one read createTestJavaProcessBuilder, as in all other occurences?
Hi Lutz,
yes, you are right! But I spoiled this already in the backport to 21, so I'll fix it there in a follow-up.
I files https://bugs.openjdk.org/browse/JDK-8342669 [21u] Fix TestArrayAllocatorMallocLimit after backport of JDK-8315097
Thanks for addressing this tedious review!
-------------
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2960#discussion_r1808288341
More information about the jdk-updates-dev
mailing list