[jdk17u-dev] RFR: 8315097: Rename createJavaProcessBuilder [v4]

[Lutz Schmidt]

On Mon, 21 Oct 2024 08:13:09 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> This backport is based on the 21 version.
>> 
>> A lot of files can be patched clean.
>> Others had to be resolved.
>> I split the change into four commits:
>> 1. The hunks that applied clean.
>> 2. The test files I resolved. Details below.
>> 3. The parts of ProcessTools.java I had to resolve
>> 4. The files I had to fix in addition so all calls to the old method are removed
>> 
>> *The tests resolved:*
>> https://github.com/openjdk/jdk21u-dev/commits/master/test/hotspot/jtreg/compiler/ciReplay/CiReplayBase.java
>> Resolved.
>> https://github.com/openjdk/jdk21u-dev/commits/master/test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java
>> Resolve, but double check on 8279573: compiler/codecache/CodeCacheFullCountTest.java fails with "RuntimeException: the value of full_count is wrong."
>> https://github.com/openjdk/jdk21u-dev/commits/master/test/hotspot/jtreg/compiler/jvmci/TestEnableJVMCIProduct.java
>> Resolved.
>> https://github.com/openjdk/jdk21u-dev/commits/master/test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestHotSpotJVMCIRuntime.java
>> Omitted because 8306992: [JVMCI] mitigate more against JVMCI related OOME causing VM to exit is not in 17.
>> 
>> https://github.com/openjdk/jdk21u-dev/commits/master/test/hotspot/jtreg/gc/arguments/TestVerifyBeforeAndAfterGCFlags.java
>> Resolved because 8270991: G1 Full GC always performs heap verification after JDK-8269295 is not in 17.
>> https://github.com/openjdk/jdk21u-dev/commits/master/test/hotspot/jtreg/gc/g1/TestGCLogMessages.java
>> Resolved.
>> https://github.com/openjdk/jdk21u-dev/commits/master/test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java
>> Resolved copyright only.
>> https://github.com/openjdk/jdk21u-dev/commits/master/test/hotspot/jtreg/gc/g1/TestMixedGCLiveThreshold.java
>> Resolved copyright only.
>> 
>> https://github.com/openjdk/jdk21u-dev/commits/master/test/hotspot/jtreg/runtime/ClassFile/JsrRewriting.java
>> Resolved.
>> https://github.com/openjdk/jdk21u-dev/commits/master/test/hotspot/jtreg/runtime/ClassFile/OomWhileParsingRepeatedJsr.java
>> Resolved.
>> https://github.com/openjdk/jdk21u-dev/commits/master/test/hotspot/jtreg/runtime/ErrorHandling/SecondaryErrorTest.java
>> Resolved.
>> https://github.com/openjdk/jdk21u-dev/commits/master/test/hotspot/jtreg/runtime/LoadClass/TestResize.java
>> Resolved.
>> https://github.com/openjdk/jdk21u-dev/commits/master/test/hotspot/jtreg/runtime/LocalLong/LocalLongTest.java
>> Resolved.
>> https://github.com/openjdk/jdk21u-de...
>
> Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into goetz_backport_8315097-2
>  - Fix one file missed
>  - Fix files that call createJavaProcessBuilder but are not in 21.
>  - Resolved ProcessTools.java
>  - Resolved test files
>  - Changes that applied clean

With the finding being fixed by a separate bug/PR/backport, I approve this PR. Please make sure the follow-up arrives in jdk17u-dev asap. This PR and the follow-up shall be contained in the same update release.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2960#pullrequestreview-2381423100