From andrewlu at openjdk.org Mon Sep 2 02:26:22 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 2 Sep 2024 02:26:22 GMT Subject: [jdk11u-dev] Integrated: 8328300: Convert PrintDialogsTest.java from Applet to main program In-Reply-To: <4mwxOZNEsaB1EO36Re1hZ9HtfazQBXyDDe6U5qe4JhU=.f37968f0-0502-4f32-a9a6-dba66522a9e4@github.com> References: <4mwxOZNEsaB1EO36Re1hZ9HtfazQBXyDDe6U5qe4JhU=.f37968f0-0502-4f32-a9a6-dba66522a9e4@github.com> Message-ID: On Thu, 1 Aug 2024 05:51:08 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. > text block modified as not supported. This pull request has now been integrated. Changeset: 8c31358c Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/8c31358ccc9d07f9512bc56159c85ce465e25135 Stats: 126 lines in 2 files changed: 64 ins; 52 del; 10 mod 8328300: Convert PrintDialogsTest.java from Applet to main program Reviewed-by: mbaesken Backport-of: dea94f4445b9389339cf7ca0eef688ca56c17814 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2892 From andrewlu at openjdk.org Mon Sep 2 02:27:36 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 2 Sep 2024 02:27:36 GMT Subject: [jdk11u-dev] Integrated: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 10:34:00 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has now been integrated. Changeset: ffcdc104 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/ffcdc104058ab2b58d8303f318c2e0ee0dc93a54 Stats: 45 lines in 1 file changed: 35 ins; 6 del; 4 mod 8315936: Parallelize gc/stress/TestStressG1Humongous.java test Backport-of: 3f19df685c342cef212305cca630331878a24e79 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2908 From andrewlu at openjdk.org Mon Sep 2 02:27:37 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 2 Sep 2024 02:27:37 GMT Subject: [jdk11u-dev] Integrated: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main In-Reply-To: References: Message-ID: <12WB6AHbo3Jsl3I-JcOx1ij1LN8NVO3GSHIhD-8RGmg=.6ef7cc6f-6130-4ed7-80bc-2cc9e4a58807@github.com> On Thu, 1 Aug 2024 02:29:56 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. > text block modified as not supported. This pull request has now been integrated. Changeset: 76b8327b Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/76b8327ba08e2d57b64cd266a3eb3f1a3232a1a5 Stats: 284 lines in 2 files changed: 46 ins; 211 del; 27 mod 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main Reviewed-by: mbaesken Backport-of: ab183e437c18b445e9c022a4d74de818d4ccecbe ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2891 From goetz at openjdk.org Mon Sep 2 06:17:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Sep 2024 06:17:31 GMT Subject: [jdk21u] RFR: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods In-Reply-To: References: Message-ID: On Fri, 30 Aug 2024 15:43:11 GMT, Goetz Lindenmaier wrote: > A backport to jdk21u as this fixes a jck issue. > > I had to remove the namespace from LogConfiguration::StdoutLog as JDK-8299825 is not in 21. > I also had to adapt TestVerboseClassLoading, as 'cause' is not known to the logging in 21. > > Tests fail as expected, and passes with the fix. GHA failure: TEST: serviceability/sa/ClhsdbFindPC.java#no-xcomp-process Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Test ERROR java.lang.RuntimeException: '^sun.jvm.hotspot.debugger.DebuggerException:.*$' found in stderr: 'sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to be a HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote process)' Linkage problem, surely unrelated to my change that does not touch this symbol. Was there some old binary somewhere? Will trigger retest. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/449#issuecomment-2323895074 From jwtang at openjdk.org Mon Sep 2 06:28:28 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Mon, 2 Sep 2024 06:28:28 GMT Subject: [jdk21u-dev] RFR: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 08:26:00 GMT, Jiawei Tang wrote: > 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option Hi, could I get help for this approval? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/910#issuecomment-2323910019 From goetz at openjdk.org Mon Sep 2 08:08:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Sep 2024 08:08:06 GMT Subject: [jdk17u] RFR: 8338139: {ClassLoading, Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods Message-ID: A backport to jdk17u as this fixes a jck issue. Based on the commit to 21. Will fix the title after pushing change to 21 to point to 21 commit. The change of 21 does not apply clean: src/hotspot/share/services/classLoadingService.cpp Copyright src/hotspot/share/services/classLoadingService.hpp Resolved due to context src/hotspot/share/services/memoryService.cpp Copyright To make it compile, I had to adapt StdoutLog again, as "8293873: Centralize the initialization of UL" is not in 17. See extra commit. The new tests pass and fail as expected without the fix. ------------- Commit messages: - Fix build - Backport 9775d57168695dc0d758e017fe5069d93d593f3e Changes: https://git.openjdk.org/jdk17u/pull/394/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=394&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338139 Stats: 204 lines in 6 files changed: 198 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk17u/pull/394.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/394/head:pull/394 PR: https://git.openjdk.org/jdk17u/pull/394 From mdoerr at openjdk.org Mon Sep 2 08:28:25 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 2 Sep 2024 08:28:25 GMT Subject: [jdk21u] RFR: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods In-Reply-To: References: Message-ID: On Fri, 30 Aug 2024 15:43:11 GMT, Goetz Lindenmaier wrote: > A backport to jdk21u as this fixes a jck issue. > > I had to remove the namespace from LogConfiguration::StdoutLog as JDK-8299825 is not in 21. > I also had to adapt TestVerboseClassLoading, as 'cause' is not known to the logging in 21. > > Tests fail as expected, and passes with the fix. LGTM. Thanks for backporting and your explanations! ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u/pull/449#pullrequestreview-2275001105 From andrewlu at openjdk.org Mon Sep 2 09:11:29 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 2 Sep 2024 09:11:29 GMT Subject: [jdk11u-dev] Withdrawn: 8257534: misc tests failed with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom" In-Reply-To: <3zMVQwjZ5QOADXFfewgtXJKPegW4Ch5CSRYsO5ODrqE=.5bb699ff-8ba1-40ad-a959-90e2789bbdb4@github.com> References: <3zMVQwjZ5QOADXFfewgtXJKPegW4Ch5CSRYsO5ODrqE=.5bb699ff-8ba1-40ad-a959-90e2789bbdb4@github.com> Message-ID: On Fri, 9 Aug 2024 08:21:18 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2901 From andrewlu at openjdk.org Mon Sep 2 09:11:31 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 2 Sep 2024 09:11:31 GMT Subject: [jdk11u-dev] Withdrawn: 8209362: sun/security/ssl/SSLSocketImpl/ReuseAddr.java failed due to "BindException: Address already in use (Bind failed)" In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 08:09:16 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. > test/jdk/javax/net/ssl/templates/SSLSocketTemplate.java > "protected volatile int serverPort = 0;" > "protected void doServerSide() throws Exception" > already protected, no need to change, make it clean. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2884 From andrewlu at openjdk.org Mon Sep 2 09:12:23 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 2 Sep 2024 09:12:23 GMT Subject: [jdk11u-dev] Withdrawn: 8278312: Update SimpleSSLContext keystore to use SANs for localhost IP addresses In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 08:40:53 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2903 From andrewlu at openjdk.org Mon Sep 2 09:12:23 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 2 Sep 2024 09:12:23 GMT Subject: [jdk11u-dev] Withdrawn: 8220673: Add test library support for determining platform IP support In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 05:33:46 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. > these tests are not clean, but all added code is clean > test/jdk/java/net/NetworkInterface/Test.java > test/jdk/java/net/Socket/CloseAvailable.java > test/jdk/java/net/Socket/HttpProxy.java > test/jdk/java/net/Socket/SetSoLinger.java > test/jdk/java/nio/channels/DatagramChannel/Disconnect.java > > this class is not exist, ignore, other classes are clean > test/jdk/java/nio/channels/etc/PrintSupportedOptions.java > > As https://bugs.openjdk.org/browse/JDK-8239355 is already backported, https://github.com/openjdk/jdk11u-dev/commit/f4288be071133267f3647475c510be4d77dcf608 > so not modify the test/lib/jdk/test/lib/net/IPSupport.java > it missed to backported to modify the test/jdk/java/net/IPSupport/MinimumPermissions.policy > so here edit it. > > also add backport for https://bugs.openjdk.org/browse/JDK-8223652 > otherwise other tests will fail due to the throwSkippedExceptionIfNonOperational() change This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2910 From andrewlu at openjdk.org Mon Sep 2 09:13:21 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 2 Sep 2024 09:13:21 GMT Subject: [jdk11u-dev] Withdrawn: 8266161: mark hotspot compiler/rtm tests which ignore VM flags In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 06:01:33 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2911 From shade at openjdk.org Mon Sep 2 09:34:29 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 2 Sep 2024 09:34:29 GMT Subject: [jdk17u-dev] RFR: 8337684: [17/11u] Revert JDK-8163921 backport [v2] In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 09:41:53 GMT, Severin Gehwolf wrote: > @GoeLin What's your take on this? If we revert, we should probably get it in soon. Also interested in this answer :) We missed the normal cutoff for October releases, but I can resubmit this PR as 17u-critical. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2775#issuecomment-2324270079 From goetz at openjdk.org Mon Sep 2 10:23:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Sep 2024 10:23:30 GMT Subject: [jdk17u-dev] RFR: 8337684: [17/11u] Revert JDK-8163921 backport [v2] In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 13:15:51 GMT, Aleksey Shipilev wrote: >> See the issue for more discussion and rationale. This is the actual code change, should we decide to go forward. >> >> This is a `git revert` of https://github.com/openjdk/jdk17u-dev/commit/b37df147b011b23b6c7474d726710e1478af7607. >> >> Additional testing: >> - [x] Linux AArch64 server fastdebug, `jdk_net` >> - [x] Linux AArch64 server fastdebug, `all` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8337684-revert-http-accept > - 8337684: [17/11u] Revert JDK-8163921 backport Has anybody else seen this, besides Amazon in its internal systems? I'm not so sure this is of relevance for everybody. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2775#issuecomment-2324369212 From sgehwolf at openjdk.org Mon Sep 2 11:08:48 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 2 Sep 2024 11:08:48 GMT Subject: [jdk21u] RFR: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) Message-ID: Clean backport to improve compatibility with JDK 21 versions which didn't support birth time. I.e. on those systems now last-modified-time is being returned when the `statx` syscall didn't fill in the birth time (is not supported for this filesystem). Proposing as a critical fix so as to get it into 21.0.5. CSR for 21-pool and 17-pool is the same as for JDK head, but would need a review before I can submit it. If anyone is willing to review it, I'd appreciate it. Thanks! ------------- Commit messages: - 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) Changes: https://git.openjdk.org/jdk21u/pull/450/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=450&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338696 Stats: 21 lines in 1 file changed: 12 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk21u/pull/450.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/450/head:pull/450 PR: https://git.openjdk.org/jdk21u/pull/450 From sgehwolf at openjdk.org Mon Sep 2 12:29:30 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 2 Sep 2024 12:29:30 GMT Subject: [jdk21u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases In-Reply-To: References: Message-ID: On Fri, 30 Aug 2024 21:32:42 GMT, Alexey Bakhtin wrote: > ? on older docker releases > > Please review the fix for regression on the old Docker versions (before v18.04). > > [JDK-8316304](https://bugs.openjdk.org/browse/JDK-8316304) was backported to JDK21, requiring statx syscall support. > In the old Docker versions, the default seccomp profile does not allow statx syscall and fails with EPERM error code. > Suggest fixing this issue by fallback to alternative implementation at runtime if syscall is not allowed. > > The same issue with copy_file_range syscall. > > The fix was initially submitted against upstream jdk ( https://github.com/openjdk/jdk/pull/20484 ) but after discussion submitted to JDK21 This seems to do more that what is says on the tin. Please explain if both fixes are needed or just the one for the relatively new `statx` issue. It's a work-around for an old Docker version. Since we introduced `statx` fairly recently it might be OK. src/java.base/linux/native/libnio/ch/FileDispatcherImpl.c line 75: > 73: } > 74: if (errno == EPERM) > 75: return IOS_UNSUPPORTED; This is unrelated to [JDK-8316304](https://bugs.openjdk.org/browse/JDK-8316304). If you want to fix this as well, then please as a separate patch. The bug speaks about JDK-8316304 and JDK-8316304 only. src/java.base/linux/native/libnio/ch/FileDispatcherImpl.c line 108: > 106: case ENOSYS: > 107: case EXDEV: > 108: case EPERM: This is unrelated to [JDK-8316304](https://bugs.openjdk.org/browse/JDK-8316304). If you want to fix this as well, then please as a separate patch. src/java.base/linux/native/libnio/fs/LinuxNativeDispatcher.c line 202: > 200: case ENOSYS: > 201: case EXDEV: > 202: case EPERM: This is unrelated to [JDK-8316304](https://bugs.openjdk.org/browse/JDK-8316304). If you want to fix this as well, then please as a separate patch. The bug speaks about JDK-8316304 and JDK-8316304 only. src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c line 690: > 688: copy_statx_attributes(env, &statx_buf, attrs); > 689: return 0; > 690: } else if (errno != ENOSYS && errno != EPERM) { I'd prefer if we only handled `EPERM` with a comment about the docker version issue. `ENOSYS` shouldn't happen since we test for `statx` availability in init() [here](https://github.com/openjdk/jdk21u-dev/blob/bd5b120f516db77c12233d53c8b834dda5b82a89/src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c#L432-L435). Also, we are in the `my_statx_func != NULL` branch. src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c line 722: > 720: copy_statx_attributes(env, &statx_buf, attrs); > 721: return; > 722: } else if (errno != ENOSYS && errno != EPERM) { Same here `EPERM` only, please. ------------- Changes requested by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/951#pullrequestreview-2275454313 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/951#discussion_r1740802598 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/951#discussion_r1740802346 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/951#discussion_r1740801426 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/951#discussion_r1740816249 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/951#discussion_r1740816791 From fyang at openjdk.org Mon Sep 2 12:46:27 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 2 Sep 2024 12:46:27 GMT Subject: [jdk23u] Integrated: 8337780: RISC-V: C2: Change C calling convention for sp to NS In-Reply-To: References: Message-ID: On Fri, 30 Aug 2024 01:30:17 GMT, Fei Yang wrote: > Clean backport of JDK-8337780 to reduce frame size by 16 bytes and improve performance for some C2 runtime stubs as we do not have to save sp on the method entry. Gtest & Tier1-3 tested on linux-riscv64 platform. This pull request has now been integrated. Changeset: 7bdece39 Author: Fei Yang URL: https://git.openjdk.org/jdk23u/commit/7bdece393887422a0c01d5c2529fcb84f6d13704 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8337780: RISC-V: C2: Change C calling convention for sp to NS Backport-of: 53db937dd0766695906dc20c1dbbd3228c02fe1e ------------- PR: https://git.openjdk.org/jdk23u/pull/87 From mbaesken at openjdk.org Mon Sep 2 12:53:25 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 2 Sep 2024 12:53:25 GMT Subject: [jdk23u] Integrated: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 08:13:54 GMT, Matthias Baesken wrote: > 8334567: [test] runtime/os/TestTracePageSizes move ppc handling This pull request has now been integrated. Changeset: 8cb44626 Author: Matthias Baesken URL: https://git.openjdk.org/jdk23u/commit/8cb44626ae6d0d08602b09e665ec49916d977d19 Stats: 12 lines in 1 file changed: 5 ins; 6 del; 1 mod 8334567: [test] runtime/os/TestTracePageSizes move ppc handling Backport-of: 6a5cb0b2c49cb390ce8b87fd977ee79572df90fc ------------- PR: https://git.openjdk.org/jdk23u/pull/86 From mbaesken at openjdk.org Mon Sep 2 12:57:19 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 2 Sep 2024 12:57:19 GMT Subject: [jdk23u] Integrated: 8333522: JFR SwapSpace event might read wrong free swap space size In-Reply-To: References: Message-ID: On Fri, 30 Aug 2024 13:01:19 GMT, Matthias Baesken wrote: > 8333522: JFR SwapSpace event might read wrong free swap space size This pull request has now been integrated. Changeset: ee1f2f6e Author: Matthias Baesken URL: https://git.openjdk.org/jdk23u/commit/ee1f2f6e48792995e6720a36a54e5ed826a9a9f0 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8333522: JFR SwapSpace event might read wrong free swap space size Backport-of: de55db2352f84c101f8197ee7aca80d72807fbc5 ------------- PR: https://git.openjdk.org/jdk23u/pull/88 From fyang at openjdk.org Mon Sep 2 13:44:28 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 2 Sep 2024 13:44:28 GMT Subject: [jdk21u-dev] Integrated: 8337780: RISC-V: C2: Change C calling convention for sp to NS In-Reply-To: References: Message-ID: On Sun, 25 Aug 2024 02:25:31 GMT, Fei Yang wrote: > Clean backport of JDK-8337780 to reduce frame size by 16 bytes and improve performance for some C2 runtime stubs as we do not have to save sp on the method entry. Gtest & Tier1-3 tested on linux-riscv64 platform. This pull request has now been integrated. Changeset: d78c446f Author: Fei Yang URL: https://git.openjdk.org/jdk21u-dev/commit/d78c446f1d17f30ed02cafbfdf10ae163061da7b Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8337780: RISC-V: C2: Change C calling convention for sp to NS Backport-of: 53db937dd0766695906dc20c1dbbd3228c02fe1e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/945 From fyang at openjdk.org Mon Sep 2 13:46:22 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 2 Sep 2024 13:46:22 GMT Subject: [jdk17u-dev] Integrated: 8337780: RISC-V: C2: Change C calling convention for sp to NS In-Reply-To: References: Message-ID: On Sun, 25 Aug 2024 02:25:33 GMT, Fei Yang wrote: > Clean backport of JDK-8337780 to reduce frame size by 16 bytes and improve performance for some C2 runtime stubs as we do not have to save sp on the method entry. Gtest & Tier1-3 tested on linux-riscv64 platform. This pull request has now been integrated. Changeset: 9150f50f Author: Fei Yang URL: https://git.openjdk.org/jdk17u-dev/commit/9150f50f85bbe7f8b4371eb7ea63e57cc74410a5 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8337780: RISC-V: C2: Change C calling convention for sp to NS Backport-of: 53db937dd0766695906dc20c1dbbd3228c02fe1e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2823 From sgehwolf at openjdk.org Mon Sep 2 14:05:18 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 2 Sep 2024 14:05:18 GMT Subject: [jdk21u] RFR: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 11:03:26 GMT, Severin Gehwolf wrote: > Clean backport to improve compatibility with JDK 21 versions which didn't support birth time. I.e. on those systems now last-modified-time is being returned when the `statx` syscall didn't fill in the birth time (is not supported for this filesystem). Proposing as a critical fix so as to get it into 21.0.5. > > CSR for 21-pool and 17-pool is the same as for JDK head, but would need a review before I can submit it. If anyone is willing to review it, I'd appreciate it. Thanks! MacosX aarch64 failure of [serviceability/sa/ClhsdbFindPC#no-xcomp-process](https://github.com/jerboaa/jdk21u/actions/runs/10665821124#user-content-serviceability_sa_clhsdbfindpc#no-xcomp-process) seems unrelated to this patch. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/450#issuecomment-2324832119 From mbaesken at openjdk.org Mon Sep 2 15:29:36 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 2 Sep 2024 15:29:36 GMT Subject: [jdk17u-dev] RFR: 8330464: hserr generic events - add entry for the before_exit calls Message-ID: Backport of 8330464, thread.cpp is changed in 17u-dev (other file) ------------- Commit messages: - Backport 45ed97f15b96071e5d6b6d21e8f0129eda5aa447 Changes: https://git.openjdk.org/jdk17u-dev/pull/2840/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2840&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330464 Stats: 7 lines in 2 files changed: 3 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2840.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2840/head:pull/2840 PR: https://git.openjdk.org/jdk17u-dev/pull/2840 From mbaesken at openjdk.org Mon Sep 2 15:32:20 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 2 Sep 2024 15:32:20 GMT Subject: [jdk17u-dev] Integrated: 8332589: ubsan: unix/native/libjava/ProcessImpl_md.c:562:5: runtime error: null pointer passed as argument 2, which is declared to never be null In-Reply-To: References: Message-ID: On Thu, 29 Aug 2024 12:09:04 GMT, Matthias Baesken wrote: > 8332589: ubsan: unix/native/libjava/ProcessImpl_md.c:562:5: runtime error: null pointer passed as argument 2, which is declared to never be null This pull request has now been integrated. Changeset: 90b0fb02 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/90b0fb02c7c678f30d0ae13524c29e6d20fd56f8 Stats: 12 lines in 1 file changed: 9 ins; 0 del; 3 mod 8332589: ubsan: unix/native/libjava/ProcessImpl_md.c:562:5: runtime error: null pointer passed as argument 2, which is declared to never be null Backport-of: 16dba04e8dfa871f8056480a42a9baeb24a2fb24 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2834 From mdoerr at openjdk.org Mon Sep 2 16:06:20 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 2 Sep 2024 16:06:20 GMT Subject: [jdk17u-dev] RFR: 8330464: hserr generic events - add entry for the before_exit calls In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 15:24:53 GMT, Matthias Baesken wrote: > Backport of 8330464, thread.cpp is changed in 17u-dev (other file) LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2840#pullrequestreview-2275945000 From zzambers at openjdk.org Mon Sep 2 16:08:53 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 2 Sep 2024 16:08:53 GMT Subject: [jdk23u] RFR: 8338402: GHA: some of bundles may not get removed Message-ID: Backport fixing problem, where some bundles may not get removed in GHA. GHA testing: OK (no leftover bundles) ------------- Commit messages: - Backport d8e4d3f2d6c187f2487acd390a4e5fa2a99010ea Changes: https://git.openjdk.org/jdk23u/pull/89/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=89&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338402 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/89.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/89/head:pull/89 PR: https://git.openjdk.org/jdk23u/pull/89 From zzambers at openjdk.org Mon Sep 2 16:14:40 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 2 Sep 2024 16:14:40 GMT Subject: [jdk17u-dev] RFR: 8338402: GHA: some of bundles may not get removed Message-ID: Backport fixing problem, where some bundles may not get removed in GHA. GHA testing: OK (no leftover bundles) ------------- Commit messages: - Backport d8e4d3f2d6c187f2487acd390a4e5fa2a99010ea Changes: https://git.openjdk.org/jdk17u-dev/pull/2841/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2841&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338402 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2841.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2841/head:pull/2841 PR: https://git.openjdk.org/jdk17u-dev/pull/2841 From zzambers at openjdk.org Mon Sep 2 16:14:43 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 2 Sep 2024 16:14:43 GMT Subject: [jdk21u-dev] RFR: 8338402: GHA: some of bundles may not get removed Message-ID: Backport fixing problem, where some bundles may not get removed in GHA. GHA testing: OK (no leftover bundles) ------------- Commit messages: - Backport d8e4d3f2d6c187f2487acd390a4e5fa2a99010ea Changes: https://git.openjdk.org/jdk21u-dev/pull/952/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=952&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338402 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/952.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/952/head:pull/952 PR: https://git.openjdk.org/jdk21u-dev/pull/952 From zzambers at openjdk.org Mon Sep 2 16:17:09 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 2 Sep 2024 16:17:09 GMT Subject: [jdk11u-dev] RFR: 8338402: GHA: some of bundles may not get removed Message-ID: Backport fixing problem, where some bundles may not get removed in GHA. GHA testing: OK (no leftover bundles, MacOS failures are unrelated) ------------- Commit messages: - Backport d8e4d3f2d6c187f2487acd390a4e5fa2a99010ea Changes: https://git.openjdk.org/jdk11u-dev/pull/2931/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2931&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338402 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2931.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2931/head:pull/2931 PR: https://git.openjdk.org/jdk11u-dev/pull/2931 From andrew at openjdk.org Mon Sep 2 16:48:25 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Sep 2024 16:48:25 GMT Subject: [jdk11u-dev] RFR: 8292177: InitialSecurityProperty JFR event In-Reply-To: References: Message-ID: On Sat, 29 Jun 2024 16:21:19 GMT, Andrew John Hughes wrote: > This backport introduces the JFR security event, `InitialSecurityProperty`, and along with it, the caching of the initial security properties which is also used by [JDK-8281658](https://bugs.openjdk.org/browse/JDK-8281658) to show the security properties with `-XshowSettings`. > > The change was backported to the Oracle fork of 11u in 11.0.20. > > The following changes were necessary for the backport: > > * `JavaSecurityPropertiesAccess` is moved to `jdk.internal.misc` where `SharedSecrets` lives in 11u > * `ensureClassInitialized` in `SharedSecrets` is called from the `unsafe` instance in 11u, as with other `get*Access()` methods in that class > * The patch to `module-info.java` is not needed as `jdk.jfr` already has access to `jdk.internal.misc` in 11u. The 17u addition is to `jdk.internal.access`. > * There are context differences in `JDKEvents.java` due to events introduced in later JDK versions. > * The `EventNames.java` test includes a huge unrelated change to reorganise the order of the variable modifiers. This was applied manually to the names in 11u, which differ slightly from those in 17u. > > All `jdk.jfr.event` tests passed, including the new one, with the exception of `TestNative`, but that seems to be a setup issue rather than a regression caused by this patch (`Error. Use -nativepath to specify the location of native code`) Still waiting for review. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2827#issuecomment-2325091863 From duke at openjdk.org Mon Sep 2 17:26:31 2024 From: duke at openjdk.org (duke) Date: Mon, 2 Sep 2024 17:26:31 GMT Subject: [jdk23u] RFR: 8335397: Improve reliability of TestRecursiveMonitorChurn.java [v3] In-Reply-To: References: <3pwEzQxTiZJbliKX3l1Y-v60JbKRh5qznRRty61UFnM=.31156468-b7ad-408e-a1da-a4b79cf257ef@github.com> Message-ID: On Thu, 29 Aug 2024 15:27:48 GMT, Mimoun Ghordou wrote: >> Clean Backport >> >> Tested open/test/hotspot/jtreg/runtime/locking/TestRecursiveMonitorChurn.java, works fine > > Mimoun Ghordou has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-8335397 > - 8336148: Test runtime/locking/TestRecursiveMonitorChurn.java failed: Unexpected Inflation > - 8335397: Improve reliability of TestRecursiveMonitorChurn.java @ghmaimon Your change (at version e664bc93ffebc2e49fdfab0474f4285a09c72f32) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/57#issuecomment-2325127272 From duke at openjdk.org Mon Sep 2 23:09:30 2024 From: duke at openjdk.org (Mimoun Ghordou) Date: Mon, 2 Sep 2024 23:09:30 GMT Subject: [jdk23u] Integrated: 8335397: Improve reliability of TestRecursiveMonitorChurn.java In-Reply-To: <3pwEzQxTiZJbliKX3l1Y-v60JbKRh5qznRRty61UFnM=.31156468-b7ad-408e-a1da-a4b79cf257ef@github.com> References: <3pwEzQxTiZJbliKX3l1Y-v60JbKRh5qznRRty61UFnM=.31156468-b7ad-408e-a1da-a4b79cf257ef@github.com> Message-ID: <9Q16i6ZfD6vAYFsIlQFV4pCFCVztqSgQB55lMqX8P4o=.4db98cf0-faad-4be0-a077-1a05e1fcc174@github.com> On Tue, 6 Aug 2024 14:50:35 GMT, Mimoun Ghordou wrote: > Clean Backport > > Tested open/test/hotspot/jtreg/runtime/locking/TestRecursiveMonitorChurn.java, works fine This pull request has now been integrated. Changeset: 3e4583b1 Author: Mimoun Ghordou Committer: Paul Hohensee URL: https://git.openjdk.org/jdk23u/commit/3e4583b12e8e07a338c3a639989fb0367813a171 Stats: 77 lines in 5 files changed: 30 ins; 21 del; 26 mod 8335397: Improve reliability of TestRecursiveMonitorChurn.java 8336148: Test runtime/locking/TestRecursiveMonitorChurn.java failed: Unexpected Inflation Reviewed-by: shade Backport-of: b20e8c8e85e0a0e96ae648f42ff803f1c83f6291 ------------- PR: https://git.openjdk.org/jdk23u/pull/57 From duke at openjdk.org Tue Sep 3 02:15:25 2024 From: duke at openjdk.org (duke) Date: Tue, 3 Sep 2024 02:15:25 GMT Subject: [jdk17u-dev] RFR: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs In-Reply-To: References: Message-ID: On Fri, 30 Aug 2024 06:35:08 GMT, Liang Mao wrote: > Clean backport of fix of soft-ref cleaning in Parallel Full GC. @mmyxym Your change (at version 1c68ee49bbf3fcdbfaf483f37718e2687cafeac1) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2838#issuecomment-2325475735 From xpeng at openjdk.org Tue Sep 3 05:04:27 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Tue, 3 Sep 2024 05:04:27 GMT Subject: [jdk17u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM [v2] In-Reply-To: References: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> Message-ID: <0tVYdGFs6O28GgtMVDPc7QBGeBDjQ7aXHAnxhIYW1as=.5edb7431-ee53-4ee4-a3fe-6ef3feecb131@github.com> On Mon, 19 Aug 2024 15:29:29 GMT, Xiaolong Peng wrote: >> Hi, >> This PR is a Backport of [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587): Shenandoah: ShenandoahLock should allow blocking in VM, the original commit was authored by Aleksey Shipilev on 21 Feb 2024 and was reviewed by Robbin Ehn and Roman Kennke, and already backported to jdk21. >> It is not a clean backport for JDK17 due to code style change(NULL -> nullptr) and thread header file and API changes. >> This is the first backport of a series of improvements for ShenandoahLock to improve contention issue which we I have seem in our customer's production load running with JDK17, here are the series of improvements I'm going to backport to JDK17: >> >> | Bug | Title | >> | ----------- | ---------------------------------------------- | >> | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | >> | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | >> | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | >> | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | >> >> >> Best, >> Xiaolong. >> >> >> Additional tests: >> - [x] hotspot_gc_shenandoah >> - [x] Linux x86_64 server fastdebug, all passes with -XX:+UseShenandoahGC > > Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: > > Use thread->as_Java_thread() instead of static_cast Thanks all for the reviews! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2797#issuecomment-2325605029 From duke at openjdk.org Tue Sep 3 05:04:27 2024 From: duke at openjdk.org (duke) Date: Tue, 3 Sep 2024 05:04:27 GMT Subject: [jdk17u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM [v2] In-Reply-To: References: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> Message-ID: On Mon, 19 Aug 2024 15:29:29 GMT, Xiaolong Peng wrote: >> Hi, >> This PR is a Backport of [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587): Shenandoah: ShenandoahLock should allow blocking in VM, the original commit was authored by Aleksey Shipilev on 21 Feb 2024 and was reviewed by Robbin Ehn and Roman Kennke, and already backported to jdk21. >> It is not a clean backport for JDK17 due to code style change(NULL -> nullptr) and thread header file and API changes. >> This is the first backport of a series of improvements for ShenandoahLock to improve contention issue which we I have seem in our customer's production load running with JDK17, here are the series of improvements I'm going to backport to JDK17: >> >> | Bug | Title | >> | ----------- | ---------------------------------------------- | >> | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | >> | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | >> | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | >> | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | >> >> >> Best, >> Xiaolong. >> >> >> Additional tests: >> - [x] hotspot_gc_shenandoah >> - [x] Linux x86_64 server fastdebug, all passes with -XX:+UseShenandoahGC > > Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: > > Use thread->as_Java_thread() instead of static_cast @pengxiaolong Your change (at version 22086ff28b9a797c3841a854b43dbaece8908530) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2797#issuecomment-2325606143 From goetz at openjdk.org Tue Sep 3 06:26:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Sep 2024 06:26:36 GMT Subject: [jdk21u] Integrated: 8338139: {ClassLoading, Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods In-Reply-To: References: Message-ID: On Fri, 30 Aug 2024 15:43:11 GMT, Goetz Lindenmaier wrote: > A backport to jdk21u as this fixes a jck issue. > > I had to remove the namespace from LogConfiguration::StdoutLog as JDK-8299825 is not in 21. > I also had to adapt TestVerboseClassLoading, as 'cause' is not known to the logging in 21. > > Tests fail as expected, and passes with the fix. This pull request has now been integrated. Changeset: 459757e3 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u/commit/459757e3777d61d7510518e88f76f66c08918161 Stats: 204 lines in 6 files changed: 198 ins; 2 del; 4 mod 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods Reviewed-by: mdoerr Backport-of: 9775d57168695dc0d758e017fe5069d93d593f3e ------------- PR: https://git.openjdk.org/jdk21u/pull/449 From mdoerr at openjdk.org Tue Sep 3 08:30:32 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 3 Sep 2024 08:30:32 GMT Subject: [jdk17u] RFR: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 08:00:33 GMT, Goetz Lindenmaier wrote: > A backport to jdk17u as this fixes a jck issue. Based on the commit to 21. > > The change of 21 does not apply clean: > src/hotspot/share/services/classLoadingService.cpp > Copyright > > src/hotspot/share/services/classLoadingService.hpp > Resolved due to context > > src/hotspot/share/services/memoryService.cpp > Copyright > > To make it compile, I had to adapt StdoutLog again, > as "8293873: Centralize the initialization of UL" is not in 17. > See extra commit. > > The new tests pass and fail as expected without the fix. LGTM. Thanks for backporting! ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u/pull/394#pullrequestreview-2276754848 From rvansa at openjdk.org Tue Sep 3 08:43:26 2024 From: rvansa at openjdk.org (Radim Vansa) Date: Tue, 3 Sep 2024 08:43:26 GMT Subject: [jdk17u-dev] RFR: 8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 15:16:04 GMT, Radim Vansa wrote: > Hi all, > > This pull request contains a backport of commit[ 02f79008](https://github.com/openjdk/jdk/commit/02f79008828b3dcce3bd6492efaa43e99376c0c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Albert Mingkun Yang on 15 Nov 2021 and was reviewed by Thomas Schatzl and Stefan Johansson. > > The backport is not clean; some method return types differ in later JDK versions. > > Thanks! The checks are now green (no changes, just rerun). ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2830#issuecomment-2325933753 From xpeng at openjdk.org Tue Sep 3 08:46:27 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Tue, 3 Sep 2024 08:46:27 GMT Subject: [jdk17u-dev] Integrated: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> References: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> Message-ID: On Tue, 13 Aug 2024 16:54:05 GMT, Xiaolong Peng wrote: > Hi, > This PR is a Backport of [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587): Shenandoah: ShenandoahLock should allow blocking in VM, the original commit was authored by Aleksey Shipilev on 21 Feb 2024 and was reviewed by Robbin Ehn and Roman Kennke, and already backported to jdk21. > It is not a clean backport for JDK17 due to code style change(NULL -> nullptr) and thread header file and API changes. > This is the first backport of a series of improvements for ShenandoahLock to improve contention issue which we I have seem in our customer's production load running with JDK17, here are the series of improvements I'm going to backport to JDK17: > > | Bug | Title | > | ----------- | ---------------------------------------------- | > | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | > | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | > | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | > | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | > > > Best, > Xiaolong. > > > Additional tests: > - [x] hotspot_gc_shenandoah > - [x] Linux x86_64 server fastdebug, all passes with -XX:+UseShenandoahGC This pull request has now been integrated. Changeset: dc69e059 Author: Xiaolong Peng URL: https://git.openjdk.org/jdk17u-dev/commit/dc69e059b16414c40ca9eabca136e71ed7bd1793 Stats: 67 lines in 3 files changed: 48 ins; 1 del; 18 mod 8325587: Shenandoah: ShenandoahLock should allow blocking in VM Reviewed-by: shade, phh Backport-of: 492e8bf563135d27b46fde198880e62d5f1940e8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2797 From gcao at openjdk.org Tue Sep 3 10:05:01 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 3 Sep 2024 10:05:01 GMT Subject: [jdk21u-dev] RFR: 8339248: RISC-V: Remove li64 macro assembler routine and related code Message-ID: <-alBH9YZdl2mMx2y0GeaXJL-6CRvgO_MJ3jpLJZcCSA=.ba085485-1bab-460b-9de8-7b13636a32f1@github.com> Hi, The same issue also exists in jdk21u-dev. So I would like to backport [JDK-8339248](https://bugs.openjdk.org/browse/JDK-8339248) to jdk21u-dev. with this patch ,it will save us some unnecessary runtime checks. RISC-V specific change, risk is low. ### Testing - [x] Run hotspot:tier1 tests on SOPHON SG2042 (fastdebug) ------------- Commit messages: - Backport 8339248: RISC-V: Remove li64 macro assembler routine and related code Changes: https://git.openjdk.org/jdk21u-dev/pull/953/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=953&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339248 Stats: 111 lines in 4 files changed: 0 ins; 111 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/953.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/953/head:pull/953 PR: https://git.openjdk.org/jdk21u-dev/pull/953 From gcao at openjdk.org Tue Sep 3 10:14:50 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 3 Sep 2024 10:14:50 GMT Subject: [jdk23u] RFR: 8339248: RISC-V: Remove li64 macro assembler routine and related code Message-ID: <-ZIvzs-Yyd-INw0l4-UZIxiPITPzt-fMRPdu_2INa3A=.99942ad4-afff-4a3d-920d-b012b97497b3@github.com> Hi, The same issue also exists in jdk23u. So I would like to backport [JDK-8339248](https://bugs.openjdk.org/browse/JDK-8339248) to jdk23u. with this patch ,it will save us some unnecessary runtime checks. This is a risc-v specific change. Backport is clean, risk is low. ### Testing - [x] Run hotspot:tier1 tests on SOPHON SG2042 (fastdebug) ------------- Commit messages: - Backport 392bdd5734e0ad4e616d52bb7bcafcf85dccbf34 Changes: https://git.openjdk.org/jdk23u/pull/90/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=90&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339248 Stats: 111 lines in 2 files changed: 0 ins; 111 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/90.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/90/head:pull/90 PR: https://git.openjdk.org/jdk23u/pull/90 From gcao at openjdk.org Tue Sep 3 10:19:57 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 3 Sep 2024 10:19:57 GMT Subject: [jdk17u-dev] RFR: 8339248: RISC-V: Remove li64 macro assembler routine and related code Message-ID: <2iWyVPMOkgY8vV9eKiY9NGggDALjZzSjm1ayVyuYOm4=.92f70a7b-cfc8-4837-aa40-9ea200686e12@github.com> Hi, The same issue also exists in jdk17u. So I would like to backport [JDK-8339248](https://bugs.openjdk.org/browse/JDK-8339248) to jdk17u-dev. with this patch ,it will save us some unnecessary runtime checks. This is a risc-v specific change, risk is low. ### Testing - [x] Run hotspot:tier1 tests on SOPHON SG2042 (release) ------------- Commit messages: - Backport 8339248: RISC-V: Remove li64 macro assembler routine and related code Changes: https://git.openjdk.org/jdk17u-dev/pull/2842/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2842&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339248 Stats: 111 lines in 4 files changed: 0 ins; 111 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2842.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2842/head:pull/2842 PR: https://git.openjdk.org/jdk17u-dev/pull/2842 From goetz at openjdk.org Tue Sep 3 10:23:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Sep 2024 10:23:31 GMT Subject: [jdk17u-dev] RFR: 8337684: [17/11u] Revert JDK-8163921 backport [v2] In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 09:31:31 GMT, Aleksey Shipilev wrote: >> @GoeLin What's your take on this? If we revert, we should probably get it in soon. > >> @GoeLin What's your take on this? If we revert, we should probably get it in soon. > > Also interested in this answer :) We missed the normal cutoff for October releases, but I can resubmit this PR as 17u-critical. Hi @shipilev What do you think about this? https://github.com/openjdk/jdk17u-dev/pull/2843 It implements what Daniel proposes in his comment in 8163921 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2775#issuecomment-2326151000 From goetz at openjdk.org Tue Sep 3 10:23:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Sep 2024 10:23:55 GMT Subject: [jdk17u-dev] RFR: 8339470: [17u] More defensive fix for 8163921 Message-ID: This does not remove the header specifications, it just fixes the error. Well, it removes * as type, but that is illegal and should be meant to match the same as */*. ------------- Commit messages: - 8339470: [17u] More defensive fix for 8163921 Changes: https://git.openjdk.org/jdk17u-dev/pull/2843/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2843&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339470 Stats: 10 lines in 2 files changed: 1 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2843.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2843/head:pull/2843 PR: https://git.openjdk.org/jdk17u-dev/pull/2843 From shade at openjdk.org Tue Sep 3 10:45:20 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 3 Sep 2024 10:45:20 GMT Subject: [jdk17u-dev] RFR: 8339470: [17u] More defensive fix for 8163921 In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 10:19:06 GMT, Goetz Lindenmaier wrote: > This does not remove the header specifications, it just fixes the error. > > Well, it removes * as type, but that is illegal and should be meant to match the same as */*. I think reverting to a known good state is better, as I mentioned here: https://bugs.openjdk.org/browse/JDK-8337684?focusedId=14695208#comment-14695208 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2843#issuecomment-2326197885 From goetz at openjdk.org Tue Sep 3 11:12:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Sep 2024 11:12:25 GMT Subject: [jdk17u-dev] RFR: 8339470: [17u] More defensive fix for 8163921 In-Reply-To: References: Message-ID: <6Wh9jbYe28ogyBwV4B6kZzdXwjmgCAXj5awZrEox2AM=.54428121-8022-417d-8c90-b60fb2006289@github.com> On Tue, 3 Sep 2024 10:19:06 GMT, Goetz Lindenmaier wrote: > This does not remove the header specifications, it just fixes the error. > > Well, it removes * as type, but that is illegal and should be meant to match the same as */*. Well, the question is whether that before really is a "good" state. It contains an error. The original bug JDK-8163921 lists some issues where the wrong syntax caused the header to be rejected. I don't think we should ignore this. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2843#issuecomment-2326249473 From fyang at openjdk.org Tue Sep 3 12:02:21 2024 From: fyang at openjdk.org (Fei Yang) Date: Tue, 3 Sep 2024 12:02:21 GMT Subject: [jdk17u-dev] RFR: 8339248: RISC-V: Remove li64 macro assembler routine and related code In-Reply-To: <2iWyVPMOkgY8vV9eKiY9NGggDALjZzSjm1ayVyuYOm4=.92f70a7b-cfc8-4837-aa40-9ea200686e12@github.com> References: <2iWyVPMOkgY8vV9eKiY9NGggDALjZzSjm1ayVyuYOm4=.92f70a7b-cfc8-4837-aa40-9ea200686e12@github.com> Message-ID: On Tue, 3 Sep 2024 10:13:49 GMT, Gui Cao wrote: > Hi, The same issue also exists in jdk17u. So I would like to backport [JDK-8339248](https://bugs.openjdk.org/browse/JDK-8339248) to jdk17u-dev. with this patch ,it will save us some unnecessary runtime checks. This is a risc-v specific change, risk is low. > > ### Testing > - [x] Run hotspot:tier1 tests on SOPHON SG2042 (release) LGTM. Thanks. ------------- Marked as reviewed by fyang (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2842#pullrequestreview-2277224086 From fyang at openjdk.org Tue Sep 3 12:02:25 2024 From: fyang at openjdk.org (Fei Yang) Date: Tue, 3 Sep 2024 12:02:25 GMT Subject: [jdk21u-dev] RFR: 8339248: RISC-V: Remove li64 macro assembler routine and related code In-Reply-To: <-alBH9YZdl2mMx2y0GeaXJL-6CRvgO_MJ3jpLJZcCSA=.ba085485-1bab-460b-9de8-7b13636a32f1@github.com> References: <-alBH9YZdl2mMx2y0GeaXJL-6CRvgO_MJ3jpLJZcCSA=.ba085485-1bab-460b-9de8-7b13636a32f1@github.com> Message-ID: On Tue, 3 Sep 2024 09:58:52 GMT, Gui Cao wrote: > Hi, The same issue also exists in jdk21u-dev. So I would like to backport [JDK-8339248](https://bugs.openjdk.org/browse/JDK-8339248) to jdk21u-dev. with this patch ,it will save us some unnecessary runtime checks. RISC-V specific change, risk is low. > > ### Testing > - [x] Run hotspot:tier1 tests on SOPHON SG2042 (fastdebug) LGTM. Thanks. ------------- Marked as reviewed by fyang (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/953#pullrequestreview-2277223494 From goetz at openjdk.org Tue Sep 3 12:31:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Sep 2024 12:31:36 GMT Subject: [jdk17u-dev] RFR: 8271456: Avoid looking up standard charsets in "java.desktop" module Message-ID: <7S58sbZVuWV2e74Yc304nlpgEAs7cQuIN5hnLofV1TM=.45b4d0ee-018e-49f5-9fb8-4b21c93d479a@github.com> I backport this for parity with 17.0.14-oracle. I backport this share/classes/javax/swing/text/html/HTMLEditorKit.java Resolved imports. It did not apply because 17 imports SwingAccessor. src/java.desktop/share/classes/javax/swing/text/rtf/RTFReader.java Also resolved imports. src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java Copyright To make it compile, I added imports of java.util Classes to RTFReader.java. ------------- Commit messages: - Resolve and fix build - Backport 6b55ef3b58ae405c46f440e06b5adb03cec3a500 Changes: https://git.openjdk.org/jdk17u-dev/pull/2844/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2844&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8271456 Stats: 762 lines in 33 files changed: 339 ins; 269 del; 154 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2844.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2844/head:pull/2844 PR: https://git.openjdk.org/jdk17u-dev/pull/2844 From goetz at openjdk.org Tue Sep 3 12:44:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Sep 2024 12:44:28 GMT Subject: [jdk17u] RFR: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 08:00:33 GMT, Goetz Lindenmaier wrote: > A backport to jdk17u as this fixes a jck issue. Based on the commit to 21. > > The change of 21 does not apply clean: > src/hotspot/share/services/classLoadingService.cpp > Copyright > > src/hotspot/share/services/classLoadingService.hpp > Resolved due to context > > src/hotspot/share/services/memoryService.cpp > Copyright > > To make it compile, I had to adapt StdoutLog again, > as "8293873: Centralize the initialization of UL" is not in 17. > See extra commit. > > The new tests pass and fail as expected without the fix. Thanks for review and approval! ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/394#issuecomment-2326422542 From goetz at openjdk.org Tue Sep 3 12:44:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Sep 2024 12:44:30 GMT Subject: [jdk17u] Integrated: 8338139: {ClassLoading, Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 08:00:33 GMT, Goetz Lindenmaier wrote: > A backport to jdk17u as this fixes a jck issue. Based on the commit to 21. > > The change of 21 does not apply clean: > src/hotspot/share/services/classLoadingService.cpp > Copyright > > src/hotspot/share/services/classLoadingService.hpp > Resolved due to context > > src/hotspot/share/services/memoryService.cpp > Copyright > > To make it compile, I had to adapt StdoutLog again, > as "8293873: Centralize the initialization of UL" is not in 17. > See extra commit. > > The new tests pass and fail as expected without the fix. This pull request has now been integrated. Changeset: 897f433b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u/commit/897f433b33a46d56cc6972b1c6b4405ecaa4dea9 Stats: 204 lines in 6 files changed: 198 ins; 2 del; 4 mod 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods Reviewed-by: mdoerr Backport-of: 459757e3777d61d7510518e88f76f66c08918161 ------------- PR: https://git.openjdk.org/jdk17u/pull/394 From goetz at openjdk.org Tue Sep 3 12:55:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Sep 2024 12:55:53 GMT Subject: [jdk11u] RFR: 8338139: {ClassLoading, Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods Message-ID: <4tMn6TwJZbupgIDcklQECvXajb_cABZNxFOkZK3bNzw=.d1800d5e-cd54-4707-a5e9-b1c2a1b1ed5e@github.com> I backport this from 17. I had hoped it would be clean, but I had to adapt the nullptr literals in the .cpp files. Also, I had to resolve the copyright in all four hotspot files. ------------- Commit messages: - Backport 897f433b33a46d56cc6972b1c6b4405ecaa4dea9 Changes: https://git.openjdk.org/jdk11u/pull/94/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=94&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338139 Stats: 204 lines in 6 files changed: 198 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk11u/pull/94.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/94/head:pull/94 PR: https://git.openjdk.org/jdk11u/pull/94 From goetz at openjdk.org Tue Sep 3 13:32:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Sep 2024 13:32:27 GMT Subject: [jdk17u-dev] RFR: 8339470: [17u] More defensive fix for 8163921 In-Reply-To: References: Message-ID: <0X8gNgKZE92t92git1P4dwjxYMoMEeUEfMrIxhNBNfw=.a875487f-329f-4b2c-a8f3-206da8f87145@github.com> On Tue, 3 Sep 2024 10:19:06 GMT, Goetz Lindenmaier wrote: > This does not remove the header specifications, it just fixes the error. > > Well, it removes * as type, but that is illegal and should be meant to match the same as */*. GHA failure: serviceability/sa/ClhsdbFindPC.java#id2 RuntimeException: Unable to deduce type of thread from address 0x000000012d027e10 (expected type JavaThread, CompilerThread, MonitorDeflationThread, ServiceThread, JvmtiAgentThread or CodeCacheSweeperThread)' This is unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2843#issuecomment-2326533656 From goetz at openjdk.org Tue Sep 3 13:35:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Sep 2024 13:35:26 GMT Subject: [jdk17u-dev] RFR: 8271456: Avoid looking up standard charsets in "java.desktop" module In-Reply-To: <7S58sbZVuWV2e74Yc304nlpgEAs7cQuIN5hnLofV1TM=.45b4d0ee-018e-49f5-9fb8-4b21c93d479a@github.com> References: <7S58sbZVuWV2e74Yc304nlpgEAs7cQuIN5hnLofV1TM=.45b4d0ee-018e-49f5-9fb8-4b21c93d479a@github.com> Message-ID: On Tue, 3 Sep 2024 12:24:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > I backport this share/classes/javax/swing/text/html/HTMLEditorKit.java > Resolved imports. It did not apply because 17 imports SwingAccessor. > > src/java.desktop/share/classes/javax/swing/text/rtf/RTFReader.java > Also resolved imports. > > src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java > Copyright > > To make it compile, I added imports of java.util Classes to RTFReader.java. GHA failure: x64-hs-nopch: Connection failure of infra. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2844#issuecomment-2326539845 From goetz at openjdk.org Tue Sep 3 13:37:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Sep 2024 13:37:27 GMT Subject: [jdk11u] RFR: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods In-Reply-To: <4tMn6TwJZbupgIDcklQECvXajb_cABZNxFOkZK3bNzw=.d1800d5e-cd54-4707-a5e9-b1c2a1b1ed5e@github.com> References: <4tMn6TwJZbupgIDcklQECvXajb_cABZNxFOkZK3bNzw=.d1800d5e-cd54-4707-a5e9-b1c2a1b1ed5e@github.com> Message-ID: On Tue, 3 Sep 2024 12:48:46 GMT, Goetz Lindenmaier wrote: > I backport this from 17. I had hoped it would be clean, but I had to adapt the nullptr literals in the .cpp files. > > Also, I had to resolve the copyright in all four hotspot files. GHA failure: macos: Both have the sprintf build problem seen recently ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/94#issuecomment-2326544805 From phh at openjdk.org Tue Sep 3 14:29:26 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 3 Sep 2024 14:29:26 GMT Subject: [jdk11u-dev] RFR: 8292177: InitialSecurityProperty JFR event In-Reply-To: References: Message-ID: On Sat, 29 Jun 2024 16:21:19 GMT, Andrew John Hughes wrote: > This backport introduces the JFR security event, `InitialSecurityProperty`, and along with it, the caching of the initial security properties which is also used by [JDK-8281658](https://bugs.openjdk.org/browse/JDK-8281658) to show the security properties with `-XshowSettings`. > > The change was backported to the Oracle fork of 11u in 11.0.20. > > The following changes were necessary for the backport: > > * `JavaSecurityPropertiesAccess` is moved to `jdk.internal.misc` where `SharedSecrets` lives in 11u > * `ensureClassInitialized` in `SharedSecrets` is called from the `unsafe` instance in 11u, as with other `get*Access()` methods in that class > * The patch to `module-info.java` is not needed as `jdk.jfr` already has access to `jdk.internal.misc` in 11u. The 17u addition is to `jdk.internal.access`. > * There are context differences in `JDKEvents.java` due to events introduced in later JDK versions. > * The `EventNames.java` test includes a huge unrelated change to reorganise the order of the variable modifiers. This was applied manually to the names in 11u, which differ slightly from those in 17u. > > All `jdk.jfr.event` tests passed, including the new one, with the exception of `TestNative`, but that seems to be a setup issue rather than a regression caused by this patch (`Error. Use -nativepath to specify the location of native code`) Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2827#pullrequestreview-2277618734 From phh at openjdk.org Tue Sep 3 14:32:29 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 3 Sep 2024 14:32:29 GMT Subject: [jdk11u] RFR: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods In-Reply-To: <4tMn6TwJZbupgIDcklQECvXajb_cABZNxFOkZK3bNzw=.d1800d5e-cd54-4707-a5e9-b1c2a1b1ed5e@github.com> References: <4tMn6TwJZbupgIDcklQECvXajb_cABZNxFOkZK3bNzw=.d1800d5e-cd54-4707-a5e9-b1c2a1b1ed5e@github.com> Message-ID: On Tue, 3 Sep 2024 12:48:46 GMT, Goetz Lindenmaier wrote: > I backport this from 17. I had hoped it would be clean, but I had to adapt the nullptr literals in the .cpp files. > > Also, I had to resolve the copyright in all four hotspot files. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u/pull/94#pullrequestreview-2277630147 From phh at openjdk.org Tue Sep 3 15:01:26 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 3 Sep 2024 15:01:26 GMT Subject: [jdk17u-dev] RFR: 8271456: Avoid looking up standard charsets in "java.desktop" module In-Reply-To: <7S58sbZVuWV2e74Yc304nlpgEAs7cQuIN5hnLofV1TM=.45b4d0ee-018e-49f5-9fb8-4b21c93d479a@github.com> References: <7S58sbZVuWV2e74Yc304nlpgEAs7cQuIN5hnLofV1TM=.45b4d0ee-018e-49f5-9fb8-4b21c93d479a@github.com> Message-ID: On Tue, 3 Sep 2024 12:24:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > I backport this share/classes/javax/swing/text/html/HTMLEditorKit.java > Resolved imports. It did not apply because 17 imports SwingAccessor. > > src/java.desktop/share/classes/javax/swing/text/rtf/RTFReader.java > Also resolved imports. > > src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java > Copyright > > To make it compile, I added imports of java.util Classes to RTFReader.java. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2844#pullrequestreview-2277715245 From lmao at openjdk.org Tue Sep 3 15:09:21 2024 From: lmao at openjdk.org (Liang Mao) Date: Tue, 3 Sep 2024 15:09:21 GMT Subject: [jdk17u-dev] Integrated: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs In-Reply-To: References: Message-ID: <7nHkRJuj5Fzy7mAPzlwrTW_01uzjytikQu7J_WYg_Ng=.3eeb14b4-caf4-4682-9277-31aadeaa9d8f@github.com> On Fri, 30 Aug 2024 06:35:08 GMT, Liang Mao wrote: > Clean backport of fix of soft-ref cleaning in Parallel Full GC. This pull request has now been integrated. Changeset: d2cae5d4 Author: Liang Mao Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/d2cae5d4269f09c60851897e5b250e0cfe049adf Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs Backport-of: cff9e246cc2fbd3914f40bb71daa85dcf7731396 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2838 From phh at openjdk.org Tue Sep 3 15:09:24 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 3 Sep 2024 15:09:24 GMT Subject: [jdk21u-dev] RFR: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 08:26:00 GMT, Jiawei Tang wrote: > 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option This is a clean backport, so just issue the github comment "approval request " ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/910#issuecomment-2326768814 From phh at openjdk.org Tue Sep 3 15:20:29 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 3 Sep 2024 15:20:29 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v3] In-Reply-To: References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: On Fri, 30 Aug 2024 01:22:14 GMT, SendaoYan wrote: >> Hi, >> This is backport of [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023), this PR is prefixed PR of backport >> [JDK-8293503](https://github.com/openjdk/jdk17u-dev/pull/2431 ) >> >> Only change the testcase, the change has been verify on below binary: >> >> - [x] linux x64 release >> - [x] linux x64 fastdebug >> - [x] linux x86 release >> - [x] linux x86 fastdebug >> [linux-x64-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142005/linux-x64-fastdebug.log) >> [linux-x64-release.log](https://github.com/openjdk/jdk17u-dev/files/15142006/linux-x64-release.log) >> [linux-x86-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142007/linux-x86-fastdebug.log) >> [linux-x86-release.log](https://github.com/openjdk/jdk17u-dev/files/15142009/linux-x86-release.log) >> >> It's not clean backport: >> 1. test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR `8210708` before `8290023` jdk20 >> 2. There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev >> 3. test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported `8298073` and `8241293` after `8290023` in jdk17u-dev >> 4. test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR `8284161` before `8290023` in jdk20 > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8290023 > - Merge branch 'openjdk:master' into jbs8290023 > - Backport 2583feb21bf5419afc3c1953d964cf89d65fe8a2 > > Signed-off-by: sendaoYan Please remove copyright date updates that are not in the original commit, and use the latest copyright dates from the original commit rather than 2024. ------------- Changes requested by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2438#pullrequestreview-2277763091 From syan at openjdk.org Tue Sep 3 15:36:35 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 3 Sep 2024 15:36:35 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v4] In-Reply-To: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: > Hi, > This is backport of [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023), this PR is prefixed PR of backport > [JDK-8293503](https://github.com/openjdk/jdk17u-dev/pull/2431 ) > > Only change the testcase, the change has been verify on below binary: > > - [x] linux x64 release > - [x] linux x64 fastdebug > - [x] linux x86 release > - [x] linux x86 fastdebug > [linux-x64-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142005/linux-x64-fastdebug.log) > [linux-x64-release.log](https://github.com/openjdk/jdk17u-dev/files/15142006/linux-x64-release.log) > [linux-x86-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142007/linux-x86-fastdebug.log) > [linux-x86-release.log](https://github.com/openjdk/jdk17u-dev/files/15142009/linux-x86-release.log) > > It's not clean backport: > 1. test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR `8210708` before `8290023` jdk20 > 2. There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev > 3. test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported `8298073` and `8241293` after `8290023` in jdk17u-dev > 4. test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR `8284161` before `8290023` in jdk20 SendaoYan has updated the pull request incrementally with one additional commit since the last revision: revert the change of copyright year ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2438/files - new: https://git.openjdk.org/jdk17u-dev/pull/2438/files/a0e75cb0..7e86a2fb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=02-03 Stats: 11 lines in 11 files changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2438.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2438/head:pull/2438 PR: https://git.openjdk.org/jdk17u-dev/pull/2438 From syan at openjdk.org Tue Sep 3 15:41:39 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 3 Sep 2024 15:41:39 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v5] In-Reply-To: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: > Hi, > This is backport of [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023), this PR is prefixed PR of backport > [JDK-8293503](https://github.com/openjdk/jdk17u-dev/pull/2431 ) > > Only change the testcase, the change has been verify on below binary: > > - [x] linux x64 release > - [x] linux x64 fastdebug > - [x] linux x86 release > - [x] linux x86 fastdebug > [linux-x64-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142005/linux-x64-fastdebug.log) > [linux-x64-release.log](https://github.com/openjdk/jdk17u-dev/files/15142006/linux-x64-release.log) > [linux-x86-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142007/linux-x86-fastdebug.log) > [linux-x86-release.log](https://github.com/openjdk/jdk17u-dev/files/15142009/linux-x86-release.log) > > It's not clean backport: > 1. test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR `8210708` before `8290023` jdk20 > 2. There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev > 3. test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported `8298073` and `8241293` after `8290023` in jdk17u-dev > 4. test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR `8284161` before `8290023` in jdk20 SendaoYan has updated the pull request incrementally with one additional commit since the last revision: use the origin copyright year of backported PR for test/hotspot/jtreg/gc/metaspace/TestMetaspacePerfCounters.java ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2438/files - new: https://git.openjdk.org/jdk17u-dev/pull/2438/files/7e86a2fb..c4925b12 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=03-04 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2438.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2438/head:pull/2438 PR: https://git.openjdk.org/jdk17u-dev/pull/2438 From syan at openjdk.org Tue Sep 3 15:45:22 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 3 Sep 2024 15:45:22 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v3] In-Reply-To: References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: On Tue, 3 Sep 2024 15:17:54 GMT, Paul Hohensee wrote: > Please remove copyright date updates that are not in the original commit, and use the latest copyright dates from the original commit rather than 2024. Thanks for the review. The copyright mis-updates has been reverted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2438#issuecomment-2326851361 From syan at openjdk.org Tue Sep 3 15:55:42 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 3 Sep 2024 15:55:42 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v6] In-Reply-To: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: > Hi, > This is backport of [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023), this PR is prefixed PR of backport > [JDK-8293503](https://github.com/openjdk/jdk17u-dev/pull/2431 ) > > Only change the testcase, additional testing: > > - [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 release build > - [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 fastdebug build > - [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 release build > - [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 fastdebug build > > It's not clean backport: > 1. test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR `8210708` before `8290023` jdk20 > 2. There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev > 3. test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported `8298073` and `8241293` after `8290023` in jdk17u-dev > 4. test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR `8284161` before `8290023` in jdk20 SendaoYan has updated the pull request incrementally with one additional commit since the last revision: implement the backport of test/hotspot/jtreg/gc/shenandoah/TestVerifyJCStress.java ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2438/files - new: https://git.openjdk.org/jdk17u-dev/pull/2438/files/c4925b12..7bdea889 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=04-05 Stats: 15 lines in 1 file changed: 15 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2438.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2438/head:pull/2438 PR: https://git.openjdk.org/jdk17u-dev/pull/2438 From syan at openjdk.org Tue Sep 3 15:58:56 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 3 Sep 2024 15:58:56 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v7] In-Reply-To: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: > Hi, > This is backport of [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023), this PR is prefixed PR of backport > [JDK-8293503](https://github.com/openjdk/jdk17u-dev/pull/2431 ) > > Only change the testcase, additional testing: > > - [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 release build > - [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 fastdebug build > - [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 release build > - [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 fastdebug build > > It's not clean backport: > 1. test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR `8210708` before `8290023` jdk20 > 2. There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev > 3. test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported `8298073` and `8241293` after `8290023` in jdk17u-dev > 4. test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR `8284161` before `8290023` in jdk20 SendaoYan has updated the pull request incrementally with one additional commit since the last revision: implement the backport of test/hotspot/jtreg/gc/shenandoah/TestVerifyJCStress.java with an empty line ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2438/files - new: https://git.openjdk.org/jdk17u-dev/pull/2438/files/7bdea889..98df7caf Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=05-06 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2438.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2438/head:pull/2438 PR: https://git.openjdk.org/jdk17u-dev/pull/2438 From xpeng at openjdk.org Tue Sep 3 16:14:39 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Tue, 3 Sep 2024 16:14:39 GMT Subject: [jdk17u-dev] RFR: 8331405: Shenandoah: Optimize ShenandoahLock with TTAS Message-ID: Hi, This PR is a Backport of [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405): Shenandoah: Optimize ShenandoahLock with TTAS, the original commit was authored by Aleksey Shipilev on 2 May 2024 and was reviewed by Zhengyu Gu and Y. S. Ramakrishna, and it had already been backported to jdk21. It is a clean merge w/o any conflicts, overall risk should be very minimal given it is single line change to apply TTAS. Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: | Bug | Title | | ----------- | ---------------------------------------------- | | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | ### Additional test - [ ] Linux AArch64 server fastdebug, hotspot_gc_shenandoah ------------- Commit messages: - Backport c4fe5bf90c2d368c29714de63a90eca444fb3ece Changes: https://git.openjdk.org/jdk17u-dev/pull/2845/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2845&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331405 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2845.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2845/head:pull/2845 PR: https://git.openjdk.org/jdk17u-dev/pull/2845 From phh at openjdk.org Tue Sep 3 17:02:26 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 3 Sep 2024 17:02:26 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v7] In-Reply-To: References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: On Tue, 3 Sep 2024 15:58:56 GMT, SendaoYan wrote: >> Hi, >> This is backport of [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023), this PR is prefixed PR of backport >> [JDK-8293503](https://github.com/openjdk/jdk17u-dev/pull/2431 ) >> >> Only change the testcase, additional testing: >> >> - [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 release build >> - [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 fastdebug build >> - [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 release build >> - [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 fastdebug build >> >> It's not clean backport: >> 1. test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR `8210708` before `8290023` jdk20 >> 2. There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev >> 3. test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported `8298073` and `8241293` after `8290023` in jdk17u-dev >> 4. test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR `8284161` before `8290023` in jdk20 > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > implement the backport of test/hotspot/jtreg/gc/shenandoah/TestVerifyJCStress.java with an empty line Thank you. Ltgm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2438#pullrequestreview-2277999056 From abakhtin at openjdk.org Tue Sep 3 18:17:44 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 3 Sep 2024 18:17:44 GMT Subject: [jdk21u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases [v2] In-Reply-To: References: Message-ID: > ? on older docker releases > > Please review the fix for regression on the old Docker versions (before v18.04). > > [JDK-8316304](https://bugs.openjdk.org/browse/JDK-8316304) was backported to JDK21, requiring statx syscall support. > In the old Docker versions, the default seccomp profile does not allow statx syscall and fails with EPERM error code. > Suggest fixing this issue by fallback to alternative implementation at runtime if syscall is not allowed. > > The same issue with copy_file_range syscall. > > The fix was initially submitted against upstream jdk ( https://github.com/openjdk/jdk/pull/20484 ) but after discussion submitted to JDK21 Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: revert changes for copy_file_range and ENOSYS for statx ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/951/files - new: https://git.openjdk.org/jdk21u-dev/pull/951/files/bd5b120f..74acb11f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=951&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=951&range=00-01 Stats: 8 lines in 3 files changed: 0 ins; 4 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/951.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/951/head:pull/951 PR: https://git.openjdk.org/jdk21u-dev/pull/951 From abakhtin at openjdk.org Tue Sep 3 18:22:20 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 3 Sep 2024 18:22:20 GMT Subject: [jdk21u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases [v2] In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 12:26:47 GMT, Severin Gehwolf wrote: >> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: >> >> revert changes for copy_file_range and ENOSYS for statx > > This seems to do more that what is says on the tin. Please explain if both fixes are needed or just the one for the relatively new `statx` issue. > > It's a work-around for an old Docker version. Since we introduced `statx` fairly recently it might be OK. @jerboaa Thank you. Reverted copy_file_range and ENONSYS for statx ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/951#issuecomment-2327147391 From sgehwolf at openjdk.org Tue Sep 3 19:16:19 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 3 Sep 2024 19:16:19 GMT Subject: [jdk21u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases [v2] In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 18:17:44 GMT, Alexey Bakhtin wrote: >> ? on older docker releases >> >> Please review the fix for regression on the old Docker versions (before v18.04). >> >> [JDK-8316304](https://bugs.openjdk.org/browse/JDK-8316304) was backported to JDK21, requiring statx syscall support. >> In the old Docker versions, the default seccomp profile does not allow statx syscall and fails with EPERM error code. >> Suggest fixing this issue by fallback to alternative implementation at runtime if syscall is not allowed. >> >> The same issue with copy_file_range syscall. >> >> The fix was initially submitted against upstream jdk ( https://github.com/openjdk/jdk/pull/20484 ) but after discussion submitted to JDK21 > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > revert changes for copy_file_range and ENOSYS for statx We need comments why the `errno != EPERM` is there. ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/951#pullrequestreview-2278268964 From abakhtin at openjdk.org Tue Sep 3 19:48:42 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 3 Sep 2024 19:48:42 GMT Subject: [jdk21u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases [v3] In-Reply-To: References: Message-ID: > ? on older docker releases > > Please review the fix for regression on the old Docker versions (before v18.04). > > [JDK-8316304](https://bugs.openjdk.org/browse/JDK-8316304) was backported to JDK21, requiring statx syscall support. > In the old Docker versions, the default seccomp profile does not allow statx syscall and fails with EPERM error code. > Suggest fixing this issue by fallback to alternative implementation at runtime if syscall is not allowed. > > The same issue with copy_file_range syscall. > > The fix was initially submitted against upstream jdk ( https://github.com/openjdk/jdk/pull/20484 ) but after discussion submitted to JDK21 Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: added comments ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/951/files - new: https://git.openjdk.org/jdk21u-dev/pull/951/files/74acb11f..515fd7dd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=951&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=951&range=01-02 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/951.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/951/head:pull/951 PR: https://git.openjdk.org/jdk21u-dev/pull/951 From syan at openjdk.org Wed Sep 4 01:13:01 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 4 Sep 2024 01:13:01 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v8] In-Reply-To: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: > Hi, > This is backport of [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023), this PR is prefixed PR of backport > [JDK-8293503](https://github.com/openjdk/jdk17u-dev/pull/2431 ) > > Only change the testcase, additional testing: > > - [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 release build > - [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 fastdebug build > - [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 release build > - [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 fastdebug build > > It's not clean backport: > 1. test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR `8210708` before `8290023` jdk20 > 2. There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev > 3. test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported `8298073` and `8241293` after `8290023` in jdk17u-dev > 4. test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR `8284161` before `8290023` in jdk20 SendaoYan has updated the pull request incrementally with one additional commit since the last revision: backport JDK-8290269, to fix error: "TEST RESULT: Error. Parse Exception: Invalid tag: required" ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2438/files - new: https://git.openjdk.org/jdk17u-dev/pull/2438/files/98df7caf..4e0213bc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=07 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=06-07 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2438.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2438/head:pull/2438 PR: https://git.openjdk.org/jdk17u-dev/pull/2438 From syan at openjdk.org Wed Sep 4 01:17:26 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 4 Sep 2024 01:17:26 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v7] In-Reply-To: References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: On Tue, 3 Sep 2024 16:59:25 GMT, Paul Hohensee wrote: > Thank you. Ltgm. In [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023), there is a typo bug, which has been fixed by [JDK-8290269](https://bugs.openjdk.org/browse/JDK-8290269), I think we should include backport of [JDK-8290269](https://bugs.openjdk.org/browse/JDK-8290269) in this PR, the backport commit is [4e02](https://github.com/openjdk/jdk17u-dev/pull/2438/commits/4e0213bc9bf6237fa4155d804754bba63aa7ac6f). Can you review this PR again, thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2438#issuecomment-2327719215 From pkumaraswamy at openjdk.org Wed Sep 4 06:10:17 2024 From: pkumaraswamy at openjdk.org (Prajwal Kumaraswamy) Date: Wed, 4 Sep 2024 06:10:17 GMT Subject: [jdk23u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs Message-ID: This is a clean backport. Internal tests are green and related jck tests are green as well ------------- Commit messages: - Backport bbb516163d400a9c7e923e423fe2a60091b59322 Changes: https://git.openjdk.org/jdk23u/pull/91/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=91&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337664 Stats: 1103 lines in 13 files changed: 1101 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk23u/pull/91.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/91/head:pull/91 PR: https://git.openjdk.org/jdk23u/pull/91 From goetz at openjdk.org Wed Sep 4 06:51:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Sep 2024 06:51:36 GMT Subject: [jdk21u-dev] RFR: Merge jdk21u:master Message-ID: <0O9OvJT0it3rwfPupH3Vm8IjeZBHlh6tv9G1jH-oIzc=.45c3906a-f106-4c68-acf8-ab9c415064aa@github.com> Merge build tag 21.0.5+6 from jdk21u to jdk21u-dev ------------- Commit messages: - Merge - 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk21u-dev/pull/954/files Stats: 204 lines in 6 files changed: 198 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/954.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/954/head:pull/954 PR: https://git.openjdk.org/jdk21u-dev/pull/954 From goetz at openjdk.org Wed Sep 4 06:54:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Sep 2024 06:54:39 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master Message-ID: Merge build tag 17.0.13+6 from jdk17u to jdk17u-dev ------------- Commit messages: - Merge - 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk17u-dev/pull/2846/files Stats: 204 lines in 6 files changed: 198 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2846.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2846/head:pull/2846 PR: https://git.openjdk.org/jdk17u-dev/pull/2846 From duke at openjdk.org Wed Sep 4 08:13:27 2024 From: duke at openjdk.org (HempushpaSahu) Date: Wed, 4 Sep 2024 08:13:27 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: References: Message-ID: On Mon, 29 Jul 2024 22:18:42 GMT, Alexey Bakhtin wrote: >> Hello, I'd like to backport JDK-8179502 to JDK17u to improve the timeout adjustment for OCSP GET requests (which was missed in JDK-8179503). >> >> The backport is almost clean except for the following: >> - OCSP.java was merged manually because of JDK-8328638 and JDK-8329213 is already backported into 17u-dev >> - copyright year in GetPropertyAction.java and URICertStore.java files are updated manually >> - CRLReadTimeout.java test is updated manually because of the different notation of internal X509CRLImpl and CRLExtensions classes. >> >> All new and related jtreg tests are passed > > CSR [JDK-8337407](https://bugs.openjdk.org/browse/JDK-8337407) for JDK17 is created Hi @alexeybakhtin Is there any plan to merge this PR anytime soon? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#issuecomment-2328199486 From duke at openjdk.org Wed Sep 4 10:43:23 2024 From: duke at openjdk.org (duke) Date: Wed, 4 Sep 2024 10:43:23 GMT Subject: [jdk23u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Wed, 4 Sep 2024 06:04:07 GMT, Prajwal Kumaraswamy wrote: > This is a clean backport. > Internal tests are green and related jck tests are green as well @pkumaraswamy Your change (at version e168dceb9b4d23629b1e18ea68507233b8eaa70d) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/91#issuecomment-2328533749 From sgehwolf at openjdk.org Wed Sep 4 11:23:20 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 4 Sep 2024 11:23:20 GMT Subject: [jdk21u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases [v3] In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 19:48:42 GMT, Alexey Bakhtin wrote: >> ? on older docker releases >> >> Please review the fix for regression on the old Docker versions (before v18.04). >> >> [JDK-8316304](https://bugs.openjdk.org/browse/JDK-8316304) was backported to JDK21, requiring statx syscall support. >> In the old Docker versions, the default seccomp profile does not allow statx syscall and fails with EPERM error code. >> Suggest fixing this issue by fallback to alternative implementation at runtime if syscall is not allowed. >> >> The same issue with copy_file_range syscall. >> >> The fix was initially submitted against upstream jdk ( https://github.com/openjdk/jdk/pull/20484 ) but after discussion submitted to JDK21 > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > added comments This seems OK as a fix to improve compatibility with older JDK 21 versions that didn't use `statx`. Somebody else should review it too, though. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/951#pullrequestreview-2279822514 From mbaesken at openjdk.org Wed Sep 4 13:02:29 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 4 Sep 2024 13:02:29 GMT Subject: [jdk17u-dev] Integrated: 8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null In-Reply-To: References: Message-ID: On Thu, 29 Aug 2024 15:42:56 GMT, Matthias Baesken wrote: > 8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null This pull request has now been integrated. Changeset: d2e3de23 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/d2e3de236e583adcb2480db647cce759ec68824d Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null Backport-of: e529101ea30b49a6601088ce5ab81df590fc52f0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2835 From aph at openjdk.org Wed Sep 4 13:27:26 2024 From: aph at openjdk.org (Andrew Haley) Date: Wed, 4 Sep 2024 13:27:26 GMT Subject: [jdk23u] Integrated: 8337958: Out-of-bounds array access in secondary_super_cache In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 11:57:17 GMT, Andrew Haley wrote: > Hi all, > > This pull request contains a backport of commit [03204600](https://github.com/openjdk/jdk/commit/03204600c596214895ef86581eba9722f76d39b3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew Haley on 12 Aug 2024 and was reviewed by Vladimir Ivanov and Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: a6956942 Author: Andrew Haley URL: https://git.openjdk.org/jdk23u/commit/a69569427817b212abea61abe26a8ab5789633f1 Stats: 13 lines in 3 files changed: 3 ins; 1 del; 9 mod 8337958: Out-of-bounds array access in secondary_super_cache Reviewed-by: vlivanov Backport-of: 03204600c596214895ef86581eba9722f76d39b3 ------------- PR: https://git.openjdk.org/jdk23u/pull/63 From pkumaraswamy at openjdk.org Wed Sep 4 13:48:29 2024 From: pkumaraswamy at openjdk.org (Prajwal Kumaraswamy) Date: Wed, 4 Sep 2024 13:48:29 GMT Subject: [jdk23u] Integrated: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Wed, 4 Sep 2024 06:04:07 GMT, Prajwal Kumaraswamy wrote: > This is a clean backport. > Internal tests are green and related jck tests are green as well This pull request has now been integrated. Changeset: 7d49c522 Author: Prajwal Kumaraswamy Committer: Sean Coffey URL: https://git.openjdk.org/jdk23u/commit/7d49c52272b54070a13b02708dd7ce5f8e375a06 Stats: 1103 lines in 13 files changed: 1101 ins; 0 del; 2 mod 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs Backport-of: bbb516163d400a9c7e923e423fe2a60091b59322 ------------- PR: https://git.openjdk.org/jdk23u/pull/91 From mbaesken at openjdk.org Wed Sep 4 13:55:55 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 4 Sep 2024 13:55:55 GMT Subject: [jdk17u-dev] RFR: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array' Message-ID: <1qJEmuDqdpCmtOk09r_y3E53m2EuGw6lD6AqsW2VRdg=.05f6bed4-915f-4eb3-847b-a28474eb9cf2@github.com> Backport of 8332720, NULL was still in 17u-dev , that's why not clean ------------- Commit messages: - Backport e19a421c30534566ba0dea0fa84f812ebeecfc87 Changes: https://git.openjdk.org/jdk17u-dev/pull/2847/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2847&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332720 Stats: 7 lines in 1 file changed: 2 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2847.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2847/head:pull/2847 PR: https://git.openjdk.org/jdk17u-dev/pull/2847 From abakhtin at openjdk.org Wed Sep 4 14:02:27 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 4 Sep 2024 14:02:27 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: References: Message-ID: <0wXAvUIZEMt1GvwINsr0RwDHmFtEsoHJIjuQJ7EOQjk=.ee466b1d-67a3-42b1-9b0f-6b4ff281d232@github.com> On Wed, 4 Sep 2024 08:10:26 GMT, HempushpaSahu wrote: >> CSR [JDK-8337407](https://bugs.openjdk.org/browse/JDK-8337407) for JDK17 is created > > Hi @alexeybakhtin > Is there any plan to merge this PR anytime soon? > > Thanks. Hi @HempushpaSahu. Yes, I will request integration into 17u as soon as it is reviewed here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#issuecomment-2329150432 From duke at openjdk.org Wed Sep 4 14:17:18 2024 From: duke at openjdk.org (duke) Date: Wed, 4 Sep 2024 14:17:18 GMT Subject: [jdk23u] RFR: 8339248: RISC-V: Remove li64 macro assembler routine and related code In-Reply-To: <-ZIvzs-Yyd-INw0l4-UZIxiPITPzt-fMRPdu_2INa3A=.99942ad4-afff-4a3d-920d-b012b97497b3@github.com> References: <-ZIvzs-Yyd-INw0l4-UZIxiPITPzt-fMRPdu_2INa3A=.99942ad4-afff-4a3d-920d-b012b97497b3@github.com> Message-ID: <4pZ2Bgfx5Fn_vxnIQw5dYPZnzH-UcSrpkw7KzmUCKQ8=.5af242e5-5f22-41ed-993e-53544f3186dc@github.com> On Tue, 3 Sep 2024 10:09:35 GMT, Gui Cao wrote: > Hi, The same issue also exists in jdk23u. So I would like to backport [JDK-8339248](https://bugs.openjdk.org/browse/JDK-8339248) to jdk23u. with this patch ,it will save us some unnecessary runtime checks. This is a risc-v specific change. Backport is clean, risk is low. > > ### Testing > - [x] Run hotspot:tier1 tests on SOPHON SG2042 (fastdebug) @zifeihan Your change (at version 13d59dd129c34cbc9cd695d912fc029996c2f703) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/90#issuecomment-2329187020 From mdoerr at openjdk.org Wed Sep 4 14:30:25 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 4 Sep 2024 14:30:25 GMT Subject: [jdk17u-dev] RFR: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array' In-Reply-To: <1qJEmuDqdpCmtOk09r_y3E53m2EuGw6lD6AqsW2VRdg=.05f6bed4-915f-4eb3-847b-a28474eb9cf2@github.com> References: <1qJEmuDqdpCmtOk09r_y3E53m2EuGw6lD6AqsW2VRdg=.05f6bed4-915f-4eb3-847b-a28474eb9cf2@github.com> Message-ID: On Wed, 4 Sep 2024 13:50:26 GMT, Matthias Baesken wrote: > Backport of 8332720, NULL was still in 17u-dev , that's why not clean LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2847#pullrequestreview-2280403098 From gcao at openjdk.org Wed Sep 4 14:41:22 2024 From: gcao at openjdk.org (Gui Cao) Date: Wed, 4 Sep 2024 14:41:22 GMT Subject: [jdk23u] Integrated: 8339248: RISC-V: Remove li64 macro assembler routine and related code In-Reply-To: <-ZIvzs-Yyd-INw0l4-UZIxiPITPzt-fMRPdu_2INa3A=.99942ad4-afff-4a3d-920d-b012b97497b3@github.com> References: <-ZIvzs-Yyd-INw0l4-UZIxiPITPzt-fMRPdu_2INa3A=.99942ad4-afff-4a3d-920d-b012b97497b3@github.com> Message-ID: <8BtXYuNom8BDrzAYyvu0P2oy3QdIE7QipU0koebbzhY=.d7c4e3e8-0cc8-41dc-a5a4-87ffcd00e329@github.com> On Tue, 3 Sep 2024 10:09:35 GMT, Gui Cao wrote: > Hi, The same issue also exists in jdk23u. So I would like to backport [JDK-8339248](https://bugs.openjdk.org/browse/JDK-8339248) to jdk23u. with this patch ,it will save us some unnecessary runtime checks. This is a risc-v specific change. Backport is clean, risk is low. > > ### Testing > - [x] Run hotspot:tier1 tests on SOPHON SG2042 (fastdebug) This pull request has now been integrated. Changeset: 691c55ab Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk23u/commit/691c55ab5c0b6d05b43ecd839655c63355fd9952 Stats: 111 lines in 2 files changed: 0 ins; 111 del; 0 mod 8339248: RISC-V: Remove li64 macro assembler routine and related code Backport-of: 392bdd5734e0ad4e616d52bb7bcafcf85dccbf34 ------------- PR: https://git.openjdk.org/jdk23u/pull/90 From shade at openjdk.org Wed Sep 4 14:47:21 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 4 Sep 2024 14:47:21 GMT Subject: [jdk17u-dev] RFR: 8339470: [17u] More defensive fix for 8163921 In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 10:19:06 GMT, Goetz Lindenmaier wrote: > This does not remove the header specifications, it just fixes the error. > > Well, it removes * as type, but that is illegal and should be meant to match the same as */*. All right, I can get behind this argument as well. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2843#pullrequestreview-2280451653 From daniel.fuchs at oracle.com Wed Sep 4 15:40:59 2024 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Wed, 4 Sep 2024 16:40:59 +0100 Subject: CFV: New JDK Updates Committer - Ravi Reddy In-Reply-To: References: Message-ID: Vote: yes On 26/08/2024 15:04, Robert Mckenna wrote: > I hereby nominate Ravi Reddy (rreddy)[1] to JDK Updates Committer. From sgehwolf at openjdk.org Wed Sep 4 16:52:57 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 4 Sep 2024 16:52:57 GMT Subject: [jdk17u] RFR: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) Message-ID: Clean backport to improve compatibility with JDK 17 versions which didn't support birth time (`17.0.10` and earlier). I.e. on those systems now last-modified-time is being returned when the statx syscall didn't fill in the birth time (is not supported for this filesystem). In `17.0.11` the epoch (or `0`) is returned for filesystems not supporting creation time. Proposing as a critical fix so as to get it into 17.0.13. CSR for 21-pool and 17-pool is the same as for JDK head. It's waiting on approval from the CSR lead. ------------- Commit messages: - 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) Changes: https://git.openjdk.org/jdk17u/pull/395/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=395&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338696 Stats: 21 lines in 1 file changed: 12 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk17u/pull/395.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/395/head:pull/395 PR: https://git.openjdk.org/jdk17u/pull/395 From sgehwolf at openjdk.org Wed Sep 4 16:52:57 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 4 Sep 2024 16:52:57 GMT Subject: [jdk17u] RFR: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 15:36:52 GMT, Severin Gehwolf wrote: > Clean backport to improve compatibility with JDK 17 versions which didn't support birth time (`17.0.10` and earlier). I.e. on those systems now last-modified-time is being returned when the statx syscall didn't fill in the birth time (is not supported for this filesystem). In `17.0.11` the epoch (or `0`) is returned for filesystems not supporting creation time. Proposing as a critical fix so as to get it into 17.0.13. > > CSR for 21-pool and 17-pool is the same as for JDK head. It's waiting on approval from the CSR lead. MacOS X aarch failure is unrelated. We seem to be seeing this elsewhere too. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/395#issuecomment-2329540357 From abakhtin at openjdk.org Wed Sep 4 18:22:29 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 4 Sep 2024 18:22:29 GMT Subject: [jdk21u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases [v3] In-Reply-To: References: Message-ID: <_ai65rcM8t4chVfCgRctwuXUWzt906WGYL4ZrXTRFTk=.09ed4f51-1323-4936-8c86-0213a32bf9bf@github.com> On Wed, 4 Sep 2024 11:21:12 GMT, Severin Gehwolf wrote: > This seems OK as a fix to improve compatibility with older JDK 21 versions that didn't use `statx`. Somebody else should review it too, though. Thank you the review. @AlanBateman , @bplb could you please look at the changes for 21u. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/951#issuecomment-2329704061 From lucy at openjdk.org Wed Sep 4 21:45:08 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Wed, 4 Sep 2024 21:45:08 GMT Subject: [jdk17u-dev] RFR: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array' In-Reply-To: <1qJEmuDqdpCmtOk09r_y3E53m2EuGw6lD6AqsW2VRdg=.05f6bed4-915f-4eb3-847b-a28474eb9cf2@github.com> References: <1qJEmuDqdpCmtOk09r_y3E53m2EuGw6lD6AqsW2VRdg=.05f6bed4-915f-4eb3-847b-a28474eb9cf2@github.com> Message-ID: On Wed, 4 Sep 2024 13:50:26 GMT, Matthias Baesken wrote: > Backport of 8332720, NULL was still in 17u-dev , that's why not clean LGTM ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2847#pullrequestreview-2281452345 From duke at openjdk.org Wed Sep 4 23:08:56 2024 From: duke at openjdk.org (duke) Date: Wed, 4 Sep 2024 23:08:56 GMT Subject: [jdk11u-dev] Withdrawn: 8302495: update for deprecated sprintf for java.desktop In-Reply-To: References: Message-ID: On Wed, 10 Jul 2024 15:43:42 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8302495](https://bugs.openjdk.org/browse/JDK-8302495) as applied to 17. > > This removes deprecated `sprintf` with `snprintf`in different parts of `java.desktop`, as `sprintf` is deprecated in latest XCode14/clang14 for the macos-13 GHA build infrastructure. > > The build is still expected to fail on this platform until all `sprintf` are removed from the codebase in future backports. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2849 From duke at openjdk.org Wed Sep 4 23:09:55 2024 From: duke at openjdk.org (duke) Date: Wed, 4 Sep 2024 23:09:55 GMT Subject: [jdk11u-dev] Withdrawn: 8335918: update for deprecated sprintf for jvmti In-Reply-To: References: Message-ID: On Wed, 10 Jul 2024 11:18:49 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8335918](https://bugs.openjdk.org/browse/JDK-8335918) from JDK-17 to replace deprecated `sprintf` with `snprintf`. > > Despite of this backport the macos build will continue failing until other backports are in place. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2846 From duke at openjdk.org Wed Sep 4 23:09:56 2024 From: duke at openjdk.org (duke) Date: Wed, 4 Sep 2024 23:09:56 GMT Subject: [jdk11u-dev] Withdrawn: 8299378: sprintf is deprecated in Xcode 14 In-Reply-To: References: Message-ID: On Wed, 10 Jul 2024 15:35:26 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378), as applied to 17. > > This replaces the deprecated `sprintf` with `os::snprintf_checked` in more places, for the build to progress in the new macos-13 GHA. > > The build will still fail until all remaining backports replace `sprintf`in all places of the codebase. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2848 From duke at openjdk.org Wed Sep 4 23:15:07 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 4 Sep 2024 23:15:07 GMT Subject: [jdk11u-dev] RFR: 8336291: [11u] update for deprecated sprintf for jdk.pack [v2] In-Reply-To: References: Message-ID: > This fixes [JDK-8336291](https://bugs.openjdk.org/browse/JDK-8336291) by replacing the deprecated `sprintf` with `snprintf` in different files `jdk.pack`. Low risk. > > This is a 11u specific issue, as `jdk.pack` was removed in [JDK-8234596](https://bugs.openjdk.org/browse/JDK-8234596) in OpenJDK 14. Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2853/files - new: https://git.openjdk.org/jdk11u-dev/pull/2853/files/124ba5e1..124ba5e1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2853&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2853&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2853.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2853/head:pull/2853 PR: https://git.openjdk.org/jdk11u-dev/pull/2853 From goetz at openjdk.org Thu Sep 5 06:00:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 06:00:25 GMT Subject: [jdk21u-dev] RFR: Merge jdk21u:master [v2] In-Reply-To: <0O9OvJT0it3rwfPupH3Vm8IjeZBHlh6tv9G1jH-oIzc=.45c3906a-f106-4c68-acf8-ab9c415064aa@github.com> References: <0O9OvJT0it3rwfPupH3Vm8IjeZBHlh6tv9G1jH-oIzc=.45c3906a-f106-4c68-acf8-ab9c415064aa@github.com> Message-ID: > Merge build tag 21.0.5+6 from jdk21u to jdk21u-dev Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision: - Merge Added tag jdk-21.0.5+6 for changeset 459757e3777d - 8337780: RISC-V: C2: Change C calling convention for sp to NS Backport-of: 53db937dd0766695906dc20c1dbbd3228c02fe1e - 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion Backport-of: 00aac4097abd3c5e6144734cfd44228bc31892fb - 8334567: [test] runtime/os/TestTracePageSizes move ppc handling Backport-of: 6a5cb0b2c49cb390ce8b87fd977ee79572df90fc - 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 8319960: RISC-V: compiler/intrinsics/TestInteger/LongUnsignedDivMod.java failed with "counts: Graph contains wrong number of nodes" Reviewed-by: phh Backport-of: c80e691adf6f9ac1a41b2329ce366710e604e34e - 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout Backport-of: 39884205fbc0e85ce9d78303dfbabf125ff36535 - 8316895: SeenThread::print_action_queue called on a null pointer Backport-of: fd52be2a3c53912598afe600d680de77090f9f43 - 8338110: Exclude Fingerprinter::do_type from ubsan checks Backport-of: 6a390147959e0fb88de6ee13204cff72cd910f09 - 8339080: Bump update version for OpenJDK: jdk-21.0.6 Reviewed-by: sgehwolf ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/954/files - new: https://git.openjdk.org/jdk21u-dev/pull/954/files/551832ba..551832ba Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=954&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=954&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/954.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/954/head:pull/954 PR: https://git.openjdk.org/jdk21u-dev/pull/954 From goetz at openjdk.org Thu Sep 5 06:00:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 06:00:26 GMT Subject: [jdk21u-dev] Integrated: Merge jdk21u:master In-Reply-To: <0O9OvJT0it3rwfPupH3Vm8IjeZBHlh6tv9G1jH-oIzc=.45c3906a-f106-4c68-acf8-ab9c415064aa@github.com> References: <0O9OvJT0it3rwfPupH3Vm8IjeZBHlh6tv9G1jH-oIzc=.45c3906a-f106-4c68-acf8-ab9c415064aa@github.com> Message-ID: On Wed, 4 Sep 2024 06:45:38 GMT, Goetz Lindenmaier wrote: > Merge build tag 21.0.5+6 from jdk21u to jdk21u-dev This pull request has now been integrated. Changeset: 427dba15 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/427dba15fcc9828a21093dd1a90fcc4724c8e5ba Stats: 204 lines in 6 files changed: 198 ins; 2 del; 4 mod Merge ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/954 From goetz at openjdk.org Thu Sep 5 06:02:05 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 06:02:05 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master In-Reply-To: References: Message-ID: On Wed, 4 Sep 2024 06:49:53 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.13+6 from jdk17u to jdk17u-dev This pull request has now been integrated. Changeset: fc3bcf94 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/fc3bcf947546940ee346fdfd1c61a678cde5fe8f Stats: 204 lines in 6 files changed: 198 ins; 2 del; 4 mod Merge ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2846 From goetz at openjdk.org Thu Sep 5 06:57:04 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 06:57:04 GMT Subject: [jdk21u-dev] RFR: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 06:25:42 GMT, Jiawei Tang wrote: >> 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option > > Hi, could I get help for this approval? Hi @jia-wei-tang Are you targeting the October release? This backport will got to jdk21u-dev and thus only make the January release. If you target the October release you must make a PR against jdk21u and flag it jdk21u-critical-request. But maybe it is more safe to backout 8330146 from the October release? Can you ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/910#issuecomment-2330746192 From mbaesken at openjdk.org Thu Sep 5 07:04:57 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 5 Sep 2024 07:04:57 GMT Subject: [jdk21u-dev] Integrated: 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058 In-Reply-To: References: Message-ID: On Fri, 30 Aug 2024 13:37:11 GMT, Matthias Baesken wrote: > 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058 This pull request has now been integrated. Changeset: 3c6b6374 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/3c6b63746b0fbf9831a38f5deb08a48700a90eb5 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058 Backport-of: 692f5cbdb9bd94f03e5f18ddf07d56fbb5c0d456 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/950 From duke at openjdk.org Thu Sep 5 07:26:02 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 5 Sep 2024 07:26:02 GMT Subject: [jdk11u-dev] RFR: 8336291: [11u] update for deprecated sprintf for jdk.pack [v2] In-Reply-To: References: Message-ID: On Wed, 4 Sep 2024 23:15:07 GMT, Antonio Vieiro wrote: >> This fixes [JDK-8336291](https://bugs.openjdk.org/browse/JDK-8336291) by replacing the deprecated `sprintf` with `snprintf` in different files `jdk.pack`. Low risk. >> >> This is a 11u specific issue, as `jdk.pack` was removed in [JDK-8234596](https://bugs.openjdk.org/browse/JDK-8234596) in OpenJDK 14. > > Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Parent pull requests have been closed, so there's no point in continuing with this one. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2853#issuecomment-2330794979 From duke at openjdk.org Thu Sep 5 07:26:02 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 5 Sep 2024 07:26:02 GMT Subject: [jdk11u-dev] Withdrawn: 8336291: [11u] update for deprecated sprintf for jdk.pack In-Reply-To: References: Message-ID: On Fri, 12 Jul 2024 07:09:51 GMT, Antonio Vieiro wrote: > This fixes [JDK-8336291](https://bugs.openjdk.org/browse/JDK-8336291) by replacing the deprecated `sprintf` with `snprintf` in different files `jdk.pack`. Low risk. > > This is a 11u specific issue, as `jdk.pack` was removed in [JDK-8234596](https://bugs.openjdk.org/browse/JDK-8234596) in OpenJDK 14. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2853 From duke at openjdk.org Thu Sep 5 07:29:41 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 5 Sep 2024 07:29:41 GMT Subject: [jdk11u-dev] RFR: 8336292: [11u] awt_ImagingLib passes arguments to function without a prototype [v2] In-Reply-To: References: Message-ID: > This is a fix to [JDK-8336292](https://bugs.openjdk.org/browse/JDK-8336292): Building 11u on the latest macos-13 GHA platform (XCode 14, clang 14) fails as we are passing arguments to a function without a prototype in awt_ImagingLib.c. > > The fix adds disables the `deprecated-non-prototype` when building with clang, for the build to pass. > > This is a 11u only issue, as the make infrastructure was reorganized in [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) after OpenJDK 15, and enhanced afterwards. Backporting [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) is an important change that should be avoided unless strictly necessary. Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2854/files - new: https://git.openjdk.org/jdk11u-dev/pull/2854/files/fd7dcc99..fd7dcc99 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2854&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2854&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2854.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2854/head:pull/2854 PR: https://git.openjdk.org/jdk11u-dev/pull/2854 From duke at openjdk.org Thu Sep 5 07:29:42 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 5 Sep 2024 07:29:42 GMT Subject: [jdk11u-dev] RFR: 8336292: [11u] awt_ImagingLib passes arguments to function without a prototype In-Reply-To: References: Message-ID: On Fri, 12 Jul 2024 07:49:44 GMT, Antonio Vieiro wrote: > This is a fix to [JDK-8336292](https://bugs.openjdk.org/browse/JDK-8336292): Building 11u on the latest macos-13 GHA platform (XCode 14, clang 14) fails as we are passing arguments to a function without a prototype in awt_ImagingLib.c. > > The fix adds disables the `deprecated-non-prototype` when building with clang, for the build to pass. > > This is a 11u only issue, as the make infrastructure was reorganized in [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) after OpenJDK 15, and enhanced afterwards. Backporting [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) is an important change that should be avoided unless strictly necessary. Parent pull requests have been closed without review, so there's no point in continuing just with this PR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2854#issuecomment-2330801368 From duke at openjdk.org Thu Sep 5 07:29:42 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 5 Sep 2024 07:29:42 GMT Subject: [jdk11u-dev] Withdrawn: 8336292: [11u] awt_ImagingLib passes arguments to function without a prototype In-Reply-To: References: Message-ID: On Fri, 12 Jul 2024 07:49:44 GMT, Antonio Vieiro wrote: > This is a fix to [JDK-8336292](https://bugs.openjdk.org/browse/JDK-8336292): Building 11u on the latest macos-13 GHA platform (XCode 14, clang 14) fails as we are passing arguments to a function without a prototype in awt_ImagingLib.c. > > The fix adds disables the `deprecated-non-prototype` when building with clang, for the build to pass. > > This is a 11u only issue, as the make infrastructure was reorganized in [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) after OpenJDK 15, and enhanced afterwards. Backporting [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) is an important change that should be avoided unless strictly necessary. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2854 From goetz at openjdk.org Thu Sep 5 07:29:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 07:29:57 GMT Subject: [jdk17u-dev] RFR: 8273979: move some os time related functions to os_posix for POSIX platforms In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 15:29:20 GMT, Radim Vansa wrote: > Hi all, > > This pull request contains a backport of commit[ 1c6fa113](https://github.com/openjdk/jdk/commit/1c6fa113bd06585945e077f0d2004a291c27946d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 23 Sep 2021 and was reviewed by David Holmes and Lutz Schmidt. > > The backport applies cleanly, was created by the /backport command. > > Thanks! Hi @rvansa I am not so happy about this backport. Simplifying another project is not an eligible reason to backport things. Also, you did not test macos and expecially not aix. Does that still build? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2831#issuecomment-2330801877 From duke at openjdk.org Thu Sep 5 07:31:02 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 5 Sep 2024 07:31:02 GMT Subject: [jdk11u-dev] RFR: 8296812: sprintf is deprecated in Xcode 14 [v4] In-Reply-To: References: <4nCoTNA6Dj1NbaY2uePRlg57kHlcCTHfq2awRsoHprE=.3bf98695-f619-4684-a353-653d36b70f28@github.com> Message-ID: On Tue, 16 Jul 2024 19:56:28 GMT, Antonio Vieiro wrote: >> Backport of [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) . >> >> The new GHA build platform (macos-13 / XCode 14) fails because `sprintf` is deprecated. An alternative (`os::snprintf_checked`) was introduced in JDK-8296812. >> >> This is sadly not a clean backport, as different issues have not been backported to 11 (JDK-8324824, JDK-8303575, JDK-8301050, JDK-8298472, JDK-8298472 to name a few). >> >> The backport required changes to the following files: >> >> >> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp >> src/hotspot/os/bsd/os_bsd.cpp >> src/hotspot/share/adlc/adlc.hpp >> src/hotspot/share/adlc/adlparse.cpp >> src/hotspot/share/adlc/formssel.cpp >> src/hotspot/share/adlc/output_c.cpp >> src/hotspot/share/c1/c1_Runtime1.cpp >> src/hotspot/share/compiler/compileBroker.cpp >> src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp >> src/hotspot/share/runtime/perfData.cpp >> src/hotspot/share/utilities/utf8.cpp >> >> >> And these files were not backported: >> >> >> src/hotspot/share/cds/filemap.cpp >> src/hotspot/share/interpreter/bootstrapInfo.cpp >> src/hotspot/share/jfr/support/jfrSymbolTable.cpp >> >> >> While we are at it, this change also replaces `strcat` in `src/hotspot/cpu/aarch64/vm_version_aarch64.cpp` with the newly introduced `os::snprintf_checked` to avoid possible buffer overflows. >> >> Builds on the new `macos-13` will continue to fail until different issues are backported. The new macos builds report a clash with the standard `assert` macro (see [1]) what suggests that [JDK-8299254](https://bugs.openjdk.org/browse/JDK-8299254) "Support dealing with standard assert macro" should be backported next. >> >> [1] >> >> In file included from /Users/runner/work/jdk11u-dev/jdk11u-dev/test/hotspot/gtest/jfr/test_networkUtilization.cpp:223: >> /Users/runner/work/jdk11u-dev/jdk11u-dev/src/hotspot/share/jfr/periodic/jfrNetworkUtilization.cpp:58:25: error: too many arguments provided to function-like macro invocation >> assert(iface != NULL, "invariant"); > > Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: > > Replace comment + newline in src/hotspot/share/adlc/adlc.hpp Parent pull requests have been closed without review, so there's no point in continuing just with this PR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2836#issuecomment-2330804798 From duke at openjdk.org Thu Sep 5 07:31:02 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 5 Sep 2024 07:31:02 GMT Subject: [jdk11u-dev] Withdrawn: 8296812: sprintf is deprecated in Xcode 14 In-Reply-To: <4nCoTNA6Dj1NbaY2uePRlg57kHlcCTHfq2awRsoHprE=.3bf98695-f619-4684-a353-653d36b70f28@github.com> References: <4nCoTNA6Dj1NbaY2uePRlg57kHlcCTHfq2awRsoHprE=.3bf98695-f619-4684-a353-653d36b70f28@github.com> Message-ID: On Fri, 5 Jul 2024 10:02:10 GMT, Antonio Vieiro wrote: > Backport of [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) . > > The new GHA build platform (macos-13 / XCode 14) fails because `sprintf` is deprecated. An alternative (`os::snprintf_checked`) was introduced in JDK-8296812. > > This is sadly not a clean backport, as different issues have not been backported to 11 (JDK-8324824, JDK-8303575, JDK-8301050, JDK-8298472, JDK-8298472 to name a few). > > The backport required changes to the following files: > > > src/hotspot/cpu/aarch64/vm_version_aarch64.cpp > src/hotspot/os/bsd/os_bsd.cpp > src/hotspot/share/adlc/adlc.hpp > src/hotspot/share/adlc/adlparse.cpp > src/hotspot/share/adlc/formssel.cpp > src/hotspot/share/adlc/output_c.cpp > src/hotspot/share/c1/c1_Runtime1.cpp > src/hotspot/share/compiler/compileBroker.cpp > src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp > src/hotspot/share/runtime/perfData.cpp > src/hotspot/share/utilities/utf8.cpp > > > And these files were not backported: > > > src/hotspot/share/cds/filemap.cpp > src/hotspot/share/interpreter/bootstrapInfo.cpp > src/hotspot/share/jfr/support/jfrSymbolTable.cpp > > > While we are at it, this change also replaces `strcat` in `src/hotspot/cpu/aarch64/vm_version_aarch64.cpp` with the newly introduced `os::snprintf_checked` to avoid possible buffer overflows. > > Builds on the new `macos-13` will continue to fail until different issues are backported. The new macos builds report a clash with the standard `assert` macro (see [1]) what suggests that [JDK-8299254](https://bugs.openjdk.org/browse/JDK-8299254) "Support dealing with standard assert macro" should be backported next. > > [1] > > In file included from /Users/runner/work/jdk11u-dev/jdk11u-dev/test/hotspot/gtest/jfr/test_networkUtilization.cpp:223: > /Users/runner/work/jdk11u-dev/jdk11u-dev/src/hotspot/share/jfr/periodic/jfrNetworkUtilization.cpp:58:25: error: too many arguments provided to function-like macro invocation > assert(iface != NULL, "invariant"); This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2836 From gcao at openjdk.org Thu Sep 5 08:08:57 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 5 Sep 2024 08:08:57 GMT Subject: [jdk17u-dev] RFR: 8339248: RISC-V: Remove li64 macro assembler routine and related code In-Reply-To: <2iWyVPMOkgY8vV9eKiY9NGggDALjZzSjm1ayVyuYOm4=.92f70a7b-cfc8-4837-aa40-9ea200686e12@github.com> References: <2iWyVPMOkgY8vV9eKiY9NGggDALjZzSjm1ayVyuYOm4=.92f70a7b-cfc8-4837-aa40-9ea200686e12@github.com> Message-ID: On Tue, 3 Sep 2024 10:13:49 GMT, Gui Cao wrote: > Hi, The same issue also exists in jdk17u. So I would like to backport [JDK-8339248](https://bugs.openjdk.org/browse/JDK-8339248) to jdk17u-dev. with this patch ,it will save us some unnecessary runtime checks. This is a risc-v specific change, risk is low. > > ### Testing > - [x] Run hotspot:tier1 tests on SOPHON SG2042 (release) Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2842#issuecomment-2330876755 From mbaesken at openjdk.org Thu Sep 5 08:09:57 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 5 Sep 2024 08:09:57 GMT Subject: [jdk17u-dev] Integrated: 8330464: hserr generic events - add entry for the before_exit calls In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 15:24:53 GMT, Matthias Baesken wrote: > Backport of 8330464, thread.cpp is changed in 17u-dev (other file) This pull request has now been integrated. Changeset: 5d849762 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/5d84976296a032bc5c31b0fb08d531e9c9d57368 Stats: 7 lines in 2 files changed: 3 ins; 0 del; 4 mod 8330464: hserr generic events - add entry for the before_exit calls Reviewed-by: mdoerr Backport-of: 45ed97f15b96071e5d6b6d21e8f0129eda5aa447 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2840 From gcao at openjdk.org Thu Sep 5 08:11:05 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 5 Sep 2024 08:11:05 GMT Subject: [jdk21u-dev] RFR: 8339248: RISC-V: Remove li64 macro assembler routine and related code In-Reply-To: <-alBH9YZdl2mMx2y0GeaXJL-6CRvgO_MJ3jpLJZcCSA=.ba085485-1bab-460b-9de8-7b13636a32f1@github.com> References: <-alBH9YZdl2mMx2y0GeaXJL-6CRvgO_MJ3jpLJZcCSA=.ba085485-1bab-460b-9de8-7b13636a32f1@github.com> Message-ID: On Tue, 3 Sep 2024 09:58:52 GMT, Gui Cao wrote: > Hi, The same issue also exists in jdk21u-dev. So I would like to backport [JDK-8339248](https://bugs.openjdk.org/browse/JDK-8339248) to jdk21u-dev. with this patch ,it will save us some unnecessary runtime checks. RISC-V specific change, risk is low. > > ### Testing > - [x] Run hotspot:tier1 tests on SOPHON SG2042 (fastdebug) Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/953#issuecomment-2330876348 From gcao at openjdk.org Thu Sep 5 08:11:05 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 5 Sep 2024 08:11:05 GMT Subject: [jdk21u-dev] Integrated: 8339248: RISC-V: Remove li64 macro assembler routine and related code In-Reply-To: <-alBH9YZdl2mMx2y0GeaXJL-6CRvgO_MJ3jpLJZcCSA=.ba085485-1bab-460b-9de8-7b13636a32f1@github.com> References: <-alBH9YZdl2mMx2y0GeaXJL-6CRvgO_MJ3jpLJZcCSA=.ba085485-1bab-460b-9de8-7b13636a32f1@github.com> Message-ID: <5OHzdxGqnEOQhTanfOWqHyS-STuKPAUkybVh-0lC5Ds=.4a13eb67-0bdf-48fa-a066-724672159d16@github.com> On Tue, 3 Sep 2024 09:58:52 GMT, Gui Cao wrote: > Hi, The same issue also exists in jdk21u-dev. So I would like to backport [JDK-8339248](https://bugs.openjdk.org/browse/JDK-8339248) to jdk21u-dev. with this patch ,it will save us some unnecessary runtime checks. RISC-V specific change, risk is low. > > ### Testing > - [x] Run hotspot:tier1 tests on SOPHON SG2042 (fastdebug) This pull request has now been integrated. Changeset: 0738937b Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk21u-dev/commit/0738937b5b590544af69b8823d802957f393927a Stats: 111 lines in 4 files changed: 0 ins; 111 del; 0 mod 8339248: RISC-V: Remove li64 macro assembler routine and related code Reviewed-by: fyang Backport-of: 392bdd5734e0ad4e616d52bb7bcafcf85dccbf34 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/953 From gcao at openjdk.org Thu Sep 5 08:11:52 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 5 Sep 2024 08:11:52 GMT Subject: [jdk17u-dev] Integrated: 8339248: RISC-V: Remove li64 macro assembler routine and related code In-Reply-To: <2iWyVPMOkgY8vV9eKiY9NGggDALjZzSjm1ayVyuYOm4=.92f70a7b-cfc8-4837-aa40-9ea200686e12@github.com> References: <2iWyVPMOkgY8vV9eKiY9NGggDALjZzSjm1ayVyuYOm4=.92f70a7b-cfc8-4837-aa40-9ea200686e12@github.com> Message-ID: On Tue, 3 Sep 2024 10:13:49 GMT, Gui Cao wrote: > Hi, The same issue also exists in jdk17u. So I would like to backport [JDK-8339248](https://bugs.openjdk.org/browse/JDK-8339248) to jdk17u-dev. with this patch ,it will save us some unnecessary runtime checks. This is a risc-v specific change, risk is low. > > ### Testing > - [x] Run hotspot:tier1 tests on SOPHON SG2042 (release) This pull request has now been integrated. Changeset: 7921433d Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk17u-dev/commit/7921433daa0e91fb80dfd305cd4d5c0e29b2aaf6 Stats: 111 lines in 4 files changed: 0 ins; 111 del; 0 mod 8339248: RISC-V: Remove li64 macro assembler routine and related code Reviewed-by: fyang Backport-of: 392bdd5734e0ad4e616d52bb7bcafcf85dccbf34 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2842 From goetz at openjdk.org Thu Sep 5 09:05:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 09:05:55 GMT Subject: [jdk17u-dev] RFR: 8339470: [17u] More defensive fix for 8163921 In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 10:19:06 GMT, Goetz Lindenmaier wrote: > This does not remove the header specifications, it just fixes the error. > > Well, it removes * as type, but that is illegal and should be meant to match the same as */*. Ok, thanks. I think we should target the January update, because, as you also remarked, this is a new change. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2843#issuecomment-2330990285 From goetz at openjdk.org Thu Sep 5 09:27:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 09:27:09 GMT Subject: [jdk23u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Wed, 4 Sep 2024 06:04:07 GMT, Prajwal Kumaraswamy wrote: > This is a clean backport. > Internal tests are green and related jck tests are green as well @pkumaraswamy , @coffeys For some reason the backport is not annotated to the bug. Did you eventually make a closed backport somehow? Could you please open it up? ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/91#issuecomment-2331034384 From goetz at openjdk.org Thu Sep 5 09:59:05 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 09:59:05 GMT Subject: [jdk11u] Integrated: 8338139: {ClassLoading, Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods In-Reply-To: <4tMn6TwJZbupgIDcklQECvXajb_cABZNxFOkZK3bNzw=.d1800d5e-cd54-4707-a5e9-b1c2a1b1ed5e@github.com> References: <4tMn6TwJZbupgIDcklQECvXajb_cABZNxFOkZK3bNzw=.d1800d5e-cd54-4707-a5e9-b1c2a1b1ed5e@github.com> Message-ID: <1W3ax5pIbNRT_K1BWBSwzDAkMQV6bCgn8JISDgI6jAk=.73b3351f-2e87-497e-9482-8410a9b20c04@github.com> On Tue, 3 Sep 2024 12:48:46 GMT, Goetz Lindenmaier wrote: > I backport this from 17. I had hoped it would be clean, but I had to adapt the nullptr literals in the .cpp files. > > Also, I had to resolve the copyright in all four hotspot files. This pull request has now been integrated. Changeset: 6ee8bacf Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u/commit/6ee8bacfdda51b53178913ebf711ac9feacce26e Stats: 204 lines in 6 files changed: 198 ins; 2 del; 4 mod 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods Reviewed-by: phh Backport-of: 897f433b33a46d56cc6972b1c6b4405ecaa4dea9 ------------- PR: https://git.openjdk.org/jdk11u/pull/94 From goetz at openjdk.org Thu Sep 5 10:00:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 10:00:53 GMT Subject: [jdk17u-dev] Integrated: 8271456: Avoid looking up standard charsets in "java.desktop" module In-Reply-To: <7S58sbZVuWV2e74Yc304nlpgEAs7cQuIN5hnLofV1TM=.45b4d0ee-018e-49f5-9fb8-4b21c93d479a@github.com> References: <7S58sbZVuWV2e74Yc304nlpgEAs7cQuIN5hnLofV1TM=.45b4d0ee-018e-49f5-9fb8-4b21c93d479a@github.com> Message-ID: On Tue, 3 Sep 2024 12:24:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > I backport this share/classes/javax/swing/text/html/HTMLEditorKit.java > Resolved imports. It did not apply because 17 imports SwingAccessor. > > src/java.desktop/share/classes/javax/swing/text/rtf/RTFReader.java > Also resolved imports. > > src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java > Copyright > > To make it compile, I added imports of java.util Classes to RTFReader.java. This pull request has now been integrated. Changeset: 58cbf5d0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/58cbf5d0490783970bc837b022899e625c34f1cd Stats: 762 lines in 33 files changed: 339 ins; 269 del; 154 mod 8271456: Avoid looking up standard charsets in "java.desktop" module Reviewed-by: phh Backport-of: 6b55ef3b58ae405c46f440e06b5adb03cec3a500 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2844 From rvansa at openjdk.org Thu Sep 5 10:04:57 2024 From: rvansa at openjdk.org (Radim Vansa) Date: Thu, 5 Sep 2024 10:04:57 GMT Subject: [jdk17u-dev] RFR: 8273979: move some os time related functions to os_posix for POSIX platforms In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 07:27:00 GMT, Goetz Lindenmaier wrote: >> Hi all, >> >> This pull request contains a backport of commit[ 1c6fa113](https://github.com/openjdk/jdk/commit/1c6fa113bd06585945e077f0d2004a291c27946d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Matthias Baesken on 23 Sep 2021 and was reviewed by David Holmes and Lutz Schmidt. >> >> The backport applies cleanly, was created by the /backport command. >> >> Thanks! > > Hi @rvansa > I am not so happy about this backport. > Simplifying another project is not an eligible reason to backport things. > Also, you did not test macos and expecially not aix. Does that still build? Hi @GoeLin , understood, though I am rather trying to be honest than making up a synthetic argument. Since it was accepted in the mainline I could say that it is an improvement in code quality. MacOS should be tested here in GHA, regrettably I don't know where to get AIX for testing. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2831#issuecomment-2331118243 From amitkumar at openjdk.org Thu Sep 5 10:07:21 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Thu, 5 Sep 2024 10:07:21 GMT Subject: [jdk21u-dev] RFR: 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' Message-ID: Hi all, This pull request contains a backport of commit [28de44da](https://github.com/openjdk/jdk/commit/28de44da71871bec7648f01a4df2faee43fa43b6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 5 Sep 2024 and was reviewed by Stefan Karlsson, Vladimir Kozlov and Dean Long. Thanks! ------------- Commit messages: - Backport 28de44da71871bec7648f01a4df2faee43fa43b6 Changes: https://git.openjdk.org/jdk21u-dev/pull/955/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=955&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332461 Stats: 5 lines in 2 files changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/955.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/955/head:pull/955 PR: https://git.openjdk.org/jdk21u-dev/pull/955 From coffeys at openjdk.org Thu Sep 5 10:18:58 2024 From: coffeys at openjdk.org (Sean Coffey) Date: Thu, 5 Sep 2024 10:18:58 GMT Subject: [jdk23u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 09:24:21 GMT, Goetz Lindenmaier wrote: > @pkumaraswamy , @coffeys For some reason the backport is not annotated to the bug. Did you eventually make a closed backport somehow? Could you please open it up? the issue should now be visible. As per JDK crypto roadmap - the aim is for October release: https://www.java.com/en/jre-jdk-cryptoroadmap.html ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/91#issuecomment-2331147555 From goetz at openjdk.org Thu Sep 5 10:24:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 10:24:06 GMT Subject: [jdk23u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Wed, 4 Sep 2024 06:04:07 GMT, Prajwal Kumaraswamy wrote: > This is a clean backport. > Internal tests are green and related jck tests are green as well Thanks for the info and opening the issues! ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/91#issuecomment-2331156917 From goetz at openjdk.org Thu Sep 5 10:40:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 10:40:29 GMT Subject: [jdk17u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 7d49c52272b54070a13b02708dd7ce5f8e375a06 Changes: https://git.openjdk.org/jdk17u/pull/396/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=396&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337664 Stats: 1103 lines in 13 files changed: 1101 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u/pull/396.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/396/head:pull/396 PR: https://git.openjdk.org/jdk17u/pull/396 From goetz at openjdk.org Thu Sep 5 10:41:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 10:41:19 GMT Subject: [jdk21u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs Message-ID: I backport this for parity with Oracle 21.0.5 . ------------- Commit messages: - Backport 7d49c52272b54070a13b02708dd7ce5f8e375a06 Changes: https://git.openjdk.org/jdk21u/pull/451/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=451&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337664 Stats: 1103 lines in 13 files changed: 1101 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/451.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/451/head:pull/451 PR: https://git.openjdk.org/jdk21u/pull/451 From goetz at openjdk.org Thu Sep 5 11:39:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 11:39:35 GMT Subject: [jdk11u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs Message-ID: I backport this for parity with 11.0.25-oracle. src/java.base/share/classes/sun/security/validator/CADistrustPolicy.java * Resolved Copyright src/java.base/share/classes/sun/security/validator/EntrustTLSPolicy.java * Removed debug argument from getFingerprint() as "8270946: X509CertImpl.getFingerprint should not return the empty String" is not in 11. ------------- Commit messages: - Resolve and fix build - Backport 7d49c52272b54070a13b02708dd7ce5f8e375a06 Changes: https://git.openjdk.org/jdk11u/pull/95/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=95&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337664 Stats: 1103 lines in 13 files changed: 1101 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u/pull/95.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/95/head:pull/95 PR: https://git.openjdk.org/jdk11u/pull/95 From robm at openjdk.org Thu Sep 5 12:37:08 2024 From: robm at openjdk.org (Rob McKenna) Date: Thu, 5 Sep 2024 12:37:08 GMT Subject: [jdk23u] Integrated: Merge jdk:jdk23 Message-ID: <53eR59qqyIaJfV-H9dklOp1gOHEQq7fvScHLM1lRWcM=.40ead88f-9ede-4331-b616-75f3fdb08379@github.com> clean merge ------------- Commit messages: - Merge - 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion - 8337971: Problem list several jvmci tests on linux-riscv64 until JDK-8331704 is fixed - 8337810: ProblemList BasicDirectoryModel/LoaderThreadCount.java on Windows - 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect - 8336342: Fix known X11 library locations in sysroot - 8337283: configure.log is truncated when build dir is on different filesystem - 8336343: Add more known sysroot library locations for ALSA - 8332113: Update nsk.share.Log to be always verbose - 8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive - ... and 44 more: https://git.openjdk.org/jdk23u/compare/9ad2e63f...39237bbe The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk23u/pull/92/files Stats: 10510 lines in 62 files changed: 10198 ins; 121 del; 191 mod Patch: https://git.openjdk.org/jdk23u/pull/92.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/92/head:pull/92 PR: https://git.openjdk.org/jdk23u/pull/92 From robm at openjdk.org Thu Sep 5 12:37:09 2024 From: robm at openjdk.org (Rob McKenna) Date: Thu, 5 Sep 2024 12:37:09 GMT Subject: [jdk23u] Integrated: Merge jdk:jdk23 In-Reply-To: <53eR59qqyIaJfV-H9dklOp1gOHEQq7fvScHLM1lRWcM=.40ead88f-9ede-4331-b616-75f3fdb08379@github.com> References: <53eR59qqyIaJfV-H9dklOp1gOHEQq7fvScHLM1lRWcM=.40ead88f-9ede-4331-b616-75f3fdb08379@github.com> Message-ID: On Thu, 5 Sep 2024 12:30:45 GMT, Rob McKenna wrote: > clean merge This pull request has now been integrated. Changeset: 325d5c87 Author: Rob McKenna URL: https://git.openjdk.org/jdk23u/commit/325d5c87cd38cc7e8cb7c1b651b779f0263f9f89 Stats: 202 lines in 6 files changed: 196 ins; 2 del; 4 mod Merge ------------- PR: https://git.openjdk.org/jdk23u/pull/92 From goetz at openjdk.org Thu Sep 5 13:03:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 13:03:59 GMT Subject: [jdk11u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 11:31:46 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.25-oracle. > > src/java.base/share/classes/sun/security/validator/CADistrustPolicy.java > * Resolved Copyright > src/java.base/share/classes/sun/security/validator/EntrustTLSPolicy.java > * Removed debug argument from getFingerprint() as "8270946: X509CertImpl.getFingerprint should not return the empty String" is not in 11. GHA failures: well known sprintf build issues. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/95#issuecomment-2331622973 From goetz at openjdk.org Thu Sep 5 13:07:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 13:07:33 GMT Subject: [jdk17u-dev] RFR: 8274505: Too weak variable type leads to unnecessary cast in java.desktop Message-ID: <9sRQS3Wanc4W3gH9O38d5Raka5re8-W9QqMtaZbu2DQ=.c8255e3e-da24-4e45-bdbb-a26e6227da04@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 9ca6bf0d22ac39d4ee29c756903038f09087ca12 Changes: https://git.openjdk.org/jdk17u-dev/pull/2848/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2848&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274505 Stats: 78 lines in 11 files changed: 0 ins; 22 del; 56 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2848.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2848/head:pull/2848 PR: https://git.openjdk.org/jdk17u-dev/pull/2848 From goetz at openjdk.org Thu Sep 5 13:23:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 5 Sep 2024 13:23:54 GMT Subject: [jdk17u-dev] RFR: 8071693: Introspector ignores default interface methods Message-ID: <6obDf4FsmA-sy2HLJ27G23FcV8HTltjH3tbJw-y8Wx8=.5101c6d3-1c3c-4378-9cea-84a5c88ba215@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 1e4eafb4fe70832294a12938d93e7860073cf4cf Changes: https://git.openjdk.org/jdk17u-dev/pull/2849/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2849&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8071693 Stats: 247 lines in 2 files changed: 243 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2849.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2849/head:pull/2849 PR: https://git.openjdk.org/jdk17u-dev/pull/2849 From phh at openjdk.org Thu Sep 5 15:25:02 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 5 Sep 2024 15:25:02 GMT Subject: [jdk11u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 11:31:46 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.25-oracle. > > src/java.base/share/classes/sun/security/validator/CADistrustPolicy.java > * Resolved Copyright > src/java.base/share/classes/sun/security/validator/EntrustTLSPolicy.java > * Removed debug argument from getFingerprint() as "8270946: X509CertImpl.getFingerprint should not return the empty String" is not in 11. Marked as reviewed by phh (Reviewer). I assume this is a critical fix because it's against jdk11u rather than jdk11u-dev. ------------- PR Review: https://git.openjdk.org/jdk11u/pull/95#pullrequestreview-2283403321 PR Comment: https://git.openjdk.org/jdk11u/pull/95#issuecomment-2332000989 From duke at openjdk.org Thu Sep 5 16:16:59 2024 From: duke at openjdk.org (duke) Date: Thu, 5 Sep 2024 16:16:59 GMT Subject: [jdk21u-dev] RFR: 8317575: AArch64: C2_MacroAssembler::fast_lock uses rscratch1 for cmpxchg result [v2] In-Reply-To: References: Message-ID: <_9AMP51yjHSHqDZO19lp08mGbCRF_jyGhsuXjif3wgw=.1f467acf-b30d-4a67-97a7-9415dca3edfe@github.com> On Thu, 22 Aug 2024 11:01:36 GMT, Boris Ulasevich wrote: >> This is a clean backport to avoid a potentially rscratch1 register clobbering in C2_MacroAssembler::fast_lock. >> >> Testing: jtreg tier1-3 on linux-aarch64. > > Boris Ulasevich has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 387504c9e4b93d162dcef7c90c57c27295858d2e @bulasevich Your change (at version 0403e0e0da65383c9a712877a8fc0dc15790e5c3) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/941#issuecomment-2332141211 From bulasevich at openjdk.org Thu Sep 5 16:46:04 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Thu, 5 Sep 2024 16:46:04 GMT Subject: [jdk21u-dev] Integrated: 8317575: AArch64: C2_MacroAssembler::fast_lock uses rscratch1 for cmpxchg result In-Reply-To: References: Message-ID: <7b8XReUcOXlxVA2MMzcb8FsevPYIWp68STzpVJfyh2M=.90281f6c-ca50-4886-957e-aa3fc9d79148@github.com> On Wed, 21 Aug 2024 22:00:46 GMT, Boris Ulasevich wrote: > This is a clean backport to avoid a potentially rscratch1 register clobbering in C2_MacroAssembler::fast_lock. > > Testing: jtreg tier1-3 on linux-aarch64. This pull request has now been integrated. Changeset: a7e928c9 Author: Boris Ulasevich Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/a7e928c9acdcae00052d91136dde8f1516b8e081 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8317575: AArch64: C2_MacroAssembler::fast_lock uses rscratch1 for cmpxchg result Backport-of: 387504c9e4b93d162dcef7c90c57c27295858d2e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/941 From phh at openjdk.org Thu Sep 5 16:49:02 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 5 Sep 2024 16:49:02 GMT Subject: [jdk21u-dev] RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v2] In-Reply-To: <3uYV4BZlYy9tlgvoA3gUBv9ldA7qPfYJjNja-ESTz5g=.f157d60a-209d-46a0-b202-096450ff441a@github.com> References: <3uYV4BZlYy9tlgvoA3gUBv9ldA7qPfYJjNja-ESTz5g=.f157d60a-209d-46a0-b202-096450ff441a@github.com> Message-ID: On Thu, 22 Aug 2024 15:48:38 GMT, Dmitry Chuyko wrote: >> This is a backport of KAT fix for SHAKE256. The test provided in the bug description currently fails on JDK 21. SHA3 part is clean, SHAKE128 part is removed as it is a separate new API. > > Dmitry Chuyko has updated the pull request incrementally with one additional commit since the last revision: > > Deleted SHAKE128 implementation Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/902#pullrequestreview-2283603348 From bulasevich at openjdk.org Thu Sep 5 17:31:14 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Thu, 5 Sep 2024 17:31:14 GMT Subject: [jdk21u-dev] RFR: 8320682: [AArch64] C1 compilation fails with "Field too big for insn" Message-ID: Hi all, This is a backport of [JDK-8320682](https://github.com/openjdk/jdk/pull/16951) change to fix C1 internal error caused by adr limit being broken by too large NMethodSizeLimit option value. The backported patch includes a change to the TestC1Globals.java that does not yet exist in the jdk21u codebase. In the mainline the test has four updates: - [1] https://github.com/openjdk/jdk/commit/7df73a23 - [2] https://github.com/openjdk/jdk/commit/c36ec2ca - [3] https://github.com/openjdk/jdk/commit/69014cd5 (this change) - [4] https://github.com/openjdk/jdk/commit/27d5f5c2 With this change I simply copy version [3] of TestC1Globals.java corresponding to this change in jdk-23. Why not backport [1]+[2]+[3] to have a clean incremental patch? - I do not think [1] fits the backporting rules (not a crash fix, and not very important) - change [3] is stronger than change [2] (once NMethodSizeLimit is limited, no need to gracefully handle large values) Testing: jtreg tier1-3. Without the patch `$ fastdebug/bin/java -XX:NMethodSizeLimit=4M` causes the `guarantee(chk == -1 || chk == 0) failed: Field too big for insn`. With the change the 4M value becomes invalid. ------------- Commit messages: - Backport 69014cd55b59a0a63f4918fad575a6887640573e Changes: https://git.openjdk.org/jdk21u-dev/pull/956/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=956&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320682 Stats: 71 lines in 2 files changed: 69 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/956.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/956/head:pull/956 PR: https://git.openjdk.org/jdk21u-dev/pull/956 From duke at openjdk.org Thu Sep 5 19:48:28 2024 From: duke at openjdk.org (Kerem Kat) Date: Thu, 5 Sep 2024 19:48:28 GMT Subject: [jdk17u-dev] RFR: 8268364: jmethod clearing should be done during unloading Message-ID: Clean backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364). It fixes crashes when accessing jmethodIDs of a class being unloaded. Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 17. **Additional testing**: release and fastdebug with `JTREG_KEYWORDS="!headful & !external-dep & !printer"`, no new test failures with the patch. To run the repro: javac Main.java gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so java -agentpath:"$(pwd)/repro.so" -Xmx100m Main ------------- Commit messages: - Backport 3d84398d128bb2eed6280ebbc3f57afb3b89908f Changes: https://git.openjdk.org/jdk17u-dev/pull/2839/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2839&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8268364 Stats: 36 lines in 2 files changed: 20 ins; 13 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2839.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2839/head:pull/2839 PR: https://git.openjdk.org/jdk17u-dev/pull/2839 From goetz at openjdk.org Fri Sep 6 06:01:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Sep 2024 06:01:01 GMT Subject: [jdk21u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 10:24:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with Oracle 21.0.5 . GHA failure: ClhsdbFindPC.java Doesn't appear to be a HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote process. Seen also in other PRs, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/451#issuecomment-2333302212 From goetz at openjdk.org Fri Sep 6 06:05:00 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Sep 2024 06:05:00 GMT Subject: [jdk11u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 11:31:46 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.25-oracle. > > src/java.base/share/classes/sun/security/validator/CADistrustPolicy.java > * Resolved Copyright > src/java.base/share/classes/sun/security/validator/EntrustTLSPolicy.java > * Removed debug argument from getFingerprint() as "8270946: X509CertImpl.getFingerprint should not return the empty String" is not in 11. Yes, according to the crypto roadmap this must be in the October update. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/95#issuecomment-2333306545 From goetz at openjdk.org Fri Sep 6 06:09:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Sep 2024 06:09:01 GMT Subject: [jdk17u-dev] RFR: 8274505: Too weak variable type leads to unnecessary cast in java.desktop In-Reply-To: <9sRQS3Wanc4W3gH9O38d5Raka5re8-W9QqMtaZbu2DQ=.c8255e3e-da24-4e45-bdbb-a26e6227da04@github.com> References: <9sRQS3Wanc4W3gH9O38d5Raka5re8-W9QqMtaZbu2DQ=.c8255e3e-da24-4e45-bdbb-a26e6227da04@github.com> Message-ID: On Thu, 5 Sep 2024 13:01:50 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: ClhsdbFindPC, timeout and "DebuggerException: Doesn't appear to be a HotSpot VM (could not find symbol "gHotSpotVMIntConstants" in remote process". Similar we see in 21. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2848#issuecomment-2333311457 From goetz at openjdk.org Fri Sep 6 06:12:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Sep 2024 06:12:01 GMT Subject: [jdk17u-dev] RFR: 8071693: Introspector ignores default interface methods In-Reply-To: <6obDf4FsmA-sy2HLJ27G23FcV8HTltjH3tbJw-y8Wx8=.5101c6d3-1c3c-4378-9cea-84a5c88ba215@github.com> References: <6obDf4FsmA-sy2HLJ27G23FcV8HTltjH3tbJw-y8Wx8=.5101c6d3-1c3c-4378-9cea-84a5c88ba215@github.com> Message-ID: On Thu, 5 Sep 2024 13:16:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. GHA failures: macos: Well known ClhsdbFindPC issue, unrelated. hs-optimized: infra issue, wget failed. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2849#issuecomment-2333314989 From goetz at openjdk.org Fri Sep 6 06:14:03 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Sep 2024 06:14:03 GMT Subject: [jdk17u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 10:28:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: Well known ClhsdbFindPC issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/396#issuecomment-2333317079 From mbalao at openjdk.org Fri Sep 6 06:50:56 2024 From: mbalao at openjdk.org (Martin Balao) Date: Fri, 6 Sep 2024 06:50:56 GMT Subject: [jdk21u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases [v3] In-Reply-To: <_ai65rcM8t4chVfCgRctwuXUWzt906WGYL4ZrXTRFTk=.09ed4f51-1323-4936-8c86-0213a32bf9bf@github.com> References: <_ai65rcM8t4chVfCgRctwuXUWzt906WGYL4ZrXTRFTk=.09ed4f51-1323-4936-8c86-0213a32bf9bf@github.com> Message-ID: On Wed, 4 Sep 2024 18:19:16 GMT, Alexey Bakhtin wrote: >> This seems OK as a fix to improve compatibility with older JDK 21 versions that didn't use `statx`. Somebody else should review it too, though. > >> This seems OK as a fix to improve compatibility with older JDK 21 versions that didn't use `statx`. Somebody else should review it too, though. > > Thank you the review. @AlanBateman , @bplb could you please look at the changes for 21u. @alexeybakhtin Thanks for looking into this problem. I've followed the discussion (JDK main line and 21u-dev PRs) and the proposed changes. I have some concerns. As @AlanBateman mentioned [here](https://github.com/openjdk/jdk/pull/20484#issuecomment-2316814125), `EPERM` seems to be undocumented for `statx` and that's not ideal. Is this stable and consistent across all Kernel/glibc versions? Is there another reason for the implementation to return `EPERM`? If this is true, these cases will be penalized with a double-call (statx, stat). Is there another way to check what an active filter is blocking? With the proposed code, when running in a Docker container ?or, more generically, with a seccomp filter blocking statx? each call will be penalized going through `statx` and `stat` because the unavailability of `statx` due to a filter is never recorded. Recording this would require handling contention. I personally think that the problem has to be fixed on Docker's side, but I understand that this was a problematic change of behavior in stable releases. @jerboaa 8316304 is documented as an enhancement. Will something be broken if we back it off from 21u and 17u? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/951#issuecomment-2333363863 From jwtang at openjdk.org Fri Sep 6 06:59:50 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Fri, 6 Sep 2024 06:59:50 GMT Subject: [jdk21u-dev] RFR: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 06:25:42 GMT, Jiawei Tang wrote: >> 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option > > Hi, could I get help for this approval? > Hi @jia-wei-tang Are you targeting the October release? This backport will got to jdk21u-dev and thus only make the January release. > > If you target the October release you must make a PR against jdk21u and flag it jdk21u-critical-request. > > But maybe it is more safe to backout 8330146 from the October release? Can you Hi, It seems that there are some words lost. So, what's the recommended practice for me? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/910#issuecomment-2333376601 From alanb at openjdk.org Fri Sep 6 07:38:00 2024 From: alanb at openjdk.org (Alan Bateman) Date: Fri, 6 Sep 2024 07:38:00 GMT Subject: [jdk21u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases [v3] In-Reply-To: References: <_ai65rcM8t4chVfCgRctwuXUWzt906WGYL4ZrXTRFTk=.09ed4f51-1323-4936-8c86-0213a32bf9bf@github.com> Message-ID: On Fri, 6 Sep 2024 06:48:29 GMT, Martin Balao wrote: > As @AlanBateman mentioned [here](https://github.com/openjdk/jdk/pull/20484#issuecomment-2316814125), `EPERM` seems to be undocumented for `statx` and that's not ideal. Is this stable and consistent across all Kernel/glibc versions? Is there another reason for the implementation to return `EPERM`? Someone familiar with `seccomp` might be able to say for sure. I think it's that the seccomp filters cause EPERM to be returned rather than the glibc or actual sys call. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/951#issuecomment-2333434778 From goetz at openjdk.org Fri Sep 6 07:46:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Sep 2024 07:46:01 GMT Subject: [jdk21u-dev] RFR: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 08:26:00 GMT, Jiawei Tang wrote: > 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option Ah, there are two words too much. Thanks for the explanation, I will approve. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/910#issuecomment-2333447929 From duke at openjdk.org Fri Sep 6 08:29:58 2024 From: duke at openjdk.org (duke) Date: Fri, 6 Sep 2024 08:29:58 GMT Subject: [jdk21u-dev] RFR: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 08:26:00 GMT, Jiawei Tang wrote: > 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option @jia-wei-tang Your change (at version a591361214b3f5b6894bdb0231d50227c2a56a4d) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/910#issuecomment-2333522963 From goetz at openjdk.org Fri Sep 6 09:04:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Sep 2024 09:04:49 GMT Subject: [jdk21u-dev] RFR: 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 10:02:23 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [28de44da](https://github.com/openjdk/jdk/commit/28de44da71871bec7648f01a4df2faee43fa43b6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 5 Sep 2024 and was reviewed by Stefan Karlsson, Vladimir Kozlov and Dean Long. > > Thanks! You have failing tests. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/955#issuecomment-2333590174 From sgehwolf at openjdk.org Fri Sep 6 10:22:01 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 6 Sep 2024 10:22:01 GMT Subject: [jdk21u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases [v3] In-Reply-To: References: <_ai65rcM8t4chVfCgRctwuXUWzt906WGYL4ZrXTRFTk=.09ed4f51-1323-4936-8c86-0213a32bf9bf@github.com> Message-ID: On Fri, 6 Sep 2024 06:48:29 GMT, Martin Balao wrote: > I personally think that the problem has to be fixed on Docker's side, but I understand that this was a problematic change of behavior in stable releases. As mentioned in the bug it affects a rather old Docker release. Releases prior v18.4 (2019). It's been fixed in newer versions. So the question is how widespread is this? It must be systems where statx is available in the first place (kernel > 4.11 and glibc >= 2.28; systems not meeting the criteria won't use `statx`), but with the old docker version. There is a work-around to run the containers with the `--security-opt seccomp=`. > @jerboaa 8316304 is documented as an enhancement. Will something be broken if we back it off from 21u and 17u? JDK-8316304 adds birth time support on Linux. So that functionality will no longer be there if we back it out. Some users already rely on the feature, unfortunately. Either way we go somebody will be disappointed. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/951#issuecomment-2333741765 From goetz at openjdk.org Fri Sep 6 10:28:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Sep 2024 10:28:09 GMT Subject: [jdk17u-dev] RFR: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee Message-ID: <0V5ooW-WaAK4Kw7L90qVzmytqvOdppLondNsIPeqn4M=.176fa928-68b3-4c45-80ff-c71250ffba26@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 18a731a3e4ec85f0f3e8d6ff619b539c0daaf320 Changes: https://git.openjdk.org/jdk17u-dev/pull/2850/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2850&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8269770 Stats: 31 lines in 3 files changed: 4 ins; 19 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2850.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2850/head:pull/2850 PR: https://git.openjdk.org/jdk17u-dev/pull/2850 From goetz at openjdk.org Fri Sep 6 10:45:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Sep 2024 10:45:25 GMT Subject: [jdk21u-dev] RFR: 8331864: Update Public Suffix List to 1cbd6e7 Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport b91083341aba952befadd79020079920f9540999 Changes: https://git.openjdk.org/jdk21u-dev/pull/957/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=957&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331864 Stats: 568 lines in 5 files changed: 408 ins; 104 del; 56 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/957.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/957/head:pull/957 PR: https://git.openjdk.org/jdk21u-dev/pull/957 From goetz at openjdk.org Fri Sep 6 10:59:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Sep 2024 10:59:26 GMT Subject: [jdk17u-dev] RFR: 8331864: Update Public Suffix List to 1cbd6e7 Message-ID: <3tGkIHJnvSa2j826v1eUCenj5dcZccmqyrQ6-xKKNdY=.e7342f04-96db-4966-8b10-209c65aa3621@github.com> Fix request [17u] I backport this for parity with 17.0.14-oracle. One of the required updates of meta information. After adapting the paths, the patch applies clean. Test passes. ------------- Commit messages: - Backport b91083341aba952befadd79020079920f9540999 Changes: https://git.openjdk.org/jdk17u-dev/pull/2851/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2851&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331864 Stats: 568 lines in 5 files changed: 408 ins; 104 del; 56 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2851.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2851/head:pull/2851 PR: https://git.openjdk.org/jdk17u-dev/pull/2851 From dcherepanov at openjdk.org Fri Sep 6 11:18:32 2024 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Fri, 6 Sep 2024 11:18:32 GMT Subject: [jdk11u-dev] RFR: 8301118: Ignore allow and disallow options for java.security.manager System Property Message-ID: Proposing the change for parity with Oracle (fixed in 11.0.21-oracle). The change isn't a backport and it's implemented according to the description of https://bugs.openjdk.org/browse/JDK-8301118. New allow/disallow options for the java.security.manager system property should be ignored in JDK11. New test fails without the change and passes with the change. ------------- Commit messages: - 8301118: Ignore allow and disallow options for java.security.manager System Property Changes: https://git.openjdk.org/jdk11u-dev/pull/2932/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2932&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301118 Stats: 37 lines in 2 files changed: 37 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2932.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2932/head:pull/2932 PR: https://git.openjdk.org/jdk11u-dev/pull/2932 From goetz at openjdk.org Fri Sep 6 12:43:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Sep 2024 12:43:41 GMT Subject: [jdk17u-dev] RFR: 8293877: Rewrite MineField test Message-ID: I backport this for parity with 17.0.14-oracle. Does not apply clean because "8173605: Remove support for source and target 1.7 option in javac" which added -Xlint:-options in diagnostics.sh is not in 17. This appears in the new file, Diagnositcs.java:95. But I think this is ok for 17, actually -options makes sense since 9. So I do not change Diagnostics.java. Tests pass. ------------- Commit messages: - Backport e137f9f2f0e4244307900cd0eadceb9b773e9858 Changes: https://git.openjdk.org/jdk17u-dev/pull/2852/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2852&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293877 Stats: 3208 lines in 15 files changed: 1931 ins; 1276 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2852.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2852/head:pull/2852 PR: https://git.openjdk.org/jdk17u-dev/pull/2852 From goetz at openjdk.org Fri Sep 6 12:55:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Sep 2024 12:55:28 GMT Subject: [jdk17u-dev] RFR: 8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out" Message-ID: <35vLVqvX5Y9aiZssjVaRXUmjFql4feGGCfuNGmCXOT4=.85d433a5-0ceb-40fe-8a27-d934cc892599@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 8aae88b0fc4acb76ef140f120712403cf4b04a46 Changes: https://git.openjdk.org/jdk17u-dev/pull/2853/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2853&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8276763 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2853.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2853/head:pull/2853 PR: https://git.openjdk.org/jdk17u-dev/pull/2853 From sshivang at openjdk.org Fri Sep 6 16:08:38 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Fri, 6 Sep 2024 16:08:38 GMT Subject: [jdk23u] RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test Message-ID: This PR contains the changes of https://bugs.openjdk.org/browse/JDK-8335344 also. ------------- Commit messages: - Backport f4d8c005b35ce34c96027b7f3abb7a307bca3f4c Changes: https://git.openjdk.org/jdk23u/pull/93/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=93&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334562 Stats: 403 lines in 6 files changed: 210 ins; 170 del; 23 mod Patch: https://git.openjdk.org/jdk23u/pull/93.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/93/head:pull/93 PR: https://git.openjdk.org/jdk23u/pull/93 From sshivang at openjdk.org Fri Sep 6 16:29:16 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Fri, 6 Sep 2024 16:29:16 GMT Subject: [jdk23u] RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test In-Reply-To: References: Message-ID: On Fri, 6 Sep 2024 16:02:34 GMT, Shivangi Gupta wrote: > This PR contains the changes of https://bugs.openjdk.org/browse/JDK-8335344 also. @wangweij Can you please review this backport to 23 ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/93#issuecomment-2334414922 From jwtang at openjdk.org Fri Sep 6 18:03:19 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Fri, 6 Sep 2024 18:03:19 GMT Subject: [jdk21u-dev] Integrated: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 08:26:00 GMT, Jiawei Tang wrote: > 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option This pull request has now been integrated. Changeset: b0cd38bb Author: Jiawei Tang Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/b0cd38bbff8d0c48ba551dee735194f6a4c305f2 Stats: 83 lines in 2 files changed: 78 ins; 1 del; 4 mod 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option Backport-of: 55c509708e9b89a7609fd41b6e5a271f250bbacd ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/910 From abakhtin at openjdk.org Fri Sep 6 18:44:29 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 6 Sep 2024 18:44:29 GMT Subject: [jdk21u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases [v3] In-Reply-To: References: <_ai65rcM8t4chVfCgRctwuXUWzt906WGYL4ZrXTRFTk=.09ed4f51-1323-4936-8c86-0213a32bf9bf@github.com> Message-ID: On Fri, 6 Sep 2024 10:18:20 GMT, Severin Gehwolf wrote: > As mentioned in the bug it affects a rather old Docker release. Releases prior v18.4 (2019). It's been fixed in newer versions. So the question is how widespread is this? It must be systems where statx is available in the first place (kernel > 4.11 and glibc >= 2.28; systems not meeting the criteria won't use statx), but with the old docker version. It is always curious how strange the real configurations can be. For example, the the host is an old Linux version (e.g. Ubuntu 16) with an old Docker version ( < 18.4 ) runs modern Linux with JDK17/JDK21 inside the container. It could be the only way to run JDK17/JDK21 on such a system, and everything works fine except for statx/copy_file_range syscalls. > Someone familiar with seccomp might be able to say for sure. I think it's that the seccomp filters cause EPERM to be returned rather than the glibc or actual sys call. It is my understanding also that EPERM for statx is caused by seccomp only, but I can not find proof in the documentation. > With the proposed code, when running in a Docker container ?or, more generically, with a seccomp filter blocking statx? each call will be penalized going through statx and stat because the unavailability of statx due to a filter is never recorded. Recording this would require handling contention. As suggested by @bplb here https://github.com/openjdk/jdk/pull/20484#issuecomment-2312952018, we can remember if statx fails with EPERM on the first use and next time fallback to stat immediately. Checking seccomp profile at runtime without calling statx will require additional CAP_SYS_ADMIN privileges. So, I think it is not usable here ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/951#issuecomment-2334623179 From duke at openjdk.org Fri Sep 6 19:02:08 2024 From: duke at openjdk.org (duke) Date: Fri, 6 Sep 2024 19:02:08 GMT Subject: [jdk21u-dev] RFR: 8331393: AArch64: u32 _partial_subtype_ctr loaded/stored as 64 In-Reply-To: References: Message-ID: On Thu, 29 Aug 2024 02:40:11 GMT, Boris Ulasevich wrote: > Clean backport. A small change to use properly sized store/load instructions. > Affects only: AARCH fastdebug. > Tested: jtreg (hotspot&jdk) tier 1-3 @bulasevich Your change (at version ae62f0f4a6e268eaf60ffe3998cc9f21b442c594) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/949#issuecomment-2334647837 From mdoerr at openjdk.org Fri Sep 6 19:39:44 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 6 Sep 2024 19:39:44 GMT Subject: [jdk17u-dev] RFR: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer Message-ID: <0sUf-neM6pa9s9HoNUfSJXjL73aUBL0kpEPMt6Ad3nE=.1b5df45c-aac9-4d8d-8f58-ef16a800697f@github.com> Clean backport of [JDK-8331626](https://bugs.openjdk.org/browse/JDK-8331626). ------------- Commit messages: - Backport 23a72a1f2f651d5e8e9a0eb1e75e2b44572a13da Changes: https://git.openjdk.org/jdk17u-dev/pull/2854/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2854&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331626 Stats: 7 lines in 1 file changed: 0 ins; 4 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2854.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2854/head:pull/2854 PR: https://git.openjdk.org/jdk17u-dev/pull/2854 From goetz at openjdk.org Sun Sep 8 11:09:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 8 Sep 2024 11:09:15 GMT Subject: [jdk17u] RFR: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) In-Reply-To: References: Message-ID: <8kbHFMlsLgkYGwcgwWcD1dEUKaU6oC7jE2s1f61vxs0=.0c4555d1-f2ee-443b-ba20-ffe69f72cec1@github.com> On Mon, 2 Sep 2024 15:36:52 GMT, Severin Gehwolf wrote: > Clean backport to improve compatibility with JDK 17 versions which didn't support birth time (`17.0.10` and earlier). I.e. on those systems now last-modified-time is being returned when the statx syscall didn't fill in the birth time (is not supported for this filesystem). In `17.0.11` the epoch (or `0`) is returned for filesystems not supporting creation time. Proposing as a critical fix so as to get it into 17.0.13. > > CSR for 21-pool and 17-pool is the same as for JDK head. I also ran both these through SAP's testing. Approving. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/395#issuecomment-2336643181 From goetz at openjdk.org Sun Sep 8 11:31:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 8 Sep 2024 11:31:13 GMT Subject: [jdk17u-dev] RFR: 8268364: jmethod clearing should be done during unloading In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 10:31:10 GMT, Kerem Kat wrote: > Clean backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364). > > It fixes crashes when accessing jmethodIDs of a class being unloaded. > > Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). > > This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 17. > > **Additional testing**: release and fastdebug with `JTREG_KEYWORDS="!headful & !external-dep & !printer"`, no new test failures with the patch. > > To run the repro: > > > javac Main.java > gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so > > java -agentpath:"$(pwd)/repro.so" -Xmx100m Main Hi @krk, thanks for contributing. Please provide a useful fix request comment. See also https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix Removed the fix-request tag in the meantime. Please also check the GHA check failures. If they are unrealated to your PR, you can tell in a comment that you want to proceed anyways, else I assume you did not check them. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2839#issuecomment-2336648840 From goetz at openjdk.org Sun Sep 8 11:36:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 8 Sep 2024 11:36:13 GMT Subject: [jdk17u-dev] RFR: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee In-Reply-To: <0V5ooW-WaAK4Kw7L90qVzmytqvOdppLondNsIPeqn4M=.176fa928-68b3-4c45-80ff-c71250ffba26@github.com> References: <0V5ooW-WaAK4Kw7L90qVzmytqvOdppLondNsIPeqn4M=.176fa928-68b3-4c45-80ff-c71250ffba26@github.com> Message-ID: On Fri, 6 Sep 2024 10:23:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: Well known issue with https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2850#issuecomment-2336651021 From goetz at openjdk.org Sun Sep 8 11:37:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 8 Sep 2024 11:37:44 GMT Subject: [jdk21u-dev] RFR: 8331864: Update Public Suffix List to 1cbd6e7 Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport b91083341aba952befadd79020079920f9540999 Changes: https://git.openjdk.org/jdk21u-dev/pull/957/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=957&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331864 Stats: 568 lines in 5 files changed: 408 ins; 104 del; 56 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/957.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/957/head:pull/957 PR: https://git.openjdk.org/jdk21u-dev/pull/957 From goetz at openjdk.org Sun Sep 8 11:37:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 8 Sep 2024 11:37:44 GMT Subject: [jdk21u-dev] RFR: 8331864: Update Public Suffix List to 1cbd6e7 In-Reply-To: References: Message-ID: On Fri, 6 Sep 2024 10:38:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. GHA failure: Well known issue with https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/957#issuecomment-2336651295 From goetz at openjdk.org Sun Sep 8 11:38:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 8 Sep 2024 11:38:11 GMT Subject: [jdk17u-dev] RFR: 8331864: Update Public Suffix List to 1cbd6e7 In-Reply-To: <3tGkIHJnvSa2j826v1eUCenj5dcZccmqyrQ6-xKKNdY=.e7342f04-96db-4966-8b10-209c65aa3621@github.com> References: <3tGkIHJnvSa2j826v1eUCenj5dcZccmqyrQ6-xKKNdY=.e7342f04-96db-4966-8b10-209c65aa3621@github.com> Message-ID: On Fri, 6 Sep 2024 10:53:26 GMT, Goetz Lindenmaier wrote: > Fix request [17u] > > I backport this for parity with 17.0.14-oracle. > One of the required updates of meta information. > After adapting the paths, the patch applies clean. > Test passes. GHA failure: Well known issue with https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2851#issuecomment-2336651519 From goetz at openjdk.org Sun Sep 8 11:41:04 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 8 Sep 2024 11:41:04 GMT Subject: [jdk17u-dev] RFR: 8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out" In-Reply-To: <35vLVqvX5Y9aiZssjVaRXUmjFql4feGGCfuNGmCXOT4=.85d433a5-0ceb-40fe-8a27-d934cc892599@github.com> References: <35vLVqvX5Y9aiZssjVaRXUmjFql4feGGCfuNGmCXOT4=.85d433a5-0ceb-40fe-8a27-d934cc892599@github.com> Message-ID: On Fri, 6 Sep 2024 12:48:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: build failed, iinfra issue. Unrelated, this is a pure test fix. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2853#issuecomment-2336652436 From goetz at openjdk.org Sun Sep 8 12:37:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 8 Sep 2024 12:37:22 GMT Subject: [jdk21u] Integrated: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 10:24:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with Oracle 21.0.5 . This pull request has now been integrated. Changeset: 0b340d1d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u/commit/0b340d1d4a59eff54fba56e4cc5a984ed1fdcb74 Stats: 1103 lines in 13 files changed: 1101 ins; 0 del; 2 mod 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs Backport-of: 7d49c52272b54070a13b02708dd7ce5f8e375a06 ------------- PR: https://git.openjdk.org/jdk21u/pull/451 From goetz at openjdk.org Sun Sep 8 12:37:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 8 Sep 2024 12:37:27 GMT Subject: [jdk11u] Integrated: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: <9LxiGRdaph5BPgT9RR87soYqis38phj8ryGTjna7234=.77ef09d4-bd04-4912-8e21-570743cbb620@github.com> On Thu, 5 Sep 2024 11:31:46 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.25-oracle. > > src/java.base/share/classes/sun/security/validator/CADistrustPolicy.java > * Resolved Copyright > src/java.base/share/classes/sun/security/validator/EntrustTLSPolicy.java > * Removed debug argument from getFingerprint() as "8270946: X509CertImpl.getFingerprint should not return the empty String" is not in 11. This pull request has now been integrated. Changeset: 90ad5b18 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u/commit/90ad5b18de314faca19e322bb21a4c33cec54785 Stats: 1103 lines in 13 files changed: 1101 ins; 0 del; 2 mod 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs Reviewed-by: phh Backport-of: 7d49c52272b54070a13b02708dd7ce5f8e375a06 ------------- PR: https://git.openjdk.org/jdk11u/pull/95 From goetz at openjdk.org Sun Sep 8 12:38:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 8 Sep 2024 12:38:14 GMT Subject: [jdk17u] Integrated: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 10:28:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: aa46c353 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u/commit/aa46c353c7a9e2fea91599395fe9466387c83541 Stats: 1103 lines in 13 files changed: 1101 ins; 0 del; 2 mod 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs Backport-of: 7d49c52272b54070a13b02708dd7ce5f8e375a06 ------------- PR: https://git.openjdk.org/jdk17u/pull/396 From andrewlu at openjdk.org Mon Sep 9 05:37:52 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 9 Sep 2024 05:37:52 GMT Subject: [jdk17u-dev] RFR: 8336413: gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf Message-ID: I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 69baa7d2850fafbd89978db12eec683c286eb921 Changes: https://git.openjdk.org/jdk17u-dev/pull/2857/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2857&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336413 Stats: 6 lines in 2 files changed: 0 ins; 4 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2857.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2857/head:pull/2857 PR: https://git.openjdk.org/jdk17u-dev/pull/2857 From andrewlu at openjdk.org Mon Sep 9 05:37:58 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 9 Sep 2024 05:37:58 GMT Subject: [jdk21u-dev] RFR: 8328723: IP Address error when client enables HTTPS endpoint check on server socket Message-ID: <73w3E154zeqRijnYXHo9pkWhWwxvt90RGNmwY9WNEq0=.b3de929f-a4d3-43fe-8b29-6a8a5997978f@github.com> I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport 1b9270ac8a76b482103dd3f6b12606a22214e554 Changes: https://git.openjdk.org/jdk21u-dev/pull/959/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=959&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328723 Stats: 12 lines in 1 file changed: 9 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/959.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/959/head:pull/959 PR: https://git.openjdk.org/jdk21u-dev/pull/959 From andrewlu at openjdk.org Mon Sep 9 05:38:03 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 9 Sep 2024 05:38:03 GMT Subject: [jdk21u-dev] RFR: 8336413: gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf Message-ID: <1McKsi8zZQKGMUEbRvLmGwROZxxmkSAXA3jNa3MgjsQ=.b5d931c3-2479-43ff-8a77-80bd98229cc7@github.com> I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport 69baa7d2850fafbd89978db12eec683c286eb921 Changes: https://git.openjdk.org/jdk21u-dev/pull/960/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=960&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336413 Stats: 6 lines in 2 files changed: 0 ins; 4 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/960.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/960/head:pull/960 PR: https://git.openjdk.org/jdk21u-dev/pull/960 From andrewlu at openjdk.org Mon Sep 9 05:38:12 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 9 Sep 2024 05:38:12 GMT Subject: [jdk17u-dev] RFR: 8328723: IP Address error when client enables HTTPS endpoint check on server socket Message-ID: I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 1b9270ac8a76b482103dd3f6b12606a22214e554 Changes: https://git.openjdk.org/jdk17u-dev/pull/2856/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2856&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328723 Stats: 12 lines in 1 file changed: 9 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2856.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2856/head:pull/2856 PR: https://git.openjdk.org/jdk17u-dev/pull/2856 From andrewlu at openjdk.org Mon Sep 9 05:39:01 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 9 Sep 2024 05:39:01 GMT Subject: [jdk21u-dev] RFR: 8326611: Clean up vmTestbase/nsk/stress/stack tests Message-ID: I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport 972e81d1adb232b02114a5260d06144eb5b08849 Changes: https://git.openjdk.org/jdk21u-dev/pull/958/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=958&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326611 Stats: 5086 lines in 41 files changed: 2259 ins; 2825 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/958.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/958/head:pull/958 PR: https://git.openjdk.org/jdk21u-dev/pull/958 From andrewlu at openjdk.org Mon Sep 9 05:39:17 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 9 Sep 2024 05:39:17 GMT Subject: [jdk21u-dev] RFR: 8337320: Update ProblemList.txt with tests known to fail on XWayland Message-ID: I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport ddbd7a78f191462695ecbeeef7fd6312e322b15a Changes: https://git.openjdk.org/jdk21u-dev/pull/961/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=961&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337320 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/961.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/961/head:pull/961 PR: https://git.openjdk.org/jdk21u-dev/pull/961 From andrewlu at openjdk.org Mon Sep 9 05:39:29 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 9 Sep 2024 05:39:29 GMT Subject: [jdk17u-dev] RFR: 8337320: Update ProblemList.txt with tests known to fail on XWayland Message-ID: I backport this for parity with 17.0.13-oracle. Not clean, this file java/awt/FullScreen/SetFullScreenTest.java does not exist in jdk17 ------------- Commit messages: - Backport ddbd7a78f191462695ecbeeef7fd6312e322b15a Changes: https://git.openjdk.org/jdk17u-dev/pull/2858/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2858&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337320 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2858.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2858/head:pull/2858 PR: https://git.openjdk.org/jdk17u-dev/pull/2858 From andrewlu at openjdk.org Mon Sep 9 05:39:58 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 9 Sep 2024 05:39:58 GMT Subject: [jdk17u-dev] RFR: 8326611: Clean up vmTestbase/nsk/stress/stack tests Message-ID: I backport this for parity with 17.0.13-oracle. test/hotspot/jtreg/runtime/stack/Stack002.java ignored JDK-8289612: Change hotspot/jtreg tests to not use Thread.stop test/hotspot/jtreg/runtime/stack/Stack018.java ignored JDK-8278415 [TESTBUG] vmTestbase/nsk/stress/stack/stack018.java fails with "java.lang.Error: TEST_RFE" ------------- Commit messages: - Backport 972e81d1adb232b02114a5260d06144eb5b08849 Changes: https://git.openjdk.org/jdk17u-dev/pull/2855/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2855&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326611 Stats: 5098 lines in 41 files changed: 2265 ins; 2831 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2855.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2855/head:pull/2855 PR: https://git.openjdk.org/jdk17u-dev/pull/2855 From goetz at openjdk.org Mon Sep 9 05:51:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 9 Sep 2024 05:51:10 GMT Subject: [jdk17u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v3] In-Reply-To: References: Message-ID: <32npCR_JcO8Lw_Mr3SBgHLyc80yOTkPtzu_odDkjqtc=.fb650fea-d364-49cc-ac0b-04c30c0e9c9e@github.com> On Thu, 22 Aug 2024 08:29:14 GMT, Andrew Lu wrote: >> I backport this for parity with 17.0.13-oracle. >> modify lines are different, but code is clean. > > Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: > > - Merge branch 'master' into andrewLu_backport_8320675 > - fix > - Backport 9f5ad43358a4e209b4cd1c91bcc86b997f371548 Hi Andrew, they changed the review process. If a PR is modified after it has been reviewed, the review is invalidated and it need a new review. I'll take a look. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2807#issuecomment-2337180001 From goetz at openjdk.org Mon Sep 9 06:09:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 9 Sep 2024 06:09:08 GMT Subject: [jdk17u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v3] In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 08:29:14 GMT, Andrew Lu wrote: >> I backport this for parity with 17.0.13-oracle. >> modify lines are different, but code is clean. > > Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: > > - Merge branch 'master' into andrewLu_backport_8320675 > - fix > - Backport 9f5ad43358a4e209b4cd1c91bcc86b997f371548 Hi Andrew, can you please change the "/**" in line 38 to be "/*". Also, please fix the indentation of the String list in INSTRUCTIONS At the very end of the file a CR is missing. Thanks, Goetz. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2807#issuecomment-2337203289 From goetz at openjdk.org Mon Sep 9 06:21:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 9 Sep 2024 06:21:06 GMT Subject: [jdk17u-dev] RFR: 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 05:58:02 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. > > test/jdk/java/net/httpclient/AuthFilterCacheTest.java > test/jdk/java/net/httpclient/ConcurrentResponses.java > ignored this commit: https://github.com/openjdk/jdk/commit/736b90d54b51830de7757a8de3ad9c98437c824a > > test/jdk/java/net/httpclient/MappingResponseSubscriber.java > ignored this commit https://github.com/openjdk/jdk/commit/49d60fee49b9f5f7182dcd1557d9b2f886901100 LGTM ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2819#pullrequestreview-2288908549 From andrewlu at openjdk.org Mon Sep 9 06:36:20 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 9 Sep 2024 06:36:20 GMT Subject: [jdk17u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v4] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.13-oracle. > modify lines are different, but code is clean. Andrew Lu has updated the pull request incrementally with two additional commits since the last revision: - Merge remote-tracking branch 'origin/andrewLu_backport_8320675' into andrewLu_backport_8320675 - fix ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2807/files - new: https://git.openjdk.org/jdk17u-dev/pull/2807/files/34364b84..75e16792 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2807&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2807&range=02-03 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2807.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2807/head:pull/2807 PR: https://git.openjdk.org/jdk17u-dev/pull/2807 From andrewlu at openjdk.org Mon Sep 9 06:39:05 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 9 Sep 2024 06:39:05 GMT Subject: [jdk17u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v3] In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 06:06:56 GMT, Goetz Lindenmaier wrote: > Hi Andrew, > > can you please change the "/**" in line 38 to be "/*". Also, please fix the indentation of the String list in INSTRUCTIONS At the very end of the file a CR is missing. > > Thanks, Goetz. hi @GoeLin , it's fixed, please check, thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2807#issuecomment-2337244101 From andrewlu at openjdk.org Mon Sep 9 06:39:47 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 9 Sep 2024 06:39:47 GMT Subject: [jdk11u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.25-oracle. > modify lines are different, but code is clean. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: fix ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2912/files - new: https://git.openjdk.org/jdk11u-dev/pull/2912/files/50f1cb5c..593b5a54 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2912&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2912&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2912.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2912/head:pull/2912 PR: https://git.openjdk.org/jdk11u-dev/pull/2912 From goetz at openjdk.org Mon Sep 9 06:54:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 9 Sep 2024 06:54:13 GMT Subject: [jdk17u-dev] RFR: 8286160: (fs) Files.exists returns unexpected results with C:\pagefile.sys because it's not readable Message-ID: A clean backport to fix this windows issue. ------------- Commit messages: - Backport d482d7f5b99e89185471c05cde797f13405c32f2 Changes: https://git.openjdk.org/jdk17u-dev/pull/2859/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2859&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286160 Stats: 47 lines in 2 files changed: 33 ins; 3 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2859.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2859/head:pull/2859 PR: https://git.openjdk.org/jdk17u-dev/pull/2859 From mbaesken at openjdk.org Mon Sep 9 07:16:08 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 9 Sep 2024 07:16:08 GMT Subject: [jdk17u-dev] RFR: 8331864: Update Public Suffix List to 1cbd6e7 In-Reply-To: <3tGkIHJnvSa2j826v1eUCenj5dcZccmqyrQ6-xKKNdY=.e7342f04-96db-4966-8b10-209c65aa3621@github.com> References: <3tGkIHJnvSa2j826v1eUCenj5dcZccmqyrQ6-xKKNdY=.e7342f04-96db-4966-8b10-209c65aa3621@github.com> Message-ID: On Fri, 6 Sep 2024 10:53:26 GMT, Goetz Lindenmaier wrote: > Fix request [17u] > > I backport this for parity with 17.0.14-oracle. > One of the required updates of meta information. > After adapting the paths, the patch applies clean. > Test passes. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2851#pullrequestreview-2289001586 From syan at openjdk.org Mon Sep 9 07:20:31 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 9 Sep 2024 07:20:31 GMT Subject: [jdk23u] RFR: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds Message-ID: Hi all, This pull request contains a backport of commit [a18d9d84](https://github.com/openjdk/jdk/commit/a18d9d84cd92b0b7e7c3c83efab1d81773e3a87c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jan Lahoda on 9 Sep 2024 and was reviewed by Aggelos Biboudis. Thanks! ------------- Commit messages: - Backport a18d9d84cd92b0b7e7c3c83efab1d81773e3a87c Changes: https://git.openjdk.org/jdk23u/pull/95/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=95&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326616 Stats: 75 lines in 2 files changed: 21 ins; 35 del; 19 mod Patch: https://git.openjdk.org/jdk23u/pull/95.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/95/head:pull/95 PR: https://git.openjdk.org/jdk23u/pull/95 From mbaesken at openjdk.org Mon Sep 9 07:23:05 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 9 Sep 2024 07:23:05 GMT Subject: [jdk17u-dev] RFR: 8293877: Rewrite MineField test In-Reply-To: References: Message-ID: On Fri, 6 Sep 2024 12:38:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Does not apply clean because "8173605: Remove support for source and target 1.7 option in javac" which added -Xlint:-options in diagnostics.sh is not in 17. > This appears in the new file, Diagnositcs.java:95. But I think this is ok for 17, actually -options makes sense since 9. So I do not change Diagnostics.java. > > Tests pass. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2852#pullrequestreview-2289027192 From fyang at openjdk.org Mon Sep 9 07:29:47 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 9 Sep 2024 07:29:47 GMT Subject: [jdk23u] RFR: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap Message-ID: Hi all, This pull request contains a backport of commit [9e0ccb8b](https://github.com/openjdk/jdk/commit/9e0ccb8bbd01ffbac466288977a770dd09e357af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Fei Yang on 6 Sep 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson. Thanks! Testing: - [ ] GHA ------------- Commit messages: - Backport 9e0ccb8bbd01ffbac466288977a770dd09e357af Changes: https://git.openjdk.org/jdk23u/pull/94/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=94&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339548 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/94.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/94/head:pull/94 PR: https://git.openjdk.org/jdk23u/pull/94 From sgehwolf at openjdk.org Mon Sep 9 08:07:21 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 9 Sep 2024 08:07:21 GMT Subject: [jdk21u] Integrated: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 11:03:26 GMT, Severin Gehwolf wrote: > Clean backport to improve compatibility with JDK 21 versions which didn't support birth time. I.e. on those systems now last-modified-time is being returned when the `statx` syscall didn't fill in the birth time (is not supported for this filesystem). Proposing as a critical fix so as to get it into 21.0.5. > > CSR for 21-pool and 17-pool is the same as for JDK head and is approved. This pull request has now been integrated. Changeset: c4d39f30 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk21u/commit/c4d39f3041374d27bae385fbca9a467cb19cda5b Stats: 21 lines in 1 file changed: 12 ins; 0 del; 9 mod 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) Backport-of: c89a1c35bda9002ee687b3fa267f3ef9cba78b00 ------------- PR: https://git.openjdk.org/jdk21u/pull/450 From mdoerr at openjdk.org Mon Sep 9 08:26:05 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 9 Sep 2024 08:26:05 GMT Subject: [jdk17u-dev] RFR: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer In-Reply-To: <0sUf-neM6pa9s9HoNUfSJXjL73aUBL0kpEPMt6Ad3nE=.1b5df45c-aac9-4d8d-8f58-ef16a800697f@github.com> References: <0sUf-neM6pa9s9HoNUfSJXjL73aUBL0kpEPMt6Ad3nE=.1b5df45c-aac9-4d8d-8f58-ef16a800697f@github.com> Message-ID: On Fri, 6 Sep 2024 19:33:45 GMT, Martin Doerr wrote: > Clean backport of [JDK-8331626](https://bugs.openjdk.org/browse/JDK-8331626). GHA test failure is unrelated. Nightly tests have passed on all SAP-supported platforms. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2854#issuecomment-2337450860 From goetz at openjdk.org Mon Sep 9 08:42:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 9 Sep 2024 08:42:13 GMT Subject: [jdk21u-dev] RFR: 8337320: Update ProblemList.txt with tests known to fail on XWayland In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 05:32:34 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.6-oracle. Hi Andrew, as in 17, SetFullScreenTest is not in 21. Please remove it. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/961#issuecomment-2337491556 From fyang at openjdk.org Mon Sep 9 08:52:39 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 9 Sep 2024 08:52:39 GMT Subject: [jdk17u-dev] RFR: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap Message-ID: Hi all, This pull request contains a backport of commit [9e0ccb8b](https://github.com/openjdk/jdk/commit/9e0ccb8bbd01ffbac466288977a770dd09e357af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Fei Yang on 6 Sep 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson. Thanks! Testing: - [x] GHA linux-cross-build job ------------- Commit messages: - Backport 9e0ccb8bbd01ffbac466288977a770dd09e357af Changes: https://git.openjdk.org/jdk17u-dev/pull/2860/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2860&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339548 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2860.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2860/head:pull/2860 PR: https://git.openjdk.org/jdk17u-dev/pull/2860 From fyang at openjdk.org Mon Sep 9 08:52:45 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 9 Sep 2024 08:52:45 GMT Subject: [jdk21u-dev] RFR: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap Message-ID: Hi all, This pull request contains a backport of commit [9e0ccb8b](https://github.com/openjdk/jdk/commit/9e0ccb8bbd01ffbac466288977a770dd09e357af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Fei Yang on 6 Sep 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson. Thanks! Testing: - [x] GHA linux-cross-build job ------------- Commit messages: - Backport 9e0ccb8bbd01ffbac466288977a770dd09e357af Changes: https://git.openjdk.org/jdk21u-dev/pull/962/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=962&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339548 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/962.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/962/head:pull/962 PR: https://git.openjdk.org/jdk21u-dev/pull/962 From goetz at openjdk.org Mon Sep 9 08:54:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 9 Sep 2024 08:54:07 GMT Subject: [jdk17u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v4] In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 06:36:20 GMT, Andrew Lu wrote: >> I backport this for parity with 17.0.13-oracle. >> modify lines are different, but code is clean. > > Andrew Lu has updated the pull request incrementally with two additional commits since the last revision: > > - Merge remote-tracking branch 'origin/andrewLu_backport_8320675' into andrewLu_backport_8320675 > - fix test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 60: > 58: "\n" + > 59: "The dialogs should be displayed even when \n" + > 60: "there is no queuePrintJob permission."; The indentation is wrong. The file should be identical with the one in 21 after this change. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2807#discussion_r1749852246 From sgehwolf at openjdk.org Mon Sep 9 09:15:11 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 9 Sep 2024 09:15:11 GMT Subject: [jdk17u] RFR: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) In-Reply-To: References: Message-ID: <6tPgvaQa8_pDuTLegRSTYAUp5xzefYZXgJGrLo83x-I=.1e93126e-05a3-413a-b9a3-878e5d450bf8@github.com> On Mon, 2 Sep 2024 15:36:52 GMT, Severin Gehwolf wrote: > Clean backport to improve compatibility with JDK 17 versions which didn't support birth time (`17.0.10` and earlier). I.e. on those systems now last-modified-time is being returned when the statx syscall didn't fill in the birth time (is not supported for this filesystem). In `17.0.11` the epoch (or `0`) is returned for filesystems not supporting creation time. Proposing as a critical fix so as to get it into 17.0.13. > > CSR for 21-pool and 17-pool is the same as for JDK head. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/395#issuecomment-2337566439 From sgehwolf at openjdk.org Mon Sep 9 09:15:11 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 9 Sep 2024 09:15:11 GMT Subject: [jdk17u] Integrated: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 15:36:52 GMT, Severin Gehwolf wrote: > Clean backport to improve compatibility with JDK 17 versions which didn't support birth time (`17.0.10` and earlier). I.e. on those systems now last-modified-time is being returned when the statx syscall didn't fill in the birth time (is not supported for this filesystem). In `17.0.11` the epoch (or `0`) is returned for filesystems not supporting creation time. Proposing as a critical fix so as to get it into 17.0.13. > > CSR for 21-pool and 17-pool is the same as for JDK head. This pull request has now been integrated. Changeset: f95f7f4a Author: Severin Gehwolf URL: https://git.openjdk.org/jdk17u/commit/f95f7f4a1163a5f62bdcac16199207ed736fdc15 Stats: 21 lines in 1 file changed: 12 ins; 0 del; 9 mod 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) Backport-of: c89a1c35bda9002ee687b3fa267f3ef9cba78b00 ------------- PR: https://git.openjdk.org/jdk17u/pull/395 From duke at openjdk.org Mon Sep 9 09:28:13 2024 From: duke at openjdk.org (duke) Date: Mon, 9 Sep 2024 09:28:13 GMT Subject: [jdk23u] RFR: 8338402: GHA: some of bundles may not get removed In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 16:03:47 GMT, Zdenek Zambersky wrote: > Backport fixing problem, where some bundles may not get removed in GHA. > > GHA testing: OK (no leftover bundles) @zzambers Your change (at version 29a8a334f255257cb8f0dcf73cd7023fc402929f) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/89#issuecomment-2337596330 From duke at openjdk.org Mon Sep 9 09:30:10 2024 From: duke at openjdk.org (duke) Date: Mon, 9 Sep 2024 09:30:10 GMT Subject: [jdk21u-dev] RFR: 8338402: GHA: some of bundles may not get removed In-Reply-To: References: Message-ID: <7o5kXLpwTos1WGyYo94dt02xiHlGmiDq1lSI5S-RuKE=.af0e9a2e-bf16-406b-83cb-775d72a1b834@github.com> On Mon, 2 Sep 2024 16:08:53 GMT, Zdenek Zambersky wrote: > Backport fixing problem, where some bundles may not get removed in GHA. > > GHA testing: OK (no leftover bundles) @zzambers Your change (at version 8cc81ad81664fb71622e7f540375e0214e308f36) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/952#issuecomment-2337600448 From zzambers at openjdk.org Mon Sep 9 09:30:10 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 9 Sep 2024 09:30:10 GMT Subject: [jdk21u-dev] RFR: 8338402: GHA: some of bundles may not get removed In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 16:08:53 GMT, Zdenek Zambersky wrote: > Backport fixing problem, where some bundles may not get removed in GHA. > > GHA testing: OK (no leftover bundles) Note: this should probably wait for 23u: https://github.com/openjdk/jdk23u/pull/89 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/952#issuecomment-2337601981 From duke at openjdk.org Mon Sep 9 09:33:10 2024 From: duke at openjdk.org (duke) Date: Mon, 9 Sep 2024 09:33:10 GMT Subject: [jdk17u-dev] RFR: 8338402: GHA: some of bundles may not get removed In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 16:09:54 GMT, Zdenek Zambersky wrote: > Backport fixing problem, where some bundles may not get removed in GHA. > > GHA testing: OK (no leftover bundles) @zzambers Your change (at version a27fd14dd2cb3a8d5babdb7bbc81c6762a2761ab) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2841#issuecomment-2337607046 From zzambers at openjdk.org Mon Sep 9 09:33:10 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 9 Sep 2024 09:33:10 GMT Subject: [jdk17u-dev] RFR: 8338402: GHA: some of bundles may not get removed In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 16:09:54 GMT, Zdenek Zambersky wrote: > Backport fixing problem, where some bundles may not get removed in GHA. > > GHA testing: OK (no leftover bundles) Note: this should wait for 21u-dev: https://github.com/openjdk/jdk21u-dev/pull/952 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2841#issuecomment-2337607692 From coffeys at openjdk.org Mon Sep 9 09:59:07 2024 From: coffeys at openjdk.org (Sean Coffey) Date: Mon, 9 Sep 2024 09:59:07 GMT Subject: [jdk17u-dev] RFR: 8339470: [17u] More defensive fix for 8163921 In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 10:19:06 GMT, Goetz Lindenmaier wrote: > This does not remove the header specifications, it just fixes the error. > > Well, it removes * as type, but that is illegal and should be meant to match the same as */*. https://github.com/openjdk/jdk17u-dev/blob/151dfb6d8d8078fb624f32a1af64a4774761aea5/test/jdk/sun/net/www/B8185898.java#L26 No harm to add the bug id as reference to test case also ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2843#issuecomment-2337667879 From sgehwolf at openjdk.org Mon Sep 9 10:00:10 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 9 Sep 2024 10:00:10 GMT Subject: [jdk21u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 15:48:49 GMT, SendaoYan wrote: > Hi all, > Test `java/nio/channels/DatagramChannel/Disconnect.java` compile error: `cannot find symbol InetAddress.ofLiteral` after JDK-8299813. There is no `InetAddress.ofLiteral` API in jdk21u and jdk17u, the `InetAddress.ofLiteral` API was added by [JDK-8272215](https://bugs.openjdk.org/browse/JDK-8272215) in jdk22. > Change `InetAddress.ofLiteral`to `Inet6Address.getByName`, change has been verified, test fix only, no risk. The point here is, AFAIK, to do parsing without the reverse look-up. The [javadoc](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/net/InetAddress.html#getByName(java.lang.String)) states for `getByName()`: The host name can either be a machine name, such as "www.example.com", or a textual representation of its IP address. If a literal IP address is supplied, only the validity of the address format is checked. So the replacement seems OK in principle. Did you run the test? test/jdk/java/nio/channels/DatagramChannel/Disconnect.java line 55: > 53: // test with IPv4 only > 54: try (DatagramChannel dc = DatagramChannel.open(StandardProtocolFamily.INET)) { > 55: InetAddress lo4 = Inet4Address.getByName("127.0.0.1"); `Inet4Address` doesn't override `getByName()` we should use `InetAddress` instead. Suggestion: InetAddress lo4 = InetAddress.getByName("127.0.0.1"); test/jdk/java/nio/channels/DatagramChannel/Disconnect.java line 65: > 63: // test with IPv6 only > 64: try (DatagramChannel dc = DatagramChannel.open(StandardProtocolFamily.INET6)) { > 65: InetAddress lo6 = Inet6Address.getByName("::1"); Suggestion: InetAddress lo6 = InetAddress.getByName("::1"); ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/939#pullrequestreview-2289433763 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/939#discussion_r1749955684 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/939#discussion_r1749956255 From duke at openjdk.org Mon Sep 9 10:26:12 2024 From: duke at openjdk.org (Kerem Kat) Date: Mon, 9 Sep 2024 10:26:12 GMT Subject: [jdk17u-dev] RFR: 8268364: jmethod clearing should be done during unloading In-Reply-To: References: Message-ID: On Sun, 8 Sep 2024 11:26:11 GMT, Goetz Lindenmaier wrote: >> Clean backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364). >> >> It fixes crashes when accessing jmethodIDs of a class being unloaded. >> >> Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). >> >> This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 17. >> >> **Additional testing**: release and fastdebug with `JTREG_KEYWORDS="!headful & !external-dep & !printer"`, no new test failures with the patch. >> >> To run the repro: >> >> >> javac Main.java >> gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so >> >> java -agentpath:"$(pwd)/repro.so" -Xmx100m Main > > Hi @krk, > thanks for contributing. > Please provide a useful fix request comment. See also https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix > Removed the fix-request tag in the meantime. > Please also check the GHA check failures. If they are unrealated to your PR, you can tell in a comment that you want to proceed anyways, else I assume you did not check them. Hi @GoeLin, Thanks for your input. I intend to backport this into 11 and 8 too. GHA failure at [[serviceability/sa/ClhsdbFindPC#id2](https://github.com/krk/jdk17u-dev/actions/runs/10631432422/attempts/3#user-content-serviceability_sa_clhsdbfindpc#id2](https://github.com/krk/jdk17u-dev/actions/runs/10631432422/job/29560140545)) can be seen failing without the patch, e.g. in https://github.com/openjdk/jdk17u-dev/pull/2843#issuecomment-2326533656: Error: java.lang.RuntimeException: Unable to deduce type of thread from address 0x000000012f808810 (expected type JavaThread, CompilerThread, MonitorDeflationThread, ServiceThread, JvmtiAgentThread or CodeCacheSweeperThread). This is unrelated to the current PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2839#issuecomment-2337731253 From fyang at openjdk.org Mon Sep 9 11:33:15 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 9 Sep 2024 11:33:15 GMT Subject: [jdk23u] RFR: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 06:50:07 GMT, Fei Yang wrote: > Hi all, > > This pull request contains a backport of commit [9e0ccb8b](https://github.com/openjdk/jdk/commit/9e0ccb8bbd01ffbac466288977a770dd09e357af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fei Yang on 6 Sep 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson. > > Thanks! > > Testing: > - [x] GHA linux-cross-build job GHA test failure is unrelated. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/94#issuecomment-2337862955 From sshivang at openjdk.org Mon Sep 9 11:53:11 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Mon, 9 Sep 2024 11:53:11 GMT Subject: [jdk23u] RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test In-Reply-To: References: Message-ID: On Fri, 6 Sep 2024 16:02:34 GMT, Shivangi Gupta wrote: > This PR contains the changes of https://bugs.openjdk.org/browse/JDK-8335344 also. @coffeys Can you please review this. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/93#issuecomment-2337910835 From coffeys at openjdk.org Mon Sep 9 13:47:18 2024 From: coffeys at openjdk.org (Sean Coffey) Date: Mon, 9 Sep 2024 13:47:18 GMT Subject: [jdk23u] RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test In-Reply-To: References: Message-ID: On Fri, 6 Sep 2024 16:02:34 GMT, Shivangi Gupta wrote: > This PR contains the changes of https://bugs.openjdk.org/browse/JDK-8335344 also. LGTM ------------- Marked as reviewed by coffeys (Reviewer). PR Review: https://git.openjdk.org/jdk23u/pull/93#pullrequestreview-2289972254 From syan at openjdk.org Mon Sep 9 14:05:14 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 9 Sep 2024 14:05:14 GMT Subject: [jdk21u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 09:57:40 GMT, Severin Gehwolf wrote: > So the replacement seems OK in principle. Did you run the test? Yes, the change has been verified locally. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/939#issuecomment-2338215735 From syan at openjdk.org Mon Sep 9 14:14:29 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 9 Sep 2024 14:14:29 GMT Subject: [jdk21u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 [v2] In-Reply-To: References: Message-ID: > Hi all, > Test `java/nio/channels/DatagramChannel/Disconnect.java` compile error: `cannot find symbol InetAddress.ofLiteral` after JDK-8299813. There is no `InetAddress.ofLiteral` API in jdk21u and jdk17u, the `InetAddress.ofLiteral` API was added by [JDK-8272215](https://bugs.openjdk.org/browse/JDK-8272215) in jdk22. > Change `InetAddress.ofLiteral`to `Inet6Address.getByName`, change has been verified, test fix only, no risk. SendaoYan has updated the pull request incrementally with one additional commit since the last revision: change Inet4Address.getByName and Inet6Address.getByName to InetAddress.getByName ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/939/files - new: https://git.openjdk.org/jdk21u-dev/pull/939/files/151843d8..125f1721 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=939&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=939&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/939.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/939/head:pull/939 PR: https://git.openjdk.org/jdk21u-dev/pull/939 From syan at openjdk.org Mon Sep 9 14:14:29 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 9 Sep 2024 14:14:29 GMT Subject: [jdk21u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 [v2] In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 09:53:41 GMT, Severin Gehwolf wrote: >> SendaoYan has updated the pull request incrementally with one additional commit since the last revision: >> >> change Inet4Address.getByName and Inet6Address.getByName to InetAddress.getByName > > test/jdk/java/nio/channels/DatagramChannel/Disconnect.java line 55: > >> 53: // test with IPv4 only >> 54: try (DatagramChannel dc = DatagramChannel.open(StandardProtocolFamily.INET)) { >> 55: InetAddress lo4 = Inet4Address.getByName("127.0.0.1"); > > `Inet4Address` doesn't override `getByName()` we should use `InetAddress` instead. > > Suggestion: > > InetAddress lo4 = InetAddress.getByName("127.0.0.1"); Thanks for the review. Inet4Address.getByName and Inet6Address.getByName has been change to InetAddress.getByName. The change has been verified locally. > test/jdk/java/nio/channels/DatagramChannel/Disconnect.java line 65: > >> 63: // test with IPv6 only >> 64: try (DatagramChannel dc = DatagramChannel.open(StandardProtocolFamily.INET6)) { >> 65: InetAddress lo6 = Inet6Address.getByName("::1"); > > Suggestion: > > InetAddress lo6 = InetAddress.getByName("::1"); Same to above. ------------- PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/939#discussion_r1750349154 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/939#discussion_r1750349649 From sgehwolf at openjdk.org Mon Sep 9 14:31:06 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 9 Sep 2024 14:31:06 GMT Subject: [jdk21u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 [v2] In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 14:14:29 GMT, SendaoYan wrote: >> Hi all, >> Test `java/nio/channels/DatagramChannel/Disconnect.java` compile error: `cannot find symbol InetAddress.ofLiteral` after JDK-8299813. There is no `InetAddress.ofLiteral` API in jdk21u and jdk17u, the `InetAddress.ofLiteral` API was added by [JDK-8272215](https://bugs.openjdk.org/browse/JDK-8272215) in jdk22. >> Change `InetAddress.ofLiteral`to `Inet6Address.getByName`, change has been verified, test fix only, no risk. > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > change Inet4Address.getByName and Inet6Address.getByName to InetAddress.getByName Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/939#pullrequestreview-2290103930 From rob.mckenna at oracle.com Mon Sep 9 15:21:34 2024 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Mon, 9 Sep 2024 15:21:34 +0000 Subject: Result: CFV: New JDK Updates Committer - Ravi Reddy Message-ID: Voting for Ravi Reddy [1] is now closed. Yes: 6 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. -Rob [1] https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-August/036824.html From syan at openjdk.org Mon Sep 9 15:43:08 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 9 Sep 2024 15:43:08 GMT Subject: [jdk21u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 [v2] In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 14:14:29 GMT, SendaoYan wrote: >> Hi all, >> Test `java/nio/channels/DatagramChannel/Disconnect.java` compile error: `cannot find symbol InetAddress.ofLiteral` after JDK-8299813. There is no `InetAddress.ofLiteral` API in jdk21u and jdk17u, the `InetAddress.ofLiteral` API was added by [JDK-8272215](https://bugs.openjdk.org/browse/JDK-8272215) in jdk22. >> Change `InetAddress.ofLiteral`to `Inet6Address.getByName`, change has been verified, test fix only, no risk. > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > change Inet4Address.getByName and Inet6Address.getByName to InetAddress.getByName Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/939#issuecomment-2338458397 From duke at openjdk.org Mon Sep 9 18:37:17 2024 From: duke at openjdk.org (duke) Date: Mon, 9 Sep 2024 18:37:17 GMT Subject: [jdk21u-dev] Withdrawn: 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 In-Reply-To: <5VtI93ebemu9HNAzcz54lzHFSd4jef9H0gPaRR0WBXk=.d2b83b05-f0f3-483a-be1a-7434175a9201@github.com> References: <5VtI93ebemu9HNAzcz54lzHFSd4jef9H0gPaRR0WBXk=.d2b83b05-f0f3-483a-be1a-7434175a9201@github.com> Message-ID: On Tue, 23 Apr 2024 07:34:36 GMT, Aleksey Shipilev wrote: > Uncleanliness comes from JDK 21 not having [JDK-8313882](https://bugs.openjdk.org/browse/JDK-8313882), so I had to rewrite the incoming hunks back to `INT64_FORMAT` and `int64_t` casts. This can be made clean by [JDK-8313882](https://bugs.openjdk.org/browse/JDK-8313882) backport, but it has follow-up bugs that break Graal. It seems a better choice to just do a little deviation here. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, new regression tests fail without the fix, pass with it > - [x] Linux AArch64 server fastdebug, `all` > - [x] Linux x86_64 server fastdebug, `all` This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/523 From fyang at openjdk.org Tue Sep 10 02:29:12 2024 From: fyang at openjdk.org (Fei Yang) Date: Tue, 10 Sep 2024 02:29:12 GMT Subject: [jdk21u-dev] RFR: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 06:58:16 GMT, Fei Yang wrote: > Hi all, > > This pull request contains a backport of commit [9e0ccb8b](https://github.com/openjdk/jdk/commit/9e0ccb8bbd01ffbac466288977a770dd09e357af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fei Yang on 6 Sep 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson. > > Thanks! > > Testing: > - [x] GHA linux-cross-build job GHA test failure is unrelated. GHA linux-cross-build job works after this change. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/962#issuecomment-2339484680 From fyang at openjdk.org Tue Sep 10 02:30:15 2024 From: fyang at openjdk.org (Fei Yang) Date: Tue, 10 Sep 2024 02:30:15 GMT Subject: [jdk17u-dev] RFR: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 06:58:45 GMT, Fei Yang wrote: > Hi all, > > This pull request contains a backport of commit [9e0ccb8b](https://github.com/openjdk/jdk/commit/9e0ccb8bbd01ffbac466288977a770dd09e357af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fei Yang on 6 Sep 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson. > > Thanks! > > Testing: > - [x] GHA linux-cross-build job GHA test failure is unrelated. GHA linux-cross-build job works after this change. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2860#issuecomment-2339484922 From andrewlu at openjdk.org Tue Sep 10 02:31:50 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 10 Sep 2024 02:31:50 GMT Subject: [jdk17u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v5] In-Reply-To: References: Message-ID: <1PzlEjnU4N1FBQtLDjDNnGIbc_DcX7GND9APTvc7x7M=.18376bcd-b518-4998-b3d7-c903d6c5ca23@github.com> > I backport this for parity with 17.0.13-oracle. > modify lines are different, but code is clean. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: fix ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2807/files - new: https://git.openjdk.org/jdk17u-dev/pull/2807/files/75e16792..6c673aee Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2807&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2807&range=03-04 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2807.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2807/head:pull/2807 PR: https://git.openjdk.org/jdk17u-dev/pull/2807 From andrewlu at openjdk.org Tue Sep 10 02:31:50 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 10 Sep 2024 02:31:50 GMT Subject: [jdk17u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v4] In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 08:50:20 GMT, Goetz Lindenmaier wrote: >> Andrew Lu has updated the pull request incrementally with two additional commits since the last revision: >> >> - Merge remote-tracking branch 'origin/andrewLu_backport_8320675' into andrewLu_backport_8320675 >> - fix > > test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 60: > >> 58: "\n" + >> 59: "The dialogs should be displayed even when \n" + >> 60: "there is no queuePrintJob permission."; > > The indentation is wrong. The file should be identical with the one in 21 after this change. @GoeLin it's right now, thanks ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2807#discussion_r1751160999 From andrewlu at openjdk.org Tue Sep 10 03:15:56 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 10 Sep 2024 03:15:56 GMT Subject: [jdk11u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.25-oracle. > modify lines are different, but code is clean. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: fix ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2912/files - new: https://git.openjdk.org/jdk11u-dev/pull/2912/files/593b5a54..64f0c5e6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2912&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2912&range=01-02 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2912.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2912/head:pull/2912 PR: https://git.openjdk.org/jdk11u-dev/pull/2912 From goetz at openjdk.org Tue Sep 10 05:37:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 05:37:19 GMT Subject: [jdk21u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 [v2] In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 14:14:29 GMT, SendaoYan wrote: >> Hi all, >> Test `java/nio/channels/DatagramChannel/Disconnect.java` compile error: `cannot find symbol InetAddress.ofLiteral` after JDK-8299813. There is no `InetAddress.ofLiteral` API in jdk21u and jdk17u, the `InetAddress.ofLiteral` API was added by [JDK-8272215](https://bugs.openjdk.org/browse/JDK-8272215) in jdk22. >> Change `InetAddress.ofLiteral`to `Inet6Address.getByName`, change has been verified, test fix only, no risk. > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > change Inet4Address.getByName and Inet6Address.getByName to InetAddress.getByName GHA failure is the well known ClhsdbFindPC issue. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/939#issuecomment-2339659417 From andrewlu at openjdk.org Tue Sep 10 05:40:50 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 10 Sep 2024 05:40:50 GMT Subject: [jdk21u-dev] RFR: 8337320: Update ProblemList.txt with tests known to fail on XWayland [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.6-oracle. > Not clean, this file java/awt/FullScreen/SetFullScreenTest.java does not exist in jdk21 Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: update ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/961/files - new: https://git.openjdk.org/jdk21u-dev/pull/961/files/ac2e443f..55eadb41 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=961&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=961&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/961.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/961/head:pull/961 PR: https://git.openjdk.org/jdk21u-dev/pull/961 From andrewlu at openjdk.org Tue Sep 10 05:40:50 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 10 Sep 2024 05:40:50 GMT Subject: [jdk21u-dev] RFR: 8337320: Update ProblemList.txt with tests known to fail on XWayland In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 08:39:25 GMT, Goetz Lindenmaier wrote: > Hi Andrew, as in 17, SetFullScreenTest is not in 21. Please remove it. Thanks. hi @GoeLin , it's updated ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/961#issuecomment-2339661126 From andrewlu at openjdk.org Tue Sep 10 05:44:10 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 10 Sep 2024 05:44:10 GMT Subject: [jdk17u-dev] Integrated: 8328723: IP Address error when client enables HTTPS endpoint check on server socket In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 05:31:54 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 8cea90b9 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/8cea90b9ca1c1a3a0c5cc55de828a35077c3f760 Stats: 12 lines in 1 file changed: 9 ins; 0 del; 3 mod 8328723: IP Address error when client enables HTTPS endpoint check on server socket Backport-of: 1b9270ac8a76b482103dd3f6b12606a22214e554 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2856 From andrewlu at openjdk.org Tue Sep 10 05:44:08 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 10 Sep 2024 05:44:08 GMT Subject: [jdk17u-dev] Integrated: 8336413: gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 05:32:22 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 49624e7d Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/49624e7d887e7fb7deb35a0bd08f1a38988b58a5 Stats: 6 lines in 2 files changed: 0 ins; 4 del; 2 mod 8336413: gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf Backport-of: 69baa7d2850fafbd89978db12eec683c286eb921 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2857 From andrewlu at openjdk.org Tue Sep 10 05:45:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 10 Sep 2024 05:45:06 GMT Subject: [jdk21u-dev] Integrated: 8336413: gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf In-Reply-To: <1McKsi8zZQKGMUEbRvLmGwROZxxmkSAXA3jNa3MgjsQ=.b5d931c3-2479-43ff-8a77-80bd98229cc7@github.com> References: <1McKsi8zZQKGMUEbRvLmGwROZxxmkSAXA3jNa3MgjsQ=.b5d931c3-2479-43ff-8a77-80bd98229cc7@github.com> Message-ID: On Mon, 9 Sep 2024 05:32:07 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: fbdaf08c Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/fbdaf08cd997876406a3cfe98c8af6a55c692e6e Stats: 6 lines in 2 files changed: 0 ins; 4 del; 2 mod 8336413: gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf Backport-of: 69baa7d2850fafbd89978db12eec683c286eb921 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/960 From andrewlu at openjdk.org Tue Sep 10 05:45:08 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 10 Sep 2024 05:45:08 GMT Subject: [jdk21u-dev] Integrated: 8326611: Clean up vmTestbase/nsk/stress/stack tests In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 05:31:05 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: d71aa197 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/d71aa197c12d3c57420d2416eb566fd45830d9f6 Stats: 5086 lines in 41 files changed: 2259 ins; 2825 del; 2 mod 8326611: Clean up vmTestbase/nsk/stress/stack tests Backport-of: 972e81d1adb232b02114a5260d06144eb5b08849 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/958 From andrewlu at openjdk.org Tue Sep 10 05:45:14 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 10 Sep 2024 05:45:14 GMT Subject: [jdk21u-dev] Integrated: 8328723: IP Address error when client enables HTTPS endpoint check on server socket In-Reply-To: <73w3E154zeqRijnYXHo9pkWhWwxvt90RGNmwY9WNEq0=.b3de929f-a4d3-43fe-8b29-6a8a5997978f@github.com> References: <73w3E154zeqRijnYXHo9pkWhWwxvt90RGNmwY9WNEq0=.b3de929f-a4d3-43fe-8b29-6a8a5997978f@github.com> Message-ID: <8LKIIG5cqrjIIt6SxVYjTjS13sHraiuWR5J-LBtwyUE=.7f1e6010-3b02-46c6-bf7f-4a677ae7fbc0@github.com> On Mon, 9 Sep 2024 05:31:40 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: c66ea3d3 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/c66ea3d39d736a5bbed0224b7ad8f82c471a27bd Stats: 12 lines in 1 file changed: 9 ins; 0 del; 3 mod 8328723: IP Address error when client enables HTTPS endpoint check on server socket Backport-of: 1b9270ac8a76b482103dd3f6b12606a22214e554 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/959 From andrewlu at openjdk.org Tue Sep 10 05:46:16 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 10 Sep 2024 05:46:16 GMT Subject: [jdk17u-dev] Integrated: 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 05:58:02 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. > > test/jdk/java/net/httpclient/AuthFilterCacheTest.java > test/jdk/java/net/httpclient/ConcurrentResponses.java > ignored this commit: https://github.com/openjdk/jdk/commit/736b90d54b51830de7757a8de3ad9c98437c824a > > test/jdk/java/net/httpclient/MappingResponseSubscriber.java > ignored this commit https://github.com/openjdk/jdk/commit/49d60fee49b9f5f7182dcd1557d9b2f886901100 This pull request has now been integrated. Changeset: 4656e39f Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/4656e39f752554d44efd5bad79d78d30201ef025 Stats: 318 lines in 19 files changed: 265 ins; 24 del; 29 mod 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests Reviewed-by: goetz Backport-of: 05e9c41eddf8961d1384c88ccedf993d86822a6b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2819 From goetz at openjdk.org Tue Sep 10 05:50:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 05:50:06 GMT Subject: [jdk21u-dev] Integrated: 8331864: Update Public Suffix List to 1cbd6e7 In-Reply-To: References: Message-ID: On Fri, 6 Sep 2024 10:38:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 40fe61ab Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/40fe61ab25db1e5b3246de7f7c5218102e742734 Stats: 568 lines in 5 files changed: 408 ins; 104 del; 56 mod 8331864: Update Public Suffix List to 1cbd6e7 Backport-of: b91083341aba952befadd79020079920f9540999 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/957 From goetz at openjdk.org Tue Sep 10 05:53:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 05:53:07 GMT Subject: [jdk17u-dev] Integrated: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee In-Reply-To: <0V5ooW-WaAK4Kw7L90qVzmytqvOdppLondNsIPeqn4M=.176fa928-68b3-4c45-80ff-c71250ffba26@github.com> References: <0V5ooW-WaAK4Kw7L90qVzmytqvOdppLondNsIPeqn4M=.176fa928-68b3-4c45-80ff-c71250ffba26@github.com> Message-ID: <8ZZG6XChFmQel0Wy_oFNA_PTxYYc8do22u_VxPiaG_o=.fa3102dc-11af-4067-be6a-47635b5f42fa@github.com> On Fri, 6 Sep 2024 10:23:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 57a1ad1b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/57a1ad1b34541476ad95cdfa939669855e2a27b1 Stats: 31 lines in 3 files changed: 4 ins; 19 del; 8 mod 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee Backport-of: 18a731a3e4ec85f0f3e8d6ff619b539c0daaf320 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2850 From goetz at openjdk.org Tue Sep 10 05:54:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 05:54:10 GMT Subject: [jdk17u-dev] Integrated: 8274505: Too weak variable type leads to unnecessary cast in java.desktop In-Reply-To: <9sRQS3Wanc4W3gH9O38d5Raka5re8-W9QqMtaZbu2DQ=.c8255e3e-da24-4e45-bdbb-a26e6227da04@github.com> References: <9sRQS3Wanc4W3gH9O38d5Raka5re8-W9QqMtaZbu2DQ=.c8255e3e-da24-4e45-bdbb-a26e6227da04@github.com> Message-ID: On Thu, 5 Sep 2024 13:01:50 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 2001d39c Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2001d39ce1c0f603e9ef547e25c086ea30780fab Stats: 78 lines in 11 files changed: 0 ins; 22 del; 56 mod 8274505: Too weak variable type leads to unnecessary cast in java.desktop Backport-of: 9ca6bf0d22ac39d4ee29c756903038f09087ca12 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2848 From goetz at openjdk.org Tue Sep 10 05:56:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 05:56:07 GMT Subject: [jdk17u-dev] Integrated: 8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out" In-Reply-To: <35vLVqvX5Y9aiZssjVaRXUmjFql4feGGCfuNGmCXOT4=.85d433a5-0ceb-40fe-8a27-d934cc892599@github.com> References: <35vLVqvX5Y9aiZssjVaRXUmjFql4feGGCfuNGmCXOT4=.85d433a5-0ceb-40fe-8a27-d934cc892599@github.com> Message-ID: On Fri, 6 Sep 2024 12:48:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: fb797141 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/fb797141ebd9baf76394d53d29e21535dcbffdf6 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod 8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out" Backport-of: 8aae88b0fc4acb76ef140f120712403cf4b04a46 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2853 From goetz at openjdk.org Tue Sep 10 05:58:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 05:58:17 GMT Subject: [jdk17u-dev] Integrated: 8293877: Rewrite MineField test In-Reply-To: References: Message-ID: On Fri, 6 Sep 2024 12:38:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Does not apply clean because "8173605: Remove support for source and target 1.7 option in javac" which added -Xlint:-options in diagnostics.sh is not in 17. > This appears in the new file, Diagnositcs.java:95. But I think this is ok for 17, actually -options makes sense since 9. So I do not change Diagnostics.java. > > Tests pass. This pull request has now been integrated. Changeset: 2886a394 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2886a394f5004e273ad12abc3ea70d41950427c1 Stats: 3208 lines in 15 files changed: 1931 ins; 1276 del; 1 mod 8293877: Rewrite MineField test Reviewed-by: mbaesken Backport-of: e137f9f2f0e4244307900cd0eadceb9b773e9858 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2852 From goetz at openjdk.org Tue Sep 10 06:01:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 06:01:08 GMT Subject: [jdk17u-dev] Integrated: 8071693: Introspector ignores default interface methods In-Reply-To: <6obDf4FsmA-sy2HLJ27G23FcV8HTltjH3tbJw-y8Wx8=.5101c6d3-1c3c-4378-9cea-84a5c88ba215@github.com> References: <6obDf4FsmA-sy2HLJ27G23FcV8HTltjH3tbJw-y8Wx8=.5101c6d3-1c3c-4378-9cea-84a5c88ba215@github.com> Message-ID: On Thu, 5 Sep 2024 13:16:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 878ceeb3 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/878ceeb3f6a7f720dbf2eb270dddc56f41e01503 Stats: 247 lines in 2 files changed: 243 ins; 0 del; 4 mod 8071693: Introspector ignores default interface methods Backport-of: 1e4eafb4fe70832294a12938d93e7860073cf4cf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2849 From goetz at openjdk.org Tue Sep 10 06:04:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 06:04:06 GMT Subject: [jdk17u-dev] Integrated: 8331864: Update Public Suffix List to 1cbd6e7 In-Reply-To: <3tGkIHJnvSa2j826v1eUCenj5dcZccmqyrQ6-xKKNdY=.e7342f04-96db-4966-8b10-209c65aa3621@github.com> References: <3tGkIHJnvSa2j826v1eUCenj5dcZccmqyrQ6-xKKNdY=.e7342f04-96db-4966-8b10-209c65aa3621@github.com> Message-ID: On Fri, 6 Sep 2024 10:53:26 GMT, Goetz Lindenmaier wrote: > Fix request [17u] > > I backport this for parity with 17.0.14-oracle. > One of the required updates of meta information. > After adapting the paths, the patch applies clean. > Test passes. This pull request has now been integrated. Changeset: 7d828586 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7d828586292dea718bb314a9b81249f6440efaf1 Stats: 568 lines in 5 files changed: 408 ins; 104 del; 56 mod 8331864: Update Public Suffix List to 1cbd6e7 Reviewed-by: mbaesken Backport-of: b91083341aba952befadd79020079920f9540999 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2851 From syan at openjdk.org Tue Sep 10 06:42:13 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 10 Sep 2024 06:42:13 GMT Subject: [jdk21u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 [v2] In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 14:14:29 GMT, SendaoYan wrote: >> Hi all, >> Test `java/nio/channels/DatagramChannel/Disconnect.java` compile error: `cannot find symbol InetAddress.ofLiteral` after JDK-8299813. There is no `InetAddress.ofLiteral` API in jdk21u and jdk17u, the `InetAddress.ofLiteral` API was added by [JDK-8272215](https://bugs.openjdk.org/browse/JDK-8272215) in jdk22. >> Change `InetAddress.ofLiteral`to `InetAddress.getByName`, change has been verified, test fix only, no risk. > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > change Inet4Address.getByName and Inet6Address.getByName to InetAddress.getByName The GHA test [runner](https://github.com/sendaoYan/jdk21u-dev-ysd/actions/runs/10774948680/job/29907380098) report two failures: 1. ClhsdbDumpheap.java fails, which has been recorded by [JDK-8247940](https://bugs.openjdk.org/browse/JDK-8247940), it's unreleated to this PR. 2. ClhsdbFindPC.java#no-xcomp-process fails, which has been recorded by [JDK-8288429](https://bugs.openjdk.org/browse/JDK-8288429), it's unreleated to this PR. Thanks all for the review and approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/939#issuecomment-2339792069 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/939#issuecomment-2339793356 From duke at openjdk.org Tue Sep 10 06:42:13 2024 From: duke at openjdk.org (duke) Date: Tue, 10 Sep 2024 06:42:13 GMT Subject: [jdk21u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 [v2] In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 14:14:29 GMT, SendaoYan wrote: >> Hi all, >> Test `java/nio/channels/DatagramChannel/Disconnect.java` compile error: `cannot find symbol InetAddress.ofLiteral` after JDK-8299813. There is no `InetAddress.ofLiteral` API in jdk21u and jdk17u, the `InetAddress.ofLiteral` API was added by [JDK-8272215](https://bugs.openjdk.org/browse/JDK-8272215) in jdk22. >> Change `InetAddress.ofLiteral`to `InetAddress.getByName`, change has been verified, test fix only, no risk. > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > change Inet4Address.getByName and Inet6Address.getByName to InetAddress.getByName @sendaoYan Your change (at version 125f1721ea03cef852408dffa4beeefada9d3cf1) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/939#issuecomment-2339793837 From syan at openjdk.org Tue Sep 10 08:03:08 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 10 Sep 2024 08:03:08 GMT Subject: [jdk21u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 [v2] In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 14:14:29 GMT, SendaoYan wrote: >> Hi all, >> Test `java/nio/channels/DatagramChannel/Disconnect.java` compile error: `cannot find symbol InetAddress.ofLiteral` after JDK-8299813. There is no `InetAddress.ofLiteral` API in jdk21u and jdk17u, the `InetAddress.ofLiteral` API was added by [JDK-8272215](https://bugs.openjdk.org/browse/JDK-8272215) in jdk22. >> Change `InetAddress.ofLiteral`to `InetAddress.getByName`, change has been verified, test fix only, no risk. > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > change Inet4Address.getByName and Inet6Address.getByName to InetAddress.getByName Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/939#issuecomment-2339942686 From syan at openjdk.org Tue Sep 10 08:03:09 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 10 Sep 2024 08:03:09 GMT Subject: [jdk21u-dev] Integrated: 8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 15:48:49 GMT, SendaoYan wrote: > Hi all, > Test `java/nio/channels/DatagramChannel/Disconnect.java` compile error: `cannot find symbol InetAddress.ofLiteral` after JDK-8299813. There is no `InetAddress.ofLiteral` API in jdk21u and jdk17u, the `InetAddress.ofLiteral` API was added by [JDK-8272215](https://bugs.openjdk.org/browse/JDK-8272215) in jdk22. > Change `InetAddress.ofLiteral`to `InetAddress.getByName`, change has been verified, test fix only, no risk. This pull request has now been integrated. Changeset: ad5656f7 Author: SendaoYan Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk21u-dev/commit/ad5656f7fa53e7d380dbadc204501c3c7f2e822a Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/939 From syan at openjdk.org Tue Sep 10 08:34:41 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 10 Sep 2024 08:34:41 GMT Subject: [jdk17u-dev] RFR: 8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 Message-ID: Hi all, This pull request contains a backport of commit [ad5656f7](https://github.com/openjdk/jdk21u-dev/commit/ad5656f7fa53e7d380dbadc204501c3c7f2e822a) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. The commit being backported was authored by SendaoYan on 10 Sep 2024 and was reviewed by Severin Gehwolf. Thanks! ------------- Commit messages: - Backport ad5656f7fa53e7d380dbadc204501c3c7f2e822a Changes: https://git.openjdk.org/jdk17u-dev/pull/2861/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2861&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338748 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2861.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2861/head:pull/2861 PR: https://git.openjdk.org/jdk17u-dev/pull/2861 From andrewlu at openjdk.org Tue Sep 10 09:29:47 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 10 Sep 2024 09:29:47 GMT Subject: [jdk17u-dev] RFR: 8294726: Update URLs in minefield tests Message-ID: <5tJoEgK8I0Zg1PeHtT8mynPJJftSXQ47g409kQ-ZyFk=.065f66de-5237-4250-a71c-edb556080d5a@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 090cdfc7a2e280c620a0926512fb67f0ce7f3c21 Changes: https://git.openjdk.org/jdk17u-dev/pull/2862/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2862&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294726 Stats: 6 lines in 6 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2862.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2862/head:pull/2862 PR: https://git.openjdk.org/jdk17u-dev/pull/2862 From andrewlu at openjdk.org Tue Sep 10 09:46:39 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 10 Sep 2024 09:46:39 GMT Subject: [jdk17u-dev] RFR: 8295859: Update Manual Test Groups Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 87017b5199522bb26f0225b60fbbc00df255ad2a Changes: https://git.openjdk.org/jdk17u-dev/pull/2863/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2863&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295859 Stats: 18 lines in 1 file changed: 11 ins; 3 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2863.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2863/head:pull/2863 PR: https://git.openjdk.org/jdk17u-dev/pull/2863 From zzambers at openjdk.org Tue Sep 10 11:05:14 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 10 Sep 2024 11:05:14 GMT Subject: [jdk21u-dev] Integrated: 8338402: GHA: some of bundles may not get removed In-Reply-To: References: Message-ID: <2NsniCQgNPgQgUuxUR2XI946VCU6mi96whiGtrH0i-8=.e6c40c77-4c16-4668-b91d-948cea8da9ae@github.com> On Mon, 2 Sep 2024 16:08:53 GMT, Zdenek Zambersky wrote: > Backport fixing problem, where some bundles may not get removed in GHA. > > GHA testing: OK (no leftover bundles) This pull request has now been integrated. Changeset: cf35ed59 Author: Zdenek Zambersky Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/cf35ed592f6e660fd4fa322b07dcf3a991a11302 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8338402: GHA: some of bundles may not get removed Backport-of: d8e4d3f2d6c187f2487acd390a4e5fa2a99010ea ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/952 From zzambers at openjdk.org Tue Sep 10 11:05:16 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 10 Sep 2024 11:05:16 GMT Subject: [jdk23u] Integrated: 8338402: GHA: some of bundles may not get removed In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 16:03:47 GMT, Zdenek Zambersky wrote: > Backport fixing problem, where some bundles may not get removed in GHA. > > GHA testing: OK (no leftover bundles) This pull request has now been integrated. Changeset: ef87a065 Author: Zdenek Zambersky Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/ef87a0653746f8950bac04c693a98b09a5e351ff Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8338402: GHA: some of bundles may not get removed Backport-of: d8e4d3f2d6c187f2487acd390a4e5fa2a99010ea ------------- PR: https://git.openjdk.org/jdk23u/pull/89 From bulasevich at openjdk.org Tue Sep 10 11:07:16 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Tue, 10 Sep 2024 11:07:16 GMT Subject: [jdk21u-dev] Integrated: 8331393: AArch64: u32 _partial_subtype_ctr loaded/stored as 64 In-Reply-To: References: Message-ID: On Thu, 29 Aug 2024 02:40:11 GMT, Boris Ulasevich wrote: > Clean backport. A small change to use properly sized store/load instructions. > Affects only: AARCH fastdebug. > Tested: jtreg (hotspot&jdk) tier 1-3 This pull request has now been integrated. Changeset: b869fc7a Author: Boris Ulasevich Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/b869fc7af82ac3cc6f6801ce0b1176fa033f0ce7 Stats: 9 lines in 2 files changed: 0 ins; 7 del; 2 mod 8331393: AArch64: u32 _partial_subtype_ctr loaded/stored as 64 Backport-of: f215899a088d1abe86adccf0e65a073189272ddd ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/949 From shade at openjdk.org Tue Sep 10 11:07:17 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 10 Sep 2024 11:07:17 GMT Subject: [jdk17u-dev] RFR: 8337684: [17/11u] Revert JDK-8163921 backport [v2] In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 13:15:51 GMT, Aleksey Shipilev wrote: >> See the issue for more discussion and rationale. This is the actual code change, should we decide to go forward. >> >> This is a `git revert` of https://github.com/openjdk/jdk17u-dev/commit/b37df147b011b23b6c7474d726710e1478af7607. >> >> Additional testing: >> - [x] Linux AArch64 server fastdebug, `jdk_net` >> - [x] Linux AArch64 server fastdebug, `all` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8337684-revert-http-accept > - 8337684: [17/11u] Revert JDK-8163921 backport Closing in favor of https://github.com/openjdk/jdk17u-dev/pull/2843 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2775#issuecomment-2340354182 From shade at openjdk.org Tue Sep 10 11:07:17 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 10 Sep 2024 11:07:17 GMT Subject: [jdk17u-dev] Withdrawn: 8337684: [17/11u] Revert JDK-8163921 backport In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 09:02:00 GMT, Aleksey Shipilev wrote: > See the issue for more discussion and rationale. This is the actual code change, should we decide to go forward. > > This is a `git revert` of https://github.com/openjdk/jdk17u-dev/commit/b37df147b011b23b6c7474d726710e1478af7607. > > Additional testing: > - [x] Linux AArch64 server fastdebug, `jdk_net` > - [x] Linux AArch64 server fastdebug, `all` This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2775 From goetz at openjdk.org Tue Sep 10 11:42:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 11:42:24 GMT Subject: [jdk17u-dev] RFR: 8339470: [17u] More defensive fix for 8163921 [v2] In-Reply-To: References: Message-ID: > This does not remove the header specifications, it just fixes the error. > > Well, it removes * as type, but that is illegal and should be meant to match the same as */*. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Add bugid to modified test ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2843/files - new: https://git.openjdk.org/jdk17u-dev/pull/2843/files/151dfb6d..1391b125 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2843&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2843&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2843.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2843/head:pull/2843 PR: https://git.openjdk.org/jdk17u-dev/pull/2843 From coffeys at openjdk.org Tue Sep 10 11:51:14 2024 From: coffeys at openjdk.org (Sean Coffey) Date: Tue, 10 Sep 2024 11:51:14 GMT Subject: [jdk17u-dev] RFR: 8339470: [17u] More defensive fix for 8163921 [v2] In-Reply-To: References: Message-ID: <0Pm2M9l54G6YVvNzHbI3yO6IOIr3aD8yqhnB9jZev9U=.c8607122-1130-4d91-90b1-be5f68e70f92@github.com> On Tue, 10 Sep 2024 11:42:24 GMT, Goetz Lindenmaier wrote: >> This does not remove the header specifications, it just fixes the error. >> >> Well, it removes * as type, but that is illegal and should be meant to match the same as */*. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Add bugid to modified test LGTM. Matches an approach originally suggested for the JDK-8163921 fix and is probably a more suitable fix for update releases. ------------- Marked as reviewed by coffeys (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2843#pullrequestreview-2292198764 From goetz at openjdk.org Tue Sep 10 12:15:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 12:15:14 GMT Subject: [jdk17u-dev] Integrated: 8339470: [17u] More defensive fix for 8163921 In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 10:19:06 GMT, Goetz Lindenmaier wrote: > This does not remove the header specifications, it just fixes the error. > > Well, it removes * as type, but that is illegal and should be meant to match the same as */*. This pull request has now been integrated. Changeset: 6261dd7e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/6261dd7e3827ecd65c61a3d71f4234c88f08fccd Stats: 11 lines in 2 files changed: 1 ins; 0 del; 10 mod 8339470: [17u] More defensive fix for 8163921 Reviewed-by: coffeys, shade ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2843 From syan at openjdk.org Tue Sep 10 13:00:10 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 10 Sep 2024 13:00:10 GMT Subject: [jdk17u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 08:30:05 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [ad5656f7](https://github.com/openjdk/jdk21u-dev/commit/ad5656f7fa53e7d380dbadc204501c3c7f2e822a) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by SendaoYan on 10 Sep 2024 and was reviewed by Severin Gehwolf. > > Thanks! The GHA report a [failure](https://github.com/openjdk-bots/jdk17u-dev/actions/runs/10788383267/job/29919683724) which I have created a issue [JDK-8339844](https://bugs.openjdk.org/browse/JDK-8339844) to record that. I think this failure is unreleated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2861#issuecomment-2340676008 From goetz at openjdk.org Tue Sep 10 13:08:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 13:08:42 GMT Subject: [jdk21u-dev] RFR: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 70c8ff1c9a9adf21a16d8a6b4da1eeec65afe61d Changes: https://git.openjdk.org/jdk21u-dev/pull/963/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=963&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328665 Stats: 17 lines in 1 file changed: 9 ins; 2 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/963.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/963/head:pull/963 PR: https://git.openjdk.org/jdk21u-dev/pull/963 From goetz at openjdk.org Tue Sep 10 13:15:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 13:15:21 GMT Subject: [jdk21u] RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 Message-ID: A clean backport to fix a regression. ------------- Commit messages: - Backport 05f13e75ee4407ba9213c69b33c6032aa87c9e95 Changes: https://git.openjdk.org/jdk21u/pull/452/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=452&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329667 Stats: 168 lines in 3 files changed: 96 ins; 64 del; 8 mod Patch: https://git.openjdk.org/jdk21u/pull/452.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/452/head:pull/452 PR: https://git.openjdk.org/jdk21u/pull/452 From goetz at openjdk.org Tue Sep 10 13:26:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 13:26:28 GMT Subject: [jdk17u] RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 Message-ID: Backport to fix a regression in 17.0.11. I had to resolve a copyright. ------------- Commit messages: - Backport 05f13e75ee4407ba9213c69b33c6032aa87c9e95 Changes: https://git.openjdk.org/jdk17u/pull/397/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=397&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329667 Stats: 168 lines in 3 files changed: 96 ins; 64 del; 8 mod Patch: https://git.openjdk.org/jdk17u/pull/397.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/397/head:pull/397 PR: https://git.openjdk.org/jdk17u/pull/397 From shade at openjdk.org Tue Sep 10 15:17:16 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 10 Sep 2024 15:17:16 GMT Subject: [jdk21u-dev] RFR: 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 [v2] In-Reply-To: <5VtI93ebemu9HNAzcz54lzHFSd4jef9H0gPaRR0WBXk=.d2b83b05-f0f3-483a-be1a-7434175a9201@github.com> References: <5VtI93ebemu9HNAzcz54lzHFSd4jef9H0gPaRR0WBXk=.d2b83b05-f0f3-483a-be1a-7434175a9201@github.com> Message-ID: <5-J8425hY0P2Ba8Cesp3252X0-A6fHGmYoYl1n2Wp8w=.d529c74c-f308-4fd7-b8dc-42ba7add939c@github.com> > Uncleanliness comes from JDK 21 not having [JDK-8313882](https://bugs.openjdk.org/browse/JDK-8313882), so I had to rewrite the incoming hunks back to `INT64_FORMAT` and `int64_t` casts. This can be made clean by [JDK-8313882](https://bugs.openjdk.org/browse/JDK-8313882) backport, but it has follow-up bugs that break Graal. It seems a better choice to just do a little deviation here. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, new regression tests fail without the fix, pass with it > - [x] Linux AArch64 server fastdebug, `all` > - [x] Linux x86_64 server fastdebug, `all` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 274c805c5137d9080a7670d864ecca8a0befc3f6 ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/523/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=523&range=01 Stats: 505 lines in 10 files changed: 460 ins; 13 del; 32 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/523.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/523/head:pull/523 PR: https://git.openjdk.org/jdk21u-dev/pull/523 From goetz at openjdk.org Tue Sep 10 17:21:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 17:21:58 GMT Subject: [jdk21u] RFR: 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8338884 Message-ID: <10IzN4lJ4COLq4EBKOZ6-itDKxyQl3Jl1Vyagv9_OPQ=.40b786c8-6fcf-4c97-9819-f51fb2d35a1b@github.com> Running one test as /othervm makes sure the lib is not loaded twice in the same VM Testing: The failure was sporadic, but we saw it in our 4 daily test runs (21u, 21u-dev, 17u, 17u-dev) about once a day. Since adding this fix temporary to the four test setups on September 3rd, we have not encountered the problem again. ------------- Commit messages: - 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 Changes: https://git.openjdk.org/jdk21u/pull/453/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=453&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339869 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/453.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/453/head:pull/453 PR: https://git.openjdk.org/jdk21u/pull/453 From goetz at openjdk.org Tue Sep 10 17:51:18 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 17:51:18 GMT Subject: [jdk17u-dev] RFR: 8326611: Clean up vmTestbase/nsk/stress/stack tests In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 05:31:18 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. > test/hotspot/jtreg/runtime/stack/Stack002.java > ignored JDK-8289612: Change hotspot/jtreg tests to not use Thread.stop > test/hotspot/jtreg/runtime/stack/Stack018.java > ignored JDK-8278415 [TESTBUG] vmTestbase/nsk/stress/stack/stack018.java fails with "java.lang.Error: TEST_RFE" LGTM ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2855#pullrequestreview-2293261857 From goetz at openjdk.org Tue Sep 10 17:57:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 17:57:15 GMT Subject: [jdk17u-dev] RFR: 8295859: Update Manual Test Groups In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 09:41:18 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. LGTM ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2863#pullrequestreview-2293275333 From goetz at openjdk.org Tue Sep 10 18:13:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Sep 2024 18:13:12 GMT Subject: [jdk17u-dev] RFR: 8295859: Update Manual Test Groups In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 09:41:18 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. @luchenlin, while the code looks good, the test results show some failures I have not seen before. Could you please restart them? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2863#issuecomment-2341670701 From sgehwolf at openjdk.org Tue Sep 10 19:05:17 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 10 Sep 2024 19:05:17 GMT Subject: [jdk21u] RFR: 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8338884 In-Reply-To: <10IzN4lJ4COLq4EBKOZ6-itDKxyQl3Jl1Vyagv9_OPQ=.40b786c8-6fcf-4c97-9819-f51fb2d35a1b@github.com> References: <10IzN4lJ4COLq4EBKOZ6-itDKxyQl3Jl1Vyagv9_OPQ=.40b786c8-6fcf-4c97-9819-f51fb2d35a1b@github.com> Message-ID: On Tue, 10 Sep 2024 17:13:25 GMT, Goetz Lindenmaier wrote: > Running one test as /othervm makes sure the lib is not loaded twice in the same VM > > Testing: > The failure was sporadic, but we saw it in our 4 daily test runs (21u, 21u-dev, 17u, 17u-dev) about once a day. Since adding this fix temporary to the four test setups on September 3rd, we have not encountered the problem again. Seems fine. FWIW, wrong bug in PR title. The JBS issue has it correct. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk21u/pull/453#pullrequestreview-2293508058 PR Comment: https://git.openjdk.org/jdk21u/pull/453#issuecomment-2341796222 From abakhtin at openjdk.org Tue Sep 10 23:33:05 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 10 Sep 2024 23:33:05 GMT Subject: [jdk17u-dev] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 20:01:27 GMT, Alexey Bakhtin wrote: > The backport is almost clean. > - manual update of the copyright year for Stream.java > - manual merge of one-line change in the Http2TestServer.java file. Caused by difference in JDK-8295944 implementation for JDK17 and JDK21 > > All java/net/httpclient JTREG tests passed Please review it. I'd like to backport this fix to correctly process trailing HEADER frames with HTTP2 endpoint ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2798#issuecomment-2342335132 From goetz at openjdk.org Wed Sep 11 07:31:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 07:31:16 GMT Subject: [jdk21u] RFR: 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 In-Reply-To: <10IzN4lJ4COLq4EBKOZ6-itDKxyQl3Jl1Vyagv9_OPQ=.40b786c8-6fcf-4c97-9819-f51fb2d35a1b@github.com> References: <10IzN4lJ4COLq4EBKOZ6-itDKxyQl3Jl1Vyagv9_OPQ=.40b786c8-6fcf-4c97-9819-f51fb2d35a1b@github.com> Message-ID: On Tue, 10 Sep 2024 17:13:25 GMT, Goetz Lindenmaier wrote: > Running one test as /othervm makes sure the lib is not loaded twice in the same VM > > Testing: > The failure was sporadic, but we saw it in our 4 daily test runs (21u, 21u-dev, 17u, 17u-dev) about once a day. Since adding this fix temporary to the four test setups on September 3rd, we have not encountered the problem again. Thanks! Fixed the bugID. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/453#issuecomment-2342869556 From goetz at openjdk.org Wed Sep 11 07:36:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 07:36:09 GMT Subject: [jdk21u] RFR: 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 In-Reply-To: <10IzN4lJ4COLq4EBKOZ6-itDKxyQl3Jl1Vyagv9_OPQ=.40b786c8-6fcf-4c97-9819-f51fb2d35a1b@github.com> References: <10IzN4lJ4COLq4EBKOZ6-itDKxyQl3Jl1Vyagv9_OPQ=.40b786c8-6fcf-4c97-9819-f51fb2d35a1b@github.com> Message-ID: <_qo-p-NdUQ9XsqOZxJFym1N-oT0DFIGzjIQ--beh2F8=.5ed24b24-d0c3-4041-b84f-09aa33e7fbd8@github.com> On Tue, 10 Sep 2024 17:13:25 GMT, Goetz Lindenmaier wrote: > Running one test as /othervm makes sure the lib is not loaded twice in the same VM > > Testing: > The failure was sporadic, but we saw it in our 4 daily test runs (21u, 21u-dev, 17u, 17u-dev) about once a day. Since adding this fix temporary to the four test setups on September 3rd, we have not encountered the problem again. GHA failure: well known ClhsdbFindPC issue, unrelated ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/453#issuecomment-2342880384 From goetz at openjdk.org Wed Sep 11 07:53:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 07:53:10 GMT Subject: [jdk21u-dev] RFR: Merge jdk21u:master Message-ID: Merge build tag 21.0.5+7 from jdk21u to jdk21u-dev ------------- Commit messages: - Merge - 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) - 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk21u-dev/pull/964/files Stats: 1124 lines in 14 files changed: 1113 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/964.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/964/head:pull/964 PR: https://git.openjdk.org/jdk21u-dev/pull/964 From goetz at openjdk.org Wed Sep 11 08:03:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 08:03:28 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master Message-ID: Merge build tag 17.0.13+7 from jdk17u to jdk17u-dev ------------- Commit messages: - Merge - 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) - 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk17u-dev/pull/2865/files Stats: 1124 lines in 14 files changed: 1113 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2865.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2865/head:pull/2865 PR: https://git.openjdk.org/jdk17u-dev/pull/2865 From goetz at openjdk.org Wed Sep 11 08:15:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 08:15:21 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: Merge build tag 11.0.25+6 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs - 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk11u-dev/pull/2934/files Stats: 1307 lines in 19 files changed: 1299 ins; 2 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2934.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2934/head:pull/2934 PR: https://git.openjdk.org/jdk11u-dev/pull/2934 From goetz at openjdk.org Wed Sep 11 08:21:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 08:21:19 GMT Subject: [jdk21u-dev] Integrated: Merge jdk21u:master In-Reply-To: References: Message-ID: On Wed, 11 Sep 2024 07:49:02 GMT, Goetz Lindenmaier wrote: > Merge build tag 21.0.5+7 from jdk21u to jdk21u-dev This pull request has now been integrated. Changeset: 347ef643 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/347ef6437040e7e0107626bed9738ecec639914c Stats: 1124 lines in 14 files changed: 1113 ins; 0 del; 11 mod Merge ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/964 From goetz at openjdk.org Wed Sep 11 09:15:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 09:15:20 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master In-Reply-To: References: Message-ID: On Wed, 11 Sep 2024 07:58:46 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.13+7 from jdk17u to jdk17u-dev This pull request has now been integrated. Changeset: 91849bf1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/91849bf127d67aeebc949936ebd7983040041ffc Stats: 1124 lines in 14 files changed: 1113 ins; 0 del; 11 mod Merge ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2865 From goetz at openjdk.org Wed Sep 11 09:21:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 09:21:32 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master [v2] In-Reply-To: References: Message-ID: > Merge build tag 11.0.25+6 from jdk11u to jdk11u-dev Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge - 8315936: Parallelize gc/stress/TestStressG1Humongous.java test Backport-of: 3f19df685c342cef212305cca630331878a24e79 - 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main Reviewed-by: mbaesken Backport-of: ab183e437c18b445e9c022a4d74de818d4ccecbe - 8328300: Convert PrintDialogsTest.java from Applet to main program Reviewed-by: mbaesken Backport-of: dea94f4445b9389339cf7ca0eef688ca56c17814 - 8339082: Bump update version for OpenJDK: jdk-11.0.26 Reviewed-by: sgehwolf ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2934/files - new: https://git.openjdk.org/jdk11u-dev/pull/2934/files/67d223bb..67d223bb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2934&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2934&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2934.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2934/head:pull/2934 PR: https://git.openjdk.org/jdk11u-dev/pull/2934 From goetz at openjdk.org Wed Sep 11 09:21:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 09:21:32 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 11 Sep 2024 08:11:58 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.25+6 from jdk11u to jdk11u-dev GHA failure: Well knwon snprintf issue. Our local build and tests succeeded on these platforms. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2934#issuecomment-2343102415 From goetz at openjdk.org Wed Sep 11 09:21:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 09:21:34 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 11 Sep 2024 08:11:58 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.25+6 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: 934decc1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/934decc1475e5acc00be23c87507274f005780b4 Stats: 1307 lines in 19 files changed: 1299 ins; 2 del; 6 mod Merge ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2934 From amitkumar at openjdk.org Wed Sep 11 10:25:11 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Wed, 11 Sep 2024 10:25:11 GMT Subject: [jdk21u-dev] RFR: 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 10:02:23 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [28de44da](https://github.com/openjdk/jdk/commit/28de44da71871bec7648f01a4df2faee43fa43b6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 5 Sep 2024 and was reviewed by Stefan Karlsson, Vladimir Kozlov and Dean Long. > > Thanks! I don't see these failure locally. I am not getting how to merge master to restart the test case, I tried but it's only pushing to local branch not updating the PR. Any suggestion for either merging master branch or re-running the test cases. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/955#issuecomment-2343248396 From goetz at openjdk.org Wed Sep 11 12:05:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 12:05:11 GMT Subject: [jdk21u] Integrated: 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 In-Reply-To: <10IzN4lJ4COLq4EBKOZ6-itDKxyQl3Jl1Vyagv9_OPQ=.40b786c8-6fcf-4c97-9819-f51fb2d35a1b@github.com> References: <10IzN4lJ4COLq4EBKOZ6-itDKxyQl3Jl1Vyagv9_OPQ=.40b786c8-6fcf-4c97-9819-f51fb2d35a1b@github.com> Message-ID: On Tue, 10 Sep 2024 17:13:25 GMT, Goetz Lindenmaier wrote: > Running one test as /othervm makes sure the lib is not loaded twice in the same VM > > Testing: > The failure was sporadic, but we saw it in our 4 daily test runs (21u, 21u-dev, 17u, 17u-dev) about once a day. Since adding this fix temporary to the four test setups on September 3rd, we have not encountered the problem again. This pull request has now been integrated. Changeset: 34b4bd44 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u/commit/34b4bd449e8eef32d47ad4f0fb8c22139e0680d6 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk21u/pull/453 From goetz at openjdk.org Wed Sep 11 12:18:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 12:18:47 GMT Subject: [jdk17u] RFR: 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 Message-ID: Backport from jdk21u. Testing: The failure was sporadic, but we saw it in our 4 daily test runs (21u, 21u-dev, 17u, 17u-dev) about once a day. Since adding this fix temporary to the four test setups on September 3rd, we have not encountered the problem again. ------------- Commit messages: - Backport 34b4bd449e8eef32d47ad4f0fb8c22139e0680d6 Changes: https://git.openjdk.org/jdk17u/pull/398/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=398&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339869 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u/pull/398.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/398/head:pull/398 PR: https://git.openjdk.org/jdk17u/pull/398 From goetz at openjdk.org Wed Sep 11 12:28:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 12:28:15 GMT Subject: [jdk17u-dev] RFR: 8294726: Update URLs in minefield tests In-Reply-To: <5tJoEgK8I0Zg1PeHtT8mynPJJftSXQ47g409kQ-ZyFk=.065f66de-5237-4250-a71c-edb556080d5a@github.com> References: <5tJoEgK8I0Zg1PeHtT8mynPJJftSXQ47g409kQ-ZyFk=.065f66de-5237-4250-a71c-edb556080d5a@github.com> Message-ID: On Tue, 10 Sep 2024 09:25:04 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: Well known ClhsdbFindPC issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2862#issuecomment-2343528330 From goetz at openjdk.org Wed Sep 11 12:35:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Sep 2024 12:35:06 GMT Subject: [jdk17u-dev] RFR: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array' In-Reply-To: <1qJEmuDqdpCmtOk09r_y3E53m2EuGw6lD6AqsW2VRdg=.05f6bed4-915f-4eb3-847b-a28474eb9cf2@github.com> References: <1qJEmuDqdpCmtOk09r_y3E53m2EuGw6lD6AqsW2VRdg=.05f6bed4-915f-4eb3-847b-a28474eb9cf2@github.com> Message-ID: On Wed, 4 Sep 2024 13:50:26 GMT, Matthias Baesken wrote: > Backport of 8332720, NULL was still in 17u-dev , that's why not clean GHA failure: the well known ClhsdbFindPC issue, today also ClhsdbFlags with the same error ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2847#issuecomment-2343544537 From mbaesken at openjdk.org Wed Sep 11 13:36:14 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 11 Sep 2024 13:36:14 GMT Subject: [jdk17u-dev] Integrated: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array' In-Reply-To: <1qJEmuDqdpCmtOk09r_y3E53m2EuGw6lD6AqsW2VRdg=.05f6bed4-915f-4eb3-847b-a28474eb9cf2@github.com> References: <1qJEmuDqdpCmtOk09r_y3E53m2EuGw6lD6AqsW2VRdg=.05f6bed4-915f-4eb3-847b-a28474eb9cf2@github.com> Message-ID: On Wed, 4 Sep 2024 13:50:26 GMT, Matthias Baesken wrote: > Backport of 8332720, NULL was still in 17u-dev , that's why not clean This pull request has now been integrated. Changeset: d92d6336 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/d92d63361cf73f500517b09f231db8a720d5974b Stats: 7 lines in 1 file changed: 2 ins; 0 del; 5 mod 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array' Reviewed-by: mdoerr, lucy Backport-of: e19a421c30534566ba0dea0fa84f812ebeecfc87 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2847 From mbalao at openjdk.org Wed Sep 11 18:14:18 2024 From: mbalao at openjdk.org (Martin Balao) Date: Wed, 11 Sep 2024 18:14:18 GMT Subject: [jdk21u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases [v3] In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 19:48:42 GMT, Alexey Bakhtin wrote: >> ? on older docker releases >> >> Please review the fix for regression on the old Docker versions (before v18.04). >> >> [JDK-8316304](https://bugs.openjdk.org/browse/JDK-8316304) was backported to JDK21, requiring statx syscall support. >> In the old Docker versions, the default seccomp profile does not allow statx syscall and fails with EPERM error code. >> Suggest fixing this issue by fallback to alternative implementation at runtime if syscall is not allowed. >> >> The same issue with copy_file_range syscall. >> >> The fix was initially submitted against upstream jdk ( https://github.com/openjdk/jdk/pull/20484 ) but after discussion submitted to JDK21 > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > added comments The options that we have are not ideal. I'll approve this change for 21u on the basis that it should be harmless and that the double-call penalty (e.g. statx - stat) will only be experienced under rare circumstances (i.e. disabling statx with a seccomp filter, as EPERM does not seem to be returned otherwise). ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/951#pullrequestreview-2298170536 From mdoerr at openjdk.org Wed Sep 11 21:00:20 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 11 Sep 2024 21:00:20 GMT Subject: [jdk17u-dev] Integrated: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer In-Reply-To: <0sUf-neM6pa9s9HoNUfSJXjL73aUBL0kpEPMt6Ad3nE=.1b5df45c-aac9-4d8d-8f58-ef16a800697f@github.com> References: <0sUf-neM6pa9s9HoNUfSJXjL73aUBL0kpEPMt6Ad3nE=.1b5df45c-aac9-4d8d-8f58-ef16a800697f@github.com> Message-ID: On Fri, 6 Sep 2024 19:33:45 GMT, Martin Doerr wrote: > Clean backport of [JDK-8331626](https://bugs.openjdk.org/browse/JDK-8331626). This pull request has now been integrated. Changeset: 98586bbd Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/98586bbd3294bd59722e78e6ae82a76a6dffce67 Stats: 7 lines in 1 file changed: 0 ins; 4 del; 3 mod 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer Backport-of: 23a72a1f2f651d5e8e9a0eb1e75e2b44572a13da ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2854 From cushon at openjdk.org Wed Sep 11 21:04:09 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Wed, 11 Sep 2024 21:04:09 GMT Subject: [jdk23u] RFR: 8337998: CompletionFailure in getEnclosingType attaching type annotations [v2] In-Reply-To: References: <9kCInkTP1JZYG7gKqoB7pkXmYjChxNti9BMrusphX4Q=.d1c53caa-cc75-4dde-b85b-95425a61f95c@github.com> Message-ID: On Wed, 14 Aug 2024 15:08:09 GMT, Liam Miller-Cushon wrote: >> This change fixes a javac crash when classes are missing from the classpath. The fix causes javac to instead report a non-crash error diagnostic. The change improves logic first added in JDK 22 as part of the fix for JDK-8225377. > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8337998 > - Backport 9e282e5c966a9c065de8b901b7d30bb5c9ccf243 Please keep this open for now ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/68#issuecomment-2344695203 From duke at openjdk.org Wed Sep 11 22:19:17 2024 From: duke at openjdk.org (Abhishek N) Date: Wed, 11 Sep 2024 22:19:17 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts Message-ID: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts ------------- Commit messages: - Backport 8feabc849ba2f617c8c6dbb2ec5074297beb6437 Changes: https://git.openjdk.org/jdk23u/pull/40/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=40&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334057 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/40.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/40/head:pull/40 PR: https://git.openjdk.org/jdk23u/pull/40 From robilad at openjdk.org Wed Sep 11 22:19:17 2024 From: robilad at openjdk.org (Dalibor Topic) Date: Wed, 11 Sep 2024 22:19:17 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts In-Reply-To: References: Message-ID: <4vM9RSCSotnx_Ahm5ARcXy2XhJXF_RweMvZZCKaQtas=.c07894d1-680b-4162-8225-c803dc3945cf@github.com> On Mon, 29 Jul 2024 10:02:59 GMT, Abhishek N wrote: > 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts Hi, please send me an email at dalibor.topic at oracle.com so that I can take care of verifying your account in Skara. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/40#issuecomment-2293779658 From fyang at openjdk.org Thu Sep 12 01:03:15 2024 From: fyang at openjdk.org (Fei Yang) Date: Thu, 12 Sep 2024 01:03:15 GMT Subject: [jdk23u] Integrated: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 06:50:07 GMT, Fei Yang wrote: > Hi all, > > This pull request contains a backport of commit [9e0ccb8b](https://github.com/openjdk/jdk/commit/9e0ccb8bbd01ffbac466288977a770dd09e357af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fei Yang on 6 Sep 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson. > > Thanks! > > Testing: > - [x] GHA linux-cross-build job This pull request has now been integrated. Changeset: 4b75cb06 Author: Fei Yang URL: https://git.openjdk.org/jdk23u/commit/4b75cb0620e563f380e737bd76969a96bf5193f6 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap Backport-of: 9e0ccb8bbd01ffbac466288977a770dd09e357af ------------- PR: https://git.openjdk.org/jdk23u/pull/94 From syan at openjdk.org Thu Sep 12 01:57:14 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 12 Sep 2024 01:57:14 GMT Subject: [jdk23u] RFR: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds In-Reply-To: References: Message-ID: <-iZe4FQEKE4VFNQ_isxiDEXASnWQ6dAdGTLa_rZuS9Y=.126a2ddc-eef6-4881-9df4-d7508b59b28d@github.com> On Mon, 9 Sep 2024 07:15:02 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [a18d9d84](https://github.com/openjdk/jdk/commit/a18d9d84cd92b0b7e7c3c83efab1d81773e3a87c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jan Lahoda on 9 Sep 2024 and was reviewed by Aggelos Biboudis. > > Thanks! [GHA](https://github.com/openjdk-bots/jdk23u/actions/runs/10768363660/job/29868047902) report two test failures: 1. `ClhsdbPstack.java#process` and `ClhsdbSource.java` fails on macos-aarch64, which has been recorded by [JDK-8247940](https://bugs.openjdk.org/browse/JDK-8247940), I think it's unrelated to this PR. Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/95#issuecomment-2345097346 PR Comment: https://git.openjdk.org/jdk23u/pull/95#issuecomment-2345097968 From duke at openjdk.org Thu Sep 12 01:57:15 2024 From: duke at openjdk.org (duke) Date: Thu, 12 Sep 2024 01:57:15 GMT Subject: [jdk23u] RFR: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 07:15:02 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [a18d9d84](https://github.com/openjdk/jdk/commit/a18d9d84cd92b0b7e7c3c83efab1d81773e3a87c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jan Lahoda on 9 Sep 2024 and was reviewed by Aggelos Biboudis. > > Thanks! @sendaoYan Your change (at version 8c58c8a6412bea7ac45fb5e4579eafb94a69615e) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/95#issuecomment-2345098136 From duke at openjdk.org Thu Sep 12 01:59:16 2024 From: duke at openjdk.org (duke) Date: Thu, 12 Sep 2024 01:59:16 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts In-Reply-To: References: Message-ID: On Tue, 16 Jul 2024 02:02:06 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [8feabc84](https://github.com/openjdk/jdk/commit/8feabc849ba2f617c8c6dbb2ec5074297beb6437) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 16 Jul 2024 and was reviewed by Jaikiran Pai. > > Thanks! @sendaoYan Your change (at version 8c2ca4bed96ac74f503ea0a1f2de616c621f1111) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/25#issuecomment-2345100309 From andrewlu at openjdk.org Thu Sep 12 02:04:20 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 12 Sep 2024 02:04:20 GMT Subject: [jdk17u-dev] Integrated: 8294726: Update URLs in minefield tests In-Reply-To: <5tJoEgK8I0Zg1PeHtT8mynPJJftSXQ47g409kQ-ZyFk=.065f66de-5237-4250-a71c-edb556080d5a@github.com> References: <5tJoEgK8I0Zg1PeHtT8mynPJJftSXQ47g409kQ-ZyFk=.065f66de-5237-4250-a71c-edb556080d5a@github.com> Message-ID: <5ijKqRzK1IaT44-QMOMszvWCmRABFhpDCGZ03DFlKR8=.0930e67c-917e-4dd6-9cb1-ccf5dfbdd4ac@github.com> On Tue, 10 Sep 2024 09:25:04 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 81ad4993 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/81ad4993e707d14d478740fb83854888aa235785 Stats: 6 lines in 6 files changed: 0 ins; 0 del; 6 mod 8294726: Update URLs in minefield tests Backport-of: 090cdfc7a2e280c620a0926512fb67f0ce7f3c21 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2862 From andrewlu at openjdk.org Thu Sep 12 02:06:16 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 12 Sep 2024 02:06:16 GMT Subject: [jdk17u-dev] Integrated: 8326611: Clean up vmTestbase/nsk/stress/stack tests In-Reply-To: References: Message-ID: <0jUCnsXQGALxxnVVLHROKOEj_W3JS3Gs2BggiigEEJ4=.8bdb3793-c0db-4613-8d66-f49f0472d99d@github.com> On Mon, 9 Sep 2024 05:31:18 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. > test/hotspot/jtreg/runtime/stack/Stack002.java > ignored JDK-8289612: Change hotspot/jtreg tests to not use Thread.stop > test/hotspot/jtreg/runtime/stack/Stack018.java > ignored JDK-8278415 [TESTBUG] vmTestbase/nsk/stress/stack/stack018.java fails with "java.lang.Error: TEST_RFE" This pull request has now been integrated. Changeset: 51395cff Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/51395cfff0912bc470ffe5a24be03b484d713359 Stats: 5098 lines in 41 files changed: 2265 ins; 2831 del; 2 mod 8326611: Clean up vmTestbase/nsk/stress/stack tests Reviewed-by: goetz Backport-of: 972e81d1adb232b02114a5260d06144eb5b08849 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2855 From serb at openjdk.org Thu Sep 12 03:05:44 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 12 Sep 2024 03:05:44 GMT Subject: [jdk21u-dev] RFR: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above Message-ID: Hi all, This pull request contains a backport of commit [999e556b](https://github.com/openjdk/jdk/commit/999e556be4302de4b6911e6d62ee5ca556a76469) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Harshitha Onkar on 12 Jan 2024 and was reviewed by Sergey Bylokhov, Tejesh R and Alexander Zvegintsev. Thanks! ------------- Commit messages: - Merge branch 'openjdk:master' into backport-mrserb-999e556b-master - Merge branch 'openjdk:master' into backport-mrserb-999e556b-master - Merge branch 'openjdk:master' into backport-mrserb-999e556b-master - Backport 999e556be4302de4b6911e6d62ee5ca556a76469 Changes: https://git.openjdk.org/jdk21u-dev/pull/793/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=793&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312518 Stats: 91 lines in 2 files changed: 90 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/793.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/793/head:pull/793 PR: https://git.openjdk.org/jdk21u-dev/pull/793 From sshivang at openjdk.org Thu Sep 12 05:22:09 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Thu, 12 Sep 2024 05:22:09 GMT Subject: [jdk23u] RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test In-Reply-To: References: Message-ID: <9fdbLtj5VTA5lDiio2mdFUUV9ypXc0XClhYNfCKfrTM=.6e285cfe-6ab2-40ed-91b2-57209fa93af5@github.com> On Mon, 9 Sep 2024 13:44:41 GMT, Sean Coffey wrote: >> This PR contains the changes of https://bugs.openjdk.org/browse/JDK-8335344 also. > > LGTM @coffeys Please sponsor this. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/93#issuecomment-2345294033 From duke at openjdk.org Thu Sep 12 05:22:09 2024 From: duke at openjdk.org (duke) Date: Thu, 12 Sep 2024 05:22:09 GMT Subject: [jdk23u] RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test In-Reply-To: References: Message-ID: <-xE6qRLRwlrc0AcPcyHgN11PMQQGrZeHjeXSOrp-Yhg=.da799fea-31d2-4493-be45-934aa8fb813c@github.com> On Fri, 6 Sep 2024 16:02:34 GMT, Shivangi Gupta wrote: > This PR contains the changes of https://bugs.openjdk.org/browse/JDK-8335344 also. @openjdk[bot] Your change (at version a52233cc8257ea2664bc93b0de5a33a2c02101bd) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/93#issuecomment-2345296155 From duke at openjdk.org Thu Sep 12 05:55:09 2024 From: duke at openjdk.org (duke) Date: Thu, 12 Sep 2024 05:55:09 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts In-Reply-To: References: Message-ID: <6OWk692KZ_7H7KS5757Ww3sCjRk8ZndDI2cAvnXY9dk=.f2f3c6c9-dccc-4deb-b227-cc350618453e@github.com> On Mon, 29 Jul 2024 10:02:59 GMT, Abhishek N wrote: > 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts @abhn-git Your change (at version 826c20cadc4598955528e0ec7df4dceddea3b18a) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/40#issuecomment-2345330514 From duke at openjdk.org Thu Sep 12 05:58:10 2024 From: duke at openjdk.org (Abhishek N) Date: Thu, 12 Sep 2024 05:58:10 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts In-Reply-To: References: Message-ID: On Mon, 29 Jul 2024 10:02:59 GMT, Abhishek N wrote: > 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts Can some one please sponsor this changeset ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/40#issuecomment-2345333723 From andrewlu at openjdk.org Thu Sep 12 07:26:19 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 12 Sep 2024 07:26:19 GMT Subject: [jdk21u-dev] RFR: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport f0c2f098150335fce736708354d58bae383cc4a1 Changes: https://git.openjdk.org/jdk21u-dev/pull/965/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=965&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296972 Stats: 40 lines in 3 files changed: 38 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/965.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/965/head:pull/965 PR: https://git.openjdk.org/jdk21u-dev/pull/965 From goetz at openjdk.org Thu Sep 12 08:22:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 08:22:24 GMT Subject: [jdk17u-dev] RFR: 8331405: Shenandoah: Optimize ShenandoahLock with TTAS In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 15:58:53 GMT, Xiaolong Peng wrote: > Hi, > This PR is a Backport of [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405): Shenandoah: Optimize ShenandoahLock with TTAS, the original commit was authored by Aleksey Shipilev on 2 May 2024 and was reviewed by Zhengyu Gu and Y. S. Ramakrishna, and it had already been backported to jdk21. > It is a clean merge w/o any conflicts, overall risk should be very minimal given it is single line change to apply TTAS. > > Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: > > | Bug | Title | PR | > | ----------- | ---------------------------------------------- |------------| > | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797) | > | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) | > | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | | > | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | | > > ### Additional test > - [x] Linux AArch64 server fastdebug, hotspot_gc_shenandoah I will approve this one here. But 17u is a stable release and now 3 years in maintenance. So please step back from backporting improvements to 17, except there is a really good reason for it. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2845#issuecomment-2345576518 From goetz at openjdk.org Thu Sep 12 08:28:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 08:28:25 GMT Subject: [jdk17u-dev] RFR: 8331405: Shenandoah: Optimize ShenandoahLock with TTAS In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 15:58:53 GMT, Xiaolong Peng wrote: > Hi, > This PR is a Backport of [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405): Shenandoah: Optimize ShenandoahLock with TTAS, the original commit was authored by Aleksey Shipilev on 2 May 2024 and was reviewed by Zhengyu Gu and Y. S. Ramakrishna, and it had already been backported to jdk21. > It is a clean merge w/o any conflicts, overall risk should be very minimal given it is single line change to apply TTAS. > > Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: > > | Bug | Title | PR | > | ----------- | ---------------------------------------------- |------------| > | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797) | > | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) | > | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | | > | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | | > > ### Additional test > - [x] Linux AArch64 server fastdebug, hotspot_gc_shenandoah GHA failure: unrelated, well known ClhsdbFindPC issue. @pengxiaolong please check the GHA tests before applying for approval. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2845#issuecomment-2345595118 From sshivang at openjdk.org Thu Sep 12 08:30:13 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Thu, 12 Sep 2024 08:30:13 GMT Subject: [jdk23u] Integrated: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test In-Reply-To: References: Message-ID: On Fri, 6 Sep 2024 16:02:34 GMT, Shivangi Gupta wrote: > This PR contains the changes of https://bugs.openjdk.org/browse/JDK-8335344 also. This pull request has now been integrated. Changeset: b2162ba4 Author: Shivangi Gupta Committer: Sean Coffey URL: https://git.openjdk.org/jdk23u/commit/b2162ba41b16f1f82df873d38205c9353d9c1c24 Stats: 403 lines in 6 files changed: 210 ins; 170 del; 23 mod 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test 8335344: test/jdk/sun/security/tools/keytool/NssTest.java fails to compile Reviewed-by: coffeys Backport-of: f4d8c005b35ce34c96027b7f3abb7a307bca3f4c ------------- PR: https://git.openjdk.org/jdk23u/pull/93 From fyang at openjdk.org Thu Sep 12 08:33:11 2024 From: fyang at openjdk.org (Fei Yang) Date: Thu, 12 Sep 2024 08:33:11 GMT Subject: [jdk21u-dev] Integrated: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 06:58:16 GMT, Fei Yang wrote: > Hi all, > > This pull request contains a backport of commit [9e0ccb8b](https://github.com/openjdk/jdk/commit/9e0ccb8bbd01ffbac466288977a770dd09e357af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fei Yang on 6 Sep 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson. > > Thanks! > > Testing: > - [x] GHA linux-cross-build job This pull request has now been integrated. Changeset: f2805076 Author: Fei Yang URL: https://git.openjdk.org/jdk21u-dev/commit/f2805076935977b5b46359af95fb5c08894c71f6 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap Backport-of: 9e0ccb8bbd01ffbac466288977a770dd09e357af ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/962 From fyang at openjdk.org Thu Sep 12 08:35:13 2024 From: fyang at openjdk.org (Fei Yang) Date: Thu, 12 Sep 2024 08:35:13 GMT Subject: [jdk17u-dev] Integrated: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 06:58:45 GMT, Fei Yang wrote: > Hi all, > > This pull request contains a backport of commit [9e0ccb8b](https://github.com/openjdk/jdk/commit/9e0ccb8bbd01ffbac466288977a770dd09e357af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fei Yang on 6 Sep 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson. > > Thanks! > > Testing: > - [x] GHA linux-cross-build job This pull request has now been integrated. Changeset: 3248a611 Author: Fei Yang URL: https://git.openjdk.org/jdk17u-dev/commit/3248a61180ca910f03b7eea41bb005b2c827354f Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap Backport-of: 9e0ccb8bbd01ffbac466288977a770dd09e357af ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2860 From goetz at openjdk.org Thu Sep 12 09:13:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 09:13:09 GMT Subject: [jdk17u-dev] RFR: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null In-Reply-To: References: Message-ID: <5H2DDo3iDbbGAjUrxfHGhUI99IB3JH5iY4N3y4BM4rU=.bb4d667a-0edc-432e-a9b2-67561bff7e9b@github.com> On Wed, 28 Aug 2024 12:44:10 GMT, Matthias Baesken wrote: > 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null GHA failure: ClhsdbFindPC is known to fail in GHA on mac aarch. Here we see a different error situation, the test times out. But this surely is unrelated to this fix. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2829#issuecomment-2345707592 From goetz at openjdk.org Thu Sep 12 09:13:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 09:13:10 GMT Subject: [jdk17u-dev] RFR: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 13:00:13 GMT, Thomas Stuefe wrote: >> 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null > > src/hotspot/share/memory/guardedMemory.cpp line 38: > >> 36: if (ptr != nullptr) { >> 37: memcpy(innerp, ptr, len); >> 38: } > > Hmm. innerp can never be null. If anything, we should assert. Hi, I don't understand. First, innerp is not checked for null. Second: does the code in 17 differ to 21&head? Else we should change this to an assertion in head, first. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2829#discussion_r1756462276 From shade at openjdk.org Thu Sep 12 09:17:10 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 12 Sep 2024 09:17:10 GMT Subject: [jdk17u-dev] RFR: 8331405: Shenandoah: Optimize ShenandoahLock with TTAS In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 08:19:00 GMT, Goetz Lindenmaier wrote: > I will approve this one here. But 17u is a stable release and now 3 years in maintenance. So please step back from backporting improvements to 17, except there is a really good reason for it. Context: This patch series is fixing the issues seen that we have seen as problems in real services running Shenandoah with lots of Java threads. Alas, until services are able to migrate to JDK 21 en masse -- they only start doing this -- we unfortunately have a good reason to backport these fixes to 17u. We certainly should stop at 17u, and not backport fixes to 11u and 8u. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2845#issuecomment-2345715899 From goetz at openjdk.org Thu Sep 12 09:27:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 09:27:06 GMT Subject: [jdk17u-dev] RFR: 8273979: move some os time related functions to os_posix for POSIX platforms In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 10:02:20 GMT, Radim Vansa wrote: >> Hi @rvansa >> I am not so happy about this backport. >> Simplifying another project is not an eligible reason to backport things. >> Also, you did not test macos and expecially not aix. Does that still build? > > Hi @GoeLin , understood, though I am rather trying to be honest than making up a synthetic argument. Since it was accepted in the mainline I could say that it is an improvement in code quality. > > MacOS should be tested here in GHA, regrettably I don't know where to get AIX for testing. Hi @rvansa @suchismith1993, Suchismith, could you verify that the backport is fine on aix? Thanks! @rvansa, you find people involved in the aix port on the corresponding project page https://wiki.openjdk.org/display/PPCAIXPort or on the OpenJDK census. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2831#issuecomment-2345737609 From stuefe at openjdk.org Thu Sep 12 09:35:07 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 12 Sep 2024 09:35:07 GMT Subject: [jdk17u-dev] RFR: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 09:09:57 GMT, Goetz Lindenmaier wrote: >> src/hotspot/share/memory/guardedMemory.cpp line 38: >> >>> 36: if (ptr != nullptr) { >>> 37: memcpy(innerp, ptr, len); >>> 38: } >> >> Hmm. innerp can never be null. If anything, we should assert. > > Hi, > I don't understand. First, innerp is not checked for null. Second: does the code in 17 differ to 21&head? Else we should change this to an assertion in head, first. Hi Goetz! `innerp` is the result of u_char* get_user_ptr() const { assert(_base_addr != nullptr, "Not wrapping any memory"); return _base_addr + sizeof(GuardHeader); } which cannot return null. _base_addr is the result of a malloc and we only ever enter this path if that malloc succeeded. It is also asserted at least twice. Cheers, Thomas ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2829#discussion_r1756499855 From andrewlu at openjdk.org Thu Sep 12 09:38:35 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 12 Sep 2024 09:38:35 GMT Subject: [jdk17u-dev] RFR: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. Message-ID: I backport this for parity with 17.0.14-oracle. test/jdk/ProblemList.txt not edit as it's not exist. ------------- Commit messages: - Backport f0c2f098150335fce736708354d58bae383cc4a1 Changes: https://git.openjdk.org/jdk17u-dev/pull/2866/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2866&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296972 Stats: 39 lines in 2 files changed: 38 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2866.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2866/head:pull/2866 PR: https://git.openjdk.org/jdk17u-dev/pull/2866 From andrewlu at openjdk.org Thu Sep 12 10:05:42 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 12 Sep 2024 10:05:42 GMT Subject: [jdk17u-dev] RFR: 8303705: Field sleeper.started should be volatile JdbLockTestTarg.java Message-ID: <0DQF_z7ZlPWr9PWWOw7hgHAx_HdR0HowNiqdp4IGcMU=.4787fcb9-43a0-442b-98d9-679d89eab378@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport cd41c69d4484f900a89a71f1c9bab2bc2e383c1e Changes: https://git.openjdk.org/jdk17u-dev/pull/2867/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2867&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303705 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2867.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2867/head:pull/2867 PR: https://git.openjdk.org/jdk17u-dev/pull/2867 From goetz at openjdk.org Thu Sep 12 10:12:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 10:12:20 GMT Subject: [jdk21u-dev] RFR: 8296787: Unify debug printing format of X.509 cert serial numbers Message-ID: I backport this for parity with 21.0.6-oracle. Trivial resolve in Debug.java, probably recognized clean. ------------- Commit messages: - Backport c328f9589ddc3a981a2c63801bd991f8e593e69f Changes: https://git.openjdk.org/jdk21u-dev/pull/966/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=966&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296787 Stats: 65 lines in 18 files changed: 19 ins; 3 del; 43 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/966.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/966/head:pull/966 PR: https://git.openjdk.org/jdk21u-dev/pull/966 From goetz at openjdk.org Thu Sep 12 10:15:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 10:15:06 GMT Subject: [jdk17u-dev] RFR: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 09:32:15 GMT, Thomas Stuefe wrote: >> Hi, >> I don't understand. First, innerp is not checked for null. Second: does the code in 17 differ to 21&head? Else we should change this to an assertion in head, first. > > Hi Goetz! > > `innerp` is the result of > > > u_char* get_user_ptr() const { > assert(_base_addr != nullptr, "Not wrapping any memory"); > return _base_addr + sizeof(GuardHeader); > } > > > which cannot return null. _base_addr is the result of a malloc and we only ever enter this path if that malloc succeeded. It is also asserted at least twice. > > Cheers, Thomas Yes, but the new code checks whether "ptr" is null. That is passed in as an argument. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2829#discussion_r1756563140 From xpeng at openjdk.org Thu Sep 12 10:30:09 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Thu, 12 Sep 2024 10:30:09 GMT Subject: [jdk17u-dev] RFR: 8331405: Shenandoah: Optimize ShenandoahLock with TTAS In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 08:25:55 GMT, Goetz Lindenmaier wrote: >> Hi, >> This PR is a Backport of [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405): Shenandoah: Optimize ShenandoahLock with TTAS, the original commit was authored by Aleksey Shipilev on 2 May 2024 and was reviewed by Zhengyu Gu and Y. S. Ramakrishna, and it had already been backported to jdk21. >> It is a clean merge w/o any conflicts, overall risk should be very minimal given it is single line change to apply TTAS. >> >> Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: >> >> | Bug | Title | PR | >> | ----------- | ---------------------------------------------- |------------| >> | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797) | >> | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) | >> | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | | >> | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | | >> >> ### Additional test >> - [x] Linux AArch64 server fastdebug, hotspot_gc_shenandoah > > GHA failure: unrelated, well known ClhsdbFindPC issue. > > @pengxiaolong please check the GHA tests before applying for approval. @GoeLin Thanks for the review and approval, appreciate it! I did checked the GHA tests result and verified that the failures are not related this this change, should had mentioned it in the approval request or comments. I understand that we prefer not to backport non-bug-fix changes to jdk17. As Aleksey said, we have seem the issue is causing problems in real services running in our production environment which will be in jdk17 for few more years I believe, also jdk17 will is the most widely adopted release, hence we decided to do these backports. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2845#issuecomment-2345867743 From duke at openjdk.org Thu Sep 12 10:30:10 2024 From: duke at openjdk.org (duke) Date: Thu, 12 Sep 2024 10:30:10 GMT Subject: [jdk17u-dev] RFR: 8331405: Shenandoah: Optimize ShenandoahLock with TTAS In-Reply-To: References: Message-ID: <3SCl-LPe_Q2S3Hdw3kn12ep3d0n0oqWqtLIqvA2H1vo=.dce99d98-44e8-4069-8391-7deafbcb089d@github.com> On Tue, 3 Sep 2024 15:58:53 GMT, Xiaolong Peng wrote: > Hi, > This PR is a Backport of [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405): Shenandoah: Optimize ShenandoahLock with TTAS, the original commit was authored by Aleksey Shipilev on 2 May 2024 and was reviewed by Zhengyu Gu and Y. S. Ramakrishna, and it had already been backported to jdk21. > It is a clean merge w/o any conflicts, overall risk should be very minimal given it is single line change to apply TTAS. > > Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: > > | Bug | Title | PR | > | ----------- | ---------------------------------------------- |------------| > | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797) | > | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) | > | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | | > | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | | > > ### Additional test > - [x] Linux AArch64 server fastdebug, hotspot_gc_shenandoah @pengxiaolong Your change (at version efaf5af73a16f6070b2f2b39c9f00afbff3382c8) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2845#issuecomment-2345870141 From xpeng at openjdk.org Thu Sep 12 10:40:10 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Thu, 12 Sep 2024 10:40:10 GMT Subject: [jdk17u-dev] Integrated: 8331405: Shenandoah: Optimize ShenandoahLock with TTAS In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 15:58:53 GMT, Xiaolong Peng wrote: > Hi, > This PR is a Backport of [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405): Shenandoah: Optimize ShenandoahLock with TTAS, the original commit was authored by Aleksey Shipilev on 2 May 2024 and was reviewed by Zhengyu Gu and Y. S. Ramakrishna, and it had already been backported to jdk21. > It is a clean merge w/o any conflicts, overall risk should be very minimal given it is single line change to apply TTAS. > > Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: > > | Bug | Title | PR | > | ----------- | ---------------------------------------------- |------------| > | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797) | > | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) | > | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | | > | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | | > > ### Additional test > - [x] Linux AArch64 server fastdebug, hotspot_gc_shenandoah This pull request has now been integrated. Changeset: 6f991090 Author: Xiaolong Peng Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/6f991090d3749c8f5002cf2e7902f6a29324d3ff Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8331405: Shenandoah: Optimize ShenandoahLock with TTAS Backport-of: c4fe5bf90c2d368c29714de63a90eca444fb3ece ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2845 From goetz at openjdk.org Thu Sep 12 11:58:18 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 11:58:18 GMT Subject: [jdk21u-dev] RFR: 8328303: 3 JDI tests timed out with UT enabled Message-ID: I backport this to improve testing. Without this, 8326898 might cause problems. ------------- Commit messages: - Backport bc73963974a824d77d54b8b0edbf8f05262b721c Changes: https://git.openjdk.org/jdk21u-dev/pull/967/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=967&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328303 Stats: 97 lines in 3 files changed: 37 ins; 22 del; 38 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/967.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/967/head:pull/967 PR: https://git.openjdk.org/jdk21u-dev/pull/967 From goetz at openjdk.org Thu Sep 12 12:13:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 12:13:39 GMT Subject: [jdk21u-dev] RFR: 8326898: NSK tests should listen on loopback addresses only Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 2482a505e5c898cc6365aa4fb8ca3e8b758b3a97 Changes: https://git.openjdk.org/jdk21u-dev/pull/968/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=968&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326898 Stats: 22 lines in 6 files changed: 2 ins; 0 del; 20 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/968.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/968/head:pull/968 PR: https://git.openjdk.org/jdk21u-dev/pull/968 From goetz at openjdk.org Thu Sep 12 12:30:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 12:30:40 GMT Subject: [jdk21u-dev] RFR: 8321550: Update several runtime/cds tests to use vm flags or mark as flagless Message-ID: <3FaoYlm0XMRkkPWQvHF6t6kndaAFU-fhcNQLX4MrdPQ=.7a9b8bac-7c1e-432f-9862-0d5959deac41@github.com> I include two follow ups. All three are clean backports. ------------- Commit messages: - Backport 8329353: ResolvedReferencesNotNullTest.java failed with Incorrect resolved... - Backport 8329533: TestCDSVMCrash fails on libgraal - Backport d1b51e39c952df4885a424afd01161c601ef0f72 Changes: https://git.openjdk.org/jdk21u-dev/pull/969/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=969&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321550 Stats: 10 lines in 4 files changed: 6 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/969.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/969/head:pull/969 PR: https://git.openjdk.org/jdk21u-dev/pull/969 From goetz at openjdk.org Thu Sep 12 12:53:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 12:53:49 GMT Subject: [jdk21u-dev] RFR: 8332340: Add JavacBench as a test case for CDS Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 7fd9d6c760c66d3e2f4034cf1a6b1b583ff829a9 Changes: https://git.openjdk.org/jdk21u-dev/pull/970/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=970&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332340 Stats: 607 lines in 4 files changed: 607 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/970.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/970/head:pull/970 PR: https://git.openjdk.org/jdk21u-dev/pull/970 From goetz at openjdk.org Thu Sep 12 13:18:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 13:18:31 GMT Subject: [jdk21u-dev] RFR: 8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport b3e29db14466ccc64a2815224ecefab4cec4c775 Changes: https://git.openjdk.org/jdk21u-dev/pull/971/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=971&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333108 Stats: 42 lines in 6 files changed: 16 ins; 21 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/971.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/971/head:pull/971 PR: https://git.openjdk.org/jdk21u-dev/pull/971 From goetz at openjdk.org Thu Sep 12 13:40:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 13:40:16 GMT Subject: [jdk21u-dev] RFR: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test Message-ID: I backport this for parity with 21.0.6-oracle. I omitted the changes to test/jdk/ProblemList.txt and test/jdk/ProblemList.txt as the test never was listed there. ------------- Commit messages: - Backport a5c2d7b305407974b3f67c48b8dcb1f8e77abde3 Changes: https://git.openjdk.org/jdk21u-dev/pull/972/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=972&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335172 Stats: 15 lines in 2 files changed: 13 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/972.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/972/head:pull/972 PR: https://git.openjdk.org/jdk21u-dev/pull/972 From xpeng at openjdk.org Thu Sep 12 13:56:25 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Thu, 12 Sep 2024 13:56:25 GMT Subject: [jdk17u-dev] RFR: 8331411: Shenandoah: Reconsider spinning duration in ShenandoahLock Message-ID: Hi, This PR is a Backport of [[JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411)]: Reconsider spinning duration in ShenandoahLock. The original commit was authored by Xiaolong Peng on 26 June 2024 and was reviewed by[Aleksey Shipil?v](https://github.com/shipilev), [Kelvin Nilsen](https://github.com/kdnilsen), and [William Kemper](https://github.com/earthling-amzn), it had already been backported to jdk21. It was not a clean merge, there were some conflicts and API change which have been resolved and tested. Meanwhile, given there were conflicts to resolve, I also updated the invalid comments which was fixed in JDK-8335904. This is the third PR of the series of improvements we are proposing to backport to jdk17 to solve the contention issue in ShenandoahLock, we have observed the lock contention is causing real problems in some of our products. Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: | Bug | Title | PR | | ----------- | ---------------------------------------------- |------------| | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797) | | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) | | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | X | ### Additional test - [x] MacOS AArch64 server fastdebug, hotspot_gc_shenandoah ------------- Commit messages: - Use thread->as_Java_thread instead of JavaThread::cast - Backport 817edcb697cbb8c608c9292cdc4b99db4f5844dc Changes: https://git.openjdk.org/jdk17u-dev/pull/2868/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2868&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331411 Stats: 47 lines in 2 files changed: 22 ins; 11 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2868.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2868/head:pull/2868 PR: https://git.openjdk.org/jdk17u-dev/pull/2868 From xpeng at openjdk.org Thu Sep 12 14:00:54 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Thu, 12 Sep 2024 14:00:54 GMT Subject: [jdk17u-dev] RFR: 8331411: Shenandoah: Reconsider spinning duration in ShenandoahLock [v2] In-Reply-To: References: Message-ID: > Hi, > This PR is a Backport of [[JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411)]: Reconsider spinning duration in ShenandoahLock. The original commit was authored by Xiaolong Peng on 26 June 2024 and was reviewed by[Aleksey Shipil?v](https://github.com/shipilev), [Kelvin Nilsen](https://github.com/kdnilsen), and [William Kemper](https://github.com/earthling-amzn), it had already been backported to jdk21. > > It was not a clean merge, there were some conflicts and API change which have been resolved and tested. Meanwhile, given there were conflicts to resolve, I also updated the invalid comments which was fixed in JDK-8335904. > > This is the third PR of the series of improvements we are proposing to backport to jdk17 to solve the contention issue in ShenandoahLock, we have observed the lock contention is causing real problems in some of our products. > > Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: > > | Bug | Title | PR | > | ----------- | ---------------------------------------------- |------------| > | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797) | > | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) | > | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | > | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | X | > > ### Additional test > - [x] MacOS AArch64 server fastdebug, hotspot_gc_shenandoah Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: Correct comments ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2868/files - new: https://git.openjdk.org/jdk17u-dev/pull/2868/files/a8d0ce60..e7cbe842 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2868&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2868&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2868.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2868/head:pull/2868 PR: https://git.openjdk.org/jdk17u-dev/pull/2868 From goetz at openjdk.org Thu Sep 12 14:06:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 14:06:12 GMT Subject: [jdk21u-dev] RFR: 8337320: Update ProblemList.txt with tests known to fail on XWayland [v2] In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 05:40:50 GMT, Andrew Lu wrote: >> I backport this for parity with 21.0.6-oracle. >> Not clean, this file java/awt/FullScreen/SetFullScreenTest.java does not exist in jdk21 > > Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: > > update LGTM ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/961#pullrequestreview-2300429412 From goetz at openjdk.org Thu Sep 12 14:14:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 14:14:11 GMT Subject: [jdk17u-dev] RFR: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 09:33:35 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. > test/jdk/ProblemList.txt > not edit as it's not exist. LGTM ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2866#pullrequestreview-2300450461 From goetz at openjdk.org Thu Sep 12 14:17:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 14:17:10 GMT Subject: [jdk17u-dev] RFR: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 09:33:35 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. > test/jdk/ProblemList.txt > not edit as it's not exist. GHA failure: Well known ClhsdbFindPC issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2866#issuecomment-2346424195 From goetz at openjdk.org Thu Sep 12 15:05:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 15:05:07 GMT Subject: [jdk17u-dev] RFR: 8286160: (fs) Files.exists returns unexpected results with C:\pagefile.sys because it's not readable In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 06:49:52 GMT, Goetz Lindenmaier wrote: > A clean backport to fix this windows issue. GHA failure: well known ClhsdbFindPC issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2859#issuecomment-2346550261 From goetz at openjdk.org Thu Sep 12 15:08:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 15:08:06 GMT Subject: [jdk17u-dev] Integrated: 8286160: (fs) Files.exists returns unexpected results with C:\pagefile.sys because it's not readable In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 06:49:52 GMT, Goetz Lindenmaier wrote: > A clean backport to fix this windows issue. This pull request has now been integrated. Changeset: 81b2c8df Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/81b2c8df001fde192d5e923590c90e1ddabe7f0b Stats: 47 lines in 2 files changed: 33 ins; 3 del; 11 mod 8286160: (fs) Files.exists returns unexpected results with C:\pagefile.sys because it's not readable Backport-of: d482d7f5b99e89185471c05cde797f13405c32f2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2859 From goetz at openjdk.org Thu Sep 12 15:49:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 15:49:33 GMT Subject: [jdk17u-dev] RFR: 8282578: AIOOBE in javax.sound.sampled.Clip Message-ID: <9EjtJ9g6NsXG3DC4dsyzkEOvxabtj1JfswLnVgBQNjE=.cc0ad45d-d9ca-4a57-88b3-a3c5e40f2e88@github.com> I backport this for parity with 17.0.14-oracle. Resolved copyright, probably clean anyways. ------------- Commit messages: - Backport af8fb7eef7188ef762399cfb3faf5c8afd49efa7 Changes: https://git.openjdk.org/jdk17u-dev/pull/2869/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2869&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282578 Stats: 544 lines in 4 files changed: 295 ins; 105 del; 144 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2869.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2869/head:pull/2869 PR: https://git.openjdk.org/jdk17u-dev/pull/2869 From goetz at openjdk.org Thu Sep 12 15:51:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Sep 2024 15:51:20 GMT Subject: [jdk17u-dev] RFR: 8294193: Files.createDirectories throws FileAlreadyExistsException for a symbolic link whose target is an existing directory Message-ID: <1tPfpg9qMX3AgosKOpOeSwUOvYsoNNgbQ8mUjN-OD24=.d6cce647-6972-4c19-9726-3e37eabfc168@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 169a5d48afbc6627f36a768c17c2a5e56219d9c7 Changes: https://git.openjdk.org/jdk17u-dev/pull/2870/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2870&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294193 Stats: 161 lines in 3 files changed: 124 ins; 34 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2870.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2870/head:pull/2870 PR: https://git.openjdk.org/jdk17u-dev/pull/2870 From serb at openjdk.org Thu Sep 12 16:10:09 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 12 Sep 2024 16:10:09 GMT Subject: [jdk21u-dev] Integrated: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above In-Reply-To: References: Message-ID: On Wed, 26 Jun 2024 00:21:14 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [999e556b](https://github.com/openjdk/jdk/commit/999e556be4302de4b6911e6d62ee5ca556a76469) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Harshitha Onkar on 12 Jan 2024 and was reviewed by Sergey Bylokhov, Tejesh R and Alexander Zvegintsev. > > Thanks! This pull request has now been integrated. Changeset: 29b65ab0 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u-dev/commit/29b65ab034d40f582505b93f38e0287453b4f796 Stats: 91 lines in 2 files changed: 90 ins; 0 del; 1 mod 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above Backport-of: 999e556be4302de4b6911e6d62ee5ca556a76469 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/793 From wkemper at openjdk.org Thu Sep 12 22:34:32 2024 From: wkemper at openjdk.org (William Kemper) Date: Thu, 12 Sep 2024 22:34:32 GMT Subject: [jdk21u-dev] RFR: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate Message-ID: <_-Tp2qhNmlZNquRSjo8f1x226hwBY3Ra7AnEmtJ9Gcw=.6fa12ab2-b85d-456f-be8b-df1f3e1f6f6b@github.com> Clean backport. Change is confined to Shenandoah. ------------- Commit messages: - Backport e74edbaea9f09169f597a470f647f3b7d10cc71b Changes: https://git.openjdk.org/jdk21u-dev/pull/973/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=973&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336640 Stats: 21 lines in 2 files changed: 14 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/973.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/973/head:pull/973 PR: https://git.openjdk.org/jdk21u-dev/pull/973 From andrewlu at openjdk.org Fri Sep 13 06:21:23 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 13 Sep 2024 06:21:23 GMT Subject: [jdk21u-dev] RFR: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 2b5aec2aad3883d4d407ec3a572f78755d60190d Changes: https://git.openjdk.org/jdk21u-dev/pull/974/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=974&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338109 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/974.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/974/head:pull/974 PR: https://git.openjdk.org/jdk21u-dev/pull/974 From andrewlu at openjdk.org Fri Sep 13 06:48:41 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 13 Sep 2024 06:48:41 GMT Subject: [jdk17u-dev] RFR: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList Message-ID: I backport this for parity with 17.0.14-oracle. ?java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java 8332158 linux-x64? not exist, no need to remove ------------- Commit messages: - Backport 2b5aec2aad3883d4d407ec3a572f78755d60190d Changes: https://git.openjdk.org/jdk17u-dev/pull/2871/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2871&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338109 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2871.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2871/head:pull/2871 PR: https://git.openjdk.org/jdk17u-dev/pull/2871 From rehn at openjdk.org Fri Sep 13 07:18:40 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Fri, 13 Sep 2024 07:18:40 GMT Subject: [jdk23u] RFR: 8339741: RISC-V: C ABI breakage for integer on stack Message-ID: <5lnL_D2b0PDuH-PvEEqggQ4bFHp2gbYAuaNVi1cvcBU=.cb2591f4-6258-49a3-9f44-c748fbd14c61@github.com> Hi all, This pull request contains a backport of commit [bfe7f920](https://github.com/openjdk/jdk/commit/bfe7f9205b56483b4364130a3a87c58c3fc82998) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry. Thanks! ------------- Commit messages: - Backport bfe7f9205b56483b4364130a3a87c58c3fc82998 Changes: https://git.openjdk.org/jdk23u/pull/96/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=96&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339741 Stats: 156 lines in 4 files changed: 150 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk23u/pull/96.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/96/head:pull/96 PR: https://git.openjdk.org/jdk23u/pull/96 From fyang at openjdk.org Fri Sep 13 08:01:10 2024 From: fyang at openjdk.org (Fei Yang) Date: Fri, 13 Sep 2024 08:01:10 GMT Subject: [jdk23u] RFR: 8339741: RISC-V: C ABI breakage for integer on stack In-Reply-To: <5lnL_D2b0PDuH-PvEEqggQ4bFHp2gbYAuaNVi1cvcBU=.cb2591f4-6258-49a3-9f44-c748fbd14c61@github.com> References: <5lnL_D2b0PDuH-PvEEqggQ4bFHp2gbYAuaNVi1cvcBU=.cb2591f4-6258-49a3-9f44-c748fbd14c61@github.com> Message-ID: On Fri, 13 Sep 2024 07:12:47 GMT, Robbin Ehn wrote: > Hi all, > > This pull request contains a backport of commit [bfe7f920](https://github.com/openjdk/jdk/commit/bfe7f9205b56483b4364130a3a87c58c3fc82998) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry. > > Thanks! Thanks! ------------- Marked as reviewed by fyang (Reviewer). PR Review: https://git.openjdk.org/jdk23u/pull/96#pullrequestreview-2302396572 From mbaesken at openjdk.org Fri Sep 13 14:23:16 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 13 Sep 2024 14:23:16 GMT Subject: [jdk17u-dev] RFR: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null In-Reply-To: References: Message-ID: <28VqbuWwvOWHbnLu452NfCrW9yY2oHy3jEvXpbouYZk=.f3bb6814-e4c0-4b4b-b55d-aa5dcf37e8e5@github.com> On Thu, 12 Sep 2024 10:12:54 GMT, Goetz Lindenmaier wrote: >> Hi Goetz! >> >> `innerp` is the result of >> >> >> u_char* get_user_ptr() const { >> assert(_base_addr != nullptr, "Not wrapping any memory"); >> return _base_addr + sizeof(GuardHeader); >> } >> >> >> which cannot return null. _base_addr is the result of a malloc and we only ever enter this path if that malloc succeeded. It is also asserted at least twice. >> >> Cheers, Thomas > > Yes, but the new code checks whether "ptr" is null. That is passed in as an argument. we call `GuardedMemory::wrap_copy(no_data, 0);` This makes `ptr == NULL / nullptr` . See the full backtrace here https://github.com/openjdk/jdk/pull/19382 It is a clean backport so should be the same in 17. The check was added to handle to no_data / length 0 case . ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2829#discussion_r1758955665 From mbaesken at openjdk.org Fri Sep 13 14:23:17 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 13 Sep 2024 14:23:17 GMT Subject: [jdk17u-dev] Integrated: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 12:44:10 GMT, Matthias Baesken wrote: > 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null This pull request has now been integrated. Changeset: 7161e295 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/7161e295db67ebdd901ac3fca4c1337dc602e944 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null Backport-of: be1d374bc54d43aae3b3c1feace22d38fe2156b6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2829 From stuefe at openjdk.org Fri Sep 13 14:31:13 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 13 Sep 2024 14:31:13 GMT Subject: [jdk17u-dev] RFR: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null In-Reply-To: <28VqbuWwvOWHbnLu452NfCrW9yY2oHy3jEvXpbouYZk=.f3bb6814-e4c0-4b4b-b55d-aa5dcf37e8e5@github.com> References: <28VqbuWwvOWHbnLu452NfCrW9yY2oHy3jEvXpbouYZk=.f3bb6814-e4c0-4b4b-b55d-aa5dcf37e8e5@github.com> Message-ID: On Fri, 13 Sep 2024 14:16:14 GMT, Matthias Baesken wrote: >> Yes, but the new code checks whether "ptr" is null. That is passed in as an argument. > > we call > `GuardedMemory::wrap_copy(no_data, 0);` > This makes `ptr == NULL / nullptr` . > See the full backtrace here https://github.com/openjdk/jdk/pull/19382 > It is a clean backport so should be the same in 17. The check was added to handle to no_data / length 0 case . Okay, I just misread the code. Sorry for the confusion, I was too tired. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2829#discussion_r1758975287 From shade at openjdk.org Fri Sep 13 14:40:11 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 13 Sep 2024 14:40:11 GMT Subject: [jdk21u-dev] RFR: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate In-Reply-To: <_-Tp2qhNmlZNquRSjo8f1x226hwBY3Ra7AnEmtJ9Gcw=.6fa12ab2-b85d-456f-be8b-df1f3e1f6f6b@github.com> References: <_-Tp2qhNmlZNquRSjo8f1x226hwBY3Ra7AnEmtJ9Gcw=.6fa12ab2-b85d-456f-be8b-df1f3e1f6f6b@github.com> Message-ID: On Thu, 12 Sep 2024 22:29:41 GMT, William Kemper wrote: > Clean backport. Change is confined to Shenandoah. Looks fine, thanks. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/973#pullrequestreview-2303311758 From goetz at openjdk.org Fri Sep 13 14:50:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 14:50:16 GMT Subject: [jdk21u-dev] RFR: 8326898: NSK tests should listen on loopback addresses only In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 12:07:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/968#issuecomment-2349136298 From goetz at openjdk.org Fri Sep 13 14:50:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 14:50:17 GMT Subject: [jdk21u-dev] RFR: 8321550: Update several runtime/cds tests to use vm flags or mark as flagless In-Reply-To: <3FaoYlm0XMRkkPWQvHF6t6kndaAFU-fhcNQLX4MrdPQ=.7a9b8bac-7c1e-432f-9862-0d5959deac41@github.com> References: <3FaoYlm0XMRkkPWQvHF6t6kndaAFU-fhcNQLX4MrdPQ=.7a9b8bac-7c1e-432f-9862-0d5959deac41@github.com> Message-ID: On Thu, 12 Sep 2024 12:24:45 GMT, Goetz Lindenmaier wrote: > I include two follow ups. All three are clean backports. GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/969#issuecomment-2349136450 From goetz at openjdk.org Fri Sep 13 14:50:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 14:50:23 GMT Subject: [jdk21u-dev] RFR: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 13:35:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. > > > This depends on [JDK-8320586](https://bugs.openjdk.org/browse/JDK-8320586), will wait until that is pushed. GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/972#issuecomment-2349136885 From goetz at openjdk.org Fri Sep 13 14:50:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 14:50:24 GMT Subject: [jdk21u-dev] RFR: 8328303: 3 JDI tests timed out with UT enabled In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 11:53:19 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing. Without this, 8326898 might cause problems. GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/967#issuecomment-2349136138 From goetz at openjdk.org Fri Sep 13 14:50:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 14:50:25 GMT Subject: [jdk21u-dev] RFR: 8296787: Unify debug printing format of X.509 cert serial numbers In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 10:05:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. > > Trivial resolve in Debug.java, probably recognized clean. GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/966#issuecomment-2349135904 From goetz at openjdk.org Fri Sep 13 14:50:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 14:50:25 GMT Subject: [jdk21u-dev] RFR: 8332340: Add JavacBench as a test case for CDS In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 12:47:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/970#issuecomment-2349136612 From mbaesken at openjdk.org Fri Sep 13 15:00:15 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 13 Sep 2024 15:00:15 GMT Subject: [jdk21u-dev] RFR: 8321550: Update several runtime/cds tests to use vm flags or mark as flagless In-Reply-To: <3FaoYlm0XMRkkPWQvHF6t6kndaAFU-fhcNQLX4MrdPQ=.7a9b8bac-7c1e-432f-9862-0d5959deac41@github.com> References: <3FaoYlm0XMRkkPWQvHF6t6kndaAFU-fhcNQLX4MrdPQ=.7a9b8bac-7c1e-432f-9862-0d5959deac41@github.com> Message-ID: <1v2qwkMxa6DFsIiTl6slgqnZpYicMzqMYvCjHBMg72o=.8a5ccf44-7f06-4236-8733-11aa0ddc354a@github.com> On Thu, 12 Sep 2024 12:24:45 GMT, Goetz Lindenmaier wrote: > I include two follow ups. All three are clean backports. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/969#pullrequestreview-2303367104 From goetz at openjdk.org Fri Sep 13 15:00:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 15:00:34 GMT Subject: [jdk17u-dev] RFR: 8282578: AIOOBE in javax.sound.sampled.Clip In-Reply-To: <9EjtJ9g6NsXG3DC4dsyzkEOvxabtj1JfswLnVgBQNjE=.cc0ad45d-d9ca-4a57-88b3-a3c5e40f2e88@github.com> References: <9EjtJ9g6NsXG3DC4dsyzkEOvxabtj1JfswLnVgBQNjE=.cc0ad45d-d9ca-4a57-88b3-a3c5e40f2e88@github.com> Message-ID: <5kWSCQO4tTM03BUu8SgnbhnyJYZPQJFjywgxCqO8Q7A=.24804911-9301-4762-accf-ae70fa2fd2c1@github.com> On Thu, 12 Sep 2024 15:43:06 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Resolved copyright, probably clean anyways. GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2869#issuecomment-2349157057 From goetz at openjdk.org Fri Sep 13 15:05:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 15:05:15 GMT Subject: [jdk17u] Integrated: 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 In-Reply-To: References: Message-ID: <1Jucu48k98mCAoeV2DXW1O9ILZS-nwDSpNgjUSExzZM=.911a148c-0e4f-4aca-b1cb-b21e436496a7@github.com> On Wed, 11 Sep 2024 12:05:38 GMT, Goetz Lindenmaier wrote: > Backport from jdk21u. > > Testing: > The failure was sporadic, but we saw it in our 4 daily test runs (21u, 21u-dev, 17u, 17u-dev) about once a day. Since adding this fix temporary to the four test setups on September 3rd, we have not encountered the problem again. This pull request has now been integrated. Changeset: 9eab2ce8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u/commit/9eab2ce877155ca537f7ea4e80e81d9851bb2607 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 Backport-of: 34b4bd449e8eef32d47ad4f0fb8c22139e0680d6 ------------- PR: https://git.openjdk.org/jdk17u/pull/398 From goetz at openjdk.org Fri Sep 13 15:17:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 15:17:19 GMT Subject: [jdk17u-dev] RFR: 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags Message-ID: <4UU6DcnigDAFXi2Eo_brAGnbagVCROJP7DxWNgjKuDU=.95f99395-036c-48cc-9622-62695f1ebcc6@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 93e82c01460a70f214653a558d53c1c6180ae0d3 Changes: https://git.openjdk.org/jdk17u-dev/pull/2872/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2872&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314824 Stats: 6 lines in 1 file changed: 3 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2872.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2872/head:pull/2872 PR: https://git.openjdk.org/jdk17u-dev/pull/2872 From goetz at openjdk.org Fri Sep 13 15:19:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 15:19:20 GMT Subject: [jdk17u-dev] RFR: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags Message-ID: <-P1ArSMWzch8w3mmL_dyUBbclRwZkKypf8CjzHGqAeo=.24ae49b2-2916-495c-9811-dea84eff82d1@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 5cbff2460812fee707f9d96ab00a628d1ce3fbef Changes: https://git.openjdk.org/jdk17u-dev/pull/2873/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2873&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315406 Stats: 63 lines in 3 files changed: 3 ins; 50 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2873.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2873/head:pull/2873 PR: https://git.openjdk.org/jdk17u-dev/pull/2873 From goetz at openjdk.org Fri Sep 13 15:28:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 15:28:34 GMT Subject: [jdk17u-dev] RFR: 8314831: NMT tests ignore vm flags Message-ID: I backport this for parity with 17.0.14-oracle. Clean except for one file omitted: MallocLimitTest.java is not in 17, omitted. It was introduced by "8291878: NMT: Malloc limits" in jdk20, not a candidate for backport to 17 ------------- Commit messages: - Backport 9bf3dee2424bd8ccbc7ef0175c6e7165ff5cf1c6 Changes: https://git.openjdk.org/jdk17u-dev/pull/2874/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2874&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314831 Stats: 22 lines in 10 files changed: 5 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2874.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2874/head:pull/2874 PR: https://git.openjdk.org/jdk17u-dev/pull/2874 From goetz at openjdk.org Fri Sep 13 17:30:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 17:30:13 GMT Subject: [jdk17u] Integrated: 8329667: [macos] Issue with JTree related fix for JDK-8317771 In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 13:17:45 GMT, Goetz Lindenmaier wrote: > Backport to fix a regression in 17.0.11. > > I had to resolve a copyright. This pull request has now been integrated. Changeset: 35d9f972 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u/commit/35d9f97294c5ec4f9a55f46831bedc0433bcce3c Stats: 168 lines in 3 files changed: 96 ins; 64 del; 8 mod 8329667: [macos] Issue with JTree related fix for JDK-8317771 Backport-of: 05f13e75ee4407ba9213c69b33c6032aa87c9e95 ------------- PR: https://git.openjdk.org/jdk17u/pull/397 From goetz at openjdk.org Fri Sep 13 17:32:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 17:32:16 GMT Subject: [jdk21u-dev] Integrated: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 13:01:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 51626608 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/5162660842fe7ef33557e107b30f0b1db5dde466 Stats: 17 lines in 1 file changed: 9 ins; 2 del; 6 mod 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout Backport-of: 70c8ff1c9a9adf21a16d8a6b4da1eeec65afe61d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/963 From goetz at openjdk.org Fri Sep 13 17:32:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 17:32:10 GMT Subject: [jdk21u] Integrated: 8329667: [macos] Issue with JTree related fix for JDK-8317771 In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 13:10:24 GMT, Goetz Lindenmaier wrote: > A clean backport to fix a regression. This pull request has now been integrated. Changeset: 25185448 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u/commit/25185448ba668e8b96289edf7f02df50045c1a3a Stats: 168 lines in 3 files changed: 96 ins; 64 del; 8 mod 8329667: [macos] Issue with JTree related fix for JDK-8317771 Backport-of: 05f13e75ee4407ba9213c69b33c6032aa87c9e95 ------------- PR: https://git.openjdk.org/jdk21u/pull/452 From goetz at openjdk.org Fri Sep 13 17:52:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 17:52:35 GMT Subject: [jdk17u-dev] RFR: 8315988: Parallel: Make TestAggressiveHeap use createTestJvm Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport fbc766ee21ff7e6d414bd7d2c8bd7c9e1889a8af Changes: https://git.openjdk.org/jdk17u-dev/pull/2875/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2875&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315988 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2875.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2875/head:pull/2875 PR: https://git.openjdk.org/jdk17u-dev/pull/2875 From phh at openjdk.org Fri Sep 13 17:57:12 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 13 Sep 2024 17:57:12 GMT Subject: [jdk17u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v5] In-Reply-To: <1PzlEjnU4N1FBQtLDjDNnGIbc_DcX7GND9APTvc7x7M=.18376bcd-b518-4998-b3d7-c903d6c5ca23@github.com> References: <1PzlEjnU4N1FBQtLDjDNnGIbc_DcX7GND9APTvc7x7M=.18376bcd-b518-4998-b3d7-c903d6c5ca23@github.com> Message-ID: On Tue, 10 Sep 2024 02:31:50 GMT, Andrew Lu wrote: >> I backport this for parity with 17.0.13-oracle. >> modify lines are different, but code is clean. > > Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: > > fix Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2807#pullrequestreview-2303734559 From goetz at openjdk.org Fri Sep 13 17:59:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 17:59:35 GMT Subject: [jdk17u-dev] RFR: 8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags Message-ID: <-QPTg9X00GyXAr8ZToQi0UoibI_6Mi_YtKLnHeuMMRI=.b90ac533-2f6b-450c-aa44-2cc35f591770@github.com> I backport this for parity with 17.0.14-oracle. Resolved ProblemList, probably clean ------------- Commit messages: - Backport e0f8d16833c8212a79ea3dda3f4fe31134c41025 Changes: https://git.openjdk.org/jdk17u-dev/pull/2876/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2876&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314829 Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2876.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2876/head:pull/2876 PR: https://git.openjdk.org/jdk17u-dev/pull/2876 From goetz at openjdk.org Fri Sep 13 18:07:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 18:07:32 GMT Subject: [jdk17u-dev] RFR: 8316446: 4 sun/management/jdp tests ignore VM flags Message-ID: <7F88ENl0GSXpJjeBjSjpcefWGnd4wK9V3aTujpBGsRU=.de88b20c-d038-4278-9639-9beee148ec28@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 5b311f20dfaed0f34d38e8c5c6b90d97ffc75172 Changes: https://git.openjdk.org/jdk17u-dev/pull/2877/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2877&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316446 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2877.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2877/head:pull/2877 PR: https://git.openjdk.org/jdk17u-dev/pull/2877 From goetz at openjdk.org Fri Sep 13 18:25:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 18:25:15 GMT Subject: [jdk17u-dev] RFR: 8317042: G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 7e39e664cf6d4658b0aa03f9b5162cf7de40de28 Changes: https://git.openjdk.org/jdk17u-dev/pull/2878/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2878&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317042 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2878.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2878/head:pull/2878 PR: https://git.openjdk.org/jdk17u-dev/pull/2878 From goetz at openjdk.org Fri Sep 13 18:37:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 18:37:22 GMT Subject: [jdk17u-dev] RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed Message-ID: <2m5RBcPqkCRYYvicwrEgdjAXcrZ7ikzGxR0DCjlzXkI=.a4258ebf-f137-45e3-9d34-906b8d37ecd2@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 672f37324f9f15ae3e03b9b3b86c7106e6a09eed Changes: https://git.openjdk.org/jdk17u-dev/pull/2879/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2879&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321163 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2879.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2879/head:pull/2879 PR: https://git.openjdk.org/jdk17u-dev/pull/2879 From goetz at openjdk.org Fri Sep 13 18:41:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 18:41:22 GMT Subject: [jdk17u-dev] RFR: 8332724: x86 MacroAssembler may over-align code Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 08d51003d142e89b9d2f66187a4ea50e12b94fbb Changes: https://git.openjdk.org/jdk17u-dev/pull/2880/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2880&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332724 Stats: 9 lines in 4 files changed: 0 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2880.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2880/head:pull/2880 PR: https://git.openjdk.org/jdk17u-dev/pull/2880 From goetz at openjdk.org Fri Sep 13 18:42:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Sep 2024 18:42:41 GMT Subject: [jdk21u-dev] RFR: 8332724: x86 MacroAssembler may over-align code Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 08d51003d142e89b9d2f66187a4ea50e12b94fbb Changes: https://git.openjdk.org/jdk21u-dev/pull/975/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=975&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332724 Stats: 9 lines in 4 files changed: 0 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/975.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/975/head:pull/975 PR: https://git.openjdk.org/jdk21u-dev/pull/975 From phh at openjdk.org Fri Sep 13 22:26:25 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 13 Sep 2024 22:26:25 GMT Subject: [jdk17u-dev] RFR: 8331411: Shenandoah: Reconsider spinning duration in ShenandoahLock [v2] In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 14:00:54 GMT, Xiaolong Peng wrote: >> Hi, >> This PR is a Backport of [[JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411)]: Reconsider spinning duration in ShenandoahLock. The original commit was authored by Xiaolong Peng on 26 June 2024 and was reviewed by[Aleksey Shipil?v](https://github.com/shipilev), [Kelvin Nilsen](https://github.com/kdnilsen), and [William Kemper](https://github.com/earthling-amzn), it had already been backported to jdk21. >> >> It was not a clean merge, there were some conflicts and API change which have been resolved and tested. Meanwhile, given there were conflicts to resolve, I also updated the invalid comments which was fixed in JDK-8335904. >> >> This is the third PR of the series of improvements we are proposing to backport to jdk17 to solve the contention issue in ShenandoahLock, we have observed the lock contention is causing real problems in some of our products. >> >> Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: >> >> | Bug | Title | PR | >> | ----------- | ---------------------------------------------- |------------| >> | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797) | >> | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) | >> | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | >> | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | >> >> ### Additional test >> - [x] MacOS AArch64 server fastdebug, hotspot_gc_shenandoah > > Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: > > Correct comments Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2868#pullrequestreview-2304246601 From phh at openjdk.org Fri Sep 13 22:52:16 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 13 Sep 2024 22:52:16 GMT Subject: [jdk17u-dev] RFR: 8314831: NMT tests ignore vm flags In-Reply-To: References: Message-ID: On Fri, 13 Sep 2024 15:23:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Clean except for one file omitted: > MallocLimitTest.java is not in 17, omitted. It was introduced by > "8291878: NMT: Malloc limits" in jdk20, not a candidate for backport to 17 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2874#pullrequestreview-2304273286 From goetz at openjdk.org Sat Sep 14 07:58:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 14 Sep 2024 07:58:13 GMT Subject: [jdk17u-dev] RFR: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags In-Reply-To: <-P1ArSMWzch8w3mmL_dyUBbclRwZkKypf8CjzHGqAeo=.24ae49b2-2916-495c-9811-dea84eff82d1@github.com> References: <-P1ArSMWzch8w3mmL_dyUBbclRwZkKypf8CjzHGqAeo=.24ae49b2-2916-495c-9811-dea84eff82d1@github.com> Message-ID: On Fri, 13 Sep 2024 15:13:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2873#issuecomment-2350900304 From goetz at openjdk.org Sat Sep 14 07:58:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 14 Sep 2024 07:58:14 GMT Subject: [jdk17u-dev] RFR: 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags In-Reply-To: <4UU6DcnigDAFXi2Eo_brAGnbagVCROJP7DxWNgjKuDU=.95f99395-036c-48cc-9622-62695f1ebcc6@github.com> References: <4UU6DcnigDAFXi2Eo_brAGnbagVCROJP7DxWNgjKuDU=.95f99395-036c-48cc-9622-62695f1ebcc6@github.com> Message-ID: On Fri, 13 Sep 2024 15:11:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2872#issuecomment-2350900266 From goetz at openjdk.org Sat Sep 14 07:58:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 14 Sep 2024 07:58:17 GMT Subject: [jdk17u-dev] RFR: 8314831: NMT tests ignore vm flags In-Reply-To: References: Message-ID: On Fri, 13 Sep 2024 15:23:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Clean except for one file omitted: > MallocLimitTest.java is not in 17, omitted. It was introduced by > "8291878: NMT: Malloc limits" in jdk20, not a candidate for backport to 17 GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2874#issuecomment-2350900334 From goetz at openjdk.org Sat Sep 14 18:02:05 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 14 Sep 2024 18:02:05 GMT Subject: [jdk21u-dev] RFR: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 07:20:08 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.6-oracle. GHA failure: Well known Clhsdb issue. Unrelated ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/965#issuecomment-2351085230 From goetz at openjdk.org Sat Sep 14 18:22:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 14 Sep 2024 18:22:15 GMT Subject: [jdk21u-dev] RFR: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList In-Reply-To: References: Message-ID: On Fri, 13 Sep 2024 06:16:28 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.6-oracle. > > ?java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java 8332158 linux-x64? > not exist, no need to remove Hi, please revisit this once you pushed the wayland change. I think that brings the line you could not remove. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/974#issuecomment-2351091273 From goetz at openjdk.org Sat Sep 14 19:23:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 14 Sep 2024 19:23:41 GMT Subject: [jdk21u-dev] RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test Message-ID: I backport this for parity with 21.0.6-oracle. I include follow-up 8335344. Two clean backports. ------------- Commit messages: - Backport 8335344 - Backport f4d8c005b35ce34c96027b7f3abb7a307bca3f4c Changes: https://git.openjdk.org/jdk21u-dev/pull/976/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=976&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334562 Stats: 211 lines in 5 files changed: 18 ins; 170 del; 23 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/976.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/976/head:pull/976 PR: https://git.openjdk.org/jdk21u-dev/pull/976 From goetz at openjdk.org Sat Sep 14 19:55:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 14 Sep 2024 19:55:41 GMT Subject: [jdk21u] RFR: 8337622: IllegalArgumentException in java.lang.reflect.Field.get Message-ID: I backport this to fix the regression caused by 8333542 ------------- Commit messages: - Backport 41e31d6b0ae00d70b6fb20c89318fde2bc605edb Changes: https://git.openjdk.org/jdk21u/pull/454/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=454&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337622 Stats: 58 lines in 3 files changed: 51 ins; 7 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/454.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/454/head:pull/454 PR: https://git.openjdk.org/jdk21u/pull/454 From goetz at openjdk.org Sat Sep 14 19:59:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 14 Sep 2024 19:59:32 GMT Subject: [jdk21u-dev] RFR: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 284671a1e4fb5bfe15b20b7f41fc24415b1235ed Changes: https://git.openjdk.org/jdk21u-dev/pull/977/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=977&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335449 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/977.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/977/head:pull/977 PR: https://git.openjdk.org/jdk21u-dev/pull/977 From goetz at openjdk.org Sun Sep 15 08:02:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 15 Sep 2024 08:02:10 GMT Subject: [jdk17u-dev] RFR: 8316446: 4 sun/management/jdp tests ignore VM flags In-Reply-To: <7F88ENl0GSXpJjeBjSjpcefWGnd4wK9V3aTujpBGsRU=.de88b20c-d038-4278-9639-9beee148ec28@github.com> References: <7F88ENl0GSXpJjeBjSjpcefWGnd4wK9V3aTujpBGsRU=.de88b20c-d038-4278-9639-9beee148ec28@github.com> Message-ID: On Fri, 13 Sep 2024 18:03:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2877#issuecomment-2351446134 From goetz at openjdk.org Sun Sep 15 08:02:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 15 Sep 2024 08:02:12 GMT Subject: [jdk17u-dev] RFR: 8315988: Parallel: Make TestAggressiveHeap use createTestJvm In-Reply-To: References: Message-ID: On Fri, 13 Sep 2024 17:46:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2875#issuecomment-2351446173 From goetz at openjdk.org Sun Sep 15 08:02:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 15 Sep 2024 08:02:17 GMT Subject: [jdk17u-dev] RFR: 8317042: G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm In-Reply-To: References: Message-ID: <-dzDOJtxU6Fw2C1C45EvtRFgleboVilpha1Y1tIuj6A=.e12a5618-0bd1-4796-ab47-b1784cdd625a@github.com> On Fri, 13 Sep 2024 18:21:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8339844. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2878#issuecomment-2351446031 From goetz at openjdk.org Sun Sep 15 08:12:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 15 Sep 2024 08:12:10 GMT Subject: [jdk21u-dev] RFR: 8332724: x86 MacroAssembler may over-align code In-Reply-To: References: Message-ID: On Fri, 13 Sep 2024 18:36:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/975#issuecomment-2351453454 From goetz at openjdk.org Sun Sep 15 08:55:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 15 Sep 2024 08:55:51 GMT Subject: [jdk21u-dev] RFR: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 2305d18e8d53dbbf341b580b60f9ed21f408bff1 Changes: https://git.openjdk.org/jdk21u-dev/pull/978/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=978&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339384 Stats: 4 lines in 1 file changed: 2 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/978.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/978/head:pull/978 PR: https://git.openjdk.org/jdk21u-dev/pull/978 From goetz at openjdk.org Sun Sep 15 09:10:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 15 Sep 2024 09:10:43 GMT Subject: [jdk17u-dev] RFR: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs Message-ID: I backport this for parity with 17.0.14-oracle. Resolved Copyright, probably clean. ------------- Commit messages: - Backport 2305d18e8d53dbbf341b580b60f9ed21f408bff1 Changes: https://git.openjdk.org/jdk17u-dev/pull/2881/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2881&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339384 Stats: 4 lines in 1 file changed: 2 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2881.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2881/head:pull/2881 PR: https://git.openjdk.org/jdk17u-dev/pull/2881 From goetz at openjdk.org Sun Sep 15 13:31:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 15 Sep 2024 13:31:10 GMT Subject: [jdk21u-dev] RFR: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... In-Reply-To: References: Message-ID: On Sat, 14 Sep 2024 19:54:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. GHA failure: both had problems downloading components. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/977#issuecomment-2351594014 From goetz at openjdk.org Mon Sep 16 05:29:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Sep 2024 05:29:53 GMT Subject: [jdk21u-dev] RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.6-oracle. > > I include follow-up 8335344. > > Two clean backports. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: forgotten file ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/976/files - new: https://git.openjdk.org/jdk21u-dev/pull/976/files/5f579cbb..2e24d6a6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=976&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=976&range=00-01 Stats: 192 lines in 1 file changed: 192 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/976.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/976/head:pull/976 PR: https://git.openjdk.org/jdk21u-dev/pull/976 From goetz at openjdk.org Mon Sep 16 06:15:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Sep 2024 06:15:24 GMT Subject: [jdk21u-dev] RFR: 8339644: Improve parsing of Day/Month in tzdata rules Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 86a2f9c7dcb6585cabf03c0940511d11560e85b7 Changes: https://git.openjdk.org/jdk21u-dev/pull/979/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=979&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339644 Stats: 83 lines in 3 files changed: 23 ins; 26 del; 34 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/979.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/979/head:pull/979 PR: https://git.openjdk.org/jdk21u-dev/pull/979 From goetz at openjdk.org Mon Sep 16 06:20:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Sep 2024 06:20:47 GMT Subject: [jdk17u-dev] RFR: 8339644: Improve parsing of Day/Month in tzdata rules Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 86a2f9c7dcb6585cabf03c0940511d11560e85b7 Changes: https://git.openjdk.org/jdk17u-dev/pull/2882/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2882&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339644 Stats: 83 lines in 3 files changed: 23 ins; 26 del; 34 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2882.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2882/head:pull/2882 PR: https://git.openjdk.org/jdk17u-dev/pull/2882 From goetz at openjdk.org Mon Sep 16 06:28:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Sep 2024 06:28:13 GMT Subject: [jdk21u-dev] Integrated: 8296787: Unify debug printing format of X.509 cert serial numbers In-Reply-To: References: Message-ID: <2bQvws4mJiTq0CVX7U-2v7xYVADIDwoKdlpTvNDTiac=.f3c4848d-65c5-49dd-b064-2d66624e60ea@github.com> On Thu, 12 Sep 2024 10:05:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. > > Trivial resolve in Debug.java, probably recognized clean. This pull request has now been integrated. Changeset: c82c70d0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/c82c70d05fc33bb73775373e5033b5675ba9723f Stats: 65 lines in 18 files changed: 19 ins; 3 del; 43 mod 8296787: Unify debug printing format of X.509 cert serial numbers Backport-of: c328f9589ddc3a981a2c63801bd991f8e593e69f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/966 From goetz at openjdk.org Mon Sep 16 06:29:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Sep 2024 06:29:07 GMT Subject: [jdk21u-dev] Integrated: 8328303: 3 JDI tests timed out with UT enabled In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 11:53:19 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing. Without this, 8326898 might cause problems. This pull request has now been integrated. Changeset: 967a3cd4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/967a3cd4a5a67770a255130faeea4e6803e7f6e1 Stats: 97 lines in 3 files changed: 37 ins; 22 del; 38 mod 8328303: 3 JDI tests timed out with UT enabled Backport-of: bc73963974a824d77d54b8b0edbf8f05262b721c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/967 From goetz at openjdk.org Mon Sep 16 06:31:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Sep 2024 06:31:15 GMT Subject: [jdk21u-dev] Integrated: 8326898: NSK tests should listen on loopback addresses only In-Reply-To: References: Message-ID: <8ggyTLzkFcoEszdOOzyNSch1afEfRe7iAV6vNYmgWP0=.008ef04a-b56e-43a8-9161-e132741467b2@github.com> On Thu, 12 Sep 2024 12:07:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: fee1d969 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/fee1d969f6bf8ee9981498f352b3bf6a89842086 Stats: 22 lines in 6 files changed: 2 ins; 0 del; 20 mod 8326898: NSK tests should listen on loopback addresses only Backport-of: 2482a505e5c898cc6365aa4fb8ca3e8b758b3a97 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/968 From goetz at openjdk.org Mon Sep 16 06:33:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Sep 2024 06:33:07 GMT Subject: [jdk21u-dev] Integrated: 8321550: Update several runtime/cds tests to use vm flags or mark as flagless In-Reply-To: <3FaoYlm0XMRkkPWQvHF6t6kndaAFU-fhcNQLX4MrdPQ=.7a9b8bac-7c1e-432f-9862-0d5959deac41@github.com> References: <3FaoYlm0XMRkkPWQvHF6t6kndaAFU-fhcNQLX4MrdPQ=.7a9b8bac-7c1e-432f-9862-0d5959deac41@github.com> Message-ID: On Thu, 12 Sep 2024 12:24:45 GMT, Goetz Lindenmaier wrote: > I include two follow ups. All three are clean backports. This pull request has now been integrated. Changeset: 58cc0a24 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/58cc0a24a3ad43d74342b9dd23e8b49d1c519ace Stats: 10 lines in 4 files changed: 6 ins; 0 del; 4 mod 8321550: Update several runtime/cds tests to use vm flags or mark as flagless 8329533: TestCDSVMCrash fails on libgraal 8329353: ResolvedReferencesNotNullTest.java failed with Incorrect resolved references array, quxString should not be archived Reviewed-by: mbaesken Backport-of: d1b51e39c952df4885a424afd01161c601ef0f72 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/969 From goetz at openjdk.org Mon Sep 16 06:35:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Sep 2024 06:35:11 GMT Subject: [jdk21u-dev] Integrated: 8332340: Add JavacBench as a test case for CDS In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 12:47:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 2e3ef5fe Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/2e3ef5feea59925505ba092a9995061da65df269 Stats: 607 lines in 4 files changed: 607 ins; 0 del; 0 mod 8332340: Add JavacBench as a test case for CDS Backport-of: 7fd9d6c760c66d3e2f4034cf1a6b1b583ff829a9 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/970 From goetz at openjdk.org Mon Sep 16 06:37:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Sep 2024 06:37:12 GMT Subject: [jdk21u-dev] Integrated: 8332724: x86 MacroAssembler may over-align code In-Reply-To: References: Message-ID: On Fri, 13 Sep 2024 18:36:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 36379913 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/36379913fe1d8e224048900c34ff22e6c4a4eb10 Stats: 9 lines in 4 files changed: 0 ins; 0 del; 9 mod 8332724: x86 MacroAssembler may over-align code Backport-of: 08d51003d142e89b9d2f66187a4ea50e12b94fbb ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/975 From goetz at openjdk.org Mon Sep 16 06:39:05 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Sep 2024 06:39:05 GMT Subject: [jdk21u-dev] Integrated: 8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 13:12:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 3fc06a21 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/3fc06a213c178cf44f84c4b259442bfa73d1157c Stats: 42 lines in 6 files changed: 16 ins; 21 del; 5 mod 8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization Backport-of: b3e29db14466ccc64a2815224ecefab4cec4c775 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/971 From goetz at openjdk.org Mon Sep 16 06:56:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Sep 2024 06:56:14 GMT Subject: [jdk21u-dev] Integrated: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... In-Reply-To: References: Message-ID: <80eEChUwc6LF_Xq1LUxY3CVbH8ZzMvS9K6WjTe5ZR6g=.ecaf245d-b203-4c63-b354-47dc2b891ae3@github.com> On Sat, 14 Sep 2024 19:54:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: bbe7bbc0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/bbe7bbc0ffe4a65493c473e592eeb56738ea2e96 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... Backport-of: 284671a1e4fb5bfe15b20b7f41fc24415b1235ed ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/977 From luhenry at openjdk.org Mon Sep 16 07:25:09 2024 From: luhenry at openjdk.org (Ludovic Henry) Date: Mon, 16 Sep 2024 07:25:09 GMT Subject: [jdk23u] RFR: 8339741: RISC-V: C ABI breakage for integer on stack In-Reply-To: <5lnL_D2b0PDuH-PvEEqggQ4bFHp2gbYAuaNVi1cvcBU=.cb2591f4-6258-49a3-9f44-c748fbd14c61@github.com> References: <5lnL_D2b0PDuH-PvEEqggQ4bFHp2gbYAuaNVi1cvcBU=.cb2591f4-6258-49a3-9f44-c748fbd14c61@github.com> Message-ID: On Fri, 13 Sep 2024 07:12:47 GMT, Robbin Ehn wrote: > Hi all, > > This pull request contains a backport of commit [bfe7f920](https://github.com/openjdk/jdk/commit/bfe7f9205b56483b4364130a3a87c58c3fc82998) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry. > > Applies clean, sanity tested, risc-v only. > > Thanks! Marked as reviewed by luhenry (no project role). ------------- PR Review: https://git.openjdk.org/jdk23u/pull/96#pullrequestreview-2305905657 From andrewlu at openjdk.org Mon Sep 16 08:24:09 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 16 Sep 2024 08:24:09 GMT Subject: [jdk21u-dev] Integrated: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. In-Reply-To: References: Message-ID: <5th55yUhwV7SEDp7qrSoJWBUPTczzCO6Rd9xJSxpHjY=.2edf653f-5a6d-403a-82d4-b422d9aa917f@github.com> On Thu, 12 Sep 2024 07:20:08 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: c19857a5 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/c19857a54163effd03ad6d1672c242a81ac261fe Stats: 40 lines in 3 files changed: 38 ins; 1 del; 1 mod 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. Backport-of: f0c2f098150335fce736708354d58bae383cc4a1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/965 From andrewlu at openjdk.org Mon Sep 16 08:24:10 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 16 Sep 2024 08:24:10 GMT Subject: [jdk17u-dev] Integrated: 8320675: PrinterJob/SecurityDialogTest.java hangs In-Reply-To: References: Message-ID: <3mutoXu6-Ep69DGFQjNE7Ozvo7M2f9bsqYjrQcf7UBA=.5f524bce-029c-4cf7-b311-85440df5e67e@github.com> On Thu, 15 Aug 2024 06:44:25 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. > modify lines are different, but code is clean. This pull request has now been integrated. Changeset: 22f82b97 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/22f82b970c6c0bd83edb3202d2f648d43ea49d92 Stats: 237 lines in 1 file changed: 53 ins; 153 del; 31 mod 8320675: PrinterJob/SecurityDialogTest.java hangs Reviewed-by: phh Backport-of: 9f5ad43358a4e209b4cd1c91bcc86b997f371548 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2807 From andrewlu at openjdk.org Mon Sep 16 08:24:13 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 16 Sep 2024 08:24:13 GMT Subject: [jdk17u-dev] Integrated: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 09:33:35 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. > test/jdk/ProblemList.txt > not edit as it's not exist. This pull request has now been integrated. Changeset: a5d9f49a Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/a5d9f49ad952e2db4b4d2428d2253813d01ba574 Stats: 39 lines in 2 files changed: 38 ins; 0 del; 1 mod 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. Reviewed-by: goetz Backport-of: f0c2f098150335fce736708354d58bae383cc4a1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2866 From andrewlu at openjdk.org Mon Sep 16 08:25:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 16 Sep 2024 08:25:06 GMT Subject: [jdk21u-dev] Integrated: 8337320: Update ProblemList.txt with tests known to fail on XWayland In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 05:32:34 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.6-oracle. > Not clean, this file java/awt/FullScreen/SetFullScreenTest.java does not exist in jdk21 This pull request has now been integrated. Changeset: 3140491f Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/3140491fe2a5f1a3104b46c6103b02fbf89d34ae Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod 8337320: Update ProblemList.txt with tests known to fail on XWayland Reviewed-by: goetz Backport-of: ddbd7a78f191462695ecbeeef7fd6312e322b15a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/961 From jnordstrom at openjdk.org Mon Sep 16 14:28:22 2024 From: jnordstrom at openjdk.org (Joakim =?UTF-8?B?Tm9yZHN0csO2bQ==?=) Date: Mon, 16 Sep 2024 14:28:22 GMT Subject: [jdk23u] RFR: 8338389: [JFR] Long strings should be added to the string pool Message-ID: Backport of fix to pool all longer strings in JFR events. ------------- Commit messages: - Backport d5c6158cedfd96a9f97d83355b10730b81274648 Changes: https://git.openjdk.org/jdk23u/pull/97/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=97&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338389 Stats: 119 lines in 2 files changed: 116 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk23u/pull/97.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/97/head:pull/97 PR: https://git.openjdk.org/jdk23u/pull/97 From szaldana at openjdk.org Mon Sep 16 15:02:16 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 16 Sep 2024 15:02:16 GMT Subject: [jdk21u-dev] Integrated: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect In-Reply-To: <43hz561PTsIN4ZqMvROzIm1AwZjYCdcLmBfaBTlrRKQ=.2b3ec82a-8ab3-4df9-973f-c328f25c8988@github.com> References: <43hz561PTsIN4ZqMvROzIm1AwZjYCdcLmBfaBTlrRKQ=.2b3ec82a-8ab3-4df9-973f-c328f25c8988@github.com> Message-ID: On Mon, 19 Aug 2024 17:14:54 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [330e520c](https://github.com/openjdk/jdk/commit/330e520c1d42d3a9f3e187873dcd8ed7fd561aaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fernando Guallini on 18 Jul 2024 and was reviewed by Bradford Wetmore, Matthew Donovan and Rajan Halade. > > Thanks! This pull request has now been integrated. Changeset: e11e0388 Author: Sonia Zaldana Calles URL: https://git.openjdk.org/jdk21u-dev/commit/e11e0388c097406177e7e2e8785146ff5424366f Stats: 96 lines in 1 file changed: 60 ins; 5 del; 31 mod 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect Backport-of: 330e520c1d42d3a9f3e187873dcd8ed7fd561aaf ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/934 From duke at openjdk.org Mon Sep 16 15:21:16 2024 From: duke at openjdk.org (duke) Date: Mon, 16 Sep 2024 15:21:16 GMT Subject: [jdk17u-dev] RFR: 8268364: jmethod clearing should be done during unloading In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 10:31:10 GMT, Kerem Kat wrote: > Clean backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364). > > It fixes crashes when accessing jmethodIDs of a class being unloaded. > > Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). > > This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 17. > > **Additional testing**: release and fastdebug with `JTREG_KEYWORDS="!headful & !external-dep & !printer"`, no new test failures with the patch. > > To run the repro: > > > javac Main.java > gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so > > java -agentpath:"$(pwd)/repro.so" -Xmx100m Main @krk Your change (at version 051316fd7e1ab1d425acbe15eadee150299f3cc4) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2839#issuecomment-2353220405 From shade at openjdk.org Mon Sep 16 15:52:17 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 16 Sep 2024 15:52:17 GMT Subject: [jdk17u-dev] RFR: 8268364: jmethod clearing should be done during unloading In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 10:31:10 GMT, Kerem Kat wrote: > Clean backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364). > > It fixes crashes when accessing jmethodIDs of a class being unloaded. > > Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). > > This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 17. > > **Additional testing**: release and fastdebug with `JTREG_KEYWORDS="!headful & !external-dep & !printer"`, no new test failures with the patch. > > To run the repro: > > > javac Main.java > gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so > > java -agentpath:"$(pwd)/repro.so" -Xmx100m Main There are a few linked issues to this bug, are they recording regressions, or? Do they need to be addressed/backported to 17u too? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2839#issuecomment-2353295789 From duke at openjdk.org Mon Sep 16 15:58:13 2024 From: duke at openjdk.org (Kerem Kat) Date: Mon, 16 Sep 2024 15:58:13 GMT Subject: [jdk17u-dev] RFR: 8268364: jmethod clearing should be done during unloading In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 10:31:10 GMT, Kerem Kat wrote: > Clean backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364). > > It fixes crashes when accessing jmethodIDs of a class being unloaded. > > Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). > > This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 17. > > **Additional testing**: release and fastdebug with `JTREG_KEYWORDS="!headful & !external-dep & !printer"`, no new test failures with the patch. > > To run the repro: > > > javac Main.java > gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so > > java -agentpath:"$(pwd)/repro.so" -Xmx100m Main * JDK-8339725 is tangential but independent - either PR does not need the other. * JDK-8267879 already in JDK 17. * JDK-8268088 is comment only. and others do not have patches. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2839#issuecomment-2353309122 From shade at openjdk.org Mon Sep 16 16:07:13 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 16 Sep 2024 16:07:13 GMT Subject: [jdk17u-dev] RFR: 8268364: jmethod clearing should be done during unloading In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 10:31:10 GMT, Kerem Kat wrote: > Clean backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364). > > It fixes crashes when accessing jmethodIDs of a class being unloaded. > > Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). > > This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 17. > > **Additional testing**: release and fastdebug with `JTREG_KEYWORDS="!headful & !external-dep & !printer"`, no new test failures with the patch. > > To run the repro: > > > javac Main.java > gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so > > java -agentpath:"$(pwd)/repro.so" -Xmx100m Main All right, thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2839#issuecomment-2353330110 From duke at openjdk.org Mon Sep 16 16:07:14 2024 From: duke at openjdk.org (Kerem Kat) Date: Mon, 16 Sep 2024 16:07:14 GMT Subject: [jdk17u-dev] Integrated: 8268364: jmethod clearing should be done during unloading In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 10:31:10 GMT, Kerem Kat wrote: > Clean backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364). > > It fixes crashes when accessing jmethodIDs of a class being unloaded. > > Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). > > This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 17. > > **Additional testing**: release and fastdebug with `JTREG_KEYWORDS="!headful & !external-dep & !printer"`, no new test failures with the patch. > > To run the repro: > > > javac Main.java > gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so > > java -agentpath:"$(pwd)/repro.so" -Xmx100m Main This pull request has now been integrated. Changeset: 35c1ebc7 Author: Kerem Kat Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/35c1ebc76dba1bd6343dbed72ad4ead04a603aed Stats: 36 lines in 2 files changed: 20 ins; 13 del; 3 mod 8268364: jmethod clearing should be done during unloading Backport-of: 3d84398d128bb2eed6280ebbc3f57afb3b89908f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2839 From abakhtin at openjdk.org Mon Sep 16 16:49:20 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 16 Sep 2024 16:49:20 GMT Subject: [jdk21u-dev] Integrated: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases In-Reply-To: References: Message-ID: On Fri, 30 Aug 2024 21:32:42 GMT, Alexey Bakhtin wrote: > ? on older docker releases > > Please review the fix for regression on the old Docker versions (before v18.04). > > [JDK-8316304](https://bugs.openjdk.org/browse/JDK-8316304) was backported to JDK21, requiring statx syscall support. > In the old Docker versions, the default seccomp profile does not allow statx syscall and fails with EPERM error code. > Suggest fixing this issue by fallback to alternative implementation at runtime if syscall is not allowed. > > The same issue with copy_file_range syscall. > > The fix was initially submitted against upstream jdk ( https://github.com/openjdk/jdk/pull/20484 ) but after discussion submitted to JDK21 This pull request has now been integrated. Changeset: 7a97e314 Author: Alexey Bakhtin URL: https://git.openjdk.org/jdk21u-dev/commit/7a97e314b52a4045ca8238eae5ba730618939bf7 Stats: 24 lines in 1 file changed: 14 ins; 6 del; 4 mod 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases Reviewed-by: sgehwolf, mbalao ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/951 From abakhtin at openjdk.org Mon Sep 16 17:11:18 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 16 Sep 2024 17:11:18 GMT Subject: [jdk17u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases Message-ID: Almost clean backport from JDK21 The only difference is an additional EPERM check in the stat1 method. This method was removed in JDK21 as part of JDK-8283335 ------------- Commit messages: - Backport 7a97e314b52a4045ca8238eae5ba730618939bf7 Changes: https://git.openjdk.org/jdk17u-dev/pull/2883/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2883&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337966 Stats: 31 lines in 1 file changed: 18 ins; 8 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2883.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2883/head:pull/2883 PR: https://git.openjdk.org/jdk17u-dev/pull/2883 From wkemper at openjdk.org Mon Sep 16 20:00:15 2024 From: wkemper at openjdk.org (William Kemper) Date: Mon, 16 Sep 2024 20:00:15 GMT Subject: [jdk17u-dev] RFR: 8331411: Shenandoah: Reconsider spinning duration in ShenandoahLock [v2] In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 14:00:54 GMT, Xiaolong Peng wrote: >> Hi, >> This PR is a Backport of [[JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411)]: Reconsider spinning duration in ShenandoahLock. The original commit was authored by Xiaolong Peng on 26 June 2024 and was reviewed by[Aleksey Shipil?v](https://github.com/shipilev), [Kelvin Nilsen](https://github.com/kdnilsen), and [William Kemper](https://github.com/earthling-amzn), it had already been backported to jdk21. >> >> It was not a clean merge, there were some conflicts and API change which have been resolved and tested. Meanwhile, given there were conflicts to resolve, I also updated the invalid comments which was fixed in JDK-8335904. >> >> This is the third PR of the series of improvements we are proposing to backport to jdk17 to solve the contention issue in ShenandoahLock, we have observed the lock contention is causing real problems in some of our products. >> >> Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: >> >> | Bug | Title | PR | >> | ----------- | ---------------------------------------------- |------------| >> | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797) | >> | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) | >> | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | >> | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | >> >> ### Additional test >> - [x] MacOS AArch64 server fastdebug, hotspot_gc_shenandoah > > Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: > > Correct comments Marked as reviewed by wkemper (Author). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2868#pullrequestreview-2307650053 From xpeng at openjdk.org Mon Sep 16 21:04:14 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Mon, 16 Sep 2024 21:04:14 GMT Subject: [jdk17u-dev] RFR: 8331411: Shenandoah: Reconsider spinning duration in ShenandoahLock [v2] In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 14:00:54 GMT, Xiaolong Peng wrote: >> Hi, >> This PR is a Backport of [[JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411)]: Reconsider spinning duration in ShenandoahLock. The original commit was authored by Xiaolong Peng on 26 June 2024 and was reviewed by[Aleksey Shipil?v](https://github.com/shipilev), [Kelvin Nilsen](https://github.com/kdnilsen), and [William Kemper](https://github.com/earthling-amzn), it had already been backported to jdk21. >> >> It was not a clean merge, there were some conflicts and API change which have been resolved and tested. Meanwhile, given there were conflicts to resolve, I also updated the invalid comments which was fixed in JDK-8335904. >> >> This is the third PR of the series of improvements we are proposing to backport to jdk17 to solve the contention issue in ShenandoahLock, we have observed the lock contention is causing real problems in some of our products. >> >> Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: >> >> | Bug | Title | PR | >> | ----------- | ---------------------------------------------- |------------| >> | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797) | >> | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) | >> | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | >> | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | >> >> ### Additional test >> - [x] MacOS AArch64 server fastdebug, hotspot_gc_shenandoah > > Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: > > Correct comments Thank you all for the review, I'll apply for maintainer approval. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2868#issuecomment-2354027483 From rehn at openjdk.org Tue Sep 17 05:12:07 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Tue, 17 Sep 2024 05:12:07 GMT Subject: [jdk23u] Integrated: 8339741: RISC-V: C ABI breakage for integer on stack In-Reply-To: <5lnL_D2b0PDuH-PvEEqggQ4bFHp2gbYAuaNVi1cvcBU=.cb2591f4-6258-49a3-9f44-c748fbd14c61@github.com> References: <5lnL_D2b0PDuH-PvEEqggQ4bFHp2gbYAuaNVi1cvcBU=.cb2591f4-6258-49a3-9f44-c748fbd14c61@github.com> Message-ID: <1nr3Z80ZwizKuFzICwUlMTIGsDEGfDWfGaUoNcEEWVA=.62afcac2-7afb-4dbc-89f1-20090d076aeb@github.com> On Fri, 13 Sep 2024 07:12:47 GMT, Robbin Ehn wrote: > Hi all, > > This pull request contains a backport of commit [bfe7f920](https://github.com/openjdk/jdk/commit/bfe7f9205b56483b4364130a3a87c58c3fc82998) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry. > > Applies clean, sanity tested, risc-v only. > > Thanks! This pull request has now been integrated. Changeset: bf45fbdc Author: Robbin Ehn URL: https://git.openjdk.org/jdk23u/commit/bf45fbdc1dbbd4c93dff79b2d6984f5a3e3e5df2 Stats: 156 lines in 4 files changed: 150 ins; 0 del; 6 mod 8339741: RISC-V: C ABI breakage for integer on stack Reviewed-by: fyang, luhenry Backport-of: bfe7f9205b56483b4364130a3a87c58c3fc82998 ------------- PR: https://git.openjdk.org/jdk23u/pull/96 From duke at openjdk.org Tue Sep 17 05:30:38 2024 From: duke at openjdk.org (Nibedita Jena) Date: Tue, 17 Sep 2024 05:30:38 GMT Subject: [jdk23u] RFR: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException Message-ID: Clean backport of JDK-8336240. ------------- Commit messages: - Backport 034297a6bd9bfcea7fa48792f54c84a6e976b319 Changes: https://git.openjdk.org/jdk23u/pull/98/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=98&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336240 Stats: 16 lines in 3 files changed: 6 ins; 5 del; 5 mod Patch: https://git.openjdk.org/jdk23u/pull/98.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/98/head:pull/98 PR: https://git.openjdk.org/jdk23u/pull/98 From syan at openjdk.org Tue Sep 17 07:53:16 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 17 Sep 2024 07:53:16 GMT Subject: [jdk21u-dev] RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test [v2] In-Reply-To: References: Message-ID: On Mon, 16 Sep 2024 05:29:53 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 21.0.6-oracle. >> >> I include follow-up 8335344. >> >> Two clean backports. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > forgotten file GHA report `gc/shenandoah/mxbeans/TestPauseNotifications.java#passive` fails on windows-x64, which seems similar to [JDK-8335355](https://bugs.openjdk.org/browse/JDK-8335355) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/976#issuecomment-2354794699 From duke at openjdk.org Tue Sep 17 08:12:11 2024 From: duke at openjdk.org (duke) Date: Tue, 17 Sep 2024 08:12:11 GMT Subject: [jdk21u-dev] RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v2] In-Reply-To: <3uYV4BZlYy9tlgvoA3gUBv9ldA7qPfYJjNja-ESTz5g=.f157d60a-209d-46a0-b202-096450ff441a@github.com> References: <3uYV4BZlYy9tlgvoA3gUBv9ldA7qPfYJjNja-ESTz5g=.f157d60a-209d-46a0-b202-096450ff441a@github.com> Message-ID: On Thu, 22 Aug 2024 15:48:38 GMT, Dmitry Chuyko wrote: >> This is a backport of KAT fix for SHAKE256. The test provided in the bug description currently fails on JDK 21. SHA3 part is clean, SHAKE128 part is removed as it is a separate new API. > > Dmitry Chuyko has updated the pull request incrementally with one additional commit since the last revision: > > Deleted SHAKE128 implementation @dchuyko Your change (at version 4b5656f7680a542a2d02cce7b8dd918d6a1cdf19) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/902#issuecomment-2354835433 From goetz at openjdk.org Tue Sep 17 09:27:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 09:27:16 GMT Subject: [jdk21u] Integrated: 8337622: IllegalArgumentException in java.lang.reflect.Field.get In-Reply-To: References: Message-ID: <6RQvVIlzcw07ug6BEwKj5OKVpe8izXuM6ALdBgW9MCU=.c06d4c37-3292-43c8-a2a3-284c5349a184@github.com> On Sat, 14 Sep 2024 19:51:14 GMT, Goetz Lindenmaier wrote: > I backport this to fix the regression caused by 8333542 This pull request has now been integrated. Changeset: b99bff9e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u/commit/b99bff9e2ef77f5294c27cdedad5c997c57ff60d Stats: 58 lines in 3 files changed: 51 ins; 7 del; 0 mod 8337622: IllegalArgumentException in java.lang.reflect.Field.get Backport-of: 41e31d6b0ae00d70b6fb20c89318fde2bc605edb ------------- PR: https://git.openjdk.org/jdk21u/pull/454 From duke at openjdk.org Tue Sep 17 09:42:18 2024 From: duke at openjdk.org (HempushpaSahu) Date: Tue, 17 Sep 2024 09:42:18 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: <0wXAvUIZEMt1GvwINsr0RwDHmFtEsoHJIjuQJ7EOQjk=.ee466b1d-67a3-42b1-9b0f-6b4ff281d232@github.com> References: <0wXAvUIZEMt1GvwINsr0RwDHmFtEsoHJIjuQJ7EOQjk=.ee466b1d-67a3-42b1-9b0f-6b4ff281d232@github.com> Message-ID: On Wed, 4 Sep 2024 13:59:45 GMT, Alexey Bakhtin wrote: >> Hi @alexeybakhtin >> Is there any plan to merge this PR anytime soon? >> >> Thanks. > > Hi @HempushpaSahu. Yes, I will request integration into 17u as soon as it is reviewed here. Hi @alexeybakhtin, I noticed from [JDK-8337407](https://bugs.openjdk.org/browse/JDK-8337407) issue, [jnimeh](https://bugs.openjdk.org/secure/ViewProfile.jspa?name=jnimeh) is the reviewer. Could you please confirm whether the review is currently in progress? Also, is it possible to assign an additional reviewer if one is available? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#issuecomment-2355064689 From goetz at openjdk.org Tue Sep 17 09:44:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 09:44:15 GMT Subject: [jdk17u-dev] Integrated: 8294193: Files.createDirectories throws FileAlreadyExistsException for a symbolic link whose target is an existing directory In-Reply-To: <1tPfpg9qMX3AgosKOpOeSwUOvYsoNNgbQ8mUjN-OD24=.d6cce647-6972-4c19-9726-3e37eabfc168@github.com> References: <1tPfpg9qMX3AgosKOpOeSwUOvYsoNNgbQ8mUjN-OD24=.d6cce647-6972-4c19-9726-3e37eabfc168@github.com> Message-ID: On Thu, 12 Sep 2024 15:44:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: e336d04e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e336d04e8ce0fe303b2bef1f08b2e4647c113d42 Stats: 161 lines in 3 files changed: 124 ins; 34 del; 3 mod 8294193: Files.createDirectories throws FileAlreadyExistsException for a symbolic link whose target is an existing directory Backport-of: 169a5d48afbc6627f36a768c17c2a5e56219d9c7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2870 From goetz at openjdk.org Tue Sep 17 09:45:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 09:45:21 GMT Subject: [jdk17u-dev] Integrated: 8282578: AIOOBE in javax.sound.sampled.Clip In-Reply-To: <9EjtJ9g6NsXG3DC4dsyzkEOvxabtj1JfswLnVgBQNjE=.cc0ad45d-d9ca-4a57-88b3-a3c5e40f2e88@github.com> References: <9EjtJ9g6NsXG3DC4dsyzkEOvxabtj1JfswLnVgBQNjE=.cc0ad45d-d9ca-4a57-88b3-a3c5e40f2e88@github.com> Message-ID: On Thu, 12 Sep 2024 15:43:06 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Resolved copyright, probably clean anyways. This pull request has now been integrated. Changeset: 604e92da Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/604e92dac4ba1a68bc1e351be8b4f480a62172ef Stats: 544 lines in 4 files changed: 295 ins; 105 del; 144 mod 8282578: AIOOBE in javax.sound.sampled.Clip Backport-of: af8fb7eef7188ef762399cfb3faf5c8afd49efa7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2869 From goetz at openjdk.org Tue Sep 17 09:47:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 09:47:12 GMT Subject: [jdk17u-dev] Integrated: 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags In-Reply-To: <4UU6DcnigDAFXi2Eo_brAGnbagVCROJP7DxWNgjKuDU=.95f99395-036c-48cc-9622-62695f1ebcc6@github.com> References: <4UU6DcnigDAFXi2Eo_brAGnbagVCROJP7DxWNgjKuDU=.95f99395-036c-48cc-9622-62695f1ebcc6@github.com> Message-ID: On Fri, 13 Sep 2024 15:11:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 65a12153 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/65a12153c777d93f9d7fad60116b3eacba384dd2 Stats: 6 lines in 1 file changed: 3 ins; 2 del; 1 mod 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags Backport-of: 93e82c01460a70f214653a558d53c1c6180ae0d3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2872 From goetz at openjdk.org Tue Sep 17 09:48:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 09:48:07 GMT Subject: [jdk17u-dev] Integrated: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags In-Reply-To: <-P1ArSMWzch8w3mmL_dyUBbclRwZkKypf8CjzHGqAeo=.24ae49b2-2916-495c-9811-dea84eff82d1@github.com> References: <-P1ArSMWzch8w3mmL_dyUBbclRwZkKypf8CjzHGqAeo=.24ae49b2-2916-495c-9811-dea84eff82d1@github.com> Message-ID: On Fri, 13 Sep 2024 15:13:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: e4590bf5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e4590bf5177ae80313a8b49f95d3dd3275c90207 Stats: 63 lines in 3 files changed: 3 ins; 50 del; 10 mod 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags Backport-of: 5cbff2460812fee707f9d96ab00a628d1ce3fbef ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2873 From goetz at openjdk.org Tue Sep 17 09:56:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 09:56:07 GMT Subject: [jdk17u-dev] Integrated: 8314831: NMT tests ignore vm flags In-Reply-To: References: Message-ID: On Fri, 13 Sep 2024 15:23:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Clean except for one file omitted: > MallocLimitTest.java is not in 17, omitted. It was introduced by > "8291878: NMT: Malloc limits" in jdk20, not a candidate for backport to 17 This pull request has now been integrated. Changeset: 5b10cd1d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5b10cd1d544577c10a12e4514327df52f14fe900 Stats: 22 lines in 10 files changed: 5 ins; 0 del; 17 mod 8314831: NMT tests ignore vm flags Reviewed-by: phh Backport-of: 9bf3dee2424bd8ccbc7ef0175c6e7165ff5cf1c6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2874 From goetz at openjdk.org Tue Sep 17 10:00:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 10:00:17 GMT Subject: [jdk17u-dev] Integrated: 8315988: Parallel: Make TestAggressiveHeap use createTestJvm In-Reply-To: References: Message-ID: On Fri, 13 Sep 2024 17:46:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 17bf3930 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/17bf39306c340196359c31f5e45ca25144da70b5 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8315988: Parallel: Make TestAggressiveHeap use createTestJvm Backport-of: fbc766ee21ff7e6d414bd7d2c8bd7c9e1889a8af ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2875 From goetz at openjdk.org Tue Sep 17 10:05:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 10:05:08 GMT Subject: [jdk17u-dev] Integrated: 8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags In-Reply-To: <-QPTg9X00GyXAr8ZToQi0UoibI_6Mi_YtKLnHeuMMRI=.b90ac533-2f6b-450c-aa44-2cc35f591770@github.com> References: <-QPTg9X00GyXAr8ZToQi0UoibI_6Mi_YtKLnHeuMMRI=.b90ac533-2f6b-450c-aa44-2cc35f591770@github.com> Message-ID: On Fri, 13 Sep 2024 17:53:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Resolved ProblemList, probably clean This pull request has now been integrated. Changeset: 5549655e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5549655eab4dea33e8e52dbc884e62a3bd14db9c Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod 8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags Backport-of: e0f8d16833c8212a79ea3dda3f4fe31134c41025 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2876 From goetz at openjdk.org Tue Sep 17 10:10:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 10:10:07 GMT Subject: [jdk17u-dev] Integrated: 8316446: 4 sun/management/jdp tests ignore VM flags In-Reply-To: <7F88ENl0GSXpJjeBjSjpcefWGnd4wK9V3aTujpBGsRU=.de88b20c-d038-4278-9639-9beee148ec28@github.com> References: <7F88ENl0GSXpJjeBjSjpcefWGnd4wK9V3aTujpBGsRU=.de88b20c-d038-4278-9639-9beee148ec28@github.com> Message-ID: <2teakOBRtm0Hqc8U2n65v6D6oL9DHIQIrOGWJdeIaPI=.44a1266e-4efa-415a-adaf-54627be54241@github.com> On Fri, 13 Sep 2024 18:03:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: fda6239f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/fda6239f533c9d0be3f48e7d97f99f7bcea0c00a Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8316446: 4 sun/management/jdp tests ignore VM flags Backport-of: 5b311f20dfaed0f34d38e8c5c6b90d97ffc75172 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2877 From goetz at openjdk.org Tue Sep 17 10:27:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 10:27:08 GMT Subject: [jdk17u-dev] Integrated: 8317042: G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm In-Reply-To: References: Message-ID: On Fri, 13 Sep 2024 18:21:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: d61861b8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/d61861b82f3458cbe64ec7054a3f7f5748324c20 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8317042: G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm Backport-of: 7e39e664cf6d4658b0aa03f9b5162cf7de40de28 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2878 From goetz at openjdk.org Tue Sep 17 10:47:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 10:47:13 GMT Subject: [jdk17u-dev] Integrated: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed In-Reply-To: <2m5RBcPqkCRYYvicwrEgdjAXcrZ7ikzGxR0DCjlzXkI=.a4258ebf-f137-45e3-9d34-906b8d37ecd2@github.com> References: <2m5RBcPqkCRYYvicwrEgdjAXcrZ7ikzGxR0DCjlzXkI=.a4258ebf-f137-45e3-9d34-906b8d37ecd2@github.com> Message-ID: <1Iqk33lzFc-czu3Rhto2TJLmL47nlbN1titfvBs7ZUA=.334db9e0-cdeb-4e0f-aaef-d3040801944b@github.com> On Fri, 13 Sep 2024 18:31:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 5a6a4251 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5a6a4251e0eb771ff69a43ef26c421c66b721646 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed Backport-of: 672f37324f9f15ae3e03b9b3b86c7106e6a09eed ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2879 From goetz at openjdk.org Tue Sep 17 10:53:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 10:53:06 GMT Subject: [jdk17u-dev] Integrated: 8332724: x86 MacroAssembler may over-align code In-Reply-To: References: Message-ID: On Fri, 13 Sep 2024 18:36:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: f7dff46e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f7dff46ec70d0615da7d98a50f213ac9050e0862 Stats: 9 lines in 4 files changed: 0 ins; 0 del; 9 mod 8332724: x86 MacroAssembler may over-align code Backport-of: 08d51003d142e89b9d2f66187a4ea50e12b94fbb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2880 From duke at openjdk.org Tue Sep 17 12:02:21 2024 From: duke at openjdk.org (Yagmur Eren) Date: Tue, 17 Sep 2024 12:02:21 GMT Subject: [jdk23u] RFR: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs Message-ID: Backport of [JDK-8339384](https://bugs.openjdk.org/browse/JDK-8339384) ------------- Commit messages: - Backport 2305d18e8d53dbbf341b580b60f9ed21f408bff1 Changes: https://git.openjdk.org/jdk23u/pull/99/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=99&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339384 Stats: 4 lines in 1 file changed: 2 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/99.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/99/head:pull/99 PR: https://git.openjdk.org/jdk23u/pull/99 From goetz at openjdk.org Tue Sep 17 13:53:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 13:53:12 GMT Subject: [jdk21u-dev] RFR: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate In-Reply-To: <_-Tp2qhNmlZNquRSjo8f1x226hwBY3Ra7AnEmtJ9Gcw=.6fa12ab2-b85d-456f-be8b-df1f3e1f6f6b@github.com> References: <_-Tp2qhNmlZNquRSjo8f1x226hwBY3Ra7AnEmtJ9Gcw=.6fa12ab2-b85d-456f-be8b-df1f3e1f6f6b@github.com> Message-ID: On Thu, 12 Sep 2024 22:29:41 GMT, William Kemper wrote: > Clean backport. Change is confined to Shenandoah. Please backport to 23 first. Removing tag in the meantime ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/973#issuecomment-2355878772 From abakhtin at openjdk.org Tue Sep 17 14:04:14 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 17 Sep 2024 14:04:14 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: References: Message-ID: On Sun, 28 Jul 2024 22:02:37 GMT, Alexey Bakhtin wrote: > Hello, I'd like to backport JDK-8179502 to JDK17u to improve the timeout adjustment for OCSP GET requests (which was missed in JDK-8179503). > > The backport is almost clean except for the following: > - OCSP.java was merged manually because of JDK-8328638 and JDK-8329213 is already backported into 17u-dev > - copyright year in GetPropertyAction.java and URICertStore.java files are updated manually > - CRLReadTimeout.java test is updated manually because of the different notation of internal X509CRLImpl and CRLExtensions classes. > > All new and related jtreg tests are passed Hello everyone, Could you please review the backport? I want to backport it for parity with Oracle. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#issuecomment-2355917851 From mbaesken at openjdk.org Tue Sep 17 14:43:37 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 17 Sep 2024 14:43:37 GMT Subject: [jdk23u] RFR: 8333098: ubsan: bytecodeInfo.cpp:318:59: runtime error: division by zero Message-ID: 8333098: ubsan: bytecodeInfo.cpp:318:59: runtime error: division by zero ------------- Commit messages: - Backport f080b4bb8a75284db1b6037f8c00ef3b1ef1add1 Changes: https://git.openjdk.org/jdk23u/pull/100/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=100&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333098 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk23u/pull/100.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/100/head:pull/100 PR: https://git.openjdk.org/jdk23u/pull/100 From mbaesken at openjdk.org Tue Sep 17 14:46:17 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 17 Sep 2024 14:46:17 GMT Subject: [jdk21u-dev] RFR: 8333098: ubsan: bytecodeInfo.cpp:318:59: runtime error: division by zero Message-ID: <7OP7kyFjM17wbRsaHmzTPWz5Q_TyVP2pP-0QKdQKmoM=.9a40f0d5-4d4b-49a6-b24b-22b8fe343961@github.com> 8333098: ubsan: bytecodeInfo.cpp:318:59: runtime error: division by zero ------------- Commit messages: - Backport f080b4bb8a75284db1b6037f8c00ef3b1ef1add1 Changes: https://git.openjdk.org/jdk21u-dev/pull/980/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=980&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333098 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/980.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/980/head:pull/980 PR: https://git.openjdk.org/jdk21u-dev/pull/980 From xpeng at openjdk.org Tue Sep 17 15:48:11 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Tue, 17 Sep 2024 15:48:11 GMT Subject: [jdk17u-dev] RFR: 8331411: Shenandoah: Reconsider spinning duration in ShenandoahLock [v2] In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 14:00:54 GMT, Xiaolong Peng wrote: >> Hi, >> This PR is a Backport of [[JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411)]: Reconsider spinning duration in ShenandoahLock. The original commit was authored by Xiaolong Peng on 26 June 2024 and was reviewed by[Aleksey Shipil?v](https://github.com/shipilev), [Kelvin Nilsen](https://github.com/kdnilsen), and [William Kemper](https://github.com/earthling-amzn), it had already been backported to jdk21. >> >> It was not a clean merge, there were some conflicts and API change which have been resolved and tested. Meanwhile, given there were conflicts to resolve, I also updated the invalid comments which was fixed in JDK-8335904. >> >> This is the third PR of the series of improvements we are proposing to backport to jdk17 to solve the contention issue in ShenandoahLock, we have observed the lock contention is causing real problems in some of our products. >> >> Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: >> >> | Bug | Title | PR | >> | ----------- | ---------------------------------------------- |------------| >> | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797) | >> | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) | >> | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | >> | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | >> >> ### Additional test >> - [x] MacOS AArch64 server fastdebug, hotspot_gc_shenandoah > > Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: > > Correct comments Thanks all for the reviews and approvals! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2868#issuecomment-2356301200 From duke at openjdk.org Tue Sep 17 15:48:12 2024 From: duke at openjdk.org (duke) Date: Tue, 17 Sep 2024 15:48:12 GMT Subject: [jdk17u-dev] RFR: 8331411: Shenandoah: Reconsider spinning duration in ShenandoahLock [v2] In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 14:00:54 GMT, Xiaolong Peng wrote: >> Hi, >> This PR is a Backport of [[JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411)]: Reconsider spinning duration in ShenandoahLock. The original commit was authored by Xiaolong Peng on 26 June 2024 and was reviewed by[Aleksey Shipil?v](https://github.com/shipilev), [Kelvin Nilsen](https://github.com/kdnilsen), and [William Kemper](https://github.com/earthling-amzn), it had already been backported to jdk21. >> >> It was not a clean merge, there were some conflicts and API change which have been resolved and tested. Meanwhile, given there were conflicts to resolve, I also updated the invalid comments which was fixed in JDK-8335904. >> >> This is the third PR of the series of improvements we are proposing to backport to jdk17 to solve the contention issue in ShenandoahLock, we have observed the lock contention is causing real problems in some of our products. >> >> Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: >> >> | Bug | Title | PR | >> | ----------- | ---------------------------------------------- |------------| >> | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797) | >> | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) | >> | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | >> | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | >> >> ### Additional test >> - [x] MacOS AArch64 server fastdebug, hotspot_gc_shenandoah > > Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: > > Correct comments @pengxiaolong Your change (at version e7cbe8425695595081945fea894ca0b445f56dfd) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2868#issuecomment-2356303660 From xpeng at openjdk.org Tue Sep 17 15:54:07 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Tue, 17 Sep 2024 15:54:07 GMT Subject: [jdk17u-dev] Integrated: 8331411: Shenandoah: Reconsider spinning duration in ShenandoahLock In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 13:34:30 GMT, Xiaolong Peng wrote: > Hi, > This PR is a Backport of [[JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411)]: Reconsider spinning duration in ShenandoahLock. The original commit was authored by Xiaolong Peng on 26 June 2024 and was reviewed by[Aleksey Shipil?v](https://github.com/shipilev), [Kelvin Nilsen](https://github.com/kdnilsen), and [William Kemper](https://github.com/earthling-amzn), it had already been backported to jdk21. > > It was not a clean merge, there were some conflicts and API change which have been resolved and tested. Meanwhile, given there were conflicts to resolve, I also updated the invalid comments which was fixed in JDK-8335904. > > This is the third PR of the series of improvements we are proposing to backport to jdk17 to solve the contention issue in ShenandoahLock, we have observed the lock contention is causing real problems in some of our products. > > Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17: > > | Bug | Title | PR | > | ----------- | ---------------------------------------------- |------------| > | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797) | > | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) | > | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | > | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | [2868](https://github.com/openjdk/jdk17u-dev/pull/2868) | > > ### Additional test > - [x] MacOS AArch64 server fastdebug, hotspot_gc_shenandoah This pull request has now been integrated. Changeset: 4f08bcd2 Author: Xiaolong Peng Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/4f08bcd2431072d3b27a9589fe07f045c71d2aca Stats: 47 lines in 2 files changed: 22 ins; 11 del; 14 mod 8331411: Shenandoah: Reconsider spinning duration in ShenandoahLock 8335904: Fix invalid comment in ShenandoahLock Reviewed-by: phh, wkemper Backport-of: 817edcb697cbb8c608c9292cdc4b99db4f5844dc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2868 From goetz at openjdk.org Tue Sep 17 16:56:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 16:56:11 GMT Subject: [jdk21u-dev] RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test [v2] In-Reply-To: References: Message-ID: On Mon, 16 Sep 2024 05:29:53 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 21.0.6-oracle. >> >> I backport this from 23, which is clean. >> It includes follow-up 8335344. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > forgotten file Thanks for checking the tests! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/976#issuecomment-2356441895 From goetz at openjdk.org Tue Sep 17 17:03:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 17:03:24 GMT Subject: [jdk21u-dev] RFR: 8321474: TestAutoCreateSharedArchiveUpgrade.java should be updated with JDK 21 Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 1b621f5527a0d7ae345d79f293357446ab7876d9 Changes: https://git.openjdk.org/jdk21u-dev/pull/981/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=981&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321474 Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/981.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/981/head:pull/981 PR: https://git.openjdk.org/jdk21u-dev/pull/981 From goetz at openjdk.org Tue Sep 17 17:14:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 17:14:40 GMT Subject: [jdk21u-dev] RFR: 8330621: Make 5 compiler tests use ProcessTools.executeProcess Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 5394f57f002c066021d811382a336253ae9f2014 Changes: https://git.openjdk.org/jdk21u-dev/pull/982/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=982&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330621 Stats: 23 lines in 5 files changed: 5 ins; 4 del; 14 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/982.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/982/head:pull/982 PR: https://git.openjdk.org/jdk21u-dev/pull/982 From goetz at openjdk.org Tue Sep 17 17:21:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Sep 2024 17:21:23 GMT Subject: [jdk17u-dev] RFR: 8330621: Make 5 compiler tests use ProcessTools.executeProcess Message-ID: I backport this for parity with 17.0.14-oracle. I omitted one test that was added by "8294609: C2: Improve inlining of methods with unloaded signature classes", an enhancement in 20 we won't backport. ------------- Commit messages: - Backport 5394f57f002c066021d811382a336253ae9f2014 Changes: https://git.openjdk.org/jdk17u-dev/pull/2884/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2884&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330621 Stats: 19 lines in 4 files changed: 4 ins; 4 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2884.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2884/head:pull/2884 PR: https://git.openjdk.org/jdk17u-dev/pull/2884 From duke at openjdk.org Tue Sep 17 21:27:42 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Tue, 17 Sep 2024 21:27:42 GMT Subject: [jdk21u-dev] RFR: 8322166: Files.isReadable/isWritable/isExecutable expensive when file does not exist [v2] In-Reply-To: <3qaZi5FvChcLH-QQyN31nKi7NFmSRQan7gX2Kagv_PE=.5c7cf259-e94e-477f-810a-6a6131f1d029@github.com> References: <3qaZi5FvChcLH-QQyN31nKi7NFmSRQan7gX2Kagv_PE=.5c7cf259-e94e-477f-810a-6a6131f1d029@github.com> Message-ID: <9oOg0L4CDBn7cDQDcVecA12zUpXIx2IuHJYIEZhm9_0=.0ef74312-3196-4a82-a5ca-6a3f6ac5e739@github.com> > Clean backport of a performance fix, originally authored by @bplb and reviewed by @AlanBateman > > Test suites run on linux-x86_64-server-release: > - [x] tier1 > - [x] jdk/java/nio Todd V. Jonker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into filecheck - Backport 51be857f3cafa23eb7cd73e5fe3db17e6d01684c ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/926/files - new: https://git.openjdk.org/jdk21u-dev/pull/926/files/1fc5729d..ce2cef3f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=926&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=926&range=00-01 Stats: 9420 lines in 193 files changed: 5602 ins; 3289 del; 529 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/926.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/926/head:pull/926 PR: https://git.openjdk.org/jdk21u-dev/pull/926 From dchuyko at openjdk.org Tue Sep 17 21:53:22 2024 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Tue, 17 Sep 2024 21:53:22 GMT Subject: [jdk21u-dev] Integrated: 8320192: SHAKE256 does not work correctly if n >= 137 In-Reply-To: References: Message-ID: On Thu, 8 Aug 2024 14:09:26 GMT, Dmitry Chuyko wrote: > This is a backport of KAT fix for SHAKE256. The test provided in the bug description currently fails on JDK 21. SHA3 part is clean, SHAKE128 part is removed as it is a separate new API. This pull request has now been integrated. Changeset: a4626db7 Author: Dmitry Chuyko Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/a4626db71c28bf428fd37e8066d79d4888304972 Stats: 11 lines in 1 file changed: 8 ins; 0 del; 3 mod 8320192: SHAKE256 does not work correctly if n >= 137 Reviewed-by: phh Backport-of: fcb4df26f18c7a10e4511f4be948c887f14ee093 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/902 From wkemper at openjdk.org Tue Sep 17 23:32:18 2024 From: wkemper at openjdk.org (William Kemper) Date: Tue, 17 Sep 2024 23:32:18 GMT Subject: [jdk23u] RFR: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate Message-ID: <6xic4wm6fjBouS8oZlUkftXrp8RbMnML6eATjqNDTa8=.c1bcfe88-1c66-4bff-91bd-754ef992ab36@github.com> Clean backport. This is a performance enhancement with no changes outside of Shenandoah. ------------- Commit messages: - Backport e74edbaea9f09169f597a470f647f3b7d10cc71b Changes: https://git.openjdk.org/jdk23u/pull/101/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=101&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336640 Stats: 21 lines in 2 files changed: 14 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk23u/pull/101.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/101/head:pull/101 PR: https://git.openjdk.org/jdk23u/pull/101 From andrewlu at openjdk.org Wed Sep 18 02:33:15 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 18 Sep 2024 02:33:15 GMT Subject: [jdk17u-dev] Integrated: 8303705: Field sleeper.started should be volatile JdbLockTestTarg.java In-Reply-To: <0DQF_z7ZlPWr9PWWOw7hgHAx_HdR0HowNiqdp4IGcMU=.4787fcb9-43a0-442b-98d9-679d89eab378@github.com> References: <0DQF_z7ZlPWr9PWWOw7hgHAx_HdR0HowNiqdp4IGcMU=.4787fcb9-43a0-442b-98d9-679d89eab378@github.com> Message-ID: <2mHb0doRZ-4sfgwjKkgoNz1yAeGf3q-K9Lo4t9l5XcQ=.964cb986-ec79-4237-8cdc-af22c0b14de3@github.com> On Thu, 12 Sep 2024 09:59:10 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: aa96b40d Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/aa96b40d72249a0abde3ff981e3b0653f63f175d Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8303705: Field sleeper.started should be volatile JdbLockTestTarg.java Backport-of: cd41c69d4484f900a89a71f1c9bab2bc2e383c1e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2867 From goetz at openjdk.org Wed Sep 18 05:57:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Sep 2024 05:57:16 GMT Subject: [jdk21u-dev] RFR: Merge jdk21u:master Message-ID: Merge build tag 21.0.5+8 from jdk21u to jdk21u-dev ------------- Commit messages: - Merge - 8337622: IllegalArgumentException in java.lang.reflect.Field.get - 8329667: [macos] Issue with JTree related fix for JDK-8317771 - 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk21u-dev/pull/983/files Stats: 228 lines in 7 files changed: 148 ins; 71 del; 9 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/983.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/983/head:pull/983 PR: https://git.openjdk.org/jdk21u-dev/pull/983 From goetz at openjdk.org Wed Sep 18 06:05:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Sep 2024 06:05:12 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master Message-ID: <0GIZwsEgIKS2MXb4BTpoWpthvczASOuKOgCiLdBpMes=.b222fb4a-71c8-43bb-a0d7-053819f7772b@github.com> Merge build tag 17.0.13+8 from jdk17u to jdk17u-dev ------------- Commit messages: - Merge - 8329667: [macos] Issue with JTree related fix for JDK-8317771 - 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk17u-dev/pull/2885/files Stats: 170 lines in 4 files changed: 97 ins; 64 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2885.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2885/head:pull/2885 PR: https://git.openjdk.org/jdk17u-dev/pull/2885 From goetz at openjdk.org Wed Sep 18 06:18:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Sep 2024 06:18:15 GMT Subject: [jdk21u-dev] Integrated: Merge jdk21u:master In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 05:52:26 GMT, Goetz Lindenmaier wrote: > Merge build tag 21.0.5+8 from jdk21u to jdk21u-dev This pull request has now been integrated. Changeset: fe357115 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/fe357115042fd9730b661c06fbf906a8598a9a77 Stats: 228 lines in 7 files changed: 148 ins; 71 del; 9 mod Merge ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/983 From goetz at openjdk.org Wed Sep 18 06:23:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Sep 2024 06:23:12 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master In-Reply-To: <0GIZwsEgIKS2MXb4BTpoWpthvczASOuKOgCiLdBpMes=.b222fb4a-71c8-43bb-a0d7-053819f7772b@github.com> References: <0GIZwsEgIKS2MXb4BTpoWpthvczASOuKOgCiLdBpMes=.b222fb4a-71c8-43bb-a0d7-053819f7772b@github.com> Message-ID: On Wed, 18 Sep 2024 05:59:35 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.13+8 from jdk17u to jdk17u-dev This pull request has now been integrated. Changeset: 8b54622b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/8b54622b3d8dba95b64e1d3507dd0a7beb421689 Stats: 170 lines in 4 files changed: 97 ins; 64 del; 9 mod Merge ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2885 From goetz at openjdk.org Wed Sep 18 06:32:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Sep 2024 06:32:16 GMT Subject: [jdk17u-dev] RFR: 8337320: Update ProblemList.txt with tests known to fail on XWayland In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 05:32:50 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. > Not clean, this file java/awt/FullScreen/SetFullScreenTest.java does not exist in jdk17 Can you please update the title with the hash from the push to 21? Backport 3140491fe2a5f1a3104b46c6103b02fbf89d34ae It should be clean then. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2858#issuecomment-2357611937 From goetz at openjdk.org Wed Sep 18 06:34:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Sep 2024 06:34:13 GMT Subject: [jdk21u-dev] RFR: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList In-Reply-To: References: Message-ID: On Fri, 13 Sep 2024 06:16:28 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.6-oracle. > > ?java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java 8332158 linux-x64? > not exist, no need to remove Please merge head, and double-check that the line isn't there twice. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/974#issuecomment-2357614828 From andrewlu at openjdk.org Wed Sep 18 06:52:43 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 18 Sep 2024 06:52:43 GMT Subject: [jdk21u-dev] RFR: 8311301: MethodExitTest may fail with stack buffer overrun Message-ID: <7Q9Y3Qr3Z3E1BDN2p4Vj8HmlLsybEXCuwNlqUbwi6JE=.c79735b7-0b7e-48c7-8714-dd6104faf48d@github.com> I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 3d813ae39f4422dd47473608eb8911e2483c6c32 Changes: https://git.openjdk.org/jdk21u-dev/pull/984/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=984&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311301 Stats: 20 lines in 1 file changed: 2 ins; 0 del; 18 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/984.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/984/head:pull/984 PR: https://git.openjdk.org/jdk21u-dev/pull/984 From andrewlu at openjdk.org Wed Sep 18 06:54:41 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 18 Sep 2024 06:54:41 GMT Subject: [jdk17u-dev] RFR: 8320586: update manual test/jdk/TEST.groups Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 99b9cb0a2eae1196f2127cd48e4085f19a90c4b4 Changes: https://git.openjdk.org/jdk17u-dev/pull/2886/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2886&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320586 Stats: 8 lines in 1 file changed: 4 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2886.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2886/head:pull/2886 PR: https://git.openjdk.org/jdk17u-dev/pull/2886 From andrewlu at openjdk.org Wed Sep 18 06:54:45 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 18 Sep 2024 06:54:45 GMT Subject: [jdk21u-dev] RFR: 8320586: update manual test/jdk/TEST.groups Message-ID: <42IrZ3ReM4q4s5dxnxGWxTFP_B2nhecmWV6AWXc2z6I=.7a09beba-261e-4ef9-a192-18d274c4a47c@github.com> I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 99b9cb0a2eae1196f2127cd48e4085f19a90c4b4 Changes: https://git.openjdk.org/jdk21u-dev/pull/985/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=985&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320586 Stats: 10 lines in 1 file changed: 5 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/985.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/985/head:pull/985 PR: https://git.openjdk.org/jdk21u-dev/pull/985 From andrewlu at openjdk.org Wed Sep 18 06:56:20 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 18 Sep 2024 06:56:20 GMT Subject: [jdk17u-dev] RFR: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3 Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport af7c6af0cc1eb6c42199c05933c7feb032bd6353 Changes: https://git.openjdk.org/jdk17u-dev/pull/2887/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2887&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324808 Stats: 1638 lines in 6 files changed: 296 ins; 1069 del; 273 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2887.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2887/head:pull/2887 PR: https://git.openjdk.org/jdk17u-dev/pull/2887 From andrewlu at openjdk.org Wed Sep 18 06:56:47 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 18 Sep 2024 06:56:47 GMT Subject: [jdk17u-dev] RFR: 8327401: Some jtreg tests fail on Wayland without any tracking bug Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 286cc163fd4f8361a633dcb6494965020d02b506 Changes: https://git.openjdk.org/jdk17u-dev/pull/2888/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2888&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327401 Stats: 736 lines in 24 files changed: 300 ins; 213 del; 223 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2888.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2888/head:pull/2888 PR: https://git.openjdk.org/jdk17u-dev/pull/2888 From mbaesken at openjdk.org Wed Sep 18 07:08:08 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 18 Sep 2024 07:08:08 GMT Subject: [jdk21u-dev] Integrated: 8333098: ubsan: bytecodeInfo.cpp:318:59: runtime error: division by zero In-Reply-To: <7OP7kyFjM17wbRsaHmzTPWz5Q_TyVP2pP-0QKdQKmoM=.9a40f0d5-4d4b-49a6-b24b-22b8fe343961@github.com> References: <7OP7kyFjM17wbRsaHmzTPWz5Q_TyVP2pP-0QKdQKmoM=.9a40f0d5-4d4b-49a6-b24b-22b8fe343961@github.com> Message-ID: <7p3-w3qx4CP6uJ_Ah3QU1h-6fvrX4AqvNapwMY8uKEs=.61ab165a-8f0b-4492-992d-050a71c01218@github.com> On Tue, 17 Sep 2024 14:39:16 GMT, Matthias Baesken wrote: > 8333098: ubsan: bytecodeInfo.cpp:318:59: runtime error: division by zero This pull request has now been integrated. Changeset: 466b87a8 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/466b87a8735a69d79c3f09e4b9d662ef37de25c9 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8333098: ubsan: bytecodeInfo.cpp:318:59: runtime error: division by zero Backport-of: f080b4bb8a75284db1b6037f8c00ef3b1ef1add1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/980 From goetz at openjdk.org Wed Sep 18 07:27:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Sep 2024 07:27:17 GMT Subject: [jdk21u-dev] RFR: 8335267: [XWayland] move screencast tokens from .awt to .java folder Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 088871ce36f85fb30b24c49146f547bc8e2b0dcb Changes: https://git.openjdk.org/jdk21u-dev/pull/986/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=986&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335267 Stats: 61 lines in 1 file changed: 23 ins; 8 del; 30 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/986.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/986/head:pull/986 PR: https://git.openjdk.org/jdk21u-dev/pull/986 From goetz at openjdk.org Wed Sep 18 07:27:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Sep 2024 07:27:38 GMT Subject: [jdk17u-dev] RFR: 8335267: [XWayland] move screencast tokens from .awt to .java folder Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 088871ce36f85fb30b24c49146f547bc8e2b0dcb Changes: https://git.openjdk.org/jdk17u-dev/pull/2889/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2889&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335267 Stats: 61 lines in 1 file changed: 23 ins; 8 del; 30 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2889.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2889/head:pull/2889 PR: https://git.openjdk.org/jdk17u-dev/pull/2889 From mbaesken at openjdk.org Wed Sep 18 07:54:21 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 18 Sep 2024 07:54:21 GMT Subject: [jdk23u] RFR: 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent Message-ID: 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent ------------- Commit messages: - Backport cb5c60b530dd744e7d78ef69f15eef7521c4f1cc Changes: https://git.openjdk.org/jdk23u/pull/102/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=102&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339591 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/102.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/102/head:pull/102 PR: https://git.openjdk.org/jdk23u/pull/102 From mbaesken at openjdk.org Wed Sep 18 08:27:37 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 18 Sep 2024 08:27:37 GMT Subject: [jdk21u-dev] RFR: 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent Message-ID: 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent ------------- Commit messages: - Backport cb5c60b530dd744e7d78ef69f15eef7521c4f1cc Changes: https://git.openjdk.org/jdk21u-dev/pull/987/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=987&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339591 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/987.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/987/head:pull/987 PR: https://git.openjdk.org/jdk21u-dev/pull/987 From gcao at openjdk.org Wed Sep 18 10:21:21 2024 From: gcao at openjdk.org (Gui Cao) Date: Wed, 18 Sep 2024 10:21:21 GMT Subject: [jdk23u] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 Message-ID: <6b81J3Qr_D0z_JaEbukjCqVHV9yWhiq9Z1E4XvKSvyQ=.aaa54edb-dd48-4299-9400-b94aeffae66c@github.com> Hi, The same issue also exists in the jdk23u. I would like to backport 8333248 to jdk23u. This is a risc-v specific change. Backport is clean, risk is low. ### Testing - [x] Run VectorGatherMaskFoldingTest.java on SOPHON SG2042 (without RVV1.0) - [x] Run VectorGatherMaskFoldingTest.java on aarch64 server mode with neon - [x] Run VectorGatherMaskFoldingTest.java on aarch64 client mode without `-XX:+IncrementalInlineForceCleanup` Option ------------- Commit messages: - Backport 9b0a5c5cd056262fab99525e9260762b617152a3 Changes: https://git.openjdk.org/jdk23u/pull/103/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=103&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333248 Stats: 29 lines in 1 file changed: 0 ins; 0 del; 29 mod Patch: https://git.openjdk.org/jdk23u/pull/103.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/103/head:pull/103 PR: https://git.openjdk.org/jdk23u/pull/103 From mdoerr at openjdk.org Wed Sep 18 11:07:35 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 18 Sep 2024 11:07:35 GMT Subject: [jdk23u] RFR: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity Message-ID: Backport of [JDK-8340230](https://bugs.openjdk.org/browse/JDK-8340230). Needs manual integration because [JDK-8340012](https://bugs.openjdk.org/browse/JDK-8340012) is not in jdk23u. Using DecodeN without CompressedOops or DecodeNKlass without CompressedClassPointers can cause errors. ------------- Commit messages: - Backport 3895b8fc0b2c6d187080dba6fe08297adad4a480 Changes: https://git.openjdk.org/jdk23u/pull/104/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=104&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340230 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk23u/pull/104.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/104/head:pull/104 PR: https://git.openjdk.org/jdk23u/pull/104 From goetz at openjdk.org Wed Sep 18 13:52:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Sep 2024 13:52:31 GMT Subject: [jdk17u-dev] RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829 Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 54028e779bb076a5ab1c03baa8ab89587252af4a Changes: https://git.openjdk.org/jdk17u-dev/pull/2890/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2890&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316562 Stats: 15 lines in 1 file changed: 8 ins; 1 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2890.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2890/head:pull/2890 PR: https://git.openjdk.org/jdk17u-dev/pull/2890 From goetz at openjdk.org Wed Sep 18 13:54:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Sep 2024 13:54:51 GMT Subject: [jdk17u-dev] RFR: 8296787: Unify debug printing format of X.509 cert serial numbers Message-ID: I backport this for parity with 17.0.14-oracle. Patching Copyright failed in most files. Resolved. Further conflicts: src/java.base/share/classes/sun/security/provider/certpath/Vertex.java One conflict due to diffs in the context. src/java.base/share/classes/sun/security/ssl/StatusResponseManager.java Resolved because code is using append() for Strings instead of '+'. test/lib/jdk/test/lib/security/TestTLSHandshake.java Resolved due to diffs in context. ------------- Commit messages: - Backport c328f9589ddc3a981a2c63801bd991f8e593e69f Changes: https://git.openjdk.org/jdk17u-dev/pull/2891/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2891&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296787 Stats: 65 lines in 18 files changed: 19 ins; 3 del; 43 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2891.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2891/head:pull/2891 PR: https://git.openjdk.org/jdk17u-dev/pull/2891 From goetz at openjdk.org Wed Sep 18 14:22:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Sep 2024 14:22:21 GMT Subject: [jdk17u-dev] RFR: 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test Message-ID: <8tyX0l47UxvDsFDUVlu1TM2sgHRyDK0OE9NNztGR3iE=.18f72e3a-1750-4f75-8827-d6f6a8bcffd4@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 54f09d734584a71c648520664447f8395050adbe Changes: https://git.openjdk.org/jdk17u-dev/pull/2892/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2892&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8278527 Stats: 76 lines in 2 files changed: 0 ins; 76 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2892.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2892/head:pull/2892 PR: https://git.openjdk.org/jdk17u-dev/pull/2892 From goetz at openjdk.org Wed Sep 18 14:27:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Sep 2024 14:27:16 GMT Subject: [jdk17u-dev] RFR: 8328303: 3 JDI tests timed out with UT enabled Message-ID: I backport this a prereq of 832898. ------------- Commit messages: - Backport bc73963974a824d77d54b8b0edbf8f05262b721c Changes: https://git.openjdk.org/jdk17u-dev/pull/2893/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2893&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328303 Stats: 97 lines in 3 files changed: 37 ins; 22 del; 38 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2893.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2893/head:pull/2893 PR: https://git.openjdk.org/jdk17u-dev/pull/2893 From goetz at openjdk.org Wed Sep 18 14:40:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Sep 2024 14:40:21 GMT Subject: [jdk17u-dev] RFR: 8328957: Update PKCS11Test.java to not use hardcoded path Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 16576b87b7267aaa99c41f77993287e3479577aa Changes: https://git.openjdk.org/jdk17u-dev/pull/2894/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2894&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328957 Stats: 37 lines in 1 file changed: 11 ins; 9 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2894.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2894/head:pull/2894 PR: https://git.openjdk.org/jdk17u-dev/pull/2894 From duke at openjdk.org Wed Sep 18 15:21:31 2024 From: duke at openjdk.org (Kerem Kat) Date: Wed, 18 Sep 2024 15:21:31 GMT Subject: [jdk11u-dev] RFR: 8268364: jmethod clearing should be done during unloading Message-ID: Backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364), single hunk conflict resolved by accepting "empty" from the backport commit vs. `clear_jmethod_ids` invocation in the dtor. Backport commit moves the `clear_jmethod_ids` invocation to `unload` method instead. It fixes crashes when accessing jmethodIDs of a class being unloaded. Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 11. To run the repro: javac Main.java gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so java -agentpath:"$(pwd)/repro.so" -Xmx100m -XX:+UseConcMarkSweepGC -XX:+CMSClassUnloadingEnabled -XX:+ExplicitGCInvokesConcurrent Main ------------- Commit messages: - Backport 3d84398d128bb2eed6280ebbc3f57afb3b89908f Changes: https://git.openjdk.org/jdk11u-dev/pull/2935/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2935&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8268364 Stats: 31 lines in 2 files changed: 20 ins; 9 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2935.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2935/head:pull/2935 PR: https://git.openjdk.org/jdk11u-dev/pull/2935 From duke at openjdk.org Wed Sep 18 15:21:32 2024 From: duke at openjdk.org (Kerem Kat) Date: Wed, 18 Sep 2024 15:21:32 GMT Subject: [jdk11u-dev] RFR: 8268364: jmethod clearing should be done during unloading In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 15:10:33 GMT, Kerem Kat wrote: > Backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364), single hunk conflict resolved by accepting "empty" from the backport commit vs. `clear_jmethod_ids` invocation in the dtor. Backport commit moves the `clear_jmethod_ids` invocation to `unload` method instead. > > It fixes crashes when accessing jmethodIDs of a class being unloaded. > > Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). > > This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 11. > > To run the repro: > > > javac Main.java > gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so > > java -agentpath:"$(pwd)/repro.so" -Xmx100m -XX:+UseConcMarkSweepGC -XX:+CMSClassUnloadingEnabled -XX:+ExplicitGCInvokesConcurrent Main * MacOS builds are failing for unrelated reason: ` error: 'sprintf' is deprecated`. * `linux-x86 / test - Test (tier1)` failing while uploading test artifacts: Error: Failed to CreateArtifact: Failed to make request after 5 attempts: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2935#issuecomment-2358763542 From cushon at openjdk.org Wed Sep 18 16:47:11 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Wed, 18 Sep 2024 16:47:11 GMT Subject: [jdk23u] RFR: 8337795: Type annotation attached to incorrect type during class reading [v2] In-Reply-To: References: Message-ID: <7vRYEqZTZ8zMhIzDRROqwzS_A6S-u9bySbgm0erFzOQ=.2f665811-5c58-4680-9e8d-1490d9cac4cf@github.com> On Wed, 14 Aug 2024 15:07:01 GMT, Liam Miller-Cushon wrote: >> This change fixes a bug in javac's handling of type annotations in bytecode, which was logic first added in JDK 22 as part of the fix for JDK-8225377. > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8337795 > - Backport 8d0831478338e9b084b2c47f46eba9faae3a5eb6 > Feel free to ask for assistance if you need help with progressing this pull request towards integration! The backport has maintainer approval, is there anything else I should be doing to help progress this towards integration? ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/67#issuecomment-2358955124 From shade at openjdk.org Wed Sep 18 17:17:12 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 18 Sep 2024 17:17:12 GMT Subject: [jdk21u-dev] RFR: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate In-Reply-To: References: <_-Tp2qhNmlZNquRSjo8f1x226hwBY3Ra7AnEmtJ9Gcw=.6fa12ab2-b85d-456f-be8b-df1f3e1f6f6b@github.com> Message-ID: <9kJj-2clmNXtF7DgSTVlWUFh7VzikFb1wR68jFjiuNk=.46350721-8aba-4616-b80c-5490d4aa315a@github.com> On Tue, 17 Sep 2024 13:50:25 GMT, Goetz Lindenmaier wrote: > Please backport to 23 first. I think 23u is now frozen for 23.0.2, and there likely be no 23.0.3. So backporting to 23u does not sound like a reasonable thing to do at this point in time. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/973#issuecomment-2359010479 From duke at openjdk.org Wed Sep 18 18:37:25 2024 From: duke at openjdk.org (duke) Date: Wed, 18 Sep 2024 18:37:25 GMT Subject: [jdk21u-dev] RFR: 8322166: Files.isReadable/isWritable/isExecutable expensive when file does not exist [v2] In-Reply-To: <9oOg0L4CDBn7cDQDcVecA12zUpXIx2IuHJYIEZhm9_0=.0ef74312-3196-4a82-a5ca-6a3f6ac5e739@github.com> References: <3qaZi5FvChcLH-QQyN31nKi7NFmSRQan7gX2Kagv_PE=.5c7cf259-e94e-477f-810a-6a6131f1d029@github.com> <9oOg0L4CDBn7cDQDcVecA12zUpXIx2IuHJYIEZhm9_0=.0ef74312-3196-4a82-a5ca-6a3f6ac5e739@github.com> Message-ID: On Tue, 17 Sep 2024 21:27:42 GMT, Todd V. Jonker wrote: >> Clean backport of a performance fix, originally authored by @bplb and reviewed by @AlanBateman >> >> Test suites run on linux-x86_64-server-release: >> - [x] tier1 >> - [x] jdk/java/nio > > Todd V. Jonker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into filecheck > - Backport 51be857f3cafa23eb7cd73e5fe3db17e6d01684c @toddjonker Your change (at version ce2cef3f771ba4516514249a2a8115e26c238005) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/926#issuecomment-2359154475 From andrewlu at openjdk.org Thu Sep 19 02:21:30 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 19 Sep 2024 02:21:30 GMT Subject: [jdk21u-dev] RFR: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.6-oracle. > > ?java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java 8332158 linux-x64? > not exist, no need to remove Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into andrewLu_backport_8338109 - Backport 2b5aec2aad3883d4d407ec3a572f78755d60190d ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/974/files - new: https://git.openjdk.org/jdk21u-dev/pull/974/files/9f05a3b7..0bdc352b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=974&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=974&range=00-01 Stats: 2504 lines in 80 files changed: 2174 ins; 138 del; 192 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/974.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/974/head:pull/974 PR: https://git.openjdk.org/jdk21u-dev/pull/974 From andrewlu at openjdk.org Thu Sep 19 02:21:34 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 19 Sep 2024 02:21:34 GMT Subject: [jdk17u-dev] RFR: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.14-oracle. > ?java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java 8332158 linux-x64? > not exist, no need to remove Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into andrewLu_backport_8338109 - Backport 2b5aec2aad3883d4d407ec3a572f78755d60190d ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2871/files - new: https://git.openjdk.org/jdk17u-dev/pull/2871/files/20e06203..541207c1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2871&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2871&range=00-01 Stats: 7656 lines in 111 files changed: 4082 ins; 3270 del; 304 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2871.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2871/head:pull/2871 PR: https://git.openjdk.org/jdk17u-dev/pull/2871 From andrewlu at openjdk.org Thu Sep 19 02:24:56 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 19 Sep 2024 02:24:56 GMT Subject: [jdk21u-dev] RFR: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.6-oracle. > > ?java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java 8332158 linux-x64? > not exist, no need to remove Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: update ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/974/files - new: https://git.openjdk.org/jdk21u-dev/pull/974/files/0bdc352b..c73a914e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=974&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=974&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/974.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/974/head:pull/974 PR: https://git.openjdk.org/jdk21u-dev/pull/974 From andrewlu at openjdk.org Thu Sep 19 02:29:12 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 19 Sep 2024 02:29:12 GMT Subject: [jdk11u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v4] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.25-oracle. > modify lines are different, but code is clean. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into andrewLu_backport_8320675 - fix - fix - Backport 9f5ad43358a4e209b4cd1c91bcc86b997f371548 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2912/files - new: https://git.openjdk.org/jdk11u-dev/pull/2912/files/64f0c5e6..873d272b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2912&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2912&range=02-03 Stats: 1937 lines in 49 files changed: 1527 ins; 297 del; 113 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2912.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2912/head:pull/2912 PR: https://git.openjdk.org/jdk11u-dev/pull/2912 From amitkumar at openjdk.org Thu Sep 19 07:07:41 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Thu, 19 Sep 2024 07:07:41 GMT Subject: [jdk21u-dev] RFR: 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' In-Reply-To: References: Message-ID: On Fri, 6 Sep 2024 09:02:25 GMT, Goetz Lindenmaier wrote: >> Hi all, >> >> This pull request contains a backport of commit [28de44da](https://github.com/openjdk/jdk/commit/28de44da71871bec7648f01a4df2faee43fa43b6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Amit Kumar on 5 Sep 2024 and was reviewed by Stefan Karlsson, Vladimir Kozlov and Dean Long. >> >> Thanks! > > You have failing tests. @GoeLin any insights on this ? I tried to restart the test few times it looks during downloading the artifact it is failing. In first run this test is failing: `serviceability/sa/ClhsdbFindPC.java#no-xcomp-process ` I looked into the JTR but not sure if it is at all related to this change. [ClhsdbFindPC_no-xcomp-process.log](https://github.com/user-attachments/files/17054980/ClhsdbFindPC_no-xcomp-process.log) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/955#issuecomment-2360158139 From andrewlu at openjdk.org Thu Sep 19 07:16:45 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 19 Sep 2024 07:16:45 GMT Subject: [jdk17u-dev] Integrated: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3 In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 06:50:04 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: e37b2961 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/e37b2961731475fc784d33b12cd2384e04cd5093 Stats: 1638 lines in 6 files changed: 296 ins; 1069 del; 273 mod 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3 Backport-of: af7c6af0cc1eb6c42199c05933c7feb032bd6353 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2887 From andrewlu at openjdk.org Thu Sep 19 07:20:37 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 19 Sep 2024 07:20:37 GMT Subject: [jdk21u-dev] Integrated: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList In-Reply-To: References: Message-ID: <5kaefBw7FUkpFWzqVE6n9rH9uHcX_XHyphtHWjcBzXQ=.3a7ba9fc-45e5-40a1-a256-9796dfa89f65@github.com> On Fri, 13 Sep 2024 06:16:28 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 77331aef Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/77331aef166f412ad19282a300b94062e0b741c6 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList Backport-of: 2b5aec2aad3883d4d407ec3a572f78755d60190d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/974 From andrewlu at openjdk.org Thu Sep 19 07:20:45 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 19 Sep 2024 07:20:45 GMT Subject: [jdk17u-dev] Integrated: 8337320: Update ProblemList.txt with tests known to fail on XWayland In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 05:32:50 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 81839816 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/81839816a0b2be50bbfb265d2cf49beef7a65b53 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod 8337320: Update ProblemList.txt with tests known to fail on XWayland Backport-of: 3140491fe2a5f1a3104b46c6103b02fbf89d34ae ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2858 From andrewlu at openjdk.org Thu Sep 19 07:21:43 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 19 Sep 2024 07:21:43 GMT Subject: [jdk21u-dev] Integrated: 8311301: MethodExitTest may fail with stack buffer overrun In-Reply-To: <7Q9Y3Qr3Z3E1BDN2p4Vj8HmlLsybEXCuwNlqUbwi6JE=.c79735b7-0b7e-48c7-8714-dd6104faf48d@github.com> References: <7Q9Y3Qr3Z3E1BDN2p4Vj8HmlLsybEXCuwNlqUbwi6JE=.c79735b7-0b7e-48c7-8714-dd6104faf48d@github.com> Message-ID: On Wed, 18 Sep 2024 06:48:15 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 2c22d283 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/2c22d28383825874ac0b56ce5ed0b90e7e3d7cdf Stats: 20 lines in 1 file changed: 2 ins; 0 del; 18 mod 8311301: MethodExitTest may fail with stack buffer overrun Backport-of: 3d813ae39f4422dd47473608eb8911e2483c6c32 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/984 From andrewlu at openjdk.org Thu Sep 19 07:29:03 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 19 Sep 2024 07:29:03 GMT Subject: [jdk17u-dev] RFR: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.14-oracle. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - update - Merge branch 'openjdk:master' into andrewLu_backport_8338109 - Merge branch 'openjdk:master' into andrewLu_backport_8338109 - Backport 2b5aec2aad3883d4d407ec3a572f78755d60190d ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2871/files - new: https://git.openjdk.org/jdk17u-dev/pull/2871/files/541207c1..a92405c4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2871&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2871&range=01-02 Stats: 1642 lines in 7 files changed: 300 ins; 1069 del; 273 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2871.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2871/head:pull/2871 PR: https://git.openjdk.org/jdk17u-dev/pull/2871 From duke at openjdk.org Thu Sep 19 09:07:24 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 19 Sep 2024 09:07:24 GMT Subject: [jdk11u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions Message-ID: The `macos-11` github runners [were deprecated and removed in June 2024](https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/) , making the `macos` tests to hang in `openjdk11u-dev` (and other OpenJDK repositories). [JDK-8335793 GHA: Bump macOS and Xcode versions](https://bugs.openjdk.org/browse/JDK-8335793) upgraded the version [from `macos-11` to `macos-13`](https://github.com/openjdk/jdk11u-dev/pull/2835). This upgrade in github runners required a long list of changes in `openjdk11u-dev` that proved difficult to review. In order to ease the review process this PR downgrades the version of github runners in `jdk11u-dev` from the current `macos-13` to `macos-12` and `xcode-13.4.1`. This will require a single backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) (a follow-up to this PR), making the review process easier. Once the github actions are running again in `macos-12` an upgrade to `macos-13` could be performed, if required, with some more additional PRs. ------------- Commit messages: - Backport 7144027dff495b623428bd9cd891c0ed912035a4 Changes: https://git.openjdk.org/jdk11u-dev/pull/2936/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2936&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318039 Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2936.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2936/head:pull/2936 PR: https://git.openjdk.org/jdk11u-dev/pull/2936 From duke at openjdk.org Thu Sep 19 09:44:09 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 19 Sep 2024 09:44:09 GMT Subject: [jdk11u-dev] RFR: 8299254: Support dealing with standard assert macro Message-ID: Backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) on top of the previous PR [`macos-12` github actions ](https://github.com/openjdk/jdk11u-dev/pull/2936). This will make the github actions in `jdk11u-dev` run again on top of `macos-12` / `xcode-13.4.1` . The change is minimal, and should work properly with no changes on any existing `macos-11` CI pipelines. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/2936 Commit messages: - Backport 89dd23f2fab0d98879e68f817923656e113087e3 Changes: https://git.openjdk.org/jdk11u-dev/pull/2937/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2937&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299254 Stats: 19 lines in 4 files changed: 12 ins; 2 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2937.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2937/head:pull/2937 PR: https://git.openjdk.org/jdk11u-dev/pull/2937 From duke at openjdk.org Thu Sep 19 09:55:25 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 19 Sep 2024 09:55:25 GMT Subject: [jdk11u-dev] RFR: 8299254: Support dealing with standard assert macro [v2] In-Reply-To: References: Message-ID: > Backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) on top of the previous PR [`macos-12` github actions ](https://github.com/openjdk/jdk11u-dev/pull/2936). > > This will make the github actions in `jdk11u-dev` run again on top of `macos-12` / `xcode-13.4.1` . > > The change is minimal, and should work properly with no changes on any existing `macos-11` CI pipelines. Antonio Vieiro has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 89dd23f2fab0d98879e68f817923656e113087e3 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2937/files - new: https://git.openjdk.org/jdk11u-dev/pull/2937/files/5974a924..c7a6fe01 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2937&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2937&range=00-01 Stats: 81 lines in 2 files changed: 81 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2937.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2937/head:pull/2937 PR: https://git.openjdk.org/jdk11u-dev/pull/2937 From amitkumar at openjdk.org Thu Sep 19 10:02:56 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Thu, 19 Sep 2024 10:02:56 GMT Subject: [jdk21u-dev] RFR: 8339416: [s390x] Provide implementation for resolve_global_jobject Message-ID: <-Q6Ek2B5P7QgpkQXpWGSisXft_tJBfNX0bxVRvd2QOo=.2adacd2d-412b-4cfd-9bf3-0f1271bc7cfd@github.com> Hi all, This pull request contains a backport of commit [ac58b610](https://github.com/openjdk/jdk/commit/ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 19 Sep 2024 and was reviewed by Martin Doerr and Lutz Schmidt. Thanks! ------------- Commit messages: - Backport ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45 Changes: https://git.openjdk.org/jdk21u-dev/pull/988/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=988&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339416 Stats: 81 lines in 6 files changed: 70 ins; 4 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/988.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/988/head:pull/988 PR: https://git.openjdk.org/jdk21u-dev/pull/988 From duke at openjdk.org Thu Sep 19 10:11:10 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 19 Sep 2024 10:11:10 GMT Subject: [jdk11u-dev] RFR: 8318696: Do not use LFS64 symbols on Linux Message-ID: Backport of [JDK-8318696 Do not use LFS64 symbols on Linux](https://bugs.openjdk.org/browse/JDK-8318696). This replaces the usage of LFS64 symbols in Linux with their regular counterparts adding `-D_FILE_OFFSET_BITS=64`. This is not a clean backport, because in `jdk11` many of these symbols still live in `os_linux.cpp` and `os_linux_inline.hpp`, that were then refactored/deleted during the years into [the current `os_posix.hpp` and `os_posix.cpp` in `jdk17`](https://github.com/openjdk/jdk17u-dev/commit/2b9228a3c92590e3146ecad468bb2ea68a5a6bb2). ------------- Commit messages: - Backport 2b9228a3c92590e3146ecad468bb2ea68a5a6bb2 Changes: https://git.openjdk.org/jdk11u-dev/pull/2938/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2938&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318696 Stats: 24 lines in 4 files changed: 0 ins; 0 del; 24 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2938.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2938/head:pull/2938 PR: https://git.openjdk.org/jdk11u-dev/pull/2938 From aivanov at openjdk.org Thu Sep 19 11:29:25 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Thu, 19 Sep 2024 11:29:25 GMT Subject: [jdk23u] RFR: 8340007: Refactor KeyEvent/FunctionKeyTest.java Message-ID: Backporting [JDK-8340007](https://bugs.openjdk.org/browse/JDK-8340007) to 23u. > This pull request contains a backport of commit [2faf8b8d](https://github.com/openjdk/jdk/commit/2faf8b8d582183275b1fdc92313a1c63c1753e80) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Ivanov on 19 Sep 2024 and was reviewed by Alexander Zvegintsev. ------------- Commit messages: - Backport 2faf8b8d582183275b1fdc92313a1c63c1753e80 Changes: https://git.openjdk.org/jdk23u/pull/105/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=105&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340007 Stats: 114 lines in 1 file changed: 62 ins; 15 del; 37 mod Patch: https://git.openjdk.org/jdk23u/pull/105.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/105/head:pull/105 PR: https://git.openjdk.org/jdk23u/pull/105 From aivanov at openjdk.org Thu Sep 19 11:30:07 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Thu, 19 Sep 2024 11:30:07 GMT Subject: [jdk23u] RFR: 8340210: Add positionTestUI() to PassFailJFrame.Builder Message-ID: <6vQ-YfIA1tiwM-k5dCnh1tNMU0g_XGz0m3Ev312Q6RA=.2ed5cf9d-1fdb-4762-98a8-c0e997253b03@github.com> Backporting [JDK-8340210](https://bugs.openjdk.org/browse/JDK-8340210) to 23u. > This pull request contains a backport of commit [f0ae90f3](https://github.com/openjdk/jdk/commit/f0ae90f30c346544e87217ef1832d6a350fe1985) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Harshitha Onkar on 17 Sep 2024 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. ------------- Commit messages: - Backport f0ae90f30c346544e87217ef1832d6a350fe1985 Changes: https://git.openjdk.org/jdk23u/pull/106/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=106&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340210 Stats: 23 lines in 1 file changed: 23 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/106.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/106/head:pull/106 PR: https://git.openjdk.org/jdk23u/pull/106 From aivanov at openjdk.org Thu Sep 19 11:52:16 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Thu, 19 Sep 2024 11:52:16 GMT Subject: [jdk23u] RFR: 8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS Message-ID: Backporting [JDK-8332901](https://bugs.openjdk.org/browse/JDK-8332901) to 23u. The patch does not apply cleanly, there's a conflict in `test/jdk/ProblemList.txt` because of context differences. JDK 23u does not have the *Wayland related* problem-listings. Essentially, the change to `ProblemList.txt` is the same: remove `SelectNewItemTest.java` from PL. > This pull request contains a backport of commit [ef96a7b0](https://github.com/openjdk/jdk/commit/ef96a7b014795f366af3a90ef8f474cfb621197f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Ivanov on 4 Sep 2024 and was reviewed by Harshitha Onkar, Phil Race and Damon Nguyen. ------------- Commit messages: - Backport ef96a7b014795f366af3a90ef8f474cfb621197f Changes: https://git.openjdk.org/jdk23u/pull/107/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=107&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332901 Stats: 593 lines in 5 files changed: 276 ins; 317 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/107.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/107/head:pull/107 PR: https://git.openjdk.org/jdk23u/pull/107 From mbaesken at openjdk.org Thu Sep 19 11:57:36 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 19 Sep 2024 11:57:36 GMT Subject: [jdk23u] Integrated: 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 07:49:39 GMT, Matthias Baesken wrote: > 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent This pull request has now been integrated. Changeset: f7d38e1c Author: Matthias Baesken URL: https://git.openjdk.org/jdk23u/commit/f7d38e1c2d2b018a6506910c3b9949d515e94b33 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent Backport-of: cb5c60b530dd744e7d78ef69f15eef7521c4f1cc ------------- PR: https://git.openjdk.org/jdk23u/pull/102 From goetz at openjdk.org Thu Sep 19 12:05:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Sep 2024 12:05:48 GMT Subject: [jdk21u-dev] Integrated: 8339644: Improve parsing of Day/Month in tzdata rules In-Reply-To: References: Message-ID: On Mon, 16 Sep 2024 06:10:58 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: da4d2c58 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/da4d2c58d3b7f1e7310b4f264a1cad05a983f522 Stats: 83 lines in 3 files changed: 23 ins; 26 del; 34 mod 8339644: Improve parsing of Day/Month in tzdata rules Backport-of: 86a2f9c7dcb6585cabf03c0940511d11560e85b7 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/979 From goetz at openjdk.org Thu Sep 19 12:05:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Sep 2024 12:05:54 GMT Subject: [jdk17u-dev] Integrated: 8339644: Improve parsing of Day/Month in tzdata rules In-Reply-To: References: Message-ID: <7hNf39EYysAgGWEIgA61yyZHrqgdOZihgch0lq_8U3o=.bea8c8a4-06e3-4d5c-a76c-c1c26e2ecf14@github.com> On Mon, 16 Sep 2024 06:14:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 5faa0df6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5faa0df6fb1b4c5dc7f642d7e062c44a1764029c Stats: 83 lines in 3 files changed: 23 ins; 26 del; 34 mod 8339644: Improve parsing of Day/Month in tzdata rules Backport-of: 86a2f9c7dcb6585cabf03c0940511d11560e85b7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2882 From aivanov at openjdk.org Thu Sep 19 12:27:43 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Thu, 19 Sep 2024 12:27:43 GMT Subject: [jdk23u] RFR: 8340306: Add border around instructions in PassFailJFrame Message-ID: Backporting JDK-8340306 to 23u. The patch applies cleanly. > This pull request contains a backport of commit [0120d3ee](https://github.com/openjdk/jdk/commit/0120d3eed50bdc9fa53f2c41b31791620aeef613) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Ivanov on 19 Sep 2024 and was reviewed by Harshitha Onkar and Phil Race. ------------- Commit messages: - Backport 0120d3eed50bdc9fa53f2c41b31791620aeef613 Changes: https://git.openjdk.org/jdk23u/pull/108/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=108&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340306 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/108.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/108/head:pull/108 PR: https://git.openjdk.org/jdk23u/pull/108 From duke at openjdk.org Thu Sep 19 12:41:42 2024 From: duke at openjdk.org (duke) Date: Thu, 19 Sep 2024 12:41:42 GMT Subject: [jdk23u] RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 In-Reply-To: <6b81J3Qr_D0z_JaEbukjCqVHV9yWhiq9Z1E4XvKSvyQ=.aaa54edb-dd48-4299-9400-b94aeffae66c@github.com> References: <6b81J3Qr_D0z_JaEbukjCqVHV9yWhiq9Z1E4XvKSvyQ=.aaa54edb-dd48-4299-9400-b94aeffae66c@github.com> Message-ID: On Wed, 18 Sep 2024 10:16:14 GMT, Gui Cao wrote: > Hi, The same issue also exists in the jdk23u. I would like to backport 8333248 to jdk23u. This is a risc-v specific change. Backport is clean, risk is low. > > ### Testing > - [x] Run VectorGatherMaskFoldingTest.java on SOPHON SG2042 (without RVV1.0) > - [x] Run VectorGatherMaskFoldingTest.java on aarch64 server mode with neon > - [x] Run VectorGatherMaskFoldingTest.java on aarch64 client mode without `-XX:+IncrementalInlineForceCleanup` Option @zifeihan Your change (at version 64bd58b1d19a886f7be19ae901d6e5475432bba2) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/103#issuecomment-2360875599 From mbaesken at openjdk.org Thu Sep 19 12:46:47 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 19 Sep 2024 12:46:47 GMT Subject: [jdk17u-dev] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 20:01:27 GMT, Alexey Bakhtin wrote: > The backport is almost clean. > - manual update of the copyright year for Stream.java > - manual merge of one-line change in the Http2TestServer.java file. Caused by difference in JDK-8295944 implementation for JDK17 and JDK21 > > All java/net/httpclient JTREG tests passed I'll put this into our build/test queue and if no issues show up, will review tomorrow . ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2798#issuecomment-2360886255 From duke at openjdk.org Thu Sep 19 12:55:52 2024 From: duke at openjdk.org (Kerem Kat) Date: Thu, 19 Sep 2024 12:55:52 GMT Subject: [jdk17u-dev] RFR: 8316581: Improve performance of Symbol::print_value_on() Message-ID: Clean backport to improve class unloading performance. ------------- Commit messages: - Backport 90bcdbd15fe7211377f6f6812a2b562c17995d65 Changes: https://git.openjdk.org/jdk17u-dev/pull/2895/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2895&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316581 Stats: 6 lines in 1 file changed: 0 ins; 3 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2895.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2895/head:pull/2895 PR: https://git.openjdk.org/jdk17u-dev/pull/2895 From goetz at openjdk.org Thu Sep 19 13:30:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Sep 2024 13:30:56 GMT Subject: [jdk21u-dev] RFR: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException Message-ID: I backport this for parity with 21.0.6-oracle. Resolved ProblemList, probably clean. ------------- Commit messages: - Backport 034297a6bd9bfcea7fa48792f54c84a6e976b319 Changes: https://git.openjdk.org/jdk21u-dev/pull/989/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=989&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336240 Stats: 16 lines in 3 files changed: 6 ins; 5 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/989.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/989/head:pull/989 PR: https://git.openjdk.org/jdk21u-dev/pull/989 From goetz at openjdk.org Thu Sep 19 13:33:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Sep 2024 13:33:15 GMT Subject: [jdk21u-dev] RFR: 8318105: [jmh] the test java.security.HSS failed with 2 active threads Message-ID: <7AIwIBUErt-PLhNwX9lg6Blm4cRcsy-Xv_l9zfraACQ=.b3bd79e2-5c2e-48cc-bd73-b008c9647004@github.com> I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 38c01971ff1c440d8c7ef4bc3432e5b9797ae708 Changes: https://git.openjdk.org/jdk21u-dev/pull/990/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=990&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318105 Stats: 224 lines in 1 file changed: 171 ins; 38 del; 15 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/990.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/990/head:pull/990 PR: https://git.openjdk.org/jdk21u-dev/pull/990 From goetz at openjdk.org Thu Sep 19 14:15:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Sep 2024 14:15:25 GMT Subject: [jdk21u-dev] RFR: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless. Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 2b4a4b7bd84806f997adc107abbd4351425e8d1d Changes: https://git.openjdk.org/jdk21u-dev/pull/991/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=991&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326121 Stats: 8 lines in 2 files changed: 4 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/991.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/991/head:pull/991 PR: https://git.openjdk.org/jdk21u-dev/pull/991 From goetz at openjdk.org Thu Sep 19 14:15:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Sep 2024 14:15:30 GMT Subject: [jdk17u-dev] RFR: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless. Message-ID: <9vn7TnW8s9-ZRBb_j5Vw5pH6LbkkRwLcksCByorH6x4=.dde46962-3594-4da4-85d6-cb99f938ca39@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 2b4a4b7bd84806f997adc107abbd4351425e8d1d Changes: https://git.openjdk.org/jdk17u-dev/pull/2896/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2896&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326121 Stats: 8 lines in 2 files changed: 4 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2896.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2896/head:pull/2896 PR: https://git.openjdk.org/jdk17u-dev/pull/2896 From goetz at openjdk.org Thu Sep 19 14:24:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Sep 2024 14:24:58 GMT Subject: [jdk17u-dev] RFR: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 284671a1e4fb5bfe15b20b7f41fc24415b1235ed Changes: https://git.openjdk.org/jdk17u-dev/pull/2897/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2897&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335449 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2897.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2897/head:pull/2897 PR: https://git.openjdk.org/jdk17u-dev/pull/2897 From goetz at openjdk.org Thu Sep 19 14:45:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Sep 2024 14:45:40 GMT Subject: [jdk21u-dev] RFR: 8339416: [s390x] Provide implementation for resolve_global_jobject In-Reply-To: <-Q6Ek2B5P7QgpkQXpWGSisXft_tJBfNX0bxVRvd2QOo=.2adacd2d-412b-4cfd-9bf3-0f1271bc7cfd@github.com> References: <-Q6Ek2B5P7QgpkQXpWGSisXft_tJBfNX0bxVRvd2QOo=.2adacd2d-412b-4cfd-9bf3-0f1271bc7cfd@github.com> Message-ID: On Thu, 19 Sep 2024 06:12:34 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [ac58b610](https://github.com/openjdk/jdk/commit/ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 19 Sep 2024 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! Please backport this to 23u, too. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/988#issuecomment-2361201267 From duke at openjdk.org Thu Sep 19 15:17:18 2024 From: duke at openjdk.org (Kerem Kat) Date: Thu, 19 Sep 2024 15:17:18 GMT Subject: [jdk17u-dev] RFR: 8325616: JFR ZGC Allocation Stall events should record stack traces Message-ID: Backport of JDK-8325616, conflict in a single hunk that wants to add `ZYoungGarbageCollection` and `ZOldGarbageCollection` to `metadata.xml`, which are unrelated and part of GenZGC. #### Verification 1. Ran jdk_jfr and hotspot_gc tests. All tests passed. ``` make test TEST=hotspot_gc TEST_VM_OPTS=-XX:+UseZGC make test TEST=jdk_jdr TEST_VM_OPTS=-XX:+UseZGC ``` 2. `ZAllocationStall` event has stack trace entry in the jfr for a sample java program: jdk.ZAllocationStall { startTime = 15:07:54.691 duration = 4.48 ms type = "Large" size = 12.0 MB eventThread = "main" (javaThreadId = 1) stackTrace = [ AllocRate.main(String[]) line: 16 ] } ------------- Commit messages: - Backport 71ff2d717798f1f314b97d97dfbc2b859fb47ae3 Changes: https://git.openjdk.org/jdk17u-dev/pull/2898/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2898&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325616 Stats: 3 lines in 3 files changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2898.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2898/head:pull/2898 PR: https://git.openjdk.org/jdk17u-dev/pull/2898 From gcao at openjdk.org Thu Sep 19 15:17:42 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 19 Sep 2024 15:17:42 GMT Subject: [jdk23u] Integrated: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 In-Reply-To: <6b81J3Qr_D0z_JaEbukjCqVHV9yWhiq9Z1E4XvKSvyQ=.aaa54edb-dd48-4299-9400-b94aeffae66c@github.com> References: <6b81J3Qr_D0z_JaEbukjCqVHV9yWhiq9Z1E4XvKSvyQ=.aaa54edb-dd48-4299-9400-b94aeffae66c@github.com> Message-ID: On Wed, 18 Sep 2024 10:16:14 GMT, Gui Cao wrote: > Hi, The same issue also exists in the jdk23u. I would like to backport 8333248 to jdk23u. This is a risc-v specific change. Backport is clean, risk is low. > > ### Testing > - [x] Run VectorGatherMaskFoldingTest.java on SOPHON SG2042 (without RVV1.0) > - [x] Run VectorGatherMaskFoldingTest.java on aarch64 server mode with neon > - [x] Run VectorGatherMaskFoldingTest.java on aarch64 client mode without `-XX:+IncrementalInlineForceCleanup` Option This pull request has now been integrated. Changeset: 227fc468 Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk23u/commit/227fc468a4d04c75e677a270b274b998f33b5e8f Stats: 29 lines in 1 file changed: 0 ins; 0 del; 29 mod 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 Backport-of: 9b0a5c5cd056262fab99525e9260762b617152a3 ------------- PR: https://git.openjdk.org/jdk23u/pull/103 From duke at openjdk.org Thu Sep 19 15:29:50 2024 From: duke at openjdk.org (Kerem Kat) Date: Thu, 19 Sep 2024 15:29:50 GMT Subject: [jdk11u-dev] RFR: 8268364: jmethod clearing should be done during unloading In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 15:10:33 GMT, Kerem Kat wrote: > Backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364), single hunk conflict resolved by accepting "empty" from the backport commit vs. `clear_jmethod_ids` invocation in the dtor. Backport commit moves the `clear_jmethod_ids` invocation to `unload` method instead. > > It fixes crashes when accessing jmethodIDs of a class being unloaded. > > Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). > > This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 11. > > To run the repro: > > > javac Main.java > gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so > > java -agentpath:"$(pwd)/repro.so" -Xmx100m -XX:+UseConcMarkSweepGC -XX:+CMSClassUnloadingEnabled -XX:+ExplicitGCInvokesConcurrent Main cc @coleenp @fisk ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2935#issuecomment-2361340298 From duke at openjdk.org Thu Sep 19 18:21:44 2024 From: duke at openjdk.org (duke) Date: Thu, 19 Sep 2024 18:21:44 GMT Subject: [jdk23u] RFR: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate In-Reply-To: <6xic4wm6fjBouS8oZlUkftXrp8RbMnML6eATjqNDTa8=.c1bcfe88-1c66-4bff-91bd-754ef992ab36@github.com> References: <6xic4wm6fjBouS8oZlUkftXrp8RbMnML6eATjqNDTa8=.c1bcfe88-1c66-4bff-91bd-754ef992ab36@github.com> Message-ID: On Tue, 17 Sep 2024 23:26:43 GMT, William Kemper wrote: > Clean backport. This is a performance enhancement with no changes outside of Shenandoah. @earthling-amzn Your change (at version da30c4f406d41333c3cfd72c0efd2d5af4751bb3) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/101#issuecomment-2361873955 From matsaave at openjdk.org Thu Sep 19 18:28:12 2024 From: matsaave at openjdk.org (Matias Saavedra Silva) Date: Thu, 19 Sep 2024 18:28:12 GMT Subject: [jdk23u] RFR: 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 Message-ID: Backport of the changes JDK-8338924 and JDK-8335664. This patch is not clean since it excludes the changes to Problem list. ------------- Commit messages: - Backport 1353601dcc8f9ec3e12dea21dc61b3585a154b13 Changes: https://git.openjdk.org/jdk23u/pull/109/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=109&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338924 Stats: 144 lines in 6 files changed: 134 ins; 6 del; 4 mod Patch: https://git.openjdk.org/jdk23u/pull/109.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/109/head:pull/109 PR: https://git.openjdk.org/jdk23u/pull/109 From coleenp at openjdk.org Thu Sep 19 18:31:42 2024 From: coleenp at openjdk.org (Coleen Phillimore) Date: Thu, 19 Sep 2024 18:31:42 GMT Subject: [jdk23u] RFR: 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 18:23:01 GMT, Matias Saavedra Silva wrote: > Backport of the changes JDK-8338924 and JDK-8335664. This patch is not clean since it excludes the changes to Problem list. Looks good! ------------- Marked as reviewed by coleenp (Reviewer). PR Review: https://git.openjdk.org/jdk23u/pull/109#pullrequestreview-2316418593 From coleenp at openjdk.org Thu Sep 19 19:32:43 2024 From: coleenp at openjdk.org (Coleen Phillimore) Date: Thu, 19 Sep 2024 19:32:43 GMT Subject: [jdk11u-dev] RFR: 8268364: jmethod clearing should be done during unloading In-Reply-To: References: Message-ID: <_x2_bto5XsOQNU2BjJ7mWObKq4oLuGILyMm0FXK7Zf8=.25853d53-92be-42f0-8f7d-e38807ebafee@github.com> On Wed, 18 Sep 2024 15:10:33 GMT, Kerem Kat wrote: > Backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364), single hunk conflict resolved by accepting "empty" from the backport commit vs. `clear_jmethod_ids` invocation in the dtor. Backport commit moves the `clear_jmethod_ids` invocation to `unload` method instead. > > It fixes crashes when accessing jmethodIDs of a class being unloaded. > > Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). > > This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 11. > > To run the repro: > > > javac Main.java > gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so > > java -agentpath:"$(pwd)/repro.so" -Xmx100m -XX:+UseConcMarkSweepGC -XX:+CMSClassUnloadingEnabled -XX:+ExplicitGCInvokesConcurrent Main This looks like a good backport. ------------- Marked as reviewed by coleenp (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2935#pullrequestreview-2316581916 From bulasevich at openjdk.org Thu Sep 19 20:57:19 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Thu, 19 Sep 2024 20:57:19 GMT Subject: [jdk21u-dev] RFR: 8320682: [AArch64] C1 compilation fails with "Field too big for insn" [v2] In-Reply-To: References: Message-ID: > Hi all, > > This is a backport of [JDK-8320682](https://github.com/openjdk/jdk/pull/16951) change to fix C1 internal error caused by adr limit being broken by too large NMethodSizeLimit option value. > > The backported patch includes a change to the TestC1Globals.java that does not yet exist in the jdk21u codebase. In the mainline the test has four updates: > - [1] https://github.com/openjdk/jdk/commit/7df73a23 > - [2] https://github.com/openjdk/jdk/commit/c36ec2ca > - [3] https://github.com/openjdk/jdk/commit/69014cd5 (this change) > - [4] https://github.com/openjdk/jdk/commit/27d5f5c2 > > With this change I simply copy version [3] of TestC1Globals.java corresponding to this change in jdk-23. Why not backport [1]+[2]+[3] to have a clean incremental patch? > - I do not think [1] fits the backporting rules (not a crash fix, and not very important) > - change [3] is stronger than change [2] (once NMethodSizeLimit is limited, no need to gracefully handle large values) > > Testing: jtreg tier1-3. > Without the patch `$ fastdebug/bin/java -XX:NMethodSizeLimit=4M` causes the `guarantee(chk == -1 || chk == 0) failed: Field too big for insn`. With the change the 4M value becomes invalid. Boris Ulasevich has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 69014cd55b59a0a63f4918fad575a6887640573e ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/956/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=956&range=01 Stats: 71 lines in 2 files changed: 69 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/956.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/956/head:pull/956 PR: https://git.openjdk.org/jdk21u-dev/pull/956 From amitkumar at openjdk.org Fri Sep 20 04:30:09 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Fri, 20 Sep 2024 04:30:09 GMT Subject: [jdk23u] RFR: 8339416: [s390x] Provide implementation for resolve_global_jobject Message-ID: <28csfiAISFu4XsPOsiyBNXGzEMaALCvYgN4sUOX8hdA=.a6bb94e4-9fbc-4dc6-ae7e-08f33bd73ba9@github.com> Hi all, This pull request contains a backport of commit [ac58b610](https://github.com/openjdk/jdk/commit/ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 19 Sep 2024 and was reviewed by Martin Doerr and Lutz Schmidt. Thanks! ------------- Commit messages: - Backport ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45 Changes: https://git.openjdk.org/jdk23u/pull/110/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=110&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339416 Stats: 81 lines in 6 files changed: 70 ins; 4 del; 7 mod Patch: https://git.openjdk.org/jdk23u/pull/110.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/110/head:pull/110 PR: https://git.openjdk.org/jdk23u/pull/110 From amitkumar at openjdk.org Fri Sep 20 04:38:46 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Fri, 20 Sep 2024 04:38:46 GMT Subject: [jdk21u-dev] RFR: 8339416: [s390x] Provide implementation for resolve_global_jobject In-Reply-To: <-Q6Ek2B5P7QgpkQXpWGSisXft_tJBfNX0bxVRvd2QOo=.2adacd2d-412b-4cfd-9bf3-0f1271bc7cfd@github.com> References: <-Q6Ek2B5P7QgpkQXpWGSisXft_tJBfNX0bxVRvd2QOo=.2adacd2d-412b-4cfd-9bf3-0f1271bc7cfd@github.com> Message-ID: On Thu, 19 Sep 2024 06:12:34 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [ac58b610](https://github.com/openjdk/jdk/commit/ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 19 Sep 2024 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! I have created PR for jdk23u and running test on it for now. Once that finishes I will apply for approval. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/988#issuecomment-2362796506 From duke at openjdk.org Fri Sep 20 04:38:46 2024 From: duke at openjdk.org (duke) Date: Fri, 20 Sep 2024 04:38:46 GMT Subject: [jdk21u-dev] RFR: 8339416: [s390x] Provide implementation for resolve_global_jobject In-Reply-To: <-Q6Ek2B5P7QgpkQXpWGSisXft_tJBfNX0bxVRvd2QOo=.2adacd2d-412b-4cfd-9bf3-0f1271bc7cfd@github.com> References: <-Q6Ek2B5P7QgpkQXpWGSisXft_tJBfNX0bxVRvd2QOo=.2adacd2d-412b-4cfd-9bf3-0f1271bc7cfd@github.com> Message-ID: <7Yl69MWb-nDQBxVRc5V-8XogFpw7qHD6Om-v4DVWEXk=.aad1abae-fc20-4c4f-85ba-a8262a58d8fc@github.com> On Thu, 19 Sep 2024 06:12:34 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [ac58b610](https://github.com/openjdk/jdk/commit/ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 19 Sep 2024 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! @offamitkumar Your change (at version 16971f604392064ffb3cfed58c7f071639dd763e) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/988#issuecomment-2362800282 From goetz at openjdk.org Fri Sep 20 06:11:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 06:11:47 GMT Subject: [jdk17u-dev] Integrated: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829 In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 13:46:56 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 59065882 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5906588236e05d77e37a385695db046d2d74afe5 Stats: 15 lines in 1 file changed: 8 ins; 1 del; 6 mod 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829 Backport-of: 54028e779bb076a5ab1c03baa8ab89587252af4a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2890 From goetz at openjdk.org Fri Sep 20 06:16:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 06:16:43 GMT Subject: [jdk21u-dev] Integrated: 8321474: TestAutoCreateSharedArchiveUpgrade.java should be updated with JDK 21 In-Reply-To: References: Message-ID: <_jo3n9uuf3uFN2uM7gmvzwvoVXFom7e7xgVVV3I2TpE=.63d4c24a-d836-4955-9a66-485e64daa194@github.com> On Tue, 17 Sep 2024 16:57:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 9ac04f17 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/9ac04f17e3aefe941246b103210f76bd33ed76aa Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod 8321474: TestAutoCreateSharedArchiveUpgrade.java should be updated with JDK 21 Backport-of: 1b621f5527a0d7ae345d79f293357446ab7876d9 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/981 From goetz at openjdk.org Fri Sep 20 06:18:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 06:18:41 GMT Subject: [jdk21u-dev] Integrated: 8330621: Make 5 compiler tests use ProcessTools.executeProcess In-Reply-To: References: Message-ID: On Tue, 17 Sep 2024 17:07:56 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 91a2eba4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/91a2eba480be32cce0ef4e55f1e763f9f7be23d2 Stats: 23 lines in 5 files changed: 5 ins; 4 del; 14 mod 8330621: Make 5 compiler tests use ProcessTools.executeProcess Backport-of: 5394f57f002c066021d811382a336253ae9f2014 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/982 From goetz at openjdk.org Fri Sep 20 06:18:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 06:18:46 GMT Subject: [jdk17u-dev] Integrated: 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test In-Reply-To: <8tyX0l47UxvDsFDUVlu1TM2sgHRyDK0OE9NNztGR3iE=.18f72e3a-1750-4f75-8827-d6f6a8bcffd4@github.com> References: <8tyX0l47UxvDsFDUVlu1TM2sgHRyDK0OE9NNztGR3iE=.18f72e3a-1750-4f75-8827-d6f6a8bcffd4@github.com> Message-ID: On Wed, 18 Sep 2024 14:16:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 32a37b26 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/32a37b2638e23841cdb3667fb5bef6d87446ad01 Stats: 76 lines in 2 files changed: 0 ins; 76 del; 0 mod 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test Backport-of: 54f09d734584a71c648520664447f8395050adbe ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2892 From goetz at openjdk.org Fri Sep 20 06:22:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 06:22:47 GMT Subject: [jdk21u-dev] Integrated: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test In-Reply-To: References: Message-ID: On Sat, 14 Sep 2024 19:13:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. > > I backport this from 23, which is clean. > It includes follow-up 8335344. This pull request has now been integrated. Changeset: 65907ffd Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/65907ffdb155221f19ce8753ce4f13b5e096c64a Stats: 403 lines in 6 files changed: 210 ins; 170 del; 23 mod 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test 8335344: test/jdk/sun/security/tools/keytool/NssTest.java fails to compile Backport-of: b2162ba41b16f1f82df873d38205c9353d9c1c24 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/976 From goetz at openjdk.org Fri Sep 20 06:24:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 06:24:37 GMT Subject: [jdk21u-dev] Integrated: 8335267: [XWayland] move screencast tokens from .awt to .java folder In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 07:22:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 44b6aca9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/44b6aca9c6cdc36f83d1d8178f66cc4e11b67b8f Stats: 61 lines in 1 file changed: 23 ins; 8 del; 30 mod 8335267: [XWayland] move screencast tokens from .awt to .java folder Backport-of: 088871ce36f85fb30b24c49146f547bc8e2b0dcb ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/986 From goetz at openjdk.org Fri Sep 20 06:24:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 06:24:45 GMT Subject: [jdk17u-dev] Integrated: 8328303: 3 JDI tests timed out with UT enabled In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 14:22:08 GMT, Goetz Lindenmaier wrote: > I backport this a prereq of 832898. This pull request has now been integrated. Changeset: 2f0a4b32 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2f0a4b328ba5088561e27283defabbeeecebd51b Stats: 97 lines in 3 files changed: 37 ins; 22 del; 38 mod 8328303: 3 JDI tests timed out with UT enabled Backport-of: bc73963974a824d77d54b8b0edbf8f05262b721c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2893 From goetz at openjdk.org Fri Sep 20 06:26:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 06:26:36 GMT Subject: [jdk17u-dev] Integrated: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 14:19:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 64e652ec Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/64e652ec90af7412a329ceec6e1217f33c4daadc Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... Backport-of: 284671a1e4fb5bfe15b20b7f41fc24415b1235ed ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2897 From goetz at openjdk.org Fri Sep 20 06:28:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 06:28:37 GMT Subject: [jdk17u-dev] Integrated: 8335267: [XWayland] move screencast tokens from .awt to .java folder In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 07:22:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: f18cde4e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f18cde4e795988dc22b00fd66713c96185c67275 Stats: 61 lines in 1 file changed: 23 ins; 8 del; 30 mod 8335267: [XWayland] move screencast tokens from .awt to .java folder Backport-of: 088871ce36f85fb30b24c49146f547bc8e2b0dcb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2889 From goetz at openjdk.org Fri Sep 20 06:40:04 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 06:40:04 GMT Subject: [jdk21u-dev] RFR: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.6-oracle. > > Resolved ProblemList, probably clean. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge head, resolve ProblemList - Backport 034297a6bd9bfcea7fa48792f54c84a6e976b319 ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/989/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=989&range=01 Stats: 16 lines in 3 files changed: 6 ins; 5 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/989.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/989/head:pull/989 PR: https://git.openjdk.org/jdk21u-dev/pull/989 From mbaesken at openjdk.org Fri Sep 20 06:49:36 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 20 Sep 2024 06:49:36 GMT Subject: [jdk21u-dev] Integrated: 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 08:22:09 GMT, Matthias Baesken wrote: > 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent This pull request has now been integrated. Changeset: b726436f Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/b726436f2ca440fcbd9b6141b32a50afc3796017 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent Backport-of: cb5c60b530dd744e7d78ef69f15eef7521c4f1cc ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/987 From duke at openjdk.org Fri Sep 20 06:53:35 2024 From: duke at openjdk.org (duke) Date: Fri, 20 Sep 2024 06:53:35 GMT Subject: [jdk23u] RFR: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException In-Reply-To: References: Message-ID: <3nKG1ZIL4B22PExQk84RpBrZAGs1kw90SAOdz7kjl8M=.41d1be79-7cb1-44ad-9445-889db618e7d1@github.com> On Tue, 17 Sep 2024 05:26:37 GMT, Nibedita Jena wrote: > Clean backport of JDK-8336240. @nibjen Your change (at version 855ca2fa93532e8c255460a69b65287fc19ed373) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/98#issuecomment-2362959554 From duke at openjdk.org Fri Sep 20 06:59:41 2024 From: duke at openjdk.org (Nibedita Jena) Date: Fri, 20 Sep 2024 06:59:41 GMT Subject: [jdk23u] Integrated: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException In-Reply-To: References: Message-ID: On Tue, 17 Sep 2024 05:26:37 GMT, Nibedita Jena wrote: > Clean backport of JDK-8336240. This pull request has now been integrated. Changeset: 3e84943e Author: nibjen Committer: Sean Coffey URL: https://git.openjdk.org/jdk23u/commit/3e84943e9bf1a0cbdc2fac669c0dd9e73760a32c Stats: 16 lines in 3 files changed: 6 ins; 5 del; 5 mod 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException Backport-of: 034297a6bd9bfcea7fa48792f54c84a6e976b319 ------------- PR: https://git.openjdk.org/jdk23u/pull/98 From mbaesken at openjdk.org Fri Sep 20 06:59:41 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 20 Sep 2024 06:59:41 GMT Subject: [jdk17u-dev] RFR: 8330621: Make 5 compiler tests use ProcessTools.executeProcess In-Reply-To: References: Message-ID: On Tue, 17 Sep 2024 17:15:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > I omitted one test that was added by "8294609: C2: Improve inlining of methods with unloaded signature classes", an enhancement in 20 we won't backport. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2884#pullrequestreview-2317425936 From goetz at openjdk.org Fri Sep 20 07:14:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 07:14:49 GMT Subject: [jdk17u-dev] RFR: 8326898: NSK tests should listen on loopback addresses only Message-ID: I backport this for parity with 17.0.14-oracle from 21u. Again had to resolve Copyrights. Probably clean. ------------- Commit messages: - Backport fee1d969f6bf8ee9981498f352b3bf6a89842086 Changes: https://git.openjdk.org/jdk17u-dev/pull/2899/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2899&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326898 Stats: 22 lines in 6 files changed: 2 ins; 0 del; 20 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2899.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2899/head:pull/2899 PR: https://git.openjdk.org/jdk17u-dev/pull/2899 From mbaesken at openjdk.org Fri Sep 20 07:29:39 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 20 Sep 2024 07:29:39 GMT Subject: [jdk17u-dev] RFR: 8296787: Unify debug printing format of X.509 cert serial numbers In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 13:48:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Patching Copyright failed in most files. Resolved. > > Further conflicts: > > src/java.base/share/classes/sun/security/provider/certpath/Vertex.java > One conflict due to diffs in the context. > > src/java.base/share/classes/sun/security/ssl/StatusResponseManager.java > Resolved because code is using append() for Strings instead of '+'. > > test/lib/jdk/test/lib/security/TestTLSHandshake.java > Resolved due to diffs in context. Backport looks okay. There might be still some place(s) where the old output is used. Is that intentional or was it forgotten to change= But not really related to the backport. E.g. src/java.base/share/classes/sun/security/tools/keytool/Main.java printX509Cert method cert.getSerialNumber().toString(16) ------------- Marked as reviewed by mbaesken (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2891#pullrequestreview-2317479147 From goetz at openjdk.org Fri Sep 20 07:33:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 07:33:08 GMT Subject: [jdk21u-dev] RFR: 8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 7d1a48807a482cd19156298ce21d9492f0d912da Changes: https://git.openjdk.org/jdk21u-dev/pull/992/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=992&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324861 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/992.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/992/head:pull/992 PR: https://git.openjdk.org/jdk21u-dev/pull/992 From mbaesken at openjdk.org Fri Sep 20 07:56:40 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 20 Sep 2024 07:56:40 GMT Subject: [jdk17u-dev] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 20:01:27 GMT, Alexey Bakhtin wrote: > The backport is almost clean. > - manual update of the copyright year for Stream.java > - manual merge of one-line change in the Http2TestServer.java file. Caused by difference in JDK-8295944 implementation for JDK17 and JDK21 > > All java/net/httpclient JTREG tests passed Is there an issue with the file end of TrailingHeadersTest.java ? Could you please check this ? Otherwise backport looks okay to me. ------------- Marked as reviewed by mbaesken (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2798#pullrequestreview-2317539716 From mbaesken at openjdk.org Fri Sep 20 07:59:03 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 20 Sep 2024 07:59:03 GMT Subject: [jdk11u-dev] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: <7tBsz-GBWANJyzFoYwKjWpa3ieXlPPmNV2AIbwk1fUU=.bf43fd0a-4c19-4cdd-9b98-3fe2b5b14e71@github.com> References: <7tBsz-GBWANJyzFoYwKjWpa3ieXlPPmNV2AIbwk1fUU=.bf43fd0a-4c19-4cdd-9b98-3fe2b5b14e71@github.com> Message-ID: On Wed, 14 Aug 2024 21:33:31 GMT, Alexey Bakhtin wrote: > Please review the backport of JDK-8296410 to 11u > > Stream.java is applied cleanly. > > BodyOutputStream.java, Http2TestServer.java, and Http2TestServerConnection.java test library classes are in another path and the package name. They are applied cleanly after updating the path to the files. > > New TrailingHeadersTest is updated: > - fixed reference to the Http2TestServer module > - fixed instanceOf pattern issue > > Added Http2TestServerConnection::addToOutputQ method required for the test functionality > > All java/net/httpclient JTREG tests passed Is there an issue with the file ending of test/jdk/java/net/httpclient/http2/TrailingHeadersTest.java ? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2909#issuecomment-2363072804 From duke at openjdk.org Fri Sep 20 08:03:54 2024 From: duke at openjdk.org (duke) Date: Fri, 20 Sep 2024 08:03:54 GMT Subject: [jdk17u-dev] Withdrawn: 8324580: SIGFPE on THP initialization on kernels < 4.10 In-Reply-To: References: Message-ID: On Fri, 26 Jul 2024 02:36:20 GMT, luwang1103 wrote: > hi @tstuefe , > > This pull request contains a backport of commit [a231706a](https://git.openjdk.org/jdk/commit/a231706a06a86abb16d0040e8ca1b76a9741a0b2) from the [master](https://github.com/openjdk/jdk) repository. > > The commit being backported was authored by Zdenek Zambersky on 15 Feb 2024. > > > When I tested jdk17-dev(3.10.0-1160.108.1.el7.x86_64 used by RHEL-7), it showed the same situation as jdk21-dev, so I Backported it . > > Thanks? This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2745 From goetz at openjdk.org Fri Sep 20 09:34:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 09:34:39 GMT Subject: [jdk17u-dev] RFR: 8295859: Update Manual Test Groups In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 09:41:18 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. Hi @luchenlin, your test results say: 2024-09-13T02:33:44.1752403Z Running test 'jtreg:test/jdk:tier1_part1' ...TEST.groups: group jdk_core_manual_no_input: file not found: java/util/zip/ZipFile/TestTooManyEntries.java ...TEST.groups: group jdk_core_manual_no_input: file not found: com/sun/net/httpserver/simpleserver/CommandLinePortNotSpecifiedTest.java ...TEST.groups: group jdk_core_manual_no_input: file not found: com/sun/net/httpserver/simpleserver/jwebserver/CommandLinePortNotSpecifiedTest.java Please remove com/sun/net/httpserver/simpleserver/CommandLinePortNotSpecifiedTest.java com/sun/net/httpserver/simpleserver/jwebserver/CommandLinePortNotSpecifiedTest.java They came with "8245095: Implementation of JEP 408: Simple Web Server" in 18 which we won't backport. I will backport 8272746 which adds TestTooManyEntries.java. Once that is pushed and merged here, the tests for this change should be passing. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2863#issuecomment-2363285733 From goetz at openjdk.org Fri Sep 20 09:35:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 09:35:37 GMT Subject: [jdk17u-dev] RFR: 8320586: update manual test/jdk/TEST.groups In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 06:49:48 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: 8295859 needs to be backported, first. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2886#issuecomment-2363287687 From duke at openjdk.org Fri Sep 20 09:53:55 2024 From: duke at openjdk.org (PAWAN CHAWDHARY) Date: Fri, 20 Sep 2024 09:53:55 GMT Subject: [jdk23u] RFR: 8337067: Test runtime/classFileParserBug/Bad_NCDFE_Msg.java won't compile Message-ID: <-dzilcI1uNQy3lv4X09ljTYjSDr3tGP_RMQ2xyn8onk=.1e044213-ffa2-45e1-ac87-3feb207fda1d@github.com> 8337067: Test runtime/classFileParserBug/Bad_NCDFE_Msg.java won't compile Reviewed-by: lfoltan ------------- Commit messages: - 8337067: Test runtime/classFileParserBug/Bad_NCDFE_Msg.java won't compile Changes: https://git.openjdk.org/jdk23u/pull/111/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=111&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337067 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/111.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/111/head:pull/111 PR: https://git.openjdk.org/jdk23u/pull/111 From goetz at openjdk.org Fri Sep 20 10:04:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 10:04:42 GMT Subject: [jdk17u-dev] RFR: 8296787: Unify debug printing format of X.509 cert serial numbers In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 13:48:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Patching Copyright failed in most files. Resolved. > > Further conflicts: > > src/java.base/share/classes/sun/security/provider/certpath/Vertex.java > One conflict due to diffs in the context. > > src/java.base/share/classes/sun/security/ssl/StatusResponseManager.java > Resolved because code is using append() for Strings instead of '+'. > > test/lib/jdk/test/lib/security/TestTLSHandshake.java > Resolved due to diffs in context. Thanks for the review. Yes, I think that needs to be fixed in head. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2891#issuecomment-2363345474 From goetz at openjdk.org Fri Sep 20 10:26:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 10:26:36 GMT Subject: [jdk17u-dev] RFR: 8327401: Some jtreg tests fail on Wayland without any tracking bug In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 06:50:18 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. > For this file test/jdk/java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java > ignored 8267374: macOS: Option+Up/Down Arrow don't traverse to beginning/end of line in JTextArea and 8157173: [macosx] java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java fails As described, onle the one files was modified by hand. 8267374 is large and comes with a CSR, so no cndidate for a backport. ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2888#pullrequestreview-2317866366 From goetz at openjdk.org Fri Sep 20 10:26:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 10:26:51 GMT Subject: [jdk17u-dev] RFR: 8272746: ZipFile can't open big file (NegativeArraySizeException) Message-ID: I would like to fix this issue in 17. ------------- Commit messages: - Backport 848b16a3f933c1cffbce93337a5d9b4e48ce4b45 Changes: https://git.openjdk.org/jdk17u-dev/pull/2900/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2900&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272746 Stats: 92 lines in 2 files changed: 92 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2900.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2900/head:pull/2900 PR: https://git.openjdk.org/jdk17u-dev/pull/2900 From aivanov at openjdk.org Fri Sep 20 10:32:06 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 20 Sep 2024 10:32:06 GMT Subject: [jdk23u] RFR: 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout Message-ID: <1lc8LA8EeW6rz6Vmf0SmYFLIXOTQ6slFGzBjLg3z0i4=.8ef80f16-2d69-43c8-b318-9c38477e1233@github.com> Backporting 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout The patch applies cleanly. > This pull request contains a backport of commit [3c22d83c](https://github.com/openjdk/jdk/commit/3c22d83c0fb9eee2e2b87e607680b96363849c16) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Ivanov on 20 Sep 2024 and was reviewed by Alexander Zvegintsev and Phil Race. ------------- Commit messages: - Backport 3c22d83c0fb9eee2e2b87e607680b96363849c16 Changes: https://git.openjdk.org/jdk23u/pull/112/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=112&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340008 Stats: 178 lines in 1 file changed: 178 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/112.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/112/head:pull/112 PR: https://git.openjdk.org/jdk23u/pull/112 From goetz at openjdk.org Fri Sep 20 10:34:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 10:34:36 GMT Subject: [jdk17u-dev] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: <5zif7nMElqUd1yc6Wc5veEHMlbJNFU6KysGWJnCdrRE=.b1171dfe-0fc8-4a8e-b0ab-527f9f2d486c@github.com> On Tue, 10 Sep 2024 23:30:52 GMT, Alexey Bakhtin wrote: >> The backport is almost clean. >> - manual update of the copyright year for Stream.java >> - manual merge of one-line change in the Http2TestServer.java file. Caused by difference in JDK-8295944 implementation for JDK17 and JDK21 >> >> All java/net/httpclient JTREG tests passed > > Please review it. > I'd like to backport this fix to correctly process trailing HEADER frames with HTTP2 endpoint Hi @alexeybakhtin good catch, I think this should even go to jdk17u. Could you please open a PR against jdk17u and label with jdk17u-critical-request? (Also, you forgot the 'u' in the label you added currently.) Same for 11 in case you want to bring it there, too. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2798#issuecomment-2363401693 From aivanov at openjdk.org Fri Sep 20 11:18:46 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 20 Sep 2024 11:18:46 GMT Subject: [jdk23u] RFR: 8340308: PassFailJFrame: Make rows default to number of lines in instructions Message-ID: Backporting 8340308: PassFailJFrame: Make rows default to number of lines in instructions The patch applies cleanly. > This pull request contains a backport of commit [d1d82400](https://github.com/openjdk/jdk/commit/d1d824008d1dc70029013820814fd03c40b4e309) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Ivanov on 19 Sep 2024 and was reviewed by Harshitha Onkar and Alexander Zvegintsev. ------------- Commit messages: - Backport d1d824008d1dc70029013820814fd03c40b4e309 Changes: https://git.openjdk.org/jdk23u/pull/113/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=113&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340308 Stats: 35 lines in 1 file changed: 34 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/113.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/113/head:pull/113 PR: https://git.openjdk.org/jdk23u/pull/113 From goetz at openjdk.org Fri Sep 20 11:48:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 11:48:50 GMT Subject: [jdk17u-dev] RFR: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 9451677daaf1184f67759c87114af3f81fa74f23 Changes: https://git.openjdk.org/jdk17u-dev/pull/2901/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2901&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326100 Stats: 13 lines in 1 file changed: 0 ins; 0 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2901.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2901/head:pull/2901 PR: https://git.openjdk.org/jdk17u-dev/pull/2901 From goetz at openjdk.org Fri Sep 20 11:49:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 11:49:10 GMT Subject: [jdk21u-dev] RFR: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 9451677daaf1184f67759c87114af3f81fa74f23 Changes: https://git.openjdk.org/jdk21u-dev/pull/993/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=993&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326100 Stats: 13 lines in 1 file changed: 0 ins; 0 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/993.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/993/head:pull/993 PR: https://git.openjdk.org/jdk21u-dev/pull/993 From goetz at openjdk.org Fri Sep 20 12:55:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 12:55:01 GMT Subject: [jdk21u-dev] RFR: 8332777: Update JCStress test suite Message-ID: <8YDCaGa0D7ORSdakAdNfQjzgdm9V7bk2ZcrDVby0FnU=.8836a704-3fcd-4299-be4e-31c9939b34f5@github.com> I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 11e926cf50c64d57b0dba095eb62c2be4a8a8f1e Changes: https://git.openjdk.org/jdk21u-dev/pull/994/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=994&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332777 Stats: 19 lines in 1 file changed: 2 ins; 6 del; 11 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/994.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/994/head:pull/994 PR: https://git.openjdk.org/jdk21u-dev/pull/994 From goetz at openjdk.org Fri Sep 20 12:55:18 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 12:55:18 GMT Subject: [jdk17u-dev] RFR: 8332777: Update JCStress test suite Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 11e926cf50c64d57b0dba095eb62c2be4a8a8f1e Changes: https://git.openjdk.org/jdk17u-dev/pull/2902/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2902&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332777 Stats: 19 lines in 1 file changed: 2 ins; 6 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2902.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2902/head:pull/2902 PR: https://git.openjdk.org/jdk17u-dev/pull/2902 From mbaesken at openjdk.org Fri Sep 20 12:56:12 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 20 Sep 2024 12:56:12 GMT Subject: [jdk17u-dev] RFR: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion Message-ID: Backport of 8338058; NULL vs nullptr , also include follow up ------------- Commit messages: - Backport 00aac4097abd3c5e6144734cfd44228bc31892fb Changes: https://git.openjdk.org/jdk17u-dev/pull/2903/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2903&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338058 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2903.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2903/head:pull/2903 PR: https://git.openjdk.org/jdk17u-dev/pull/2903 From mbaesken at openjdk.org Fri Sep 20 12:56:40 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 20 Sep 2024 12:56:40 GMT Subject: [jdk23u] RFR: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 11:02:19 GMT, Martin Doerr wrote: > Backport of [JDK-8340230](https://bugs.openjdk.org/browse/JDK-8340230). Needs manual integration because [JDK-8340012](https://bugs.openjdk.org/browse/JDK-8340012) is not in jdk23u. > Using DecodeN without CompressedOops or DecodeNKlass without CompressedClassPointers can cause errors. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk23u/pull/104#pullrequestreview-2318199581 From mdoerr at openjdk.org Fri Sep 20 13:06:35 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 20 Sep 2024 13:06:35 GMT Subject: [jdk17u-dev] RFR: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion In-Reply-To: References: Message-ID: On Fri, 20 Sep 2024 12:51:36 GMT, Matthias Baesken wrote: > Backport of 8338058; NULL vs nullptr , also include follow up JDK-8338101 LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2903#pullrequestreview-2318225945 From goetz at openjdk.org Fri Sep 20 13:19:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 13:19:19 GMT Subject: [jdk21u-dev] RFR: 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 26de9e247a6ed1c0b8b247d77514ed16905d7c48 Changes: https://git.openjdk.org/jdk21u-dev/pull/995/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=995&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321616 Stats: 1120 lines in 14 files changed: 565 ins; 283 del; 272 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/995.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/995/head:pull/995 PR: https://git.openjdk.org/jdk21u-dev/pull/995 From goetz at openjdk.org Fri Sep 20 13:20:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Sep 2024 13:20:19 GMT Subject: [jdk17u-dev] RFR: 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile Message-ID: <1wmAX0u2YBMi_EP-GgMfIwEro40hIRhp_gtnNk8AKwU=.c2eb1a89-0122-4670-b27e-f799dce94f04@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 26de9e247a6ed1c0b8b247d77514ed16905d7c48 Changes: https://git.openjdk.org/jdk17u-dev/pull/2904/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2904&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321616 Stats: 1120 lines in 14 files changed: 565 ins; 283 del; 272 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2904.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2904/head:pull/2904 PR: https://git.openjdk.org/jdk17u-dev/pull/2904 From mbaesken at openjdk.org Fri Sep 20 14:32:49 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 20 Sep 2024 14:32:49 GMT Subject: [jdk21u-dev] RFR: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings Message-ID: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings ------------- Commit messages: - Backport ac3f92b4110b05906a49c4146774fd6324c6d198 Changes: https://git.openjdk.org/jdk21u-dev/pull/996/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=996&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339731 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/996.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/996/head:pull/996 PR: https://git.openjdk.org/jdk21u-dev/pull/996 From mbaesken at openjdk.org Fri Sep 20 14:32:53 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 20 Sep 2024 14:32:53 GMT Subject: [jdk23u] RFR: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings Message-ID: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings ------------- Commit messages: - Backport ac3f92b4110b05906a49c4146774fd6324c6d198 Changes: https://git.openjdk.org/jdk23u/pull/114/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=114&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339731 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/114.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/114/head:pull/114 PR: https://git.openjdk.org/jdk23u/pull/114 From mbaesken at openjdk.org Fri Sep 20 14:50:45 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 20 Sep 2024 14:50:45 GMT Subject: [jdk17u-dev] RFR: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling Message-ID: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling ------------- Commit messages: - Backport 6a5cb0b2c49cb390ce8b87fd977ee79572df90fc Changes: https://git.openjdk.org/jdk17u-dev/pull/2905/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2905&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334567 Stats: 12 lines in 1 file changed: 5 ins; 6 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2905.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2905/head:pull/2905 PR: https://git.openjdk.org/jdk17u-dev/pull/2905 From syan at openjdk.org Fri Sep 20 15:01:36 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 20 Sep 2024 15:01:36 GMT Subject: [jdk17u-dev] RFR: 8327474: Review use of java.io.tmpdir in jdk tests In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 16:09:28 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [af6c5854](https://github.com/openjdk/jdk21u-dev/commit/af6c5854235573a29b6b418e9f759e2564bca63a) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by Goetz Lindenmaier on 22 Apr 2024 and had no reviewers. > > The backport not clean because jdk17u-dev doesn't have `test/jdk/jdk/jfr/threading/TestManyVirtualThreads.java`, all other files are backported cleanly. > Existing tests should be reviewed to check the usage of java.io.tmpdir. Test fix only, the risk is low. > > Additional testing: > > - [x] full jtreg tests on linux x64 > - [x] full jtreg tests in linux aarch64 > > > Thanks! Hi, can anyone take look tihs PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2811#issuecomment-2363932576 From wkemper at openjdk.org Fri Sep 20 15:32:36 2024 From: wkemper at openjdk.org (William Kemper) Date: Fri, 20 Sep 2024 15:32:36 GMT Subject: [jdk23u] Integrated: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate In-Reply-To: <6xic4wm6fjBouS8oZlUkftXrp8RbMnML6eATjqNDTa8=.c1bcfe88-1c66-4bff-91bd-754ef992ab36@github.com> References: <6xic4wm6fjBouS8oZlUkftXrp8RbMnML6eATjqNDTa8=.c1bcfe88-1c66-4bff-91bd-754ef992ab36@github.com> Message-ID: On Tue, 17 Sep 2024 23:26:43 GMT, William Kemper wrote: > Clean backport. This is a performance enhancement with no changes outside of Shenandoah. This pull request has now been integrated. Changeset: ac8e8da5 Author: William Kemper Committer: Paul Hohensee URL: https://git.openjdk.org/jdk23u/commit/ac8e8da546815eca5a531fe1e749ee4d7b6b51e9 Stats: 21 lines in 2 files changed: 14 ins; 0 del; 7 mod 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate Backport-of: e74edbaea9f09169f597a470f647f3b7d10cc71b ------------- PR: https://git.openjdk.org/jdk23u/pull/101 From duke at openjdk.org Fri Sep 20 15:36:48 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Fri, 20 Sep 2024 15:36:48 GMT Subject: [jdk21u-dev] Integrated: 8322166: Files.isReadable/isWritable/isExecutable expensive when file does not exist In-Reply-To: <3qaZi5FvChcLH-QQyN31nKi7NFmSRQan7gX2Kagv_PE=.5c7cf259-e94e-477f-810a-6a6131f1d029@github.com> References: <3qaZi5FvChcLH-QQyN31nKi7NFmSRQan7gX2Kagv_PE=.5c7cf259-e94e-477f-810a-6a6131f1d029@github.com> Message-ID: <2lV80UwLWpwxgsqSF0xza04JsfCoFQD1F636wOMhhb0=.c00b3b1b-b660-4a05-bd42-717b9a2045e6@github.com> On Fri, 16 Aug 2024 00:23:54 GMT, Todd V. Jonker wrote: > Clean backport of a performance fix, originally authored by @bplb and reviewed by @AlanBateman > > Test suites run on linux-x86_64-server-release: > - [x] tier1 > - [x] jdk/java/nio This pull request has now been integrated. Changeset: 816706c0 Author: Todd V. Jonker Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/816706c06daf391b61039e7b45cbf55066393f94 Stats: 126 lines in 6 files changed: 76 ins; 28 del; 22 mod 8322166: Files.isReadable/isWritable/isExecutable expensive when file does not exist Backport-of: 51be857f3cafa23eb7cd73e5fe3db17e6d01684c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/926 From abakhtin at openjdk.org Fri Sep 20 18:03:42 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 20 Sep 2024 18:03:42 GMT Subject: [jdk17u-dev] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Fri, 20 Sep 2024 07:53:34 GMT, Matthias Baesken wrote: > Is there an issue with the file end of TrailingHeadersTest.java ? Could you please check this ? Otherwise backport looks okay to me. @MBaesken , yes. there is no newline at the end of the TrailingHeadersTest.java, but it is the same as in the original commit. So, decides not to change it. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2798#issuecomment-2364251761 From aivanov at openjdk.org Fri Sep 20 18:20:52 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 20 Sep 2024 18:20:52 GMT Subject: [jdk23u] RFR: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @ Message-ID: Backporting JDK-8335789. The patch applies cleanly. > This pull request contains a backport of commit [3733fe3a](https://github.com/openjdk/jdk/commit/3733fe3a207078b585421cd2a098e808fafaa817) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by lawrence.andrews on 8 Jul 2024 and was reviewed by Alexey Ivanov. ------------- Commit messages: - Backport 3733fe3a207078b585421cd2a098e808fafaa817 Changes: https://git.openjdk.org/jdk23u/pull/115/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=115&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335789 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk23u/pull/115.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/115/head:pull/115 PR: https://git.openjdk.org/jdk23u/pull/115 From goetz at openjdk.org Sat Sep 21 08:42:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Sep 2024 08:42:35 GMT Subject: [jdk17u-dev] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Fri, 20 Sep 2024 18:00:46 GMT, Alexey Bakhtin wrote: >> Is there an issue with the file end of TrailingHeadersTest.java ? >> Could you please check this ? >> Otherwise backport looks okay to me. > >> Is there an issue with the file end of TrailingHeadersTest.java ? Could you please check this ? Otherwise backport looks okay to me. > > @MBaesken , yes. there is no newline at the end of the TrailingHeadersTest.java, but it is the same as in the original commit. So, decides not to change it. Hi @alexeybakhtin If you want to get this into the October update, you need to make a PR against repo jdk17u (jdk11u) and not jdk17u-dev. In jdk17u-dev we currently develop the January update. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2798#issuecomment-2365062887 From duke at openjdk.org Sat Sep 21 09:42:41 2024 From: duke at openjdk.org (duke) Date: Sat, 21 Sep 2024 09:42:41 GMT Subject: [jdk21u-dev] Withdrawn: 8334738: os::print_hex_dump should optionally print ASCII In-Reply-To: References: Message-ID: On Fri, 19 Jul 2024 11:38:04 GMT, Thomas Stuefe wrote: > This backports a small new feature down to jdk 21u: The ability to print ASCII portions alongside hex portions in hotspot hex dump. > > This has been very useful recently with CDS archive analysis in the context of reproducible builds (figuring out which parts of the dump make archive generation non-reproducible). Since this is very much a topic for JDK 21, I would be happy if we could backport it. > > The backport consists of two patches: > - one for [JDK-8334738](https://bugs.openjdk.org/browse/JDK-8334738) > - a small follow-up fix for Big Endian platforms: [JDK-8335906](https://bugs.openjdk.org/browse/JDK-8335906) > > Unfortunately, [JDK-8334738](https://bugs.openjdk.org/browse/JDK-8334738) does not apply cleanly to JDK 23 because of some intermediate cleanup patches that are missing from JDK21 and possibly too large to backport: > > - 8314752: Use google test string comparison macros > - 8313882: Fix -Wconversion warnings in runtime code This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/855 From sshivang at openjdk.org Sat Sep 21 12:19:51 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Sat, 21 Sep 2024 12:19:51 GMT Subject: [jdk23u] RFR: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect Message-ID: Straight Backport. Test only change. ------------- Commit messages: - Backport 21e86d10a726fe707febb0111f5b80d8d1d29f03 Changes: https://git.openjdk.org/jdk23u/pull/116/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=116&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334405 Stats: 42 lines in 1 file changed: 28 ins; 5 del; 9 mod Patch: https://git.openjdk.org/jdk23u/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/116/head:pull/116 PR: https://git.openjdk.org/jdk23u/pull/116 From phh at openjdk.org Sat Sep 21 15:02:50 2024 From: phh at openjdk.org (Paul Hohensee) Date: Sat, 21 Sep 2024 15:02:50 GMT Subject: [jdk11u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v4] In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 02:29:12 GMT, Andrew Lu wrote: >> I backport this for parity with 11.0.25-oracle. >> modify lines are different, but code is clean. > > Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'openjdk:master' into andrewLu_backport_8320675 > - fix > - fix > - Backport 9f5ad43358a4e209b4cd1c91bcc86b997f371548 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2912#pullrequestreview-2319820511 From cushon at openjdk.org Sat Sep 21 20:12:51 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Sat, 21 Sep 2024 20:12:51 GMT Subject: [jdk17u-dev] RFR: 8273914: Indy string concat changes order of operations Message-ID: This is a backport of [JDK-8273914: Indy string concat changes order of operations](https://bugs.openjdk.org/browse/JDK-8273914). The patch applied cleanly. Testing: tier1 langtools tests ------------- Commit messages: - Merge remote-tracking branch 'origin/master' into backport-JDK-8273914 - Backport cfee4512f7048e9cf440078e9eb87d37c7ebcdd9 Changes: https://git.openjdk.org/jdk17u-dev/pull/2864/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2864&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273914 Stats: 532 lines in 8 files changed: 473 ins; 20 del; 39 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2864.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2864/head:pull/2864 PR: https://git.openjdk.org/jdk17u-dev/pull/2864 From cushon at openjdk.org Sat Sep 21 20:13:08 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Sat, 21 Sep 2024 20:13:08 GMT Subject: [jdk11u-dev] RFR: 8273914: Indy string concat changes order of operations Message-ID: <48_6CiXhu6kGwSLVNcSEC9X5wi7rc6JOMY2CaEJ1yu4=.bbf55ed2-ef95-413c-a4d9-85f3b386778c@github.com> This is a backport of [JDK-8273914: Indy string concat changes order of operations](https://bugs.openjdk.org/browse/JDK-8273914). The patch applied cleanly. Testing: tier1 langtools tests ------------- Commit messages: - Backport cfee4512f7048e9cf440078e9eb87d37c7ebcdd9 Changes: https://git.openjdk.org/jdk11u-dev/pull/2933/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2933&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273914 Stats: 532 lines in 8 files changed: 473 ins; 20 del; 39 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2933.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2933/head:pull/2933 PR: https://git.openjdk.org/jdk11u-dev/pull/2933 From abakhtin at openjdk.org Sun Sep 22 05:47:29 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Sun, 22 Sep 2024 05:47:29 GMT Subject: [jdk17u] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 Message-ID: The backport is almost clean. manual update of the copyright year for Stream.java manual merge of one-line change in the Http2TestServer.java file. Caused by difference in JDK-8295944 implementation for JDK17 and JDK21 All java/net/httpclient JTREG tests passed ------------- Commit messages: - Backport f4b140b4200fc0f49161395501d3dbcba7a79059 Changes: https://git.openjdk.org/jdk17u/pull/399/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=399&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296410 Stats: 431 lines in 5 files changed: 389 ins; 14 del; 28 mod Patch: https://git.openjdk.org/jdk17u/pull/399.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/399/head:pull/399 PR: https://git.openjdk.org/jdk17u/pull/399 From abakhtin at openjdk.org Sun Sep 22 05:50:29 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Sun, 22 Sep 2024 05:50:29 GMT Subject: [jdk11u] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 Message-ID: Please review the backport of JDK-8296410 to 11u Stream.java is applied cleanly. BodyOutputStream.java, Http2TestServer.java, and Http2TestServerConnection.java test library classes are in another path and the package name. They are applied cleanly after updating the path to the files. New TrailingHeadersTest is updated: fixed reference to the Http2TestServer module fixed instanceOf pattern issue Added Http2TestServerConnection::addToOutputQ method required for the test functionality All java/net/httpclient JTREG tests passed ------------- Commit messages: - Backport f4b140b4200fc0f49161395501d3dbcba7a79059 Changes: https://git.openjdk.org/jdk11u/pull/96/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=96&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296410 Stats: 434 lines in 5 files changed: 392 ins; 14 del; 28 mod Patch: https://git.openjdk.org/jdk11u/pull/96.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/96/head:pull/96 PR: https://git.openjdk.org/jdk11u/pull/96 From abakhtin at openjdk.org Sun Sep 22 06:05:46 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Sun, 22 Sep 2024 06:05:46 GMT Subject: [jdk17u-dev] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Fri, 20 Sep 2024 18:00:46 GMT, Alexey Bakhtin wrote: >> Is there an issue with the file end of TrailingHeadersTest.java ? >> Could you please check this ? >> Otherwise backport looks okay to me. > >> Is there an issue with the file end of TrailingHeadersTest.java ? Could you please check this ? Otherwise backport looks okay to me. > > @MBaesken , yes. there is no newline at the end of the TrailingHeadersTest.java, but it is the same as in the original commit. So, decides not to change it. > Hi @alexeybakhtin If you want to get this into the October update, you need to make a PR against repo jdk17u (jdk11u) and not jdk17u-dev. In jdk17u-dev we currently develop the January update. Thanks. Thank you. Submitted new requests to jdk17u and jdk11u repos ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2798#issuecomment-2365485232 From goetz at openjdk.org Sun Sep 22 14:58:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Sep 2024 14:58:45 GMT Subject: [jdk17u-dev] Integrated: 8272746: ZipFile can't open big file (NegativeArraySizeException) In-Reply-To: References: Message-ID: <4FxI3yNAy8adG7wjrwhA6E-5M1o_S33FbYNq52SUWas=.52f5b6fd-317f-4eef-8821-311c98e96d33@github.com> On Fri, 20 Sep 2024 10:20:45 GMT, Goetz Lindenmaier wrote: > I would like to fix this issue in 17. This pull request has now been integrated. Changeset: 4120fcc8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/4120fcc88fb2d7c39fa36add290945c1d3c6aee7 Stats: 92 lines in 2 files changed: 92 ins; 0 del; 0 mod 8272746: ZipFile can't open big file (NegativeArraySizeException) Backport-of: 848b16a3f933c1cffbce93337a5d9b4e48ce4b45 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2900 From goetz at openjdk.org Sun Sep 22 15:11:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Sep 2024 15:11:45 GMT Subject: [jdk17u] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Sun, 22 Sep 2024 05:43:09 GMT, Alexey Bakhtin wrote: > The backport is almost clean. > > manual update of the copyright year for Stream.java > manual merge of one-line change in the Http2TestServer.java file. Caused by difference in JDK-8295944 implementation for JDK17 and JDK21 > All java/net/httpclient JTREG tests passed Hi @alexeybakhtin Please enable GHA testing for this repo! Also, please close 2798. This change is identical to https://github.com/openjdk/jdk17u-dev/pull/2798, approving. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/399#issuecomment-2366830152 From goetz at openjdk.org Sun Sep 22 15:27:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Sep 2024 15:27:43 GMT Subject: [jdk11u] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Sun, 22 Sep 2024 05:44:48 GMT, Alexey Bakhtin wrote: > Please review the backport of JDK-8296410 to 11u > > Stream.java is applied cleanly. > > BodyOutputStream.java, Http2TestServer.java, and Http2TestServerConnection.java test library classes are in another path and the package name. They are applied cleanly after updating the path to the files. > > New TrailingHeadersTest is updated: > > fixed reference to the Http2TestServer module > fixed instanceOf pattern issue > Added Http2TestServerConnection::addToOutputQ method required for the test functionality > > All java/net/httpclient JTREG tests passed GHA failures: well known build problems with snprintf on mac. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/96#issuecomment-2366837031 From goetz at openjdk.org Sun Sep 22 15:36:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Sep 2024 15:36:37 GMT Subject: [jdk11u] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Sun, 22 Sep 2024 05:44:48 GMT, Alexey Bakhtin wrote: > Please review the backport of JDK-8296410 to 11u > > Stream.java is applied cleanly. > > BodyOutputStream.java, Http2TestServer.java, and Http2TestServerConnection.java test library classes are in another path and the package name. They are applied cleanly after updating the path to the files. > > New TrailingHeadersTest is updated: > > fixed reference to the Http2TestServer module > fixed instanceOf pattern issue > Added Http2TestServerConnection::addToOutputQ method required for the test functionality > > All java/net/httpclient JTREG tests passed This is identical to the change proposed to 11u-dev. The test well reproduces the issue, with the fix applied the test passes. I'll run this though SAPs testing tonight. The line end at the end of TrailingHeadersTest.java is also missing in earlier releases. Somehow Github shows the (-) in the PR but not in the commmit to jdk. ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk11u/pull/96#pullrequestreview-2320877558 From goetz at openjdk.org Sun Sep 22 15:38:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Sep 2024 15:38:48 GMT Subject: [jdk17u-dev] RFR: 8295859: Update Manual Test Groups In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 09:41:18 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. Hi @luchenlin I pushed 8272746, so you can now proceed with this. See above. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2863#issuecomment-2366842233 From abakhtin at openjdk.org Sun Sep 22 17:02:39 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Sun, 22 Sep 2024 17:02:39 GMT Subject: [jdk17u-dev] Withdrawn: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 20:01:27 GMT, Alexey Bakhtin wrote: > The backport is almost clean. > - manual update of the copyright year for Stream.java > - manual merge of one-line change in the Http2TestServer.java file. Caused by difference in JDK-8295944 implementation for JDK17 and JDK21 > > All java/net/httpclient JTREG tests passed This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2798 From abakhtin at openjdk.org Sun Sep 22 17:06:11 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Sun, 22 Sep 2024 17:06:11 GMT Subject: [jdk17u-dev] RFR: 8307648: java/net/httpclient/ExpectContinueTest.java timed out [v2] In-Reply-To: <7b2Q9_wuaiyAuPzTbGcsHBJFBeZdM0fK1cq6zjJpjgQ=.04ca936f-2ef2-485b-bc00-ac48829ab2d6@github.com> References: <7b2Q9_wuaiyAuPzTbGcsHBJFBeZdM0fK1cq6zjJpjgQ=.04ca936f-2ef2-485b-bc00-ac48829ab2d6@github.com> Message-ID: > The backport is not clean. > > JDK17 does not have JDK-8293786. As a result, the debug log is not merged into Stream::incoming_reset method. These changes could be skipped because they are not required for this functionality > > Also, ExpectContinueTest test was added in JDK21 as part of JDK-8286171. Not backported to JDK17. The changes for this test are skipped > > All java/net/httpclient JTREG tests passed Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2799/files - new: https://git.openjdk.org/jdk17u-dev/pull/2799/files/1f255128..1f255128 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2799&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2799&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2799.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2799/head:pull/2799 PR: https://git.openjdk.org/jdk17u-dev/pull/2799 From abakhtin at openjdk.org Sun Sep 22 17:09:47 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Sun, 22 Sep 2024 17:09:47 GMT Subject: [jdk11u-dev] Withdrawn: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: <7tBsz-GBWANJyzFoYwKjWpa3ieXlPPmNV2AIbwk1fUU=.bf43fd0a-4c19-4cdd-9b98-3fe2b5b14e71@github.com> References: <7tBsz-GBWANJyzFoYwKjWpa3ieXlPPmNV2AIbwk1fUU=.bf43fd0a-4c19-4cdd-9b98-3fe2b5b14e71@github.com> Message-ID: On Wed, 14 Aug 2024 21:33:31 GMT, Alexey Bakhtin wrote: > Please review the backport of JDK-8296410 to 11u > > Stream.java is applied cleanly. > > BodyOutputStream.java, Http2TestServer.java, and Http2TestServerConnection.java test library classes are in another path and the package name. They are applied cleanly after updating the path to the files. > > New TrailingHeadersTest is updated: > - fixed reference to the Http2TestServer module > - fixed instanceOf pattern issue > > Added Http2TestServerConnection::addToOutputQ method required for the test functionality > > All java/net/httpclient JTREG tests passed This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2909 From andrewlu at openjdk.org Mon Sep 23 02:10:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 23 Sep 2024 02:10:40 GMT Subject: [jdk17u-dev] Integrated: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList In-Reply-To: References: Message-ID: On Fri, 13 Sep 2024 06:43:23 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 2ca2c2c0 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/2ca2c2c03cc26e3cc530b5baabc28a1bc987423d Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList Backport-of: 2b5aec2aad3883d4d407ec3a572f78755d60190d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2871 From andrewlu at openjdk.org Mon Sep 23 02:10:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 23 Sep 2024 02:10:40 GMT Subject: [jdk21u-dev] Integrated: 8320586: update manual test/jdk/TEST.groups In-Reply-To: <42IrZ3ReM4q4s5dxnxGWxTFP_B2nhecmWV6AWXc2z6I=.7a09beba-261e-4ef9-a192-18d274c4a47c@github.com> References: <42IrZ3ReM4q4s5dxnxGWxTFP_B2nhecmWV6AWXc2z6I=.7a09beba-261e-4ef9-a192-18d274c4a47c@github.com> Message-ID: On Wed, 18 Sep 2024 06:49:14 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 0a7aa3d2 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/0a7aa3d2d4d26aa706c253759cbc4eb1d1d92cca Stats: 10 lines in 1 file changed: 5 ins; 2 del; 3 mod 8320586: update manual test/jdk/TEST.groups Backport-of: 99b9cb0a2eae1196f2127cd48e4085f19a90c4b4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/985 From lmao at openjdk.org Mon Sep 23 03:48:20 2024 From: lmao at openjdk.org (Liang Mao) Date: Mon, 23 Sep 2024 03:48:20 GMT Subject: [jdk23u] RFR: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass Message-ID: Backport of concurrent GC crash due to GetMethodDeclaringClass. The backport is not clean because of make file. ------------- Commit messages: - Backport c91fa278fe17ab204beef0fcef1ada6dd0bc37bb Changes: https://git.openjdk.org/jdk23u/pull/117/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=117&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339725 Stats: 244 lines in 5 files changed: 241 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk23u/pull/117.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/117/head:pull/117 PR: https://git.openjdk.org/jdk23u/pull/117 From andrewlu at openjdk.org Mon Sep 23 05:58:10 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 23 Sep 2024 05:58:10 GMT Subject: [jdk17u-dev] RFR: 8295859: Update Manual Test Groups [v2] In-Reply-To: References: Message-ID: <9HRKryRLdRrBVZenOfrbuE4462A6xX2_tL2CiX_-w-U=.bc601bb9-cb5e-4471-b121-8d1d2a5dfbe0@github.com> > I backport this for parity with 17.0.14-oracle. > As GoeLin saied, > com/sun/net/httpserver/simpleserver/CommandLinePortNotSpecifiedTest.java > com/sun/net/httpserver/simpleserver/jwebserver/CommandLinePortNotSpecifiedTest.java > They came with "8245095: Implementation of JEP 408: Simple Web Server" in 18 > which we won't backport. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into andrewLu_backport_8295859 - remove com/sun/net/httpserver/simpleserver/CommandLinePortNotSpecifiedTest.java com/sun/net/httpserver/simpleserver/jwebserver/CommandLinePortNotSpecifiedTest.java - Backport 87017b5199522bb26f0225b60fbbc00df255ad2a ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2863/files - new: https://git.openjdk.org/jdk17u-dev/pull/2863/files/3ffc2075..3565f6fb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2863&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2863&range=00-01 Stats: 9727 lines in 131 files changed: 4565 ins; 4474 del; 688 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2863.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2863/head:pull/2863 PR: https://git.openjdk.org/jdk17u-dev/pull/2863 From goetz at openjdk.org Mon Sep 23 06:04:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:04:43 GMT Subject: [jdk11u] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Sun, 22 Sep 2024 05:44:48 GMT, Alexey Bakhtin wrote: > Please review the backport of JDK-8296410 to 11u > > Stream.java is applied cleanly. > > BodyOutputStream.java, Http2TestServer.java, and Http2TestServerConnection.java test library classes are in another path and the package name. They are applied cleanly after updating the path to the files. > > New TrailingHeadersTest is updated: > > fixed reference to the Http2TestServer module > fixed instanceOf pattern issue > Added Http2TestServerConnection::addToOutputQ method required for the test functionality > > All java/net/httpclient JTREG tests passed SAP''s testing passed, which includes tests of mac. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/96#issuecomment-2367295669 From goetz at openjdk.org Mon Sep 23 06:23:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:23:46 GMT Subject: [jdk21u-dev] Integrated: 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile In-Reply-To: References: Message-ID: <-yefAmxPMgmcbvDnQAdc7LzMcSmp8hOHTrEqvI-i3UM=.0ef0905b-76da-47bd-8e6c-ed3340b5f212@github.com> On Fri, 20 Sep 2024 13:13:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: ad783847 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/ad783847901a3fac685bf371876cb7c593283243 Stats: 1120 lines in 14 files changed: 565 ins; 283 del; 272 mod 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile 8322830: Add test case for ZipFile opening a ZIP with no entries Backport-of: 26de9e247a6ed1c0b8b247d77514ed16905d7c48 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/995 From goetz at openjdk.org Mon Sep 23 06:35:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:35:39 GMT Subject: [jdk21u-dev] Integrated: 8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark In-Reply-To: References: Message-ID: On Fri, 20 Sep 2024 07:27:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 1dd7b657 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/1dd7b657a313dc2b41bf0042ee819a8fefcbaf1b Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark Backport-of: 7d1a48807a482cd19156298ce21d9492f0d912da ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/992 From goetz at openjdk.org Mon Sep 23 06:36:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:36:41 GMT Subject: [jdk17u-dev] Integrated: 8296787: Unify debug printing format of X.509 cert serial numbers In-Reply-To: References: Message-ID: <5QnBGV1zlJzkJU_eHVrSCfPbjCsRJ9IYMDwQVd4In8s=.f97946fe-0c9b-4bc7-80b7-93bb1dbb6055@github.com> On Wed, 18 Sep 2024 13:48:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Patching Copyright failed in most files. Resolved. > > Further conflicts: > > src/java.base/share/classes/sun/security/provider/certpath/Vertex.java > One conflict due to diffs in the context. > > src/java.base/share/classes/sun/security/ssl/StatusResponseManager.java > Resolved because code is using append() for Strings instead of '+'. > > test/lib/jdk/test/lib/security/TestTLSHandshake.java > Resolved due to diffs in context. This pull request has now been integrated. Changeset: d7d492b7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/d7d492b73ba1b1fdd447f80f67598ecfe4992b36 Stats: 65 lines in 18 files changed: 19 ins; 3 del; 43 mod 8296787: Unify debug printing format of X.509 cert serial numbers Reviewed-by: mbaesken Backport-of: c328f9589ddc3a981a2c63801bd991f8e593e69f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2891 From goetz at openjdk.org Mon Sep 23 06:36:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:36:49 GMT Subject: [jdk17u-dev] Integrated: 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile In-Reply-To: <1wmAX0u2YBMi_EP-GgMfIwEro40hIRhp_gtnNk8AKwU=.c2eb1a89-0122-4670-b27e-f799dce94f04@github.com> References: <1wmAX0u2YBMi_EP-GgMfIwEro40hIRhp_gtnNk8AKwU=.c2eb1a89-0122-4670-b27e-f799dce94f04@github.com> Message-ID: On Fri, 20 Sep 2024 13:13:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 1dcecb37 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/1dcecb3744d0e0439ac721fec1540420cb230239 Stats: 1120 lines in 14 files changed: 565 ins; 283 del; 272 mod 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile 8322830: Add test case for ZipFile opening a ZIP with no entries Backport-of: 26de9e247a6ed1c0b8b247d77514ed16905d7c48 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2904 From goetz at openjdk.org Mon Sep 23 06:38:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:38:44 GMT Subject: [jdk21u-dev] Integrated: 8318105: [jmh] the test java.security.HSS failed with 2 active threads In-Reply-To: <7AIwIBUErt-PLhNwX9lg6Blm4cRcsy-Xv_l9zfraACQ=.b3bd79e2-5c2e-48cc-bd73-b008c9647004@github.com> References: <7AIwIBUErt-PLhNwX9lg6Blm4cRcsy-Xv_l9zfraACQ=.b3bd79e2-5c2e-48cc-bd73-b008c9647004@github.com> Message-ID: On Thu, 19 Sep 2024 13:27:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: afb6047e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/afb6047e002e8d078639a358f0281a7ba0709b5e Stats: 224 lines in 1 file changed: 171 ins; 38 del; 15 mod 8318105: [jmh] the test java.security.HSS failed with 2 active threads Backport-of: 38c01971ff1c440d8c7ef4bc3432e5b9797ae708 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/990 From goetz at openjdk.org Mon Sep 23 06:40:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:40:35 GMT Subject: [jdk21u-dev] Integrated: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut In-Reply-To: References: Message-ID: On Fri, 20 Sep 2024 11:42:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 7d52b717 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/7d52b717c963488ae7e4802098376c93047e36cd Stats: 13 lines in 1 file changed: 0 ins; 0 del; 13 mod 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut Backport-of: 9451677daaf1184f67759c87114af3f81fa74f23 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/993 From mbaesken at openjdk.org Mon Sep 23 06:44:50 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 23 Sep 2024 06:44:50 GMT Subject: [jdk17u] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Sun, 22 Sep 2024 05:43:09 GMT, Alexey Bakhtin wrote: > The backport is almost clean. > > manual update of the copyright year for Stream.java > manual merge of one-line change in the Http2TestServer.java file. Caused by difference in JDK-8295944 implementation for JDK17 and JDK21 > All java/net/httpclient JTREG tests passed Seems to be still something wrong with file ending of TrailingHeadersTest.java . ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/399#issuecomment-2367344871 From goetz at openjdk.org Mon Sep 23 06:46:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:46:38 GMT Subject: [jdk21u-dev] Integrated: 8332777: Update JCStress test suite In-Reply-To: <8YDCaGa0D7ORSdakAdNfQjzgdm9V7bk2ZcrDVby0FnU=.8836a704-3fcd-4299-be4e-31c9939b34f5@github.com> References: <8YDCaGa0D7ORSdakAdNfQjzgdm9V7bk2ZcrDVby0FnU=.8836a704-3fcd-4299-be4e-31c9939b34f5@github.com> Message-ID: On Fri, 20 Sep 2024 12:49:27 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 76fde39d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/76fde39db8781859d0e24eba7da321a8bffdc1b2 Stats: 19 lines in 1 file changed: 2 ins; 6 del; 11 mod 8332777: Update JCStress test suite Backport-of: 11e926cf50c64d57b0dba095eb62c2be4a8a8f1e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/994 From goetz at openjdk.org Mon Sep 23 06:46:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:46:47 GMT Subject: [jdk17u-dev] Integrated: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut In-Reply-To: References: Message-ID: <3iDobrEGKamT4TFp03SA9PAmuGrE3jxdAFIr2ClZCqA=.a9b6ed7c-f0f9-466f-812e-636fc7202175@github.com> On Fri, 20 Sep 2024 11:43:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 8f5f8f31 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/8f5f8f31b9e5eb80df8ef14abbbfa46c39b68747 Stats: 13 lines in 1 file changed: 0 ins; 0 del; 13 mod 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut Backport-of: 9451677daaf1184f67759c87114af3f81fa74f23 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2901 From goetz at openjdk.org Mon Sep 23 06:47:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:47:17 GMT Subject: [jdk21u-dev] RFR: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless. [v2] In-Reply-To: References: Message-ID: <9AIN5r20L-ey4giPzhCar0RoT2yhtv-y41Qx8pu6DJM=.93cc4566-d242-49a8-8c27-d90b7445593f@github.com> > I backport this for parity with 21.0.6-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-GoeLin-2b4a4b7b-master - Backport 2b4a4b7bd84806f997adc107abbd4351425e8d1d ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/991/files - new: https://git.openjdk.org/jdk21u-dev/pull/991/files/71001ebd..f04b0763 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=991&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=991&range=00-01 Stats: 1993 lines in 37 files changed: 1065 ins; 533 del; 395 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/991.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/991/head:pull/991 PR: https://git.openjdk.org/jdk21u-dev/pull/991 From goetz at openjdk.org Mon Sep 23 06:47:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:47:17 GMT Subject: [jdk21u-dev] RFR: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless. In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 14:08:50 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. GHA: artifact download failes. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/991#issuecomment-2367343797 From goetz at openjdk.org Mon Sep 23 06:50:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:50:45 GMT Subject: [jdk17u-dev] Integrated: 8326898: NSK tests should listen on loopback addresses only In-Reply-To: References: Message-ID: On Fri, 20 Sep 2024 07:09:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle from 21u. > > Again had to resolve Copyrights. Probably clean. This pull request has now been integrated. Changeset: f75765ab Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f75765aba84048e6a7a5b36b5f724fc1e60b2a2d Stats: 22 lines in 6 files changed: 2 ins; 0 del; 20 mod 8326898: NSK tests should listen on loopback addresses only Backport-of: fee1d969f6bf8ee9981498f352b3bf6a89842086 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2899 From goetz at openjdk.org Mon Sep 23 06:50:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:50:45 GMT Subject: [jdk17u-dev] Integrated: 8328957: Update PKCS11Test.java to not use hardcoded path In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 14:35:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 9def563b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9def563b0bfd7092f0ab01d55a94a6608f51de2d Stats: 37 lines in 1 file changed: 11 ins; 9 del; 17 mod 8328957: Update PKCS11Test.java to not use hardcoded path Backport-of: 16576b87b7267aaa99c41f77993287e3479577aa ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2894 From mbaesken at openjdk.org Mon Sep 23 06:51:48 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 23 Sep 2024 06:51:48 GMT Subject: [jdk17u] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Sun, 22 Sep 2024 05:43:09 GMT, Alexey Bakhtin wrote: > The backport is almost clean. > > manual update of the copyright year for Stream.java > manual merge of one-line change in the Http2TestServer.java file. Caused by difference in JDK-8295944 implementation for JDK17 and JDK21 > All java/net/httpclient JTREG tests passed Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u/pull/399#pullrequestreview-2321245829 From goetz at openjdk.org Mon Sep 23 06:51:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:51:48 GMT Subject: [jdk17u] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: <3OMS1zXhd-VmOIVFVOcu95keowrBQ-KaD7-DP1FqTKw=.3d746ac1-cf6f-4f63-9fab-f9852e72be8b@github.com> On Sun, 22 Sep 2024 05:43:09 GMT, Alexey Bakhtin wrote: > The backport is almost clean. > > manual update of the copyright year for Stream.java > manual merge of one-line change in the Http2TestServer.java file. Caused by difference in JDK-8295944 implementation for JDK17 and JDK21 > All java/net/httpclient JTREG tests passed Hi @mbaesken, please have a look at the file in a repo of 21 or head. The file ending is missing, there, too. So it is a correct clean backport as-is. Ready to go. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/399#issuecomment-2367352346 From mbaesken at openjdk.org Mon Sep 23 06:51:48 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 23 Sep 2024 06:51:48 GMT Subject: [jdk17u] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 06:42:15 GMT, Matthias Baesken wrote: >> The backport is almost clean. >> >> manual update of the copyright year for Stream.java >> manual merge of one-line change in the Http2TestServer.java file. Caused by difference in JDK-8295944 implementation for JDK17 and JDK21 >> All java/net/httpclient JTREG tests passed > > Seems to be still something wrong with file ending of TrailingHeadersTest.java . > Hi @MBaesken, please have a look at the file in a repo of 21 or head. The file ending is missing, there, too. So it is a correct clean backport as-is. Ready to go. Yeah you are correct I just checked it and found out the same ! ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/399#issuecomment-2367354638 From goetz at openjdk.org Mon Sep 23 06:52:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:52:47 GMT Subject: [jdk17u-dev] Integrated: 8330621: Make 5 compiler tests use ProcessTools.executeProcess In-Reply-To: References: Message-ID: On Tue, 17 Sep 2024 17:15:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > I omitted one test that was added by "8294609: C2: Improve inlining of methods with unloaded signature classes", an enhancement in 20 we won't backport. This pull request has now been integrated. Changeset: 08b9698b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/08b9698bc0d897d47047317cc058f4079ee087e5 Stats: 19 lines in 4 files changed: 4 ins; 4 del; 11 mod 8330621: Make 5 compiler tests use ProcessTools.executeProcess Reviewed-by: mbaesken Backport-of: 5394f57f002c066021d811382a336253ae9f2014 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2884 From goetz at openjdk.org Mon Sep 23 06:54:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:54:37 GMT Subject: [jdk17u-dev] Integrated: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless. In-Reply-To: <9vn7TnW8s9-ZRBb_j5Vw5pH6LbkkRwLcksCByorH6x4=.dde46962-3594-4da4-85d6-cb99f938ca39@github.com> References: <9vn7TnW8s9-ZRBb_j5Vw5pH6LbkkRwLcksCByorH6x4=.dde46962-3594-4da4-85d6-cb99f938ca39@github.com> Message-ID: On Thu, 19 Sep 2024 14:08:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 92c24656 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/92c24656bc6e2cefbba75b2f0090772ece6f02a2 Stats: 8 lines in 2 files changed: 4 ins; 2 del; 2 mod 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless. Backport-of: 2b4a4b7bd84806f997adc107abbd4351425e8d1d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2896 From goetz at openjdk.org Mon Sep 23 06:57:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 06:57:39 GMT Subject: [jdk17u-dev] Integrated: 8332777: Update JCStress test suite In-Reply-To: References: Message-ID: On Fri, 20 Sep 2024 12:49:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 4f32fcaf Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/4f32fcafd8d237860acd67fc2d8767799b275fe6 Stats: 19 lines in 1 file changed: 2 ins; 6 del; 11 mod 8332777: Update JCStress test suite Backport-of: 11e926cf50c64d57b0dba095eb62c2be4a8a8f1e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2902 From goetz at openjdk.org Mon Sep 23 07:19:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 07:19:57 GMT Subject: [jdk21u-dev] RFR: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.6-oracle. > > > This depends on [JDK-8320586](https://bugs.openjdk.org/browse/JDK-8320586), will wait until that is pushed. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into goetz_backport_8335172 - Backport a5c2d7b305407974b3f67c48b8dcb1f8e77abde3 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/972/files - new: https://git.openjdk.org/jdk21u-dev/pull/972/files/886922e9..f600848a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=972&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=972&range=00-01 Stats: 3484 lines in 103 files changed: 2152 ins; 696 del; 636 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/972.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/972/head:pull/972 PR: https://git.openjdk.org/jdk21u-dev/pull/972 From goetz at openjdk.org Mon Sep 23 07:36:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 07:36:17 GMT Subject: [jdk21u-dev] RFR: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test [v3] In-Reply-To: References: Message-ID: <2OYV1FKV-UGJs2GBRr8F9VJrjcZ8GbuvG6qyTt6LM1E=.d95b2e1b-48aa-4453-a950-f1aa0db08cab@github.com> > I backport this for parity with 21.0.6-oracle. > > > This depends on [JDK-8320586](https://bugs.openjdk.org/browse/JDK-8320586), will wait until that is pushed. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Fix after Merge ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/972/files - new: https://git.openjdk.org/jdk21u-dev/pull/972/files/f600848a..76eb18fa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=972&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=972&range=01-02 Stats: 4 lines in 2 files changed: 2 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/972.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/972/head:pull/972 PR: https://git.openjdk.org/jdk21u-dev/pull/972 From goetz at openjdk.org Mon Sep 23 07:41:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 07:41:15 GMT Subject: [jdk21u-dev] RFR: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test [v4] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.6-oracle. > > > This depends on [JDK-8320586](https://bugs.openjdk.org/browse/JDK-8320586), will wait until that is pushed. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Fix after Merge ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/972/files - new: https://git.openjdk.org/jdk21u-dev/pull/972/files/76eb18fa..096cc3b4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=972&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=972&range=02-03 Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/972.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/972/head:pull/972 PR: https://git.openjdk.org/jdk21u-dev/pull/972 From goetz at openjdk.org Mon Sep 23 07:42:04 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 07:42:04 GMT Subject: [jdk21u-dev] RFR: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.6-oracle. > > Resolved ProblemList, probably clean. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'openjdk:master' into goetz_backport_8336240 - Merge head, resolve ProblemList - Backport 034297a6bd9bfcea7fa48792f54c84a6e976b319 ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/989/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=989&range=02 Stats: 16 lines in 3 files changed: 6 ins; 5 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/989.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/989/head:pull/989 PR: https://git.openjdk.org/jdk21u-dev/pull/989 From goetz at openjdk.org Mon Sep 23 08:11:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 08:11:09 GMT Subject: [jdk21u-dev] RFR: 8309218: java/util/concurrent/locks/Lock/OOMEInAQS.java still times out with ZGC, Generational ZGC, and SerialGC Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport b86c3b7a68335d57699ea3c5ec6d09a62ea9026a Changes: https://git.openjdk.org/jdk21u-dev/pull/997/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=997&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309218 Stats: 8 lines in 3 files changed: 1 ins; 3 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/997.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/997/head:pull/997 PR: https://git.openjdk.org/jdk21u-dev/pull/997 From goetz at openjdk.org Mon Sep 23 08:16:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 08:16:11 GMT Subject: [jdk21u-dev] RFR: 8325399: Add tests for virtual threads doing Selector operations Message-ID: <97vtJnpD9AyzcIQde9AQv5ILw_mA-EEkvymNMo02yPc=.0895bc01-f101-42e7-b218-581761be0231@github.com> I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 43089bf0065ce85681724d92d26709f4e3ad28ea Changes: https://git.openjdk.org/jdk21u-dev/pull/998/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=998&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325399 Stats: 349 lines in 1 file changed: 349 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/998.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/998/head:pull/998 PR: https://git.openjdk.org/jdk21u-dev/pull/998 From goetz at openjdk.org Mon Sep 23 08:19:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 08:19:49 GMT Subject: [jdk21u-dev] RFR: 8335530: Java file extension missing in AuthenticatorTest Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport a537e87d2d2c6bff63f63bb436e3e919740221ce Changes: https://git.openjdk.org/jdk21u-dev/pull/999/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=999&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335530 Stats: 120 lines in 2 files changed: 60 ins; 60 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/999.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/999/head:pull/999 PR: https://git.openjdk.org/jdk21u-dev/pull/999 From goetz at openjdk.org Mon Sep 23 08:24:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 08:24:44 GMT Subject: [jdk17u-dev] RFR: 8295859: Update Manual Test Groups [v2] In-Reply-To: <9HRKryRLdRrBVZenOfrbuE4462A6xX2_tL2CiX_-w-U=.bc601bb9-cb5e-4471-b121-8d1d2a5dfbe0@github.com> References: <9HRKryRLdRrBVZenOfrbuE4462A6xX2_tL2CiX_-w-U=.bc601bb9-cb5e-4471-b121-8d1d2a5dfbe0@github.com> Message-ID: On Mon, 23 Sep 2024 05:58:10 GMT, Andrew Lu wrote: >> I backport this for parity with 17.0.14-oracle. >> As GoeLin saied, >> com/sun/net/httpserver/simpleserver/CommandLinePortNotSpecifiedTest.java >> com/sun/net/httpserver/simpleserver/jwebserver/CommandLinePortNotSpecifiedTest.java >> They came with "8245095: Implementation of JEP 408: Simple Web Server" in 18 >> which we won't backport. > > Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into andrewLu_backport_8295859 > - remove > com/sun/net/httpserver/simpleserver/CommandLinePortNotSpecifiedTest.java > com/sun/net/httpserver/simpleserver/jwebserver/CommandLinePortNotSpecifiedTest.java > - Backport 87017b5199522bb26f0225b60fbbc00df255ad2a LGTM, tests passing now. ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2863#pullrequestreview-2321458925 From amitkumar at openjdk.org Mon Sep 23 08:54:42 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 23 Sep 2024 08:54:42 GMT Subject: [jdk21u-dev] Integrated: 8339416: [s390x] Provide implementation for resolve_global_jobject In-Reply-To: <-Q6Ek2B5P7QgpkQXpWGSisXft_tJBfNX0bxVRvd2QOo=.2adacd2d-412b-4cfd-9bf3-0f1271bc7cfd@github.com> References: <-Q6Ek2B5P7QgpkQXpWGSisXft_tJBfNX0bxVRvd2QOo=.2adacd2d-412b-4cfd-9bf3-0f1271bc7cfd@github.com> Message-ID: <7-KsSvg72AEOz6Y2ADOk1UewKOLy-16dY-0FsDuWfOs=.5c310d60-4a38-40d0-9dbd-289d20571ed3@github.com> On Thu, 19 Sep 2024 06:12:34 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [ac58b610](https://github.com/openjdk/jdk/commit/ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 19 Sep 2024 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! This pull request has now been integrated. Changeset: a5e7c327 Author: Amit Kumar Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/a5e7c3277d5eb4ce5f3053867b32b3d974f8ceef Stats: 81 lines in 6 files changed: 70 ins; 4 del; 7 mod 8339416: [s390x] Provide implementation for resolve_global_jobject Backport-of: ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/988 From goetz at openjdk.org Mon Sep 23 09:26:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 09:26:37 GMT Subject: [jdk21u-dev] Integrated: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless. In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 14:08:50 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 87aa1dd2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/87aa1dd2299b22cdd572569527918b7fbcd3ff71 Stats: 8 lines in 2 files changed: 4 ins; 2 del; 2 mod 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless. Backport-of: 2b4a4b7bd84806f997adc107abbd4351425e8d1d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/991 From goetz at openjdk.org Mon Sep 23 09:48:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 09:48:52 GMT Subject: [jdk17u-dev] RFR: 8284874: Add comment to ProcessHandle/OnExitTest to describe zombie problem Message-ID: I am backporting this to simplify follow-up backports. Comment only, harmless. ------------- Commit messages: - Backport bb7c97bddfe88cb3261706f5e272fd0418e5238c Changes: https://git.openjdk.org/jdk17u-dev/pull/2906/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2906&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284874 Stats: 19 lines in 1 file changed: 18 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2906.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2906/head:pull/2906 PR: https://git.openjdk.org/jdk17u-dev/pull/2906 From goetz at openjdk.org Mon Sep 23 10:00:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 10:00:48 GMT Subject: [jdk17u-dev] RFR: 8319574: Exec/process tests should be marked as flagless Message-ID: I backport this for parity with 17.0.14-oracle. Omitted test/jdk/java/lang/ProcessBuilder/ProcessStartLoggingTest.java. That came with "8303392: Runtime.exec and ProcessBuilder.start should use System logger" which is not a candidate for backport. Omitted test/jdk/java/lang/RuntimeTests/RuntimeExitLogTest.java. That came with "8301627: System.exit and Runtime.exit debug logging" which is not a candidate for backport. ------------- Commit messages: - Backport 68110b7a82ae82e2485aec23aba5406d2a5c0327 Changes: https://git.openjdk.org/jdk17u-dev/pull/2907/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2907&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319574 Stats: 20 lines in 12 files changed: 11 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2907.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2907/head:pull/2907 PR: https://git.openjdk.org/jdk17u-dev/pull/2907 From goetz at openjdk.org Mon Sep 23 10:22:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 10:22:53 GMT Subject: [jdk17u-dev] RFR: 8335530: Java file extension missing in AuthenticatorTest Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport a537e87d2d2c6bff63f63bb436e3e919740221ce Changes: https://git.openjdk.org/jdk17u-dev/pull/2908/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2908&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335530 Stats: 120 lines in 2 files changed: 60 ins; 60 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2908.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2908/head:pull/2908 PR: https://git.openjdk.org/jdk17u-dev/pull/2908 From goetz at openjdk.org Mon Sep 23 10:30:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Sep 2024 10:30:01 GMT Subject: [jdk17u-dev] RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 330e520c1d42d3a9f3e187873dcd8ed7fd561aaf Changes: https://git.openjdk.org/jdk17u-dev/pull/2909/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2909&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8028127 Stats: 96 lines in 1 file changed: 60 ins; 5 del; 31 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2909.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2909/head:pull/2909 PR: https://git.openjdk.org/jdk17u-dev/pull/2909 From mbaesken at openjdk.org Mon Sep 23 10:51:42 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 23 Sep 2024 10:51:42 GMT Subject: [jdk17u-dev] Integrated: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion In-Reply-To: References: Message-ID: On Fri, 20 Sep 2024 12:51:36 GMT, Matthias Baesken wrote: > Backport of 8338058; NULL vs nullptr , also include follow up JDK-8338101 This pull request has now been integrated. Changeset: 5b948954 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/5b9489546b50ec18dcfaf21caa8fb37c48eb7c3f Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058 Reviewed-by: mdoerr Backport-of: 00aac4097abd3c5e6144734cfd44228bc31892fb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2903 From mbaesken at openjdk.org Mon Sep 23 11:01:35 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 23 Sep 2024 11:01:35 GMT Subject: [jdk11u-dev] RFR: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion Message-ID: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion ------------- Commit messages: - Backport 5b9489546b50ec18dcfaf21caa8fb37c48eb7c3f Changes: https://git.openjdk.org/jdk11u-dev/pull/2939/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2939&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338058 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2939.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2939/head:pull/2939 PR: https://git.openjdk.org/jdk11u-dev/pull/2939 From mbaesken at openjdk.org Mon Sep 23 11:08:37 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 23 Sep 2024 11:08:37 GMT Subject: [jdk17u-dev] Integrated: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling In-Reply-To: References: Message-ID: <-a0dpW06j9tAVZcZKqDRLl0K9__LPAfRKXID1-EONEE=.5bc6aad5-1d14-4bd9-96a8-1d978d29624e@github.com> On Fri, 20 Sep 2024 14:46:06 GMT, Matthias Baesken wrote: > 8334567: [test] runtime/os/TestTracePageSizes move ppc handling This pull request has now been integrated. Changeset: 20bd36c3 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/20bd36c33824ddeac90681ea49af4cd073166c47 Stats: 12 lines in 1 file changed: 5 ins; 6 del; 1 mod 8334567: [test] runtime/os/TestTracePageSizes move ppc handling Backport-of: 6a5cb0b2c49cb390ce8b87fd977ee79572df90fc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2905 From mbaesken at openjdk.org Mon Sep 23 11:34:41 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 23 Sep 2024 11:34:41 GMT Subject: [jdk23u] Integrated: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings In-Reply-To: References: Message-ID: On Fri, 20 Sep 2024 14:28:22 GMT, Matthias Baesken wrote: > 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings This pull request has now been integrated. Changeset: faea17a3 Author: Matthias Baesken URL: https://git.openjdk.org/jdk23u/commit/faea17a3f580a020c4ecad0a6d6484bf671720e8 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings Backport-of: ac3f92b4110b05906a49c4146774fd6324c6d198 ------------- PR: https://git.openjdk.org/jdk23u/pull/114 From duke at openjdk.org Mon Sep 23 12:02:43 2024 From: duke at openjdk.org (HempushpaSahu) Date: Mon, 23 Sep 2024 12:02:43 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: References: Message-ID: <-O5O_iB4-_Z8C1tgCYqd6UDgFDb_3fhBOdJoEzXL3sw=.17c6645f-9dc6-4783-a2ac-163276c5bd0f@github.com> On Sun, 28 Jul 2024 22:02:37 GMT, Alexey Bakhtin wrote: > Hello, I'd like to backport JDK-8179502 to JDK17u to improve the timeout adjustment for OCSP GET requests (which was missed in JDK-8179503). > > The backport is almost clean except for the following: > - OCSP.java was merged manually because of JDK-8328638 and JDK-8329213 is already backported into 17u-dev > - copyright year in GetPropertyAction.java and URICertStore.java files are updated manually > - CRLReadTimeout.java test is updated manually because of the different notation of internal X509CRLImpl and CRLExtensions classes. > > All new and related jtreg tests are passed Hi, Since there is multiple follow-ups for this PR and customer is awaiting the fix, could someone please provide an update on the review status? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2747#issuecomment-2368005780 From duke at openjdk.org Mon Sep 23 12:04:41 2024 From: duke at openjdk.org (duke) Date: Mon, 23 Sep 2024 12:04:41 GMT Subject: [jdk23u] RFR: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect In-Reply-To: References: Message-ID: On Sat, 21 Sep 2024 12:12:07 GMT, Shivangi Gupta wrote: > Straight Backport. Test only change. @Shivangi-aa Your change (at version 947f131eef40a63721e37b41e7828497c091ef32) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/116#issuecomment-2368011868 From sshivang at openjdk.org Mon Sep 23 12:08:42 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Mon, 23 Sep 2024 12:08:42 GMT Subject: [jdk23u] RFR: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect In-Reply-To: References: Message-ID: On Sat, 21 Sep 2024 12:12:07 GMT, Shivangi Gupta wrote: > Straight Backport. Test only change. @coffeys Can you please sponsor this. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/116#issuecomment-2368021402 From dchuyko at openjdk.org Mon Sep 23 12:18:18 2024 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Mon, 23 Sep 2024 12:18:18 GMT Subject: [jdk21u-dev] RFR: 8333867: SHA3 performance can be improved Message-ID: This is a clean backport of multi-platform SHA3 performance improvement. MessageDigests benchmarks show same speedup as for the original change (C2 generated code variant, -XX:-UseSHA3Intrinsics). Testing: test/jdk/sun/security, tier1, tier2 (linux-aarch64, linux-amd64). ------------- Commit messages: - Backport 75bea280b9adb6dac9fefafbb3f4b212f100fbb5 Changes: https://git.openjdk.org/jdk21u-dev/pull/1000/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1000&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333867 Stats: 86 lines in 3 files changed: 24 ins; 35 del; 27 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1000.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1000/head:pull/1000 PR: https://git.openjdk.org/jdk21u-dev/pull/1000 From mdoerr at openjdk.org Mon Sep 23 12:46:36 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 23 Sep 2024 12:46:36 GMT Subject: [jdk23u] RFR: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 11:02:19 GMT, Martin Doerr wrote: > Backport of [JDK-8340230](https://bugs.openjdk.org/browse/JDK-8340230). Needs manual integration because [JDK-8340012](https://bugs.openjdk.org/browse/JDK-8340012) is not in jdk23u. > Using DecodeN without CompressedOops or DecodeNKlass without CompressedClassPointers can cause errors. Thanks for the review and the approval! ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/104#issuecomment-2368105221 From mdoerr at openjdk.org Mon Sep 23 12:46:36 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 23 Sep 2024 12:46:36 GMT Subject: [jdk23u] Integrated: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity In-Reply-To: References: Message-ID: <1YZAKX8Db8HlA3Ji4KvQLJto50FIV3ktUWKg466FMUY=.8efd38a9-3c16-49a2-a151-e3cd8ae8ec52@github.com> On Wed, 18 Sep 2024 11:02:19 GMT, Martin Doerr wrote: > Backport of [JDK-8340230](https://bugs.openjdk.org/browse/JDK-8340230). Needs manual integration because [JDK-8340012](https://bugs.openjdk.org/browse/JDK-8340012) is not in jdk23u. > Using DecodeN without CompressedOops or DecodeNKlass without CompressedClassPointers can cause errors. This pull request has now been integrated. Changeset: a6754f31 Author: Martin Doerr URL: https://git.openjdk.org/jdk23u/commit/a6754f31cf52c3058d5f95a54e9f66738f4216e6 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity Reviewed-by: mbaesken Backport-of: 3895b8fc0b2c6d187080dba6fe08297adad4a480 ------------- PR: https://git.openjdk.org/jdk23u/pull/104 From mdoerr at openjdk.org Mon Sep 23 12:53:51 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 23 Sep 2024 12:53:51 GMT Subject: [jdk21u-dev] RFR: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity Message-ID: Clean backport of [JDK-8340230](https://bugs.openjdk.org/browse/JDK-8340230) from jdk23u. ------------- Commit messages: - Backport a6754f31cf52c3058d5f95a54e9f66738f4216e6 Changes: https://git.openjdk.org/jdk21u-dev/pull/1001/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1001&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340230 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1001.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1001/head:pull/1001 PR: https://git.openjdk.org/jdk21u-dev/pull/1001 From mdoerr at openjdk.org Mon Sep 23 12:56:06 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 23 Sep 2024 12:56:06 GMT Subject: [jdk17u-dev] RFR: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity Message-ID: Clean backport of [JDK-8340230](https://bugs.openjdk.org/browse/JDK-8340230) from jdk23u. ------------- Commit messages: - Backport a6754f31cf52c3058d5f95a54e9f66738f4216e6 Changes: https://git.openjdk.org/jdk17u-dev/pull/2910/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2910&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340230 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2910.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2910/head:pull/2910 PR: https://git.openjdk.org/jdk17u-dev/pull/2910 From shade at openjdk.org Mon Sep 23 13:06:39 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 23 Sep 2024 13:06:39 GMT Subject: [jdk23u] Integrated: 8334229: Optimize InterpreterOopMap layout In-Reply-To: <8Wz03YoeGv51nc4Zl3uTsPo5FM1Frlda8Rub7M_5QXw=.d2ecc0a5-5814-4938-8890-a0d4fc202439@github.com> References: <8Wz03YoeGv51nc4Zl3uTsPo5FM1Frlda8Rub7M_5QXw=.d2ecc0a5-5814-4938-8890-a0d4fc202439@github.com> Message-ID: On Wed, 21 Aug 2024 17:25:05 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve OopMapCache. I actually want this change in 21u-dev, so I am backporting to 23u on its way there. The change is pretty simple, so there is only a little risk. > > It is different from mainline change, because [JDK-8335409](https://bugs.openjdk.org/browse/JDK-8335409) went into 23u first. It removes one of the definitions we move: https://github.com/openjdk/jdk/commit/7ab96c74e2c39f430a5c2f65a981da7314a2385b#diff-d47427bcae3d32d55540df020532bf223ed3cdc6496c3277068e0125fa7be22cL91-L93 > > Applying this backport yields no difference in `oopMapCache.hpp` with mainline version, which is what we want. This pull request has now been integrated. Changeset: 73313ef1 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/73313ef14f9d4fd0ff005e32de23eb171d536c9b Stats: 4 lines in 1 file changed: 2 ins; 2 del; 0 mod 8334229: Optimize InterpreterOopMap layout Reviewed-by: phh Backport-of: fac74b118f5fda4ec297e46238d34ce5b9be1e21 ------------- PR: https://git.openjdk.org/jdk23u/pull/81 From rehn at openjdk.org Mon Sep 23 13:18:25 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Mon, 23 Sep 2024 13:18:25 GMT Subject: [jdk21u-dev] RFR: 8339741: RISC-V: C ABI breakage for integer on stack Message-ID: Hi all, This pull request contains a backport of commit [bfe7f920](https://github.com/openjdk/jdk/commit/bfe7f9205b56483b4364130a3a87c58c3fc82998) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry. Thanks! ------------- Commit messages: - Backport bfe7f9205b56483b4364130a3a87c58c3fc82998 Changes: https://git.openjdk.org/jdk21u-dev/pull/1002/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1002&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339741 Stats: 156 lines in 4 files changed: 150 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1002.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1002/head:pull/1002 PR: https://git.openjdk.org/jdk21u-dev/pull/1002 From sgehwolf at openjdk.org Mon Sep 23 13:56:46 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 23 Sep 2024 13:56:46 GMT Subject: [jdk11u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 08:59:31 GMT, Antonio Vieiro wrote: > The `macos-11` github runners [were deprecated and removed in June 2024](https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/) , making the `macos` tests to hang in `openjdk11u-dev` (and other OpenJDK repositories). > > [JDK-8335793 GHA: Bump macOS and Xcode versions](https://bugs.openjdk.org/browse/JDK-8335793) upgraded the version [from `macos-11` to `macos-13`](https://github.com/openjdk/jdk11u-dev/pull/2835). This upgrade in github runners required a long list of changes in `openjdk11u-dev` that proved difficult to review. > > In order to ease the review process this PR downgrades the version of github runners in `jdk11u-dev` from the current `macos-13` to `macos-12` and `xcode-13.4.1`. This will require a single backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) (a follow-up to this PR), making the review process easier. > > Once the github actions are running again in `macos-12` an upgrade to `macos-13` could be performed, if required, with some more additional PRs. This seems OK as a fix, but not under this bug. `8318039` is already in `jdk11u-dev`: https://git.openjdk.org/jdk11u-dev/commit/82e28669e7abbea30033d7b3e52c6b1fe5f4184a Therefore, please open a JDK 11u specific bug and propose the fix under that new bug. ------------- Changes requested by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2936#pullrequestreview-2322325972 From shade at openjdk.org Mon Sep 23 14:02:08 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 23 Sep 2024 14:02:08 GMT Subject: [jdk23u] RFR: 8340418: GHA: MacOS AArch64 bundles can be removed prematurely Message-ID: Clean backport to improve GHA reliability. Follows [JDK-8325194](https://bugs.openjdk.org/browse/JDK-8325194). Additional testing: - [ ] GHA ------------- Commit messages: - Backport 9d76c7c60ff3133c1078892d7c50a2cfc9ff9c1b Changes: https://git.openjdk.org/jdk23u/pull/118/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=118&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340418 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/118.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/118/head:pull/118 PR: https://git.openjdk.org/jdk23u/pull/118 From abakhtin at openjdk.org Mon Sep 23 14:11:47 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 23 Sep 2024 14:11:47 GMT Subject: [jdk11u] Integrated: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Sun, 22 Sep 2024 05:44:48 GMT, Alexey Bakhtin wrote: > Please review the backport of JDK-8296410 to 11u > > Stream.java is applied cleanly. > > BodyOutputStream.java, Http2TestServer.java, and Http2TestServerConnection.java test library classes are in another path and the package name. They are applied cleanly after updating the path to the files. > > New TrailingHeadersTest is updated: > > fixed reference to the Http2TestServer module > fixed instanceOf pattern issue > Added Http2TestServerConnection::addToOutputQ method required for the test functionality > > All java/net/httpclient JTREG tests passed This pull request has now been integrated. Changeset: 0358cbd0 Author: Alexey Bakhtin URL: https://git.openjdk.org/jdk11u/commit/0358cbd0a1538937612e3a78ffbfb64d7f4c45a2 Stats: 434 lines in 5 files changed: 392 ins; 14 del; 28 mod 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 Reviewed-by: goetz Backport-of: f4b140b4200fc0f49161395501d3dbcba7a79059 ------------- PR: https://git.openjdk.org/jdk11u/pull/96 From abakhtin at openjdk.org Mon Sep 23 14:12:46 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 23 Sep 2024 14:12:46 GMT Subject: [jdk17u] Integrated: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 In-Reply-To: References: Message-ID: On Sun, 22 Sep 2024 05:43:09 GMT, Alexey Bakhtin wrote: > The backport is almost clean. > > manual update of the copyright year for Stream.java > manual merge of one-line change in the Http2TestServer.java file. Caused by difference in JDK-8295944 implementation for JDK17 and JDK21 > All java/net/httpclient JTREG tests passed This pull request has now been integrated. Changeset: 33cd4b41 Author: Alexey Bakhtin URL: https://git.openjdk.org/jdk17u/commit/33cd4b41b3815092b7cbbd324845eeae8cf76257 Stats: 431 lines in 5 files changed: 389 ins; 14 del; 28 mod 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 Reviewed-by: mbaesken Backport-of: f4b140b4200fc0f49161395501d3dbcba7a79059 ------------- PR: https://git.openjdk.org/jdk17u/pull/399 From sgehwolf at openjdk.org Mon Sep 23 14:15:44 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 23 Sep 2024 14:15:44 GMT Subject: [jdk11u-dev] RFR: 8318696: Do not use LFS64 symbols on Linux In-Reply-To: References: Message-ID: <3gd9VEi0WKCicf0SSRz_5V-BMVvgocwjjH0QzJPj7po=.e68e9961-7155-46d4-977e-ea50e2a3e2ac@github.com> On Thu, 19 Sep 2024 10:05:35 GMT, Antonio Vieiro wrote: > Backport of [JDK-8318696 Do not use LFS64 symbols on Linux](https://bugs.openjdk.org/browse/JDK-8318696). This replaces the usage of LFS64 symbols in Linux with their regular counterparts adding `-D_FILE_OFFSET_BITS=64`. > > This is not a clean backport, because in `jdk11` many of these symbols still live in `os_linux.cpp` and `os_linux_inline.hpp`, that were then refactored/deleted during the years into [the current `os_posix.hpp` and `os_posix.cpp` in `jdk17`](https://github.com/openjdk/jdk17u-dev/commit/2b9228a3c92590e3146ecad468bb2ea68a5a6bb2). This is a fairly risky backport for this stage of where JDK 11 is. What problem does this solve other than what https://bugs.openjdk.org/browse/JDK-8062658 and https://bugs.openjdk.org/browse/JDK-8280747 describe (32 bit specific on large filesystems). Why do this backport now? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2938#issuecomment-2368398990 From shade at openjdk.org Mon Sep 23 14:25:04 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 23 Sep 2024 14:25:04 GMT Subject: [jdk21u-dev] RFR: 8340418: GHA: MacOS AArch64 bundles can be removed prematurely Message-ID: Clean backport to improve GHA reliability. Follows [JDK-8325194](https://bugs.openjdk.org/browse/JDK-8325194). Additional testing: - [ ] GHA ------------- Commit messages: - Backport 9d76c7c60ff3133c1078892d7c50a2cfc9ff9c1b Changes: https://git.openjdk.org/jdk21u-dev/pull/1003/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1003&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340418 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1003.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1003/head:pull/1003 PR: https://git.openjdk.org/jdk21u-dev/pull/1003 From shade at openjdk.org Mon Sep 23 14:29:46 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 23 Sep 2024 14:29:46 GMT Subject: [jdk17u-dev] RFR: 8340418: GHA: MacOS AArch64 bundles can be removed prematurely Message-ID: Clean backport to improve GHA reliability. Follows [JDK-8325194](https://bugs.openjdk.org/browse/JDK-8325194). Additional testing: - [ ] GHA ------------- Commit messages: - Backport 9d76c7c60ff3133c1078892d7c50a2cfc9ff9c1b Changes: https://git.openjdk.org/jdk17u-dev/pull/2911/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2911&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340418 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2911.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2911/head:pull/2911 PR: https://git.openjdk.org/jdk17u-dev/pull/2911 From sshivang at openjdk.org Mon Sep 23 14:40:41 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Mon, 23 Sep 2024 14:40:41 GMT Subject: [jdk23u] Integrated: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect In-Reply-To: References: Message-ID: On Sat, 21 Sep 2024 12:12:07 GMT, Shivangi Gupta wrote: > Straight Backport. Test only change. This pull request has now been integrated. Changeset: 127a68a4 Author: Shivangi Gupta Committer: Sean Coffey URL: https://git.openjdk.org/jdk23u/commit/127a68a40995c028540e4125d91acaf68ef61f87 Stats: 42 lines in 1 file changed: 28 ins; 5 del; 9 mod 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect Backport-of: 21e86d10a726fe707febb0111f5b80d8d1d29f03 ------------- PR: https://git.openjdk.org/jdk23u/pull/116 From shade at openjdk.org Mon Sep 23 15:18:47 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 23 Sep 2024 15:18:47 GMT Subject: [jdk17u-dev] RFR: 8338402: GHA: some of bundles may not get removed In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 16:09:54 GMT, Zdenek Zambersky wrote: > Backport fixing problem, where some bundles may not get removed in GHA. > > GHA testing: OK (no leftover bundles) Still waiting for anything, or we can integrate? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2841#issuecomment-2368608579 From rehn at openjdk.org Mon Sep 23 15:52:22 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Mon, 23 Sep 2024 15:52:22 GMT Subject: [jdk17u-dev] RFR: 8339741: RISC-V: C ABI breakage for integer on stack Message-ID: Hi all, This pull request contains a backport of commit [bfe7f920](https://github.com/openjdk/jdk/commit/bfe7f9205b56483b4364130a3a87c58c3fc82998) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry. Not clean, locally tested the new jtreg test. Thanks! ------------- Commit messages: - Backport bfe7f9205b56483b4364130a3a87c58c3fc82998 Changes: https://git.openjdk.org/jdk17u-dev/pull/2912/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2912&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339741 Stats: 156 lines in 4 files changed: 150 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2912.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2912/head:pull/2912 PR: https://git.openjdk.org/jdk17u-dev/pull/2912 From zzambers at openjdk.org Mon Sep 23 16:09:47 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 23 Sep 2024 16:09:47 GMT Subject: [jdk17u-dev] RFR: 8338402: GHA: some of bundles may not get removed In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 15:16:14 GMT, Aleksey Shipilev wrote: >> Backport fixing problem, where some bundles may not get removed in GHA. >> >> GHA testing: OK (no leftover bundles) > > Still waiting for anything, or we can integrate? @shipilev can be integrated, thanks ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2841#issuecomment-2368739403 From duke at openjdk.org Mon Sep 23 16:16:43 2024 From: duke at openjdk.org (duke) Date: Mon, 23 Sep 2024 16:16:43 GMT Subject: [jdk23u] RFR: 8339416: [s390x] Provide implementation for resolve_global_jobject In-Reply-To: <28csfiAISFu4XsPOsiyBNXGzEMaALCvYgN4sUOX8hdA=.a6bb94e4-9fbc-4dc6-ae7e-08f33bd73ba9@github.com> References: <28csfiAISFu4XsPOsiyBNXGzEMaALCvYgN4sUOX8hdA=.a6bb94e4-9fbc-4dc6-ae7e-08f33bd73ba9@github.com> Message-ID: On Fri, 20 Sep 2024 04:24:04 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [ac58b610](https://github.com/openjdk/jdk/commit/ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 19 Sep 2024 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! @offamitkumar Your change (at version 8a00193aac3e848279160858d5d1fbcfedb92d56) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/110#issuecomment-2368755171 From bulasevich at openjdk.org Mon Sep 23 16:27:43 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Mon, 23 Sep 2024 16:27:43 GMT Subject: [jdk21u-dev] Withdrawn: 8321308: AArch64: Fix matching predication for cbz/cbnz In-Reply-To: <6ZbthRNyFF-b9jXEweyrQqAjh_-PT2cSLJ7HQ2mv38c=.56d099f5-a4b5-42d8-a70c-eb46a3421852@github.com> References: <6ZbthRNyFF-b9jXEweyrQqAjh_-PT2cSLJ7HQ2mv38c=.56d099f5-a4b5-42d8-a70c-eb46a3421852@github.com> Message-ID: On Wed, 21 Aug 2024 21:31:34 GMT, Boris Ulasevich wrote: > Clean backport to improve aarch code generation for array length `if (a.length > 0)` > > Testing: jtreg tier1-3 on linux-aarch64. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/940 From zzambers at openjdk.org Mon Sep 23 16:41:39 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 23 Sep 2024 16:41:39 GMT Subject: [jdk17u-dev] Integrated: 8338402: GHA: some of bundles may not get removed In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 16:09:54 GMT, Zdenek Zambersky wrote: > Backport fixing problem, where some bundles may not get removed in GHA. > > GHA testing: OK (no leftover bundles) This pull request has now been integrated. Changeset: 22bcb909 Author: Zdenek Zambersky Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/22bcb90948a8c574508dac55359364ad29cffcd5 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8338402: GHA: some of bundles may not get removed Backport-of: d8e4d3f2d6c187f2487acd390a4e5fa2a99010ea ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2841 From duke at openjdk.org Mon Sep 23 16:46:52 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 23 Sep 2024 16:46:52 GMT Subject: [jdk11u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 08:59:31 GMT, Antonio Vieiro wrote: > The `macos-11` github runners [were deprecated and removed in June 2024](https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/) , making the `macos` tests to hang in `openjdk11u-dev` (and other OpenJDK repositories). > > [JDK-8335793 GHA: Bump macOS and Xcode versions](https://bugs.openjdk.org/browse/JDK-8335793) upgraded the version [from `macos-11` to `macos-13`](https://github.com/openjdk/jdk11u-dev/pull/2835). This upgrade in github runners required a long list of changes in `openjdk11u-dev` that proved difficult to review. > > In order to ease the review process this PR downgrades the version of github runners in `jdk11u-dev` from the current `macos-13` to `macos-12` and `xcode-13.4.1`. This will require a single backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) (a follow-up to this PR), making the review process easier. > > Once the github actions are running again in `macos-12` an upgrade to `macos-13` could be performed, if required, with some more additional PRs. Filed as https://bugs.openjdk.org/browse/JDK-8318039 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2936#issuecomment-2368816378 From sgehwolf at openjdk.org Mon Sep 23 17:04:42 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 23 Sep 2024 17:04:42 GMT Subject: [jdk11u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 16:41:43 GMT, Antonio Vieiro wrote: > Filed as https://bugs.openjdk.org/browse/JDK-8318039 Still `8318039`? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2936#issuecomment-2368857011 From duke at openjdk.org Mon Sep 23 19:21:41 2024 From: duke at openjdk.org (duke) Date: Mon, 23 Sep 2024 19:21:41 GMT Subject: [jdk21u-dev] Withdrawn: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream In-Reply-To: <1kXxLLV3TU6gpgjY-di-Wa4Q8vnBkw6EXFFYBszrh4s=.a980c8f2-cfef-4ead-8e94-64452cd3d379@github.com> References: <1kXxLLV3TU6gpgjY-di-Wa4Q8vnBkw6EXFFYBszrh4s=.a980c8f2-cfef-4ead-8e94-64452cd3d379@github.com> Message-ID: On Fri, 26 Jul 2024 19:04:46 GMT, William Kemper wrote: > Clean backport. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/871 From duke at openjdk.org Mon Sep 23 21:47:42 2024 From: duke at openjdk.org (Saint Wesonga) Date: Mon, 23 Sep 2024 21:47:42 GMT Subject: [jdk21u-dev] RFR: 6942632: Hotspot should be able to use more than 64 logical processors on Windows In-Reply-To: References: <2coHSZZXFN7EQtSqhEuq3uM01sX9UqpOpvAMZBuowEw=.045fbe79-cd99-4b58-a756-895fc8ab0bf7@github.com> Message-ID: On Tue, 13 Aug 2024 15:13:09 GMT, Severin Gehwolf wrote: > @swesonga Please add an appropriate fix request comment to the bug when it's being asked for approval. Currently there is none. It should mention the testing you've done and the estimated risk (with a reason) for bringing this patch to 21u. Meanwhile I'll remove the approval label. Also, I don't see the CSR for 21-pool as approved (it's still in provisional). Hi @jerboaa, I updated https://bugs.openjdk.org/browse/JDK-6942632 with a fix request comment describing the testing and risk and the CSR has also been approved. Please let me know if there is anything else needed for this PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/881#issuecomment-2369528895 From serb at openjdk.org Mon Sep 23 23:32:44 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 23 Sep 2024 23:32:44 GMT Subject: [jdk17u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 08:30:05 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [ad5656f7](https://github.com/openjdk/jdk21u-dev/commit/ad5656f7fa53e7d380dbadc204501c3c7f2e822a) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by SendaoYan on 10 Sep 2024 and was reviewed by Severin Gehwolf. > > Thanks! Is it ready for integration? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2861#issuecomment-2369772554 From syan at openjdk.org Tue Sep 24 01:23:35 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 24 Sep 2024 01:23:35 GMT Subject: [jdk17u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 23:30:23 GMT, Sergey Bylokhov wrote: > Is it ready for integration? Sorry, I miss that some have approval this PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2861#issuecomment-2369913880 From duke at openjdk.org Tue Sep 24 01:23:35 2024 From: duke at openjdk.org (duke) Date: Tue, 24 Sep 2024 01:23:35 GMT Subject: [jdk17u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 08:30:05 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [ad5656f7](https://github.com/openjdk/jdk21u-dev/commit/ad5656f7fa53e7d380dbadc204501c3c7f2e822a) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by SendaoYan on 10 Sep 2024 and was reviewed by Severin Gehwolf. > > Thanks! @sendaoYan Your change (at version dc5892f6f4a5dbaef6e7fd99d4ea76108ba7c940) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2861#issuecomment-2369914795 From duke at openjdk.org Tue Sep 24 02:03:41 2024 From: duke at openjdk.org (duke) Date: Tue, 24 Sep 2024 02:03:41 GMT Subject: [jdk23u] RFR: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 03:40:37 GMT, Liang Mao wrote: > Backport of concurrent GC crash due to GetMethodDeclaringClass. The backport is not clean because of make file. @mmyxym Your change (at version 0988ce56c5359da340dc0f8a4e19136af41ef439) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/117#issuecomment-2369958375 From fyang at openjdk.org Tue Sep 24 02:26:44 2024 From: fyang at openjdk.org (Fei Yang) Date: Tue, 24 Sep 2024 02:26:44 GMT Subject: [jdk17u-dev] RFR: 8339741: RISC-V: C ABI breakage for integer on stack In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 15:45:33 GMT, Robbin Ehn wrote: > Hi all, > > This pull request contains a backport of commit [bfe7f920](https://github.com/openjdk/jdk/commit/bfe7f9205b56483b4364130a3a87c58c3fc82998) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry. > > Not clean, locally tested the new jtreg test. > > Thanks! Looks good. Thanks. ------------- Marked as reviewed by fyang (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2912#pullrequestreview-2323863570 From lmao at openjdk.org Tue Sep 24 03:28:18 2024 From: lmao at openjdk.org (Liang Mao) Date: Tue, 24 Sep 2024 03:28:18 GMT Subject: [jdk21u-dev] RFR: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass Message-ID: Backport of fixing concurrent GC crashed due to GetMethodDeclaringClass. Not clean because of make file. ------------- Commit messages: - Backport c91fa278fe17ab204beef0fcef1ada6dd0bc37bb Changes: https://git.openjdk.org/jdk21u-dev/pull/1004/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1004&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339725 Stats: 244 lines in 5 files changed: 241 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1004.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1004/head:pull/1004 PR: https://git.openjdk.org/jdk21u-dev/pull/1004 From amitkumar at openjdk.org Tue Sep 24 04:23:39 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Tue, 24 Sep 2024 04:23:39 GMT Subject: [jdk23u] RFR: 8339416: [s390x] Provide implementation for resolve_global_jobject In-Reply-To: <28csfiAISFu4XsPOsiyBNXGzEMaALCvYgN4sUOX8hdA=.a6bb94e4-9fbc-4dc6-ae7e-08f33bd73ba9@github.com> References: <28csfiAISFu4XsPOsiyBNXGzEMaALCvYgN4sUOX8hdA=.a6bb94e4-9fbc-4dc6-ae7e-08f33bd73ba9@github.com> Message-ID: On Fri, 20 Sep 2024 04:24:04 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [ac58b610](https://github.com/openjdk/jdk/commit/ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 19 Sep 2024 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! @RealLucy ? ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/110#issuecomment-2370119986 From syan at openjdk.org Tue Sep 24 04:26:42 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 24 Sep 2024 04:26:42 GMT Subject: [jdk17u-dev] Integrated: 8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 08:30:05 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [ad5656f7](https://github.com/openjdk/jdk21u-dev/commit/ad5656f7fa53e7d380dbadc204501c3c7f2e822a) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by SendaoYan on 10 Sep 2024 and was reviewed by Severin Gehwolf. > > Thanks! This pull request has now been integrated. Changeset: cf0fea9d Author: SendaoYan Committer: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/cf0fea9ddb8b30a2d537d467ea1850ff858de469 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 Backport-of: ad5656f7fa53e7d380dbadc204501c3c7f2e822a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2861 From syan at openjdk.org Tue Sep 24 05:52:37 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 24 Sep 2024 05:52:37 GMT Subject: [jdk17u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 08:30:05 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [ad5656f7](https://github.com/openjdk/jdk21u-dev/commit/ad5656f7fa53e7d380dbadc204501c3c7f2e822a) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by SendaoYan on 10 Sep 2024 and was reviewed by Severin Gehwolf. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2861#issuecomment-2370248175 From andrewlu at openjdk.org Tue Sep 24 06:55:43 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 24 Sep 2024 06:55:43 GMT Subject: [jdk17u-dev] Integrated: 8295859: Update Manual Test Groups In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 09:41:18 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. > As GoeLin saied, > com/sun/net/httpserver/simpleserver/CommandLinePortNotSpecifiedTest.java > com/sun/net/httpserver/simpleserver/jwebserver/CommandLinePortNotSpecifiedTest.java > They came with "8245095: Implementation of JEP 408: Simple Web Server" in 18 > which we won't backport. This pull request has now been integrated. Changeset: ac5ef4ba Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/ac5ef4bab3dbbd3ab1e5dee205e46898ee59e091 Stats: 16 lines in 1 file changed: 9 ins; 3 del; 4 mod 8295859: Update Manual Test Groups Reviewed-by: goetz Backport-of: 87017b5199522bb26f0225b60fbbc00df255ad2a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2863 From duke at openjdk.org Tue Sep 24 06:57:44 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 24 Sep 2024 06:57:44 GMT Subject: [jdk11u-dev] RFR: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 08:59:31 GMT, Antonio Vieiro wrote: > The `macos-11` github runners [were deprecated and removed in June 2024](https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/) , making the `macos` tests to hang in `openjdk11u-dev` (and other OpenJDK repositories). > > [JDK-8335793 GHA: Bump macOS and Xcode versions](https://bugs.openjdk.org/browse/JDK-8335793) upgraded the version [from `macos-11` to `macos-13`](https://github.com/openjdk/jdk11u-dev/pull/2835). This upgrade in github runners required a long list of changes in `openjdk11u-dev` that proved difficult to review. > > In order to ease the review process this PR downgrades the version of github runners in `jdk11u-dev` from the current `macos-13` to `macos-12` and `xcode-13.4.1`. This will require a single backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) (a follow-up to this PR), making the review process easier. > > Once the github actions are running again in `macos-12` an upgrade to `macos-13` could be performed, if required, with some more additional PRs. https://bugs.openjdk.org/browse/JDK-8340671 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2936#issuecomment-2370347400 From andrewlu at openjdk.org Tue Sep 24 07:04:13 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 24 Sep 2024 07:04:13 GMT Subject: [jdk17u-dev] RFR: 8320586: update manual test/jdk/TEST.groups [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.14-oracle. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge remote-tracking branch 'origin/master' into backport_8320586 # Conflicts: # test/jdk/TEST.groups - Backport 99b9cb0a2eae1196f2127cd48e4085f19a90c4b4 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/2886/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2886&range=01 Stats: 10 lines in 1 file changed: 8 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2886.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2886/head:pull/2886 PR: https://git.openjdk.org/jdk17u-dev/pull/2886 From andrewlu at openjdk.org Tue Sep 24 07:09:14 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 24 Sep 2024 07:09:14 GMT Subject: [jdk17u-dev] RFR: 8320586: update manual test/jdk/TEST.groups [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.14-oracle. Andrew Lu has updated the pull request incrementally with two additional commits since the last revision: - update - update ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2886/files - new: https://git.openjdk.org/jdk17u-dev/pull/2886/files/a9ef3577..56bcb909 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2886&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2886&range=01-02 Stats: 10 lines in 1 file changed: 1 ins; 5 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2886.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2886/head:pull/2886 PR: https://git.openjdk.org/jdk17u-dev/pull/2886 From goetz at openjdk.org Tue Sep 24 07:12:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 07:12:11 GMT Subject: [jdk17u-dev] RFR: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose Message-ID: I backport this to improve testing in 17. ------------- Commit messages: - Backport f0b7eb519ae1cf6f4cb2baea55b5e02a46a8192e Changes: https://git.openjdk.org/jdk17u-dev/pull/2913/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2913&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304020 Stats: 316 lines in 3 files changed: 226 ins; 90 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2913.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2913/head:pull/2913 PR: https://git.openjdk.org/jdk17u-dev/pull/2913 From goetz at openjdk.org Tue Sep 24 07:12:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 07:12:41 GMT Subject: [jdk21u-dev] RFR: 8309218: java/util/concurrent/locks/Lock/OOMEInAQS.java still times out with ZGC, Generational ZGC, and SerialGC In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 08:04:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. GHA failure: Error: Download failed: [https://ghcr.io/v2/homebrew/core/make/blobs](https://ghcr.io /v2/homebrew/core/make/blobs/sha256:e5b435315db19e1634289e888fcbd4282ed985a85591a7bec9661595a091d56f) infra issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/997#issuecomment-2370373661 From andrewlu at openjdk.org Tue Sep 24 07:19:16 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 24 Sep 2024 07:19:16 GMT Subject: [jdk21u-dev] RFR: 8320665: update jdk_core at open/test/jdk/TEST.groups Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport da7cf258bb5b24788409dde084ad012bd64a032a Changes: https://git.openjdk.org/jdk21u-dev/pull/1005/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1005&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320665 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1005.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1005/head:pull/1005 PR: https://git.openjdk.org/jdk21u-dev/pull/1005 From andrewlu at openjdk.org Tue Sep 24 07:23:10 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 24 Sep 2024 07:23:10 GMT Subject: [jdk17u-dev] RFR: 8320665: update jdk_core at open/test/jdk/TEST.groups Message-ID: <25bjPBUt0pTbZyZOZjRgW4MHcGlCoMHIZ87_OKJFZmQ=.9239cc6d-7f19-45db-9471-38215354bcd4@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport da7cf258bb5b24788409dde084ad012bd64a032a Changes: https://git.openjdk.org/jdk17u-dev/pull/2914/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2914&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320665 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2914.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2914/head:pull/2914 PR: https://git.openjdk.org/jdk17u-dev/pull/2914 From goetz at openjdk.org Tue Sep 24 07:42:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 07:42:39 GMT Subject: [jdk21u-dev] Integrated: 8325399: Add tests for virtual threads doing Selector operations In-Reply-To: <97vtJnpD9AyzcIQde9AQv5ILw_mA-EEkvymNMo02yPc=.0895bc01-f101-42e7-b218-581761be0231@github.com> References: <97vtJnpD9AyzcIQde9AQv5ILw_mA-EEkvymNMo02yPc=.0895bc01-f101-42e7-b218-581761be0231@github.com> Message-ID: On Mon, 23 Sep 2024 08:09:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: df2d31f7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/df2d31f73434b5a6537843d7ab8f945c3d383d5e Stats: 349 lines in 1 file changed: 349 ins; 0 del; 0 mod 8325399: Add tests for virtual threads doing Selector operations Backport-of: 43089bf0065ce85681724d92d26709f4e3ad28ea ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/998 From goetz at openjdk.org Tue Sep 24 07:43:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 07:43:41 GMT Subject: [jdk17u-dev] Integrated: 8284874: Add comment to ProcessHandle/OnExitTest to describe zombie problem In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 09:43:43 GMT, Goetz Lindenmaier wrote: > I am backporting this to simplify follow-up backports. Comment only, harmless. This pull request has now been integrated. Changeset: 01740fbd Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/01740fbdbde713b616e26780e400c1af41f25adb Stats: 19 lines in 1 file changed: 18 ins; 0 del; 1 mod 8284874: Add comment to ProcessHandle/OnExitTest to describe zombie problem Backport-of: bb7c97bddfe88cb3261706f5e272fd0418e5238c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2906 From goetz at openjdk.org Tue Sep 24 07:50:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 07:50:09 GMT Subject: [jdk17u-dev] RFR: 8319574: Exec/process tests should be marked as flagless [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.14-oracle. > > Omitted test/jdk/java/lang/ProcessBuilder/ProcessStartLoggingTest.java. That came > with "8303392: Runtime.exec and ProcessBuilder.start should use System logger" > which is not a candidate for backport. > > Omitted test/jdk/java/lang/RuntimeTests/RuntimeExitLogTest.java. That came > with "8301627: System.exit and Runtime.exit debug logging" > which is not a candidate for backport. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge - Backport 68110b7a82ae82e2485aec23aba5406d2a5c0327 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/2907/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2907&range=01 Stats: 20 lines in 12 files changed: 11 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2907.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2907/head:pull/2907 PR: https://git.openjdk.org/jdk17u-dev/pull/2907 From goetz at openjdk.org Tue Sep 24 07:52:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 07:52:44 GMT Subject: [jdk17u-dev] Integrated: 8335530: Java file extension missing in AuthenticatorTest In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 10:17:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 9c36bb90 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9c36bb90ffa0e69e9bb672a4af5357e7f7d9baa0 Stats: 120 lines in 2 files changed: 60 ins; 60 del; 0 mod 8335530: Java file extension missing in AuthenticatorTest Backport-of: a537e87d2d2c6bff63f63bb436e3e919740221ce ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2908 From goetz at openjdk.org Tue Sep 24 07:54:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 07:54:43 GMT Subject: [jdk21u-dev] Integrated: 8335530: Java file extension missing in AuthenticatorTest In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 08:14:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: b0fb7420 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/b0fb742052736f3963f206efe997965911d69b87 Stats: 120 lines in 2 files changed: 60 ins; 60 del; 0 mod 8335530: Java file extension missing in AuthenticatorTest Backport-of: a537e87d2d2c6bff63f63bb436e3e919740221ce ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/999 From goetz at openjdk.org Tue Sep 24 07:59:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 07:59:36 GMT Subject: [jdk21u-dev] Integrated: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 13:25:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. > > Resolved ProblemList, probably clean. This pull request has now been integrated. Changeset: b5c3d76d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/b5c3d76de858195d490ee21158e0d5e8437e84cd Stats: 16 lines in 3 files changed: 6 ins; 5 del; 5 mod 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException Backport-of: 034297a6bd9bfcea7fa48792f54c84a6e976b319 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/989 From goetz at openjdk.org Tue Sep 24 08:01:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 08:01:38 GMT Subject: [jdk17u-dev] Integrated: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 10:23:42 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 9e8a1c0c Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9e8a1c0c937ab3c26f02dd74d956dea01e0bd2fa Stats: 96 lines in 1 file changed: 60 ins; 5 del; 31 mod 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect Backport-of: 330e520c1d42d3a9f3e187873dcd8ed7fd561aaf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2909 From goetz at openjdk.org Tue Sep 24 08:03:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 08:03:37 GMT Subject: [jdk17u-dev] Integrated: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs In-Reply-To: References: Message-ID: On Sun, 15 Sep 2024 09:06:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Resolved Copyright, probably clean. This pull request has now been integrated. Changeset: 668fd088 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/668fd088d64fff71b8601d0540cc12f7465c2ad7 Stats: 4 lines in 1 file changed: 2 ins; 1 del; 1 mod 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs Backport-of: 2305d18e8d53dbbf341b580b60f9ed21f408bff1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2881 From goetz at openjdk.org Tue Sep 24 08:08:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 08:08:09 GMT Subject: [jdk21u-dev] RFR: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test [v5] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.6-oracle. > > > This depends on [JDK-8320586](https://bugs.openjdk.org/browse/JDK-8320586), and JDK-8336240, will wait until that is pushed. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'master' into goetz_backport_8335172 - Fix after Merge - Merge branch 'openjdk:master' into goetz_backport_8335172 - Backport a5c2d7b305407974b3f67c48b8dcb1f8e77abde3 ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/972/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=972&range=04 Stats: 17 lines in 3 files changed: 13 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/972.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/972/head:pull/972 PR: https://git.openjdk.org/jdk21u-dev/pull/972 From goetz at openjdk.org Tue Sep 24 08:11:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 08:11:36 GMT Subject: [jdk21u-dev] Integrated: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 13:35:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. > > > This depends on [JDK-8320586](https://bugs.openjdk.org/browse/JDK-8320586), and JDK-8336240, will wait until that is pushed. This pull request has now been integrated. Changeset: 41f7936e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/41f7936e41dd988c14f814b089ba4e063bb8cde5 Stats: 17 lines in 3 files changed: 13 ins; 2 del; 2 mod 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test Backport-of: a5c2d7b305407974b3f67c48b8dcb1f8e77abde3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/972 From goetz at openjdk.org Tue Sep 24 08:12:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 08:12:44 GMT Subject: [jdk21u-dev] Integrated: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs In-Reply-To: References: Message-ID: On Sun, 15 Sep 2024 08:50:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: ead7e5f7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/ead7e5f7eff9bbbfdc0f7a429027783fd8a2cff0 Stats: 4 lines in 1 file changed: 2 ins; 1 del; 1 mod 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs Backport-of: 2305d18e8d53dbbf341b580b60f9ed21f408bff1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/978 From goetz at openjdk.org Tue Sep 24 08:14:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 08:14:40 GMT Subject: [jdk21u-dev] Integrated: 8309218: java/util/concurrent/locks/Lock/OOMEInAQS.java still times out with ZGC, Generational ZGC, and SerialGC In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 08:04:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 5fa98abc Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/5fa98abc010b050ab19dc0a4ea7c1956cd488d88 Stats: 8 lines in 3 files changed: 1 ins; 3 del; 4 mod 8309218: java/util/concurrent/locks/Lock/OOMEInAQS.java still times out with ZGC, Generational ZGC, and SerialGC Backport-of: b86c3b7a68335d57699ea3c5ec6d09a62ea9026a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/997 From mdoerr at openjdk.org Tue Sep 24 08:23:37 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 24 Sep 2024 08:23:37 GMT Subject: [jdk17u-dev] RFR: 8319574: Exec/process tests should be marked as flagless [v2] In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 07:50:09 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.14-oracle. >> >> Omitted test/jdk/java/lang/ProcessBuilder/ProcessStartLoggingTest.java. That came >> with "8303392: Runtime.exec and ProcessBuilder.start should use System logger" >> which is not a candidate for backport. >> >> Omitted test/jdk/java/lang/RuntimeTests/RuntimeExitLogTest.java. That came >> with "8301627: System.exit and Runtime.exit debug logging" >> which is not a candidate for backport. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Merge > - Backport 68110b7a82ae82e2485aec23aba5406d2a5c0327 LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2907#pullrequestreview-2324493332 From shade at openjdk.org Tue Sep 24 08:49:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 24 Sep 2024 08:49:56 GMT Subject: [jdk23u] RFR: 8337876: [IR Framework] Add support for IR tests with @Stable [v3] In-Reply-To: References: Message-ID: > Clean backport to improve IR Framework for upcoming tests. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `testlibrary_tests/ir_framework` passes Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into JDK-8337876-ir-framework-bcp - Backport 0e7c1c1afeaba1c125b70cabe7b1b7a3193ee5c3 - Backport c01f53ac2dab1d4d2cd1e4d45a67f9373d4a9c7e ------------- Changes: - all: https://git.openjdk.org/jdk23u/pull/62/files - new: https://git.openjdk.org/jdk23u/pull/62/files/7ef846f3..fd254946 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk23u&pr=62&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk23u&pr=62&range=01-02 Stats: 3073 lines in 102 files changed: 2280 ins; 486 del; 307 mod Patch: https://git.openjdk.org/jdk23u/pull/62.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/62/head:pull/62 PR: https://git.openjdk.org/jdk23u/pull/62 From shade at openjdk.org Tue Sep 24 08:49:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 24 Sep 2024 08:49:56 GMT Subject: [jdk23u] RFR: 8337876: [IR Framework] Add support for IR tests with @Stable [v2] In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 18:18:22 GMT, Aleksey Shipilev wrote: >> Clean backport to improve IR Framework for upcoming tests. >> >> Additional testing: >> - [x] MacOS AArch64 server fastdebug, `testlibrary_tests/ir_framework` passes > > Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: > > Backport 0e7c1c1afeaba1c125b70cabe7b1b7a3193ee5c3 Both backports are actually clean. The PR is not marked clean because we have two bugs references in it. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/62#issuecomment-2370650368 From shade at openjdk.org Tue Sep 24 09:02:39 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 24 Sep 2024 09:02:39 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts In-Reply-To: References: Message-ID: On Tue, 16 Jul 2024 02:02:06 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [8feabc84](https://github.com/openjdk/jdk/commit/8feabc849ba2f617c8c6dbb2ec5074297beb6437) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 16 Jul 2024 and was reviewed by Jaikiran Pai. > > Thanks! Could you merge from master first, to see that nothing is broken? ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/25#issuecomment-2370685983 From shade at openjdk.org Tue Sep 24 09:02:38 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 24 Sep 2024 09:02:38 GMT Subject: [jdk23u] RFR: 8339416: [s390x] Provide implementation for resolve_global_jobject In-Reply-To: References: <28csfiAISFu4XsPOsiyBNXGzEMaALCvYgN4sUOX8hdA=.a6bb94e4-9fbc-4dc6-ae7e-08f33bd73ba9@github.com> Message-ID: <64LoyBuRmX0YP8u0skHIyEiQjDTiGPE_Erh0F1xKvoI=.37a22d78-bf8d-409b-a3f5-5e9a841a7be9@github.com> On Tue, 24 Sep 2024 04:21:28 GMT, Amit Kumar wrote: >> Hi all, >> >> This pull request contains a backport of commit [ac58b610](https://github.com/openjdk/jdk/commit/ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Amit Kumar on 19 Sep 2024 and was reviewed by Martin Doerr and Lutz Schmidt. >> >> Thanks! > > @RealLucy ? @offamitkumar ? ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/110#issuecomment-2370681755 From amitkumar at openjdk.org Tue Sep 24 09:02:39 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Tue, 24 Sep 2024 09:02:39 GMT Subject: [jdk23u] Integrated: 8339416: [s390x] Provide implementation for resolve_global_jobject In-Reply-To: <28csfiAISFu4XsPOsiyBNXGzEMaALCvYgN4sUOX8hdA=.a6bb94e4-9fbc-4dc6-ae7e-08f33bd73ba9@github.com> References: <28csfiAISFu4XsPOsiyBNXGzEMaALCvYgN4sUOX8hdA=.a6bb94e4-9fbc-4dc6-ae7e-08f33bd73ba9@github.com> Message-ID: On Fri, 20 Sep 2024 04:24:04 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [ac58b610](https://github.com/openjdk/jdk/commit/ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 19 Sep 2024 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! This pull request has now been integrated. Changeset: 8f53f515 Author: Amit Kumar Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/8f53f5155e1906ed5d5de30d5309154fc65d9cd2 Stats: 81 lines in 6 files changed: 70 ins; 4 del; 7 mod 8339416: [s390x] Provide implementation for resolve_global_jobject Backport-of: ac58b6102a26ac2ca7f6df5f176d5b5ca1d00d45 ------------- PR: https://git.openjdk.org/jdk23u/pull/110 From shade at openjdk.org Tue Sep 24 09:03:40 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 24 Sep 2024 09:03:40 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts In-Reply-To: References: Message-ID: On Mon, 29 Jul 2024 10:02:59 GMT, Abhishek N wrote: > 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts Looks to me https://github.com/openjdk/jdk23u/pull/25 was here first, so we would probably integrate that? Going forward, please enable GHA tests for new PRs, see "Pre-submit test status" in "Checks" above. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/40#issuecomment-2370687871 From shade at openjdk.org Tue Sep 24 09:04:44 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 24 Sep 2024 09:04:44 GMT Subject: [jdk23u] RFR: 8337876: [IR Framework] Add support for IR tests with @Stable [v2] In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 08:45:24 GMT, Aleksey Shipilev wrote: >> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: >> >> Backport 0e7c1c1afeaba1c125b70cabe7b1b7a3193ee5c3 > > Both backports are actually clean. The PR is not marked clean because we have two bugs references in it. > @shipilev The `/clean` pull request command is not enabled for this repository :( Need some reviews then, please. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/62#issuecomment-2370691088 From syan at openjdk.org Tue Sep 24 09:13:44 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 24 Sep 2024 09:13:44 GMT Subject: [jdk23u] Integrated: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds In-Reply-To: References: Message-ID: <-8pMVXE6OTjHDPcq3OohWLenHOE78HG-IKBXZ5SIk1g=.27f0f291-37b1-4109-8db0-e88ce970dd30@github.com> On Mon, 9 Sep 2024 07:15:02 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [a18d9d84](https://github.com/openjdk/jdk/commit/a18d9d84cd92b0b7e7c3c83efab1d81773e3a87c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jan Lahoda on 9 Sep 2024 and was reviewed by Aggelos Biboudis. > > Thanks! This pull request has now been integrated. Changeset: a21db48d Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/a21db48de18c02a96e7bc98383255b255a14f335 Stats: 75 lines in 2 files changed: 21 ins; 35 del; 19 mod 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds Backport-of: a18d9d84cd92b0b7e7c3c83efab1d81773e3a87c ------------- PR: https://git.openjdk.org/jdk23u/pull/95 From amitkumar at openjdk.org Tue Sep 24 09:15:42 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Tue, 24 Sep 2024 09:15:42 GMT Subject: [jdk23u] RFR: 8339416: [s390x] Provide implementation for resolve_global_jobject In-Reply-To: <64LoyBuRmX0YP8u0skHIyEiQjDTiGPE_Erh0F1xKvoI=.37a22d78-bf8d-409b-a3f5-5e9a841a7be9@github.com> References: <28csfiAISFu4XsPOsiyBNXGzEMaALCvYgN4sUOX8hdA=.a6bb94e4-9fbc-4dc6-ae7e-08f33bd73ba9@github.com> <64LoyBuRmX0YP8u0skHIyEiQjDTiGPE_Erh0F1xKvoI=.37a22d78-bf8d-409b-a3f5-5e9a841a7be9@github.com> Message-ID: On Tue, 24 Sep 2024 08:58:39 GMT, Aleksey Shipilev wrote: >> @RealLucy ? > > @offamitkumar ? Thanks @shipilev :-) ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/110#issuecomment-2370717742 From syan at openjdk.org Tue Sep 24 09:16:23 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 24 Sep 2024 09:16:23 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [8feabc84](https://github.com/openjdk/jdk/commit/8feabc849ba2f617c8c6dbb2ec5074297beb6437) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 16 Jul 2024 and was reviewed by Jaikiran Pai. > > Thanks! SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-sendaoYan-8feabc84-master - Backport 8feabc849ba2f617c8c6dbb2ec5074297beb6437 ------------- Changes: - all: https://git.openjdk.org/jdk23u/pull/25/files - new: https://git.openjdk.org/jdk23u/pull/25/files/8c2ca4be..6dc92654 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk23u&pr=25&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk23u&pr=25&range=00-01 Stats: 15152 lines in 253 files changed: 13649 ins; 813 del; 690 mod Patch: https://git.openjdk.org/jdk23u/pull/25.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/25/head:pull/25 PR: https://git.openjdk.org/jdk23u/pull/25 From syan at openjdk.org Tue Sep 24 09:16:23 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 24 Sep 2024 09:16:23 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 09:00:25 GMT, Aleksey Shipilev wrote: > Could you merge from master first, to see that nothing is broken? Okey ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/25#issuecomment-2370714263 From syan at openjdk.org Tue Sep 24 09:17:36 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 24 Sep 2024 09:17:36 GMT Subject: [jdk23u] RFR: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 07:15:02 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [a18d9d84](https://github.com/openjdk/jdk/commit/a18d9d84cd92b0b7e7c3c83efab1d81773e3a87c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jan Lahoda on 9 Sep 2024 and was reviewed by Aggelos Biboudis. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/95#issuecomment-2370721099 From eastigeevich at openjdk.org Tue Sep 24 09:33:37 2024 From: eastigeevich at openjdk.org (Evgeny Astigeevich) Date: Tue, 24 Sep 2024 09:33:37 GMT Subject: [jdk23u] RFR: 8337876: [IR Framework] Add support for IR tests with @Stable [v3] In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 08:49:56 GMT, Aleksey Shipilev wrote: >> Clean backport to improve IR Framework for upcoming tests. >> >> Additional testing: >> - [x] MacOS AArch64 server fastdebug, `testlibrary_tests/ir_framework` passes > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into JDK-8337876-ir-framework-bcp > - Backport 0e7c1c1afeaba1c125b70cabe7b1b7a3193ee5c3 > - Backport c01f53ac2dab1d4d2cd1e4d45a67f9373d4a9c7e Confirming it's a clean backport. ------------- Marked as reviewed by eastigeevich (Author). PR Review: https://git.openjdk.org/jdk23u/pull/62#pullrequestreview-2324668940 From duke at openjdk.org Tue Sep 24 09:44:40 2024 From: duke at openjdk.org (duke) Date: Tue, 24 Sep 2024 09:44:40 GMT Subject: [jdk23u] RFR: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs In-Reply-To: References: Message-ID: <7_QIWclW0QC-68bs6sPBTYAqD6_GA2lCJwRLUJoad98=.e15c91a0-e8b1-41a0-9847-dcce43bc750b@github.com> On Tue, 17 Sep 2024 11:56:56 GMT, Yagmur Eren wrote: > Backport of [JDK-8339384](https://bugs.openjdk.org/browse/JDK-8339384) @nelanbu Your change (at version ddc152a7032c1a4bfe5d73636f6f1b456f676d57) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/99#issuecomment-2370787579 From kevinw at openjdk.org Tue Sep 24 09:55:43 2024 From: kevinw at openjdk.org (Kevin Walls) Date: Tue, 24 Sep 2024 09:55:43 GMT Subject: [jdk23u] RFR: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs In-Reply-To: References: Message-ID: On Tue, 17 Sep 2024 11:56:56 GMT, Yagmur Eren wrote: > Backport of [JDK-8339384](https://bugs.openjdk.org/browse/JDK-8339384) looks good. ------------- Marked as reviewed by kevinw (Committer). PR Review: https://git.openjdk.org/jdk23u/pull/99#pullrequestreview-2324722580 From duke at openjdk.org Tue Sep 24 09:55:44 2024 From: duke at openjdk.org (Yagmur Eren) Date: Tue, 24 Sep 2024 09:55:44 GMT Subject: [jdk23u] Integrated: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs In-Reply-To: References: Message-ID: <71_GOgXZBq43kXeOZEq9QjjdALOE-p8qU26xlqnQWGY=.18de8ddc-5dc1-4f53-93eb-8d305862392e@github.com> On Tue, 17 Sep 2024 11:56:56 GMT, Yagmur Eren wrote: > Backport of [JDK-8339384](https://bugs.openjdk.org/browse/JDK-8339384) This pull request has now been integrated. Changeset: 7f9c4ab4 Author: Yagmur Eren Committer: Kevin Walls URL: https://git.openjdk.org/jdk23u/commit/7f9c4ab4e59ff27cfa8d5273153e5ec4c01fb9a2 Stats: 4 lines in 1 file changed: 2 ins; 1 del; 1 mod 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs Reviewed-by: kevinw Backport-of: 2305d18e8d53dbbf341b580b60f9ed21f408bff1 ------------- PR: https://git.openjdk.org/jdk23u/pull/99 From sgehwolf at openjdk.org Tue Sep 24 11:05:44 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 24 Sep 2024 11:05:44 GMT Subject: [jdk21u-dev] RFR: 6942632: Hotspot should be able to use more than 64 logical processors on Windows In-Reply-To: References: <2coHSZZXFN7EQtSqhEuq3uM01sX9UqpOpvAMZBuowEw=.045fbe79-cd99-4b58-a756-895fc8ab0bf7@github.com> Message-ID: On Mon, 23 Sep 2024 21:44:47 GMT, Saint Wesonga wrote: > > @swesonga Please add an appropriate fix request comment to the bug when it's being asked for approval. Currently there is none. It should mention the testing you've done and the estimated risk (with a reason) for bringing this patch to 21u. Meanwhile I'll remove the approval label. Also, I don't see the CSR for 21-pool as approved (it's still in provisional). > > Hi @jerboaa, I updated https://bugs.openjdk.org/browse/JDK-6942632 with a fix request comment describing the testing and risk and the CSR has also been approved. Please let me know if there is anything else needed for this PR. This PR is ready for integration. See https://github.com/openjdk/jdk21u-dev/pull/881#event-13986519980 It has the `ready` label. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/881#issuecomment-2370946464 From sgehwolf at openjdk.org Tue Sep 24 11:11:48 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 24 Sep 2024 11:11:48 GMT Subject: [jdk11u-dev] RFR: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 08:59:31 GMT, Antonio Vieiro wrote: > The `macos-11` github runners [were deprecated and removed in June 2024](https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/) , making the `macos` tests to hang in `openjdk11u-dev` (and other OpenJDK repositories). > > [JDK-8335793 GHA: Bump macOS and Xcode versions](https://bugs.openjdk.org/browse/JDK-8335793) upgraded the version [from `macos-11` to `macos-13`](https://github.com/openjdk/jdk11u-dev/pull/2835). This upgrade in github runners required a long list of changes in `openjdk11u-dev` that proved difficult to review. > > In order to ease the review process this PR downgrades the version of github runners in `jdk11u-dev` from the current `macos-13` to `macos-12` and `xcode-13.4.1`. This will require a single backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) (a follow-up to this PR), making the review process easier. > > Once the github actions are running again in `macos-12` an upgrade to `macos-13` could be performed, if required, with some more additional PRs. Thanks. We need a 11u non-backport PR for this. On second thought, this PR is labelled backport. It's an 11u specific bug. Please close this PR and open a new - non-backport pr. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2936#pullrequestreview-2324887673 Changes requested by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2936#pullrequestreview-2324892906 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2936#issuecomment-2370956040 From mbaesken at openjdk.org Tue Sep 24 11:52:06 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 24 Sep 2024 11:52:06 GMT Subject: [jdk21u-dev] RFR: 8340387: Update OS detection code to recognize Windows Server 2025 Message-ID: <7umifdYOkXaVSP3FCtyFdCVygBNxBA0u3egSQCWDA3U=.632b9797-63b9-4c36-b4f7-20bef9a2add2@github.com> 8340387: Update OS detection code to recognize Windows Server 2025 ------------- Commit messages: - Backport 34cddfbedd20d5804cab8044fbc402564e98eb9c Changes: https://git.openjdk.org/jdk21u-dev/pull/1006/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1006&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340387 Stats: 11 lines in 2 files changed: 8 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1006.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1006/head:pull/1006 PR: https://git.openjdk.org/jdk21u-dev/pull/1006 From mbaesken at openjdk.org Tue Sep 24 11:52:11 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 24 Sep 2024 11:52:11 GMT Subject: [jdk23u] RFR: 8340387: Update OS detection code to recognize Windows Server 2025 Message-ID: 8340387: Update OS detection code to recognize Windows Server 2025 ------------- Commit messages: - Backport 34cddfbedd20d5804cab8044fbc402564e98eb9c Changes: https://git.openjdk.org/jdk23u/pull/119/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=119&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340387 Stats: 11 lines in 2 files changed: 8 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk23u/pull/119.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/119/head:pull/119 PR: https://git.openjdk.org/jdk23u/pull/119 From lmao at openjdk.org Tue Sep 24 11:52:41 2024 From: lmao at openjdk.org (Liang Mao) Date: Tue, 24 Sep 2024 11:52:41 GMT Subject: [jdk23u] Integrated: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 03:40:37 GMT, Liang Mao wrote: > Backport of concurrent GC crash due to GetMethodDeclaringClass. The backport is not clean because of make file. This pull request has now been integrated. Changeset: c212fe63 Author: Liang Mao Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/c212fe63a18e966451c39cba8a5cef6d5236f105 Stats: 244 lines in 5 files changed: 241 ins; 0 del; 3 mod 8339725: Concurrent GC crashed due to GetMethodDeclaringClass Backport-of: c91fa278fe17ab204beef0fcef1ada6dd0bc37bb ------------- PR: https://git.openjdk.org/jdk23u/pull/117 From shade at openjdk.org Tue Sep 24 11:52:43 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 24 Sep 2024 11:52:43 GMT Subject: [jdk21u-dev] RFR: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 03:22:59 GMT, Liang Mao wrote: > Backport of fixing concurrent GC crashed due to GetMethodDeclaringClass. Not clean because of make file. It might be too fresh to go into jdk21u-dev, but on the other hand, the fix looks simple. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1004#pullrequestreview-2324989243 From goetz at openjdk.org Tue Sep 24 12:12:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 12:12:45 GMT Subject: [jdk17u-dev] Integrated: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 07:06:29 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing in 17. This pull request has now been integrated. Changeset: ed2c4b68 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ed2c4b6894f9bca05f5090c1f295dbc8c2e326f0 Stats: 316 lines in 3 files changed: 226 ins; 90 del; 0 mod 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose Backport-of: f0b7eb519ae1cf6f4cb2baea55b5e02a46a8192e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2913 From sroy at openjdk.org Tue Sep 24 12:13:41 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Tue, 24 Sep 2024 12:13:41 GMT Subject: [jdk17u-dev] RFR: 8273979: move some os time related functions to os_posix for POSIX platforms In-Reply-To: References: Message-ID: <5I5Ho4fHp1u17cMKxKt3nowFw8j4_Qn2UO8J9suFURQ=.306b3495-44d5-45cc-8a20-eab992e8b328@github.com> On Thu, 5 Sep 2024 10:02:20 GMT, Radim Vansa wrote: >> Hi @rvansa >> I am not so happy about this backport. >> Simplifying another project is not an eligible reason to backport things. >> Also, you did not test macos and expecially not aix. Does that still build? > > Hi @GoeLin , understood, though I am rather trying to be honest than making up a synthetic argument. Since it was accepted in the mainline I could say that it is an improvement in code quality. > > MacOS should be tested here in GHA, regrettably I don't know where to get AIX for testing. @rvansa I am currently facing some issue with my AIX development machine. Some migration in progress. By When are you expecting this to be tested? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2831#issuecomment-2371094773 From duke at openjdk.org Tue Sep 24 12:52:41 2024 From: duke at openjdk.org (duke) Date: Tue, 24 Sep 2024 12:52:41 GMT Subject: [jdk17u-dev] RFR: 8325616: JFR ZGC Allocation Stall events should record stack traces In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 15:09:03 GMT, Kerem Kat wrote: > Backport of JDK-8325616, conflict in a single hunk that wants to add `ZYoungGarbageCollection` and `ZOldGarbageCollection` to `metadata.xml`, which are unrelated and part of GenZGC. > > #### Verification > > 1. Ran jdk_jfr and hotspot_gc tests. All tests passed. > > ``` > make test TEST=hotspot_gc TEST_VM_OPTS=-XX:+UseZGC > make test TEST=jdk_jdr TEST_VM_OPTS=-XX:+UseZGC > ``` > > 2. `ZAllocationStall` event has stack trace entry in the jfr for a sample java program: > > > jdk.ZAllocationStall { > startTime = 15:07:54.691 > duration = 4.48 ms > type = "Large" > size = 12.0 MB > eventThread = "main" (javaThreadId = 1) > stackTrace = [ > AllocRate.main(String[]) line: 16 > ] > } @krk Your change (at version 9344fd678ae7a0db71f9b5b2f143d5add0e6e2f2) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2898#issuecomment-2371182396 From gdams at openjdk.org Tue Sep 24 12:59:08 2024 From: gdams at openjdk.org (George Adams) Date: Tue, 24 Sep 2024 12:59:08 GMT Subject: [jdk23u] RFR: 8340383: VM issues warning failure to find kernel32.dll on Windows nanoserver Message-ID: On Windows Nanoserver the kernel32.dll is not within the System32 directory itself but within the "forwarders" sub-folder. See a similar bug reported in dotnet a while back: https://github.com/dotnet/sdk/issues/6056 ------------- Commit messages: - Backport 3c97d2437d34d2db47f3607fbb95ac3b8e2ec60b Changes: https://git.openjdk.org/jdk23u/pull/120/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=120&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340383 Stats: 40 lines in 1 file changed: 39 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/120.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/120/head:pull/120 PR: https://git.openjdk.org/jdk23u/pull/120 From duke at openjdk.org Tue Sep 24 13:03:42 2024 From: duke at openjdk.org (Kerem Kat) Date: Tue, 24 Sep 2024 13:03:42 GMT Subject: [jdk17u-dev] Integrated: 8325616: JFR ZGC Allocation Stall events should record stack traces In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 15:09:03 GMT, Kerem Kat wrote: > Backport of JDK-8325616, conflict in a single hunk that wants to add `ZYoungGarbageCollection` and `ZOldGarbageCollection` to `metadata.xml`, which are unrelated and part of GenZGC. > > #### Verification > > 1. Ran jdk_jfr and hotspot_gc tests. All tests passed. > > ``` > make test TEST=hotspot_gc TEST_VM_OPTS=-XX:+UseZGC > make test TEST=jdk_jdr TEST_VM_OPTS=-XX:+UseZGC > ``` > > 2. `ZAllocationStall` event has stack trace entry in the jfr for a sample java program: > > > jdk.ZAllocationStall { > startTime = 15:07:54.691 > duration = 4.48 ms > type = "Large" > size = 12.0 MB > eventThread = "main" (javaThreadId = 1) > stackTrace = [ > AllocRate.main(String[]) line: 16 > ] > } This pull request has now been integrated. Changeset: e77aad9b Author: Kerem Kat Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/e77aad9b64028f2a9f88d21721f68faa8ad36b75 Stats: 3 lines in 3 files changed: 2 ins; 0 del; 1 mod 8325616: JFR ZGC Allocation Stall events should record stack traces Backport-of: 71ff2d717798f1f314b97d97dfbc2b859fb47ae3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2898 From shade at openjdk.org Tue Sep 24 13:07:19 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 24 Sep 2024 13:07:19 GMT Subject: [jdk21u-dev] RFR: 8300148: Consider using a StoreStore barrier instead of Release barrier on ctor exit Message-ID: The backport is not clean because the hunk in `macro.cpp` does not apply to JDK 21, because it was added later with [JDK-8287061](https://bugs.openjdk.org/browse/JDK-8287061). Additional testing: - [x] New benchmark improves - [x] New IR test passes - [x] Linux AArch64 server fastdebug, `all` - [x] Linux x86_64 server fastdebug, `all` ------------- Commit messages: - Backport 1d06170758bd76a0ea32e5bb7d4a017e829ae710 Changes: https://git.openjdk.org/jdk21u-dev/pull/530/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=530&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300148 Stats: 606 lines in 8 files changed: 602 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/530.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/530/head:pull/530 PR: https://git.openjdk.org/jdk21u-dev/pull/530 From shade at openjdk.org Tue Sep 24 13:07:19 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 24 Sep 2024 13:07:19 GMT Subject: [jdk21u-dev] RFR: 8300148: Consider using a StoreStore barrier instead of Release barrier on ctor exit In-Reply-To: References: Message-ID: On Wed, 24 Apr 2024 19:02:10 GMT, Aleksey Shipilev wrote: > The backport is not clean because the hunk in `macro.cpp` does not apply to JDK 21, because it was added later with [JDK-8287061](https://bugs.openjdk.org/browse/JDK-8287061). > > Additional testing: > - [x] New benchmark improves > - [x] New IR test passes > - [x] Linux AArch64 server fastdebug, `all` > - [x] Linux x86_64 server fastdebug, `all` Not now, bot. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/530#issuecomment-2191071586 From mdoerr at openjdk.org Tue Sep 24 13:28:01 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 24 Sep 2024 13:28:01 GMT Subject: [jdk21u-dev] RFR: 8340657: [PPC64] SA determines wrong unextendedSP Message-ID: <42R6318VN9Uv2-mQwKxK77dG7bxBY_9wfyqVtGsBvLY=.6edc7a5f-ec6e-4ab3-9110-b87efbe34f0f@github.com> Clean backport of [JDK-8340657](https://bugs.openjdk.org/browse/JDK-8340657). ------------- Commit messages: - Backport 49d15edd31c863faf3722af1bae8b50662ecf71f Changes: https://git.openjdk.org/jdk21u-dev/pull/1007/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1007&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340657 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1007.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1007/head:pull/1007 PR: https://git.openjdk.org/jdk21u-dev/pull/1007 From mdoerr at openjdk.org Tue Sep 24 13:37:12 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 24 Sep 2024 13:37:12 GMT Subject: [jdk17u-dev] RFR: 8340657: [PPC64] SA determines wrong unextendedSP Message-ID: Clean backport of [JDK-8340657](https://bugs.openjdk.org/browse/JDK-8340657). ------------- Commit messages: - Backport 49d15edd31c863faf3722af1bae8b50662ecf71f Changes: https://git.openjdk.org/jdk17u-dev/pull/2915/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2915&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340657 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2915.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2915/head:pull/2915 PR: https://git.openjdk.org/jdk17u-dev/pull/2915 From rehn at openjdk.org Tue Sep 24 13:53:42 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Tue, 24 Sep 2024 13:53:42 GMT Subject: [jdk21u-dev] Integrated: 8339741: RISC-V: C ABI breakage for integer on stack In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 13:12:28 GMT, Robbin Ehn wrote: > Hi all, > > This pull request contains a backport of commit [bfe7f920](https://github.com/openjdk/jdk/commit/bfe7f9205b56483b4364130a3a87c58c3fc82998) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry. > > Thanks! This pull request has now been integrated. Changeset: 37f576d7 Author: Robbin Ehn URL: https://git.openjdk.org/jdk21u-dev/commit/37f576d7861a6d4a27bb2c7c3f5a42e645d1baf2 Stats: 156 lines in 4 files changed: 150 ins; 0 del; 6 mod 8339741: RISC-V: C ABI breakage for integer on stack Backport-of: bfe7f9205b56483b4364130a3a87c58c3fc82998 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1002 From goetz at openjdk.org Tue Sep 24 14:20:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 14:20:09 GMT Subject: [jdk21u-dev] RFR: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 21e86d10a726fe707febb0111f5b80d8d1d29f03 Changes: https://git.openjdk.org/jdk21u-dev/pull/1008/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1008&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334405 Stats: 42 lines in 1 file changed: 28 ins; 5 del; 9 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1008.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1008/head:pull/1008 PR: https://git.openjdk.org/jdk21u-dev/pull/1008 From goetz at openjdk.org Tue Sep 24 14:20:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 14:20:16 GMT Subject: [jdk21u-dev] RFR: 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport c9bee173d61f4accfc4adc280ab5d21600191756 Changes: https://git.openjdk.org/jdk21u-dev/pull/1009/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1009&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331391 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1009.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1009/head:pull/1009 PR: https://git.openjdk.org/jdk21u-dev/pull/1009 From duke at openjdk.org Tue Sep 24 14:25:37 2024 From: duke at openjdk.org (duke) Date: Tue, 24 Sep 2024 14:25:37 GMT Subject: [jdk21u-dev] RFR: 6942632: Hotspot should be able to use more than 64 logical processors on Windows In-Reply-To: <2coHSZZXFN7EQtSqhEuq3uM01sX9UqpOpvAMZBuowEw=.045fbe79-cd99-4b58-a756-895fc8ab0bf7@github.com> References: <2coHSZZXFN7EQtSqhEuq3uM01sX9UqpOpvAMZBuowEw=.045fbe79-cd99-4b58-a756-895fc8ab0bf7@github.com> Message-ID: On Tue, 30 Jul 2024 19:05:36 GMT, Saint Wesonga wrote: > Clean backport of support for >64 logical processors on Windows (https://github.com/openjdk/jdk/pull/17576) to jdk21. @swesonga Your change (at version 540948635ae71e0e4b6d8a17cbdb0debc2e1393c) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/881#issuecomment-2371448623 From goetz at openjdk.org Tue Sep 24 14:33:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Sep 2024 14:33:51 GMT Subject: [jdk17u-dev] RFR: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect Message-ID: I backport this for parity with 17.0.14-oracle. Resolved Copyright. Probably clean. ------------- Commit messages: - Backport 21e86d10a726fe707febb0111f5b80d8d1d29f03 Changes: https://git.openjdk.org/jdk17u-dev/pull/2916/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2916&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334405 Stats: 42 lines in 1 file changed: 28 ins; 5 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2916.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2916/head:pull/2916 PR: https://git.openjdk.org/jdk17u-dev/pull/2916 From shade at openjdk.org Tue Sep 24 15:44:42 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 24 Sep 2024 15:44:42 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts [v2] In-Reply-To: References: Message-ID: <-Pi-M9_1BYoQZ3S3_Y0tJPrHFVcFNvXsh_1u-A-Zb8U=.77af0f9b-b827-4857-b728-8bb40fe1bdb0@github.com> On Tue, 24 Sep 2024 09:16:23 GMT, SendaoYan wrote: >> Hi all, >> >> This pull request contains a backport of commit [8feabc84](https://github.com/openjdk/jdk/commit/8feabc849ba2f617c8c6dbb2ec5074297beb6437) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by SendaoYan on 16 Jul 2024 and was reviewed by Jaikiran Pai. >> >> Thanks! > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-8feabc84-master > - Backport 8feabc849ba2f617c8c6dbb2ec5074297beb6437 I think this PR is basically fine. Mac jobs would catch up. You can request integration again, and I'll sponsor. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/25#issuecomment-2371669440 From shade at openjdk.org Tue Sep 24 15:51:34 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 24 Sep 2024 15:51:34 GMT Subject: [jdk21u-dev] RFR: 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 [v3] In-Reply-To: <5VtI93ebemu9HNAzcz54lzHFSd4jef9H0gPaRR0WBXk=.d2b83b05-f0f3-483a-be1a-7434175a9201@github.com> References: <5VtI93ebemu9HNAzcz54lzHFSd4jef9H0gPaRR0WBXk=.d2b83b05-f0f3-483a-be1a-7434175a9201@github.com> Message-ID: > Uncleanliness comes from JDK 21 not having [JDK-8313882](https://bugs.openjdk.org/browse/JDK-8313882), so I had to rewrite the incoming hunks back to `INT64_FORMAT` and `int64_t` casts. This can be made clean by [JDK-8313882](https://bugs.openjdk.org/browse/JDK-8313882) backport, but it has follow-up bugs that break Graal. It seems a better choice to just do a little deviation here. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, new regression tests fail without the fix, pass with it > - [x] Linux AArch64 server fastdebug, `all` > - [x] Linux x86_64 server fastdebug, `all` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8327743-loom-jni-monitor-count - Backport 274c805c5137d9080a7670d864ecca8a0befc3f6 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/523/files - new: https://git.openjdk.org/jdk21u-dev/pull/523/files/29e62b8b..c736dedf Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=523&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=523&range=01-02 Stats: 5212 lines in 134 files changed: 3770 ins; 773 del; 669 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/523.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/523/head:pull/523 PR: https://git.openjdk.org/jdk21u-dev/pull/523 From duke at openjdk.org Tue Sep 24 19:58:41 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 24 Sep 2024 19:58:41 GMT Subject: [jdk11u-dev] Withdrawn: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 08:59:31 GMT, Antonio Vieiro wrote: > The `macos-11` github runners [were deprecated and removed in June 2024](https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/) , making the `macos` tests to hang in `openjdk11u-dev` (and other OpenJDK repositories). > > [JDK-8335793 GHA: Bump macOS and Xcode versions](https://bugs.openjdk.org/browse/JDK-8335793) upgraded the version [from `macos-11` to `macos-13`](https://github.com/openjdk/jdk11u-dev/pull/2835). This upgrade in github runners required a long list of changes in `openjdk11u-dev` that proved difficult to review. > > In order to ease the review process this PR downgrades the version of github runners in `jdk11u-dev` from the current `macos-13` to `macos-12` and `xcode-13.4.1`. This will require a single backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) (a follow-up to this PR), making the review process easier. > > Once the github actions are running again in `macos-12` an upgrade to `macos-13` could be performed, if required, with some more additional PRs. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2936 From duke at openjdk.org Tue Sep 24 20:07:54 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 24 Sep 2024 20:07:54 GMT Subject: [jdk11u-dev] RFR: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 Message-ID: The macos-11 github runners [were deprecated and removed in June 2024](https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/) , making the macos tests to hang in openjdk11u-dev (and other OpenJDK repositories). [JDK-8335793 GHA: Bump macOS and Xcode versions](https://bugs.openjdk.org/browse/JDK-8335793) upgraded the version https://github.com/openjdk/jdk11u-dev/pull/2835 of mac runners to macos-13. This upgrade in github runners required a long list of changes in openjdk11u-dev that proved difficult to review. In order to ease the review process this PR downgrades the version of github runners in jdk11u-dev from the current macos-13 to macos-12 and xcode-13.4.1. This will require a single backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) (a follow-up to this PR), making the review process easier. Once the github actions are running again in macos-12 an upgrade to macos-13 could be performed, if required, with some more additional PRs. ------------- Commit messages: - 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 Changes: https://git.openjdk.org/jdk11u-dev/pull/2940/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2940&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340671 Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2940.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2940/head:pull/2940 PR: https://git.openjdk.org/jdk11u-dev/pull/2940 From duke at openjdk.org Tue Sep 24 20:14:53 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 24 Sep 2024 20:14:53 GMT Subject: [jdk11u-dev] RFR: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 08:59:31 GMT, Antonio Vieiro wrote: > The `macos-11` github runners [were deprecated and removed in June 2024](https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/) , making the `macos` tests to hang in `openjdk11u-dev` (and other OpenJDK repositories). > > [JDK-8335793 GHA: Bump macOS and Xcode versions](https://bugs.openjdk.org/browse/JDK-8335793) upgraded the version [from `macos-11` to `macos-13`](https://github.com/openjdk/jdk11u-dev/pull/2835). This upgrade in github runners required a long list of changes in `openjdk11u-dev` that proved difficult to review. > > In order to ease the review process this PR downgrades the version of github runners in `jdk11u-dev` from the current `macos-13` to `macos-12` and `xcode-13.4.1`. This will require a single backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) (a follow-up to this PR), making the review process easier. > > Once the github actions are running again in `macos-12` an upgrade to `macos-13` could be performed, if required, with some more additional PRs. Reopened as https://github.com/openjdk/jdk11u-dev/pull/2940 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2936#issuecomment-2372280093 From duke at openjdk.org Tue Sep 24 20:19:36 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 24 Sep 2024 20:19:36 GMT Subject: [jdk11u-dev] RFR: 8299254: Support dealing with standard assert macro [v2] In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 09:55:25 GMT, Antonio Vieiro wrote: >> Backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) on top of the previous PR [`macos-12` github actions ](https://github.com/openjdk/jdk11u-dev/pull/2940). >> >> This will make the github actions in `jdk11u-dev` run again on top of `macos-12` / `xcode-13.4.1` . >> >> The change is minimal, and should work properly with no changes on any existing `macos-11` CI pipelines. > > Antonio Vieiro has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 89dd23f2fab0d98879e68f817923656e113087e3 Rebased on top of #2940 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2937#issuecomment-2372293055 From phh at openjdk.org Tue Sep 24 20:44:42 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 24 Sep 2024 20:44:42 GMT Subject: [jdk21u-dev] RFR: 8300148: Consider using a StoreStore barrier instead of Release barrier on ctor exit In-Reply-To: References: Message-ID: On Wed, 24 Apr 2024 19:02:10 GMT, Aleksey Shipilev wrote: > The backport is not clean because the hunk in `macro.cpp` does not apply to JDK 21, because it was added later with [JDK-8287061](https://bugs.openjdk.org/browse/JDK-8287061). > > We have been carrying this patch in our internal releases for 4 months, with some services using it successfully. It is time to bring it to JDK 21u. > > Additional testing: > - [x] New benchmark improves > - [x] New IR test passes > - [x] Linux AArch64 server fastdebug, `all` > - [x] Linux x86_64 server fastdebug, `all` Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/530#pullrequestreview-2326440418 From phh at openjdk.org Tue Sep 24 20:50:47 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 24 Sep 2024 20:50:47 GMT Subject: [jdk21u-dev] RFR: 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 [v3] In-Reply-To: References: <5VtI93ebemu9HNAzcz54lzHFSd4jef9H0gPaRR0WBXk=.d2b83b05-f0f3-483a-be1a-7434175a9201@github.com> Message-ID: <4glQEaBrzEKqxT3DBSnNZzhzYrptQLZIleXKjvu2lsQ=.6cc721b4-ec22-4405-afc1-c5cd61184122@github.com> On Tue, 24 Sep 2024 15:51:34 GMT, Aleksey Shipilev wrote: >> Uncleanliness comes from JDK 21 not having [JDK-8313882](https://bugs.openjdk.org/browse/JDK-8313882), so I had to rewrite the incoming hunks back to `INT64_FORMAT` and `int64_t` casts. This can be made clean by [JDK-8313882](https://bugs.openjdk.org/browse/JDK-8313882) backport, but it has follow-up bugs that break Graal. It seems a better choice to just do a little deviation here. >> >> Additional testing: >> - [x] MacOS AArch64 server fastdebug, new regression tests fail without the fix, pass with it >> - [x] Linux AArch64 server fastdebug, `all` >> - [x] Linux x86_64 server fastdebug, `all` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8327743-loom-jni-monitor-count > - Backport 274c805c5137d9080a7670d864ecca8a0befc3f6 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/523#pullrequestreview-2326450450 From phh at openjdk.org Tue Sep 24 20:55:42 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 24 Sep 2024 20:55:42 GMT Subject: [jdk23u] RFR: 8337876: [IR Framework] Add support for IR tests with @Stable [v3] In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 08:49:56 GMT, Aleksey Shipilev wrote: >> Clean backport to improve IR Framework for upcoming tests. >> >> Additional testing: >> - [x] MacOS AArch64 server fastdebug, `testlibrary_tests/ir_framework` passes > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into JDK-8337876-ir-framework-bcp > - Backport 0e7c1c1afeaba1c125b70cabe7b1b7a3193ee5c3 > - Backport c01f53ac2dab1d4d2cd1e4d45a67f9373d4a9c7e Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk23u/pull/62#pullrequestreview-2326459555 From gdams at openjdk.org Tue Sep 24 21:41:13 2024 From: gdams at openjdk.org (George Adams) Date: Tue, 24 Sep 2024 21:41:13 GMT Subject: [jdk23u] RFR: 8340804: doc/building.md update Xcode instructions to note that full install is required Message-ID: Since JDK17 there has been a dependency on metal in the macOS builds which is only available as part of the full Xcode IDE (rather than command-line tools). We currently recommend only installing the command-line tools in the building.md doc which is incorrect. ------------- Commit messages: - Backport b639661e797fb52ce32ce397a153c886fdc40f53 Changes: https://git.openjdk.org/jdk23u/pull/121/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=121&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340804 Stats: 11 lines in 2 files changed: 0 ins; 5 del; 6 mod Patch: https://git.openjdk.org/jdk23u/pull/121.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/121/head:pull/121 PR: https://git.openjdk.org/jdk23u/pull/121 From syan at openjdk.org Wed Sep 25 01:28:39 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 25 Sep 2024 01:28:39 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts [v2] In-Reply-To: <-Pi-M9_1BYoQZ3S3_Y0tJPrHFVcFNvXsh_1u-A-Zb8U=.77af0f9b-b827-4857-b728-8bb40fe1bdb0@github.com> References: <-Pi-M9_1BYoQZ3S3_Y0tJPrHFVcFNvXsh_1u-A-Zb8U=.77af0f9b-b827-4857-b728-8bb40fe1bdb0@github.com> Message-ID: On Tue, 24 Sep 2024 15:42:07 GMT, Aleksey Shipilev wrote: > I think this PR is basically fine. Mac jobs would catch up. You can request integration again, and I'll sponsor. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/25#issuecomment-2372682335 From duke at openjdk.org Wed Sep 25 01:28:41 2024 From: duke at openjdk.org (duke) Date: Wed, 25 Sep 2024 01:28:41 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts [v2] In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 09:16:23 GMT, SendaoYan wrote: >> Hi all, >> >> This pull request contains a backport of commit [8feabc84](https://github.com/openjdk/jdk/commit/8feabc849ba2f617c8c6dbb2ec5074297beb6437) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by SendaoYan on 16 Jul 2024 and was reviewed by Jaikiran Pai. >> >> Thanks! > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-8feabc84-master > - Backport 8feabc849ba2f617c8c6dbb2ec5074297beb6437 @sendaoYan Your change (at version 6dc926549a9fbb2572a40a448daf82abc2be451d) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/25#issuecomment-2372683315 From andrewlu at openjdk.org Wed Sep 25 02:01:50 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 25 Sep 2024 02:01:50 GMT Subject: [jdk17u-dev] Integrated: 8327401: Some jtreg tests fail on Wayland without any tracking bug In-Reply-To: References: Message-ID: <-CPYidMu6eEr6R2c_J9Uk-GbD2m4vuGxXHuH95ORzdI=.baa69c5c-f0c1-4474-82a9-39511e77f248@github.com> On Wed, 18 Sep 2024 06:50:18 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. > For this file test/jdk/java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java > ignored 8267374: macOS: Option+Up/Down Arrow don't traverse to beginning/end of line in JTextArea and 8157173: [macosx] java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java fails This pull request has now been integrated. Changeset: 89a9243c Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/89a9243cd77c2823e02a8eff641f7642560082ac Stats: 736 lines in 24 files changed: 300 ins; 213 del; 223 mod 8327401: Some jtreg tests fail on Wayland without any tracking bug 8312111: open/test/jdk/java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java fails on ubuntu 23.04 Reviewed-by: goetz Backport-of: 286cc163fd4f8361a633dcb6494965020d02b506 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2888 From duke at openjdk.org Wed Sep 25 05:43:04 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 25 Sep 2024 05:43:04 GMT Subject: [jdk11u-dev] RFR: 8299254: Support dealing with standard assert macro [v3] In-Reply-To: References: Message-ID: > Backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) on top of the previous PR [`macos-12` github actions ](https://github.com/openjdk/jdk11u-dev/pull/2940). > > This will make the github actions in `jdk11u-dev` run again on top of `macos-12` / `xcode-13.4.1` . > > The change is minimal, and should work properly with no changes on any existing `macos-11` CI pipelines. Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 89dd23f2fab0d98879e68f817923656e113087e3 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/2937/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2937&range=02 Stats: 100 lines in 6 files changed: 93 ins; 2 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2937.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2937/head:pull/2937 PR: https://git.openjdk.org/jdk11u-dev/pull/2937 From syan at openjdk.org Wed Sep 25 06:26:45 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 25 Sep 2024 06:26:45 GMT Subject: [jdk23u] Integrated: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts In-Reply-To: References: Message-ID: <2rbMVsFrX_v4QA4ZeBQxf4nYOhblg8qY-VejCfHDh74=.a7aa0c8b-73d4-4ab2-90dc-ef76971829b6@github.com> On Tue, 16 Jul 2024 02:02:06 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [8feabc84](https://github.com/openjdk/jdk/commit/8feabc849ba2f617c8c6dbb2ec5074297beb6437) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 16 Jul 2024 and was reviewed by Jaikiran Pai. > > Thanks! This pull request has now been integrated. Changeset: 547a229b Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/547a229b53a93809b6b585deefbf9c8be1fef3ae Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts Backport-of: 8feabc849ba2f617c8c6dbb2ec5074297beb6437 ------------- PR: https://git.openjdk.org/jdk23u/pull/25 From shade at openjdk.org Wed Sep 25 06:27:47 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 25 Sep 2024 06:27:47 GMT Subject: [jdk23u] RFR: 8337876: [IR Framework] Add support for IR tests with @Stable [v3] In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 08:49:56 GMT, Aleksey Shipilev wrote: >> Clean backport to improve IR Framework for upcoming tests. >> >> Additional testing: >> - [x] MacOS AArch64 server fastdebug, `testlibrary_tests/ir_framework` passes > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into JDK-8337876-ir-framework-bcp > - Backport 0e7c1c1afeaba1c125b70cabe7b1b7a3193ee5c3 > - Backport c01f53ac2dab1d4d2cd1e4d45a67f9373d4a9c7e Thank you! ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/62#issuecomment-2373134499 From shade at openjdk.org Wed Sep 25 06:27:49 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 25 Sep 2024 06:27:49 GMT Subject: [jdk23u] Integrated: 8337876: [IR Framework] Add support for IR tests with @Stable In-Reply-To: References: Message-ID: <8ncCvSQgVAdkW13NvH84OH7TxlDt1EYaqYqRRrvaMr4=.b3bec35e-eca7-4652-ab75-80d78737bddc@github.com> On Mon, 12 Aug 2024 10:29:02 GMT, Aleksey Shipilev wrote: > Clean backport to improve IR Framework for upcoming tests. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `testlibrary_tests/ir_framework` passes This pull request has now been integrated. Changeset: 59799049 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/5979904902e4e0d9c615b71ecfa1d3f9f4b2b1c0 Stats: 103 lines in 5 files changed: 96 ins; 0 del; 7 mod 8337876: [IR Framework] Add support for IR tests with @Stable 8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build Reviewed-by: eastigeevich, phh Backport-of: c01f53ac2dab1d4d2cd1e4d45a67f9373d4a9c7e ------------- PR: https://git.openjdk.org/jdk23u/pull/62 From syan at openjdk.org Wed Sep 25 06:30:38 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 25 Sep 2024 06:30:38 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts [v2] In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 09:16:23 GMT, SendaoYan wrote: >> Hi all, >> >> This pull request contains a backport of commit [8feabc84](https://github.com/openjdk/jdk/commit/8feabc849ba2f617c8c6dbb2ec5074297beb6437) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by SendaoYan on 16 Jul 2024 and was reviewed by Jaikiran Pai. >> >> Thanks! > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-8feabc84-master > - Backport 8feabc849ba2f617c8c6dbb2ec5074297beb6437 Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/25#issuecomment-2373140938 From mbaesken at openjdk.org Wed Sep 25 07:22:41 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 25 Sep 2024 07:22:41 GMT Subject: [jdk21u-dev] Integrated: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings In-Reply-To: References: Message-ID: On Fri, 20 Sep 2024 14:28:25 GMT, Matthias Baesken wrote: > 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings This pull request has now been integrated. Changeset: 7cdb3da6 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/7cdb3da6cf6b0a5056f16904bc8424530c19e531 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings Backport-of: ac3f92b4110b05906a49c4146774fd6324c6d198 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/996 From goetz at openjdk.org Wed Sep 25 07:50:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 25 Sep 2024 07:50:47 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: Merge build tag 11.0.25+7 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk11u-dev/pull/2941/files Stats: 434 lines in 5 files changed: 392 ins; 14 del; 28 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2941.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2941/head:pull/2941 PR: https://git.openjdk.org/jdk11u-dev/pull/2941 From goetz at openjdk.org Wed Sep 25 07:52:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 25 Sep 2024 07:52:43 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master Message-ID: Merge build tag 17.0.13+9 from jdk17u to jdk17u-dev ------------- Commit messages: - Merge - 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk17u-dev/pull/2917/files Stats: 431 lines in 5 files changed: 389 ins; 14 del; 28 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2917.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2917/head:pull/2917 PR: https://git.openjdk.org/jdk17u-dev/pull/2917 From goetz at openjdk.org Wed Sep 25 08:04:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 25 Sep 2024 08:04:44 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master In-Reply-To: References: Message-ID: On Wed, 25 Sep 2024 07:34:40 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.13+9 from jdk17u to jdk17u-dev This pull request has now been integrated. Changeset: bb7d33ec Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/bb7d33ec4d2965d65d71a73eba0864d4600a4d5f Stats: 431 lines in 5 files changed: 389 ins; 14 del; 28 mod Merge ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2917 From goetz at openjdk.org Wed Sep 25 08:10:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 25 Sep 2024 08:10:20 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master [v2] In-Reply-To: References: Message-ID: <4bcbAzkY7jfHD75zRu-jftAEgY5Cak0iEN5i7Gj4fY8=.0f2c3cb7-458a-4b01-8efd-50a2008cd629@github.com> > Merge build tag 11.0.25+7 from jdk11u to jdk11u-dev Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge - Merge - 8315936: Parallelize gc/stress/TestStressG1Humongous.java test Backport-of: 3f19df685c342cef212305cca630331878a24e79 - 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main Reviewed-by: mbaesken Backport-of: ab183e437c18b445e9c022a4d74de818d4ccecbe - 8328300: Convert PrintDialogsTest.java from Applet to main program Reviewed-by: mbaesken Backport-of: dea94f4445b9389339cf7ca0eef688ca56c17814 - 8339082: Bump update version for OpenJDK: jdk-11.0.26 Reviewed-by: sgehwolf ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2941/files - new: https://git.openjdk.org/jdk11u-dev/pull/2941/files/db36bf4e..db36bf4e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2941&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2941&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2941.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2941/head:pull/2941 PR: https://git.openjdk.org/jdk11u-dev/pull/2941 From goetz at openjdk.org Wed Sep 25 08:10:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 25 Sep 2024 08:10:20 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 25 Sep 2024 07:46:11 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.25+7 from jdk11u to jdk11u-dev GHA failures: well known macos snprintf issue. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2941#issuecomment-2373364922 From goetz at openjdk.org Wed Sep 25 08:10:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 25 Sep 2024 08:10:21 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 25 Sep 2024 07:46:11 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.25+7 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: b2d38597 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/b2d385978fca9eb2fd2eb260a72d727d5f0d6740 Stats: 434 lines in 5 files changed: 392 ins; 14 del; 28 mod Merge ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2941 From sgehwolf at openjdk.org Wed Sep 25 08:20:42 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 25 Sep 2024 08:20:42 GMT Subject: [jdk11u-dev] RFR: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 20:01:56 GMT, Antonio Vieiro wrote: > The macos-11 github runners [were deprecated and removed in June 2024](https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/) , making the macos tests to hang in openjdk11u-dev (and other OpenJDK repositories). > > [JDK-8335793 GHA: Bump macOS and Xcode versions](https://bugs.openjdk.org/browse/JDK-8335793) upgraded the version https://github.com/openjdk/jdk11u-dev/pull/2835 of mac runners to macos-13. This upgrade in github runners required a long list of changes in openjdk11u-dev that proved difficult to review. > > In order to ease the review process this PR downgrades the version of github runners in jdk11u-dev from the current macos-13 to macos-12 and xcode-13.4.1. This will require a single backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) (a follow-up to this PR), making the review process easier. > > Once the github actions are running again in macos-12 an upgrade to macos-13 could be performed, if required, with some more additional PRs. Thanks! ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2940#pullrequestreview-2327528392 From shade at openjdk.org Wed Sep 25 08:35:30 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 25 Sep 2024 08:35:30 GMT Subject: [jdk23u] RFR: 8333791: Fix memory barriers for @Stable fields Message-ID: Improves performance around `@Stable` uses, notably `new String`, `Enum.hashCode` and others. Additional testing: - [x] MacOS AArch64 server fastdebug, new IR tests pass - [ ] Linux x86_64 server fastdebug, `all` - [ ] Linux AArch64 server fastdebug, `all` ------------- Commit messages: - Backport 74fdd6868d3f71d44ef9f71a0ca9506c04d39148 Changes: https://git.openjdk.org/jdk23u/pull/122/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=122&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333791 Stats: 1067 lines in 14 files changed: 1028 ins; 20 del; 19 mod Patch: https://git.openjdk.org/jdk23u/pull/122.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/122/head:pull/122 PR: https://git.openjdk.org/jdk23u/pull/122 From goetz at openjdk.org Wed Sep 25 09:16:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 25 Sep 2024 09:16:42 GMT Subject: [jdk17u-dev] RFR: 8339741: RISC-V: C ABI breakage for integer on stack In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 15:45:33 GMT, Robbin Ehn wrote: > Hi all, > > This pull request contains a backport of commit [bfe7f920](https://github.com/openjdk/jdk/commit/bfe7f9205b56483b4364130a3a87c58c3fc82998) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry. > > Not clean, locally tested the new jtreg test. > > Thanks! Why are the tests failing? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2912#issuecomment-2373517499 From mdoerr at openjdk.org Wed Sep 25 09:32:38 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 25 Sep 2024 09:32:38 GMT Subject: [jdk21u-dev] Integrated: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 12:48:10 GMT, Martin Doerr wrote: > Clean backport of [JDK-8340230](https://bugs.openjdk.org/browse/JDK-8340230) from jdk23u. This pull request has now been integrated. Changeset: 4539e46e Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/4539e46e4a35ae3d79ceaa3877db367950b75a9a Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity Backport-of: a6754f31cf52c3058d5f95a54e9f66738f4216e6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1001 From mdoerr at openjdk.org Wed Sep 25 09:36:41 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 25 Sep 2024 09:36:41 GMT Subject: [jdk17u-dev] RFR: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 12:49:54 GMT, Martin Doerr wrote: > Clean backport of [JDK-8340230](https://bugs.openjdk.org/browse/JDK-8340230) from jdk23u. GHA test failure is unrelated (timeout). ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2910#issuecomment-2373563343 From rvansa at openjdk.org Wed Sep 25 09:39:41 2024 From: rvansa at openjdk.org (Radim Vansa) Date: Wed, 25 Sep 2024 09:39:41 GMT Subject: [jdk17u-dev] RFR: 8273979: move some os time related functions to os_posix for POSIX platforms In-Reply-To: <5I5Ho4fHp1u17cMKxKt3nowFw8j4_Qn2UO8J9suFURQ=.306b3495-44d5-45cc-8a20-eab992e8b328@github.com> References: <5I5Ho4fHp1u17cMKxKt3nowFw8j4_Qn2UO8J9suFURQ=.306b3495-44d5-45cc-8a20-eab992e8b328@github.com> Message-ID: On Tue, 24 Sep 2024 12:11:21 GMT, Suchismith Roy wrote: >> Hi @GoeLin , understood, though I am rather trying to be honest than making up a synthetic argument. Since it was accepted in the mainline I could say that it is an improvement in code quality. >> >> MacOS should be tested here in GHA, regrettably I don't know where to get AIX for testing. > > @rvansa I am currently facing some issue with my AIX development machine. Some migration in progress. > By When are you expecting this to be tested? @suchismith1993 No hurry, but it would be nice if you can try in a few weeks. Thank you! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2831#issuecomment-2373573208 From rehn at openjdk.org Wed Sep 25 12:22:37 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Wed, 25 Sep 2024 12:22:37 GMT Subject: [jdk17u-dev] RFR: 8339741: RISC-V: C ABI breakage for integer on stack In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 15:45:33 GMT, Robbin Ehn wrote: > Hi all, > > This pull request contains a backport of commit [bfe7f920](https://github.com/openjdk/jdk/commit/bfe7f9205b56483b4364130a3a87c58c3fc82998) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry. > > Not clean, locally tested the new jtreg test. > > Thanks! One was E: Tried to extract package, but file already exists. Exit... Error: Process completed with exit code 1. The others: `This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.` ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2912#issuecomment-2373930289 From mbaesken at openjdk.org Wed Sep 25 12:55:10 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 25 Sep 2024 12:55:10 GMT Subject: [jdk23u] RFR: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message Message-ID: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message ------------- Commit messages: - Backport 4ff72dc57e65e99b129f0ba28196994edf402018 Changes: https://git.openjdk.org/jdk23u/pull/123/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=123&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339487 Stats: 29 lines in 2 files changed: 11 ins; 1 del; 17 mod Patch: https://git.openjdk.org/jdk23u/pull/123.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/123/head:pull/123 PR: https://git.openjdk.org/jdk23u/pull/123 From mbaesken at openjdk.org Wed Sep 25 13:16:17 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 25 Sep 2024 13:16:17 GMT Subject: [jdk21u-dev] RFR: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message Message-ID: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message ------------- Commit messages: - Backport 4ff72dc57e65e99b129f0ba28196994edf402018 Changes: https://git.openjdk.org/jdk21u-dev/pull/1010/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1010&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339487 Stats: 29 lines in 2 files changed: 11 ins; 1 del; 17 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1010.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1010/head:pull/1010 PR: https://git.openjdk.org/jdk21u-dev/pull/1010 From duke at openjdk.org Wed Sep 25 13:58:45 2024 From: duke at openjdk.org (duke) Date: Wed, 25 Sep 2024 13:58:45 GMT Subject: [jdk23u] RFR: 8338389: [JFR] Long strings should be added to the string pool In-Reply-To: References: Message-ID: On Mon, 16 Sep 2024 14:23:36 GMT, Joakim Nordstr?m wrote: > Backport of fix to pool all longer strings in JFR events. @jaokim Your change (at version a0745935d9f9303c1e7af360233fe6ddbe44e6d7) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/97#issuecomment-2374167412 From jnordstrom at openjdk.org Wed Sep 25 14:02:44 2024 From: jnordstrom at openjdk.org (Joakim =?UTF-8?B?Tm9yZHN0csO2bQ==?=) Date: Wed, 25 Sep 2024 14:02:44 GMT Subject: [jdk23u] Integrated: 8338389: [JFR] Long strings should be added to the string pool In-Reply-To: References: Message-ID: On Mon, 16 Sep 2024 14:23:36 GMT, Joakim Nordstr?m wrote: > Backport of fix to pool all longer strings in JFR events. This pull request has now been integrated. Changeset: 54bb851b Author: Joakim Nordstr?m Committer: Markus Gr?nlund URL: https://git.openjdk.org/jdk23u/commit/54bb851b927046faf7d46d1a352556db2f284780 Stats: 119 lines in 2 files changed: 116 ins; 0 del; 3 mod 8338389: [JFR] Long strings should be added to the string pool Backport-of: d5c6158cedfd96a9f97d83355b10730b81274648 ------------- PR: https://git.openjdk.org/jdk23u/pull/97 From matsaave at openjdk.org Wed Sep 25 16:22:42 2024 From: matsaave at openjdk.org (Matias Saavedra Silva) Date: Wed, 25 Sep 2024 16:22:42 GMT Subject: [jdk23u] RFR: 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 18:28:35 GMT, Coleen Phillimore wrote: >> Backport of the changes JDK-8338924 and JDK-8335664. This patch is not clean since it excludes the changes to Problem list. > > Looks good! Thank you for the review @coleenp ! ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/109#issuecomment-2374541986 From duke at openjdk.org Wed Sep 25 16:22:42 2024 From: duke at openjdk.org (duke) Date: Wed, 25 Sep 2024 16:22:42 GMT Subject: [jdk23u] RFR: 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 18:23:01 GMT, Matias Saavedra Silva wrote: > Backport of the changes JDK-8338924 and JDK-8335664. This patch is not clean since it excludes the changes to Problem list. @matias9927 Your change (at version fb0bb05f5236c7277d4eea1c33fccac235bd493f) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/109#issuecomment-2374543035 From gdams at openjdk.org Wed Sep 25 16:33:50 2024 From: gdams at openjdk.org (George Adams) Date: Wed, 25 Sep 2024 16:33:50 GMT Subject: [jdk23u] RFR: 8340815: Add SECURITY.md file Message-ID: Hi all, This pull request contains a backport of commit [0474f020](https://github.com/openjdk/jdk/commit/0474f020bf276c761f46bc8ba0873ed90a8fd19b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by George Adams on 25 Sep 2024 and was reviewed by Mark Reinhold, Julian Waters and Erik Joelsson. Thanks! ------------- Commit messages: - Backport 0474f020bf276c761f46bc8ba0873ed90a8fd19b Changes: https://git.openjdk.org/jdk23u/pull/124/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=124&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340815 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/124.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/124/head:pull/124 PR: https://git.openjdk.org/jdk23u/pull/124 From matsaave at openjdk.org Wed Sep 25 17:10:46 2024 From: matsaave at openjdk.org (Matias Saavedra Silva) Date: Wed, 25 Sep 2024 17:10:46 GMT Subject: [jdk23u] Integrated: 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 18:23:01 GMT, Matias Saavedra Silva wrote: > Backport of the changes JDK-8338924 and JDK-8335664. This patch is not clean since it excludes the changes to Problem list. This pull request has now been integrated. Changeset: caf28d4a Author: Matias Saavedra Silva Committer: Coleen Phillimore URL: https://git.openjdk.org/jdk23u/commit/caf28d4ac5711cc864a05fbdd64451d364c599ef Stats: 144 lines in 6 files changed: 134 ins; 6 del; 4 mod 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 8335664: Parsing jsr broken: assert(bci>= 0 && bci < c->method()->code_size()) failed: index out of bounds Reviewed-by: coleenp Backport-of: 1353601dcc8f9ec3e12dea21dc61b3585a154b13 ------------- PR: https://git.openjdk.org/jdk23u/pull/109 From shade at openjdk.org Wed Sep 25 17:12:34 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 25 Sep 2024 17:12:34 GMT Subject: [jdk23u] RFR: 8333791: Fix memory barriers for @Stable fields In-Reply-To: References: Message-ID: On Wed, 25 Sep 2024 08:29:55 GMT, Aleksey Shipilev wrote: > Improves performance around `@Stable` uses, notably `new String`, `Enum.hashCode` and others. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, new IR tests pass > - [x] Linux x86_64 server fastdebug, `all` > - [x] Linux AArch64 server fastdebug, `all` GHA failure looks environmental. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/122#issuecomment-2374671418 From abakhtin at openjdk.org Wed Sep 25 18:28:45 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 25 Sep 2024 18:28:45 GMT Subject: [jdk11u-dev] RFR: 8287596: Reorg jdk.test.lib.util.ForceGC In-Reply-To: References: Message-ID: On Fri, 29 Mar 2024 21:17:08 GMT, Alexey Bakhtin wrote: > Hello > I'd like to backport this enhancement to fix regression in java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java caused by JDK-8300727. The backport of JDK-8300727 requires JDK-8287596 to be applied first. > > The main differences from the JDK17 patch are the following: > - Reference::refersTo() is introduced in JDK16. Reference::get is used instead > - test/jdk/java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java in JDK11 does not use ForceGC. Skipped > - no test/jdk/java/lang/invoke/defineHiddenClass/UnloadingTest.java in JDK11 > - This patch also includes JDK-8261851 changes as part of the test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java patch > > All related jtreg tests passed. MR is reopened to fix JTREG failure ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2640#issuecomment-2374860151 From andrewlu at openjdk.org Thu Sep 26 02:23:46 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 26 Sep 2024 02:23:46 GMT Subject: [jdk17u-dev] Integrated: 8320586: update manual test/jdk/TEST.groups In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 06:49:48 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 989b975f Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/989b975fa5e1151acd62004022ba90a3be7b10dc Stats: 10 lines in 1 file changed: 5 ins; 2 del; 3 mod 8320586: update manual test/jdk/TEST.groups Backport-of: 99b9cb0a2eae1196f2127cd48e4085f19a90c4b4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2886 From andrewlu at openjdk.org Thu Sep 26 02:23:48 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 26 Sep 2024 02:23:48 GMT Subject: [jdk21u-dev] Integrated: 8320665: update jdk_core at open/test/jdk/TEST.groups In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 07:13:27 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: f181fc64 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/f181fc648d8efc028639dc60c64438c50a88df1a Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8320665: update jdk_core at open/test/jdk/TEST.groups Backport-of: da7cf258bb5b24788409dde084ad012bd64a032a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1005 From duke at openjdk.org Thu Sep 26 03:07:43 2024 From: duke at openjdk.org (duke) Date: Thu, 26 Sep 2024 03:07:43 GMT Subject: [jdk21u-dev] RFR: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 03:22:59 GMT, Liang Mao wrote: > Backport of fixing concurrent GC crashed due to GetMethodDeclaringClass. Not clean because of make file. @mmyxym Your change (at version b989396c3793060031158b69047d355267fb4f16) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1004#issuecomment-2375753020 From duke at openjdk.org Thu Sep 26 06:47:38 2024 From: duke at openjdk.org (duke) Date: Thu, 26 Sep 2024 06:47:38 GMT Subject: [jdk11u-dev] RFR: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 20:01:56 GMT, Antonio Vieiro wrote: > The macos-11 github runners [were deprecated and removed in June 2024](https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/) , making the macos tests to hang in openjdk11u-dev (and other OpenJDK repositories). > > [JDK-8335793 GHA: Bump macOS and Xcode versions](https://bugs.openjdk.org/browse/JDK-8335793) upgraded the version https://github.com/openjdk/jdk11u-dev/pull/2835 of mac runners to macos-13. This upgrade in github runners required a long list of changes in openjdk11u-dev that proved difficult to review. > > In order to ease the review process this PR downgrades the version of github runners in jdk11u-dev from the current macos-13 to macos-12 and xcode-13.4.1. This will require a single backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) (a follow-up to this PR), making the review process easier. > > Once the github actions are running again in macos-12 an upgrade to macos-13 could be performed, if required, with some more additional PRs. @vieiro Your change (at version e7ab1def6b31b1cad25322430d1ca6a3fe09388d) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2940#issuecomment-2376068134 From goetz at openjdk.org Thu Sep 26 06:49:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 26 Sep 2024 06:49:13 GMT Subject: [jdk17u-dev] RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 65907ffdb155221f19ce8753ce4f13b5e096c64a Changes: https://git.openjdk.org/jdk17u-dev/pull/2918/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2918&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334562 Stats: 403 lines in 6 files changed: 210 ins; 170 del; 23 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2918.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2918/head:pull/2918 PR: https://git.openjdk.org/jdk17u-dev/pull/2918 From mbalao at openjdk.org Thu Sep 26 07:01:00 2024 From: mbalao at openjdk.org (Martin Balao) Date: Thu, 26 Sep 2024 07:01:00 GMT Subject: [jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large Message-ID: Hi, Can I have a review for the backport of JDK-8263031 to 17u? This backport fixes a bug and will also serve as a dependency for a backport of 8328286. The JDK main line patch did not apply cleanly because JDK-8295944 was backported to 17u already and tests were moved. In addition, I had to make changes to PushPromiseContinuation.java to adapt the test to its new location (see jtreg header diff) and context (see the invocations to conn.addToOutputQ). With these changes, the test is passing. No regressions observed in the jdk/java/net/httpclient tests category. Thanks, Martin.- ------------- Commit messages: - Backport 4d2cd26ab5092ad0a169e4239164a869a4255bd3 Changes: https://git.openjdk.org/jdk17u/pull/400/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=400&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8263031 Stats: 446 lines in 4 files changed: 406 ins; 19 del; 21 mod Patch: https://git.openjdk.org/jdk17u/pull/400.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/400/head:pull/400 PR: https://git.openjdk.org/jdk17u/pull/400 From goetz at openjdk.org Thu Sep 26 07:11:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 26 Sep 2024 07:11:49 GMT Subject: [jdk21u-dev] RFR: 8324841: PKCS11 tests still skip execution Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport 9d4a4bd2c2a4bd16bbc80b602b15b448c52220f6 Changes: https://git.openjdk.org/jdk21u-dev/pull/1011/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1011&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324841 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1011.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1011/head:pull/1011 PR: https://git.openjdk.org/jdk21u-dev/pull/1011 From goetz at openjdk.org Thu Sep 26 07:12:04 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 26 Sep 2024 07:12:04 GMT Subject: [jdk17u-dev] RFR: 8324841: PKCS11 tests still skip execution Message-ID: <4njPueEvB2P31EPXd07keNAdA6yIOlEZ8yrk9DB0Dsk=.57357c40-b2be-4263-be26-9794ebe6787c@github.com> I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 9d4a4bd2c2a4bd16bbc80b602b15b448c52220f6 Changes: https://git.openjdk.org/jdk17u-dev/pull/2919/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2919&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324841 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2919.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2919/head:pull/2919 PR: https://git.openjdk.org/jdk17u-dev/pull/2919 From goetz at openjdk.org Thu Sep 26 08:09:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 26 Sep 2024 08:09:55 GMT Subject: [jdk21u-dev] RFR: 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport caf28d4ac5711cc864a05fbdd64451d364c599ef Changes: https://git.openjdk.org/jdk21u-dev/pull/1012/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1012&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338924 Stats: 144 lines in 6 files changed: 134 ins; 6 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1012.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1012/head:pull/1012 PR: https://git.openjdk.org/jdk21u-dev/pull/1012 From duke at openjdk.org Thu Sep 26 08:33:38 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 26 Sep 2024 08:33:38 GMT Subject: [jdk11u-dev] Integrated: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 20:01:56 GMT, Antonio Vieiro wrote: > The macos-11 github runners [were deprecated and removed in June 2024](https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/) , making the macos tests to hang in openjdk11u-dev (and other OpenJDK repositories). > > [JDK-8335793 GHA: Bump macOS and Xcode versions](https://bugs.openjdk.org/browse/JDK-8335793) upgraded the version https://github.com/openjdk/jdk11u-dev/pull/2835 of mac runners to macos-13. This upgrade in github runners required a long list of changes in openjdk11u-dev that proved difficult to review. > > In order to ease the review process this PR downgrades the version of github runners in jdk11u-dev from the current macos-13 to macos-12 and xcode-13.4.1. This will require a single backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) (a follow-up to this PR), making the review process easier. > > Once the github actions are running again in macos-12 an upgrade to macos-13 could be performed, if required, with some more additional PRs. This pull request has now been integrated. Changeset: dd35f187 Author: Antonio Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/dd35f187fd038281ce36b986ef71d3b813c0a83e Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2940 From goetz at openjdk.org Thu Sep 26 09:29:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 26 Sep 2024 09:29:13 GMT Subject: [jdk17u-dev] RFR: 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport c9bee173d61f4accfc4adc280ab5d21600191756 Changes: https://git.openjdk.org/jdk17u-dev/pull/2920/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2920&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331391 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2920.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2920/head:pull/2920 PR: https://git.openjdk.org/jdk17u-dev/pull/2920 From goetz at openjdk.org Thu Sep 26 09:30:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 26 Sep 2024 09:30:44 GMT Subject: [jdk17u-dev] RFR: 8339741: RISC-V: C ABI breakage for integer on stack In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 15:45:33 GMT, Robbin Ehn wrote: > Hi all, > > This pull request contains a backport of commit [bfe7f920](https://github.com/openjdk/jdk/commit/bfe7f9205b56483b4364130a3a87c58c3fc82998) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry. > > Not clean, locally tested the new jtreg test. > > Thanks! Wonderful, no runners available :/ . Well I ran it through SAPs testing without issues. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2912#issuecomment-2376428540 From mdoerr at openjdk.org Thu Sep 26 09:43:09 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 26 Sep 2024 09:43:09 GMT Subject: [jdk23u] RFR: 8340657: [PPC64] SA determines wrong unextendedSP Message-ID: Clean backport of [JDK-8340657](https://bugs.openjdk.org/browse/JDK-8340657). ------------- Commit messages: - Backport 49d15edd31c863faf3722af1bae8b50662ecf71f Changes: https://git.openjdk.org/jdk23u/pull/125/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=125&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340657 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/125.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/125/head:pull/125 PR: https://git.openjdk.org/jdk23u/pull/125 From rehn at openjdk.org Thu Sep 26 10:12:43 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Thu, 26 Sep 2024 10:12:43 GMT Subject: [jdk17u-dev] RFR: 8339741: RISC-V: C ABI breakage for integer on stack In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 09:27:58 GMT, Goetz Lindenmaier wrote: > Wonderful, no runners available :/ . Well I ran it through SAPs testing without issues. Thank you! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2912#issuecomment-2376522460 From sgehwolf at openjdk.org Thu Sep 26 11:14:47 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 26 Sep 2024 11:14:47 GMT Subject: [jdk11u-dev] RFR: 8299254: Support dealing with standard assert macro [v2] In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 20:17:09 GMT, Antonio Vieiro wrote: >> Antonio Vieiro has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. > > Rebased on top of #2940 @vieiro Please merge latest master into this PR. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2937#issuecomment-2376648015 From goetz at openjdk.org Thu Sep 26 11:31:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 26 Sep 2024 11:31:40 GMT Subject: [jdk21u-dev] Integrated: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 14:13:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: cb811690 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/cb811690f96ae30914b0bf18fbc3d1564e469f95 Stats: 42 lines in 1 file changed: 28 ins; 5 del; 9 mod 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect Backport-of: 21e86d10a726fe707febb0111f5b80d8d1d29f03 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1008 From goetz at openjdk.org Thu Sep 26 11:34:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 26 Sep 2024 11:34:39 GMT Subject: [jdk21u-dev] Integrated: 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 14:14:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: 3b2b3219 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/3b2b321939a979852dc718e29005effa08f42b43 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options Backport-of: c9bee173d61f4accfc4adc280ab5d21600191756 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1009 From goetz at openjdk.org Thu Sep 26 11:36:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 26 Sep 2024 11:36:44 GMT Subject: [jdk17u-dev] Integrated: 8319574: Exec/process tests should be marked as flagless In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 09:54:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Omitted test/jdk/java/lang/ProcessBuilder/ProcessStartLoggingTest.java. That came > with "8303392: Runtime.exec and ProcessBuilder.start should use System logger" > which is not a candidate for backport. > > Omitted test/jdk/java/lang/RuntimeTests/RuntimeExitLogTest.java. That came > with "8301627: System.exit and Runtime.exit debug logging" > which is not a candidate for backport. This pull request has now been integrated. Changeset: c56241eb Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c56241eb2ec17369a9538e9bb3ac30e46c585fd4 Stats: 20 lines in 12 files changed: 11 ins; 0 del; 9 mod 8319574: Exec/process tests should be marked as flagless Reviewed-by: mdoerr Backport-of: 68110b7a82ae82e2485aec23aba5406d2a5c0327 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2907 From goetz at openjdk.org Thu Sep 26 11:38:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 26 Sep 2024 11:38:43 GMT Subject: [jdk17u-dev] Integrated: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 14:27:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Resolved Copyright. Probably clean. This pull request has now been integrated. Changeset: 8d61f49d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/8d61f49d9f2111cb94d94026b65165b2ca8d949c Stats: 42 lines in 1 file changed: 28 ins; 5 del; 9 mod 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect Backport-of: 21e86d10a726fe707febb0111f5b80d8d1d29f03 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2916 From duke at openjdk.org Thu Sep 26 13:30:09 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 26 Sep 2024 13:30:09 GMT Subject: [jdk11u-dev] RFR: 8299254: Support dealing with standard assert macro [v4] In-Reply-To: References: Message-ID: <8sOAv72_VVpeKetLq2O2AQo0SyxMMCpbw04VQRP9xTk=.1b887146-8432-4c13-95b5-e0e3929d026d@github.com> > Backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) on top of the previous PR [`macos-12` github actions ](https://github.com/openjdk/jdk11u-dev/pull/2940). > > This will make the github actions in `jdk11u-dev` run again on top of `macos-12` / `xcode-13.4.1` . > > The change is minimal, and should work properly with no changes on any existing `macos-11` CI pipelines. Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' of github.com:openjdk/jdk11u-dev into backports/JDK-8299254-macos12 - Backport 89dd23f2fab0d98879e68f817923656e113087e3 - 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2937/files - new: https://git.openjdk.org/jdk11u-dev/pull/2937/files/96c74af0..76d976f7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2937&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2937&range=02-03 Stats: 434 lines in 5 files changed: 392 ins; 14 del; 28 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2937.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2937/head:pull/2937 PR: https://git.openjdk.org/jdk11u-dev/pull/2937 From goetz at openjdk.org Thu Sep 26 14:33:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 26 Sep 2024 14:33:40 GMT Subject: [jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 06:57:11 GMT, Martin Balao wrote: > Hi, > > Can I have a review for the backport of JDK-8263031 to 17u? This backport fixes a bug and will also serve as a dependency for a backport of 8328286. > > The JDK main line patch did not apply cleanly because JDK-8295944 was backported to 17u already and tests were moved. > > In addition, I had to make changes to PushPromiseContinuation.java to adapt the test to its new location (see jtreg header diff) and context (see the invocations to conn.addToOutputQ). With these changes, the test is passing. > > No regressions observed in the jdk/java/net/httpclient tests category. > > Thanks, > Martin.- Please enable the GHA action tests! ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/400#issuecomment-2377144662 From andrew at openjdk.org Thu Sep 26 15:14:41 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 26 Sep 2024 15:14:41 GMT Subject: [jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 14:30:42 GMT, Goetz Lindenmaier wrote: > Please enable the GHA action tests! I think the problem here is this is against 17u, not 17u-dev. 17u is closed for the October release: https://wiki.openjdk.org/display/JDKUpdates/JDK+17u ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/400#issuecomment-2377255012 From mbalao at openjdk.org Thu Sep 26 15:30:42 2024 From: mbalao at openjdk.org (Martin Balao) Date: Thu, 26 Sep 2024 15:30:42 GMT Subject: [jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large In-Reply-To: References: Message-ID: <2E3EJXV3gFCMnAYrxsEKEsnw_oLitezHTC7AyOWwrSY=.789c7cb8-9872-47ce-b8a3-a97e02211180@github.com> On Thu, 26 Sep 2024 06:57:11 GMT, Martin Balao wrote: > Hi, > > Can I have a review for the backport of JDK-8263031 to 17u? This backport fixes a bug and will also serve as a dependency for a backport of 8328286. > > The JDK main line patch did not apply cleanly because JDK-8295944 was backported to 17u already and tests were moved. > > In addition, I had to make changes to PushPromiseContinuation.java to adapt the test to its new location (see jtreg header diff) and context (see the invocations to conn.addToOutputQ). With these changes, the test is passing. > > No regressions observed in the jdk/java/net/httpclient tests category. > > Thanks, > Martin.- I forgot to enable the GHA when forking. They're disabled by default. Running manually now. On Thursday, September 26, 2024, Andrew Hughes ***@***.***> wrote: > Please enable the GHA action tests! > > I think the problem here is this is against 17u, not 17u-dev. 17u is > closed for the October release: https://wiki.openjdk.org/ > display/JDKUpdates/JDK+17u > > ? > Reply to this email directly, view it on GitHub > , or > unsubscribe > > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/400#issuecomment-2377292072 From andrew at openjdk.org Thu Sep 26 15:42:40 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 26 Sep 2024 15:42:40 GMT Subject: [jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large In-Reply-To: <2E3EJXV3gFCMnAYrxsEKEsnw_oLitezHTC7AyOWwrSY=.789c7cb8-9872-47ce-b8a3-a97e02211180@github.com> References: <2E3EJXV3gFCMnAYrxsEKEsnw_oLitezHTC7AyOWwrSY=.789c7cb8-9872-47ce-b8a3-a97e02211180@github.com> Message-ID: On Thu, 26 Sep 2024 15:27:48 GMT, Martin Balao wrote: > I forgot to enable the GHA when forking. They're disabled by default. Running manually now. The PR should be against 17u-dev. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/400#issuecomment-2377321385 From abakhtin at openjdk.org Thu Sep 26 16:09:50 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Thu, 26 Sep 2024 16:09:50 GMT Subject: [jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 06:57:11 GMT, Martin Balao wrote: > Hi, > > Can I have a review for the backport of JDK-8263031 to 17u? This backport fixes a bug and will also serve as a dependency for a backport of 8328286. > > The JDK main line patch did not apply cleanly because JDK-8295944 was backported to 17u already and tests were moved. > > In addition, I had to make changes to PushPromiseContinuation.java to adapt the test to its new location (see jtreg header diff) and context (see the invocations to conn.addToOutputQ). With these changes, the test is passing. > > No regressions observed in the jdk/java/net/httpclient tests category. > > Thanks, > Martin.- test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java line 34: > 32: * jdk.httpclient.test.lib.http2.BodyOutputStream > 33: * jdk.httpclient.test.lib.http2.OutgoingPushPromise > 34: * @modules java.base/sun.net.www.http I think the module section is not required anymore as soon as JDK-8295944 in the JDK17 already ------------- PR Review Comment: https://git.openjdk.org/jdk17u/pull/400#discussion_r1777380619 From phh at openjdk.org Thu Sep 26 16:58:31 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 26 Sep 2024 16:58:31 GMT Subject: [jdk21u-dev] RFR: 8320682: [AArch64] C1 compilation fails with "Field too big for insn" [v2] In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 20:57:19 GMT, Boris Ulasevich wrote: >> Hi all, >> >> This is a backport of [JDK-8320682](https://github.com/openjdk/jdk/pull/16951) change to fix C1 internal error caused by adr limit being broken by too large NMethodSizeLimit option value. >> >> The backported patch includes a change to the TestC1Globals.java that does not yet exist in the jdk21u codebase. In the mainline the test has four updates: >> - [1] https://github.com/openjdk/jdk/commit/7df73a23 >> - [2] https://github.com/openjdk/jdk/commit/c36ec2ca >> - [3] https://github.com/openjdk/jdk/commit/69014cd5 (this change) >> - [4] https://github.com/openjdk/jdk/commit/27d5f5c2 >> >> With this change I simply copy version [3] of TestC1Globals.java corresponding to this change in jdk-23. Why not backport [1]+[2]+[3] to have a clean incremental patch? >> - I do not think [1] fits the backporting rules (not a crash fix, and not very important) >> - change [3] is stronger than change [2] (once NMethodSizeLimit is limited, no need to gracefully handle large values) >> >> Testing: jtreg tier1-3. >> Without the patch `$ fastdebug/bin/java -XX:NMethodSizeLimit=4M` causes the `guarantee(chk == -1 || chk == 0) failed: Field too big for insn`. With the change the 4M value becomes invalid. > > Boris Ulasevich has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 69014cd55b59a0a63f4918fad575a6887640573e Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/956#pullrequestreview-2331876457 From duke at openjdk.org Thu Sep 26 20:09:46 2024 From: duke at openjdk.org (Saint Wesonga) Date: Thu, 26 Sep 2024 20:09:46 GMT Subject: [jdk21u-dev] Integrated: 6942632: Hotspot should be able to use more than 64 logical processors on Windows In-Reply-To: <2coHSZZXFN7EQtSqhEuq3uM01sX9UqpOpvAMZBuowEw=.045fbe79-cd99-4b58-a756-895fc8ab0bf7@github.com> References: <2coHSZZXFN7EQtSqhEuq3uM01sX9UqpOpvAMZBuowEw=.045fbe79-cd99-4b58-a756-895fc8ab0bf7@github.com> Message-ID: On Tue, 30 Jul 2024 19:05:36 GMT, Saint Wesonga wrote: > Clean backport of support for >64 logical processors on Windows (https://github.com/openjdk/jdk/pull/17576) to jdk21. This pull request has now been integrated. Changeset: 5be5942d Author: Saint Wesonga Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/5be5942de233727b261b847340441bc6c98b17ce Stats: 760 lines in 10 files changed: 702 ins; 40 del; 18 mod 6942632: Hotspot should be able to use more than 64 logical processors on Windows Backport-of: f15d423fb5451c7c8f2d1007235ebf8aa79a403e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/881 From phh at openjdk.org Thu Sep 26 20:30:40 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 26 Sep 2024 20:30:40 GMT Subject: [jdk23u] RFR: 8337795: Type annotation attached to incorrect type during class reading [v2] In-Reply-To: References: Message-ID: <4bZ9kYCaVj-b-o6oeWBbPiFih_t9TcfAL1cAME2Vl1w=.2e1048d4-43ac-4f21-9dca-44a375e7fdc9@github.com> On Wed, 14 Aug 2024 15:07:01 GMT, Liam Miller-Cushon wrote: >> This change fixes a bug in javac's handling of type annotations in bytecode, which was logic first added in JDK 22 as part of the fix for JDK-8225377. > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8337795 > - Backport 8d0831478338e9b084b2c47f46eba9faae3a5eb6 Add a "/integrate" comment and I'll sponsor. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/67#issuecomment-2377873454 From phh at openjdk.org Thu Sep 26 20:36:50 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 26 Sep 2024 20:36:50 GMT Subject: [jdk17u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases In-Reply-To: References: Message-ID: On Mon, 16 Sep 2024 17:06:28 GMT, Alexey Bakhtin wrote: > Almost clean backport from JDK21 > > The only difference is an additional EPERM check in the stat1 method. This method was removed in JDK21 as part of JDK-8283335 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2883#pullrequestreview-2332296418 From mbalao at openjdk.org Thu Sep 26 20:46:21 2024 From: mbalao at openjdk.org (Martin Balao) Date: Thu, 26 Sep 2024 20:46:21 GMT Subject: [jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2] In-Reply-To: References: Message-ID: > Hi, > > Can I have a review for the backport of JDK-8263031 to 17u? This backport fixes a bug and will also serve as a dependency for a backport of 8328286. > > The JDK main line patch did not apply cleanly because JDK-8295944 was backported to 17u already and tests were moved. > > In addition, I had to make changes to PushPromiseContinuation.java to adapt the test to its new location (see jtreg header diff) and context (see the invocations to conn.addToOutputQ). With these changes, the test is passing. > > No regressions observed in the jdk/java/net/httpclient tests category. > > Thanks, > Martin.- Martin Balao has updated the pull request incrementally with one additional commit since the last revision: Remove unnecessary @modules header. ------------- Changes: - all: https://git.openjdk.org/jdk17u/pull/400/files - new: https://git.openjdk.org/jdk17u/pull/400/files/cdd40840..7b122c13 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u&pr=400&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u&pr=400&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod Patch: https://git.openjdk.org/jdk17u/pull/400.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/400/head:pull/400 PR: https://git.openjdk.org/jdk17u/pull/400 From mbalao at openjdk.org Thu Sep 26 20:46:21 2024 From: mbalao at openjdk.org (Martin Balao) Date: Thu, 26 Sep 2024 20:46:21 GMT Subject: [jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large In-Reply-To: References: <2E3EJXV3gFCMnAYrxsEKEsnw_oLitezHTC7AyOWwrSY=.789c7cb8-9872-47ce-b8a3-a97e02211180@github.com> Message-ID: <-RRCuWZlUrZW3zf5RFNeDf7cj_GaiEyPjPp353qowkA=.2f9ac8cf-5c69-4292-a71d-9fdf7f2530c5@github.com> On Thu, 26 Sep 2024 15:39:49 GMT, Andrew John Hughes wrote: > > I forgot to enable the GHA when forking. They're disabled by default. Running manually now. > > The PR should be against 17u-dev. It's my understanding that @RealCLanger prefers PRs against stable repositories when they are for critical fixes in the last part of the cycle. While I tend to agree with that choice, I'm okay with anything as long as there is a unified criteria. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/400#issuecomment-2377898483 From mbalao at openjdk.org Thu Sep 26 20:46:21 2024 From: mbalao at openjdk.org (Martin Balao) Date: Thu, 26 Sep 2024 20:46:21 GMT Subject: [jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2] In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 16:06:42 GMT, Alexey Bakhtin wrote: >> Martin Balao has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove unnecessary @modules header. > > test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java line 34: > >> 32: * jdk.httpclient.test.lib.http2.BodyOutputStream >> 33: * jdk.httpclient.test.lib.http2.OutgoingPushPromise >> 34: * @modules java.base/sun.net.www.http > > I think the module section is not required anymore as soon as JDK-8295944 in the JDK17 already Done. Thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk17u/pull/400#discussion_r1777711401 From abakhtin at openjdk.org Thu Sep 26 20:56:40 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Thu, 26 Sep 2024 20:56:40 GMT Subject: [jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2] In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 20:46:21 GMT, Martin Balao wrote: >> Hi, >> >> Can I have a review for the backport of JDK-8263031 to 17u? This backport fixes a bug and will also serve as a dependency for a backport of 8328286. >> >> The JDK main line patch did not apply cleanly because JDK-8295944 was backported to 17u already and tests were moved. >> >> In addition, I had to make changes to PushPromiseContinuation.java to adapt the test to its new location (see jtreg header diff) and context (see the invocations to conn.addToOutputQ). With these changes, the test is passing. >> >> No regressions observed in the jdk/java/net/httpclient tests category. >> >> Thanks, >> Martin.- > > Martin Balao has updated the pull request incrementally with one additional commit since the last revision: > > Remove unnecessary @modules header. Looks good to me. Unfortunately, I have no review status and can not officially approve ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/400#issuecomment-2377917590 From andrewlu at openjdk.org Fri Sep 27 01:58:45 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 27 Sep 2024 01:58:45 GMT Subject: [jdk17u-dev] Integrated: 8320665: update jdk_core at open/test/jdk/TEST.groups In-Reply-To: <25bjPBUt0pTbZyZOZjRgW4MHcGlCoMHIZ87_OKJFZmQ=.9239cc6d-7f19-45db-9471-38215354bcd4@github.com> References: <25bjPBUt0pTbZyZOZjRgW4MHcGlCoMHIZ87_OKJFZmQ=.9239cc6d-7f19-45db-9471-38215354bcd4@github.com> Message-ID: On Tue, 24 Sep 2024 07:16:52 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: 26010eae Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/26010eaea782ba46b1a1dcc11bb0c86ce6072de7 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8320665: update jdk_core at open/test/jdk/TEST.groups Backport-of: da7cf258bb5b24788409dde084ad012bd64a032a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2914 From duke at openjdk.org Fri Sep 27 06:36:47 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 27 Sep 2024 06:36:47 GMT Subject: [jdk11u-dev] RFR: 8299254: Support dealing with standard assert macro [v4] In-Reply-To: <8sOAv72_VVpeKetLq2O2AQo0SyxMMCpbw04VQRP9xTk=.1b887146-8432-4c13-95b5-e0e3929d026d@github.com> References: <8sOAv72_VVpeKetLq2O2AQo0SyxMMCpbw04VQRP9xTk=.1b887146-8432-4c13-95b5-e0e3929d026d@github.com> Message-ID: <5ThEe6EUFLNFMIl6GB78ascZvG9QGTDC5crdpTOVaYw=.598ffa7e-8362-4b6b-8813-eafd798af0cd@github.com> On Thu, 26 Sep 2024 13:30:09 GMT, Antonio Vieiro wrote: >> Backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) on top of the previous PR [`macos-12` github actions ](https://github.com/openjdk/jdk11u-dev/pull/2940). >> >> This will make the github actions in `jdk11u-dev` run again on top of `macos-12` / `xcode-13.4.1` . >> >> The change is minimal, and should work properly with no changes on any existing `macos-11` CI pipelines. > > Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' of github.com:openjdk/jdk11u-dev into backports/JDK-8299254-macos12 > - Backport 89dd23f2fab0d98879e68f817923656e113087e3 > - 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 Done! We have green lights in GHA. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2937#issuecomment-2378503611 From mbaesken at openjdk.org Fri Sep 27 08:13:44 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 27 Sep 2024 08:13:44 GMT Subject: [jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2] In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 20:46:21 GMT, Martin Balao wrote: >> Hi, >> >> Can I have a review for the backport of JDK-8263031 to 17u? This backport fixes a bug and will also serve as a dependency for a backport of 8328286. >> >> The JDK main line patch did not apply cleanly because JDK-8295944 was backported to 17u already and tests were moved. >> >> In addition, I had to make changes to PushPromiseContinuation.java to adapt the test to its new location (see jtreg header diff) and context (see the invocations to conn.addToOutputQ). With these changes, the test is passing. >> >> No regressions observed in the jdk/java/net/httpclient tests category. >> >> Thanks, >> Martin.- > > Martin Balao has updated the pull request incrementally with one additional commit since the last revision: > > Remove unnecessary @modules header. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u/pull/400#pullrequestreview-2333070907 From serb at openjdk.org Fri Sep 27 09:20:53 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 27 Sep 2024 09:20:53 GMT Subject: [jdk11u-dev] RFR: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java Message-ID: Hi all, This pull request contains a backport of commit [e61252dc](https://github.com/openjdk/jdk/commit/e61252dc278fd44345c5377811552ed6760ffcf0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Chris Hegarty on 9 Oct 2018 and was reviewed by Daniel Fuchs. Thanks! ------------- Commit messages: - Backport e61252dc278fd44345c5377811552ed6760ffcf0 Changes: https://git.openjdk.org/jdk11u-dev/pull/2942/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2942&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8211920 Stats: 739 lines in 8 files changed: 270 ins; 201 del; 268 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2942.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2942/head:pull/2942 PR: https://git.openjdk.org/jdk11u-dev/pull/2942 From serb at openjdk.org Fri Sep 27 09:20:53 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 27 Sep 2024 09:20:53 GMT Subject: [jdk11u-dev] RFR: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 07:25:15 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [e61252dc](https://github.com/openjdk/jdk/commit/e61252dc278fd44345c5377811552ed6760ffcf0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Chris Hegarty on 9 Oct 2018 and was reviewed by Daniel Fuchs. > > Thanks! The build issue on macOS x64/aarch64 is due to https://github.com/openjdk/jdk11u-dev/pull/2937 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2942#issuecomment-2378833105 From yan at openjdk.org Fri Sep 27 09:58:43 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 27 Sep 2024 09:58:43 GMT Subject: [jdk11u-dev] RFR: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 07:25:15 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [e61252dc](https://github.com/openjdk/jdk/commit/e61252dc278fd44345c5377811552ed6760ffcf0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Chris Hegarty on 9 Oct 2018 and was reviewed by Daniel Fuchs. > > Thanks! Marked as reviewed by yan (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2942#pullrequestreview-2333294692 From sgehwolf at openjdk.org Fri Sep 27 10:02:48 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 27 Sep 2024 10:02:48 GMT Subject: [jdk11u-dev] RFR: 8299254: Support dealing with standard assert macro [v4] In-Reply-To: <8sOAv72_VVpeKetLq2O2AQo0SyxMMCpbw04VQRP9xTk=.1b887146-8432-4c13-95b5-e0e3929d026d@github.com> References: <8sOAv72_VVpeKetLq2O2AQo0SyxMMCpbw04VQRP9xTk=.1b887146-8432-4c13-95b5-e0e3929d026d@github.com> Message-ID: On Thu, 26 Sep 2024 13:30:09 GMT, Antonio Vieiro wrote: >> Backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) on top of the previous PR [`macos-12` github actions ](https://github.com/openjdk/jdk11u-dev/pull/2940). >> >> This will make the github actions in `jdk11u-dev` run again on top of `macos-12` / `xcode-13.4.1` . >> >> The change is minimal, and should work properly with no changes on any existing `macos-11` CI pipelines. > > Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' of github.com:openjdk/jdk11u-dev into backports/JDK-8299254-macos12 > - Backport 89dd23f2fab0d98879e68f817923656e113087e3 > - 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 It would be helpful to explain what the differences of the patch to, say the JDK 17u backport was. As far as I can tell these are: - Omitted hunk in test/hotspot/gtest/gc/shenandoah/test_shenandoahNumberSeq.cpp since the test isn't in JDK 11u - You didn't remove the `gtest/gtest.h` related [hunk](https://github.com/openjdk/jdk17u/commit/89dd23f2fab0d98879e68f817923656e113087e3#diff-ff1dd449619fcf441d7a63b01c6c4b6bf3e6fd5dc1149ffa48f38d5e6d82e5baL63-L74) as was done for the 17u version. Why? What testing have you done? Did you run gtests to verify they still work? test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp line 2: > 1: /* > 2: * Copyright (c) 2016, 2024, Oracle and/or its affiliates. All rights reserved. Suggestion: * Copyright (c) 2016, 2022, Oracle and/or its affiliates. All rights reserved. So as to match the JDK 17u version of the patch. test/hotspot/gtest/jfr/test_networkUtilization.cpp line 2: > 1: /* > 2: * Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved. Suggestion: * Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved. test/hotspot/gtest/unittest.hpp line 2: > 1: /* > 2: * Copyright (c) 2016, 2024, Oracle and/or its affiliates. All rights reserved. This copyright update isn't in the JDK 17u version of the patch, please remove. https://github.com/openjdk/jdk17u/commit/89dd23f2fab0d98879e68f817923656e113087e3#diff-ff1dd449619fcf441d7a63b01c6c4b6bf3e6fd5dc1149ffa48f38d5e6d82e5ba For backports we try to avoid copyright updates, only use what was done in the backports of newer code-lines. test/hotspot/gtest/unittest.hpp line 36: > 34: #include "utilities/vmassert_reinstall.hpp" > 35: > 36: // gtest/gtest.h includes assert.h which will define the assert macro, but hotspot has its This was removed in the 17u version. Why not here as well? ------------- Changes requested by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2937#pullrequestreview-2333280003 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2937#discussion_r1778346956 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2937#discussion_r1778347314 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2937#discussion_r1778350401 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2937#discussion_r1778359911 From aivanov at openjdk.org Fri Sep 27 10:39:43 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 27 Sep 2024 10:39:43 GMT Subject: [jdk23u] Integrated: 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout In-Reply-To: <1lc8LA8EeW6rz6Vmf0SmYFLIXOTQ6slFGzBjLg3z0i4=.8ef80f16-2d69-43c8-b318-9c38477e1233@github.com> References: <1lc8LA8EeW6rz6Vmf0SmYFLIXOTQ6slFGzBjLg3z0i4=.8ef80f16-2d69-43c8-b318-9c38477e1233@github.com> Message-ID: On Fri, 20 Sep 2024 10:26:13 GMT, Alexey Ivanov wrote: > Backporting 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout > > The patch applies cleanly. > >> This pull request contains a backport of commit [3c22d83c](https://github.com/openjdk/jdk/commit/3c22d83c0fb9eee2e2b87e607680b96363849c16) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexey Ivanov on 20 Sep 2024 and was reviewed by Alexander Zvegintsev and Phil Race. This pull request has now been integrated. Changeset: 20c1153e Author: Alexey Ivanov URL: https://git.openjdk.org/jdk23u/commit/20c1153efab9265caa12bc6747923f0c338ca2f3 Stats: 178 lines in 1 file changed: 178 ins; 0 del; 0 mod 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout Backport-of: 3c22d83c0fb9eee2e2b87e607680b96363849c16 ------------- PR: https://git.openjdk.org/jdk23u/pull/112 From aivanov at openjdk.org Fri Sep 27 10:44:36 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 27 Sep 2024 10:44:36 GMT Subject: [jdk23u] Integrated: 8340007: Refactor KeyEvent/FunctionKeyTest.java In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 11:22:16 GMT, Alexey Ivanov wrote: > Backporting [JDK-8340007](https://bugs.openjdk.org/browse/JDK-8340007) to 23u. > >> This pull request contains a backport of commit [2faf8b8d](https://github.com/openjdk/jdk/commit/2faf8b8d582183275b1fdc92313a1c63c1753e80) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexey Ivanov on 19 Sep 2024 and was reviewed by Alexander Zvegintsev. This pull request has now been integrated. Changeset: e4badd4b Author: Alexey Ivanov URL: https://git.openjdk.org/jdk23u/commit/e4badd4b10620c4f92dda87179e712879f327322 Stats: 114 lines in 1 file changed: 62 ins; 15 del; 37 mod 8340007: Refactor KeyEvent/FunctionKeyTest.java Backport-of: 2faf8b8d582183275b1fdc92313a1c63c1753e80 ------------- PR: https://git.openjdk.org/jdk23u/pull/105 From aivanov at openjdk.org Fri Sep 27 10:46:40 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 27 Sep 2024 10:46:40 GMT Subject: [jdk23u] Integrated: 8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 11:45:36 GMT, Alexey Ivanov wrote: > Backporting [JDK-8332901](https://bugs.openjdk.org/browse/JDK-8332901) to 23u. > > The patch does not apply cleanly, there's a conflict in `test/jdk/ProblemList.txt` because of context differences. JDK 23u does not have the *Wayland related* problem-listings. > > Essentially, the change to `ProblemList.txt` is the same: remove `SelectNewItemTest.java` from PL. > >> This pull request contains a backport of commit [ef96a7b0](https://github.com/openjdk/jdk/commit/ef96a7b014795f366af3a90ef8f474cfb621197f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexey Ivanov on 4 Sep 2024 and was reviewed by Harshitha Onkar, Phil Race and Damon Nguyen. This pull request has now been integrated. Changeset: fa008ded Author: Alexey Ivanov URL: https://git.openjdk.org/jdk23u/commit/fa008ded77ce14d0c33b5ad6fc612ae3c983f019 Stats: 593 lines in 5 files changed: 276 ins; 317 del; 0 mod 8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS Move SelectCurrentItemTest.java to java/awt/Choice/SelectItem/. Move SelectNewItemTest.java to java/awt/Choice/SelectItem/. Use latches to control test flow instead of delays. Encapsulate the common logic in SelectCurrentItemTest. Provide overridable checkXXX() methods to modify conditions. Provide an overridable method which defines where to click in the choice popup to select an item. Backport-of: ef96a7b014795f366af3a90ef8f474cfb621197f ------------- PR: https://git.openjdk.org/jdk23u/pull/107 From aivanov at openjdk.org Fri Sep 27 10:47:38 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 27 Sep 2024 10:47:38 GMT Subject: [jdk23u] Integrated: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @ In-Reply-To: References: Message-ID: On Fri, 20 Sep 2024 18:14:58 GMT, Alexey Ivanov wrote: > Backporting JDK-8335789. > > The patch applies cleanly. > >> This pull request contains a backport of commit [3733fe3a](https://github.com/openjdk/jdk/commit/3733fe3a207078b585421cd2a098e808fafaa817) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by lawrence.andrews on 8 Jul 2024 and was reviewed by Alexey Ivanov. This pull request has now been integrated. Changeset: bd44358a Author: Alexey Ivanov URL: https://git.openjdk.org/jdk23u/commit/bd44358ae6725758c08db7dde0c95dc6635aa3e8 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @ Backport-of: 3733fe3a207078b585421cd2a098e808fafaa817 ------------- PR: https://git.openjdk.org/jdk23u/pull/115 From aivanov at openjdk.org Fri Sep 27 10:47:39 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 27 Sep 2024 10:47:39 GMT Subject: [jdk23u] Integrated: 8340210: Add positionTestUI() to PassFailJFrame.Builder In-Reply-To: <6vQ-YfIA1tiwM-k5dCnh1tNMU0g_XGz0m3Ev312Q6RA=.2ed5cf9d-1fdb-4762-98a8-c0e997253b03@github.com> References: <6vQ-YfIA1tiwM-k5dCnh1tNMU0g_XGz0m3Ev312Q6RA=.2ed5cf9d-1fdb-4762-98a8-c0e997253b03@github.com> Message-ID: On Thu, 19 Sep 2024 11:24:12 GMT, Alexey Ivanov wrote: > Backporting [JDK-8340210](https://bugs.openjdk.org/browse/JDK-8340210) to 23u. > >> This pull request contains a backport of commit [f0ae90f3](https://github.com/openjdk/jdk/commit/f0ae90f30c346544e87217ef1832d6a350fe1985) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Harshitha Onkar on 17 Sep 2024 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. This pull request has now been integrated. Changeset: faa89f45 Author: Alexey Ivanov URL: https://git.openjdk.org/jdk23u/commit/faa89f45151c95d152798950fb9f422706e28ef5 Stats: 23 lines in 1 file changed: 23 ins; 0 del; 0 mod 8340210: Add positionTestUI() to PassFailJFrame.Builder Backport-of: f0ae90f30c346544e87217ef1832d6a350fe1985 ------------- PR: https://git.openjdk.org/jdk23u/pull/106 From aivanov at openjdk.org Fri Sep 27 10:47:43 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 27 Sep 2024 10:47:43 GMT Subject: [jdk23u] Integrated: 8340308: PassFailJFrame: Make rows default to number of lines in instructions In-Reply-To: References: Message-ID: On Fri, 20 Sep 2024 11:11:49 GMT, Alexey Ivanov wrote: > Backporting 8340308: PassFailJFrame: Make rows default to number of lines in instructions > > The patch applies cleanly. > >> This pull request contains a backport of commit [d1d82400](https://github.com/openjdk/jdk/commit/d1d824008d1dc70029013820814fd03c40b4e309) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexey Ivanov on 19 Sep 2024 and was reviewed by Harshitha Onkar and Alexander Zvegintsev. This pull request has now been integrated. Changeset: b8d01b0e Author: Alexey Ivanov URL: https://git.openjdk.org/jdk23u/commit/b8d01b0ece17c533dadbe8dec5d21b083aaf589c Stats: 35 lines in 1 file changed: 34 ins; 0 del; 1 mod 8340308: PassFailJFrame: Make rows default to number of lines in instructions Backport-of: d1d824008d1dc70029013820814fd03c40b4e309 ------------- PR: https://git.openjdk.org/jdk23u/pull/113 From aivanov at openjdk.org Fri Sep 27 10:47:47 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 27 Sep 2024 10:47:47 GMT Subject: [jdk23u] Integrated: 8340306: Add border around instructions in PassFailJFrame In-Reply-To: References: Message-ID: <1QXZ-jiws5hHZLC1wu770cmLlUdMgjCd9PvHMbo2bOI=.99a9631f-9814-4c9d-a502-e3df2cbec228@github.com> On Thu, 19 Sep 2024 12:21:14 GMT, Alexey Ivanov wrote: > Backporting JDK-8340306 to 23u. > > The patch applies cleanly. > >> This pull request contains a backport of commit [0120d3ee](https://github.com/openjdk/jdk/commit/0120d3eed50bdc9fa53f2c41b31791620aeef613) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexey Ivanov on 19 Sep 2024 and was reviewed by Harshitha Onkar and Phil Race. This pull request has now been integrated. Changeset: f63b7021 Author: Alexey Ivanov URL: https://git.openjdk.org/jdk23u/commit/f63b70216fc9e4cd9c13cec61e5c7158e5a4bc90 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8340306: Add border around instructions in PassFailJFrame Backport-of: 0120d3eed50bdc9fa53f2c41b31791620aeef613 ------------- PR: https://git.openjdk.org/jdk23u/pull/108 From gdams at openjdk.org Fri Sep 27 14:14:59 2024 From: gdams at openjdk.org (George Adams) Date: Fri, 27 Sep 2024 14:14:59 GMT Subject: [jdk11u-dev] RFR: 8340815: Add SECURITY.md file Message-ID: Hi all, This pull request contains a backport of commit [0474f020](https://github.com/openjdk/jdk/commit/0474f020bf276c761f46bc8ba0873ed90a8fd19b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by George Adams on 25 Sep 2024 and was reviewed by Mark Reinhold, Julian Waters and Erik Joelsson. Thanks! ------------- Commit messages: - Backport 0474f020bf276c761f46bc8ba0873ed90a8fd19b Changes: https://git.openjdk.org/jdk11u-dev/pull/2943/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2943&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340815 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2943.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2943/head:pull/2943 PR: https://git.openjdk.org/jdk11u-dev/pull/2943 From gdams at openjdk.org Fri Sep 27 14:15:16 2024 From: gdams at openjdk.org (George Adams) Date: Fri, 27 Sep 2024 14:15:16 GMT Subject: [jdk17u-dev] RFR: 8340815: Add SECURITY.md file Message-ID: <7RTYWCkg1toiSY7Z8uh9gt9Py8tx8FKuwz80NtGTNb4=.6048ec0f-9693-40cc-a75d-a322b8fd674c@github.com> Hi all, This pull request contains a backport of commit [0474f020](https://github.com/openjdk/jdk/commit/0474f020bf276c761f46bc8ba0873ed90a8fd19b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by George Adams on 25 Sep 2024 and was reviewed by Mark Reinhold, Julian Waters and Erik Joelsson. Thanks! ------------- Commit messages: - Backport 0474f020bf276c761f46bc8ba0873ed90a8fd19b Changes: https://git.openjdk.org/jdk17u-dev/pull/2921/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2921&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340815 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2921.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2921/head:pull/2921 PR: https://git.openjdk.org/jdk17u-dev/pull/2921 From gdams at openjdk.org Fri Sep 27 14:16:17 2024 From: gdams at openjdk.org (George Adams) Date: Fri, 27 Sep 2024 14:16:17 GMT Subject: [jdk21u-dev] RFR: 8340815: Add SECURITY.md file Message-ID: <0aL6K4_1hUAdIIduF0mAbwPHu71TmDm6Ti_rRkileD4=.63bccf95-fb09-429b-a5e5-0ec1ce012411@github.com> Hi all, This pull request contains a backport of commit [0474f020](https://github.com/openjdk/jdk/commit/0474f020bf276c761f46bc8ba0873ed90a8fd19b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by George Adams on 25 Sep 2024 and was reviewed by Mark Reinhold, Julian Waters and Erik Joelsson. Thanks! ------------- Commit messages: - Backport 0474f020bf276c761f46bc8ba0873ed90a8fd19b Changes: https://git.openjdk.org/jdk21u-dev/pull/1013/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1013&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340815 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1013.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1013/head:pull/1013 PR: https://git.openjdk.org/jdk21u-dev/pull/1013 From gdams at openjdk.org Fri Sep 27 14:27:45 2024 From: gdams at openjdk.org (George Adams) Date: Fri, 27 Sep 2024 14:27:45 GMT Subject: [jdk21u-dev] Integrated: 8340815: Add SECURITY.md file In-Reply-To: <0aL6K4_1hUAdIIduF0mAbwPHu71TmDm6Ti_rRkileD4=.63bccf95-fb09-429b-a5e5-0ec1ce012411@github.com> References: <0aL6K4_1hUAdIIduF0mAbwPHu71TmDm6Ti_rRkileD4=.63bccf95-fb09-429b-a5e5-0ec1ce012411@github.com> Message-ID: On Fri, 27 Sep 2024 14:06:01 GMT, George Adams wrote: > Hi all, > > This pull request contains a backport of commit [0474f020](https://github.com/openjdk/jdk/commit/0474f020bf276c761f46bc8ba0873ed90a8fd19b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by George Adams on 25 Sep 2024 and was reviewed by Mark Reinhold, Julian Waters and Erik Joelsson. > > Thanks! This pull request has now been integrated. Changeset: c66748cc Author: George Adams URL: https://git.openjdk.org/jdk21u-dev/commit/c66748cc03e1aed2460b6cea3efb9ff20c85cf90 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8340815: Add SECURITY.md file Backport-of: 0474f020bf276c761f46bc8ba0873ed90a8fd19b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1013 From duke at openjdk.org Fri Sep 27 15:40:36 2024 From: duke at openjdk.org (duke) Date: Fri, 27 Sep 2024 15:40:36 GMT Subject: [jdk23u] RFR: 8337795: Type annotation attached to incorrect type during class reading [v2] In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 15:07:01 GMT, Liam Miller-Cushon wrote: >> This change fixes a bug in javac's handling of type annotations in bytecode, which was logic first added in JDK 22 as part of the fix for JDK-8225377. > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8337795 > - Backport 8d0831478338e9b084b2c47f46eba9faae3a5eb6 @cushon Your change (at version c7b59e5bf75ac3c510a84a36e099d5168c9f64b7) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/67#issuecomment-2379565757 From gdams at openjdk.org Fri Sep 27 15:44:53 2024 From: gdams at openjdk.org (George Adams) Date: Fri, 27 Sep 2024 15:44:53 GMT Subject: [jdk21u-dev] RFR: 8340383: VM issues warning failure to find kernel32.dll on Windows nanoserver Message-ID: Hi all, This pull request contains a backport of commit [3c97d243](https://github.com/openjdk/jdk/commit/3c97d2437d34d2db47f3607fbb95ac3b8e2ec60b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by George Adams on 24 Sep 2024 and was reviewed by David Holmes and Julian Waters. Thanks! ------------- Commit messages: - Backport 3c97d2437d34d2db47f3607fbb95ac3b8e2ec60b Changes: https://git.openjdk.org/jdk21u-dev/pull/1014/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1014&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340383 Stats: 40 lines in 1 file changed: 39 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1014.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1014/head:pull/1014 PR: https://git.openjdk.org/jdk21u-dev/pull/1014 From rehn at openjdk.org Fri Sep 27 16:22:46 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Fri, 27 Sep 2024 16:22:46 GMT Subject: [jdk17u-dev] Integrated: 8339741: RISC-V: C ABI breakage for integer on stack In-Reply-To: References: Message-ID: On Mon, 23 Sep 2024 15:45:33 GMT, Robbin Ehn wrote: > Hi all, > > This pull request contains a backport of commit [bfe7f920](https://github.com/openjdk/jdk/commit/bfe7f9205b56483b4364130a3a87c58c3fc82998) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry. > > Not clean, locally tested the new jtreg test. > > Thanks! This pull request has now been integrated. Changeset: e3231e69 Author: Robbin Ehn URL: https://git.openjdk.org/jdk17u-dev/commit/e3231e69b6843641c419a9bf326f11fa800a85c8 Stats: 156 lines in 4 files changed: 150 ins; 0 del; 6 mod 8339741: RISC-V: C ABI breakage for integer on stack Reviewed-by: fyang Backport-of: bfe7f9205b56483b4364130a3a87c58c3fc82998 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2912 From rhalade at openjdk.org Fri Sep 27 16:52:50 2024 From: rhalade at openjdk.org (Rajan Halade) Date: Fri, 27 Sep 2024 16:52:50 GMT Subject: [jdk23u] RFR: 8341059: Change Entrust TLS distrust date to November 12, 2024 Message-ID: The backport is not clean because [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) is only addressed in JDK 24. ------------- Commit messages: - 8341059: Change Entrust TLS distrust date to November 12, 2024 Changes: https://git.openjdk.org/jdk23u/pull/126/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=126&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341059 Stats: 12 lines in 4 files changed: 0 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk23u/pull/126.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/126/head:pull/126 PR: https://git.openjdk.org/jdk23u/pull/126 From kcr at openjdk.org Fri Sep 27 17:00:26 2024 From: kcr at openjdk.org (Kevin Rushforth) Date: Fri, 27 Sep 2024 17:00:26 GMT Subject: [jdk23u] RFR: 8341059: Change Entrust TLS distrust date to November 12, 2024 In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 16:46:38 GMT, Rajan Halade wrote: > The backport is not clean because [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) is only addressed in JDK 24. Even though the backport is not clean, consider changing the PR title to "Backport LONGCOMMITHASH" so that Skara will record it in the meta-data as a backport. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/126#issuecomment-2379697911 From rhalade at openjdk.org Fri Sep 27 17:08:16 2024 From: rhalade at openjdk.org (Rajan Halade) Date: Fri, 27 Sep 2024 17:08:16 GMT Subject: [jdk23u] RFR: 8341057: Add 2 SSL.com TLS roots Message-ID: Clean backport to JDK 23u ------------- Commit messages: - Backport 824a297aae15ba16cf6d7aded4b95fc9d6bf55e5 Changes: https://git.openjdk.org/jdk23u/pull/127/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=127&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341057 Stats: 98 lines in 4 files changed: 93 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk23u/pull/127.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/127/head:pull/127 PR: https://git.openjdk.org/jdk23u/pull/127 From gdams at openjdk.org Fri Sep 27 18:40:43 2024 From: gdams at openjdk.org (George Adams) Date: Fri, 27 Sep 2024 18:40:43 GMT Subject: [jdk21u-dev] Integrated: 8340383: VM issues warning failure to find kernel32.dll on Windows nanoserver In-Reply-To: References: Message-ID: <_PqNkAoXkmhcwvkmsBXKT86iMxGbBoYJIrrDeBJpFaQ=.d17b903a-726a-4166-ae81-a475a0dd82e4@github.com> On Fri, 27 Sep 2024 15:38:58 GMT, George Adams wrote: > Hi all, > > This pull request contains a backport of commit [3c97d243](https://github.com/openjdk/jdk/commit/3c97d2437d34d2db47f3607fbb95ac3b8e2ec60b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by George Adams on 24 Sep 2024 and was reviewed by David Holmes and Julian Waters. > > Thanks! This pull request has now been integrated. Changeset: c8b8f72a Author: George Adams URL: https://git.openjdk.org/jdk21u-dev/commit/c8b8f72aeffa8a93c4b848679f4eb9bd43ee2a86 Stats: 40 lines in 1 file changed: 39 ins; 0 del; 1 mod 8340383: VM issues warning failure to find kernel32.dll on Windows nanoserver Backport-of: 3c97d2437d34d2db47f3607fbb95ac3b8e2ec60b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1014 From cushon at openjdk.org Fri Sep 27 19:01:42 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Fri, 27 Sep 2024 19:01:42 GMT Subject: [jdk23u] Integrated: 8337795: Type annotation attached to incorrect type during class reading In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 17:17:13 GMT, Liam Miller-Cushon wrote: > This change fixes a bug in javac's handling of type annotations in bytecode, which was logic first added in JDK 22 as part of the fix for JDK-8225377. This pull request has now been integrated. Changeset: a55e4763 Author: Liam Miller-Cushon Committer: Paul Hohensee URL: https://git.openjdk.org/jdk23u/commit/a55e476321ead9d28a7df096f8ef715bb7b51177 Stats: 109 lines in 2 files changed: 25 ins; 44 del; 40 mod 8337795: Type annotation attached to incorrect type during class reading Backport-of: 8d0831478338e9b084b2c47f46eba9faae3a5eb6 ------------- PR: https://git.openjdk.org/jdk23u/pull/67 From rhalade at openjdk.org Fri Sep 27 22:41:45 2024 From: rhalade at openjdk.org (Rajan Halade) Date: Fri, 27 Sep 2024 22:41:45 GMT Subject: [jdk23u] Integrated: 8341057: Add 2 SSL.com TLS roots In-Reply-To: References: Message-ID: <2D6keRjkoIbR5tKDe8V4LQqRixswhf6YlaV5GVVLNg4=.3fa8f04b-8e2e-4db3-bef8-32d01e7bdc60@github.com> On Fri, 27 Sep 2024 17:00:20 GMT, Rajan Halade wrote: > Clean backport to JDK 23u This pull request has now been integrated. Changeset: 6b9dcdbc Author: Rajan Halade URL: https://git.openjdk.org/jdk23u/commit/6b9dcdbcb299a9fe83b9558fa82659475bb4bb78 Stats: 98 lines in 4 files changed: 93 ins; 1 del; 4 mod 8341057: Add 2 SSL.com TLS roots Backport-of: 824a297aae15ba16cf6d7aded4b95fc9d6bf55e5 ------------- PR: https://git.openjdk.org/jdk23u/pull/127 From ascarpino at openjdk.org Fri Sep 27 23:03:50 2024 From: ascarpino at openjdk.org (Anthony Scarpino) Date: Fri, 27 Sep 2024 23:03:50 GMT Subject: [jdk23u] RFR: 8341059: Change Entrust TLS distrust date to November 12, 2024 In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 16:46:38 GMT, Rajan Halade wrote: > The backport is not clean because [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) is only addressed in JDK 24. Looks good ------------- Marked as reviewed by ascarpino (Reviewer). PR Review: https://git.openjdk.org/jdk23u/pull/126#pullrequestreview-2334782311 From rhalade at openjdk.org Fri Sep 27 23:10:41 2024 From: rhalade at openjdk.org (Rajan Halade) Date: Fri, 27 Sep 2024 23:10:41 GMT Subject: [jdk23u] Integrated: 8341059: Change Entrust TLS distrust date to November 12, 2024 In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 16:46:38 GMT, Rajan Halade wrote: > The backport is not clean because [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) is only addressed in JDK 24. This pull request has now been integrated. Changeset: cc6f90a7 Author: Rajan Halade URL: https://git.openjdk.org/jdk23u/commit/cc6f90a77bf08c8cc1cc2157ebfbbd1bf74dd5d4 Stats: 12 lines in 4 files changed: 0 ins; 0 del; 12 mod 8341059: Change Entrust TLS distrust date to November 12, 2024 Reviewed-by: ascarpino Backport-of: f554c3ffce7599fdb535b03db4a6ea96870b3c2d ------------- PR: https://git.openjdk.org/jdk23u/pull/126 From andrew at openjdk.org Fri Sep 27 23:47:38 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 27 Sep 2024 23:47:38 GMT Subject: [jdk21u-dev] RFR: 8341059: Change Entrust TLS distrust date to November 12, 2024 Message-ID: <7vZuE1siKa9wZGjSHg1yTubxKcA11XI7rYCwLHsc1_Y=.23f4d493-a3ed-49b0-9bd2-361cd86b0006@github.com> Hi all, This pull request contains a backport of commit [f554c3ff](https://github.com/openjdk/jdk/commit/f554c3ffce7599fdb535b03db4a6ea96870b3c2d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Rajan Halade on 27 Sep 2024 and was reviewed by Sean Mullan. The commit does not apply cleanly to 21u-dev due to the absence of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560). Equivalent changes to those in `distrust/Entrust.java` are applied to `Entrust/Distrust.java` instead. The tests in `test/jdk/sun/security/ssl/X509TrustManagerImpl/Entrust` pass with the updated build and fail against 21.0.4. Thanks! ------------- Commit messages: - Backport f554c3ffce7599fdb535b03db4a6ea96870b3c2d Changes: https://git.openjdk.org/jdk21u-dev/pull/1015/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1015&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341059 Stats: 12 lines in 4 files changed: 0 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1015.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1015/head:pull/1015 PR: https://git.openjdk.org/jdk21u-dev/pull/1015 From mbalao at openjdk.org Sat Sep 28 04:25:41 2024 From: mbalao at openjdk.org (Martin Balao) Date: Sat, 28 Sep 2024 04:25:41 GMT Subject: [jdk21u-dev] RFR: 8341059: Change Entrust TLS distrust date to November 12, 2024 In-Reply-To: <7vZuE1siKa9wZGjSHg1yTubxKcA11XI7rYCwLHsc1_Y=.23f4d493-a3ed-49b0-9bd2-361cd86b0006@github.com> References: <7vZuE1siKa9wZGjSHg1yTubxKcA11XI7rYCwLHsc1_Y=.23f4d493-a3ed-49b0-9bd2-361cd86b0006@github.com> Message-ID: On Fri, 27 Sep 2024 23:40:46 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [f554c3ff](https://github.com/openjdk/jdk/commit/f554c3ffce7599fdb535b03db4a6ea96870b3c2d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Rajan Halade on 27 Sep 2024 and was reviewed by Sean Mullan. > > The commit does not apply cleanly to 21u-dev due to the absence of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560). Equivalent changes to those in `distrust/Entrust.java` are applied to `Entrust/Distrust.java` instead. > > The tests in `test/jdk/sun/security/ssl/X509TrustManagerImpl/Entrust` pass with the updated build and fail against 21.0.4. > > Thanks! Looks good to me. ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1015#pullrequestreview-2334873913 From andrew at openjdk.org Sat Sep 28 15:42:45 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 28 Sep 2024 15:42:45 GMT Subject: [jdk21u-dev] RFR: 8341059: Change Entrust TLS distrust date to November 12, 2024 In-Reply-To: References: <7vZuE1siKa9wZGjSHg1yTubxKcA11XI7rYCwLHsc1_Y=.23f4d493-a3ed-49b0-9bd2-361cd86b0006@github.com> Message-ID: On Sat, 28 Sep 2024 04:23:06 GMT, Martin Balao wrote: > Looks good to me. Thanks Martin for the quick review. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1015#issuecomment-2380712896 From andrew at openjdk.org Sun Sep 29 12:00:46 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 29 Sep 2024 12:00:46 GMT Subject: [jdk11u-dev] RFR: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 07:25:15 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [e61252dc](https://github.com/openjdk/jdk/commit/e61252dc278fd44345c5377811552ed6760ffcf0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Chris Hegarty on 9 Oct 2018 and was reviewed by Daniel Fuchs. > > Thanks! Confirmed clean. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2942#pullrequestreview-2335837311 From duke at openjdk.org Mon Sep 30 06:12:08 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 30 Sep 2024 06:12:08 GMT Subject: [jdk11u-dev] RFR: 8299254: Support dealing with standard assert macro [v5] In-Reply-To: References: Message-ID: > Backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) on top of the previous PR [`macos-12` github actions ](https://github.com/openjdk/jdk11u-dev/pull/2940). > > This will make the github actions in `jdk11u-dev` run again on top of `macos-12` / `xcode-13.4.1` . > > The change is minimal, and should work properly with no changes on any existing `macos-11` CI pipelines. Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: Review fixes for 8299254 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2937/files - new: https://git.openjdk.org/jdk11u-dev/pull/2937/files/76d976f7..ed195ef2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2937&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2937&range=03-04 Stats: 15 lines in 3 files changed: 0 ins; 12 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2937.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2937/head:pull/2937 PR: https://git.openjdk.org/jdk11u-dev/pull/2937 From duke at openjdk.org Mon Sep 30 06:12:09 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 30 Sep 2024 06:12:09 GMT Subject: [jdk11u-dev] RFR: 8299254: Support dealing with standard assert macro [v4] In-Reply-To: <8sOAv72_VVpeKetLq2O2AQo0SyxMMCpbw04VQRP9xTk=.1b887146-8432-4c13-95b5-e0e3929d026d@github.com> References: <8sOAv72_VVpeKetLq2O2AQo0SyxMMCpbw04VQRP9xTk=.1b887146-8432-4c13-95b5-e0e3929d026d@github.com> Message-ID: On Thu, 26 Sep 2024 13:30:09 GMT, Antonio Vieiro wrote: >> Backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) on top of the previous PR [`macos-12` github actions ](https://github.com/openjdk/jdk11u-dev/pull/2940). >> >> This will make the github actions in `jdk11u-dev` run again on top of `macos-12` / `xcode-13.4.1` . >> >> The change is minimal, and should work properly with no changes on any existing `macos-11` CI pipelines. > > Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' of github.com:openjdk/jdk11u-dev into backports/JDK-8299254-macos12 > - Backport 89dd23f2fab0d98879e68f817923656e113087e3 > - 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 Thanks for the review! I tested this with tier1 tests and with gtest. Gtest pass on macos12/x64 too. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2937#issuecomment-2382191340 From duke at openjdk.org Mon Sep 30 06:12:09 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 30 Sep 2024 06:12:09 GMT Subject: [jdk11u-dev] RFR: 8299254: Support dealing with standard assert macro [v4] In-Reply-To: References: <8sOAv72_VVpeKetLq2O2AQo0SyxMMCpbw04VQRP9xTk=.1b887146-8432-4c13-95b5-e0e3929d026d@github.com> Message-ID: On Fri, 27 Sep 2024 09:48:54 GMT, Severin Gehwolf wrote: >> Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: >> >> - Merge branch 'master' of github.com:openjdk/jdk11u-dev into backports/JDK-8299254-macos12 >> - Backport 89dd23f2fab0d98879e68f817923656e113087e3 >> - 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 > > test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp line 2: > >> 1: /* >> 2: * Copyright (c) 2016, 2024, Oracle and/or its affiliates. All rights reserved. > > Suggestion: > > * Copyright (c) 2016, 2022, Oracle and/or its affiliates. All rights reserved. > > > So as to match the JDK 17u version of the patch. Updated in new commit. > test/hotsp