[jdk17u-dev] RFR: 8273979: move some os time related functions to os_posix for POSIX platforms

[Radim Vansa]

On Thu, 5 Sep 2024 07:27:00 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit[ 1c6fa113](https://github.com/openjdk/jdk/commit/1c6fa113bd06585945e077f0d2004a291c27946d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> 
>> The commit being backported was authored by Matthias Baesken on 23 Sep 2021 and was reviewed by David Holmes and Lutz Schmidt.
>> 
>> The backport applies cleanly, was created by the /backport command.
>> 
>> Thanks!
>
> Hi @rvansa 
> I am not so happy about this backport. 
> Simplifying another project is not an eligible reason to backport things.
> Also, you did not test macos and expecially not aix. Does that still build?

Hi @GoeLin , understood, though I am rather trying to be honest than making up a synthetic argument. Since it was accepted in the mainline I could say that it is an improvement in code quality.

MacOS should be tested here in GHA, regrettably I don't know where to get AIX for testing.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2831#issuecomment-2331118243