[jdk17u-dev] RFR: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null

[Goetz Lindenmaier]

On Wed, 28 Aug 2024 13:00:13 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null
>
> src/hotspot/share/memory/guardedMemory.cpp line 38:
> 
>> 36:     if (ptr != nullptr) {
>> 37:       memcpy(innerp, ptr, len);
>> 38:     }
> 
> Hmm. innerp can never be null. If anything, we should assert.

Hi,
I don't understand. First, innerp is not checked for null. Second: does the code in 17 differ to 21&head? Else we should change this to an assertion in head, first.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2829#discussion_r1756462276