[jdk17u-dev] RFR: 8331411: Shenandoah: Reconsider spinning duration in ShenandoahLock [v2]

[Xiaolong Peng]

On Thu, 12 Sep 2024 14:00:54 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:

>> Hi, 
>>     This PR is a Backport of [[JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411)]: Reconsider spinning duration in ShenandoahLock. The original commit was authored by Xiaolong Peng on 26 June 2024 and was reviewed by[Aleksey Shipilëv](https://github.com/shipilev), [Kelvin Nilsen](https://github.com/kdnilsen), and [William Kemper](https://github.com/earthling-amzn), it had already been backported to jdk21.
>>     
>>    It was not a clean merge, there were some conflicts and API change which have been resolved and tested. Meanwhile, given there were conflicts to resolve, I also updated the invalid comments which was fixed in JDK-8335904.
>>    
>>    This is the third PR of the series of improvements we are proposing to backport to jdk17 to solve the contention issue in ShenandoahLock, we have observed  the lock contention is causing real problems in some of our products.
>> 
>>    Here is the series of improvements for ShenandoahLock I'm going to backport to JDK17:
>> 
>> | Bug         | Title                                          | PR         |
>> | ----------- | ---------------------------------------------- |------------|
>> | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM     | [2797](https://github.com/openjdk/jdk17u-dev/pull/2797)     |
>> | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS              | [2845](https://github.com/openjdk/jdk17u-dev/pull/2845) |
>> | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock |  [2868](https://github.com/openjdk/jdk17u-dev/pull/2868)  |
>> | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock          |  [2868](https://github.com/openjdk/jdk17u-dev/pull/2868)   |
>> 
>> ### Additional test
>> - [x] MacOS AArch64 server fastdebug, hotspot_gc_shenandoah
>
> Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Correct comments

Thanks all for the reviews and approvals!

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2868#issuecomment-2356301200