[jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large

[Martin Balao]

On Thu, 26 Sep 2024 06:57:11 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi,
> 
> Can I have a review for the backport of JDK-8263031 to 17u? This backport fixes a bug and will also serve as a dependency for a backport of 8328286.
> 
> The JDK main line patch did not apply cleanly because JDK-8295944 was backported to 17u already and tests were moved.
> 
> In addition, I had to make changes to PushPromiseContinuation.java to adapt the test to its new location (see jtreg header diff) and context (see the invocations to conn.addToOutputQ). With these changes, the test is passing.
> 
> No regressions observed in the jdk/java/net/httpclient tests category.
> 
> Thanks,
> Martin.-

I forgot to enable the GHA when forking. They're disabled by default.
Running manually now.

On Thursday, September 26, 2024, Andrew Hughes ***@***.***>
wrote:

> Please enable the GHA action tests!
>
> I think the problem here is this is against 17u, not 17u-dev. 17u is
> closed for the October release: https://wiki.openjdk.org/
> display/JDKUpdates/JDK+17u
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/jdk17u/pull/400#issuecomment-2377255012>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFID3EE7YLE3DOVQNTJIKPLZYQP6JAVCNFSM6AAAAABO4JUI2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXGI2TKMBRGI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>

-------------

PR Comment: https://git.openjdk.org/jdk17u/pull/400#issuecomment-2377292072