[jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large

[Alexey Bakhtin]

On Thu, 26 Sep 2024 06:57:11 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi,
> 
> Can I have a review for the backport of JDK-8263031 to 17u? This backport fixes a bug and will also serve as a dependency for a backport of 8328286.
> 
> The JDK main line patch did not apply cleanly because JDK-8295944 was backported to 17u already and tests were moved.
> 
> In addition, I had to make changes to PushPromiseContinuation.java to adapt the test to its new location (see jtreg header diff) and context (see the invocations to conn.addToOutputQ). With these changes, the test is passing.
> 
> No regressions observed in the jdk/java/net/httpclient tests category.
> 
> Thanks,
> Martin.-

test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java line 34:

> 32:  *        jdk.httpclient.test.lib.http2.BodyOutputStream
> 33:  *        jdk.httpclient.test.lib.http2.OutgoingPushPromise
> 34:  * @modules java.base/sun.net.www.http

I think the module section is not required anymore as soon as JDK-8295944 in the JDK17 already

-------------

PR Review Comment: https://git.openjdk.org/jdk17u/pull/400#discussion_r1777380619