[jdk17u] RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2]
Matthias Baesken
mbaesken at openjdk.org
Fri Sep 27 08:13:44 UTC 2024
On Thu, 26 Sep 2024 20:46:21 GMT, Martin Balao <mbalao at openjdk.org> wrote:
>> Hi,
>>
>> Can I have a review for the backport of JDK-8263031 to 17u? This backport fixes a bug and will also serve as a dependency for a backport of 8328286.
>>
>> The JDK main line patch did not apply cleanly because JDK-8295944 was backported to 17u already and tests were moved.
>>
>> In addition, I had to make changes to PushPromiseContinuation.java to adapt the test to its new location (see jtreg header diff) and context (see the invocations to conn.addToOutputQ). With these changes, the test is passing.
>>
>> No regressions observed in the jdk/java/net/httpclient tests category.
>>
>> Thanks,
>> Martin.-
>
> Martin Balao has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove unnecessary @modules header.
Marked as reviewed by mbaesken (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk17u/pull/400#pullrequestreview-2333070907
More information about the jdk-updates-dev
mailing list