[jdk11u-dev] RFR: 8299254: Support dealing with standard assert macro [v5]
Antonio Vieiro
duke at openjdk.org
Mon Sep 30 08:24:41 UTC 2024
On Mon, 30 Sep 2024 06:12:08 GMT, Antonio Vieiro <duke at openjdk.org> wrote:
>> Backport of [JDK-8299254 Support dealing with standard assert macro](https://bugs.openjdk.org/browse/JDK-8299254) on top of the previous PR [`macos-12` github actions ](https://github.com/openjdk/jdk11u-dev/pull/2940).
>>
>> This will make the github actions in `jdk11u-dev` run again on top of `macos-12` / `xcode-13.4.1` .
>>
>> The change is minimal, and should work properly with no changes on any existing `macos-11` CI pipelines.
>
> Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision:
>
> Review fixes for 8299254
Adding gtest to GHA is [easy and does not take too much time to run](https://github.com/openjdk/jdk11u-dev/commit/4688a46d0b3ff6656415e2931184391b358040e8). Here're results for [macos-12](https://productionresultssa17.blob.core.windows.net/actions-results/b04a7192-f356-4cfb-b21c-655a1f034da1/workflow-job-run-064b10e3-6341-54c8-9ad0-d7271a2dfd47/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-09-30T08%3A26%3A44Z&sig=1tvmnERTieotDGFSe9kF24Llz5WfCglFfzkbApZWVzY%3D&ske=2024-09-30T19%3A31%3A31Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2024-09-30T07%3A31%3A31Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2024-08-04&sp=r&spr=https&sr=b&st=2024-09-30T08%3A16%3A39Z&sv=2024-08-04), [linux](https://productionresultssa17.blob.core.windows.net/actions-results/b04a7192-f356-4cfb-b21c-655a1f034da1/workflow-job-run-db478f82-522f-548f-c8aa-a62bbe03ab69/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-09-30T08%3A30%3A29Z&sig=UIpnNFljb0gKGgzHTEBMuRYLPyrrXwhwWKx9OaINf4s%3D&ske=2024-09-30T16
%3A45%3A08Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2024-09-30T04%3A45%3A08Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2024-08-04&sp=r&spr=https&sr=b&st=2024-09-30T08%3A20%3A24Z&sv=2024-08-04) and [windows](https://productionresultssa17.blob.core.windows.net/actions-results/b04a7192-f356-4cfb-b21c-655a1f034da1/workflow-job-run-db9dfd45-fd3a-5436-aec9-954be22895b4/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-09-30T08%3A31%3A09Z&sig=khZoofxiUvZSb20D2LKYKFIjloVkpSS14Eh%2BNPQQSJs%3D&ske=2024-09-30T19%3A31%3A21Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2024-09-30T07%3A31%3A21Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2024-08-04&sp=r&spr=https&sr=b&st=2024-09-30T08%3A21%3A04Z&sv=2024-08-04)
-------------
PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2937#issuecomment-2382430845
More information about the jdk-updates-dev
mailing list