[jdk17u-dev] RFR: 8330106: C2: VectorInsertNode::make() shouldn't call ConINode::make() directly

[Satyen Subramaniam]

Backporting JDK-8330106: C2: VectorInsertNode::make() shouldn't call ConINode::make() directly. Adjusts code to call PhaseValues::intcon(), which is required so the node is properly entered in the GVN's hash table and its type is properly recorded in the GVN's type table. Ran GHA Sanity Checks, and local Tier 1, and Tier 2 tests. Patch is clean.

-------------

Commit messages:
 - Backport bde3fc0c03c87d1f2605ae6bb84c33fadb7aa865

Changes: https://git.openjdk.org/jdk17u-dev/pull/3433/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3433&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8330106
  Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk17u-dev/pull/3433.diff
  Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3433/head:pull/3433

PR: https://git.openjdk.org/jdk17u-dev/pull/3433