[jdk21u-dev] RFR: 8343855: HTTP/2 ConnectionWindowUpdateSender may miss some unprocessed DataFrames from closed streams [v4]

[Goetz Lindenmaier]

On Fri, 4 Apr 2025 21:50:04 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> Backport for parity with Oracle 21.0.8. Passes tier2 and modified tests. Low risk: the patch /1 locks existing unlocked code, which is at worst a performance issue, but necessary for correctness, /2 checks for a closed stream before pushing a data frame into it, see pushDataFrame() in Stream.java.
>> 
>> Clean except for whitespace change in Stream.java from 8309118, 8309118 isn't in 21u.
>
> Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into 8343855
>  - Merge branch 'master' into 8343855
>  - Revert part of 8309118
>  - Backport bd6152f5967107d7b32db9bcfa224fc07314f098

Hi @phohensee,
Thanks for the detailed risk assessment, I think this is ok for backport.
One question: Why is there a change to test [ShutdownNow.java](https://github.com/openjdk/jdk21u-dev/pull/1585/files#diff-dfe4461252d21dc54a2a5e17d72047bf89bd3688dce084253fbcb0382073cc77) in this change?  I can't see that in the original.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1585#issuecomment-2800070886