[jdk21u-dev] RFR: 8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries (JDK-8225377) [v9]
Severin Gehwolf
sgehwolf at openjdk.org
Tue Apr 15 15:06:08 UTC 2025
On Mon, 14 Apr 2025 21:24:35 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java line 2298:
>>
>>> 2296: }
>>> 2297: t.interfaces_field = interfaces.toList();
>>> 2298: t.supertype_field = addTypeAnnotations(t.supertype_field, classExtends(65535));
>>
>> can we use a named constant here instead of a literal?
>
> That happened as a different change: https://bugs.openjdk.org/browse/JDK-8340024
>
> My understanding was that the best practice for backports was to minimize the number of changes from the original patch, and if a chain of related changes needed to be backported to do them all as separate changes, is that accurate? Would you like me to backport that one as well?
@cushon You could fold this change into this one. It makes sense to backport them both. Then use `/issue add JDK-8340024` on this PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1251#discussion_r2044855479
More information about the jdk-updates-dev
mailing list