[jdk11u-dev] RFR: 8315380: AsyncGetCallTrace crash in frame::safe_for_sender [v2]
Jaroslav Bachorik
jbachorik at openjdk.org
Thu Apr 17 07:08:58 UTC 2025
On Wed, 16 Apr 2025 18:32:52 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> What's the meaning of trailing \ here?
No particular meaning, removed.
> I think you can do unextended_sp >= thread->stack_end() to better capture the intent and match 8238988 better.
Yes. Done.
Also, I noticed that the check for unextended_sp is not done very consistently across archs. This is also changed in 8238988 but I opted for the simplicity and added the change only for the arch for which the original issue was reported. I hope it's ok but if a more extensive change is preferred I can apply similar logic to other archs as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/3003#discussion_r2048367427
More information about the jdk-updates-dev
mailing list