[jdk21u-dev] RFR: 8354893: [REDO BACKPORT] javac crashes while adding type annotations to the return type of a constructor [v2]

[Liam Miller-Cushon]

> [JDK-8354893](https://bugs.openjdk.org/browse/JDK-8354893) is a redo of the backport of [JDK-8320001](https://bugs.openjdk.org/browse/JDK-8320001), which is a follow-up to [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377).

Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:

 - Backport 5e24aaf4f7f11862ec8ac9d5c3e65d614104fb2c
 - Merge remote-tracking branch 'origin/master' into backport-JDK-8337795
 - Backport 8d0831478338e9b084b2c47f46eba9faae3a5eb6
 - Merge branch 'master' into redo-JDK-8341779
 - 8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries
 - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942
 - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942
 - 8336942: Improve test coverage for class loading elements with annotations of different retentions
   
   Reviewed-by: vromero

-------------

Changes:
  - all: https://git.openjdk.org/jdk21u-dev/pull/1670/files
  - new: https://git.openjdk.org/jdk21u-dev/pull/1670/files/1a10cd0d..1a10cd0d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1670&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1670&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk21u-dev/pull/1670.diff
  Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1670/head:pull/1670

PR: https://git.openjdk.org/jdk21u-dev/pull/1670