[jdk17u-dev] RFR: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder [v2]

[Ralf Schmelter]

On Fri, 25 Apr 2025 10:11:21 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this for parity with 17.0.16-oracle based on the push to 21.
>> I verified that the tests omitted there have not been backported
>> to 17 in the meantime etc.
>> Anyways, already the build will detect if a change that needs
>> to be adapted to this one is backported.
>> 
>> I needed some adaptions on top of the jdk21 change:
>> 
>> Omitted: test/hotspot/jtreg/compiler/arguments/TestCompileThresholdScaling.java
>> Introduced by "8283807: Handle CompileThreshold the same as other thresholds when scaled with -XX:CompileThresholdScaling".
>> This eventually is a candidate for backport. Omit for now I think.
>> 
>> Omitted: test/hotspot/jtreg/compiler/c1/TestPrintC1Statistics.java
>> Introduced by "8296969: C1: PrintC1Statistics is broken after JDK-8292878".  JDK-8292878 is
>> an assembler code cleanup that came in 20. 
>> 
>> test/hotspot/jtreg/compiler/loopstripmining/CheckLoopStripMining.java
>> test/hotspot/jtreg/compiler/vectorapi/TestVectorErgonomics.java
>> Trivial resolve.
>> 
>> Omitted: test/hotspot/jtreg/gc/x/TestHighUsage.java
>> Not in 17. Generational ZGC missing.
>> 
>> test/hotspot/jtreg/gc/z/TestHighUsage.java
>> Trivial resolve. Generational ZGC missing.
>> 
>> Omitted: test/jdk/java/io/File/TempDirDoesNotExist.java
>> Introduced by "8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist". Not
>> a candidate for backport, changes behavior.
>> 
>> Omitted: test/jdk/jdk/jfr/jcmd/TestJcmdPreserveRepository.java
>> Introduced by "8303229: JFR: Preserve disk repository after exit". Would be nice to have
>> in 17, but larger change with CSR.
>> 
>> 
>> **The following files need adidtional adaptions, see extra commit:**
>> 
>> test/hotspot/jtreg/compiler/c2/Test8062950.java
>> Was removed with BiasedLocking.
>> 
>> test/hotspot/jtreg/runtime/jni/checked/TestCheckedEnsureLocalCapacity.java
>> test/jdk/com/sun/management/DiagnosticCommandMBean/DcmdMBeanTestCheckJni.java
>> Removed by "8297106: Remove the -Xcheck:jni local reference capacity checking" in 20.
>> 
>> test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/Test.java
>> This test was only added in the backport of "8286490: JvmtiEventControllerPrivate::set_event_callbacks
>> CLEARING_MASK computation is incorrect" to 17.
>
> Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into goetz_backport_8321713
>  - Adapt additional calls
>  - Backport e7ebae54a7e0250cb9f645bd2bdc04a60f6b0cba

Looks good.

-------------

Marked as reviewed by rschmelter (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/3495#pullrequestreview-2799285202