[jdk17u-dev] RFR: 8320687: sun.jvmstat.monitor.MonitoredHost.getMonitoredHost() throws unexpected exceptions when invoked concurrently

[Goetz Lindenmaier]

On Fri, 25 Apr 2025 16:37:20 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote:

> Backporting JDK-8320687: sun.jvmstat.monitor.MonitoredHost.getMonitoredHost() throws unexpected exceptions when invoked concurrently. The fix proposes to guard the usage of the shared ServiceLoader instance through the monitoredHosts object monitor. Adds test. Ran GHA Sanity Checks, local Tier 1, 2, and 3, and new `test/jdk/sun/jvmstat/monitor/MonitoredVm/ConcurrentGetMonitoredHost.java` tests. Patch is almost clean (copyright header is slightly different).

Hi @phohensee @satyenme 

Your patch breaks testing. The test you submitted uses Java that can not be compiled with 17.  Please fix or back out asap!

You are supposed to run tests included in the change before you do a backport!!!  You claim you did so, so why is the syntax wrong?

      try (ExecutorService executor = Executors.newCachedThreadPool()) {
                             ^
    (ExecutorService cannot be converted to AutoCloseable)
1 error
result: Failed. Compilation failed: Compilation failed

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3531#issuecomment-2837801318