[jdk17u-dev] RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v5]

[Ralf Schmelter]

On Tue, 12 Aug 2025 09:10:22 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this for parity with 17.0.17-oracle based on the change in 21.
>> 
>> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java
>> Two trivial resolves due to context.
>> 
>> src/java.net.http/share/classes/jdk/internal/net/http/WindowUpdateSender.java
>> 
>> Resolved because 8308310: HttpClient: Avoid logging or locking from within synchronized blocks
>> is not in 17.
>> 
>> src/java.net.http/share/classes/module-info.java
>> Omitted, as "8296804: Document HttpClient configuration properties in java.net.http module-info"
>> is not in 17.  The CSR for 17 documents that this is dropped.
>> 
>> Follow ups are on the list of backports I will do.
>> Blocking changes all already in 17.
>> 
>> I had to adapt ConnectionFlowControlTest.java and StreamFlowControlTest.java because HttpClient does not
>> implement AutoClosable / shutdownNow() / close() in 17.
>> I also amended the @build instructions in StreamFlowControlTest.java.
>
> Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
> 
>  - Merge branch 'master' into goetz_backport_8342075
>  - Test improvements by Aleksey Bakhtin
>  - Merge branch 'master' into goetz_backport_8342075
>  - Merge branch 'openjdk:master' into goetz_backport_8342075
>  - Make tests compile
>  - Resolved changes
>  - Backport 32ac3e713ea4370e496717967fff7de9450d2f69
>  - backport 209939a90e9b804da4c37ebd978b088cb8f41ead

Looks good.

-------------

Marked as reviewed by rschmelter (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/3786#pullrequestreview-3119534505