[jdk17u-dev] RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux

[Stanislav Bashkyrtsev]

On Thu, 25 Jan 2024 15:05:49 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> This is an unclean backport of the filesystem enhancement on Linux to use `statx` where available. The JDK 21u patch didn't apply cleanly because JDK 20+ has [JDK-8283335](https://bugs.openjdk.org/browse/JDK-8283335) which isn't needed for this backport. The relevant code has been adjusted to work without that enhancement being present (see different commits). Copyright dates needed manual adjusting and the test needed some trivial changes related to test lib and import so that it works (failed to compile on 17u).
> 
> As for the code changes in `UnixNativeDispatcher.c`, the JNI method `Java_sun_nio_fs_UnixNativeDispatcher_stat1()` returning the mode for a file/directory doesn't exist in JDK 21 (again [JDK-8283335](https://bugs.openjdk.org/browse/JDK-8283335)). Therefore, I've adjusted the code to also use `statx` where available for symmetry.
> 
> I'll follow up with the related build fix (for the test libs) in a dependent PR (JDK-8319922).
> 
> Please review!
> 
> Testing:
> - [x] GHA
> - [x] Build test on various Linux (aarch64, Alpine x64, ppc64le, x64) and Unix OSes (AIX, Mac) so as to not break the build there.
> - [x] Manual testing for `BasicFileAttributes.creationTime()`. Looks good.

My point is that the methods used to be consistent: you pass createTime when changing it through `BasicFileAttributeView`, and you get the same result in `BasicFileAttributes.creationTime()`. I don't know how this worked before, but it did. I think it makes sense to keep the API consistent, or at least mention the inconsistencies in the docs.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2175#issuecomment-3224266873