[jdk25u-dev] RFR: 8365398: TEST_BUG: java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java failing intermittently

[Aleksey Shipilev]

On Tue, 2 Dec 2025 19:52:25 GMT, Roland Mesde <duke at openjdk.org> wrote:

> Backporting JDK-8365398: TEST_BUG: java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java failing intermittently.
> 
> For parity with Oracle JDK. Increased available object count threshold to 6 (half of total created objects) to fix intermittent macOS test failures caused by slower garbage collection. 
> 
> Merge conflict (resolved) was a change in class import ordering and the correction of a comment.
> 
> Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed) and related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
> 
> (Passed) - make test-tier1
> (Passed) - make test TEST=test/jdk/java/rmi/transport
> 
> Results are attached.
> 
> [linux-aarch64-jtreg-tier1.log](https://github.com/user-attachments/files/23911453/linux-aarch64-jtreg-tier1.log)
> [linux-aarch64-specific-test.log](https://github.com/user-attachments/files/23911454/linux-aarch64-specific-test.log)
> [linux-x64-jtreg-tier1.log](https://github.com/user-attachments/files/23911455/linux-x64-jtreg-tier1.log)
> [linux-x64-specific-test.log](https://github.com/user-attachments/files/23911457/linux-x64-specific-test.log)
> [macos-aarch64-jtreg-tier1.log](https://github.com/user-attachments/files/23911458/macos-aarch64-jtreg-tier1.log)
> [macos-aarch64-specific-test.log](https://github.com/user-attachments/files/23911459/macos-aarch64-specific-test.log)
> [windows-x64-jtreg-tier1.log](https://github.com/user-attachments/files/23911460/windows-x64-jtreg-tier1.log)
> [windows-x64-specific-test.log](https://github.com/user-attachments/files/23911461/windows-x64-specific-test.log)

test/jdk/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java line 61:

> 59: import java.lang.reflect.*;
> 60: import java.rmi.registry.*;
> 61: import java.util.concurrent.CountDownLatch;

I can see why you would want to do this, as mainline change introduced this out-of-order. But for backports, you want to stay faithful to the original commit as much as possible. So refrain from making cosmetic changes as you go. If you still want to fix this, you can do a trivial PR against mainline, and backport the follow-up fix. But I think it does not worth the trouble.

test/jdk/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java line 141:

> 139: 
> 140:         /* numLeft should not be greater than 2 - if 11 there is a problem. */
> 141:         if (numLeft > 2) {

I don't understand your comment: "The "(numLeft > 2)" condition which was changed to "(numLeft > 4)" then changed back to "(numLeft > 2)". AFAICS, the original commit has this hunk exactly as you have written here?

https://github.com/openjdk/jdk/commit/4b4d0cd35a32448e4b056109c502af2765766432#diff-9348ad66aa09ad1a3d437e736b0ec93f9f674ba91864fd15ca59375093386548L128-R141

-------------

PR Review Comment: https://git.openjdk.org/jdk25u-dev/pull/46#discussion_r2585758765
PR Review Comment: https://git.openjdk.org/jdk25u-dev/pull/46#discussion_r2585779669