[jdk25u-dev] RFR: 8365398: TEST_BUG: java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java failing intermittently

[Aleksey Shipilev]

On Wed, 3 Dec 2025 16:39:47 GMT, Roland Mesde <duke at openjdk.org> wrote:

>> test/jdk/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java line 141:
>> 
>>> 139: 
>>> 140:         /* numLeft should not be greater than 2 - if 11 there is a problem. */
>>> 141:         if (numLeft > 2) {
>> 
>> I don't understand your comment: "The "(numLeft > 2)" condition which was changed to "(numLeft > 4)" then changed back to "(numLeft > 2)". AFAICS, the original commit has this hunk exactly as you have written here?
>> 
>> https://github.com/openjdk/jdk/commit/4b4d0cd35a32448e4b056109c502af2765766432#diff-9348ad66aa09ad1a3d437e736b0ec93f9f674ba91864fd15ca59375093386548L128-R141
>
> This commit changed the condition in line 132/129 of "CheckLeaseLeak.java" from "(numLeft > 2)" to "(numLeft > 4)"
> 
> https://github.com/openjdk/jdk/commit/5a442197d21e1dfb89cdbf5f0ad5596869ab333a
> 
> Then the following commit  changed the condition in line 129/141 from "(numLeft > 4)" back to "(numLeft > 2)"
> 
> https://github.com/openjdk/jdk/commit/4b4d0cd35a32448e4b056109c502af2765766432

Yes, but why does it matter for this backport? https://github.com/openjdk/jdk/commit/5a442197d21e1dfb89cdbf5f0ad5596869ab333a is already in 25u. So https://github.com/openjdk/jdk/commit/4b4d0cd35a32448e4b056109c502af2765766432 that you are backporting is clean addition on top of it? 

I am just confused why the merge was even required.

-------------

PR Review Comment: https://git.openjdk.org/jdk25u-dev/pull/46#discussion_r2585873293