[jdk25u-dev] RFR: 8360562: sun/security/tools/keytool/i18n.java add an ability to add comment for failures

[duke]

On Wed, 3 Dec 2025 19:37:37 GMT, Roland Mesde <duke at openjdk.org> wrote:

> Backporting JDK-8360562: sun/security/tools/keytool/i18n.java add an ability to add comment for failures.
> 
> For parity with Oracle JDK. The commit adds failure comment capability to sun/security/tools/keytool/i18n.java to enable faster verification and reporting.
> 
> Ran the manual test on macos-aarch64:
> 
> jtreg -jdk build/macosx-aarch64-server-release/images/jdk -vmoption:-Duser.language=en -m test/jdk/sun/security/tools/keytool/i18n.java
> 
> It generated the dialog box when the "fail" button is selected and the written text is reflected on the test report. Screenshots attached.
> 
> <img width="782" height="493" alt="DialogBox" src="https://github.com/user-attachments/assets/b1c10e7a-7d1e-488e-ac67-b3d61e26cbe4" />
> <img width="538" height="213" alt="TestReport" src="https://github.com/user-attachments/assets/e4c64f00-b556-4a14-9073-0df3522603b1" />
> 
> Ran GHA Sanity Checks (passed), and jtreg tier1 tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
> 
> (Passed) - make test-tier1
> 
> Results are attached.
> 
> [linux-aarch64-jtreg-tier1.log](https://github.com/user-attachments/files/23938244/linux-aarch64-jtreg-tier1.log)
> [linux-x64-jtreg-tier1.log](https://github.com/user-attachments/files/23938245/linux-x64-jtreg-tier1.log)
> [macos-aarch64-jtreg-tier1.log](https://github.com/user-attachments/files/23938246/macos-aarch64-jtreg-tier1.log)
> [windows-x64-jtreg-tier1.log](https://github.com/user-attachments/files/23938247/windows-x64-jtreg-tier1.log)

@rm-gh-8 
Your change (at version 7421a0630b7d5cae4fc56c0002ef92b32f66de5b) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk25u-dev/pull/57#issuecomment-3617434033