[jdk25u-dev] RFR: 8370572: Cgroups hierarchical memory limit is not honored after JDK-8322420

[Aleksey Shipilev]

On Mon, 15 Dec 2025 14:50:00 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> I am confused. Isn't it visibly different code? What do you mean by "no divergence"? For me, no divergence means the code in this PR repeats what is/was mainline at some point. The version you have in this PR never existed in mainline, AFAICS: neither after JDK-8370573, nor after JDK-8365606. And if it did not existed, it means we have not tested it; that's the risk we are running into here.
>
> The patch for JDK 25 won't be the same as in mainline at some point. This is nothing new when doing backports and needs to be evaluated on a case by case basis. In this case JDK-8292984 not being there in 25 makes the patch divergent. Just dragging in JDK-8292984 for sake of this fix doesn't strike me as a better risk/benefit balance. That's what it ultimately boils down to: Backport X patches as a dependency or do a reduced fix by rewriting some parts. IMO, rewriting some parts is the less risky approach for 25 and 21 that's why I've chosen this approach. It has been tested with the regression test written for that purpose.
> 
> With that said, I'd appreciate help in testing the patch if you have some means to test it outside the regression test.

Well, if the testing you want, then consider again, we picked up the *mainline* version into Corretto 25, just changing a variable name: https://github.com/corretto/corretto-25/commit/d38805b294493ad7a7e582286d64a874121417f8, https://github.com/corretto/corretto-25/pull/26/ -- and not only we tested it on our case scenarios, it is currently running in production for 6+ weeks! You don't get better testing than that :)

-------------

PR Review Comment: https://git.openjdk.org/jdk25u-dev/pull/76#discussion_r2619966866