[jdk11u-dev] RFR: 8361748: Enforce limits on the size of an XBM image

Severin Gehwolf sgehwolf at openjdk.org
Fri Dec 19 16:12:10 UTC 2025


On Thu, 18 Dec 2025 23:47:59 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> Hi, this is an almost clean backport of openjdk/jdk17u-dev#3901.
> 
> The only differences are in context (deleted and surrounding code) due to 11u missing [JDK-8211300: Convert C-style array declarations in JDK client code](https://bugs.openjdk.org/browse/JDK-8211300).
> 
> NOTE: as part of this work, I found some issues with the original patch (see [JDK-8373727](https://bugs.openjdk.org/browse/JDK-8373727 "New XBM images parser regression: only the first line of the bitmap array is parsed")), so an additional backport of that fix will be needed too.
> 
> #### Testing
> 
> The [GitHub Actions testing run (tier1 on various platforms)](https://github.com/franferrax/jdk11u-dev/actions/runs/20177700844) has passed.
> 
> In addition, the new `test/jdk/java/awt/image/XBMDecoder/XBMDecoderTest.java` is passing in a local slowdebug build on _Fedora Linux x64_.

This looks good. Tiny nit about the copyright. Thanks!

src/java.desktop/share/classes/sun/awt/image/XbmImageDecoder.java line 1:

> 1: /*

The JDK 17u patch updates the copyright in this file for the end year to 2025. I think we should do that here as well.

-------------

PR Review: https://git.openjdk.org/jdk11u-dev/pull/3135#pullrequestreview-3599148796
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/3135#discussion_r2635560253


More information about the jdk-updates-dev mailing list