From duke at openjdk.org Sun Feb 2 17:47:01 2025 From: duke at openjdk.org (duke) Date: Sun, 2 Feb 2025 17:47:01 GMT Subject: [jdk11u-dev] Withdrawn: 8231058: VerifyOops crashes with assert(_offset >= 0) failed: offset for non comment? In-Reply-To: References: Message-ID: On Sun, 10 Nov 2024 01:24:15 GMT, SendaoYan wrote: > Hi all, > This is clean backport of [JDK-8231058](https://bugs.openjdk.org/browse/JDK-8231058), to fix JVM crash when running with `-XX:+VerifyOops`. The newly added test run failed before this backport, and run passed after apply this backport. > > Additonal testing: > > - [x] linux aarch64 build with release/slowdebug configure > - [x] linux x86_64 build with release/slowdebug configure > - [x] jtreg tests(include tier1/2/3 etc.) with release build on linux aarch64 > - [x] jtreg tests(include tier1/2/3 etc.) with release build on linux x86_64 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2963 From snazarki at openjdk.org Mon Feb 3 08:41:40 2025 From: snazarki at openjdk.org (Sergey Nazarkin) Date: Mon, 3 Feb 2025 08:41:40 GMT Subject: [jdk17u-dev] RFR: 8340547: Starting many threads can delay safepoints Message-ID: <4YaO4fYOIf8lK-iD83HTrzKYK0I1YDuL5LPubuhBwqk=.500c3c8d-f16f-4c6e-a00d-fb51f1a1faa5@github.com> I'd like to backport this fix to fix the issue with starting a lot of threads in a burst. Despite the low priority of this issue, some users have found this to be a barrier to migrating from JDK8. The backport is not clean as it needs to adjust `globals.hpp` and replace `ConditionalMutexLocker` with classic MutexLocker. The rank `nonleaf` of `UseThreadsLockThrottleLock` has been chosen to be as close as possible to the rank of `Threads_lock` and to not cause a crash in debug mode: # Internal Error (/home/ubuntu/jdk17u-dev/src/hotspot/share/runtime/mutex.cpp:398), pid=1777, tid=1782 # assert(false) failed: Attempting to acquire lock Threads_lock/22 out of order with lock ThreadsLockThrottle_lock/22 -- possible deadlock Field `_allow_vm_block` is set to `false` to prevent # Internal Error (/home/ubuntu/jdk17u-dev/src/hotspot/share/runtime/thread.cpp:981), pid=56846, tid=56851 # assert(false) failed: Possible safepoint reached by thread that does not allow it Similar PR is on review at [jdk21](https://github.com/openjdk/jdk21u-dev/pull/1365) Original fix and discussion are https://github.com/openjdk/jdk/pull/21111 Tested with tier1 (release), tier2(fastdebug), and reproducers from [JDK-8340547](https://bugs.openjdk.org/browse/JDK-8340547), [JDK-8307970](https://bugs.openjdk.org/browse/JDK-8307970) ------------- Commit messages: - Fix lock rank - Fix absence of ConditionalMutexLocker Changes: https://git.openjdk.org/jdk17u-dev/pull/3263/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3263&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340547 Stats: 14 lines in 5 files changed: 11 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3263.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3263/head:pull/3263 PR: https://git.openjdk.org/jdk17u-dev/pull/3263 From duke at openjdk.org Mon Feb 3 11:22:10 2025 From: duke at openjdk.org (PAWAN CHAWDHARY) Date: Mon, 3 Feb 2025 11:22:10 GMT Subject: [jdk24u] RFR: 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out Message-ID: 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out ------------- Commit messages: - 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out Changes: https://git.openjdk.org/jdk24u/pull/42/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=42&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344453 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk24u/pull/42.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/42/head:pull/42 PR: https://git.openjdk.org/jdk24u/pull/42 From duke at openjdk.org Mon Feb 3 13:09:56 2025 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Mon, 3 Feb 2025 13:09:56 GMT Subject: [jdk17u-dev] RFR: 8347965: (tz) Update Timezone Data to 2025a In-Reply-To: References: Message-ID: On Mon, 27 Jan 2025 11:20:35 GMT, Radek ??p wrote: > Backport of https://bugs.openjdk.org/browse/JDK-8347965 > Changes to Update Timezone Data to 2025a > > Passed tier1 tests. > Passed gtests. > > Results of > `make run-test TEST="jtreg:java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources"` > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/text/Format 111 111 0 0 > jtreg:test/jdk/java/util/TimeZone 25 25 0 0 > jtreg:test/jdk/sun/util/calendar 5 5 0 0 > jtreg:test/jdk/sun/util/resources 22 22 0 0 > ============================== > TEST SUCCESS > > Finished building target 'run-test' in configuration 'linux-x86_64-server-release' I'm adding information about java/tests run. `make test TEST="jtreg:java/time" ` ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/java/time 186 186 0 0 ============================== TEST SUCCESS ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3245#issuecomment-2630959671 From duke at openjdk.org Mon Feb 3 14:29:56 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 3 Feb 2025 14:29:56 GMT Subject: [jdk11u-dev] RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic In-Reply-To: References: Message-ID: On Fri, 3 Jan 2025 14:42:32 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8293345](https://bugs.openjdk.org/browse/JDK-8293345) (but a copyright line, that is) for parity with 11.0.27-oracle. > > Tier 1 tests pass in Linux. Let's keep it open. I may want to run additional tests too. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2983#issuecomment-2631156904 From sshivang at openjdk.org Mon Feb 3 16:05:25 2025 From: sshivang at openjdk.org (Shivangi Gupta) Date: Mon, 3 Feb 2025 16:05:25 GMT Subject: [jdk24u] RFR: 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine Message-ID: <1mEfSdstFnugU3oaI6yYSOuO0U9TV074HXG4PbYKy-g=.0a193f87-5dd5-4d40-89ba-4221b77418a0@github.com> Straight Backport. Test passed ------------- Commit messages: - Backport f6e7713bb653811423eeb2515c2f69b437750326 Changes: https://git.openjdk.org/jdk24u/pull/43/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=43&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339356 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk24u/pull/43.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/43/head:pull/43 PR: https://git.openjdk.org/jdk24u/pull/43 From jnimeh at openjdk.org Mon Feb 3 17:50:50 2025 From: jnimeh at openjdk.org (Jamil Nimeh) Date: Mon, 3 Feb 2025 17:50:50 GMT Subject: [jdk24u] Integrated: 8347506: Compatible OCSP readtimeout property with OCSP timeout In-Reply-To: References: Message-ID: On Tue, 28 Jan 2025 17:31:25 GMT, Jamil Nimeh wrote: > 8347506: Compatible OCSP readtimeout property with OCSP timeout This pull request has now been integrated. Changeset: c082dcfb Author: Jamil Nimeh URL: https://git.openjdk.org/jdk24u/commit/c082dcfbfbfd07079abae1e06a24079099367a1d Stats: 73 lines in 2 files changed: 70 ins; 1 del; 2 mod 8347506: Compatible OCSP readtimeout property with OCSP timeout Reviewed-by: abakhtin Backport-of: f8e81d23393cbc04557e3975edd8898901dd6d26 ------------- PR: https://git.openjdk.org/jdk24u/pull/39 From robm at openjdk.org Mon Feb 3 19:07:08 2025 From: robm at openjdk.org (Rob McKenna) Date: Mon, 3 Feb 2025 19:07:08 GMT Subject: [jdk24u] Integrated: Merge jdk:jdk24 Message-ID: Merge ------------- Commit messages: - Merge - 8347506: Compatible OCSP readtimeout property with OCSP timeout - 8347965: (tz) Update Timezone Data to 2025a - 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI - 8345959: Make JVM_IsStaticallyLinked JVM_LEAF - 8344361: Restore null return for invalid services from legacy providers - 8347299: Add annotations to test cases in LicenseTest - 8347911: Limit the length of inflated text chunks - Merge - 8347129: cpuset cgroups controller is required for no good reason - ... and 19 more: https://git.openjdk.org/jdk24u/compare/47c15b5f...7babbc5b The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk24u/pull/44/files Stats: 1225 lines in 68 files changed: 782 ins; 281 del; 162 mod Patch: https://git.openjdk.org/jdk24u/pull/44.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/44/head:pull/44 PR: https://git.openjdk.org/jdk24u/pull/44 From robm at openjdk.org Mon Feb 3 19:07:10 2025 From: robm at openjdk.org (Rob McKenna) Date: Mon, 3 Feb 2025 19:07:10 GMT Subject: [jdk24u] Integrated: Merge jdk:jdk24 In-Reply-To: References: Message-ID: On Mon, 3 Feb 2025 19:00:35 GMT, Rob McKenna wrote: > Merge This pull request has now been integrated. Changeset: 50333762 Author: Rob McKenna URL: https://git.openjdk.org/jdk24u/commit/503337628216bc9db1c755208cdc1727e0883527 Stats: 6820 lines in 76 files changed: 2605 ins; 3179 del; 1036 mod Merge ------------- PR: https://git.openjdk.org/jdk24u/pull/44 From mdoerr at openjdk.org Mon Feb 3 19:13:56 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 3 Feb 2025 19:13:56 GMT Subject: [jdk21u-dev] RFR: 8334371: [AIX] Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages [v4] In-Reply-To: References: Message-ID: <1tad_CDOSHNSa6LaTBBoF7GonKynGP5dic0HOQJmF3Y=.625a806a-204f-4b76-b52f-23205812e633@github.com> On Tue, 28 Jan 2025 09:28:32 GMT, Joachim Kern wrote: >> Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages. As an enhancement, during the initialization of the VM the availability of this new feature is examined. If the 64K pages are supported the VM will use mmap() with 64K pages instead of shmget()/shmat() with 64K pages due to the bad 256M alignment of shmget()/shmat(). >> >> In this downport to jdk21 we want to support the new AIX 7.3 TL1 feature, but with some differences explained here: >> - `static void query_multipage_support()` in `src/hotspot/os/aix/os_aix.cpp` >> The structure of the function was changed identically in head and jdk21. Because jdk21 beforehand used trcVerbose(...) and head beforehand used log_warning(pagesize)(...) this seems to be a difference, but I just kept the tracing functions as the were before. >> >> - `src/hotspot/share/memory/virtualspace.cpp` >> Adding the use of `os::Aix::supports_64K_mmap_pages()` introduces the dependency to the header `src/hotspot/os/aix/os_aix.hpp`. In head this header was included with `#include "runtime/os.inline.hpp"` beforehand by dependant code added after jdk21. Therefore I have to include `#include "runtime/os.inline.hpp" `explicitely in virtualspace.cpp. >> >> - `src/hotspot/share/runtime/os.cpp` >> Function `char* os::attempt_reserve_memory_between()` does not exist in jdk21, so I do not have to port the adoptions of head there. >> >> - `TEST_VM(os, aix_reserve_at_non_shmlba_aligned_address)` moved from `test/hotspot/gtest/runtime/test_os.cpp` to `test/hotspot/gtest/runtime/test_os_aix.cpp` >> This test function does not exist in jdk21, so there is nothing to move. > > Joachim Kern has updated the pull request incrementally with one additional commit since the last revision: > > additionally headers LGTM. src/hotspot/share/memory/virtualspace.cpp line 35: > 33: #include "runtime/java.hpp" > 34: #include "runtime/os.hpp" > 35: #include "runtime/os.inline.hpp" Note that including `os.hpp` is no longer needed when you include `os.inline.hpp`. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1362#pullrequestreview-2590785718 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1362#discussion_r1939893685 From mdoerr at openjdk.org Mon Feb 3 19:27:48 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 3 Feb 2025 19:27:48 GMT Subject: [jdk24u] RFR: 8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis In-Reply-To: References: Message-ID: On Mon, 27 Jan 2025 10:23:34 GMT, Martin Doerr wrote: > Clean backport of [JDK-8348562](https://bugs.openjdk.org/browse/JDK-8348562). It only adds a null check + bailout where the current implementation crashes with SIGSEGV. Closing in favor of https://github.com/openjdk/jdk/pull/23422. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/35#issuecomment-2631877871 From mdoerr at openjdk.org Mon Feb 3 19:27:49 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 3 Feb 2025 19:27:49 GMT Subject: [jdk24u] Withdrawn: 8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis In-Reply-To: References: Message-ID: <6BL-iO-ebRaQEwzEVRy5f86CUCQ2goK1ex_oIOTUs0I=.48c0e00b-8094-4663-af87-1a37c26ce1dd@github.com> On Mon, 27 Jan 2025 10:23:34 GMT, Martin Doerr wrote: > Clean backport of [JDK-8348562](https://bugs.openjdk.org/browse/JDK-8348562). It only adds a null check + bailout where the current implementation crashes with SIGSEGV. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk24u/pull/35 From cushon at openjdk.org Mon Feb 3 20:58:16 2025 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Mon, 3 Feb 2025 20:58:16 GMT Subject: [jdk21u-dev] RFR: 8337795: Type annotation attached to incorrect type during class reading [v3] In-Reply-To: References: <2BCPA80dofBDxNg0jR_7Qm1_Y3MgtcC-iyxk7ENdJ9Q=.cd3d5da7-ec74-451b-9b58-6f110a6a0012@github.com> Message-ID: On Thu, 9 Jan 2025 15:50:13 GMT, Liam Miller-Cushon wrote: >> This is a backport of [JDK-8337795](https://bugs.openjdk.org/browse/JDK-8337795), which is a follow-up to [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377). > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 8d0831478338e9b084b2c47f46eba9faae3a5eb6 Please keep this open ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1252#issuecomment-2632055018 From cushon at openjdk.org Mon Feb 3 20:58:16 2025 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Mon, 3 Feb 2025 20:58:16 GMT Subject: [jdk21u-dev] RFR: 8337998: CompletionFailure in getEnclosingType attaching type annotations [v2] In-Reply-To: References: Message-ID: <_V9KV7HIyr50BEBSQBlBl61QXxEQ6IbV0z5mfvgPSLA=.af422aa7-3f14-4832-b6ff-8b026f82f355@github.com> On Thu, 9 Jan 2025 15:54:02 GMT, Liam Miller-Cushon wrote: >> This is a backport of [JDK-8337998](https://bugs.openjdk.org/browse/JDK-8337998), which is a follow-up to [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377). > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 9e282e5c966a9c065de8b901b7d30bb5c9ccf243 Please keep this open ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1253#issuecomment-2632054952 From cushon at openjdk.org Mon Feb 3 20:58:15 2025 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Mon, 3 Feb 2025 20:58:15 GMT Subject: [jdk21u-dev] RFR: 8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries [v3] In-Reply-To: <1UmvinsDMK4XT-L88pY4L00EjogQgdqZszJX5JOSLr8=.43377296-f73c-4944-8aef-0ad4a210341b@github.com> References: <1UmvinsDMK4XT-L88pY4L00EjogQgdqZszJX5JOSLr8=.43377296-f73c-4944-8aef-0ad4a210341b@github.com> Message-ID: On Thu, 9 Jan 2025 15:46:22 GMT, Liam Miller-Cushon wrote: >> [JDK-8341779](https://bugs.openjdk.org/browse/JDK-8341779) is a redo of the backport of [JDK-8323093](https://bugs.openjdk.org/browse/JDK-8323093), see also discussion in CSR [JDK-8346471](https://bugs.openjdk.org/browse/JDK-8346471). > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'master' into redo-JDK-8341779 > - 8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries > - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 > - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 > - 8336942: Improve test coverage for class loading elements with annotations of different retentions > > Reviewed-by: vromero Please keep this open ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1251#issuecomment-2632055101 From dhanalla at openjdk.org Mon Feb 3 21:49:06 2025 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Mon, 3 Feb 2025 21:49:06 GMT Subject: [jdk21u-dev] RFR: 8348323: Corrupted timezone string in JVM crash log Message-ID: Add a error check to "wcstombs" otherwise the "buf" prints junk or corrupted string. ------------- Commit messages: - Backport 2bef5b4a877f4d3bc766558b8782b7b57dee79a8 Changes: https://git.openjdk.org/jdk21u-dev/pull/1382/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1382&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348323 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1382.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1382/head:pull/1382 PR: https://git.openjdk.org/jdk21u-dev/pull/1382 From duke at openjdk.org Tue Feb 4 00:51:12 2025 From: duke at openjdk.org (duke) Date: Tue, 4 Feb 2025 00:51:12 GMT Subject: [jdk24u] RFR: 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine In-Reply-To: <1mEfSdstFnugU3oaI6yYSOuO0U9TV074HXG4PbYKy-g=.0a193f87-5dd5-4d40-89ba-4221b77418a0@github.com> References: <1mEfSdstFnugU3oaI6yYSOuO0U9TV074HXG4PbYKy-g=.0a193f87-5dd5-4d40-89ba-4221b77418a0@github.com> Message-ID: On Mon, 3 Feb 2025 16:00:14 GMT, Shivangi Gupta wrote: > Straight Backport. Test passed @Shivangi-aa Your change (at version 6a9df61974990dc442548c2d02c07131130f7f8f) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/43#issuecomment-2632508890 From serb at openjdk.org Tue Feb 4 03:41:19 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 4 Feb 2025 03:41:19 GMT Subject: [jdk21u-dev] Integrated: 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04 In-Reply-To: References: Message-ID: On Tue, 28 Jan 2025 19:57:41 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [6f307623](https://github.com/openjdk/jdk/commit/6f307623568efe4d90942cd22ec9a26b2e1ca1b1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Prasanta Sadhukhan on 4 Dec 2024 and was reviewed by Abhishek Kumar. > > Thanks! This pull request has now been integrated. Changeset: d2cbada0 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u-dev/commit/d2cbada0b7c88521dfb4d3696205c9beb77018af Stats: 37 lines in 1 file changed: 7 ins; 17 del; 13 mod 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04 Backport-of: 6f307623568efe4d90942cd22ec9a26b2e1ca1b1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1367 From sshivang at openjdk.org Tue Feb 4 07:16:23 2025 From: sshivang at openjdk.org (Shivangi Gupta) Date: Tue, 4 Feb 2025 07:16:23 GMT Subject: [jdk24u] Integrated: 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine In-Reply-To: <1mEfSdstFnugU3oaI6yYSOuO0U9TV074HXG4PbYKy-g=.0a193f87-5dd5-4d40-89ba-4221b77418a0@github.com> References: <1mEfSdstFnugU3oaI6yYSOuO0U9TV074HXG4PbYKy-g=.0a193f87-5dd5-4d40-89ba-4221b77418a0@github.com> Message-ID: On Mon, 3 Feb 2025 16:00:14 GMT, Shivangi Gupta wrote: > Straight Backport. Test passed This pull request has now been integrated. Changeset: a681dbb5 Author: Shivangi Gupta Committer: Sean Coffey URL: https://git.openjdk.org/jdk24u/commit/a681dbb5a15fdc3723aaa96dc482f18841abfe19 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine Backport-of: f6e7713bb653811423eeb2515c2f69b437750326 ------------- PR: https://git.openjdk.org/jdk24u/pull/43 From duke at openjdk.org Tue Feb 4 07:17:21 2025 From: duke at openjdk.org (duke) Date: Tue, 4 Feb 2025 07:17:21 GMT Subject: [jdk24u] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs In-Reply-To: References: Message-ID: On Wed, 29 Jan 2025 11:25:16 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. Low risk. > > On Linux it passes tier1 tests and also all `jdk/sun/security` tests: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 798 798 0 0 > ============================== > TEST SUCCESS @vieiro Your change (at version 99237c9559d05b1106bcfbb0da9dd18d8f39b99c) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/40#issuecomment-2633063615 From stuefe at openjdk.org Tue Feb 4 07:32:17 2025 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 4 Feb 2025 07:32:17 GMT Subject: [jdk21u-dev] RFR: 8334371: [AIX] Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages [v4] In-Reply-To: References: Message-ID: On Tue, 28 Jan 2025 09:28:32 GMT, Joachim Kern wrote: >> Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages. As an enhancement, during the initialization of the VM the availability of this new feature is examined. If the 64K pages are supported the VM will use mmap() with 64K pages instead of shmget()/shmat() with 64K pages due to the bad 256M alignment of shmget()/shmat(). >> >> In this downport to jdk21 we want to support the new AIX 7.3 TL1 feature, but with some differences explained here: >> - `static void query_multipage_support()` in `src/hotspot/os/aix/os_aix.cpp` >> The structure of the function was changed identically in head and jdk21. Because jdk21 beforehand used trcVerbose(...) and head beforehand used log_warning(pagesize)(...) this seems to be a difference, but I just kept the tracing functions as the were before. >> >> - `src/hotspot/share/memory/virtualspace.cpp` >> Adding the use of `os::Aix::supports_64K_mmap_pages()` introduces the dependency to the header `src/hotspot/os/aix/os_aix.hpp`. In head this header was included with `#include "runtime/os.inline.hpp"` beforehand by dependant code added after jdk21. Therefore I have to include `#include "runtime/os.inline.hpp" `explicitely in virtualspace.cpp. >> >> - `src/hotspot/share/runtime/os.cpp` >> Function `char* os::attempt_reserve_memory_between()` does not exist in jdk21, so I do not have to port the adoptions of head there. >> >> - `TEST_VM(os, aix_reserve_at_non_shmlba_aligned_address)` moved from `test/hotspot/gtest/runtime/test_os.cpp` to `test/hotspot/gtest/runtime/test_os_aix.cpp` >> This test function does not exist in jdk21, so there is nothing to move. > > Joachim Kern has updated the pull request incrementally with one additional commit since the last revision: > > additionally headers Patch looks good. Thanks for doing this. After 20 years we can finally start reducing the crud around 64k page handling. If 64K page handling is ubiquitous, you will be able to throw out the System V shm allocation path, and all that vmem_xxx stuff we wrote 20 years ago. ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1362#pullrequestreview-2591944110 From syan at openjdk.org Tue Feb 4 10:11:54 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 4 Feb 2025 10:11:54 GMT Subject: [jdk21u-dev] RFR: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError Message-ID: Hi all, Hi all, This pull request contains a backport of commit [4d8fb807](https://github.com/openjdk/jdk/commit/4d8fb80732fd17352c36254c6dfc1be5dbfbacf1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backport fix the JMH test bug which report "NoClassDefFoundError" fails, test-fix only, no risk. Thanks! The commit being backported was authored by SendaoYan on 7 Jan 2025 and was reviewed by Paul Sandoz. Thanks! ------------- Commit messages: - Backport 4d8fb80732fd17352c36254c6dfc1be5dbfbacf1 Changes: https://git.openjdk.org/jdk21u-dev/pull/1383/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1383&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347038 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1383.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1383/head:pull/1383 PR: https://git.openjdk.org/jdk21u-dev/pull/1383 From thomas.stuefe at gmail.com Tue Feb 4 10:48:54 2025 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Tue, 4 Feb 2025 11:48:54 +0100 Subject: CFV: New JDK Updates Committer: Damon Fenacci In-Reply-To: <8C2FBCBC-1594-4FBE-B77C-8847D30A818D@amazon.com> References: <8C2FBCBC-1594-4FBE-B77C-8847D30A818D@amazon.com> Message-ID: Vote: yes On Wed, Jan 29, 2025 at 4:34?PM Hohensee, Paul wrote: > Vote: yes > > ?On 1/29/25, 1:41 AM, "jdk-updates-dev on behalf of Tobias Hartmann" < > jdk-updates-dev-retn at openjdk.org > on behalf of tobias.hartmann at oracle.com > > wrote > > I hereby nominate Damon Fenacci [1] for the role of JDK Updates Project > Committer. > > Damon is a member of the HotSpot Compiler Team at Oracle and a JDK > Committer. He contributed 29 changes to the JDK project [2]. > > Votes are due by February 12, 2025, 10:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.org/census#dfenacci < > https://openjdk.org/census#dfenacci> > [2] > https://github.com/search?q=author-name%3A%22Damon+Fenacci%22+repo%3Aopenjdk%2Fjdk&type=commits > < > https://github.com/search?q=author-name%3A%22Damon+Fenacci%22+repo%3Aopenjdk%2Fjdk&type=commits > > > [3] https://openjdk.java.net/census#jdk-updates < > https://openjdk.java.net/census#jdk-updates> > [4] https://openjdk.org/projects/#committer-vote < > https://openjdk.org/projects/#committer-vote> > > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jkern at openjdk.org Tue Feb 4 10:49:53 2025 From: jkern at openjdk.org (Joachim Kern) Date: Tue, 4 Feb 2025 10:49:53 GMT Subject: [jdk21u-dev] RFR: 8334371: [AIX] Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages [v5] In-Reply-To: References: Message-ID: <9Qct8kGQ2NlYV8qNNBrqgyB2oFblP8e9Zyx9Wx9LRiQ=.06ff70d1-35c3-45e5-aa46-af6d85831b59@github.com> > Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages. As an enhancement, during the initialization of the VM the availability of this new feature is examined. If the 64K pages are supported the VM will use mmap() with 64K pages instead of shmget()/shmat() with 64K pages due to the bad 256M alignment of shmget()/shmat(). > > In this downport to jdk21 we want to support the new AIX 7.3 TL1 feature, but with some differences explained here: > - `static void query_multipage_support()` in `src/hotspot/os/aix/os_aix.cpp` > The structure of the function was changed identically in head and jdk21. Because jdk21 beforehand used trcVerbose(...) and head beforehand used log_warning(pagesize)(...) this seems to be a difference, but I just kept the tracing functions as the were before. > > - `src/hotspot/share/memory/virtualspace.cpp` > Adding the use of `os::Aix::supports_64K_mmap_pages()` introduces the dependency to the header `src/hotspot/os/aix/os_aix.hpp`. In head this header was included with `#include "runtime/os.inline.hpp"` beforehand by dependant code added after jdk21. Therefore I have to include `#include "runtime/os.inline.hpp" `explicitely in virtualspace.cpp. `#include "runtime/os.hpp"` can be dropped instead. > > - `src/hotspot/share/runtime/os.cpp` > Function `char* os::attempt_reserve_memory_between()` does not exist in jdk21, so I do not have to port the adoptions of head there. > > - `TEST_VM(os, aix_reserve_at_non_shmlba_aligned_address)` moved from `test/hotspot/gtest/runtime/test_os.cpp` to `test/hotspot/gtest/runtime/test_os_aix.cpp` > This test function does not exist in jdk21, so there is nothing to move. Joachim Kern has updated the pull request incrementally with one additional commit since the last revision: runtime/os.hpp replaced by runtime/os.inline.hpp ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1362/files - new: https://git.openjdk.org/jdk21u-dev/pull/1362/files/7a128fe2..8b5a6d2c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1362&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1362&range=03-04 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1362.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1362/head:pull/1362 PR: https://git.openjdk.org/jdk21u-dev/pull/1362 From syan at openjdk.org Tue Feb 4 11:34:17 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 4 Feb 2025 11:34:17 GMT Subject: [jdk21u-dev] RFR: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError In-Reply-To: References: Message-ID: On Tue, 4 Feb 2025 10:05:32 GMT, SendaoYan wrote: > Hi all, > > Hi all, > > This pull request contains a backport of commit [4d8fb807](https://github.com/openjdk/jdk/commit/4d8fb80732fd17352c36254c6dfc1be5dbfbacf1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backport fix the JMH test bug which report "NoClassDefFoundError" fails, test-fix only, no risk. > > Thanks! > > The commit being backported was authored by SendaoYan on 7 Jan 2025 and was reviewed by Paul Sandoz. > > Thanks! GHA report 1 falure: 1. job [linux-x64-hs-nopch / build (debug)](https://github.com/openjdk-bots/jdk21u-dev/actions/runs/12653968339/job/35260701084#logs) fails "wget exited with exit code 4" at 'Get JTReg' stage, seems like environmental issue or infrastructure issue, it's unrelated to this backport. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1383#issuecomment-2633637711 From mdoerr at openjdk.org Tue Feb 4 12:02:17 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 4 Feb 2025 12:02:17 GMT Subject: [jdk21u-dev] RFR: 8334371: [AIX] Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages [v5] In-Reply-To: <9Qct8kGQ2NlYV8qNNBrqgyB2oFblP8e9Zyx9Wx9LRiQ=.06ff70d1-35c3-45e5-aa46-af6d85831b59@github.com> References: <9Qct8kGQ2NlYV8qNNBrqgyB2oFblP8e9Zyx9Wx9LRiQ=.06ff70d1-35c3-45e5-aa46-af6d85831b59@github.com> Message-ID: On Tue, 4 Feb 2025 10:49:53 GMT, Joachim Kern wrote: >> Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages. As an enhancement, during the initialization of the VM the availability of this new feature is examined. If the 64K pages are supported the VM will use mmap() with 64K pages instead of shmget()/shmat() with 64K pages due to the bad 256M alignment of shmget()/shmat(). >> >> In this downport to jdk21 we want to support the new AIX 7.3 TL1 feature, but with some differences explained here: >> - `static void query_multipage_support()` in `src/hotspot/os/aix/os_aix.cpp` >> The structure of the function was changed identically in head and jdk21. Because jdk21 beforehand used trcVerbose(...) and head beforehand used log_warning(pagesize)(...) this seems to be a difference, but I just kept the tracing functions as the were before. >> >> - `src/hotspot/share/memory/virtualspace.cpp` >> Adding the use of `os::Aix::supports_64K_mmap_pages()` introduces the dependency to the header `src/hotspot/os/aix/os_aix.hpp`. In head this header was included with `#include "runtime/os.inline.hpp"` beforehand by dependant code added after jdk21. Therefore I have to include `#include "runtime/os.inline.hpp" `explicitely in virtualspace.cpp. `#include "runtime/os.hpp"` can be dropped instead. >> >> - `src/hotspot/share/runtime/os.cpp` >> Function `char* os::attempt_reserve_memory_between()` does not exist in jdk21, so I do not have to port the adoptions of head there. >> >> - `TEST_VM(os, aix_reserve_at_non_shmlba_aligned_address)` moved from `test/hotspot/gtest/runtime/test_os.cpp` to `test/hotspot/gtest/runtime/test_os_aix.cpp` >> This test function does not exist in jdk21, so there is nothing to move. > > Joachim Kern has updated the pull request incrementally with one additional commit since the last revision: > > runtime/os.hpp replaced by runtime/os.inline.hpp Marked as reviewed by mdoerr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1362#pullrequestreview-2592610625 From robm at openjdk.org Tue Feb 4 14:52:57 2025 From: robm at openjdk.org (Rob McKenna) Date: Tue, 4 Feb 2025 14:52:57 GMT Subject: [jdk24u] RFR: 8349370: Bump version numbers for 24.0.2 Message-ID: bump version numbers ------------- Commit messages: - 8349370: Bump version numbers for 24.0.2 Changes: https://git.openjdk.org/jdk24u/pull/45/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=45&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349370 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk24u/pull/45.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/45/head:pull/45 PR: https://git.openjdk.org/jdk24u/pull/45 From coffeys at openjdk.org Tue Feb 4 15:06:23 2025 From: coffeys at openjdk.org (Sean Coffey) Date: Tue, 4 Feb 2025 15:06:23 GMT Subject: [jdk24u] RFR: 8349370: Bump version numbers for 24.0.2 In-Reply-To: References: Message-ID: <8BDgpd6T6KFVJlwlt5sx-CAvXEDKkuIeXg-SEFwkO58=.5bf94b57-369e-4c3c-a54f-7afababf6aaf@github.com> On Tue, 4 Feb 2025 14:48:09 GMT, Rob McKenna wrote: > bump version numbers Marked as reviewed by coffeys (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk24u/pull/45#pullrequestreview-2593160315 From robm at openjdk.org Tue Feb 4 15:09:20 2025 From: robm at openjdk.org (Rob McKenna) Date: Tue, 4 Feb 2025 15:09:20 GMT Subject: [jdk24u] Integrated: 8349370: Bump version numbers for 24.0.2 In-Reply-To: References: Message-ID: On Tue, 4 Feb 2025 14:48:09 GMT, Rob McKenna wrote: > bump version numbers This pull request has now been integrated. Changeset: 9669f0cf Author: Rob McKenna URL: https://git.openjdk.org/jdk24u/commit/9669f0cf29e467cfdfab062a64c71000de8cb9e6 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8349370: Bump version numbers for 24.0.2 Reviewed-by: coffeys ------------- PR: https://git.openjdk.org/jdk24u/pull/45 From phh at openjdk.org Tue Feb 4 17:53:21 2025 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 4 Feb 2025 17:53:21 GMT Subject: [jdk21u-dev] RFR: 8340547: Starting many threads can delay safepoints [v2] In-Reply-To: <-4djKeb43H8gczefZqMVMOHs-N-FrvZ76KMh8_0FxJ0=.037b876d-0ab7-41ff-a2f4-16d136a87f0c@github.com> References: <-4djKeb43H8gczefZqMVMOHs-N-FrvZ76KMh8_0FxJ0=.037b876d-0ab7-41ff-a2f4-16d136a87f0c@github.com> Message-ID: On Tue, 28 Jan 2025 17:21:26 GMT, Sergey Nazarkin wrote: >> I'd like to backport this fix to fix the issue with starting a lot of threads in a burst. Some users found this to be a barrier to migrating from JDK8. >> >> The backport is not clean as required to adjust `globals.hpp` and replace `ConditionalMutexLocker` with classic `MutexLocker`. Original fix and discussion are [here](https://github.com/openjdk/jdk/pull/21111) >> >> Tested with `tier1` and reproducers from [JDK-8340547](https://bugs.openjdk.org/browse/JDK-8340547), [JDK-8307970](https://bugs.openjdk.org/browse/JDK-8307970) > > Sergey Nazarkin has updated the pull request incrementally with one additional commit since the last revision: > > NULL -> nullptr Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1365#pullrequestreview-2593614058 From aivanov at openjdk.org Tue Feb 4 19:21:44 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Tue, 4 Feb 2025 19:21:44 GMT Subject: [jdk24u] Integrated: 8348299: Update List/ItemEventTest/ItemEventTest.java In-Reply-To: <0QpWS9saIujo2hC1Y4-arYzLb0LxsM-2kY_yzu6988w=.e29b419e-f7f9-4de5-86b2-dfeba866e431@github.com> References: <0QpWS9saIujo2hC1Y4-arYzLb0LxsM-2kY_yzu6988w=.e29b419e-f7f9-4de5-86b2-dfeba866e431@github.com> Message-ID: <0tT2qKlUd_vnKCjHeHLRZJb4SA_1by7xJ3tS2ZrsEl4=.5dea420b-7c10-4976-afe6-e11b61b48ed8@github.com> On Fri, 24 Jan 2025 20:24:20 GMT, Alexey Ivanov wrote: > Improve the `java/awt/List/ItemEventTest/ItemEventTest.java` test to make it more stable and to provide more diagnostic messages for failure analysis. > >> This pull request contains a backport of commit [605b53e4](https://github.com/openjdk/jdk/commit/605b53e4f8857c58a72fa361f8787c563d6dab90) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexey Ivanov on 23 Jan 2025 and was reviewed by Alexander Zvegintsev, Phil Race and Alexander Zuev. This pull request has now been integrated. Changeset: 7eb2f794 Author: Alexey Ivanov URL: https://git.openjdk.org/jdk24u/commit/7eb2f79448d9b10912ab83163cd2b79b0ac6d0b4 Stats: 98 lines in 1 file changed: 44 ins; 8 del; 46 mod 8348299: Update List/ItemEventTest/ItemEventTest.java Use thread-safe StringBuffer to track selecting/deselecting items. Use auto waitForIdle for all events. Log handleEvent and ItemListener. Take screenshot of the list on failure; Optionally take screenshot after each mouse press+release. Backport-of: 605b53e4f8857c58a72fa361f8787c563d6dab90 ------------- PR: https://git.openjdk.org/jdk24u/pull/34 From aivanov at openjdk.org Tue Feb 4 19:21:45 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Tue, 4 Feb 2025 19:21:45 GMT Subject: [jdk24u] Integrated: 8346581: JRadioButton/ButtonGroupFocusTest.java fails in CI on Linux In-Reply-To: <0v1cu91ELwHOcXDRuTeA1Mfm8CN070eQHS6d66bkUa0=.efe34192-3f8f-4297-b198-f8c6857609c3@github.com> References: <0v1cu91ELwHOcXDRuTeA1Mfm8CN070eQHS6d66bkUa0=.efe34192-3f8f-4297-b198-f8c6857609c3@github.com> Message-ID: On Fri, 24 Jan 2025 19:50:49 GMT, Alexey Ivanov wrote: > Improves stability of the `javax/swing/JRadioButton/ButtonGroupFocus/ButtonGroupFocusTest.java` test. > > See https://github.com/openjdk/jdk/pull/22977 for more details. > >> This pull request contains a backport of commit [57af52c5](https://github.com/openjdk/jdk/commit/57af52c57390f6f7413b5d3ffe64921c9b83aae4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexey Ivanov on 10 Jan 2025 and was reviewed by Harshitha Onkar and Damon Nguyen. This pull request has now been integrated. Changeset: 3f234d97 Author: Alexey Ivanov URL: https://git.openjdk.org/jdk24u/commit/3f234d97ebc63ddc586f733952270fbbdbcfc05b Stats: 124 lines in 1 file changed: 85 ins; 13 del; 26 mod 8346581: JRadioButton/ButtonGroupFocusTest.java fails in CI on Linux Backport-of: 57af52c57390f6f7413b5d3ffe64921c9b83aae4 ------------- PR: https://git.openjdk.org/jdk24u/pull/32 From aivanov at openjdk.org Tue Feb 4 19:23:22 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Tue, 4 Feb 2025 19:23:22 GMT Subject: [jdk24u] Integrated: 8347427: JTabbedPane/8134116/Bug8134116.java has no license header In-Reply-To: References: Message-ID: On Fri, 24 Jan 2025 20:21:16 GMT, Alexey Ivanov wrote: > Add the missing GPL header to `test/jdk/javax/swing/JTabbedPane/8134116/Bug8134116.java`. > >> This pull request contains a backport of commit [f67b7036](https://github.com/openjdk/jdk/commit/f67b703625afa2e049c572978d29ac00d8c956d3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexey Ivanov on 13 Jan 2025 and was reviewed by Dmitry Markov, Harshitha Onkar and Abhishek Kumar. This pull request has now been integrated. Changeset: f90566ac Author: Alexey Ivanov URL: https://git.openjdk.org/jdk24u/commit/f90566ac10eea6630118229f6eb1453e94454bad Stats: 33 lines in 1 file changed: 30 ins; 0 del; 3 mod 8347427: JTabbedPane/8134116/Bug8134116.java has no license header Backport-of: f67b703625afa2e049c572978d29ac00d8c956d3 ------------- PR: https://git.openjdk.org/jdk24u/pull/33 From aivanov at openjdk.org Tue Feb 4 19:23:54 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Tue, 4 Feb 2025 19:23:54 GMT Subject: [jdk24u] RFR: 8340784: Remove PassFailJFrame constructor with screenshots Message-ID: Removes an unused constructor of `PassFailJFrame`, use the builder pattern to enable screenshots. > This pull request contains a backport of commit [50ca4504](https://github.com/openjdk/jdk/commit/50ca450417a5da7d4c6c08154515b8407bf656e8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by anass baya on 24 Jan 2025 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. ------------- Commit messages: - Backport 50ca450417a5da7d4c6c08154515b8407bf656e8 Changes: https://git.openjdk.org/jdk24u/pull/46/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=46&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340784 Stats: 51 lines in 1 file changed: 0 ins; 42 del; 9 mod Patch: https://git.openjdk.org/jdk24u/pull/46.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/46/head:pull/46 PR: https://git.openjdk.org/jdk24u/pull/46 From duke at openjdk.org Tue Feb 4 22:03:45 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 4 Feb 2025 22:03:45 GMT Subject: [jdk11u-dev] RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x In-Reply-To: References: Message-ID: On Mon, 13 Jan 2025 19:55:14 GMT, Antonio Vieiro wrote: > Backport of [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316) to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded. > > This solves the problem in https://github.com/openjdk/jdk11u-dev/pull/2967#issuecomment-2538048579, so all tier1 tests are expected to pass in all GHA platforms. > > The change is not clean as there were merge conflicts in ProblemList.txt, as these usually differ between JDK versions (just dropped `8294316`). Also `add_map_info` has a different number of arguments in JDK11. The tests that were failing are passing now in 11 with on `macos13/XCode 14` combination with the GitHub runners. 2025-01-10T20:42:40.3502240Z TEST: serviceability/sa/ClhsdbFindPC.java#id0 2025-01-10T20:42:40.3544430Z build: 0.797 seconds 2025-01-10T20:42:40.3594360Z compile: 0.797 seconds 2025-01-10T20:42:40.3625370Z main: 35.655 seconds 2025-01-10T20:42:40.3652970Z TEST RESULT: Passed. Execution successful 2025-01-10T20:42:40.3685900Z -------------------------------------------------- 2025-01-10T20:43:07.3248130Z TEST: serviceability/sa/ClhsdbFindPC.java#id2 2025-01-10T20:43:07.3248690Z build: 0.65 seconds 2025-01-10T20:43:07.3249030Z compile: 0.648 seconds 2025-01-10T20:43:07.3249550Z main: 21.154 seconds 2025-01-10T20:43:07.3249930Z TEST RESULT: Passed. Execution successful 2025-01-10T20:43:07.3250420Z -------------------------------------------------- 2025-01-10T20:44:23.6450570Z TEST: serviceability/sa/ClhsdbFindPC.java#id3 2025-01-10T20:44:23.6590930Z build: 2.521 seconds 2025-01-10T20:44:23.6626600Z compile: 2.521 seconds 2025-01-10T20:44:23.6634720Z main: 68.66 seconds 2025-01-10T20:44:23.6637250Z TEST RESULT: Passed. Execution successful 2025-01-10T20:44:23.6644360Z -------------------------------------------------- 2025-01-10T20:44:23.9983120Z TEST: serviceability/sa/ClhsdbFindPC.java#id1 2025-01-10T20:44:24.0109410Z build: 1.103 seconds 2025-01-10T20:44:24.0114190Z compile: 1.102 seconds 2025-01-10T20:44:24.0115000Z main: 97.538 seconds 2025-01-10T20:44:24.0116180Z TEST RESULT: Passed. Execution successful I'll run tier1 tests in the previous `macos-12 and XCode 13.4.1` to ensure backwards compatibility. All tier1 tests pass on `macos 13` and `XCode 14`. Also ran tier1 tests on the _previous_ `macOS Monterey v 12.6.1` with `Xcode 13.4.1` on `arm64`: ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg:tier1 1381 1381 0 0 jtreg:test/jdk:tier1 1894 1894 0 0 jtreg:test/langtools:tier1 3940 3940 0 0 jtreg:test/nashorn:tier1 0 0 0 0 jtreg:test/jaxp:tier1 0 0 0 0 ============================== TEST SUCCESS ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2987#issuecomment-2615059557 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2987#issuecomment-2635166737 From duke at openjdk.org Tue Feb 4 22:03:45 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 4 Feb 2025 22:03:45 GMT Subject: [jdk11u-dev] RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x [v2] In-Reply-To: References: Message-ID: > Backport of [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316) to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded. > > This solves the problem in https://github.com/openjdk/jdk11u-dev/pull/2967#issuecomment-2538048579, so all tier1 tests are expected to pass in all GHA platforms. > > The change is not clean as there were merge conflicts in ProblemList.txt, as these usually differ between JDK versions (just dropped `8294316`). Also `add_map_info` has a different number of arguments in JDK11. Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport b0c130ba3aa443ca58e9bcda813a80e989632b93 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/2987/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2987&range=01 Stats: 16 lines in 2 files changed: 5 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2987.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2987/head:pull/2987 PR: https://git.openjdk.org/jdk11u-dev/pull/2987 From syan at openjdk.org Wed Feb 5 07:55:56 2025 From: syan at openjdk.org (SendaoYan) Date: Wed, 5 Feb 2025 07:55:56 GMT Subject: [jdk24u] RFR: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError Message-ID: Hi all, This pull request contains a backport of commit [4d8fb807](https://github.com/openjdk/jdk/commit/4d8fb80732fd17352c36254c6dfc1be5dbfbacf1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backport fix the JMH test bug which report "NoClassDefFoundError" fails, test-fix only, no risk. Thanks! ------------- Commit messages: - Backport 4d8fb80732fd17352c36254c6dfc1be5dbfbacf1 Changes: https://git.openjdk.org/jdk24u/pull/47/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=47&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347038 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk24u/pull/47.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/47/head:pull/47 PR: https://git.openjdk.org/jdk24u/pull/47 From goetz at openjdk.org Wed Feb 5 08:02:29 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 08:02:29 GMT Subject: [jdk24u] RFR: 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025 Message-ID: I backport this to improve testing on new Windows. ------------- Commit messages: - Backport 2e00816ac30373df28a29dc938f7ce5489a3edfc Changes: https://git.openjdk.org/jdk24u/pull/48/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=48&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346671 Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk24u/pull/48.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/48/head:pull/48 PR: https://git.openjdk.org/jdk24u/pull/48 From goetz at openjdk.org Wed Feb 5 08:08:48 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 08:08:48 GMT Subject: [jdk24u] RFR: 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025 Message-ID: I backport this to improve testing with recent Windows. ------------- Commit messages: - Backport b0c131e872f997cb7deadc9b0a87bd76e3a2a83c Changes: https://git.openjdk.org/jdk24u/pull/49/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=49&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345368 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk24u/pull/49.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/49/head:pull/49 PR: https://git.openjdk.org/jdk24u/pull/49 From goetz at openjdk.org Wed Feb 5 08:33:18 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 08:33:18 GMT Subject: [jdk24u] RFR: 8347740: java/io/File/createTempFile/SpecialTempFile.java failing Message-ID: I backport this to improve testing on windows. Clean backport on top of JDK-8345368. ------------- Depends on: https://git.openjdk.org/jdk24u/pull/49 Commit messages: - Backport f2a9d26b2e409a7216d967ebb6b92726e8ed65c3 Changes: https://git.openjdk.org/jdk24u/pull/50/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=50&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347740 Stats: 28 lines in 1 file changed: 12 ins; 3 del; 13 mod Patch: https://git.openjdk.org/jdk24u/pull/50.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/50/head:pull/50 PR: https://git.openjdk.org/jdk24u/pull/50 From goetz at openjdk.org Wed Feb 5 08:47:17 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 08:47:17 GMT Subject: [jdk24u] RFR: 8347740: java/io/File/createTempFile/SpecialTempFile.java failing In-Reply-To: References: Message-ID: <9Csp5-VBj4_Hpa4B8ljExZg6VW2NKQ49mcKX4EV9scY=.4025ef47-fec9-4e5c-895c-227261540427@github.com> On Wed, 5 Feb 2025 08:29:16 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing on windows. > > Clean backport on top of JDK-8345368. I enabled the gh actions in the meantime, they will run once I merge the dependent pull request. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/50#issuecomment-2636086884 From goetz at openjdk.org Wed Feb 5 08:49:12 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 08:49:12 GMT Subject: [jdk21u-dev] Integrated: 8320691: Timeout handler on Windows takes 2 hours to complete In-Reply-To: References: Message-ID: On Thu, 30 Jan 2025 09:17:56 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: 69e8c201 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/69e8c2016d94342a29a8bd42e702a3fa08636b8a Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8320691: Timeout handler on Windows takes 2 hours to complete Backport-of: 4d50df63b6ea76fd6a6c387593c3d6bc9429007b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1374 From goetz at openjdk.org Wed Feb 5 08:51:18 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 08:51:18 GMT Subject: [jdk21u-dev] Integrated: 8325042: Remove unused JVMDITools test files In-Reply-To: References: Message-ID: On Wed, 29 Jan 2025 07:43:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: ba27543d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/ba27543d1ec75757e7ab247e23d9f826ac48ab5b Stats: 200 lines in 3 files changed: 0 ins; 200 del; 0 mod 8325042: Remove unused JVMDITools test files Backport-of: 0cc8e5beed664a21c2668be86a9d3c5a1b165743 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1368 From goetz at openjdk.org Wed Feb 5 08:52:19 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 08:52:19 GMT Subject: [jdk21u-dev] Integrated: 8329692: Add more details to FrameStateTest.java test instructions In-Reply-To: References: Message-ID: On Thu, 30 Jan 2025 07:57:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 7b7aa75f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/7b7aa75ff584fa6b880680c24579f74966276b45 Stats: 50 lines in 1 file changed: 7 ins; 13 del; 30 mod 8329692: Add more details to FrameStateTest.java test instructions Backport-of: 6f98d8f58f98827ae454c7ce4839de4071d95767 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1373 From goetz at openjdk.org Wed Feb 5 08:54:13 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 08:54:13 GMT Subject: [jdk21u-dev] Integrated: 8330647: Two CDS tests fail with -UseCompressedOops and UseSerialGC/UseParallelGC In-Reply-To: References: Message-ID: On Thu, 30 Jan 2025 15:51:08 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle. This pull request has now been integrated. Changeset: 42f0ebc0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/42f0ebc0b3f97898cc3b2a9a20ec7822afeedf2c Stats: 30 lines in 1 file changed: 27 ins; 2 del; 1 mod 8330647: Two CDS tests fail with -UseCompressedOops and UseSerialGC/UseParallelGC Backport-of: c2cca2ab443ff87f689810b747985adfdbfbe54a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1381 From goetz at openjdk.org Wed Feb 5 08:55:18 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 08:55:18 GMT Subject: [jdk17u-dev] Integrated: 8295176: some langtools test pollutes source tree In-Reply-To: References: Message-ID: <82gNZTpDQe7e1JpAPjvnekWtCnfaK-FdoGXBX62hraE=.55edfe3c-41fd-4034-ab32-de27bd9f7fa7@github.com> On Wed, 29 Jan 2025 07:14:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle > > I had to resolve both java files as "[8173605: Remove support for source and target 1.7 option in javac](https://github.com/openjdk/jdk/commit/2d18dda3f2074a4f8b9a0c62ece9ac6d5284e93b)" is not in 17. > > I think it's ok to raise the tested version to 11 as the change does. > But the fix described in the bug title is achieved by adding the -d . in the command when > javac is called through the API. This pull request has now been integrated. Changeset: 9f9655f5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9f9655f518a55536274da69408ee134d4359e2e3 Stats: 7 lines in 3 files changed: 2 ins; 0 del; 5 mod 8295176: some langtools test pollutes source tree Reviewed-by: rschmelter Backport-of: 71aa8210910dbafe30eccc772eaa7747f46be0cd ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3249 From goetz at openjdk.org Wed Feb 5 08:59:18 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 08:59:18 GMT Subject: [jdk17u-dev] Integrated: 8320691: Timeout handler on Windows takes 2 hours to complete In-Reply-To: References: Message-ID: On Thu, 30 Jan 2025 09:18:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle, This pull request has now been integrated. Changeset: 56830215 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/56830215a89e12a908f9b9b7d68a6d99d60153e9 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8320691: Timeout handler on Windows takes 2 hours to complete Backport-of: 4d50df63b6ea76fd6a6c387593c3d6bc9429007b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3256 From goetz at openjdk.org Wed Feb 5 08:59:16 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 08:59:16 GMT Subject: [jdk21u-dev] Integrated: 8332917: failure_handler should execute gdb "info threads" command on linux In-Reply-To: References: Message-ID: On Wed, 29 Jan 2025 12:41:08 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: 12070ca9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/12070ca98839022fc13c0862db18f37b829f15ee Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8332917: failure_handler should execute gdb "info threads" command on linux Backport-of: ec88c6a872a97cee1cde8844f5ee6834023a10c6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1369 From goetz at openjdk.org Wed Feb 5 09:00:25 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 09:00:25 GMT Subject: [jdk17u-dev] Integrated: 8325042: Remove unused JVMDITools test files In-Reply-To: References: Message-ID: On Wed, 29 Jan 2025 07:43:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 0ef3fd03 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/0ef3fd036baf581d3ed8a6ad6d28533c9f792c9e Stats: 200 lines in 3 files changed: 0 ins; 200 del; 0 mod 8325042: Remove unused JVMDITools test files Backport-of: 0cc8e5beed664a21c2668be86a9d3c5a1b165743 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3250 From goetz at openjdk.org Wed Feb 5 09:02:00 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 09:02:00 GMT Subject: [jdk21u-dev] Integrated: 8340078: Open source several 2D tests In-Reply-To: <7z5pXBzyOg4a8dAl5YltfeWArUDKaK5xLjrVgpiiaC4=.34227be2-8fa2-4f2d-aab0-563c9fa3bd58@github.com> References: <7z5pXBzyOg4a8dAl5YltfeWArUDKaK5xLjrVgpiiaC4=.34227be2-8fa2-4f2d-aab0-563c9fa3bd58@github.com> Message-ID: On Thu, 30 Jan 2025 13:52:35 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 9a2988c2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/9a2988c25e921b2ccf90fd0b42ee0eed30ea2838 Stats: 484 lines in 5 files changed: 484 ins; 0 del; 0 mod 8340078: Open source several 2D tests Backport-of: 88a1c0550e435888c571d32c577fd697652e5620 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1378 From goetz at openjdk.org Wed Feb 5 09:02:23 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 09:02:23 GMT Subject: [jdk21u-dev] Integrated: 8226938: [TEST_BUG]GTK L&F: There is no Details button in FileChooser Dialog In-Reply-To: <5QTL60iIpNoaafkh-6YYGa6qoCRCOVeZzfoNn3EGbhk=.53011bcf-aef3-4eb0-9500-51bea5151cbf@github.com> References: <5QTL60iIpNoaafkh-6YYGa6qoCRCOVeZzfoNn3EGbhk=.53011bcf-aef3-4eb0-9500-51bea5151cbf@github.com> Message-ID: On Wed, 29 Jan 2025 14:12:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: d0fbffd9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d0fbffd96d47cbd7d1f967b2fc0405366ad4398e Stats: 77 lines in 1 file changed: 77 ins; 0 del; 0 mod 8226938: [TEST_BUG]GTK L&F: There is no Details button in FileChooser Dialog Backport-of: fe98f86b5792cbb17d47871452d27ab87d72b342 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1370 From goetz at openjdk.org Wed Feb 5 09:02:27 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 09:02:27 GMT Subject: [jdk17u-dev] Integrated: 8327986: ASAN reports use-after-free in DirectivesParserTest.empty_object_vm In-Reply-To: References: Message-ID: On Wed, 29 Jan 2025 14:01:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 2fb96bfb Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2fb96bfbf1bd806d0cc3dba1307489492120616a Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8327986: ASAN reports use-after-free in DirectivesParserTest.empty_object_vm Backport-of: ce188fdacab9fd1cb841d0ccd5c385f47b348791 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3252 From goetz at openjdk.org Wed Feb 5 09:03:19 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 09:03:19 GMT Subject: [jdk21u-dev] Integrated: 8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table In-Reply-To: References: Message-ID: On Thu, 30 Jan 2025 13:53:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle This pull request has now been integrated. Changeset: 80253a3d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/80253a3d27a5e9e8cfb9e5f2c0106205ae46d9eb Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table Backport-of: 4f5a241ec11981bcb5f8ab0936b0e821ec5a03ce ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1379 From goetz at openjdk.org Wed Feb 5 09:04:13 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 09:04:13 GMT Subject: [jdk21u-dev] Integrated: 8338571: [TestBug] DefaultCloseOperation.java test not working as expected wrt instruction after JDK-8325851 fix In-Reply-To: References: Message-ID: <1fftAfHtvmF5e9Zea6CzJZ5ue60SAhHqayoFUCNy_Cg=.e389407d-d0d3-4d80-99d1-8fee74798821@github.com> On Thu, 30 Jan 2025 14:03:50 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle This pull request has now been integrated. Changeset: caa7cc2f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/caa7cc2f58feef5f32c375d9b10e9b22280fd709 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod 8338571: [TestBug] DefaultCloseOperation.java test not working as expected wrt instruction after JDK-8325851 fix Backport-of: 8858de393a5cb4f9f1150a6cdf388266362a9559 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1380 From goetz at openjdk.org Wed Feb 5 09:04:20 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 09:04:20 GMT Subject: [jdk17u-dev] Integrated: 8329692: Add more details to FrameStateTest.java test instructions In-Reply-To: References: Message-ID: On Thu, 30 Jan 2025 07:57:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 3c6af866 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/3c6af8669b1c54846e723888b54188dcf329c3c4 Stats: 50 lines in 1 file changed: 7 ins; 13 del; 30 mod 8329692: Add more details to FrameStateTest.java test instructions Backport-of: 6f98d8f58f98827ae454c7ce4839de4071d95767 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3255 From goetz at openjdk.org Wed Feb 5 09:05:13 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 09:05:13 GMT Subject: [jdk17u-dev] Integrated: 8332917: failure_handler should execute gdb "info threads" command on linux In-Reply-To: References: Message-ID: On Wed, 29 Jan 2025 12:41:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle This pull request has now been integrated. Changeset: 2ebb6f56 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2ebb6f567e9a4dbbaeff4c353b52be2a8a33d21d Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8332917: failure_handler should execute gdb "info threads" command on linux Backport-of: ec88c6a872a97cee1cde8844f5ee6834023a10c6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3251 From goetz at openjdk.org Wed Feb 5 09:06:17 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 09:06:17 GMT Subject: [jdk21u-dev] Integrated: 8347911: Limit the length of inflated text chunks In-Reply-To: <3M3qgAMZLcPbPlWfLU-3cSHwxOKiBWCqH9bwwcI0abA=.e9732fe6-dc0c-4451-bb9d-56a3330bd773@github.com> References: <3M3qgAMZLcPbPlWfLU-3cSHwxOKiBWCqH9bwwcI0abA=.e9732fe6-dc0c-4451-bb9d-56a3330bd773@github.com> Message-ID: On Wed, 29 Jan 2025 14:22:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 981ec169 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/981ec16962d6e747fc8fe1d1be0f97c8ebd4ccf5 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8347911: Limit the length of inflated text chunks Reviewed-by: andrew Backport-of: 398a580518b4e7961bdddf733e0a89ff25bc437a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1371 From goetz at openjdk.org Wed Feb 5 09:07:18 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 09:07:18 GMT Subject: [jdk17u-dev] Integrated: 8340078: Open source several 2D tests In-Reply-To: References: Message-ID: <6C9_cQLF0w51HEg60O2G-NgLxlaUaePczzCtIf3PfSg=.aab738ad-9c50-4008-acfb-d44e141e3e8c@github.com> On Thu, 30 Jan 2025 13:52:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: f0527c12 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f0527c12b395751727e97fd38442bf4b9e2bc3ea Stats: 484 lines in 5 files changed: 484 ins; 0 del; 0 mod 8340078: Open source several 2D tests Backport-of: 88a1c0550e435888c571d32c577fd697652e5620 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3260 From goetz at openjdk.org Wed Feb 5 09:08:14 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 09:08:14 GMT Subject: [jdk17u-dev] Integrated: 8226938: [TEST_BUG]GTK L&F: There is no Details button in FileChooser Dialog In-Reply-To: References: Message-ID: On Wed, 29 Jan 2025 14:12:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 373b67c8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/373b67c82e56753b9375a1538d10f1b233edbf9f Stats: 77 lines in 1 file changed: 77 ins; 0 del; 0 mod 8226938: [TEST_BUG]GTK L&F: There is no Details button in FileChooser Dialog Backport-of: fe98f86b5792cbb17d47871452d27ab87d72b342 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3253 From goetz at openjdk.org Wed Feb 5 09:09:12 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 09:09:12 GMT Subject: [jdk17u-dev] Integrated: 8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table In-Reply-To: References: Message-ID: On Thu, 30 Jan 2025 13:54:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: 52a25fd7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/52a25fd7a56bce81c8c1e88d156905428f34267c Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table Backport-of: 4f5a241ec11981bcb5f8ab0936b0e821ec5a03ce ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3261 From goetz at openjdk.org Wed Feb 5 09:10:15 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 09:10:15 GMT Subject: [jdk17u-dev] Integrated: 8338571: [TestBug] DefaultCloseOperation.java test not working as expected wrt instruction after JDK-8325851 fix In-Reply-To: References: Message-ID: On Thu, 30 Jan 2025 14:06:08 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: bd41268a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/bd41268a9a56be7039805ddacd20f1a8b33baec8 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod 8338571: [TestBug] DefaultCloseOperation.java test not working as expected wrt instruction after JDK-8325851 fix Backport-of: 8858de393a5cb4f9f1150a6cdf388266362a9559 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3262 From duke at openjdk.org Wed Feb 5 09:35:11 2025 From: duke at openjdk.org (duke) Date: Wed, 5 Feb 2025 09:35:11 GMT Subject: [jdk21u-dev] RFR: 8334371: [AIX] Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages [v5] In-Reply-To: <9Qct8kGQ2NlYV8qNNBrqgyB2oFblP8e9Zyx9Wx9LRiQ=.06ff70d1-35c3-45e5-aa46-af6d85831b59@github.com> References: <9Qct8kGQ2NlYV8qNNBrqgyB2oFblP8e9Zyx9Wx9LRiQ=.06ff70d1-35c3-45e5-aa46-af6d85831b59@github.com> Message-ID: <8EXS0eluRdQ_jE2mgUyGONaMpvcCJ2ogLkG62J2W088=.08d1bc15-bfe4-46f1-8acd-11e2b0a54402@github.com> On Tue, 4 Feb 2025 10:49:53 GMT, Joachim Kern wrote: >> Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages. As an enhancement, during the initialization of the VM the availability of this new feature is examined. If the 64K pages are supported the VM will use mmap() with 64K pages instead of shmget()/shmat() with 64K pages due to the bad 256M alignment of shmget()/shmat(). >> >> In this downport to jdk21 we want to support the new AIX 7.3 TL1 feature, but with some differences explained here: >> - `static void query_multipage_support()` in `src/hotspot/os/aix/os_aix.cpp` >> The structure of the function was changed identically in head and jdk21. Because jdk21 beforehand used trcVerbose(...) and head beforehand used log_warning(pagesize)(...) this seems to be a difference, but I just kept the tracing functions as the were before. >> >> - `src/hotspot/share/memory/virtualspace.cpp` >> Adding the use of `os::Aix::supports_64K_mmap_pages()` introduces the dependency to the header `src/hotspot/os/aix/os_aix.hpp`. In head this header was included with `#include "runtime/os.inline.hpp"` beforehand by dependant code added after jdk21. Therefore I have to include `#include "runtime/os.inline.hpp" `explicitely in virtualspace.cpp. `#include "runtime/os.hpp"` can be dropped instead. >> >> - `src/hotspot/share/runtime/os.cpp` >> Function `char* os::attempt_reserve_memory_between()` does not exist in jdk21, so I do not have to port the adoptions of head there. >> >> - `TEST_VM(os, aix_reserve_at_non_shmlba_aligned_address)` moved from `test/hotspot/gtest/runtime/test_os.cpp` to `test/hotspot/gtest/runtime/test_os_aix.cpp` >> This test function does not exist in jdk21, so there is nothing to move. > > Joachim Kern has updated the pull request incrementally with one additional commit since the last revision: > > runtime/os.hpp replaced by runtime/os.inline.hpp @JoKern65 Your change (at version 8b5a6d2c10ef509c378c1ce39cc402963ff79796) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1362#issuecomment-2636201052 From jkern at openjdk.org Wed Feb 5 09:53:24 2025 From: jkern at openjdk.org (Joachim Kern) Date: Wed, 5 Feb 2025 09:53:24 GMT Subject: [jdk21u-dev] Integrated: 8334371: [AIX] Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages In-Reply-To: References: Message-ID: On Mon, 27 Jan 2025 12:13:46 GMT, Joachim Kern wrote: > Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages. As an enhancement, during the initialization of the VM the availability of this new feature is examined. If the 64K pages are supported the VM will use mmap() with 64K pages instead of shmget()/shmat() with 64K pages due to the bad 256M alignment of shmget()/shmat(). > > In this downport to jdk21 we want to support the new AIX 7.3 TL1 feature, but with some differences explained here: > - `static void query_multipage_support()` in `src/hotspot/os/aix/os_aix.cpp` > The structure of the function was changed identically in head and jdk21. Because jdk21 beforehand used trcVerbose(...) and head beforehand used log_warning(pagesize)(...) this seems to be a difference, but I just kept the tracing functions as the were before. > > - `src/hotspot/share/memory/virtualspace.cpp` > Adding the use of `os::Aix::supports_64K_mmap_pages()` introduces the dependency to the header `src/hotspot/os/aix/os_aix.hpp`. In head this header was included with `#include "runtime/os.inline.hpp"` beforehand by dependant code added after jdk21. Therefore I have to include `#include "runtime/os.inline.hpp" `explicitely in virtualspace.cpp. `#include "runtime/os.hpp"` can be dropped instead. > > - `src/hotspot/share/runtime/os.cpp` > Function `char* os::attempt_reserve_memory_between()` does not exist in jdk21, so I do not have to port the adoptions of head there. > > - `TEST_VM(os, aix_reserve_at_non_shmlba_aligned_address)` moved from `test/hotspot/gtest/runtime/test_os.cpp` to `test/hotspot/gtest/runtime/test_os_aix.cpp` > This test function does not exist in jdk21, so there is nothing to move. This pull request has now been integrated. Changeset: 29a5de08 Author: Joachim Kern URL: https://git.openjdk.org/jdk21u-dev/commit/29a5de085a4eb746dcad637ced4cb719a59c3013 Stats: 97 lines in 3 files changed: 51 ins; 8 del; 38 mod 8334371: [AIX] Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages Reviewed-by: mdoerr, stuefe Backport-of: ced99066354fc6a32c587b9e3c35b07e26d3452e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1362 From phh at openjdk.org Wed Feb 5 10:30:12 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 5 Feb 2025 10:30:12 GMT Subject: [jdk21u-dev] RFR: 8340547: Starting many threads can delay safepoints [v2] In-Reply-To: <-4djKeb43H8gczefZqMVMOHs-N-FrvZ76KMh8_0FxJ0=.037b876d-0ab7-41ff-a2f4-16d136a87f0c@github.com> References: <-4djKeb43H8gczefZqMVMOHs-N-FrvZ76KMh8_0FxJ0=.037b876d-0ab7-41ff-a2f4-16d136a87f0c@github.com> Message-ID: On Tue, 28 Jan 2025 17:21:26 GMT, Sergey Nazarkin wrote: >> I'd like to backport this fix to fix the issue with starting a lot of threads in a burst. Some users found this to be a barrier to migrating from JDK8. >> >> The backport is not clean as required to adjust `globals.hpp` and replace `ConditionalMutexLocker` with classic `MutexLocker`. Original fix and discussion are [here](https://github.com/openjdk/jdk/pull/21111) >> >> Tested with `tier1` and reproducers from [JDK-8340547](https://bugs.openjdk.org/browse/JDK-8340547), [JDK-8307970](https://bugs.openjdk.org/browse/JDK-8307970) > > Sergey Nazarkin has updated the pull request incrementally with one additional commit since the last revision: > > NULL -> nullptr Didn't catch the NULL use, thanks for fixing it. Marked as reviewed by phh (Reviewer). ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1365#pullrequestreview-2595252929 PR Review: https://git.openjdk.org/jdk21u-dev/pull/1365#pullrequestreview-2595254388 From sgehwolf at openjdk.org Wed Feb 5 10:45:15 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 5 Feb 2025 10:45:15 GMT Subject: [jdk24u] RFR: 8345185: Update jpackage to not include service bindings by default In-Reply-To: References: Message-ID: On Tue, 28 Jan 2025 12:29:40 GMT, Severin Gehwolf wrote: > Clean backport of JDK-8345185, which would be great to have in 24.0.1 as well since that improves usability of `jpackage` in combination with `JEP 493` enabled builds of JDK 24. GHA is infra related. Let me try a re-run. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/37#issuecomment-2636367677 From mbaesken at openjdk.org Wed Feb 5 12:27:29 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 5 Feb 2025 12:27:29 GMT Subject: [jdk24u] RFR: 8345590: AIX 'make all' fails after JDK-8339480 Message-ID: <2qEmqSXa3j6MdAqKwpF2vRactMWXQDq-WAobdZjXhg4=.e6d79e0e-4f78-4231-9057-a0b493a7d87e@github.com> 8345590: AIX 'make all' fails after JDK-8339480 ------------- Commit messages: - Backport 266e3d0decc09b9c17c455e2c754cd39114fa31a Changes: https://git.openjdk.org/jdk24u/pull/51/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=51&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345590 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk24u/pull/51.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/51/head:pull/51 PR: https://git.openjdk.org/jdk24u/pull/51 From mbaesken at openjdk.org Wed Feb 5 12:31:53 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 5 Feb 2025 12:31:53 GMT Subject: [jdk24u] RFR: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero Message-ID: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero ------------- Commit messages: - Backport 5e92a4ceafd0626e3600e44a3370ca2f5d9347c8 Changes: https://git.openjdk.org/jdk24u/pull/52/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=52&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347267 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk24u/pull/52.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/52/head:pull/52 PR: https://git.openjdk.org/jdk24u/pull/52 From mbaesken at openjdk.org Wed Feb 5 12:53:36 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 5 Feb 2025 12:53:36 GMT Subject: [jdk24u] RFR: 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64 Message-ID: <9k4E3VOlT_ZSmE7lgU2BpwdzWyO8kMLgjWkr1vHZ8lc=.9fdf2e9c-48be-4be3-b477-ee9f781c669b@github.com> 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64 ------------- Commit messages: - Backport 1d2ccaeaa316029772b5de3dc5579ee7b1363b60 Changes: https://git.openjdk.org/jdk24u/pull/53/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=53&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345569 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk24u/pull/53.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/53/head:pull/53 PR: https://git.openjdk.org/jdk24u/pull/53 From goetz at openjdk.org Wed Feb 5 13:03:31 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 13:03:31 GMT Subject: [jdk17u-dev] RFR: 8330702: Update failure handler to don't generate Error message if cores actions are empty Message-ID: <-yoJ0GTOktWK5Y87zANCbvL4pwvrLPIVrlIdAnKlCII=.7b720cae-b67d-471e-a4c1-df763557e1c6@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 548e95a689d63e97ddbdfe7dd7df3a2e3377046c Changes: https://git.openjdk.org/jdk17u-dev/pull/3265/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3265&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330702 Stats: 9 lines in 2 files changed: 5 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3265.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3265/head:pull/3265 PR: https://git.openjdk.org/jdk17u-dev/pull/3265 From goetz at openjdk.org Wed Feb 5 13:03:21 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 13:03:21 GMT Subject: [jdk21u-dev] RFR: 8330702: Update failure handler to don't generate Error message if cores actions are empty Message-ID: I backport this for parity with 21.0.5-oracle ------------- Commit messages: - Backport 548e95a689d63e97ddbdfe7dd7df3a2e3377046c Changes: https://git.openjdk.org/jdk21u-dev/pull/1384/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1384&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330702 Stats: 9 lines in 2 files changed: 5 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1384.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1384/head:pull/1384 PR: https://git.openjdk.org/jdk21u-dev/pull/1384 From goetz at openjdk.org Wed Feb 5 13:12:38 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 13:12:38 GMT Subject: [jdk17u-dev] RFR: 8314975: JavadocTester should set source path if not specified Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport 2f4d601a56bf02db2766d1f8a2ddfff906b78678 Changes: https://git.openjdk.org/jdk17u-dev/pull/3266/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3266&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314975 Stats: 12 lines in 1 file changed: 12 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3266.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3266/head:pull/3266 PR: https://git.openjdk.org/jdk17u-dev/pull/3266 From goetz at openjdk.org Wed Feb 5 13:20:47 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 13:20:47 GMT Subject: [jdk21u-dev] RFR: 8340411: open source several 2D imaging tests Message-ID: <-TEKJqHgjcjRRt2PR78NMrsqKXJzBChsJDZlYLrGNbg=.3dfe5015-6210-41bc-a13f-065e7ba87484@github.com> I backport this for parity with 21.0.8-oracle ------------- Commit messages: - Backport 8dcf7b8fa7b17bf34c62c561c6ed78e8080df1ff Changes: https://git.openjdk.org/jdk21u-dev/pull/1385/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1385&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340411 Stats: 485 lines in 4 files changed: 485 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1385.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1385/head:pull/1385 PR: https://git.openjdk.org/jdk21u-dev/pull/1385 From goetz at openjdk.org Wed Feb 5 13:20:51 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 13:20:51 GMT Subject: [jdk17u-dev] RFR: 8340411: open source several 2D imaging tests Message-ID: <1CskINabJeghNH7Sn4bK1InEzvwpw-lD8aX7xqgcWeY=.709a6adb-6861-4886-bc73-d9f29ea68974@github.com> I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport 8dcf7b8fa7b17bf34c62c561c6ed78e8080df1ff Changes: https://git.openjdk.org/jdk17u-dev/pull/3267/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3267&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340411 Stats: 485 lines in 4 files changed: 485 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3267.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3267/head:pull/3267 PR: https://git.openjdk.org/jdk17u-dev/pull/3267 From goetz at openjdk.org Wed Feb 5 13:21:29 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 13:21:29 GMT Subject: [jdk17u-dev] RFR: 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04 Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport 6f307623568efe4d90942cd22ec9a26b2e1ca1b1 Changes: https://git.openjdk.org/jdk17u-dev/pull/3268/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3268&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345468 Stats: 37 lines in 1 file changed: 7 ins; 17 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3268.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3268/head:pull/3268 PR: https://git.openjdk.org/jdk17u-dev/pull/3268 From goetz at openjdk.org Wed Feb 5 13:47:53 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 13:47:53 GMT Subject: [jdk21u-dev] RFR: 8325730: StringBuilder.toString allocation for the empty String Message-ID: I backport this for parity with 21.0.7-oracle. ------------- Commit messages: - Backport d2590c69b4efe5aa2b48b08070e0dbafb04ef202 Changes: https://git.openjdk.org/jdk21u-dev/pull/1387/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1387&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325730 Stats: 25 lines in 4 files changed: 20 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1387.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1387/head:pull/1387 PR: https://git.openjdk.org/jdk21u-dev/pull/1387 From goetz at openjdk.org Wed Feb 5 14:16:49 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 5 Feb 2025 14:16:49 GMT Subject: [jdk17u-dev] RFR: 8266435: WBMPImageReader.read() should not truncate the input stream Message-ID: <3-ylTMKnTS3NF-gZuh-NUxhq2om72b6fFAa3HqvfFkk=.253ab196-9f11-4548-9ecc-7b6f09d18b79@github.com> I'd like to fix this small issue in 17. ------------- Commit messages: - Backport 8198807b4a811040c7d9f65fb98494fc7d840814 Changes: https://git.openjdk.org/jdk17u-dev/pull/3269/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3269&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8266435 Stats: 122 lines in 2 files changed: 118 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3269.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3269/head:pull/3269 PR: https://git.openjdk.org/jdk17u-dev/pull/3269 From duke at openjdk.org Wed Feb 5 16:21:27 2025 From: duke at openjdk.org (kieran-farrell) Date: Wed, 5 Feb 2025 16:21:27 GMT Subject: [jdk24u] RFR: 8346705: SNI not sent with Java 22+ using java.net.http.HttpClient.Builder#sslParameters Message-ID: @coffeys Backport applied cleanly with all tests passing Baseline: https://mach5.us.oracle.com/mdash/jobs/kifarrel-jdk24u-20250205-1259-23276314/results?search=status%3A* Post backport: https://mach5.us.oracle.com/mdash/jobs/kifarrel-jdk24u-20250205-1309-23276794/results?search=status%3A* ------------- Commit messages: - 8349454_SNI not sent with Java 22+ using java.net.http.HttpClient.Builder#sslParameters Changes: https://git.openjdk.org/jdk24u/pull/54/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=54&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346705 Stats: 268 lines in 3 files changed: 256 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk24u/pull/54.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/54/head:pull/54 PR: https://git.openjdk.org/jdk24u/pull/54 From sgehwolf at openjdk.org Wed Feb 5 17:06:17 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 5 Feb 2025 17:06:17 GMT Subject: [jdk24u] RFR: 8345185: Update jpackage to not include service bindings by default In-Reply-To: References: Message-ID: On Tue, 28 Jan 2025 12:29:40 GMT, Severin Gehwolf wrote: > Clean backport of JDK-8345185, which would be great to have in 24.0.1 as well since that improves usability of `jpackage` in combination with `JEP 493` enabled builds of JDK 24. GHA looks good (not that it tests anything part of that patch, other than basic builds of jdk.jpackage). ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/37#issuecomment-2637515023 From sgehwolf at openjdk.org Wed Feb 5 17:06:18 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 5 Feb 2025 17:06:18 GMT Subject: [jdk24u] Integrated: 8345185: Update jpackage to not include service bindings by default In-Reply-To: References: Message-ID: On Tue, 28 Jan 2025 12:29:40 GMT, Severin Gehwolf wrote: > Clean backport of JDK-8345185, which would be great to have in 24.0.1 as well since that improves usability of `jpackage` in combination with `JEP 493` enabled builds of JDK 24. This pull request has now been integrated. Changeset: ba7b3c24 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk24u/commit/ba7b3c2455eb4fd7b88387b3a21eb3b302cd5644 Stats: 60 lines in 7 files changed: 36 ins; 11 del; 13 mod 8345185: Update jpackage to not include service bindings by default Backport-of: 85ed78c063493259247d88f5ca51b47b7a45fcb0 ------------- PR: https://git.openjdk.org/jdk24u/pull/37 From kvn at openjdk.org Wed Feb 5 19:59:46 2025 From: kvn at openjdk.org (Vladimir Kozlov) Date: Wed, 5 Feb 2025 19:59:46 GMT Subject: [jdk24u] RFR: 8347997: assert(false) failed: EA: missing memory path Message-ID: Hi all, This pull request contains a backport of commit [6b581d22](https://github.com/openjdk/jdk/commit/6b581d22e13599b16b38aff1ca5a795c6a910d30) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Vladimir Kozlov on 29 Jan 2025 and was reviewed by Tobias Hartmann and Christian Hagedorn. Thanks! ------------- Commit messages: - Backport 6b581d22e13599b16b38aff1ca5a795c6a910d30 Changes: https://git.openjdk.org/jdk24u/pull/55/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=55&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347997 Stats: 106 lines in 2 files changed: 91 ins; 13 del; 2 mod Patch: https://git.openjdk.org/jdk24u/pull/55.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/55/head:pull/55 PR: https://git.openjdk.org/jdk24u/pull/55 From wkemper at openjdk.org Wed Feb 5 20:17:25 2025 From: wkemper at openjdk.org (William Kemper) Date: Wed, 5 Feb 2025 20:17:25 GMT Subject: [jdk24u] RFR: 8349002: GenShen: Deadlock during shutdown Message-ID: Clean backport. Fixes bug recently introduced by [JDK-8345970](https://bugs.openjdk.org/browse/JDK-8345970). ------------- Commit messages: - Backport 06ebb170bac3879dc1e378b48b1c7ef006070c86 Changes: https://git.openjdk.org/jdk24u/pull/56/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=56&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349002 Stats: 5 lines in 2 files changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk24u/pull/56.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/56/head:pull/56 PR: https://git.openjdk.org/jdk24u/pull/56 From kvn at openjdk.org Wed Feb 5 23:32:09 2025 From: kvn at openjdk.org (Vladimir Kozlov) Date: Wed, 5 Feb 2025 23:32:09 GMT Subject: [jdk24u] RFR: 8347997: assert(false) failed: EA: missing memory path In-Reply-To: References: Message-ID: <3Kg2HPGpRzMS3oKxy2BNS47BqR_XWZtf5ZL6wvXB9pY=.b022a9ce-3160-4109-b52f-548e407ffadb@github.com> On Wed, 5 Feb 2025 19:54:59 GMT, Vladimir Kozlov wrote: > Hi all, > > This pull request contains a backport of commit [6b581d22](https://github.com/openjdk/jdk/commit/6b581d22e13599b16b38aff1ca5a795c6a910d30) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Vladimir Kozlov on 29 Jan 2025 and was reviewed by Tobias Hartmann and Christian Hagedorn. > > Thanks! Waiting GHA testing done. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/55#issuecomment-2638265977 From duke at openjdk.org Wed Feb 5 23:38:32 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Wed, 5 Feb 2025 23:38:32 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v4] In-Reply-To: References: Message-ID: <8QAByjk9I8NK7Jxp2NSWdSsNkF8DiO21P2Fjh_gEK3M=.29a213df-a3d3-4ec1-b08b-8c4fa05cf2a1@github.com> On Wed, 27 Nov 2024 11:29:35 GMT, Andrew Haley wrote: >> Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: >> >> Replace pkcs11/fips/key4.db and pkcs11.txt > > What do you see? > > $ pwd > /local/jdk11u-dev/test/jdk/sun/security/pkcs11/fips > $ /usr/lib64/nss/unsupported-tools/dbtool -d . > dbdir selected is . > > CertDB: > KeyDB: @theRealAph If you have time, I would like you to check my comment. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2955#issuecomment-2638273449 From duke at openjdk.org Wed Feb 5 23:44:35 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Wed, 5 Feb 2025 23:44:35 GMT Subject: [jdk11u-dev] RFR: 8026976: ECParameters, Point does not match field size In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 07:15:55 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8026976: ECParameters, Point does not match field size > > Original patch apply cleanly to 11u. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. @gnu-andrew Sorry for the sudden mention, if possible, could you please review this PR? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2958#issuecomment-2638281086 From goetz at openjdk.org Thu Feb 6 06:38:19 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 6 Feb 2025 06:38:19 GMT Subject: [jdk17u-dev] RFR: 8330702: Update failure handler to don't generate Error message if cores actions are empty In-Reply-To: <-yoJ0GTOktWK5Y87zANCbvL4pwvrLPIVrlIdAnKlCII=.7b720cae-b67d-471e-a4c1-df763557e1c6@github.com> References: <-yoJ0GTOktWK5Y87zANCbvL4pwvrLPIVrlIdAnKlCII=.7b720cae-b67d-471e-a4c1-df763557e1c6@github.com> Message-ID: On Wed, 5 Feb 2025 12:58:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.13-oracle. GHA failure: wget issue, unrelated ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3265#issuecomment-2638957820 From duke at openjdk.org Thu Feb 6 09:08:20 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 6 Feb 2025 09:08:20 GMT Subject: [jdk24u] Integrated: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs In-Reply-To: References: Message-ID: On Wed, 29 Jan 2025 11:25:16 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. Low risk. > > On Linux it passes tier1 tests and also all `jdk/sun/security` tests: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 798 798 0 0 > ============================== > TEST SUCCESS This pull request has now been integrated. Changeset: d2262fe4 Author: Antonio Vieiro Committer: Andrew Dinn URL: https://git.openjdk.org/jdk24u/commit/d2262fe4e9b3118d4c4ab152aa2771b744398367 Stats: 392 lines in 8 files changed: 388 ins; 0 del; 4 mod 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs Backport-of: 907350e9e8e9b66365e9eaa3ae89ddc55cf9731f ------------- PR: https://git.openjdk.org/jdk24u/pull/40 From duke at openjdk.org Thu Feb 6 09:27:33 2025 From: duke at openjdk.org (toshiogata) Date: Thu, 6 Feb 2025 09:27:33 GMT Subject: [jdk11u-dev] RFR: 8328242: Add a log area to the PassFailJFrame In-Reply-To: References: Message-ID: <8_wUQapqQNnX_IXfzDaC-QZqFhIqX9kbSWE5JLn_Hpk=.d6fe1895-abd9-46b1-87d4-484540e5b95c@github.com> On Tue, 22 Oct 2024 07:41:09 GMT, toshiogata wrote: > Hi all, > > I would like to backport this patch to improve test maintainability for manual tests. The patch is clean. > Testing: manually checked some tests using PassFailJFrame, and confirmed that they work in the same way. > > Thank you. Keep open. Additional comments for this PR This PR, along with a subsequent PR which I plan to submit, can make the backport of JDK-8337851 (https://bugs.openjdk.org/browse/JDK-8337851) cleaner. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2959#issuecomment-2639257773 From aph at openjdk.org Thu Feb 6 09:33:24 2025 From: aph at openjdk.org (Andrew Haley) Date: Thu, 6 Feb 2025 09:33:24 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v4] In-Reply-To: References: Message-ID: On Wed, 27 Nov 2024 11:29:35 GMT, Andrew Haley wrote: >> Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: >> >> Replace pkcs11/fips/key4.db and pkcs11.txt > > What do you see? > > $ pwd > /local/jdk11u-dev/test/jdk/sun/security/pkcs11/fips > $ /usr/lib64/nss/unsupported-tools/dbtool -d . > dbdir selected is . > > CertDB: > KeyDB: > @theRealAph > > > Why are the two sets of files key4.db and cert9.db different? > > The reason key4.db and cert9.db are different is that they are newly created by me using the "modutil" command. I created them with reference to [jdk/test/jdk/sun/security/pkcs11/Secmod/README-SQLITE](https://github.com/openjdk/jdk/blob/ac82a8f89c7066fb1d379b12bcfd68053cb39ba4/test/jdk/sun/security/pkcs11/Secmod/README-SQLITE) and manually copied pkcs11.txt from [jdk/test/jdk/sun/security/pkcs11/Secmod/pkcs11.txt](https://github.com/openjdk/jdk/blob/f0b251d76078e8d5b47e967b0449c4cbdcb5a005/test/jdk/sun/security/pkcs11/Secmod/pkcs11.txt). However, after receiving your comment, I realized that the README-SQLITE procedure does not correspond to the contents of pkcs11.txt. So I recreated key4.db ,cert9.db and pkcs11.txt using the following steps: OK, that's better. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2955#issuecomment-2639269469 From duke at openjdk.org Thu Feb 6 10:09:01 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 6 Feb 2025 10:09:01 GMT Subject: [jdk21u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs Message-ID: Clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. Low risk. It passes tier1 tests and also all jdk/sun/security tests: ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/sun/security 795 795 0 0 ============================== TEST SUCCESS ------------- Commit messages: - Backport d2262fe4e9b3118d4c4ab152aa2771b744398367 Changes: https://git.openjdk.org/jdk21u-dev/pull/1388/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1388&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346587 Stats: 392 lines in 8 files changed: 388 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1388.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1388/head:pull/1388 PR: https://git.openjdk.org/jdk21u-dev/pull/1388 From duke at openjdk.org Thu Feb 6 10:28:14 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 6 Feb 2025 10:28:14 GMT Subject: [jdk21u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs In-Reply-To: References: Message-ID: On Thu, 6 Feb 2025 10:02:04 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. Low risk. > > It passes tier1 tests and also all jdk/sun/security tests: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 795 795 0 0 > ============================== > TEST SUCCESS Looks like there's an ongoing GHA availability issue (`api.github.com` is failing). I'll keep on retrying tests. Download action repository 'actions/github-script at v7' (SHA:60a0d83039c74a4aee543508d2ffcb1c3799cdea) Warning: Failed to download action 'https://api.github.com/repos/actions/github-script/tarball/60a0d83039c74a4aee543508d2ffcb1c3799cdea'. Error: Response status code does not indicate success: 502 (Bad Gateway). 1490:16A03E:48BF133:92183DE:67A4889A Warning: Back off 15.868 seconds before retry. Warning: Failed to download action 'https://api.github.com/repos/actions/github-script/tarball/60a0d83039c74a4aee543508d2ffcb1c3799cdea'. Error: Response status code does not indicate success: 504 (Gateway Timeout). Warning: Back off 29.822 seconds before retry. Error: Response status code does not indicate success: 503 (Service Unavailable). ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1388#issuecomment-2639416245 From goetz at openjdk.org Thu Feb 6 13:59:00 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 6 Feb 2025 13:59:00 GMT Subject: [jdk17u-dev] RFR: 8314975: JavadocTester should set source path if not specified [v2] In-Reply-To: References: Message-ID: <5Ocn4LlJ2kUVVh126hX-sbhvtfN4jNGKAVuvFEhKcSk=.2ba369fe-f39c-4c54-8c55-dffc26b5375c@github.com> > I backport this for parity with 17.0.16-oracle. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Fix TestCopyFiles.java ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3266/files - new: https://git.openjdk.org/jdk17u-dev/pull/3266/files/18eddb3c..2d032c63 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3266&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3266&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3266.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3266/head:pull/3266 PR: https://git.openjdk.org/jdk17u-dev/pull/3266 From goetz at openjdk.org Thu Feb 6 14:20:56 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 6 Feb 2025 14:20:56 GMT Subject: [jdk17u-dev] RFR: 8342988: GHA: Build JTReg in single step Message-ID: <7RYLD7tRxof3pzOKZwE_exHfrKS3popeWByz2d1Rnd8=.997b01fa-c083-4af7-9294-6834debcba32@github.com> I want to backport this to reduce errors in gha runs. The backport is based on the commit to 21. I had to resolve becasue 8297984: Turn on warnings as errors for javadoc is not in 17. Omitted the edits in the code added by JDK-8297984. ------------- Commit messages: - Add missing file - Backport 6e6f8b2f90e362ceb2d76e791cd6e58cf5d3ddbd Changes: https://git.openjdk.org/jdk17u-dev/pull/3264/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3264&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342988 Stats: 136 lines in 3 files changed: 81 ins; 26 del; 29 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3264.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3264/head:pull/3264 PR: https://git.openjdk.org/jdk17u-dev/pull/3264 From mbaesken at openjdk.org Thu Feb 6 14:20:56 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 6 Feb 2025 14:20:56 GMT Subject: [jdk17u-dev] RFR: 8342988: GHA: Build JTReg in single step In-Reply-To: <7RYLD7tRxof3pzOKZwE_exHfrKS3popeWByz2d1Rnd8=.997b01fa-c083-4af7-9294-6834debcba32@github.com> References: <7RYLD7tRxof3pzOKZwE_exHfrKS3popeWByz2d1Rnd8=.997b01fa-c083-4af7-9294-6834debcba32@github.com> Message-ID: On Wed, 5 Feb 2025 12:25:48 GMT, Goetz Lindenmaier wrote: > I want to backport this to reduce errors in gha runs. The backport is based on the commit to 21. > > I had to resolve becasue 8297984: Turn on warnings as errors for javadoc > is not in 17. > Omitted the edits in the code added by JDK-8297984. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3264#pullrequestreview-2598049418 From kvn at openjdk.org Thu Feb 6 16:23:16 2025 From: kvn at openjdk.org (Vladimir Kozlov) Date: Thu, 6 Feb 2025 16:23:16 GMT Subject: [jdk24u] RFR: 8347997: assert(false) failed: EA: missing memory path In-Reply-To: References: Message-ID: <2cas5uv4lvBsgrqw6NvgyNR_UTvhWahIRBoPMC28H-U=.be5ccdeb-1a98-4c55-b0f3-22ba729d6d1d@github.com> On Wed, 5 Feb 2025 19:54:59 GMT, Vladimir Kozlov wrote: > Hi all, > > This pull request contains a backport of commit [6b581d22](https://github.com/openjdk/jdk/commit/6b581d22e13599b16b38aff1ca5a795c6a910d30) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Vladimir Kozlov on 29 Jan 2025 and was reviewed by Tobias Hartmann and Christian Hagedorn. > > Thanks! Test `gc/shenandoah/TestSmallHeap.java#generational` timed out on linux-x64. I don't think it is related to my changes. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/55#issuecomment-2640295856 From kvn at openjdk.org Thu Feb 6 16:23:17 2025 From: kvn at openjdk.org (Vladimir Kozlov) Date: Thu, 6 Feb 2025 16:23:17 GMT Subject: [jdk24u] Integrated: 8347997: assert(false) failed: EA: missing memory path In-Reply-To: References: Message-ID: On Wed, 5 Feb 2025 19:54:59 GMT, Vladimir Kozlov wrote: > Hi all, > > This pull request contains a backport of commit [6b581d22](https://github.com/openjdk/jdk/commit/6b581d22e13599b16b38aff1ca5a795c6a910d30) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Vladimir Kozlov on 29 Jan 2025 and was reviewed by Tobias Hartmann and Christian Hagedorn. > > Thanks! This pull request has now been integrated. Changeset: 74bc60ba Author: Vladimir Kozlov URL: https://git.openjdk.org/jdk24u/commit/74bc60ba89f4011b5994ad86d51b2a2210bea49f Stats: 106 lines in 2 files changed: 91 ins; 13 del; 2 mod 8347997: assert(false) failed: EA: missing memory path Backport-of: 6b581d22e13599b16b38aff1ca5a795c6a910d30 ------------- PR: https://git.openjdk.org/jdk24u/pull/55 From sgehwolf at openjdk.org Thu Feb 6 16:32:16 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 6 Feb 2025 16:32:16 GMT Subject: [jdk17u-dev] RFR: 8342988: GHA: Build JTReg in single step In-Reply-To: <7RYLD7tRxof3pzOKZwE_exHfrKS3popeWByz2d1Rnd8=.997b01fa-c083-4af7-9294-6834debcba32@github.com> References: <7RYLD7tRxof3pzOKZwE_exHfrKS3popeWByz2d1Rnd8=.997b01fa-c083-4af7-9294-6834debcba32@github.com> Message-ID: <_DejriL6MhAWGHzaZyBmy-yOdLVANeJayKscvgV7geY=.a8fa6e6e-7273-4388-a8d9-606726c3978e@github.com> On Wed, 5 Feb 2025 12:25:48 GMT, Goetz Lindenmaier wrote: > I want to backport this to reduce errors in gha runs. The backport is based on the commit to 21. > > I had to resolve becasue 8297984: Turn on warnings as errors for javadoc > is not in 17. > Omitted the edits in the code added by JDK-8297984. Looks good. Thanks for doing this! ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3264#pullrequestreview-2599239776 From duke at openjdk.org Thu Feb 6 16:44:10 2025 From: duke at openjdk.org (duke) Date: Thu, 6 Feb 2025 16:44:10 GMT Subject: [jdk21u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs In-Reply-To: References: Message-ID: On Thu, 6 Feb 2025 10:02:04 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. Low risk. > > It passes tier1 tests and also all jdk/sun/security tests: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 795 795 0 0 > ============================== > TEST SUCCESS @vieiro Your change (at version ee8c8e256dff0b8786cd58ae25657cc70543e2c4) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1388#issuecomment-2640378047 From aph at openjdk.org Thu Feb 6 18:45:19 2025 From: aph at openjdk.org (Andrew Haley) Date: Thu, 6 Feb 2025 18:45:19 GMT Subject: [jdk21u-dev] RFR: 8180450: secondary_super_cache does not scale well In-Reply-To: <4LeEOVL3OM57vpgMH9YTOBgyGCucK3L6iWC0XGD60ZQ=.10c0f7c0-897d-45ec-b105-5c4467890d74@github.com> References: <4LeEOVL3OM57vpgMH9YTOBgyGCucK3L6iWC0XGD60ZQ=.10c0f7c0-897d-45ec-b105-5c4467890d74@github.com> Message-ID: On Thu, 24 Oct 2024 10:10:45 GMT, Andrew Haley wrote: > See [8180450](https://github.com/openjdk/jdk/pull/18309) for a full description of how this works. > This is a pretty clean backport, but a few files had to be fiddled manually because things had been added nearby. > > This PR also includes a fix for [[8337958](https://bugs.openjdk.org/browse/JDK-8337958)](https://bugs.openjdk.org/browse/JDK-8337958), which was a minor bug in the original commit. > > For a justification of why this PR should be backported to JDK 21u, see > [Franz's email](https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-October/038649.html). For avoidance of doubt: A later bug, https://bugs.openjdk.org/browse/JDK-8344355, does not apply to this PR. The bug 8344355 fixed was caused by 8331341: secondary_super_cache does not scale well: C1 and interpreter. 8331341 is not included here, and I have no intention of ever backporting it. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1090#issuecomment-2640710960 From serguei.spitsyn at oracle.com Thu Feb 6 19:01:45 2025 From: serguei.spitsyn at oracle.com (Serguei Spitsyn) Date: Thu, 6 Feb 2025 19:01:45 +0000 Subject: CFV: New JDK Updates Committer: Damon Fenacci In-Reply-To: <6a336e93-0c07-4ab0-86a2-b171f933e464@oracle.com> References: <6a336e93-0c07-4ab0-86a2-b171f933e464@oracle.com> Message-ID: Vote: yes -------------- next part -------------- An HTML attachment was scrubbed... URL: From clanger at openjdk.org Thu Feb 6 20:14:40 2025 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 6 Feb 2025 20:14:40 GMT Subject: [jdk17u-dev] RFR: 8348625: [21u, 17u] Revert JDK-8185862 to restore old java.awt.headless behavior on Windows Message-ID: Hi all, This pull request contains a backport of commit [e1967d51 ](https://github.com/openjdk/jdk21u-dev/commit/e1967d51)from the [openjdk/jdk21u-dev](https://github.com/openjdk/jdk21u-dev) repository. The commit being backported was authored by Christoph Langer on 31 Jan 2025 and was reviewed by Severin Gehwolf. Thanks! ------------- Commit messages: - Backport e1967d5124309de5276ab88d1bcf4d24f2620dab Changes: https://git.openjdk.org/jdk17u-dev/pull/3270/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3270&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348625 Stats: 138 lines in 6 files changed: 20 ins; 87 del; 31 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3270.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3270/head:pull/3270 PR: https://git.openjdk.org/jdk17u-dev/pull/3270 From clanger at openjdk.org Thu Feb 6 21:15:27 2025 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 6 Feb 2025 21:15:27 GMT Subject: [jdk21u-dev] RFR: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates Message-ID: <0SXRA26DNGEAUbp6nl-hP7RTNQwpQ0VDrG7cATsIuUM=.ae8cb8f1-a934-4c10-94a6-8ebfd91c7d30@github.com> Bumps the GHA JDKs. ------------- Commit messages: - JDK-8349603 Changes: https://git.openjdk.org/jdk21u-dev/pull/1389/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1389&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349603 Stats: 14 lines in 1 file changed: 4 ins; 4 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1389.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1389/head:pull/1389 PR: https://git.openjdk.org/jdk21u-dev/pull/1389 From duke at openjdk.org Thu Feb 6 22:24:13 2025 From: duke at openjdk.org (duke) Date: Thu, 6 Feb 2025 22:24:13 GMT Subject: [jdk21u-dev] Withdrawn: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11 In-Reply-To: References: Message-ID: On Fri, 4 Oct 2024 12:01:25 GMT, Sorna Sarathi N wrote: > Hi all, > This pull request contains a backport of commit [3251eea](https://github.com/openjdk/jdk/commit/3251eea1f4289a0505052be204407c02ca38b0ad) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > Tier1 testing is successful. > Thanks! > > JBS Issue: [JDK-8336499](https://bugs.openjdk.org/browse/JDK-8336499) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1021 From goetz at openjdk.org Fri Feb 7 07:25:15 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 7 Feb 2025 07:25:15 GMT Subject: [jdk24u] Integrated: 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025 In-Reply-To: References: Message-ID: On Wed, 5 Feb 2025 07:57:17 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing on new Windows. > > With a lot of hurry I could make jdk24 RDP2, which ends tomorrow, Feb 6th. > But I want to run this through our testing, so I think jdk24u is the better target. This pull request has now been integrated. Changeset: 19fc73a6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk24u/commit/19fc73a6de04741d082a706c64a410cb521a5447 Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025 Backport-of: 2e00816ac30373df28a29dc938f7ce5489a3edfc ------------- PR: https://git.openjdk.org/jdk24u/pull/48 From goetz at openjdk.org Fri Feb 7 07:26:26 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 7 Feb 2025 07:26:26 GMT Subject: [jdk24u] Integrated: 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025 In-Reply-To: References: Message-ID: On Wed, 5 Feb 2025 08:02:52 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing with recent Windows. > > With a lot of hurry I could make jdk24 RDP2, which ends tomorrow, Feb 6th. > But I want to run this through our testing, so I think jdk24u is the better target. This pull request has now been integrated. Changeset: aa97299f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk24u/commit/aa97299fecb6c31ccf0816f6c6bb5de91a6b61b3 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025 Backport-of: b0c131e872f997cb7deadc9b0a87bd76e3a2a83c ------------- PR: https://git.openjdk.org/jdk24u/pull/49 From goetz at openjdk.org Fri Feb 7 08:15:20 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 7 Feb 2025 08:15:20 GMT Subject: [jdk21u-dev] Integrated: 8330702: Update failure handler to don't generate Error message if cores actions are empty In-Reply-To: References: Message-ID: On Wed, 5 Feb 2025 12:58:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.5-oracle This pull request has now been integrated. Changeset: 4a3eaa71 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/4a3eaa71b8f284cd1dcaf01b74a144287dfdb9a5 Stats: 9 lines in 2 files changed: 5 ins; 0 del; 4 mod 8330702: Update failure handler to don't generate Error message if cores actions are empty Backport-of: 548e95a689d63e97ddbdfe7dd7df3a2e3377046c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1384 From goetz at openjdk.org Fri Feb 7 08:36:14 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 7 Feb 2025 08:36:14 GMT Subject: [jdk17u-dev] Integrated: 8266435: WBMPImageReader.read() should not truncate the input stream In-Reply-To: <3-ylTMKnTS3NF-gZuh-NUxhq2om72b6fFAa3HqvfFkk=.253ab196-9f11-4548-9ecc-7b6f09d18b79@github.com> References: <3-ylTMKnTS3NF-gZuh-NUxhq2om72b6fFAa3HqvfFkk=.253ab196-9f11-4548-9ecc-7b6f09d18b79@github.com> Message-ID: <9wN1KHjfrBHzg0WrF38N0Jl3Z3m7qPJ1HPSL_RMfDqc=.5c2869c6-56ec-439b-bbad-5157e90255a5@github.com> On Wed, 5 Feb 2025 14:11:49 GMT, Goetz Lindenmaier wrote: > I'd like to fix this small issue in 17. This pull request has now been integrated. Changeset: cf4fca2f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/cf4fca2f96f8ae20a4645d571ef65b2be1d7a5fb Stats: 122 lines in 2 files changed: 118 ins; 0 del; 4 mod 8266435: WBMPImageReader.read() should not truncate the input stream Backport-of: 8198807b4a811040c7d9f65fb98494fc7d840814 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3269 From goetz at openjdk.org Fri Feb 7 08:37:20 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 7 Feb 2025 08:37:20 GMT Subject: [jdk17u-dev] Integrated: 8330702: Update failure handler to don't generate Error message if cores actions are empty In-Reply-To: <-yoJ0GTOktWK5Y87zANCbvL4pwvrLPIVrlIdAnKlCII=.7b720cae-b67d-471e-a4c1-df763557e1c6@github.com> References: <-yoJ0GTOktWK5Y87zANCbvL4pwvrLPIVrlIdAnKlCII=.7b720cae-b67d-471e-a4c1-df763557e1c6@github.com> Message-ID: On Wed, 5 Feb 2025 12:58:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 50c6fab7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/50c6fab7306a7bf54bfe545164012c651e0e0990 Stats: 9 lines in 2 files changed: 5 ins; 0 del; 4 mod 8330702: Update failure handler to don't generate Error message if cores actions are empty Backport-of: 548e95a689d63e97ddbdfe7dd7df3a2e3377046c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3265 From goetz at openjdk.org Fri Feb 7 08:39:20 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 7 Feb 2025 08:39:20 GMT Subject: [jdk17u-dev] Integrated: 8340411: open source several 2D imaging tests In-Reply-To: <1CskINabJeghNH7Sn4bK1InEzvwpw-lD8aX7xqgcWeY=.709a6adb-6861-4886-bc73-d9f29ea68974@github.com> References: <1CskINabJeghNH7Sn4bK1InEzvwpw-lD8aX7xqgcWeY=.709a6adb-6861-4886-bc73-d9f29ea68974@github.com> Message-ID: On Wed, 5 Feb 2025 13:15:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: 7213c0da Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7213c0da2f78980942f563a40af53dccd9f98d1e Stats: 485 lines in 4 files changed: 485 ins; 0 del; 0 mod 8340411: open source several 2D imaging tests Backport-of: 8dcf7b8fa7b17bf34c62c561c6ed78e8080df1ff ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3267 From goetz at openjdk.org Fri Feb 7 08:33:19 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 7 Feb 2025 08:33:19 GMT Subject: [jdk21u-dev] Integrated: 8340411: open source several 2D imaging tests In-Reply-To: <-TEKJqHgjcjRRt2PR78NMrsqKXJzBChsJDZlYLrGNbg=.3dfe5015-6210-41bc-a13f-065e7ba87484@github.com> References: <-TEKJqHgjcjRRt2PR78NMrsqKXJzBChsJDZlYLrGNbg=.3dfe5015-6210-41bc-a13f-065e7ba87484@github.com> Message-ID: On Wed, 5 Feb 2025 13:15:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle This pull request has now been integrated. Changeset: d279d442 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d279d442cf8a2c262beb4f70b6c4912cd8fdebe8 Stats: 485 lines in 4 files changed: 485 ins; 0 del; 0 mod 8340411: open source several 2D imaging tests Backport-of: 8dcf7b8fa7b17bf34c62c561c6ed78e8080df1ff ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1385 From goetz at openjdk.org Fri Feb 7 08:39:11 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 7 Feb 2025 08:39:11 GMT Subject: [jdk17u-dev] Integrated: 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04 In-Reply-To: References: Message-ID: <7hBU6QxoaR88RWlID1IXpUG2l2JgHVGgKcpl0262D-E=.ab800b58-ac01-4b72-a334-b5e0f132b1c8@github.com> On Wed, 5 Feb 2025 13:16:56 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: 751130a4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/751130a424de99d46242eac4ffffd4ff7710b72b Stats: 37 lines in 1 file changed: 7 ins; 17 del; 13 mod 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04 Backport-of: 6f307623568efe4d90942cd22ec9a26b2e1ca1b1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3268 From goetz at openjdk.org Fri Feb 7 10:04:21 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 7 Feb 2025 10:04:21 GMT Subject: [jdk24u] Integrated: 8347740: java/io/File/createTempFile/SpecialTempFile.java failing In-Reply-To: References: Message-ID: <46R7wGHgzZmxujRdE4h8a_WXv1sMigwzv-g5SseMKBU=.6b094150-941b-4484-930f-ba600f4040bc@github.com> On Wed, 5 Feb 2025 08:29:16 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing on windows. > > Clean backport on top of JDK-8345368. This pull request has now been integrated. Changeset: 8012f69b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk24u/commit/8012f69bc7a168784ebe41df082e2ecff094e789 Stats: 28 lines in 1 file changed: 12 ins; 3 del; 13 mod 8347740: java/io/File/createTempFile/SpecialTempFile.java failing Backport-of: f2a9d26b2e409a7216d967ebb6b92726e8ed65c3 ------------- PR: https://git.openjdk.org/jdk24u/pull/50 From mdoerr at openjdk.org Fri Feb 7 10:13:15 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 7 Feb 2025 10:13:15 GMT Subject: [jdk21u-dev] Integrated: 8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis In-Reply-To: References: Message-ID: <13q9YLgxskDb2NIaKOisGA0jibomd7JC3AirDu8Rxvs=.4ac30b63-1aa3-44da-88ae-639149feee41@github.com> On Mon, 27 Jan 2025 11:01:00 GMT, Martin Doerr wrote: > Clean backport of [JDK-8348562](https://bugs.openjdk.org/browse/JDK-8348562). The crashes can be reproduced in 21u by `make run-test TEST="jdk/jfr/api/consumer/streaming/TestFilledChunks.java" JTREG="VM_OPTIONS=-XX:+UseZGC -XX:+ZGenerational"` on linux PPC64le. The fix only adds a null check + bailout where the current implementation crashes with SIGSEGV. The test passes with this fix. This pull request has now been integrated. Changeset: 46a14640 Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/46a146407f0a2168c5a92a06f2d08f33096937e2 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis Backport-of: afcc2b03afc77f730300e1d92471466d56ed75fb ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1361 From mbaesken at openjdk.org Fri Feb 7 10:44:59 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 7 Feb 2025 10:44:59 GMT Subject: [jdk21u-dev] RFR: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates In-Reply-To: <0SXRA26DNGEAUbp6nl-hP7RTNQwpQ0VDrG7cATsIuUM=.ae8cb8f1-a934-4c10-94a6-8ebfd91c7d30@github.com> References: <0SXRA26DNGEAUbp6nl-hP7RTNQwpQ0VDrG7cATsIuUM=.ae8cb8f1-a934-4c10-94a6-8ebfd91c7d30@github.com> Message-ID: On Thu, 6 Feb 2025 21:10:48 GMT, Christoph Langer wrote: > Bumps the GHA JDKs. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1389#pullrequestreview-2601404821 From mbaesken at openjdk.org Fri Feb 7 11:10:26 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 7 Feb 2025 11:10:26 GMT Subject: [jdk24u] RFR: 8347576: Error output in libjsound has non matching format strings Message-ID: 8347576: Error output in libjsound has non matching format strings ------------- Commit messages: - Backport 07a0dcbabcb1216211c1da75f6dd2582da194df9 Changes: https://git.openjdk.org/jdk24u/pull/57/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=57&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347576 Stats: 13 lines in 4 files changed: 2 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk24u/pull/57.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/57/head:pull/57 PR: https://git.openjdk.org/jdk24u/pull/57 From mbaesken at openjdk.org Fri Feb 7 11:15:52 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 7 Feb 2025 11:15:52 GMT Subject: [jdk24u] RFR: 8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer Message-ID: 8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer ------------- Commit messages: - Backport 0a81676fae3b25117dd2289a734193bcbee822de Changes: https://git.openjdk.org/jdk24u/pull/58/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=58&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346881 Stats: 14 lines in 3 files changed: 8 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk24u/pull/58.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/58/head:pull/58 PR: https://git.openjdk.org/jdk24u/pull/58 From mbaesken at openjdk.org Fri Feb 7 11:32:19 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 7 Feb 2025 11:32:19 GMT Subject: [jdk24u] RFR: 8348582: Set -fstack-protector when building with clang Message-ID: 8348582: Set -fstack-protector when building with clang ------------- Commit messages: - Backport fe6d9ab951cb84d1161aee781af2d93edaac3595 Changes: https://git.openjdk.org/jdk24u/pull/59/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=59&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348582 Stats: 15 lines in 1 file changed: 6 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk24u/pull/59.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/59/head:pull/59 PR: https://git.openjdk.org/jdk24u/pull/59 From sgehwolf at openjdk.org Fri Feb 7 12:46:17 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 7 Feb 2025 12:46:17 GMT Subject: [jdk21u-dev] RFR: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates In-Reply-To: <0SXRA26DNGEAUbp6nl-hP7RTNQwpQ0VDrG7cATsIuUM=.ae8cb8f1-a934-4c10-94a6-8ebfd91c7d30@github.com> References: <0SXRA26DNGEAUbp6nl-hP7RTNQwpQ0VDrG7cATsIuUM=.ae8cb8f1-a934-4c10-94a6-8ebfd91c7d30@github.com> Message-ID: On Thu, 6 Feb 2025 21:10:48 GMT, Christoph Langer wrote: > Bumps the GHA JDKs. Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1389#pullrequestreview-2601638707 From jkratochvil at azul.com Fri Feb 7 13:13:53 2025 From: jkratochvil at azul.com (Jan Kratochvil) Date: Fri, 7 Feb 2025 21:13:53 +0800 Subject: [21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected In-Reply-To: <1e30742239badd10d071ed9f5d591763a92a1990.camel@redhat.com> References: <1e30742239badd10d071ed9f5d591763a92a1990.camel@redhat.com> Message-ID: On Mon, 20 Jan 2025 17:58:01 +0800, Severin Gehwolf wrote: > You didn't say *why* you'd like to backport it https://bugs.openjdk.org/browse/JDK-8322420 The following text is based on: https://mail.openjdk.org/pipermail/jdk-updates-dev/2022-February/012398.html cgroups v2 support hierarchical groups. Limits from outer groups apply also for the inner groups. To calculate an effective limit for the current nested group one needs to calculate a minimum of all the limits in the current group and its parent groups up to the root one. The risk of NOT backporting those patches is that the JVM would wrongly detect resource limits. Container detection code would just give up early and would use the host systems' resource limits instead. Random OOM kills and other strange behaviour can happen. As the code is the same in 21u as in 24u and all the backports are clean I do not expect regressions. ------------------------------------------------------------------------------ I would like to backport: https://bugs.openjdk.org/browse/JDK-8322420 [Linux] cgroup v2: Limits in parent nested control groups are not detected The whole patchset in a chronological order (the reverse of `git log`): - Print 'rss' and 'cache' as part of the container information 9 files changed, 46 insertions(+), 1 deletion(-) - Record total and free swap space in JFR 11 files changed, 178 insertions(+), 1 deletion(-) - JFR SwapSpace event - add free swap space information on Linux when running in a container environment 9 files changed, 101 insertions(+), 10 deletions(-) - Replace NULL with nullptr in HotSpot gtests patch reduced only to files: - test/hotspot/gtest/runtime/test_os_linux_cgroups.cpp 1 file changed, 2 insertions(+), 2 deletions(-) - Several methods in hotspot are missing "static" patch reduced only to files: - test/hotspot/gtest/os/linux/test_cgroupSubsystem_linux.cpp 1 file changed, 5 insertions(+), 5 deletions(-) - [Testbug] g-tests for cgroup leave files in /tmp on linux 1 file changed, 10 insertions(+), 1 deletion(-) - Refactor Hotspot container detection code 10 files changed, 862 insertions(+), 590 deletions(-) - Linux Alpine build fails after 8302744 1 file changed, 9 insertions(+), 5 deletions(-) - [Linux] OSContainer::is_containerized() returns true when run outside a container 18 files changed, 290 insertions(+), 63 deletions(-) - src/java.base/linux/native/libjava/CgroupMetrics.c:42:(.text+0x11): undefined reference to `JVM_IsContainerized' a patch by Yuri Nesterenko, it is not needed in recent JDKs due to 1 file changed, 1 insertion(+) - Refactor Hotspot container detection code so that subsystem delegates to controllers 8 files changed, 511 insertions(+), 264 deletions(-) - Compile error in cgroup code on Linux when using clang 2 files changed, 5 insertions(+), 5 deletions(-) - Make os::Linux::active_processor_count() public unclean but obvious 1 file changed, 1 insertion(+), 3 deletions(-) - [Linux] cgroup v2: Limits in parent nested control groups are not detected 9 files changed, 362 insertions(+), 111 deletions(-) - JFR SwapSpace event might read wrong free swap space size 1 file changed, 4 insertions(+), 1 deletion(-) Whether they are all needed? They are 3 kinds of pre-requisite patches: * non-trivial functionality required by later patches * trivial fix-ups which make the later applied patches clean * trivial fix-ups of previously applied patch For easier checking of the backport it is also available at: https://github.com/jankratochvil/jdk21u-dev/tree/devmaster-cgroup2 If pre-approved I need to submit those patches as separate backports. I find the April release as the suitable one. Thanks, Jan Kratochvil From syan at openjdk.org Fri Feb 7 15:18:19 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 7 Feb 2025 15:18:19 GMT Subject: [jdk24u] RFR: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError In-Reply-To: References: Message-ID: <3914MbiJpShhTGdIfNzU1YWolqCUqREc4c9S6nEWudI=.2b8e019b-5f9d-4945-b890-8f4e4448ceef@github.com> On Wed, 5 Feb 2025 07:48:51 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [4d8fb807](https://github.com/openjdk/jdk/commit/4d8fb80732fd17352c36254c6dfc1be5dbfbacf1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backport fix the JMH test bug which report "NoClassDefFoundError" fails, test-fix only, no risk. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/47#issuecomment-2643215232 From syan at openjdk.org Fri Feb 7 15:18:19 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 7 Feb 2025 15:18:19 GMT Subject: [jdk24u] Integrated: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError In-Reply-To: References: Message-ID: On Wed, 5 Feb 2025 07:48:51 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [4d8fb807](https://github.com/openjdk/jdk/commit/4d8fb80732fd17352c36254c6dfc1be5dbfbacf1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backport fix the JMH test bug which report "NoClassDefFoundError" fails, test-fix only, no risk. > > Thanks! This pull request has now been integrated. Changeset: f1b1fd4d Author: SendaoYan URL: https://git.openjdk.org/jdk24u/commit/f1b1fd4d7b5f44eac5be7e1e4f7f184eea1e75c1 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError Backport-of: 4d8fb80732fd17352c36254c6dfc1be5dbfbacf1 ------------- PR: https://git.openjdk.org/jdk24u/pull/47 From duke at openjdk.org Fri Feb 7 15:20:18 2025 From: duke at openjdk.org (duke) Date: Fri, 7 Feb 2025 15:20:18 GMT Subject: [jdk24u] RFR: 8346705: SNI not sent with Java 22+ using java.net.http.HttpClient.Builder#sslParameters In-Reply-To: References: Message-ID: On Wed, 5 Feb 2025 14:15:49 GMT, kieran-farrell wrote: > @coffeys > > Backport applied cleanly with all tests passing @kieran-farrell Your change (at version e793aa7fe2f2934afc3f438500f49ae054cb083b) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/54#issuecomment-2643224774 From duke at openjdk.org Fri Feb 7 15:45:20 2025 From: duke at openjdk.org (kieran-farrell) Date: Fri, 7 Feb 2025 15:45:20 GMT Subject: [jdk24u] Integrated: 8346705: SNI not sent with Java 22+ using java.net.http.HttpClient.Builder#sslParameters In-Reply-To: References: Message-ID: On Wed, 5 Feb 2025 14:15:49 GMT, kieran-farrell wrote: > @coffeys > > Backport applied cleanly with all tests passing This pull request has now been integrated. Changeset: 9e811f1a Author: kieran_farrell Committer: Sean Coffey URL: https://git.openjdk.org/jdk24u/commit/9e811f1a476c819842b2375b84776963021214ed Stats: 268 lines in 3 files changed: 256 ins; 0 del; 12 mod 8346705: SNI not sent with Java 22+ using java.net.http.HttpClient.Builder#sslParameters Backport-of: 72f1114909854aaed5d190d1c74a98527600a0c2 ------------- PR: https://git.openjdk.org/jdk24u/pull/54 From syan at openjdk.org Fri Feb 7 15:49:48 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 7 Feb 2025 15:49:48 GMT Subject: [jdk24u] RFR: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk Message-ID: Hi all, This pull request contains a backport of commit [4e0ffda5](https://github.com/openjdk/jdk/commit/4e0ffda5b1d82449d2d6f639be7641b69d6cb520) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to jdk24u. This backport make test more rubustness, test-fix only, no risk. Thanks! ------------- Commit messages: - Backport 4e0ffda5b1d82449d2d6f639be7641b69d6cb520 Changes: https://git.openjdk.org/jdk24u/pull/60/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=60&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346972 Stats: 10 lines in 1 file changed: 5 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk24u/pull/60.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/60/head:pull/60 PR: https://git.openjdk.org/jdk24u/pull/60 From syan at openjdk.org Fri Feb 7 16:16:02 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 7 Feb 2025 16:16:02 GMT Subject: [jdk24u] RFR: 8347171: (dc) java/nio/channels/DatagramChannel/InterruptibleOrNot.java fails with virtual thread factory Message-ID: Hi all, This pull request contains a backport of commit [1ef77cdd](https://github.com/openjdk/jdk/commit/1ef77cdd51b91f6d6d3367444a37a3f0f2e4bc99) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to jdk24u. This backport make test more robustness, test-fix only, no risk, Thanks! ------------- Commit messages: - Backport 1ef77cdd51b91f6d6d3367444a37a3f0f2e4bc99 Changes: https://git.openjdk.org/jdk24u/pull/61/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=61&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347171 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk24u/pull/61.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/61/head:pull/61 PR: https://git.openjdk.org/jdk24u/pull/61 From syan at openjdk.org Fri Feb 7 16:24:51 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 7 Feb 2025 16:24:51 GMT Subject: [jdk24u] RFR: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless Message-ID: Hi all, This pull request contains a backport of commit [e7e8f60c](https://github.com/openjdk/jdk/commit/e7e8f60c9bedd5622525cc4339300b438eedc9fd) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to jdk24u. Test test/jdk/tools/jimage/JImageToolTest.java ignore vm flags and should be marked as flagless. Test-fix only, no risk. Thanks! ------------- Commit messages: - Backport e7e8f60c9bedd5622525cc4339300b438eedc9fd Changes: https://git.openjdk.org/jdk24u/pull/62/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=62&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347302 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk24u/pull/62.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/62/head:pull/62 PR: https://git.openjdk.org/jdk24u/pull/62 From syan at openjdk.org Fri Feb 7 16:34:17 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 7 Feb 2025 16:34:17 GMT Subject: [jdk24u] RFR: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position Message-ID: <-HSEo8_b2dVDj85Fqgp1DUnL3zUT6fgqVnqQzCbXavk=.92bc88e0-2794-4d1e-99da-7daf4bb23c30@github.com> Hi all, This pull request contains a backport of commit [d562d3c7](https://github.com/openjdk/jdk/commit/d562d3c7a9e1e857c095ef908b0957b033972949) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Clean backport to fix the test bug which may cause test can not catch the expected failure, test-fix only, no risk. Thanks! ------------- Commit messages: - Backport d562d3c7a9e1e857c095ef908b0957b033972949 Changes: https://git.openjdk.org/jdk24u/pull/63/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=63&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343882 Stats: 18 lines in 1 file changed: 5 ins; 4 del; 9 mod Patch: https://git.openjdk.org/jdk24u/pull/63.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/63/head:pull/63 PR: https://git.openjdk.org/jdk24u/pull/63 From duke at openjdk.org Fri Feb 7 23:01:15 2025 From: duke at openjdk.org (duke) Date: Fri, 7 Feb 2025 23:01:15 GMT Subject: [jdk24u] RFR: 8349002: GenShen: Deadlock during shutdown In-Reply-To: References: Message-ID: On Wed, 5 Feb 2025 20:08:24 GMT, William Kemper wrote: > Clean backport. Fixes bug recently introduced by [JDK-8345970](https://bugs.openjdk.org/browse/JDK-8345970). @earthling-amzn Your change (at version e2469e96a505e12a11bd0e50e20e05d4f55cbd66) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/56#issuecomment-2644280676 From clanger at openjdk.org Sun Feb 9 12:23:16 2025 From: clanger at openjdk.org (Christoph Langer) Date: Sun, 9 Feb 2025 12:23:16 GMT Subject: [jdk21u-dev] Integrated: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates In-Reply-To: <0SXRA26DNGEAUbp6nl-hP7RTNQwpQ0VDrG7cATsIuUM=.ae8cb8f1-a934-4c10-94a6-8ebfd91c7d30@github.com> References: <0SXRA26DNGEAUbp6nl-hP7RTNQwpQ0VDrG7cATsIuUM=.ae8cb8f1-a934-4c10-94a6-8ebfd91c7d30@github.com> Message-ID: On Thu, 6 Feb 2025 21:10:48 GMT, Christoph Langer wrote: > Bumps the GHA JDKs. This pull request has now been integrated. Changeset: 9c8fe67a Author: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/9c8fe67afff3a275c2e5944e996ce3f32ae53b37 Stats: 14 lines in 1 file changed: 4 ins; 4 del; 6 mod 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates Reviewed-by: mbaesken, sgehwolf ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1389 From duke at openjdk.org Mon Feb 10 01:46:25 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Mon, 10 Feb 2025 01:46:25 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v4] In-Reply-To: References: Message-ID: On Thu, 6 Feb 2025 09:31:00 GMT, Andrew Haley wrote: >> What do you see? >> >> $ pwd >> /local/jdk11u-dev/test/jdk/sun/security/pkcs11/fips >> $ /usr/lib64/nss/unsupported-tools/dbtool -d . >> dbdir selected is . >> >> CertDB: >> KeyDB: > >> @theRealAph >> >> > Why are the two sets of files key4.db and cert9.db different? >> >> The reason key4.db and cert9.db are different is that they are newly created by me using the "modutil" command. I created them with reference to [jdk/test/jdk/sun/security/pkcs11/Secmod/README-SQLITE](https://github.com/openjdk/jdk/blob/ac82a8f89c7066fb1d379b12bcfd68053cb39ba4/test/jdk/sun/security/pkcs11/Secmod/README-SQLITE) and manually copied pkcs11.txt from [jdk/test/jdk/sun/security/pkcs11/Secmod/pkcs11.txt](https://github.com/openjdk/jdk/blob/f0b251d76078e8d5b47e967b0449c4cbdcb5a005/test/jdk/sun/security/pkcs11/Secmod/pkcs11.txt). However, after receiving your comment, I realized that the README-SQLITE procedure does not correspond to the contents of pkcs11.txt. So I recreated key4.db ,cert9.db and pkcs11.txt using the following steps: > > OK, that's better. Thanks. @theRealAph Thank you for checking. If there is no problem, could you approve? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2955#issuecomment-2646743416 From sshivang at openjdk.org Mon Feb 10 06:33:55 2025 From: sshivang at openjdk.org (Shivangi Gupta) Date: Mon, 10 Feb 2025 06:33:55 GMT Subject: [jdk24u] RFR: 8344316: security/auth/callback/TextCallbackHandler/Password.java make runnable with JTReg and add the UI Message-ID: Straight Backport. Needed in lower releases too. Test passed ------------- Commit messages: - Backport 82bc0a7f8c7ee63d2f8c3db57dc22f39963ae022 Changes: https://git.openjdk.org/jdk24u/pull/64/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=64&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344316 Stats: 120 lines in 1 file changed: 98 ins; 15 del; 7 mod Patch: https://git.openjdk.org/jdk24u/pull/64.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/64/head:pull/64 PR: https://git.openjdk.org/jdk24u/pull/64 From thartmann at openjdk.org Mon Feb 10 08:12:57 2025 From: thartmann at openjdk.org (Tobias Hartmann) Date: Mon, 10 Feb 2025 08:12:57 GMT Subject: [jdk24u] RFR: 8347718: Unexpected NullPointerException in C2 compiled code due to ReduceAllocationMerges Message-ID: Hi all, This pull request contains a backport of commit [9f4d3de4](https://github.com/openjdk/jdk/commit/9f4d3de442a846c503dac52de4a757e5b5638e73) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Cesar Soares Lucas on 28 Jan 2025 and was reviewed by Vladimir Kozlov and Tobias Hartmann. Thanks! ------------- Commit messages: - Backport 9f4d3de442a846c503dac52de4a757e5b5638e73 Changes: https://git.openjdk.org/jdk24u/pull/65/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=65&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347718 Stats: 74 lines in 2 files changed: 71 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk24u/pull/65.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/65/head:pull/65 PR: https://git.openjdk.org/jdk24u/pull/65 From chagedorn at openjdk.org Mon Feb 10 08:46:58 2025 From: chagedorn at openjdk.org (Christian Hagedorn) Date: Mon, 10 Feb 2025 08:46:58 GMT Subject: [jdk24u] RFR: 8347018: C2: Insertion of Assertion Predicates ignores the effects of PhaseIdealLoop::clone_up_backedge_goo() Message-ID: Hi all, This pull request contains a backport of commit [8a83dc21](https://github.com/openjdk/jdk/commit/8a83dc213ac630ec79d62637133fe7aa102a27a3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Christian Hagedorn on 20 Jan 2025 and was reviewed by Emanuel Peter and Vladimir Kozlov. Applied cleanly except for a copyright merging issue in `predicates.hpp`. Thanks! ------------- Commit messages: - Backport 8a83dc213ac630ec79d62637133fe7aa102a27a3 Changes: https://git.openjdk.org/jdk24u/pull/66/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=66&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347018 Stats: 181 lines in 5 files changed: 155 ins; 13 del; 13 mod Patch: https://git.openjdk.org/jdk24u/pull/66.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/66/head:pull/66 PR: https://git.openjdk.org/jdk24u/pull/66 From aph at openjdk.org Mon Feb 10 09:53:25 2025 From: aph at openjdk.org (Andrew Haley) Date: Mon, 10 Feb 2025 09:53:25 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v4] In-Reply-To: References: Message-ID: On Thu, 6 Feb 2025 09:31:00 GMT, Andrew Haley wrote: >> What do you see? >> >> $ pwd >> /local/jdk11u-dev/test/jdk/sun/security/pkcs11/fips >> $ /usr/lib64/nss/unsupported-tools/dbtool -d . >> dbdir selected is . >> >> CertDB: >> KeyDB: > >> @theRealAph >> >> > Why are the two sets of files key4.db and cert9.db different? >> >> The reason key4.db and cert9.db are different is that they are newly created by me using the "modutil" command. I created them with reference to [jdk/test/jdk/sun/security/pkcs11/Secmod/README-SQLITE](https://github.com/openjdk/jdk/blob/ac82a8f89c7066fb1d379b12bcfd68053cb39ba4/test/jdk/sun/security/pkcs11/Secmod/README-SQLITE) and manually copied pkcs11.txt from [jdk/test/jdk/sun/security/pkcs11/Secmod/pkcs11.txt](https://github.com/openjdk/jdk/blob/f0b251d76078e8d5b47e967b0449c4cbdcb5a005/test/jdk/sun/security/pkcs11/Secmod/pkcs11.txt). However, after receiving your comment, I realized that the README-SQLITE procedure does not correspond to the contents of pkcs11.txt. So I recreated key4.db ,cert9.db and pkcs11.txt using the following steps: > > OK, that's better. Thanks. > @theRealAph > > Thank you for checking. If there is no problem, could you approve? There's no need. You already have one review. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2955#issuecomment-2647470473 From adinn at openjdk.org Mon Feb 10 12:28:23 2025 From: adinn at openjdk.org (Andrew Dinn) Date: Mon, 10 Feb 2025 12:28:23 GMT Subject: [jdk21u-dev] RFR: 8180450: secondary_super_cache does not scale well In-Reply-To: <4LeEOVL3OM57vpgMH9YTOBgyGCucK3L6iWC0XGD60ZQ=.10c0f7c0-897d-45ec-b105-5c4467890d74@github.com> References: <4LeEOVL3OM57vpgMH9YTOBgyGCucK3L6iWC0XGD60ZQ=.10c0f7c0-897d-45ec-b105-5c4467890d74@github.com> Message-ID: On Thu, 24 Oct 2024 10:10:45 GMT, Andrew Haley wrote: > See [8180450](https://github.com/openjdk/jdk/pull/18309) for a full description of how this works. > This is a pretty clean backport, but a few files had to be fiddled manually because things had been added nearby. > > This PR also includes a fix for [[8337958](https://bugs.openjdk.org/browse/JDK-8337958)](https://bugs.openjdk.org/browse/JDK-8337958), which was a minor bug in the original commit. > > For a justification of why this PR should be backported to JDK 21u, see > [Franz's email](https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-October/038649.html). Backport looks ok to me modulo a couple of questions. n.b. I agree this is sorely needed for jdk21u and earlier releases src/hotspot/share/cds/filemap.cpp line 293: > 291: st->print_cr("- cloned_vtables_offset: " SIZE_FORMAT_X, _cloned_vtables_offset); > 292: st->print_cr("- serialized_data_offset: " SIZE_FORMAT_X, _serialized_data_offset); > 293: st->print_cr("- heap_begin: " INTPTR_FORMAT, p2i(_heap_begin)); The upstream patch added the following sanity check at line 2425 (equivalent to line 2411 in the 21u version): if (! _use_secondary_supers_table && UseSecondarySupersTable) { log_warning(cds)("The shared archive was created without UseSecondarySupersTable."); return false; } Is there a reason why it has been omitted from this patch? test/micro/org/openjdk/bench/vm/lang/SecondarySupersLookup.java line 1: > 1: /* Could you comment on why only this one test is being back-ported? ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1090#pullrequestreview-2605545538 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1090#discussion_r1948928978 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1090#discussion_r1948963613 From kvn at openjdk.org Mon Feb 10 15:06:20 2025 From: kvn at openjdk.org (Vladimir Kozlov) Date: Mon, 10 Feb 2025 15:06:20 GMT Subject: [jdk24u] RFR: 8347018: C2: Insertion of Assertion Predicates ignores the effects of PhaseIdealLoop::clone_up_backedge_goo() In-Reply-To: References: Message-ID: On Mon, 10 Feb 2025 08:41:20 GMT, Christian Hagedorn wrote: > Hi all, > > This pull request contains a backport of commit [8a83dc21](https://github.com/openjdk/jdk/commit/8a83dc213ac630ec79d62637133fe7aa102a27a3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Christian Hagedorn on 20 Jan 2025 and was reviewed by Emanuel Peter and Vladimir Kozlov. > > Applied cleanly except for a copyright merging issue in `predicates.hpp`. > > Thanks! Approved since is is not completely clean backport (copyright line). ------------- Marked as reviewed by kvn (Reviewer). PR Review: https://git.openjdk.org/jdk24u/pull/66#pullrequestreview-2606133200 From goetz at openjdk.org Mon Feb 10 15:43:43 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 10 Feb 2025 15:43:43 GMT Subject: [jdk21u-dev] RFR: 8302111: Serialization considerations Message-ID: I think this is a valuable fix we need in 21. It secures deserialized data. The code needed some resolves, but overall the change of head fits well on the code in 21. In detail: I resolved src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java and src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java. It does not apply as these changes are missing in 21: 8311170: Simplify and modernize equals and hashCode in security area 8315974: Make fields final in 'com.sun.crypto.provider' package In both files I resolved one larger chunk. Some removed code is different: * Initialization of this.l removed in original. Initialization not in 21. * head has some coding initializing this.x/y. This is handled by a call to parseKeyBits in 21. Both files have similar differences between head and 21. In src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBError.java, changes 8327818: Implement Kerberos debug with sun.security.util.Debug and again 8311170: Simplify and modernize equals and hashCode in security area are missing in 21. This only requires trivial resolves due to context differences. I based this backport on the commit to head. The commit to 22.0.2 is identical to that, except that it skips two unnecessary empty lines in KRBError.java. I rather go with the head version as this will make further backports fit better. ------------- Commit messages: - Backport 369c573383a0120e0d85aeb89a211f38b5261013 Changes: https://git.openjdk.org/jdk21u-dev/pull/1391/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1391&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302111 Stats: 1026 lines in 21 files changed: 567 ins; 279 del; 180 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1391.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1391/head:pull/1391 PR: https://git.openjdk.org/jdk21u-dev/pull/1391 From syan at openjdk.org Mon Feb 10 15:47:21 2025 From: syan at openjdk.org (SendaoYan) Date: Mon, 10 Feb 2025 15:47:21 GMT Subject: [jdk24u] RFR: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless In-Reply-To: References: Message-ID: <9PqvjRo7bjBB5ng7Qb-vTKzQKjxobmFc-wG5chHikJU=.834df473-7fe1-4b99-a1d8-a149ae4f1f2c@github.com> On Fri, 7 Feb 2025 16:20:39 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [e7e8f60c](https://github.com/openjdk/jdk/commit/e7e8f60c9bedd5622525cc4339300b438eedc9fd) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to jdk24u. > > Test test/jdk/tools/jimage/JImageToolTest.java ignore vm flags and should be marked as flagless. Test-fix only, no risk. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/62#issuecomment-2648446082 From syan at openjdk.org Mon Feb 10 15:47:21 2025 From: syan at openjdk.org (SendaoYan) Date: Mon, 10 Feb 2025 15:47:21 GMT Subject: [jdk24u] Integrated: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless In-Reply-To: References: Message-ID: On Fri, 7 Feb 2025 16:20:39 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [e7e8f60c](https://github.com/openjdk/jdk/commit/e7e8f60c9bedd5622525cc4339300b438eedc9fd) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to jdk24u. > > Test test/jdk/tools/jimage/JImageToolTest.java ignore vm flags and should be marked as flagless. Test-fix only, no risk. > > Thanks! This pull request has now been integrated. Changeset: aa7b3df3 Author: SendaoYan URL: https://git.openjdk.org/jdk24u/commit/aa7b3df3c691f74acb036f869d34ac43ecf403b6 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8347302: Mark test tools/jimage/JImageToolTest.java as flagless Backport-of: e7e8f60c9bedd5622525cc4339300b438eedc9fd ------------- PR: https://git.openjdk.org/jdk24u/pull/62 From duke at openjdk.org Mon Feb 10 15:48:20 2025 From: duke at openjdk.org (duke) Date: Mon, 10 Feb 2025 15:48:20 GMT Subject: [jdk24u] RFR: 8344316: security/auth/callback/TextCallbackHandler/Password.java make runnable with JTReg and add the UI In-Reply-To: References: Message-ID: On Mon, 10 Feb 2025 06:26:54 GMT, Shivangi Gupta wrote: > Straight Backport. Needed in lower releases too. Test passed @Shivangi-aa Your change (at version 68f3ebb9e00d41be04ac558179fef762fb268df1) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/64#issuecomment-2648451420 From sshivang at openjdk.org Mon Feb 10 16:03:11 2025 From: sshivang at openjdk.org (Shivangi Gupta) Date: Mon, 10 Feb 2025 16:03:11 GMT Subject: [jdk24u] Integrated: 8344316: security/auth/callback/TextCallbackHandler/Password.java make runnable with JTReg and add the UI In-Reply-To: References: Message-ID: On Mon, 10 Feb 2025 06:26:54 GMT, Shivangi Gupta wrote: > Straight Backport. Needed in lower releases too. Test passed This pull request has now been integrated. Changeset: 0397f98a Author: Shivangi Gupta Committer: Sean Coffey URL: https://git.openjdk.org/jdk24u/commit/0397f98a432cd4e2d05a6f80bd7e7b8a12615e0c Stats: 120 lines in 1 file changed: 98 ins; 15 del; 7 mod 8344316: security/auth/callback/TextCallbackHandler/Password.java make runnable with JTReg and add the UI Backport-of: 82bc0a7f8c7ee63d2f8c3db57dc22f39963ae022 ------------- PR: https://git.openjdk.org/jdk24u/pull/64 From wkemper at openjdk.org Mon Feb 10 17:50:19 2025 From: wkemper at openjdk.org (William Kemper) Date: Mon, 10 Feb 2025 17:50:19 GMT Subject: [jdk24u] Integrated: 8349002: GenShen: Deadlock during shutdown In-Reply-To: References: Message-ID: <_FuM0vQkIShH7II5CU-gbYZ-LQAZLoCYmREETKzQRxc=.6ccebdf4-b67e-48c7-9df9-98953c4bbd2e@github.com> On Wed, 5 Feb 2025 20:08:24 GMT, William Kemper wrote: > Clean backport. Fixes bug recently introduced by [JDK-8345970](https://bugs.openjdk.org/browse/JDK-8345970). This pull request has now been integrated. Changeset: 72f23f09 Author: William Kemper Committer: Paul Hohensee URL: https://git.openjdk.org/jdk24u/commit/72f23f094bba2cafd219521da06e5aefca4edd7d Stats: 5 lines in 2 files changed: 4 ins; 0 del; 1 mod 8349002: GenShen: Deadlock during shutdown Backport-of: 06ebb170bac3879dc1e378b48b1c7ef006070c86 ------------- PR: https://git.openjdk.org/jdk24u/pull/56 From ssubramaniam at openjdk.org Mon Feb 10 19:57:22 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Mon, 10 Feb 2025 19:57:22 GMT Subject: [jdk11u-dev] RFR: 8346887: DrawFocusRect() may cause an assertion failure In-Reply-To: References: Message-ID: On Fri, 10 Jan 2025 04:36:56 GMT, Satyen Subramaniam wrote: > Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is nearly clean (adjusting comment). Ran headful and headless `jdk_desktop` tests locally - all passing/not regressing. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2985#issuecomment-2649092326 From cslucas at openjdk.org Mon Feb 10 20:33:15 2025 From: cslucas at openjdk.org (Cesar Soares Lucas) Date: Mon, 10 Feb 2025 20:33:15 GMT Subject: [jdk24u] RFR: 8347718: Unexpected NullPointerException in C2 compiled code due to ReduceAllocationMerges In-Reply-To: References: Message-ID: On Mon, 10 Feb 2025 08:07:01 GMT, Tobias Hartmann wrote: > Hi all, > > This pull request contains a backport of commit [9f4d3de4](https://github.com/openjdk/jdk/commit/9f4d3de442a846c503dac52de4a757e5b5638e73) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Cesar Soares Lucas on 28 Jan 2025 and was reviewed by Vladimir Kozlov and Tobias Hartmann. > > Thanks! Thank you. LGTM ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/65#issuecomment-2649165391 From abakhtin at openjdk.org Mon Feb 10 20:42:11 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 10 Feb 2025 20:42:11 GMT Subject: [jdk21u-dev] RFR: 8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java In-Reply-To: <-nEcg8S-8Gw8WKSzR1--2V_PTZWVVpJ2M_p2UFgZ0fI=.f2e0b59b-3fb4-4e17-a1a9-b4ce6a04c058@github.com> References: <-nEcg8S-8Gw8WKSzR1--2V_PTZWVVpJ2M_p2UFgZ0fI=.f2e0b59b-3fb4-4e17-a1a9-b4ce6a04c058@github.com> Message-ID: On Sat, 21 Dec 2024 04:14:39 GMT, Jan Kratochvil wrote: > Only `TestPLABAdaptToMinTLABSize.java` is a clean backport. > `TestPinnedHumongousFragmentation.java` and `TestPinnedObjectContents.java` did not exist in JDK 21. Marked as reviewed by abakhtin (Reviewer). TestPLABAdaptToMinTLABSize.java is a clean backport from JDK24 TestPinnedHumongousFragmentation.java?and?TestPinnedObjectContents.java were added as part of the JDK-8318706: "Implement JEP 423: Region Pinning for G1". No plans to backport it to JDK21u LGTM ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1277#pullrequestreview-2607106040 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1277#issuecomment-2649182044 From andrew at openjdk.org Mon Feb 10 21:05:19 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 10 Feb 2025 21:05:19 GMT Subject: [jdk21u-dev] RFR: 8302111: Serialization considerations In-Reply-To: References: Message-ID: On Mon, 10 Feb 2025 15:38:07 GMT, Goetz Lindenmaier wrote: > I think this is a valuable fix we need in 21. It secures deserialized data. > > The code needed some resolves, but overall the change of > head fits well on the code in 21. In detail: > > I resolved > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java and > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java. > It does not apply as these changes are missing in 21: > 8311170: Simplify and modernize equals and hashCode in security area > 8315974: Make fields final in 'com.sun.crypto.provider' package > Both files have similar differences between head and 21: > In both files I resolved one larger chunk. Some of the removed code is different: > * Initialization of this.l removed in original. This initialization is not in 21. > * head has some coding initializing this.x/y. This is handled by a call to > parseKeyBits() in 21, which executes similar code. > The new code is the same as in head. > > In src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBError.java, changes > 8327818: Implement Kerberos debug with sun.security.util.Debug and again > 8311170: Simplify and modernize equals and hashCode in security area > are missing in 21. > This only requires trivial resolves due to context differences. > > I based this backport on the commit to head. > The commit to 22.0.2 is identical to that, except that it skips > two unnecessary empty lines in KRBError.java. I rather go > with the head version as this will make further backports > fit better. > > This passed our nightly testing which includes the tests for the security implementations. > We run headless tier 1-4 on 8 platform with fastdebug, jck and further internal tests. Backport mostly looks good. The initialisation differences for `l`, `x` and `y` are also from JDK-8315974: "Make fields final in 'com.sun.crypto.provider' package". I presume, because the fields were now final, there could not be code paths that didn't initialise `l` and the initialisation of `x` and `y` could no longer be delegated to `parseKeyBits`. On the subject of `parseKeyBits`, I think this method can now be removed, as it is in JDK-8315974. It is a private method that I don't see being called from anywhere else in those files. ------------- Changes requested by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1391#pullrequestreview-2607161182 From syan at openjdk.org Tue Feb 11 02:15:32 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Feb 2025 02:15:32 GMT Subject: [jdk21u-dev] RFR: 8339834: Replace usages of -mx and -ms in some tests Message-ID: Hi all, This pull request contains a backport of commit [1d392492](https://github.com/openjdk/jdk/commit/1d392492311daceeae12769cb9494eae63289853) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jaikiran Pai on 12 Sep 2024 and was reviewed by Alexey Ivanov, Anthony Scarpino, Phil Race and David Holmes. Thanks! ------------- Commit messages: - Backport 1d392492311daceeae12769cb9494eae63289853 Changes: https://git.openjdk.org/jdk21u-dev/pull/1392/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1392&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339834 Stats: 22 lines in 9 files changed: 0 ins; 5 del; 17 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1392.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1392/head:pull/1392 PR: https://git.openjdk.org/jdk21u-dev/pull/1392 From syan at openjdk.org Tue Feb 11 02:23:14 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Feb 2025 02:23:14 GMT Subject: [jdk21u-dev] RFR: 8339834: Replace usages of -mx and -ms in some tests In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 02:09:27 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [1d392492](https://github.com/openjdk/jdk/commit/1d392492311daceeae12769cb9494eae63289853) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 12 Sep 2024 and was reviewed by Alexey Ivanov, Anthony Scarpino, Phil Race and David Holmes. > > Thanks! This backport PR will make backport [JDK-8347302](https://bugs.openjdk.org/browse/JDK-8347302) cleanly. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1392#issuecomment-2649666829 From syan at openjdk.org Tue Feb 11 03:12:17 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Feb 2025 03:12:17 GMT Subject: [jdk24u] RFR: 8347171: (dc) java/nio/channels/DatagramChannel/InterruptibleOrNot.java fails with virtual thread factory In-Reply-To: References: Message-ID: On Fri, 7 Feb 2025 16:10:49 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [1ef77cdd](https://github.com/openjdk/jdk/commit/1ef77cdd51b91f6d6d3367444a37a3f0f2e4bc99) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to jdk24u. > > This backport make test more robustness, test-fix only, no risk, > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/61#issuecomment-2649710084 From syan at openjdk.org Tue Feb 11 03:12:18 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Feb 2025 03:12:18 GMT Subject: [jdk24u] Integrated: 8347171: (dc) java/nio/channels/DatagramChannel/InterruptibleOrNot.java fails with virtual thread factory In-Reply-To: References: Message-ID: On Fri, 7 Feb 2025 16:10:49 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [1ef77cdd](https://github.com/openjdk/jdk/commit/1ef77cdd51b91f6d6d3367444a37a3f0f2e4bc99) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to jdk24u. > > This backport make test more robustness, test-fix only, no risk, > > Thanks! This pull request has now been integrated. Changeset: 687ea73b Author: SendaoYan URL: https://git.openjdk.org/jdk24u/commit/687ea73b00fd047305bfa1dda8187276bfb68dbf Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8347171: (dc) java/nio/channels/DatagramChannel/InterruptibleOrNot.java fails with virtual thread factory Backport-of: 1ef77cdd51b91f6d6d3367444a37a3f0f2e4bc99 ------------- PR: https://git.openjdk.org/jdk24u/pull/61 From syan at openjdk.org Tue Feb 11 03:14:16 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Feb 2025 03:14:16 GMT Subject: [jdk24u] RFR: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position In-Reply-To: <-HSEo8_b2dVDj85Fqgp1DUnL3zUT6fgqVnqQzCbXavk=.92bc88e0-2794-4d1e-99da-7daf4bb23c30@github.com> References: <-HSEo8_b2dVDj85Fqgp1DUnL3zUT6fgqVnqQzCbXavk=.92bc88e0-2794-4d1e-99da-7daf4bb23c30@github.com> Message-ID: On Fri, 7 Feb 2025 16:29:16 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [d562d3c7](https://github.com/openjdk/jdk/commit/d562d3c7a9e1e857c095ef908b0957b033972949) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Clean backport to fix the test bug which may cause test can not catch the expected failure, test-fix only, no risk. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/63#issuecomment-2649713171 From syan at openjdk.org Tue Feb 11 03:14:17 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Feb 2025 03:14:17 GMT Subject: [jdk24u] Integrated: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position In-Reply-To: <-HSEo8_b2dVDj85Fqgp1DUnL3zUT6fgqVnqQzCbXavk=.92bc88e0-2794-4d1e-99da-7daf4bb23c30@github.com> References: <-HSEo8_b2dVDj85Fqgp1DUnL3zUT6fgqVnqQzCbXavk=.92bc88e0-2794-4d1e-99da-7daf4bb23c30@github.com> Message-ID: On Fri, 7 Feb 2025 16:29:16 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [d562d3c7](https://github.com/openjdk/jdk/commit/d562d3c7a9e1e857c095ef908b0957b033972949) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Clean backport to fix the test bug which may cause test can not catch the expected failure, test-fix only, no risk. > > Thanks! This pull request has now been integrated. Changeset: 46b39279 Author: SendaoYan URL: https://git.openjdk.org/jdk24u/commit/46b3927985e220ee756c0a8384d5628c28a11457 Stats: 18 lines in 1 file changed: 5 ins; 4 del; 9 mod 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position Backport-of: d562d3c7a9e1e857c095ef908b0957b033972949 ------------- PR: https://git.openjdk.org/jdk24u/pull/63 From syan at openjdk.org Tue Feb 11 03:14:20 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Feb 2025 03:14:20 GMT Subject: [jdk24u] RFR: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk In-Reply-To: References: Message-ID: On Fri, 7 Feb 2025 15:44:33 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [4e0ffda5](https://github.com/openjdk/jdk/commit/4e0ffda5b1d82449d2d6f639be7641b69d6cb520) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to jdk24u. This backport make test more rubustness, test-fix only, no risk. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/60#issuecomment-2649712769 From syan at openjdk.org Tue Feb 11 03:14:20 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Feb 2025 03:14:20 GMT Subject: [jdk24u] Integrated: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk In-Reply-To: References: Message-ID: On Fri, 7 Feb 2025 15:44:33 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [4e0ffda5](https://github.com/openjdk/jdk/commit/4e0ffda5b1d82449d2d6f639be7641b69d6cb520) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to jdk24u. This backport make test more rubustness, test-fix only, no risk. > > Thanks! This pull request has now been integrated. Changeset: a07d7849 Author: SendaoYan URL: https://git.openjdk.org/jdk24u/commit/a07d784919ae232a890bf79de27b8623e294ad20 Stats: 10 lines in 1 file changed: 5 ins; 2 del; 3 mod 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk Backport-of: 4e0ffda5b1d82449d2d6f639be7641b69d6cb520 ------------- PR: https://git.openjdk.org/jdk24u/pull/60 From syan at openjdk.org Tue Feb 11 03:20:29 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Feb 2025 03:20:29 GMT Subject: [jdk21u-dev] RFR: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position Message-ID: Hi all, This pull request contains a backport of commit [46b39279](https://github.com/openjdk/jdk24u/commit/46b3927985e220ee756c0a8384d5628c28a11457) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository to jdk21u-dev. Clean backport to fix the test bug which may cause test can not catch the expected failure, test-fix only, no risk. Thanks! ------------- Commit messages: - Backport 46b3927985e220ee756c0a8384d5628c28a11457 Changes: https://git.openjdk.org/jdk21u-dev/pull/1393/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1393&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343882 Stats: 18 lines in 1 file changed: 5 ins; 4 del; 9 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1393.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1393/head:pull/1393 PR: https://git.openjdk.org/jdk21u-dev/pull/1393 From syan at openjdk.org Tue Feb 11 03:21:48 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Feb 2025 03:21:48 GMT Subject: [jdk17u-dev] RFR: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position Message-ID: Hi all, This pull request contains a backport of commit [46b39279](https://github.com/openjdk/jdk24u/commit/46b3927985e220ee756c0a8384d5628c28a11457) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository to jdk17u-dev. Clean backport to fix the test bug which may cause test can not catch the expected failure, test-fix only, no risk. Thanks! ------------- Commit messages: - Backport 46b3927985e220ee756c0a8384d5628c28a11457 Changes: https://git.openjdk.org/jdk17u-dev/pull/3272/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3272&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343882 Stats: 18 lines in 1 file changed: 5 ins; 4 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3272.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3272/head:pull/3272 PR: https://git.openjdk.org/jdk17u-dev/pull/3272 From syan at openjdk.org Tue Feb 11 03:27:42 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Feb 2025 03:27:42 GMT Subject: [jdk21u-dev] RFR: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk Message-ID: <1zju6m4K1dzsLwnH8a4er7Jn36ZGU9qmF43L0IMmQ2M=.d417ed34-632c-4827-8606-856cb4cbb0cb@github.com> Hi all, This pull request contains a backport of commit [a07d7849](https://github.com/openjdk/jdk24u/commit/a07d784919ae232a890bf79de27b8623e294ad20) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository to jdk21u-dev. This backport make test more rubustness, test-fix only, no risk. Thanks! ------------- Commit messages: - Backport a07d784919ae232a890bf79de27b8623e294ad20 Changes: https://git.openjdk.org/jdk21u-dev/pull/1394/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1394&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346972 Stats: 10 lines in 1 file changed: 5 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1394.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1394/head:pull/1394 PR: https://git.openjdk.org/jdk21u-dev/pull/1394 From syan at openjdk.org Tue Feb 11 03:28:41 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Feb 2025 03:28:41 GMT Subject: [jdk17u-dev] RFR: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk Message-ID: <8XhG8kCyd65DvmZw2DAq_b0JuSriyDToK5gh9M4c6MY=.9f2949f6-a2a0-4d87-b09e-3aaed757d290@github.com> Hi all, This pull request contains a backport of commit a07d7849 from the openjdk/jdk24u repository to jdk17u-dev. This backport make test more rubustness, test-fix only, no risk. Thanks! ------------- Commit messages: - Backport a07d784919ae232a890bf79de27b8623e294ad20 Changes: https://git.openjdk.org/jdk17u-dev/pull/3273/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3273&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346972 Stats: 10 lines in 1 file changed: 5 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3273.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3273/head:pull/3273 PR: https://git.openjdk.org/jdk17u-dev/pull/3273 From syan at openjdk.org Tue Feb 11 03:31:45 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Feb 2025 03:31:45 GMT Subject: [jdk21u-dev] RFR: 8347171: (dc) java/nio/channels/DatagramChannel/InterruptibleOrNot.java fails with virtual thread factory Message-ID: Hi all, This pull request contains a backport of commit [687ea73b](https://github.com/openjdk/jdk24u/commit/687ea73b00fd047305bfa1dda8187276bfb68dbf) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository. This backport make test more robustness, which skip this test when enable virtual thread, test-fix only, no risk, Thanks! ------------- Commit messages: - Backport 687ea73b00fd047305bfa1dda8187276bfb68dbf Changes: https://git.openjdk.org/jdk21u-dev/pull/1395/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1395&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347171 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1395.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1395/head:pull/1395 PR: https://git.openjdk.org/jdk21u-dev/pull/1395 From mbaesken at openjdk.org Tue Feb 11 08:29:18 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 11 Feb 2025 08:29:18 GMT Subject: [jdk24u] Integrated: 8347576: Error output in libjsound has non matching format strings In-Reply-To: References: Message-ID: On Fri, 7 Feb 2025 11:04:54 GMT, Matthias Baesken wrote: > 8347576: Error output in libjsound has non matching format strings This pull request has now been integrated. Changeset: 5a3ab690 Author: Matthias Baesken URL: https://git.openjdk.org/jdk24u/commit/5a3ab69050941770b5f384cbd0395f09a50a6fb5 Stats: 13 lines in 4 files changed: 2 ins; 0 del; 11 mod 8347576: Error output in libjsound has non matching format strings Backport-of: 07a0dcbabcb1216211c1da75f6dd2582da194df9 ------------- PR: https://git.openjdk.org/jdk24u/pull/57 From goetz at openjdk.org Tue Feb 11 08:30:01 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 11 Feb 2025 08:30:01 GMT Subject: [jdk21u-dev] RFR: 8302111: Serialization considerations [v2] In-Reply-To: References: Message-ID: > I think this is a valuable fix we need in 21. It secures deserialized data. > > The code needed some resolves, but overall the change of > head fits well on the code in 21. In detail: > > I resolved > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java and > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java. > It does not apply as these changes are missing in 21: > 8311170: Simplify and modernize equals and hashCode in security area > 8315974: Make fields final in 'com.sun.crypto.provider' package > Both files have similar differences between head and 21: > In both files I resolved one larger chunk. Some of the removed code is different: > * Initialization of this.l removed in original. This initialization is not in 21. > * head has some coding initializing this.x/y. This is handled by a call to > parseKeyBits() in 21, which executes similar code. > The new code is the same as in head. > > In src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBError.java, changes > 8327818: Implement Kerberos debug with sun.security.util.Debug and again > 8311170: Simplify and modernize equals and hashCode in security area > are missing in 21. > This only requires trivial resolves due to context differences. > > I based this backport on the commit to head. > The commit to 22.0.2 is identical to that, except that it skips > two unnecessary empty lines in KRBError.java. I rather go > with the head version as this will make further backports > fit better. > > This passed our nightly testing which includes the tests for the security implementations. > We run headless tier 1-4 on 8 platform with fastdebug, jck and further internal tests. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Remove parseKeyBits() ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1391/files - new: https://git.openjdk.org/jdk21u-dev/pull/1391/files/c11e3a94..d3ec94bc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1391&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1391&range=00-01 Stats: 20 lines in 2 files changed: 0 ins; 20 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1391.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1391/head:pull/1391 PR: https://git.openjdk.org/jdk21u-dev/pull/1391 From goetz at openjdk.org Tue Feb 11 08:30:01 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 11 Feb 2025 08:30:01 GMT Subject: [jdk21u-dev] RFR: 8302111: Serialization considerations [v2] In-Reply-To: References: Message-ID: On Mon, 10 Feb 2025 21:02:35 GMT, Andrew John Hughes wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove parseKeyBits() > > Backport mostly looks good. The initialisation differences for `l`, `x` and `y` are also from JDK-8315974: "Make fields final in 'com.sun.crypto.provider' package". I presume, because the fields were now final, there could not be code paths that didn't initialise `l` and the initialisation of `x` and `y` could no longer be delegated to `parseKeyBits`. > > On the subject of `parseKeyBits`, I think this method can now be removed, as it is in JDK-8315974. It is a private method that I don't see being called from anywhere else in those files. Hi @gnu-andrew, thanks for your review. Good point to remove the function, done. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1391#issuecomment-2650107898 From mbaesken at openjdk.org Tue Feb 11 08:32:18 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 11 Feb 2025 08:32:18 GMT Subject: [jdk17u-dev] RFR: 8348625: [21u, 17u] Revert JDK-8185862 to restore old java.awt.headless behavior on Windows In-Reply-To: References: Message-ID: On Thu, 6 Feb 2025 20:10:03 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of commit [e1967d51 ](https://github.com/openjdk/jdk21u-dev/commit/e1967d51)from the [openjdk/jdk21u-dev](https://github.com/openjdk/jdk21u-dev) repository. > The commit being backported was authored by Christoph Langer on 31 Jan 2025 and was reviewed by Severin Gehwolf. > > The patch is clean, but in 17 there is no FreeTypeScalerJNICheck.java so the bots don't recognize this. > > Thanks! Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3270#pullrequestreview-2608006988 From clanger at openjdk.org Tue Feb 11 08:43:54 2025 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 11 Feb 2025 08:43:54 GMT Subject: [jdk17u-dev] RFR: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates Message-ID: Hi all, This pull request contains a backport of [JDK-8349603](https://bugs.openjdk.org/browse/JDK-8349603). The change is different to the JDK 21u original because obviously the JDKs need for JDK 17u are different. Thanks! ------------- Commit messages: - Backport 9c8fe67afff3a275c2e5944e996ce3f32ae53b37 Changes: https://git.openjdk.org/jdk17u-dev/pull/3274/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3274&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349603 Stats: 14 lines in 1 file changed: 4 ins; 4 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3274.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3274/head:pull/3274 PR: https://git.openjdk.org/jdk17u-dev/pull/3274 From aph at openjdk.org Tue Feb 11 08:52:19 2025 From: aph at openjdk.org (Andrew Haley) Date: Tue, 11 Feb 2025 08:52:19 GMT Subject: [jdk21u-dev] RFR: 8180450: secondary_super_cache does not scale well In-Reply-To: References: <4LeEOVL3OM57vpgMH9YTOBgyGCucK3L6iWC0XGD60ZQ=.10c0f7c0-897d-45ec-b105-5c4467890d74@github.com> Message-ID: On Mon, 10 Feb 2025 12:23:43 GMT, Andrew Dinn wrote: >> See [8180450](https://github.com/openjdk/jdk/pull/18309) for a full description of how this works. >> This is a pretty clean backport, but a few files had to be fiddled manually because things had been added nearby. >> >> This PR also includes a fix for [[8337958](https://bugs.openjdk.org/browse/JDK-8337958)](https://bugs.openjdk.org/browse/JDK-8337958), which was a minor bug in the original commit. >> >> For a justification of why this PR should be backported to JDK 21u, see >> [Franz's email](https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-October/038649.html). > > test/micro/org/openjdk/bench/vm/lang/SecondarySupersLookup.java line 1: > >> 1: /* > > Could you comment on why only this one test is being back-ported? The other tests don't really apply to this PR, but to later PRs. They were checked in at the time due to some confusion as to their applicability. ------------- PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1090#discussion_r1950447219 From aph at openjdk.org Tue Feb 11 09:47:29 2025 From: aph at openjdk.org (Andrew Haley) Date: Tue, 11 Feb 2025 09:47:29 GMT Subject: [jdk21u-dev] RFR: 8180450: secondary_super_cache does not scale well [v2] In-Reply-To: <4LeEOVL3OM57vpgMH9YTOBgyGCucK3L6iWC0XGD60ZQ=.10c0f7c0-897d-45ec-b105-5c4467890d74@github.com> References: <4LeEOVL3OM57vpgMH9YTOBgyGCucK3L6iWC0XGD60ZQ=.10c0f7c0-897d-45ec-b105-5c4467890d74@github.com> Message-ID: <_D9aTO2W__r3NuVKXmmJwKJhKbvWqANESx3O6weLgi0=.51bb7244-5f76-460f-97ff-6a24b87e67c4@github.com> > See [8180450](https://github.com/openjdk/jdk/pull/18309) for a full description of how this works. > This is a pretty clean backport, but a few files had to be fiddled manually because things had been added nearby. > > This PR also includes a fix for [[8337958](https://bugs.openjdk.org/browse/JDK-8337958)](https://bugs.openjdk.org/browse/JDK-8337958), which was a minor bug in the original commit. > > For a justification of why this PR should be backported to JDK 21u, see > [Franz's email](https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-October/038649.html). Andrew Haley has updated the pull request incrementally with one additional commit since the last revision: Add check ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1090/files - new: https://git.openjdk.org/jdk21u-dev/pull/1090/files/983b05e3..cfce5b29 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1090&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1090&range=00-01 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1090.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1090/head:pull/1090 PR: https://git.openjdk.org/jdk21u-dev/pull/1090 From aph at openjdk.org Tue Feb 11 09:47:29 2025 From: aph at openjdk.org (Andrew Haley) Date: Tue, 11 Feb 2025 09:47:29 GMT Subject: [jdk21u-dev] RFR: 8180450: secondary_super_cache does not scale well [v2] In-Reply-To: References: <4LeEOVL3OM57vpgMH9YTOBgyGCucK3L6iWC0XGD60ZQ=.10c0f7c0-897d-45ec-b105-5c4467890d74@github.com> Message-ID: On Mon, 10 Feb 2025 11:58:15 GMT, Andrew Dinn wrote: >> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision: >> >> Add check > > src/hotspot/share/cds/filemap.cpp line 293: > >> 291: st->print_cr("- cloned_vtables_offset: " SIZE_FORMAT_X, _cloned_vtables_offset); >> 292: st->print_cr("- serialized_data_offset: " SIZE_FORMAT_X, _serialized_data_offset); >> 293: st->print_cr("- heap_begin: " INTPTR_FORMAT, p2i(_heap_begin)); > > The upstream patch added the following sanity check at line 2425 (equivalent to line 2411 in the 21u version): > > if (! _use_secondary_supers_table && UseSecondarySupersTable) { > log_warning(cds)("The shared archive was created without UseSecondarySupersTable."); > return false; > } > > Is there a reason why it has been omitted from this patch? I think it was a hunk I should have applied manually. Good catch. I'm assuming that CDS gets tested reasonably well as part of tier1. ------------- PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1090#discussion_r1950526159 From mbaesken at openjdk.org Tue Feb 11 11:22:42 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 11 Feb 2025 11:22:42 GMT Subject: [jdk21u-dev] RFR: 8347576: Error output in libjsound has non matching format strings Message-ID: Backport of 8347576; PLATFORM_API_WinOS_MidiIn.cpp needed copyright year adjustment ------------- Commit messages: - Backport 07a0dcbabcb1216211c1da75f6dd2582da194df9 Changes: https://git.openjdk.org/jdk21u-dev/pull/1396/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1396&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347576 Stats: 13 lines in 4 files changed: 2 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1396.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1396/head:pull/1396 PR: https://git.openjdk.org/jdk21u-dev/pull/1396 From duke at openjdk.org Tue Feb 11 11:26:11 2025 From: duke at openjdk.org (duke) Date: Tue, 11 Feb 2025 11:26:11 GMT Subject: [jdk21u-dev] RFR: 8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java In-Reply-To: <-nEcg8S-8Gw8WKSzR1--2V_PTZWVVpJ2M_p2UFgZ0fI=.f2e0b59b-3fb4-4e17-a1a9-b4ce6a04c058@github.com> References: <-nEcg8S-8Gw8WKSzR1--2V_PTZWVVpJ2M_p2UFgZ0fI=.f2e0b59b-3fb4-4e17-a1a9-b4ce6a04c058@github.com> Message-ID: On Sat, 21 Dec 2024 04:14:39 GMT, Jan Kratochvil wrote: > Only `TestPLABAdaptToMinTLABSize.java` is a clean backport. > `TestPinnedHumongousFragmentation.java` and `TestPinnedObjectContents.java` did not exist in JDK 21. @jankratochvil Your change (at version 804127b4a3b1e6edb898792218224a13598b00c6) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1277#issuecomment-2650523679 From mbaesken at openjdk.org Tue Feb 11 11:36:10 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 11 Feb 2025 11:36:10 GMT Subject: [jdk24u] Integrated: 8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer In-Reply-To: References: Message-ID: <9qSrjNHgYO-Qvc4F9dgFBoDmgZaFWIuhcJu8sjmRFdI=.70bcf9a8-b18d-4b18-aa36-b69de71bd0d9@github.com> On Fri, 7 Feb 2025 11:09:50 GMT, Matthias Baesken wrote: > 8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer This pull request has now been integrated. Changeset: bbfe4059 Author: Matthias Baesken URL: https://git.openjdk.org/jdk24u/commit/bbfe4059fb0d29f565d045a833ddffe60a11fe9c Stats: 14 lines in 3 files changed: 8 ins; 0 del; 6 mod 8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer Backport-of: 0a81676fae3b25117dd2289a734193bcbee822de ------------- PR: https://git.openjdk.org/jdk24u/pull/58 From mbaesken at openjdk.org Tue Feb 11 12:38:32 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 11 Feb 2025 12:38:32 GMT Subject: [jdk24u] Integrated: 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64 In-Reply-To: <9k4E3VOlT_ZSmE7lgU2BpwdzWyO8kMLgjWkr1vHZ8lc=.9fdf2e9c-48be-4be3-b477-ee9f781c669b@github.com> References: <9k4E3VOlT_ZSmE7lgU2BpwdzWyO8kMLgjWkr1vHZ8lc=.9fdf2e9c-48be-4be3-b477-ee9f781c669b@github.com> Message-ID: On Wed, 5 Feb 2025 12:49:16 GMT, Matthias Baesken wrote: > 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64 This pull request has now been integrated. Changeset: 82ccb078 Author: Matthias Baesken URL: https://git.openjdk.org/jdk24u/commit/82ccb0789977e322dfb9af7aa0c44cff2ad57b05 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64 Backport-of: 1d2ccaeaa316029772b5de3dc5579ee7b1363b60 ------------- PR: https://git.openjdk.org/jdk24u/pull/53 From thartmann at openjdk.org Tue Feb 11 13:03:17 2025 From: thartmann at openjdk.org (Tobias Hartmann) Date: Tue, 11 Feb 2025 13:03:17 GMT Subject: [jdk24u] RFR: 8347718: Unexpected NullPointerException in C2 compiled code due to ReduceAllocationMerges In-Reply-To: References: Message-ID: <7MeuMBGAlLwntg8LDoUC_0_dSdIE_V-ysGTP5NQ2IAM=.86e81785-e53c-45b5-a885-20789dc073f9@github.com> On Mon, 10 Feb 2025 08:07:01 GMT, Tobias Hartmann wrote: > Hi all, > > This pull request contains a backport of commit [9f4d3de4](https://github.com/openjdk/jdk/commit/9f4d3de442a846c503dac52de4a757e5b5638e73) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Cesar Soares Lucas on 28 Jan 2025 and was reviewed by Vladimir Kozlov and Tobias Hartmann. > > Thanks! Thanks Cesar! ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/65#issuecomment-2650754226 From mbaesken at openjdk.org Tue Feb 11 13:04:27 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 11 Feb 2025 13:04:27 GMT Subject: [jdk21u-dev] RFR: 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64 Message-ID: 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64 ------------- Commit messages: - Backport 1d2ccaeaa316029772b5de3dc5579ee7b1363b60 Changes: https://git.openjdk.org/jdk21u-dev/pull/1397/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1397&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345569 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1397.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1397/head:pull/1397 PR: https://git.openjdk.org/jdk21u-dev/pull/1397 From goetz at openjdk.org Tue Feb 11 13:49:15 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 11 Feb 2025 13:49:15 GMT Subject: [jdk21u-dev] RFR: 8325730: StringBuilder.toString allocation for the empty String In-Reply-To: References: Message-ID: On Wed, 5 Feb 2025 13:43:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. GHA failures: network timeouts. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1387#issuecomment-2650874823 From goetz at openjdk.org Tue Feb 11 13:52:15 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 11 Feb 2025 13:52:15 GMT Subject: [jdk21u-dev] Integrated: 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025 In-Reply-To: References: Message-ID: On Thu, 30 Jan 2025 13:12:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: e122829d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/e122829dcacb494fbe9668d454b49a256c1640a4 Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025 Backport-of: 2e00816ac30373df28a29dc938f7ce5489a3edfc ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1377 From goetz at openjdk.org Tue Feb 11 13:53:18 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 11 Feb 2025 13:53:18 GMT Subject: [jdk21u-dev] Integrated: 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025 In-Reply-To: References: Message-ID: <13KBfDHTwgsqged_qvswsjM8YPFw0QipzKUWGXvsCVY=.59162d4b-b2a6-48ce-be5c-5ce0add848c9@github.com> On Thu, 30 Jan 2025 12:37:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 3e556491 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/3e556491933baa9b03b79319ababe20bc3c69e38 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025 Backport-of: b0c131e872f997cb7deadc9b0a87bd76e3a2a83c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1376 From goetz at openjdk.org Tue Feb 11 13:54:22 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 11 Feb 2025 13:54:22 GMT Subject: [jdk17u-dev] Integrated: 8342988: GHA: Build JTReg in single step In-Reply-To: <7RYLD7tRxof3pzOKZwE_exHfrKS3popeWByz2d1Rnd8=.997b01fa-c083-4af7-9294-6834debcba32@github.com> References: <7RYLD7tRxof3pzOKZwE_exHfrKS3popeWByz2d1Rnd8=.997b01fa-c083-4af7-9294-6834debcba32@github.com> Message-ID: <_UHBsj-4rQCrQ2n_LuZ1IDbsL9TdvZ_KYMf_NkVrC7E=.0f28cfd4-f45d-4c6f-80fd-bd5a54234b55@github.com> On Wed, 5 Feb 2025 12:25:48 GMT, Goetz Lindenmaier wrote: > I want to backport this to reduce errors in gha runs. The backport is based on the commit to 21. > > I had to resolve becasue 8297984: Turn on warnings as errors for javadoc > is not in 17. > Omitted the edits in the code added by JDK-8297984. This pull request has now been integrated. Changeset: 087e8a29 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/087e8a29f2aead8b31a71b144523810c8538388c Stats: 136 lines in 3 files changed: 81 ins; 26 del; 29 mod 8342988: GHA: Build JTReg in single step Reviewed-by: sgehwolf, mbaesken Backport-of: 6e6f8b2f90e362ceb2d76e791cd6e58cf5d3ddbd ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3264 From goetz at openjdk.org Tue Feb 11 13:55:15 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 11 Feb 2025 13:55:15 GMT Subject: [jdk17u-dev] Integrated: 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025 In-Reply-To: References: Message-ID: <6gbWiRgExgZERmfZ5-wZwL3XH9MYDt2stFCAtXavQR0=.a8481f61-8a1a-4d44-acb3-8a1ae8f48c31@github.com> On Thu, 30 Jan 2025 13:10:58 GMT, Goetz Lindenmaier wrote: > I backport this because we see problems on our Windows Server 2025 test machines. > > I had to resolve. > StaticProperty.osName() is not in 17. > Also, two changes are missing in 17: > > [8287237: (fs) Files.probeContentType returns null if filename contains hash mark on Linux](https://github.com/openjdk/jdk/commit/8071b2311caaacd714d74f12aee6cb7c2fe700fa) > [8297609: Add application/wasm MIME type for wasm file extension](https://github.com/openjdk/jdk/commit/914ef07fed960f940e1591318b9f00938b37bf09) > > I don't think these should be backported as prereq. This pull request has now been integrated. Changeset: f63ee83a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f63ee83afdb03fecc1017ae1b15e21140f17a9e9 Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025 Reviewed-by: mbaesken Backport-of: 2e00816ac30373df28a29dc938f7ce5489a3edfc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3259 From goetz at openjdk.org Tue Feb 11 13:56:21 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 11 Feb 2025 13:56:21 GMT Subject: [jdk17u-dev] Integrated: 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025 In-Reply-To: References: Message-ID: On Thu, 30 Jan 2025 12:37:28 GMT, Goetz Lindenmaier wrote: > I backport this because we see reported problems on our Windows Server 2025 box. > > Resolved because StaticProperty has no osName() in 17. This pull request has now been integrated. Changeset: 2691c142 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2691c1428c592f952a0093e0cae3244ab48246c0 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025 Reviewed-by: mbaesken Backport-of: b0c131e872f997cb7deadc9b0a87bd76e3a2a83c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3258 From mbaesken at openjdk.org Tue Feb 11 13:56:53 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 11 Feb 2025 13:56:53 GMT Subject: [jdk24u] RFR: 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64 Message-ID: 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64 ------------- Commit messages: - Backport 0285020c7ea01f32b32efe166a0a5dae39957216 Changes: https://git.openjdk.org/jdk24u/pull/68/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=68&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345676 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk24u/pull/68.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/68/head:pull/68 PR: https://git.openjdk.org/jdk24u/pull/68 From goetz at openjdk.org Tue Feb 11 14:09:32 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 11 Feb 2025 14:09:32 GMT Subject: [jdk21u-dev] RFR: 8347740: java/io/File/createTempFile/SpecialTempFile.java failing Message-ID: <1U8BqA9RDu6OssXX-On8p7ieeTWmL6uQPu5-Yma-aFg=.c81a3f32-d016-4ad6-b275-6dc21374337b@github.com> I would like to fix this issue in 21. We see it in our CI. ------------- Commit messages: - Backport f2a9d26b2e409a7216d967ebb6b92726e8ed65c3 Changes: https://git.openjdk.org/jdk21u-dev/pull/1398/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1398&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347740 Stats: 28 lines in 1 file changed: 12 ins; 3 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1398.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1398/head:pull/1398 PR: https://git.openjdk.org/jdk21u-dev/pull/1398 From goetz at openjdk.org Tue Feb 11 14:11:49 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 11 Feb 2025 14:11:49 GMT Subject: [jdk17u-dev] RFR: 8347740: java/io/File/createTempFile/SpecialTempFile.java failing Message-ID: <3QHF2Mos4rHXvL6Tbv5esdYdXa7iyh3d2pdATbTOyaw=.c78eeae3-b50a-4284-a320-a1fac0a646f0@github.com> I would like to fix this issue in 17. I had to resolve because the os name must be fetched by System.getProperty("os.name") in 17. ------------- Commit messages: - Backport f2a9d26b2e409a7216d967ebb6b92726e8ed65c3 Changes: https://git.openjdk.org/jdk17u-dev/pull/3275/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3275&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347740 Stats: 28 lines in 1 file changed: 16 ins; 3 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3275.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3275/head:pull/3275 PR: https://git.openjdk.org/jdk17u-dev/pull/3275 From mbaesken at openjdk.org Tue Feb 11 14:44:32 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 11 Feb 2025 14:44:32 GMT Subject: [jdk21u-dev] RFR: 8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer Message-ID: <-a9tKQDTRxkxsLJzea1wCK0uFoXjnCOOcN7XTNly8n8=.b4e6123b-1bd3-45ca-87f2-db12b93bb64d@github.com> copyright years had to be adjusted ------------- Commit messages: - Backport 0a81676fae3b25117dd2289a734193bcbee822de Changes: https://git.openjdk.org/jdk21u-dev/pull/1399/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1399&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346881 Stats: 14 lines in 3 files changed: 8 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1399.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1399/head:pull/1399 PR: https://git.openjdk.org/jdk21u-dev/pull/1399 From mbaesken at openjdk.org Tue Feb 11 15:37:20 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 11 Feb 2025 15:37:20 GMT Subject: [jdk24u] Integrated: 8345590: AIX 'make all' fails after JDK-8339480 In-Reply-To: <2qEmqSXa3j6MdAqKwpF2vRactMWXQDq-WAobdZjXhg4=.e6d79e0e-4f78-4231-9057-a0b493a7d87e@github.com> References: <2qEmqSXa3j6MdAqKwpF2vRactMWXQDq-WAobdZjXhg4=.e6d79e0e-4f78-4231-9057-a0b493a7d87e@github.com> Message-ID: On Wed, 5 Feb 2025 12:22:54 GMT, Matthias Baesken wrote: > 8345590: AIX 'make all' fails after JDK-8339480 This pull request has now been integrated. Changeset: 63a800da Author: Matthias Baesken URL: https://git.openjdk.org/jdk24u/commit/63a800da86a986010fe8a4777781a1b56a46200b Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8345590: AIX 'make all' fails after JDK-8339480 Backport-of: 266e3d0decc09b9c17c455e2c754cd39114fa31a ------------- PR: https://git.openjdk.org/jdk24u/pull/51 From mdoerr at openjdk.org Tue Feb 11 15:41:20 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 11 Feb 2025 15:41:20 GMT Subject: [jdk17u-dev] RFR: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 11:39:50 GMT, Martin Doerr wrote: > Backport of [JDK-8343205](https://bugs.openjdk.org/browse/JDK-8343205) from jdk21u-dev. We'll ship it later. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3106#issuecomment-2651196456 From andrew at openjdk.org Tue Feb 11 16:03:24 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 11 Feb 2025 16:03:24 GMT Subject: [jdk21u-dev] RFR: 8302111: Serialization considerations [v2] In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 08:30:01 GMT, Goetz Lindenmaier wrote: >> I think this is a valuable fix we need in 21. It secures deserialized data. >> >> The code needed some resolves, but overall the change of >> head fits well on the code in 21. In detail: >> >> I resolved >> src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java and >> src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java. >> It does not apply as these changes are missing in 21: >> 8311170: Simplify and modernize equals and hashCode in security area >> 8315974: Make fields final in 'com.sun.crypto.provider' package >> Both files have similar differences between head and 21: >> In both files I resolved one larger chunk. Some of the removed code is different: >> * Initialization of this.l removed in original. This initialization is not in 21. >> * head has some coding initializing this.x/y. This is handled by a call to >> parseKeyBits() in 21, which executes similar code. >> The new code is the same as in head. >> >> In src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBError.java, changes >> 8327818: Implement Kerberos debug with sun.security.util.Debug and again >> 8311170: Simplify and modernize equals and hashCode in security area >> are missing in 21. >> This only requires trivial resolves due to context differences. >> >> I based this backport on the commit to head. >> The commit to 22.0.2 is identical to that, except that it skips >> two unnecessary empty lines in KRBError.java. I rather go >> with the head version as this will make further backports >> fit better. >> >> This passed our nightly testing which includes the tests for the security implementations. >> We run headless tier 1-4 on 8 platform with fastdebug, jck and further internal tests. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Remove parseKeyBits() Thanks Goetz. I think this is good to go in now. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1391#pullrequestreview-2609221919 From cushon at openjdk.org Tue Feb 11 17:03:19 2025 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 11 Feb 2025 17:03:19 GMT Subject: [jdk24u] RFR: 8349058: 'internal proprietary API' warnings make javac warnings unusable Message-ID: Hi, This pull request contains a backport of commit [1ab1c1d53b86228be85aac96fa5d69db39ac6317](https://github.com/openjdk/jdk/commit/1ab1c1d53b86228be85aac96fa5d69db39ac6317) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to fix [JDK-8349058](https://bugs.openjdk.org/browse/JDK-8349058). It's a clean backport that partially backs out an earlier change, the affected test passes. ------------- Commit messages: - Backport 1ab1c1d53b86228be85aac96fa5d69db39ac6317 Changes: https://git.openjdk.org/jdk24u/pull/69/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=69&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349058 Stats: 103 lines in 2 files changed: 46 ins; 37 del; 20 mod Patch: https://git.openjdk.org/jdk24u/pull/69.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/69/head:pull/69 PR: https://git.openjdk.org/jdk24u/pull/69 From jkratochvil at openjdk.org Tue Feb 11 17:55:16 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 11 Feb 2025 17:55:16 GMT Subject: [jdk21u-dev] Integrated: 8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java In-Reply-To: <-nEcg8S-8Gw8WKSzR1--2V_PTZWVVpJ2M_p2UFgZ0fI=.f2e0b59b-3fb4-4e17-a1a9-b4ce6a04c058@github.com> References: <-nEcg8S-8Gw8WKSzR1--2V_PTZWVVpJ2M_p2UFgZ0fI=.f2e0b59b-3fb4-4e17-a1a9-b4ce6a04c058@github.com> Message-ID: On Sat, 21 Dec 2024 04:14:39 GMT, Jan Kratochvil wrote: > Only `TestPLABAdaptToMinTLABSize.java` is a clean backport. > `TestPinnedHumongousFragmentation.java` and `TestPinnedObjectContents.java` did not exist in JDK 21. This pull request has now been integrated. Changeset: 37ad4db3 Author: Jan Kratochvil Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/37ad4db361355e87bf4edb0c16fce717b46b14bd Stats: 19 lines in 1 file changed: 13 ins; 0 del; 6 mod 8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java Reviewed-by: abakhtin Backport-of: 43b7e9f54776ec7ed98d2e2f717c3d9663268ef2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1277 From andrew at openjdk.org Wed Feb 12 02:05:18 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 12 Feb 2025 02:05:18 GMT Subject: [jdk21u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs In-Reply-To: References: Message-ID: On Thu, 6 Feb 2025 10:02:04 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. Low risk. > > It passes tier1 tests and also all jdk/sun/security tests: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 795 795 0 0 > ============================== > TEST SUCCESS Backport confirmed clean and tests pass. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1388#pullrequestreview-2610630316 From duke at openjdk.org Wed Feb 12 02:08:14 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 12 Feb 2025 02:08:14 GMT Subject: [jdk21u-dev] Integrated: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs In-Reply-To: References: Message-ID: On Thu, 6 Feb 2025 10:02:04 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. Low risk. > > It passes tier1 tests and also all jdk/sun/security tests: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 795 795 0 0 > ============================== > TEST SUCCESS This pull request has now been integrated. Changeset: eb824722 Author: Antonio Vieiro Committer: Andrew John Hughes URL: https://git.openjdk.org/jdk21u-dev/commit/eb824722c053608b779d3b8959ba218aceed6875 Stats: 392 lines in 8 files changed: 388 ins; 0 del; 4 mod 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs Reviewed-by: andrew Backport-of: d2262fe4e9b3118d4c4ab152aa2771b744398367 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1388 From lliu at openjdk.org Wed Feb 12 03:06:58 2025 From: lliu at openjdk.org (Liming Liu) Date: Wed, 12 Feb 2025 03:06:58 GMT Subject: [jdk24u] RFR: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B Message-ID: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B ------------- Commit messages: - Backport 89ee1a5517ea1e3915f4362ada3d2086b63c107e Changes: https://git.openjdk.org/jdk24u/pull/70/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=70&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343978 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk24u/pull/70.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/70/head:pull/70 PR: https://git.openjdk.org/jdk24u/pull/70 From duke at openjdk.org Wed Feb 12 04:22:26 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Wed, 12 Feb 2025 04:22:26 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v3] In-Reply-To: <6XnuRsFDFHNl27zoXvVdwQnBvkIhYQdABEPRCAts0AY=.087e93a8-7eab-45a2-9296-5742b2c4f968@github.com> References: <6XnuRsFDFHNl27zoXvVdwQnBvkIhYQdABEPRCAts0AY=.087e93a8-7eab-45a2-9296-5742b2c4f968@github.com> Message-ID: On Tue, 5 Nov 2024 17:00:15 GMT, Paul Hohensee wrote: >> Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: >> >> - Merge branch 'openjdk:master' into backport-8296631 >> - Merge branch 'openjdk:master' into backport-8296631 >> - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 >> - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 > > Marked as reviewed by phh (Reviewer). @phohensee If there is no problem, I would like you to approve again. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2955#issuecomment-2652623673 From mbaesken at openjdk.org Wed Feb 12 07:43:17 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 12 Feb 2025 07:43:17 GMT Subject: [jdk21u-dev] RFR: 8346082: Output JVMTI agent information in hserr files In-Reply-To: References: Message-ID: On Tue, 14 Jan 2025 14:45:44 GMT, Matthias Baesken wrote: > os.cpp seems to have diffs in the strides; other files apply cleanly This is postponed to a future JDK update. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1328#issuecomment-2652885960 From mbaesken at openjdk.org Wed Feb 12 08:40:22 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 12 Feb 2025 08:40:22 GMT Subject: [jdk17u-dev] RFR: 8347740: java/io/File/createTempFile/SpecialTempFile.java failing In-Reply-To: <3QHF2Mos4rHXvL6Tbv5esdYdXa7iyh3d2pdATbTOyaw=.c78eeae3-b50a-4284-a320-a1fac0a646f0@github.com> References: <3QHF2Mos4rHXvL6Tbv5esdYdXa7iyh3d2pdATbTOyaw=.c78eeae3-b50a-4284-a320-a1fac0a646f0@github.com> Message-ID: On Tue, 11 Feb 2025 14:05:44 GMT, Goetz Lindenmaier wrote: > I would like to fix this issue in 17. > > I had to resolve because the os name must be fetched by System.getProperty("os.name") in 17. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3275#pullrequestreview-2611176534 From jwtang at openjdk.org Wed Feb 12 11:01:56 2025 From: jwtang at openjdk.org (Jiawei Tang) Date: Wed, 12 Feb 2025 11:01:56 GMT Subject: [jdk21u-dev] RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" Message-ID: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" ------------- Commit messages: - Backport 667cca9d7aef1ff4abe630cefaac34c0b1646925 Changes: https://git.openjdk.org/jdk21u-dev/pull/1400/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1400&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288899 Stats: 4526 lines in 18 files changed: 2460 ins; 666 del; 1400 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1400.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1400/head:pull/1400 PR: https://git.openjdk.org/jdk21u-dev/pull/1400 From mbaesken at openjdk.org Wed Feb 12 11:45:24 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 12 Feb 2025 11:45:24 GMT Subject: [jdk24u] RFR: 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer Message-ID: 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer ------------- Commit messages: - Backport 82e16ba248a97e3446d5b2d64c353b61dd6bdda6 Changes: https://git.openjdk.org/jdk24u/pull/71/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=71&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347268 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk24u/pull/71.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/71/head:pull/71 PR: https://git.openjdk.org/jdk24u/pull/71 From goetz at openjdk.org Wed Feb 12 13:21:40 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 12 Feb 2025 13:21:40 GMT Subject: [jdk21u-dev] RFR: 8347740: java/io/File/createTempFile/SpecialTempFile.java failing [v2] In-Reply-To: <1U8BqA9RDu6OssXX-On8p7ieeTWmL6uQPu5-Yma-aFg=.c81a3f32-d016-4ad6-b275-6dc21374337b@github.com> References: <1U8BqA9RDu6OssXX-On8p7ieeTWmL6uQPu5-Yma-aFg=.c81a3f32-d016-4ad6-b275-6dc21374337b@github.com> Message-ID: > I would like to fix this issue in 21. We see it in our CI. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-GoeLin-f2a9d26b-master - Backport f2a9d26b2e409a7216d967ebb6b92726e8ed65c3 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1398/files - new: https://git.openjdk.org/jdk21u-dev/pull/1398/files/0fd7c420..ebfae079 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1398&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1398&range=00-01 Stats: 411 lines in 9 files changed: 401 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1398.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1398/head:pull/1398 PR: https://git.openjdk.org/jdk21u-dev/pull/1398 From goetz at openjdk.org Wed Feb 12 13:21:40 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 12 Feb 2025 13:21:40 GMT Subject: [jdk21u-dev] RFR: 8347740: java/io/File/createTempFile/SpecialTempFile.java failing In-Reply-To: <1U8BqA9RDu6OssXX-On8p7ieeTWmL6uQPu5-Yma-aFg=.c81a3f32-d016-4ad6-b275-6dc21374337b@github.com> References: <1U8BqA9RDu6OssXX-On8p7ieeTWmL6uQPu5-Yma-aFg=.c81a3f32-d016-4ad6-b275-6dc21374337b@github.com> Message-ID: On Tue, 11 Feb 2025 14:04:47 GMT, Goetz Lindenmaier wrote: > I would like to fix this issue in 21. We see it in our CI. GHA failure: build failed. Connection attempt failed: Connection refused: getsockopt Unrelated. As this change adresses win, and the failure is on win, I will restart the tests. The backport to 17 already completed successfully. So I don't expect any issues here. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1398#issuecomment-2653689356 From mbaesken at openjdk.org Wed Feb 12 13:30:54 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 12 Feb 2025 13:30:54 GMT Subject: [jdk21u-dev] RFR: 8319233: AArch64: Build failure with clang due to -Wformat-nonliteral warning Message-ID: 8319233: AArch64: Build failure with clang due to -Wformat-nonliteral warning ------------- Commit messages: - Backport 439ed046e451fc41a875993819a6d4335a0efad5 Changes: https://git.openjdk.org/jdk21u-dev/pull/1401/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1401&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319233 Stats: 35 lines in 7 files changed: 13 ins; 17 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1401.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1401/head:pull/1401 PR: https://git.openjdk.org/jdk21u-dev/pull/1401 From mbaesken at openjdk.org Wed Feb 12 13:42:26 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 12 Feb 2025 13:42:26 GMT Subject: [jdk24u] RFR: 8338303: Linux ppc64le with toolchain clang - detection failure in early JVM startup Message-ID: 8338303: Linux ppc64le with toolchain clang - detection failure in early JVM startup ------------- Commit messages: - Backport 70eec9001a550888f35476f9e2cf3c62d41442dd Changes: https://git.openjdk.org/jdk24u/pull/72/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=72&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338303 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk24u/pull/72.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/72/head:pull/72 PR: https://git.openjdk.org/jdk24u/pull/72 From mbaesken at openjdk.org Wed Feb 12 13:53:54 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 12 Feb 2025 13:53:54 GMT Subject: [jdk21u-dev] RFR: 8338303: Linux ppc64le with toolchain clang - detection failure in early JVM startup Message-ID: <_nCfb8ay5ndj5RC1A283DP5SYXFrVrzaiR0yDHJ626s=.0c20511e-e739-43c0-8623-e3a781c17ffb@github.com> 8338303: Linux ppc64le with toolchain clang - detection failure in early JVM startup ------------- Commit messages: - Backport 70eec9001a550888f35476f9e2cf3c62d41442dd Changes: https://git.openjdk.org/jdk21u-dev/pull/1402/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1402&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338303 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1402.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1402/head:pull/1402 PR: https://git.openjdk.org/jdk21u-dev/pull/1402 From duke at openjdk.org Wed Feb 12 14:38:41 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 12 Feb 2025 14:38:41 GMT Subject: [jdk17u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs Message-ID: <10kgc6AoDtOX0U1qr1cHpQ_zRBJkbgUM2SnkrTXgrOk=.c4fb8f1e-3002-4480-83b0-b66847fa12b8@github.com> Clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. Low risk. On Linux it passes tier1 tests and also all jdk/sun/security tests: ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/sun/security 737 737 0 0 ============================== TEST SUCCESS ------------- Commit messages: - Backport eb824722c053608b779d3b8959ba218aceed6875 Changes: https://git.openjdk.org/jdk17u-dev/pull/3276/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3276&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346587 Stats: 392 lines in 8 files changed: 388 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3276.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3276/head:pull/3276 PR: https://git.openjdk.org/jdk17u-dev/pull/3276 From phh at openjdk.org Wed Feb 12 15:06:26 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 12 Feb 2025 15:06:26 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v4] In-Reply-To: References: Message-ID: On Thu, 7 Nov 2024 13:13:10 GMT, Taizo Kurashige wrote: >> Hi, >> >> This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts >> >> Original patch does not apply cleanly for the following reasons: >> >> ?Fix to getOsMap() in test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied since getOsMap() was removed in https://bugs.openjdk.org/browse/JDK-8331700. >> ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in [https://bugs.openjdk.org/browse/JDK-8220753](https://bugs.openjdk.org/browse/JDK-8220753%28jdk13%29) (jdk13). >> ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed in https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. >> >> Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing >> >> Thanks. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > Replace pkcs11/fips/key4.db and pkcs11.txt Still fine. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2955#pullrequestreview-2612243725 From clanger at openjdk.org Wed Feb 12 17:07:12 2025 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 12 Feb 2025 17:07:12 GMT Subject: [jdk17u-dev] Integrated: 8348625: [21u, 17u] Revert JDK-8185862 to restore old java.awt.headless behavior on Windows In-Reply-To: References: Message-ID: <9eiyBBqf_p33Shgsk8xazq3RSoWPndXlf4HJAFDnDqI=.7244b610-c1bc-4032-9168-75568a00d929@github.com> On Thu, 6 Feb 2025 20:10:03 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of commit [e1967d51 ](https://github.com/openjdk/jdk21u-dev/commit/e1967d51)from the [openjdk/jdk21u-dev](https://github.com/openjdk/jdk21u-dev) repository. > The commit being backported was authored by Christoph Langer on 31 Jan 2025 and was reviewed by Severin Gehwolf. > > The patch is clean, but in 17 there is no FreeTypeScalerJNICheck.java so the bots don't recognize this. > > Thanks! This pull request has now been integrated. Changeset: 4e517641 Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/4e5176419cdf67562ae3e3d491ba0efe77acb1df Stats: 138 lines in 6 files changed: 20 ins; 87 del; 31 mod 8348625: [21u, 17u] Revert JDK-8185862 to restore old java.awt.headless behavior on Windows Reviewed-by: mbaesken Backport-of: e1967d5124309de5276ab88d1bcf4d24f2620dab ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3270 From mdoerr at openjdk.org Wed Feb 12 19:50:25 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 12 Feb 2025 19:50:25 GMT Subject: [jdk21u-dev] RFR: 8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats In-Reply-To: References: Message-ID: On Fri, 27 Dec 2024 18:35:12 GMT, Martin Doerr wrote: > Almost clean backport of [JDK-8345146](https://bugs.openjdk.org/browse/JDK-8345146). Two hunks had to be integrated manually due to unrelated differences in the context. The test updates had to be integrated manually because the RISCV part is not backported. TestFloat16VectorConvChain.java is not in 21u (introduced by https://github.com/openjdk/jdk/commit/55fd1ed228ea3c42aaf92579e5dcb818fe14351d). > > Original PR with performance numbers: https://github.com/openjdk/jdk/pull/22433 We'll ship it later. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1295#issuecomment-2654694879 From duke at openjdk.org Thu Feb 13 00:02:22 2025 From: duke at openjdk.org (duke) Date: Thu, 13 Feb 2025 00:02:22 GMT Subject: [jdk24u] RFR: 8349058: 'internal proprietary API' warnings make javac warnings unusable In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 16:57:52 GMT, Liam Miller-Cushon wrote: > Hi, > > This pull request contains a backport of commit [1ab1c1d53b86228be85aac96fa5d69db39ac6317](https://github.com/openjdk/jdk/commit/1ab1c1d53b86228be85aac96fa5d69db39ac6317) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to fix [JDK-8349058](https://bugs.openjdk.org/browse/JDK-8349058). > > It's a clean backport that partially backs out an earlier change, the affected test passes. @cushon Your change (at version f333075d7dbabf313b4462e5f95cef581b35d7af) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/69#issuecomment-2655114247 From jwtang at openjdk.org Thu Feb 13 02:00:07 2025 From: jwtang at openjdk.org (Jiawei Tang) Date: Thu, 13 Feb 2025 02:00:07 GMT Subject: [jdk21u-dev] RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v2] In-Reply-To: References: Message-ID: > 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" Jiawei Tang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 667cca9d7aef1ff4abe630cefaac34c0b1646925 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1400/files - new: https://git.openjdk.org/jdk21u-dev/pull/1400/files/556f79b7..76668d60 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1400&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1400&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1400.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1400/head:pull/1400 PR: https://git.openjdk.org/jdk21u-dev/pull/1400 From jwtang at openjdk.org Thu Feb 13 02:15:15 2025 From: jwtang at openjdk.org (Jiawei Tang) Date: Thu, 13 Feb 2025 02:15:15 GMT Subject: [jdk21u-dev] RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v2] In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 02:00:07 GMT, Jiawei Tang wrote: >> 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" > > Jiawei Tang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 667cca9d7aef1ff4abe630cefaac34c0b1646925 I found this backport can fix the problem: https://bugs.openjdk.org/browse/JDK-8346175 The awaitWork will recheck queues before park. This solve the problem in JDK-8346175 . ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1400#issuecomment-2655275022 From syan at openjdk.org Thu Feb 13 03:03:19 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 03:03:19 GMT Subject: [jdk21u-dev] Integrated: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError In-Reply-To: References: Message-ID: On Tue, 4 Feb 2025 10:05:32 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [4d8fb807](https://github.com/openjdk/jdk/commit/4d8fb80732fd17352c36254c6dfc1be5dbfbacf1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backport fix the JMH test bug which report "NoClassDefFoundError" fails, test-fix only, no risk. > > Thanks! This pull request has now been integrated. Changeset: 4f4c3cee Author: SendaoYan URL: https://git.openjdk.org/jdk21u-dev/commit/4f4c3cee1f943048e0f5e599333aa5b155a4b1b0 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError Backport-of: 4d8fb80732fd17352c36254c6dfc1be5dbfbacf1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1383 From syan at openjdk.org Thu Feb 13 03:03:18 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 03:03:18 GMT Subject: [jdk21u-dev] RFR: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError In-Reply-To: References: Message-ID: On Tue, 4 Feb 2025 10:05:32 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [4d8fb807](https://github.com/openjdk/jdk/commit/4d8fb80732fd17352c36254c6dfc1be5dbfbacf1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backport fix the JMH test bug which report "NoClassDefFoundError" fails, test-fix only, no risk. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1383#issuecomment-2655344300 From syan at openjdk.org Thu Feb 13 03:04:26 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 03:04:26 GMT Subject: [jdk21u-dev] RFR: 8339834: Replace usages of -mx and -ms in some tests In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 02:09:27 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [1d392492](https://github.com/openjdk/jdk/commit/1d392492311daceeae12769cb9494eae63289853) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 12 Sep 2024 and was reviewed by Alexey Ivanov, Anthony Scarpino, Phil Race and David Holmes. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1392#issuecomment-2655345088 From syan at openjdk.org Thu Feb 13 03:04:27 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 03:04:27 GMT Subject: [jdk21u-dev] Integrated: 8339834: Replace usages of -mx and -ms in some tests In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 02:09:27 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [1d392492](https://github.com/openjdk/jdk/commit/1d392492311daceeae12769cb9494eae63289853) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 12 Sep 2024 and was reviewed by Alexey Ivanov, Anthony Scarpino, Phil Race and David Holmes. > > Thanks! This pull request has now been integrated. Changeset: 4e19a9ba Author: SendaoYan URL: https://git.openjdk.org/jdk21u-dev/commit/4e19a9ba8e4ab03c3939a8d2558db5f4d2f3c52b Stats: 22 lines in 9 files changed: 0 ins; 5 del; 17 mod 8339834: Replace usages of -mx and -ms in some tests Backport-of: 1d392492311daceeae12769cb9494eae63289853 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1392 From duke at openjdk.org Thu Feb 13 03:51:14 2025 From: duke at openjdk.org (duke) Date: Thu, 13 Feb 2025 03:51:14 GMT Subject: [jdk24u] RFR: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B In-Reply-To: References: Message-ID: On Wed, 12 Feb 2025 02:58:04 GMT, Liming Liu wrote: > 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B @limingliu-ampere Your change (at version 95af7c83e53f8002397ae6830dcad61b0b221f28) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/70#issuecomment-2655410722 From mbaesken at openjdk.org Thu Feb 13 08:09:14 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 13 Feb 2025 08:09:14 GMT Subject: [jdk17u-dev] RFR: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates In-Reply-To: References: Message-ID: <9UjODVQTjbqhgnCdJdmp2VP8aICjq3uaKpqLZNyPxTg=.4cfce68f-d6a7-4333-87b1-83e50721abf1@github.com> On Tue, 11 Feb 2025 08:38:46 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8349603](https://bugs.openjdk.org/browse/JDK-8349603). > > The change is different to the JDK 21u original because obviously the JDKs need for JDK 17u are different. > > Thanks! Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3274#pullrequestreview-2614158979 From chagedorn at openjdk.org Thu Feb 13 09:01:25 2025 From: chagedorn at openjdk.org (Christian Hagedorn) Date: Thu, 13 Feb 2025 09:01:25 GMT Subject: [jdk24u] RFR: 8347018: C2: Insertion of Assertion Predicates ignores the effects of PhaseIdealLoop::clone_up_backedge_goo() In-Reply-To: References: Message-ID: On Mon, 10 Feb 2025 08:41:20 GMT, Christian Hagedorn wrote: > Hi all, > > This pull request contains a backport of commit [8a83dc21](https://github.com/openjdk/jdk/commit/8a83dc213ac630ec79d62637133fe7aa102a27a3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Christian Hagedorn on 20 Jan 2025 and was reviewed by Emanuel Peter and Vladimir Kozlov. > > Applied cleanly except for a copyright merging issue in `predicates.hpp`. > > Thanks! Thanks Vladimir for your review! ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/66#issuecomment-2655926808 From chagedorn at openjdk.org Thu Feb 13 09:01:26 2025 From: chagedorn at openjdk.org (Christian Hagedorn) Date: Thu, 13 Feb 2025 09:01:26 GMT Subject: [jdk24u] Integrated: 8347018: C2: Insertion of Assertion Predicates ignores the effects of PhaseIdealLoop::clone_up_backedge_goo() In-Reply-To: References: Message-ID: On Mon, 10 Feb 2025 08:41:20 GMT, Christian Hagedorn wrote: > Hi all, > > This pull request contains a backport of commit [8a83dc21](https://github.com/openjdk/jdk/commit/8a83dc213ac630ec79d62637133fe7aa102a27a3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Christian Hagedorn on 20 Jan 2025 and was reviewed by Emanuel Peter and Vladimir Kozlov. > > Applied cleanly except for a copyright merging issue in `predicates.hpp`. > > Thanks! This pull request has now been integrated. Changeset: 2280d5bc Author: Christian Hagedorn URL: https://git.openjdk.org/jdk24u/commit/2280d5bc817b4248e9000c12cc8b3c953dbae737 Stats: 181 lines in 5 files changed: 155 ins; 13 del; 13 mod 8347018: C2: Insertion of Assertion Predicates ignores the effects of PhaseIdealLoop::clone_up_backedge_goo() Reviewed-by: kvn Backport-of: 8a83dc213ac630ec79d62637133fe7aa102a27a3 ------------- PR: https://git.openjdk.org/jdk24u/pull/66 From syan at openjdk.org Thu Feb 13 09:26:06 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 09:26:06 GMT Subject: [jdk17u-dev] RFR: 8349974: [JMH,17u] MaskQueryOperationsBenchmark fails java.lang.NoClassDefFoundError Message-ID: Hi all, JMH tests org.openjdk.bench.jdk.incubator.vector.MaskQueryOperationsBenchmark report fails "java.lang.NoClassDefFoundError: jdk/incubator/vector/VectorSpecies" in jdk17u-dev repo. This failure was fixed by [JDK-8284960](https://bugs.openjdk.org/browse/JDK-8284960) in main-line repo, I think it's not suitable backport [JDK-8284960](https://bugs.openjdk.org/browse/JDK-8284960) to jdk17u-dev. So I create this issue to fix failure. Change has been verified locally, test-fix only, no risk. Verify command: build/linux-x86_64-server-release/images/jdk/bin/java -Djmh.ignoreLock=true -Djava.library.path=$PWD/build/linux-x86_64-server-release/images/test/micro/native --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED --add-opens=java.base/jdk.internal.misc=ALL-UNNAMED --add-opens java.base/sun.security.provider=ALL-UNNAMED --add-opens java.base/com.sun.crypto.provider=ALL-UNNAMED -jar $PWD/build/linux-x86_64-server-release/images/test/micro/benchmarks.jar -jvmArgsPrepend -Djava.library.path=$PWD/build/linux-x86_64-server-release/images/test/micro/native -t 1 -f 1 -wi 2 org.openjdk.bench.jdk.incubator.vector.MaskQueryOperationsBenchmark.testFirstTrueByte ------------- Commit messages: - 8349974: [JMH,17u] MaskQueryOperationsBenchmark fails java.lang.NoClassDefFoundError Changes: https://git.openjdk.org/jdk17u-dev/pull/3277/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3277&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349974 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3277.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3277/head:pull/3277 PR: https://git.openjdk.org/jdk17u-dev/pull/3277 From galder at openjdk.org Thu Feb 13 09:45:07 2025 From: galder at openjdk.org (Galder =?UTF-8?B?WmFtYXJyZcOxbw==?=) Date: Thu, 13 Feb 2025 09:45:07 GMT Subject: [jdk24u] RFR: 8344925: translet-name ignored when package-name is also set Message-ID: Passed tier1 and tier2 tests on x64. ------------- Commit messages: - Backport 3989a199578fc1d91988cfdbb95f11dd6d4c7b81 Changes: https://git.openjdk.org/jdk24u/pull/73/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=73&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344925 Stats: 173 lines in 4 files changed: 165 ins; 4 del; 4 mod Patch: https://git.openjdk.org/jdk24u/pull/73.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/73/head:pull/73 PR: https://git.openjdk.org/jdk24u/pull/73 From mbaesken at openjdk.org Thu Feb 13 10:22:17 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 13 Feb 2025 10:22:17 GMT Subject: [jdk21u-dev] Integrated: 8319233: AArch64: Build failure with clang due to -Wformat-nonliteral warning In-Reply-To: References: Message-ID: On Wed, 12 Feb 2025 13:25:41 GMT, Matthias Baesken wrote: > 8319233: AArch64: Build failure with clang due to -Wformat-nonliteral warning This pull request has now been integrated. Changeset: 072651a6 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/072651a6d3d7b4736035d8875df336bce88732ca Stats: 35 lines in 7 files changed: 13 ins; 17 del; 5 mod 8319233: AArch64: Build failure with clang due to -Wformat-nonliteral warning Backport-of: 439ed046e451fc41a875993819a6d4335a0efad5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1401 From goetz at openjdk.org Thu Feb 13 10:26:17 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 13 Feb 2025 10:26:17 GMT Subject: [jdk21u-dev] Integrated: 8302111: Serialization considerations In-Reply-To: References: Message-ID: On Mon, 10 Feb 2025 15:38:07 GMT, Goetz Lindenmaier wrote: > I think this is a valuable fix we need in 21. It secures deserialized data. > > The code needed some resolves, but overall the change of > head fits well on the code in 21. In detail: > > I resolved > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java and > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java. > It does not apply as these changes are missing in 21: > 8311170: Simplify and modernize equals and hashCode in security area > 8315974: Make fields final in 'com.sun.crypto.provider' package > Both files have similar differences between head and 21: > In both files I resolved one larger chunk. Some of the removed code is different: > * Initialization of this.l removed in original. This initialization is not in 21. > * head has some coding initializing this.x/y. This is handled by a call to > parseKeyBits() in 21, which executes similar code. > The new code is the same as in head. > > In src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBError.java, changes > 8327818: Implement Kerberos debug with sun.security.util.Debug and again > 8311170: Simplify and modernize equals and hashCode in security area > are missing in 21. > This only requires trivial resolves due to context differences. > > I based this backport on the commit to head. > The commit to 22.0.2 is identical to that, except that it skips > two unnecessary empty lines in KRBError.java. I rather go > with the head version as this will make further backports > fit better. > > This passed our nightly testing which includes the tests for the security implementations. > We run headless tier 1-4 on 8 platform with fastdebug, jck and further internal tests. This pull request has now been integrated. Changeset: 17cb53a9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/17cb53a995e3afd8e8e3b612fdfd71880faaae80 Stats: 1046 lines in 21 files changed: 567 ins; 299 del; 180 mod 8302111: Serialization considerations Reviewed-by: andrew Backport-of: 369c573383a0120e0d85aeb89a211f38b5261013 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1391 From goetz at openjdk.org Thu Feb 13 10:26:17 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 13 Feb 2025 10:26:17 GMT Subject: [jdk21u-dev] Integrated: 8347740: java/io/File/createTempFile/SpecialTempFile.java failing In-Reply-To: <1U8BqA9RDu6OssXX-On8p7ieeTWmL6uQPu5-Yma-aFg=.c81a3f32-d016-4ad6-b275-6dc21374337b@github.com> References: <1U8BqA9RDu6OssXX-On8p7ieeTWmL6uQPu5-Yma-aFg=.c81a3f32-d016-4ad6-b275-6dc21374337b@github.com> Message-ID: On Tue, 11 Feb 2025 14:04:47 GMT, Goetz Lindenmaier wrote: > I would like to fix this issue in 21. We see it in our CI. This pull request has now been integrated. Changeset: 41dcb8ca Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/41dcb8ca322015fe498ff167bc350af847cb4e11 Stats: 28 lines in 1 file changed: 12 ins; 3 del; 13 mod 8347740: java/io/File/createTempFile/SpecialTempFile.java failing Backport-of: f2a9d26b2e409a7216d967ebb6b92726e8ed65c3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1398 From goetz at openjdk.org Thu Feb 13 10:29:13 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 13 Feb 2025 10:29:13 GMT Subject: [jdk17u-dev] Integrated: 8347740: java/io/File/createTempFile/SpecialTempFile.java failing In-Reply-To: <3QHF2Mos4rHXvL6Tbv5esdYdXa7iyh3d2pdATbTOyaw=.c78eeae3-b50a-4284-a320-a1fac0a646f0@github.com> References: <3QHF2Mos4rHXvL6Tbv5esdYdXa7iyh3d2pdATbTOyaw=.c78eeae3-b50a-4284-a320-a1fac0a646f0@github.com> Message-ID: On Tue, 11 Feb 2025 14:05:44 GMT, Goetz Lindenmaier wrote: > I would like to fix this issue in 17. > > I had to resolve because the os name must be fetched by System.getProperty("os.name") in 17. This pull request has now been integrated. Changeset: 356146f5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/356146f558660abdf56d81ede41ce62c5e412f50 Stats: 28 lines in 1 file changed: 16 ins; 3 del; 9 mod 8347740: java/io/File/createTempFile/SpecialTempFile.java failing Reviewed-by: mbaesken Backport-of: f2a9d26b2e409a7216d967ebb6b92726e8ed65c3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3275 From clanger at openjdk.org Thu Feb 13 10:49:11 2025 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 13 Feb 2025 10:49:11 GMT Subject: [jdk17u-dev] Integrated: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 08:38:46 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8349603](https://bugs.openjdk.org/browse/JDK-8349603). > > The change is different to the JDK 21u original because obviously the JDKs need for JDK 17u are different. > > Thanks! This pull request has now been integrated. Changeset: 6ccdc3f8 Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/6ccdc3f8e03d5780da0914c1155b38d33ab76e42 Stats: 14 lines in 1 file changed: 4 ins; 4 del; 6 mod 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates Reviewed-by: mbaesken Backport-of: 9c8fe67afff3a275c2e5944e996ce3f32ae53b37 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3274 From duke at openjdk.org Thu Feb 13 11:11:13 2025 From: duke at openjdk.org (duke) Date: Thu, 13 Feb 2025 11:11:13 GMT Subject: [jdk17u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs In-Reply-To: <10kgc6AoDtOX0U1qr1cHpQ_zRBJkbgUM2SnkrTXgrOk=.c4fb8f1e-3002-4480-83b0-b66847fa12b8@github.com> References: <10kgc6AoDtOX0U1qr1cHpQ_zRBJkbgUM2SnkrTXgrOk=.c4fb8f1e-3002-4480-83b0-b66847fa12b8@github.com> Message-ID: On Wed, 12 Feb 2025 14:33:03 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. Low risk. > > On Linux it passes tier1 tests and also all jdk/sun/security tests: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 737 737 0 0 > ============================== > TEST SUCCESS @vieiro Your change (at version 7d466589cd0597db7d36b6522a67ca2cce3dd7d0) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3276#issuecomment-2656260575 From duke at openjdk.org Thu Feb 13 11:35:16 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 13 Feb 2025 11:35:16 GMT Subject: [jdk17u-dev] Integrated: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs In-Reply-To: <10kgc6AoDtOX0U1qr1cHpQ_zRBJkbgUM2SnkrTXgrOk=.c4fb8f1e-3002-4480-83b0-b66847fa12b8@github.com> References: <10kgc6AoDtOX0U1qr1cHpQ_zRBJkbgUM2SnkrTXgrOk=.c4fb8f1e-3002-4480-83b0-b66847fa12b8@github.com> Message-ID: On Wed, 12 Feb 2025 14:33:03 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. Low risk. > > On Linux it passes tier1 tests and also all jdk/sun/security tests: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 737 737 0 0 > ============================== > TEST SUCCESS This pull request has now been integrated. Changeset: f4bef2f2 Author: Antonio Vieiro Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/f4bef2f24a9bb433b5693aa59bb81acac6b311f3 Stats: 392 lines in 8 files changed: 388 ins; 0 del; 4 mod 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs Backport-of: eb824722c053608b779d3b8959ba218aceed6875 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3276 From syan at openjdk.org Thu Feb 13 11:49:18 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:49:18 GMT Subject: [jdk21u-dev] RFR: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 03:15:34 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [46b39279](https://github.com/openjdk/jdk24u/commit/46b3927985e220ee756c0a8384d5628c28a11457) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository to jdk21u-dev. > > Clean backport to fix the test bug which may cause test can not catch the expected failure, test-fix only, no risk. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1393#issuecomment-2656351955 From syan at openjdk.org Thu Feb 13 11:50:16 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:50:16 GMT Subject: [jdk21u-dev] RFR: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 04:02:01 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [d562d3c7](https://github.com/openjdk/jdk/commit/d562d3c7a9e1e857c095ef908b0957b033972949) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Test-fix only, change has been verified locally, no risk. > > The commit being backported was authored by Liam Miller-Cushon on 20 Dec 2024 and was reviewed by Joe Darcy. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1276#issuecomment-2656350912 From syan at openjdk.org Thu Feb 13 11:50:16 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:50:16 GMT Subject: [jdk21u-dev] Integrated: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 04:02:01 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [d562d3c7](https://github.com/openjdk/jdk/commit/d562d3c7a9e1e857c095ef908b0957b033972949) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Test-fix only, change has been verified locally, no risk. > > The commit being backported was authored by Liam Miller-Cushon on 20 Dec 2024 and was reviewed by Joe Darcy. > > Thanks! This pull request has now been integrated. Changeset: 37ad92f3 Author: SendaoYan URL: https://git.openjdk.org/jdk21u-dev/commit/37ad92f3098cbc5488e2b960d3ac78486aab5a68 Stats: 18 lines in 1 file changed: 5 ins; 4 del; 9 mod 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position Backport-of: d562d3c7a9e1e857c095ef908b0957b033972949 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1276 From syan at openjdk.org Thu Feb 13 11:51:17 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:51:17 GMT Subject: [jdk17u-dev] RFR: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 04:02:03 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [d562d3c7](https://github.com/openjdk/jdk/commit/d562d3c7a9e1e857c095ef908b0957b033972949) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Test-fix only, change has been verified locally, no risk. > > The commit being backported was authored by Liam Miller-Cushon on 20 Dec 2024 and was reviewed by Joe Darcy. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3158#issuecomment-2656354338 From syan at openjdk.org Thu Feb 13 11:51:18 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:51:18 GMT Subject: [jdk17u-dev] Integrated: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 04:02:03 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [d562d3c7](https://github.com/openjdk/jdk/commit/d562d3c7a9e1e857c095ef908b0957b033972949) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Test-fix only, change has been verified locally, no risk. > > The commit being backported was authored by Liam Miller-Cushon on 20 Dec 2024 and was reviewed by Joe Darcy. > > Thanks! This pull request has now been integrated. Changeset: 9eb9ce44 Author: SendaoYan URL: https://git.openjdk.org/jdk17u-dev/commit/9eb9ce4406344ad940fd0e5b789bcf0726ee9c40 Stats: 18 lines in 1 file changed: 5 ins; 4 del; 9 mod 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position Backport-of: d562d3c7a9e1e857c095ef908b0957b033972949 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3158 From syan at openjdk.org Thu Feb 13 11:52:12 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:52:12 GMT Subject: [jdk17u-dev] RFR: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position In-Reply-To: References: Message-ID: <3qAb5tETl8gZrK-1NZr9AS0x--Dl7ePFzrMahMV3N-A=.f64e9d0d-213f-4044-9e25-eb3eabbce58d@github.com> On Tue, 11 Feb 2025 03:16:36 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [46b39279](https://github.com/openjdk/jdk24u/commit/46b3927985e220ee756c0a8384d5628c28a11457) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository to jdk17u-dev. > > Clean backport to fix the test bug which may cause test can not catch the expected failure, test-fix only, no risk. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3272#issuecomment-2656357624 From syan at openjdk.org Thu Feb 13 11:53:14 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:53:14 GMT Subject: [jdk21u-dev] Integrated: 8347171: (dc) java/nio/channels/DatagramChannel/InterruptibleOrNot.java fails with virtual thread factory In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 03:26:56 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [687ea73b](https://github.com/openjdk/jdk24u/commit/687ea73b00fd047305bfa1dda8187276bfb68dbf) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository. > > This backport make test more robustness, which skip this test when enable virtual thread, test-fix only, no risk, > > Thanks! This pull request has now been integrated. Changeset: cc142d4d Author: SendaoYan URL: https://git.openjdk.org/jdk21u-dev/commit/cc142d4da9d30edb07b4567bfacad2f02946159c Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8347171: (dc) java/nio/channels/DatagramChannel/InterruptibleOrNot.java fails with virtual thread factory Backport-of: 687ea73b00fd047305bfa1dda8187276bfb68dbf ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1395 From syan at openjdk.org Thu Feb 13 11:53:13 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:53:13 GMT Subject: [jdk21u-dev] RFR: 8347171: (dc) java/nio/channels/DatagramChannel/InterruptibleOrNot.java fails with virtual thread factory In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 03:26:56 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [687ea73b](https://github.com/openjdk/jdk24u/commit/687ea73b00fd047305bfa1dda8187276bfb68dbf) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository. > > This backport make test more robustness, which skip this test when enable virtual thread, test-fix only, no risk, > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1395#issuecomment-2656358864 From syan at openjdk.org Thu Feb 13 11:54:20 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:54:20 GMT Subject: [jdk21u-dev] RFR: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk In-Reply-To: <1zju6m4K1dzsLwnH8a4er7Jn36ZGU9qmF43L0IMmQ2M=.d417ed34-632c-4827-8606-856cb4cbb0cb@github.com> References: <1zju6m4K1dzsLwnH8a4er7Jn36ZGU9qmF43L0IMmQ2M=.d417ed34-632c-4827-8606-856cb4cbb0cb@github.com> Message-ID: On Tue, 11 Feb 2025 03:22:51 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [a07d7849](https://github.com/openjdk/jdk24u/commit/a07d784919ae232a890bf79de27b8623e294ad20) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository to jdk21u-dev. > > This backport make test more rubustness, test-fix only, no risk. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1394#issuecomment-2656360240 From syan at openjdk.org Thu Feb 13 11:54:20 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:54:20 GMT Subject: [jdk17u-dev] RFR: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk In-Reply-To: <8XhG8kCyd65DvmZw2DAq_b0JuSriyDToK5gh9M4c6MY=.9f2949f6-a2a0-4d87-b09e-3aaed757d290@github.com> References: <8XhG8kCyd65DvmZw2DAq_b0JuSriyDToK5gh9M4c6MY=.9f2949f6-a2a0-4d87-b09e-3aaed757d290@github.com> Message-ID: On Tue, 11 Feb 2025 03:23:24 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit a07d7849 from the openjdk/jdk24u repository to jdk17u-dev. > > This backport make test more rubustness, test-fix only, no risk. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3273#issuecomment-2656359818 From syan at openjdk.org Thu Feb 13 11:54:21 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:54:21 GMT Subject: [jdk21u-dev] Integrated: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk In-Reply-To: <1zju6m4K1dzsLwnH8a4er7Jn36ZGU9qmF43L0IMmQ2M=.d417ed34-632c-4827-8606-856cb4cbb0cb@github.com> References: <1zju6m4K1dzsLwnH8a4er7Jn36ZGU9qmF43L0IMmQ2M=.d417ed34-632c-4827-8606-856cb4cbb0cb@github.com> Message-ID: On Tue, 11 Feb 2025 03:22:51 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [a07d7849](https://github.com/openjdk/jdk24u/commit/a07d784919ae232a890bf79de27b8623e294ad20) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository to jdk21u-dev. > > This backport make test more rubustness, test-fix only, no risk. > > Thanks! This pull request has now been integrated. Changeset: 8b4ee659 Author: SendaoYan URL: https://git.openjdk.org/jdk21u-dev/commit/8b4ee6592f99eed6d14c58b4e32d8c558eb58428 Stats: 10 lines in 1 file changed: 5 ins; 2 del; 3 mod 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk Backport-of: a07d784919ae232a890bf79de27b8623e294ad20 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1394 From syan at openjdk.org Thu Feb 13 11:54:21 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:54:21 GMT Subject: [jdk17u-dev] Integrated: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk In-Reply-To: <8XhG8kCyd65DvmZw2DAq_b0JuSriyDToK5gh9M4c6MY=.9f2949f6-a2a0-4d87-b09e-3aaed757d290@github.com> References: <8XhG8kCyd65DvmZw2DAq_b0JuSriyDToK5gh9M4c6MY=.9f2949f6-a2a0-4d87-b09e-3aaed757d290@github.com> Message-ID: <2zfsFWqqE1rrn9p78gWy8kFN0XvHUGWgDk51QYU7Coo=.245991e6-56e7-434a-8896-c7642d5de7f4@github.com> On Tue, 11 Feb 2025 03:23:24 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit a07d7849 from the openjdk/jdk24u repository to jdk17u-dev. > > This backport make test more rubustness, test-fix only, no risk. > > Thanks! This pull request has now been integrated. Changeset: fcdcff0e Author: SendaoYan URL: https://git.openjdk.org/jdk17u-dev/commit/fcdcff0e0d6a25de5e1c3bd62ba909774663b0db Stats: 10 lines in 1 file changed: 5 ins; 2 del; 3 mod 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk Backport-of: a07d784919ae232a890bf79de27b8623e294ad20 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3273 From syan at openjdk.org Thu Feb 13 11:55:10 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:55:10 GMT Subject: [jdk21u-dev] RFR: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 03:15:34 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [46b39279](https://github.com/openjdk/jdk24u/commit/46b3927985e220ee756c0a8384d5628c28a11457) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository to jdk21u-dev. > > Clean backport to fix the test bug which may cause test can not catch the expected failure, test-fix only, no risk. > > Thanks! Duplicated to https://github.com/openjdk/jdk21u-dev/pull/1276 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1393#issuecomment-2656366006 From syan at openjdk.org Thu Feb 13 11:55:11 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:55:11 GMT Subject: [jdk21u-dev] Withdrawn: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position In-Reply-To: References: Message-ID: <0xwvIfGVXzKW7SPx_JOKjnLosmaZeIKxrm8AP_NIxlc=.35fae92a-923f-48b9-b665-5dc137459675@github.com> On Tue, 11 Feb 2025 03:15:34 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [46b39279](https://github.com/openjdk/jdk24u/commit/46b3927985e220ee756c0a8384d5628c28a11457) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository to jdk21u-dev. > > Clean backport to fix the test bug which may cause test can not catch the expected failure, test-fix only, no risk. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1393 From syan at openjdk.org Thu Feb 13 11:56:15 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:56:15 GMT Subject: [jdk17u-dev] RFR: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 03:16:36 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [46b39279](https://github.com/openjdk/jdk24u/commit/46b3927985e220ee756c0a8384d5628c28a11457) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository to jdk17u-dev. > > Clean backport to fix the test bug which may cause test can not catch the expected failure, test-fix only, no risk. > > Thanks! Duplicated to https://github.com/openjdk/jdk17u-dev/pull/3158 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3272#issuecomment-2656368196 From syan at openjdk.org Thu Feb 13 11:56:16 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 11:56:16 GMT Subject: [jdk17u-dev] Withdrawn: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 03:16:36 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [46b39279](https://github.com/openjdk/jdk24u/commit/46b3927985e220ee756c0a8384d5628c28a11457) from the [openjdk/jdk24u](https://git.openjdk.org/jdk24u) repository to jdk17u-dev. > > Clean backport to fix the test bug which may cause test can not catch the expected failure, test-fix only, no risk. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3272 From syan at openjdk.org Thu Feb 13 12:05:36 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 12:05:36 GMT Subject: [jdk24u] RFR: 8322983: Virtual Threads: exclude 2 tests Message-ID: Hi all, This pull request contains a backport of commit [cf28fd4c](https://github.com/openjdk/jdk/commit/cf28fd4cbc6507eb69fcfeb33622316eb5b6b0c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Evgeny Nikitin on 20 Dec 2024 and was reviewed by Jaikiran Pai, Leonid Mesnik and SendaoYan. Thanks! ------------- Commit messages: - Backport cf28fd4cbc6507eb69fcfeb33622316eb5b6b0c5 Changes: https://git.openjdk.org/jdk24u/pull/74/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=74&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322983 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk24u/pull/74.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/74/head:pull/74 PR: https://git.openjdk.org/jdk24u/pull/74 From syan at openjdk.org Thu Feb 13 12:12:44 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 12:12:44 GMT Subject: [jdk21u-dev] RFR: 8342958: Use jvmArgs consistently in microbenchmarks Message-ID: <-MC1d5SLZGMy_ArJcNwQpTvunmLBScwQ_PJ-YCPYayA=.16d1ef9e-090c-4c28-a8d5-e162c123f72c@github.com> Hi all, This is uncleanly backport of [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958) to jdk21u-dev. ------------- Commit messages: - backport JDK-8343345 - Backport 90bd544512de541cd98889bec58f419bc69a723d Changes: https://git.openjdk.org/jdk21u-dev/pull/1403/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1403&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342958 Stats: 37 lines in 26 files changed: 0 ins; 0 del; 37 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1403.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1403/head:pull/1403 PR: https://git.openjdk.org/jdk21u-dev/pull/1403 From syan at openjdk.org Thu Feb 13 12:38:36 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 13 Feb 2025 12:38:36 GMT Subject: [jdk21u-dev] RFR: 8342958: Use jvmArgs consistently in microbenchmarks [v2] In-Reply-To: <-MC1d5SLZGMy_ArJcNwQpTvunmLBScwQ_PJ-YCPYayA=.16d1ef9e-090c-4c28-a8d5-e162c123f72c@github.com> References: <-MC1d5SLZGMy_ArJcNwQpTvunmLBScwQ_PJ-YCPYayA=.16d1ef9e-090c-4c28-a8d5-e162c123f72c@github.com> Message-ID: > Hi all, > > - This is PR contains two backport to jdk21u-dev > > 1. Uncleanly backport of [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958). > 2. Cleanly backport of [JDK-8343345](https://bugs.openjdk.org/browse/JDK-8343345). > > - Why do we need these two backport? > > 1. [Suggests using jvmArgs consistently](https://github.com/openjdk/jdk/pull/21683#issue-2611685724). > 2. This backport will make several JMH tests run normally after this backport. Before this backport, 'org.openjdk.bench.java.net.NetworkInterfaceLookup.bound' report fails "java.lang.IllegalAccessException: class org.openjdk.bench.java.net.NetworkInterfaceLookup cannot access a member of class java.net.NetworkInterface (in module java.base) with package access", after this backport this JMH test will run passes. > > Why this backport can not backport cleanly? > > 1. TODO > > > Testing: > > - [ ] Run all the touch JMH tests locally. > > Test commands: > > wget https://patch-diff.githubusercontent.com/raw/openjdk/jdk21u-dev/pull/1403.diff -O JDK-8342958-21u.patch > grep "diff --git" JDK-8342958-21u.patch | awk '{print $3}' | grep "^a/test" | sed "s|^a/test/||" | sed "s|/|.|g" | sed "s|.java$||" > list.txt > rm -rf build/jmh-result/ ; mkdir -p build/jmh-result/ ; time for test in `cat list.txt` ; do time make test TEST="micro:$test" MICRO="FORK=1;WARMUP_ITER=2" CONF=release &> build/jmh-result/$test.log ; done SendaoYan has updated the pull request incrementally with one additional commit since the last revision: Replace jvmArgsAppend as jvmArgs ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1403/files - new: https://git.openjdk.org/jdk21u-dev/pull/1403/files/bb4da1ec..7a55ff48 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1403&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1403&range=00-01 Stats: 82 lines in 68 files changed: 0 ins; 0 del; 82 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1403.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1403/head:pull/1403 PR: https://git.openjdk.org/jdk21u-dev/pull/1403 From mbaesken at openjdk.org Thu Feb 13 12:53:12 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 13 Feb 2025 12:53:12 GMT Subject: [jdk21u-dev] Integrated: 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64 In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 12:57:08 GMT, Matthias Baesken wrote: > 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64 This pull request has now been integrated. Changeset: 196c6cc8 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/196c6cc8b22dc74635f80fc268bcfe9045266186 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64 Backport-of: 1d2ccaeaa316029772b5de3dc5579ee7b1363b60 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1397 From mbaesken at openjdk.org Thu Feb 13 12:59:12 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 13 Feb 2025 12:59:12 GMT Subject: [jdk21u-dev] Integrated: 8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer In-Reply-To: <-a9tKQDTRxkxsLJzea1wCK0uFoXjnCOOcN7XTNly8n8=.b4e6123b-1bd3-45ca-87f2-db12b93bb64d@github.com> References: <-a9tKQDTRxkxsLJzea1wCK0uFoXjnCOOcN7XTNly8n8=.b4e6123b-1bd3-45ca-87f2-db12b93bb64d@github.com> Message-ID: On Tue, 11 Feb 2025 14:40:13 GMT, Matthias Baesken wrote: > copyright years had to be adjusted This pull request has now been integrated. Changeset: 7846bc63 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/7846bc63c2bf8d206f38df500d4fd923a9883b73 Stats: 14 lines in 3 files changed: 8 ins; 0 del; 6 mod 8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer Backport-of: 0a81676fae3b25117dd2289a734193bcbee822de ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1399 From mbaesken at openjdk.org Thu Feb 13 13:00:19 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 13 Feb 2025 13:00:19 GMT Subject: [jdk21u-dev] Integrated: 8347576: Error output in libjsound has non matching format strings In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 11:18:23 GMT, Matthias Baesken wrote: > Backport of 8347576; PLATFORM_API_WinOS_MidiIn.cpp needed copyright year adjustment This pull request has now been integrated. Changeset: 950e6550 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/950e655064a75e20540955ad91430c8bea7ae73b Stats: 13 lines in 4 files changed: 2 ins; 0 del; 11 mod 8347576: Error output in libjsound has non matching format strings Backport-of: 07a0dcbabcb1216211c1da75f6dd2582da194df9 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1396 From clanger at openjdk.org Thu Feb 13 13:20:07 2025 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 13 Feb 2025 13:20:07 GMT Subject: [jdk11u-dev] RFR: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates Message-ID: Hi all, This pull request contains a backport of [JDK-8349603](https://bugs.openjdk.org/browse/JDK-8349603). The JDK versions in use are different in jdk11u than in the upstream change, obviously. Thanks! ------------- Commit messages: - Backport 6ccdc3f8e03d5780da0914c1155b38d33ab76e42 Changes: https://git.openjdk.org/jdk11u-dev/pull/2991/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2991&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349603 Stats: 12 lines in 1 file changed: 4 ins; 4 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2991.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2991/head:pull/2991 PR: https://git.openjdk.org/jdk11u-dev/pull/2991 From duke at openjdk.org Thu Feb 13 14:07:43 2025 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Thu, 13 Feb 2025 14:07:43 GMT Subject: [jdk11u-dev] RFR: 8339931: Update problem list for WindowUpdateFocusabilityTest.java Message-ID: JDK-8339931 Update problem list for WindowUpdateFocusabilityTest.java Currently, java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.java is problem-listed against [JDK-8202926](https://bugs.openjdk.org/browse/JDK-8202926) which is resolved without a fix. Fixing the proper number of still existing issue. Clean backport. Passed tier 1 tests. Passed gtests. GH Actions are passing ------------- Commit messages: - Backport 5fada9567731c4538c7d3744fd655ea97420147e Changes: https://git.openjdk.org/jdk11u-dev/pull/2992/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2992&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339931 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2992.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2992/head:pull/2992 PR: https://git.openjdk.org/jdk11u-dev/pull/2992 From sgehwolf at openjdk.org Thu Feb 13 14:23:17 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 13 Feb 2025 14:23:17 GMT Subject: [jdk11u-dev] RFR: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 13:14:33 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8349603](https://bugs.openjdk.org/browse/JDK-8349603). > > The JDK versions in use are different in jdk11u than in the upstream change, obviously. > > Thanks! LGTM. Thanks! ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2991#pullrequestreview-2615148408 From sgehwolf at openjdk.org Thu Feb 13 14:27:12 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 13 Feb 2025 14:27:12 GMT Subject: [jdk11u-dev] RFR: 8339931: Update problem list for WindowUpdateFocusabilityTest.java In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 14:03:19 GMT, Radek ??p wrote: > JDK-8339931 Update problem list for WindowUpdateFocusabilityTest.java > > Currently, java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.java is problem-listed against [JDK-8202926](https://bugs.openjdk.org/browse/JDK-8202926) which is resolved without a fix. Fixing the proper number of still existing issue. > > I backport it for the parity with Oracle 11.0.26. > > Clean backport. > Passed tier 1 tests. > Passed gtests. > > GH Actions are passing Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2992#pullrequestreview-2615158203 From mbaesken at openjdk.org Thu Feb 13 15:16:25 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 13 Feb 2025 15:16:25 GMT Subject: [jdk24u] RFR: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected" Message-ID: <29S6K_YTw5xUoBWGtRh8wfTb6TrFHgsorloeDaApMO0=.3f3f3b08-416e-46a7-a410-234e336525de@github.com> 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected" ------------- Commit messages: - Backport f9b11332eccd8a8ffb4128308f442b209d07a3b1 Changes: https://git.openjdk.org/jdk24u/pull/75/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=75&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346880 Stats: 18 lines in 1 file changed: 17 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk24u/pull/75.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/75/head:pull/75 PR: https://git.openjdk.org/jdk24u/pull/75 From mbaesken at openjdk.org Thu Feb 13 15:21:21 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 13 Feb 2025 15:21:21 GMT Subject: [jdk24u] Integrated: 8338303: Linux ppc64le with toolchain clang - detection failure in early JVM startup In-Reply-To: References: Message-ID: On Wed, 12 Feb 2025 13:38:02 GMT, Matthias Baesken wrote: > 8338303: Linux ppc64le with toolchain clang - detection failure in early JVM startup This pull request has now been integrated. Changeset: ded2ed28 Author: Matthias Baesken URL: https://git.openjdk.org/jdk24u/commit/ded2ed2828ab684cf0cb3e6b3411af17fbd43131 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod 8338303: Linux ppc64le with toolchain clang - detection failure in early JVM startup Backport-of: 70eec9001a550888f35476f9e2cf3c62d41442dd ------------- PR: https://git.openjdk.org/jdk24u/pull/72 From mbaesken at openjdk.org Thu Feb 13 15:35:10 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 13 Feb 2025 15:35:10 GMT Subject: [jdk24u] Integrated: 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer In-Reply-To: References: Message-ID: On Wed, 12 Feb 2025 11:40:42 GMT, Matthias Baesken wrote: > 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer This pull request has now been integrated. Changeset: ff59e5b0 Author: Matthias Baesken URL: https://git.openjdk.org/jdk24u/commit/ff59e5b0064cf6fbe658ddf2ff2cb4e9690e59fa Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer Backport-of: 82e16ba248a97e3446d5b2d64c353b61dd6bdda6 ------------- PR: https://git.openjdk.org/jdk24u/pull/71 From lliu at openjdk.org Thu Feb 13 16:16:13 2025 From: lliu at openjdk.org (Liming Liu) Date: Thu, 13 Feb 2025 16:16:13 GMT Subject: [jdk24u] Integrated: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B In-Reply-To: References: Message-ID: <2tEEJ-PO2_HWEF9kGRXv6Hn8mVx0Mza345PsdfDddoQ=.b81c46b8-e602-4a29-8ed2-9ee623ee0543@github.com> On Wed, 12 Feb 2025 02:58:04 GMT, Liming Liu wrote: > 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B This pull request has now been integrated. Changeset: 010833df Author: Liming Liu Committer: Paul Hohensee URL: https://git.openjdk.org/jdk24u/commit/010833df35f4400a2ee5970a42dd8a13828acdb0 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B Backport-of: 89ee1a5517ea1e3915f4362ada3d2086b63c107e ------------- PR: https://git.openjdk.org/jdk24u/pull/70 From cushon at openjdk.org Thu Feb 13 16:17:17 2025 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Thu, 13 Feb 2025 16:17:17 GMT Subject: [jdk24u] Integrated: 8349058: 'internal proprietary API' warnings make javac warnings unusable In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 16:57:52 GMT, Liam Miller-Cushon wrote: > Hi, > > This pull request contains a backport of commit [1ab1c1d53b86228be85aac96fa5d69db39ac6317](https://github.com/openjdk/jdk/commit/1ab1c1d53b86228be85aac96fa5d69db39ac6317) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to fix [JDK-8349058](https://bugs.openjdk.org/browse/JDK-8349058). > > It's a clean backport that partially backs out an earlier change, the affected test passes. This pull request has now been integrated. Changeset: 754e5ddb Author: Liam Miller-Cushon Committer: Paul Hohensee URL: https://git.openjdk.org/jdk24u/commit/754e5ddb6ada7ccd778ddbe468f62df6d6a6977a Stats: 103 lines in 2 files changed: 46 ins; 37 del; 20 mod 8349058: 'internal proprietary API' warnings make javac warnings unusable Backport-of: 1ab1c1d53b86228be85aac96fa5d69db39ac6317 ------------- PR: https://git.openjdk.org/jdk24u/pull/69 From duke at openjdk.org Thu Feb 13 16:56:19 2025 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Thu, 13 Feb 2025 16:56:19 GMT Subject: [jdk11u-dev] RFR: 8339931: Update problem list for WindowUpdateFocusabilityTest.java In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 14:03:19 GMT, Radek ??p wrote: > JDK-8339931 Update problem list for WindowUpdateFocusabilityTest.java > > Currently, java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.java is problem-listed against [JDK-8202926](https://bugs.openjdk.org/browse/JDK-8202926) which is resolved without a fix. Fixing the proper number of still existing issue. > > I backport it for the parity with Oracle 11.0.26. > > Clean backport. > Passed tier 1 tests. > Passed gtests. > > GH Actions are passing GHA failing on Mac are unrelated. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2992#issuecomment-2657202921 From duke at openjdk.org Thu Feb 13 17:52:41 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 13 Feb 2025 17:52:41 GMT Subject: [jdk11u-dev] RFR: 8339560: Unaddressed comments during code review of JDK-8337664 Message-ID: <3uoHcpXgTRtiqtJakRW4gaQ6YPc0JQ5nXaISyKDgVPU=.6ef22477-2b0d-4f39-b734-ee922fd074fd@github.com> Clean backport of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) that improves `Distrust.java` and reorganizes the directories of distrusted certificates. It will prove useful in order to ease the review of future backports such as upcoming [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) for next april 2025. Tested with tier1 tests in Linux... ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 jtreg:test/jdk:tier1 1899 1899 0 0 jtreg:test/langtools:tier1 3941 3941 0 0 jtreg:test/nashorn:tier1 0 0 0 0 jtreg:test/jaxp:tier1 0 0 0 0 ============================== TEST SUCCESS ... and with the `jdk/sun/security` tests too. ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/sun/security 656 656 0 0 ============================== TEST SUCCESS ------------- Commit messages: - Backport 6a3f208c0b32d90eb3853008301e680695d3ac28 Changes: https://git.openjdk.org/jdk11u-dev/pull/2993/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2993&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339560 Stats: 932 lines in 26 files changed: 391 ins; 541 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2993.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2993/head:pull/2993 PR: https://git.openjdk.org/jdk11u-dev/pull/2993 From azvegint at openjdk.org Thu Feb 13 18:19:37 2025 From: azvegint at openjdk.org (Alexander Zvegintsev) Date: Thu, 13 Feb 2025 18:19:37 GMT Subject: [jdk24u] RFR: 8348600: Update PipeWire to 1.3.81 Message-ID: Hi all, This pull request contains a backport of commit [add3cd1c](https://github.com/openjdk/jdk/commit/add3cd1ca470be8fd5e5e1930d7f789318eb8e6d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alexander Zvegintsev on 13 Feb 2025 and was reviewed by Prasanta Sadhukhan, Phil Race and Harshitha Onkar. Thanks! ------------- Commit messages: - Backport add3cd1ca470be8fd5e5e1930d7f789318eb8e6d Changes: https://git.openjdk.org/jdk24u/pull/76/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=76&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348600 Stats: 2369 lines in 72 files changed: 1728 ins; 59 del; 582 mod Patch: https://git.openjdk.org/jdk24u/pull/76.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/76/head:pull/76 PR: https://git.openjdk.org/jdk24u/pull/76 From duke at openjdk.org Thu Feb 13 18:57:41 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 13 Feb 2025 18:57:41 GMT Subject: [jdk11u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs Message-ID: Almost clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. This is on top of [this previous PR](https://github.com/openjdk/jdk11u-dev/pull/2993) for [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) ("Unaddressed comments during code review of JDK-8337664"). The backport is not completely clean because it required a change in line 98 of `CamerfirmaTLSPolicy.java` since [JDK-8270946](https://bugs.openjdk.org/browse/JDK-8270946) has not been backported to 11. Passes `tier1` and `jdk/sun/security` tests: ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 jtreg:test/jdk:tier1 1899 1899 0 0 jtreg:test/langtools:tier1 3941 3941 0 0 jtreg:test/nashorn:tier1 0 0 0 0 jtreg:test/jaxp:tier1 0 0 0 0 ============================== TEST SUCCESS ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/sun/security 657 657 0 0 ============================== TEST SUCCESS ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/2993 Commit messages: - Backport f4bef2f24a9bb433b5693aa59bb81acac6b311f3 Changes: https://git.openjdk.org/jdk11u-dev/pull/2994/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2994&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346587 Stats: 392 lines in 8 files changed: 388 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2994.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2994/head:pull/2994 PR: https://git.openjdk.org/jdk11u-dev/pull/2994 From duke at openjdk.org Thu Feb 13 18:57:41 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 13 Feb 2025 18:57:41 GMT Subject: [jdk11u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 18:52:18 GMT, Antonio Vieiro wrote: > Almost clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. > > This is on top of [this previous PR](https://github.com/openjdk/jdk11u-dev/pull/2993) for [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) ("Unaddressed comments during code review of JDK-8337664"). > > The backport is not completely clean because it required a change in line 98 of `CamerfirmaTLSPolicy.java` since [JDK-8270946](https://bugs.openjdk.org/browse/JDK-8270946) has not been backported to 11. > > Passes `tier1` and `jdk/sun/security` tests: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 > jtreg:test/jdk:tier1 1899 1899 0 0 > jtreg:test/langtools:tier1 3941 3941 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 657 657 0 0 > ============================== > TEST SUCCESS src/java.base/share/classes/sun/security/validator/CamerfirmaTLSPolicy.java line 98: > 96: > 97: private static String fingerprint(X509Certificate cert) { > 98: return X509CertImpl.getFingerprint("SHA-256", cert); This reads return X509CertImpl.getFingerprint("SHA-256", cert, debug); in JDK-17 and above. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2994#discussion_r1955058882 From duke at openjdk.org Thu Feb 13 19:40:10 2025 From: duke at openjdk.org (Michael De Vera) Date: Thu, 13 Feb 2025 19:40:10 GMT Subject: [jdk17u-dev] RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG Message-ID: <6s2VcYDTqKwhRGyGP5LhuzzKI9q2Rj-c8__G-sgt2nY=.af7290a6-5c6d-4cd9-ba2a-bbff949d35a2@github.com> Backport of [JDK-6355567: AdobeMarkerSegment causes failure to read valid JPEG](https://bugs.openjdk.org/browse/JDK-6355567) Fixes bug that can occur when reading JPEG files with Adobe-specific JPEG application markers. Tier 1 tests were successful. New regression test fails without this fix but passes with it. ------------- Commit messages: - Backport c7c6d47a07100f6c81af6cfad301ec1bda77adf7 Changes: https://git.openjdk.org/jdk17u-dev/pull/2977/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2977&range=00 Issue: https://bugs.openjdk.org/browse/JDK-6355567 Stats: 69 lines in 3 files changed: 61 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2977.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2977/head:pull/2977 PR: https://git.openjdk.org/jdk17u-dev/pull/2977 From duke at openjdk.org Thu Feb 13 19:40:10 2025 From: duke at openjdk.org (Michael De Vera) Date: Thu, 13 Feb 2025 19:40:10 GMT Subject: [jdk17u-dev] RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG In-Reply-To: <6s2VcYDTqKwhRGyGP5LhuzzKI9q2Rj-c8__G-sgt2nY=.af7290a6-5c6d-4cd9-ba2a-bbff949d35a2@github.com> References: <6s2VcYDTqKwhRGyGP5LhuzzKI9q2Rj-c8__G-sgt2nY=.af7290a6-5c6d-4cd9-ba2a-bbff949d35a2@github.com> Message-ID: On Fri, 18 Oct 2024 23:02:44 GMT, Michael De Vera wrote: > Backport of [JDK-6355567: AdobeMarkerSegment causes failure to read valid JPEG](https://bugs.openjdk.org/browse/JDK-6355567) > > Fixes bug that can occur when reading JPEG files with Adobe-specific JPEG application markers. > > Tier 1 tests were successful. New regression test fails without this fix but passes with it. Reopening now that OCA is approved ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2977#issuecomment-2657543482 From duke at openjdk.org Thu Feb 13 20:00:37 2025 From: duke at openjdk.org (duke) Date: Thu, 13 Feb 2025 20:00:37 GMT Subject: [jdk11u-dev] RFR: 8339931: Update problem list for WindowUpdateFocusabilityTest.java In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 14:03:19 GMT, Radek ??p wrote: > JDK-8339931 Update problem list for WindowUpdateFocusabilityTest.java > > Currently, java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.java is problem-listed against [JDK-8202926](https://bugs.openjdk.org/browse/JDK-8202926) which is resolved without a fix. Fixing the proper number of still existing issue. > > I backport it for the parity with Oracle 11.0.26. > > Clean backport. > Passed tier 1 tests. > Passed gtests. > > GH Actions are passing @RadekCap Your change (at version d1da36ccbdc80392bcfe5115f9714f0340ff0496) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2992#issuecomment-2657587533 From duke at openjdk.org Thu Feb 13 20:00:37 2025 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Thu, 13 Feb 2025 20:00:37 GMT Subject: [jdk11u-dev] RFR: 8339931: Update problem list for WindowUpdateFocusabilityTest.java [v2] In-Reply-To: References: Message-ID: > JDK-8339931 Update problem list for WindowUpdateFocusabilityTest.java > > Currently, java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.java is problem-listed against [JDK-8202926](https://bugs.openjdk.org/browse/JDK-8202926) which is resolved without a fix. Fixing the proper number of still existing issue. > > I backport it for the parity with Oracle 11.0.26. > > Clean backport. > Passed tier 1 tests. > Passed gtests. > > GH Actions are passing Radek ??p has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2992/files - new: https://git.openjdk.org/jdk11u-dev/pull/2992/files/4ed3d2a1..d1da36cc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2992&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2992&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2992.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2992/head:pull/2992 PR: https://git.openjdk.org/jdk11u-dev/pull/2992 From syan at openjdk.org Fri Feb 14 03:39:25 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 14 Feb 2025 03:39:25 GMT Subject: [jdk24u] RFR: 8349787: java/lang/Thread/virtual/ThreadPollOnYield.java#default passes unexpectedly without libVThreadPinner.so Message-ID: Hi all, This pull request contains a backport of commit [adc3f53d](https://github.com/openjdk/jdk/commit/adc3f53d2403cd414a91e71c079b4108b2346da0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 13 Feb 2025 and was reviewed by Alan Bateman. Thanks! ------------- Commit messages: - Backport adc3f53d2403cd414a91e71c079b4108b2346da0 Changes: https://git.openjdk.org/jdk24u/pull/77/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=77&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349787 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk24u/pull/77.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/77/head:pull/77 PR: https://git.openjdk.org/jdk24u/pull/77 From duke at openjdk.org Fri Feb 14 07:42:23 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 14 Feb 2025 07:42:23 GMT Subject: [jdk11u-dev] RFR: 8339560: Unaddressed comments during code review of JDK-8337664 In-Reply-To: <3uoHcpXgTRtiqtJakRW4gaQ6YPc0JQ5nXaISyKDgVPU=.6ef22477-2b0d-4f39-b734-ee922fd074fd@github.com> References: <3uoHcpXgTRtiqtJakRW4gaQ6YPc0JQ5nXaISyKDgVPU=.6ef22477-2b0d-4f39-b734-ee922fd074fd@github.com> Message-ID: <449ZQMXOXoU7frqlQMb2O-J-Yba9ni2Utk3heCVW7Cw=.7fcc5ab2-0a67-46d3-b9c7-9ec0461cddb0@github.com> On Thu, 13 Feb 2025 17:46:52 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) that improves `Distrust.java` and reorganizes the directories of distrusted certificates. > > It will prove useful in order to ease the review of future backports such as upcoming [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) for next april 2025. > > Tested with tier1 tests in Linux... > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 > jtreg:test/jdk:tier1 1899 1899 0 0 > jtreg:test/langtools:tier1 3941 3941 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS > > > ... and with the `jdk/sun/security` tests too. > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 656 656 0 0 > ============================== > TEST SUCCESS Build failure on macos is unrelated (see https://github.com/openjdk/jdk11u-dev/pull/2987) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2993#issuecomment-2658498593 From mbaesken at openjdk.org Fri Feb 14 08:07:11 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 14 Feb 2025 08:07:11 GMT Subject: [jdk24u] Integrated: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected" In-Reply-To: <29S6K_YTw5xUoBWGtRh8wfTb6TrFHgsorloeDaApMO0=.3f3f3b08-416e-46a7-a410-234e336525de@github.com> References: <29S6K_YTw5xUoBWGtRh8wfTb6TrFHgsorloeDaApMO0=.3f3f3b08-416e-46a7-a410-234e336525de@github.com> Message-ID: On Thu, 13 Feb 2025 15:12:02 GMT, Matthias Baesken wrote: > 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected" This pull request has now been integrated. Changeset: cb5f489d Author: Matthias Baesken URL: https://git.openjdk.org/jdk24u/commit/cb5f489df7096a44d10a61836c038544cdc02494 Stats: 18 lines in 1 file changed: 17 ins; 0 del; 1 mod 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected" Backport-of: f9b11332eccd8a8ffb4128308f442b209d07a3b1 ------------- PR: https://git.openjdk.org/jdk24u/pull/75 From syan at openjdk.org Fri Feb 14 08:27:15 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 14 Feb 2025 08:27:15 GMT Subject: [jdk24u] RFR: 8322983: Virtual Threads: exclude 2 tests In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 11:59:47 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [cf28fd4c](https://github.com/openjdk/jdk/commit/cf28fd4cbc6507eb69fcfeb33622316eb5b6b0c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Evgeny Nikitin on 20 Dec 2024 and was reviewed by Jaikiran Pai, Leonid Mesnik and SendaoYan. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/74#issuecomment-2658572413 From syan at openjdk.org Fri Feb 14 08:27:16 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 14 Feb 2025 08:27:16 GMT Subject: [jdk24u] Integrated: 8322983: Virtual Threads: exclude 2 tests In-Reply-To: References: Message-ID: <1WK2MkBSAQB82wRKrJk8thXlSP79Yugn6kwdmUr2en4=.39cd381c-2e0c-4e61-a543-41dccf058ddc@github.com> On Thu, 13 Feb 2025 11:59:47 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [cf28fd4c](https://github.com/openjdk/jdk/commit/cf28fd4cbc6507eb69fcfeb33622316eb5b6b0c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Evgeny Nikitin on 20 Dec 2024 and was reviewed by Jaikiran Pai, Leonid Mesnik and SendaoYan. > > Thanks! This pull request has now been integrated. Changeset: 2397beac Author: SendaoYan URL: https://git.openjdk.org/jdk24u/commit/2397beac67bcf8dccc19dc472b354335dc28cc49 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8322983: Virtual Threads: exclude 2 tests Backport-of: cf28fd4cbc6507eb69fcfeb33622316eb5b6b0c5 ------------- PR: https://git.openjdk.org/jdk24u/pull/74 From duke at openjdk.org Fri Feb 14 09:36:19 2025 From: duke at openjdk.org (Radek Cap) Date: Fri, 14 Feb 2025 09:36:19 GMT Subject: [jdk11u-dev] Integrated: 8339931: Update problem list for WindowUpdateFocusabilityTest.java In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 14:03:19 GMT, Radek Cap wrote: > JDK-8339931 Update problem list for WindowUpdateFocusabilityTest.java > > Currently, java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.java is problem-listed against [JDK-8202926](https://bugs.openjdk.org/browse/JDK-8202926) which is resolved without a fix. Fixing the proper number of still existing issue. > > I backport it for the parity with Oracle 11.0.26. > > Clean backport. > Passed tier 1 tests. > Passed gtests. > > GH Actions are passing This pull request has now been integrated. Changeset: cde36426 Author: Radek Cap Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/cde36426cf319f34543abff8afe8d1b3244525d7 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8339931: Update problem list for WindowUpdateFocusabilityTest.java 8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails Reviewed-by: sgehwolf Backport-of: 5fada9567731c4538c7d3744fd655ea97420147e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2992 From sgehwolf at openjdk.org Fri Feb 14 10:14:26 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 14 Feb 2025 10:14:26 GMT Subject: [jdk11u-dev] RFR: 8339560: Unaddressed comments during code review of JDK-8337664 In-Reply-To: <3uoHcpXgTRtiqtJakRW4gaQ6YPc0JQ5nXaISyKDgVPU=.6ef22477-2b0d-4f39-b734-ee922fd074fd@github.com> References: <3uoHcpXgTRtiqtJakRW4gaQ6YPc0JQ5nXaISyKDgVPU=.6ef22477-2b0d-4f39-b734-ee922fd074fd@github.com> Message-ID: <5vatOFRoo534xMC6nF51he8tOdBOAV0wyfmw6thLp7Y=.f33e7f5e-740b-42f2-8534-09362810899e@github.com> On Thu, 13 Feb 2025 17:46:52 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) that improves `Distrust.java` and reorganizes the directories of distrusted certificates. > > It will prove useful in order to ease the review of future backports such as upcoming [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) for next april 2025. > > Tested with tier1 tests in Linux... > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 > jtreg:test/jdk:tier1 1899 1899 0 0 > jtreg:test/langtools:tier1 3941 3941 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS > > > ... and with the `jdk/sun/security` tests too. > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 656 656 0 0 > ============================== > TEST SUCCESS Looks clean as compared to the JDK 17u change. Test only change. OK. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2993#issuecomment-2658859837 From sgehwolf at openjdk.org Fri Feb 14 10:14:27 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 14 Feb 2025 10:14:27 GMT Subject: [jdk11u-dev] RFR: 8339560: Unaddressed comments during code review of JDK-8337664 In-Reply-To: <449ZQMXOXoU7frqlQMb2O-J-Yba9ni2Utk3heCVW7Cw=.7fcc5ab2-0a67-46d3-b9c7-9ec0461cddb0@github.com> References: <3uoHcpXgTRtiqtJakRW4gaQ6YPc0JQ5nXaISyKDgVPU=.6ef22477-2b0d-4f39-b734-ee922fd074fd@github.com> <449ZQMXOXoU7frqlQMb2O-J-Yba9ni2Utk3heCVW7Cw=.7fcc5ab2-0a67-46d3-b9c7-9ec0461cddb0@github.com> Message-ID: On Fri, 14 Feb 2025 07:39:31 GMT, Antonio Vieiro wrote: >> Clean backport of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) that improves `Distrust.java` and reorganizes the directories of distrusted certificates. >> >> It will prove useful in order to ease the review of future backports such as upcoming [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) for next april 2025. >> >> Tested with tier1 tests in Linux... >> >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 >> jtreg:test/jdk:tier1 1899 1899 0 0 >> jtreg:test/langtools:tier1 3941 3941 0 0 >> jtreg:test/nashorn:tier1 0 0 0 0 >> jtreg:test/jaxp:tier1 0 0 0 0 >> ============================== >> TEST SUCCESS >> >> >> ... and with the `jdk/sun/security` tests too. >> >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/sun/security 656 656 0 0 >> ============================== >> TEST SUCCESS > > Build failure on macos is unrelated (see https://github.com/openjdk/jdk11u-dev/pull/2987) @vieiro Please mention that it's a test only change for backports like these in the approval request going forward. This helps assess the risk when gauging the request for approval. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2993#issuecomment-2658869156 From duke at openjdk.org Fri Feb 14 10:25:21 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 14 Feb 2025 10:25:21 GMT Subject: [jdk11u-dev] RFR: 8339560: Unaddressed comments during code review of JDK-8337664 In-Reply-To: <449ZQMXOXoU7frqlQMb2O-J-Yba9ni2Utk3heCVW7Cw=.7fcc5ab2-0a67-46d3-b9c7-9ec0461cddb0@github.com> References: <3uoHcpXgTRtiqtJakRW4gaQ6YPc0JQ5nXaISyKDgVPU=.6ef22477-2b0d-4f39-b734-ee922fd074fd@github.com> <449ZQMXOXoU7frqlQMb2O-J-Yba9ni2Utk3heCVW7Cw=.7fcc5ab2-0a67-46d3-b9c7-9ec0461cddb0@github.com> Message-ID: On Fri, 14 Feb 2025 07:39:31 GMT, Antonio Vieiro wrote: >> Clean backport of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) that improves `Distrust.java` and reorganizes the directories of distrusted certificates. >> >> It will prove useful in order to ease the review of future backports such as upcoming [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) for next april 2025. >> >> Tested with tier1 tests in Linux... >> >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 >> jtreg:test/jdk:tier1 1899 1899 0 0 >> jtreg:test/langtools:tier1 3941 3941 0 0 >> jtreg:test/nashorn:tier1 0 0 0 0 >> jtreg:test/jaxp:tier1 0 0 0 0 >> ============================== >> TEST SUCCESS >> >> >> ... and with the `jdk/sun/security` tests too. >> >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/sun/security 656 656 0 0 >> ============================== >> TEST SUCCESS > > Build failure on macos is unrelated (see https://github.com/openjdk/jdk11u-dev/pull/2987) > @vieiro Please mention that it's a test only change for backports like these in the approval request going forward. This helps assess the risk when gauging the request for approval. Very true, thanks! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2993#issuecomment-2658905972 From duke at openjdk.org Fri Feb 14 10:25:22 2025 From: duke at openjdk.org (duke) Date: Fri, 14 Feb 2025 10:25:22 GMT Subject: [jdk11u-dev] RFR: 8339560: Unaddressed comments during code review of JDK-8337664 In-Reply-To: <3uoHcpXgTRtiqtJakRW4gaQ6YPc0JQ5nXaISyKDgVPU=.6ef22477-2b0d-4f39-b734-ee922fd074fd@github.com> References: <3uoHcpXgTRtiqtJakRW4gaQ6YPc0JQ5nXaISyKDgVPU=.6ef22477-2b0d-4f39-b734-ee922fd074fd@github.com> Message-ID: On Thu, 13 Feb 2025 17:46:52 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) that improves `Distrust.java` and reorganizes the directories of distrusted certificates. > > It will prove useful in order to ease the review of future backports such as upcoming [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) for next april 2025. > > Tested with tier1 tests in Linux... > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 > jtreg:test/jdk:tier1 1899 1899 0 0 > jtreg:test/langtools:tier1 3941 3941 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS > > > ... and with the `jdk/sun/security` tests too. > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 656 656 0 0 > ============================== > TEST SUCCESS @vieiro Your change (at version fd6b6bbe87ecce8f9be43652606bfe2c890f6f13) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2993#issuecomment-2658907044 From sgehwolf at openjdk.org Fri Feb 14 10:29:18 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 14 Feb 2025 10:29:18 GMT Subject: [jdk11u-dev] RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x [v2] In-Reply-To: References: Message-ID: On Tue, 4 Feb 2025 22:03:45 GMT, Antonio Vieiro wrote: >> Backport of [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316) to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded. >> >> This solves the problem in https://github.com/openjdk/jdk11u-dev/pull/2967#issuecomment-2538048579, so all tier1 tests are expected to pass in all GHA platforms. >> >> The change is not clean as there were merge conflicts in ProblemList.txt, as these usually differ between JDK versions (just dropped `8294316`). Also `add_map_info` has a different number of arguments in JDK11. > > Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport b0c130ba3aa443ca58e9bcda813a80e989632b93 > The change is not clean as there were merge conflicts in ProblemList.txt, as these usually differ between JDK versions (just dropped `8294316`). Also `add_map_info` has a different number of arguments in JDK11. Confirmed. Patch looks good to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2987#pullrequestreview-2617368674 From duke at openjdk.org Fri Feb 14 10:32:19 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 14 Feb 2025 10:32:19 GMT Subject: [jdk11u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 18:52:18 GMT, Antonio Vieiro wrote: > Almost clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. > > This is on top of [this previous PR](https://github.com/openjdk/jdk11u-dev/pull/2993) for [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) ("Unaddressed comments during code review of JDK-8337664"). > > The backport is not completely clean because it required a change in line 98 of `CamerfirmaTLSPolicy.java` since [JDK-8270946](https://bugs.openjdk.org/browse/JDK-8270946) has not been backported to 11. > > Passes `tier1` and `jdk/sun/security` tests: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 > jtreg:test/jdk:tier1 1899 1899 0 0 > jtreg:test/langtools:tier1 3941 3941 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 657 657 0 0 > ============================== > TEST SUCCESS - Test failures unrelated (see https://github.com/openjdk/jdk11u-dev/pull/2987). - [JDK-8270946](https://bugs.openjdk.org/browse/JDK-8270946) could be backported too from [JDK-17](https://github.com/openjdk/jdk17u/commit/facbabb2032aabed0cb52cfcdc6894db1358edbf) but I think the risk is too high for just a single-line fix. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2994#issuecomment-2658923174 From duke at openjdk.org Fri Feb 14 10:35:20 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 14 Feb 2025 10:35:20 GMT Subject: [jdk11u-dev] Integrated: 8339560: Unaddressed comments during code review of JDK-8337664 In-Reply-To: <3uoHcpXgTRtiqtJakRW4gaQ6YPc0JQ5nXaISyKDgVPU=.6ef22477-2b0d-4f39-b734-ee922fd074fd@github.com> References: <3uoHcpXgTRtiqtJakRW4gaQ6YPc0JQ5nXaISyKDgVPU=.6ef22477-2b0d-4f39-b734-ee922fd074fd@github.com> Message-ID: On Thu, 13 Feb 2025 17:46:52 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) that improves `Distrust.java` and reorganizes the directories of distrusted certificates. > > It will prove useful in order to ease the review of future backports such as upcoming [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) for next april 2025. > > Tested with tier1 tests in Linux... > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 > jtreg:test/jdk:tier1 1899 1899 0 0 > jtreg:test/langtools:tier1 3941 3941 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS > > > ... and with the `jdk/sun/security` tests too. > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 656 656 0 0 > ============================== > TEST SUCCESS This pull request has now been integrated. Changeset: 52c8606d Author: Antonio Vieiro Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/52c8606db4e81b9aa9c55a31e5f401e5e835c714 Stats: 932 lines in 26 files changed: 391 ins; 541 del; 0 mod 8339560: Unaddressed comments during code review of JDK-8337664 Backport-of: 6a3f208c0b32d90eb3853008301e680695d3ac28 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2993 From duke at openjdk.org Fri Feb 14 10:41:14 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 14 Feb 2025 10:41:14 GMT Subject: [jdk11u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs [v2] In-Reply-To: References: Message-ID: > Almost clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. > > This is on top of [this previous PR](https://github.com/openjdk/jdk11u-dev/pull/2993) for [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) ("Unaddressed comments during code review of JDK-8337664"). > > The backport is not completely clean because it required a change in line 98 of `CamerfirmaTLSPolicy.java` since [JDK-8270946](https://bugs.openjdk.org/browse/JDK-8270946) has not been backported to 11. > > Passes `tier1` and `jdk/sun/security` tests: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 > jtreg:test/jdk:tier1 1899 1899 0 0 > jtreg:test/langtools:tier1 3941 3941 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 657 657 0 0 > ============================== > TEST SUCCESS Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2994/files - new: https://git.openjdk.org/jdk11u-dev/pull/2994/files/2c483da7..2c483da7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2994&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2994&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2994.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2994/head:pull/2994 PR: https://git.openjdk.org/jdk11u-dev/pull/2994 From duke at openjdk.org Fri Feb 14 10:44:29 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 14 Feb 2025 10:44:29 GMT Subject: [jdk11u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs [v3] In-Reply-To: References: Message-ID: > Almost clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. > > This is on top of [this previous PR](https://github.com/openjdk/jdk11u-dev/pull/2993) for [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) ("Unaddressed comments during code review of JDK-8337664"). > > The backport is not completely clean because it required a change in line 98 of `CamerfirmaTLSPolicy.java` since [JDK-8270946](https://bugs.openjdk.org/browse/JDK-8270946) has not been backported to 11. > > Passes `tier1` and `jdk/sun/security` tests: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 > jtreg:test/jdk:tier1 1899 1899 0 0 > jtreg:test/langtools:tier1 3941 3941 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 657 657 0 0 > ============================== > TEST SUCCESS Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge master - Backport f4bef2f24a9bb433b5693aa59bb81acac6b311f3 - Backport 6a3f208c0b32d90eb3853008301e680695d3ac28 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2994/files - new: https://git.openjdk.org/jdk11u-dev/pull/2994/files/2c483da7..f78bb635 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2994&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2994&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2994.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2994/head:pull/2994 PR: https://git.openjdk.org/jdk11u-dev/pull/2994 From duke at openjdk.org Fri Feb 14 10:58:17 2025 From: duke at openjdk.org (duke) Date: Fri, 14 Feb 2025 10:58:17 GMT Subject: [jdk11u-dev] RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x [v2] In-Reply-To: References: Message-ID: On Tue, 4 Feb 2025 22:03:45 GMT, Antonio Vieiro wrote: >> Backport of [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316) to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded. >> >> This solves the problem in https://github.com/openjdk/jdk11u-dev/pull/2967#issuecomment-2538048579, so all tier1 tests are expected to pass in all GHA platforms. >> >> The change is not clean as there were merge conflicts in ProblemList.txt, as these usually differ between JDK versions (just dropped `8294316`). Also `add_map_info` has a different number of arguments in JDK11. > > Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport b0c130ba3aa443ca58e9bcda813a80e989632b93 @vieiro Your change (at version 0f91a2af342a70c9bfa4688bef52613e47406bcf) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2987#issuecomment-2658979487 From duke at openjdk.org Fri Feb 14 11:24:17 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 14 Feb 2025 11:24:17 GMT Subject: [jdk11u-dev] Integrated: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x In-Reply-To: References: Message-ID: <51pWTS4bNlyV2_1iCcD-lwjhN0JfcXguWgiuBZEEhWY=.7c223ccb-a97d-40b1-b977-ca72e4b130b3@github.com> On Mon, 13 Jan 2025 19:55:14 GMT, Antonio Vieiro wrote: > Backport of [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316) to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded. > > This solves the problem in https://github.com/openjdk/jdk11u-dev/pull/2967#issuecomment-2538048579, so all tier1 tests are expected to pass in all GHA platforms. > > The change is not clean as there were merge conflicts in ProblemList.txt, as these usually differ between JDK versions (just dropped `8294316`). Also `add_map_info` has a different number of arguments in JDK11. This pull request has now been integrated. Changeset: 7dab5fef Author: Antonio Vieiro Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/7dab5fef87bd1871c0a0b4872cb8d711bc927dd5 Stats: 16 lines in 2 files changed: 5 ins; 0 del; 11 mod 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x Reviewed-by: sgehwolf Backport-of: eaa475f72ced51cf0f0d0bce9ff1265bfb81ab31 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2987 From azvegint at openjdk.org Fri Feb 14 12:59:24 2025 From: azvegint at openjdk.org (Alexander Zvegintsev) Date: Fri, 14 Feb 2025 12:59:24 GMT Subject: [jdk24u] Integrated: 8348600: Update PipeWire to 1.3.81 In-Reply-To: References: Message-ID: <6ELjHW6U0vC7RzGxjMkM51W4U3DQRCpBvJ16k2KpYPg=.4c035036-aeda-4b2e-8cc4-d87882180418@github.com> On Thu, 13 Feb 2025 18:13:11 GMT, Alexander Zvegintsev wrote: > Hi all, > > This pull request contains a backport of commit [add3cd1c](https://github.com/openjdk/jdk/commit/add3cd1ca470be8fd5e5e1930d7f789318eb8e6d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zvegintsev on 13 Feb 2025 and was reviewed by Prasanta Sadhukhan, Phil Race and Harshitha Onkar. > > Thanks! This pull request has now been integrated. Changeset: e3d6b0ac Author: Alexander Zvegintsev URL: https://git.openjdk.org/jdk24u/commit/e3d6b0ac3d12d870c408fba1b5375917530f3e86 Stats: 2369 lines in 72 files changed: 1728 ins; 59 del; 582 mod 8348600: Update PipeWire to 1.3.81 Backport-of: add3cd1ca470be8fd5e5e1930d7f789318eb8e6d ------------- PR: https://git.openjdk.org/jdk24u/pull/76 From azvegint at openjdk.org Fri Feb 14 13:13:26 2025 From: azvegint at openjdk.org (Alexander Zvegintsev) Date: Fri, 14 Feb 2025 13:13:26 GMT Subject: [jdk24u] RFR: 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland Message-ID: Hi all, This pull request contains a backport of commit [6f4fc821](https://github.com/openjdk/jdk/commit/6f4fc82149b52dd91289fe42def7d1cacad31212) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alexander Zvegintsev on 3 Feb 2025 and was reviewed by Alexey Ivanov and Damon Nguyen. Thanks! ------------- Commit messages: - Backport 6f4fc82149b52dd91289fe42def7d1cacad31212 Changes: https://git.openjdk.org/jdk24u/pull/78/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=78&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348675 Stats: 204 lines in 4 files changed: 91 ins; 22 del; 91 mod Patch: https://git.openjdk.org/jdk24u/pull/78.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/78/head:pull/78 PR: https://git.openjdk.org/jdk24u/pull/78 From duke at openjdk.org Fri Feb 14 13:29:56 2025 From: duke at openjdk.org (Radek Cap) Date: Fri, 14 Feb 2025 13:29:56 GMT Subject: [jdk11u-dev] RFR: 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress Message-ID: <421WIzOjFit9t0rTacGZvQvsSW7OfJwoc3GWxtHYE_E=.d42f1ba6-32a4-41a2-b03f-860955a16f4a@github.com> Backport of JDK-8342496 - C2/Shenandoah: SEGV in compiled code when running jcstress It's fixing the java/lang/invoke/PrivateInvokeTest.java#PrivateInvokeTest failure. Clean backport. Passed tier 1 tests. Passed gtests. ------------- Commit messages: - Backport 955bae2b03055552237584aa7c68b1afcfa3b9c1 Changes: https://git.openjdk.org/jdk11u-dev/pull/2995/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2995&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342496 Stats: 70 lines in 2 files changed: 70 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2995.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2995/head:pull/2995 PR: https://git.openjdk.org/jdk11u-dev/pull/2995 From sgehwolf at openjdk.org Fri Feb 14 14:00:42 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 14 Feb 2025 14:00:42 GMT Subject: [jdk11u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs [v3] In-Reply-To: References: Message-ID: On Fri, 14 Feb 2025 10:44:29 GMT, Antonio Vieiro wrote: >> Almost clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. >> >> This is on top of [this previous PR](https://github.com/openjdk/jdk11u-dev/pull/2993) for [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) ("Unaddressed comments during code review of JDK-8337664"). >> >> The backport is not completely clean because it required a change in line 98 of `CamerfirmaTLSPolicy.java` since [JDK-8270946](https://bugs.openjdk.org/browse/JDK-8270946) has not been backported to 11. >> >> Passes `tier1` and `jdk/sun/security` tests: >> >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 >> jtreg:test/jdk:tier1 1899 1899 0 0 >> jtreg:test/langtools:tier1 3941 3941 0 0 >> jtreg:test/nashorn:tier1 0 0 0 0 >> jtreg:test/jaxp:tier1 0 0 0 0 >> ============================== >> TEST SUCCESS >> >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/sun/security 657 657 0 0 >> ============================== >> TEST SUCCESS > > Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge master > - Backport f4bef2f24a9bb433b5693aa59bb81acac6b311f3 > - Backport 6a3f208c0b32d90eb3853008301e680695d3ac28 LGTM. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2994#pullrequestreview-2617872346 From sgehwolf at openjdk.org Fri Feb 14 14:00:43 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 14 Feb 2025 14:00:43 GMT Subject: [jdk11u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs [v2] In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 18:54:32 GMT, Antonio Vieiro wrote: >> Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. > > src/java.base/share/classes/sun/security/validator/CamerfirmaTLSPolicy.java line 98: > >> 96: >> 97: private static String fingerprint(X509Certificate cert) { >> 98: return X509CertImpl.getFingerprint("SHA-256", cert); > > This reads > > return X509CertImpl.getFingerprint("SHA-256", cert, debug); > > in JDK-17 and above. Right. Confirmed. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2994#discussion_r1956190397 From sgehwolf at openjdk.org Fri Feb 14 14:05:17 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 14 Feb 2025 14:05:17 GMT Subject: [jdk11u-dev] RFR: 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress In-Reply-To: <421WIzOjFit9t0rTacGZvQvsSW7OfJwoc3GWxtHYE_E=.d42f1ba6-32a4-41a2-b03f-860955a16f4a@github.com> References: <421WIzOjFit9t0rTacGZvQvsSW7OfJwoc3GWxtHYE_E=.d42f1ba6-32a4-41a2-b03f-860955a16f4a@github.com> Message-ID: <8mtGu98Q4cb6g-LK5qUp6TrgR3WVSF1-6nMQbBR7KHI=.de98ba34-e15a-489c-b49b-5c3bc0125dd1@github.com> On Fri, 14 Feb 2025 13:24:35 GMT, Radek Cap wrote: > Backport of JDK-8342496 - C2/Shenandoah: SEGV in compiled code when running jcstress > > It's fixing the java/lang/invoke/PrivateInvokeTest.java#PrivateInvokeTest failure. > > Clean backport. > Passed tier 1 tests. > Passed gtests. @RadekCap Did you run the test without the patch an with it? If so what were the results? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2995#issuecomment-2659417306 From duke at openjdk.org Fri Feb 14 14:08:15 2025 From: duke at openjdk.org (Radek Cap) Date: Fri, 14 Feb 2025 14:08:15 GMT Subject: [jdk11u-dev] RFR: 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress In-Reply-To: <421WIzOjFit9t0rTacGZvQvsSW7OfJwoc3GWxtHYE_E=.d42f1ba6-32a4-41a2-b03f-860955a16f4a@github.com> References: <421WIzOjFit9t0rTacGZvQvsSW7OfJwoc3GWxtHYE_E=.d42f1ba6-32a4-41a2-b03f-860955a16f4a@github.com> Message-ID: On Fri, 14 Feb 2025 13:24:35 GMT, Radek Cap wrote: > Backport of JDK-8342496 - C2/Shenandoah: SEGV in compiled code when running jcstress > > Clean backport. > Passed tier 1 tests. > Passed gtests. No, because in the bug 11is listed as an affected version. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2995#issuecomment-2659424308 From duke at openjdk.org Fri Feb 14 14:12:12 2025 From: duke at openjdk.org (Radek Cap) Date: Fri, 14 Feb 2025 14:12:12 GMT Subject: [jdk11u-dev] RFR: 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress In-Reply-To: <421WIzOjFit9t0rTacGZvQvsSW7OfJwoc3GWxtHYE_E=.d42f1ba6-32a4-41a2-b03f-860955a16f4a@github.com> References: <421WIzOjFit9t0rTacGZvQvsSW7OfJwoc3GWxtHYE_E=.d42f1ba6-32a4-41a2-b03f-860955a16f4a@github.com> Message-ID: On Fri, 14 Feb 2025 13:24:35 GMT, Radek Cap wrote: > Backport of JDK-8342496 - C2/Shenandoah: SEGV in compiled code when running jcstress > > Clean backport. > Passed tier 1 tests. > Passed gtests. ("It's fixing the java/lang/invoke/PrivateInvokeTest.java#PrivateInvokeTest failure." has been removed from the first comment as it was relict from the template which shouldn't be there.) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2995#issuecomment-2659432057 From adinn at openjdk.org Fri Feb 14 14:23:26 2025 From: adinn at openjdk.org (Andrew Dinn) Date: Fri, 14 Feb 2025 14:23:26 GMT Subject: [jdk21u-dev] RFR: 8180450: secondary_super_cache does not scale well [v2] In-Reply-To: <_D9aTO2W__r3NuVKXmmJwKJhKbvWqANESx3O6weLgi0=.51bb7244-5f76-460f-97ff-6a24b87e67c4@github.com> References: <4LeEOVL3OM57vpgMH9YTOBgyGCucK3L6iWC0XGD60ZQ=.10c0f7c0-897d-45ec-b105-5c4467890d74@github.com> <_D9aTO2W__r3NuVKXmmJwKJhKbvWqANESx3O6weLgi0=.51bb7244-5f76-460f-97ff-6a24b87e67c4@github.com> Message-ID: On Tue, 11 Feb 2025 09:47:29 GMT, Andrew Haley wrote: >> See [8180450](https://github.com/openjdk/jdk/pull/18309) for a full description of how this works. >> This is a pretty clean backport, but a few files had to be fiddled manually because things had been added nearby. >> >> This PR also includes a fix for [[8337958](https://bugs.openjdk.org/browse/JDK-8337958)](https://bugs.openjdk.org/browse/JDK-8337958), which was a minor bug in the original commit. >> >> For a justification of why this PR should be backported to JDK 21u, see >> [Franz's email](https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-October/038649.html). > > Andrew Haley has updated the pull request incrementally with one additional commit since the last revision: > > Add check Good to go ------------- Marked as reviewed by adinn (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1090#pullrequestreview-2617932889 From sgehwolf at openjdk.org Fri Feb 14 14:28:11 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 14 Feb 2025 14:28:11 GMT Subject: [jdk11u-dev] RFR: 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress In-Reply-To: References: <421WIzOjFit9t0rTacGZvQvsSW7OfJwoc3GWxtHYE_E=.d42f1ba6-32a4-41a2-b03f-860955a16f4a@github.com> Message-ID: <5Xlz3KFHszOyiNBA80IdItoqkn5yZnD2dFn8dt82DZk=.79a4538c-6404-4645-baee-c93ff9ea6404@github.com> On Fri, 14 Feb 2025 14:05:44 GMT, Radek Cap wrote: > No, because in the bug 11is listed as an affected version. Please do so. In fact, it's the least one should do to sanity-check a patch. I'm not sure whether this test has been run on JDK 11. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2995#issuecomment-2659473984 From duke at openjdk.org Fri Feb 14 16:13:24 2025 From: duke at openjdk.org (duke) Date: Fri, 14 Feb 2025 16:13:24 GMT Subject: [jdk11u-dev] RFR: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs [v3] In-Reply-To: References: Message-ID: On Fri, 14 Feb 2025 10:44:29 GMT, Antonio Vieiro wrote: >> Almost clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. >> >> This is on top of [this previous PR](https://github.com/openjdk/jdk11u-dev/pull/2993) for [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) ("Unaddressed comments during code review of JDK-8337664"). >> >> The backport is not completely clean because it required a change in line 98 of `CamerfirmaTLSPolicy.java` since [JDK-8270946](https://bugs.openjdk.org/browse/JDK-8270946) has not been backported to 11. >> >> Passes `tier1` and `jdk/sun/security` tests: >> >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 >> jtreg:test/jdk:tier1 1899 1899 0 0 >> jtreg:test/langtools:tier1 3941 3941 0 0 >> jtreg:test/nashorn:tier1 0 0 0 0 >> jtreg:test/jaxp:tier1 0 0 0 0 >> ============================== >> TEST SUCCESS >> >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/sun/security 657 657 0 0 >> ============================== >> TEST SUCCESS > > Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge master > - Backport f4bef2f24a9bb433b5693aa59bb81acac6b311f3 > - Backport 6a3f208c0b32d90eb3853008301e680695d3ac28 @vieiro Your change (at version f78bb635d23ec7f6ff56aed062e88b580d4a4feb) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2994#issuecomment-2659732370 From duke at openjdk.org Fri Feb 14 16:24:21 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 14 Feb 2025 16:24:21 GMT Subject: [jdk11u-dev] Integrated: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 18:52:18 GMT, Antonio Vieiro wrote: > Almost clean backport of [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) to distrust TLS server certificates issued after April 15, 2025 and anchored by Camerfirma Root CAs. > > This is on top of [this previous PR](https://github.com/openjdk/jdk11u-dev/pull/2993) for [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) ("Unaddressed comments during code review of JDK-8337664"). > > The backport is not completely clean because it required a change in line 98 of `CamerfirmaTLSPolicy.java` since [JDK-8270946](https://bugs.openjdk.org/browse/JDK-8270946) has not been backported to 11. > > Passes `tier1` and `jdk/sun/security` tests: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 > jtreg:test/jdk:tier1 1899 1899 0 0 > jtreg:test/langtools:tier1 3941 3941 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 657 657 0 0 > ============================== > TEST SUCCESS This pull request has now been integrated. Changeset: 8322c66e Author: Antonio Vieiro Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/8322c66efa9da9210eca7d6081d2a8c2d65ba4e0 Stats: 392 lines in 8 files changed: 388 ins; 0 del; 4 mod 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs Reviewed-by: sgehwolf Backport-of: f4bef2f24a9bb433b5693aa59bb81acac6b311f3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2994 From sgehwolf at redhat.com Fri Feb 14 17:45:15 2025 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Fri, 14 Feb 2025 18:45:15 +0100 Subject: [jdk21u-dev] Backport the fix of JDK-8180450 to JDK 21u? In-Reply-To: <68b3e73f-5a61-4b37-82cd-bc8f6048700e@littlepinkcloud.com> References: <5a63c606-552d-4b3d-bc76-3e05e7403099@littlepinkcloud.com> <68b3e73f-5a61-4b37-82cd-bc8f6048700e@littlepinkcloud.com> Message-ID: On Thu, 2024-10-24 at 11:48 +0100, Andrew Haley wrote: > [ Added the correct subject: this is 21u, not 11u ] > > On 10/17/24 09:14, Lindenmaier, Goetz wrote: > > So I think while we could consider this for the latest LTE, 21, > > we should not bring this to 17 or older releases.? It's just too > > risky for these. > > Even for 21 it would be a considerable effort to backport it > > along with the needed follow-up issues. > > I have created a draft backport at https://github.com/openjdk/jdk21u-dev/pull/1090. > It applies cleanly except for a few places where surrounding code had moved. > > I am not pushing for this to be included in 21u, but I have been speaking to Java > developers who have been adversely affected by the problem this patch fixes, who > seem quite keen to have it. Several significant Java projects are affected. I'm OK for this to go into JDK 21u (x86_64 and aarch). Since it's a fairly large change I'd suggest for it to integrate early in the 21.0.8 dev cycle (release in July 2025 CPU) to increase the chance bake time and test time. Thoughts? Thanks, Severin From sgehwolf at redhat.com Fri Feb 14 18:05:38 2025 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Fri, 14 Feb 2025 19:05:38 +0100 Subject: [21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected In-Reply-To: References: <1e30742239badd10d071ed9f5d591763a92a1990.camel@redhat.com> Message-ID: <744c5981746193fd5c1f4c4f1b92fd7d5e851eca.camel@redhat.com> Hi, This is a rather invasive patch set. Is this something that Azul ships in the downstream distribution? On Fri, 2025-02-07 at 21:13 +0800, Jan Kratochvil wrote: > On Mon, 20 Jan 2025 17:58:01 +0800, Severin Gehwolf wrote: > > You didn't say *why* you'd like to backport it > > https://bugs.openjdk.org/browse/JDK-8322420 > The following text is based on: > https://mail.openjdk.org/pipermail/jdk-updates-dev/2022-February/012398.html > > cgroups v2 support hierarchical groups. Limits from outer groups apply also > for the inner groups. To calculate an effective limit for the current nested > group one needs to calculate a minimum of all the limits in the current group > and its parent groups up to the root one. > > The risk of NOT backporting those patches is that the JVM would wrongly detect > resource limits. Container detection code would just give up early and would > use the host systems' resource limits instead. Random OOM kills and other > strange behaviour can happen. Surely this only applies to systems that have such a setup (of hierarchical cgroups), not cgroup limits in general. Common container frameworks (kubernetes) aren't affected AFAIK (I might be wrong, though). The risk is a function of such affected systems. Would you have any estimation of the affected systems out in the wild? That would help assess this. > As the code is the same in 21u as in 24u and all the backports are clean I do > not expect regressions. JDK 24 hasn't been officially released yet, so the proposed patches haven't seen much real-world usage yet. > If pre-approved I need to submit those patches as separate backports. OK. > I find the April release as the suitable one. I don't think that's a good time-frame. For one, JDK 24 hasn't been released. For two, we are already fairly late in the April CPU development cycle. Let's reconsider this for a later release. Thanks, Severin From duke at openjdk.org Fri Feb 14 18:57:10 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 14 Feb 2025 18:57:10 GMT Subject: [jdk11u-dev] RFR: 8342988: GHA: Build JTReg in single step Message-ID: Backport of [JDK-8349829](https://bugs.openjdk.org/browse/JDK-8349829) from 17u to build jtreg and cache it for subsequent builds. Low risk (only GHA actions affected). The backport is not clean as [JDK-8338286](https://bugs.openjdk.org/browse/JDK-8338286) has not been backported to JDK-11, on purpose. Also `JAVA_HOME_11_X64` is being used now to build `jtreg`. As expected jtreg is now being built & cached in subsequent builds: 2025-02-14T17:08:58.4041646Z Cache hit for: jtreg-7.3.1+1 2025-02-14T17:08:58.6790456Z Received 9265658 of 9265658 (100.0%), 42.7 MBs/sec 2025-02-14T17:08:58.6791682Z Cache Size: ~9 MB (9265658 B) 2025-02-14T17:08:58.6819135Z [command]/usr/bin/tar -xf /home/runner/work/_temp/fe85d627-93f0-40be-9ba4-b41aadc9f6ed/cache.tzst -P -C /home/runner/work/jdk11u-dev/jdk11u-dev --use-compress-program unzstd 2025-02-14T17:08:58.7115863Z Cache restored successfully 2025-02-14T17:08:58.7298813Z Cache restored from key: jtreg-7.3.1+1 All tests pass but I detected an intermittent time- out in serviceability agent in macos (possibly because of [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389)? despite JDK-8294316 having been already integrated. This is under investigation). 2025-02-14T17:48:43.0846500Z -------------------------------------------------- 2025-02-14T17:48:46.6648080Z TEST: serviceability/sa/ClhsdbFindPC.java#id0 2025-02-14T17:48:46.6661380Z build: 0.886 seconds 2025-02-14T17:48:46.6662400Z compile: 0.886 seconds 2025-02-14T17:48:46.6663300Z main: 34.198 seconds 2025-02-14T17:48:46.6664240Z TEST RESULT: Passed. Execution successful 2025-02-14T17:48:46.6665470Z -------------------------------------------------- 2025-02-14T17:49:24.4350100Z TEST: serviceability/sa/ClhsdbFindPC.java#id2 2025-02-14T17:49:24.4351780Z build: 0.653 seconds 2025-02-14T17:49:24.4352850Z compile: 0.653 seconds 2025-02-14T17:49:24.4353430Z main: 31.826 seconds 2025-02-14T17:49:24.4353820Z TEST RESULT: Passed. Execution successful 2025-02-14T17:49:24.4354390Z -------------------------------------------------- 2025-02-14T17:50:36.6580860Z TEST: serviceability/sa/ClhsdbFindPC.java#id1 2025-02-14T17:50:36.6582200Z TEST JDK: /Users/runner/work/jdk11u-dev/jdk11u-dev/bundles/jdk/jdk-11.0.27/fastdebug ... 2025-02-14T17:50:36.6836040Z TEST RESULT: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Test ERROR java.io.IOException: App waiting timeout 2025-02-14T17:50:36.6837390Z -------------------------------------------------- 2025-02-14T17:51:15.1063160Z TEST: serviceability/sa/ClhsdbFindPC.java#id3 2025-02-14T17:51:15.1461480Z build: 2.91 seconds 2025-02-14T17:51:15.1520520Z compile: 2.909 seconds 2025-02-14T17:51:15.1535170Z main: 102.784 seconds 2025-02-14T17:51:15.1536860Z TEST RESULT: Passed. Execution successful ------------- Commit messages: - Backport 087e8a29f2aead8b31a71b144523810c8538388c Changes: https://git.openjdk.org/jdk11u-dev/pull/2996/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2996&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342988 Stats: 83 lines in 3 files changed: 81 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2996.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2996/head:pull/2996 PR: https://git.openjdk.org/jdk11u-dev/pull/2996 From duke at openjdk.org Fri Feb 14 18:58:19 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 14 Feb 2025 18:58:19 GMT Subject: [jdk11u-dev] RFR: 8341424: GHA: Collect hs_errs from build time failures In-Reply-To: References: Message-ID: On Thu, 2 Jan 2025 09:40:10 GMT, Antonio Vieiro wrote: > Backport of [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424) and companion [JDK-8342704](https://bugs.openjdk.org/browse/JDK-8342704) > > This collects hs_errs when they happen with GitHub Actions, which may be useful during reviews. > > Low risk, as this affects GHA actions only. GHA builds and tests run correctly. Let's keep this open. It may prove valuable in the future. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2982#issuecomment-2660052084 From mdoerr at openjdk.org Fri Feb 14 20:19:24 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 14 Feb 2025 20:19:24 GMT Subject: [jdk24u] RFR: 8349751: AIX build failure after upgrade pipewire to 1.3.81 Message-ID: Clean backport of [JDK-8349751](https://bugs.openjdk.org/browse/JDK-8349751). ------------- Commit messages: - Backport 19c0ce43e258d00d77314d76a361feb2069a5af1 Changes: https://git.openjdk.org/jdk24u/pull/79/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=79&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349751 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk24u/pull/79.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/79/head:pull/79 PR: https://git.openjdk.org/jdk24u/pull/79 From tobias.hartmann at oracle.com Sat Feb 15 13:34:48 2025 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Sat, 15 Feb 2025 14:34:48 +0100 Subject: Result: New JDK Updates Committer: Damon Fenacci Message-ID: <3d824e5b-85c6-45df-b31f-a29b6a9e05ae@oracle.com> Voting [1] for Damon Fenacci [2] is now closed. Yes: 11 Veto: 0 Abstain: 0 According to the bylaw's definition of Lazy Consensus [3], this is sufficient to approve the nomination. Thanks, Tobias [1] https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-January/040996.html [2] https://openjdk.org/census#dfenacci [3] https://openjdk.org/bylaws#lazy-consensus From goetz at openjdk.org Sat Feb 15 14:49:18 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 15 Feb 2025 14:49:18 GMT Subject: [jdk21u-dev] RFR: 8325730: StringBuilder.toString allocation for the empty String In-Reply-To: References: Message-ID: On Wed, 5 Feb 2025 13:43:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. Closing this as it violates the standart of 21, and Oracle backs out the backport of this change from 21. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1387#issuecomment-2660954194 From goetz at openjdk.org Sat Feb 15 14:49:19 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 15 Feb 2025 14:49:19 GMT Subject: [jdk21u-dev] Withdrawn: 8325730: StringBuilder.toString allocation for the empty String In-Reply-To: References: Message-ID: On Wed, 5 Feb 2025 13:43:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1387 From duke at openjdk.org Mon Feb 17 03:03:14 2025 From: duke at openjdk.org (duke) Date: Mon, 17 Feb 2025 03:03:14 GMT Subject: [jdk24u] RFR: 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out In-Reply-To: References: Message-ID: <8NxdO5fqRVKqqyCQcgNWPvHtom0ctkuTZqTimjGfUPc=.9a9879b5-d97b-4202-ac2d-a96c0f07ebc6@github.com> On Mon, 3 Feb 2025 11:17:48 GMT, PAWAN CHAWDHARY wrote: > 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out @pawanchawdhary1 Your change (at version b7dbd9167a386e5f6f6e116dcaef1212b1f081ab) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/42#issuecomment-2661854227 From thartmann at openjdk.org Mon Feb 17 06:18:20 2025 From: thartmann at openjdk.org (Tobias Hartmann) Date: Mon, 17 Feb 2025 06:18:20 GMT Subject: [jdk24u] Integrated: 8347718: Unexpected NullPointerException in C2 compiled code due to ReduceAllocationMerges In-Reply-To: References: Message-ID: On Mon, 10 Feb 2025 08:07:01 GMT, Tobias Hartmann wrote: > Hi all, > > This pull request contains a backport of commit [9f4d3de4](https://github.com/openjdk/jdk/commit/9f4d3de442a846c503dac52de4a757e5b5638e73) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Cesar Soares Lucas on 28 Jan 2025 and was reviewed by Vladimir Kozlov and Tobias Hartmann. > > Thanks! This pull request has now been integrated. Changeset: d8feb0f3 Author: Tobias Hartmann URL: https://git.openjdk.org/jdk24u/commit/d8feb0f3ecc80b93cf3fd36f825260d21d3ef4b0 Stats: 74 lines in 2 files changed: 71 ins; 0 del; 3 mod 8347718: Unexpected NullPointerException in C2 compiled code due to ReduceAllocationMerges Backport-of: 9f4d3de442a846c503dac52de4a757e5b5638e73 ------------- PR: https://git.openjdk.org/jdk24u/pull/65 From duke at openjdk.org Mon Feb 17 09:45:18 2025 From: duke at openjdk.org (duke) Date: Mon, 17 Feb 2025 09:45:18 GMT Subject: [jdk21u-dev] RFR: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected" In-Reply-To: References: Message-ID: On Fri, 14 Feb 2025 09:55:46 GMT, Joachim Kern wrote: > Hi all, > This pull request contains a backport of commit [f9b11332](https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk%2Fcommit%2Ff9b11332eccd8a8ffb4128308f442b209d07a3b1&data=05%7C02%7Cjoachim.kern%40sap.com%7Cbe715ba6412b406e359b08dd4cdd34eb%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C638751235135819397%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=mvtI1vdJ41owt0%2BgXarMbCRuhHukZDrYLBdDusX4%2B3M%3D&reserved=0) from the [openjdk/jdk](https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.openjdk.org%2Fjdk&data=05%7C02%7Cjoachim.kern%40sap.com%7Cbe715ba6412b406e359b08dd4cdd34eb%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C638751235135832802%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=6UjioNHwX7Gmrc9OGyQBLaygd0A2kRyELgmiHtvSzUc%3D&reserved=0) repository. > The commit being backported was authored by Joachim Kern on 9 Jan 2025 and was reviewed by Martin Doerr, Christoph Langer and Matthias Baesken. > Thanks! @JoKern65 Your change (at version b8c69a9925b47b9d2edd1d96c167c1b9d8c6b789) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1404#issuecomment-2662567095 From jkern at openjdk.org Mon Feb 17 09:53:22 2025 From: jkern at openjdk.org (Joachim Kern) Date: Mon, 17 Feb 2025 09:53:22 GMT Subject: [jdk21u-dev] Integrated: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected" In-Reply-To: References: Message-ID: On Fri, 14 Feb 2025 09:55:46 GMT, Joachim Kern wrote: > Hi all, > This pull request contains a backport of commit [f9b11332](https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk%2Fcommit%2Ff9b11332eccd8a8ffb4128308f442b209d07a3b1&data=05%7C02%7Cjoachim.kern%40sap.com%7Cbe715ba6412b406e359b08dd4cdd34eb%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C638751235135819397%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=mvtI1vdJ41owt0%2BgXarMbCRuhHukZDrYLBdDusX4%2B3M%3D&reserved=0) from the [openjdk/jdk](https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.openjdk.org%2Fjdk&data=05%7C02%7Cjoachim.kern%40sap.com%7Cbe715ba6412b406e359b08dd4cdd34eb%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C638751235135832802%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=6UjioNHwX7Gmrc9OGyQBLaygd0A2kRyELgmiHtvSzUc%3D&reserved=0) repository. > The commit being backported was authored by Joachim Kern on 9 Jan 2025 and was reviewed by Martin Doerr, Christoph Langer and Matthias Baesken. > Thanks! This pull request has now been integrated. Changeset: a4998f84 Author: Joachim Kern Committer: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/a4998f847bac6308a59e9928b33e2dae9dbe1f27 Stats: 18 lines in 1 file changed: 17 ins; 0 del; 1 mod 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected" Backport-of: f9b11332eccd8a8ffb4128308f442b209d07a3b1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1404 From mbaesken at openjdk.org Mon Feb 17 11:43:23 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 17 Feb 2025 11:43:23 GMT Subject: [jdk21u-dev] Integrated: 8338303: Linux ppc64le with toolchain clang - detection failure in early JVM startup In-Reply-To: <_nCfb8ay5ndj5RC1A283DP5SYXFrVrzaiR0yDHJ626s=.0c20511e-e739-43c0-8623-e3a781c17ffb@github.com> References: <_nCfb8ay5ndj5RC1A283DP5SYXFrVrzaiR0yDHJ626s=.0c20511e-e739-43c0-8623-e3a781c17ffb@github.com> Message-ID: On Wed, 12 Feb 2025 13:49:06 GMT, Matthias Baesken wrote: > 8338303: Linux ppc64le with toolchain clang - detection failure in early JVM startup This pull request has now been integrated. Changeset: b7d92cd0 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/b7d92cd0ae781de6c51ea965c16bd6e0c396e9f7 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod 8338303: Linux ppc64le with toolchain clang - detection failure in early JVM startup Backport-of: 70eec9001a550888f35476f9e2cf3c62d41442dd ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1402 From mbaesken at openjdk.org Mon Feb 17 12:16:20 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 17 Feb 2025 12:16:20 GMT Subject: [jdk24u] Integrated: 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64 In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 13:51:41 GMT, Matthias Baesken wrote: > 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64 This pull request has now been integrated. Changeset: d06d7a49 Author: Matthias Baesken URL: https://git.openjdk.org/jdk24u/commit/d06d7a49e941c4316789a4c82e532a6fd0447bf7 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64 Backport-of: 0285020c7ea01f32b32efe166a0a5dae39957216 ------------- PR: https://git.openjdk.org/jdk24u/pull/68 From mbaesken at openjdk.org Mon Feb 17 12:23:00 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 17 Feb 2025 12:23:00 GMT Subject: [jdk21u-dev] RFR: 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64 Message-ID: 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64 ------------- Commit messages: - Backport 0285020c7ea01f32b32efe166a0a5dae39957216 Changes: https://git.openjdk.org/jdk21u-dev/pull/1405/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1405&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345676 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1405.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1405/head:pull/1405 PR: https://git.openjdk.org/jdk21u-dev/pull/1405 From mbaesken at openjdk.org Mon Feb 17 12:57:47 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 17 Feb 2025 12:57:47 GMT Subject: [jdk21u-dev] RFR: 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer Message-ID: 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer ------------- Commit messages: - Backport 82e16ba248a97e3446d5b2d64c353b61dd6bdda6 Changes: https://git.openjdk.org/jdk21u-dev/pull/1406/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1406&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347268 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1406.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1406/head:pull/1406 PR: https://git.openjdk.org/jdk21u-dev/pull/1406 From mbaesken at openjdk.org Mon Feb 17 13:00:22 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 17 Feb 2025 13:00:22 GMT Subject: [jdk24u] Integrated: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero In-Reply-To: References: Message-ID: <3LFCtUlFseYD3GAXGqxg76SUHGRBkyiUWD94SyRWRAk=.12220849-7471-4613-876d-b6ab819f6beb@github.com> On Wed, 5 Feb 2025 12:27:25 GMT, Matthias Baesken wrote: > 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero This pull request has now been integrated. Changeset: e8808b77 Author: Matthias Baesken URL: https://git.openjdk.org/jdk24u/commit/e8808b775339750eb787d4594f729e4002314604 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero Backport-of: 5e92a4ceafd0626e3600e44a3370ca2f5d9347c8 ------------- PR: https://git.openjdk.org/jdk24u/pull/52 From azvegint at openjdk.org Mon Feb 17 13:03:24 2025 From: azvegint at openjdk.org (Alexander Zvegintsev) Date: Mon, 17 Feb 2025 13:03:24 GMT Subject: [jdk24u] Integrated: 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland In-Reply-To: References: Message-ID: On Fri, 14 Feb 2025 13:08:47 GMT, Alexander Zvegintsev wrote: > Hi all, > > This pull request contains a backport of commit [6f4fc821](https://github.com/openjdk/jdk/commit/6f4fc82149b52dd91289fe42def7d1cacad31212) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zvegintsev on 3 Feb 2025 and was reviewed by Alexey Ivanov and Damon Nguyen. > > Thanks! This pull request has now been integrated. Changeset: a6de59e4 Author: Alexander Zvegintsev URL: https://git.openjdk.org/jdk24u/commit/a6de59e47f797082e68ca109eab9a04f4d7d572e Stats: 204 lines in 4 files changed: 91 ins; 22 del; 91 mod 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland Backport-of: 6f4fc82149b52dd91289fe42def7d1cacad31212 ------------- PR: https://git.openjdk.org/jdk24u/pull/78 From mbaesken at openjdk.org Mon Feb 17 13:09:28 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 17 Feb 2025 13:09:28 GMT Subject: [jdk21u-dev] RFR: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero Message-ID: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero ------------- Commit messages: - Backport 5e92a4ceafd0626e3600e44a3370ca2f5d9347c8 Changes: https://git.openjdk.org/jdk21u-dev/pull/1407/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1407&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347267 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1407.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1407/head:pull/1407 PR: https://git.openjdk.org/jdk21u-dev/pull/1407 From adinn at redhat.com Mon Feb 17 13:49:42 2025 From: adinn at redhat.com (Andrew Dinn) Date: Mon, 17 Feb 2025 13:49:42 +0000 Subject: [jdk21u-dev] Backport the fix of JDK-8180450 to JDK 21u? In-Reply-To: References: <5a63c606-552d-4b3d-bc76-3e05e7403099@littlepinkcloud.com> <68b3e73f-5a61-4b37-82cd-bc8f6048700e@littlepinkcloud.com> Message-ID: <1d3f6702-837a-4e1c-b6e5-94fce9d20dff@redhat.com> On 14/02/2025 17:45, Severin Gehwolf wrote: > I'm OK for this to go into JDK 21u (x86_64 and aarch). Since it's a > fairly large change I'd suggest for it to integrate early in the 21.0.8 > dev cycle (release in July 2025 CPU) to increase the chance bake time > and test time. > > Thoughts? I agree this should go in. As you say the earlier in the cycle the better. regards, Andrew Dinn ----------- Red Hat Distinguished Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill From duke at openjdk.org Mon Feb 17 16:34:40 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 17 Feb 2025 16:34:40 GMT Subject: [jdk11u-dev] RFR: 8051959: Add thread and timestamp options to java.security.debug system property Message-ID: <8zevx5ak4TVIJGHt01qlLt3WWn_SsJNWCvgVPuN9784=.bf83fd95-d4e8-472a-9fee-b4edd31a73b7@github.com> Almost clean backport of [JDK-8051959](https://bugs.openjdk.org/browse/JDK-8051959) that adds options to `java.security.debug` to enhance traces with thread, log record and timestamp information, improving traceability and easying troubleshooting, on par with ["The java.security.debug System Property" in JDK17](https://docs.oracle.com/en/java/javase/17/security/troubleshooting-security.html#GUID-05F3E865-20FF-46EB-AC35-84D4B552CA48) and above, and with 11.0.26-oracle. Low risk. Backport is not completely clean because, among other things, [JDK-8292177](https://bugs.openjdk.org/browse/JDK-8292177) was applied differently in 11 (also `HexFormat` is not in 11). One of the tests cases had to be changed, since JDK11 does not keep track of [Security#initialSystemProperties](https://github.com/openjdk/jdk17u-dev/blob/fcdcff0e0d6a25de5e1c3bd62ba909774663b0db/src/java.base/share/classes/java/security/Security.java#L68) and thus searching for [`properties: Initial`](https://github.com/openjdk/jdk17u-dev/blob/fcdcff0e0d6a25de5e1c3bd62ba909774663b0db/test/jdk/sun/security/util/Debug/DebugOptions.java#L50) in the test `stderr` makes no sense. We're searching for `properties: java.security` instead (this is indicated in the github PR). Tested on Linux with tier1... ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 jtreg:test/jdk:tier1 1899 1899 0 0 jtreg:test/langtools:tier1 3941 3941 0 0 jtreg:test/nashorn:tier1 0 0 0 0 jtreg:test/jaxp:tier1 0 0 0 0 ============================== TEST SUCCESS ... and security tests ... ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/sun/security 658 658 0 0 ============================== TEST SUCCESS ------------- Commit messages: - Backport f277b3999f8cd30d5874ce58f290a06538d0189f Changes: https://git.openjdk.org/jdk11u-dev/pull/2998/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2998&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8051959 Stats: 244 lines in 2 files changed: 224 ins; 7 del; 13 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2998.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2998/head:pull/2998 PR: https://git.openjdk.org/jdk11u-dev/pull/2998 From duke at openjdk.org Mon Feb 17 16:34:40 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 17 Feb 2025 16:34:40 GMT Subject: [jdk11u-dev] RFR: 8051959: Add thread and timestamp options to java.security.debug system property In-Reply-To: <8zevx5ak4TVIJGHt01qlLt3WWn_SsJNWCvgVPuN9784=.bf83fd95-d4e8-472a-9fee-b4edd31a73b7@github.com> References: <8zevx5ak4TVIJGHt01qlLt3WWn_SsJNWCvgVPuN9784=.bf83fd95-d4e8-472a-9fee-b4edd31a73b7@github.com> Message-ID: On Mon, 17 Feb 2025 16:27:04 GMT, Antonio Vieiro wrote: > Almost clean backport of [JDK-8051959](https://bugs.openjdk.org/browse/JDK-8051959) that adds options to `java.security.debug` to enhance traces with thread, log record and timestamp information, improving traceability and easying troubleshooting, on par with ["The java.security.debug System Property" in JDK17](https://docs.oracle.com/en/java/javase/17/security/troubleshooting-security.html#GUID-05F3E865-20FF-46EB-AC35-84D4B552CA48) and above, and with 11.0.26-oracle. Low risk. > > Backport is not completely clean because, among other things, [JDK-8292177](https://bugs.openjdk.org/browse/JDK-8292177) was applied differently in 11 (also `HexFormat` is not in 11). > > One of the tests cases had to be changed, since JDK11 does not keep track of [Security#initialSystemProperties](https://github.com/openjdk/jdk17u-dev/blob/fcdcff0e0d6a25de5e1c3bd62ba909774663b0db/src/java.base/share/classes/java/security/Security.java#L68) and thus searching for [`properties: Initial`](https://github.com/openjdk/jdk17u-dev/blob/fcdcff0e0d6a25de5e1c3bd62ba909774663b0db/test/jdk/sun/security/util/Debug/DebugOptions.java#L50) in the test `stderr` makes no sense. We're searching for `properties: java.security` instead (this is indicated in the github PR). > > Tested on Linux with tier1... > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 > jtreg:test/jdk:tier1 1899 1899 0 0 > jtreg:test/langtools:tier1 3941 3941 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS > > > ... and security tests ... > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 658 658 0 0 > ============================== > TEST SUCCESS test/jdk/sun/security/util/Debug/DebugOptions.java line 51: > 49: // no extra info present > 50: Arguments.of("properties", > 51: "properties: java.security", This reads `properties: Initial` in [JDK17](https://github.com/openjdk/jdk17u-dev/blob/fcdcff0e0d6a25de5e1c3bd62ba909774663b0db/test/jdk/sun/security/util/Debug/DebugOptions.java#L51), since JDK17 keeps track of initial properties and prints something like this on `stderr` (note the _"Initial security..."_ message): $ [JDK17]/bin/java -Djava.security.debug=properties properties: java.security properties: java.security.disableSystemPropertiesFile=false properties: security.useSystemPropertiesFile=false properties: System security property support disabled by user. properties: WARNING: FIPS mode support can not be enabled without system security properties being enabled. properties: Initial security property: jdk.jar.disabledAlgorithms=MD2, MD5, RSA keySize < 1024, DSA keySize < 1024, SHA1 denyAfter 2019-01-01 properties: Initial security property: fips.provider.3=SunEC properties: Initial security property: fips.provider.4=SunJSSE properties: Initial security property: fips.provider.1=SunPKCS11 ${java.home}/conf/security/nss.fips.cfg Whereas, for 11: $ [JDK11]/bin/java -Djava.security.debug=properties properties: java.security Usage: java [options] [args...] (to execute a class) ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2998#discussion_r1958512721 From goetz at openjdk.org Mon Feb 17 16:44:51 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 17 Feb 2025 16:44:51 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations Message-ID: I backport this to match 17.0.13-oracle based on the commit to 21. I had to resolve several files, two of them considerably: src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java Resolved larger chunk. src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java Resolved some code. The new code in DHPublic/PrivateKey depends on the removal of IOException in [JDK-8297065.](https://bugs.openjdk.org/browse/JDK-8297065)"DerOutputStream operations should not throw IOExceptions" It calls functions that throw an exception in 17, but do not do so in 21. JDK-8297065 makes the point that these exceptions can never been thrown, which also holds for 17. So I just catch and ignore them. Also, I had to adapt code because a constructor with cause for InvalidObjectException is missing in 17. This was added by [JDK-8282696](https://bugs.openjdk.org/browse/JDK-8282696) "Add constructors taking a cause to InvalidObjectException and InvalidClassException" in 19. I double-checked that [JDK-8297065.](https://bugs.openjdk.org/browse/JDK-8297065) was not backported by Oracle. Backporting this change would simplify matters considerably. The remaining files only needed trivial resolves: src/java.base/share/classes/java/security/Permissions.java src/java.base/share/classes/java/security/SignedObject.java Only Copyright. src/java.base/share/classes/java/security/Timestamp.java Copyright and import. src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java src/java.base/share/classes/java/security/cert/CertificateRevokedException.java src/java.base/share/classes/sun/security/provider/DRBG.java src/java.base/share/classes/sun/security/util/ObjectIdentifier.java src/java.base/share/classes/sun/security/x509/AlgIdDSA.java Only Copyright. src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Context.java Resolved imports. src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecureRandom.java Only Copyright. I manually ran these tests on linux x86_64: test/jdk/com/sun/security test/jdk/java/awt/security test/jdk/java/net/httpclient/security test/jdk/java/net/httpclient/websocket/security test/jdk/java/security test/jdk/javax/management/security test/jdk/javax/security test/jdk/jdk/security test/jdk/security test/jdk/sun/security Our well-known nightly tests passed, too. ------------- Commit messages: - Make it build, just ignore IOException. call initCause - Backport 8302111 Changes: https://git.openjdk.org/jdk17u-dev/pull/3278/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3278&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302111 Stats: 1103 lines in 21 files changed: 612 ins; 339 del; 152 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3278.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3278/head:pull/3278 PR: https://git.openjdk.org/jdk17u-dev/pull/3278 From andrew at openjdk.org Mon Feb 17 19:44:23 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 17 Feb 2025 19:44:23 GMT Subject: [jdk11u-dev] RFR: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates In-Reply-To: References: Message-ID: <7NIfx2X3hwbnGgIsNWdubmhTLxox_PxRN5qILOWcCPY=.f2948587-3d7b-4650-8720-db36d248b03a@github.com> On Thu, 13 Feb 2025 13:14:33 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8349603](https://bugs.openjdk.org/browse/JDK-8349603). > > The JDK versions in use are different in jdk11u than in the upstream change, obviously. > > Thanks! What is the reason for continually changing the bootstrap JDK? Surely it would be better to test that someone can upgrade to the latest version from a much older one. Ideally, we'd be bootstrapping with JDK 10. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2991#issuecomment-2663954996 From duke at openjdk.org Tue Feb 18 07:38:22 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 18 Feb 2025 07:38:22 GMT Subject: [jdk11u-dev] RFR: 8051959: Add thread and timestamp options to java.security.debug system property In-Reply-To: <8zevx5ak4TVIJGHt01qlLt3WWn_SsJNWCvgVPuN9784=.bf83fd95-d4e8-472a-9fee-b4edd31a73b7@github.com> References: <8zevx5ak4TVIJGHt01qlLt3WWn_SsJNWCvgVPuN9784=.bf83fd95-d4e8-472a-9fee-b4edd31a73b7@github.com> Message-ID: On Mon, 17 Feb 2025 16:27:04 GMT, Antonio Vieiro wrote: > Almost clean backport of [JDK-8051959](https://bugs.openjdk.org/browse/JDK-8051959) that adds options to `java.security.debug` to enhance traces with thread, log record and timestamp information, improving traceability and easying troubleshooting, on par with ["The java.security.debug System Property" in JDK17](https://docs.oracle.com/en/java/javase/17/security/troubleshooting-security.html#GUID-05F3E865-20FF-46EB-AC35-84D4B552CA48) and above, and with 11.0.26-oracle. Low risk. > > Backport is not completely clean because, among other things, [JDK-8292177](https://bugs.openjdk.org/browse/JDK-8292177) was applied differently in 11 (also `HexFormat` is not in 11). > > One of the tests cases had to be changed, since JDK11 does not keep track of [Security#initialSystemProperties](https://github.com/openjdk/jdk17u-dev/blob/fcdcff0e0d6a25de5e1c3bd62ba909774663b0db/src/java.base/share/classes/java/security/Security.java#L68) and thus searching for [`properties: Initial`](https://github.com/openjdk/jdk17u-dev/blob/fcdcff0e0d6a25de5e1c3bd62ba909774663b0db/test/jdk/sun/security/util/Debug/DebugOptions.java#L50) in the test `stderr` makes no sense. We're searching for `properties: java.security` instead (this is indicated in the github PR). > > Tested on Linux with tier1... > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0 > jtreg:test/jdk:tier1 1899 1899 0 0 > jtreg:test/langtools:tier1 3941 3941 0 0 > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST SUCCESS > > > ... and security tests ... > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security 658 658 0 0 > ============================== > TEST SUCCESS > At least one of the issues associated with this backport has a resolved [CSR](https://wiki.openjdk.org/display/csr/Main) ... Let's wait for a review before creating the CSR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2998#issuecomment-2664826606 From sgehwolf at openjdk.org Tue Feb 18 09:26:26 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 18 Feb 2025 09:26:26 GMT Subject: [jdk11u-dev] RFR: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates In-Reply-To: <7NIfx2X3hwbnGgIsNWdubmhTLxox_PxRN5qILOWcCPY=.f2948587-3d7b-4650-8720-db36d248b03a@github.com> References: <7NIfx2X3hwbnGgIsNWdubmhTLxox_PxRN5qILOWcCPY=.f2948587-3d7b-4650-8720-db36d248b03a@github.com> Message-ID: On Mon, 17 Feb 2025 19:41:28 GMT, Andrew John Hughes wrote: > What is the reason for continually changing the bootstrap JDK? Surely it would be better to test that someone can upgrade to the latest version from a much older one. Ideally, we'd be bootstrapping with JDK 10. We've long since moved away from testing this (bootstrap with 10). There is the option of bootstrapping JDK 11.0.0 GA with JDK 10 and then build the latest update version for 11. IMO, the reason should be to not use unpatched JDKs even for building. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2991#issuecomment-2665050622 From duke at openjdk.org Tue Feb 18 10:12:17 2025 From: duke at openjdk.org (duke) Date: Tue, 18 Feb 2025 10:12:17 GMT Subject: [jdk24u] RFR: 8344925: translet-name ignored when package-name is also set In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 09:39:29 GMT, Galder Zamarre?o wrote: > Passed tier1 and tier2 tests on x64. @galderz Your change (at version 5f6d6d33dece2f20f776081a4800ac4288f330bc) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/73#issuecomment-2665167265 From mdoerr at openjdk.org Tue Feb 18 11:21:17 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 18 Feb 2025 11:21:17 GMT Subject: [jdk24u] Integrated: 8349751: AIX build failure after upgrade pipewire to 1.3.81 In-Reply-To: References: Message-ID: On Fri, 14 Feb 2025 20:14:10 GMT, Martin Doerr wrote: > Clean backport of [JDK-8349751](https://bugs.openjdk.org/browse/JDK-8349751). This pull request has now been integrated. Changeset: d38ab94c Author: Martin Doerr URL: https://git.openjdk.org/jdk24u/commit/d38ab94cf7c75746dc699787f87e8c25fe9146a5 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8349751: AIX build failure after upgrade pipewire to 1.3.81 Backport-of: 19c0ce43e258d00d77314d76a361feb2069a5af1 ------------- PR: https://git.openjdk.org/jdk24u/pull/79 From duke at openjdk.org Tue Feb 18 12:38:23 2025 From: duke at openjdk.org (duke) Date: Tue, 18 Feb 2025 12:38:23 GMT Subject: [jdk11u-dev] Withdrawn: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out In-Reply-To: References: Message-ID: <7F_LbMye45SFc5YSkORk1n7QLyqg-udVcBItB-N6YAo=.5f904128-d617-46d6-b8b3-5cdafb121d83@github.com> On Tue, 24 Dec 2024 06:32:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [7acfba28](https://github.com/openjdk/jdk/commit/7acfba288ff4d1f43cc36506b2bd2d32107b00c2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This PR fix the test bug which cause test intermittent fails. The change has been verified locally, test-fix only, no risk. > > The commit being backported was authored by Mark Sheppard on 5 Jun 2024 and was reviewed by Brian Burkhalter. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2980 From duke at openjdk.org Tue Feb 18 14:06:20 2025 From: duke at openjdk.org (duke) Date: Tue, 18 Feb 2025 14:06:20 GMT Subject: [jdk24u] RFR: 8347564: ZGC: Crash in DependencyContext::clean_unloading_dependents In-Reply-To: References: Message-ID: On Mon, 10 Feb 2025 14:56:08 GMT, Axel Boldt-Christmas wrote: > Hi all, > > This pull request contains a backport of commit [14136f8b](https://github.com/openjdk/jdk/commit/14136f8b1106137317393bc2ab0a2db0d212f8d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Axel Boldt-Christmas on 30 Jan 2025 and was reviewed by Erik ?sterlund, Stefan Karlsson and Vladimir Ivanov. > > Thanks! @xmas92 Your change (at version 36cf60351107c61e6716cf906681f7a19b48a506) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/67#issuecomment-2665811958 From galder at openjdk.org Tue Feb 18 14:30:34 2025 From: galder at openjdk.org (Galder =?UTF-8?B?WmFtYXJyZcOxbw==?=) Date: Tue, 18 Feb 2025 14:30:34 GMT Subject: [jdk24u] Integrated: 8344925: translet-name ignored when package-name is also set In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 09:39:29 GMT, Galder Zamarre?o wrote: > Passed tier1 and tier2 tests on x64. This pull request has now been integrated. Changeset: ba481f0d Author: Galder Zamarre?o Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk24u/commit/ba481f0d93ca8c90218c1ae6285d677f9a2651b0 Stats: 173 lines in 4 files changed: 165 ins; 4 del; 4 mod 8344925: translet-name ignored when package-name is also set Backport-of: 3989a199578fc1d91988cfdbb95f11dd6d4c7b81 ------------- PR: https://git.openjdk.org/jdk24u/pull/73 From mdoerr at openjdk.org Tue Feb 18 14:55:44 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 18 Feb 2025 14:55:44 GMT Subject: [jdk24u] RFR: 8347564: ZGC: Crash in DependencyContext::clean_unloading_dependents In-Reply-To: References: Message-ID: On Mon, 10 Feb 2025 14:56:08 GMT, Axel Boldt-Christmas wrote: > Hi all, > > This pull request contains a backport of commit [14136f8b](https://github.com/openjdk/jdk/commit/14136f8b1106137317393bc2ab0a2db0d212f8d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Axel Boldt-Christmas on 30 Jan 2025 and was reviewed by Erik ?sterlund, Stefan Karlsson and Vladimir Ivanov. > > Thanks! Please consider enabling Pre-submit tests for future backports. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/67#issuecomment-2665941512 From aboldtch at openjdk.org Tue Feb 18 14:55:45 2025 From: aboldtch at openjdk.org (Axel Boldt-Christmas) Date: Tue, 18 Feb 2025 14:55:45 GMT Subject: [jdk24u] Integrated: 8347564: ZGC: Crash in DependencyContext::clean_unloading_dependents In-Reply-To: References: Message-ID: <2dptHvyZBZ5TyojC1y9atRkYWBMOGnFe4t8lGLsDuYY=.f4a3416c-6478-49cd-ad9b-483dd7fada46@github.com> On Mon, 10 Feb 2025 14:56:08 GMT, Axel Boldt-Christmas wrote: > Hi all, > > This pull request contains a backport of commit [14136f8b](https://github.com/openjdk/jdk/commit/14136f8b1106137317393bc2ab0a2db0d212f8d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Axel Boldt-Christmas on 30 Jan 2025 and was reviewed by Erik ?sterlund, Stefan Karlsson and Vladimir Ivanov. > > Thanks! This pull request has now been integrated. Changeset: 352a7a97 Author: Axel Boldt-Christmas Committer: Martin Doerr URL: https://git.openjdk.org/jdk24u/commit/352a7a97823b0fe3ce65cb3b00b8aa0bbdfb08f3 Stats: 168 lines in 13 files changed: 8 ins; 143 del; 17 mod 8347564: ZGC: Crash in DependencyContext::clean_unloading_dependents Backport-of: 14136f8b1106137317393bc2ab0a2db0d212f8d8 ------------- PR: https://git.openjdk.org/jdk24u/pull/67 From goetz at openjdk.org Tue Feb 18 20:19:46 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 18 Feb 2025 20:19:46 GMT Subject: [jdk17u-dev] RFR: 8292848: AWT_Mixing and TrayIcon tests fail on el8 with hard-coded isOel7 Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport c13e0ef3f8046a979638d6885a732553fc2b126e Changes: https://git.openjdk.org/jdk17u-dev/pull/3279/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3279&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292848 Stats: 69 lines in 12 files changed: 19 ins; 0 del; 50 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3279.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3279/head:pull/3279 PR: https://git.openjdk.org/jdk17u-dev/pull/3279 From goetz at openjdk.org Tue Feb 18 20:20:10 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 18 Feb 2025 20:20:10 GMT Subject: [jdk21u-dev] RFR: 8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main Message-ID: I backport this for parity with 21.0.8-oracle ------------- Commit messages: - Backport 4047a3623a44d86df2b82565f33ce739a882802d Changes: https://git.openjdk.org/jdk21u-dev/pull/1408/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1408&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328730 Stats: 542 lines in 3 files changed: 211 ins; 331 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1408.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1408/head:pull/1408 PR: https://git.openjdk.org/jdk21u-dev/pull/1408 From goetz at openjdk.org Tue Feb 18 20:20:49 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 18 Feb 2025 20:20:49 GMT Subject: [jdk17u-dev] RFR: 8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport 4047a3623a44d86df2b82565f33ce739a882802d Changes: https://git.openjdk.org/jdk17u-dev/pull/3280/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3280&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328730 Stats: 542 lines in 3 files changed: 211 ins; 331 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3280.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3280/head:pull/3280 PR: https://git.openjdk.org/jdk17u-dev/pull/3280 From goetz at openjdk.org Tue Feb 18 20:26:06 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 18 Feb 2025 20:26:06 GMT Subject: [jdk17u-dev] RFR: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java Message-ID: I backport this for parity with 17.0.16-oracle ------------- Commit messages: - Backport 84c99fb91ffc4bfbc2fb0f20f558603d5660d7f1 Changes: https://git.openjdk.org/jdk17u-dev/pull/3281/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3281&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283664 Stats: 514 lines in 2 files changed: 85 ins; 180 del; 249 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3281.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3281/head:pull/3281 PR: https://git.openjdk.org/jdk17u-dev/pull/3281 From goetz at openjdk.org Tue Feb 18 20:28:48 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 18 Feb 2025 20:28:48 GMT Subject: [jdk21u-dev] RFR: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java Message-ID: I backport this for parity with 21.0.8-oracle. ------------- Commit messages: - Backport 84c99fb91ffc4bfbc2fb0f20f558603d5660d7f1 Changes: https://git.openjdk.org/jdk21u-dev/pull/1409/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1409&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283664 Stats: 514 lines in 2 files changed: 85 ins; 180 del; 249 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1409.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1409/head:pull/1409 PR: https://git.openjdk.org/jdk21u-dev/pull/1409 From goetz at openjdk.org Tue Feb 18 20:35:09 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 18 Feb 2025 20:35:09 GMT Subject: [jdk21u-dev] RFR: 8342098: Write a test to compare the images Message-ID: <-HU90wQN-EmLgQnpX9BEiVF5ioN78LzcOwEOfO7apYg=.9427a4ee-2eb7-4a18-ada8-12450a884fa8@github.com> I backport this for parity with 21.0.8-oracle ------------- Commit messages: - Backport 47ebf8d868b2e15b943a227ad3cf2ee12eed10f6 Changes: https://git.openjdk.org/jdk21u-dev/pull/1410/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1410&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342098 Stats: 166 lines in 1 file changed: 166 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1410.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1410/head:pull/1410 PR: https://git.openjdk.org/jdk21u-dev/pull/1410 From goetz at openjdk.org Tue Feb 18 20:36:57 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 18 Feb 2025 20:36:57 GMT Subject: [jdk17u-dev] RFR: 8342098: Write a test to compare the images Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport 47ebf8d868b2e15b943a227ad3cf2ee12eed10f6 Changes: https://git.openjdk.org/jdk17u-dev/pull/3282/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3282&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342098 Stats: 166 lines in 1 file changed: 166 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3282.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3282/head:pull/3282 PR: https://git.openjdk.org/jdk17u-dev/pull/3282 From andrew at openjdk.org Tue Feb 18 21:25:55 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 18 Feb 2025 21:25:55 GMT Subject: [jdk17u-dev] RFR: 8347965: (tz) Update Timezone Data to 2025a In-Reply-To: References: Message-ID: On Mon, 27 Jan 2025 11:20:35 GMT, Radek Cap wrote: > Backport of https://bugs.openjdk.org/browse/JDK-8347965 > Changes to Update Timezone Data to 2025a > > Passed tier1 tests. > Passed gtests. > > Results of > `make run-test TEST="jtreg:java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources"` > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/text/Format 111 111 0 0 > jtreg:test/jdk/java/util/TimeZone 25 25 0 0 > jtreg:test/jdk/sun/util/calendar 5 5 0 0 > jtreg:test/jdk/sun/util/resources 22 22 0 0 > ============================== > TEST SUCCESS > > Finished building target 'run-test' in configuration 'linux-x86_64-server-release' Thanks. Sorry for the delay. Approved now. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3245#pullrequestreview-2625061187 From duke at openjdk.org Tue Feb 18 21:35:57 2025 From: duke at openjdk.org (duke) Date: Tue, 18 Feb 2025 21:35:57 GMT Subject: [jdk11u-dev] Withdrawn: 8216539: tools/jar/modularJar/Basic.java timed out In-Reply-To: References: Message-ID: <6EDBXx3ert1wqc3vyWIYO_zPr3vlkB9EpOSPcoKSjJQ=.2697cf9f-6855-4526-a1a4-127bd5d7e1a7@github.com> On Tue, 24 Dec 2024 06:42:49 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [518e3a87](https://github.com/openjdk/jdk/commit/518e3a878862fd7be2d9eea42f122fdaa01c7dd8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This PR fix the test bug which cause test intermittent fails. The change has been verified locally, test-fix only, no risk. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2981 From duke at openjdk.org Tue Feb 18 21:38:04 2025 From: duke at openjdk.org (duke) Date: Tue, 18 Feb 2025 21:38:04 GMT Subject: [jdk11u-dev] Withdrawn: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 03:11:41 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [69384745](https://github.com/openjdk/jdk/commit/693847452f208446a34186f142fe2c56a49ceceb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Albert Mingkun Yang on 30 Nov 2023 and was reviewed by Stefan Johansson and Thomas Schatzl. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2976 From duke at openjdk.org Tue Feb 18 23:52:59 2025 From: duke at openjdk.org (Michael De Vera) Date: Tue, 18 Feb 2025 23:52:59 GMT Subject: [jdk17u-dev] RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG [v2] In-Reply-To: <6s2VcYDTqKwhRGyGP5LhuzzKI9q2Rj-c8__G-sgt2nY=.af7290a6-5c6d-4cd9-ba2a-bbff949d35a2@github.com> References: <6s2VcYDTqKwhRGyGP5LhuzzKI9q2Rj-c8__G-sgt2nY=.af7290a6-5c6d-4cd9-ba2a-bbff949d35a2@github.com> Message-ID: > Backport of [JDK-6355567: AdobeMarkerSegment causes failure to read valid JPEG](https://bugs.openjdk.org/browse/JDK-6355567) > > Fixes bug that can occur when reading JPEG files with Adobe-specific JPEG application markers. > > tier1 tests, jdk:desktop passing. New regression test in jdk:desktop fails without this fix but passes with it. Michael De Vera has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2977/files - new: https://git.openjdk.org/jdk17u-dev/pull/2977/files/3b035acc..9e90637e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2977&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2977&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2977.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2977/head:pull/2977 PR: https://git.openjdk.org/jdk17u-dev/pull/2977 From syan at openjdk.org Wed Feb 19 01:29:59 2025 From: syan at openjdk.org (SendaoYan) Date: Wed, 19 Feb 2025 01:29:59 GMT Subject: [jdk21u-dev] RFR: 8322983: Virtual Threads: exclude 2 tests In-Reply-To: <8GjzAr9Sp9r4yZE25gFF1O7Xkg82-VJb9BvgICNlp6k=.c829fcf7-6580-4e25-9919-a02accce3dd4@github.com> References: <8GjzAr9Sp9r4yZE25gFF1O7Xkg82-VJb9BvgICNlp6k=.c829fcf7-6580-4e25-9919-a02accce3dd4@github.com> Message-ID: <4khQSDv9HScXeNTayc7miaRrx3se-RUAh1sIaKezB-w=.6c6bbcc0-0c89-4f6b-96a6-9cad7843504a@github.com> On Mon, 23 Dec 2024 12:51:19 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [cf28fd4c](https://github.com/openjdk/jdk/commit/cf28fd4cbc6507eb69fcfeb33622316eb5b6b0c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Evgeny Nikitin on 20 Dec 2024 and was reviewed by Jaikiran Pai, Leonid Mesnik and SendaoYan. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1285#issuecomment-2667294442 From syan at openjdk.org Wed Feb 19 01:29:59 2025 From: syan at openjdk.org (SendaoYan) Date: Wed, 19 Feb 2025 01:29:59 GMT Subject: [jdk21u-dev] Integrated: 8322983: Virtual Threads: exclude 2 tests In-Reply-To: <8GjzAr9Sp9r4yZE25gFF1O7Xkg82-VJb9BvgICNlp6k=.c829fcf7-6580-4e25-9919-a02accce3dd4@github.com> References: <8GjzAr9Sp9r4yZE25gFF1O7Xkg82-VJb9BvgICNlp6k=.c829fcf7-6580-4e25-9919-a02accce3dd4@github.com> Message-ID: On Mon, 23 Dec 2024 12:51:19 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [cf28fd4c](https://github.com/openjdk/jdk/commit/cf28fd4cbc6507eb69fcfeb33622316eb5b6b0c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Evgeny Nikitin on 20 Dec 2024 and was reviewed by Jaikiran Pai, Leonid Mesnik and SendaoYan. > > Thanks! This pull request has now been integrated. Changeset: 9d496c08 Author: SendaoYan URL: https://git.openjdk.org/jdk21u-dev/commit/9d496c08d4df51bad740fe85dee3cfbeed13fdae Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8322983: Virtual Threads: exclude 2 tests Backport-of: cf28fd4cbc6507eb69fcfeb33622316eb5b6b0c5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1285 From lliu at openjdk.org Wed Feb 19 05:40:59 2025 From: lliu at openjdk.org (Liming Liu) Date: Wed, 19 Feb 2025 05:40:59 GMT Subject: [jdk21u-dev] RFR: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B Message-ID: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B ------------- Commit messages: - Backport 89ee1a5517ea1e3915f4362ada3d2086b63c107e Changes: https://git.openjdk.org/jdk21u-dev/pull/1411/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1411&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343978 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1411.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1411/head:pull/1411 PR: https://git.openjdk.org/jdk21u-dev/pull/1411 From galder at openjdk.org Wed Feb 19 05:42:45 2025 From: galder at openjdk.org (Galder =?UTF-8?B?WmFtYXJyZcOxbw==?=) Date: Wed, 19 Feb 2025 05:42:45 GMT Subject: [jdk21u-dev] RFR: 8344925: translet-name ignored when package-name is also set Message-ID: This is a backport of JDK-8344925: translet-name ignored when package-name is also set Original patch does not apply cleanly to 21u-dev, because of javadoc and license header year discrepancies. Testing: tier1 and tier2 passed. Tier 2 includes the `PropertiesTest` test included in the original PR and individually verified that it passes. ------------- Commit messages: - Backport 3989a199578fc1d91988cfdbb95f11dd6d4c7b81 Changes: https://git.openjdk.org/jdk21u-dev/pull/1412/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1412&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344925 Stats: 173 lines in 4 files changed: 165 ins; 4 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1412.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1412/head:pull/1412 PR: https://git.openjdk.org/jdk21u-dev/pull/1412 From alanb at openjdk.org Wed Feb 19 07:47:58 2025 From: alanb at openjdk.org (Alan Bateman) Date: Wed, 19 Feb 2025 07:47:58 GMT Subject: [jdk21u-dev] RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v2] In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 02:00:07 GMT, Jiawei Tang wrote: >> 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" > > Jiawei Tang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 667cca9d7aef1ff4abe630cefaac34c0b1646925 This is a major update to ForkJoinPool that includes new APIs and changes to existing APIs, see CSR and release notes for details. I assume it's a mistake to propose this as a back port. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1400#issuecomment-2667791268 From mbaesken at openjdk.org Wed Feb 19 08:37:01 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 19 Feb 2025 08:37:01 GMT Subject: [jdk21u-dev] Integrated: 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64 In-Reply-To: References: Message-ID: On Mon, 17 Feb 2025 12:15:53 GMT, Matthias Baesken wrote: > 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64 This pull request has now been integrated. Changeset: 58f3acc9 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/58f3acc9f8576248fdb3e0a319706284b2cb2620 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64 Backport-of: 0285020c7ea01f32b32efe166a0a5dae39957216 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1405 From mbaesken at openjdk.org Wed Feb 19 08:37:52 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 19 Feb 2025 08:37:52 GMT Subject: [jdk21u-dev] Integrated: 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer In-Reply-To: References: Message-ID: On Mon, 17 Feb 2025 12:49:02 GMT, Matthias Baesken wrote: > 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer This pull request has now been integrated. Changeset: c9bf9482 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/c9bf94827d34f1bc24616c812a59049931e81071 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer Backport-of: 82e16ba248a97e3446d5b2d64c353b61dd6bdda6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1406 From mbaesken at openjdk.org Wed Feb 19 08:38:55 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 19 Feb 2025 08:38:55 GMT Subject: [jdk21u-dev] Integrated: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero In-Reply-To: References: Message-ID: On Mon, 17 Feb 2025 13:01:27 GMT, Matthias Baesken wrote: > 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero This pull request has now been integrated. Changeset: 6cc0ec2f Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/6cc0ec2fdc56150df361a31861a36cc8518f4cb6 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero Backport-of: 5e92a4ceafd0626e3600e44a3370ca2f5d9347c8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1407 From mbaesken at openjdk.org Wed Feb 19 09:07:09 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 19 Feb 2025 09:07:09 GMT Subject: [jdk24u] RFR: 8349150: Support precompiled headers on AIX Message-ID: <6qBfLiBWycLxeHmh2GUT0ZURLuFXX3BqabNxmqrLzOQ=.fdfc67f2-be0d-4c16-9ca5-262bf6e46553@github.com> 8349150: Support precompiled headers on AIX ------------- Commit messages: - Backport beae8843b9b2433af5e9fbe420b17e663cbdb960 Changes: https://git.openjdk.org/jdk24u/pull/80/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=80&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349150 Stats: 16 lines in 2 files changed: 7 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk24u/pull/80.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/80/head:pull/80 PR: https://git.openjdk.org/jdk24u/pull/80 From coffeys at openjdk.org Wed Feb 19 10:54:53 2025 From: coffeys at openjdk.org (Sean Coffey) Date: Wed, 19 Feb 2025 10:54:53 GMT Subject: [jdk24u] RFR: Merge jdk:jdk24 Message-ID: Merge ------------- Commit messages: - Merge jdk:jdk24 branch - 8345276: Remove EA from the JDK 24 version string with first RC promotion - 8349084: Update vectors used in several PQC benchmarks - 8349183: [BACKOUT] Optimization for StringBuilder append boolean & null - 8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk24u/pull/81/files Stats: 2707 lines in 10 files changed: 50 ins; 2061 del; 596 mod Patch: https://git.openjdk.org/jdk24u/pull/81.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/81/head:pull/81 PR: https://git.openjdk.org/jdk24u/pull/81 From duke at openjdk.org Wed Feb 19 11:12:35 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 19 Feb 2025 11:12:35 GMT Subject: [jdk21u-dev] RFR: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class Message-ID: Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 24u that solves some accessibility issues on Windows, for parity with 11.0.27-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ) ------------- Commit messages: - Backport ecdc322029d3f1338d547955c938b6bc57696ac0 Changes: https://git.openjdk.org/jdk21u-dev/pull/1414/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1414&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339728 Stats: 127 lines in 3 files changed: 116 ins; 5 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1414.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1414/head:pull/1414 PR: https://git.openjdk.org/jdk21u-dev/pull/1414 From duke at openjdk.org Wed Feb 19 11:15:33 2025 From: duke at openjdk.org (Radek Cap) Date: Wed, 19 Feb 2025 11:15:33 GMT Subject: [jdk17u-dev] RFR: 8347965: (tz) Update Timezone Data to 2025a [v2] In-Reply-To: References: Message-ID: > Backport of https://bugs.openjdk.org/browse/JDK-8347965 > Changes to Update Timezone Data to 2025a > > Passed tier1 tests. > Passed gtests. > > Results of > `make run-test TEST="jtreg:java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources"` > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/text/Format 111 111 0 0 > jtreg:test/jdk/java/util/TimeZone 25 25 0 0 > jtreg:test/jdk/sun/util/calendar 5 5 0 0 > jtreg:test/jdk/sun/util/resources 22 22 0 0 > ============================== > TEST SUCCESS > > Finished building target 'run-test' in configuration 'linux-x86_64-server-release' Radek Cap has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3245/files - new: https://git.openjdk.org/jdk17u-dev/pull/3245/files/0ec216db..b66a8fbe Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3245&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3245&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3245.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3245/head:pull/3245 PR: https://git.openjdk.org/jdk17u-dev/pull/3245 From duke at openjdk.org Wed Feb 19 11:15:33 2025 From: duke at openjdk.org (duke) Date: Wed, 19 Feb 2025 11:15:33 GMT Subject: [jdk17u-dev] RFR: 8347965: (tz) Update Timezone Data to 2025a In-Reply-To: References: Message-ID: <7JN-aIY-OCrAvR4ZrCI2omBdeHPZCXfH8XxfhXHtweo=.90065380-5a47-46ac-b95f-3c4ffd0bf96c@github.com> On Mon, 27 Jan 2025 11:20:35 GMT, Radek Cap wrote: > Backport of https://bugs.openjdk.org/browse/JDK-8347965 > Changes to Update Timezone Data to 2025a > > Passed tier1 tests. > Passed gtests. > > Results of > `make run-test TEST="jtreg:java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources"` > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/text/Format 111 111 0 0 > jtreg:test/jdk/java/util/TimeZone 25 25 0 0 > jtreg:test/jdk/sun/util/calendar 5 5 0 0 > jtreg:test/jdk/sun/util/resources 22 22 0 0 > ============================== > TEST SUCCESS > > Finished building target 'run-test' in configuration 'linux-x86_64-server-release' @RadekCap Your change (at version b66a8fbeed73ec0da305d41a9121f269df36cae3) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3245#issuecomment-2668326435 From coffeys at openjdk.org Wed Feb 19 11:31:55 2025 From: coffeys at openjdk.org (Sean Coffey) Date: Wed, 19 Feb 2025 11:31:55 GMT Subject: [jdk24u] Integrated: Merge jdk:jdk24 In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 10:49:36 GMT, Sean Coffey wrote: > Merge This pull request has now been integrated. Changeset: ec34f8b9 Author: Sean Coffey URL: https://git.openjdk.org/jdk24u/commit/ec34f8b9ca8851f35b8d74147e07effe83362df2 Stats: 2707 lines in 10 files changed: 50 ins; 2061 del; 596 mod Merge ------------- PR: https://git.openjdk.org/jdk24u/pull/81 From asteiner at openjdk.org Wed Feb 19 13:33:13 2025 From: asteiner at openjdk.org (Andreas Steiner) Date: Wed, 19 Feb 2025 13:33:13 GMT Subject: [jdk21u-dev] RFR: 8318636: Add jcmd to print annotated process memory map Message-ID: Hi all, This pull request contains a backport of commit [6f863b2a](https://github.com/openjdk/jdk/commit/6f863b2a1baa67deb2a7b33fcd93d272aea01812) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Thomas Stuefe on 13 Nov 2023 and was reviewed by Johan Sj?len and Gerard Ziemski. Thanks! ------------- Commit messages: - Backport 6f863b2a1baa67deb2a7b33fcd93d272aea01812 Changes: https://git.openjdk.org/jdk21u-dev/pull/1415/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1415&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318636 Stats: 793 lines in 9 files changed: 792 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1415.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1415/head:pull/1415 PR: https://git.openjdk.org/jdk21u-dev/pull/1415 From sgehwolf at openjdk.org Wed Feb 19 14:29:03 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 19 Feb 2025 14:29:03 GMT Subject: [jdk21u-dev] RFR: 8318636: Add jcmd to print annotated process memory map In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 13:25:34 GMT, Andreas Steiner wrote: > Hi all, > > This pull request contains a backport of commit [6f863b2a](https://github.com/openjdk/jdk/commit/6f863b2a1baa67deb2a7b33fcd93d272aea01812) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Thomas Stuefe on 13 Nov 2023 and was reviewed by Johan Sj?len and Gerard Ziemski. > > Thanks! @ansteiner Please enable GHA testing for your fork. Thanks! See: https://github.com/openjdk/jdk21u-dev/pull/1415/checks?check_run_id=37469345959 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1415#issuecomment-2668812509 From duke at openjdk.org Wed Feb 19 15:37:02 2025 From: duke at openjdk.org (Radek Cap) Date: Wed, 19 Feb 2025 15:37:02 GMT Subject: [jdk17u-dev] Integrated: 8347965: (tz) Update Timezone Data to 2025a In-Reply-To: References: Message-ID: On Mon, 27 Jan 2025 11:20:35 GMT, Radek Cap wrote: > Backport of https://bugs.openjdk.org/browse/JDK-8347965 > Changes to Update Timezone Data to 2025a > > Passed tier1 tests. > Passed gtests. > > Results of > `make run-test TEST="jtreg:java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources"` > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/text/Format 111 111 0 0 > jtreg:test/jdk/java/util/TimeZone 25 25 0 0 > jtreg:test/jdk/sun/util/calendar 5 5 0 0 > jtreg:test/jdk/sun/util/resources 22 22 0 0 > ============================== > TEST SUCCESS > > Finished building target 'run-test' in configuration 'linux-x86_64-server-release' This pull request has now been integrated. Changeset: 06ea6d5c Author: Radek Cap Committer: Andrew John Hughes URL: https://git.openjdk.org/jdk17u-dev/commit/06ea6d5c17899df8fd83d0b14983c7c1e88d9cde Stats: 249 lines in 12 files changed: 150 ins; 53 del; 46 mod 8347965: (tz) Update Timezone Data to 2025a Reviewed-by: goetz, andrew Backport-of: 5d21a2bcc4ba06331df52470795134d8540dd567 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3245 From rrich at openjdk.org Wed Feb 19 17:10:07 2025 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 19 Feb 2025 17:10:07 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations In-Reply-To: References: Message-ID: On Mon, 17 Feb 2025 16:39:14 GMT, Goetz Lindenmaier wrote: > I backport this to match 17.0.13-oracle based on the commit to 21. > > I had to resolve several files, two of them considerably: > > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java > Resolved larger chunk. > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java > Resolved some code. > > The new code in DHPublic/PrivateKey depends on the removal > of IOExceptions in [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) "DerOutputStream operations should not throw IOExceptions". > This change is in 21 but not in 17. Thus code backported from 21 calls functions of > DerOutputStream that do not throw an exception in 21, but do so in 17. > JDK-8297065 makes the point that these exceptions can never be thrown, which also > holds for 17. So I just catch and ignore them. > > Also, I had to adapt code because an exception constructor with cause for > InvalidObjectException is missing in 17. > This was added by [JDK-8282696](https://bugs.openjdk.org/browse/JDK-8282696) "Add constructors taking a cause > to InvalidObjectException and InvalidClassException" in 19. > I added a call to initCause() to store the causing exception. > > I double-checked that [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) was not backported > by Oracle. Backporting this change would simplify matters considerably. > > The remaining files only needed trivial resolves: > > src/java.base/share/classes/java/security/Permissions.java > src/java.base/share/classes/java/security/SignedObject.java > Only Copyright. > src/java.base/share/classes/java/security/Timestamp.java > Copyright and import. > src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java > src/java.base/share/classes/java/security/cert/CertificateRevokedException.java > src/java.base/share/classes/sun/security/provider/DRBG.java > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > src/java.base/share/classes/sun/security/x509/AlgIdDSA.java > Only Copyright. > src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Context.java > Resolved imports. > src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecureRandom.java > Only Copyright. > > I manually ran these tests on linux x86_64: > > test/jdk/com/sun/security > test/jdk/java/awt/security > test/jdk/java/net/httpclient/security > test/jdk/java/net/httpclient/websocket/security > test/jdk/java/security > test/jdk/javax/management/security > test/jdk/javax/security > t... src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java line 212: > 210: * @param g the base generator > 211: * > 212: * @throws ProviderException if the key cannot be encoded `ProviderException` isn't thrown anymore, is it? I think you should remove the `@throws ProviderException` line here and below. The import should also be removed. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#discussion_r1962066059 From duke at openjdk.org Wed Feb 19 17:20:03 2025 From: duke at openjdk.org (duke) Date: Wed, 19 Feb 2025 17:20:03 GMT Subject: [jdk17u-dev] RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG [v2] In-Reply-To: References: <6s2VcYDTqKwhRGyGP5LhuzzKI9q2Rj-c8__G-sgt2nY=.af7290a6-5c6d-4cd9-ba2a-bbff949d35a2@github.com> Message-ID: On Tue, 18 Feb 2025 23:52:59 GMT, Michael De Vera wrote: >> Backport of [JDK-6355567: AdobeMarkerSegment causes failure to read valid JPEG](https://bugs.openjdk.org/browse/JDK-6355567) >> >> Fixes bug that can occur when reading JPEG files with Adobe-specific JPEG application markers. >> >> tier1 tests, jdk:desktop passing. New regression test in jdk:desktop fails without this fix but passes with it. > > Michael De Vera has updated the pull request incrementally with one additional commit since the last revision: > > Update full name @midver Your change (at version 9e90637e46b188859c6478d174d5508baf0e7dd8) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2977#issuecomment-2669277988 From duke at openjdk.org Wed Feb 19 17:47:02 2025 From: duke at openjdk.org (Michael De Vera) Date: Wed, 19 Feb 2025 17:47:02 GMT Subject: [jdk17u-dev] Integrated: 6355567: AdobeMarkerSegment causes failure to read valid JPEG In-Reply-To: <6s2VcYDTqKwhRGyGP5LhuzzKI9q2Rj-c8__G-sgt2nY=.af7290a6-5c6d-4cd9-ba2a-bbff949d35a2@github.com> References: <6s2VcYDTqKwhRGyGP5LhuzzKI9q2Rj-c8__G-sgt2nY=.af7290a6-5c6d-4cd9-ba2a-bbff949d35a2@github.com> Message-ID: On Fri, 18 Oct 2024 23:02:44 GMT, Michael De Vera wrote: > Backport of [JDK-6355567: AdobeMarkerSegment causes failure to read valid JPEG](https://bugs.openjdk.org/browse/JDK-6355567) > > Fixes bug that can occur when reading JPEG files with Adobe-specific JPEG application markers. > > tier1 tests, jdk:desktop passing. New regression test in jdk:desktop fails without this fix but passes with it. This pull request has now been integrated. Changeset: 86d5a0e3 Author: Michael De Vera Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/86d5a0e37a622950d55cb95876a805da5c572793 Stats: 69 lines in 3 files changed: 61 ins; 0 del; 8 mod 6355567: AdobeMarkerSegment causes failure to read valid JPEG Backport-of: c7c6d47a07100f6c81af6cfad301ec1bda77adf7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2977 From honkar at openjdk.org Wed Feb 19 17:51:36 2025 From: honkar at openjdk.org (Harshitha Onkar) Date: Wed, 19 Feb 2025 17:51:36 GMT Subject: [jdk24u] RFR: 8347377: Add validation checks for ICC_Profile header fields Message-ID: Hi all, This pull request contains a backport of commit [ed8945a6](https://github.com/openjdk/jdk/commit/ed8945a68a67dd51a7cfa332905941afccc12b36) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Harshitha Onkar on 6 Feb 2025 and was reviewed by Phil Race and Jayathirth D V. Thanks! ------------- Commit messages: - Backport ed8945a68a67dd51a7cfa332905941afccc12b36 Changes: https://git.openjdk.org/jdk24u/pull/82/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=82&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347377 Stats: 327 lines in 4 files changed: 325 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk24u/pull/82.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/82/head:pull/82 PR: https://git.openjdk.org/jdk24u/pull/82 From duke at openjdk.org Wed Feb 19 19:47:16 2025 From: duke at openjdk.org (Michael De Vera) Date: Wed, 19 Feb 2025 19:47:16 GMT Subject: [jdk11u-dev] RFR: 8347965: (tz) Update Timezone Data to 2025a Message-ID: Clean backport of https://bugs.openjdk.org/browse/JDK-8347965 to update Timezone data to 2025a. Passed tier1 tests and other related tests shown below: ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/java/util/TimeZone 25 25 0 0 jtreg:test/jdk/java/time/test 74 74 0 0 jtreg:test/jdk/sun/util/resources 21 21 0 0 jtreg:test/jdk/sun/text/resources 17 17 0 0 jtreg:test/jdk/sun/util/calendar 5 5 0 0 ============================== TEST SUCCESS ------------- Commit messages: - Backport caa3c78f7837b1f561740184bd8f9cb671c467eb Changes: https://git.openjdk.org/jdk11u-dev/pull/2999/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2999&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347965 Stats: 249 lines in 12 files changed: 150 ins; 53 del; 46 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2999.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2999/head:pull/2999 PR: https://git.openjdk.org/jdk11u-dev/pull/2999 From andrew at openjdk.org Wed Feb 19 19:54:03 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 19 Feb 2025 19:54:03 GMT Subject: [jdk11u-dev] RFR: 8306408: Fix the format of several tables in building.md In-Reply-To: References: Message-ID: <6kRJFtibAyRDB4wRtFQPgCyCz_1C-TF124ir7gNF2Ps=.41b8208f-dbec-4c9c-919a-1a894a6eb5da@github.com> On Tue, 20 Feb 2024 15:32:47 GMT, Zdenek Zambersky wrote: > Backport fixing several tables in `doc/building.md`, so they would display correctly in GitHub. Changes to `doc/building.html` were done manually, as there are some differences to table contents. Also table in `Oracle Solaris Studio` section was fixed, which is missing in newer jdks. > > File `doc/building.html` was regenerated (pandoc used was one [created by current jdk17u devkit](https://github.com/openjdk/jdk17u-dev/blob/3285292597efd34176465df0b0394cc4a99605eb/make/devkit/createPandocBundle.sh), as this one seems to have be used previously -> no unrelated format changes). > > Interestingly update of `doc/building.html` also removed one paragraph (about C99 standard). However, it turns out, this was accidentally included in [JDK-8226910](https://bugs.openjdk.org/browse/JDK-8226910) backport to jdk11u-dev. Paragraph is from [JDK-8224087](https://bugs.openjdk.org/browse/JDK-8224087), which has not been backported to jdk11u-dev. (So paragraph should never been there in first place.) Backport looks good to me. Differences from 17u match the existing 11u content (including Solaris) ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2533#pullrequestreview-2627831553 From sgehwolf at openjdk.org Wed Feb 19 20:16:00 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 19 Feb 2025 20:16:00 GMT Subject: [jdk11u-dev] RFR: 8347965: (tz) Update Timezone Data to 2025a In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 19:41:37 GMT, Michael De Vera wrote: > Clean backport of https://bugs.openjdk.org/browse/JDK-8347965 to update Timezone data to 2025a. > > Passed tier1 tests and other related tests shown below: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/util/TimeZone 25 25 0 0 > jtreg:test/jdk/java/time/test 74 74 0 0 > jtreg:test/jdk/sun/util/resources 21 21 0 0 > jtreg:test/jdk/sun/text/resources 17 17 0 0 > jtreg:test/jdk/sun/util/calendar 5 5 0 0 > ============================== > TEST SUCCESS @midver Please enable GHA testing on your fork: https://github.com/openjdk/jdk11u-dev/pull/2999/checks?check_run_id=37493433202 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2999#issuecomment-2669660138 From andrew at openjdk.org Wed Feb 19 20:36:53 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 19 Feb 2025 20:36:53 GMT Subject: [jdk11u-dev] RFR: 8347965: (tz) Update Timezone Data to 2025a In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 19:41:37 GMT, Michael De Vera wrote: > Clean backport of https://bugs.openjdk.org/browse/JDK-8347965 to update Timezone data to 2025a. > > Passed tier1 tests and other related tests shown below: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/util/TimeZone 25 25 0 0 > jtreg:test/jdk/java/time/test 74 74 0 0 > jtreg:test/jdk/sun/util/resources 21 21 0 0 > jtreg:test/jdk/sun/text/resources 17 17 0 0 > jtreg:test/jdk/sun/util/calendar 5 5 0 0 > ============================== > TEST SUCCESS Backport confirmed clean from 17u and test results look good. Will approve once the GHA test results are in. ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2999#pullrequestreview-2627921233 From abakhtin at openjdk.org Wed Feb 19 22:40:41 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 19 Feb 2025 22:40:41 GMT Subject: [jdk21u-dev] RFR: 8316580: HttpClient with StructuredTaskScope does not close when a task fails Message-ID: Please review the backport of JDK-8316580 The backport is almost clean, with an exception for src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java The manual merge is required for MultiExchange::cancel(boolean mayInterruptIfRunning) because of no 8310330 in JDK21 All jtreg tests for java.net.httpclient are passed ------------- Commit messages: - Backport fc98998627443d6e73ac70661f47f48b30525712 Changes: https://git.openjdk.org/jdk21u-dev/pull/1416/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1416&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316580 Stats: 463 lines in 4 files changed: 439 ins; 10 del; 14 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1416.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1416/head:pull/1416 PR: https://git.openjdk.org/jdk21u-dev/pull/1416 From andrew at openjdk.org Wed Feb 19 22:45:59 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 19 Feb 2025 22:45:59 GMT Subject: [jdk11u-dev] RFR: 8347965: (tz) Update Timezone Data to 2025a In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 19:41:37 GMT, Michael De Vera wrote: > Clean backport of https://bugs.openjdk.org/browse/JDK-8347965 to update Timezone data to 2025a. > > Passed tier1 tests and other related tests shown below: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/util/TimeZone 25 25 0 0 > jtreg:test/jdk/java/time/test 74 74 0 0 > jtreg:test/jdk/sun/util/resources 21 21 0 0 > jtreg:test/jdk/sun/text/resources 17 17 0 0 > jtreg:test/jdk/sun/util/calendar 5 5 0 0 > ============================== > TEST SUCCESS All checks passed. Please [apply for approval](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval) ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2999#pullrequestreview-2628138648 From honkar at openjdk.org Wed Feb 19 23:07:07 2025 From: honkar at openjdk.org (Harshitha Onkar) Date: Wed, 19 Feb 2025 23:07:07 GMT Subject: [jdk24u] RFR: 8347377: Add validation checks for ICC_Profile header fields In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 17:46:25 GMT, Harshitha Onkar wrote: > Hi all, > > This pull request contains a backport of commit [ed8945a6](https://github.com/openjdk/jdk/commit/ed8945a68a67dd51a7cfa332905941afccc12b36) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Harshitha Onkar on 6 Feb 2025 and was reviewed by Phil Race and Jayathirth D V. > > Thanks! @prrace @jayathirthrao Can you please approve this backport? ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/82#issuecomment-2669959317 From duke at openjdk.org Wed Feb 19 23:38:53 2025 From: duke at openjdk.org (duke) Date: Wed, 19 Feb 2025 23:38:53 GMT Subject: [jdk11u-dev] RFR: 8347965: (tz) Update Timezone Data to 2025a In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 19:41:37 GMT, Michael De Vera wrote: > Clean backport of https://bugs.openjdk.org/browse/JDK-8347965 to update Timezone data to 2025a. > > Passed tier1 tests and other related tests shown below: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/util/TimeZone 25 25 0 0 > jtreg:test/jdk/java/time/test 74 74 0 0 > jtreg:test/jdk/sun/util/resources 21 21 0 0 > jtreg:test/jdk/sun/text/resources 17 17 0 0 > jtreg:test/jdk/sun/util/calendar 5 5 0 0 > ============================== > TEST SUCCESS @midver Your change (at version 0d669e27dd282b6a1da42a2f69182543f0b962f4) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2999#issuecomment-2670016594 From duke at openjdk.org Wed Feb 19 23:43:01 2025 From: duke at openjdk.org (Michael De Vera) Date: Wed, 19 Feb 2025 23:43:01 GMT Subject: [jdk11u-dev] Integrated: 8347965: (tz) Update Timezone Data to 2025a In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 19:41:37 GMT, Michael De Vera wrote: > Clean backport of https://bugs.openjdk.org/browse/JDK-8347965 to update Timezone data to 2025a. > > Passed tier1 tests and other related tests shown below: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/util/TimeZone 25 25 0 0 > jtreg:test/jdk/java/time/test 74 74 0 0 > jtreg:test/jdk/sun/util/resources 21 21 0 0 > jtreg:test/jdk/sun/text/resources 17 17 0 0 > jtreg:test/jdk/sun/util/calendar 5 5 0 0 > ============================== > TEST SUCCESS This pull request has now been integrated. Changeset: bbe28d92 Author: Michael DeVera Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/bbe28d927803d0c9286cdb1494afa9a267463dd4 Stats: 249 lines in 12 files changed: 150 ins; 53 del; 46 mod 8347965: (tz) Update Timezone Data to 2025a Reviewed-by: andrew Backport-of: caa3c78f7837b1f561740184bd8f9cb671c467eb ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2999 From abakhtin at openjdk.org Thu Feb 20 00:05:43 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Thu, 20 Feb 2025 00:05:43 GMT Subject: [jdk21u-dev] RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient Message-ID: Please review the backport of JDK-8335181 src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java - manual merge for MultiExchange::getExceptionalCF because of the difference in the logging caused by 8310330 src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java - added import for the AtomicLong class manually because of the difference in the import section src/java.net.http/share/classes/jdk/internal/net/http/ExchangeImpl.java - copyright year updated manually test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java - import section is updated manually test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java - getConnectionKey() declaration is added manually in the HttpServerAdapters::HttpTestExchange class All jtreg tests for java.net.httpclient are passed ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/1416 Commit messages: - Backport 720b44648bcff997278af92746f942b2425298a5 Changes: https://git.openjdk.org/jdk21u-dev/pull/1417/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1417&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335181 Stats: 625 lines in 12 files changed: 571 ins; 2 del; 52 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1417.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1417/head:pull/1417 PR: https://git.openjdk.org/jdk21u-dev/pull/1417 From kcr at openjdk.org Thu Feb 20 00:39:55 2025 From: kcr at openjdk.org (Kevin Rushforth) Date: Thu, 20 Feb 2025 00:39:55 GMT Subject: [jdk24u] RFR: 8347377: Add validation checks for ICC_Profile header fields In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 23:03:55 GMT, Harshitha Onkar wrote: > @prrace @jayathirthrao Can you please review and approve this backport? To be clear on the terminology: Phil or Jay can Review the PR (and approve the review). Since this is a clean backport, this is optional unless either you or they feel that it is needed. The maintainer Approval (from @robm-openjdk) is what is blocking integration. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/82#issuecomment-2670096997 From honkar at openjdk.org Thu Feb 20 01:42:58 2025 From: honkar at openjdk.org (Harshitha Onkar) Date: Thu, 20 Feb 2025 01:42:58 GMT Subject: [jdk24u] RFR: 8347377: Add validation checks for ICC_Profile header fields In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 00:36:55 GMT, Kevin Rushforth wrote: > > @prrace @jayathirthrao Can you please review and approve this backport? > > To be clear on the terminology: Phil or Jay can Review the PR (and approve the review). Since this is a clean backport, this is optional unless either you or they feel that it is needed. > The maintainer Approval (from @robm-openjdk) is what is blocking integration. @kevinrushforth I was under the same assumption that a clean backport doesn't require additional review/approval. After discussing with Phil, he mentioned that a review/approval is required (because of RFR label) before the maintainer approves the fix request. Additionally do I need to add client label to this PR? ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/82#issuecomment-2670194335 From jwtang at openjdk.org Thu Feb 20 07:19:08 2025 From: jwtang at openjdk.org (Jiawei Tang) Date: Thu, 20 Feb 2025 07:19:08 GMT Subject: [jdk21u-dev] RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v2] In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 02:00:07 GMT, Jiawei Tang wrote: >> 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" > > Jiawei Tang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 667cca9d7aef1ff4abe630cefaac34c0b1646925 I read the CSR Q&A and try to create a CSR. I cannot create a CSR for JDK-8288899. So, I first choose to create backport[ JDK-8350294](https://bugs.openjdk.org/browse/JDK-8350294) from [JDK-8288899 ](https://bugs.openjdk.org/browse/JDK-8288899)and then create [a CSR for JDK-8350294](https://bugs.openjdk.org/browse/JDK-8350295). Is that right? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1400#issuecomment-2670649224 From goetz at openjdk.org Thu Feb 20 08:07:02 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 08:07:02 GMT Subject: [jdk21u-dev] Integrated: 8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main In-Reply-To: References: Message-ID: <_1l1LLo1yPvooPJjHpig__JhSyav7KI1kcigb1HQZzA=.9efc4f55-e1e6-4f7b-837c-5cf3f23b916d@github.com> On Tue, 18 Feb 2025 20:14:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle This pull request has now been integrated. Changeset: fdf6dbe2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/fdf6dbe297911840b398bd160cb908cacb08c36d Stats: 542 lines in 3 files changed: 211 ins; 331 del; 0 mod 8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main Backport-of: 4047a3623a44d86df2b82565f33ce739a882802d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1408 From goetz at openjdk.org Thu Feb 20 08:08:10 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 08:08:10 GMT Subject: [jdk21u-dev] Integrated: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java In-Reply-To: References: Message-ID: On Tue, 18 Feb 2025 20:22:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle. This pull request has now been integrated. Changeset: 2ff0232e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/2ff0232e35b56d52bdba964b62608acaa29931d8 Stats: 514 lines in 2 files changed: 85 ins; 180 del; 249 mod 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java Backport-of: 84c99fb91ffc4bfbc2fb0f20f558603d5660d7f1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1409 From goetz at openjdk.org Thu Feb 20 08:09:07 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 08:09:07 GMT Subject: [jdk21u-dev] Integrated: 8342098: Write a test to compare the images In-Reply-To: <-HU90wQN-EmLgQnpX9BEiVF5ioN78LzcOwEOfO7apYg=.9427a4ee-2eb7-4a18-ada8-12450a884fa8@github.com> References: <-HU90wQN-EmLgQnpX9BEiVF5ioN78LzcOwEOfO7apYg=.9427a4ee-2eb7-4a18-ada8-12450a884fa8@github.com> Message-ID: <7xZoyyn1NY42ASkXmxmnT3Re6NST5aroiToVgVGCEb8=.0bc68274-09e6-4a03-8e61-06b85f8d6655@github.com> On Tue, 18 Feb 2025 20:30:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle This pull request has now been integrated. Changeset: 1b49a33e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/1b49a33e73ba40058462e0d8269d941386d94a30 Stats: 166 lines in 1 file changed: 166 ins; 0 del; 0 mod 8342098: Write a test to compare the images Backport-of: 47ebf8d868b2e15b943a227ad3cf2ee12eed10f6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1410 From syan at openjdk.org Thu Feb 20 08:22:35 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 20 Feb 2025 08:22:35 GMT Subject: [jdk24u] RFR: 8349943: [JMH] Use jvmArgs consistently Message-ID: Hi all, This pull request contains a backport of commit [3ebed783](https://github.com/openjdk/jdk/commit/3ebed78328bd64d2e18369d63d6ea323b87a7b24) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Nicole Xu on 20 Feb 2025 and was reviewed by SendaoYan, Claes Redestad and Hao Sun. Thanks! ------------- Commit messages: - Backport 3ebed78328bd64d2e18369d63d6ea323b87a7b24 Changes: https://git.openjdk.org/jdk24u/pull/83/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=83&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349943 Stats: 20 lines in 9 files changed: 2 ins; 0 del; 18 mod Patch: https://git.openjdk.org/jdk24u/pull/83.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/83/head:pull/83 PR: https://git.openjdk.org/jdk24u/pull/83 From goetz at openjdk.org Thu Feb 20 08:59:41 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 08:59:41 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v2] In-Reply-To: References: Message-ID: > I backport this to match 17.0.13-oracle based on the commit to 21. > > I had to resolve several files, two of them considerably: > > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java > Resolved larger chunk. > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java > Resolved some code. > > The new code in DHPublic/PrivateKey depends on the removal > of IOExceptions in [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) "DerOutputStream operations should not throw IOExceptions". > This change is in 21 but not in 17. Thus code backported from 21 calls functions of > DerOutputStream that do not throw an exception in 21, but do so in 17. > JDK-8297065 makes the point that these exceptions can never be thrown, which also > holds for 17. So I just catch and ignore them. > > Also, I had to adapt code because an exception constructor with cause for > InvalidObjectException is missing in 17. > This was added by [JDK-8282696](https://bugs.openjdk.org/browse/JDK-8282696) "Add constructors taking a cause > to InvalidObjectException and InvalidClassException" in 19. > I added a call to initCause() to store the causing exception. > > I double-checked that [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) was not backported > by Oracle. Backporting this change would simplify matters considerably. > > The remaining files only needed trivial resolves: > > src/java.base/share/classes/java/security/Permissions.java > src/java.base/share/classes/java/security/SignedObject.java > Only Copyright. > src/java.base/share/classes/java/security/Timestamp.java > Copyright and import. > src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java > src/java.base/share/classes/java/security/cert/CertificateRevokedException.java > src/java.base/share/classes/sun/security/provider/DRBG.java > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > src/java.base/share/classes/sun/security/x509/AlgIdDSA.java > Only Copyright. > src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Context.java > Resolved imports. > src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecureRandom.java > Only Copyright. > > I manually ran these tests on linux x86_64: > > test/jdk/com/sun/security > test/jdk/java/awt/security > test/jdk/java/net/httpclient/security > test/jdk/java/net/httpclient/websocket/security > test/jdk/java/security > test/jdk/javax/management/security > test/jdk/javax/security > t... Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Remove mentioning of ProviderException ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3278/files - new: https://git.openjdk.org/jdk17u-dev/pull/3278/files/1cff1fbd..55b241ec Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3278&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3278&range=00-01 Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3278.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3278/head:pull/3278 PR: https://git.openjdk.org/jdk17u-dev/pull/3278 From goetz at openjdk.org Thu Feb 20 08:59:41 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 08:59:41 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v2] In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 17:07:45 GMT, Richard Reingruber wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove mentioning of ProviderException > > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java line 212: > >> 210: * @param g the base generator >> 211: * >> 212: * @throws ProviderException if the key cannot be encoded > > `ProviderException` isn't thrown anymore, is it? I think you should remove the `@throws ProviderException` line here and below. The import should also be removed. Hi @reinrich, thanks for looking at this backport. I fixed DHPrivateKey accordingly. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#discussion_r1963112027 From ssarathi at openjdk.org Thu Feb 20 09:37:35 2025 From: ssarathi at openjdk.org (Sorna Sarathi N) Date: Thu, 20 Feb 2025 09:37:35 GMT Subject: [jdk21u-dev] RFR: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11 [v2] In-Reply-To: References: Message-ID: > Hi all, > This pull request contains a backport of commit [3251eea](https://github.com/openjdk/jdk/commit/3251eea1f4289a0505052be204407c02ca38b0ad) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > Tier1 testing is successful. > Thanks! > > JBS Issue: [JDK-8336499](https://bugs.openjdk.org/browse/JDK-8336499) Sorna Sarathi N has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 3251eea1f4289a0505052be204407c02ca38b0ad ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/1021/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1021&range=01 Stats: 81 lines in 1 file changed: 44 ins; 18 del; 19 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1021.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1021/head:pull/1021 PR: https://git.openjdk.org/jdk21u-dev/pull/1021 From sroy at openjdk.org Thu Feb 20 10:04:56 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Thu, 20 Feb 2025 10:04:56 GMT Subject: [jdk21u] RFR: 8349729 : [AIX] jtreg tests fail to compile with qvisibility=hidden Message-ID: JBS ISSUE : [JDK-8349729](https://bugs.openjdk.org/browse/JDK-8349729) ------------- Commit messages: - remove xlc check Changes: https://git.openjdk.org/jdk21u/pull/459/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=459&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349729 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/459.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/459/head:pull/459 PR: https://git.openjdk.org/jdk21u/pull/459 From goetz at openjdk.org Thu Feb 20 10:10:08 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 10:10:08 GMT Subject: [jdk21u] RFR: 8349729 : [AIX] jtreg tests fail to compile with qvisibility=hidden In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 08:56:21 GMT, Suchismith Roy wrote: > JBS ISSUE : [JDK-8349729](https://bugs.openjdk.org/browse/JDK-8349729) Hi @suchismith1993 please target jdk21u-dev, jdk21u is closed for backports as long automatic merges from jdk21u-dev to jdk21u are done. This ends on Feb 25th. Also please enable GHA actions for this repo. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/459#issuecomment-2671031414 PR Comment: https://git.openjdk.org/jdk21u/pull/459#issuecomment-2671032498 From goetz at openjdk.org Thu Feb 20 10:21:29 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 10:21:29 GMT Subject: [jdk17u-dev] RFR: 8274893: Update java.desktop classes to use try-with-resources Message-ID: I backport this for parity with 17.0.15-oracle. I hesitated a while to backport this Enhancements, but I think it's better to go along with Oracle here, too. Especially as it's an almost clean backport. Copyright: src/java.desktop/share/classes/com/sun/media/sound/AudioFileSoundbankReader.java src/java.desktop/share/classes/com/sun/media/sound/JARSoundbankReader.java src/java.desktop/share/classes/javax/imageio/ImageIO.java The try-finally statement catches an exception in 17, which is not present in the original change. This is becasue "(8272998)[https://bugs.openjdk.org/browse/JDK-8272998]: ImageIO.read() throws incorrect exception type" was already backported. Trivial resolve. ------------- Commit messages: - Backport 70c6df6be431fe11c5441986ed04040f9ec3b750 Changes: https://git.openjdk.org/jdk17u-dev/pull/3283/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3283&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274893 Stats: 225 lines in 24 files changed: 27 ins; 98 del; 100 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3283.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3283/head:pull/3283 PR: https://git.openjdk.org/jdk17u-dev/pull/3283 From duke at openjdk.org Thu Feb 20 10:22:33 2025 From: duke at openjdk.org (kieran-farrell) Date: Thu, 20 Feb 2025 10:22:33 GMT Subject: [jdk24u] RFR: 8348102: java/net/httpclient/HttpClientSNITest.java fails intermittently Message-ID: 8348102: java/net/httpclient/HttpClientSNITest.java fails intermittently ------------- Commit messages: - 835026 update test Changes: https://git.openjdk.org/jdk24u/pull/84/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=84&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348102 Stats: 17 lines in 1 file changed: 5 ins; 9 del; 3 mod Patch: https://git.openjdk.org/jdk24u/pull/84.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/84/head:pull/84 PR: https://git.openjdk.org/jdk24u/pull/84 From goetz at openjdk.org Thu Feb 20 10:31:59 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 10:31:59 GMT Subject: [jdk21u-dev] RFR: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 11:06:53 GMT, Antonio Vieiro wrote: > Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 24u that solves some accessibility issues on Windows, for parity with 11.0.27-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. > > The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ) Hi @vieiro Thanks for adressing this! Did this really read out the menu items in your test? Did you double-check the test is failing without the fix? It did not work out in my setup on the first try, but I did not find time to look into this further. I assumed it is related to my local JAWS setup. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1414#issuecomment-2671085274 From duke at openjdk.org Thu Feb 20 11:37:03 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 20 Feb 2025 11:37:03 GMT Subject: [jdk21u-dev] RFR: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 10:29:30 GMT, Goetz Lindenmaier wrote: > Hi @vieiro Thanks for adressing this! > Did this really read out the menu items in your test? Yes. Peculiarly JAWS was reading the text of JMenuItems in perfect english, and some of the shortcut words in spanish (for instance, `Shift` was read out as `May?sculas`). Windows language was set to "english" (but the keyboard was set to spanish, I may change the keyboard layout if you want and double check). > Did you double-check the test is failing without the fix? Yes. The shortcut "Ctrl+Shift+Period" was read out as "Control plus May?sculas plus P" (and not `Period`). > It did not work out in my setup on the first try, but I did not find time to look into this further. I assumed it is related to my local JAWS setup. Could be. As I said JAWS seems to be speaking out some shortcut words in spanish and others in english. @GoeLin D'oh. I hit the "Close and comment" button instead of the "Comment" button. Reopening. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1414#issuecomment-2671232645 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1414#issuecomment-2671237141 From dchuyko at openjdk.org Thu Feb 20 12:14:33 2025 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Thu, 20 Feb 2025 12:14:33 GMT Subject: [jdk21u-dev] RFR: 8350412: [21u] AArch64: Ambiguous frame layout leads to incorrect traces in JFR Message-ID: This change fixes incorrect stack traces sometimes reported by JFR (non-deterministic stack walking). It is technically a clean backport of 'Make the anchor frame walkable' changes of aarch64_enc_java_to_runtime() from https://github.com/openjdk/jdk/pull/21565/files#diff-018aa61d1a7aafcf70a535fcd40a318a4bd6511fd40ac39ce4be90cc52216749 I propose to cherry pick those into older releases after JDK 24 is out, starting from 21u. Testing: tier1,2 on linux-aarch64. ------------- Commit messages: - Backport 'Make the anchor frame walkable' in aarch64.ad from JDK-8338383 Changes: https://git.openjdk.org/jdk21u-dev/pull/1418/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1418&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350412 Stats: 7 lines in 1 file changed: 3 ins; 4 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1418.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1418/head:pull/1418 PR: https://git.openjdk.org/jdk21u-dev/pull/1418 From kcr at openjdk.org Thu Feb 20 12:40:54 2025 From: kcr at openjdk.org (Kevin Rushforth) Date: Thu, 20 Feb 2025 12:40:54 GMT Subject: [jdk24u] RFR: 8347377: Add validation checks for ICC_Profile header fields In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 00:36:55 GMT, Kevin Rushforth wrote: >> @prrace @jayathirthrao Can you please review and approve this backport? > >> @prrace @jayathirthrao Can you please review and approve this backport? > > To be clear on the terminology: Phil or Jay can Review the PR (and approve the review). Since this is a clean backport, this is optional unless either you or they feel that it is needed. > > The maintainer Approval (from @robm-openjdk) is what is blocking integration. > @kevinrushforth I was under the same assumption that a clean backport doesn't require additional review/approval. After discussing with Phil, he mentioned that a review/approval is required (because of RFR label) before the maintainer approves the fix request. Not for a clean backport (although it's always OK to have it reviewed, it's optional). > Additionally do I need to add client label to this PR? You can if you like, but it isn't necessary. See, for example, the recent TrayIcon Wayland backport #78 -- it was neither reviewed nor was the client label added. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/82#issuecomment-2671378387 From goetz at openjdk.org Thu Feb 20 12:41:01 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 12:41:01 GMT Subject: [jdk17u-dev] Integrated: 8292848: AWT_Mixing and TrayIcon tests fail on el8 with hard-coded isOel7 In-Reply-To: References: Message-ID: On Tue, 18 Feb 2025 20:14:06 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: 54628252 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5462825246a94a0bafa157987356e14738eda018 Stats: 69 lines in 12 files changed: 19 ins; 0 del; 50 mod 8292848: AWT_Mixing and TrayIcon tests fail on el8 with hard-coded isOel7 Backport-of: c13e0ef3f8046a979638d6885a732553fc2b126e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3279 From goetz at openjdk.org Thu Feb 20 12:43:00 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 12:43:00 GMT Subject: [jdk17u-dev] Integrated: 8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main In-Reply-To: References: Message-ID: On Tue, 18 Feb 2025 20:14:56 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: 9d2235be Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9d2235be583671cc54eef2701c2bf903d351e091 Stats: 542 lines in 3 files changed: 211 ins; 331 del; 0 mod 8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main Backport-of: 4047a3623a44d86df2b82565f33ce739a882802d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3280 From goetz at openjdk.org Thu Feb 20 12:43:53 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 12:43:53 GMT Subject: [jdk17u-dev] Integrated: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java In-Reply-To: References: Message-ID: <67G_NL0CJDWLXK8gHUedbnXzQhHLAQd_6EecuD2BHhA=.869d1cf6-864d-43d2-bb54-84c3d9deea14@github.com> On Tue, 18 Feb 2025 20:21:42 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle This pull request has now been integrated. Changeset: ceea8821 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ceea8821af29fc88bd96616dd254d6c9dcc0692b Stats: 514 lines in 2 files changed: 85 ins; 180 del; 249 mod 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java Backport-of: 84c99fb91ffc4bfbc2fb0f20f558603d5660d7f1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3281 From mbaesken at openjdk.org Thu Feb 20 12:53:58 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 20 Feb 2025 12:53:58 GMT Subject: [jdk17u-dev] RFR: 8314975: JavadocTester should set source path if not specified [v2] In-Reply-To: <5Ocn4LlJ2kUVVh126hX-sbhvtfN4jNGKAVuvFEhKcSk=.2ba369fe-f39c-4c54-8c55-dffc26b5375c@github.com> References: <5Ocn4LlJ2kUVVh126hX-sbhvtfN4jNGKAVuvFEhKcSk=.2ba369fe-f39c-4c54-8c55-dffc26b5375c@github.com> Message-ID: On Thu, 6 Feb 2025 13:59:00 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.16-oracle. >> >> Add-on: >> >> Our nightly testing found that TestCopyFiles.java is failing with this patch. >> This concerns only the subtest testDocFilesInPackagesSource7UsingClassPath(). >> >> This test is removed in later jdks by [JDK-8173605](https://bugs.openjdk.org/browse/JDK-8173605): Remove support for source and target 1.7 option in javac. >> >> The test sets "-source 7" for the test run. It tests that -classpath can >> be given to javadoc instead of -sourcepath. This feature still exists in higher jdks, >> I verified that the test is passing if either using "-source 8/9" or removing this flag (and undoing the edits of this change). >> >> The edits of this change affect that -sourcepath is added to the javadoc command line, but the >> path used (testSrc) does not point to the proper sources. Thus the test fails. >> >> I see several ways to repair this: >> * add proper -sourcepath to the test. This contradicts the purpose of this test, but makes it pass. See second commit. >> * remove the test altogether as it is the case in later jdks. >> * somehow implement a special case to avoid that JavadocTester adds -sourcepath to this test. >> >> A somewhat bigger fix would be to add "-classpath" to the check for sourcepath in JavadocTester and add the testDocFilesInPackagesSource7UsingClassPath back again, but remove the -source setting from that test. I guess this should be done in head and backported to 24, 21 and 17. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Fix TestCopyFiles.java Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3266#pullrequestreview-2629756617 From jkratochvil at azul.com Thu Feb 20 13:05:04 2025 From: jkratochvil at azul.com (Jan Kratochvil) Date: Thu, 20 Feb 2025 21:05:04 +0800 Subject: [21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected In-Reply-To: <744c5981746193fd5c1f4c4f1b92fd7d5e851eca.camel@redhat.com> References: <1e30742239badd10d071ed9f5d591763a92a1990.camel@redhat.com> <744c5981746193fd5c1f4c4f1b92fd7d5e851eca.camel@redhat.com> Message-ID: On Sat, 15 Feb 2025 02:05:38 +0800, Severin Gehwolf wrote: > This is a rather invasive patch set. Is this something that Azul ships > in the downstream distribution? No. The customer is waiting since January 2024 how JDK upstream decides. Azul does not want to fork from upstream too much. > Surely this only applies to systems that have such a setup (of > hierarchical cgroups), not cgroup limits in general. Common container > frameworks (kubernetes) aren't affected AFAIK (I might be wrong, > though). The risk is a function of such affected systems. Would you > have any estimation of the affected systems out in the wild? That would > help assess this. It can affect any Linux system as systemd is everywhere nowadays and root can: # systemctl set-property user.slice MemoryMax=256M > > As the code is the same in 21u as in 24u and all the backports are clean I do > > not expect regressions. > > JDK 24 hasn't been officially released yet, so the proposed patches > haven't seen much real-world usage yet. OK. Thanks, Jan Kratochvil From goetz at openjdk.org Thu Feb 20 13:17:54 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 13:17:54 GMT Subject: [jdk17u-dev] RFR: 8314975: JavadocTester should set source path if not specified [v2] In-Reply-To: <5Ocn4LlJ2kUVVh126hX-sbhvtfN4jNGKAVuvFEhKcSk=.2ba369fe-f39c-4c54-8c55-dffc26b5375c@github.com> References: <5Ocn4LlJ2kUVVh126hX-sbhvtfN4jNGKAVuvFEhKcSk=.2ba369fe-f39c-4c54-8c55-dffc26b5375c@github.com> Message-ID: <2r7vhkF3wre7QcDXkazfV175y3p0BmlV_xSH1JO8dx8=.47e04fba-738c-46cc-bc17-c0df9247e140@github.com> On Thu, 6 Feb 2025 13:59:00 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.16-oracle. >> >> Add-on: >> >> Our nightly testing found that TestCopyFiles.java is failing with this patch. >> This concerns only the subtest testDocFilesInPackagesSource7UsingClassPath(). >> >> This test is removed in later jdks by [JDK-8173605](https://bugs.openjdk.org/browse/JDK-8173605): Remove support for source and target 1.7 option in javac. >> >> The test sets "-source 7" for the test run. It tests that -classpath can >> be given to javadoc instead of -sourcepath. This feature still exists in higher jdks, >> I verified that the test is passing if either using "-source 8/9" or removing this flag (and undoing the edits of this change). >> >> The edits of this change affect that -sourcepath is added to the javadoc command line, but the >> path used (testSrc) does not point to the proper sources. Thus the test fails. >> >> I see several ways to repair this: >> * add proper -sourcepath to the test. This contradicts the purpose of this test, but makes it pass. See second commit. >> * remove the test altogether as it is the case in later jdks. >> * somehow implement a special case to avoid that JavadocTester adds -sourcepath to this test. >> >> A somewhat bigger fix would be to add "-classpath" to the check for sourcepath in JavadocTester and add the testDocFilesInPackagesSource7UsingClassPath back again, but remove the -source setting from that test. I guess this should be done in head and backported to 24, 21 and 17. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Fix TestCopyFiles.java Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3266#issuecomment-2671464003 From goetz at openjdk.org Thu Feb 20 13:28:40 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 13:28:40 GMT Subject: [jdk17u-dev] RFR: 8301989: new javax.swing.text.DefaultCaret().setBlinkRate(N) results in NPE Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport e81f20b50405dc02963c8bf549000c60e78152d8 Changes: https://git.openjdk.org/jdk17u-dev/pull/3284/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3284&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301989 Stats: 49 lines in 2 files changed: 46 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3284.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3284/head:pull/3284 PR: https://git.openjdk.org/jdk17u-dev/pull/3284 From goetz at openjdk.org Thu Feb 20 13:29:59 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 13:29:59 GMT Subject: [jdk17u-dev] Integrated: 8342098: Write a test to compare the images In-Reply-To: References: Message-ID: On Tue, 18 Feb 2025 20:30:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: b2f814e0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/b2f814e033e1bd81be1d8c2dff16dcf7aa80eddc Stats: 166 lines in 1 file changed: 166 ins; 0 del; 0 mod 8342098: Write a test to compare the images Backport-of: 47ebf8d868b2e15b943a227ad3cf2ee12eed10f6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3282 From goetz at openjdk.org Thu Feb 20 13:37:26 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 13:37:26 GMT Subject: [jdk17u-dev] RFR: 8337222: gc/TestDisableExplicitGC.java fails due to unexpected CodeCache GC Message-ID: <-o2IHfc9vqG_Z6slE5AMnezmHhKl9U4yCbpo8AIXJNw=.f634427b-dc27-403d-9f87-0f94b7751e25@github.com> I backport this for parity with 17.0.16-oracle ------------- Commit messages: - Backport dab2a0b5978cdd3fad693e4c120a84bb64a3ccde Changes: https://git.openjdk.org/jdk17u-dev/pull/3285/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3285&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337222 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3285.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3285/head:pull/3285 PR: https://git.openjdk.org/jdk17u-dev/pull/3285 From goetz at openjdk.org Thu Feb 20 13:37:32 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 13:37:32 GMT Subject: [jdk21u-dev] RFR: 8337222: gc/TestDisableExplicitGC.java fails due to unexpected CodeCache GC Message-ID: I backport this for parity with 21.0.8-oracle. ------------- Commit messages: - Backport dab2a0b5978cdd3fad693e4c120a84bb64a3ccde Changes: https://git.openjdk.org/jdk21u-dev/pull/1419/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1419&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337222 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1419.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1419/head:pull/1419 PR: https://git.openjdk.org/jdk21u-dev/pull/1419 From goetz at openjdk.org Thu Feb 20 13:58:25 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 13:58:25 GMT Subject: [jdk17u-dev] RFR: 8338595: Add more linesize for MIME decoder in macro bench test Base64Decode Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport 7458952dedc0a34b5c7f3e9e228f9b18e08f19e3 Changes: https://git.openjdk.org/jdk17u-dev/pull/3286/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3286&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338595 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3286.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3286/head:pull/3286 PR: https://git.openjdk.org/jdk17u-dev/pull/3286 From goetz at openjdk.org Thu Feb 20 13:59:28 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 13:59:28 GMT Subject: [jdk21u-dev] RFR: 8338595: Add more linesize for MIME decoder in macro bench test Base64Decode Message-ID: <4MyPaageQjDIGPcPdi7uD4q2UnxI5arAKFAcJ6yJnaA=.be723f32-90a9-4d00-9b6c-230bb6cd1d0d@github.com> I backport this for parity with 21.0.8-oracle. ------------- Commit messages: - Backport 7458952dedc0a34b5c7f3e9e228f9b18e08f19e3 Changes: https://git.openjdk.org/jdk21u-dev/pull/1420/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1420&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338595 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1420.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1420/head:pull/1420 PR: https://git.openjdk.org/jdk21u-dev/pull/1420 From goetz at openjdk.org Thu Feb 20 14:07:31 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 14:07:31 GMT Subject: [jdk21u-dev] RFR: 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI Message-ID: I backport this for parity with 21.0.8-oracle ------------- Commit messages: - Backport a0b7c4f015c694425893b8d21d2aecae71a3b604 Changes: https://git.openjdk.org/jdk21u-dev/pull/1421/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1421&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346324 Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1421.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1421/head:pull/1421 PR: https://git.openjdk.org/jdk21u-dev/pull/1421 From goetz at openjdk.org Thu Feb 20 14:10:03 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 14:10:03 GMT Subject: [jdk17u-dev] RFR: 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport a0b7c4f015c694425893b8d21d2aecae71a3b604 Changes: https://git.openjdk.org/jdk17u-dev/pull/3287/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3287&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346324 Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3287.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3287/head:pull/3287 PR: https://git.openjdk.org/jdk17u-dev/pull/3287 From goetz at openjdk.org Thu Feb 20 14:20:32 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 14:20:32 GMT Subject: [jdk21u-dev] RFR: 8346828: javax/swing/JScrollBar/4865918/bug4865918.java still fails in CI Message-ID: I backport this for parity with 21.0.8-oracle ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/1421 Commit messages: - Backport 9fafd63d46f64428e0b9c2e9a6b0ac7ca0e2d355 Changes: https://git.openjdk.org/jdk21u-dev/pull/1422/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1422&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346828 Stats: 35 lines in 1 file changed: 4 ins; 19 del; 12 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1422.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1422/head:pull/1422 PR: https://git.openjdk.org/jdk21u-dev/pull/1422 From goetz at openjdk.org Thu Feb 20 14:21:05 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 14:21:05 GMT Subject: [jdk17u-dev] RFR: 8346828: javax/swing/JScrollBar/4865918/bug4865918.java still fails in CI Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/3287 Commit messages: - Backport 9fafd63d46f64428e0b9c2e9a6b0ac7ca0e2d355 Changes: https://git.openjdk.org/jdk17u-dev/pull/3288/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3288&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346828 Stats: 35 lines in 1 file changed: 4 ins; 19 del; 12 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3288.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3288/head:pull/3288 PR: https://git.openjdk.org/jdk17u-dev/pull/3288 From goetz at openjdk.org Thu Feb 20 14:29:31 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 14:29:31 GMT Subject: [jdk21u-dev] RFR: 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland Message-ID: I backport this for parity with 21.0.8-oracle ------------- Commit messages: - Backport 6f4fc82149b52dd91289fe42def7d1cacad31212 Changes: https://git.openjdk.org/jdk21u-dev/pull/1423/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1423&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348675 Stats: 204 lines in 4 files changed: 91 ins; 22 del; 91 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1423.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1423/head:pull/1423 PR: https://git.openjdk.org/jdk21u-dev/pull/1423 From jdv at openjdk.org Thu Feb 20 14:49:59 2025 From: jdv at openjdk.org (Jayathirth D V) Date: Thu, 20 Feb 2025 14:49:59 GMT Subject: [jdk24u] RFR: 8347377: Add validation checks for ICC_Profile header fields In-Reply-To: References: Message-ID: <5oojmClSxK907bYaF25whvAKc1GnRc_4pYMFmqAsM3s=.46a81e8c-d323-4926-a8fd-56cafc65a1fd@github.com> On Wed, 19 Feb 2025 17:46:25 GMT, Harshitha Onkar wrote: > Hi all, > > This pull request contains a backport of commit [ed8945a6](https://github.com/openjdk/jdk/commit/ed8945a68a67dd51a7cfa332905941afccc12b36) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Harshitha Onkar on 6 Feb 2025 and was reviewed by Phil Race and Jayathirth D V. > > Thanks! I think this doesn't need any approval apart from Maintainer of 24u as it is applied cleanly. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/82#issuecomment-2671716962 From goetz at openjdk.org Thu Feb 20 14:55:08 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 14:55:08 GMT Subject: [jdk17u-dev] RFR: 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport 6f4fc82149b52dd91289fe42def7d1cacad31212 Changes: https://git.openjdk.org/jdk17u-dev/pull/3289/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3289&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348675 Stats: 204 lines in 4 files changed: 91 ins; 22 del; 91 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3289.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3289/head:pull/3289 PR: https://git.openjdk.org/jdk17u-dev/pull/3289 From goetz at openjdk.org Thu Feb 20 15:07:21 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 15:07:21 GMT Subject: [jdk21u-dev] RFR: 8327476: Upgrade JLine to 3.26.1 Message-ID: I backport this change for parity with 21.0.7-oracle. It brings updates of upstream library jline 3.26.1 to jdk21. Jdk21 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). The original sources of jline 3.26.1 can be found here: https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz The backport of this change needed larger adaptions. The original jline library dynamically selects how to access the operating system in two means: * Which operating system? linux, windows, mac? * JDK functionality to do native calls: JNI, jna, ffm? The implementation in OpenJDK does this selection at JDK build time. The code is split into more subdirectories for the operating systems. One of the methods to call native is picked, the code for the others is removed. Unfortunately this differs for the JDK releases: * jdk21 uses jna. * jdk23 uses ffm. The original patch of this change includes all the edits to replace jna by ffm. Further changes that fell into the eye during the backport * jline changed the format of its Copyright header * jline changed sorting of imports * jline changed a lot of formatting, especially how arguments to methods are listed. * jline removed the `Stream` enum from `TerminalProvider.java` and moved it into a class of its own: `SystemStream.java`. This makes changes to import statements and argument lists necessary. * OpenJDK added a new parameter `inputStreamWrapper` to the functions which are also affected by the `Stream` enum change. This also made changes to import statements and argument lists necessary. OpenJDK 23 added jline to the list of modules needed for a jre. I don't think we should do that in 21, so I omitted that change. jline 3.26.1 and OpenJDK 23 added a new method `systemStreamWidth() `to `TerminalProvider`. I don't think we should extend the functionlaity of jline in 21, so I omitted this. Also, I would need additional parts of the jline windows files that are not yet included in OpenJDK to implement this. For the backport, I dropped the following files from the patch: ``` src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/CLibrary.java src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmNativePty.java src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmTerminalProvider.java src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/Kernel32.java src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/NativeWinConsoleWriter.java src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/NativeWinSysTerminal.java src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/WindowsAnsiWriter.java Also, I did not remove the following files as the original change did: ``` make/modules/jdk.internal.le/Lib.gmk src/jdk.internal.le/aix/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java src/jdk.internal.le/linux/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java src/jdk.internal.le/linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/CLibrary.java src/jdk.internal.le/linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/CLibraryImpl.java src/jdk.internal.le/linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/LinuxNativePty.java src/jdk.internal.le/linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/UtilLibraryImpl.java src/jdk.internal.le/linux/native/lible/CLibrary.cpp src/jdk.internal.le/macosx/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java src/jdk.internal.le/macosx/classes/jdk/internal/org/jline/terminal/impl/jna/osx/CLibrary.java src/jdk.internal.le/macosx/classes/jdk/internal/org/jline/terminal/impl/jna/osx/CLibraryImpl.java src/jdk.internal.le/macosx/classes/jdk/internal/org/jline/terminal/impl/jna/osx/NativeLong.java src/jdk.internal.le/macosx/classes/jdk/internal/org/jline/terminal/impl/jna/osx/OsXNativePty.java src/jdk.internal.le/macosx/native/lible/CLibrary.cpp src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/jna/LastErrorException.java src/jdk.internal.le/unix/classes/jdk/internal/org/jline/terminal/impl/jna/JnaNativePty.java src/jdk.internal.le/unix/classes/jdk/internal/org/jline/terminal/impl/jna/JnaTerminalProvider.java src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/JnaTerminalProvider.java src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/IntByReference.java src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/JnaWinConsoleWriter.java src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/JnaWinSysTerminal.java src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/Kernel32.java src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/Kernel32Impl.java src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/Pointer.java src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/WindowsAnsiWriter.java src/jdk.internal.le/windows/native/lible/Kernel32.cpp I added the changes for the new parameter "`inputStreamWrapper`" in the jna files. I patched all differences between jline 3.22.0 and 3.26.1 into the jna files that were deleted in the original change for jdk23, as far as there is a direct relation between OpenJDK 21 and upstream jline. I split the changes needed on top of the origin patch into several commits. ------------- Commit messages: - Adapt jdk21 jna parts to changes from OpenJDk head and from jline 3.26.1 - Don't add new method systemStreamWidth() - Dont put jline into jre, keep the status of 21 - Backport aaa90b3005c85852971203ce6feb88e7091e167b Changes: https://git.openjdk.org/jdk21u-dev/pull/1413/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1413&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327476 Stats: 6858 lines in 126 files changed: 3024 ins; 1089 del; 2745 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1413.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1413/head:pull/1413 PR: https://git.openjdk.org/jdk21u-dev/pull/1413 From mdoerr at openjdk.org Thu Feb 20 15:23:58 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 20 Feb 2025 15:23:58 GMT Subject: [jdk21u-dev] RFR: 8327476: Upgrade JLine to 3.26.1 In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 09:37:11 GMT, Goetz Lindenmaier wrote: > I backport this change for parity with 21.0.7-oracle. > > It brings updates of upstream library jline 3.26.1 to jdk21. > Jdk21 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). > The original sources of jline 3.26.1 can be found here: > https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz > > The backport of this change needed larger adaptions. > > The original jline library dynamically selects how to access > the operating system in two means: > * Which operating system? linux, windows, mac? > * JDK functionality to do native calls: JNI, jna, ffm? > > The implementation in OpenJDK does this selection at JDK build time. > The code is split into more subdirectories for the operating systems. > One of the methods to call native is picked, the code for the others > is removed. Unfortunately this differs for the JDK releases: > * jdk21 uses jna. > * jdk23 uses ffm. > The original patch of this change includes all the edits to > replace jna by ffm. > > Further changes that fell into the eye during the backport > * jline changed the format of its Copyright header > * jline changed sorting of imports > * jline changed a lot of formatting, especially how > arguments to methods are listed. > * jline removed the `Stream` enum from `TerminalProvider.java` and moved it > into a class of its own: `SystemStream.java`. This makes changes to > import statements and argument lists necessary. > * OpenJDK added a new parameter `inputStreamWrapper` to the > functions which are also affected by the `Stream` enum change. > This also made changes to import statements and argument lists > necessary. > > OpenJDK 23 added jline to the list of modules needed for a jre. > I don't think we should do that in 21, so I omitted that change. > > jline 3.26.1 and OpenJDK 23 added a new method `systemStreamWidth() `to `TerminalProvider`. > I don't think we should extend the functionlaity of jline in 21, > so I omitted this. Also, I would need additional parts of the > jline windows files that are not yet included in OpenJDK to > implement this. > > For the backport, I dropped the following files from the patch: > ``` > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/CLibrary.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmNativePty.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmTerminalProvider.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/termina... Indentation looks bad in some commented lines: + // state = State.INTERRUPT; + // addBuiltinWidget(widgets, QUIT, this::quit); + // bind(vicmd, INSERT_COMMENT, alt('#')); + // bind(vicmd, INSERT_COMPLETIONS, alt('*')); + // if (attributes.getLocalFlag(Attributes.LocalFlag.ECHO)) { + // processOutputByte(c); + // masterOutput.flush(); + // } + // case 'l': + // rawPrint('\l'); + // break; + // if (charRead < 0) { + // continue; + // } + // charRead = -1; (The PR is too large to review it in the GUI.) The 4th Commit is from https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz ? Thanks for splitting the PR into the individual commits! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1413#issuecomment-2671821179 From goetz at openjdk.org Thu Feb 20 15:30:54 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 15:30:54 GMT Subject: [jdk21u-dev] RFR: 8327476: Upgrade JLine to 3.26.1 In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 09:37:11 GMT, Goetz Lindenmaier wrote: > I backport this change for parity with 21.0.7-oracle. > > It brings updates of upstream library jline 3.26.1 to jdk21. > Jdk21 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). > The original sources of jline 3.26.1 can be found here: > https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz > > The backport of this change needed larger adaptions. > > The original jline library dynamically selects how to access > the operating system in two means: > * Which operating system? linux, windows, mac? > * JDK functionality to do native calls: JNI, jna, ffm? > > The implementation in OpenJDK does this selection at JDK build time. > The code is split into more subdirectories for the operating systems. > One of the methods to call native is picked, the code for the others > is removed. Unfortunately this differs for the JDK releases: > * jdk21 uses jna. > * jdk23 uses ffm. > The original patch of this change includes all the edits to > replace jna by ffm. > > Further changes that fell into the eye during the backport > * jline changed the format of its Copyright header > * jline changed sorting of imports > * jline changed a lot of formatting, especially how > arguments to methods are listed. > * jline removed the `Stream` enum from `TerminalProvider.java` and moved it > into a class of its own: `SystemStream.java`. This makes changes to > import statements and argument lists necessary. > * OpenJDK added a new parameter `inputStreamWrapper` to the > functions which are also affected by the `Stream` enum change. > This also made changes to import statements and argument lists > necessary. > > OpenJDK 23 added jline to the list of modules needed for a jre. > I don't think we should do that in 21, so I omitted that change. > > jline 3.26.1 and OpenJDK 23 added a new method `systemStreamWidth() `to `TerminalProvider`. > I don't think we should extend the functionlaity of jline in 21, > so I omitted this. Also, I would need additional parts of the > jline windows files that are not yet included in OpenJDK to > implement this. > > For the backport, I dropped the following files from the patch: > ``` > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/CLibrary.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmNativePty.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmTerminalProvider.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/termina... Hi, the fourth commit combines the changes from jline-parent-3.26.1 and what is needed to implement changes by the original OpenJDK 3.26.1 change. In detail this is passing `inputStreamWrapper` to the functions in the jna part. I'll have a look at the indentation. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1413#issuecomment-2671841364 From goetz at openjdk.org Thu Feb 20 15:34:01 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 15:34:01 GMT Subject: [jdk21u-dev] RFR: 8327476: Upgrade JLine to 3.26.1 In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 09:37:11 GMT, Goetz Lindenmaier wrote: > I backport this change for parity with 21.0.7-oracle. > > It brings updates of upstream library jline 3.26.1 to jdk21. > Jdk21 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). > The original sources of jline 3.26.1 can be found here: > https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz > > The backport of this change needed larger adaptions. > > The original jline library dynamically selects how to access > the operating system in two means: > * Which operating system? linux, windows, mac? > * JDK functionality to do native calls: JNI, jna, ffm? > > The implementation in OpenJDK does this selection at JDK build time. > The code is split into more subdirectories for the operating systems. > One of the methods to call native is picked, the code for the others > is removed. Unfortunately this differs for the JDK releases: > * jdk21 uses jna. > * jdk23 uses ffm. > The original patch of this change includes all the edits to > replace jna by ffm. > > Further changes that fell into the eye during the backport > * jline changed the format of its Copyright header > * jline changed sorting of imports > * jline changed a lot of formatting, especially how > arguments to methods are listed. > * jline removed the `Stream` enum from `TerminalProvider.java` and moved it > into a class of its own: `SystemStream.java`. This makes changes to > import statements and argument lists necessary. > * OpenJDK added a new parameter `inputStreamWrapper` to the > functions which are also affected by the `Stream` enum change. > This also made changes to import statements and argument lists > necessary. > > OpenJDK 23 added jline to the list of modules needed for a jre. > I don't think we should do that in 21, so I omitted that change. > > jline 3.26.1 and OpenJDK 23 added a new method `systemStreamWidth() `to `TerminalProvider`. > I don't think we should extend the functionlaity of jline in 21, > so I omitted this. Also, I would need additional parts of the > jline windows files that are not yet included in OpenJDK to > implement this. > > For the backport, I dropped the following files from the patch: > ``` > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/CLibrary.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmNativePty.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmTerminalProvider.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/termina... Indentation: That part is broken in the original patch as well, so I'd rather keep it. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1413#issuecomment-2671853104 From rrich at openjdk.org Thu Feb 20 15:47:56 2025 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 20 Feb 2025 15:47:56 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v2] In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 08:59:41 GMT, Goetz Lindenmaier wrote: >> I backport this to match 17.0.13-oracle based on the commit to 21. >> >> I had to resolve several files, two of them considerably: >> >> src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java >> Resolved larger chunk. >> src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java >> Resolved some code. >> >> The new code in DHPublic/PrivateKey depends on the removal >> of IOExceptions in [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) "DerOutputStream operations should not throw IOExceptions". >> This change is in 21 but not in 17. Thus code backported from 21 calls functions of >> DerOutputStream that do not throw an exception in 21, but do so in 17. >> JDK-8297065 makes the point that these exceptions can never be thrown, which also >> holds for 17. So I just catch and ignore them. >> >> Also, I had to adapt code because an exception constructor with cause for >> InvalidObjectException is missing in 17. >> This was added by [JDK-8282696](https://bugs.openjdk.org/browse/JDK-8282696) "Add constructors taking a cause >> to InvalidObjectException and InvalidClassException" in 19. >> I added a call to initCause() to store the causing exception. >> >> I double-checked that [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) was not backported >> by Oracle. Backporting this change would simplify matters considerably. >> >> The remaining files only needed trivial resolves: >> >> src/java.base/share/classes/java/security/Permissions.java >> src/java.base/share/classes/java/security/SignedObject.java >> Only Copyright. >> src/java.base/share/classes/java/security/Timestamp.java >> Copyright and import. >> src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java >> src/java.base/share/classes/java/security/cert/CertificateRevokedException.java >> src/java.base/share/classes/sun/security/provider/DRBG.java >> src/java.base/share/classes/sun/security/util/ObjectIdentifier.java >> src/java.base/share/classes/sun/security/x509/AlgIdDSA.java >> Only Copyright. >> src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Context.java >> Resolved imports. >> src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecureRandom.java >> Only Copyright. >> >> I manually ran these tests on linux x86_64: >> >> test/jdk/com/sun/security >> test/jdk/java/awt/security >> test/jdk/java/net/httpclient/security >> test/jdk/java/net/httpclient/we... > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Remove mentioning of ProviderException src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java line 379: > 377: } catch (IOException e) { > 378: InvalidObjectException ioe = new InvalidObjectException("Invalid encoding"); > 379: if (ioe != null) { Isn't this condition always true? Note also that the throw below will throw a NPE if it `ioe` was null. I think you can actually remove the condition. src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java line 188: > 186: derKey = null; > 187: } > 188: return derKey.toByteArray(); This looks weired if someone has a quick look at these lines of code: if an IOE occurs and is caught here, then `derKey` will be assigned null and 2 lines below an NPE will thrown because of this. I'd suggest to wrap the whole method body in a try-catch. This would reduce the diff to jdk 21. In the IOE catch clause you shouldn't say that the IOE is ignored but you should state that it cannot even occur since `DerOutputStream` is a `ByteArrayOutputStream` which doesn't do any I/O. Then just return null or throw an `InternalError` are something else if more appropriate. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#discussion_r1963035399 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#discussion_r1963829813 From rrich at openjdk.org Thu Feb 20 16:03:05 2025 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 20 Feb 2025 16:03:05 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v2] In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 08:59:41 GMT, Goetz Lindenmaier wrote: >> I backport this to match 17.0.13-oracle based on the commit to 21. >> >> I had to resolve several files, two of them considerably: >> >> src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java >> Resolved larger chunk. >> src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java >> Resolved some code. >> >> The new code in DHPublic/PrivateKey depends on the removal >> of IOExceptions in [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) "DerOutputStream operations should not throw IOExceptions". >> This change is in 21 but not in 17. Thus code backported from 21 calls functions of >> DerOutputStream that do not throw an exception in 21, but do so in 17. >> JDK-8297065 makes the point that these exceptions can never be thrown, which also >> holds for 17. So I just catch and ignore them. >> >> Also, I had to adapt code because an exception constructor with cause for >> InvalidObjectException is missing in 17. >> This was added by [JDK-8282696](https://bugs.openjdk.org/browse/JDK-8282696) "Add constructors taking a cause >> to InvalidObjectException and InvalidClassException" in 19. >> I added a call to initCause() to store the causing exception. >> >> I double-checked that [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) was not backported >> by Oracle. Backporting this change would simplify matters considerably. >> >> The remaining files only needed trivial resolves: >> >> src/java.base/share/classes/java/security/Permissions.java >> src/java.base/share/classes/java/security/SignedObject.java >> Only Copyright. >> src/java.base/share/classes/java/security/Timestamp.java >> Copyright and import. >> src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java >> src/java.base/share/classes/java/security/cert/CertificateRevokedException.java >> src/java.base/share/classes/sun/security/provider/DRBG.java >> src/java.base/share/classes/sun/security/util/ObjectIdentifier.java >> src/java.base/share/classes/sun/security/x509/AlgIdDSA.java >> Only Copyright. >> src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Context.java >> Resolved imports. >> src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecureRandom.java >> Only Copyright. >> >> I manually ran these tests on linux x86_64: >> >> test/jdk/com/sun/security >> test/jdk/java/awt/security >> test/jdk/java/net/httpclient/security >> test/jdk/java/net/httpclient/we... > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Remove mentioning of ProviderException Changes requested by rrich (Reviewer). src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java line 229: > 227: } catch (IOException e) { > 228: throw new ProviderException("Cannot produce ASN.1 encoding", e); > 229: } You should remove the try-catch. `encode` doesn't throw IOE. This also removes the diff to jdk 21. src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java line 384: > 382: if (ioe != null) { > 383: ioe.initCause(e); > 384: } The null check is redundant. Suggestion: ioe.initCause(e); ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3278#pullrequestreview-2630339484 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#discussion_r1963842849 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#discussion_r1963850223 From goetz at openjdk.org Thu Feb 20 16:03:08 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 16:03:08 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v2] In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 08:03:22 GMT, Richard Reingruber wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove mentioning of ProviderException > > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java line 379: > >> 377: } catch (IOException e) { >> 378: InvalidObjectException ioe = new InvalidObjectException("Invalid encoding"); >> 379: if (ioe != null) { > > Isn't this condition always true? > Note also that the throw below will throw a NPE if it `ioe` was null. > I think you can actually remove the condition. My inital desing was throw new InvalidObjectException("Invalid encoding").initCause(e); But the compiler does not like this: error: unreported exception Throwable; must be caught or declared to be thrown So I decided to add the try/catch with the null check. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#discussion_r1963863612 From goetz at openjdk.org Thu Feb 20 16:22:14 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 16:22:14 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v3] In-Reply-To: References: Message-ID: > I backport this to match 17.0.13-oracle based on the commit to 21. > > I had to resolve several files, two of them considerably: > > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java > Resolved larger chunk. > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java > Resolved some code. > > The new code in DHPublic/PrivateKey depends on the removal > of IOExceptions in [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) "DerOutputStream operations should not throw IOExceptions". > This change is in 21 but not in 17. Thus code backported from 21 calls functions of > DerOutputStream that do not throw an exception in 21, but do so in 17. > JDK-8297065 makes the point that these exceptions can never be thrown, which also > holds for 17. So I just catch and ignore them. > > Also, I had to adapt code because an exception constructor with cause for > InvalidObjectException is missing in 17. > This was added by [JDK-8282696](https://bugs.openjdk.org/browse/JDK-8282696) "Add constructors taking a cause > to InvalidObjectException and InvalidClassException" in 19. > I added a call to initCause() to store the causing exception. > > I double-checked that [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) was not backported > by Oracle. Backporting this change would simplify matters considerably. > > The remaining files only needed trivial resolves: > > src/java.base/share/classes/java/security/Permissions.java > src/java.base/share/classes/java/security/SignedObject.java > Only Copyright. > src/java.base/share/classes/java/security/Timestamp.java > Copyright and import. > src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java > src/java.base/share/classes/java/security/cert/CertificateRevokedException.java > src/java.base/share/classes/sun/security/provider/DRBG.java > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > src/java.base/share/classes/sun/security/x509/AlgIdDSA.java > Only Copyright. > src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Context.java > Resolved imports. > src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecureRandom.java > Only Copyright. > > I manually ran these tests on linux x86_64: > > test/jdk/com/sun/security > test/jdk/java/awt/security > test/jdk/java/net/httpclient/security > test/jdk/java/net/httpclient/websocket/security > test/jdk/java/security > test/jdk/javax/management/security > test/jdk/javax/security > t... Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Catch exception as proposed in review ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3278/files - new: https://git.openjdk.org/jdk17u-dev/pull/3278/files/55b241ec..705540fd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3278&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3278&range=01-02 Stats: 16 lines in 2 files changed: 7 ins; 4 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3278.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3278/head:pull/3278 PR: https://git.openjdk.org/jdk17u-dev/pull/3278 From rrich at openjdk.org Thu Feb 20 16:22:14 2025 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 20 Feb 2025 16:22:14 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v3] In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 16:00:09 GMT, Goetz Lindenmaier wrote: >> src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java line 379: >> >>> 377: } catch (IOException e) { >>> 378: InvalidObjectException ioe = new InvalidObjectException("Invalid encoding"); >>> 379: if (ioe != null) { >> >> Isn't this condition always true? >> Note also that the throw below will throw a NPE if it `ioe` was null. >> I think you can actually remove the condition. > > My inital desing was > throw new InvalidObjectException("Invalid encoding").initCause(e); > But the compiler does not like this: > error: unreported exception Throwable; must be caught or declared to be thrown > So I decided to add the try/catch with the null check. I see... strange. But it does compile without the null check. I think it should be removed. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#discussion_r1963898802 From goetz at openjdk.org Thu Feb 20 16:22:15 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 20 Feb 2025 16:22:15 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v3] In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 15:44:50 GMT, Richard Reingruber wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Catch exception as proposed in review > > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java line 188: > >> 186: derKey = null; >> 187: } >> 188: return derKey.toByteArray(); > > This looks weired if someone has a quick look at these lines of code: if an IOE occurs and is caught here, then `derKey` will be assigned null and 2 lines below an NPE will thrown because of this. > > I'd suggest to wrap the whole method body in a try-catch. This would reduce the diff to jdk 21. > In the IOE catch clause you shouldn't say that the IOE is ignored but you should state that it cannot even occur since `DerOutputStream` is a `ByteArrayOutputStream` which doesn't do any I/O. Then just return null or throw an `InternalError` are something else if more appropriate. ok, this makes sense. See extra commit. I did it for all three places where I catch the IO exception. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#discussion_r1963918296 From andrew at openjdk.org Thu Feb 20 16:28:24 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 20 Feb 2025 16:28:24 GMT Subject: [jdk21u-dev] RFR: 8331735: UpcallLinker::on_exit races with GC when copying frame anchor Message-ID: Clean backport of a fix for a race condition in code adapted from `JavaCallWrapper` for the FFM API. This is more visible in 22 and later, where FFM is fully supported and the [OpenType implementation using HarfBuzz](https://bugs.openjdk.org/browse/JDK-8318364) has been ported to use it. However, the copy in the native state seems to have been introduced as far back as [JDK-8269240](https://bugs.openjdk.org/browse/JDK-8269240) in 17 when the `JavaCallWrapper` code was ported to what was then `universalUpcallHandler.cpp`. ------------- Commit messages: - Backport 461ffafeba459c077f1c2d9c5037305b71a8bc2a Changes: https://git.openjdk.org/jdk21u-dev/pull/1424/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1424&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331735 Stats: 15 lines in 1 file changed: 5 ins; 9 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1424.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1424/head:pull/1424 PR: https://git.openjdk.org/jdk21u-dev/pull/1424 From phh at openjdk.org Thu Feb 20 16:35:57 2025 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 20 Feb 2025 16:35:57 GMT Subject: [jdk21u-dev] RFR: 8350412: [21u] AArch64: Ambiguous frame layout leads to incorrect traces in JFR In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 12:09:51 GMT, Dmitry Chuyko wrote: > This change fixes incorrect stack traces sometimes reported by JFR (non-deterministic stack walking). It is technically a clean backport of 'Make the anchor frame walkable' changes of aarch64_enc_java_to_runtime() from https://github.com/openjdk/jdk/pull/21565/files#diff-018aa61d1a7aafcf70a535fcd40a318a4bd6511fd40ac39ce4be90cc52216749 > > I propose to cherry pick those into older releases after JDK 24 is out, starting from 21u. > > Testing: tier1,2 on linux-aarch64. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1418#pullrequestreview-2630500097 From sgehwolf at openjdk.org Thu Feb 20 16:42:00 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 20 Feb 2025 16:42:00 GMT Subject: [jdk11u-dev] RFR: 8026976: ECParameters, Point does not match field size In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 07:15:55 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8026976: ECParameters, Point does not match field size > > Original patch apply cleanly to 11u. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. @martinuy @franferrax Could you please take a look at this backport and see if that makes sense to bring to 11u at this stage of where 11u is currently? Thanks! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2958#issuecomment-2672048914 From duke at openjdk.org Thu Feb 20 16:44:54 2025 From: duke at openjdk.org (duke) Date: Thu, 20 Feb 2025 16:44:54 GMT Subject: [jdk11u-dev] RFR: 8341424: GHA: Collect hs_errs from build time failures In-Reply-To: References: Message-ID: On Thu, 2 Jan 2025 09:40:10 GMT, Antonio Vieiro wrote: > Backport of [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424) and companion [JDK-8342704](https://bugs.openjdk.org/browse/JDK-8342704) > > This collects hs_errs when they happen with GitHub Actions, which may be useful during reviews. > > Low risk, as this affects GHA actions only. GHA builds and tests run correctly. @vieiro Your change (at version bb053f435ecb13c125dea5d330c2c68d46564842) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2982#issuecomment-2672055437 From sroy at openjdk.org Thu Feb 20 16:48:06 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Thu, 20 Feb 2025 16:48:06 GMT Subject: [jdk21u] Withdrawn: 8349729 : [AIX] jtreg tests fail to compile with qvisibility=hidden In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 08:56:21 GMT, Suchismith Roy wrote: > JBS ISSUE : [JDK-8349729](https://bugs.openjdk.org/browse/JDK-8349729) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u/pull/459 From sroy at openjdk.org Thu Feb 20 16:52:11 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Thu, 20 Feb 2025 16:52:11 GMT Subject: [jdk21u-dev] RFR: 8349729 : [21u] AIX jtreg tests fail to compile with qvisibility=hidden Message-ID: <-eorSrfLcZAAlwV-oN9XLLVi_D_4cTp9EPYGlt51HYU=.bd836d4e-69d3-4cfd-ae49-597eb2ac0628@github.com> JBS ISSUE : [JDK-8349729](https://bugs.openjdk.org/browse/JDK-8349729) ------------- Commit messages: - remove qvisibility for xlc16 Changes: https://git.openjdk.org/jdk21u-dev/pull/1425/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1425&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349729 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1425.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1425/head:pull/1425 PR: https://git.openjdk.org/jdk21u-dev/pull/1425 From sroy at openjdk.org Thu Feb 20 17:05:52 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Thu, 20 Feb 2025 17:05:52 GMT Subject: [jdk21u-dev] RFR: 8349729 : [21u] AIX jtreg tests fail to compile with qvisibility=hidden In-Reply-To: <-eorSrfLcZAAlwV-oN9XLLVi_D_4cTp9EPYGlt51HYU=.bd836d4e-69d3-4cfd-ae49-597eb2ac0628@github.com> References: <-eorSrfLcZAAlwV-oN9XLLVi_D_4cTp9EPYGlt51HYU=.bd836d4e-69d3-4cfd-ae49-597eb2ac0628@github.com> Message-ID: On Thu, 20 Feb 2025 16:44:30 GMT, Suchismith Roy wrote: > JBS ISSUE : [JDK-8349729](https://bugs.openjdk.org/browse/JDK-8349729) @GoeLin I am not able to find the Actions tab under jdk21u-dev to activate the tests. I was added as contributor to the repository before as I have done back ports. Not sure what is the issue . ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1425#issuecomment-2672117172 From duke at openjdk.org Thu Feb 20 17:10:02 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 20 Feb 2025 17:10:02 GMT Subject: [jdk11u-dev] Integrated: 8341424: GHA: Collect hs_errs from build time failures In-Reply-To: References: Message-ID: On Thu, 2 Jan 2025 09:40:10 GMT, Antonio Vieiro wrote: > Backport of [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424) and companion [JDK-8342704](https://bugs.openjdk.org/browse/JDK-8342704) > > This collects hs_errs when they happen with GitHub Actions, which may be useful during reviews. > > Low risk, as this affects GHA actions only. GHA builds and tests run correctly. This pull request has now been integrated. Changeset: dba357f0 Author: Antonio Vieiro Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/dba357f027f6b6ab361f15f0c50b4e9bdeb5ea66 Stats: 81 lines in 3 files changed: 67 ins; 14 del; 0 mod 8341424: GHA: Collect hs_errs from build time failures 8342704: GHA: Report truncation is broken after JDK-8341424 Backport-of: 3bc06ab80f09b57dc10b182d9bc1ab1584cf6706 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2982 From duke at openjdk.org Thu Feb 20 17:26:01 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 20 Feb 2025 17:26:01 GMT Subject: [jdk11u-dev] RFR: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1 In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 09:26:54 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8331959](https://bugs.openjdk.org/browse/JDK-8331959) for parity with Oracle's 11.0.27. > This adds some new constants and typedefs, and minor formatting of the license file. > Passes tier1 tests on Linux. Let's keep open until 11.0.28. Meanwhile I may want to rebase on master and run some tests. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2979#issuecomment-2672174390 From duke at openjdk.org Thu Feb 20 17:31:02 2025 From: duke at openjdk.org (duke) Date: Thu, 20 Feb 2025 17:31:02 GMT Subject: [jdk11u-dev] RFR: 8312049: runtime/logging/ClassLoadUnloadTest can be improved In-Reply-To: References: Message-ID: On Fri, 23 Aug 2024 19:29:43 GMT, Daniel Hu wrote: > Backport that improves ClassLoadUnloadTest; already backported to [JDK21](https://github.com/openjdk/jdk21u-dev/pull/909) and [JDK17](https://github.com/openjdk/jdk17u-dev/pull/2806). Original commit does not apply cleanly due to the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later [version](https://bugs.openjdk.org/browse/JDK-8193513), thus these cases are excluded. Some args in exec() also were not added until a [later version](https://bugs.openjdk.org/browse/JDK-8289184), thus they are excluded. Additionally, [these flags](https://bugs.openjdk.org/browse/JDK-8256718) were deprecated in a later version and thus removed from this test; simple modifications are added so that these later removed cases follow the backport logic. Affected test passes. > > MacOS GHA not passing due to unrelated deprecated sprintf @cost0much Your change (at version 7e9fb1f48355cc5203ca832ab569906c3de5cae8) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2920#issuecomment-2672188150 From duke at openjdk.org Thu Feb 20 17:36:04 2025 From: duke at openjdk.org (Daniel Hu) Date: Thu, 20 Feb 2025 17:36:04 GMT Subject: [jdk11u-dev] Integrated: 8312049: runtime/logging/ClassLoadUnloadTest can be improved In-Reply-To: References: Message-ID: On Fri, 23 Aug 2024 19:29:43 GMT, Daniel Hu wrote: > Backport that improves ClassLoadUnloadTest; already backported to [JDK21](https://github.com/openjdk/jdk21u-dev/pull/909) and [JDK17](https://github.com/openjdk/jdk17u-dev/pull/2806). Original commit does not apply cleanly due to the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later [version](https://bugs.openjdk.org/browse/JDK-8193513), thus these cases are excluded. Some args in exec() also were not added until a [later version](https://bugs.openjdk.org/browse/JDK-8289184), thus they are excluded. Additionally, [these flags](https://bugs.openjdk.org/browse/JDK-8256718) were deprecated in a later version and thus removed from this test; simple modifications are added so that these later removed cases follow the backport logic. Affected test passes. > > MacOS GHA not passing due to unrelated deprecated sprintf This pull request has now been integrated. Changeset: d158b8ba Author: Daniel Hu Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/d158b8baefb0f47991c202fa5eae877a09d37956 Stats: 42 lines in 1 file changed: 3 ins; 6 del; 33 mod 8312049: runtime/logging/ClassLoadUnloadTest can be improved Reviewed-by: phh Backport-of: 4676b40f17dd18941f5883cb9b989ad639992a50 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2920 From abakhtin at openjdk.org Thu Feb 20 23:46:34 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Thu, 20 Feb 2025 23:46:34 GMT Subject: [jdk21u-dev] RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v2] In-Reply-To: References: Message-ID: > Please review the backport of JDK-8335181 > > src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java > - manual merge for MultiExchange::getExceptionalCF > because of the difference in the logging caused by 8310330 > > src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java > - added import for the AtomicLong class manually because of the difference in the import section > > src/java.net.http/share/classes/jdk/internal/net/http/ExchangeImpl.java > - copyright year updated manually > > test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java > - import section is updated manually > > test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java > - getConnectionKey() declaration is added manually in the HttpServerAdapters::HttpTestExchange class > > All jtreg tests for java.net.httpclient are passed Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: Remove extra import ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1417/files - new: https://git.openjdk.org/jdk21u-dev/pull/1417/files/e90978f6..0ec8ff7f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1417&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1417&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1417.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1417/head:pull/1417 PR: https://git.openjdk.org/jdk21u-dev/pull/1417 From duke at openjdk.org Thu Feb 20 23:58:12 2025 From: duke at openjdk.org (duke) Date: Thu, 20 Feb 2025 23:58:12 GMT Subject: [jdk11u-dev] RFR: 8328242: Add a log area to the PassFailJFrame In-Reply-To: References: Message-ID: <3gUW8brC0zmGUo0oYUsy6bX-LkvSYtK4nG1NYQpCBVo=.734ab9d9-3c60-4ce9-9e5e-48f8e6a4d800@github.com> On Tue, 22 Oct 2024 07:41:09 GMT, toshiogata wrote: > Hi all, > > I would like to backport this patch to improve test maintainability for manual tests. The patch is clean. > Testing: manually checked some tests using PassFailJFrame, and confirmed that they work in the same way. > > Thank you. @toshiogata Your change (at version d294b2fb508987ba739849f6125e0da6e816bea9) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2959#issuecomment-2672975767 From abakhtin at openjdk.org Fri Feb 21 00:49:21 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 21 Feb 2025 00:49:21 GMT Subject: [jdk21u-dev] RFR: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered Message-ID: Clean backport of JDK-8317808 All jtreg tests for java.net.httpclient are passed ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/1417 Commit messages: - Backport 6273ab97dc1a0d3c1f51ba94694d9594dd7593d4 Changes: https://git.openjdk.org/jdk21u-dev/pull/1426/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1426&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317808 Stats: 29 lines in 4 files changed: 22 ins; 4 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1426.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1426/head:pull/1426 PR: https://git.openjdk.org/jdk21u-dev/pull/1426 From syan at openjdk.org Fri Feb 21 01:51:01 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 01:51:01 GMT Subject: [jdk11u-dev] RFR: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out In-Reply-To: References: Message-ID: On Tue, 24 Dec 2024 06:32:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [7acfba28](https://github.com/openjdk/jdk/commit/7acfba288ff4d1f43cc36506b2bd2d32107b00c2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This PR fix the test bug which cause test intermittent fails. The change has been verified locally, test-fix only, no risk. > > The commit being backported was authored by Mark Sheppard on 5 Jun 2024 and was reviewed by Brian Burkhalter. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2980#issuecomment-2673152226 From syan at openjdk.org Fri Feb 21 01:51:01 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 01:51:01 GMT Subject: [jdk11u-dev] Integrated: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out In-Reply-To: References: Message-ID: On Tue, 24 Dec 2024 06:32:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [7acfba28](https://github.com/openjdk/jdk/commit/7acfba288ff4d1f43cc36506b2bd2d32107b00c2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This PR fix the test bug which cause test intermittent fails. The change has been verified locally, test-fix only, no risk. > > The commit being backported was authored by Mark Sheppard on 5 Jun 2024 and was reviewed by Brian Burkhalter. > > Thanks! This pull request has now been integrated. Changeset: 9ee1571d Author: SendaoYan URL: https://git.openjdk.org/jdk11u-dev/commit/9ee1571d0485d3c57649c9cb143779ce27abee9f Stats: 110 lines in 1 file changed: 74 ins; 10 del; 26 mod 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out Backport-of: 7acfba288ff4d1f43cc36506b2bd2d32107b00c2 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2980 From syan at openjdk.org Fri Feb 21 01:52:06 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 01:52:06 GMT Subject: [jdk11u-dev] RFR: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 03:11:41 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [69384745](https://github.com/openjdk/jdk/commit/693847452f208446a34186f142fe2c56a49ceceb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Albert Mingkun Yang on 30 Nov 2023 and was reviewed by Stefan Johansson and Thomas Schatzl. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2976#issuecomment-2673153477 From syan at openjdk.org Fri Feb 21 01:52:04 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 01:52:04 GMT Subject: [jdk11u-dev] RFR: 8216539: tools/jar/modularJar/Basic.java timed out In-Reply-To: References: Message-ID: On Tue, 24 Dec 2024 06:42:49 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [518e3a87](https://github.com/openjdk/jdk/commit/518e3a878862fd7be2d9eea42f122fdaa01c7dd8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This PR fix the test bug which cause test intermittent fails. The change has been verified locally, test-fix only, no risk. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2981#issuecomment-2673151523 From syan at openjdk.org Fri Feb 21 01:52:05 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 01:52:05 GMT Subject: [jdk11u-dev] Integrated: 8216539: tools/jar/modularJar/Basic.java timed out In-Reply-To: References: Message-ID: On Tue, 24 Dec 2024 06:42:49 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [518e3a87](https://github.com/openjdk/jdk/commit/518e3a878862fd7be2d9eea42f122fdaa01c7dd8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This PR fix the test bug which cause test intermittent fails. The change has been verified locally, test-fix only, no risk. > > Thanks! This pull request has now been integrated. Changeset: 1fafc5d2 Author: SendaoYan URL: https://git.openjdk.org/jdk11u-dev/commit/1fafc5d236b99aa623c83abee0365e493bb9a814 Stats: 34 lines in 1 file changed: 24 ins; 2 del; 8 mod 8216539: tools/jar/modularJar/Basic.java timed out Backport-of: 518e3a878862fd7be2d9eea42f122fdaa01c7dd8 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2981 From syan at openjdk.org Fri Feb 21 01:52:06 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 01:52:06 GMT Subject: [jdk11u-dev] Integrated: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 03:11:41 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [69384745](https://github.com/openjdk/jdk/commit/693847452f208446a34186f142fe2c56a49ceceb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Albert Mingkun Yang on 30 Nov 2023 and was reviewed by Stefan Johansson and Thomas Schatzl. > > Thanks! This pull request has now been integrated. Changeset: aad0315a Author: SendaoYan URL: https://git.openjdk.org/jdk11u-dev/commit/aad0315a008aef50259c04ee9c48cbd7f922abb6 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" Backport-of: 693847452f208446a34186f142fe2c56a49ceceb ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2976 From abakhtin at openjdk.org Fri Feb 21 01:52:43 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 21 Feb 2025 01:52:43 GMT Subject: [jdk21u-dev] RFR: 8342075: HttpClient: improve HTTP/2 flow control checks Message-ID: Please review the backport of JDK-8342075 Almost clean backport except for the import section of src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java All jtreg tests for java.net.httpclient are passed ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/1426 Commit messages: - Backport b0ac633b2d0076d64b463b2a6ce19abf6b12c50f Changes: https://git.openjdk.org/jdk21u-dev/pull/1427/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1427&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342075 Stats: 1024 lines in 13 files changed: 987 ins; 2 del; 35 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1427.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1427/head:pull/1427 PR: https://git.openjdk.org/jdk21u-dev/pull/1427 From syan at openjdk.org Fri Feb 21 02:04:56 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 02:04:56 GMT Subject: [jdk21u-dev] RFR: 8342958: Use jvmArgs consistently in microbenchmarks [v2] In-Reply-To: References: <-MC1d5SLZGMy_ArJcNwQpTvunmLBScwQ_PJ-YCPYayA=.16d1ef9e-090c-4c28-a8d5-e162c123f72c@github.com> Message-ID: <9myRWzEZq0mtD5fLqKCb3mKIXXUqQdQIWdowmoZzI-E=.22030d9f-4916-43e6-b2ef-0f1b1ce07e3c@github.com> On Thu, 13 Feb 2025 12:38:36 GMT, SendaoYan wrote: >> Hi all, >> >> - This is PR contains two backport to jdk21u-dev >> >> 1. Uncleanly backport of [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958). >> 2. Cleanly backport of [JDK-8343345](https://bugs.openjdk.org/browse/JDK-8343345). >> >> - Why do we need these two backport? >> >> 1. [Suggests using jvmArgs consistently](https://github.com/openjdk/jdk/pull/21683#issue-2611685724). >> 2. This backport will make several JMH tests run normally after this backport. Before this backport, 'org.openjdk.bench.java.net.NetworkInterfaceLookup.bound' report fails "java.lang.IllegalAccessException: class org.openjdk.bench.java.net.NetworkInterfaceLookup cannot access a member of class java.net.NetworkInterface (in module java.base) with package access", after this backport this JMH test will run passes. >> >> Why this backport can not backport cleanly? >> >> 1. Some JMH tests added after jdk21u, such as test/micro/org/openjdk/bench/java/lang/CallerClassBench.java was added by jdk22. >> 2. Some JMH tests removed after jdk21u, such as test/micro/org/openjdk/bench/java/lang/StringTemplateFMT.java wad removed by JDK-8329948 >> 3. Some JMH tests has diffrent file name ater jdk21u, such as rename from test/micro/org/openjdk/bench/jdk/classfile/GenerateStackMaps.java to test/micro/org/openjdk/bench/jdk/classfile/CodeAttributeTools.java by JDK-8323183 >> >> >> Testing: >> >> - [x] Run all the touch JMH tests locally. >> >> Test commands: >> >> wget https://patch-diff.githubusercontent.com/raw/openjdk/jdk21u-dev/pull/1403.diff -O JDK-8342958-21u.patch >> grep "diff --git" JDK-8342958-21u.patch | awk '{print $3}' | grep "^a/test" | sed "s|^a/test/micro/||" | sed "s|/|.|g" | sed "s|.java$||" > list.txt >> rm -rf build/jmh-result/ ; mkdir -p build/jmh-result/ ; time for test in `cat list.txt` ; do time make test TEST="micro:$test" MICRO="FORK=1;WARMUP_ITER=2" CONF=release &> build/jmh-result/$test.log ; done >> >> >> Test result: >> 5 tests fails, the fails unrelated to this PR, I have create a new [issue](https://bugs.openjdk.org/browse/JDK-8350051) to record this failure. All other tests passes. >> >> [jmh-result.zip](https://github.com/user-attachments/files/18792902/jmh-result.zip) > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > Replace jvmArgsAppend as jvmArgs Backport to fix several JMH test bugs and make using jvmArgs consistently. Change has been verified locally, test-fix only, no risk. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1403#issuecomment-2673168102 From syan at openjdk.org Fri Feb 21 02:56:26 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 02:56:26 GMT Subject: [jdk11u-dev] RFR: 8350469: [11u] Backport JDK-8239429 to jdk11u-dev Message-ID: Hi all, We observed test build/AbsPathsInImage.java fails which has been recorded by https://github.com/dragonwell-project/dragonwell11/issues/934, and this backport can fix the test bug which cause the test failure. The test bug which cause this test failure has been fixed by JDK-8239429. But JDK-8239429 is invisible cause JDK-8239429 can not backported directly. So I create a new issue to fix the test bug in jdk11u-dev. Clean backport to fix the test bug, change has been verified locally, test-fix only, no risk. ------------- Commit messages: - 8239429: AbsPathsInImage.java fails in JDK 11u and 14u on Windows Changes: https://git.openjdk.org/jdk11u-dev/pull/2997/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2997&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350469 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2997.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2997/head:pull/2997 PR: https://git.openjdk.org/jdk11u-dev/pull/2997 From syan at openjdk.org Fri Feb 21 02:59:56 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 02:59:56 GMT Subject: [jdk11u-dev] RFR: 8350469: [11u] Backport JDK-8239429 to jdk11u-dev In-Reply-To: References: Message-ID: On Mon, 17 Feb 2025 08:14:35 GMT, SendaoYan wrote: > Hi all, > > We observed test build/AbsPathsInImage.java fails which has been recorded by https://github.com/dragonwell-project/dragonwell11/issues/934, and this backport can fix the test bug which cause the test failure. > > The test bug which cause this test failure has been fixed by JDK-8239429. But JDK-8239429 is invisible cause JDK-8239429 can not backported directly. So I create a new issue to fix the test bug in jdk11u-dev. > > Clean backport to fix the test bug, change has been verified locally, test-fix only, no risk. GHA report 1 test failure: 1. Test "serviceability/sa/ClhsdbFindPC.java#id1" report "java.io.IOException: App waiting timeout", which has been recorded and fixed by [JDK-8249150](https://bugs.openjdk.org/browse/JDK-8249150), it's unralated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2997#issuecomment-2673241364 From duke at openjdk.org Fri Feb 21 03:09:58 2025 From: duke at openjdk.org (toshiogata) Date: Fri, 21 Feb 2025 03:09:58 GMT Subject: [jdk11u-dev] Integrated: 8328242: Add a log area to the PassFailJFrame In-Reply-To: References: Message-ID: On Tue, 22 Oct 2024 07:41:09 GMT, toshiogata wrote: > Hi all, > > I would like to backport this patch to improve test maintainability for manual tests. The patch is clean. > Testing: manually checked some tests using PassFailJFrame, and confirmed that they work in the same way. > > Thank you. This pull request has now been integrated. Changeset: 6d12f926 Author: t.ogata Committer: SendaoYan URL: https://git.openjdk.org/jdk11u-dev/commit/6d12f92616aed239cd315e8846d09faf8195770e Stats: 103 lines in 1 file changed: 98 ins; 0 del; 5 mod 8328242: Add a log area to the PassFailJFrame Backport-of: 9bc1b065db238b7c9d0562f9bd55d2f338c6ff3d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2959 From abhiscxk at openjdk.org Fri Feb 21 05:12:11 2025 From: abhiscxk at openjdk.org (Abhishek Kumar) Date: Fri, 21 Feb 2025 05:12:11 GMT Subject: [jdk24u] RFR: 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS Message-ID: Hi all, This pull request contains a backport of commit [1e87ff01](https://github.com/openjdk/jdk/commit/1e87ff01994df16df7de331040fc5d7a4a85f630) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Abhishek Kumar on 20 Feb 2025 and was reviewed by Alexey Ivanov, Alexander Zuev, Damon Nguyen and Artem Semenov. Thanks! ------------- Commit messages: - Backport 1e87ff01994df16df7de331040fc5d7a4a85f630 Changes: https://git.openjdk.org/jdk24u/pull/85/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=85&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348936 Stats: 133 lines in 2 files changed: 130 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk24u/pull/85.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/85/head:pull/85 PR: https://git.openjdk.org/jdk24u/pull/85 From clanger at openjdk.org Fri Feb 21 06:19:01 2025 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 21 Feb 2025 06:19:01 GMT Subject: [jdk11u-dev] Integrated: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates In-Reply-To: References: Message-ID: On Thu, 13 Feb 2025 13:14:33 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8349603](https://bugs.openjdk.org/browse/JDK-8349603). > > The JDK versions in use are different in jdk11u than in the upstream change, obviously. > > Thanks! This pull request has now been integrated. Changeset: 61393320 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/6139332080e106a31bf4281ee4a6edc9918d83d0 Stats: 12 lines in 1 file changed: 4 ins; 4 del; 4 mod 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates Reviewed-by: sgehwolf Backport-of: 6ccdc3f8e03d5780da0914c1155b38d33ab76e42 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2991 From stuefe at openjdk.org Fri Feb 21 06:21:56 2025 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 21 Feb 2025 06:21:56 GMT Subject: [jdk21u-dev] RFR: 8318636: Add jcmd to print annotated process memory map In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 13:25:34 GMT, Andreas Steiner wrote: > Hi all, > > This pull request contains a backport of commit [6f863b2a](https://github.com/openjdk/jdk/commit/6f863b2a1baa67deb2a7b33fcd93d272aea01812) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Thomas Stuefe on 13 Nov 2023 and was reviewed by Johan Sj?len and Gerard Ziemski. > > Thanks! Looks good. Where there any changes needed apart from the fact that the NMT sources moved to share/nmt ? ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1415#pullrequestreview-2632097311 From goetz at openjdk.org Fri Feb 21 06:23:59 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 06:23:59 GMT Subject: [jdk17u-dev] RFR: 8301989: new javax.swing.text.DefaultCaret().setBlinkRate(N) results in NPE In-Reply-To: References: Message-ID: <45n5_ATzDZRkRYZqEcKFsgrHgLROh_uIxv6lGxe_BhI=.9675ca9f-0160-4edf-9287-bdc8cdec7e5f@github.com> On Thu, 20 Feb 2025 13:23:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3284#issuecomment-2673577556 From goetz at openjdk.org Fri Feb 21 06:27:59 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 06:27:59 GMT Subject: [jdk17u-dev] RFR: 8337222: gc/TestDisableExplicitGC.java fails due to unexpected CodeCache GC In-Reply-To: <-o2IHfc9vqG_Z6slE5AMnezmHhKl9U4yCbpo8AIXJNw=.f634427b-dc27-403d-9f87-0f94b7751e25@github.com> References: <-o2IHfc9vqG_Z6slE5AMnezmHhKl9U4yCbpo8AIXJNw=.f634427b-dc27-403d-9f87-0f94b7751e25@github.com> Message-ID: On Thu, 20 Feb 2025 13:32:58 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle GHA failure: The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings. Unrelated ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3285#issuecomment-2673582698 From goetz at openjdk.org Fri Feb 21 06:29:56 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 06:29:56 GMT Subject: [jdk17u-dev] RFR: 8338595: Add more linesize for MIME decoder in macro bench test Base64Decode In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 13:54:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. GHA failure: The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settin Unrelated ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3286#issuecomment-2673585174 From goetz at openjdk.org Fri Feb 21 06:31:01 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 06:31:01 GMT Subject: [jdk17u-dev] RFR: 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 14:04:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. GHA failure The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3287#issuecomment-2673587154 From goetz at openjdk.org Fri Feb 21 06:33:56 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 06:33:56 GMT Subject: [jdk17u-dev] RFR: 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 14:51:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. GHA failures: The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3289#issuecomment-2673592580 From goetz at openjdk.org Fri Feb 21 06:33:56 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 06:33:56 GMT Subject: [jdk21u-dev] RFR: 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 14:24:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle GHA failures: The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1423#issuecomment-2673591962 From goetz at openjdk.org Fri Feb 21 06:36:57 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 06:36:57 GMT Subject: [jdk21u-dev] RFR: 8349729 : [21u] AIX jtreg tests fail to compile with qvisibility=hidden In-Reply-To: <-eorSrfLcZAAlwV-oN9XLLVi_D_4cTp9EPYGlt51HYU=.bd836d4e-69d3-4cfd-ae49-597eb2ac0628@github.com> References: <-eorSrfLcZAAlwV-oN9XLLVi_D_4cTp9EPYGlt51HYU=.bd836d4e-69d3-4cfd-ae49-597eb2ac0628@github.com> Message-ID: On Thu, 20 Feb 2025 16:44:30 GMT, Suchismith Roy wrote: > JBS ISSUE : [JDK-8349729](https://bugs.openjdk.org/browse/JDK-8349729) LGTM ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1425#pullrequestreview-2632118259 From goetz at openjdk.org Fri Feb 21 06:47:52 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 06:47:52 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v3] In-Reply-To: References: Message-ID: <4yTRr10IcvmD4xuKFwDKGNWrxMS6G28wzCr2KJ8g76A=.10a8f77f-4db5-4ba4-a6d7-2b9c3d52c0fe@github.com> On Thu, 20 Feb 2025 16:16:04 GMT, Richard Reingruber wrote: >> My inital desing was >> throw new InvalidObjectException("Invalid encoding").initCause(e); >> But the compiler does not like this: >> error: unreported exception Throwable; must be caught or declared to be thrown >> So I decided to add the try/catch with the null check. > > I see... strange. But it does compile without the null check. I think it should be removed. I'll remove the null check in both places where I added initCause(). ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#discussion_r1964937495 From goetz at openjdk.org Fri Feb 21 06:56:29 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 06:56:29 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v4] In-Reply-To: References: Message-ID: > I backport this to match 17.0.13-oracle based on the commit to 21. > > I had to resolve several files, two of them considerably: > > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java > Resolved larger chunk. > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java > Resolved some code. > > The new code in DHPublic/PrivateKey depends on the removal > of IOExceptions in [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) "DerOutputStream operations should not throw IOExceptions". > This change is in 21 but not in 17. Thus code backported from 21 calls functions of > DerOutputStream that do not throw an exception in 21, but do so in 17. > JDK-8297065 makes the point that these exceptions can never be thrown, which also > holds for 17. So I just catch and ignore them. > > Also, I had to adapt code because an exception constructor with cause for > InvalidObjectException is missing in 17. > This was added by [JDK-8282696](https://bugs.openjdk.org/browse/JDK-8282696) "Add constructors taking a cause > to InvalidObjectException and InvalidClassException" in 19. > I added a call to initCause() to store the causing exception. > > I double-checked that [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) was not backported > by Oracle. Backporting this change would simplify matters considerably. > > The remaining files only needed trivial resolves: > > src/java.base/share/classes/java/security/Permissions.java > src/java.base/share/classes/java/security/SignedObject.java > Only Copyright. > src/java.base/share/classes/java/security/Timestamp.java > Copyright and import. > src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java > src/java.base/share/classes/java/security/cert/CertificateRevokedException.java > src/java.base/share/classes/sun/security/provider/DRBG.java > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > src/java.base/share/classes/sun/security/x509/AlgIdDSA.java > Only Copyright. > src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Context.java > Resolved imports. > src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecureRandom.java > Only Copyright. > > I manually ran these tests on linux x86_64: > > test/jdk/com/sun/security > test/jdk/java/awt/security > test/jdk/java/net/httpclient/security > test/jdk/java/net/httpclient/websocket/security > test/jdk/java/security > test/jdk/javax/management/security > test/jdk/javax/security > t... Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Remove null check before calling initCause ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3278/files - new: https://git.openjdk.org/jdk17u-dev/pull/3278/files/705540fd..a335e4f7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3278&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3278&range=02-03 Stats: 6 lines in 2 files changed: 0 ins; 4 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3278.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3278/head:pull/3278 PR: https://git.openjdk.org/jdk17u-dev/pull/3278 From goetz at openjdk.org Fri Feb 21 06:56:29 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 06:56:29 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v2] In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 15:52:14 GMT, Richard Reingruber wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove mentioning of ProviderException > > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java line 229: > >> 227: } catch (IOException e) { >> 228: throw new ProviderException("Cannot produce ASN.1 encoding", e); >> 229: } > > You should remove the try-catch. `encode` doesn't throw IOE. This also removes the diff to jdk 21. It is toByteArray that trows the IOException. I can add the InternalError here as in the other places? But here I thought it's obvious to have the old behaviour. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#discussion_r1964952623 From syan at openjdk.org Fri Feb 21 06:56:35 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 06:56:35 GMT Subject: [jdk17u-dev] RFR: 8287801: Fix test-bugs related to stress flags Message-ID: Hi all, This pull request contains a backport of commit [302a6c06](https://github.com/openjdk/jdk/commit/302a6c068dcbb176381b1535baf25547079c9b06) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Below files not exists in jdk17u-dev cause [JDK-8287801](https://bugs.openjdk.org/browse/JDK-8287801) can not backported cleanly. test/hotspot/jtreg/compiler/uncommontrap/Decompile.java test/hotspot/jtreg/compiler/rangechecks/TestLongRangeCheck.java ------------- Commit messages: - Backport 302a6c068dcbb176381b1535baf25547079c9b06 Changes: https://git.openjdk.org/jdk17u-dev/pull/3290/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3290&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287801 Stats: 871 lines in 16 files changed: 866 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3290.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3290/head:pull/3290 PR: https://git.openjdk.org/jdk17u-dev/pull/3290 From syan at openjdk.org Fri Feb 21 07:00:32 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 07:00:32 GMT Subject: [jdk17u-dev] RFR: 8287801: Fix test-bugs related to stress flags [v2] In-Reply-To: References: Message-ID: <3FwSGutaiJgts_T5lzRh6VSAYyHaKx4gen6A0g4oUDs=.f1b31140-78ef-4d87-a074-1cdb3ff17753@github.com> > Hi all, > > This pull request contains a backport of commit [302a6c06](https://github.com/openjdk/jdk/commit/302a6c068dcbb176381b1535baf25547079c9b06) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Below files not exists in jdk17u-dev cause [JDK-8287801](https://bugs.openjdk.org/browse/JDK-8287801) can not backported cleanly. > > > test/hotspot/jtreg/compiler/uncommontrap/Decompile.java > test/hotspot/jtreg/compiler/rangechecks/TestLongRangeCheck.java SendaoYan has updated the pull request incrementally with one additional commit since the last revision: Backport JDK-8271707 after incorrect cherry-pick ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3290/files - new: https://git.openjdk.org/jdk17u-dev/pull/3290/files/c579e624..717e386b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3290&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3290&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3290.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3290/head:pull/3290 PR: https://git.openjdk.org/jdk17u-dev/pull/3290 From syan at openjdk.org Fri Feb 21 07:13:08 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 07:13:08 GMT Subject: [jdk17u-dev] RFR: 8287801: Fix test-bugs related to stress flags [v3] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [302a6c06](https://github.com/openjdk/jdk/commit/302a6c068dcbb176381b1535baf25547079c9b06) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > There are three files can not backport cleanly: > > 1. Backport JDK-8271707 touch the file test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckSmearing.java cause this file can not backport cleanly. > > 2. Below files not exists in jdk17u-dev cause [JDK-8287801](https://bugs.openjdk.org/browse/JDK-8287801) can not backported cleanly. > > > test/hotspot/jtreg/compiler/uncommontrap/Decompile.java > test/hotspot/jtreg/compiler/rangechecks/TestLongRangeCheck.java > > > Backport to fix test bugs which cause tests fails with stress flags, make test more robustness, change has been verified locally, test-fix only, no risk. > > Additional testing: > > - [ ] Run all the touch tests on linux-aarch64 > - [ ] Run all the touch tests on linux-x64 > > [list.txt](https://github.com/user-attachments/files/18902361/list.txt) SendaoYan has updated the pull request incrementally with one additional commit since the last revision: rm test/hotspot/jtreg/compiler/uncommontrap/Decompile.java test/hotspot/jtreg/compiler/rangechecks/TestLongRangeCheck.java ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3290/files - new: https://git.openjdk.org/jdk17u-dev/pull/3290/files/717e386b..4b9d7982 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3290&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3290&range=01-02 Stats: 844 lines in 2 files changed: 0 ins; 844 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3290.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3290/head:pull/3290 PR: https://git.openjdk.org/jdk17u-dev/pull/3290 From asteiner at openjdk.org Fri Feb 21 07:45:03 2025 From: asteiner at openjdk.org (Andreas Steiner) Date: Fri, 21 Feb 2025 07:45:03 GMT Subject: [jdk21u-dev] RFR: 8318636: Add jcmd to print annotated process memory map In-Reply-To: References: Message-ID: <7cCgI84ucCSiRf7Yhq-EwWjLHeJXVy0H1-oYmAgJnII=.38b10f56-7728-47be-91e3-a0837e338c3c@github.com> On Fri, 21 Feb 2025 06:19:15 GMT, Thomas Stuefe wrote: > Looks good. Where there any changes needed apart from the fact that the NMT sources moved to share/nmt ? Only in the tests, because the OutputAnalyzer in 21 is missing the convenience contains method. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1415#issuecomment-2673812808 From mbaesken at openjdk.org Fri Feb 21 08:29:06 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 21 Feb 2025 08:29:06 GMT Subject: [jdk24u] RFR: 8349039: Adjust exception No type named in database Message-ID: <1J_feEGBIFDjWxGmoEOS3ZQnbH_hGd-Gvcn1KmILEcA=.96fd8cb3-465a-4ec9-8409-ea6baad050b1@github.com> 8349039: Adjust exception No type named in database ------------- Commit messages: - Backport 669f8c0c07b57fa00ac84b8a90c4a1a1459443e3 Changes: https://git.openjdk.org/jdk24u/pull/86/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=86&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349039 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk24u/pull/86.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/86/head:pull/86 PR: https://git.openjdk.org/jdk24u/pull/86 From syan at openjdk.org Fri Feb 21 08:41:02 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 08:41:02 GMT Subject: [jdk24u] RFR: 8349787: java/lang/Thread/virtual/ThreadPollOnYield.java#default passes unexpectedly without libVThreadPinner.so In-Reply-To: References: Message-ID: On Fri, 14 Feb 2025 03:35:12 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [adc3f53d](https://github.com/openjdk/jdk/commit/adc3f53d2403cd414a91e71c079b4108b2346da0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Feb 2025 and was reviewed by Alan Bateman. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/77#issuecomment-2673912358 From syan at openjdk.org Fri Feb 21 08:41:03 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 08:41:03 GMT Subject: [jdk24u] Integrated: 8349787: java/lang/Thread/virtual/ThreadPollOnYield.java#default passes unexpectedly without libVThreadPinner.so In-Reply-To: References: Message-ID: On Fri, 14 Feb 2025 03:35:12 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [adc3f53d](https://github.com/openjdk/jdk/commit/adc3f53d2403cd414a91e71c079b4108b2346da0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Feb 2025 and was reviewed by Alan Bateman. > > Thanks! This pull request has now been integrated. Changeset: e06d01d6 Author: SendaoYan URL: https://git.openjdk.org/jdk24u/commit/e06d01d6460fc5c2bd600bc5712398479949e8e3 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8349787: java/lang/Thread/virtual/ThreadPollOnYield.java#default passes unexpectedly without libVThreadPinner.so Backport-of: adc3f53d2403cd414a91e71c079b4108b2346da0 ------------- PR: https://git.openjdk.org/jdk24u/pull/77 From mdoerr at openjdk.org Fri Feb 21 11:39:59 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 21 Feb 2025 11:39:59 GMT Subject: [jdk21u-dev] RFR: 8327476: Upgrade JLine to 3.26.1 In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 09:37:11 GMT, Goetz Lindenmaier wrote: > I backport this change for parity with 21.0.7-oracle. > > It brings updates of upstream library jline 3.26.1 to jdk21. > Jdk21 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). > The original sources of jline 3.26.1 can be found here: > https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz > > The backport of this change needed larger adaptions. > > The original jline library dynamically selects how to access > the operating system in two means: > * Which operating system? linux, windows, mac? > * JDK functionality to do native calls: JNI, jna, ffm? > > The implementation in OpenJDK does this selection at JDK build time. > The code is split into more subdirectories for the operating systems. > One of the methods to call native is picked, the code for the others > is removed. Unfortunately this differs for the JDK releases: > * jdk21 uses jna. > * jdk23 uses ffm. > The original patch of this change includes all the edits to > replace jna by ffm. > > Further changes that fell into the eye during the backport > * jline changed the format of its Copyright header > * jline changed sorting of imports > * jline changed a lot of formatting, especially how > arguments to methods are listed. > * jline removed the `Stream` enum from `TerminalProvider.java` and moved it > into a class of its own: `SystemStream.java`. This makes changes to > import statements and argument lists necessary. > * OpenJDK added a new parameter `inputStreamWrapper` to the > functions which are also affected by the `Stream` enum change. > This also made changes to import statements and argument lists > necessary. > > OpenJDK 23 added jline to the list of modules needed for a jre. > I don't think we should do that in 21, so I omitted that change. > > jline 3.26.1 and OpenJDK 23 added a new method `systemStreamWidth() `to `TerminalProvider`. > I don't think we should extend the functionlaity of jline in 21, > so I omitted this. Also, I would need additional parts of the > jline windows files that are not yet included in OpenJDK to > implement this. > > For the backport, I dropped the following files from the patch: > ``` > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/CLibrary.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmNativePty.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmTerminalProvider.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/termina... I've compared with https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz and your resolution looks good to me. Only one question: Why is `GetConsoleOutputCP` removed (src/jdk.internal.le/windows/native/lible/Kernel32.cpp)? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1413#issuecomment-2674321474 From goetz at openjdk.org Fri Feb 21 14:08:03 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 14:08:03 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v2] In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 15:56:12 GMT, Richard Reingruber wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove mentioning of ProviderException > > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java line 384: > >> 382: if (ioe != null) { >> 383: ioe.initCause(e); >> 384: } > > The null check is redundant. > Suggestion: > > ioe.initCause(e); Removed. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#discussion_r1965528465 From goetz at openjdk.org Fri Feb 21 14:43:14 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 14:43:14 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v5] In-Reply-To: References: Message-ID: <3OnhdEdth2V6akBT6KVqRjnn8lQHryZdBmY5ZuYKPiQ=.8e63f79b-cf55-4b29-9f13-ce4035be8c4b@github.com> > I backport this to match 17.0.13-oracle based on the commit to 21. > > I had to resolve several files, two of them considerably: > > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java > Resolved larger chunk. > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java > Resolved some code. > > The new code in DHPublic/PrivateKey depends on the removal > of IOExceptions in [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) "DerOutputStream operations should not throw IOExceptions". > This change is in 21 but not in 17. Thus code backported from 21 calls functions of > DerOutputStream that do not throw an exception in 21, but do so in 17. > JDK-8297065 makes the point that these exceptions can never be thrown, which also > holds for 17. So I just catch and ignore them. > > Also, I had to adapt code because an exception constructor with cause for > InvalidObjectException is missing in 17. > This was added by [JDK-8282696](https://bugs.openjdk.org/browse/JDK-8282696) "Add constructors taking a cause > to InvalidObjectException and InvalidClassException" in 19. > I added a call to initCause() to store the causing exception. > > I double-checked that [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) was not backported > by Oracle. Backporting this change would simplify matters considerably. > > The remaining files only needed trivial resolves: > > src/java.base/share/classes/java/security/Permissions.java > src/java.base/share/classes/java/security/SignedObject.java > Only Copyright. > src/java.base/share/classes/java/security/Timestamp.java > Copyright and import. > src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java > src/java.base/share/classes/java/security/cert/CertificateRevokedException.java > src/java.base/share/classes/sun/security/provider/DRBG.java > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > src/java.base/share/classes/sun/security/x509/AlgIdDSA.java > Only Copyright. > src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Context.java > Resolved imports. > src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecureRandom.java > Only Copyright. > > I manually ran these tests on linux x86_64: > > test/jdk/com/sun/security > test/jdk/java/awt/security > test/jdk/java/net/httpclient/security > test/jdk/java/net/httpclient/websocket/security > test/jdk/java/security > test/jdk/javax/management/security > test/jdk/javax/security > t... Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Bring exceptions closer to status before JDK-8297065 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3278/files - new: https://git.openjdk.org/jdk17u-dev/pull/3278/files/a335e4f7..8317f7c9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3278&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3278&range=03-04 Stats: 22 lines in 2 files changed: 6 ins; 10 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3278.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3278/head:pull/3278 PR: https://git.openjdk.org/jdk17u-dev/pull/3278 From goetz at openjdk.org Fri Feb 21 14:43:14 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 14:43:14 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v4] In-Reply-To: References: Message-ID: On Fri, 21 Feb 2025 06:56:29 GMT, Goetz Lindenmaier wrote: >> I backport this to match 17.0.13-oracle based on the commit to 21. >> >> I had to resolve several files, two of them considerably: >> >> src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java >> Resolved larger chunk. >> src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java >> Resolved some code. >> >> The new code in DHPublic/PrivateKey depends on the removal >> of IOExceptions in [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) "DerOutputStream operations should not throw IOExceptions". >> This change is in 21 but not in 17. Thus code backported from 21 calls functions of >> DerOutputStream that do not throw an exception in 21, but do so in 17. >> JDK-8297065 makes the point that these exceptions can never be thrown, which also >> holds for 17. So I just catch and ignore them. >> >> Also, I had to adapt code because an exception constructor with cause for >> InvalidObjectException is missing in 17. >> This was added by [JDK-8282696](https://bugs.openjdk.org/browse/JDK-8282696) "Add constructors taking a cause >> to InvalidObjectException and InvalidClassException" in 19. >> I added a call to initCause() to store the causing exception. >> >> I double-checked that [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) was not backported >> by Oracle. Backporting this change would simplify matters considerably. >> >> The remaining files only needed trivial resolves: >> >> src/java.base/share/classes/java/security/Permissions.java >> src/java.base/share/classes/java/security/SignedObject.java >> Only Copyright. >> src/java.base/share/classes/java/security/Timestamp.java >> Copyright and import. >> src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java >> src/java.base/share/classes/java/security/cert/CertificateRevokedException.java >> src/java.base/share/classes/sun/security/provider/DRBG.java >> src/java.base/share/classes/sun/security/util/ObjectIdentifier.java >> src/java.base/share/classes/sun/security/x509/AlgIdDSA.java >> Only Copyright. >> src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Context.java >> Resolved imports. >> src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecureRandom.java >> Only Copyright. >> >> I manually ran these tests on linux x86_64: >> >> test/jdk/com/sun/security >> test/jdk/java/awt/security >> test/jdk/java/net/httpclient/security >> test/jdk/java/net/httpclient/we... > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Remove null check before calling initCause Triggered by the discussion here and offline I had a second look at the exceptions I need to add because JDK-8297065 is not in 17. I committed some code that brings these closer to the origin. One I had added is not really needed as IOException is caught at the callsite anyways. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#issuecomment-2674729272 From goetz at openjdk.org Fri Feb 21 14:45:56 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 14:45:56 GMT Subject: [jdk21u-dev] RFR: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 11:34:47 GMT, Antonio Vieiro wrote: >> Hi @vieiro >> Thanks for adressing this! >> Did this really read out the menu items in your test? >> Did you double-check the test is failing without the fix? >> It did not work out in my setup on the first try, but I did not find time to look >> into this further. I assumed it is related to my local JAWS setup. > > @GoeLin D'oh. I hit the "Close and comment" button instead of the "Comment" button. Reopening. Hi @vieiro, thanks for the heads up! approved. Will you also do 17? That would be great! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1414#issuecomment-2674734895 From rrich at openjdk.org Fri Feb 21 15:05:01 2025 From: rrich at openjdk.org (Richard Reingruber) Date: Fri, 21 Feb 2025 15:05:01 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v4] In-Reply-To: References: Message-ID: On Fri, 21 Feb 2025 14:40:39 GMT, Goetz Lindenmaier wrote: > Triggered by the discussion here and offline I had a second look at the exceptions I need to add because JDK-8297065 is not in 17. I committed some code that brings these closer to the origin. One I had added is not really needed as IOException is caught at the callsite anyways. And the diff to the versions of DHPublicKey.java and DHPrivateKey.java is minimal now. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#issuecomment-2674786755 From duke at openjdk.org Fri Feb 21 16:03:59 2025 From: duke at openjdk.org (duke) Date: Fri, 21 Feb 2025 16:03:59 GMT Subject: [jdk21u-dev] RFR: 8349729 : [21u] AIX jtreg tests fail to compile with qvisibility=hidden In-Reply-To: <-eorSrfLcZAAlwV-oN9XLLVi_D_4cTp9EPYGlt51HYU=.bd836d4e-69d3-4cfd-ae49-597eb2ac0628@github.com> References: <-eorSrfLcZAAlwV-oN9XLLVi_D_4cTp9EPYGlt51HYU=.bd836d4e-69d3-4cfd-ae49-597eb2ac0628@github.com> Message-ID: On Thu, 20 Feb 2025 16:44:30 GMT, Suchismith Roy wrote: > JBS ISSUE : [JDK-8349729](https://bugs.openjdk.org/browse/JDK-8349729) @suchismith1993 Your change (at version 738ab1f9300632d7ff14c146449d5c91f5c83866) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1425#issuecomment-2674932074 From goetz at openjdk.org Fri Feb 21 16:04:54 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 16:04:54 GMT Subject: [jdk21u-dev] RFR: 8327476: Upgrade JLine to 3.26.1 In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 09:37:11 GMT, Goetz Lindenmaier wrote: > I backport this change for parity with 21.0.7-oracle. > > It brings updates of upstream library jline 3.26.1 to jdk21. > Jdk21 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). > The original sources of jline 3.26.1 can be found here: > https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz > > The backport of this change needed larger adaptions. > > The original jline library dynamically selects how to access > the operating system in two means: > * Which operating system? linux, windows, mac? > * JDK functionality to do native calls: JNI, jna, ffm? > > The implementation in OpenJDK does this selection at JDK build time. > The code is split into more subdirectories for the operating systems. > One of the methods to call native is picked, the code for the others > is removed. Unfortunately this differs for the JDK releases: > * jdk21 uses jna. > * jdk23 uses ffm. > The original patch of this change includes all the edits to > replace jna by ffm. > > Further changes that fell into the eye during the backport > * jline changed the format of its Copyright header > * jline changed sorting of imports > * jline changed a lot of formatting, especially how > arguments to methods are listed. > * jline removed the `Stream` enum from `TerminalProvider.java` and moved it > into a class of its own: `SystemStream.java`. This makes changes to > import statements and argument lists necessary. > * OpenJDK added a new parameter `inputStreamWrapper` to the > functions which are also affected by the `Stream` enum change. > This also made changes to import statements and argument lists > necessary. > > OpenJDK 23 added jline to the list of modules needed for a jre. > I don't think we should do that in 21, so I omitted that change. > > jline 3.26.1 and OpenJDK 23 added a new method `systemStreamWidth() `to `TerminalProvider`. > I don't think we should extend the functionlaity of jline in 21, > so I omitted this. Also, I would need additional parts of the > jline windows files that are not yet included in OpenJDK to > implement this. > > For the backport, I dropped the following files from the patch: > ``` > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/CLibrary.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmNativePty.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmTerminalProvider.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/termina... Thanks for looking at this change! GetConsoleOutputCP was removed in the original lib from .../win/Kernel32.java So I removed it from Kernel32Impl.java and Kernel32.cpp. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1413#issuecomment-2674932891 From mdoerr at openjdk.org Fri Feb 21 16:16:54 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 21 Feb 2025 16:16:54 GMT Subject: [jdk21u-dev] RFR: 8327476: Upgrade JLine to 3.26.1 In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 09:37:11 GMT, Goetz Lindenmaier wrote: > I backport this change for parity with 21.0.7-oracle. > > It brings updates of upstream library jline 3.26.1 to jdk21. > Jdk21 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). > The original sources of jline 3.26.1 can be found here: > https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz > > The backport of this change needed larger adaptions. > > The original jline library dynamically selects how to access > the operating system in two means: > * Which operating system? linux, windows, mac? > * JDK functionality to do native calls: JNI, jna, ffm? > > The implementation in OpenJDK does this selection at JDK build time. > The code is split into more subdirectories for the operating systems. > One of the methods to call native is picked, the code for the others > is removed. Unfortunately this differs for the JDK releases: > * jdk21 uses jna. > * jdk23 uses ffm. > The original patch of this change includes all the edits to > replace jna by ffm. > > Further changes that fell into the eye during the backport > * jline changed the format of its Copyright header > * jline changed sorting of imports > * jline changed a lot of formatting, especially how > arguments to methods are listed. > * jline removed the `Stream` enum from `TerminalProvider.java` and moved it > into a class of its own: `SystemStream.java`. This makes changes to > import statements and argument lists necessary. > * OpenJDK added a new parameter `inputStreamWrapper` to the > functions which are also affected by the `Stream` enum change. > This also made changes to import statements and argument lists > necessary. > > OpenJDK 23 added jline to the list of modules needed for a jre. > I don't think we should do that in 21, so I omitted that change. > > jline 3.26.1 and OpenJDK 23 added a new method `systemStreamWidth() `to `TerminalProvider`. > I don't think we should extend the functionlaity of jline in 21, > so I omitted this. Also, I would need additional parts of the > jline windows files that are not yet included in OpenJDK to > implement this. > > For the backport, I dropped the following files from the patch: > ``` > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/CLibrary.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmNativePty.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmTerminalProvider.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/termina... I can still see `GetConsoleOutputCP` in https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz. Where did you find the removal? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1413#issuecomment-2674968588 From goetz at openjdk.org Fri Feb 21 16:16:54 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 16:16:54 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v4] In-Reply-To: References: Message-ID: On Fri, 21 Feb 2025 15:01:52 GMT, Richard Reingruber wrote: > > Triggered by the discussion here and offline I had a second look at the exceptions I need to add because JDK-8297065 is not in 17. I committed some code that brings these closer to the origin. One I had added is not really needed as IOException is caught at the callsite anyways. > > And the diff to the versions of DHPublicKey.java and DHPrivateKey.java is minimal now. Yes, thanks for reviewing! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#issuecomment-2674964182 From goetz at openjdk.org Fri Feb 21 16:16:55 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 16:16:55 GMT Subject: [jdk17u-dev] RFR: 8302111: Serialization considerations [v5] In-Reply-To: <3OnhdEdth2V6akBT6KVqRjnn8lQHryZdBmY5ZuYKPiQ=.8e63f79b-cf55-4b29-9f13-ce4035be8c4b@github.com> References: <3OnhdEdth2V6akBT6KVqRjnn8lQHryZdBmY5ZuYKPiQ=.8e63f79b-cf55-4b29-9f13-ce4035be8c4b@github.com> Message-ID: <9_vaGVAzF92s69wtP-P8NPQq0orMOdW2aGRb-NMmXLM=.a61c89ba-5f9f-4860-b1e9-6664a95b5cf7@github.com> On Fri, 21 Feb 2025 14:43:14 GMT, Goetz Lindenmaier wrote: >> I backport this to match 17.0.13-oracle based on the commit to 21. >> >> I had to resolve several files, two of them considerably: >> >> src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java >> Resolved larger chunk. >> src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java >> Resolved some code. >> >> The new code in DHPublic/PrivateKey depends on the removal >> of IOExceptions in [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) "DerOutputStream operations should not throw IOExceptions". >> This change is in 21 but not in 17. Thus code backported from 21 calls functions of >> DerOutputStream that do not throw an exception in 21, but do so in 17. >> JDK-8297065 makes the point that these exceptions can never be thrown, which also >> holds for 17. So I just catch and ignore them. >> >> Also, I had to adapt code because an exception constructor with cause for >> InvalidObjectException is missing in 17. >> This was added by [JDK-8282696](https://bugs.openjdk.org/browse/JDK-8282696) "Add constructors taking a cause >> to InvalidObjectException and InvalidClassException" in 19. >> I added a call to initCause() to store the causing exception. >> >> I double-checked that [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) was not backported >> by Oracle. Backporting this change would simplify matters considerably. >> >> The remaining files only needed trivial resolves: >> >> src/java.base/share/classes/java/security/Permissions.java >> src/java.base/share/classes/java/security/SignedObject.java >> Only Copyright. >> src/java.base/share/classes/java/security/Timestamp.java >> Copyright and import. >> src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java >> src/java.base/share/classes/java/security/cert/CertificateRevokedException.java >> src/java.base/share/classes/sun/security/provider/DRBG.java >> src/java.base/share/classes/sun/security/util/ObjectIdentifier.java >> src/java.base/share/classes/sun/security/x509/AlgIdDSA.java >> Only Copyright. >> src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Context.java >> Resolved imports. >> src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecureRandom.java >> Only Copyright. >> >> I manually ran these tests on linux x86_64: >> >> test/jdk/com/sun/security >> test/jdk/java/awt/security >> test/jdk/java/net/httpclient/security >> test/jdk/java/net/httpclient/we... > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Bring exceptions closer to status before JDK-8297065 Hi @martinuy, Although I think this is good to go now, I would appreciate a second look by you. Could you find time in the next days? Thanks, Goetz. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#issuecomment-2674969857 From mdoerr at openjdk.org Fri Feb 21 16:20:51 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 21 Feb 2025 16:20:51 GMT Subject: [jdk21u-dev] RFR: 8327476: Upgrade JLine to 3.26.1 In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 09:37:11 GMT, Goetz Lindenmaier wrote: > I backport this change for parity with 21.0.7-oracle. > > It brings updates of upstream library jline 3.26.1 to jdk21. > Jdk21 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). > The original sources of jline 3.26.1 can be found here: > https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz > > The backport of this change needed larger adaptions. > > The original jline library dynamically selects how to access > the operating system in two means: > * Which operating system? linux, windows, mac? > * JDK functionality to do native calls: JNI, jna, ffm? > > The implementation in OpenJDK does this selection at JDK build time. > The code is split into more subdirectories for the operating systems. > One of the methods to call native is picked, the code for the others > is removed. Unfortunately this differs for the JDK releases: > * jdk21 uses jna. > * jdk23 uses ffm. > The original patch of this change includes all the edits to > replace jna by ffm. > > Further changes that fell into the eye during the backport > * jline changed the format of its Copyright header > * jline changed sorting of imports > * jline changed a lot of formatting, especially how > arguments to methods are listed. > * jline removed the `Stream` enum from `TerminalProvider.java` and moved it > into a class of its own: `SystemStream.java`. This makes changes to > import statements and argument lists necessary. > * OpenJDK added a new parameter `inputStreamWrapper` to the > functions which are also affected by the `Stream` enum change. > This also made changes to import statements and argument lists > necessary. > > OpenJDK 23 added jline to the list of modules needed for a jre. > I don't think we should do that in 21, so I omitted that change. > > jline 3.26.1 and OpenJDK 23 added a new method `systemStreamWidth() `to `TerminalProvider`. > I don't think we should extend the functionlaity of jline in 21, > so I omitted this. Also, I would need additional parts of the > jline windows files that are not yet included in OpenJDK to > implement this. > > For the backport, I dropped the following files from the patch: > ``` > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/CLibrary.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmNativePty.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmTerminalProvider.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/termina... Marked as reviewed by mdoerr (Reviewer). Ah, I see it only in jline3-jline-parent-3.26.1/native/src/main/java/org/jline/nativ/Kernel32.java: public static native int GetConsoleOutputCP(); jline3-jline-parent-3.26.1/native/src/main/native/kernel32.c:JNIEXPORT jint JNICALL Kernel32_NATIVE(GetConsoleOutputCP) jline3-jline-parent-3.26.1/native/src/main/native/kernel32.c: rc = (jint)GetConsoleOutputCP(); So, it seems to be no longer in the windows files. ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1413#pullrequestreview-2633580839 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1413#issuecomment-2674980888 From duke at openjdk.org Fri Feb 21 16:48:58 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 21 Feb 2025 16:48:58 GMT Subject: [jdk21u-dev] RFR: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 11:34:47 GMT, Antonio Vieiro wrote: >> Hi @vieiro >> Thanks for adressing this! >> Did this really read out the menu items in your test? >> Did you double-check the test is failing without the fix? >> It did not work out in my setup on the first try, but I did not find time to look >> into this further. I assumed it is related to my local JAWS setup. > > @GoeLin D'oh. I hit the "Close and comment" button instead of the "Comment" button. Reopening. > Hi @vieiro, thanks for the heads up! approved. Will you also do 17? That would be great! Hi @GoeLin . Yep, 17 and 11. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1414#issuecomment-2675050530 From goetz at openjdk.org Fri Feb 21 16:58:52 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 16:58:52 GMT Subject: [jdk21u-dev] RFR: 8327476: Upgrade JLine to 3.26.1 In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 09:37:11 GMT, Goetz Lindenmaier wrote: > I backport this change for parity with 21.0.7-oracle. > > It brings updates of upstream library jline 3.26.1 to jdk21. > Jdk21 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). > The original sources of jline 3.26.1 can be found here: > https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz > > The backport of this change needed larger adaptions. > > The original jline library dynamically selects how to access > the operating system in two means: > * Which operating system? linux, windows, mac? > * JDK functionality to do native calls: JNI, jna, ffm? > > The implementation in OpenJDK does this selection at JDK build time. > The code is split into more subdirectories for the operating systems. > One of the methods to call native is picked, the code for the others > is removed. Unfortunately this differs for the JDK releases: > * jdk21 uses jna. > * jdk23 uses ffm. > The original patch of this change includes all the edits to > replace jna by ffm. > > Further changes that fell into the eye during the backport > * jline changed the format of its Copyright header > * jline changed sorting of imports > * jline changed a lot of formatting, especially how > arguments to methods are listed. > * jline removed the `Stream` enum from `TerminalProvider.java` and moved it > into a class of its own: `SystemStream.java`. This makes changes to > import statements and argument lists necessary. > * OpenJDK added a new parameter `inputStreamWrapper` to the > functions which are also affected by the `Stream` enum change. > This also made changes to import statements and argument lists > necessary. > > OpenJDK 23 added jline to the list of modules needed for a jre. > I don't think we should do that in 21, so I omitted that change. > > jline 3.26.1 and OpenJDK 23 added a new method `systemStreamWidth() `to `TerminalProvider`. > I don't think we should extend the functionlaity of jline in 21, > so I omitted this. Also, I would need additional parts of the > jline windows files that are not yet included in OpenJDK to > implement this. > > For the backport, I dropped the following files from the patch: > ``` > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/CLibrary.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmNativePty.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmTerminalProvider.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/termina... I think it is unused, and this was cleaned up in the win files, but not in the rest. At least is't nowhere called within jline. Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1413#issuecomment-2675074273 From duke at openjdk.org Fri Feb 21 16:58:56 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 21 Feb 2025 16:58:56 GMT Subject: [jdk21u-dev] RFR: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: On Fri, 21 Feb 2025 14:42:59 GMT, Goetz Lindenmaier wrote: >> @GoeLin D'oh. I hit the "Close and comment" button instead of the "Comment" button. Reopening. > > Hi @vieiro, thanks for the heads up! approved. > Will you also do 17? That would be great! Hi @GoeLin I'm afraid there's a typo at [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) : label `jddk21u-fix-yes` should read `jdk21u-fix-yes`, I'm afraid (note a double `d`). Would you please fix that one for me? Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1414#issuecomment-2675074918 From goetz at openjdk.org Fri Feb 21 17:09:53 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 21 Feb 2025 17:09:53 GMT Subject: [jdk21u-dev] RFR: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 11:06:53 GMT, Antonio Vieiro wrote: > Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 24u that solves some accessibility issues on Windows, for parity with 11.0.27-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. > > The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ) Sorry for that, fixed! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1414#issuecomment-2675099054 From duke at openjdk.org Fri Feb 21 17:15:54 2025 From: duke at openjdk.org (duke) Date: Fri, 21 Feb 2025 17:15:54 GMT Subject: [jdk21u-dev] RFR: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 11:06:53 GMT, Antonio Vieiro wrote: > Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 24u that solves some accessibility issues on Windows, for parity with 11.0.27-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. > > The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ) @vieiro Your change (at version 55bcca72445a677648d64c286489d65a81890d48) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1414#issuecomment-2675111273 From duke at openjdk.org Fri Feb 21 17:25:59 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 21 Feb 2025 17:25:59 GMT Subject: [jdk21u-dev] Integrated: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 11:06:53 GMT, Antonio Vieiro wrote: > Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 24u that solves some accessibility issues on Windows, for parity with 11.0.27-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. > > The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ) This pull request has now been integrated. Changeset: af639f37 Author: Antonio Vieiro Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/af639f37ffb3a46351258155a4400a20c9b313fb Stats: 127 lines in 3 files changed: 116 ins; 5 del; 6 mod 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class Backport-of: ecdc322029d3f1338d547955c938b6bc57696ac0 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1414 From kvn at openjdk.org Fri Feb 21 19:16:30 2025 From: kvn at openjdk.org (Vladimir Kozlov) Date: Fri, 21 Feb 2025 19:16:30 GMT Subject: [jdk24u] RFR: 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places Message-ID: Hi all, This pull request contains a backport of commit [0b50e479](https://github.com/openjdk/jdk/commit/0b50e479a060cf745a3e858d535516444fe80fd8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Vladimir Kozlov on 13 Feb 2025 and was reviewed by Dean Long and Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport 0b50e479a060cf745a3e858d535516444fe80fd8 Changes: https://git.openjdk.org/jdk24u/pull/87/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=87&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349753 Stats: 47 lines in 4 files changed: 45 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk24u/pull/87.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/87/head:pull/87 PR: https://git.openjdk.org/jdk24u/pull/87 From abakhtin at openjdk.org Fri Feb 21 21:01:29 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 21 Feb 2025 21:01:29 GMT Subject: [jdk21u-dev] RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2] In-Reply-To: References: Message-ID: > Please review the backport of JDK-8342075 > > Almost clean backport except for the import section of src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java > > All jtreg tests for java.net.httpclient are passed Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1427/files - new: https://git.openjdk.org/jdk21u-dev/pull/1427/files/d69829e8..d69829e8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1427&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1427&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1427.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1427/head:pull/1427 PR: https://git.openjdk.org/jdk21u-dev/pull/1427 From abakhtin at openjdk.org Fri Feb 21 21:01:48 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 21 Feb 2025 21:01:48 GMT Subject: [jdk21u-dev] RFR: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered [v2] In-Reply-To: References: Message-ID: > Clean backport of JDK-8317808 > > All jtreg tests for java.net.httpclient are passed Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Backport 6273ab97dc1a0d3c1f51ba94694d9594dd7593d4 - Remove extra import - Backport 720b44648bcff997278af92746f942b2425298a5 - Backport fc98998627443d6e73ac70661f47f48b30525712 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1426/files - new: https://git.openjdk.org/jdk21u-dev/pull/1426/files/fa55d4a5..c0f83e97 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1426&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1426&range=00-01 Stats: 1362 lines in 13 files changed: 587 ins; 516 del; 259 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1426.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1426/head:pull/1426 PR: https://git.openjdk.org/jdk21u-dev/pull/1426 From abakhtin at openjdk.org Fri Feb 21 21:17:08 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 21 Feb 2025 21:17:08 GMT Subject: [jdk21u-dev] RFR: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered [v3] In-Reply-To: References: Message-ID: > Clean backport of JDK-8317808 > > All jtreg tests for java.net.httpclient are passed Alexey Bakhtin has updated the pull request incrementally with three additional commits since the last revision: - Revert "Backport fc98998627443d6e73ac70661f47f48b30525712" This reverts commit 899abf76e7a381abdfbc30f08a6a5678c0a8065d. - Revert "Backport 720b44648bcff997278af92746f942b2425298a5" This reverts commit a5b7bb4d432c868d598c35f54306e40747071ad7. - Revert "Remove extra import" This reverts commit 480336754274ea62ab2e9b076dcec91f7d483c25. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1426/files - new: https://git.openjdk.org/jdk21u-dev/pull/1426/files/c0f83e97..0857043a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1426&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1426&range=01-02 Stats: 1087 lines in 15 files changed: 12 ins; 1009 del; 66 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1426.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1426/head:pull/1426 PR: https://git.openjdk.org/jdk21u-dev/pull/1426 From abakhtin at openjdk.org Fri Feb 21 22:00:08 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 21 Feb 2025 22:00:08 GMT Subject: [jdk21u-dev] Withdrawn: 8342075: HttpClient: improve HTTP/2 flow control checks In-Reply-To: References: Message-ID: On Fri, 21 Feb 2025 01:47:39 GMT, Alexey Bakhtin wrote: > Please review the backport of JDK-8342075 > > Almost clean backport except for the import section of src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java > > All jtreg tests for java.net.httpclient are passed This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1427 From abakhtin at openjdk.org Fri Feb 21 22:02:15 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 21 Feb 2025 22:02:15 GMT Subject: [jdk21u-dev] Withdrawn: 8316580: HttpClient with StructuredTaskScope does not close when a task fails In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 22:34:41 GMT, Alexey Bakhtin wrote: > Please review the backport of JDK-8316580 > > The backport is almost clean, with an exception for src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java > The manual merge is required for MultiExchange::cancel(boolean mayInterruptIfRunning) because of no 8310330 in JDK21 > > All jtreg tests for java.net.httpclient are passed This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1416 From kvn at openjdk.org Fri Feb 21 22:02:15 2025 From: kvn at openjdk.org (Vladimir Kozlov) Date: Fri, 21 Feb 2025 22:02:15 GMT Subject: [jdk24u] Integrated: 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places In-Reply-To: References: Message-ID: On Fri, 21 Feb 2025 19:10:54 GMT, Vladimir Kozlov wrote: > Hi all, > > This pull request contains a backport of commit [0b50e479](https://github.com/openjdk/jdk/commit/0b50e479a060cf745a3e858d535516444fe80fd8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Vladimir Kozlov on 13 Feb 2025 and was reviewed by Dean Long and Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: a5f39c16 Author: Vladimir Kozlov URL: https://git.openjdk.org/jdk24u/commit/a5f39c16b3b4817c65fdc9e5fea84c15ddb779f6 Stats: 47 lines in 4 files changed: 45 ins; 0 del; 2 mod 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places Backport-of: 0b50e479a060cf745a3e858d535516444fe80fd8 ------------- PR: https://git.openjdk.org/jdk24u/pull/87 From abakhtin at openjdk.org Fri Feb 21 22:02:32 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 21 Feb 2025 22:02:32 GMT Subject: [jdk21u-dev] RFR: 8342075: HttpClient: improve HTTP/2 flow control checks Message-ID: Please review the backport of JDK-8342075 Almost clean backport except for the import section of src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java Requires JDK-8317808 [1] as a prerequisite to fixing the hanging of the new tests. Also, new tests require Http2TestExchange::getConnectionKey() method added by JDK-8335181 [2]. test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchange.java, test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchangeImpl.java and test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java test classes are updated to add getConnectionKey() implementation All jtreg tests for java.net.httpclient are passed [1] - https://github.com/openjdk/jdk21u-dev/pull/1426 [2] - https://github.com/openjdk/jdk/commit/720b44648bcff997278af92746f942b2425298a5#diff-c18c2a070038409f25c08e13c174a95f33840e2deddcc29f6d8306de572a618b ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/1426 Commit messages: - Add Http2TestExchange::getConnectionKey() from JDK-8335181 - Backport b0ac633b2d0076d64b463b2a6ce19abf6b12c50f Changes: https://git.openjdk.org/jdk21u-dev/pull/1428/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1428&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342075 Stats: 1039 lines in 15 files changed: 1002 ins; 2 del; 35 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1428.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1428/head:pull/1428 PR: https://git.openjdk.org/jdk21u-dev/pull/1428 From serb at openjdk.org Fri Feb 21 23:09:05 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 21 Feb 2025 23:09:05 GMT Subject: [jdk11u-dev] Integrated: 8347427: JTabbedPane/8134116/Bug8134116.java has no license header In-Reply-To: <1_-_cyQRnz5LBqeI-dtFHUyBKvjfqejMGmdWC-Jnp8w=.769abea0-6190-4303-a7d9-bec25ba7f523@github.com> References: <1_-_cyQRnz5LBqeI-dtFHUyBKvjfqejMGmdWC-Jnp8w=.769abea0-6190-4303-a7d9-bec25ba7f523@github.com> Message-ID: On Wed, 29 Jan 2025 22:05:27 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [f67b7036](https://github.com/openjdk/jdk/commit/f67b703625afa2e049c572978d29ac00d8c956d3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Ivanov on 13 Jan 2025 and was reviewed by Dmitry Markov, Harshitha Onkar and Abhishek Kumar. > > Thanks! This pull request has now been integrated. Changeset: 86dddbcd Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/86dddbcda62626382d97c596f2edf777757dbe98 Stats: 33 lines in 1 file changed: 30 ins; 0 del; 3 mod 8347427: JTabbedPane/8134116/Bug8134116.java has no license header Backport-of: f67b703625afa2e049c572978d29ac00d8c956d3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2990 From duke at openjdk.org Sat Feb 22 10:10:42 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Sat, 22 Feb 2025 10:10:42 GMT Subject: [jdk17u-dev] RFR: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class Message-ID: Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 21u that solves some accessibility issues on Windows, for parity with 17.0.15/166-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. The test does fail without this fix (when read-out, the short-cuts are truncated, so for instance the menu short-cut "Ctrl+Shift+Period" was read out as "Control plus Shift plus P", instead of "Control plus Shift plus Period". The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ). Clean but for an update in copyright header in `AccessBridge.java`. ------------- Commit messages: - Backport af639f37ffb3a46351258155a4400a20c9b313fb Changes: https://git.openjdk.org/jdk17u-dev/pull/3291/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3291&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339728 Stats: 127 lines in 3 files changed: 116 ins; 5 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3291.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3291/head:pull/3291 PR: https://git.openjdk.org/jdk17u-dev/pull/3291 From duke at openjdk.org Sat Feb 22 11:46:56 2025 From: duke at openjdk.org (duke) Date: Sat, 22 Feb 2025 11:46:56 GMT Subject: [jdk17u-dev] RFR: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: On Sat, 22 Feb 2025 10:05:33 GMT, Antonio Vieiro wrote: > Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 21u that solves some accessibility issues on Windows, for parity with 17.0.15/166-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. > > The test does fail without this fix (when read-out, the short-cuts are truncated, so for instance the menu short-cut "Ctrl+Shift+Period" was read out as "Control plus Shift plus P", instead of "Control plus Shift plus Period". > > The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ). > > Clean but for an update in copyright header in `AccessBridge.java`. @vieiro Your change (at version 0d71e9700b9b8fdf2dccd34068d0ee857efba7ed) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3291#issuecomment-2676161217 From goetz at openjdk.org Sat Feb 22 15:02:59 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:02:59 GMT Subject: [jdk21u-dev] Integrated: 8337222: gc/TestDisableExplicitGC.java fails due to unexpected CodeCache GC In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 13:32:35 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle. This pull request has now been integrated. Changeset: d930aa1c Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d930aa1c6eb600ba135f224abc22238bf2fc2f43 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8337222: gc/TestDisableExplicitGC.java fails due to unexpected CodeCache GC Backport-of: dab2a0b5978cdd3fad693e4c120a84bb64a3ccde ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1419 From goetz at openjdk.org Sat Feb 22 15:05:53 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:05:53 GMT Subject: [jdk21u-dev] Integrated: 8338595: Add more linesize for MIME decoder in macro bench test Base64Decode In-Reply-To: <4MyPaageQjDIGPcPdi7uD4q2UnxI5arAKFAcJ6yJnaA=.be723f32-90a9-4d00-9b6c-230bb6cd1d0d@github.com> References: <4MyPaageQjDIGPcPdi7uD4q2UnxI5arAKFAcJ6yJnaA=.be723f32-90a9-4d00-9b6c-230bb6cd1d0d@github.com> Message-ID: On Thu, 20 Feb 2025 13:54:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle. This pull request has now been integrated. Changeset: 1e66664d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/1e66664d2dadd861a1a76505f2fbadd117301263 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8338595: Add more linesize for MIME decoder in macro bench test Base64Decode Backport-of: 7458952dedc0a34b5c7f3e9e228f9b18e08f19e3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1420 From goetz at openjdk.org Sat Feb 22 15:07:53 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:07:53 GMT Subject: [jdk21u-dev] Integrated: 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 14:02:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle This pull request has now been integrated. Changeset: e746fe64 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/e746fe648903ab8876d8d2d3fd63e37d17e1db2a Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI Backport-of: a0b7c4f015c694425893b8d21d2aecae71a3b604 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1421 From goetz at openjdk.org Sat Feb 22 15:12:34 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:12:34 GMT Subject: [jdk21u-dev] RFR: 8346828: javax/swing/JScrollBar/4865918/bug4865918.java still fails in CI [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.8-oracle Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into goetz_backport_8346828 - Backport 9fafd63d46f64428e0b9c2e9a6b0ac7ca0e2d355 - Backport a0b7c4f015c694425893b8d21d2aecae71a3b604 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1422/files - new: https://git.openjdk.org/jdk21u-dev/pull/1422/files/ca88c925..d86d4096 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1422&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1422&range=00-01 Stats: 129 lines in 5 files changed: 117 ins; 5 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1422.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1422/head:pull/1422 PR: https://git.openjdk.org/jdk21u-dev/pull/1422 From goetz at openjdk.org Sat Feb 22 15:13:54 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:13:54 GMT Subject: [jdk17u-dev] Integrated: 8274893: Update java.desktop classes to use try-with-resources In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 10:16:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > I hesitated a while to backport this Enhancements, but I think it's better to > go along with Oracle here, too. Especially as it's an almost clean backport. > > Copyright: > src/java.desktop/share/classes/com/sun/media/sound/AudioFileSoundbankReader.java > src/java.desktop/share/classes/com/sun/media/sound/JARSoundbankReader.java > > src/java.desktop/share/classes/javax/imageio/ImageIO.java > The try-finally statement catches an exception in 17, which is not > present in the original change. > This is becasue "(8272998)[https://bugs.openjdk.org/browse/JDK-8272998]: ImageIO.read() throws incorrect exception type" was > already backported. Trivial resolve. This pull request has now been integrated. Changeset: 15730c0b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/15730c0bf2d9ee79ee9b023b33c739ee84669fde Stats: 225 lines in 24 files changed: 27 ins; 98 del; 100 mod 8274893: Update java.desktop classes to use try-with-resources Backport-of: 70c6df6be431fe11c5441986ed04040f9ec3b750 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3283 From goetz at openjdk.org Sat Feb 22 15:15:00 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:15:00 GMT Subject: [jdk17u-dev] Integrated: 8301989: new javax.swing.text.DefaultCaret().setBlinkRate(N) results in NPE In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 13:23:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 45a35e85 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/45a35e8539c3f93be78264832d4f4c462edb071f Stats: 49 lines in 2 files changed: 46 ins; 0 del; 3 mod 8301989: new javax.swing.text.DefaultCaret().setBlinkRate(N) results in NPE Backport-of: e81f20b50405dc02963c8bf549000c60e78152d8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3284 From goetz at openjdk.org Sat Feb 22 15:15:01 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:15:01 GMT Subject: [jdk21u-dev] Integrated: 8346828: javax/swing/JScrollBar/4865918/bug4865918.java still fails in CI In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 14:15:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle This pull request has now been integrated. Changeset: ed0c9d3e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/ed0c9d3e288fa1b35b3569a420b8bcb7aec275ed Stats: 35 lines in 1 file changed: 4 ins; 19 del; 12 mod 8346828: javax/swing/JScrollBar/4865918/bug4865918.java still fails in CI Backport-of: 9fafd63d46f64428e0b9c2e9a6b0ac7ca0e2d355 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1422 From goetz at openjdk.org Sat Feb 22 15:15:57 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:15:57 GMT Subject: [jdk21u-dev] Integrated: 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 14:24:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle This pull request has now been integrated. Changeset: 69192feb Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/69192febb25cfe2cd053735815e85657aea3e777 Stats: 204 lines in 4 files changed: 91 ins; 22 del; 91 mod 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland Backport-of: 6f4fc82149b52dd91289fe42def7d1cacad31212 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1423 From goetz at openjdk.org Sat Feb 22 15:16:54 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:16:54 GMT Subject: [jdk17u-dev] Integrated: 8314975: JavadocTester should set source path if not specified In-Reply-To: References: Message-ID: On Wed, 5 Feb 2025 13:08:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. > > Add-on: > > Our nightly testing found that TestCopyFiles.java is failing with this patch. > This concerns only the subtest testDocFilesInPackagesSource7UsingClassPath(). > > This test is removed in later jdks by [JDK-8173605](https://bugs.openjdk.org/browse/JDK-8173605): Remove support for source and target 1.7 option in javac. > > The test sets "-source 7" for the test run. It tests that -classpath can > be given to javadoc instead of -sourcepath. This feature still exists in higher jdks, > I verified that the test is passing if either using "-source 8/9" or removing this flag (and undoing the edits of this change). > > The edits of this change affect that -sourcepath is added to the javadoc command line, but the > path used (testSrc) does not point to the proper sources. Thus the test fails. > > I see several ways to repair this: > * add proper -sourcepath to the test. This contradicts the purpose of this test, but makes it pass. See second commit. > * remove the test altogether as it is the case in later jdks. > * somehow implement a special case to avoid that JavadocTester adds -sourcepath to this test. > > A somewhat bigger fix would be to add "-classpath" to the check for sourcepath in JavadocTester and add the testDocFilesInPackagesSource7UsingClassPath back again, but remove the -source setting from that test. I guess this should be done in head and backported to 24, 21 and 17. This pull request has now been integrated. Changeset: d8ae0398 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/d8ae0398f6208953ebe02142475b47d765a22004 Stats: 13 lines in 2 files changed: 13 ins; 0 del; 0 mod 8314975: JavadocTester should set source path if not specified Reviewed-by: mbaesken Backport-of: 2f4d601a56bf02db2766d1f8a2ddfff906b78678 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3266 From goetz at openjdk.org Sat Feb 22 15:18:08 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:18:08 GMT Subject: [jdk17u-dev] Integrated: 8337222: gc/TestDisableExplicitGC.java fails due to unexpected CodeCache GC In-Reply-To: <-o2IHfc9vqG_Z6slE5AMnezmHhKl9U4yCbpo8AIXJNw=.f634427b-dc27-403d-9f87-0f94b7751e25@github.com> References: <-o2IHfc9vqG_Z6slE5AMnezmHhKl9U4yCbpo8AIXJNw=.f634427b-dc27-403d-9f87-0f94b7751e25@github.com> Message-ID: <-4os5_6_rrH2Sako-N6Lk0BdYowZeJc0ThDs9UkUeKY=.23e64601-dcff-4852-8825-9d768043c603@github.com> On Thu, 20 Feb 2025 13:32:58 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle This pull request has now been integrated. Changeset: f7a071e2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f7a071e21a52aa95f5fcc6452212682eecf3cea8 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8337222: gc/TestDisableExplicitGC.java fails due to unexpected CodeCache GC Backport-of: dab2a0b5978cdd3fad693e4c120a84bb64a3ccde ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3285 From goetz at openjdk.org Sat Feb 22 15:19:03 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:19:03 GMT Subject: [jdk17u-dev] Integrated: 8338595: Add more linesize for MIME decoder in macro bench test Base64Decode In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 13:54:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: 9f48d421 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9f48d4211f86764f4ba928003270d6268dd538c6 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8338595: Add more linesize for MIME decoder in macro bench test Base64Decode Backport-of: 7458952dedc0a34b5c7f3e9e228f9b18e08f19e3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3286 From goetz at openjdk.org Sat Feb 22 15:20:01 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:20:01 GMT Subject: [jdk17u-dev] Integrated: 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 14:04:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: 715d37ef Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/715d37ef788d99ce5218001ab78e63022a0d2a3d Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI Backport-of: a0b7c4f015c694425893b8d21d2aecae71a3b604 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3287 From goetz at openjdk.org Sat Feb 22 15:23:32 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:23:32 GMT Subject: [jdk17u-dev] RFR: 8346828: javax/swing/JScrollBar/4865918/bug4865918.java still fails in CI [v2] In-Reply-To: References: Message-ID: <8ZCp8f8V9bK6otdbWEy2ezKd-_DkFQcpds7TetN1OmA=.f2020325-fe71-4e32-9744-b5b5dde6864d@github.com> > I backport this for parity with 17.0.16-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into goetz_backport_8346828 - Backport 9fafd63d46f64428e0b9c2e9a6b0ac7ca0e2d355 - Backport a0b7c4f015c694425893b8d21d2aecae71a3b604 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3288/files - new: https://git.openjdk.org/jdk17u-dev/pull/3288/files/1255ae4e..9fbf8b93 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3288&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3288&range=00-01 Stats: 289 lines in 30 files changed: 87 ins; 98 del; 104 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3288.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3288/head:pull/3288 PR: https://git.openjdk.org/jdk17u-dev/pull/3288 From goetz at openjdk.org Sat Feb 22 15:23:32 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 22 Feb 2025 15:23:32 GMT Subject: [jdk17u-dev] Integrated: 8346828: javax/swing/JScrollBar/4865918/bug4865918.java still fails in CI In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 14:16:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: 2846c9e0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2846c9e07b4502f2cc0c823b97c889f1440c66a6 Stats: 35 lines in 1 file changed: 4 ins; 19 del; 12 mod 8346828: javax/swing/JScrollBar/4865918/bug4865918.java still fails in CI Backport-of: 9fafd63d46f64428e0b9c2e9a6b0ac7ca0e2d355 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3288 From syan at openjdk.org Sun Feb 23 09:31:44 2025 From: syan at openjdk.org (SendaoYan) Date: Sun, 23 Feb 2025 09:31:44 GMT Subject: [jdk17u-dev] RFR: 8350540: [17u,11u] B8312065.java fails Network is unreachable Message-ID: Hi all, Test test/jdk/java/net/Socket/B8312065.java fails on some machines. Test assume 192.168.255.255 is not in use, but on some machines linux command `ping 192.168.255.255` will report "ping: connect: Network is unreachable" failure, so this test will report "java.net.ConnectException: Network is unreachable (connect failed)" failure. And this failure is not caused by JDK bug, so I think it's better throw `jtreg.SkippedException` when this failure reported. Change has been verified locally, test-fix only to make test more robustness, no risk. ------------- Commit messages: - 8350540: [17u,11u] B8312065.java fails Network is unreachable Changes: https://git.openjdk.org/jdk17u-dev/pull/3293/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3293&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350540 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3293.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3293/head:pull/3293 PR: https://git.openjdk.org/jdk17u-dev/pull/3293 From duke at openjdk.org Sun Feb 23 14:01:58 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Sun, 23 Feb 2025 14:01:58 GMT Subject: [jdk17u-dev] RFR: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: <1_zpIxHNwNbJnqiZNz_w4cEOlveJwTH170FR1W-lxm4=.af0928ba-54d5-41b7-8ca9-cb6dfeaa9286@github.com> On Sat, 22 Feb 2025 10:05:33 GMT, Antonio Vieiro wrote: > Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 21u that solves some accessibility issues on Windows, for parity with 17.0.15/166-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. > > The test does fail without this fix (when read-out, the short-cuts are truncated, so for instance the menu short-cut "Ctrl+Shift+Period" was read out as "Control plus Shift plus P", instead of "Control plus Shift plus Period". > > The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ). > > Clean but for an update in copyright header in `AccessBridge.java`. D'oh! This was already backported by @GoeLin in https://github.com/openjdk/jdk17u-dev/pull/3271. Closing this one then. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3291#issuecomment-2676877086 From duke at openjdk.org Sun Feb 23 14:01:58 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Sun, 23 Feb 2025 14:01:58 GMT Subject: [jdk17u-dev] Withdrawn: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: On Sat, 22 Feb 2025 10:05:33 GMT, Antonio Vieiro wrote: > Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 21u that solves some accessibility issues on Windows, for parity with 17.0.15/166-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. > > The test does fail without this fix (when read-out, the short-cuts are truncated, so for instance the menu short-cut "Ctrl+Shift+Period" was read out as "Control plus Shift plus P", instead of "Control plus Shift plus Period". > > The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ). > > Clean but for an update in copyright header in `AccessBridge.java`. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3291 From goetz at openjdk.org Mon Feb 24 07:06:04 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 24 Feb 2025 07:06:04 GMT Subject: [jdk17u-dev] RFR: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: <1_zpIxHNwNbJnqiZNz_w4cEOlveJwTH170FR1W-lxm4=.af0928ba-54d5-41b7-8ca9-cb6dfeaa9286@github.com> References: <1_zpIxHNwNbJnqiZNz_w4cEOlveJwTH170FR1W-lxm4=.af0928ba-54d5-41b7-8ca9-cb6dfeaa9286@github.com> Message-ID: On Sun, 23 Feb 2025 13:59:36 GMT, Antonio Vieiro wrote: >> Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 21u that solves some accessibility issues on Windows, for parity with 17.0.15/166-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. >> >> The test does fail without this fix (when read-out, the short-cuts are truncated, so for instance the menu short-cut "Ctrl+Shift+Period" was read out as "Control plus Shift plus P", instead of "Control plus Shift plus Period". >> >> The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ). >> >> Clean but for an update in copyright header in `AccessBridge.java`. > > D'oh! This was already backported by @GoeLin in https://github.com/openjdk/jdk17u-dev/pull/3271. Closing this one then. Hi @vieiro, yes, I prepared a PR, but I never got to properly testing it. So please proceed with your PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3291#issuecomment-2677579613 From goetz at openjdk.org Mon Feb 24 07:09:00 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 24 Feb 2025 07:09:00 GMT Subject: [jdk17u-dev] RFR: 8350540: [17u, 11u] B8312065.java fails Network is unreachable In-Reply-To: References: Message-ID: <75LvhZHJ5SxD4D7hs5awIRwLThuxCyA8e_froRAdUpQ=.c748161a-9318-4890-bab5-3b3c966b3b44@github.com> On Sun, 23 Feb 2025 09:27:24 GMT, SendaoYan wrote: > Hi all, > > Test test/jdk/java/net/Socket/B8312065.java fails on some machines. Test assume 192.168.255.255 is not in use, but on some machines linux command `ping 192.168.255.255` will report "ping: connect: Network is unreachable" failure, so this test will report "java.net.ConnectException: Network is unreachable (connect failed)" failure. And this failure is not caused by JDK bug, so I think it's better throw `jtreg.SkippedException` when this failure reported. > > Change has been verified locally, test-fix only to make test more robustness, no risk. Hi @sensaYan, why doesn't this apply to head and jdk21? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3293#issuecomment-2677582759 From syan at openjdk.org Mon Feb 24 07:14:58 2025 From: syan at openjdk.org (SendaoYan) Date: Mon, 24 Feb 2025 07:14:58 GMT Subject: [jdk17u-dev] RFR: 8350540: [17u, 11u] B8312065.java fails Network is unreachable In-Reply-To: References: Message-ID: On Sun, 23 Feb 2025 09:27:24 GMT, SendaoYan wrote: > Hi all, > > Test test/jdk/java/net/Socket/B8312065.java fails on some machines. Test assume 192.168.255.255 is not in use, but on some machines linux command `ping 192.168.255.255` will report "ping: connect: Network is unreachable" failure, so this test will report "java.net.ConnectException: Network is unreachable (connect failed)" failure. And this failure is not caused by JDK bug, so I think it's better throw `jtreg.SkippedException` when this failure reported. > > Change has been verified locally, test-fix only to make test more robustness, no risk. > Hi @sensayan, why doesn't this apply to head and jdk21? Hi @GoeLin Test test/jdk/java/net/Socket/B8312065.java was add by [JDK-8312065](https://bugs.openjdk.org/browse/JDK-8312065), and this test only added for jdk17u-dev and jdk11u-dev. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3293#issuecomment-2677590770 From duke at openjdk.org Mon Feb 24 07:43:05 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 24 Feb 2025 07:43:05 GMT Subject: [jdk17u-dev] RFR: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: <1_zpIxHNwNbJnqiZNz_w4cEOlveJwTH170FR1W-lxm4=.af0928ba-54d5-41b7-8ca9-cb6dfeaa9286@github.com> Message-ID: On Mon, 24 Feb 2025 07:03:31 GMT, Goetz Lindenmaier wrote: >> D'oh! This was already backported by @GoeLin in https://github.com/openjdk/jdk17u-dev/pull/3271. Closing this one then. > > Hi @vieiro, yes, I prepared a PR, but I never got to properly testing it. So please proceed with your PR. @GoeLin I'll reopen this one then. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3291#issuecomment-2677634129 From goetz at openjdk.org Mon Feb 24 08:14:04 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 24 Feb 2025 08:14:04 GMT Subject: [jdk17u-dev] RFR: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: On Sat, 22 Feb 2025 10:05:33 GMT, Antonio Vieiro wrote: > Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 21u that solves some accessibility issues on Windows, for parity with 17.0.15/166-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. > > The test does fail without this fix (when read-out, the short-cuts are truncated, so for instance the menu short-cut "Ctrl+Shift+Period" was read out as "Control plus Shift plus P", instead of "Control plus Shift plus Period". > > The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ). > > Clean but for an update in copyright header in `AccessBridge.java`. Thanks for backporting this! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3291#issuecomment-2677687020 From duke at openjdk.org Mon Feb 24 08:14:05 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 24 Feb 2025 08:14:05 GMT Subject: [jdk17u-dev] Integrated: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: On Sat, 22 Feb 2025 10:05:33 GMT, Antonio Vieiro wrote: > Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 21u that solves some accessibility issues on Windows, for parity with 17.0.15/166-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. > > The test does fail without this fix (when read-out, the short-cuts are truncated, so for instance the menu short-cut "Ctrl+Shift+Period" was read out as "Control plus Shift plus P", instead of "Control plus Shift plus Period". > > The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ). > > Clean but for an update in copyright header in `AccessBridge.java`. This pull request has now been integrated. Changeset: 01d107ae Author: Antonio Vieiro Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/01d107aea8eca4f4d2863deb30ac60e802debe15 Stats: 127 lines in 3 files changed: 116 ins; 5 del; 6 mod 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class Backport-of: af639f37ffb3a46351258155a4400a20c9b313fb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3291 From duke at openjdk.org Mon Feb 24 08:24:12 2025 From: duke at openjdk.org (Konanki Sreenath) Date: Mon, 24 Feb 2025 08:24:12 GMT Subject: [jdk24u] RFR: 8350554: Harden X509CertImpl.getExtensionValue for NPE cases Message-ID: Earlier code will trigger NPE if the certificate does not contain the extensions or if the requested extensions does not exist. The better approach for hardening getExtensionValue here is to to check for NULL explicitly before calling getExtensionValue() and avoding try-catch block which ensures the readability and maintainability. After scanning in multiple places where invokng getExtensions on the X509CertInfo reference, the check for NULL is added in the getKeyUsage() as well while calling before getExtensionValue() The associated tests are written and added in test class CertificateExtensions. Which will ensure to validate the getExtensionValue() and getKeyUsage() methods in X509CertImpl class. ------------- Commit messages: - 8350554: Harden X509CertImpl.getExtensionValue for NPE cases Changes: https://git.openjdk.org/jdk24u/pull/88/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=88&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350554 Stats: 267 lines in 3 files changed: 209 ins; 47 del; 11 mod Patch: https://git.openjdk.org/jdk24u/pull/88.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/88/head:pull/88 PR: https://git.openjdk.org/jdk24u/pull/88 From mbaesken at openjdk.org Mon Feb 24 08:58:58 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 24 Feb 2025 08:58:58 GMT Subject: [jdk24u] Integrated: 8349039: Adjust exception No type named in database In-Reply-To: <1J_feEGBIFDjWxGmoEOS3ZQnbH_hGd-Gvcn1KmILEcA=.96fd8cb3-465a-4ec9-8409-ea6baad050b1@github.com> References: <1J_feEGBIFDjWxGmoEOS3ZQnbH_hGd-Gvcn1KmILEcA=.96fd8cb3-465a-4ec9-8409-ea6baad050b1@github.com> Message-ID: <6dDfZ3W_0ZRZv4ufgs2JT-iNM6DipwVUWS3FhBugIeQ=.488cdc5c-9c1b-4f56-bb34-c2f1fc9831ff@github.com> On Fri, 21 Feb 2025 08:24:30 GMT, Matthias Baesken wrote: > 8349039: Adjust exception No type named in database This pull request has now been integrated. Changeset: 05d53715 Author: Matthias Baesken URL: https://git.openjdk.org/jdk24u/commit/05d53715cf301e5518d8796d4d9115cc90a9134c Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8349039: Adjust exception No type named in database Backport-of: 669f8c0c07b57fa00ac84b8a90c4a1a1459443e3 ------------- PR: https://git.openjdk.org/jdk24u/pull/86 From duke at openjdk.org Mon Feb 24 09:28:53 2025 From: duke at openjdk.org (PAWAN CHAWDHARY) Date: Mon, 24 Feb 2025 09:28:53 GMT Subject: [jdk24u] Integrated: 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out In-Reply-To: References: Message-ID: On Mon, 3 Feb 2025 11:17:48 GMT, PAWAN CHAWDHARY wrote: > 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out This pull request has now been integrated. Changeset: 924e7bb3 Author: pawan chawdhary Committer: Sean Coffey URL: https://git.openjdk.org/jdk24u/commit/924e7bb34fa79e98526f092221af660b8f29d0e3 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out Backport-of: 6b022bb64b2109c8cd40ebd3b8b3226cf894544d ------------- PR: https://git.openjdk.org/jdk24u/pull/42 From mbaesken at openjdk.org Mon Feb 24 09:30:12 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 24 Feb 2025 09:30:12 GMT Subject: [jdk21u-dev] RFR: 8349039: Adjust exception No type named in database Message-ID: 8349039: Adjust exception No type named in database ------------- Commit messages: - Backport 669f8c0c07b57fa00ac84b8a90c4a1a1459443e3 Changes: https://git.openjdk.org/jdk21u-dev/pull/1429/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1429&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349039 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1429.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1429/head:pull/1429 PR: https://git.openjdk.org/jdk21u-dev/pull/1429 From sroy at openjdk.org Mon Feb 24 09:56:01 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 24 Feb 2025 09:56:01 GMT Subject: [jdk21u-dev] Integrated: 8349729 : [21u] AIX jtreg tests fail to compile with qvisibility=hidden In-Reply-To: <-eorSrfLcZAAlwV-oN9XLLVi_D_4cTp9EPYGlt51HYU=.bd836d4e-69d3-4cfd-ae49-597eb2ac0628@github.com> References: <-eorSrfLcZAAlwV-oN9XLLVi_D_4cTp9EPYGlt51HYU=.bd836d4e-69d3-4cfd-ae49-597eb2ac0628@github.com> Message-ID: <_I5eOanntg5j-oLyqd_DayL-RrRS5J4M-dPj363AY0s=.1b14b889-94b8-47c9-b120-1d761ba11c26@github.com> On Thu, 20 Feb 2025 16:44:30 GMT, Suchismith Roy wrote: > JBS ISSUE : [JDK-8349729](https://bugs.openjdk.org/browse/JDK-8349729) This pull request has now been integrated. Changeset: 9c263232 Author: Suchismith Roy Committer: Amit Kumar URL: https://git.openjdk.org/jdk21u-dev/commit/9c26323271a4617b800b277a6afffe7c9a566db4 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod 8349729: [21u] AIX jtreg tests fail to compile with qvisibility=hidden Reviewed-by: goetz ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1425 From duke at openjdk.org Mon Feb 24 09:56:44 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 24 Feb 2025 09:56:44 GMT Subject: [jdk11u-dev] RFR: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class Message-ID: Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 17u that solves some accessibility issues on Windows, for parity with 11.0.27/28-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. The test does fail without this fix (when read-out, the short-cuts are truncated, so for instance the menu short-cut "Ctrl+Shift+Period" was read out as "Control plus Shift plus P", instead of "Control plus Shift plus Period". The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ). Clean but for an update in copyright header and for a multi-line string (that has been replaced) in `AccessBridge.java`. ------------- Commit messages: - Backport 01d107aea8eca4f4d2863deb30ac60e802debe15 Changes: https://git.openjdk.org/jdk11u-dev/pull/3001/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3001&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339728 Stats: 126 lines in 3 files changed: 115 ins; 5 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3001.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3001/head:pull/3001 PR: https://git.openjdk.org/jdk11u-dev/pull/3001 From duke at openjdk.org Mon Feb 24 10:25:00 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 24 Feb 2025 10:25:00 GMT Subject: [jdk11u-dev] RFR: 8339728: [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 09:51:09 GMT, Antonio Vieiro wrote: > Backport of [JDK-8339728](https://bugs.openjdk.org/browse/JDK-8339728) from 17u that solves some accessibility issues on Windows, for parity with 11.0.27/28-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk. > > The test does fail without this fix (when read-out, the short-cuts are truncated, so for instance the menu short-cut "Ctrl+Shift+Period" was read out as "Control plus Shift plus P", instead of "Control plus Shift plus Period". > > The new accessibility test passes on Windows 10 (tested with [JAWS v. 2025.2412.102 - February 2025](https://support.freedomscientific.com/Downloads/JAWS) ). > > Clean but for an update in copyright header and for a multi-line string (that has been replaced) in `AccessBridge.java`. test/jdk/javax/accessibility/TestJMenuItemShortcutAccessibility.java line 44: > 42: public class TestJMenuItemShortcutAccessibility { > 43: public static void main(String[] args) throws Exception { > 44: String INSTRUCTIONS = "" This one was a multiline String constant in JDK17 and above. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/3001#discussion_r1967358874 From goetz at openjdk.org Mon Feb 24 10:58:04 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 24 Feb 2025 10:58:04 GMT Subject: [jdk21u-dev] Integrated: 8327476: Upgrade JLine to 3.26.1 In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 09:37:11 GMT, Goetz Lindenmaier wrote: > I backport this change for parity with 21.0.7-oracle. > > It brings updates of upstream library jline 3.26.1 to jdk21. > Jdk21 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). > The original sources of jline 3.26.1 can be found here: > https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz > > The backport of this change needed larger adaptions. > > The original jline library dynamically selects how to access > the operating system in two means: > * Which operating system? linux, windows, mac? > * JDK functionality to do native calls: JNI, jna, ffm? > > The implementation in OpenJDK does this selection at JDK build time. > The code is split into more subdirectories for the operating systems. > One of the methods to call native is picked, the code for the others > is removed. Unfortunately this differs for the JDK releases: > * jdk21 uses jna. > * jdk23 uses ffm. > The original patch of this change includes all the edits to > replace jna by ffm. > > Further changes that fell into the eye during the backport > * jline changed the format of its Copyright header > * jline changed sorting of imports > * jline changed a lot of formatting, especially how > arguments to methods are listed. > * jline removed the `Stream` enum from `TerminalProvider.java` and moved it > into a class of its own: `SystemStream.java`. This makes changes to > import statements and argument lists necessary. > * OpenJDK added a new parameter `inputStreamWrapper` to the > functions which are also affected by the `Stream` enum change. > This also made changes to import statements and argument lists > necessary. > > OpenJDK 23 added jline to the list of modules needed for a jre. > I don't think we should do that in 21, so I omitted that change. > > jline 3.26.1 and OpenJDK 23 added a new method `systemStreamWidth() `to `TerminalProvider`. > I don't think we should extend the functionlaity of jline in 21, > so I omitted this. Also, I would need additional parts of the > jline windows files that are not yet included in OpenJDK to > implement this. > > For the backport, I dropped the following files from the patch: > ``` > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/CLibrary.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmNativePty.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ffm/FfmTerminalProvider.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/termina... This pull request has now been integrated. Changeset: d02ad341 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d02ad34144917a36911296b20ce28381ead3f601 Stats: 6858 lines in 126 files changed: 3024 ins; 1089 del; 2745 mod 8327476: Upgrade JLine to 3.26.1 Reviewed-by: mdoerr Backport-of: aaa90b3005c85852971203ce6feb88e7091e167b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1413 From duke at openjdk.org Mon Feb 24 11:19:05 2025 From: duke at openjdk.org (duke) Date: Mon, 24 Feb 2025 11:19:05 GMT Subject: [jdk11u-dev] RFR: 8306408: Fix the format of several tables in building.md In-Reply-To: References: Message-ID: On Tue, 20 Feb 2024 15:32:47 GMT, Zdenek Zambersky wrote: > Backport fixing several tables in `doc/building.md`, so they would display correctly in GitHub. Changes to `doc/building.html` were done manually, as there are some differences to table contents. Also table in `Oracle Solaris Studio` section was fixed, which is missing in newer jdks. > > File `doc/building.html` was regenerated (pandoc used was one [created by current jdk17u devkit](https://github.com/openjdk/jdk17u-dev/blob/3285292597efd34176465df0b0394cc4a99605eb/make/devkit/createPandocBundle.sh), as this one seems to have be used previously -> no unrelated format changes). > > Interestingly update of `doc/building.html` also removed one paragraph (about C99 standard). However, it turns out, this was accidentally included in [JDK-8226910](https://bugs.openjdk.org/browse/JDK-8226910) backport to jdk11u-dev. Paragraph is from [JDK-8224087](https://bugs.openjdk.org/browse/JDK-8224087), which has not been backported to jdk11u-dev. (So paragraph should never been there in first place.) @zzambers Your change (at version e3e1b2799cbb65e0a849988f824743d6cff2e9a1) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2533#issuecomment-2678111452 From goetz at openjdk.org Mon Feb 24 11:55:32 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 24 Feb 2025 11:55:32 GMT Subject: [jdk17u-dev] RFR: 8327476: Upgrade JLine to 3.26.1 [v2] In-Reply-To: References: Message-ID: > I backport this change for parity with 17.0.15-oracle. > > It brings updates of upstream library jline 3.26.1 to jdk17. > Jdk17 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). > The original sources of jline 3.26.1 can be found here: > https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz > > The backport of this change needed some adaptions. > > The original jline library dynamically selects how to access > the operating system in two means: > > Which operating system? linux, windows, mac? > JDK functionality to do native calls: JNI, jna, ffm? > > The implementation in OpenJDK does this selection at JDK build time. > The code is split into more subdirectories for the operating systems. > One of the methods to call native is picked, the code for the others > is removed. Unfortunately this differs for the JDK releases: > > jdk23 uses ffm. > jdk21 uses jna. > jdk17 uses jna on windows, "exec" on the remaining OSes. > > "[8306983](https://bugs.openjdk.org/browse/JDK-8306983): Do not invoke external programs when switch terminal to raw mode on selected platforms" > implemented the jna access for unix etc. in 21. > > Because of these differences I had to adapt the change when > backporting from 23 to 21, and now I need to do so again. > > I am basing my backport to 17 on the commit of this change in 21. > > First, I just drop the changes to the files not in 17 that were added by [8306983](https://bugs.openjdk.org/browse/JDK-8306983): > > aix/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java > linux/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java > linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/CLibrary.java > linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/LinuxNativePty.java > macosx/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java > macosx/classes/jdk/internal/org/jline/terminal/impl/jna/osx/CLibrary.java > macosx/classes/jdk/internal/org/jline/terminal/impl/jna/osx/OsXNativePty.java > unix/classes/jdk/internal/org/jline/terminal/impl/jna/JnaNativePty.java > unix/classes/jdk/internal/org/jline/terminal/impl/jna/JnaTerminalProvider.java > > > The remaining patch applied quite well, I only had to > resolve the following files: > > src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Buffer.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReader.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/BufferImpl.java > src/jdk.internal... Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Fix test that fails in agentvm mode (-avm) ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3292/files - new: https://git.openjdk.org/jdk17u-dev/pull/3292/files/7eebf01e..7f8f177a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3292&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3292&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3292.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3292/head:pull/3292 PR: https://git.openjdk.org/jdk17u-dev/pull/3292 From goetz at openjdk.org Mon Feb 24 12:59:11 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 24 Feb 2025 12:59:11 GMT Subject: [jdk17u-dev] RFR: 8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 02ea4b548ea1d5e96b9e59e2aa916d7728844116 Changes: https://git.openjdk.org/jdk17u-dev/pull/3294/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3294&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342635 Stats: 10 lines in 2 files changed: 0 ins; 5 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3294.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3294/head:pull/3294 PR: https://git.openjdk.org/jdk17u-dev/pull/3294 From goetz at openjdk.org Mon Feb 24 13:01:33 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 24 Feb 2025 13:01:33 GMT Subject: [jdk21u-dev] RFR: 8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir Message-ID: <_lMzfyNOIrdwE1EYCXrQLkeLsUtvPAN2HpTodGhOw1I=.7dd19f15-305b-4d8a-9a1d-1c9d5fdc1cae@github.com> I backport this for parity with 21.0.7-oracle. Also useful for 17. ------------- Commit messages: - Backport 02ea4b548ea1d5e96b9e59e2aa916d7728844116 Changes: https://git.openjdk.org/jdk21u-dev/pull/1430/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1430&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342635 Stats: 10 lines in 2 files changed: 0 ins; 5 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1430.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1430/head:pull/1430 PR: https://git.openjdk.org/jdk21u-dev/pull/1430 From duke at openjdk.org Mon Feb 24 13:01:08 2025 From: duke at openjdk.org (duke) Date: Mon, 24 Feb 2025 13:01:08 GMT Subject: [jdk24u] RFR: 8348936: [Accessibility, macOS, VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS In-Reply-To: References: Message-ID: On Fri, 21 Feb 2025 05:07:33 GMT, Abhishek Kumar wrote: > Hi all, > > This pull request contains a backport of commit [1e87ff01](https://github.com/openjdk/jdk/commit/1e87ff01994df16df7de331040fc5d7a4a85f630) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Abhishek Kumar on 20 Feb 2025 and was reviewed by Alexey Ivanov, Alexander Zuev, Damon Nguyen and Artem Semenov. > > Thanks! @kumarabhi006 Your change (at version 37ba3173e9c6898d636ee98de8cf8b42808857d6) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/85#issuecomment-2678345639 From goetz at openjdk.org Mon Feb 24 13:06:36 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 24 Feb 2025 13:06:36 GMT Subject: [jdk17u-dev] RFR: 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport f6e7713bb653811423eeb2515c2f69b437750326 Changes: https://git.openjdk.org/jdk17u-dev/pull/3295/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3295&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339356 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3295.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3295/head:pull/3295 PR: https://git.openjdk.org/jdk17u-dev/pull/3295 From goetz at openjdk.org Mon Feb 24 13:08:37 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 24 Feb 2025 13:08:37 GMT Subject: [jdk21u-dev] RFR: 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine Message-ID: I backport this for parity with 21.0.8-oracle ------------- Commit messages: - Backport f6e7713bb653811423eeb2515c2f69b437750326 Changes: https://git.openjdk.org/jdk21u-dev/pull/1431/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1431&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339356 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1431.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1431/head:pull/1431 PR: https://git.openjdk.org/jdk21u-dev/pull/1431 From fferrari at openjdk.org Mon Feb 24 15:03:06 2025 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Mon, 24 Feb 2025 15:03:06 GMT Subject: [jdk11u-dev] RFR: 8026976: ECParameters, Point does not match field size In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 16:39:36 GMT, Severin Gehwolf wrote: >> Hi all, >> >> This is a backport of JDK-8026976: ECParameters, Point does not match field size >> >> Original patch apply cleanly to 11u. >> >> Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing >> >> Thanks. > > @martinuy @franferrax Could you please take a look at this backport and see if that makes sense to bring to 11u at this stage of where 11u is currently? Thanks! @jerboaa: in my view this is a minor and clean backport. 11u already contains e6e820c6474e3608abe4e08698097d06dda2900e, which is partial/incomplete without this change. I agree that the risk is low considering this affects _SunPKCS11_, a security provider that is disabled by default. The test removed from `ProblemList.txt` (`sun/security/pkcs11/ec/TestKeyFactory.java`) is now passing (I checked this in a local slowdebug build of this PR code). This test fails with the current version of NSS and without this PR change, meaning this bug may be being hit by users: java.security.spec.InvalidKeySpecException: Could not parse key at jdk.crypto.cryptoki/sun.security.pkcs11.P11ECKeyFactory.implGetPublicKeySpec(P11ECKeyFactory.java:300) at jdk.crypto.cryptoki/sun.security.pkcs11.P11KeyFactory.engineGetKeySpec(P11KeyFactory.java:94) at java.base/java.security.KeyFactory.getKeySpec(KeyFactory.java:433) at TestKeyFactory.testPublic(TestKeyFactory.java:83) at TestKeyFactory.test(TestKeyFactory.java:117) at TestKeyFactory.main(TestKeyFactory.java:146) at PKCS11Test.premain(PKCS11Test.java:907) at PKCS11Test.testNSS(PKCS11Test.java:605) at PKCS11Test.main(PKCS11Test.java:254) at TestKeyFactory.main(TestKeyFactory.java:124) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.io.IOException: Point does not match field size at java.base/sun.security.util.ECUtil.decodePoint(ECUtil.java:48) at jdk.crypto.cryptoki/sun.security.pkcs11.P11ECKeyFactory.decodePoint(P11ECKeyFactory.java:89) at jdk.crypto.cryptoki/sun.security.pkcs11.P11ECKeyFactory.implGetPublicKeySpec(P11ECKeyFactory.java:297) ... 15 more ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2958#issuecomment-2678716263 From fferrari at openjdk.org Mon Feb 24 15:03:07 2025 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Mon, 24 Feb 2025 15:03:07 GMT Subject: [jdk11u-dev] RFR: 8026976: ECParameters, Point does not match field size In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 07:15:55 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8026976: ECParameters, Point does not match field size > > Original patch apply cleanly to 11u. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11ECKeyFactory.java line 2: > 1: /* > 2: * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved. @jerboaa: is it generally acceptable to downgrade the copyright year? Should we leave 2021 untouched? Should we update to 2025? ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2958#discussion_r1967818787 From sgehwolf at openjdk.org Mon Feb 24 15:27:03 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 24 Feb 2025 15:27:03 GMT Subject: [jdk11u-dev] RFR: 8026976: ECParameters, Point does not match field size In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 16:39:36 GMT, Severin Gehwolf wrote: >> Hi all, >> >> This is a backport of JDK-8026976: ECParameters, Point does not match field size >> >> Original patch apply cleanly to 11u. >> >> Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing >> >> Thanks. > > @martinuy @franferrax Could you please take a look at this backport and see if that makes sense to bring to 11u at this stage of where 11u is currently? Thanks! > @jerboaa: in my view this is a minor and clean backport. 11u already contains [e6e820c](https://github.com/openjdk/jdk11u-dev/commit/e6e820c6474e3608abe4e08698097d06dda2900e), which is partial/incomplete without this change. > > I agree that the risk is low considering this affects _SunPKCS11_, a security provider that is disabled by default. > > The test removed from `ProblemList.txt` (`sun/security/pkcs11/ec/TestKeyFactory.java`) is now passing (I checked this in a local slowdebug build of this PR code). This test fails with the current version of NSS and without this PR change, meaning this bug may be being hit by users: > > ``` > java.security.spec.InvalidKeySpecException: Could not parse key > at jdk.crypto.cryptoki/sun.security.pkcs11.P11ECKeyFactory.implGetPublicKeySpec(P11ECKeyFactory.java:300) > at jdk.crypto.cryptoki/sun.security.pkcs11.P11KeyFactory.engineGetKeySpec(P11KeyFactory.java:94) > at java.base/java.security.KeyFactory.getKeySpec(KeyFactory.java:433) > at TestKeyFactory.testPublic(TestKeyFactory.java:83) > at TestKeyFactory.test(TestKeyFactory.java:117) > at TestKeyFactory.main(TestKeyFactory.java:146) > at PKCS11Test.premain(PKCS11Test.java:907) > at PKCS11Test.testNSS(PKCS11Test.java:605) > at PKCS11Test.main(PKCS11Test.java:254) > at TestKeyFactory.main(TestKeyFactory.java:124) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:566) > at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138) > at java.base/java.lang.Thread.run(Thread.java:829) > Caused by: java.io.IOException: Point does not match field size > at java.base/sun.security.util.ECUtil.decodePoint(ECUtil.java:48) > at jdk.crypto.cryptoki/sun.security.pkcs11.P11ECKeyFactory.decodePoint(P11ECKeyFactory.java:89) > at jdk.crypto.cryptoki/sun.security.pkcs11.P11ECKeyFactory.implGetPublicKeySpec(P11ECKeyFactory.java:297) > ... 15 more > ``` OK, thanks. That's helpful. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2958#issuecomment-2678791417 From sgehwolf at openjdk.org Mon Feb 24 15:27:03 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 24 Feb 2025 15:27:03 GMT Subject: [jdk11u-dev] RFR: 8026976: ECParameters, Point does not match field size In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 14:59:47 GMT, Francisco Ferrari Bihurriet wrote: >> Hi all, >> >> This is a backport of JDK-8026976: ECParameters, Point does not match field size >> >> Original patch apply cleanly to 11u. >> >> Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing >> >> Thanks. > > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11ECKeyFactory.java line 2: > >> 1: /* >> 2: * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved. > > @jerboaa: is it generally acceptable to downgrade the copyright year? Should we leave 2021 untouched? Should we update to 2025? No. If the existing copyright date is newer we usually leave it alone. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2958#discussion_r1967866751 From nbenalla at openjdk.org Mon Feb 24 15:31:39 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Mon, 24 Feb 2025 15:31:39 GMT Subject: [jdk24u] RFR: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools Message-ID: Hi all, This pull request contains a backport of commit [53db5764](https://github.com/openjdk/jdk/commit/53db57648a09c4c380064eea11fcdb680011d741) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Nizar Benalla on 20 Feb 2025 and was reviewed by Erik Joelsson. Thanks! ------------- Commit messages: - Backport 53db57648a09c4c380064eea11fcdb680011d741 Changes: https://git.openjdk.org/jdk24u/pull/89/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=89&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350137 Stats: 9 lines in 2 files changed: 7 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk24u/pull/89.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/89/head:pull/89 PR: https://git.openjdk.org/jdk24u/pull/89 From zzambers at openjdk.org Mon Feb 24 15:33:11 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 24 Feb 2025 15:33:11 GMT Subject: [jdk11u-dev] Integrated: 8306408: Fix the format of several tables in building.md In-Reply-To: References: Message-ID: On Tue, 20 Feb 2024 15:32:47 GMT, Zdenek Zambersky wrote: > Backport fixing several tables in `doc/building.md`, so they would display correctly in GitHub. Changes to `doc/building.html` were done manually, as there are some differences to table contents. Also table in `Oracle Solaris Studio` section was fixed, which is missing in newer jdks. > > File `doc/building.html` was regenerated (pandoc used was one [created by current jdk17u devkit](https://github.com/openjdk/jdk17u-dev/blob/3285292597efd34176465df0b0394cc4a99605eb/make/devkit/createPandocBundle.sh), as this one seems to have be used previously -> no unrelated format changes). > > Interestingly update of `doc/building.html` also removed one paragraph (about C99 standard). However, it turns out, this was accidentally included in [JDK-8226910](https://bugs.openjdk.org/browse/JDK-8226910) backport to jdk11u-dev. Paragraph is from [JDK-8224087](https://bugs.openjdk.org/browse/JDK-8224087), which has not been backported to jdk11u-dev. (So paragraph should never been there in first place.) This pull request has now been integrated. Changeset: 659a4669 Author: Zdenek Zambersky Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/659a4669208645420e151e78ab5fd3ac3808b310 Stats: 130 lines in 2 files changed: 0 ins; 1 del; 129 mod 8306408: Fix the format of several tables in building.md Reviewed-by: andrew Backport-of: 26755a968665545a151adce79a5227c79724bb6b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2533 From goetz at openjdk.org Mon Feb 24 15:34:32 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 24 Feb 2025 15:34:32 GMT Subject: [jdk17u-dev] RFR: 8198666: Many java/awt/Modal/OnTop/ test fails on mac Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport dbcf38932ef4f87b560ec660851368ac5697f4da Changes: https://git.openjdk.org/jdk17u-dev/pull/3296/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3296&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8198666 Stats: 30 lines in 1 file changed: 0 ins; 30 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3296.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3296/head:pull/3296 PR: https://git.openjdk.org/jdk17u-dev/pull/3296 From goetz at openjdk.org Mon Feb 24 15:57:12 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 24 Feb 2025 15:57:12 GMT Subject: [jdk21u-dev] RFR: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS Message-ID: I backport this for parity with 21.0.8-oracle Not problem listed in 21, thus omitted PL change. ------------- Commit messages: - Backport 0d30b869d8be831bfc5ff5511b3a42900e4c22a4 Changes: https://git.openjdk.org/jdk21u-dev/pull/1432/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1432&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344581 Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1432.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1432/head:pull/1432 PR: https://git.openjdk.org/jdk21u-dev/pull/1432 From goetz at openjdk.org Mon Feb 24 15:58:05 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 24 Feb 2025 15:58:05 GMT Subject: [jdk17u-dev] RFR: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS Message-ID: I backport this for parity with 17.0.15-oracle. Not problem listed in 17, thus omitted PL change. I will make this depend on 21 once pushed, and I assume it will turn out clean. ------------- Commit messages: - Backport 0d30b869d8be831bfc5ff5511b3a42900e4c22a4 Changes: https://git.openjdk.org/jdk17u-dev/pull/3297/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3297&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344581 Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3297.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3297/head:pull/3297 PR: https://git.openjdk.org/jdk17u-dev/pull/3297 From mdoerr at openjdk.org Mon Feb 24 16:23:54 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 24 Feb 2025 16:23:54 GMT Subject: [jdk17u-dev] RFR: 8327476: Upgrade JLine to 3.26.1 [v2] In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 11:55:32 GMT, Goetz Lindenmaier wrote: >> I backport this change for parity with 17.0.15-oracle. >> >> It brings updates of upstream library jline 3.26.1 to jdk17. >> Jdk17 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). >> The original sources of jline 3.26.1 can be found here: >> https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz >> >> The backport of this change needed some adaptions. >> >> The original jline library dynamically selects how to access >> the operating system in two means: >> >> Which operating system? linux, windows, mac? >> JDK functionality to do native calls: JNI, jna, ffm? >> >> The implementation in OpenJDK does this selection at JDK build time. >> The code is split into more subdirectories for the operating systems. >> One of the methods to call native is picked, the code for the others >> is removed. Unfortunately this differs for the JDK releases: >> >> jdk23 uses ffm. >> jdk21 uses jna. >> jdk17 uses jna on windows, "exec" on the remaining OSes. >> >> "[8306983](https://bugs.openjdk.org/browse/JDK-8306983): Do not invoke external programs when switch terminal to raw mode on selected platforms" >> implemented the jna access for unix etc. in 21. >> >> Because of these differences I had to adapt the change when >> backporting from 23 to 21, and now I need to do so again. >> >> I am basing my backport to 17 on the commit of this change in 21. >> >> First, I just drop the changes to the files not in 17 that were added by [8306983](https://bugs.openjdk.org/browse/JDK-8306983): >> >> aix/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java >> linux/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java >> linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/CLibrary.java >> linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/LinuxNativePty.java >> macosx/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java >> macosx/classes/jdk/internal/org/jline/terminal/impl/jna/osx/CLibrary.java >> macosx/classes/jdk/internal/org/jline/terminal/impl/jna/osx/OsXNativePty.java >> unix/classes/jdk/internal/org/jline/terminal/impl/jna/JnaNativePty.java >> unix/classes/jdk/internal/org/jline/terminal/impl/jna/JnaTerminalProvider.java >> >> >> The remaining patch applied quite well, I only had to >> resolve the following files: >> >> src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Buffer.java >> src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReader.java >>... > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Fix test that fails in agentvm mode (-avm) Your modifications look reasonable. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3292#pullrequestreview-2637716477 From sgehwolf at openjdk.org Mon Feb 24 16:26:56 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 24 Feb 2025 16:26:56 GMT Subject: [jdk11u-dev] RFR: 8350469: [11u] Backport JDK-8239429 to jdk11u-dev In-Reply-To: References: Message-ID: <0WoSsGrKuzQ42k0FQBaGEgJot9-bPiV6mZuTVLeittY=.6fa548f6-e703-414f-84de-bdd9bbca4110@github.com> On Mon, 17 Feb 2025 08:14:35 GMT, SendaoYan wrote: > Hi all, > > We observed test build/AbsPathsInImage.java fails which has been recorded by https://github.com/dragonwell-project/dragonwell11/issues/934, and this backport can fix the test bug which cause the test failure. > > The test bug which cause this test failure has been fixed by JDK-8239429. But JDK-8239429 is invisible cause JDK-8239429 can not backported directly. So I create a new issue to fix the test bug in jdk11u-dev. > > Clean backport to fix the test bug, change has been verified locally, test-fix only, no risk. LGTM. Please update the PR title as I've updated the JBS synopsis. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2997#pullrequestreview-2637723461 From syan at openjdk.org Mon Feb 24 16:32:00 2025 From: syan at openjdk.org (SendaoYan) Date: Mon, 24 Feb 2025 16:32:00 GMT Subject: [jdk11u-dev] RFR: 8350469: [11u] Test AbsPathsInImage.java fails - JDK-8239429 public clone In-Reply-To: <0WoSsGrKuzQ42k0FQBaGEgJot9-bPiV6mZuTVLeittY=.6fa548f6-e703-414f-84de-bdd9bbca4110@github.com> References: <0WoSsGrKuzQ42k0FQBaGEgJot9-bPiV6mZuTVLeittY=.6fa548f6-e703-414f-84de-bdd9bbca4110@github.com> Message-ID: On Mon, 24 Feb 2025 16:23:49 GMT, Severin Gehwolf wrote: > LGTM. Please update the PR title as I've updated the JBS synopsis. Thanks @jerboaa ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2997#issuecomment-2679007074 From abhiscxk at openjdk.org Mon Feb 24 16:40:01 2025 From: abhiscxk at openjdk.org (Abhishek Kumar) Date: Mon, 24 Feb 2025 16:40:01 GMT Subject: [jdk24u] Integrated: 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS In-Reply-To: References: Message-ID: On Fri, 21 Feb 2025 05:07:33 GMT, Abhishek Kumar wrote: > Hi all, > > This pull request contains a backport of commit [1e87ff01](https://github.com/openjdk/jdk/commit/1e87ff01994df16df7de331040fc5d7a4a85f630) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Abhishek Kumar on 20 Feb 2025 and was reviewed by Alexey Ivanov, Alexander Zuev, Damon Nguyen and Artem Semenov. > > Thanks! This pull request has now been integrated. Changeset: ab9a2fd3 Author: Abhishek Kumar Committer: Alexey Ivanov URL: https://git.openjdk.org/jdk24u/commit/ab9a2fd3439dda603883c73f5341e589b6e3af23 Stats: 133 lines in 2 files changed: 130 ins; 0 del; 3 mod 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS 8345728: [Accessibility,macOS,Screen Magnifier]: JCheckbox unchecked state does not magnify but works for checked state Backport-of: 1e87ff01994df16df7de331040fc5d7a4a85f630 ------------- PR: https://git.openjdk.org/jdk24u/pull/85 From duke at openjdk.org Mon Feb 24 17:25:03 2025 From: duke at openjdk.org (duke) Date: Mon, 24 Feb 2025 17:25:03 GMT Subject: [jdk24u] RFR: 8347377: Add validation checks for ICC_Profile header fields In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 17:46:25 GMT, Harshitha Onkar wrote: > Hi all, > > This pull request contains a backport of commit [ed8945a6](https://github.com/openjdk/jdk/commit/ed8945a68a67dd51a7cfa332905941afccc12b36) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Harshitha Onkar on 6 Feb 2025 and was reviewed by Phil Race and Jayathirth D V. > > Thanks! @honkar-jdk Your change (at version fb0729fec5fdb869390f0cc5abf02dbc5cf16ab5) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/82#issuecomment-2679159038 From honkar at openjdk.org Mon Feb 24 17:31:17 2025 From: honkar at openjdk.org (Harshitha Onkar) Date: Mon, 24 Feb 2025 17:31:17 GMT Subject: [jdk24u] Integrated: 8347377: Add validation checks for ICC_Profile header fields In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 17:46:25 GMT, Harshitha Onkar wrote: > Hi all, > > This pull request contains a backport of commit [ed8945a6](https://github.com/openjdk/jdk/commit/ed8945a68a67dd51a7cfa332905941afccc12b36) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Harshitha Onkar on 6 Feb 2025 and was reviewed by Phil Race and Jayathirth D V. > > Thanks! This pull request has now been integrated. Changeset: f8b84a9e Author: Harshitha Onkar Committer: Alexander Zvegintsev URL: https://git.openjdk.org/jdk24u/commit/f8b84a9e2a344a116f7569e105b46d165f87c289 Stats: 327 lines in 4 files changed: 325 ins; 0 del; 2 mod 8347377: Add validation checks for ICC_Profile header fields Backport-of: ed8945a68a67dd51a7cfa332905941afccc12b36 ------------- PR: https://git.openjdk.org/jdk24u/pull/82 From fferrari at openjdk.org Mon Feb 24 18:01:27 2025 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Mon, 24 Feb 2025 18:01:27 GMT Subject: [jdk11u-dev] RFR: 8026976: ECParameters, Point does not match field size In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 15:23:49 GMT, Severin Gehwolf wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11ECKeyFactory.java line 2: >> >>> 1: /* >>> 2: * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved. >> >> @jerboaa: is it generally acceptable to downgrade the copyright year? Should we leave 2021 untouched? Should we update to 2025? > > No. If the existing copyright date is newer we usually leave it alone. So @kurashige23, could you please revert it back to 2021? According to openjdk/skara#1556, the Skara bot should still consider the backport clean. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2958#discussion_r1968142978 From abakhtin at openjdk.org Mon Feb 24 23:42:17 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 24 Feb 2025 23:42:17 GMT Subject: [jdk17u-dev] RFR: 8342075: HttpClient: improve HTTP/2 flow control checks Message-ID: <7BgKKZjq9D8VTW-4Os3ZN_jZOocnVJ1V7mZfYFbeAG4=.ace32bc6-b847-4db6-825e-24135875eefe@github.com> Please review backport of JDK-8342075 The backport is not clean: - src/java.net.http/share/classes/module-info.java skip these changes because there are no java.net.http configuration properties definitions in the file. It was added by JDK-8296804 in JDK20 but not backported - src/java.net.http/share/classes/jdk/internal/net/http/Stream.java Comments are not added into Stream::incoming() method because of no JDK-8298340 in JDK17 - src/java.net.http/share/classes/jdk/internal/net/http/WindowUpdateSender.java manual merge because of differences in the import section caused by JDK-8308310 - src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java Add Http2Connection.java::isOpen method. It was added by 8254786 in JDK19 - test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchange.java and test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchangeImpl.java and test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java are updated from 8335181 with getConnectionKey() implementation ------------- Commit messages: - Use Executor to shutdown httpClient - Backport b0ac633b2d0076d64b463b2a6ce19abf6b12c50f Changes: https://git.openjdk.org/jdk17u-dev/pull/3298/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3298&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342075 Stats: 1058 lines in 14 files changed: 1026 ins; 1 del; 31 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3298.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3298/head:pull/3298 PR: https://git.openjdk.org/jdk17u-dev/pull/3298 From fyang at openjdk.org Tue Feb 25 01:58:34 2025 From: fyang at openjdk.org (Fei Yang) Date: Tue, 25 Feb 2025 01:58:34 GMT Subject: [jdk24u] RFR: 8346832: runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java fails on RISC-V Message-ID: Hi all, This pull request contains a backport of commit [de025036](https://github.com/openjdk/jdk/commit/de0250368edbf4e9bebf326778f8f8773b69b84c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Fei Yang on 7 Jan 2025 and was reviewed by Thomas Stuefe and Feilong Jiang. Thanks! ------------- Commit messages: - Backport de0250368edbf4e9bebf326778f8f8773b69b84c Changes: https://git.openjdk.org/jdk24u/pull/90/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=90&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346832 Stats: 15 lines in 2 files changed: 0 ins; 12 del; 3 mod Patch: https://git.openjdk.org/jdk24u/pull/90.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/90/head:pull/90 PR: https://git.openjdk.org/jdk24u/pull/90 From syan at openjdk.org Tue Feb 25 03:25:18 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 25 Feb 2025 03:25:18 GMT Subject: [jdk24u] RFR: 8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails Message-ID: Hi all, This pull request contains a backport of commit [a51e6699](https://github.com/openjdk/jdk/commit/a51e6699b497564de65620a36dc38437ca87cb32) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 5 Feb 2025 and was reviewed by Naoto Sato and Justin Lu. Thanks! ------------- Commit messages: - Backport a51e6699b497564de65620a36dc38437ca87cb32 Changes: https://git.openjdk.org/jdk24u/pull/91/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=91&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349200 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk24u/pull/91.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/91/head:pull/91 PR: https://git.openjdk.org/jdk24u/pull/91 From duke at openjdk.org Tue Feb 25 06:04:34 2025 From: duke at openjdk.org (Konanki Sreenath) Date: Tue, 25 Feb 2025 06:04:34 GMT Subject: [jdk24u] RFR: 8350554: Harden X509CertImpl.getExtensionValue for NPE cases [v2] In-Reply-To: References: Message-ID: > Earlier code will trigger NPE if the certificate does not contain the extensions or if the requested extensions does not exist. The better approach for hardening getExtensionValue here is to to check for NULL explicitly before calling getExtensionValue() and avoding try-catch block which ensures the readability and maintainability. > > After scanning in multiple places where invokng getExtensions on the X509CertInfo reference, the check for NULL is added in the getKeyUsage() as well while calling before getExtensionValue() > > The associated tests are written and added in test class CertificateExtensions. Which will ensure to validate the > getExtensionValue() and getKeyUsage() methods in X509CertImpl class. Konanki Sreenath has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 70a6c0b7ac952eebdffa1d64399cd0ee1efec1f6 ------------- Changes: - all: https://git.openjdk.org/jdk24u/pull/88/files - new: https://git.openjdk.org/jdk24u/pull/88/files/2fcfe10f..8030273c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk24u&pr=88&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk24u&pr=88&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk24u/pull/88.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/88/head:pull/88 PR: https://git.openjdk.org/jdk24u/pull/88 From mbaesken at openjdk.org Tue Feb 25 08:32:05 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 25 Feb 2025 08:32:05 GMT Subject: [jdk21u-dev] RFR: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 15:51:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle > > Not problem listed in 21, thus omitted PL change. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1432#pullrequestreview-2640079906 From mbaesken at openjdk.org Tue Feb 25 09:05:58 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 25 Feb 2025 09:05:58 GMT Subject: [jdk17u-dev] RFR: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 15:51:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > Not problem listed in 17, thus omitted PL change. > I will make this depend on 21 once pushed, and I assume it will turn out clean. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3297#pullrequestreview-2640188887 From goetz at openjdk.org Tue Feb 25 12:17:24 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 12:17:24 GMT Subject: [jdk21u-dev] RFR: 8350650: Bump update version for OpenJDK: jdk-21.0.8 Message-ID: Required change in 21. ------------- Commit messages: - 8350650: Bump update version for OpenJDK: jdk-21.0.8 Changes: https://git.openjdk.org/jdk21u-dev/pull/1433/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1433&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350650 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1433.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1433/head:pull/1433 PR: https://git.openjdk.org/jdk21u-dev/pull/1433 From goetz at openjdk.org Tue Feb 25 13:08:35 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 13:08:35 GMT Subject: [jdk17u-dev] RFR: 8350651: Bump update version for OpenJDK: jdk-17.0.16 Message-ID: Required for next release. ------------- Commit messages: - 8350651: Bump update version for OpenJDK: jdk-17.0.16 Changes: https://git.openjdk.org/jdk17u-dev/pull/3299/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3299&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350651 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3299.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3299/head:pull/3299 PR: https://git.openjdk.org/jdk17u-dev/pull/3299 From mbaesken at openjdk.org Tue Feb 25 13:31:58 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 25 Feb 2025 13:31:58 GMT Subject: [jdk21u-dev] Integrated: 8349039: Adjust exception No type named in database In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 09:25:24 GMT, Matthias Baesken wrote: > 8349039: Adjust exception No type named in database This pull request has now been integrated. Changeset: 335b2f56 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/335b2f569f01643922485effe35872fd39a67e6f Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8349039: Adjust exception No type named in database Backport-of: 669f8c0c07b57fa00ac84b8a90c4a1a1459443e3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1429 From mbaesken at openjdk.org Tue Feb 25 13:58:05 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 25 Feb 2025 13:58:05 GMT Subject: [jdk24u] Integrated: 8349150: Support precompiled headers on AIX In-Reply-To: <6qBfLiBWycLxeHmh2GUT0ZURLuFXX3BqabNxmqrLzOQ=.fdfc67f2-be0d-4c16-9ca5-262bf6e46553@github.com> References: <6qBfLiBWycLxeHmh2GUT0ZURLuFXX3BqabNxmqrLzOQ=.fdfc67f2-be0d-4c16-9ca5-262bf6e46553@github.com> Message-ID: On Wed, 19 Feb 2025 09:02:14 GMT, Matthias Baesken wrote: > 8349150: Support precompiled headers on AIX This pull request has now been integrated. Changeset: 2d22e13b Author: Matthias Baesken URL: https://git.openjdk.org/jdk24u/commit/2d22e13bb1569fc231798797efb36f0463360443 Stats: 16 lines in 2 files changed: 7 ins; 6 del; 3 mod 8349150: Support precompiled headers on AIX Backport-of: beae8843b9b2433af5e9fbe420b17e663cbdb960 ------------- PR: https://git.openjdk.org/jdk24u/pull/80 From goetz at openjdk.org Tue Feb 25 14:06:06 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 14:06:06 GMT Subject: [jdk21u-dev] RFR: 8331735: UpcallLinker::on_exit races with GC when copying frame anchor In-Reply-To: References: Message-ID: <-jK2vUjMIUSOPPztQ-ejoHuZvVZwqE-xO4UOvhhLtDg=.dfed7484-1cf6-46ee-b3be-e52a2bc2a8cc@github.com> On Thu, 20 Feb 2025 16:23:03 GMT, Andrew John Hughes wrote: > Clean backport of a fix for a race condition in code adapted from `JavaCallWrapper` for the FFM API. This is more visible in 22 and later, where FFM is fully supported and the [OpenType implementation using HarfBuzz](https://bugs.openjdk.org/browse/JDK-8318364) has been ported to use it. However, the copy in the native state seems to have been introduced as far back as [JDK-8269240](https://bugs.openjdk.org/browse/JDK-8269240) in 17 when the `JavaCallWrapper` code was ported to what was then `universalUpcallHandler.cpp`. @gnu-andrew, you might want to push this, today 18:00 CET the last automatic merge from jdk21u-dev to jdk21u will happen. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1424#issuecomment-2682081349 From goetz at openjdk.org Tue Feb 25 14:20:01 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 14:20:01 GMT Subject: [jdk21u-dev] RFR: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered [v3] In-Reply-To: References: Message-ID: On Fri, 21 Feb 2025 21:17:08 GMT, Alexey Bakhtin wrote: >> Clean backport of JDK-8317808 >> >> All jtreg tests for java.net.httpclient are passed > > Alexey Bakhtin has updated the pull request incrementally with three additional commits since the last revision: > > - Revert "Backport fc98998627443d6e73ac70661f47f48b30525712" > > This reverts commit 899abf76e7a381abdfbc30f08a6a5678c0a8065d. > - Revert "Backport 720b44648bcff997278af92746f942b2425298a5" > > This reverts commit a5b7bb4d432c868d598c35f54306e40747071ad7. > - Revert "Remove extra import" > > This reverts commit 480336754274ea62ab2e9b076dcec91f7d483c25. @alexeybakhtin , please push by 1800 CET today as that is the last time for the merge from jdk21u-dev to jdk21u ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1426#issuecomment-2682124098 From clanger at openjdk.org Tue Feb 25 14:54:01 2025 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 25 Feb 2025 14:54:01 GMT Subject: [jdk21u-dev] RFR: 8350650: Bump update version for OpenJDK: jdk-21.0.8 In-Reply-To: References: Message-ID: On Tue, 25 Feb 2025 12:12:48 GMT, Goetz Lindenmaier wrote: > Required change in 21. Marked as reviewed by clanger (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1433#pullrequestreview-2641379028 From clanger at openjdk.org Tue Feb 25 15:03:55 2025 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 25 Feb 2025 15:03:55 GMT Subject: [jdk17u-dev] RFR: 8350651: Bump update version for OpenJDK: jdk-17.0.16 In-Reply-To: References: Message-ID: On Tue, 25 Feb 2025 13:02:26 GMT, Goetz Lindenmaier wrote: > Required for next release. Marked as reviewed by clanger (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3299#pullrequestreview-2641414148 From goetz at openjdk.org Tue Feb 25 16:13:08 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 16:13:08 GMT Subject: [jdk21u-dev] Integrated: 8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir In-Reply-To: <_lMzfyNOIrdwE1EYCXrQLkeLsUtvPAN2HpTodGhOw1I=.7dd19f15-305b-4d8a-9a1d-1c9d5fdc1cae@github.com> References: <_lMzfyNOIrdwE1EYCXrQLkeLsUtvPAN2HpTodGhOw1I=.7dd19f15-305b-4d8a-9a1d-1c9d5fdc1cae@github.com> Message-ID: <7o1WL_e9skLvPwAjpv5Ks56Kh5SSjKiXy-_Gfxk-iaA=.ee3f1e73-d263-4ed7-96b9-87cab0cf0b39@github.com> On Mon, 24 Feb 2025 12:55:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. Also useful for 17. This pull request has now been integrated. Changeset: 68ad8435 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/68ad8435c173bc86e066642fc33301a2ace174dd Stats: 10 lines in 2 files changed: 0 ins; 5 del; 5 mod 8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir 8342634: javax/imageio/plugins/wbmp/WBMPStreamTruncateTest.java creates temp file in src dir Backport-of: 02ea4b548ea1d5e96b9e59e2aa916d7728844116 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1430 From goetz at openjdk.org Tue Feb 25 16:13:59 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 16:13:59 GMT Subject: [jdk21u-dev] Integrated: 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 13:02:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle This pull request has now been integrated. Changeset: 2f9840c2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/2f9840c24b018f6b4c37b69805a7ffe688648b04 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine Backport-of: f6e7713bb653811423eeb2515c2f69b437750326 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1431 From goetz at openjdk.org Tue Feb 25 16:14:01 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 16:14:01 GMT Subject: [jdk17u-dev] RFR: 8327476: Upgrade JLine to 3.26.1 [v2] In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 11:55:32 GMT, Goetz Lindenmaier wrote: >> I backport this change for parity with 17.0.15-oracle. >> >> It brings updates of upstream library jline 3.26.1 to jdk17. >> Jdk17 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). >> The original sources of jline 3.26.1 can be found here: >> https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz >> >> The backport of this change needed some adaptions. >> >> The original jline library dynamically selects how to access >> the operating system in two means: >> >> Which operating system? linux, windows, mac? >> JDK functionality to do native calls: JNI, jna, ffm? >> >> The implementation in OpenJDK does this selection at JDK build time. >> The code is split into more subdirectories for the operating systems. >> One of the methods to call native is picked, the code for the others >> is removed. Unfortunately this differs for the JDK releases: >> >> jdk23 uses ffm. >> jdk21 uses jna. >> jdk17 uses jna on windows, "exec" on the remaining OSes. >> >> "[8306983](https://bugs.openjdk.org/browse/JDK-8306983): Do not invoke external programs when switch terminal to raw mode on selected platforms" >> implemented the jna access for unix etc. in 21. >> >> Because of these differences I had to adapt the change when >> backporting from 23 to 21, and now I need to do so again. >> >> I am basing my backport to 17 on the commit of this change in 21. >> >> First, I just drop the changes to the files not in 17 that were added by [8306983](https://bugs.openjdk.org/browse/JDK-8306983): >> >> aix/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java >> linux/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java >> linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/CLibrary.java >> linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/LinuxNativePty.java >> macosx/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java >> macosx/classes/jdk/internal/org/jline/terminal/impl/jna/osx/CLibrary.java >> macosx/classes/jdk/internal/org/jline/terminal/impl/jna/osx/OsXNativePty.java >> unix/classes/jdk/internal/org/jline/terminal/impl/jna/JnaNativePty.java >> unix/classes/jdk/internal/org/jline/terminal/impl/jna/JnaTerminalProvider.java >> >> >> The remaining patch applied quite well, I only had to >> resolve the following files: >> >> src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Buffer.java >> src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReader.java >>... > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Fix test that fails in agentvm mode (-avm) Thanks for reviewing! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3292#issuecomment-2682528957 From goetz at openjdk.org Tue Feb 25 16:15:03 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 16:15:03 GMT Subject: [jdk17u-dev] Integrated: 8198666: Many java/awt/Modal/OnTop/ test fails on mac In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 15:29:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: fbf5ebe1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/fbf5ebe12f0c70b528a372dcab60d20af70a55e0 Stats: 30 lines in 1 file changed: 0 ins; 30 del; 0 mod 8198666: Many java/awt/Modal/OnTop/ test fails on mac Backport-of: dbcf38932ef4f87b560ec660851368ac5697f4da ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3296 From goetz at openjdk.org Tue Feb 25 16:17:04 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 16:17:04 GMT Subject: [jdk21u-dev] Integrated: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 15:51:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle > > Not problem listed in 21, thus omitted PL change. This pull request has now been integrated. Changeset: 951453e9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/951453e9f0a46d114b801986f29cb0fe1179e130 Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS Reviewed-by: mbaesken Backport-of: 0d30b869d8be831bfc5ff5511b3a42900e4c22a4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1432 From goetz at openjdk.org Tue Feb 25 16:17:06 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 16:17:06 GMT Subject: [jdk17u-dev] Integrated: 8327476: Upgrade JLine to 3.26.1 In-Reply-To: References: Message-ID: On Sat, 22 Feb 2025 19:21:58 GMT, Goetz Lindenmaier wrote: > I backport this change for parity with 17.0.15-oracle. > > It brings updates of upstream library jline 3.26.1 to jdk17. > Jdk17 currently includes jline 3.22.0, see [JDK-8297587](https://bugs.openjdk.org/browse/JDK-8297587). > The original sources of jline 3.26.1 can be found here: > https://github.com/jline/jline3/archive/refs/tags/jline-parent-3.26.1.tar.gz > > The backport of this change needed some adaptions. > > The original jline library dynamically selects how to access > the operating system in two means: > > Which operating system? linux, windows, mac? > JDK functionality to do native calls: JNI, jna, ffm? > > The implementation in OpenJDK does this selection at JDK build time. > The code is split into more subdirectories for the operating systems. > One of the methods to call native is picked, the code for the others > is removed. Unfortunately this differs for the JDK releases: > > jdk23 uses ffm. > jdk21 uses jna. > jdk17 uses jna on windows, "exec" on the remaining OSes. > > "[8306983](https://bugs.openjdk.org/browse/JDK-8306983): Do not invoke external programs when switch terminal to raw mode on selected platforms" > implemented the jna access for unix etc. in 21. > > Because of these differences I had to adapt the change when > backporting from 23 to 21, and now I need to do so again. > > I am basing my backport to 17 on the commit of this change in 21. > > First, I just drop the changes to the files not in 17 that were added by [8306983](https://bugs.openjdk.org/browse/JDK-8306983): > > aix/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java > linux/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java > linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/CLibrary.java > linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/LinuxNativePty.java > macosx/classes/jdk/internal/org/jline/terminal/impl/jna/JDKNativePty.java > macosx/classes/jdk/internal/org/jline/terminal/impl/jna/osx/CLibrary.java > macosx/classes/jdk/internal/org/jline/terminal/impl/jna/osx/OsXNativePty.java > unix/classes/jdk/internal/org/jline/terminal/impl/jna/JnaNativePty.java > unix/classes/jdk/internal/org/jline/terminal/impl/jna/JnaTerminalProvider.java > > > The remaining patch applied quite well, I only had to > resolve the following files: > > src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Buffer.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReader.java > src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/BufferImpl.java > src/jdk.internal... This pull request has now been integrated. Changeset: bb391d7a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/bb391d7a3656eda8864b777a9561a9e7e71a47a9 Stats: 6144 lines in 117 files changed: 2859 ins; 1016 del; 2269 mod 8327476: Upgrade JLine to 3.26.1 Reviewed-by: mdoerr Backport-of: d02ad34144917a36911296b20ce28381ead3f601 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3292 From goetz at openjdk.org Tue Feb 25 16:17:57 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 16:17:57 GMT Subject: [jdk17u-dev] Integrated: 8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir In-Reply-To: References: Message-ID: <9Dq2OAYPu5SQmBkGIVTpaM5552ja_CarJXYCMRZ_xJ8=.012977fd-b389-4bc7-9590-1f4bdc570c43@github.com> On Mon, 24 Feb 2025 12:55:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: db37be36 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/db37be367455f846b11c3e2134969410acb2e1c8 Stats: 10 lines in 2 files changed: 0 ins; 5 del; 5 mod 8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir 8342634: javax/imageio/plugins/wbmp/WBMPStreamTruncateTest.java creates temp file in src dir Backport-of: 02ea4b548ea1d5e96b9e59e2aa916d7728844116 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3294 From goetz at openjdk.org Tue Feb 25 16:20:14 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 16:20:14 GMT Subject: [jdk17u-dev] Integrated: 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine In-Reply-To: References: Message-ID: <6jHJr2d3hsD_jVB1Vzs06lIvN_aGXR9XQziihnzxPN0=.22106d29-b730-41e4-a2ee-eba7a034742f@github.com> On Mon, 24 Feb 2025 13:02:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: 16b21465 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/16b21465012eb608f96b46ee6e8a5dc0e0bcef3c Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine Backport-of: f6e7713bb653811423eeb2515c2f69b437750326 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3295 From goetz at openjdk.org Tue Feb 25 16:21:00 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 16:21:00 GMT Subject: [jdk17u-dev] Integrated: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 15:51:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > Not problem listed in 17, thus omitted PL change. > I will make this depend on 21 once pushed, and I assume it will turn out clean. This pull request has now been integrated. Changeset: 4216ad64 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/4216ad64d0029940f40fc5cea2672b7485722adc Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS Reviewed-by: mbaesken Backport-of: 0d30b869d8be831bfc5ff5511b3a42900e4c22a4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3297 From goetz at openjdk.org Tue Feb 25 16:21:56 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 16:21:56 GMT Subject: [jdk17u-dev] Integrated: 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 14:51:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.16-oracle. This pull request has now been integrated. Changeset: 117ce560 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/117ce5601bbc60a3b01723a4eaed477190550e1b Stats: 204 lines in 4 files changed: 91 ins; 22 del; 91 mod 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland Backport-of: 6f4fc82149b52dd91289fe42def7d1cacad31212 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3289 From goetz at openjdk.org Tue Feb 25 16:22:59 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 25 Feb 2025 16:22:59 GMT Subject: [jdk17u-dev] Integrated: 8302111: Serialization considerations In-Reply-To: References: Message-ID: On Mon, 17 Feb 2025 16:39:14 GMT, Goetz Lindenmaier wrote: > I backport this to match 17.0.13-oracle based on the commit to 21. > > I had to resolve several files, two of them considerably: > > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java > Resolved larger chunk. > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java > Resolved some code. > > The new code in DHPublic/PrivateKey depends on the removal > of IOExceptions in [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) "DerOutputStream operations should not throw IOExceptions". > This change is in 21 but not in 17. Thus code backported from 21 calls functions of > DerOutputStream that do not throw an exception in 21, but do so in 17. > JDK-8297065 makes the point that these exceptions can never be thrown, which also > holds for 17. So I just catch and ignore them. > > Also, I had to adapt code because an exception constructor with cause for > InvalidObjectException is missing in 17. > This was added by [JDK-8282696](https://bugs.openjdk.org/browse/JDK-8282696) "Add constructors taking a cause > to InvalidObjectException and InvalidClassException" in 19. > I added a call to initCause() to store the causing exception. > > I double-checked that [JDK-8297065](https://bugs.openjdk.org/browse/JDK-8297065) was not backported > by Oracle. Backporting this change would simplify matters considerably. > > The remaining files only needed trivial resolves: > > src/java.base/share/classes/java/security/Permissions.java > src/java.base/share/classes/java/security/SignedObject.java > Only Copyright. > src/java.base/share/classes/java/security/Timestamp.java > Copyright and import. > src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java > src/java.base/share/classes/java/security/cert/CertificateRevokedException.java > src/java.base/share/classes/sun/security/provider/DRBG.java > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > src/java.base/share/classes/sun/security/x509/AlgIdDSA.java > Only Copyright. > src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Context.java > Resolved imports. > src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecureRandom.java > Only Copyright. > > I manually ran these tests on linux x86_64: > > test/jdk/com/sun/security > test/jdk/java/awt/security > test/jdk/java/net/httpclient/security > test/jdk/java/net/httpclient/websocket/security > test/jdk/java/security > test/jdk/javax/management/security > test/jdk/javax/security > t... This pull request has now been integrated. Changeset: ae0177b6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ae0177b6abc1c4b3755ec446f2f35ad2616107a9 Stats: 1092 lines in 21 files changed: 602 ins; 339 del; 151 mod 8302111: Serialization considerations Reviewed-by: rrich Backport-of: 369c573383a0120e0d85aeb89a211f38b5261013 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3278 From aoqi at openjdk.org Tue Feb 25 16:29:15 2025 From: aoqi at openjdk.org (Ao Qi) Date: Tue, 25 Feb 2025 16:29:15 GMT Subject: [jdk24u] RFR: 8350499: Minimal build fails with slowdebug builds Message-ID: Hi all, This pull request contains a backport of commit [302bed05](https://github.com/openjdk/jdk/commit/302bed055c3b4881f97c584d5953273b9dbc2969) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Ao Qi on 24 Feb 2025 and was reviewed by Kim Barrett and David Holmes. The backport is clean and solves corner case build issues. Risk is low. Thanks! ------------- Commit messages: - Backport 302bed055c3b4881f97c584d5953273b9dbc2969 Changes: https://git.openjdk.org/jdk24u/pull/92/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=92&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350499 Stats: 6 lines in 1 file changed: 5 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk24u/pull/92.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/92/head:pull/92 PR: https://git.openjdk.org/jdk24u/pull/92 From abakhtin at openjdk.org Tue Feb 25 16:47:55 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 25 Feb 2025 16:47:55 GMT Subject: [jdk21u-dev] Integrated: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered In-Reply-To: References: Message-ID: On Fri, 21 Feb 2025 00:44:32 GMT, Alexey Bakhtin wrote: > Clean backport of JDK-8317808 > > All jtreg tests for java.net.httpclient are passed This pull request has now been integrated. Changeset: 58069061 Author: Alexey Bakhtin URL: https://git.openjdk.org/jdk21u-dev/commit/580690614f3e27660feeccd89a3691de266bcbc3 Stats: 29 lines in 4 files changed: 22 ins; 4 del; 3 mod 8317808: HTTP/2 stream cancelImpl may leave subscriber registered Backport-of: 6273ab97dc1a0d3c1f51ba94694d9594dd7593d4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1426 From abakhtin at openjdk.org Tue Feb 25 16:53:56 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 25 Feb 2025 16:53:56 GMT Subject: [jdk21u-dev] RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2] In-Reply-To: References: Message-ID: > Please review the backport of JDK-8342075 > > Almost clean backport except for the import section of src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java > > Requires JDK-8317808 [1] as a prerequisite to fixing the hanging of the new tests. > > Also, new tests require Http2TestExchange::getConnectionKey() method added by JDK-8335181 [2]. > > test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchange.java, test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchangeImpl.java and test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java test classes are updated to add getConnectionKey() implementation > > All jtreg tests for java.net.httpclient are passed > > [1] - https://github.com/openjdk/jdk21u-dev/pull/1426 > [2] - https://github.com/openjdk/jdk/commit/720b44648bcff997278af92746f942b2425298a5#diff-c18c2a070038409f25c08e13c174a95f33840e2deddcc29f6d8306de572a618b Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1428/files - new: https://git.openjdk.org/jdk21u-dev/pull/1428/files/ec9d0ca6..ec9d0ca6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1428&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1428&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1428.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1428/head:pull/1428 PR: https://git.openjdk.org/jdk21u-dev/pull/1428 From abakhtin at openjdk.org Tue Feb 25 20:22:35 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 25 Feb 2025 20:22:35 GMT Subject: [jdk21u-dev] RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v3] In-Reply-To: References: Message-ID: > Please review the backport of JDK-8342075 > > Almost clean backport except for the import section of src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java > > Requires JDK-8317808 [1] as a prerequisite to fixing the hanging of the new tests. > > Also, new tests require Http2TestExchange::getConnectionKey() method added by JDK-8335181 [2]. > > test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchange.java, test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchangeImpl.java and test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java test classes are updated to add getConnectionKey() implementation > > All jtreg tests for java.net.httpclient are passed > > [1] - https://github.com/openjdk/jdk21u-dev/pull/1426 > [2] - https://github.com/openjdk/jdk/commit/720b44648bcff997278af92746f942b2425298a5#diff-c18c2a070038409f25c08e13c174a95f33840e2deddcc29f6d8306de572a618b Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: - Merge master - Add Http2TestExchange::getConnectionKey() from JDK-8335181 - Backport b0ac633b2d0076d64b463b2a6ce19abf6b12c50f - Revert "Backport fc98998627443d6e73ac70661f47f48b30525712" This reverts commit 899abf76e7a381abdfbc30f08a6a5678c0a8065d. - Revert "Backport 720b44648bcff997278af92746f942b2425298a5" This reverts commit a5b7bb4d432c868d598c35f54306e40747071ad7. - Revert "Remove extra import" This reverts commit 480336754274ea62ab2e9b076dcec91f7d483c25. - Backport 6273ab97dc1a0d3c1f51ba94694d9594dd7593d4 - Remove extra import - Backport 720b44648bcff997278af92746f942b2425298a5 - Backport fc98998627443d6e73ac70661f47f48b30525712 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1428/files - new: https://git.openjdk.org/jdk21u-dev/pull/1428/files/ec9d0ca6..247e11ea Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1428&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1428&range=01-02 Stats: 7134 lines in 139 files changed: 3142 ins; 1131 del; 2861 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1428.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1428/head:pull/1428 PR: https://git.openjdk.org/jdk21u-dev/pull/1428 From abakhtin at openjdk.org Tue Feb 25 20:25:02 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 25 Feb 2025 20:25:02 GMT Subject: [jdk21u-dev] RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2] In-Reply-To: References: Message-ID: On Tue, 25 Feb 2025 16:53:56 GMT, Alexey Bakhtin wrote: >> Please review the backport of JDK-8342075 >> >> Almost clean backport except for the import section of src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java >> >> Requires JDK-8317808 [1] as a prerequisite to fixing the hanging of the new tests. >> >> Also, new tests require Http2TestExchange::getConnectionKey() method added by JDK-8335181 [2]. >> >> test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchange.java, test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchangeImpl.java and test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java test classes are updated to add getConnectionKey() implementation >> >> All jtreg tests for java.net.httpclient are passed >> >> [1] - https://github.com/openjdk/jdk21u-dev/pull/1426 >> [2] - https://github.com/openjdk/jdk/commit/720b44648bcff997278af92746f942b2425298a5#diff-c18c2a070038409f25c08e13c174a95f33840e2deddcc29f6d8306de572a618b > > Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. CSR is submitted : https://bugs.openjdk.org/browse/JDK-8350611 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1428#issuecomment-2683199556 From dhanalla at openjdk.org Tue Feb 25 20:50:11 2025 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Tue, 25 Feb 2025 20:50:11 GMT Subject: [jdk24u] RFR: 8348323: Corrupted timezone string in JVM crash log Message-ID: Add a error check to "wcstombs" otherwise the "buf" prints junk or corrupted string. Test performed: "jcmd < jvm pid > VM.info" for different JVM versions ------------- Commit messages: - Backport 2bef5b4a877f4d3bc766558b8782b7b57dee79a8 Changes: https://git.openjdk.org/jdk24u/pull/93/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=93&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348323 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk24u/pull/93.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/93/head:pull/93 PR: https://git.openjdk.org/jdk24u/pull/93 From duke at openjdk.org Tue Feb 25 23:29:33 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Tue, 25 Feb 2025 23:29:33 GMT Subject: [jdk11u-dev] RFR: 8026976: ECParameters, Point does not match field size [v2] In-Reply-To: References: Message-ID: > Hi all, > > This is a backport of JDK-8026976: ECParameters, Point does not match field size > > Original patch apply cleanly to 11u. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8026976 - Backport 55f5542ca2104df91e14693534cc7b3c36e81953 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2958/files - new: https://git.openjdk.org/jdk11u-dev/pull/2958/files/bb5ed9cd..131868b3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2958&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2958&range=00-01 Stats: 5012 lines in 116 files changed: 2894 ins; 784 del; 1334 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2958.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2958/head:pull/2958 PR: https://git.openjdk.org/jdk11u-dev/pull/2958 From duke at openjdk.org Tue Feb 25 23:35:47 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Tue, 25 Feb 2025 23:35:47 GMT Subject: [jdk11u-dev] RFR: 8026976: ECParameters, Point does not match field size [v3] In-Reply-To: References: Message-ID: > Hi all, > > This is a backport of JDK-8026976: ECParameters, Point does not match field size > > Original patch apply cleanly to 11u. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: Fix copyright year ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2958/files - new: https://git.openjdk.org/jdk11u-dev/pull/2958/files/131868b3..f019f2d4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2958&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2958&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2958.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2958/head:pull/2958 PR: https://git.openjdk.org/jdk11u-dev/pull/2958 From duke at openjdk.org Tue Feb 25 23:35:48 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Tue, 25 Feb 2025 23:35:48 GMT Subject: [jdk11u-dev] RFR: 8026976: ECParameters, Point does not match field size [v3] In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 17:58:17 GMT, Francisco Ferrari Bihurriet wrote: >> No. If the existing copyright date is newer we usually leave it alone. > > So @kurashige23, could you please revert it back to 2021? According to openjdk/skara#1556, the Skara bot should still consider the backport clean. I fixed it. Thank you for your review. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2958#discussion_r1970685820 From duke at openjdk.org Tue Feb 25 23:48:40 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Tue, 25 Feb 2025 23:48:40 GMT Subject: [jdk11u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts [v5] In-Reply-To: References: Message-ID: > Hi, > > This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts > > Original patch does not apply cleanly for the following reasons: > > ?Fix to getOsMap() in test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied since getOsMap() was removed in https://bugs.openjdk.org/browse/JDK-8331700. > ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in [https://bugs.openjdk.org/browse/JDK-8220753](https://bugs.openjdk.org/browse/JDK-8220753%28jdk13%29) (jdk13). > ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed in https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge branch 'openjdk:master' into backport-8296631 - Replace pkcs11/fips/key4.db and pkcs11.txt - Merge branch 'openjdk:master' into backport-8296631 - Merge branch 'openjdk:master' into backport-8296631 - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2955/files - new: https://git.openjdk.org/jdk11u-dev/pull/2955/files/7c28df67..9c87a3cb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2955&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2955&range=03-04 Stats: 4949 lines in 113 files changed: 2854 ins; 776 del; 1319 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2955.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2955/head:pull/2955 PR: https://git.openjdk.org/jdk11u-dev/pull/2955 From syan at openjdk.org Wed Feb 26 02:46:17 2025 From: syan at openjdk.org (SendaoYan) Date: Wed, 26 Feb 2025 02:46:17 GMT Subject: [jdk24u] RFR: 8339889: Several compiler tests ignore vm flags and not marked as flagless Message-ID: Hi all, This pull request contains a backport of commit [829d7a84](https://github.com/openjdk/jdk/commit/829d7a845e18ec483379abf3a3fccb596d899f25) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Leonid Mesnik on 25 Feb 2025 and was reviewed by Tobias Hartmann. Thanks! ------------- Commit messages: - Backport 829d7a845e18ec483379abf3a3fccb596d899f25 Changes: https://git.openjdk.org/jdk24u/pull/94/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=94&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339889 Stats: 8 lines in 4 files changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk24u/pull/94.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/94/head:pull/94 PR: https://git.openjdk.org/jdk24u/pull/94 From duke at openjdk.org Wed Feb 26 07:52:39 2025 From: duke at openjdk.org (toshiogata) Date: Wed, 26 Feb 2025 07:52:39 GMT Subject: [jdk11u-dev] RFR: 8328379: Convert URLDragTest.html applet test to main In-Reply-To: <0baFntlJOMTTWrgxm7dWhutzj0ILvOEyt-HlMrLyO8E=.c9fb333b-74c3-48c4-9ae8-3c25e909baf5@github.com> References: <0baFntlJOMTTWrgxm7dWhutzj0ILvOEyt-HlMrLyO8E=.c9fb333b-74c3-48c4-9ae8-3c25e909baf5@github.com> Message-ID: On Wed, 26 Feb 2025 07:45:13 GMT, toshiogata wrote: > Hi all, > > I would like to backport this patch to improve test maintainability. The patch is not clean. A text block needs to be replaced with string literals. > Testing: manually checked URLDragTest.java, and confirmed that the test works in the same way. > > Thank you. GHA report 1 test failure on macos-x64 * serviceability/sa/ClhsdbFindPC.java#id1 This test failure occurs frequently in recent GHA runs, and is not related to this fix. Perhaps related issue for this failure is https://bugs.openjdk.org/browse/JDK-8253028 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3002#issuecomment-2684190224 From duke at openjdk.org Wed Feb 26 07:52:39 2025 From: duke at openjdk.org (toshiogata) Date: Wed, 26 Feb 2025 07:52:39 GMT Subject: [jdk11u-dev] RFR: 8328379: Convert URLDragTest.html applet test to main Message-ID: <0baFntlJOMTTWrgxm7dWhutzj0ILvOEyt-HlMrLyO8E=.c9fb333b-74c3-48c4-9ae8-3c25e909baf5@github.com> Hi all, I would like to backport this patch to improve test maintainability. The patch is not clean. A text block needs to be replaced with string literals. Testing: manually checked URLDragTest.java, and confirmed that the test works in the same way. Thank you. ------------- Commit messages: - Merge branch 'master' into JDK-8328379 - Replace a text block with string literals - Backport fbeac98c84078a566c572abeba07c49e94bbf26b Changes: https://git.openjdk.org/jdk11u-dev/pull/3002/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3002&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328379 Stats: 226 lines in 3 files changed: 93 ins; 133 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3002.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3002/head:pull/3002 PR: https://git.openjdk.org/jdk11u-dev/pull/3002 From goetz at openjdk.org Wed Feb 26 08:17:02 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 26 Feb 2025 08:17:02 GMT Subject: [jdk21u-dev] Integrated: 8350650: Bump update version for OpenJDK: jdk-21.0.8 In-Reply-To: References: Message-ID: On Tue, 25 Feb 2025 12:12:48 GMT, Goetz Lindenmaier wrote: > Required change in 21. This pull request has now been integrated. Changeset: 4159e888 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/4159e888ca33db26703483c6c9d64a28221eda4a Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8350650: Bump update version for OpenJDK: jdk-21.0.8 Reviewed-by: clanger ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1433 From goetz at openjdk.org Wed Feb 26 08:31:58 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 26 Feb 2025 08:31:58 GMT Subject: [jdk17u-dev] Integrated: 8350651: Bump update version for OpenJDK: jdk-17.0.16 In-Reply-To: References: Message-ID: On Tue, 25 Feb 2025 13:02:26 GMT, Goetz Lindenmaier wrote: > Required for next release. This pull request has now been integrated. Changeset: fd353e38 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/fd353e38a820eed00b1a5f28e892a4d6baa3f1d1 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8350651: Bump update version for OpenJDK: jdk-17.0.16 Reviewed-by: clanger ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3299 From jbachorik at openjdk.org Wed Feb 26 11:18:45 2025 From: jbachorik at openjdk.org (Jaroslav Bachorik) Date: Wed, 26 Feb 2025 11:18:45 GMT Subject: [jdk11u-dev] RFR: 8315380: AsyncGetCallTrace crash in frame::safe_for_sender Message-ID: This change is fixing the problem in `frame_aarch64.cpp`, function `safe_for_sender`, where we have this code bool unextended_sp_safe = unextended_sp < thread->stack_base(); While this captures one possibility of not being safe, it omits the check for `unextended_sp` falling within the stack space. The proposed change then is bool unextended_sp_safe = (unextended_sp < thread->stack_base() && \ sp >= thread->stack_base() - thread->stack_size()); This is actually just making sure the behaviour is the same as in JDK 15+ (since [JDK-8238988](https://bugs.openjdk.org/browse/JDK-8238988)) where the `unextended_sp` is checked for being within the stack limits. The change is not accompanied by a JTReg test because I was not able to craft one triggering the issue reliably. Existing tests from tier1-tier4 were run on a linux-aarch64 system with no new failures observed. ------------- Commit messages: - 8315380: AsyncGetCallTrace crash in frame::safe_for_sender Changes: https://git.openjdk.org/jdk11u-dev/pull/3003/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3003&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315380 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3003.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3003/head:pull/3003 PR: https://git.openjdk.org/jdk11u-dev/pull/3003 From fyang at openjdk.org Wed Feb 26 11:57:04 2025 From: fyang at openjdk.org (Fei Yang) Date: Wed, 26 Feb 2025 11:57:04 GMT Subject: [jdk24u] Integrated: 8346832: runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java fails on RISC-V In-Reply-To: References: Message-ID: On Tue, 25 Feb 2025 01:52:09 GMT, Fei Yang wrote: > Hi all, > > This pull request contains a backport of commit [de025036](https://github.com/openjdk/jdk/commit/de0250368edbf4e9bebf326778f8f8773b69b84c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fei Yang on 7 Jan 2025 and was reviewed by Thomas Stuefe and Feilong Jiang. > > Thanks! This pull request has now been integrated. Changeset: a0bee88a Author: Fei Yang URL: https://git.openjdk.org/jdk24u/commit/a0bee88a19399a69b97b90cc7877aba85e4f7c96 Stats: 15 lines in 2 files changed: 0 ins; 12 del; 3 mod 8346832: runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java fails on RISC-V Backport-of: de0250368edbf4e9bebf326778f8f8773b69b84c ------------- PR: https://git.openjdk.org/jdk24u/pull/90 From duke at openjdk.org Wed Feb 26 12:13:08 2025 From: duke at openjdk.org (duke) Date: Wed, 26 Feb 2025 12:13:08 GMT Subject: [jdk24u] RFR: 8350499: Minimal build fails with slowdebug builds In-Reply-To: References: Message-ID: On Tue, 25 Feb 2025 16:23:22 GMT, Ao Qi wrote: > Hi all, > > This pull request contains a backport of commit [302bed05](https://github.com/openjdk/jdk/commit/302bed055c3b4881f97c584d5953273b9dbc2969) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Ao Qi on 24 Feb 2025 and was reviewed by Kim Barrett and David Holmes. > > The backport is clean and solves corner case build issues. Risk is low. > > Thanks! @theaoqi Your change (at version 991c20da9177177597fb2cdbeafc039b8ace0e3c) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/92#issuecomment-2684781245 From syan at openjdk.org Wed Feb 26 12:14:09 2025 From: syan at openjdk.org (SendaoYan) Date: Wed, 26 Feb 2025 12:14:09 GMT Subject: [jdk24u] Integrated: 8349943: [JMH] Use jvmArgs consistently In-Reply-To: References: Message-ID: <6sBeAMEccblznKgWQb6QZuxSznegjPnPCIq6HkQKlwo=.27466671-fe80-47b2-9dbb-1edd207dd8c4@github.com> On Thu, 20 Feb 2025 08:17:55 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [3ebed783](https://github.com/openjdk/jdk/commit/3ebed78328bd64d2e18369d63d6ea323b87a7b24) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Nicole Xu on 20 Feb 2025 and was reviewed by SendaoYan, Claes Redestad and Hao Sun. > > Thanks! This pull request has now been integrated. Changeset: bbecbaf7 Author: SendaoYan URL: https://git.openjdk.org/jdk24u/commit/bbecbaf7b915551f3bcd5fe9839d991ff5f6723c Stats: 20 lines in 9 files changed: 2 ins; 0 del; 18 mod 8349943: [JMH] Use jvmArgs consistently Backport-of: 3ebed78328bd64d2e18369d63d6ea323b87a7b24 ------------- PR: https://git.openjdk.org/jdk24u/pull/83 From syan at openjdk.org Wed Feb 26 12:14:09 2025 From: syan at openjdk.org (SendaoYan) Date: Wed, 26 Feb 2025 12:14:09 GMT Subject: [jdk24u] RFR: 8349943: [JMH] Use jvmArgs consistently In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 08:17:55 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [3ebed783](https://github.com/openjdk/jdk/commit/3ebed78328bd64d2e18369d63d6ea323b87a7b24) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Nicole Xu on 20 Feb 2025 and was reviewed by SendaoYan, Claes Redestad and Hao Sun. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/83#issuecomment-2684782540 From ssarathi at openjdk.org Wed Feb 26 13:54:14 2025 From: ssarathi at openjdk.org (Sorna Sarathi N) Date: Wed, 26 Feb 2025 13:54:14 GMT Subject: [jdk21u-dev] RFR: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11 In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 16:14:00 GMT, Goetz Lindenmaier wrote: >> Hi all, >> This pull request contains a backport of commit [3251eea](https://github.com/openjdk/jdk/commit/3251eea1f4289a0505052be204407c02ca38b0ad) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> Tier1 testing is successful. >> Thanks! >> >> JBS Issue: [JDK-8336499](https://bugs.openjdk.org/browse/JDK-8336499) > > Hi @Sorna-Sarathi, > I still would like to see some more testing. Removing the label in the meantime. Same for 17. > Also please check the failures in the Pre-submit tests. Hi @GoeLin, I had tested Tier 2 level tests for this change and it ended with few failures. I also checked with them and they're not related to the current backport changes. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1021#issuecomment-2685069911 From ssarathi at openjdk.org Wed Feb 26 13:59:13 2025 From: ssarathi at openjdk.org (Sorna Sarathi N) Date: Wed, 26 Feb 2025 13:59:13 GMT Subject: [jdk17u-dev] RFR: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11 In-Reply-To: <_8aB5QsHCNeMop1bjiLVgDN2Y-h78HKc6k_TQcb0f0o=.573348a8-f93f-49c4-9026-bbb8b41a3f38@github.com> References: <_8aB5QsHCNeMop1bjiLVgDN2Y-h78HKc6k_TQcb0f0o=.573348a8-f93f-49c4-9026-bbb8b41a3f38@github.com> Message-ID: On Mon, 21 Oct 2024 05:14:28 GMT, Sorna Sarathi N wrote: > Hi all, > This pull request contains a backport of commit [3251eea](https://github.com/openjdk/jdk/commit/3251eea1f4289a0505052be204407c02ca38b0ad) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > I've also resolved a build failure with the latest version of gtest(In JDK17) by backporting the [fix](https://github.com/openjdk/jdk17u-dev/pull/2959). > Thanks! > > JBS Issue: [JDK-8336499](https://bugs.openjdk.org/browse/JDK-8336499) Hi @GoeLin, I had tested Tier 2 level tests for this change and it ended with few failures. I also checked with them and they're not related to the current backport changes. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2979#issuecomment-2685101077 From nbenalla at openjdk.org Wed Feb 26 14:28:58 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Wed, 26 Feb 2025 14:28:58 GMT Subject: [jdk24u] RFR: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools In-Reply-To: References: Message-ID: <6twYGbmTEX1i7SB3GVN1utQcFjR7qK6Bsv5AwQRqG58=.cdf6bd99-5f20-453a-a583-95de00807bb7@github.com> On Mon, 24 Feb 2025 15:26:12 GMT, Nizar Benalla wrote: > Hi all, > > This pull request contains a backport of commit [53db5764](https://github.com/openjdk/jdk/commit/53db57648a09c4c380064eea11fcdb680011d741) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Nizar Benalla on 20 Feb 2025 and was reviewed by Erik Joelsson. > > Thanks! this clean backport will require a sponsor ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/89#issuecomment-2685180917 From duke at openjdk.org Wed Feb 26 14:28:58 2025 From: duke at openjdk.org (duke) Date: Wed, 26 Feb 2025 14:28:58 GMT Subject: [jdk24u] RFR: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 15:26:12 GMT, Nizar Benalla wrote: > Hi all, > > This pull request contains a backport of commit [53db5764](https://github.com/openjdk/jdk/commit/53db57648a09c4c380064eea11fcdb680011d741) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Nizar Benalla on 20 Feb 2025 and was reviewed by Erik Joelsson. > > Thanks! @nizarbenalla Your change (at version 2c750ee449b214d5ac6975b0935f40b0aa2b59d5) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/89#issuecomment-2685182556 From duke at openjdk.org Wed Feb 26 15:02:14 2025 From: duke at openjdk.org (duke) Date: Wed, 26 Feb 2025 15:02:14 GMT Subject: [jdk24u] RFR: 8348323: Corrupted timezone string in JVM crash log In-Reply-To: References: Message-ID: On Tue, 25 Feb 2025 20:45:00 GMT, Dhamoder Nalla wrote: > Add a error check to "wcstombs" otherwise the "buf" prints junk or corrupted string. > > Test performed: > > "jcmd < jvm pid > VM.info" for different JVM versions @dhanalla Your change (at version fb408d6a6e6f797ec5938df0bf31ae0ebd9c185b) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/93#issuecomment-2685324206 From duke at openjdk.org Wed Feb 26 15:16:02 2025 From: duke at openjdk.org (duke) Date: Wed, 26 Feb 2025 15:16:02 GMT Subject: [jdk24u] RFR: 8348102: java/net/httpclient/HttpClientSNITest.java fails intermittently In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 10:17:37 GMT, kieran-farrell wrote: > 8348102: java/net/httpclient/HttpClientSNITest.java fails intermittently @kieran-farrell Your change (at version 937ada5537e5e59a30ba12277f9bd926cc2da445) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/84#issuecomment-2685366523 From duke at openjdk.org Wed Feb 26 17:15:02 2025 From: duke at openjdk.org (kieran-farrell) Date: Wed, 26 Feb 2025 17:15:02 GMT Subject: [jdk24u] Integrated: 8348102: java/net/httpclient/HttpClientSNITest.java fails intermittently In-Reply-To: References: Message-ID: <0GFNVhL9aAy9kLMxTIKPpZTAsnebL9_0hA_IPKbMRXU=.edab6518-d9ea-4acc-8995-36fb23268142@github.com> On Thu, 20 Feb 2025 10:17:37 GMT, kieran-farrell wrote: > 8348102: java/net/httpclient/HttpClientSNITest.java fails intermittently This pull request has now been integrated. Changeset: 6fb19bb1 Author: Kieran Farrell Committer: Paul Hohensee URL: https://git.openjdk.org/jdk24u/commit/6fb19bb1eff650168aeea81744ba4650fc15e11c Stats: 17 lines in 1 file changed: 5 ins; 9 del; 3 mod 8348102: java/net/httpclient/HttpClientSNITest.java fails intermittently Backport-of: 8cf0735839727300e446828f4f4a8ef6354a8c7a ------------- PR: https://git.openjdk.org/jdk24u/pull/84 From dhanalla at openjdk.org Wed Feb 26 17:19:01 2025 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Wed, 26 Feb 2025 17:19:01 GMT Subject: [jdk24u] Integrated: 8348323: Corrupted timezone string in JVM crash log In-Reply-To: References: Message-ID: On Tue, 25 Feb 2025 20:45:00 GMT, Dhamoder Nalla wrote: > Add a error check to "wcstombs" otherwise the "buf" prints junk or corrupted string. > > Test performed: > > "jcmd < jvm pid > VM.info" for different JVM versions This pull request has now been integrated. Changeset: 114f2e34 Author: Dhamoder Nalla Committer: Paul Hohensee URL: https://git.openjdk.org/jdk24u/commit/114f2e342c25afcd0839e1b6609f8bd28ed97002 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8348323: Corrupted timezone string in JVM crash log Backport-of: 2bef5b4a877f4d3bc766558b8782b7b57dee79a8 ------------- PR: https://git.openjdk.org/jdk24u/pull/93 From nbenalla at openjdk.org Wed Feb 26 17:19:13 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Wed, 26 Feb 2025 17:19:13 GMT Subject: [jdk24u] Integrated: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools In-Reply-To: References: Message-ID: <_LcBBDiFz7fOv9HtwmEbRDCmqfDlI4m3aFVp2-3r_JA=.c04b3adc-6be9-4ed9-811c-ee90f78b1b55@github.com> On Mon, 24 Feb 2025 15:26:12 GMT, Nizar Benalla wrote: > Hi all, > > This pull request contains a backport of commit [53db5764](https://github.com/openjdk/jdk/commit/53db57648a09c4c380064eea11fcdb680011d741) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Nizar Benalla on 20 Feb 2025 and was reviewed by Erik Joelsson. > > Thanks! This pull request has now been integrated. Changeset: ef35e669 Author: Nizar Benalla Committer: Paul Hohensee URL: https://git.openjdk.org/jdk24u/commit/ef35e66937108b56742e4f1b9faddf7379aed805 Stats: 9 lines in 2 files changed: 7 ins; 0 del; 2 mod 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools Backport-of: 53db57648a09c4c380064eea11fcdb680011d741 ------------- PR: https://git.openjdk.org/jdk24u/pull/89 From aoqi at openjdk.org Wed Feb 26 17:19:59 2025 From: aoqi at openjdk.org (Ao Qi) Date: Wed, 26 Feb 2025 17:19:59 GMT Subject: [jdk24u] Integrated: 8350499: Minimal build fails with slowdebug builds In-Reply-To: References: Message-ID: On Tue, 25 Feb 2025 16:23:22 GMT, Ao Qi wrote: > Hi all, > > This pull request contains a backport of commit [302bed05](https://github.com/openjdk/jdk/commit/302bed055c3b4881f97c584d5953273b9dbc2969) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Ao Qi on 24 Feb 2025 and was reviewed by Kim Barrett and David Holmes. > > The backport is clean and solves corner case build issues. Risk is low. > > Thanks! This pull request has now been integrated. Changeset: 1eed4ba9 Author: Ao Qi Committer: Paul Hohensee URL: https://git.openjdk.org/jdk24u/commit/1eed4ba9187bddec68ace5fa7740d01d8717ef83 Stats: 6 lines in 1 file changed: 5 ins; 1 del; 0 mod 8350499: Minimal build fails with slowdebug builds Backport-of: 302bed055c3b4881f97c584d5953273b9dbc2969 ------------- PR: https://git.openjdk.org/jdk24u/pull/92 From nbenalla at openjdk.org Wed Feb 26 17:29:06 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Wed, 26 Feb 2025 17:29:06 GMT Subject: [jdk24u] RFR: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 15:26:12 GMT, Nizar Benalla wrote: > Hi all, > > This pull request contains a backport of commit [53db5764](https://github.com/openjdk/jdk/commit/53db57648a09c4c380064eea11fcdb680011d741) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Nizar Benalla on 20 Feb 2025 and was reviewed by Erik Joelsson. > > Thanks! Thanks Paul. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/89#issuecomment-2685729190 From fferrari at openjdk.org Wed Feb 26 21:12:24 2025 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Wed, 26 Feb 2025 21:12:24 GMT Subject: [jdk11u-dev] RFR: 8328957: Update PKCS11Test.java to not use hardcoded path Message-ID: Hi, I would like to propose an openjdk/jdk at 16576b87b7267aaa99c41f77993287e3479577aa backport. I do this backport for parity with 11.0.26-oracle. The backport is clean. Also, this allows running _SunPKCS11_ tests more easily, without the need to make symlink workarounds to locate the NSS library inside a `/nss/lib` path. ### Testing * `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk11u-dev/actions/runs/13551011718)) * The failure in macos-x64 / test (hs/tier1 serviceability) / `serviceability/sa/ClhsdbFindPC.java#id1` is unrelated with PKCS11 test changes * `test/jdk/sun/security/pkcs11` * No regressions found against `jdk11u-dev/master` (currently: 659a4669208645420e151e78ab5fd3ac3808b310) ``` ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/sun/security/pkcs11 95 84 10 1 << ============================== TEST FAILURE ``` *
jtreg summary.txt comparison ```diff diff --git a/jdk11u-dev/pkcs11_regression/report/text/summary.txt b/jdk11u-dev-backport-8328957/pkcs11_regression/report/text/summary.txt index ec3301f..552b9d0 100644 --- a/jdk11u-dev/pkcs11_regression/report/text/summary.txt +++ b/jdk11u-dev-backport-8328957/pkcs11_regression/report/text/summary.txt @@ -1,98 +1,98 @@ sun/security/pkcs11/Cipher/CancelMultipart.java Passed. Execution successful sun/security/pkcs11/Cipher/EncryptionPadding.java Passed. Execution successful sun/security/pkcs11/Cipher/JNICheck.java Passed. Execution successful sun/security/pkcs11/Cipher/ReinitCipher.java Passed. Execution successful sun/security/pkcs11/Cipher/Test4512704.java Passed. Execution successful sun/security/pkcs11/Cipher/TestCICOWithGCM.java Passed. Execution successful sun/security/pkcs11/Cipher/TestCICOWithGCMAndAAD.java Passed. Execution successful sun/security/pkcs11/Cipher/TestChaChaPoly.java Passed. Execution successful sun/security/pkcs11/Cipher/TestChaChaPolyKAT.java Passed. Execution successful sun/security/pkcs11/Cipher/TestChaChaPolyNoReuse.java Passed. Execution successful sun/security/pkcs11/Cipher/TestChaChaPolyOutputSize.java Passed. Execution successful sun/security/pkcs11/Cipher/TestGCMKeyAndIvCheck.java Passed. Execution successful sun/security/pkcs11/Cipher/TestKATForGCM.java Passed. Execution successful sun/security/pkcs11/Cipher/TestPKCS5PaddingError.java Passed. Execution successful sun/security/pkcs11/Cipher/TestPaddingOOB.java Passed. Execution successful sun/security/pkcs11/Cipher/TestRSACipher.java Passed. Execution successful sun/security/pkcs11/Cipher/TestRSACipherWrap.java Passed. Execution successful sun/security/pkcs11/Cipher/TestRawRSACipher.java Passed. Execution successful sun/security/pkcs11/Cipher/TestSymmCiphers.java Passed. Execution successful sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java Passed. Execution successful sun/security/pkcs11/Config/ReadConfInUTF16Env.java Passed. Execution successful sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java Passed. Execution successful sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java Passed. Execution successful sun/security/pkcs11/KeyAgreement/TestDH.java Passed. Execution successful sun/security/pkcs11/KeyAgreement/TestInterop.java Passed. Execution successful sun/security/pkcs11/KeyAgreement/TestShort.java Passed. Execution successful sun/security/pkcs11/KeyAgreement/UnsupportedDHKeys.java Passed. Execution successful sun/security/pkcs11/KeyGenerator/DESParity.java Passed. Execution successful sun/security/pkcs11/KeyGenerator/TestChaCha20.java Passed. Execution successful sun/security/pkcs11/KeyGenerator/TestKeyGenerator.java Passed. Execution successful sun/security/pkcs11/KeyPairGenerator/TestDH2048.java Passed. Execution successful sun/security/pkcs11/KeyStore/Basic.java Failed. Execution failed: `main' threw exception: java.lang.Exception: config failures: 0, test failures: 1 -sun/security/pkcs11/KeyStore/ClientAuth.java Error. Program `jdk11u-dev/build/linux-x86_64-normal-server-slowdebug/images/jdk/bin/java' timed out (timeout set to 960000ms, elapsed time including timeout handling was 962981ms). +sun/security/pkcs11/KeyStore/ClientAuth.java Error. Program `jdk11u-dev-backport-8328957/build/linux-x86_64-normal-server-slowdebug/images/jdk/bin/java' timed out (timeout set to 960000ms, elapsed time including timeout handling was 961779ms). sun/security/pkcs11/KeyStore/SecretKeysBasic.java Failed. Execution failed: `main' threw exception: java.lang.Exception: config failures: 0, test failures: 1 sun/security/pkcs11/KeyStore/Solaris.sh Passed. Execution successful sun/security/pkcs11/Mac/MacKAT.java Passed. Execution successful sun/security/pkcs11/Mac/MacSameTest.java Passed. Execution successful sun/security/pkcs11/Mac/ReinitMac.java Passed. Execution successful sun/security/pkcs11/MessageDigest/ByteBuffers.java Passed. Execution successful sun/security/pkcs11/MessageDigest/DigestKAT.java Passed. Execution successful sun/security/pkcs11/MessageDigest/ReinitDigest.java Passed. Execution successful sun/security/pkcs11/MessageDigest/TestCloning.java Passed. Execution successful sun/security/pkcs11/Provider/Absolute.java Passed. Execution successful sun/security/pkcs11/Provider/ConfigQuotedString.java Passed. Execution successful sun/security/pkcs11/Provider/ConfigShortPath.java Passed. Execution successful sun/security/pkcs11/Provider/Login.java Failed. Execution failed: `main' threw exception: java.lang.Exception: config failures: 0, test failures: 1 sun/security/pkcs11/Provider/LoginISE.java Passed. Execution successful sun/security/pkcs11/Provider/MultipleLogins.sh Failed. Execution failed: exit code 10 sun/security/pkcs11/SampleTest.java Passed. Execution successful sun/security/pkcs11/Secmod/AddPrivateKey.java Failed. Execution failed: `main' threw exception: java.io.IOException: load failed sun/security/pkcs11/Secmod/AddTrustedCert.java Failed. Execution failed: `main' threw exception: java.io.IOException: load failed sun/security/pkcs11/Secmod/Crypto.java Passed. Execution successful sun/security/pkcs11/Secmod/GetPrivateKey.java Failed. Execution failed: `main' threw exception: java.io.IOException: load failed sun/security/pkcs11/Secmod/JksSetPrivateKey.java Failed. Execution failed: `main' threw exception: java.io.IOException: load failed sun/security/pkcs11/Secmod/LoadKeystore.java Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Unexpected cause: javax.security.auth.login.LoginException sun/security/pkcs11/Secmod/TestNssDbSqlite.java Passed. Execution successful sun/security/pkcs11/Secmod/TrustAnchors.java Failed. Execution failed: `main' threw exception: java.security.ProviderException: NSS module not available: trustanchors sun/security/pkcs11/SecretKeyFactory/TestGeneral.java Passed. Execution successful sun/security/pkcs11/SecureRandom/Basic.java Passed. Execution successful sun/security/pkcs11/SecureRandom/TestDeserialization.java Passed. Execution successful sun/security/pkcs11/Serialize/SerializeProvider.java Passed. Execution successful sun/security/pkcs11/Signature/ByteBuffers.java Passed. Execution successful sun/security/pkcs11/Signature/InitAgainPSS.java Passed. Execution successful sun/security/pkcs11/Signature/KeyAndParamCheckForPSS.java Passed. Execution successful sun/security/pkcs11/Signature/ReinitSignature.java Passed. Execution successful sun/security/pkcs11/Signature/SigInteropPSS.java Passed. Execution successful sun/security/pkcs11/Signature/SignatureTestPSS.java Passed. Execution successful sun/security/pkcs11/Signature/TestDSA.java Passed. Execution successful sun/security/pkcs11/Signature/TestDSA2.java Passed. Execution successful sun/security/pkcs11/Signature/TestDSAKeyLength.java Failed. Execution failed: `main' threw exception: java.lang.Exception: Test Failed - expected IKE not thrown sun/security/pkcs11/Signature/TestRSAKeyLength.java Passed. Execution successful sun/security/pkcs11/ec/ReadCertificates.java Passed. Execution successful sun/security/pkcs11/ec/ReadPKCS12.java Passed. Execution successful sun/security/pkcs11/ec/TestCurves.java Passed. Execution successful sun/security/pkcs11/ec/TestECDH.java Passed. Execution successful sun/security/pkcs11/ec/TestECDH2.java Passed. Execution successful sun/security/pkcs11/ec/TestECDSA.java Passed. Execution successful sun/security/pkcs11/ec/TestECDSA2.java Passed. Execution successful sun/security/pkcs11/ec/TestECGenSpec.java Passed. Execution successful sun/security/pkcs11/ec/TestKeyFactory.java Failed. Execution failed: `main' threw exception: java.security.spec.InvalidKeySpecException: Could not parse key sun/security/pkcs11/fips/ClientJSSEServerJSSE.java Passed. Execution successful sun/security/pkcs11/fips/SunJSSEFIPSInit.java Passed. Execution successful sun/security/pkcs11/fips/SunJSSEKeyExchangeFIPS.java Passed. Execution successful sun/security/pkcs11/fips/TestTLS12.java Passed. Execution successful sun/security/pkcs11/fips/TrustManagerTest.java Passed. Execution successful sun/security/pkcs11/rsa/KeyWrap.java Passed. Execution successful sun/security/pkcs11/rsa/TestCACerts.java Passed. Execution successful sun/security/pkcs11/rsa/TestKeyFactory.java Passed. Execution successful sun/security/pkcs11/rsa/TestKeyPairGenerator.java Passed. Execution successful sun/security/pkcs11/rsa/TestP11KeyFactoryGetRSAKeySpec.java Passed. Execution successful sun/security/pkcs11/rsa/TestSignatures.java Passed. Execution successful sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java Passed. Execution successful sun/security/pkcs11/tls/TestKeyMaterial.java Passed. Execution successful sun/security/pkcs11/tls/TestKeyMaterialChaCha20.java Passed. Execution successful sun/security/pkcs11/tls/TestLeadingZeroesP11.java Passed. Execution successful sun/security/pkcs11/tls/TestMasterSecret.java Passed. Execution successful sun/security/pkcs11/tls/TestPRF.java Passed. Execution successful sun/security/pkcs11/tls/TestPremaster.java Passed. Execution successful ```
------------- Commit messages: - Backport 16576b87b7267aaa99c41f77993287e3479577aa Changes: https://git.openjdk.org/jdk11u-dev/pull/3004/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3004&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328957 Stats: 37 lines in 1 file changed: 11 ins; 9 del; 17 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3004.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3004/head:pull/3004 PR: https://git.openjdk.org/jdk11u-dev/pull/3004 From fferrari at openjdk.org Wed Feb 26 23:07:19 2025 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Wed, 26 Feb 2025 23:07:19 GMT Subject: [jdk11u-dev] RFR: 8328957: Update PKCS11Test.java to not use hardcoded path In-Reply-To: References: Message-ID: On Wed, 26 Feb 2025 21:07:06 GMT, Francisco Ferrari Bihurriet wrote: > Hi, I would like to propose an openjdk/jdk at 16576b87b7267aaa99c41f77993287e3479577aa backport. > > I do this backport for parity with 11.0.26-oracle. The backport is clean. > > Also, this allows running _SunPKCS11_ tests more easily, without the need to make symlink workarounds to locate the NSS library inside a `/nss/lib` path. > > ### Testing > > * `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk11u-dev/actions/runs/13551011718)) > * The failure in macos-x64 / test (hs/tier1 serviceability) / `serviceability/sa/ClhsdbFindPC.java#id1` is unrelated with PKCS11 test changes > * `test/jdk/sun/security/pkcs11` > * No regressions found against `jdk11u-dev/master` (currently: 659a4669208645420e151e78ab5fd3ac3808b310) > ``` > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > >> jtreg:test/jdk/sun/security/pkcs11 95 84 10 1 << > ============================== > TEST FAILURE > ``` > *
> jtreg summary.txt comparison > > ```diff > diff --git a/jdk11u-dev/pkcs11_regression/report/text/summary.txt b/jdk11u-dev-backport-8328957/pkcs11_regression/report/text/summary.txt > index ec3301f..552b9d0 100644 > --- a/jdk11u-dev/pkcs11_regression/report/text/summary.txt > +++ b/jdk11u-dev-backport-8328957/pkcs11_regression/report/text/summary.txt > @@ -1,98 +1,98 @@ > sun/security/pkcs11/Cipher/CancelMultipart.java Passed. Execution successful > sun/security/pkcs11/Cipher/EncryptionPadding.java Passed. Execution successful > sun/security/pkcs11/Cipher/JNICheck.java Passed. Execution successful > sun/security/pkcs11/Cipher/ReinitCipher.java Passed. Execution successful > sun/security/pkcs11/Cipher/Test4512704.java Passed. Execution successful > sun/security/pkcs11/Cipher/TestCICOWithGCM.java Passed. Execution successful > sun/security/pkcs11/Cipher/TestCICOWithGCMAndAAD.java Passed. Execution successful > sun/security/pkcs11/Cipher/TestChaChaPoly.java Passed. Execution successful > sun/security/pkcs11/Cipher/TestChaChaPolyKAT.java Passed. Execution successful > sun/security/pkcs11/Cipher/TestChaChaPolyNoReuse.java Passed. Execution succe... [[11u] approval request](https://bugs.openjdk.org/browse/JDK-8328957?focusedId=14756680&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14756680) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3004#issuecomment-2686405046 From abakhtin at openjdk.org Thu Feb 27 00:07:09 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Thu, 27 Feb 2025 00:07:09 GMT Subject: [jdk11u-dev] RFR: 8342075: HttpClient: improve HTTP/2 flow control checks Message-ID: Please review backport of JDK-8342075 The backport is not clean: - src/java.net.http/share/classes/module-info.java The changes are skipped because there are no java.net.http configuration properties definitions in the file. It was added by JDK-8296804 in JDK20 but not backported. - src/java.net.http/share/classes/jdk/internal/net/http/Stream.java Comments are not added into Stream::incoming() method because of no JDK-8298340 in JDK11 Fixed instance of pattern, added in JDK14 Fixed string formatting in Stream::windowSizeExceeded - src/java.net.http/share/classes/jdk/internal/net/http/WindowUpdateSender.java manual merge because of differences in the import section caused by JDK-8308310 - src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java Added Http2Connection.java::isOpen method. It was added by 8254786 in JDK19 - test/jdk/java/net/httpclient/GZIPInputStreamTest.java Changes skipped. This test was added as part of the JDK-8217264, but this functionality was not backported to JDK11 - test/jdk/java/net/httpclient/http2/server/Http2TestExchange.java and test/jdk/java/net/httpclient/http2/server/Http2TestExchangeImpl.java and test/jdk/java/net/httpclient/http2/server/Http2TestServerConnection.java Test classes are updated from JDK-8335181 with getConnectionKey() implementation - test/jdk/java/net/httpclient/http2/server/BodyOutputStream.java and test/jdk/java/net/httpclient/http2/server/Http2TestServerConnection.java These library classes are located in another directory (8295944 is not backported to JDK11). ? - test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/ConnectionFlowControlTest.java and test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/StreamFlowControlTest.java Test classes are updated to use ExecutorService::shutdown method to shut down httpclient. These methods are added by JDK-8267140 in JDK21 Fixed instance of pattern, added in JDK14 Fixed build and modules dependencies All java/net/httpclient jtreg tests are passed ------------- Commit messages: - Backport b0ac633b2d0076d64b463b2a6ce19abf6b12c50f Changes: https://git.openjdk.org/jdk11u-dev/pull/3005/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3005&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342075 Stats: 1057 lines in 13 files changed: 1027 ins; 1 del; 29 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3005.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3005/head:pull/3005 PR: https://git.openjdk.org/jdk11u-dev/pull/3005 From syan at openjdk.org Thu Feb 27 02:54:43 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 27 Feb 2025 02:54:43 GMT Subject: [jdk11u-dev] RFR: 8259268: Refactor InheritIO shell test as java test Message-ID: Hi all, This pull request contains a backport of commit [fb46d4e5](https://github.com/openjdk/jdk/commit/fb46d4e578db297c66176852bec77fc3ad5b89a8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Ivan ?ipka on 6 Feb 2021 and was reviewed by Igor Ignatyev and Roger Riggs. Thanks! ------------- Commit messages: - Backport fb46d4e578db297c66176852bec77fc3ad5b89a8 Changes: https://git.openjdk.org/jdk11u-dev/pull/3006/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3006&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8259268 Stats: 215 lines in 3 files changed: 84 ins; 131 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3006.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3006/head:pull/3006 PR: https://git.openjdk.org/jdk11u-dev/pull/3006 From qpzhang at openjdk.org Thu Feb 27 07:03:14 2025 From: qpzhang at openjdk.org (Patrick Zhang) Date: Thu, 27 Feb 2025 07:03:14 GMT Subject: [jdk17u-dev] RFR: 8350483: AArch64: turn on signum intrinsics by default on Ampere CPUs Message-ID: Backport the commit to set -XX:+UseSignumIntrinsic by default for Ampere CPUs. It is to fix performance problem observed on JMH cases `vm.compiler.Signum|java.lang.*MathBench.sig[nN]um*`. For example, `vm.compiler.Signum._1_signumFloatTest` thrpt score becomes 30x better on both jdk mainline and jdk17u-dev. The backporting can be very safe as it is limited to Ampere CPUs only and well verified on Ampere-1A with related jmh and jtreg tier1 tests. ------------- Commit messages: - Backport f529bf712d8946584999dfc98abea60c22c97167 Changes: https://git.openjdk.org/jdk17u-dev/pull/3300/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3300&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350483 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3300.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3300/head:pull/3300 PR: https://git.openjdk.org/jdk17u-dev/pull/3300 From duke at openjdk.org Thu Feb 27 08:20:06 2025 From: duke at openjdk.org (duke) Date: Thu, 27 Feb 2025 08:20:06 GMT Subject: [jdk24u] Withdrawn: 8343224: print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4 In-Reply-To: <1Fb34aMayv692p5sHu5LA3lT0ghUqAfnXQ7mjo5xDts=.9458815e-0c8a-4d9c-a449-5d1a1c0586e9@github.com> References: <1Fb34aMayv692p5sHu5LA3lT0ghUqAfnXQ7mjo5xDts=.9458815e-0c8a-4d9c-a449-5d1a1c0586e9@github.com> Message-ID: On Thu, 2 Jan 2025 07:17:00 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [b3e63631](https://github.com/openjdk/jdk/commit/b3e63631c735862ba00270636b4ef51c0e48a1af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by GennadiyKrivoshein on 28 Dec 2024 and was reviewed by Alexander Zvegintsev, Alexander Scherbatiy, Prasanta Sadhukhan and Alisen Chung. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk24u/pull/11 From goetz at openjdk.org Thu Feb 27 08:37:21 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 08:37:21 GMT Subject: [jdk17u-dev] RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized Message-ID: I would like to fix this mac issue ------------- Commit messages: - Backport 1c514b34c0260823e70f209996ac933a76ac34c2 Changes: https://git.openjdk.org/jdk17u-dev/pull/3302/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3302&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325435 Stats: 125 lines in 2 files changed: 124 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3302.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3302/head:pull/3302 PR: https://git.openjdk.org/jdk17u-dev/pull/3302 From goetz at openjdk.org Thu Feb 27 08:38:50 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 08:38:50 GMT Subject: [jdk21u-dev] RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized Message-ID: I would like to fix this mac issue. ------------- Commit messages: - Backport 1c514b34c0260823e70f209996ac933a76ac34c2 Changes: https://git.openjdk.org/jdk21u-dev/pull/1434/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1434&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325435 Stats: 125 lines in 2 files changed: 124 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1434.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1434/head:pull/1434 PR: https://git.openjdk.org/jdk21u-dev/pull/1434 From goetz at openjdk.org Thu Feb 27 08:38:52 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 08:38:52 GMT Subject: [jdk17u-dev] RFR: 8340560: Open Source several AWT/2D font and rendering tests Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport ade17ecb6cb5125d048401a878b557e5afefc08c Changes: https://git.openjdk.org/jdk17u-dev/pull/3303/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3303&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340560 Stats: 578 lines in 4 files changed: 578 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3303.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3303/head:pull/3303 PR: https://git.openjdk.org/jdk17u-dev/pull/3303 From goetz at openjdk.org Thu Feb 27 08:39:57 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 08:39:57 GMT Subject: [jdk21u-dev] RFR: 8340560: Open Source several AWT/2D font and rendering tests Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport ade17ecb6cb5125d048401a878b557e5afefc08c Changes: https://git.openjdk.org/jdk21u-dev/pull/1435/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1435&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340560 Stats: 578 lines in 4 files changed: 578 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1435.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1435/head:pull/1435 PR: https://git.openjdk.org/jdk21u-dev/pull/1435 From duke at openjdk.org Thu Feb 27 08:44:05 2025 From: duke at openjdk.org (Konanki Sreenath) Date: Thu, 27 Feb 2025 08:44:05 GMT Subject: [jdk24u] RFR: 8346094: Harden X509CertImpl.getExtensionValue for NPE cases [v2] In-Reply-To: References: Message-ID: <0NPsls2E-I04MSvrmQrWtfIJuEX0KqkdF4mX49aBKUE=.afb6b0d1-3a96-4877-bb13-ee84fdab02ca@github.com> On Tue, 25 Feb 2025 06:04:34 GMT, Konanki Sreenath wrote: >> Earlier code will trigger NPE if the certificate does not contain the extensions or if the requested extensions does not exist. The better approach for hardening getExtensionValue here is to to check for NULL explicitly before calling getExtensionValue() and avoding try-catch block which ensures the readability and maintainability. >> >> After scanning in multiple places where invokng getExtensions on the X509CertInfo reference, the check for NULL is added in the getKeyUsage() as well while calling before getExtensionValue() >> >> The associated tests are written and added in test class CertificateExtensions. Which will ensure to validate the >> getExtensionValue() and getKeyUsage() methods in X509CertImpl class. > > Konanki Sreenath has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 70a6c0b7ac952eebdffa1d64399cd0ee1efec1f6 This is not critical backport to 24.0.2 from the main hence closing the MR. Since the changes are in internal classes which are not used by user/customer directly. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/88#issuecomment-2687267401 From duke at openjdk.org Thu Feb 27 08:44:06 2025 From: duke at openjdk.org (Konanki Sreenath) Date: Thu, 27 Feb 2025 08:44:06 GMT Subject: [jdk24u] Withdrawn: 8346094: Harden X509CertImpl.getExtensionValue for NPE cases In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 08:16:38 GMT, Konanki Sreenath wrote: > Earlier code will trigger NPE if the certificate does not contain the extensions or if the requested extensions does not exist. The better approach for hardening getExtensionValue here is to to check for NULL explicitly before calling getExtensionValue() and avoding try-catch block which ensures the readability and maintainability. > > After scanning in multiple places where invokng getExtensions on the X509CertInfo reference, the check for NULL is added in the getKeyUsage() as well while calling before getExtensionValue() > > The associated tests are written and added in test class CertificateExtensions. Which will ensure to validate the > getExtensionValue() and getKeyUsage() methods in X509CertImpl class. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk24u/pull/88 From goetz at openjdk.org Thu Feb 27 08:49:23 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 08:49:23 GMT Subject: [jdk21u-dev] RFR: 8341535: sun/awt/font/TestDevTransform.java fails with RuntimeException: Different rendering Message-ID: I backport this as follow up to JDK-8340560. ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/1435 Commit messages: - Backport 593c27e69703875115e6db5843a3743ba9bd8c18 Changes: https://git.openjdk.org/jdk21u-dev/pull/1436/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1436&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341535 Stats: 25 lines in 1 file changed: 19 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1436.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1436/head:pull/1436 PR: https://git.openjdk.org/jdk21u-dev/pull/1436 From goetz at openjdk.org Thu Feb 27 08:51:09 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 08:51:09 GMT Subject: [jdk17u-dev] RFR: 8341535: sun/awt/font/TestDevTransform.java fails with RuntimeException: Different rendering Message-ID: I backport this as follow- up to JDK-8340560 ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/3303 Commit messages: - Backport 593c27e69703875115e6db5843a3743ba9bd8c18 Changes: https://git.openjdk.org/jdk17u-dev/pull/3304/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3304&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341535 Stats: 25 lines in 1 file changed: 19 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3304.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3304/head:pull/3304 PR: https://git.openjdk.org/jdk17u-dev/pull/3304 From goetz at openjdk.org Thu Feb 27 09:05:36 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 09:05:36 GMT Subject: [jdk17u-dev] RFR: 8347911: Limit the length of inflated text chunks Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 398a580518b4e7961bdddf733e0a89ff25bc437a Changes: https://git.openjdk.org/jdk17u-dev/pull/3305/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3305&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347911 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3305.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3305/head:pull/3305 PR: https://git.openjdk.org/jdk17u-dev/pull/3305 From goetz at openjdk.org Thu Feb 27 09:27:01 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 09:27:01 GMT Subject: [jdk17u-dev] RFR: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 11:39:50 GMT, Martin Doerr wrote: > Backport of [JDK-8343205](https://bugs.openjdk.org/browse/JDK-8343205) from jdk21u-dev. Can you please merge head and rerun tests? Thanks! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3106#issuecomment-2687369837 From mdoerr at openjdk.org Thu Feb 27 10:49:28 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 27 Feb 2025 10:49:28 GMT Subject: [jdk17u-dev] RFR: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory [v2] In-Reply-To: References: Message-ID: > Backport of [JDK-8343205](https://bugs.openjdk.org/browse/JDK-8343205) from jdk21u-dev. Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'origin' into 8343205_possibly_add_compiler_threads - Backport 3087c6c74d742b7b5eaf28e4c886b5dc1811ea6f ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3106/files - new: https://git.openjdk.org/jdk17u-dev/pull/3106/files/a320a4b7..ac1b0926 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3106&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3106&range=00-01 Stats: 40722 lines in 781 files changed: 21596 ins; 11010 del; 8116 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3106.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3106/head:pull/3106 PR: https://git.openjdk.org/jdk17u-dev/pull/3106 From goetz at openjdk.org Thu Feb 27 12:44:01 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 12:44:01 GMT Subject: [jdk21u-dev] RFR: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 05:34:50 GMT, Liming Liu wrote: > 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B Hi @limingliu-ampere Can you please elaborate on the risk you give this backport, and tell how you did test it? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1411#issuecomment-2687850313 From mdoerr at openjdk.org Thu Feb 27 12:53:11 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 27 Feb 2025 12:53:11 GMT Subject: [jdk21u-dev] Integrated: 8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats In-Reply-To: References: Message-ID: On Fri, 27 Dec 2024 18:35:12 GMT, Martin Doerr wrote: > Almost clean backport of [JDK-8345146](https://bugs.openjdk.org/browse/JDK-8345146). Two hunks had to be integrated manually due to unrelated differences in the context. The test updates had to be integrated manually because the RISCV part is not backported. TestFloat16VectorConvChain.java is not in 21u (introduced by https://github.com/openjdk/jdk/commit/55fd1ed228ea3c42aaf92579e5dcb818fe14351d). > > Original PR with performance numbers: https://github.com/openjdk/jdk/pull/22433 This pull request has now been integrated. Changeset: b942b5e3 Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/b942b5e3cf550c2acbbc6b8ba61017d72e640e3c Stats: 181 lines in 14 files changed: 178 ins; 2 del; 1 mod 8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats Reviewed-by: rrich Backport-of: b42d79eb6a6d497dc63718c2854609bebca4498c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1295 From syan at openjdk.org Thu Feb 27 13:11:29 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 27 Feb 2025 13:11:29 GMT Subject: [jdk24u] RFR: 8314840: 3 gc/epsilon tests ignore external vm options Message-ID: Hi all, This pull request contains a backport of commit [799ac528](https://github.com/openjdk/jdk/commit/799ac5288efbbb89e21319cd45657c8f817ad680) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Ramkumar Sunderbabu on 27 Feb 2025 and was reviewed by Thomas Schatzl. Thanks! ------------- Commit messages: - Backport 799ac5288efbbb89e21319cd45657c8f817ad680 Changes: https://git.openjdk.org/jdk24u/pull/95/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=95&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314840 Stats: 9 lines in 3 files changed: 0 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk24u/pull/95.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/95/head:pull/95 PR: https://git.openjdk.org/jdk24u/pull/95 From syan at openjdk.org Thu Feb 27 13:11:35 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 27 Feb 2025 13:11:35 GMT Subject: [jdk24u] RFR: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC Message-ID: Hi all, This pull request contains a backport of commit [e80b76b6](https://github.com/openjdk/jdk/commit/e80b76b663c6b82a353665fd68819cc9295ec429) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Robert Toyonaga on 27 Feb 2025 and was reviewed by Erik Gahlin and David Holmes. Thanks! ------------- Commit messages: - Backport e80b76b663c6b82a353665fd68819cc9295ec429 Changes: https://git.openjdk.org/jdk24u/pull/96/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=96&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8276995 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk24u/pull/96.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/96/head:pull/96 PR: https://git.openjdk.org/jdk24u/pull/96 From syan at openjdk.org Thu Feb 27 13:24:45 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 27 Feb 2025 13:24:45 GMT Subject: [jdk24u] RFR: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp Message-ID: Hi all, This pull request contains a backport of commit [09269497](https://github.com/openjdk/jdk/commit/09269497a27c732ce4644d0bb95e0380162398c9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jan Lahoda on 5 Feb 2025 and was reviewed by Chen Liang. Thanks! ------------- Commit messages: - Backport 09269497a27c732ce4644d0bb95e0380162398c9 Changes: https://git.openjdk.org/jdk24u/pull/97/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=97&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347629 Stats: 4 lines in 1 file changed: 2 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk24u/pull/97.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/97/head:pull/97 PR: https://git.openjdk.org/jdk24u/pull/97 From goetz at openjdk.org Thu Feb 27 13:24:51 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 13:24:51 GMT Subject: [jdk17u-dev] RFR: 8279884: Use better file for cygwin source permission check Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport 36f41cbe1126c6d9a00b21a1a68cf5f44e2f443f Changes: https://git.openjdk.org/jdk17u-dev/pull/3306/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3306&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8279884 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3306.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3306/head:pull/3306 PR: https://git.openjdk.org/jdk17u-dev/pull/3306 From goetz at openjdk.org Thu Feb 27 13:34:37 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 13:34:37 GMT Subject: [jdk17u-dev] RFR: 8279894: javax/swing/JInternalFrame/8020708/bug8020708.java timeouts on Windows 11 Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport c4a624d46332552e7baca8ee09bfdce0e53eef05 Changes: https://git.openjdk.org/jdk17u-dev/pull/3307/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3307&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8279894 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3307.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3307/head:pull/3307 PR: https://git.openjdk.org/jdk17u-dev/pull/3307 From mbaesken at openjdk.org Thu Feb 27 13:35:09 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 27 Feb 2025 13:35:09 GMT Subject: [jdk21u-dev] Integrated: 8346082: Output JVMTI agent information in hserr files In-Reply-To: References: Message-ID: On Tue, 14 Jan 2025 14:45:44 GMT, Matthias Baesken wrote: > os.cpp seems to have diffs in the strides; other files apply cleanly This pull request has now been integrated. Changeset: ae47d996 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/ae47d99675d38a60006dd901187595e6cad04e82 Stats: 40 lines in 4 files changed: 39 ins; 1 del; 0 mod 8346082: Output JVMTI agent information in hserr files Backport-of: c75b1d4bf65d927e18b10ea6de263a331b78e13a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1328 From goetz at openjdk.org Thu Feb 27 13:57:12 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 13:57:12 GMT Subject: [jdk17u-dev] RFR: 8024624: [TEST_BUG] [macosx] CTRL+RIGHT(LEFT) doesn't move selection on next cell in JTable on Aqua L&F Message-ID: I backport this for parity with 17.0.16-oracle. ------------- Commit messages: - Backport 535938722028b86e9d77d3728190f62f42117792 Changes: https://git.openjdk.org/jdk17u-dev/pull/3308/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3308&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8024624 Stats: 295 lines in 1 file changed: 295 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3308.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3308/head:pull/3308 PR: https://git.openjdk.org/jdk17u-dev/pull/3308 From goetz at openjdk.org Thu Feb 27 14:18:48 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 14:18:48 GMT Subject: [jdk17u-dev] RFR: 8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix Message-ID: I backport this for parity with 17.0.16-oracle Resolved Copyright, probably clean. ------------- Commit messages: - Backport dadd9cd1e8434cffaafc7406a864eaa55954cfb8 Changes: https://git.openjdk.org/jdk17u-dev/pull/3309/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3309&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316497 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3309.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3309/head:pull/3309 PR: https://git.openjdk.org/jdk17u-dev/pull/3309 From goetz at openjdk.org Thu Feb 27 14:18:56 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 14:18:56 GMT Subject: [jdk21u-dev] RFR: 8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix Message-ID: I backport this for parity with 21.0.8-oracle. ------------- Commit messages: - Backport dadd9cd1e8434cffaafc7406a864eaa55954cfb8 Changes: https://git.openjdk.org/jdk21u-dev/pull/1437/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1437&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316497 Stats: 155 lines in 2 files changed: 151 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1437.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1437/head:pull/1437 PR: https://git.openjdk.org/jdk21u-dev/pull/1437 From goetz at openjdk.org Thu Feb 27 15:00:41 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 27 Feb 2025 15:00:41 GMT Subject: [jdk17u-dev] RFR: 8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.16-oracle > > Resolved Copyright, probably clean. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport dadd9cd1e8434cffaafc7406a864eaa55954cfb8 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3309/files - new: https://git.openjdk.org/jdk17u-dev/pull/3309/files/6e96249c..37e5d396 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3309&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3309&range=00-01 Stats: 151 lines in 1 file changed: 151 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3309.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3309/head:pull/3309 PR: https://git.openjdk.org/jdk17u-dev/pull/3309 From evergizova at openjdk.org Thu Feb 27 15:40:55 2025 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Thu, 27 Feb 2025 15:40:55 GMT Subject: [jdk21u-dev] RFR: 8337506: Disable "best-fit" mapping on Windows command line Message-ID: I'd like to backport this for parity with 21.0.8-oracle. ------------- Commit messages: - Backport ff634a967027cfa56b666d31c45db9a4acc09ea4 Changes: https://git.openjdk.org/jdk21u-dev/pull/1438/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1438&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337506 Stats: 103 lines in 2 files changed: 101 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1438.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1438/head:pull/1438 PR: https://git.openjdk.org/jdk21u-dev/pull/1438 From shade at openjdk.org Thu Feb 27 16:08:56 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 27 Feb 2025 16:08:56 GMT Subject: [jdk21u-dev] RFR: 8279016: JFR Leak Profiler is broken with Shenandoah Message-ID: Plugs the bug opportunity with Shenandoah and JFR. Both changes apply cleanly, and both are need at the same time to keep the tests clean. Additional testing: - [x] MacOS AArch64 fastdebug, `jdk_jfr` - [x] MacOS AArch64 fastdebug, `jdk_jfr` with `-XX:+UseShenandoahGC` ------------- Commit messages: - Backport 0c281acfb4c87436096cb562d70f800dffa3671a - Backport 0be7118b2f761b416ebf8cbb11473d51e80be409 Changes: https://git.openjdk.org/jdk21u-dev/pull/1439/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1439&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8279016 Stats: 81 lines in 5 files changed: 81 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1439.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1439/head:pull/1439 PR: https://git.openjdk.org/jdk21u-dev/pull/1439 From phh at openjdk.org Thu Feb 27 16:29:07 2025 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 27 Feb 2025 16:29:07 GMT Subject: [jdk21u-dev] RFR: 8279016: JFR Leak Profiler is broken with Shenandoah In-Reply-To: References: Message-ID: <7-uCbnXEuzssrjQBZ2JDSd_1654hZ-xMI3HCR4kjfSE=.a6e73807-75e0-47cd-9212-d26be62db99f@github.com> On Thu, 27 Feb 2025 16:00:16 GMT, Aleksey Shipilev wrote: > Plugs the bug opportunity with Shenandoah and JFR. Both changes apply cleanly, and both are need at the same time to keep the tests clean. > > Additional testing: > - [x] MacOS AArch64 fastdebug, `jdk_jfr` > - [x] MacOS AArch64 fastdebug, `jdk_jfr` with `-XX:+UseShenandoahGC` Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1439#pullrequestreview-2648379729 From serb at openjdk.org Thu Feb 27 16:45:13 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 27 Feb 2025 16:45:13 GMT Subject: [jdk21u-dev] RFR: 8279016: JFR Leak Profiler is broken with Shenandoah In-Reply-To: References: Message-ID: On Thu, 27 Feb 2025 16:00:16 GMT, Aleksey Shipilev wrote: > Plugs the bug opportunity with Shenandoah and JFR. Both changes apply cleanly, and both are need at the same time to keep the tests clean. > > Additional testing: > - [x] MacOS AArch64 fastdebug, `jdk_jfr` > - [x] MacOS AArch64 fastdebug, `jdk_jfr` with `-XX:+UseShenandoahGC` Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1439#pullrequestreview-2648427472 From shade at openjdk.org Thu Feb 27 16:50:53 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 27 Feb 2025 16:50:53 GMT Subject: [jdk21u-dev] RFR: 8279016: JFR Leak Profiler is broken with Shenandoah In-Reply-To: References: Message-ID: On Thu, 27 Feb 2025 16:00:16 GMT, Aleksey Shipilev wrote: > Plugs the bug opportunity with Shenandoah and JFR. Both changes apply cleanly, and both are need at the same time to keep the tests clean. > > Additional testing: > - [x] MacOS AArch64 fastdebug, `jdk_jfr` > - [x] MacOS AArch64 fastdebug, `jdk_jfr` with `-XX:+UseShenandoahGC` Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1439#issuecomment-2688537949 From rmarchenko at openjdk.org Thu Feb 27 20:04:48 2025 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 27 Feb 2025 20:04:48 GMT Subject: [jdk21u-dev] RFR: 8309841: Jarsigner should print a warning if an entry is removed Message-ID: This is backport of "8309841: Jarsigner should print a warning if an entry is removed" Original patch does not apply cleanly to jdk21, some minor conflicts, and `_` was replaced with a variable in `test/jdk/sun/security/tools/jarsigner/RemovedFiles.java`. We need this fix in jdk21 and below, down to jdk8, as all versions have this issue with `jarsigner`. New tests successfully ran locally on Linux, x86_64. ------------- Commit messages: - Backport bdfb41f977258831e4b0ceaef5d016d095ab6e7f Changes: https://git.openjdk.org/jdk21u-dev/pull/1440/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1440&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309841 Stats: 241 lines in 5 files changed: 240 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1440.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1440/head:pull/1440 PR: https://git.openjdk.org/jdk21u-dev/pull/1440 From ysr at openjdk.org Thu Feb 27 23:49:59 2025 From: ysr at openjdk.org (Y. Srinivas Ramakrishna) Date: Thu, 27 Feb 2025 23:49:59 GMT Subject: [jdk21u-dev] RFR: 8279016: JFR Leak Profiler is broken with Shenandoah In-Reply-To: References: Message-ID: <5rAwVi8MTVtFVWP-zEwkXK6zRRtEdW81Hg8QY3AREN0=.b865b458-c098-4d29-9f54-d82d7ab5a14c@github.com> On Thu, 27 Feb 2025 16:00:16 GMT, Aleksey Shipilev wrote: > Plugs the bug opportunity with Shenandoah and JFR. Both changes apply cleanly, and both are need at the same time to keep the tests clean. > > Additional testing: > - [x] MacOS AArch64 fastdebug, `jdk_jfr` > - [x] MacOS AArch64 fastdebug, `jdk_jfr` with `-XX:+UseShenandoahGC` Marked as reviewed by ysr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1439#pullrequestreview-2649341802 From yan at openjdk.org Fri Feb 28 09:19:09 2025 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 28 Feb 2025 09:19:09 GMT Subject: [jdk21u-dev] RFR: 8309841: Jarsigner should print a warning if an entry is removed In-Reply-To: References: Message-ID: <1FSOPjYLiab6b2axB96es7DOGBa9zGeFKPpiqtqh5EI=.ca00e86e-3c1c-4e25-9bb0-250b158285a9@github.com> On Thu, 27 Feb 2025 19:58:56 GMT, Roman Marchenko wrote: > This is backport of "8309841: Jarsigner should print a warning if an entry is removed" > > Original patch does not apply cleanly to jdk21, some minor conflicts, and `_` was replaced with a variable in `test/jdk/sun/security/tools/jarsigner/RemovedFiles.java`. > > We need this fix in jdk21 and below, down to jdk8, as all versions have this issue with `jarsigner`. > > New tests successfully ran locally on Linux, x86_64. LGTM ------------- Marked as reviewed by yan (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1440#pullrequestreview-2650182858 From rmarchenko at openjdk.org Fri Feb 28 10:35:46 2025 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Fri, 28 Feb 2025 10:35:46 GMT Subject: [jdk17u-dev] RFR: 8309841: Jarsigner should print a warning if an entry is removed Message-ID: <7qTv2X6EuIXhhUSoCH3qIosI1uX1stKS1acQbDjeQK4=.74c470d1-d05e-4419-8e5f-449345ae9e7e@github.com> This is backport of "8309841: Jarsigner should print a warning if an entry is removed" Original patch does not apply cleanly to jdk17, some minor conflicts, and _ was replaced with a variable in test/jdk/sun/security/tools/jarsigner/RemovedFiles.java. We need this fix in jdk17 and below, down to jdk8, as all versions have this issue with jarsigner. New tests successfully ran locally on Linux, x86_64. ------------- Commit messages: - Backport bdfb41f977258831e4b0ceaef5d016d095ab6e7f Changes: https://git.openjdk.org/jdk17u-dev/pull/3310/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3310&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309841 Stats: 241 lines in 5 files changed: 240 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3310.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3310/head:pull/3310 PR: https://git.openjdk.org/jdk17u-dev/pull/3310 From andrew at openjdk.org Fri Feb 28 12:50:02 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 28 Feb 2025 12:50:02 GMT Subject: [jdk21u-dev] RFR: 8331735: UpcallLinker::on_exit races with GC when copying frame anchor In-Reply-To: <-jK2vUjMIUSOPPztQ-ejoHuZvVZwqE-xO4UOvhhLtDg=.dfed7484-1cf6-46ee-b3be-e52a2bc2a8cc@github.com> References: <-jK2vUjMIUSOPPztQ-ejoHuZvVZwqE-xO4UOvhhLtDg=.dfed7484-1cf6-46ee-b3be-e52a2bc2a8cc@github.com> Message-ID: On Tue, 25 Feb 2025 14:02:52 GMT, Goetz Lindenmaier wrote: > @gnu-andrew, you might want to push this, today 18:00 CET the last automatic merge from jdk21u-dev to jdk21u will happen. Ah, sorry, I got my dates mixed up and thought that was next week. I've been away the first half of this week, so only been able to get back to this today. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1424#issuecomment-2690557655 From andrew at openjdk.org Fri Feb 28 12:50:03 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 28 Feb 2025 12:50:03 GMT Subject: [jdk21u-dev] Integrated: 8331735: UpcallLinker::on_exit races with GC when copying frame anchor In-Reply-To: References: Message-ID: On Thu, 20 Feb 2025 16:23:03 GMT, Andrew John Hughes wrote: > Clean backport of a fix for a race condition in code adapted from `JavaCallWrapper` for the FFM API. This is more visible in 22 and later, where FFM is fully supported and the [OpenType implementation using HarfBuzz](https://bugs.openjdk.org/browse/JDK-8318364) has been ported to use it. However, the copy in the native state seems to have been introduced as far back as [JDK-8269240](https://bugs.openjdk.org/browse/JDK-8269240) in 17 when the `JavaCallWrapper` code was ported to what was then `universalUpcallHandler.cpp`. This pull request has now been integrated. Changeset: 91457e69 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk21u-dev/commit/91457e694353386737e325e6fa0253bcefb8d579 Stats: 15 lines in 1 file changed: 5 ins; 9 del; 1 mod 8331735: UpcallLinker::on_exit races with GC when copying frame anchor 8343144: UpcallLinker::on_entry racingly clears pending exception with GC safepoints 8286875: ProgrammableUpcallHandler::on_entry/on_exit access thread fields from native Backport-of: 461ffafeba459c077f1c2d9c5037305b71a8bc2a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1424 From yan at openjdk.org Fri Feb 28 13:03:59 2025 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 28 Feb 2025 13:03:59 GMT Subject: [jdk17u-dev] RFR: 8309841: Jarsigner should print a warning if an entry is removed In-Reply-To: <7qTv2X6EuIXhhUSoCH3qIosI1uX1stKS1acQbDjeQK4=.74c470d1-d05e-4419-8e5f-449345ae9e7e@github.com> References: <7qTv2X6EuIXhhUSoCH3qIosI1uX1stKS1acQbDjeQK4=.74c470d1-d05e-4419-8e5f-449345ae9e7e@github.com> Message-ID: On Fri, 28 Feb 2025 10:30:29 GMT, Roman Marchenko wrote: > This is backport of "8309841: Jarsigner should print a warning if an entry is removed" > > Original patch does not apply cleanly to jdk17, some minor conflicts, and _ was replaced with a variable in test/jdk/sun/security/tools/jarsigner/RemovedFiles.java. > > We need this fix in jdk17 and below, down to jdk8, as all versions have this issue with jarsigner. > > New tests successfully ran locally on Linux, x86_64. Marked as reviewed by yan (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3310#pullrequestreview-2650690814 From mdoerr at openjdk.org Fri Feb 28 14:23:06 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 28 Feb 2025 14:23:06 GMT Subject: [jdk17u-dev] RFR: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory [v2] In-Reply-To: References: Message-ID: On Thu, 27 Feb 2025 10:49:28 GMT, Martin Doerr wrote: >> Backport of [JDK-8343205](https://bugs.openjdk.org/browse/JDK-8343205) from jdk21u-dev. > > Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'origin' into 8343205_possibly_add_compiler_threads > - Backport 3087c6c74d742b7b5eaf28e4c886b5dc1811ea6f Tier1-4 have passed on Windows, Linux, MacOS. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3106#issuecomment-2690764475 From rrich at openjdk.org Fri Feb 28 15:33:13 2025 From: rrich at openjdk.org (Richard Reingruber) Date: Fri, 28 Feb 2025 15:33:13 GMT Subject: [jdk17u-dev] RFR: 8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields Message-ID: Hi all, This pull request contains a backport of commit [13dce296](https://github.com/openjdk/jdk/commit/13dce296fc3924b269757ce1279c57afe18faeeb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Richard Reingruber on 24 Jun 2024 and was reviewed by Matthias Baesken and Martin Doerr. The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, Renaissance Suite, and SAP specific tests. Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. Risk is low. The change affects only PPC64 and the field that is changed is only read in the JVMTI implementation. Also the change includes a regression test. Thanks, Richard. ------------- Commit messages: - 8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields Changes: https://git.openjdk.org/jdk17u-dev/pull/3301/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3301&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334560 Stats: 92 lines in 2 files changed: 92 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3301.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3301/head:pull/3301 PR: https://git.openjdk.org/jdk17u-dev/pull/3301 From rmarchenko at openjdk.org Fri Feb 28 16:26:22 2025 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Fri, 28 Feb 2025 16:26:22 GMT Subject: [jdk11u-dev] RFR: 8309841: Jarsigner should print a warning if an entry is removed Message-ID: This is backport of "8309841: Jarsigner should print a warning if an entry is removed" Original patch does not apply cleanly to jdk11, some minor conflicts, and also in `test/jdk/sun/security/tools/jarsigner/RemovedFiles.java` `ed25519` algorithm was replaced with `RSA`, and `_` was replaced with a variable. We need this fix in jdk11 and below, down to jdk8, as all versions have this issue with jarsigner. New tests successfully ran locally on Linux, x86_64. ------------- Commit messages: - Backport bdfb41f977258831e4b0ceaef5d016d095ab6e7f Changes: https://git.openjdk.org/jdk11u-dev/pull/3007/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3007&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309841 Stats: 241 lines in 5 files changed: 240 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3007.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3007/head:pull/3007 PR: https://git.openjdk.org/jdk11u-dev/pull/3007 From abakhtin at openjdk.org Fri Feb 28 20:25:00 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 28 Feb 2025 20:25:00 GMT Subject: [jdk11u-dev] RFR: 8309841: Jarsigner should print a warning if an entry is removed In-Reply-To: References: Message-ID: On Fri, 28 Feb 2025 16:21:45 GMT, Roman Marchenko wrote: > This is backport of "8309841: Jarsigner should print a warning if an entry is removed" > > Original patch does not apply cleanly to jdk11, some minor conflicts, and also in `test/jdk/sun/security/tools/jarsigner/RemovedFiles.java` `ed25519` algorithm was replaced with `RSA`, and `_` was replaced with a variable. > > We need this fix in jdk11 and below, down to jdk8, as all versions have this issue with jarsigner. > > New tests successfully ran locally on Linux, x86_64. src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line 1296: > 1294: } > 1295: } > 1296: if (hasNonexistentEntries) { I think we should check hasNonexistentEntries at line 1259 also. This is a difference between JDK17 and JDK11 versions ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/3007#discussion_r1975969928